From d4a82b169725e3c17d61993e209866e398dcd2d0 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Fri, 11 Mar 2022 12:02:30 -0500 Subject: [PATCH 001/104] us VS "unit tests" as they don't need extra stuff --- Test/Test.vcxproj | 12 +++ UnitTest/Test.h | 43 +++++++++ UnitTest/TestCase.h | 2 + UnitTest/UnitTest.vcxproj | 148 ++++++++++++++++++++++++++++++ UnitTest/UnitTest.vcxproj.filters | 15 +++ UnitTest/j2k_Test.h | 6 ++ UnitTest/nitf_Test.h | 17 ++++ UnitTest/nrt_Test.h | 6 ++ UnitTest/nrt_test_utils.cpp | 12 +++ UnitTest/pch.cpp | 5 + UnitTest/pch.h | 49 ++++++++++ nitro.sln | 32 ++----- 12 files changed, 325 insertions(+), 22 deletions(-) create mode 100644 UnitTest/Test.h create mode 100644 UnitTest/TestCase.h create mode 100644 UnitTest/UnitTest.vcxproj create mode 100644 UnitTest/UnitTest.vcxproj.filters create mode 100644 UnitTest/j2k_Test.h create mode 100644 UnitTest/nitf_Test.h create mode 100644 UnitTest/nrt_Test.h create mode 100644 UnitTest/nrt_test_utils.cpp create mode 100644 UnitTest/pch.cpp create mode 100644 UnitTest/pch.h diff --git a/Test/Test.vcxproj b/Test/Test.vcxproj index 6b1ca67bf..56a27b4a3 100644 --- a/Test/Test.vcxproj +++ b/Test/Test.vcxproj @@ -74,12 +74,24 @@ {023de06d-3967-4406-b1b8-032118bb2552} + + {53f9f908-c678-4dee-9309-e71c1e03a45f} + + + {d749aa73-4c9a-473d-96bb-070a6d9caa54} + {d1d7fcd3-6130-4504-9da0-9d80506be55e} + + {2baaaca9-a5a4-412c-ae52-b16c2d107f55} + {cf5b4f02-364d-4117-9fb9-6c9c7938e412} + + {78849481-d356-4cc7-b182-31c21f857ed1} + diff --git a/UnitTest/Test.h b/UnitTest/Test.h new file mode 100644 index 000000000..c1c87a570 --- /dev/null +++ b/UnitTest/Test.h @@ -0,0 +1,43 @@ +#pragma once + +#include "CppUnitTest.h" + +#define TEST_ASSERT(X) Assert::IsTrue(X) + +template +inline void test_assert_eq_(const T& t, const U& u) +{ + Assert::AreEqual(t, u); +} +#define TEST_ASSERT_EQ(X1, X2) { test_assert_eq_(X1, X2); test_assert_eq_(X2, X1); } +#define TEST_ASSERT_EQ_INT(X1, X2) TEST_ASSERT_EQ(X1, X2) +template +inline void test_assert_str_eq_(const T& t, const U& u) +{ + Assert::AreEqual(t, u); +} +#define TEST_ASSERT_EQ_STR(X1, X2) { test_assert_str_eq_(X1, X2); test_assert_str_eq_(X2, X1); } +#define TEST_ASSERT_EQ_FLOAT(X1, X2) Assert::AreEqual(static_cast(X1), static_cast(X2)) + +#define TEST_ASSERT_NULL(X) TEST_ASSERT_EQ((X), nullptr) +#define TEST_ASSERT_TRUE(X) TEST_ASSERT_EQ((X), true) +#define TEST_ASSERT_FALSE(X) TEST_ASSERT_EQ((X), false) + +template +inline void test_assert_not_eq_(const T& t, const U& u) +{ + EXPECT_NE(t, u); +} +#define TEST_ASSERT_NOT_EQ(X1, X2) { test_assert_not_eq_(X1, X2); test_assert_not_eq_(X2, X1);} + +#define TEST_ASSERT_GREATER(X1, X2) EXPECT_GT(X1, X2) + +#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) Assert:AreEqual(X1, X2, EPS) +#define TEST_ASSERT_ALMOST_EQ(X1, X2) TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, 0.0001) + +#define TEST_ASSERT_EQ_MSG(msg, X1, X2) SCOPED_TRACE(msg); TEST_ASSERT_EQ(X1, X2) + +#define TEST_EXCEPTION(X) EXPECT_ANY_THROW((X)) +#define TEST_THROWS(X) EXPECT_ANY_THROW((X)) + +#define TEST_MAIN(X) diff --git a/UnitTest/TestCase.h b/UnitTest/TestCase.h new file mode 100644 index 000000000..c9583fa66 --- /dev/null +++ b/UnitTest/TestCase.h @@ -0,0 +1,2 @@ +#pragma once +#include "Test.h" diff --git a/UnitTest/UnitTest.vcxproj b/UnitTest/UnitTest.vcxproj new file mode 100644 index 000000000..8d7a7bd1a --- /dev/null +++ b/UnitTest/UnitTest.vcxproj @@ -0,0 +1,148 @@ + + + + + Debug + x64 + + + Release + x64 + + + + 17.0 + {F89191ED-2AC9-472E-A869-F68F8AEFA708} + Win32Proj + UnitTest + 10.0 + NativeUnitTestProject + + + + DynamicLibrary + true + v143 + Unicode + false + + + DynamicLibrary + false + v143 + true + Unicode + false + + + + + + + + + + + + + + + true + + + false + + + + Use + Level3 + true + $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + _DEBUG;%(PreprocessorDefinitions) + true + pch.h + + + Windows + $(VCInstallDir)UnitTest\lib;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) + + + + + Use + Level3 + true + true + true + $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + NDEBUG;%(PreprocessorDefinitions) + true + pch.h + + + Windows + true + true + $(VCInstallDir)UnitTest\lib;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) + + + + + Create + Create + + + + + + + + + + + + + + {8f357a19-799e-4971-850e-3f28485c130b} + + + {f06550ad-cfc7-40b8-8727-6c82c69a8982} + + + {53f9f908-c678-4dee-9309-e71c1d03a45f} + + + {730b1e6e-2469-4f9e-b093-d0c6262453c9} + + + {51d7b426-899e-428d-9f69-5ddac9e403fb} + + + {12aa0752-4ee3-4e0a-85af-0e5deadbf343} + + + {023de06d-3967-4406-b1b8-032118bb2552} + + + {53f9f908-c678-4dee-9309-e71c1e03a45f} + + + {d749aa73-4c9a-473d-96bb-070a6d9caa54} + + + {d1d7fcd3-6130-4504-9da0-9d80506be55e} + + + {2baaaca9-a5a4-412c-ae52-b16c2d107f55} + + + {cf5b4f02-364d-4117-9fb9-6c9c7938e412} + + + {78849481-d356-4cc7-b182-31c21f857ed1} + + + + + + \ No newline at end of file diff --git a/UnitTest/UnitTest.vcxproj.filters b/UnitTest/UnitTest.vcxproj.filters new file mode 100644 index 000000000..c07187b46 --- /dev/null +++ b/UnitTest/UnitTest.vcxproj.filters @@ -0,0 +1,15 @@ + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/UnitTest/j2k_Test.h b/UnitTest/j2k_Test.h new file mode 100644 index 000000000..23af9b6d4 --- /dev/null +++ b/UnitTest/j2k_Test.h @@ -0,0 +1,6 @@ +#pragma once + +#if defined(GTEST_API_) +#define __TEST_H__ // #include "../j2k/unittests/Test.h" +#endif +#include "Test.h" diff --git a/UnitTest/nitf_Test.h b/UnitTest/nitf_Test.h new file mode 100644 index 000000000..86f39e272 --- /dev/null +++ b/UnitTest/nitf_Test.h @@ -0,0 +1,17 @@ +#pragma once + +#if defined(GTEST_API_) +#define __TEST_H__ // #include "../nitf/unittests/Test.h" +#define __TEST_CASE_H__ // #include "../nitf/unittests/TestCase.h" +#endif +#include "Test.h" + +#include + +namespace nitf +{ + namespace Test + { + std::string buildPluginsDir(); + } +} \ No newline at end of file diff --git a/UnitTest/nrt_Test.h b/UnitTest/nrt_Test.h new file mode 100644 index 000000000..7f0d7a36f --- /dev/null +++ b/UnitTest/nrt_Test.h @@ -0,0 +1,6 @@ +#pragma once + +#if defined(MS_CPP_UNITTESTFRAMEWORK) +#define __TEST_H__ // #include "../nrt/unittests/Test.h" +#endif +#include "Test.h" diff --git a/UnitTest/nrt_test_utils.cpp b/UnitTest/nrt_test_utils.cpp new file mode 100644 index 000000000..e0b2e49c6 --- /dev/null +++ b/UnitTest/nrt_test_utils.cpp @@ -0,0 +1,12 @@ +#include "pch.h" + +#include "nrt_Test.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nrt_test_utils) { public: + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nrt/unittests/test_utils.c" + +}; \ No newline at end of file diff --git a/UnitTest/pch.cpp b/UnitTest/pch.cpp new file mode 100644 index 000000000..64b7eef6d --- /dev/null +++ b/UnitTest/pch.cpp @@ -0,0 +1,5 @@ +// pch.cpp: source file corresponding to the pre-compiled header + +#include "pch.h" + +// When you are using pre-compiled headers, this source file is necessary for compilation to succeed. diff --git a/UnitTest/pch.h b/UnitTest/pch.h new file mode 100644 index 000000000..a2c6e0e88 --- /dev/null +++ b/UnitTest/pch.h @@ -0,0 +1,49 @@ +// pch.h: This is a precompiled header file. +// Files listed below are compiled only once, improving build performance for future builds. +// This also affects IntelliSense performance, including code completion and many code browsing features. +// However, files listed here are ALL re-compiled if any one of them is updated between builds. +// Do not add files here that you will be updating frequently as this negates the performance advantage. + +#ifndef PCH_H +#define PCH_H +#pragma once + +#pragma warning(disable: 4820) // '...': '...' bytes padding added after data member '...' +#pragma warning(disable: 4710) // '...': function not inlined +#pragma warning(disable: 5045) // Compiler will insert Spectre mitigation for memory load if / Qspectre switch specified +#pragma warning(disable: 4668) // '...' is not defined as a preprocessor macro, replacing with '...' for '...' +// TODO: get rid of these someday? +#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to 'extern "C"' function under -EHc. Undefined behavior may occur if this function throws an exception. +#pragma warning(disable: 4514) // '...': unreferenced inline function has been removed + +#pragma warning(push) +#pragma warning(disable: 4464) // relative include path contains '..' +#include "../modules/c++/cpp.h" +#pragma warning(pop) +#pragma comment(lib, "ws2_32") + +// We're building in Visual Studio ... used to control where we get a little bit of config info +#define NITRO_PCH 1 + +#pragma warning(disable: 5032) // detected #pragma warning(push) with no corresponding #pragma warning(pop) +#pragma warning(push) +#pragma warning(disable: 4464) // relative include path contains '..' +#include +#pragma warning(disable: 5031) // #pragma warning(pop): likely mismatch, popping warning state pushed in different file +#pragma comment(lib, "io-c++") +#pragma comment(lib, "except-c++") +#pragma comment(lib, "sys-c++") +#pragma comment(lib, "str-c++") +#pragma warning(pop) + +#pragma warning(push) +#include "CppUnitTest.h" +#pragma warning(pop) + +#include +#include + +#include "nitf_Test.h" +#include "Test.h" + +#endif //PCH_H diff --git a/nitro.sln b/nitro.sln index edd7ba711..2429e8cf9 100644 --- a/nitro.sln +++ b/nitro.sln @@ -42,15 +42,11 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "HISTOA", "modules\c\nitf\HI EndProject Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "ENGRDA", "modules\c\nitf\ENGRDA.vcxproj", "{53F9F908-C678-4DEE-9309-E71C1E03A45F}" EndProject -Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "Test", "Test\Test.vcxproj", "{238C9787-B27D-4107-B8FD-1BDB49EA8023}" -EndProject Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "Test++", "Test++\Test++.vcxproj", "{E610F11D-1240-4260-87F8-504B49DB6915}" EndProject -Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "test_j2k_read_tile", "modules\c\j2k\tests\test_j2k_read_tile.vcxproj", "{E34A31A2-609F-44E8-AF49-A9272CAC45D6}" -EndProject -Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "test_j2k_nitf", "modules\c\j2k\tests\test_j2k_nitf.vcxproj", "{D901F2CE-09F9-42D2-A38A-6376E2A9F25B}" +Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "UnitTest", "UnitTest\UnitTest.vcxproj", "{F89191ED-2AC9-472E-A869-F68F8AEFA708}" EndProject -Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "test_j2k_nitf_read_region", "modules\c++\nitf\tests\test_j2k_nitf_read_region.vcxproj", "{E34A31A2-609F-44E8-AF49-A9272CAC45D7}" +Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "Test", "Test\Test.vcxproj", "{238C9787-B27D-4107-B8FD-1BDB49EA8023}" EndProject Global GlobalSection(SolutionConfigurationPlatforms) = preSolution @@ -114,26 +110,18 @@ Global {53F9F908-C678-4DEE-9309-E71C1E03A45F}.Debug|x64.Build.0 = Debug|x64 {53F9F908-C678-4DEE-9309-E71C1E03A45F}.Release|x64.ActiveCfg = Release|x64 {53F9F908-C678-4DEE-9309-E71C1E03A45F}.Release|x64.Build.0 = Release|x64 - {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Debug|x64.ActiveCfg = Debug|x64 - {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Debug|x64.Build.0 = Debug|x64 - {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Release|x64.ActiveCfg = Release|x64 - {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Release|x64.Build.0 = Release|x64 {E610F11D-1240-4260-87F8-504B49DB6915}.Debug|x64.ActiveCfg = Debug|x64 {E610F11D-1240-4260-87F8-504B49DB6915}.Debug|x64.Build.0 = Debug|x64 {E610F11D-1240-4260-87F8-504B49DB6915}.Release|x64.ActiveCfg = Release|x64 {E610F11D-1240-4260-87F8-504B49DB6915}.Release|x64.Build.0 = Release|x64 - {E34A31A2-609F-44E8-AF49-A9272CAC45D6}.Debug|x64.ActiveCfg = Debug|x64 - {E34A31A2-609F-44E8-AF49-A9272CAC45D6}.Debug|x64.Build.0 = Debug|x64 - {E34A31A2-609F-44E8-AF49-A9272CAC45D6}.Release|x64.ActiveCfg = Release|x64 - {E34A31A2-609F-44E8-AF49-A9272CAC45D6}.Release|x64.Build.0 = Release|x64 - {D901F2CE-09F9-42D2-A38A-6376E2A9F25B}.Debug|x64.ActiveCfg = Debug|x64 - {D901F2CE-09F9-42D2-A38A-6376E2A9F25B}.Debug|x64.Build.0 = Debug|x64 - {D901F2CE-09F9-42D2-A38A-6376E2A9F25B}.Release|x64.ActiveCfg = Release|x64 - {D901F2CE-09F9-42D2-A38A-6376E2A9F25B}.Release|x64.Build.0 = Release|x64 - {E34A31A2-609F-44E8-AF49-A9272CAC45D7}.Debug|x64.ActiveCfg = Debug|x64 - {E34A31A2-609F-44E8-AF49-A9272CAC45D7}.Debug|x64.Build.0 = Debug|x64 - {E34A31A2-609F-44E8-AF49-A9272CAC45D7}.Release|x64.ActiveCfg = Release|x64 - {E34A31A2-609F-44E8-AF49-A9272CAC45D7}.Release|x64.Build.0 = Release|x64 + {F89191ED-2AC9-472E-A869-F68F8AEFA708}.Debug|x64.ActiveCfg = Debug|x64 + {F89191ED-2AC9-472E-A869-F68F8AEFA708}.Debug|x64.Build.0 = Debug|x64 + {F89191ED-2AC9-472E-A869-F68F8AEFA708}.Release|x64.ActiveCfg = Release|x64 + {F89191ED-2AC9-472E-A869-F68F8AEFA708}.Release|x64.Build.0 = Release|x64 + {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Debug|x64.ActiveCfg = Debug|x64 + {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Debug|x64.Build.0 = Debug|x64 + {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Release|x64.ActiveCfg = Release|x64 + {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Release|x64.Build.0 = Release|x64 EndGlobalSection GlobalSection(SolutionProperties) = preSolution HideSolutionNode = FALSE From 9135e5036bfa01e508f1dd20a76508bcc6703232 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Fri, 11 Mar 2022 12:09:37 -0500 Subject: [PATCH 002/104] add test_tree --- UnitTest/Test.h | 8 ++++---- UnitTest/UnitTest.vcxproj | 1 + UnitTest/UnitTest.vcxproj.filters | 1 + UnitTest/nrt_test_tree.cpp | 14 ++++++++++++++ modules/c/nrt/unittests/test_tree.c | 2 +- 5 files changed, 21 insertions(+), 5 deletions(-) create mode 100644 UnitTest/nrt_test_tree.cpp diff --git a/UnitTest/Test.h b/UnitTest/Test.h index c1c87a570..afbfd4d16 100644 --- a/UnitTest/Test.h +++ b/UnitTest/Test.h @@ -19,14 +19,14 @@ inline void test_assert_str_eq_(const T& t, const U& u) #define TEST_ASSERT_EQ_STR(X1, X2) { test_assert_str_eq_(X1, X2); test_assert_str_eq_(X2, X1); } #define TEST_ASSERT_EQ_FLOAT(X1, X2) Assert::AreEqual(static_cast(X1), static_cast(X2)) -#define TEST_ASSERT_NULL(X) TEST_ASSERT_EQ((X), nullptr) -#define TEST_ASSERT_TRUE(X) TEST_ASSERT_EQ((X), true) -#define TEST_ASSERT_FALSE(X) TEST_ASSERT_EQ((X), false) +#define TEST_ASSERT_NULL(X) Assert::IsNull((X)) +#define TEST_ASSERT_TRUE(X) Assert::IsTrue((X)) +#define TEST_ASSERT_FALSE(X) Assert::IsFalse((X)) template inline void test_assert_not_eq_(const T& t, const U& u) { - EXPECT_NE(t, u); + Assert::AreNotEqual(t, u); } #define TEST_ASSERT_NOT_EQ(X1, X2) { test_assert_not_eq_(X1, X2); test_assert_not_eq_(X2, X1);} diff --git a/UnitTest/UnitTest.vcxproj b/UnitTest/UnitTest.vcxproj index 8d7a7bd1a..94d10dc5b 100644 --- a/UnitTest/UnitTest.vcxproj +++ b/UnitTest/UnitTest.vcxproj @@ -87,6 +87,7 @@ + Create Create diff --git a/UnitTest/UnitTest.vcxproj.filters b/UnitTest/UnitTest.vcxproj.filters index c07187b46..999a3e264 100644 --- a/UnitTest/UnitTest.vcxproj.filters +++ b/UnitTest/UnitTest.vcxproj.filters @@ -3,6 +3,7 @@ + diff --git a/UnitTest/nrt_test_tree.cpp b/UnitTest/nrt_test_tree.cpp new file mode 100644 index 000000000..0d1c83100 --- /dev/null +++ b/UnitTest/nrt_test_tree.cpp @@ -0,0 +1,14 @@ +#include "pch.h" + +#include "nrt_Test.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +const char* testName = "testTree"; +TEST_CLASS(nrt_test_tree) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nrt/unittests/test_tree.c" + +}; \ No newline at end of file diff --git a/modules/c/nrt/unittests/test_tree.c b/modules/c/nrt/unittests/test_tree.c index 13dd05428..af7d3e502 100644 --- a/modules/c/nrt/unittests/test_tree.c +++ b/modules/c/nrt/unittests/test_tree.c @@ -23,7 +23,7 @@ #include #include "Test.h" -char *C(const char *p) +static char *C(const char *p) { const size_t p_sz = strlen(p) + 1; void* x_ = malloc(p_sz); From 379021d71735f9d7aec4748b01abd4e6d155c663 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Fri, 11 Mar 2022 12:18:08 -0500 Subject: [PATCH 003/104] add remaining NRT tests --- UnitTest/UnitTest.vcxproj | 5 +++++ UnitTest/UnitTest.vcxproj.filters | 5 +++++ UnitTest/nrt_test_buffer_adapter.cpp | 13 +++++++++++++ UnitTest/nrt_test_core_values.cpp | 13 +++++++++++++ UnitTest/nrt_test_list.cpp | 13 +++++++++++++ UnitTest/nrt_test_nrt_byte_swap.cpp | 13 +++++++++++++ UnitTest/nrt_test_nrt_datetime.cpp | 13 +++++++++++++ UnitTest/nrt_test_utils.cpp | 5 +++-- modules/c/nrt/unittests/test_list.c | 12 ++++++------ 9 files changed, 84 insertions(+), 8 deletions(-) create mode 100644 UnitTest/nrt_test_buffer_adapter.cpp create mode 100644 UnitTest/nrt_test_core_values.cpp create mode 100644 UnitTest/nrt_test_list.cpp create mode 100644 UnitTest/nrt_test_nrt_byte_swap.cpp create mode 100644 UnitTest/nrt_test_nrt_datetime.cpp diff --git a/UnitTest/UnitTest.vcxproj b/UnitTest/UnitTest.vcxproj index 94d10dc5b..78a91ea72 100644 --- a/UnitTest/UnitTest.vcxproj +++ b/UnitTest/UnitTest.vcxproj @@ -87,6 +87,11 @@ + + + + + Create diff --git a/UnitTest/UnitTest.vcxproj.filters b/UnitTest/UnitTest.vcxproj.filters index 999a3e264..67e401d45 100644 --- a/UnitTest/UnitTest.vcxproj.filters +++ b/UnitTest/UnitTest.vcxproj.filters @@ -4,6 +4,11 @@ + + + + + diff --git a/UnitTest/nrt_test_buffer_adapter.cpp b/UnitTest/nrt_test_buffer_adapter.cpp new file mode 100644 index 000000000..79b5af6f3 --- /dev/null +++ b/UnitTest/nrt_test_buffer_adapter.cpp @@ -0,0 +1,13 @@ +#include "pch.h" + +#include "nrt_Test.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nrt_test_buffer_adapter) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nrt/unittests/test_buffer_adapter.c" + +}; \ No newline at end of file diff --git a/UnitTest/nrt_test_core_values.cpp b/UnitTest/nrt_test_core_values.cpp new file mode 100644 index 000000000..8e1b96416 --- /dev/null +++ b/UnitTest/nrt_test_core_values.cpp @@ -0,0 +1,13 @@ +#include "pch.h" + +#include "nrt_Test.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nrt_test_core_values) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nrt/unittests/test_core_values.c" + +}; \ No newline at end of file diff --git a/UnitTest/nrt_test_list.cpp b/UnitTest/nrt_test_list.cpp new file mode 100644 index 000000000..45ddc75ff --- /dev/null +++ b/UnitTest/nrt_test_list.cpp @@ -0,0 +1,13 @@ +#include "pch.h" + +#include "nrt_Test.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nrt_test_list) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nrt/unittests/test_list.c" + +}; \ No newline at end of file diff --git a/UnitTest/nrt_test_nrt_byte_swap.cpp b/UnitTest/nrt_test_nrt_byte_swap.cpp new file mode 100644 index 000000000..c863cf98f --- /dev/null +++ b/UnitTest/nrt_test_nrt_byte_swap.cpp @@ -0,0 +1,13 @@ +#include "pch.h" + +#include "nrt_Test.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nrt_test_nrt_byte_swap) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nrt/unittests/test_nrt_byte_swap.c" + +}; diff --git a/UnitTest/nrt_test_nrt_datetime.cpp b/UnitTest/nrt_test_nrt_datetime.cpp new file mode 100644 index 000000000..59e0f3faa --- /dev/null +++ b/UnitTest/nrt_test_nrt_datetime.cpp @@ -0,0 +1,13 @@ +#include "pch.h" + +#include "nrt_Test.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nrt_test_nrt_datetime) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nrt/unittests/test_nrt_datetime.c" + +}; diff --git a/UnitTest/nrt_test_utils.cpp b/UnitTest/nrt_test_utils.cpp index e0b2e49c6..4ca3e39fc 100644 --- a/UnitTest/nrt_test_utils.cpp +++ b/UnitTest/nrt_test_utils.cpp @@ -4,8 +4,9 @@ using namespace Microsoft::VisualStudio::CppUnitTestFramework; -TEST_CLASS(nrt_test_utils) { public: - +TEST_CLASS(nrt_test_utils) { +public: + #define TEST_CASE(X) TEST_METHOD(X) #include "nrt/unittests/test_utils.c" diff --git a/modules/c/nrt/unittests/test_list.c b/modules/c/nrt/unittests/test_list.c index a99ad8ced..2c6cf54c5 100644 --- a/modules/c/nrt/unittests/test_list.c +++ b/modules/c/nrt/unittests/test_list.c @@ -65,12 +65,12 @@ TEST_CASE(testPushPop) char *p = (char *) nrt_List_popFront(l); TEST_ASSERT(p); } - TEST_ASSERT_EQ_INT((size_t)0, nrt_List_size(l)); + TEST_ASSERT_EQ_INT((uint32_t)0, nrt_List_size(l)); nrt_List_destruct(&l); TEST_ASSERT_NULL(l); } -char *cloneString(const char *data, nrt_Error * error) +static char *cloneString(const char *data, nrt_Error * error) { (void)error; @@ -100,11 +100,11 @@ TEST_CASE(testClone) { char *p = (char *) nrt_List_popFront(dolly); TEST_ASSERT(p); - const int32_t value = ++i; + const long value = ++i; TEST_ASSERT_EQ_INT(NRT_ATO32(p), value); } - TEST_ASSERT_EQ_INT((size_t)0, nrt_List_size(dolly)); + TEST_ASSERT_EQ_INT((uint32_t)0, nrt_List_size(dolly)); nrt_List_destruct(&dolly); TEST_ASSERT_NULL(dolly); nrt_List_destruct(&l); @@ -133,7 +133,7 @@ TEST_CASE(testIterate) { char *p = (char *) nrt_ListIterator_get(&it); TEST_ASSERT(p); - const int32_t value = ++i; + const long value = ++i; TEST_ASSERT_EQ_INT(NRT_ATO32(p), value); nrt_ListIterator_increment(&it); } @@ -164,7 +164,7 @@ TEST_CASE(testIterateRemove) char *p = (char *) nrt_List_remove(l, &it); TEST_ASSERT(p); } - TEST_ASSERT_EQ_INT((size_t)0, nrt_List_size(l)); + TEST_ASSERT_EQ_INT((uint32_t)0, nrt_List_size(l)); nrt_List_destruct(&l); TEST_ASSERT_NULL(l); From 5f61e5b5669a0518bf0161f7af10eaf9d6e382c5 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Fri, 11 Mar 2022 12:30:09 -0500 Subject: [PATCH 004/104] start adding nitf_ unittests --- UnitTest/UnitTest.vcxproj | 1 + UnitTest/UnitTest.vcxproj.filters | 1 + UnitTest/nitf_Test.h | 4 +- UnitTest/nitf_test_create.cpp | 13 +++ UnitTest/nitf_test_create_nitf.cpp | 12 +++ UnitTest/nitf_test_field.cpp | 7 ++ UnitTest/nitf_test_geo_utils.cpp | 7 ++ UnitTest/nitf_test_image_io.cpp | 11 +++ UnitTest/nitf_test_mem_source.cpp | 6 ++ UnitTest/nitf_test_tre_mods.cpp | 133 +++++++++++++++++++++++++++++ UnitTest/nitf_test_tre_read.cpp | 35 ++++++++ UnitTest/nitf_test_zero_field.cpp | 6 ++ UnitTest/pch.h | 1 + 13 files changed, 236 insertions(+), 1 deletion(-) create mode 100644 UnitTest/nitf_test_create.cpp create mode 100644 UnitTest/nitf_test_create_nitf.cpp create mode 100644 UnitTest/nitf_test_field.cpp create mode 100644 UnitTest/nitf_test_geo_utils.cpp create mode 100644 UnitTest/nitf_test_image_io.cpp create mode 100644 UnitTest/nitf_test_mem_source.cpp create mode 100644 UnitTest/nitf_test_tre_mods.cpp create mode 100644 UnitTest/nitf_test_tre_read.cpp create mode 100644 UnitTest/nitf_test_zero_field.cpp diff --git a/UnitTest/UnitTest.vcxproj b/UnitTest/UnitTest.vcxproj index 78a91ea72..ba4a7a002 100644 --- a/UnitTest/UnitTest.vcxproj +++ b/UnitTest/UnitTest.vcxproj @@ -87,6 +87,7 @@ + diff --git a/UnitTest/UnitTest.vcxproj.filters b/UnitTest/UnitTest.vcxproj.filters index 67e401d45..d1249efa9 100644 --- a/UnitTest/UnitTest.vcxproj.filters +++ b/UnitTest/UnitTest.vcxproj.filters @@ -9,6 +9,7 @@ + diff --git a/UnitTest/nitf_Test.h b/UnitTest/nitf_Test.h index 86f39e272..db18ff558 100644 --- a/UnitTest/nitf_Test.h +++ b/UnitTest/nitf_Test.h @@ -1,6 +1,6 @@ #pragma once -#if defined(GTEST_API_) +#if defined(MS_CPP_UNITTESTFRAMEWORK) #define __TEST_H__ // #include "../nitf/unittests/Test.h" #define __TEST_CASE_H__ // #include "../nitf/unittests/TestCase.h" #endif @@ -8,6 +8,8 @@ #include +#include "import/nitf.h" + namespace nitf { namespace Test diff --git a/UnitTest/nitf_test_create.cpp b/UnitTest/nitf_test_create.cpp new file mode 100644 index 000000000..f794fe585 --- /dev/null +++ b/UnitTest/nitf_test_create.cpp @@ -0,0 +1,13 @@ +#include "pch.h" + +#include "nitf_Test.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_create) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nitf/unittests/test_create.c" + +}; \ No newline at end of file diff --git a/UnitTest/nitf_test_create_nitf.cpp b/UnitTest/nitf_test_create_nitf.cpp new file mode 100644 index 000000000..8a65bf06b --- /dev/null +++ b/UnitTest/nitf_test_create_nitf.cpp @@ -0,0 +1,12 @@ +#include "pch.h" + +#include "nitf_Test.h" + +#define TEST_NAME nitf_test_create_nitf +#define TEST_CASE(X) TEST(TEST_NAME, X) + +int argc = 1; +const char* argv[] = { "nitf_test_create_nitf" }; +#define TEST_CASE_ARGS(X) TEST(TEST_NAME, X) + +#include "nitf/unittests/test_create_nitf.c" diff --git a/UnitTest/nitf_test_field.cpp b/UnitTest/nitf_test_field.cpp new file mode 100644 index 000000000..a65438a1c --- /dev/null +++ b/UnitTest/nitf_test_field.cpp @@ -0,0 +1,7 @@ +#include "pch.h" + +#include "nitf_Test.h" + +#define TEST_CASE(X) TEST(nitf_test_field, X) +#include "nitf/unittests/test_field.c" + diff --git a/UnitTest/nitf_test_geo_utils.cpp b/UnitTest/nitf_test_geo_utils.cpp new file mode 100644 index 000000000..f7e9e6672 --- /dev/null +++ b/UnitTest/nitf_test_geo_utils.cpp @@ -0,0 +1,7 @@ +#include "pch.h" + +#include "nitf_Test.h" + +#define TEST_CASE(X) TEST(nitf_test_geo_utils, X) +#include "nitf/unittests/test_geo_utils.c" + diff --git a/UnitTest/nitf_test_image_io.cpp b/UnitTest/nitf_test_image_io.cpp new file mode 100644 index 000000000..3f3277845 --- /dev/null +++ b/UnitTest/nitf_test_image_io.cpp @@ -0,0 +1,11 @@ +#include "pch.h" + +#include +#include +#undef interface + +#include "nitf_Test.h" + +#define TEST_CASE(X) TEST(nitf_test_image_io, X) +#include "nitf/unittests/test_image_io.c" + diff --git a/UnitTest/nitf_test_mem_source.cpp b/UnitTest/nitf_test_mem_source.cpp new file mode 100644 index 000000000..34847e778 --- /dev/null +++ b/UnitTest/nitf_test_mem_source.cpp @@ -0,0 +1,6 @@ +#include "pch.h" + +#include "nitf_Test.h" + +#define TEST_CASE(X) TEST(nitf_test_mem_source, X) +#include "nitf/unittests/test_mem_source.c" diff --git a/UnitTest/nitf_test_tre_mods.cpp b/UnitTest/nitf_test_tre_mods.cpp new file mode 100644 index 000000000..167a0aece --- /dev/null +++ b/UnitTest/nitf_test_tre_mods.cpp @@ -0,0 +1,133 @@ +#include "pch.h" + +#include + +#include +#include + +#include "nitf_Test.h" + +namespace fs = std::filesystem; + +static bool is_x64_Configuration(const fs::path& path) // "Configuration" is typically "Debug" or "Release" +{ + const std::string build_configuration = +#if defined(NDEBUG) // i.e., release + "Release"; +#else + "Debug"; +#endif + + const auto Configuration = path.filename(); + const auto path_parent_path = path.parent_path(); + const auto x64 = path_parent_path.filename(); + return (Configuration == build_configuration) && (x64 == "x64"); +} + +static bool is_install_unittests(const fs::path& path) +{ + const auto unittests = path.filename(); + const auto path_parent_path = path.parent_path(); + const auto install = path_parent_path.filename(); + return (unittests == "unittests") && (install == "install"); +} +static bool is_install_tests(const fs::path& path) +{ + const auto tests = path.filename(); + const auto path_parent_path = path.parent_path(); + const auto install = path_parent_path.filename(); + return (tests == "tests") && (install == "install"); +} + +static fs::path buildDir(const fs::path& path) +{ + const auto cwd = fs::current_path(); + + const sys::OS os; + const auto exec = fs::path(os.getCurrentExecutable()); + const auto argv0 = exec.filename(); + if (argv0 == "Test.exe") + { + // Running GTest unit-tests in Visual Studio on Windows + if (is_x64_Configuration(cwd)) + { + return cwd / path; + } + } + + if (argv0 == "unittests.exe") + { + // stand-alone unittest executable on Windows (ends in .EXE) + const auto parent_path = exec.parent_path(); + if (is_x64_Configuration(parent_path)) + { + const auto parent_path_ = parent_path.parent_path().parent_path(); + return parent_path_ / "dev" / "tests" / "images"; + } + } + + // stand-alone unit-test on Linux + const auto exec_dir = exec.parent_path(); + if (is_install_unittests(exec_dir)) + { + const auto install = exec_dir.parent_path(); + return install / "unittests" / "data"; + } + if (is_install_tests(exec_dir)) + { + const auto install = exec_dir.parent_path(); + return install / "unittests" / "data"; + } + + if (argv0 == "unittests") + { + // stand-alone unittest executable on Linux + const auto bin = exec.parent_path(); + if (bin.filename() == "bin") + { + const auto unittests = bin.parent_path(); + return unittests / "unittests" / "data"; + } + } + + //fprintf(stderr, "cwd = %s\n", cwd.c_str()); + //fprintf(stderr, "exec = %s\n", exec.c_str()); + + return cwd; +} + +static fs::path buildPluginsDir() +{ + return buildDir(fs::path("share") / "nitf" / "plugins"); +} + +struct nitf_test_tre_mods : public ::testing::Test { + nitf_test_tre_mods() { + // initialization code here + //const std::string NITF_PLUGIN_PATH = R"(C:\Users\jdsmith\source\repos\nitro\x64\Debug\share\nitf\plugins)"; + const std::string putenv_ = "NITF_PLUGIN_PATH=" + buildPluginsDir().string(); + _putenv(putenv_.c_str()); + } + + void SetUp() { + // code here will execute just before the test ensues + } + + void TearDown() { + // code here will be called just after the test completes + // ok to through exceptions from here if need be + } + + ~nitf_test_tre_mods() { + // cleanup any pending stuff, but no exceptions allowed + } + + nitf_test_tre_mods(const nitf_test_tre_mods&) = delete; + nitf_test_tre_mods& operator=(const nitf_test_tre_mods&) = delete; + + + // put in any custom data members that you need +}; + +#define TEST_CASE(X) TEST_F(nitf_test_tre_mods, X) +#include "nitf/unittests/test_tre_mods.c" diff --git a/UnitTest/nitf_test_tre_read.cpp b/UnitTest/nitf_test_tre_read.cpp new file mode 100644 index 000000000..f7ec0cfe5 --- /dev/null +++ b/UnitTest/nitf_test_tre_read.cpp @@ -0,0 +1,35 @@ +#include "pch.h" + +#include + +#include "nitf_Test.h" + +struct test_tre_read : public ::testing::Test { + test_tre_read() { + // initialization code here + //const std::string NITF_PLUGIN_PATH = R"(C:\Users\jdsmith\source\repos\nitro\x64\Debug\share\nitf\plugins)"; + sys::OS().setEnv("NITF_PLUGIN_PATH", nitf::Test::buildPluginsDir(), true /*overwrite*/); + } + + void SetUp() { + // code here will execute just before the test ensues + } + + void TearDown() { + // code here will be called just after the test completes + // ok to through exceptions from here if need be + } + + ~test_tre_read() { + // cleanup any pending stuff, but no exceptions allowed + } + + test_tre_read(const test_tre_read&) = delete; + test_tre_read& operator=(const test_tre_read&) = delete; + + + // put in any custom data members that you need +}; + +#define TEST_CASE(X) TEST_F(test_tre_read, X) +#include "nitf/unittests/test_tre_read.cpp" diff --git a/UnitTest/nitf_test_zero_field.cpp b/UnitTest/nitf_test_zero_field.cpp new file mode 100644 index 000000000..0d0cf4852 --- /dev/null +++ b/UnitTest/nitf_test_zero_field.cpp @@ -0,0 +1,6 @@ +#include "pch.h" + +#include "nitf_Test.h" + +#define TEST_CASE(X) TEST(nitf_test_zero_field, X) +#include "nitf/unittests/test_zero_field.c" diff --git a/UnitTest/pch.h b/UnitTest/pch.h index a2c6e0e88..fb05af902 100644 --- a/UnitTest/pch.h +++ b/UnitTest/pch.h @@ -41,6 +41,7 @@ #pragma warning(pop) #include +#include #include #include "nitf_Test.h" From ff1c6c00dcd2c78108e2961905df505d66ee4848 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Fri, 11 Mar 2022 12:33:23 -0500 Subject: [PATCH 005/104] add some simple nitf unittests --- UnitTest/UnitTest.vcxproj | 4 ++++ UnitTest/UnitTest.vcxproj.filters | 4 ++++ UnitTest/nitf_test_field.cpp | 8 +++++++- UnitTest/nitf_test_geo_utils.cpp | 8 +++++++- UnitTest/nitf_test_mem_source.cpp | 9 ++++++++- UnitTest/nitf_test_zero_field.cpp | 9 ++++++++- 6 files changed, 38 insertions(+), 4 deletions(-) diff --git a/UnitTest/UnitTest.vcxproj b/UnitTest/UnitTest.vcxproj index ba4a7a002..2fce71c3e 100644 --- a/UnitTest/UnitTest.vcxproj +++ b/UnitTest/UnitTest.vcxproj @@ -88,6 +88,10 @@ + + + + diff --git a/UnitTest/UnitTest.vcxproj.filters b/UnitTest/UnitTest.vcxproj.filters index d1249efa9..8b2cdb49b 100644 --- a/UnitTest/UnitTest.vcxproj.filters +++ b/UnitTest/UnitTest.vcxproj.filters @@ -10,6 +10,10 @@ + + + + diff --git a/UnitTest/nitf_test_field.cpp b/UnitTest/nitf_test_field.cpp index a65438a1c..70fecd6e6 100644 --- a/UnitTest/nitf_test_field.cpp +++ b/UnitTest/nitf_test_field.cpp @@ -2,6 +2,12 @@ #include "nitf_Test.h" -#define TEST_CASE(X) TEST(nitf_test_field, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_field) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_field.c" +}; \ No newline at end of file diff --git a/UnitTest/nitf_test_geo_utils.cpp b/UnitTest/nitf_test_geo_utils.cpp index f7e9e6672..e30ba258d 100644 --- a/UnitTest/nitf_test_geo_utils.cpp +++ b/UnitTest/nitf_test_geo_utils.cpp @@ -2,6 +2,12 @@ #include "nitf_Test.h" -#define TEST_CASE(X) TEST(nitf_test_geo_utils, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_geo_utils) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_geo_utils.c" +}; \ No newline at end of file diff --git a/UnitTest/nitf_test_mem_source.cpp b/UnitTest/nitf_test_mem_source.cpp index 34847e778..341cccbac 100644 --- a/UnitTest/nitf_test_mem_source.cpp +++ b/UnitTest/nitf_test_mem_source.cpp @@ -2,5 +2,12 @@ #include "nitf_Test.h" -#define TEST_CASE(X) TEST(nitf_test_mem_source, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_mem_source) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_mem_source.c" + +}; \ No newline at end of file diff --git a/UnitTest/nitf_test_zero_field.cpp b/UnitTest/nitf_test_zero_field.cpp index 0d0cf4852..adda886ae 100644 --- a/UnitTest/nitf_test_zero_field.cpp +++ b/UnitTest/nitf_test_zero_field.cpp @@ -2,5 +2,12 @@ #include "nitf_Test.h" -#define TEST_CASE(X) TEST(nitf_test_zero_field, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_zero_field) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_zero_field.c" + +}; \ No newline at end of file From 0facbe5a16cc778a5e96f4db5f888cf675f6ea35 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Fri, 11 Mar 2022 12:42:57 -0500 Subject: [PATCH 006/104] hook up more "nitf" unit-tests --- UnitTest/UnitTest.vcxproj | 2 ++ UnitTest/UnitTest.vcxproj.filters | 2 ++ UnitTest/nitf_test_create_nitf.cpp | 14 +++++++++++--- UnitTest/nitf_test_image_io.cpp | 12 +++++++----- modules/c/nitf/unittests/nitro_image_.c_ | 5 +++++ modules/c/nitf/unittests/test_create_nitf.c | 2 +- modules/c/nitf/unittests/test_image_io.c | 2 +- 7 files changed, 29 insertions(+), 10 deletions(-) diff --git a/UnitTest/UnitTest.vcxproj b/UnitTest/UnitTest.vcxproj index 2fce71c3e..206fdd1ca 100644 --- a/UnitTest/UnitTest.vcxproj +++ b/UnitTest/UnitTest.vcxproj @@ -88,8 +88,10 @@ + + diff --git a/UnitTest/UnitTest.vcxproj.filters b/UnitTest/UnitTest.vcxproj.filters index 8b2cdb49b..24e296d65 100644 --- a/UnitTest/UnitTest.vcxproj.filters +++ b/UnitTest/UnitTest.vcxproj.filters @@ -14,6 +14,8 @@ + + diff --git a/UnitTest/nitf_test_create_nitf.cpp b/UnitTest/nitf_test_create_nitf.cpp index 8a65bf06b..8fdf17ce8 100644 --- a/UnitTest/nitf_test_create_nitf.cpp +++ b/UnitTest/nitf_test_create_nitf.cpp @@ -3,10 +3,18 @@ #include "nitf_Test.h" #define TEST_NAME nitf_test_create_nitf -#define TEST_CASE(X) TEST(TEST_NAME, X) - int argc = 1; const char* argv[] = { "nitf_test_create_nitf" }; -#define TEST_CASE_ARGS(X) TEST(TEST_NAME, X) +#include "nitf/unittests/nitro_image_.c_" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_create_nitf) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) +#define TEST_CASE_ARGS(X) TEST_METHOD(X) #include "nitf/unittests/test_create_nitf.c" + +}; \ No newline at end of file diff --git a/UnitTest/nitf_test_image_io.cpp b/UnitTest/nitf_test_image_io.cpp index 3f3277845..097defccb 100644 --- a/UnitTest/nitf_test_image_io.cpp +++ b/UnitTest/nitf_test_image_io.cpp @@ -1,11 +1,13 @@ #include "pch.h" -#include -#include -#undef interface - #include "nitf_Test.h" -#define TEST_CASE(X) TEST(nitf_test_image_io, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_image_io) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_image_io.c" +}; \ No newline at end of file diff --git a/modules/c/nitf/unittests/nitro_image_.c_ b/modules/c/nitf/unittests/nitro_image_.c_ index cdf1d8e4a..611bc89e4 100644 --- a/modules/c/nitf/unittests/nitro_image_.c_ +++ b/modules/c/nitf/unittests/nitro_image_.c_ @@ -20,6 +20,9 @@ * see . * */ + #ifndef NITRO_nitf_unittests_nitro_image__c__INCLUDED_ + #define NITRO_nitf_unittests_nitro_image__c__INCLUDED_ + #pragma once #ifdef _MSC_VER #pragma warning(push) @@ -973,3 +976,5 @@ static const struct { #ifdef _MSC_VER #pragma warning(pop) #endif + +#endif // NITRO_nitf_unittests_nitro_image__c__INCLUDED_ diff --git a/modules/c/nitf/unittests/test_create_nitf.c b/modules/c/nitf/unittests/test_create_nitf.c index c286c6a05..27bbfa5ff 100644 --- a/modules/c/nitf/unittests/test_create_nitf.c +++ b/modules/c/nitf/unittests/test_create_nitf.c @@ -32,7 +32,7 @@ #include "nitro_image_.c_" -static const char* RGB[] = {"R", "G", "B"}; +const char* RGB[3] = {"R", "G", "B"}; diff --git a/modules/c/nitf/unittests/test_image_io.c b/modules/c/nitf/unittests/test_image_io.c index ab6c81e10..0320e3831 100644 --- a/modules/c/nitf/unittests/test_image_io.c +++ b/modules/c/nitf/unittests/test_image_io.c @@ -158,7 +158,7 @@ void freeTestState(TestState* state) free(state); } -void freeBands(uint8_t** bands, size_t numBands) +static void freeBands(uint8_t** bands, size_t numBands) { size_t bandIndex; for (bandIndex = 0; bandIndex < numBands; ++bandIndex) From c7553f49e69737051e04700b78d01fde5e4e3ca6 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Fri, 11 Mar 2022 12:53:44 -0500 Subject: [PATCH 007/104] hookup test_tre_mods --- UnitTest/Test.h | 2 +- UnitTest/UnitTest.vcxproj | 1 + UnitTest/UnitTest.vcxproj.filters | 1 + UnitTest/nitf_test_tre_mods.cpp | 42 ++++++++++++------------------- 4 files changed, 19 insertions(+), 27 deletions(-) diff --git a/UnitTest/Test.h b/UnitTest/Test.h index afbfd4d16..760edec79 100644 --- a/UnitTest/Test.h +++ b/UnitTest/Test.h @@ -10,7 +10,7 @@ inline void test_assert_eq_(const T& t, const U& u) Assert::AreEqual(t, u); } #define TEST_ASSERT_EQ(X1, X2) { test_assert_eq_(X1, X2); test_assert_eq_(X2, X1); } -#define TEST_ASSERT_EQ_INT(X1, X2) TEST_ASSERT_EQ(X1, X2) +#define TEST_ASSERT_EQ_INT(X1, X2) TEST_ASSERT_EQ(X2, X1) template inline void test_assert_str_eq_(const T& t, const U& u) { diff --git a/UnitTest/UnitTest.vcxproj b/UnitTest/UnitTest.vcxproj index 206fdd1ca..e064b0a78 100644 --- a/UnitTest/UnitTest.vcxproj +++ b/UnitTest/UnitTest.vcxproj @@ -93,6 +93,7 @@ + diff --git a/UnitTest/UnitTest.vcxproj.filters b/UnitTest/UnitTest.vcxproj.filters index 24e296d65..8e3447ec3 100644 --- a/UnitTest/UnitTest.vcxproj.filters +++ b/UnitTest/UnitTest.vcxproj.filters @@ -16,6 +16,7 @@ + diff --git a/UnitTest/nitf_test_tre_mods.cpp b/UnitTest/nitf_test_tre_mods.cpp index 167a0aece..072abac48 100644 --- a/UnitTest/nitf_test_tre_mods.cpp +++ b/UnitTest/nitf_test_tre_mods.cpp @@ -46,9 +46,9 @@ static fs::path buildDir(const fs::path& path) const sys::OS os; const auto exec = fs::path(os.getCurrentExecutable()); const auto argv0 = exec.filename(); - if (argv0 == "Test.exe") + if (argv0 == "testhost.exe") { - // Running GTest unit-tests in Visual Studio on Windows + // Running Visual Studio unit-tests on Windows if (is_x64_Configuration(cwd)) { return cwd / path; @@ -101,33 +101,23 @@ static fs::path buildPluginsDir() return buildDir(fs::path("share") / "nitf" / "plugins"); } -struct nitf_test_tre_mods : public ::testing::Test { - nitf_test_tre_mods() { - // initialization code here - //const std::string NITF_PLUGIN_PATH = R"(C:\Users\jdsmith\source\repos\nitro\x64\Debug\share\nitf\plugins)"; - const std::string putenv_ = "NITF_PLUGIN_PATH=" + buildPluginsDir().string(); - _putenv(putenv_.c_str()); - } - - void SetUp() { - // code here will execute just before the test ensues - } - - void TearDown() { - // code here will be called just after the test completes - // ok to through exceptions from here if need be - } +using namespace Microsoft::VisualStudio::CppUnitTestFramework; - ~nitf_test_tre_mods() { - // cleanup any pending stuff, but no exceptions allowed - } +TEST_CLASS(nitf_test_tre_mods) { +public: + nitf_test_tre_mods() + { + // initialization code here + //const std::string NITF_PLUGIN_PATH = R"(C:\Users\jdsmith\source\repos\nitro\x64\Debug\share\nitf\plugins)"; + const std::string putenv_ = "NITF_PLUGIN_PATH=" + buildPluginsDir().string(); + _putenv(putenv_.c_str()); + } + ~nitf_test_tre_mods() = default; nitf_test_tre_mods(const nitf_test_tre_mods&) = delete; nitf_test_tre_mods& operator=(const nitf_test_tre_mods&) = delete; - - // put in any custom data members that you need -}; - -#define TEST_CASE(X) TEST_F(nitf_test_tre_mods, X) +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_tre_mods.c" + +}; \ No newline at end of file From b916f1157ccc7dd9439d7fbf24803a3e07367c8e Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Mon, 14 Mar 2022 16:51:37 -0400 Subject: [PATCH 008/104] move C++ unit-test to Test++ --- Test++/Test++.vcxproj | 1 + {Test => Test++}/nitf_test_tre_read.cpp | 0 Test/Test.vcxproj | 1 - 3 files changed, 1 insertion(+), 1 deletion(-) rename {Test => Test++}/nitf_test_tre_read.cpp (100%) diff --git a/Test++/Test++.vcxproj b/Test++/Test++.vcxproj index 52abbab3f..097d5c823 100644 --- a/Test++/Test++.vcxproj +++ b/Test++/Test++.vcxproj @@ -44,6 +44,7 @@ + Create diff --git a/Test/nitf_test_tre_read.cpp b/Test++/nitf_test_tre_read.cpp similarity index 100% rename from Test/nitf_test_tre_read.cpp rename to Test++/nitf_test_tre_read.cpp diff --git a/Test/Test.vcxproj b/Test/Test.vcxproj index 56a27b4a3..44c703606 100644 --- a/Test/Test.vcxproj +++ b/Test/Test.vcxproj @@ -40,7 +40,6 @@ - From da58fbad1dbbdd6b272b2587dda3c9bdcfd1be1e Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Mon, 14 Mar 2022 16:55:18 -0400 Subject: [PATCH 009/104] replace Google "Test" with Visual Studio "UnitTest" --- Test/SetPluginPath.cpp | 126 -------------- Test/Test.h | 24 ++- Test/Test.vcxproj | 162 +++++++++--------- .../Test.vcxproj.filters | 0 Test/nitf_Test.h | 4 +- Test/nitf_test_create.cpp | 9 +- Test/nitf_test_create_nitf.cpp | 14 +- Test/nitf_test_field.cpp | 8 +- Test/nitf_test_geo_utils.cpp | 8 +- Test/nitf_test_image_io.cpp | 12 +- Test/nitf_test_mem_source.cpp | 9 +- Test/nitf_test_tre_mods.cpp | 42 ++--- {UnitTest => Test}/nitf_test_tre_read.cpp | 0 Test/nitf_test_zero_field.cpp | 9 +- Test/nrt_Test.h | 2 +- Test/nrt_test_buffer_adapter.cpp | 9 +- Test/nrt_test_core_values.cpp | 11 +- Test/nrt_test_list.cpp | 9 +- Test/nrt_test_nrt_byte_swap.cpp | 9 +- Test/nrt_test_nrt_datetime.cpp | 9 +- Test/nrt_test_tree.cpp | 9 +- Test/nrt_test_utils.cpp | 9 +- Test/packages.config | 4 - Test/pch.cpp | 7 +- Test/pch.h | 24 ++- UnitTest/Test.h | 43 ----- UnitTest/TestCase.h | 2 - UnitTest/UnitTest.vcxproj | 162 ------------------ UnitTest/j2k_Test.h | 6 - UnitTest/nitf_Test.h | 19 -- UnitTest/nitf_test_create.cpp | 13 -- UnitTest/nitf_test_create_nitf.cpp | 20 --- UnitTest/nitf_test_field.cpp | 13 -- UnitTest/nitf_test_geo_utils.cpp | 13 -- UnitTest/nitf_test_image_io.cpp | 13 -- UnitTest/nitf_test_mem_source.cpp | 13 -- UnitTest/nitf_test_tre_mods.cpp | 123 ------------- UnitTest/nitf_test_zero_field.cpp | 13 -- UnitTest/nrt_Test.h | 6 - UnitTest/nrt_test_buffer_adapter.cpp | 13 -- UnitTest/nrt_test_core_values.cpp | 13 -- UnitTest/nrt_test_list.cpp | 13 -- UnitTest/nrt_test_nrt_byte_swap.cpp | 13 -- UnitTest/nrt_test_nrt_datetime.cpp | 13 -- UnitTest/nrt_test_tree.cpp | 14 -- UnitTest/nrt_test_utils.cpp | 13 -- UnitTest/pch.cpp | 5 - UnitTest/pch.h | 50 ------ nitro.sln | 6 - 49 files changed, 241 insertions(+), 900 deletions(-) delete mode 100644 Test/SetPluginPath.cpp rename UnitTest/UnitTest.vcxproj.filters => Test/Test.vcxproj.filters (100%) rename {UnitTest => Test}/nitf_test_tre_read.cpp (100%) delete mode 100644 Test/packages.config delete mode 100644 UnitTest/Test.h delete mode 100644 UnitTest/TestCase.h delete mode 100644 UnitTest/UnitTest.vcxproj delete mode 100644 UnitTest/j2k_Test.h delete mode 100644 UnitTest/nitf_Test.h delete mode 100644 UnitTest/nitf_test_create.cpp delete mode 100644 UnitTest/nitf_test_create_nitf.cpp delete mode 100644 UnitTest/nitf_test_field.cpp delete mode 100644 UnitTest/nitf_test_geo_utils.cpp delete mode 100644 UnitTest/nitf_test_image_io.cpp delete mode 100644 UnitTest/nitf_test_mem_source.cpp delete mode 100644 UnitTest/nitf_test_tre_mods.cpp delete mode 100644 UnitTest/nitf_test_zero_field.cpp delete mode 100644 UnitTest/nrt_Test.h delete mode 100644 UnitTest/nrt_test_buffer_adapter.cpp delete mode 100644 UnitTest/nrt_test_core_values.cpp delete mode 100644 UnitTest/nrt_test_list.cpp delete mode 100644 UnitTest/nrt_test_nrt_byte_swap.cpp delete mode 100644 UnitTest/nrt_test_nrt_datetime.cpp delete mode 100644 UnitTest/nrt_test_tree.cpp delete mode 100644 UnitTest/nrt_test_utils.cpp delete mode 100644 UnitTest/pch.cpp delete mode 100644 UnitTest/pch.h diff --git a/Test/SetPluginPath.cpp b/Test/SetPluginPath.cpp deleted file mode 100644 index 2a8a521cb..000000000 --- a/Test/SetPluginPath.cpp +++ /dev/null @@ -1,126 +0,0 @@ -#include "pch.h" - -#include - -#include -#include - -#include "nitf_Test.h" - -namespace fs = std::filesystem; - -static std::string Configuration() // "Configuration" is typically "Debug" or "Release" -{ - static const sys::OS os; - return os.getSpecialEnv("Configuration"); -} - -static std::string Platform() -{ - static const sys::OS os; - return os.getSpecialEnv("Platform"); -} - -//// https://stackoverflow.com/questions/13794130/visual-studio-how-to-check-used-c-platform-toolset-programmatically -//static std::string PlatformToolset() -//{ -// // https://docs.microsoft.com/en-us/cpp/build/how-to-modify-the-target-framework-and-platform-toolset?view=msvc-160 -//#if _MSC_FULL_VER >= 190000000 -// return "v142"; -//#else -//#error "Don't know $(PlatformToolset) value.'" -//#endif -//} - -static bool is_x64_Configuration(const fs::path& path) // "Configuration" is typically "Debug" or "Release" -{ - static const std::string build_configuration = Configuration(); - const auto Configuration = path.filename(); - const auto path_parent_path = path.parent_path(); - const auto x64 = path_parent_path.filename(); - return (Configuration == build_configuration) && (x64 == Platform()); -} - -static bool is_install_unittests(const fs::path& path) -{ - const auto unittests = path.filename(); - const auto path_parent_path = path.parent_path(); - const auto install = path_parent_path.filename(); - return (unittests == "unittests") && (install == "install"); -} -static bool is_install_tests(const fs::path& path) -{ - const auto tests = path.filename(); - const auto path_parent_path = path.parent_path(); - const auto install = path_parent_path.filename(); - return (tests == "tests") && (install == "install"); -} - -static fs::path buildDir(const fs::path& path) -{ - const auto cwd = fs::current_path(); - - const sys::OS os; - const auto exec = fs::path(os.getCurrentExecutable()); - const auto argv0 = exec.filename(); - if (argv0 == "Test.exe") - { - // Running GTest unit-tests in Visual Studio on Windows - if (is_x64_Configuration(cwd)) - { - //const auto root = cwd.parent_path().parent_path(); - //const auto install = "install-" + Configuration() + "-" + Platform() + "." + PlatformToolset(); - //return root / install / path; - return cwd / path; - } - } - - if (argv0 == "unittests.exe") - { - // stand-alone unittest executable on Windows (ends in .EXE) - const auto parent_path = exec.parent_path(); - if (is_x64_Configuration(parent_path)) - { - const auto parent_path_ = parent_path.parent_path().parent_path(); - return parent_path_ / "dev" / "tests" / "images"; - } - } - - // stand-alone unit-test on Linux - const auto exec_dir = exec.parent_path(); - if (is_install_unittests(exec_dir)) - { - const auto install = exec_dir.parent_path(); - return install / "unittests" / "data"; - } - if (is_install_tests(exec_dir)) - { - const auto install = exec_dir.parent_path(); - return install / "unittests" / "data"; - } - - if (argv0 == "unittests") - { - // stand-alone unittest executable on Linux - const auto bin = exec.parent_path(); - if (bin.filename() == "bin") - { - const auto unittests = bin.parent_path(); - return unittests / "unittests" / "data"; - } - } - - //fprintf(stderr, "cwd = %s\n", cwd.c_str()); - //fprintf(stderr, "exec = %s\n", exec.c_str()); - - return cwd; -} - -static fs::path buildPluginsDir() -{ - return buildDir(fs::path("share") / "nitf" / "plugins"); -} -std::string nitf::Test::buildPluginsDir() -{ - return ::buildPluginsDir().string(); -} \ No newline at end of file diff --git a/Test/Test.h b/Test/Test.h index 1d2cdf509..760edec79 100644 --- a/Test/Test.h +++ b/Test/Test.h @@ -1,40 +1,38 @@ #pragma once -#include "gtest/gtest.h" +#include "CppUnitTest.h" -// use GTest macros to mimic existing unit-tests - -#define TEST_ASSERT(X) EXPECT_TRUE(X) +#define TEST_ASSERT(X) Assert::IsTrue(X) template inline void test_assert_eq_(const T& t, const U& u) { - EXPECT_EQ(t, u); + Assert::AreEqual(t, u); } #define TEST_ASSERT_EQ(X1, X2) { test_assert_eq_(X1, X2); test_assert_eq_(X2, X1); } -#define TEST_ASSERT_EQ_INT(X1, X2) TEST_ASSERT_EQ(X1, X2) +#define TEST_ASSERT_EQ_INT(X1, X2) TEST_ASSERT_EQ(X2, X1) template inline void test_assert_str_eq_(const T& t, const U& u) { - EXPECT_STREQ(t, u); + Assert::AreEqual(t, u); } #define TEST_ASSERT_EQ_STR(X1, X2) { test_assert_str_eq_(X1, X2); test_assert_str_eq_(X2, X1); } -#define TEST_ASSERT_EQ_FLOAT(X1, X2) EXPECT_FLOAT_EQ(static_cast(X1), static_cast(X2)) +#define TEST_ASSERT_EQ_FLOAT(X1, X2) Assert::AreEqual(static_cast(X1), static_cast(X2)) -#define TEST_ASSERT_NULL(X) TEST_ASSERT_EQ((X), nullptr) -#define TEST_ASSERT_TRUE(X) TEST_ASSERT_EQ((X), true) -#define TEST_ASSERT_FALSE(X) TEST_ASSERT_EQ((X), false) +#define TEST_ASSERT_NULL(X) Assert::IsNull((X)) +#define TEST_ASSERT_TRUE(X) Assert::IsTrue((X)) +#define TEST_ASSERT_FALSE(X) Assert::IsFalse((X)) template inline void test_assert_not_eq_(const T& t, const U& u) { - EXPECT_NE(t, u); + Assert::AreNotEqual(t, u); } #define TEST_ASSERT_NOT_EQ(X1, X2) { test_assert_not_eq_(X1, X2); test_assert_not_eq_(X2, X1);} #define TEST_ASSERT_GREATER(X1, X2) EXPECT_GT(X1, X2) -#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) EXPECT_NEAR(X1, X2, EPS) +#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) Assert:AreEqual(X1, X2, EPS) #define TEST_ASSERT_ALMOST_EQ(X1, X2) TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, 0.0001) #define TEST_ASSERT_EQ_MSG(msg, X1, X2) SCOPED_TRACE(msg); TEST_ASSERT_EQ(X1, X2) diff --git a/Test/Test.vcxproj b/Test/Test.vcxproj index 44c703606..2bff7604a 100644 --- a/Test/Test.vcxproj +++ b/Test/Test.vcxproj @@ -1,5 +1,5 @@ - - + + Debug @@ -11,27 +11,81 @@ - {238c9787-b27d-4107-b8fd-1bdb49ea8023} + 17.0 + {238C9787-B27D-4107-B8FD-1BDB49EA8023} Win32Proj - 10.0.20348.0 - Application + UnitTest + 10.0 + NativeUnitTestProject + + + + DynamicLibrary + true v143 Unicode + false + + + DynamicLibrary + false + v143 + true + Unicode + false - - - - + + + + + + + + + + - - - - - - - - + + true + + + false + + + + Use + Level3 + true + $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + _DEBUG;%(PreprocessorDefinitions) + true + pch.h + + + Windows + $(VCInstallDir)UnitTest\lib;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) + + + + + Use + Level3 + true + true + true + $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + NDEBUG;%(PreprocessorDefinitions) + true + pch.h + + + Windows + true + true + $(VCInstallDir)UnitTest\lib;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) + + @@ -47,14 +101,24 @@ - Create Create - + + + + + + + + + + + {8f357a19-799e-4971-850e-3f28485c130b} + {f06550ad-cfc7-40b8-8727-6c82c69a8982} @@ -92,67 +156,7 @@ {78849481-d356-4cc7-b182-31c21f857ed1} - - - - - - - - Use - pch.h - Disabled - X64;_DEBUG;_CONSOLE;%(PreprocessorDefinitions) - EnableFastChecks - MultiThreadedDebugDLL - EnableAllWarnings - $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;%(AdditionalIncludeDirectories) - true - Guard - true - AdvancedVectorExtensions2 - true - true - - - true - Console - $(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) - - - - - Use - pch.h - X64;NDEBUG;_CONSOLE;%(PreprocessorDefinitions) - MultiThreadedDLL - Level3 - ProgramDatabase - $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;%(AdditionalIncludeDirectories) - true - Guard - true - Speed - AdvancedVectorExtensions2 - true - true - true - - - true - Console - true - true - $(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) - - - - - This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}. - - - \ No newline at end of file diff --git a/UnitTest/UnitTest.vcxproj.filters b/Test/Test.vcxproj.filters similarity index 100% rename from UnitTest/UnitTest.vcxproj.filters rename to Test/Test.vcxproj.filters diff --git a/Test/nitf_Test.h b/Test/nitf_Test.h index 86f39e272..db18ff558 100644 --- a/Test/nitf_Test.h +++ b/Test/nitf_Test.h @@ -1,6 +1,6 @@ #pragma once -#if defined(GTEST_API_) +#if defined(MS_CPP_UNITTESTFRAMEWORK) #define __TEST_H__ // #include "../nitf/unittests/Test.h" #define __TEST_CASE_H__ // #include "../nitf/unittests/TestCase.h" #endif @@ -8,6 +8,8 @@ #include +#include "import/nitf.h" + namespace nitf { namespace Test diff --git a/Test/nitf_test_create.cpp b/Test/nitf_test_create.cpp index 93b4a8e1b..f794fe585 100644 --- a/Test/nitf_test_create.cpp +++ b/Test/nitf_test_create.cpp @@ -2,5 +2,12 @@ #include "nitf_Test.h" -#define TEST_CASE(X) TEST(nitf_test_create, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_create) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_create.c" + +}; \ No newline at end of file diff --git a/Test/nitf_test_create_nitf.cpp b/Test/nitf_test_create_nitf.cpp index 8a65bf06b..8fdf17ce8 100644 --- a/Test/nitf_test_create_nitf.cpp +++ b/Test/nitf_test_create_nitf.cpp @@ -3,10 +3,18 @@ #include "nitf_Test.h" #define TEST_NAME nitf_test_create_nitf -#define TEST_CASE(X) TEST(TEST_NAME, X) - int argc = 1; const char* argv[] = { "nitf_test_create_nitf" }; -#define TEST_CASE_ARGS(X) TEST(TEST_NAME, X) +#include "nitf/unittests/nitro_image_.c_" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_create_nitf) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) +#define TEST_CASE_ARGS(X) TEST_METHOD(X) #include "nitf/unittests/test_create_nitf.c" + +}; \ No newline at end of file diff --git a/Test/nitf_test_field.cpp b/Test/nitf_test_field.cpp index a65438a1c..70fecd6e6 100644 --- a/Test/nitf_test_field.cpp +++ b/Test/nitf_test_field.cpp @@ -2,6 +2,12 @@ #include "nitf_Test.h" -#define TEST_CASE(X) TEST(nitf_test_field, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_field) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_field.c" +}; \ No newline at end of file diff --git a/Test/nitf_test_geo_utils.cpp b/Test/nitf_test_geo_utils.cpp index f7e9e6672..e30ba258d 100644 --- a/Test/nitf_test_geo_utils.cpp +++ b/Test/nitf_test_geo_utils.cpp @@ -2,6 +2,12 @@ #include "nitf_Test.h" -#define TEST_CASE(X) TEST(nitf_test_geo_utils, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_geo_utils) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_geo_utils.c" +}; \ No newline at end of file diff --git a/Test/nitf_test_image_io.cpp b/Test/nitf_test_image_io.cpp index 3f3277845..097defccb 100644 --- a/Test/nitf_test_image_io.cpp +++ b/Test/nitf_test_image_io.cpp @@ -1,11 +1,13 @@ #include "pch.h" -#include -#include -#undef interface - #include "nitf_Test.h" -#define TEST_CASE(X) TEST(nitf_test_image_io, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_image_io) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_image_io.c" +}; \ No newline at end of file diff --git a/Test/nitf_test_mem_source.cpp b/Test/nitf_test_mem_source.cpp index 34847e778..341cccbac 100644 --- a/Test/nitf_test_mem_source.cpp +++ b/Test/nitf_test_mem_source.cpp @@ -2,5 +2,12 @@ #include "nitf_Test.h" -#define TEST_CASE(X) TEST(nitf_test_mem_source, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_mem_source) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_mem_source.c" + +}; \ No newline at end of file diff --git a/Test/nitf_test_tre_mods.cpp b/Test/nitf_test_tre_mods.cpp index 167a0aece..072abac48 100644 --- a/Test/nitf_test_tre_mods.cpp +++ b/Test/nitf_test_tre_mods.cpp @@ -46,9 +46,9 @@ static fs::path buildDir(const fs::path& path) const sys::OS os; const auto exec = fs::path(os.getCurrentExecutable()); const auto argv0 = exec.filename(); - if (argv0 == "Test.exe") + if (argv0 == "testhost.exe") { - // Running GTest unit-tests in Visual Studio on Windows + // Running Visual Studio unit-tests on Windows if (is_x64_Configuration(cwd)) { return cwd / path; @@ -101,33 +101,23 @@ static fs::path buildPluginsDir() return buildDir(fs::path("share") / "nitf" / "plugins"); } -struct nitf_test_tre_mods : public ::testing::Test { - nitf_test_tre_mods() { - // initialization code here - //const std::string NITF_PLUGIN_PATH = R"(C:\Users\jdsmith\source\repos\nitro\x64\Debug\share\nitf\plugins)"; - const std::string putenv_ = "NITF_PLUGIN_PATH=" + buildPluginsDir().string(); - _putenv(putenv_.c_str()); - } - - void SetUp() { - // code here will execute just before the test ensues - } - - void TearDown() { - // code here will be called just after the test completes - // ok to through exceptions from here if need be - } +using namespace Microsoft::VisualStudio::CppUnitTestFramework; - ~nitf_test_tre_mods() { - // cleanup any pending stuff, but no exceptions allowed - } +TEST_CLASS(nitf_test_tre_mods) { +public: + nitf_test_tre_mods() + { + // initialization code here + //const std::string NITF_PLUGIN_PATH = R"(C:\Users\jdsmith\source\repos\nitro\x64\Debug\share\nitf\plugins)"; + const std::string putenv_ = "NITF_PLUGIN_PATH=" + buildPluginsDir().string(); + _putenv(putenv_.c_str()); + } + ~nitf_test_tre_mods() = default; nitf_test_tre_mods(const nitf_test_tre_mods&) = delete; nitf_test_tre_mods& operator=(const nitf_test_tre_mods&) = delete; - - // put in any custom data members that you need -}; - -#define TEST_CASE(X) TEST_F(nitf_test_tre_mods, X) +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_tre_mods.c" + +}; \ No newline at end of file diff --git a/UnitTest/nitf_test_tre_read.cpp b/Test/nitf_test_tre_read.cpp similarity index 100% rename from UnitTest/nitf_test_tre_read.cpp rename to Test/nitf_test_tre_read.cpp diff --git a/Test/nitf_test_zero_field.cpp b/Test/nitf_test_zero_field.cpp index 0d0cf4852..adda886ae 100644 --- a/Test/nitf_test_zero_field.cpp +++ b/Test/nitf_test_zero_field.cpp @@ -2,5 +2,12 @@ #include "nitf_Test.h" -#define TEST_CASE(X) TEST(nitf_test_zero_field, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_zero_field) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_zero_field.c" + +}; \ No newline at end of file diff --git a/Test/nrt_Test.h b/Test/nrt_Test.h index 576ef9e17..7f0d7a36f 100644 --- a/Test/nrt_Test.h +++ b/Test/nrt_Test.h @@ -1,6 +1,6 @@ #pragma once -#if defined(GTEST_API_) +#if defined(MS_CPP_UNITTESTFRAMEWORK) #define __TEST_H__ // #include "../nrt/unittests/Test.h" #endif #include "Test.h" diff --git a/Test/nrt_test_buffer_adapter.cpp b/Test/nrt_test_buffer_adapter.cpp index e250573fb..79b5af6f3 100644 --- a/Test/nrt_test_buffer_adapter.cpp +++ b/Test/nrt_test_buffer_adapter.cpp @@ -2,5 +2,12 @@ #include "nrt_Test.h" -#define TEST_CASE(X) TEST(nrt_test_buffer_adapter, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nrt_test_buffer_adapter) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nrt/unittests/test_buffer_adapter.c" + +}; \ No newline at end of file diff --git a/Test/nrt_test_core_values.cpp b/Test/nrt_test_core_values.cpp index 8fc1d84c7..8e1b96416 100644 --- a/Test/nrt_test_core_values.cpp +++ b/Test/nrt_test_core_values.cpp @@ -2,5 +2,12 @@ #include "nrt_Test.h" -#define TEST_CASE(X) TEST(nrt_test_core_values, X) -#include "nrt/unittests/test_core_values.c" \ No newline at end of file +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nrt_test_core_values) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nrt/unittests/test_core_values.c" + +}; \ No newline at end of file diff --git a/Test/nrt_test_list.cpp b/Test/nrt_test_list.cpp index 5371286fc..45ddc75ff 100644 --- a/Test/nrt_test_list.cpp +++ b/Test/nrt_test_list.cpp @@ -2,5 +2,12 @@ #include "nrt_Test.h" -#define TEST_CASE(X) TEST(nrt_test_list, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nrt_test_list) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nrt/unittests/test_list.c" + +}; \ No newline at end of file diff --git a/Test/nrt_test_nrt_byte_swap.cpp b/Test/nrt_test_nrt_byte_swap.cpp index 88db5c0c6..c863cf98f 100644 --- a/Test/nrt_test_nrt_byte_swap.cpp +++ b/Test/nrt_test_nrt_byte_swap.cpp @@ -2,5 +2,12 @@ #include "nrt_Test.h" -#define TEST_CASE(X) TEST(nrt_test_nrt_byte_swap, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nrt_test_nrt_byte_swap) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nrt/unittests/test_nrt_byte_swap.c" + +}; diff --git a/Test/nrt_test_nrt_datetime.cpp b/Test/nrt_test_nrt_datetime.cpp index 1bbd0cbbb..59e0f3faa 100644 --- a/Test/nrt_test_nrt_datetime.cpp +++ b/Test/nrt_test_nrt_datetime.cpp @@ -2,5 +2,12 @@ #include "nrt_Test.h" -#define TEST_CASE(X) TEST(nrt_test_nrt_datetime, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nrt_test_nrt_datetime) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nrt/unittests/test_nrt_datetime.c" + +}; diff --git a/Test/nrt_test_tree.cpp b/Test/nrt_test_tree.cpp index b2ac175e6..0d1c83100 100644 --- a/Test/nrt_test_tree.cpp +++ b/Test/nrt_test_tree.cpp @@ -2,6 +2,13 @@ #include "nrt_Test.h" +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + const char* testName = "testTree"; -#define TEST_CASE(X) TEST(nrt_test_tree, X) +TEST_CLASS(nrt_test_tree) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nrt/unittests/test_tree.c" + +}; \ No newline at end of file diff --git a/Test/nrt_test_utils.cpp b/Test/nrt_test_utils.cpp index 4c1b832ed..4ca3e39fc 100644 --- a/Test/nrt_test_utils.cpp +++ b/Test/nrt_test_utils.cpp @@ -2,5 +2,12 @@ #include "nrt_Test.h" -#define TEST_CASE(X) TEST(nrt_test_utils, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nrt_test_utils) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nrt/unittests/test_utils.c" + +}; \ No newline at end of file diff --git a/Test/packages.config b/Test/packages.config deleted file mode 100644 index 34505441d..000000000 --- a/Test/packages.config +++ /dev/null @@ -1,4 +0,0 @@ - - - - \ No newline at end of file diff --git a/Test/pch.cpp b/Test/pch.cpp index 97b544ec1..64b7eef6d 100644 --- a/Test/pch.cpp +++ b/Test/pch.cpp @@ -1,6 +1,5 @@ -// -// pch.cpp -// Include the standard header and generate the precompiled header. -// +// pch.cpp: source file corresponding to the pre-compiled header #include "pch.h" + +// When you are using pre-compiled headers, this source file is necessary for compilation to succeed. diff --git a/Test/pch.h b/Test/pch.h index 55be39546..fb05af902 100644 --- a/Test/pch.h +++ b/Test/pch.h @@ -1,7 +1,11 @@ -// -// pch.h -// Header for standard system include files. -// +// pch.h: This is a precompiled header file. +// Files listed below are compiled only once, improving build performance for future builds. +// This also affects IntelliSense performance, including code completion and many code browsing features. +// However, files listed here are ALL re-compiled if any one of them is updated between builds. +// Do not add files here that you will be updating frequently as this negates the performance advantage. + +#ifndef PCH_H +#define PCH_H #pragma once #pragma warning(disable: 4820) // '...': '...' bytes padding added after data member '...' @@ -33,20 +37,14 @@ #pragma warning(pop) #pragma warning(push) -#pragma warning(disable: 4388) // '...': signed / unsigned mismatch -#pragma warning(disable: 4389) // '...': signed / unsigned mismatch -#pragma warning(disable: 4800) // Implicit conversion from '...' to bool. Possible information loss -#pragma warning(disable: 4625) // '...': copy constructor was implicitly defined as deleted -#pragma warning(disable: 4626) // '...': assignment operator was implicitly defined as deleted -#pragma warning(disable: 5026) // '...': move constructor was implicitly defined as deleted -#pragma warning(disable: 5027) // '...': move assignment operator was implicitly defined as deleted -#include "gtest/gtest.h" +#include "CppUnitTest.h" #pragma warning(pop) #include +#include #include #include "nitf_Test.h" #include "Test.h" - +#endif //PCH_H diff --git a/UnitTest/Test.h b/UnitTest/Test.h deleted file mode 100644 index 760edec79..000000000 --- a/UnitTest/Test.h +++ /dev/null @@ -1,43 +0,0 @@ -#pragma once - -#include "CppUnitTest.h" - -#define TEST_ASSERT(X) Assert::IsTrue(X) - -template -inline void test_assert_eq_(const T& t, const U& u) -{ - Assert::AreEqual(t, u); -} -#define TEST_ASSERT_EQ(X1, X2) { test_assert_eq_(X1, X2); test_assert_eq_(X2, X1); } -#define TEST_ASSERT_EQ_INT(X1, X2) TEST_ASSERT_EQ(X2, X1) -template -inline void test_assert_str_eq_(const T& t, const U& u) -{ - Assert::AreEqual(t, u); -} -#define TEST_ASSERT_EQ_STR(X1, X2) { test_assert_str_eq_(X1, X2); test_assert_str_eq_(X2, X1); } -#define TEST_ASSERT_EQ_FLOAT(X1, X2) Assert::AreEqual(static_cast(X1), static_cast(X2)) - -#define TEST_ASSERT_NULL(X) Assert::IsNull((X)) -#define TEST_ASSERT_TRUE(X) Assert::IsTrue((X)) -#define TEST_ASSERT_FALSE(X) Assert::IsFalse((X)) - -template -inline void test_assert_not_eq_(const T& t, const U& u) -{ - Assert::AreNotEqual(t, u); -} -#define TEST_ASSERT_NOT_EQ(X1, X2) { test_assert_not_eq_(X1, X2); test_assert_not_eq_(X2, X1);} - -#define TEST_ASSERT_GREATER(X1, X2) EXPECT_GT(X1, X2) - -#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) Assert:AreEqual(X1, X2, EPS) -#define TEST_ASSERT_ALMOST_EQ(X1, X2) TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, 0.0001) - -#define TEST_ASSERT_EQ_MSG(msg, X1, X2) SCOPED_TRACE(msg); TEST_ASSERT_EQ(X1, X2) - -#define TEST_EXCEPTION(X) EXPECT_ANY_THROW((X)) -#define TEST_THROWS(X) EXPECT_ANY_THROW((X)) - -#define TEST_MAIN(X) diff --git a/UnitTest/TestCase.h b/UnitTest/TestCase.h deleted file mode 100644 index c9583fa66..000000000 --- a/UnitTest/TestCase.h +++ /dev/null @@ -1,2 +0,0 @@ -#pragma once -#include "Test.h" diff --git a/UnitTest/UnitTest.vcxproj b/UnitTest/UnitTest.vcxproj deleted file mode 100644 index e064b0a78..000000000 --- a/UnitTest/UnitTest.vcxproj +++ /dev/null @@ -1,162 +0,0 @@ - - - - - Debug - x64 - - - Release - x64 - - - - 17.0 - {F89191ED-2AC9-472E-A869-F68F8AEFA708} - Win32Proj - UnitTest - 10.0 - NativeUnitTestProject - - - - DynamicLibrary - true - v143 - Unicode - false - - - DynamicLibrary - false - v143 - true - Unicode - false - - - - - - - - - - - - - - - true - - - false - - - - Use - Level3 - true - $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) - _DEBUG;%(PreprocessorDefinitions) - true - pch.h - - - Windows - $(VCInstallDir)UnitTest\lib;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) - - - - - Use - Level3 - true - true - true - $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) - NDEBUG;%(PreprocessorDefinitions) - true - pch.h - - - Windows - true - true - $(VCInstallDir)UnitTest\lib;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) - - - - - - - - - - - - - - - - - - - Create - Create - - - - - - - - - - - - - - {8f357a19-799e-4971-850e-3f28485c130b} - - - {f06550ad-cfc7-40b8-8727-6c82c69a8982} - - - {53f9f908-c678-4dee-9309-e71c1d03a45f} - - - {730b1e6e-2469-4f9e-b093-d0c6262453c9} - - - {51d7b426-899e-428d-9f69-5ddac9e403fb} - - - {12aa0752-4ee3-4e0a-85af-0e5deadbf343} - - - {023de06d-3967-4406-b1b8-032118bb2552} - - - {53f9f908-c678-4dee-9309-e71c1e03a45f} - - - {d749aa73-4c9a-473d-96bb-070a6d9caa54} - - - {d1d7fcd3-6130-4504-9da0-9d80506be55e} - - - {2baaaca9-a5a4-412c-ae52-b16c2d107f55} - - - {cf5b4f02-364d-4117-9fb9-6c9c7938e412} - - - {78849481-d356-4cc7-b182-31c21f857ed1} - - - - - - \ No newline at end of file diff --git a/UnitTest/j2k_Test.h b/UnitTest/j2k_Test.h deleted file mode 100644 index 23af9b6d4..000000000 --- a/UnitTest/j2k_Test.h +++ /dev/null @@ -1,6 +0,0 @@ -#pragma once - -#if defined(GTEST_API_) -#define __TEST_H__ // #include "../j2k/unittests/Test.h" -#endif -#include "Test.h" diff --git a/UnitTest/nitf_Test.h b/UnitTest/nitf_Test.h deleted file mode 100644 index db18ff558..000000000 --- a/UnitTest/nitf_Test.h +++ /dev/null @@ -1,19 +0,0 @@ -#pragma once - -#if defined(MS_CPP_UNITTESTFRAMEWORK) -#define __TEST_H__ // #include "../nitf/unittests/Test.h" -#define __TEST_CASE_H__ // #include "../nitf/unittests/TestCase.h" -#endif -#include "Test.h" - -#include - -#include "import/nitf.h" - -namespace nitf -{ - namespace Test - { - std::string buildPluginsDir(); - } -} \ No newline at end of file diff --git a/UnitTest/nitf_test_create.cpp b/UnitTest/nitf_test_create.cpp deleted file mode 100644 index f794fe585..000000000 --- a/UnitTest/nitf_test_create.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_create) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_create.c" - -}; \ No newline at end of file diff --git a/UnitTest/nitf_test_create_nitf.cpp b/UnitTest/nitf_test_create_nitf.cpp deleted file mode 100644 index 8fdf17ce8..000000000 --- a/UnitTest/nitf_test_create_nitf.cpp +++ /dev/null @@ -1,20 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -#define TEST_NAME nitf_test_create_nitf -int argc = 1; -const char* argv[] = { "nitf_test_create_nitf" }; - -#include "nitf/unittests/nitro_image_.c_" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_create_nitf) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#define TEST_CASE_ARGS(X) TEST_METHOD(X) -#include "nitf/unittests/test_create_nitf.c" - -}; \ No newline at end of file diff --git a/UnitTest/nitf_test_field.cpp b/UnitTest/nitf_test_field.cpp deleted file mode 100644 index 70fecd6e6..000000000 --- a/UnitTest/nitf_test_field.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_field) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_field.c" - -}; \ No newline at end of file diff --git a/UnitTest/nitf_test_geo_utils.cpp b/UnitTest/nitf_test_geo_utils.cpp deleted file mode 100644 index e30ba258d..000000000 --- a/UnitTest/nitf_test_geo_utils.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_geo_utils) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_geo_utils.c" - -}; \ No newline at end of file diff --git a/UnitTest/nitf_test_image_io.cpp b/UnitTest/nitf_test_image_io.cpp deleted file mode 100644 index 097defccb..000000000 --- a/UnitTest/nitf_test_image_io.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_image_io) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_image_io.c" - -}; \ No newline at end of file diff --git a/UnitTest/nitf_test_mem_source.cpp b/UnitTest/nitf_test_mem_source.cpp deleted file mode 100644 index 341cccbac..000000000 --- a/UnitTest/nitf_test_mem_source.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_mem_source) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_mem_source.c" - -}; \ No newline at end of file diff --git a/UnitTest/nitf_test_tre_mods.cpp b/UnitTest/nitf_test_tre_mods.cpp deleted file mode 100644 index 072abac48..000000000 --- a/UnitTest/nitf_test_tre_mods.cpp +++ /dev/null @@ -1,123 +0,0 @@ -#include "pch.h" - -#include - -#include -#include - -#include "nitf_Test.h" - -namespace fs = std::filesystem; - -static bool is_x64_Configuration(const fs::path& path) // "Configuration" is typically "Debug" or "Release" -{ - const std::string build_configuration = -#if defined(NDEBUG) // i.e., release - "Release"; -#else - "Debug"; -#endif - - const auto Configuration = path.filename(); - const auto path_parent_path = path.parent_path(); - const auto x64 = path_parent_path.filename(); - return (Configuration == build_configuration) && (x64 == "x64"); -} - -static bool is_install_unittests(const fs::path& path) -{ - const auto unittests = path.filename(); - const auto path_parent_path = path.parent_path(); - const auto install = path_parent_path.filename(); - return (unittests == "unittests") && (install == "install"); -} -static bool is_install_tests(const fs::path& path) -{ - const auto tests = path.filename(); - const auto path_parent_path = path.parent_path(); - const auto install = path_parent_path.filename(); - return (tests == "tests") && (install == "install"); -} - -static fs::path buildDir(const fs::path& path) -{ - const auto cwd = fs::current_path(); - - const sys::OS os; - const auto exec = fs::path(os.getCurrentExecutable()); - const auto argv0 = exec.filename(); - if (argv0 == "testhost.exe") - { - // Running Visual Studio unit-tests on Windows - if (is_x64_Configuration(cwd)) - { - return cwd / path; - } - } - - if (argv0 == "unittests.exe") - { - // stand-alone unittest executable on Windows (ends in .EXE) - const auto parent_path = exec.parent_path(); - if (is_x64_Configuration(parent_path)) - { - const auto parent_path_ = parent_path.parent_path().parent_path(); - return parent_path_ / "dev" / "tests" / "images"; - } - } - - // stand-alone unit-test on Linux - const auto exec_dir = exec.parent_path(); - if (is_install_unittests(exec_dir)) - { - const auto install = exec_dir.parent_path(); - return install / "unittests" / "data"; - } - if (is_install_tests(exec_dir)) - { - const auto install = exec_dir.parent_path(); - return install / "unittests" / "data"; - } - - if (argv0 == "unittests") - { - // stand-alone unittest executable on Linux - const auto bin = exec.parent_path(); - if (bin.filename() == "bin") - { - const auto unittests = bin.parent_path(); - return unittests / "unittests" / "data"; - } - } - - //fprintf(stderr, "cwd = %s\n", cwd.c_str()); - //fprintf(stderr, "exec = %s\n", exec.c_str()); - - return cwd; -} - -static fs::path buildPluginsDir() -{ - return buildDir(fs::path("share") / "nitf" / "plugins"); -} - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_tre_mods) { -public: - nitf_test_tre_mods() - { - // initialization code here - //const std::string NITF_PLUGIN_PATH = R"(C:\Users\jdsmith\source\repos\nitro\x64\Debug\share\nitf\plugins)"; - const std::string putenv_ = "NITF_PLUGIN_PATH=" + buildPluginsDir().string(); - _putenv(putenv_.c_str()); - } - - ~nitf_test_tre_mods() = default; - nitf_test_tre_mods(const nitf_test_tre_mods&) = delete; - nitf_test_tre_mods& operator=(const nitf_test_tre_mods&) = delete; - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_tre_mods.c" - -}; \ No newline at end of file diff --git a/UnitTest/nitf_test_zero_field.cpp b/UnitTest/nitf_test_zero_field.cpp deleted file mode 100644 index adda886ae..000000000 --- a/UnitTest/nitf_test_zero_field.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_zero_field) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_zero_field.c" - -}; \ No newline at end of file diff --git a/UnitTest/nrt_Test.h b/UnitTest/nrt_Test.h deleted file mode 100644 index 7f0d7a36f..000000000 --- a/UnitTest/nrt_Test.h +++ /dev/null @@ -1,6 +0,0 @@ -#pragma once - -#if defined(MS_CPP_UNITTESTFRAMEWORK) -#define __TEST_H__ // #include "../nrt/unittests/Test.h" -#endif -#include "Test.h" diff --git a/UnitTest/nrt_test_buffer_adapter.cpp b/UnitTest/nrt_test_buffer_adapter.cpp deleted file mode 100644 index 79b5af6f3..000000000 --- a/UnitTest/nrt_test_buffer_adapter.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nrt_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nrt_test_buffer_adapter) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nrt/unittests/test_buffer_adapter.c" - -}; \ No newline at end of file diff --git a/UnitTest/nrt_test_core_values.cpp b/UnitTest/nrt_test_core_values.cpp deleted file mode 100644 index 8e1b96416..000000000 --- a/UnitTest/nrt_test_core_values.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nrt_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nrt_test_core_values) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nrt/unittests/test_core_values.c" - -}; \ No newline at end of file diff --git a/UnitTest/nrt_test_list.cpp b/UnitTest/nrt_test_list.cpp deleted file mode 100644 index 45ddc75ff..000000000 --- a/UnitTest/nrt_test_list.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nrt_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nrt_test_list) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nrt/unittests/test_list.c" - -}; \ No newline at end of file diff --git a/UnitTest/nrt_test_nrt_byte_swap.cpp b/UnitTest/nrt_test_nrt_byte_swap.cpp deleted file mode 100644 index c863cf98f..000000000 --- a/UnitTest/nrt_test_nrt_byte_swap.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nrt_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nrt_test_nrt_byte_swap) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nrt/unittests/test_nrt_byte_swap.c" - -}; diff --git a/UnitTest/nrt_test_nrt_datetime.cpp b/UnitTest/nrt_test_nrt_datetime.cpp deleted file mode 100644 index 59e0f3faa..000000000 --- a/UnitTest/nrt_test_nrt_datetime.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nrt_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nrt_test_nrt_datetime) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nrt/unittests/test_nrt_datetime.c" - -}; diff --git a/UnitTest/nrt_test_tree.cpp b/UnitTest/nrt_test_tree.cpp deleted file mode 100644 index 0d1c83100..000000000 --- a/UnitTest/nrt_test_tree.cpp +++ /dev/null @@ -1,14 +0,0 @@ -#include "pch.h" - -#include "nrt_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -const char* testName = "testTree"; -TEST_CLASS(nrt_test_tree) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nrt/unittests/test_tree.c" - -}; \ No newline at end of file diff --git a/UnitTest/nrt_test_utils.cpp b/UnitTest/nrt_test_utils.cpp deleted file mode 100644 index 4ca3e39fc..000000000 --- a/UnitTest/nrt_test_utils.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nrt_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nrt_test_utils) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nrt/unittests/test_utils.c" - -}; \ No newline at end of file diff --git a/UnitTest/pch.cpp b/UnitTest/pch.cpp deleted file mode 100644 index 64b7eef6d..000000000 --- a/UnitTest/pch.cpp +++ /dev/null @@ -1,5 +0,0 @@ -// pch.cpp: source file corresponding to the pre-compiled header - -#include "pch.h" - -// When you are using pre-compiled headers, this source file is necessary for compilation to succeed. diff --git a/UnitTest/pch.h b/UnitTest/pch.h deleted file mode 100644 index fb05af902..000000000 --- a/UnitTest/pch.h +++ /dev/null @@ -1,50 +0,0 @@ -// pch.h: This is a precompiled header file. -// Files listed below are compiled only once, improving build performance for future builds. -// This also affects IntelliSense performance, including code completion and many code browsing features. -// However, files listed here are ALL re-compiled if any one of them is updated between builds. -// Do not add files here that you will be updating frequently as this negates the performance advantage. - -#ifndef PCH_H -#define PCH_H -#pragma once - -#pragma warning(disable: 4820) // '...': '...' bytes padding added after data member '...' -#pragma warning(disable: 4710) // '...': function not inlined -#pragma warning(disable: 5045) // Compiler will insert Spectre mitigation for memory load if / Qspectre switch specified -#pragma warning(disable: 4668) // '...' is not defined as a preprocessor macro, replacing with '...' for '...' -// TODO: get rid of these someday? -#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to 'extern "C"' function under -EHc. Undefined behavior may occur if this function throws an exception. -#pragma warning(disable: 4514) // '...': unreferenced inline function has been removed - -#pragma warning(push) -#pragma warning(disable: 4464) // relative include path contains '..' -#include "../modules/c++/cpp.h" -#pragma warning(pop) -#pragma comment(lib, "ws2_32") - -// We're building in Visual Studio ... used to control where we get a little bit of config info -#define NITRO_PCH 1 - -#pragma warning(disable: 5032) // detected #pragma warning(push) with no corresponding #pragma warning(pop) -#pragma warning(push) -#pragma warning(disable: 4464) // relative include path contains '..' -#include -#pragma warning(disable: 5031) // #pragma warning(pop): likely mismatch, popping warning state pushed in different file -#pragma comment(lib, "io-c++") -#pragma comment(lib, "except-c++") -#pragma comment(lib, "sys-c++") -#pragma comment(lib, "str-c++") -#pragma warning(pop) - -#pragma warning(push) -#include "CppUnitTest.h" -#pragma warning(pop) - -#include -#include -#include - -#include "nitf_Test.h" -#include "Test.h" - -#endif //PCH_H diff --git a/nitro.sln b/nitro.sln index 2429e8cf9..ea6e988e3 100644 --- a/nitro.sln +++ b/nitro.sln @@ -44,8 +44,6 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "ENGRDA", "modules\c\nitf\EN EndProject Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "Test++", "Test++\Test++.vcxproj", "{E610F11D-1240-4260-87F8-504B49DB6915}" EndProject -Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "UnitTest", "UnitTest\UnitTest.vcxproj", "{F89191ED-2AC9-472E-A869-F68F8AEFA708}" -EndProject Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "Test", "Test\Test.vcxproj", "{238C9787-B27D-4107-B8FD-1BDB49EA8023}" EndProject Global @@ -114,10 +112,6 @@ Global {E610F11D-1240-4260-87F8-504B49DB6915}.Debug|x64.Build.0 = Debug|x64 {E610F11D-1240-4260-87F8-504B49DB6915}.Release|x64.ActiveCfg = Release|x64 {E610F11D-1240-4260-87F8-504B49DB6915}.Release|x64.Build.0 = Release|x64 - {F89191ED-2AC9-472E-A869-F68F8AEFA708}.Debug|x64.ActiveCfg = Debug|x64 - {F89191ED-2AC9-472E-A869-F68F8AEFA708}.Debug|x64.Build.0 = Debug|x64 - {F89191ED-2AC9-472E-A869-F68F8AEFA708}.Release|x64.ActiveCfg = Release|x64 - {F89191ED-2AC9-472E-A869-F68F8AEFA708}.Release|x64.Build.0 = Release|x64 {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Debug|x64.ActiveCfg = Debug|x64 {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Debug|x64.Build.0 = Debug|x64 {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Release|x64.ActiveCfg = Release|x64 From 7ac6eda7f1875ec5ec8ce45418ea0043f2d5a5ec Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Mon, 14 Mar 2022 18:39:33 -0400 Subject: [PATCH 010/104] start converting Tests++ to VS-test --- UnitTest++/Test.h | 58 ++++++++ UnitTest++/TestCase.h | 2 + UnitTest++/UnitTest++.vcxproj | 148 ++++++++++++++++++++ UnitTest++/UnitTest++.vcxproj.filters | 15 ++ UnitTest++/nitf_Test.h | 19 +++ UnitTest++/nitf_test_field++.cpp | 13 ++ UnitTest++/nrt_Test.h | 6 + UnitTest++/nrt_test_utils.cpp | 13 ++ UnitTest++/pch.cpp | 6 + UnitTest++/pch.h | 52 +++++++ modules/c++/nitf/unittests/test_field++.cpp | 19 ++- nitro.sln | 6 + 12 files changed, 346 insertions(+), 11 deletions(-) create mode 100644 UnitTest++/Test.h create mode 100644 UnitTest++/TestCase.h create mode 100644 UnitTest++/UnitTest++.vcxproj create mode 100644 UnitTest++/UnitTest++.vcxproj.filters create mode 100644 UnitTest++/nitf_Test.h create mode 100644 UnitTest++/nitf_test_field++.cpp create mode 100644 UnitTest++/nrt_Test.h create mode 100644 UnitTest++/nrt_test_utils.cpp create mode 100644 UnitTest++/pch.cpp create mode 100644 UnitTest++/pch.h diff --git a/UnitTest++/Test.h b/UnitTest++/Test.h new file mode 100644 index 000000000..edf088175 --- /dev/null +++ b/UnitTest++/Test.h @@ -0,0 +1,58 @@ +#pragma once + +#include +#include + +#include "CppUnitTest.h" + +#define TEST_ASSERT(X) Assert::IsTrue(X) + +namespace Microsoft{ namespace VisualStudio {namespace CppUnitTestFramework +{ +inline std::wstring ToString(const uint8_t& q) +{ + return std::to_wstring(q); +} +inline std::wstring ToString(const uint16_t& q) +{ + return std::to_wstring(q); +} +}}} + +template +inline void test_assert_eq_(const T& t, const U& u) +{ + Assert::AreEqual(t, u); +} +#define TEST_ASSERT_EQ(X1, X2) { test_assert_eq_(X1, X2); test_assert_eq_(X2, X1); } +#define TEST_ASSERT_EQ_INT(X1, X2) TEST_ASSERT_EQ(X2, X1) +template +inline void test_assert_str_eq_(const T& t, const U& u) +{ + Assert::AreEqual(std::string(t), std::string(u)); +} +#define TEST_ASSERT_EQ_STR(X1, X2) { test_assert_str_eq_(X1, X2); test_assert_str_eq_(X2, X1); } +#define TEST_ASSERT_EQ_FLOAT(X1, X2) Assert::AreEqual(static_cast(X1), static_cast(X2)) + +#define TEST_ASSERT_NULL(X) Assert::IsNull((X)) +#define TEST_ASSERT_TRUE(X) Assert::IsTrue((X)) +#define TEST_ASSERT_FALSE(X) Assert::IsFalse((X)) + +template +inline void test_assert_not_eq_(const T& t, const U& u) +{ + Assert::AreNotEqual(t, u); +} +#define TEST_ASSERT_NOT_EQ(X1, X2) { test_assert_not_eq_(X1, X2); test_assert_not_eq_(X2, X1);} + +#define TEST_ASSERT_GREATER(X1, X2) EXPECT_GT(X1, X2) + +#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) Assert:AreEqual(X1, X2, EPS) +#define TEST_ASSERT_ALMOST_EQ(X1, X2) TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, 0.0001) + +#define TEST_ASSERT_EQ_MSG(msg, X1, X2) SCOPED_TRACE(msg); TEST_ASSERT_EQ(X1, X2) + +#define TEST_EXCEPTION(X) EXPECT_ANY_THROW((X)) +#define TEST_THROWS(X) EXPECT_ANY_THROW((X)) + +#define TEST_MAIN(X) diff --git a/UnitTest++/TestCase.h b/UnitTest++/TestCase.h new file mode 100644 index 000000000..c9583fa66 --- /dev/null +++ b/UnitTest++/TestCase.h @@ -0,0 +1,2 @@ +#pragma once +#include "Test.h" diff --git a/UnitTest++/UnitTest++.vcxproj b/UnitTest++/UnitTest++.vcxproj new file mode 100644 index 000000000..030033d3b --- /dev/null +++ b/UnitTest++/UnitTest++.vcxproj @@ -0,0 +1,148 @@ + + + + + Debug + x64 + + + Release + x64 + + + + 17.0 + {B19FE958-B3A5-4457-9919-F4F81F28CF95} + Win32Proj + UnitTest + 10.0 + NativeUnitTestProject + + + + DynamicLibrary + true + v143 + Unicode + false + + + DynamicLibrary + false + v143 + true + Unicode + false + + + + + + + + + + + + + + + true + + + false + + + + Use + Level3 + true + $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + _DEBUG;%(PreprocessorDefinitions) + true + pch.h + + + Windows + $(VCInstallDir)UnitTest\lib;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) + + + + + Use + Level3 + true + true + true + $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + NDEBUG;%(PreprocessorDefinitions) + true + pch.h + + + Windows + true + true + $(VCInstallDir)UnitTest\lib;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) + + + + + + Create + Create + + + + + + + + + + + + + {8f357a19-799e-4971-850e-3f28485c130b} + + + {f06550ad-cfc7-40b8-8727-6c82c69a8982} + + + {53f9f908-c678-4dee-9309-e71c1d03a45f} + + + {730b1e6e-2469-4f9e-b093-d0c6262453c9} + + + {51d7b426-899e-428d-9f69-5ddac9e403fb} + + + {12aa0752-4ee3-4e0a-85af-0e5deadbf343} + + + {023de06d-3967-4406-b1b8-032118bb2552} + + + {53f9f908-c678-4dee-9309-e71c1e03a45f} + + + {d749aa73-4c9a-473d-96bb-070a6d9caa54} + + + {d1d7fcd3-6130-4504-9da0-9d80506be55e} + + + {2baaaca9-a5a4-412c-ae52-b16c2d107f55} + + + {cf5b4f02-364d-4117-9fb9-6c9c7938e412} + + + {78849481-d356-4cc7-b182-31c21f857ed1} + + + + + + \ No newline at end of file diff --git a/UnitTest++/UnitTest++.vcxproj.filters b/UnitTest++/UnitTest++.vcxproj.filters new file mode 100644 index 000000000..b1177e8a7 --- /dev/null +++ b/UnitTest++/UnitTest++.vcxproj.filters @@ -0,0 +1,15 @@ + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/UnitTest++/nitf_Test.h b/UnitTest++/nitf_Test.h new file mode 100644 index 000000000..db18ff558 --- /dev/null +++ b/UnitTest++/nitf_Test.h @@ -0,0 +1,19 @@ +#pragma once + +#if defined(MS_CPP_UNITTESTFRAMEWORK) +#define __TEST_H__ // #include "../nitf/unittests/Test.h" +#define __TEST_CASE_H__ // #include "../nitf/unittests/TestCase.h" +#endif +#include "Test.h" + +#include + +#include "import/nitf.h" + +namespace nitf +{ + namespace Test + { + std::string buildPluginsDir(); + } +} \ No newline at end of file diff --git a/UnitTest++/nitf_test_field++.cpp b/UnitTest++/nitf_test_field++.cpp new file mode 100644 index 000000000..416032b1c --- /dev/null +++ b/UnitTest++/nitf_test_field++.cpp @@ -0,0 +1,13 @@ +#include "pch.h" + +#include "nitf_Test.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_field__) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nitf/unittests/test_field++.cpp" + +}; \ No newline at end of file diff --git a/UnitTest++/nrt_Test.h b/UnitTest++/nrt_Test.h new file mode 100644 index 000000000..7f0d7a36f --- /dev/null +++ b/UnitTest++/nrt_Test.h @@ -0,0 +1,6 @@ +#pragma once + +#if defined(MS_CPP_UNITTESTFRAMEWORK) +#define __TEST_H__ // #include "../nrt/unittests/Test.h" +#endif +#include "Test.h" diff --git a/UnitTest++/nrt_test_utils.cpp b/UnitTest++/nrt_test_utils.cpp new file mode 100644 index 000000000..4ca3e39fc --- /dev/null +++ b/UnitTest++/nrt_test_utils.cpp @@ -0,0 +1,13 @@ +#include "pch.h" + +#include "nrt_Test.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nrt_test_utils) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nrt/unittests/test_utils.c" + +}; \ No newline at end of file diff --git a/UnitTest++/pch.cpp b/UnitTest++/pch.cpp new file mode 100644 index 000000000..97b544ec1 --- /dev/null +++ b/UnitTest++/pch.cpp @@ -0,0 +1,6 @@ +// +// pch.cpp +// Include the standard header and generate the precompiled header. +// + +#include "pch.h" diff --git a/UnitTest++/pch.h b/UnitTest++/pch.h new file mode 100644 index 000000000..96e057e19 --- /dev/null +++ b/UnitTest++/pch.h @@ -0,0 +1,52 @@ +// pch.h: This is a precompiled header file. +// Files listed below are compiled only once, improving build performance for future builds. +// This also affects IntelliSense performance, including code completion and many code browsing features. +// However, files listed here are ALL re-compiled if any one of them is updated between builds. +// Do not add files here that you will be updating frequently as this negates the performance advantage. + +#ifndef PCH_H +#define PCH_H +#pragma once + +#pragma warning(disable: 4820) // '...': '...' bytes padding added after data member '...' +#pragma warning(disable: 4710) // '...': function not inlined +#pragma warning(disable: 5045) // Compiler will insert Spectre mitigation for memory load if / Qspectre switch specified +#pragma warning(disable: 4668) // '...' is not defined as a preprocessor macro, replacing with '...' for '...' +// TODO: get rid of these someday? +#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to 'extern "C"' function under -EHc. Undefined behavior may occur if this function throws an exception. +#pragma warning(disable: 4514) // '...': unreferenced inline function has been removed + +#pragma warning(push) +#pragma warning(disable: 4464) // relative include path contains '..' +#include "../modules/c++/cpp.h" +#pragma warning(pop) +#pragma comment(lib, "ws2_32") + +// We're building in Visual Studio ... used to control where we get a little bit of config info +#define NITRO_PCH 1 + +#pragma warning(disable: 5032) // detected #pragma warning(push) with no corresponding #pragma warning(pop) +#pragma warning(push) +#pragma warning(disable: 4464) // relative include path contains '..' +#include +#pragma warning(disable: 5031) // #pragma warning(pop): likely mismatch, popping warning state pushed in different file +#pragma comment(lib, "io-c++") +#pragma comment(lib, "except-c++") +#pragma comment(lib, "sys-c++") +#pragma comment(lib, "str-c++") +#pragma warning(pop) + +#pragma warning(push) +#include "CppUnitTest.h" +#pragma warning(pop) + +#include + +#include +#include +#include + +#include "nitf_Test.h" +#include "Test.h" + +#endif //PCH_H diff --git a/modules/c++/nitf/unittests/test_field++.cpp b/modules/c++/nitf/unittests/test_field++.cpp index 8723e94e1..75b903701 100644 --- a/modules/c++/nitf/unittests/test_field++.cpp +++ b/modules/c++/nitf/unittests/test_field++.cpp @@ -25,8 +25,6 @@ #include #include "TestCase.h" -namespace -{ TEST_CASE(testCastOperator) { nitf::Field field(20, nitf::Field::BCS_A); @@ -34,11 +32,11 @@ TEST_CASE(testCastOperator) // Test unsigned values field.set(123); const uint8_t valUint8 = field; - TEST_ASSERT_EQ(valUint8, 123); + TEST_ASSERT_EQ(valUint8, static_cast(123)); field.set(12345); const uint16_t valUint16 = field; - TEST_ASSERT_EQ(valUint16, 12345); + TEST_ASSERT_EQ(valUint16, static_cast(12345)); field.set(1234567890); const uint32_t valUint32 = field; @@ -60,11 +58,11 @@ TEST_CASE(testCastOperator) // Test signed values field.set(-123); const int8_t valInt8 = field; - TEST_ASSERT_EQ(valInt8, -123); + TEST_ASSERT_EQ(valInt8, gsl::narrow(-123)); field.set(-12345); const int16_t valInt16 = field; - TEST_ASSERT_EQ(valInt16, -12345); + TEST_ASSERT_EQ(valInt16, gsl::narrow(-12345)); field.set(-1234567890); const int32_t valInt32 = field; @@ -96,7 +94,7 @@ TEST_CASE(testCastOperator) // Test arbitrary string field.set("ABCxyz"); const std::string valStr = field; - TEST_ASSERT_EQ(valStr, "ABCxyz "); + TEST_ASSERT_EQ(valStr, std::string("ABCxyz ")); } TEST_CASE(testDescriptors) { @@ -104,16 +102,15 @@ TEST_CASE(testDescriptors) test1a.setF1("1234"); const auto descriptors = test1a.getDescriptors(); - TEST_ASSERT_EQ(1, descriptors.size()); + TEST_ASSERT_EQ(gsl::narrow(1), descriptors.size()); for (const auto& descriptor : descriptors) { - TEST_ASSERT_EQ("f1", descriptor.name()); + TEST_ASSERT_EQ(std::string("f1"), descriptor.name()); const auto field = descriptor.getField(test1a); const std::string value = field; // nitf::Field will implicitly cast - TEST_ASSERT_EQ("1234", value); + TEST_ASSERT_EQ(std::string("1234"), value); } } -} TEST_MAIN( (void)argc; diff --git a/nitro.sln b/nitro.sln index ea6e988e3..e235d6de9 100644 --- a/nitro.sln +++ b/nitro.sln @@ -46,6 +46,8 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "Test++", "Test++\Test++.vcx EndProject Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "Test", "Test\Test.vcxproj", "{238C9787-B27D-4107-B8FD-1BDB49EA8023}" EndProject +Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "UnitTest++", "UnitTest++\UnitTest++.vcxproj", "{B19FE958-B3A5-4457-9919-F4F81F28CF95}" +EndProject Global GlobalSection(SolutionConfigurationPlatforms) = preSolution Debug|x64 = Debug|x64 @@ -116,6 +118,10 @@ Global {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Debug|x64.Build.0 = Debug|x64 {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Release|x64.ActiveCfg = Release|x64 {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Release|x64.Build.0 = Release|x64 + {B19FE958-B3A5-4457-9919-F4F81F28CF95}.Debug|x64.ActiveCfg = Debug|x64 + {B19FE958-B3A5-4457-9919-F4F81F28CF95}.Debug|x64.Build.0 = Debug|x64 + {B19FE958-B3A5-4457-9919-F4F81F28CF95}.Release|x64.ActiveCfg = Release|x64 + {B19FE958-B3A5-4457-9919-F4F81F28CF95}.Release|x64.Build.0 = Release|x64 EndGlobalSection GlobalSection(SolutionProperties) = preSolution HideSolutionNode = FALSE From ac622a80385932f417588f0bbf5bb207367e73ef Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Tue, 15 Mar 2022 11:51:48 -0400 Subject: [PATCH 011/104] use universal references to better preserve actual types --- Test/Test.h | 11 +++-------- UnitTest++/Test.h | 11 +++-------- 2 files changed, 6 insertions(+), 16 deletions(-) diff --git a/Test/Test.h b/Test/Test.h index 760edec79..6c0288230 100644 --- a/Test/Test.h +++ b/Test/Test.h @@ -5,19 +5,14 @@ #define TEST_ASSERT(X) Assert::IsTrue(X) template -inline void test_assert_eq_(const T& t, const U& u) +inline void test_assert_eq_(T&& t, U&& u) { Assert::AreEqual(t, u); } #define TEST_ASSERT_EQ(X1, X2) { test_assert_eq_(X1, X2); test_assert_eq_(X2, X1); } #define TEST_ASSERT_EQ_INT(X1, X2) TEST_ASSERT_EQ(X2, X1) -template -inline void test_assert_str_eq_(const T& t, const U& u) -{ - Assert::AreEqual(t, u); -} -#define TEST_ASSERT_EQ_STR(X1, X2) { test_assert_str_eq_(X1, X2); test_assert_str_eq_(X2, X1); } -#define TEST_ASSERT_EQ_FLOAT(X1, X2) Assert::AreEqual(static_cast(X1), static_cast(X2)) +#define TEST_ASSERT_EQ_STR(X1, X2) TEST_ASSERT_EQ(X1, X2) +#define TEST_ASSERT_EQ_FLOAT(X1, X2) TEST_ASSERT_EQ(static_cast(X1), static_cast(X2)) #define TEST_ASSERT_NULL(X) Assert::IsNull((X)) #define TEST_ASSERT_TRUE(X) Assert::IsTrue((X)) diff --git a/UnitTest++/Test.h b/UnitTest++/Test.h index edf088175..77a0cc59d 100644 --- a/UnitTest++/Test.h +++ b/UnitTest++/Test.h @@ -20,19 +20,14 @@ inline std::wstring ToString(const uint16_t& q) }}} template -inline void test_assert_eq_(const T& t, const U& u) +inline void test_assert_eq_(T&& t, U&& u) { Assert::AreEqual(t, u); } #define TEST_ASSERT_EQ(X1, X2) { test_assert_eq_(X1, X2); test_assert_eq_(X2, X1); } #define TEST_ASSERT_EQ_INT(X1, X2) TEST_ASSERT_EQ(X2, X1) -template -inline void test_assert_str_eq_(const T& t, const U& u) -{ - Assert::AreEqual(std::string(t), std::string(u)); -} -#define TEST_ASSERT_EQ_STR(X1, X2) { test_assert_str_eq_(X1, X2); test_assert_str_eq_(X2, X1); } -#define TEST_ASSERT_EQ_FLOAT(X1, X2) Assert::AreEqual(static_cast(X1), static_cast(X2)) +#define TEST_ASSERT_EQ_STR(X1, X2) TEST_ASSERT_EQ(X1, X2) +#define TEST_ASSERT_EQ_FLOAT(X1, X2) TEST_ASSERT_EQ(static_cast(X1), static_cast(X2)) #define TEST_ASSERT_NULL(X) Assert::IsNull((X)) #define TEST_ASSERT_TRUE(X) Assert::IsTrue((X)) From afd267a90b02cb198fa5ec3634e2a5bddcf82035 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Tue, 15 Mar 2022 12:17:19 -0400 Subject: [PATCH 012/104] move another test case to UnitTests++ --- UnitTest++/Test.h | 4 +- UnitTest++/UnitTest++.vcxproj | 295 +++++------ UnitTest++/UnitTest++.vcxproj.filters | 29 +- UnitTest++/nitf_test_create_nitf++.cpp | 30 ++ modules/c++/cpp.h | 1 + .../c++/nitf/unittests/test_create_nitf++.cpp | 459 +++++++++--------- 6 files changed, 422 insertions(+), 396 deletions(-) create mode 100644 UnitTest++/nitf_test_create_nitf++.cpp diff --git a/UnitTest++/Test.h b/UnitTest++/Test.h index 77a0cc59d..f4f327671 100644 --- a/UnitTest++/Test.h +++ b/UnitTest++/Test.h @@ -5,8 +5,6 @@ #include "CppUnitTest.h" -#define TEST_ASSERT(X) Assert::IsTrue(X) - namespace Microsoft{ namespace VisualStudio {namespace CppUnitTestFramework { inline std::wstring ToString(const uint8_t& q) @@ -19,6 +17,8 @@ inline std::wstring ToString(const uint16_t& q) } }}} +#define TEST_ASSERT(X) Assert::IsTrue(X) + template inline void test_assert_eq_(T&& t, U&& u) { diff --git a/UnitTest++/UnitTest++.vcxproj b/UnitTest++/UnitTest++.vcxproj index 030033d3b..4bac7e490 100644 --- a/UnitTest++/UnitTest++.vcxproj +++ b/UnitTest++/UnitTest++.vcxproj @@ -1,148 +1,149 @@ - - - - - Debug - x64 - - - Release - x64 - - - - 17.0 - {B19FE958-B3A5-4457-9919-F4F81F28CF95} - Win32Proj - UnitTest - 10.0 - NativeUnitTestProject - - - - DynamicLibrary - true - v143 - Unicode - false - - - DynamicLibrary - false - v143 - true - Unicode - false - - - - - - - - - - - - - - - true - - - false - - - - Use - Level3 - true - $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) - _DEBUG;%(PreprocessorDefinitions) - true - pch.h - - - Windows - $(VCInstallDir)UnitTest\lib;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) - - - - - Use - Level3 - true - true - true - $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) - NDEBUG;%(PreprocessorDefinitions) - true - pch.h - - - Windows - true - true - $(VCInstallDir)UnitTest\lib;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) - - - - - - Create - Create - - - - - - - - - - - - - {8f357a19-799e-4971-850e-3f28485c130b} - - - {f06550ad-cfc7-40b8-8727-6c82c69a8982} - - - {53f9f908-c678-4dee-9309-e71c1d03a45f} - - - {730b1e6e-2469-4f9e-b093-d0c6262453c9} - - - {51d7b426-899e-428d-9f69-5ddac9e403fb} - - - {12aa0752-4ee3-4e0a-85af-0e5deadbf343} - - - {023de06d-3967-4406-b1b8-032118bb2552} - - - {53f9f908-c678-4dee-9309-e71c1e03a45f} - - - {d749aa73-4c9a-473d-96bb-070a6d9caa54} - - - {d1d7fcd3-6130-4504-9da0-9d80506be55e} - - - {2baaaca9-a5a4-412c-ae52-b16c2d107f55} - - - {cf5b4f02-364d-4117-9fb9-6c9c7938e412} - - - {78849481-d356-4cc7-b182-31c21f857ed1} - - - - - + + + + + Debug + x64 + + + Release + x64 + + + + 17.0 + {B19FE958-B3A5-4457-9919-F4F81F28CF95} + Win32Proj + UnitTest + 10.0 + NativeUnitTestProject + + + + DynamicLibrary + true + v143 + Unicode + false + + + DynamicLibrary + false + v143 + true + Unicode + false + + + + + + + + + + + + + + + true + + + false + + + + Use + Level3 + true + $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + _DEBUG;%(PreprocessorDefinitions) + true + pch.h + + + Windows + $(VCInstallDir)UnitTest\lib;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) + + + + + Use + Level3 + true + true + true + $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + NDEBUG;%(PreprocessorDefinitions) + true + pch.h + + + Windows + true + true + $(VCInstallDir)UnitTest\lib;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) + + + + + + + Create + Create + + + + + + + + + + + + + {8f357a19-799e-4971-850e-3f28485c130b} + + + {f06550ad-cfc7-40b8-8727-6c82c69a8982} + + + {53f9f908-c678-4dee-9309-e71c1d03a45f} + + + {730b1e6e-2469-4f9e-b093-d0c6262453c9} + + + {51d7b426-899e-428d-9f69-5ddac9e403fb} + + + {12aa0752-4ee3-4e0a-85af-0e5deadbf343} + + + {023de06d-3967-4406-b1b8-032118bb2552} + + + {53f9f908-c678-4dee-9309-e71c1e03a45f} + + + {d749aa73-4c9a-473d-96bb-070a6d9caa54} + + + {d1d7fcd3-6130-4504-9da0-9d80506be55e} + + + {2baaaca9-a5a4-412c-ae52-b16c2d107f55} + + + {cf5b4f02-364d-4117-9fb9-6c9c7938e412} + + + {78849481-d356-4cc7-b182-31c21f857ed1} + + + + + \ No newline at end of file diff --git a/UnitTest++/UnitTest++.vcxproj.filters b/UnitTest++/UnitTest++.vcxproj.filters index b1177e8a7..5ef698738 100644 --- a/UnitTest++/UnitTest++.vcxproj.filters +++ b/UnitTest++/UnitTest++.vcxproj.filters @@ -1,15 +1,16 @@ - - - - - - - - - - - - - - + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/UnitTest++/nitf_test_create_nitf++.cpp b/UnitTest++/nitf_test_create_nitf++.cpp new file mode 100644 index 000000000..5ec83aff8 --- /dev/null +++ b/UnitTest++/nitf_test_create_nitf++.cpp @@ -0,0 +1,30 @@ +#include "pch.h" + +#include + +#include "nitf_Test.h" + +CODA_OSS_disable_warning_push +#if _MSC_VER +#pragma warning(disable: 4464) // relative include path contains '..' +#endif +#include +CODA_OSS_disable_warning_pop + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_create_nitf__) { +public: + nitf_test_create_nitf__() { + // initialization code here + //sys::OS().setEnv("NITF_PLUGIN_PATH", nitf::Test::buildPluginsDir(), true /*overwrite*/); + } + + ~nitf_test_create_nitf__() = default; + nitf_test_create_nitf__(const nitf_test_create_nitf__&) = delete; + nitf_test_create_nitf__& operator=(const nitf_test_create_nitf__&) = delete; + + #define TEST_CASE(X) TEST_METHOD(X) + #include "nitf/unittests/test_create_nitf++.cpp" + +}; \ No newline at end of file diff --git a/modules/c++/cpp.h b/modules/c++/cpp.h index 9ba827ff7..d8d94434b 100644 --- a/modules/c++/cpp.h +++ b/modules/c++/cpp.h @@ -38,6 +38,7 @@ #include #include #include +#include #include #include #include diff --git a/modules/c++/nitf/unittests/test_create_nitf++.cpp b/modules/c++/nitf/unittests/test_create_nitf++.cpp index da2b9f76b..3fb2489c8 100644 --- a/modules/c++/nitf/unittests/test_create_nitf++.cpp +++ b/modules/c++/nitf/unittests/test_create_nitf++.cpp @@ -51,7 +51,7 @@ CODA_OSS_disable_warning_pop #include "TestCase.h" -void populateFileHeader(nitf::Record& record, const std::string& title) +static void populateFileHeader(nitf::Record& record, const std::string& title) { /* the file header is already created, so just grab it */ nitf::FileHeader header = record.getHeader(); @@ -61,7 +61,7 @@ void populateFileHeader(nitf::Record& record, const std::string& title) } -void setCornersFromDMSBox(nitf::ImageSubheader& header) +static void setCornersFromDMSBox(nitf::ImageSubheader& header) { /* * You could do this in degrees as easily @@ -102,135 +102,132 @@ void setCornersFromDMSBox(nitf::ImageSubheader& header) header.setCornersFromLatLons(NITF_CORNERS_DECIMAL, corners); } -namespace test_create_nitf_with_byte_provider +static void test_create_nitf_with_byte_provider__addImageSegment(nitf::Record& record, + bool shouldCompress = false) { - void addImageSegment(nitf::Record& record, - bool shouldCompress = false) - { - nitf::ImageSegment segment = record.newImageSegment(); - nitf::ImageSubheader header = segment.getSubheader(); + nitf::ImageSegment segment = record.newImageSegment(); + nitf::ImageSubheader header = segment.getSubheader(); - header.getImageId().set("NITRO-TEST"); - header.getImageDateAndTime().set("20080812000000"); + header.getImageId().set("NITRO-TEST"); + header.getImageDateAndTime().set("20080812000000"); - if (shouldCompress) - { - header.getImageCompression().set("C8"); - } + if (shouldCompress) + { + header.getImageCompression().set("C8"); + } - /* Set the geo-corners to Ann Arbor, MI */ - setCornersFromDMSBox(header); + /* Set the geo-corners to Ann Arbor, MI */ + setCornersFromDMSBox(header); - const size_t NUM_BANDS = 1; - std::vector bands(NUM_BANDS, nitf::BandInfo()); - for (size_t ii = 0; ii < bands.size(); ++ii) - { - bands[ii].init(nitf::Representation::M, /* The band representation, Nth band */ - nitf::Subcategory::None, /* The band subcategory */ - "N", /* The band filter condition */ - " "); /* The band standard image filter code */ + const size_t NUM_BANDS = 1; + std::vector bands(NUM_BANDS, nitf::BandInfo()); + for (size_t ii = 0; ii < bands.size(); ++ii) + { + bands[ii].init(nitf::Representation::M, /* The band representation, Nth band */ + nitf::Subcategory::None, /* The band subcategory */ + "N", /* The band filter condition */ + " "); /* The band standard image filter code */ - } + } - const auto iRep = nitf::ImageRepresentation::MONO; - header.setPixelInformation(nitf::PixelValueType::Integer, /* Pixel value type */ - 8, /* Number of bits/pixel */ - 8, /* Actual number of bits/pixel */ - "R", /* Pixel justification */ - iRep, /* Image representation */ - "VIS", /* Image category */ - bands); /* Band information object list */ + const auto iRep = nitf::ImageRepresentation::MONO; + header.setPixelInformation(nitf::PixelValueType::Integer, /* Pixel value type */ + 8, /* Number of bits/pixel */ + 8, /* Actual number of bits/pixel */ + "R", /* Pixel justification */ + iRep, /* Image representation */ + "VIS", /* Image category */ + bands); /* Band information object list */ /* for fun, let's add a comment */ - header.insertImageComment("NITF generated by NITRO", 0); - - // The image mode P is part of an awful hack to workaround us not - // having a compression plugin for blocking mode P. - // If you run this test, it will throw an error. The error will reference - // a file in the j2k plugin. To make this test run, go to the file - // and disable the check for blocking mode B. - // To the best of my knowledge, nothing bad happens as a result. - header.setBlocking(NITRO_IMAGE.height, /*!< The number of rows */ - NITRO_IMAGE.width, /*!< The number of columns */ - NITRO_IMAGE.height, /*!< The number of rows/block */ - NITRO_IMAGE.width, /*!< The number of columns/block */ - nitf::BlockingMode::Pixel); /*!< Image mode */ - } + header.insertImageComment("NITF generated by NITRO", 0); + + // The image mode P is part of an awful hack to workaround us not + // having a compression plugin for blocking mode P. + // If you run this test, it will throw an error. The error will reference + // a file in the j2k plugin. To make this test run, go to the file + // and disable the check for blocking mode B. + // To the best of my knowledge, nothing bad happens as a result. + header.setBlocking(NITRO_IMAGE.height, /*!< The number of rows */ + NITRO_IMAGE.width, /*!< The number of columns */ + NITRO_IMAGE.height, /*!< The number of rows/block */ + NITRO_IMAGE.width, /*!< The number of columns/block */ + nitf::BlockingMode::Pixel); /*!< Image mode */ +} - void writeNITF(nitf::Record& record, const std::string& filename) +static void test_create_nitf_with_byte_provider__writeNITF(nitf::Record& record, const std::string& filename) +{ + constexpr size_t NUM_BANDS = 1; + /* + * COMPRESSION: + * Right now, this is writing a single-segment single-block uncompressed + * NITF. If you want to compress, you would compress the data here. + * + * bytesPerBlock has an element for each image segment. Each image segment + * element has an element for each block. If you're compressing into a + * single tile, you can simple populate the single element with the + * compressed size of the image. + * + * If you are compressing to multiple tiles (blocks), each tile will have + * a different size, hence the need for a vector. + * Once you have CompressedByteProvider constructed, everything else + * should work the same + */ + std::vector > bytesPerBlock(1); + bytesPerBlock[0].push_back(NITRO_IMAGE.width * NITRO_IMAGE.height * NUM_BANDS); + nitf::CompressedByteProvider byteProvider(record, + bytesPerBlock); + nitf::Off fileOffset; + nitf::NITFBufferList buffers; + byteProvider.getBytes(NITRO_IMAGE.data, 0, NITRO_IMAGE.height, + fileOffset, buffers); + io::FileOutputStream outputStream(filename); + for (size_t ii = 0; ii < buffers.mBuffers.size(); ++ii) { - constexpr size_t NUM_BANDS = 1; - /* - * COMPRESSION: - * Right now, this is writing a single-segment single-block uncompressed - * NITF. If you want to compress, you would compress the data here. - * - * bytesPerBlock has an element for each image segment. Each image segment - * element has an element for each block. If you're compressing into a - * single tile, you can simple populate the single element with the - * compressed size of the image. - * - * If you are compressing to multiple tiles (blocks), each tile will have - * a different size, hence the need for a vector. - * Once you have CompressedByteProvider constructed, everything else - * should work the same - */ - std::vector > bytesPerBlock(1); - bytesPerBlock[0].push_back(NITRO_IMAGE.width * NITRO_IMAGE.height * NUM_BANDS); - nitf::CompressedByteProvider byteProvider(record, - bytesPerBlock); - nitf::Off fileOffset; - nitf::NITFBufferList buffers; - byteProvider.getBytes(NITRO_IMAGE.data, 0, NITRO_IMAGE.height, - fileOffset, buffers); - io::FileOutputStream outputStream(filename); - for (size_t ii = 0; ii < buffers.mBuffers.size(); ++ii) - { - outputStream.write( - static_cast(buffers.mBuffers[ii].mData), - buffers.mBuffers[ii].mNumBytes); - } + outputStream.write( + static_cast(buffers.mBuffers[ii].mData), + buffers.mBuffers[ii].mNumBytes); } +} - void testCreate(const std::string& outname, - bool shouldCompress = false) - { - nitf::Record record; - populateFileHeader(record, outname); - addImageSegment(record, shouldCompress); - writeNITF(record, outname); - } +static void test_create_nitf_with_byte_provider__testCreate(const std::string& outname, + bool shouldCompress = false) +{ + nitf::Record record; + populateFileHeader(record, outname); + test_create_nitf_with_byte_provider__addImageSegment(record, shouldCompress); + test_create_nitf_with_byte_provider__writeNITF(record, outname); +} - bool testRead(const std::string& pathname) - { - constexpr size_t NUM_BANDS = 1; - nitf::IOHandle handle(pathname, NITF_ACCESS_READONLY, NITF_OPEN_EXISTING); - nitf::Reader reader; - nitf::Record record = reader.read(handle); +static bool test_create_nitf_with_byte_provider__testRead(const std::string& pathname) +{ + constexpr size_t NUM_BANDS = 1; + nitf::IOHandle handle(pathname, NITF_ACCESS_READONLY, NITF_OPEN_EXISTING); + nitf::Reader reader; + nitf::Record record = reader.read(handle); - for (int ii = 0; ii < static_cast(record.getNumImages()); ++ii) + for (int ii = 0; ii < static_cast(record.getNumImages()); ++ii) + { + nitf::ImageReader imageReader = reader.newImageReader(ii); + uint64_t blockSize; + // Read one block. It should match the first blockSize points of the + // image. If it does, we got the blocking mode right. + auto block = reinterpret_cast(imageReader.readBlock(0, &blockSize)); + const size_t imageLength = NITRO_IMAGE.width * NITRO_IMAGE.height; + + for (size_t jj = 0; jj < imageLength * NUM_BANDS; ++jj) { - nitf::ImageReader imageReader = reader.newImageReader(ii); - uint64_t blockSize; - // Read one block. It should match the first blockSize points of the - // image. If it does, we got the blocking mode right. - auto block = reinterpret_cast(imageReader.readBlock(0, &blockSize)); - const size_t imageLength = NITRO_IMAGE.width * NITRO_IMAGE.height; - - for (size_t jj = 0; jj < imageLength * NUM_BANDS; ++jj) + if (block[jj] != NITRO_IMAGE.data[jj]) { - if (block[jj] != NITRO_IMAGE.data[jj]) - { - std::cerr << "Image data doesn't match" << std::endl; - return false; - } + std::cerr << "Image data doesn't match" << std::endl; + return false; } } - return true; } + return true; } TEST_CASE(test_create_nitf_with_byte_provider_test) @@ -239,152 +236,148 @@ TEST_CASE(test_create_nitf_with_byte_provider_test) const bool shouldCompress = false; const std::string outname("test_create.nitf"); - test_create_nitf_with_byte_provider::testCreate(outname, shouldCompress); - const auto result = test_create_nitf_with_byte_provider::testRead(outname); + test_create_nitf_with_byte_provider__testCreate(outname, shouldCompress); + const auto result = test_create_nitf_with_byte_provider__testRead(outname); TEST_ASSERT(result); } -namespace test_create_nitf +static void test_create_nitf__addImageSegment(nitf::Record& record, bool isMono = false, + bool shouldCompress = false) { - static const nitf::Representation RGB[] = { nitf::Representation::R, nitf::Representation::G, nitf::Representation::B }; + nitf::ImageSegment segment = record.newImageSegment(); + nitf::ImageSubheader header = segment.getSubheader(); - void addImageSegment(nitf::Record& record, bool isMono = false, - bool shouldCompress = false) + header.getImageId().set("NITRO-TEST"); + header.getImageDateAndTime().set("20080812000000"); + + if (shouldCompress) { - nitf::ImageSegment segment = record.newImageSegment(); - nitf::ImageSubheader header = segment.getSubheader(); + header.getImageCompression().set("C8"); + } - header.getImageId().set("NITRO-TEST"); - header.getImageDateAndTime().set("20080812000000"); + /* Set the geo-corners to Ann Arbor, MI */ + setCornersFromDMSBox(header); - if (shouldCompress) - { - header.getImageCompression().set("C8"); - } + const auto NUM_BANDS = static_cast(isMono ? 1 : 3); + const nitf::Representation RGB[3] = { nitf::Representation::R, nitf::Representation::G, nitf::Representation::B }; + std::vector bands(NUM_BANDS, nitf::BandInfo()); + for (size_t ii = 0; ii < bands.size(); ++ii) + { + bands[ii].init(RGB[ii], /* The band representation, Nth band */ + nitf::Subcategory::None, /* The band subcategory */ + "N", /* The band filter condition */ + " "); /* The band standard image filter code */ - /* Set the geo-corners to Ann Arbor, MI */ - setCornersFromDMSBox(header); + } - const auto NUM_BANDS = static_cast(isMono ? 1 : 3); - std::vector bands(NUM_BANDS, nitf::BandInfo()); - for (size_t ii = 0; ii < bands.size(); ++ii) - { - bands[ii].init(RGB[ii], /* The band representation, Nth band */ - nitf::Subcategory::None, /* The band subcategory */ - "N", /* The band filter condition */ - " "); /* The band standard image filter code */ + const auto iRep = isMono ? nitf::ImageRepresentation::MONO : nitf::ImageRepresentation::RGB; + header.setPixelInformation(nitf::PixelValueType::Integer /*INT*/, /* Pixel value type */ + 8, /* Number of bits/pixel */ + 8, /* Actual number of bits/pixel */ + "R", /* Pixel justification */ + iRep, /* Image representation */ + "VIS", /* Image category */ + bands); /* Band information object list */ - } - const auto iRep = isMono ? nitf::ImageRepresentation::MONO : nitf::ImageRepresentation::RGB; - header.setPixelInformation(nitf::PixelValueType::Integer /*INT*/, /* Pixel value type */ - 8, /* Number of bits/pixel */ - 8, /* Actual number of bits/pixel */ - "R", /* Pixel justification */ - iRep, /* Image representation */ - "VIS", /* Image category */ - bands); /* Band information object list */ +/* for fun, let's add a comment */ + header.insertImageComment("NITF generated by NITRO", 0); + + // The image mode P is part of an awful hack to workaround us not + // having a compression plugin for blocking mode P. + // If you run this test, it will throw an error. The error will reference + // a file in the j2k plugin. To make this test run, go to the file + // and disable the check for blocking mode B. + // To the best of my knowledge, nothing bad happens as a result. + header.setBlocking(NITRO_IMAGE.height, /*!< The number of rows */ + NITRO_IMAGE.width, /*!< The number of columns */ + NITRO_IMAGE.height, /*!< The number of rows/block */ + NITRO_IMAGE.width, /*!< The number of columns/block */ + nitf::BlockingMode::Pixel /* "P" */); /*!< Image mode */ +} -/* for fun, let's add a comment */ - header.insertImageComment("NITF generated by NITRO", 0); - - // The image mode P is part of an awful hack to workaround us not - // having a compression plugin for blocking mode P. - // If you run this test, it will throw an error. The error will reference - // a file in the j2k plugin. To make this test run, go to the file - // and disable the check for blocking mode B. - // To the best of my knowledge, nothing bad happens as a result. - header.setBlocking(NITRO_IMAGE.height, /*!< The number of rows */ - NITRO_IMAGE.width, /*!< The number of columns */ - NITRO_IMAGE.height, /*!< The number of rows/block */ - NITRO_IMAGE.width, /*!< The number of columns/block */ - nitf::BlockingMode::Pixel /* "P" */); /*!< Image mode */ - } +static void test_create_nitf__writeNITF(nitf::Record& record, const std::string& filename, + bool isMono = false) +{ + const int NUM_BANDS = isMono ? 1 : 3; + nitf::IOHandle out(filename, NITF_ACCESS_WRITEONLY, NITF_CREATE); + nitf::Writer writer; + writer.prepare(out, record); + nitf::ImageWriter imageWriter = writer.newImageWriter(0); + nitf::ImageSource imageSource; - void writeNITF(nitf::Record& record, const std::string& filename, - bool isMono = false) + /* make one bandSource per band */ + for (int ii = 0; ii < NUM_BANDS; ++ii) { - const int NUM_BANDS = isMono ? 1 : 3; - nitf::IOHandle out(filename, NITF_ACCESS_WRITEONLY, NITF_CREATE); - nitf::Writer writer; - writer.prepare(out, record); + nitf::BandSource bandSource = nitf::MemorySource( + (char*)NITRO_IMAGE.data, + NITRO_IMAGE.width * NITRO_IMAGE.height, + ii, 1, 2); + imageSource.addBand(bandSource); + } - nitf::ImageWriter imageWriter = writer.newImageWriter(0); - nitf::ImageSource imageSource; + imageWriter.setWriteCaching(1); + imageWriter.attachSource(imageSource); + writer.write(); +} - /* make one bandSource per band */ - for (int ii = 0; ii < NUM_BANDS; ++ii) - { - nitf::BandSource bandSource = nitf::MemorySource( - (char*)NITRO_IMAGE.data, - NITRO_IMAGE.width * NITRO_IMAGE.height, - ii, 1, 2); - imageSource.addBand(bandSource); - } +static void test_create_nitf__testCreate(const std::string& outname, bool isMono = false, + bool shouldCompress = false) +{ + nitf::Record record; + populateFileHeader(record, outname); + test_create_nitf__addImageSegment(record, isMono, shouldCompress); + test_create_nitf__writeNITF(record, outname, isMono); +} - imageWriter.setWriteCaching(1); - imageWriter.attachSource(imageSource); - writer.write(); - } +static bool test_create_nitf__testRead(const std::string& pathname, bool isMono = false, + bool shouldCompress = false) +{ + const int NUM_BANDS = isMono ? 1 : 3; + nitf::IOHandle handle(pathname, NITF_ACCESS_READONLY, NITF_OPEN_EXISTING); + nitf::Reader reader; + nitf::Record record = reader.read(handle); - void testCreate(const std::string& outname, bool isMono = false, - bool shouldCompress = false) + for (int ii = 0; ii < static_cast(record.getNumImages()); ++ii) { - nitf::Record record; - populateFileHeader(record, outname); - addImageSegment(record, isMono, shouldCompress); - writeNITF(record, outname, isMono); - } + nitf::ImageReader imageReader = reader.newImageReader(ii); + uint64_t blockSize; + // Read one block. It should match the first blockSize points of the + // image. If it does, we got the blocking mode right. + auto block = reinterpret_cast(imageReader.readBlock(0, &blockSize)); + const size_t imageLength = NITRO_IMAGE.width * NITRO_IMAGE.height; + + // The image data is interleaved by pixel. When feeding it to the + // writer, we unpack to interleave by block. Now that we're reading + // it back in, we have to interleave by pixel again to compare. + // imageLength is the pixel length of a single band of image data + for (size_t jj = 0; jj < imageLength * NUM_BANDS; ++jj) + { + size_t offset = jj / imageLength; + size_t index = jj % imageLength; - bool testRead(const std::string& pathname, bool isMono = false, - bool shouldCompress = false) - { - const int NUM_BANDS = isMono ? 1 : 3; - nitf::IOHandle handle(pathname, NITF_ACCESS_READONLY, NITF_OPEN_EXISTING); - nitf::Reader reader; - nitf::Record record = reader.read(handle); + // Even though there's only one band, the pixel skip still + // applies during the write + size_t imageIndex = (offset)+(3 * index); - for (int ii = 0; ii < static_cast(record.getNumImages()); ++ii) - { - nitf::ImageReader imageReader = reader.newImageReader(ii); - uint64_t blockSize; - // Read one block. It should match the first blockSize points of the - // image. If it does, we got the blocking mode right. - auto block = reinterpret_cast(imageReader.readBlock(0, &blockSize)); - const size_t imageLength = NITRO_IMAGE.width * NITRO_IMAGE.height; - - // The image data is interleaved by pixel. When feeding it to the - // writer, we unpack to interleave by block. Now that we're reading - // it back in, we have to interleave by pixel again to compare. - // imageLength is the pixel length of a single band of image data - for (size_t jj = 0; jj < imageLength * NUM_BANDS; ++jj) + // For this case, NITRO will have already undone our interleaving + // while writing, so we can ignore the stuff above and just + // compare directly + if (!shouldCompress && !isMono) + { + imageIndex = jj; + } + if (block[jj] != NITRO_IMAGE.data[imageIndex]) { - size_t offset = jj / imageLength; - size_t index = jj % imageLength; - - // Even though there's only one band, the pixel skip still - // applies during the write - size_t imageIndex = (offset)+(3 * index); - - // For this case, NITRO will have already undone our interleaving - // while writing, so we can ignore the stuff above and just - // compare directly - if (!shouldCompress && !isMono) - { - imageIndex = jj; - } - if (block[jj] != NITRO_IMAGE.data[imageIndex]) - { - std::cerr << "Image data doesn't match" << std::endl; - return false; - } + std::cerr << "Image data doesn't match" << std::endl; + return false; } } - return true; } + return true; } TEST_CASE(test_create_nitf_test) @@ -395,13 +388,13 @@ TEST_CASE(test_create_nitf_test) bool shouldCompress = false; bool isMono = true; - test_create_nitf::testCreate(outname, isMono, shouldCompress); - bool result = test_create_nitf::testRead(outname, isMono, shouldCompress); + test_create_nitf__testCreate(outname, isMono, shouldCompress); + bool result = test_create_nitf__testRead(outname, isMono, shouldCompress); TEST_ASSERT(result); isMono = false; - test_create_nitf::testCreate(outname, isMono, shouldCompress); - result = test_create_nitf::testRead(outname, isMono, shouldCompress); + test_create_nitf__testCreate(outname, isMono, shouldCompress); + result = test_create_nitf__testRead(outname, isMono, shouldCompress); TEST_ASSERT(result); // If we're compressing, we're using the J2K plugin, so please ensure @@ -412,13 +405,13 @@ TEST_CASE(test_create_nitf_test) TEST_ASSERT_FALSE(nitf_plugin_path.empty()); shouldCompress = false; // TODO: true - test_create_nitf::testCreate(outname, isMono, shouldCompress); - result = test_create_nitf::testRead(outname, isMono, shouldCompress); + test_create_nitf__testCreate(outname, isMono, shouldCompress); + result = test_create_nitf__testRead(outname, isMono, shouldCompress); TEST_ASSERT(result); isMono = true; - test_create_nitf::testCreate(outname, isMono, shouldCompress); - result = test_create_nitf::testRead(outname, isMono, shouldCompress); + test_create_nitf__testCreate(outname, isMono, shouldCompress); + result = test_create_nitf__testRead(outname, isMono, shouldCompress); TEST_ASSERT(result); } else From 2c5ea366d18f3e0e612f256ab716f8940c4832a4 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Thu, 10 Mar 2022 10:41:07 -0500 Subject: [PATCH 013/104] trying to get new unittest working with CMake --- Test++/Test++.vcxproj | 1 - Test++/nitf_Test.h | 8 +- modules/c++/nitf-c++.vcxproj | 2 + modules/c++/nitf/CMakeLists.txt | 1 + modules/c++/nitf/include/nitf/UnitTests.hpp | 37 +++ .../c++/nitf/source/UnitTests.cpp | 266 ++++++++++-------- modules/c/j2k/CMakeLists.txt | 12 + 7 files changed, 194 insertions(+), 133 deletions(-) create mode 100644 modules/c++/nitf/include/nitf/UnitTests.hpp rename Test++/SetPluginPath.cpp => modules/c++/nitf/source/UnitTests.cpp (68%) diff --git a/Test++/Test++.vcxproj b/Test++/Test++.vcxproj index 097d5c823..70dcafbcb 100644 --- a/Test++/Test++.vcxproj +++ b/Test++/Test++.vcxproj @@ -50,7 +50,6 @@ Create Create - diff --git a/Test++/nitf_Test.h b/Test++/nitf_Test.h index 86f39e272..f67c51ca7 100644 --- a/Test++/nitf_Test.h +++ b/Test++/nitf_Test.h @@ -8,10 +8,4 @@ #include -namespace nitf -{ - namespace Test - { - std::string buildPluginsDir(); - } -} \ No newline at end of file +#include diff --git a/modules/c++/nitf-c++.vcxproj b/modules/c++/nitf-c++.vcxproj index 4a16a4a27..b5b4425b8 100644 --- a/modules/c++/nitf-c++.vcxproj +++ b/modules/c++/nitf-c++.vcxproj @@ -71,6 +71,7 @@ + @@ -151,6 +152,7 @@ + diff --git a/modules/c++/nitf/CMakeLists.txt b/modules/c++/nitf/CMakeLists.txt index c80719c2d..8a43a0e09 100644 --- a/modules/c++/nitf/CMakeLists.txt +++ b/modules/c++/nitf/CMakeLists.txt @@ -69,6 +69,7 @@ coda_add_module( source/TestingTest.cpp source/TextSegment.cpp source/TextSubheader.cpp + source/UnitTests.cpp source/Utils.cpp source/WriteHandler.cpp source/Writer.cpp diff --git a/modules/c++/nitf/include/nitf/UnitTests.hpp b/modules/c++/nitf/include/nitf/UnitTests.hpp new file mode 100644 index 000000000..f942b28c2 --- /dev/null +++ b/modules/c++/nitf/include/nitf/UnitTests.hpp @@ -0,0 +1,37 @@ +/* ========================================================================= + * This file is part of NITRO + * ========================================================================= + * + * (C) Copyright 2022, Maxar Technologies, Inc. + * + * NITRO is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this program; if not, If not, + * see . + * + */ + +#ifndef NITRO_nitf_UnitTests_hpp_INCLUDED_ +#define NITRO_nitf_UnitTests_hpp_INCLUDED_ +#pragma once + +#include + +namespace nitf +{ + namespace Test + { + std::string buildPluginsDir(); + } +} + +#endif // NITRO_nitf_UnitTests_hpp_INCLUDED_ diff --git a/Test++/SetPluginPath.cpp b/modules/c++/nitf/source/UnitTests.cpp similarity index 68% rename from Test++/SetPluginPath.cpp rename to modules/c++/nitf/source/UnitTests.cpp index e6690f4cd..1db912a97 100644 --- a/Test++/SetPluginPath.cpp +++ b/modules/c++/nitf/source/UnitTests.cpp @@ -1,126 +1,142 @@ -#include "pch.h" - -#include - -#include -#include - -#include "nitf_Test.h" - -namespace fs = std::filesystem; - -static std::string Configuration() // "Configuration" is typically "Debug" or "Release" -{ - static const sys::OS os; - return os.getSpecialEnv("Configuration"); -} - -static std::string Platform() -{ - static const sys::OS os; - return os.getSpecialEnv("Platform"); -} - -//// https://stackoverflow.com/questions/13794130/visual-studio-how-to-check-used-c-platform-toolset-programmatically -//static std::string PlatformToolset() -//{ -// // https://docs.microsoft.com/en-us/cpp/build/how-to-modify-the-target-framework-and-platform-toolset?view=msvc-160 -//#if _MSC_FULL_VER >= 190000000 -// return "v142"; -//#else -//#error "Don't know $(PlatformToolset) value.'" -//#endif -//} - -static bool is_x64_Configuration(const fs::path& path) // "Configuration" is typically "Debug" or "Release" -{ - static const std::string build_configuration = Configuration(); - const auto Configuration = path.filename(); - const auto path_parent_path = path.parent_path(); - const auto x64 = path_parent_path.filename(); - return (Configuration == build_configuration) && (x64 == Platform()); -} - -static bool is_install_unittests(const fs::path& path) -{ - const auto unittests = path.filename(); - const auto path_parent_path = path.parent_path(); - const auto install = path_parent_path.filename(); - return (unittests == "unittests") && (install == "install"); -} -static bool is_install_tests(const fs::path& path) -{ - const auto tests = path.filename(); - const auto path_parent_path = path.parent_path(); - const auto install = path_parent_path.filename(); - return (tests == "tests") && (install == "install"); -} - -static fs::path buildDir(const fs::path& path) -{ - const auto cwd = fs::current_path(); - - const sys::OS os; - const auto exec = fs::path(os.getCurrentExecutable()); - const auto argv0 = exec.filename(); - if (argv0 == "Test++.exe") - { - // Running GTest unit-tests in Visual Studio on Windows - if (is_x64_Configuration(cwd)) - { - //const auto root = cwd.parent_path().parent_path(); - //const auto install = "install-" + Configuration() + "-" + Platform() + "." + PlatformToolset(); - //return root / install / path; - return cwd / path; - } - } - - if (argv0 == "unittests.exe") - { - // stand-alone unittest executable on Windows (ends in .EXE) - const auto parent_path = exec.parent_path(); - if (is_x64_Configuration(parent_path)) - { - const auto parent_path_ = parent_path.parent_path().parent_path(); - return parent_path_ / "dev" / "tests" / "images"; - } - } - - // stand-alone unit-test on Linux - const auto exec_dir = exec.parent_path(); - if (is_install_unittests(exec_dir)) - { - const auto install = exec_dir.parent_path(); - return install / "unittests" / "data"; - } - if (is_install_tests(exec_dir)) - { - const auto install = exec_dir.parent_path(); - return install / "unittests" / "data"; - } - - if (argv0 == "unittests") - { - // stand-alone unittest executable on Linux - const auto bin = exec.parent_path(); - if (bin.filename() == "bin") - { - const auto unittests = bin.parent_path(); - return unittests / "unittests" / "data"; - } - } - - //fprintf(stderr, "cwd = %s\n", cwd.c_str()); - //fprintf(stderr, "exec = %s\n", exec.c_str()); - - return cwd; -} - -static fs::path buildPluginsDir() -{ - return buildDir(fs::path("share") / "nitf" / "plugins"); -} -std::string nitf::Test::buildPluginsDir() -{ - return ::buildPluginsDir().string(); +/* ========================================================================= + * This file is part of NITRO + * ========================================================================= + * + * (C) Copyright 2022, Maxar Technologies, Inc. + * + * NITRO is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this program; if not, If not, + * see . + * + */ + +#include "nitf/UnitTests.hpp" + +#include +#include + +namespace fs = std::filesystem; + +static const sys::OS os; +static std::string Configuration() // "Configuration" is typically "Debug" or "Release" +{ + return os.getSpecialEnv("Configuration"); +} +static std::string Platform() +{ + return os.getSpecialEnv("Platform"); +} + +//// https://stackoverflow.com/questions/13794130/visual-studio-how-to-check-used-c-platform-toolset-programmatically +//static std::string PlatformToolset() +//{ +// // https://docs.microsoft.com/en-us/cpp/build/how-to-modify-the-target-framework-and-platform-toolset?view=msvc-160 +//#if _MSC_FULL_VER >= 190000000 +// return "v142"; +//#else +//#error "Don't know $(PlatformToolset) value.'" +//#endif +//} + +static bool is_x64_Configuration(const fs::path& path) // "Configuration" is typically "Debug" or "Release" +{ + static const std::string build_configuration = Configuration(); + const auto Configuration = path.filename(); + const auto path_parent_path = path.parent_path(); + const auto x64 = path_parent_path.filename(); + return (Configuration == build_configuration) && (x64 == Platform()); +} + +static bool is_install_unittests(const fs::path& path) +{ + const auto unittests = path.filename(); + const auto path_parent_path = path.parent_path(); + const auto install = path_parent_path.filename(); + return (unittests == "unittests") && (install == "install"); +} +static bool is_install_tests(const fs::path& path) +{ + const auto tests = path.filename(); + const auto path_parent_path = path.parent_path(); + const auto install = path_parent_path.filename(); + return (tests == "tests") && (install == "install"); +} + +static fs::path buildDir(const fs::path& path) +{ + const auto cwd = fs::current_path(); + + const auto exec = fs::path(os.getCurrentExecutable()); + const auto argv0 = exec.filename(); + if (argv0 == "Test++.exe") + { + // Running GTest unit-tests in Visual Studio on Windows + if (is_x64_Configuration(cwd)) + { + //const auto root = cwd.parent_path().parent_path(); + //const auto install = "install-" + Configuration() + "-" + Platform() + "." + PlatformToolset(); + //return root / install / path; + return cwd / path; + } + } + + if (argv0 == "unittests.exe") + { + // stand-alone unittest executable on Windows (ends in .EXE) + const auto parent_path = exec.parent_path(); + if (is_x64_Configuration(parent_path)) + { + const auto parent_path_ = parent_path.parent_path().parent_path(); + return parent_path_ / "dev" / "tests" / "images"; + } + } + + // stand-alone unit-test on Linux + const auto exec_dir = exec.parent_path(); + if (is_install_unittests(exec_dir)) + { + const auto install = exec_dir.parent_path(); + return install / "unittests" / "data"; + } + if (is_install_tests(exec_dir)) + { + const auto install = exec_dir.parent_path(); + return install / "unittests" / "data"; + } + + if (argv0 == "unittests") + { + // stand-alone unittest executable on Linux + const auto bin = exec.parent_path(); + if (bin.filename() == "bin") + { + const auto unittests = bin.parent_path(); + return unittests / "unittests" / "data"; + } + } + + //fprintf(stderr, "cwd = %s\n", cwd.c_str()); + //fprintf(stderr, "exec = %s\n", exec.c_str()); + + // running a CTest from CMake + const auto nitro_out = cwd.parent_path().parent_path().parent_path().parent_path().parent_path(); + const auto install = nitro_out / "install" / (Platform() + "-" + Configuration()); // e.g., "x64-Debug" + return install / path; + // return cwd; +} + +std::string nitf::Test::buildPluginsDir() +{ + const auto plugins = buildDir(fs::path("share") / "nitf" / "plugins"); + return plugins.string(); } \ No newline at end of file diff --git a/modules/c/j2k/CMakeLists.txt b/modules/c/j2k/CMakeLists.txt index 368ca5e56..728e0e3fa 100644 --- a/modules/c/j2k/CMakeLists.txt +++ b/modules/c/j2k/CMakeLists.txt @@ -37,4 +37,16 @@ coda_add_tests( test_j2k_read_region.c test_j2k_read_tile.c) +# Build all J2KCompress and J2KDecompress +set(j2k_shared_srcs J2KCompress J2KDecompress) +foreach(j2k_shared ${j2k_shared_srcs}) + add_library(${j2k_shared} SHARED shared/${j2k_shared}.c) + target_link_libraries(${j2k_shared} PUBLIC nitf-c) + target_compile_definitions(${j2k_shared} PRIVATE NITF_MODULE_EXPORTS) + # This line is making sure the resultant TRE is named, e.g. + # XML_DATA_CONTENT.so instead of libXML_DATA_CONTENT.so + set_target_properties(${j2k_shared} PROPERTIES PREFIX "") +endforeach() + +install(TARGETS ${j2k_shared_srcs} DESTINATION "share/nitf/plugins") \ No newline at end of file From 738078fa07add5a0b8fc1dd23a4962a994ee28ed Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Tue, 15 Mar 2022 12:19:40 -0400 Subject: [PATCH 014/104] don't need these changes from feature/j2k here --- modules/c/j2k/CMakeLists.txt | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/modules/c/j2k/CMakeLists.txt b/modules/c/j2k/CMakeLists.txt index 728e0e3fa..3e9f2853a 100644 --- a/modules/c/j2k/CMakeLists.txt +++ b/modules/c/j2k/CMakeLists.txt @@ -36,17 +36,3 @@ coda_add_tests( test_j2k_nitf.c test_j2k_read_region.c test_j2k_read_tile.c) - -# Build all J2KCompress and J2KDecompress -set(j2k_shared_srcs J2KCompress J2KDecompress) -foreach(j2k_shared ${j2k_shared_srcs}) - add_library(${j2k_shared} SHARED shared/${j2k_shared}.c) - target_link_libraries(${j2k_shared} PUBLIC nitf-c) - target_compile_definitions(${j2k_shared} PRIVATE NITF_MODULE_EXPORTS) - - # This line is making sure the resultant TRE is named, e.g. - # XML_DATA_CONTENT.so instead of libXML_DATA_CONTENT.so - set_target_properties(${j2k_shared} PROPERTIES PREFIX "") -endforeach() - -install(TARGETS ${j2k_shared_srcs} DESTINATION "share/nitf/plugins") \ No newline at end of file From a7fe154cdcfbc8bf89edaefd53f69ab974d917b8 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Tue, 15 Mar 2022 12:26:15 -0400 Subject: [PATCH 015/104] use buildPluginDir() utility --- UnitTest++/nitf_Test.h | 8 +------- UnitTest++/nitf_test_create_nitf++.cpp | 2 +- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/UnitTest++/nitf_Test.h b/UnitTest++/nitf_Test.h index db18ff558..695150ce7 100644 --- a/UnitTest++/nitf_Test.h +++ b/UnitTest++/nitf_Test.h @@ -10,10 +10,4 @@ #include "import/nitf.h" -namespace nitf -{ - namespace Test - { - std::string buildPluginsDir(); - } -} \ No newline at end of file +#include \ No newline at end of file diff --git a/UnitTest++/nitf_test_create_nitf++.cpp b/UnitTest++/nitf_test_create_nitf++.cpp index 5ec83aff8..e498c6f68 100644 --- a/UnitTest++/nitf_test_create_nitf++.cpp +++ b/UnitTest++/nitf_test_create_nitf++.cpp @@ -17,7 +17,7 @@ TEST_CLASS(nitf_test_create_nitf__) { public: nitf_test_create_nitf__() { // initialization code here - //sys::OS().setEnv("NITF_PLUGIN_PATH", nitf::Test::buildPluginsDir(), true /*overwrite*/); + sys::OS().setEnv("NITF_PLUGIN_PATH", nitf::Test::buildPluginsDir(), true /*overwrite*/); } ~nitf_test_create_nitf__() = default; From ada85184afa5159456d6318e6348d92ec0a66b31 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Tue, 15 Mar 2022 15:07:18 -0400 Subject: [PATCH 016/104] get unit-tests to compile as Visual Studio tests --- Test++/Test.h | 20 +- UnitTest++/Test.h | 32 +-- UnitTest++/UnitTest++.vcxproj | 12 + UnitTest++/UnitTest++.vcxproj.filters | 12 + UnitTest++/nitf_Test.h | 25 +- UnitTest++/nitf_test_hash_table_1++.cpp | 13 + UnitTest++/nitf_test_image_blocker.cpp | 13 + UnitTest++/nitf_test_image_io.cpp | 14 ++ ...est_image_segment_blank_nm_compression.cpp | 13 + .../nitf_test_image_segment_computer.cpp | 13 + UnitTest++/nitf_test_j2k_loading++.cpp | 13 + UnitTest++/nitf_test_j2k_read_tile.cpp | 13 + UnitTest++/nitf_test_nitf_buffer_list.cpp | 13 + UnitTest++/nitf_test_tre_create++.cpp | 22 ++ UnitTest++/nitf_test_tre_mods.cpp | 50 ++++ UnitTest++/nitf_test_tre_read.cpp | 23 ++ UnitTest++/nitf_test_writer_3++.cpp | 23 ++ UnitTest++/pch.h | 9 + modules/c++/cpp.h | 2 + modules/c++/nitf/include/nitf/Enum.hpp | 9 +- modules/c++/nitf/unittests/TestCase.h | 2 + .../nitf/unittests/test_hash_table_1++.cpp | 2 +- .../c++/nitf/unittests/test_image_blocker.cpp | 3 - .../nitf/unittests/test_image_loading++.cpp | 38 ++- ...est_image_segment_blank_nm_compression.cpp | 8 +- .../unittests/test_image_segment_computer.cpp | 3 - .../c++/nitf/unittests/test_image_writer.cpp | 23 +- .../c++/nitf/unittests/test_j2k_loading++.cpp | 25 +- .../c++/nitf/unittests/test_j2k_read_tile.cpp | 4 +- .../c++/nitf/unittests/test_load_plugins.cpp | 46 ++-- .../nitf/unittests/test_nitf_buffer_list.cpp | 3 - .../c++/nitf/unittests/test_tre_create++.cpp | 2 +- .../c++/nitf/unittests/test_tre_mods++.cpp | 228 +++++++++--------- modules/c++/nitf/unittests/test_tre_read.cpp | 37 ++- .../c++/nitf/unittests/test_writer_3++.cpp | 108 ++++----- 35 files changed, 565 insertions(+), 311 deletions(-) create mode 100644 UnitTest++/nitf_test_hash_table_1++.cpp create mode 100644 UnitTest++/nitf_test_image_blocker.cpp create mode 100644 UnitTest++/nitf_test_image_io.cpp create mode 100644 UnitTest++/nitf_test_image_segment_blank_nm_compression.cpp create mode 100644 UnitTest++/nitf_test_image_segment_computer.cpp create mode 100644 UnitTest++/nitf_test_j2k_loading++.cpp create mode 100644 UnitTest++/nitf_test_j2k_read_tile.cpp create mode 100644 UnitTest++/nitf_test_nitf_buffer_list.cpp create mode 100644 UnitTest++/nitf_test_tre_create++.cpp create mode 100644 UnitTest++/nitf_test_tre_mods.cpp create mode 100644 UnitTest++/nitf_test_tre_read.cpp create mode 100644 UnitTest++/nitf_test_writer_3++.cpp diff --git a/Test++/Test.h b/Test++/Test.h index f0f8682bf..b8a097895 100644 --- a/Test++/Test.h +++ b/Test++/Test.h @@ -7,30 +7,36 @@ #define TEST_ASSERT(X) EXPECT_TRUE(X) template -inline void test_assert_eq_(const T& t, const U& u) +inline void test_assert_eq_(T&& t,U&& u) { EXPECT_EQ(t, u); + EXPECT_EQ(u, t); } -#define TEST_ASSERT_EQ(X1, X2) { test_assert_eq_(X1, X2); test_assert_eq_(X2, X1); } +#define TEST_ASSERT_EQ(X1, X2) test_assert_eq_(X1, X2) #define TEST_ASSERT_EQ_INT(X1, X2) TEST_ASSERT_EQ(X1, X2) template -inline void test_assert_str_eq_(const T& t, const U& u) +inline void test_assert_str_eq_(T&& t, U&& u) { - EXPECT_STREQ(t, u); + EXPECT_STREQ(t.c_str(), u.c_str()); + EXPECT_STREQ(u.c_str(), t.c_str()); } -#define TEST_ASSERT_EQ_STR(X1, X2) { test_assert_str_eq_(X1, X2); test_assert_str_eq_(X2, X1; } +#define TEST_ASSERT_EQ_STR(X1, X2) { test_assert_str_eq_(std::string(X1), std::string(X2)); } #define TEST_ASSERT_EQ_FLOAT(X1, X2) EXPECT_FLOAT_EQ(static_cast(X1), static_cast(X2)) #define TEST_ASSERT_NULL(X) TEST_ASSERT_EQ((X), nullptr) + #define TEST_ASSERT_TRUE(X) TEST_ASSERT_EQ((X), true) #define TEST_ASSERT_FALSE(X) TEST_ASSERT_EQ((X), false) template -inline void test_assert_not_eq_(const T& t, const U& u) +inline void test_assert_not_eq_(T&& t, U&& u) { EXPECT_NE(t, u); + EXPECT_NE(u, t); } -#define TEST_ASSERT_NOT_EQ(X1, X2) { test_assert_not_eq_(X1, X2); test_assert_not_eq_(X2, X1);} +#define TEST_ASSERT_NOT_EQ(X1, X2) test_assert_not_eq_(X1, X2) +#define TEST_ASSERT_NOT_NULL(X) TEST_ASSERT_NOT_EQ(X, nullptr) + #define TEST_ASSERT_GREATER(X1, X2) EXPECT_GT(X1, X2) diff --git a/UnitTest++/Test.h b/UnitTest++/Test.h index f4f327671..f5b882401 100644 --- a/UnitTest++/Test.h +++ b/UnitTest++/Test.h @@ -7,10 +7,7 @@ namespace Microsoft{ namespace VisualStudio {namespace CppUnitTestFramework { -inline std::wstring ToString(const uint8_t& q) -{ - return std::to_wstring(q); -} +template<> inline std::wstring ToString(const uint16_t& q) { return std::to_wstring(q); @@ -23,31 +20,38 @@ template inline void test_assert_eq_(T&& t, U&& u) { Assert::AreEqual(t, u); + Assert::AreEqual(u, t); } -#define TEST_ASSERT_EQ(X1, X2) { test_assert_eq_(X1, X2); test_assert_eq_(X2, X1); } +#define TEST_ASSERT_EQ(X1, X2) test_assert_eq_(X1, X2); #define TEST_ASSERT_EQ_INT(X1, X2) TEST_ASSERT_EQ(X2, X1) -#define TEST_ASSERT_EQ_STR(X1, X2) TEST_ASSERT_EQ(X1, X2) +#define TEST_ASSERT_EQ_STR(X1, X2) TEST_ASSERT_EQ(std::string(X1), std::string(X2)) #define TEST_ASSERT_EQ_FLOAT(X1, X2) TEST_ASSERT_EQ(static_cast(X1), static_cast(X2)) #define TEST_ASSERT_NULL(X) Assert::IsNull((X)) +#define TEST_ASSERT_NOT_NULL(X) Assert::IsNotNull((X)) #define TEST_ASSERT_TRUE(X) Assert::IsTrue((X)) #define TEST_ASSERT_FALSE(X) Assert::IsFalse((X)) template -inline void test_assert_not_eq_(const T& t, const U& u) +inline void test_assert_not_eq_(T&& t, U&& u) { Assert::AreNotEqual(t, u); + Assert::AreNotEqual(u, t); } -#define TEST_ASSERT_NOT_EQ(X1, X2) { test_assert_not_eq_(X1, X2); test_assert_not_eq_(X2, X1);} - -#define TEST_ASSERT_GREATER(X1, X2) EXPECT_GT(X1, X2) +#define TEST_ASSERT_NOT_EQ(X1, X2) test_assert_not_eq_(X1, X2); +template +inline void test_assert_greater_(T&& t, U&& u) +{ + Assert::IsTrue(t > u); +} +#define TEST_ASSERT_GREATER(X1, X2) test_assert_greater_(X1, X2) -#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) Assert:AreEqual(X1, X2, EPS) +#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) { Assert:AreEqual(X1, X2, EPS); Assert:AreEqual(X1, X1, EPS); } #define TEST_ASSERT_ALMOST_EQ(X1, X2) TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, 0.0001) -#define TEST_ASSERT_EQ_MSG(msg, X1, X2) SCOPED_TRACE(msg); TEST_ASSERT_EQ(X1, X2) +#define TEST_ASSERT_EQ_MSG(msg, X1, X2) Logger::WriteMessage(msg.c_str()); TEST_ASSERT_EQ(X1, X2) -#define TEST_EXCEPTION(X) EXPECT_ANY_THROW((X)) -#define TEST_THROWS(X) EXPECT_ANY_THROW((X)) +#define TEST_EXCEPTION(X) try { (X); TEST_ASSERT_FALSE(false); } catch (...) { TEST_ASSERT_TRUE(true); } +#define TEST_THROWS(X) TEST_EXCEPTION(X) #define TEST_MAIN(X) diff --git a/UnitTest++/UnitTest++.vcxproj b/UnitTest++/UnitTest++.vcxproj index 4bac7e490..dad524a24 100644 --- a/UnitTest++/UnitTest++.vcxproj +++ b/UnitTest++/UnitTest++.vcxproj @@ -89,6 +89,18 @@ + + + + + + + + + + + + Create Create diff --git a/UnitTest++/UnitTest++.vcxproj.filters b/UnitTest++/UnitTest++.vcxproj.filters index 5ef698738..06faa5354 100644 --- a/UnitTest++/UnitTest++.vcxproj.filters +++ b/UnitTest++/UnitTest++.vcxproj.filters @@ -4,6 +4,18 @@ + + + + + + + + + + + + diff --git a/UnitTest++/nitf_Test.h b/UnitTest++/nitf_Test.h index 695150ce7..833ebfa7e 100644 --- a/UnitTest++/nitf_Test.h +++ b/UnitTest++/nitf_Test.h @@ -10,4 +10,27 @@ #include "import/nitf.h" -#include \ No newline at end of file +#include + +namespace Microsoft{ namespace VisualStudio {namespace CppUnitTestFramework +{ + +template<> +inline std::wstring ToString(const nitf::PixelValueType& q) +{ + return nitf::to_wstring(q); +} + +template<> +inline std::wstring ToString(const nitf::BlockingMode& q) +{ + return nitf::to_wstring(q); +} + +template<> +inline std::wstring ToString(const nitf::ImageCompression& q) +{ + return nitf::to_wstring(q); +} + +}}} \ No newline at end of file diff --git a/UnitTest++/nitf_test_hash_table_1++.cpp b/UnitTest++/nitf_test_hash_table_1++.cpp new file mode 100644 index 000000000..62fece1c6 --- /dev/null +++ b/UnitTest++/nitf_test_hash_table_1++.cpp @@ -0,0 +1,13 @@ +#include "pch.h" + +#include "nitf_Test.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_hash_table_1__) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nitf/unittests/test_hash_table_1++.cpp" + +}; \ No newline at end of file diff --git a/UnitTest++/nitf_test_image_blocker.cpp b/UnitTest++/nitf_test_image_blocker.cpp new file mode 100644 index 000000000..be61b895e --- /dev/null +++ b/UnitTest++/nitf_test_image_blocker.cpp @@ -0,0 +1,13 @@ +#include "pch.h" + +#include "nitf_Test.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(test_image_blocker) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nitf/unittests/test_image_blocker.cpp" + +}; \ No newline at end of file diff --git a/UnitTest++/nitf_test_image_io.cpp b/UnitTest++/nitf_test_image_io.cpp new file mode 100644 index 000000000..b23256d8f --- /dev/null +++ b/UnitTest++/nitf_test_image_io.cpp @@ -0,0 +1,14 @@ +#include "pch.h" + +#include "nitf_Test.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(test_image_loading__) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nitf/unittests/test_image_loading++.cpp" + +}; +std::string test_image_loading__::argv0; diff --git a/UnitTest++/nitf_test_image_segment_blank_nm_compression.cpp b/UnitTest++/nitf_test_image_segment_blank_nm_compression.cpp new file mode 100644 index 000000000..47a54fd25 --- /dev/null +++ b/UnitTest++/nitf_test_image_segment_blank_nm_compression.cpp @@ -0,0 +1,13 @@ +#include "pch.h" + +#include "nitf_Test.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(test_image_segment_blank_nm_compression) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nitf/unittests/test_image_segment_blank_nm_compression.cpp" + +}; \ No newline at end of file diff --git a/UnitTest++/nitf_test_image_segment_computer.cpp b/UnitTest++/nitf_test_image_segment_computer.cpp new file mode 100644 index 000000000..3129bc58f --- /dev/null +++ b/UnitTest++/nitf_test_image_segment_computer.cpp @@ -0,0 +1,13 @@ +#include "pch.h" + +#include "nitf_Test.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(test_image_segment_computer) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nitf/unittests/test_image_segment_computer.cpp" + +}; \ No newline at end of file diff --git a/UnitTest++/nitf_test_j2k_loading++.cpp b/UnitTest++/nitf_test_j2k_loading++.cpp new file mode 100644 index 000000000..bcd213237 --- /dev/null +++ b/UnitTest++/nitf_test_j2k_loading++.cpp @@ -0,0 +1,13 @@ +#include "pch.h" + +#include "nitf_Test.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(test_j2k_loading__) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nitf/unittests/test_j2k_loading++.cpp" + +}; \ No newline at end of file diff --git a/UnitTest++/nitf_test_j2k_read_tile.cpp b/UnitTest++/nitf_test_j2k_read_tile.cpp new file mode 100644 index 000000000..c7d2e83d6 --- /dev/null +++ b/UnitTest++/nitf_test_j2k_read_tile.cpp @@ -0,0 +1,13 @@ +#include "pch.h" + +#include "nitf_Test.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(test_j2k_read_tile) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nitf/unittests/test_j2k_read_tile.cpp" + +}; \ No newline at end of file diff --git a/UnitTest++/nitf_test_nitf_buffer_list.cpp b/UnitTest++/nitf_test_nitf_buffer_list.cpp new file mode 100644 index 000000000..71f19a07e --- /dev/null +++ b/UnitTest++/nitf_test_nitf_buffer_list.cpp @@ -0,0 +1,13 @@ +#include "pch.h" + +#include "nitf_Test.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(test_nitf_buffer_list) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nitf/unittests/test_nitf_buffer_list.cpp" + +}; \ No newline at end of file diff --git a/UnitTest++/nitf_test_tre_create++.cpp b/UnitTest++/nitf_test_tre_create++.cpp new file mode 100644 index 000000000..f05067fe6 --- /dev/null +++ b/UnitTest++/nitf_test_tre_create++.cpp @@ -0,0 +1,22 @@ +#include "pch.h" + +#include + +#include "nitf_Test.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_tre_create__) { +public: + nitf_test_tre_create__() { + // initialization code here + sys::OS().setEnv("NITF_PLUGIN_PATH", nitf::Test::buildPluginsDir(), true /*overwrite*/); + } + ~nitf_test_tre_create__() = default; + nitf_test_tre_create__(const nitf_test_tre_create__&) = delete; + nitf_test_tre_create__& operator=(const nitf_test_tre_create__&) = delete; + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nitf/unittests/test_tre_create++.cpp" + +}; \ No newline at end of file diff --git a/UnitTest++/nitf_test_tre_mods.cpp b/UnitTest++/nitf_test_tre_mods.cpp new file mode 100644 index 000000000..5a4962029 --- /dev/null +++ b/UnitTest++/nitf_test_tre_mods.cpp @@ -0,0 +1,50 @@ +#include "pch.h" + +#include + +#include "nitf_Test.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_tre_mods) { +public: + nitf_test_tre_mods() { + // initialization code here + sys::OS().setEnv("NITF_PLUGIN_PATH", nitf::Test::buildPluginsDir(), true /*overwrite*/); + } + ~nitf_test_tre_mods() = default; + nitf_test_tre_mods(const nitf_test_tre_mods&) = delete; + nitf_test_tre_mods& operator=(const nitf_test_tre_mods&) = delete; + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nitf/unittests/test_tre_mods++.cpp" + +}; + +// Be sure this runs AFTER the tre_mods tests ... not really sure why ... +#undef TEST_CASE +TEST_CLASS(test_image_writer) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nitf/unittests/test_image_writer.cpp" + +}; +std::filesystem::path test_image_writer::argv0; +const std::filesystem::path test_image_writer::file = __FILE__; + +#undef TEST_CASE +TEST_CLASS(test_load_plugins) { +public: + test_load_plugins() { + // initialization code here + sys::OS().setEnv("NITF_PLUGIN_PATH", nitf::Test::buildPluginsDir(), true /*overwrite*/); + } + ~test_load_plugins() = default; + test_load_plugins(const test_load_plugins&) = delete; + test_load_plugins& operator=(const test_load_plugins&) = delete; + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nitf/unittests/test_load_plugins.cpp" + +}; diff --git a/UnitTest++/nitf_test_tre_read.cpp b/UnitTest++/nitf_test_tre_read.cpp new file mode 100644 index 000000000..f02967d46 --- /dev/null +++ b/UnitTest++/nitf_test_tre_read.cpp @@ -0,0 +1,23 @@ +#include "pch.h" + +#include + +#include "nitf_Test.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(test_tre_read) { +public: + test_tre_read() { + // initialization code here + sys::OS().setEnv("NITF_PLUGIN_PATH", nitf::Test::buildPluginsDir(), true /*overwrite*/); + } + ~test_tre_read() = default; + test_tre_read(const test_tre_read&) = delete; + test_tre_read& operator=(const test_tre_read&) = delete; + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nitf/unittests/test_tre_read.cpp" + +}; +const char* test_tre_read::argv0 = nullptr; diff --git a/UnitTest++/nitf_test_writer_3++.cpp b/UnitTest++/nitf_test_writer_3++.cpp new file mode 100644 index 000000000..10bfc481e --- /dev/null +++ b/UnitTest++/nitf_test_writer_3++.cpp @@ -0,0 +1,23 @@ +#include "pch.h" + +#include + +#include "nitf_Test.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_writer_3__) { +public: + nitf_test_writer_3__() { + // initialization code here + sys::OS().setEnv("NITF_PLUGIN_PATH", nitf::Test::buildPluginsDir(), true /*overwrite*/); + } + ~nitf_test_writer_3__() = default; + nitf_test_writer_3__(const nitf_test_writer_3__&) = delete; + nitf_test_writer_3__& operator=(const nitf_test_writer_3__&) = delete; + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nitf/unittests/test_writer_3++.cpp" + +}; +std::string nitf_test_writer_3__::argv0; \ No newline at end of file diff --git a/UnitTest++/pch.h b/UnitTest++/pch.h index 96e057e19..01fd2e7fa 100644 --- a/UnitTest++/pch.h +++ b/UnitTest++/pch.h @@ -29,6 +29,8 @@ #pragma warning(push) #pragma warning(disable: 4464) // relative include path contains '..' #include +#include +#include #pragma warning(disable: 5031) // #pragma warning(pop): likely mismatch, popping warning state pushed in different file #pragma comment(lib, "io-c++") #pragma comment(lib, "except-c++") @@ -43,8 +45,15 @@ #include #include +#include +#include +#include #include #include +#include +#include +#include +#include #include "nitf_Test.h" #include "Test.h" diff --git a/modules/c++/cpp.h b/modules/c++/cpp.h index d8d94434b..f3e3960da 100644 --- a/modules/c++/cpp.h +++ b/modules/c++/cpp.h @@ -26,6 +26,7 @@ #include #include #include +#include #include #include @@ -35,6 +36,7 @@ #include #include #include +#include #include #include #include diff --git a/modules/c++/nitf/include/nitf/Enum.hpp b/modules/c++/nitf/include/nitf/Enum.hpp index 13c96f807..abeda465b 100644 --- a/modules/c++/nitf/include/nitf/Enum.hpp +++ b/modules/c++/nitf/include/nitf/Enum.hpp @@ -30,6 +30,7 @@ #include #include "str/Manip.h" +#include "str/EncodedStringView.h" namespace nitf { @@ -101,7 +102,8 @@ namespace nitf #define NITF_ENUM_map_entry_14(name, n1, n2, n3, n4, n5, n6, n7, n8, n9, n10, n11, n12, n13, n14) NITF_ENUM_map_entry(name, n1), NITF_ENUM_map_entry_13(name, n2, n3, n4, n5, n6, n7, n8, n9, n10, n11, n12, n13, n14) #define NITF_ENUM_map_entry_15(name, n1, n2, n3, n4, n5, n6, n7, n8, n9, n10, n11, n12, n13, n14, n15) NITF_ENUM_map_entry(name, n1), NITF_ENUM_map_entry_14(name, n2, n3, n4, n5, n6, n7, n8, n9, n10, n11, n12, n13, n14, n15) -#define NITF_ENUM_define_string_to_enum_begin(name) inline std::ostream& operator<<(std::ostream& os, name e) { os << to_string(e); return os; } \ +#define NITF_ENUM_define_string_to_enum_ostream_(name) inline std::ostream& operator<<(std::ostream& os, name e) { os << to_string(e); return os; } +#define NITF_ENUM_define_string_to_enum_begin(name) NITF_ENUM_define_string_to_enum_ostream_(name) \ namespace details { template<> inline const std::map& string_to_enum() { \ static const std::map retval { #define NITF_ENUM_define_string_to_end }; return retval; } } @@ -117,6 +119,11 @@ namespace nitf return details::to_string(v); } template + inline std::wstring to_wstring(T v) noexcept(false) + { + return str::EncodedStringView(details::to_string(v)).wstring(); + } + template inline T from_string(std::string v) noexcept(false) { str::trim(v); diff --git a/modules/c++/nitf/unittests/TestCase.h b/modules/c++/nitf/unittests/TestCase.h index e42301117..45c35cc24 100644 --- a/modules/c++/nitf/unittests/TestCase.h +++ b/modules/c++/nitf/unittests/TestCase.h @@ -40,9 +40,11 @@ catch(const except::Throwable11& ex) { die_printf("%s: FAILED: Exception thrown: %s\n", std::string(#X).c_str(), ex.what()); } # define TEST_ASSERT(X) if (!(X)) { die_printf("%s (%s,%s,%d): FAILED: Value should not be NULL\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } # define TEST_ASSERT_NULL(X) if ((X) != nullptr) { die_printf("%s (%s,%s,%d): FAILED: Value should be NULL\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } +# define TEST_ASSERT_NOT_NULL(X) if ((X) == nullptr) { die_printf("%s (%s,%s,%d): FAILED: Value should not be NULL\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } # define TEST_ASSERT_FALSE(X) if ((X)) { die_printf("%s (%s,%s,%d): FAILED: Value should evaluate to false\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } # define TEST_ASSERT_TRUE(X) if (!(X)) { die_printf("%s (%s,%s,%d): FAILED: Value should evaluate to true\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } # define TEST_ASSERT_EQ(X1, X2) if ((X1) != (X2)) { die_printf("%s (%s,%s,%d): FAILED: Recv'd %s, Expected %s\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__, str::toString(X1).c_str(), str::toString(X2).c_str()); } +# define TEST_ASSERT_EQ_STR(X1, X2) TEST_ASSERT_EQ(std::string(X1), std::string(X2)) # define TEST_ASSERT_EQ_MSG(msg, X1, X2) if ((X1) != (X2)) die_printf("%s (%s,%d): FAILED (%s): Recv'd %s, Expected %s\n", testName.c_str(), __FILE__, __LINE__, (msg).c_str(), str::toString((X1)).c_str(), str::toString((X2)).c_str()); # define TEST_ASSERT_NOT_EQ(X1, X2) if ((X1) == (X2)) { die_printf("%s (%s,%s,%d): FAILED: Recv'd %s should not equal %s\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__, str::toString(X1).c_str(), str::toString(X2).c_str()); } # define TEST_ASSERT_NOT_EQ_MSG(msg, X1, X2) if ((X1) == (X2)) die_printf("%s (%s,%d): FAILED (%s): Recv'd %s should not equal %s\n", testName.c_str(), __FILE__, __LINE__, (msg).c_str(), str::toString((X1)).c_str(), str::toString((X2)).c_str()); diff --git a/modules/c++/nitf/unittests/test_hash_table_1++.cpp b/modules/c++/nitf/unittests/test_hash_table_1++.cpp index f3ffaf0a4..6c755387e 100644 --- a/modules/c++/nitf/unittests/test_hash_table_1++.cpp +++ b/modules/c++/nitf/unittests/test_hash_table_1++.cpp @@ -96,7 +96,7 @@ TEST_CASE(test_hash_table_1) } catch (const except::NoSuchKeyException& t) { - TEST_ASSERT_EQ("NOT FOUND", keyBuf); + TEST_ASSERT_EQ_STR("NOT FOUND", keyBuf); const auto message = t.getMessage(); TEST_ASSERT_EQ(message, keyBuf); } diff --git a/modules/c++/nitf/unittests/test_image_blocker.cpp b/modules/c++/nitf/unittests/test_image_blocker.cpp index 45ed32ed5..189e331fa 100644 --- a/modules/c++/nitf/unittests/test_image_blocker.cpp +++ b/modules/c++/nitf/unittests/test_image_blocker.cpp @@ -27,8 +27,6 @@ #include "TestCase.h" -namespace -{ TEST_CASE(testSingleSegmentNoLeftovers) { // 4 rows of blocks and 5 cols of blocks @@ -475,7 +473,6 @@ TEST_CASE(testBlockPartialImage) } } } -} TEST_MAIN( (void)argc; diff --git a/modules/c++/nitf/unittests/test_image_loading++.cpp b/modules/c++/nitf/unittests/test_image_loading++.cpp index 52853d318..ffad7a2b4 100644 --- a/modules/c++/nitf/unittests/test_image_loading++.cpp +++ b/modules/c++/nitf/unittests/test_image_loading++.cpp @@ -26,46 +26,46 @@ #include -namespace fs = std::filesystem; +using path = std::filesystem::path; #include "TestCase.h" static std::string testName; static std::string argv0; -static fs::path findInputFile(const fs::path& inputFile) +static path findInputFile(const path& inputFile) { - fs::path root; + path root; if (argv0.empty()) { // running in Visual Studio - root = fs::current_path().parent_path().parent_path(); + root = std::filesystem::current_path().parent_path().parent_path(); } else { - root = absolute(fs::path(argv0)).parent_path().parent_path().parent_path().parent_path(); + root = absolute(path(argv0)).parent_path().parent_path().parent_path().parent_path(); root = root.parent_path().parent_path(); } return root / inputFile; } -static fs::path findInputFile() +static path findInputFile() { - const auto inputPath = fs::path("modules") / "c++" / "nitf" / "unittests" / "sicd_50x50.nitf"; + const auto inputPath = path("modules") / "c++" / "nitf" / "unittests" / "sicd_50x50.nitf"; return findInputFile(inputPath); } -static fs::path findInputFile(bool withAmpTable) +static path findInputFile(bool withAmpTable) { - fs::path inputPath; + path inputPath; if (withAmpTable) { - inputPath = fs::path("modules") / "c++" / "nitf" / "unittests" / "8_bit_Amp_Phs_Examples" / + inputPath = path("modules") / "c++" / "nitf" / "unittests" / "8_bit_Amp_Phs_Examples" / "With_amplitude_table" / "sicd_example_1_PFA_AMP8I_PHS8I_VV_with_amplitude_table_SICD.nitf"; } else { - inputPath = fs::path("modules") / "c++" / "nitf" / "unittests" / "8_bit_Amp_Phs_Examples" / + inputPath = path("modules") / "c++" / "nitf" / "unittests" / "8_bit_Amp_Phs_Examples" / "No_amplitude_table" / "sicd_example_1_PFA_AMP8I_PHS8I_VV_no_amplitude_table_SICD.nitf"; @@ -78,10 +78,10 @@ struct expected_values final uint32_t nRows = 50; uint32_t nCols = 50; nitf::PixelValueType pixelValueType = nitf::PixelValueType::Floating; // "R" - uint32_t bitsPerPixel = 32; + size_t bitsPerPixel = 32; std::string actualBitsPerPixel = "32"; - uint32_t pixelsPerHorizBlock = 50; - uint32_t pixelsPerVertBlock = 50; + size_t pixelsPerHorizBlock = 50; + size_t pixelsPerVertBlock = 50; int luts = 0; }; @@ -140,14 +140,14 @@ static void writeImage(nitf::ImageSegment &segment, TEST_ASSERT_EQ(expected.pixelValueType, subheader.pixelValueType()); TEST_ASSERT_EQ(expected.bitsPerPixel, subheader.numBitsPerPixel()); TEST_ASSERT_EQ(expected.actualBitsPerPixel, subheader.getActualBitsPerPixel().toString()); - TEST_ASSERT_EQ("R", subheader.getPixelJustification().toString()); + TEST_ASSERT_EQ_STR("R", subheader.getPixelJustification().toString()); TEST_ASSERT_EQ(nitf::BlockingMode::Pixel, subheader.imageBlockingMode()); // "P" TEST_ASSERT_EQ(static_cast(1), subheader.numBlocksPerRow()); TEST_ASSERT_EQ(static_cast(1), subheader.numBlocksPerCol()); TEST_ASSERT_EQ(expected.pixelsPerHorizBlock, subheader.numPixelsPerHorizBlock()); TEST_ASSERT_EQ(expected.pixelsPerVertBlock, subheader.numPixelsPerVertBlock()); TEST_ASSERT_EQ(nitf::ImageCompression::NC, subheader.imageCompression()); - TEST_ASSERT_EQ(" ", subheader.getCompressionRate().toString()); + TEST_ASSERT_EQ_STR(" ", subheader.getCompressionRate().toString()); nitf::BufferList buffer(nBands); std::vector bandList(nBands); @@ -173,7 +173,7 @@ static void writeImage(nitf::ImageSegment &segment, for (unsigned int i = 0; i < nBands; i++) { - std::string base = fs::path(imageName).filename().string(); + auto base = path(imageName).filename().string(); size_t where = 0; while ((where = base.find(".")) != (size_t)std::string::npos) @@ -223,8 +223,6 @@ static void test_image_loading_(const std::string& input_file, bool optz, const TEST_CASE(test_image_loading) { - ::testName = testName; - /* If you didnt give us a nitf file, we're croaking */ const auto input_file = findInputFile().string(); expected_values expected; // braced-initialization cause CodeQL to fail? @@ -241,8 +239,6 @@ TEST_CASE(test_image_loading) TEST_CASE(test_8bit_image_loading) { - ::testName = testName; - auto input_file = findInputFile(true /*withAmpTable*/).string(); expected_values expected; // braced-initialization cause CodeQL to fail? expected.nRows = 3975; diff --git a/modules/c++/nitf/unittests/test_image_segment_blank_nm_compression.cpp b/modules/c++/nitf/unittests/test_image_segment_blank_nm_compression.cpp index 5a8c9c743..8cff7624f 100644 --- a/modules/c++/nitf/unittests/test_image_segment_blank_nm_compression.cpp +++ b/modules/c++/nitf/unittests/test_image_segment_blank_nm_compression.cpp @@ -18,9 +18,9 @@ #include "TestCase.h" -const int64_t BLOCK_LENGTH = 256; -const int64_t ILOC_MAX = 99999; -std::string generateILOC(const types::RowCol& offset) +static constexpr int64_t BLOCK_LENGTH = 256; +static constexpr int64_t ILOC_MAX = 99999; +static std::string generateILOC(const types::RowCol& offset) { std::ostringstream oss; @@ -266,7 +266,7 @@ TEST_CASE(testBlankSegmentsValid) if (imgCtr == static_cast(testIdx)) { - TEST_ASSERT_EQ(nBlocksPresent, 0); + TEST_ASSERT_EQ(nBlocksPresent, static_cast(0)); } else { diff --git a/modules/c++/nitf/unittests/test_image_segment_computer.cpp b/modules/c++/nitf/unittests/test_image_segment_computer.cpp index 8655f58fb..26c952b9a 100644 --- a/modules/c++/nitf/unittests/test_image_segment_computer.cpp +++ b/modules/c++/nitf/unittests/test_image_segment_computer.cpp @@ -29,8 +29,6 @@ #include "TestCase.h" -namespace -{ TEST_CASE(testBlockSizedBoundaries) { // This test is meant to run through a lot of cases just to make sure @@ -214,7 +212,6 @@ TEST_CASE(testKnownCase) } } -} TEST_MAIN diff --git a/modules/c++/nitf/unittests/test_image_writer.cpp b/modules/c++/nitf/unittests/test_image_writer.cpp index 1a70847e5..55d6b37ae 100644 --- a/modules/c++/nitf/unittests/test_image_writer.cpp +++ b/modules/c++/nitf/unittests/test_image_writer.cpp @@ -35,10 +35,10 @@ #include "TestCase.h" -namespace fs = std::filesystem; +using path = std::filesystem::path; -static fs::path argv0; -static const fs::path file = __FILE__; +static path argv0; +static const path file; static bool is_linux() { @@ -52,11 +52,11 @@ static bool is_vs_gtest() return argv0.empty(); // no argv[0] in VS w/GTest } -static fs::path buildFileDir(const fs::path& relativePath) +static path buildFileDir(const path& relativePath) { if (is_vs_gtest()) { - static const auto cwd = fs::current_path(); + static const auto cwd = std::filesystem::current_path(); // Running GTest unit-tests in Visual Studio on Windows return cwd.parent_path().parent_path() / relativePath; @@ -117,8 +117,6 @@ static void doChangeFileHeader(const std::string& inputPathname, const std::stri writer.write(); } -namespace -{ TEST_CASE(imageWriterThrowsOnFailedConstruction) { nitf::ImageSubheader subheader; @@ -138,11 +136,9 @@ TEST_CASE(constructValidImageWriter) TEST_CASE(changeFileHeader) { - const auto inputPathname = buildFileDir(fs::path("modules") / "c++" / "nitf" / "tests" / "test_blank.ntf").string(); - TEST_ASSERT_NOT_EQ(inputPathname, ""); - //std::clog << "'" << inputPathname << "'\n"; - TEST_ASSERT_TRUE(fs::is_regular_file(inputPathname)); - const auto outputPathname = buildFileDir(fs::path("outputPathname.ntf")).string(); + const auto inputPathname = buildFileDir(path("modules") / "c++" / "nitf" / "tests" / "test_blank.ntf").string(); + TEST_ASSERT_TRUE(std::filesystem::is_regular_file(inputPathname)); + const auto outputPathname = buildFileDir(path("outputPathname.ntf")).string(); doChangeFileHeader(inputPathname, outputPathname); @@ -157,11 +153,10 @@ TEST_CASE(changeFileHeader) npos = fileTitle.find("*"); TEST_ASSERT(npos != std::string::npos); } -} TEST_MAIN( (void)argc; - argv0 = fs::absolute(argv[0]).string(); + argv0 = std::filesystem::absolute(argv[0]).string(); TEST_CHECK(imageWriterThrowsOnFailedConstruction); TEST_CHECK(constructValidImageWriter); diff --git a/modules/c++/nitf/unittests/test_j2k_loading++.cpp b/modules/c++/nitf/unittests/test_j2k_loading++.cpp index ada13f7fb..2e0fbdee9 100644 --- a/modules/c++/nitf/unittests/test_j2k_loading++.cpp +++ b/modules/c++/nitf/unittests/test_j2k_loading++.cpp @@ -36,34 +36,34 @@ #include #include -namespace fs = std::filesystem; +using path = std::filesystem::path; #include "TestCase.h" static std::string testName; -static fs::path findRoot(const fs::path& p) +static path findRoot(const path& p) { - if (fs::is_regular_file(p / "LICENSE") && fs::is_regular_file(p / "README.md") && fs::is_regular_file(p / "CMakeLists.txt")) + if (is_regular_file(p / "LICENSE") && is_regular_file(p / "README.md") && is_regular_file(p / "CMakeLists.txt")) { return p; } return findRoot(p.parent_path()); } -inline fs::path findRoot() +inline static path findRoot() { - return findRoot(fs::current_path()); + return findRoot(std::filesystem::current_path()); } static std::string argv0; -static fs::path findInputFile_(const fs::path& inputFile) +static path findInputFile_(const path& inputFile) { - fs::path root = findRoot(); + auto root = findRoot(); return root / inputFile; } -static fs::path findInputFile(const fs::path& fn) +static path findInputFile(const path& fn) { - const auto inputPath = fs::path("modules") / "c++" / "nitf" / "unittests" / fn; + const auto inputPath = path("modules") / "c++" / "nitf" / "unittests" / fn; return findInputFile_(inputPath); } @@ -99,8 +99,6 @@ static void test_image_loading_(const std::string& input_file, bool /*optz*/) TEST_CASE(test_j2k_loading) { - ::testName = testName; - auto input_file = findInputFile("j2k_compressed_file1_jp2.ntf").string(); test_image_loading_(input_file, false /*optz*/); //test_image_loading_(input_file, true /*optz*/); @@ -150,8 +148,6 @@ static void test_j2k_nitf_(const std::string& fname) } TEST_CASE(test_j2k_nitf) { - ::testName = testName; - j2k_Reader* pNative = nullptr; try { @@ -207,7 +203,7 @@ void writeJ2K(uint32_t x0, uint32_t y0, writer.write(outIO); //printf("Wrote file: %s\n", outName.c_str()); } -void test_j2k_nitf_read_region_(const fs::path& fname) +void test_j2k_nitf_read_region_(const path& fname) { nitf::IOHandle io(fname.string(), NRT_ACCESS_READONLY, NRT_OPEN_EXISTING); nitf::Reader reader; @@ -280,7 +276,6 @@ void test_j2k_nitf_read_region_(const fs::path& fname) } TEST_CASE(test_j2k_nitf_read_region) { - ::testName = testName; // This is a JP2 file, not J2K; see OpenJPEG_setup_() auto input_file = findInputFile("j2k_compressed_file1_jp2.ntf"); test_j2k_nitf_read_region_(input_file); diff --git a/modules/c++/nitf/unittests/test_j2k_read_tile.cpp b/modules/c++/nitf/unittests/test_j2k_read_tile.cpp index 7d35698c1..da7a853ab 100644 --- a/modules/c++/nitf/unittests/test_j2k_read_tile.cpp +++ b/modules/c++/nitf/unittests/test_j2k_read_tile.cpp @@ -24,7 +24,7 @@ #include #include "TestCase.h" -TEST_CASE(test_j2k_read_tile) +TEST_CASE(unittest_j2k_read_tile) { /* placeholder */ } @@ -32,6 +32,6 @@ TEST_CASE(test_j2k_read_tile) TEST_MAIN( (void)argc; (void)argv; - TEST_CHECK(test_j2k_read_tile); + TEST_CHECK(unittest_j2k_read_tile); ) diff --git a/modules/c++/nitf/unittests/test_load_plugins.cpp b/modules/c++/nitf/unittests/test_load_plugins.cpp index 3c7572262..fd6762ca1 100644 --- a/modules/c++/nitf/unittests/test_load_plugins.cpp +++ b/modules/c++/nitf/unittests/test_load_plugins.cpp @@ -50,30 +50,32 @@ static void load_plugin(const char* tre) TEST_ASSERT(test_main_ != nullptr); } -static const std::vector all_plugins +static const std::vector& all_plugins() { -#if _MSC_VER && NITRO_PCH - // only build a handful in Visual Studio - "ACCHZB", "ACCPOB", "ACFTA", "AIMIDB", "CSCRNA", "ENGRDA", "HISTOA", "JITCID", "PTPRAA", "RPFHDR", -#else - "ACCHZB", "BANDSB", "CSDIDA", "GEOLOB", "JITCID", "NBLOCA", "PIAPEB", "REGPTB", "RSMIDA", "STEROB", - "ACCPOB", "BCKGDA", "CSEPHA", "GEOPSB", "MAPLOB", "OBJCTA", "PIAPRC", "RPC00B", "RSMPCA", "STREOB", - "ACCVTB", "BLOCKA", "CSEXRA", "GRDPSB", "MATESA", "OFFSET", "PIAPRD", "RPFDES", "RSMPIA", "TEST_DES", - "ACFTA", "BNDPLB", "CSPROA", "HISTOA", "MENSRA", "PATCHA", "PIATGA", "RPFHDR", "SECTGA", "TRGTA", - "ACFTB", "CCINFA", "CSSFAA", "ICHIPB", "MENSRB", "PATCHB", "PIATGB", "RPFIMG", "SENSRA", "USE00A", - "AIMIDA", "CLCTNA", "CSSHPA", "IMASDA", "MPDSRA", "PIAEQA", "PIXQLA", "RSMAPA", "SENSRB", - "AIMIDB", "CLCTNB", "ENGRDA", "IMGDTA", "MSDIRA", "PIAEVA", "PLTFMA", "RSMDCA", "SNSPSB", - "AIPBCA", "CMETAA", "EXOPTA", "IMRFCA", "MSTGTA", "PIAIMB", "PRADAA", "RSMECA", "SNSRA", - "ASTORA", "CSCCGA", "EXPLTA", "IOMAPA", "MTIRPA", "PIAIMC", "PRJPSB", "RSMGGA", "SOURCB", - "BANDSA", "CSCRNA", "EXPLTB", "J2KLRA", "MTIRPB", "PIAPEA", "PTPRAA", "RSMGIA", "STDIDC", -#endif -}; + static const std::vector all_plugins_ + { + #if _MSC_VER && NITRO_PCH + // only build a handful in Visual Studio + "ACCHZB", "ACCPOB", "ACFTA", "AIMIDB", "CSCRNA", "ENGRDA", "HISTOA", "JITCID", "PTPRAA", "RPFHDR", + #else + "ACCHZB", "BANDSB", "CSDIDA", "GEOLOB", "JITCID", "NBLOCA", "PIAPEB", "REGPTB", "RSMIDA", "STEROB", + "ACCPOB", "BCKGDA", "CSEPHA", "GEOPSB", "MAPLOB", "OBJCTA", "PIAPRC", "RPC00B", "RSMPCA", "STREOB", + "ACCVTB", "BLOCKA", "CSEXRA", "GRDPSB", "MATESA", "OFFSET", "PIAPRD", "RPFDES", "RSMPIA", "TEST_DES", + "ACFTA", "BNDPLB", "CSPROA", "HISTOA", "MENSRA", "PATCHA", "PIATGA", "RPFHDR", "SECTGA", "TRGTA", + "ACFTB", "CCINFA", "CSSFAA", "ICHIPB", "MENSRB", "PATCHB", "PIATGB", "RPFIMG", "SENSRA", "USE00A", + "AIMIDA", "CLCTNA", "CSSHPA", "IMASDA", "MPDSRA", "PIAEQA", "PIXQLA", "RSMAPA", "SENSRB", + "AIMIDB", "CLCTNB", "ENGRDA", "IMGDTA", "MSDIRA", "PIAEVA", "PLTFMA", "RSMDCA", "SNSPSB", + "AIPBCA", "CMETAA", "EXOPTA", "IMRFCA", "MSTGTA", "PIAIMB", "PRADAA", "RSMECA", "SNSRA", + "ASTORA", "CSCCGA", "EXPLTA", "IOMAPA", "MTIRPA", "PIAIMC", "PRJPSB", "RSMGGA", "SOURCB", + "BANDSA", "CSCRNA", "EXPLTB", "J2KLRA", "MTIRPB", "PIAPEA", "PTPRAA", "RSMGIA", "STDIDC", + #endif + }; + return all_plugins_; +} TEST_CASE(test_load_all_plugins_C) { - ::testName = testName; - - for (const auto& tre : all_plugins) + for (const auto& tre : all_plugins()) { load_plugin(tre.c_str()); } @@ -90,9 +92,7 @@ TEST_CASE(test_load_ENGRDA) TEST_CASE(test_load_all_plugins) { - ::testName = testName; - - for (const auto& tre : all_plugins) + for (const auto& tre : all_plugins()) { #ifdef _WIN32 // need the full path to load on Linux diff --git a/modules/c++/nitf/unittests/test_nitf_buffer_list.cpp b/modules/c++/nitf/unittests/test_nitf_buffer_list.cpp index a67cfa1ba..06a07dfa6 100644 --- a/modules/c++/nitf/unittests/test_nitf_buffer_list.cpp +++ b/modules/c++/nitf/unittests/test_nitf_buffer_list.cpp @@ -26,8 +26,6 @@ #include -namespace -{ TEST_CASE(testGetNumBlocks) { // 5000 total bytes @@ -177,7 +175,6 @@ TEST_CASE(testGetBlock_std_byte) numBytesInBlock)); } } -} TEST_MAIN( (void)argc; diff --git a/modules/c++/nitf/unittests/test_tre_create++.cpp b/modules/c++/nitf/unittests/test_tre_create++.cpp index e0c34798a..6e3d0ffaf 100644 --- a/modules/c++/nitf/unittests/test_tre_create++.cpp +++ b/modules/c++/nitf/unittests/test_tre_create++.cpp @@ -23,7 +23,7 @@ TEST_CASE(test_tre_clone_329) { nitf_Error error; rawTre = nitf::TRE::create("TESTxyz", NITF_TRE_RAW, error); - TEST_ASSERT_NOT_EQ(nullptr, rawTre); + TEST_ASSERT_NOT_NULL(rawTre); nitf::TRE::setField(rawTre, "raw_data", rd, error); TEST_ASSERT_TRUE(true); diff --git a/modules/c++/nitf/unittests/test_tre_mods++.cpp b/modules/c++/nitf/unittests/test_tre_mods++.cpp index 2eb899c17..7070862b6 100644 --- a/modules/c++/nitf/unittests/test_tre_mods++.cpp +++ b/modules/c++/nitf/unittests/test_tre_mods++.cpp @@ -60,106 +60,101 @@ // A sample "strongly-typed" TRE. There are too many TREs (and too much unwillingness to change) to // actually hook this up. But it's kind of neat code that I don't want to lose. -namespace nitf +struct /*namespace*/ TREs { - namespace TREs + class NITRO_NITFCPP_API ENGRDA final { - class NITRO_NITFCPP_API ENGRDA final + nitf::TRE tre_; + + public: + // from TRE::getID() + /** + * Get the TRE identifier. This is NOT the tag, however it may be the + * same value as the tag. The ID is used to identify a specific + * version/incarnation of the TRE, if multiple are possible. For most TREs, + * this value will be the same as the tag. + */ + ENGRDA(const std::string& id = "") noexcept(false) + : tre_("ENGRDA", id.empty() ? "ENGRDA" : id.c_str()), + RESRC(tre_, "RESRC"), + RECNT(tre_, "RECNT", true /*forceUpdate*/), + ENGDTS{ tre_, "ENGDTS", RECNT }, + ENGDATC{ tre_, "ENGDATC", RECNT }, + ENGDATA{ tre_, "ENGDATA", RECNT } { - nitf::TRE tre_; - - public: - // from TRE::getID() - /** - * Get the TRE identifier. This is NOT the tag, however it may be the - * same value as the tag. The ID is used to identify a specific - * version/incarnation of the TRE, if multiple are possible. For most TREs, - * this value will be the same as the tag. - */ - ENGRDA(const std::string& id = "") noexcept(false) - : tre_("ENGRDA", id.empty() ? "ENGRDA" : id.c_str()), - RESRC(tre_, "RESRC"), - RECNT(tre_, "RECNT", true /*forceUpdate*/), - ENGDTS{ tre_, "ENGDTS", RECNT }, - ENGDATC{ tre_, "ENGDATC", RECNT }, - ENGDATA{ tre_, "ENGDATA", RECNT } - { - } - ~ENGRDA() = default; - ENGRDA(const ENGRDA&) = delete; - ENGRDA& operator=(const ENGRDA&) = delete; - ENGRDA(ENGRDA&&) = default; - ENGRDA& operator=(ENGRDA&&) = delete; - - // From ENGRDA.c - // - //static nitf_TREDescription description[] = { - // {NITF_BCS_A, 20, "Unique Source System Name", "RESRC" }, - TREField_BCS_A<20> RESRC; - - // {NITF_BCS_N, 3, "Record Entry Count", "RECNT" }, - TREField_BCS_N<3> RECNT; - - // {NITF_LOOP, 0, NULL, "RECNT"}, - // {NITF_BCS_N, 2, "Engineering Data Label Length", "ENGLN" }, - // /* This one we don't know the length of, so we have to use the special length tag */ - // {NITF_BCS_A, NITF_TRE_CONDITIONAL_LENGTH, "Engineering Data Label", - // "ENGLBL", "ENGLN" }, - // {NITF_BCS_N, 4, "Engineering Matrix Data Column Count", "ENGMTXC" }, - // {NITF_BCS_N, 4, "Engineering Matrix Data Row Count", "ENGMTXR" }, - // {NITF_BCS_A, 1, "Value Type of Engineering Data Element", "ENGTYP" }, - // {NITF_BCS_N, 1, "Engineering Data Element Size", "ENGDTS" }, - IndexedField> ENGDTS; - - // {NITF_BCS_A, 2, "Engineering Data Units", "ENGDATU" }, - // {NITF_BCS_N, 8, "Engineering Data Count", "ENGDATC" }, - IndexedField> ENGDATC; - - // /* This one we don't know the length of, so we have to use the special length tag */ - // /* Notice that we use postfix notation to compute the length - // * We also don't know the type of data (it depends on ENGDTS), so - // * we need to override the TREHandler's read method. If we don't do - // * this, not only will the field type potentially be wrong, but - // * strings will be endian swapped if they're of length 2 or 4. */ - // {NITF_BINARY, NITF_TRE_CONDITIONAL_LENGTH, "Engineering Data", - // "ENGDATA", "ENGDATC ENGDTS *"}, - IndexedField> ENGDATA; - - // {NITF_ENDLOOP, 0, NULL, NULL}, - // {NITF_END, 0, NULL, NULL} - //}; - - template - void setFieldValue(const std::string& tag, const T& value, bool forceUpdate = false) - { - tre_.setFieldValue(tag, value, forceUpdate); - } - void setFieldValue(const std::string& tag, const void* data, size_t dataLength, bool forceUpdate = false) - { - tre_.setFieldValue(tag, data, dataLength, forceUpdate); - } - - template - const T& getFieldValue(const std::string& tag, T& value) const - { - return tre_.getFieldValue(tag, value); - } - template - const T getFieldValue(const std::string& tag) const - { - return tre_.getFieldValue(tag); - } - - void updateFields() - { - tre_.updateFields(); - } - }; - } -} + } + ~ENGRDA() = default; + ENGRDA(const ENGRDA&) = delete; + ENGRDA& operator=(const ENGRDA&) = delete; + ENGRDA(ENGRDA&&) = default; + ENGRDA& operator=(ENGRDA&&) = delete; + + // From ENGRDA.c + // + //static nitf_TREDescription description[] = { + // {NITF_BCS_A, 20, "Unique Source System Name", "RESRC" }, + nitf::TREField_BCS_A<20> RESRC; + + // {NITF_BCS_N, 3, "Record Entry Count", "RECNT" }, + nitf::TREField_BCS_N<3> RECNT; + + // {NITF_LOOP, 0, NULL, "RECNT"}, + // {NITF_BCS_N, 2, "Engineering Data Label Length", "ENGLN" }, + // /* This one we don't know the length of, so we have to use the special length tag */ + // {NITF_BCS_A, NITF_TRE_CONDITIONAL_LENGTH, "Engineering Data Label", + // "ENGLBL", "ENGLN" }, + // {NITF_BCS_N, 4, "Engineering Matrix Data Column Count", "ENGMTXC" }, + // {NITF_BCS_N, 4, "Engineering Matrix Data Row Count", "ENGMTXR" }, + // {NITF_BCS_A, 1, "Value Type of Engineering Data Element", "ENGTYP" }, + // {NITF_BCS_N, 1, "Engineering Data Element Size", "ENGDTS" }, + nitf::IndexedField> ENGDTS; + + // {NITF_BCS_A, 2, "Engineering Data Units", "ENGDATU" }, + // {NITF_BCS_N, 8, "Engineering Data Count", "ENGDATC" }, + nitf::IndexedField> ENGDATC; + + // /* This one we don't know the length of, so we have to use the special length tag */ + // /* Notice that we use postfix notation to compute the length + // * We also don't know the type of data (it depends on ENGDTS), so + // * we need to override the TREHandler's read method. If we don't do + // * this, not only will the field type potentially be wrong, but + // * strings will be endian swapped if they're of length 2 or 4. */ + // {NITF_BINARY, NITF_TRE_CONDITIONAL_LENGTH, "Engineering Data", + // "ENGDATA", "ENGDATC ENGDTS *"}, + nitf::IndexedField> ENGDATA; + + // {NITF_ENDLOOP, 0, NULL, NULL}, + // {NITF_END, 0, NULL, NULL} + //}; + + template + void setFieldValue(const std::string& tag, const T& value, bool forceUpdate = false) + { + tre_.setFieldValue(tag, value, forceUpdate); + } + void setFieldValue(const std::string& tag, const void* data, size_t dataLength, bool forceUpdate = false) + { + tre_.setFieldValue(tag, data, dataLength, forceUpdate); + } + + template + const T& getFieldValue(const std::string& tag, T& value) const + { + return tre_.getFieldValue(tag, value); + } + template + const T getFieldValue(const std::string& tag) const + { + return tre_.getFieldValue(tag); + } + + void updateFields() + { + tre_.updateFields(); + } + }; +}; -namespace -{ TEST_CASE(setFields) { // create an ACFTA TRE @@ -185,7 +180,7 @@ TEST_CASE(setBinaryFields) const int value = 123; tre.setField("LOCSEC", value); - nitf::Field field = tre.getField("LOCSEC"); + auto field = tre.getField("LOCSEC"); const int readValue = *reinterpret_cast(field.getRawData()); TEST_ASSERT_EQ(readValue, value); } @@ -259,56 +254,56 @@ TEST_CASE(use_ENGRDA_typed_fields) nitf::TREField_BCS_A<20> RESRC(engrda, "RESRC"); RESRC = "HSS"; // engrda.setField("RESRC", "HSS"); const auto resrc_ = str::strip(RESRC); - TEST_ASSERT_EQ(resrc_, "HSS"); + TEST_ASSERT_EQ_STR(resrc_, "HSS"); nitf::TREField_BCS_N<3> RECNT(engrda, "RECNT", true /*forceUpdate*/); RECNT = 1; // engrda.setField("RECNT", 1, true /*forceUpdate*/); const int64_t recnt_ = RECNT; - TEST_ASSERT_EQ(recnt_, 1); + TEST_ASSERT_EQ(recnt_, static_cast(1)); nitf::IndexedField> ENGDTS(engrda, "ENGDTS", RECNT); ENGDTS[0] = 3; // engrda.setField("ENGDTS[0]", 3); // size const int64_t engdts_0_ = ENGDTS[0]; - TEST_ASSERT_EQ(engdts_0_, 3); + TEST_ASSERT_EQ(engdts_0_, static_cast(3)); nitf::IndexedField> ENGDATC(engrda, "ENGDATC", RECNT); ENGDATC[0] = 1; // engrda.setField("ENGDATC[0]", 1); // count const int64_t engdatc_0_ = ENGDATC[0]; - TEST_ASSERT_EQ(engdatc_0_, 1); + TEST_ASSERT_EQ(engdatc_0_, static_cast(1)); engrda.updateFields(); nitf::IndexedField> ENGDATA(engrda, "ENGDATA", RECNT); ENGDATA[0] = "ABC"; // engrda.setField("ENGDATA[0]", "ABC"); const auto engdata_0_ = str::strip(ENGDATA[0]); - TEST_ASSERT_EQ(engdata_0_, "ABC"); + TEST_ASSERT_EQ_STR(engdata_0_, "ABC"); } TEST_CASE(use_typed_ENGRDA) { - nitf::TREs::ENGRDA engrda; // nitf::TRE engrda("ENGRDA", "ENGRDA"); + TREs::ENGRDA engrda; // nitf::TRE engrda("ENGRDA", "ENGRDA"); engrda.RESRC = "HSS"; // engrda.setField("RESRC", "HSS"); const auto RESRC = str::strip(engrda.RESRC); - TEST_ASSERT_EQ(RESRC, "HSS"); + TEST_ASSERT_EQ_STR(RESRC, "HSS"); engrda.RECNT = 1; // engrda.setField("RECNT", 1, true /*forceUpdate*/); const int64_t RECNT = engrda.RECNT; - TEST_ASSERT_EQ(RECNT, 1); + TEST_ASSERT_EQ(RECNT, static_cast(1)); engrda.ENGDTS[0] = 3; // engrda.setField("ENGDTS[0]", 3); // size const int64_t ENGDTS_0 = engrda.ENGDTS[0]; - TEST_ASSERT_EQ(ENGDTS_0, 3); + TEST_ASSERT_EQ(ENGDTS_0, static_cast(3)); engrda.ENGDATC[0] = 1; // engrda.setField("ENGDATC[0]", 1); // count const int64_t ENGDATC_0 = engrda.ENGDATC[0]; - TEST_ASSERT_EQ(ENGDATC_0, 1); + TEST_ASSERT_EQ(ENGDATC_0, static_cast(1)); engrda.updateFields(); engrda.ENGDATA[0] = "ABC"; // engrda.setField("ENGDATA[0]", "ABC"); const auto& engrda_ = engrda; const auto ENGDATA_0 = str::strip(engrda_.ENGDATA[0]); - TEST_ASSERT_EQ(ENGDATA_0, "ABC"); + TEST_ASSERT_EQ_STR(ENGDATA_0, "ABC"); try { @@ -336,7 +331,7 @@ TEST_CASE(populateWhileIterating) { nitf::TRE tre("ACCPOB"); size_t numFields = 0; - for (nitf::TRE::Iterator it = tre.begin(); it != tre.end(); ++it) + for (auto it = tre.begin(); it != tre.end(); ++it) { ++numFields; const std::string fieldName((*it).first()); @@ -363,28 +358,27 @@ TEST_CASE(overflowingNumericFields) // This field has a length of 9, so check that it's properly // truncated tre.setField("ULCNR_LAT", 1.0 / 9); - TEST_ASSERT_EQ(tre.getField("ULCNR_LAT").toString(), "0.1111111"); - TEST_ASSERT_EQ(tre.getFieldValue("ULCNR_LAT"), "0.1111111"); + TEST_ASSERT_EQ_STR(tre.getField("ULCNR_LAT").toString(), "0.1111111"); + TEST_ASSERT_EQ_STR(tre.getFieldValue("ULCNR_LAT"), "0.1111111"); std::string value; - TEST_ASSERT_EQ(tre.getFieldValue("ULCNR_LAT", value), "0.1111111"); + TEST_ASSERT_EQ_STR(tre.getFieldValue("ULCNR_LAT", value), "0.1111111"); tre.setField("ULCNR_LAT", 123456789); - TEST_ASSERT_EQ(tre.getField("ULCNR_LAT").toString(), "123456789"); + TEST_ASSERT_EQ_STR(tre.getField("ULCNR_LAT").toString(), "123456789"); tre.setField("ULCNR_LAT", 12345678.); - TEST_ASSERT_EQ(tre.getField("ULCNR_LAT").toString(), "012345678"); + TEST_ASSERT_EQ_STR(tre.getField("ULCNR_LAT").toString(), "012345678"); tre.setField("ULCNR_LAT", 12345678.9); - TEST_ASSERT_EQ(tre.getField("ULCNR_LAT").toString(), "012345678"); + TEST_ASSERT_EQ_STR(tre.getField("ULCNR_LAT").toString(), "012345678"); tre.setField("ULCNR_LAT", 1); - TEST_ASSERT_EQ(tre.getField("ULCNR_LAT").toString(), "000000001"); + TEST_ASSERT_EQ_STR(tre.getField("ULCNR_LAT").toString(), "000000001"); // If we run out of digits before hitting the decimal, there's no // saving it TEST_EXCEPTION(tre.setField("ULCNR_LAT", 123456789012LL)); } -} TEST_MAIN( TEST_CHECK(setFields); diff --git a/modules/c++/nitf/unittests/test_tre_read.cpp b/modules/c++/nitf/unittests/test_tre_read.cpp index 3e8ac96f7..3d0a7b8de 100644 --- a/modules/c++/nitf/unittests/test_tre_read.cpp +++ b/modules/c++/nitf/unittests/test_tre_read.cpp @@ -93,25 +93,25 @@ files, this bug may allow an attacker to cause a denial of service. static std::string testName; const char* output_file = "test_writer_3++.nitf"; -static const char* argv0 = NULL; +static const char* argv0; static bool is_vs_gtest() { return argv0 == NULL; } -namespace fs = std::filesystem; -static fs::path findInputFile_(const std::string& name) +using path = std::filesystem::path; +static path findInputFile_(const std::string& name) { - const auto inputFile = fs::path("modules") / "c++" / "nitf" / "unittests" / name; + const auto inputFile = path("modules") / "c++" / "nitf" / "unittests" / name; if (is_vs_gtest()) // running Google Test in Visual Studio { - const auto root= fs::current_path().parent_path().parent_path(); + const auto root= std::filesystem::current_path().parent_path().parent_path(); return root / inputFile; } - const auto exe = absolute(fs::path(argv0)); - fs::path root = exe.parent_path(); + const auto exe = absolute(path(argv0)); + auto root = exe.parent_path(); do { auto retval = root / inputFile; @@ -133,7 +133,6 @@ static const char* findInputFile(const char* name) TEST_CASE(test_nitf_Record_unmergeTREs_crash) { - ::testName = testName; const char* input_file = findInputFile("bug2_crash.ntf"); nitf_Error error; @@ -146,11 +145,11 @@ TEST_CASE(test_nitf_Record_unmergeTREs_crash) /* We need to make a reader so we can parse the NITF */ nitf_Reader* reader = nitf_Reader_construct(&error); - TEST_ASSERT_NOT_EQ(NULL, reader); + TEST_ASSERT_NOT_NULL(reader); /* This parses all header data within the NITF */ nitf_Record* record = nitf_Reader_read(reader, io, &error); - TEST_ASSERT_NOT_EQ(NULL, record); + TEST_ASSERT_NOT_NULL(record); /* Open the output IO Handle */ nitf_IOHandle output = nitf_IOHandle_create("bug2_crash_out.ntf", NITF_ACCESS_WRITEONLY, NITF_CREATE, &error); @@ -160,7 +159,7 @@ TEST_CASE(test_nitf_Record_unmergeTREs_crash) } nitf_Writer* writer = nitf_Writer_construct(&error); - TEST_ASSERT_NOT_EQ(nullptr, writer); + TEST_ASSERT_NOT_NULL(writer); (void)nitf_Writer_prepare(writer, record, output, &error); nitf_IOHandle_close(io); @@ -172,7 +171,6 @@ TEST_CASE(test_nitf_Record_unmergeTREs_crash) TEST_CASE(test_nitf_Record_unmergeTREs_hangs) { - ::testName = testName; const char* input_file = findInputFile("bug6_hangs.ntf"); nitf_Error error; @@ -185,11 +183,11 @@ TEST_CASE(test_nitf_Record_unmergeTREs_hangs) /* We need to make a reader so we can parse the NITF */ nitf_Reader* reader = nitf_Reader_construct(&error); - TEST_ASSERT_NOT_EQ(NULL, reader); + TEST_ASSERT_NOT_NULL(reader); /* This parses all header data within the NITF */ nitf_Record* record = nitf_Reader_read(reader, io, &error); - TEST_ASSERT_NOT_EQ(NULL, record); + TEST_ASSERT_NOT_NULL(record); /* Open the output IO Handle */ nitf_IOHandle output = nitf_IOHandle_create("bug6_hangs_out.ntf", NITF_ACCESS_WRITEONLY, NITF_CREATE, &error); @@ -199,7 +197,7 @@ TEST_CASE(test_nitf_Record_unmergeTREs_hangs) } nitf_Writer* writer = nitf_Writer_construct(&error); - TEST_ASSERT_NOT_EQ(NULL, writer); + TEST_ASSERT_NOT_NULL(writer); (void)nitf_Writer_prepare(writer, record, output, &error); nitf_IOHandle_close(io); @@ -211,7 +209,6 @@ TEST_CASE(test_nitf_Record_unmergeTREs_hangs) TEST_CASE(test_defaultRead_crash) { - ::testName = testName; const char* input_file = findInputFile("bug3_crash.ntf"); nitf_Error error; @@ -224,7 +221,7 @@ TEST_CASE(test_defaultRead_crash) /* We need to make a reader so we can parse the NITF */ nitf_Reader* reader = nitf_Reader_construct(&error); - TEST_ASSERT_NOT_EQ(NULL, reader); + TEST_ASSERT_NOT_NULL(reader); /* This parses all header data within the NITF */ (void)nitf_Reader_read(reader, io, &error); @@ -234,7 +231,6 @@ TEST_CASE(test_defaultRead_crash) TEST_CASE(test_readBandInfo_crash) { - ::testName = testName; const char* input_file = findInputFile("bug4_crash.ntf"); nitf_Error error; @@ -247,7 +243,7 @@ TEST_CASE(test_readBandInfo_crash) /* We need to make a reader so we can parse the NITF */ nitf_Reader* reader = nitf_Reader_construct(&error); - TEST_ASSERT_NOT_EQ(NULL, reader); + TEST_ASSERT_NOT_NULL(reader); /* This parses all header data within the NITF */ (void) nitf_Reader_read(reader, io, &error); @@ -256,7 +252,6 @@ TEST_CASE(test_readBandInfo_crash) TEST_CASE(test_readRESubheader_crash) { - ::testName = testName; const char* input_file = findInputFile("bug5_crash.ntf"); nitf_Error error; @@ -269,7 +264,7 @@ TEST_CASE(test_readRESubheader_crash) /* We need to make a reader so we can parse the NITF */ nitf_Reader* reader = nitf_Reader_construct(&error); - TEST_ASSERT_NOT_EQ(NULL, reader); + TEST_ASSERT_NOT_NULL(reader); /* This parses all header data within the NITF */ (void)nitf_Reader_read(reader, io, &error); diff --git a/modules/c++/nitf/unittests/test_writer_3++.cpp b/modules/c++/nitf/unittests/test_writer_3++.cpp index 62bef7524..b7fa3c88f 100644 --- a/modules/c++/nitf/unittests/test_writer_3++.cpp +++ b/modules/c++/nitf/unittests/test_writer_3++.cpp @@ -34,30 +34,28 @@ static std::string testName; const std::string output_file = "test_writer_3++.nitf"; -namespace fs = std::filesystem; +using path = std::filesystem::path; static std::string argv0; -static fs::path findInputFile() +static path findInputFile() { - const fs::path inputFile = fs::path("modules") / "c++" / "nitf" / "unittests" / "sicd_50x50.nitf"; + const auto inputFile = path("modules") / "c++" / "nitf" / "unittests" / "sicd_50x50.nitf"; - fs::path root; + path root; if (argv0.empty()) { // running in Visual Studio - root = fs::current_path().parent_path().parent_path(); + root = std::filesystem::current_path().parent_path().parent_path(); } else { - root = absolute(fs::path(argv0)).parent_path().parent_path().parent_path().parent_path(); + root = absolute(path(argv0)).parent_path().parent_path().parent_path().parent_path(); root = root.parent_path().parent_path(); } return root / inputFile; } -static nitf::Record doRead(const std::string& inFile, nitf::Reader& reader); - static std::string makeBandName(const std::string& rootFile, int imageNum, int bandNum) { std::string::size_type pos = rootFile.find_last_of("/\\"); @@ -137,18 +135,18 @@ static void manuallyWriteImageBands(nitf::ImageSegment & segment, TEST_ASSERT_EQ(2, static_cast(nBands)); TEST_ASSERT_EQ(0, static_cast(xBands)); TEST_ASSERT_EQ(static_cast(50), nRows); - TEST_ASSERT_EQ(static_cast(50), nColumns); + TEST_ASSERT_EQ(static_cast(50), nColumns); TEST_ASSERT_EQ(nitf::PixelValueType::Floating , subheader.pixelValueType()); TEST_ASSERT_EQ(static_cast(32), subheader.numBitsPerPixel()); - TEST_ASSERT_EQ("32", subheader.getActualBitsPerPixel().toString()); - TEST_ASSERT_EQ("R", subheader.getPixelJustification().toString()); + TEST_ASSERT_EQ_STR("32", subheader.getActualBitsPerPixel().toString()); + TEST_ASSERT_EQ_STR("R", subheader.getPixelJustification().toString()); TEST_ASSERT_EQ(nitf::BlockingMode::Pixel, subheader.imageBlockingMode()); TEST_ASSERT_EQ(static_cast(1), subheader.numBlocksPerRow()); TEST_ASSERT_EQ(static_cast(1), subheader.numBlocksPerCol()); TEST_ASSERT_EQ(static_cast(50), subheader.numPixelsPerHorizBlock()); TEST_ASSERT_EQ(static_cast(50), subheader.numPixelsPerVertBlock()); TEST_ASSERT_EQ(nitf::ImageCompression::NC, subheader.imageCompression()); - TEST_ASSERT_EQ(" ", subheader.getCompressionRate().toString()); + TEST_ASSERT_EQ_STR(" ", subheader.getCompressionRate().toString()); nitf::BufferList buffer(nBands); std::vector bandList(nBands); @@ -215,78 +213,68 @@ static nitf::Record doRead(const std::string& inFile, nitf::Reader& reader) return record; } -namespace test_writer_3 +/* + * This test tests the round-trip process of taking an input NITF + * file and writing it to a new file. This includes writing the image + * segments (headers, extensions, and image data). This is an example + * of how users can write the image data to their NITF file + */ +static void test_writer_3__doWrite(nitf::Record record, nitf::Reader& reader, const std::string& inRootFile, const std::string& outFile) { - /* - * This test tests the round-trip process of taking an input NITF - * file and writing it to a new file. This includes writing the image - * segments (headers, extensions, and image data). This is an example - * of how users can write the image data to their NITF file - */ - static void doWrite(nitf::Record record, nitf::Reader& reader, const std::string& inRootFile, const std::string& outFile) - { - nitf::Writer writer; - nitf::IOHandle output(outFile, NITF_ACCESS_WRITEONLY, NITF_CREATE); - writer.prepare(output, record); + nitf::Writer writer; + nitf::IOHandle output(outFile, NITF_ACCESS_WRITEONLY, NITF_CREATE); + writer.prepare(output, record); - ::doWrite(record, reader, inRootFile, writer); + doWrite(record, reader, inRootFile, writer); - output.close(); - } + output.close(); } TEST_CASE(test_writer_3_) { - ::testName = testName; - const auto input_file = findInputFile().string(); nitf::Reader reader; nitf::Record record = doRead(input_file, reader); - test_writer_3::doWrite(record, reader, input_file, output_file); + test_writer_3__doWrite(record, reader, input_file, output_file); } -namespace test_buffered_write +/* + * This test tests the round-trip process of taking an input NITF + * file and writing it to a new file. This includes writing the image + * segments (headers, extensions, and image data). + * + * This example differs from test_writer_3 in that it tests the + * BufferedWriter classes, and writes the entire file as a set of + * configurable sized blocks. The last block may be smaller than the others + * if the data does not fill the block. + * + */ +static void test_buffered_write__doWrite(nitf::Record record, nitf::Reader& reader, + const std::string& inRootFile, + const std::string& outFile, + size_t bufferSize) { - /* - * This test tests the round-trip process of taking an input NITF - * file and writing it to a new file. This includes writing the image - * segments (headers, extensions, and image data). - * - * This example differs from test_writer_3 in that it tests the - * BufferedWriter classes, and writes the entire file as a set of - * configurable sized blocks. The last block may be smaller than the others - * if the data does not fill the block. - * - */ - void doWrite(nitf::Record record, nitf::Reader& reader, - const std::string& inRootFile, - const std::string& outFile, - size_t bufferSize) - { - nitf::BufferedWriter output(outFile, bufferSize); - nitf::Writer writer; - writer.prepareIO(output, record); + nitf::BufferedWriter output(outFile, bufferSize); + nitf::Writer writer; + writer.prepareIO(output, record); - ::doWrite(record, reader, inRootFile, writer); + doWrite(record, reader, inRootFile, writer); - const auto blocksWritten = output.getNumBlocksWritten(); - const auto partialBlocksWritten = output.getNumPartialBlocksWritten(); - output.close(); - TEST_ASSERT_EQ(static_cast(60), blocksWritten); - TEST_ASSERT_EQ(static_cast(53), partialBlocksWritten); - } + const auto blocksWritten = output.getNumBlocksWritten(); + const auto partialBlocksWritten = output.getNumPartialBlocksWritten(); + output.close(); + TEST_ASSERT_EQ(static_cast(60), blocksWritten); + TEST_ASSERT_EQ(static_cast(53), partialBlocksWritten); } TEST_CASE(test_buffered_write_) { - ::testName = testName; - const auto input_file = findInputFile().string(); size_t blockSize = 8192; nitf::Reader reader; nitf::Record record = doRead(input_file, reader); - test_buffered_write::doWrite(record, reader, input_file, output_file, blockSize); + test_buffered_write__doWrite(record, reader, input_file, output_file, blockSize); } From cb0bd9e2011da0aebeda7d903720566ba0111d46 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Tue, 15 Mar 2022 15:15:34 -0400 Subject: [PATCH 017/104] find path to shares --- modules/c++/nitf/source/UnitTests.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/c++/nitf/source/UnitTests.cpp b/modules/c++/nitf/source/UnitTests.cpp index 1db912a97..f6f7d85b7 100644 --- a/modules/c++/nitf/source/UnitTests.cpp +++ b/modules/c++/nitf/source/UnitTests.cpp @@ -78,7 +78,7 @@ static fs::path buildDir(const fs::path& path) const auto exec = fs::path(os.getCurrentExecutable()); const auto argv0 = exec.filename(); - if (argv0 == "Test++.exe") + if ((argv0 == "Test++.exe") || (argv0 == "testhost.exe")) { // Running GTest unit-tests in Visual Studio on Windows if (is_x64_Configuration(cwd)) From 97b4c82ba162d5117616ce9251cbb3c0724422e8 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Tue, 15 Mar 2022 15:22:06 -0400 Subject: [PATCH 018/104] move UnitTest++ to Test++ --- Test++/Test++.vcxproj | 165 ++++++++++-------- .../Test++.vcxproj.filters | 0 Test++/Test.h | 66 +++---- Test++/nitf_Test.h | 27 ++- Test++/nitf_test_create_nitf++.cpp | 35 ++-- Test++/nitf_test_field++.cpp | 9 +- Test++/nitf_test_hash_table_1++.cpp | 9 +- Test++/nitf_test_image_blocker.cpp | 9 +- Test++/nitf_test_image_io.cpp | 14 +- ...est_image_segment_blank_nm_compression.cpp | 11 +- Test++/nitf_test_image_segment_computer.cpp | 9 +- Test++/nitf_test_j2k_loading++.cpp | 13 +- Test++/nitf_test_j2k_read_tile.cpp | 13 +- Test++/nitf_test_nitf_buffer_list.cpp | 9 +- Test++/nitf_test_tre_create++.cpp | 29 +-- Test++/nitf_test_tre_mods.cpp | 161 +++-------------- Test++/nitf_test_tre_read.cpp | 28 +-- Test++/nitf_test_writer_3++.cpp | 29 +-- Test++/nrt_Test.h | 2 +- {UnitTest++ => Test++}/nrt_test_utils.cpp | 0 Test++/packages.config | 4 - Test++/pch.h | 39 +++-- UnitTest++/Test.h | 57 ------ UnitTest++/TestCase.h | 2 - UnitTest++/UnitTest++.vcxproj | 161 ----------------- UnitTest++/nitf_Test.h | 36 ---- UnitTest++/nitf_test_create_nitf++.cpp | 30 ---- UnitTest++/nitf_test_field++.cpp | 13 -- UnitTest++/nitf_test_hash_table_1++.cpp | 13 -- UnitTest++/nitf_test_image_blocker.cpp | 13 -- UnitTest++/nitf_test_image_io.cpp | 14 -- ...est_image_segment_blank_nm_compression.cpp | 13 -- .../nitf_test_image_segment_computer.cpp | 13 -- UnitTest++/nitf_test_j2k_loading++.cpp | 13 -- UnitTest++/nitf_test_j2k_read_tile.cpp | 13 -- UnitTest++/nitf_test_nitf_buffer_list.cpp | 13 -- UnitTest++/nitf_test_tre_create++.cpp | 22 --- UnitTest++/nitf_test_tre_mods.cpp | 50 ------ UnitTest++/nitf_test_tre_read.cpp | 23 --- UnitTest++/nitf_test_writer_3++.cpp | 23 --- UnitTest++/nrt_Test.h | 6 - UnitTest++/pch.cpp | 6 - UnitTest++/pch.h | 61 ------- nitro.sln | 6 - 44 files changed, 314 insertions(+), 968 deletions(-) rename UnitTest++/UnitTest++.vcxproj.filters => Test++/Test++.vcxproj.filters (100%) rename {UnitTest++ => Test++}/nrt_test_utils.cpp (100%) delete mode 100644 Test++/packages.config delete mode 100644 UnitTest++/Test.h delete mode 100644 UnitTest++/TestCase.h delete mode 100644 UnitTest++/UnitTest++.vcxproj delete mode 100644 UnitTest++/nitf_Test.h delete mode 100644 UnitTest++/nitf_test_create_nitf++.cpp delete mode 100644 UnitTest++/nitf_test_field++.cpp delete mode 100644 UnitTest++/nitf_test_hash_table_1++.cpp delete mode 100644 UnitTest++/nitf_test_image_blocker.cpp delete mode 100644 UnitTest++/nitf_test_image_io.cpp delete mode 100644 UnitTest++/nitf_test_image_segment_blank_nm_compression.cpp delete mode 100644 UnitTest++/nitf_test_image_segment_computer.cpp delete mode 100644 UnitTest++/nitf_test_j2k_loading++.cpp delete mode 100644 UnitTest++/nitf_test_j2k_read_tile.cpp delete mode 100644 UnitTest++/nitf_test_nitf_buffer_list.cpp delete mode 100644 UnitTest++/nitf_test_tre_create++.cpp delete mode 100644 UnitTest++/nitf_test_tre_mods.cpp delete mode 100644 UnitTest++/nitf_test_tre_read.cpp delete mode 100644 UnitTest++/nitf_test_writer_3++.cpp delete mode 100644 UnitTest++/nrt_Test.h delete mode 100644 UnitTest++/pch.cpp delete mode 100644 UnitTest++/pch.h diff --git a/Test++/Test++.vcxproj b/Test++/Test++.vcxproj index 70dcafbcb..6fb1a8037 100644 --- a/Test++/Test++.vcxproj +++ b/Test++/Test++.vcxproj @@ -1,5 +1,5 @@ - - + + Debug @@ -11,26 +11,81 @@ + 17.0 {E610F11D-1240-4260-87F8-504B49DB6915} Win32Proj - 10.0.20348.0 - Application + UnitTest + 10.0 + NativeUnitTestProject + + + + DynamicLibrary + true v143 Unicode + false + + + DynamicLibrary + false + v143 + true + Unicode + false - - - - + + + + + + + + + + - - - - - - - + + true + + + false + + + + Use + Level3 + true + $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + _DEBUG;%(PreprocessorDefinitions) + true + pch.h + + + Windows + $(VCInstallDir)UnitTest\lib;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) + + + + + Use + Level3 + true + true + true + $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + NDEBUG;%(PreprocessorDefinitions) + true + pch.h + + + Windows + true + true + $(VCInstallDir)UnitTest\lib;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) + + @@ -51,10 +106,21 @@ Create + + + + + + + + {8f357a19-799e-4971-850e-3f28485c130b} + + {f06550ad-cfc7-40b8-8727-6c82c69a8982} + {53f9f908-c678-4dee-9309-e71c1d03a45f} @@ -73,74 +139,23 @@ {53f9f908-c678-4dee-9309-e71c1e03a45f} + + {d749aa73-4c9a-473d-96bb-070a6d9caa54} + {d1d7fcd3-6130-4504-9da0-9d80506be55e} + + {2baaaca9-a5a4-412c-ae52-b16c2d107f55} + {cf5b4f02-364d-4117-9fb9-6c9c7938e412} + + {78849481-d356-4cc7-b182-31c21f857ed1} + - - - - - - - - Use - pch.h - Disabled - X64;_DEBUG;_CONSOLE;%(PreprocessorDefinitions) - EnableFastChecks - MultiThreadedDebugDLL - EnableAllWarnings - $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;%(AdditionalIncludeDirectories) - true - Guard - true - AdvancedVectorExtensions2 - true - true - - - true - Console - $(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) - - - - - Use - pch.h - X64;NDEBUG;_CONSOLE;%(PreprocessorDefinitions) - MultiThreadedDLL - Level3 - ProgramDatabase - $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;%(AdditionalIncludeDirectories) - true - Guard - true - Speed - AdvancedVectorExtensions2 - true - true - true - - - true - Console - true - true - $(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) - - - - - This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}. - - - \ No newline at end of file diff --git a/UnitTest++/UnitTest++.vcxproj.filters b/Test++/Test++.vcxproj.filters similarity index 100% rename from UnitTest++/UnitTest++.vcxproj.filters rename to Test++/Test++.vcxproj.filters diff --git a/Test++/Test.h b/Test++/Test.h index b8a097895..f5b882401 100644 --- a/Test++/Test.h +++ b/Test++/Test.h @@ -1,51 +1,57 @@ #pragma once -#include "gtest/gtest.h" +#include +#include -// use GTest macros to mimic existing unit-tests +#include "CppUnitTest.h" -#define TEST_ASSERT(X) EXPECT_TRUE(X) - -template -inline void test_assert_eq_(T&& t,U&& u) +namespace Microsoft{ namespace VisualStudio {namespace CppUnitTestFramework +{ +template<> +inline std::wstring ToString(const uint16_t& q) { - EXPECT_EQ(t, u); - EXPECT_EQ(u, t); + return std::to_wstring(q); } -#define TEST_ASSERT_EQ(X1, X2) test_assert_eq_(X1, X2) -#define TEST_ASSERT_EQ_INT(X1, X2) TEST_ASSERT_EQ(X1, X2) +}}} + +#define TEST_ASSERT(X) Assert::IsTrue(X) + template -inline void test_assert_str_eq_(T&& t, U&& u) +inline void test_assert_eq_(T&& t, U&& u) { - EXPECT_STREQ(t.c_str(), u.c_str()); - EXPECT_STREQ(u.c_str(), t.c_str()); + Assert::AreEqual(t, u); + Assert::AreEqual(u, t); } -#define TEST_ASSERT_EQ_STR(X1, X2) { test_assert_str_eq_(std::string(X1), std::string(X2)); } -#define TEST_ASSERT_EQ_FLOAT(X1, X2) EXPECT_FLOAT_EQ(static_cast(X1), static_cast(X2)) - -#define TEST_ASSERT_NULL(X) TEST_ASSERT_EQ((X), nullptr) +#define TEST_ASSERT_EQ(X1, X2) test_assert_eq_(X1, X2); +#define TEST_ASSERT_EQ_INT(X1, X2) TEST_ASSERT_EQ(X2, X1) +#define TEST_ASSERT_EQ_STR(X1, X2) TEST_ASSERT_EQ(std::string(X1), std::string(X2)) +#define TEST_ASSERT_EQ_FLOAT(X1, X2) TEST_ASSERT_EQ(static_cast(X1), static_cast(X2)) -#define TEST_ASSERT_TRUE(X) TEST_ASSERT_EQ((X), true) -#define TEST_ASSERT_FALSE(X) TEST_ASSERT_EQ((X), false) +#define TEST_ASSERT_NULL(X) Assert::IsNull((X)) +#define TEST_ASSERT_NOT_NULL(X) Assert::IsNotNull((X)) +#define TEST_ASSERT_TRUE(X) Assert::IsTrue((X)) +#define TEST_ASSERT_FALSE(X) Assert::IsFalse((X)) template inline void test_assert_not_eq_(T&& t, U&& u) { - EXPECT_NE(t, u); - EXPECT_NE(u, t); + Assert::AreNotEqual(t, u); + Assert::AreNotEqual(u, t); } -#define TEST_ASSERT_NOT_EQ(X1, X2) test_assert_not_eq_(X1, X2) -#define TEST_ASSERT_NOT_NULL(X) TEST_ASSERT_NOT_EQ(X, nullptr) - - -#define TEST_ASSERT_GREATER(X1, X2) EXPECT_GT(X1, X2) +#define TEST_ASSERT_NOT_EQ(X1, X2) test_assert_not_eq_(X1, X2); +template +inline void test_assert_greater_(T&& t, U&& u) +{ + Assert::IsTrue(t > u); +} +#define TEST_ASSERT_GREATER(X1, X2) test_assert_greater_(X1, X2) -#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) EXPECT_NEAR(X1, X2, EPS) +#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) { Assert:AreEqual(X1, X2, EPS); Assert:AreEqual(X1, X1, EPS); } #define TEST_ASSERT_ALMOST_EQ(X1, X2) TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, 0.0001) -#define TEST_ASSERT_EQ_MSG(msg, X1, X2) SCOPED_TRACE(msg); TEST_ASSERT_EQ(X1, X2) +#define TEST_ASSERT_EQ_MSG(msg, X1, X2) Logger::WriteMessage(msg.c_str()); TEST_ASSERT_EQ(X1, X2) -#define TEST_EXCEPTION(X) EXPECT_ANY_THROW((X)) -#define TEST_THROWS(X) EXPECT_ANY_THROW((X)) +#define TEST_EXCEPTION(X) try { (X); TEST_ASSERT_FALSE(false); } catch (...) { TEST_ASSERT_TRUE(true); } +#define TEST_THROWS(X) TEST_EXCEPTION(X) #define TEST_MAIN(X) diff --git a/Test++/nitf_Test.h b/Test++/nitf_Test.h index f67c51ca7..833ebfa7e 100644 --- a/Test++/nitf_Test.h +++ b/Test++/nitf_Test.h @@ -1,6 +1,6 @@ #pragma once -#if defined(GTEST_API_) +#if defined(MS_CPP_UNITTESTFRAMEWORK) #define __TEST_H__ // #include "../nitf/unittests/Test.h" #define __TEST_CASE_H__ // #include "../nitf/unittests/TestCase.h" #endif @@ -8,4 +8,29 @@ #include +#include "import/nitf.h" + #include + +namespace Microsoft{ namespace VisualStudio {namespace CppUnitTestFramework +{ + +template<> +inline std::wstring ToString(const nitf::PixelValueType& q) +{ + return nitf::to_wstring(q); +} + +template<> +inline std::wstring ToString(const nitf::BlockingMode& q) +{ + return nitf::to_wstring(q); +} + +template<> +inline std::wstring ToString(const nitf::ImageCompression& q) +{ + return nitf::to_wstring(q); +} + +}}} \ No newline at end of file diff --git a/Test++/nitf_test_create_nitf++.cpp b/Test++/nitf_test_create_nitf++.cpp index 18d92403f..e498c6f68 100644 --- a/Test++/nitf_test_create_nitf++.cpp +++ b/Test++/nitf_test_create_nitf++.cpp @@ -4,32 +4,27 @@ #include "nitf_Test.h" -struct nitf_test_create_nitf__ : public ::testing::Test { +CODA_OSS_disable_warning_push +#if _MSC_VER +#pragma warning(disable: 4464) // relative include path contains '..' +#endif +#include +CODA_OSS_disable_warning_pop + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_create_nitf__) { +public: nitf_test_create_nitf__() { // initialization code here - //const std::string NITF_PLUGIN_PATH = R"(C:\Users\jdsmith\source\repos\nitro\x64\Debug\share\nitf\plugins)"; sys::OS().setEnv("NITF_PLUGIN_PATH", nitf::Test::buildPluginsDir(), true /*overwrite*/); } - void SetUp() { - // code here will execute just before the test ensues - } - - void TearDown() { - // code here will be called just after the test completes - // ok to through exceptions from here if need be - } - - ~nitf_test_create_nitf__() { - // cleanup any pending stuff, but no exceptions allowed - } - + ~nitf_test_create_nitf__() = default; nitf_test_create_nitf__(const nitf_test_create_nitf__&) = delete; nitf_test_create_nitf__& operator=(const nitf_test_create_nitf__&) = delete; + #define TEST_CASE(X) TEST_METHOD(X) + #include "nitf/unittests/test_create_nitf++.cpp" - // put in any custom data members that you need -}; - -#define TEST_CASE(X) TEST_F(nitf_test_create_nitf__, X) -#include "nitf/unittests/test_create_nitf++.cpp" +}; \ No newline at end of file diff --git a/Test++/nitf_test_field++.cpp b/Test++/nitf_test_field++.cpp index 9317360e7..416032b1c 100644 --- a/Test++/nitf_test_field++.cpp +++ b/Test++/nitf_test_field++.cpp @@ -2,5 +2,12 @@ #include "nitf_Test.h" -#define TEST_CASE(X) TEST(nitf_test_field__, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_field__) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_field++.cpp" + +}; \ No newline at end of file diff --git a/Test++/nitf_test_hash_table_1++.cpp b/Test++/nitf_test_hash_table_1++.cpp index fcef47edd..62fece1c6 100644 --- a/Test++/nitf_test_hash_table_1++.cpp +++ b/Test++/nitf_test_hash_table_1++.cpp @@ -2,5 +2,12 @@ #include "nitf_Test.h" -#define TEST_CASE(X) TEST(nitf_test_hash_table_1__, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_hash_table_1__) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_hash_table_1++.cpp" + +}; \ No newline at end of file diff --git a/Test++/nitf_test_image_blocker.cpp b/Test++/nitf_test_image_blocker.cpp index 2c7a6e1d6..be61b895e 100644 --- a/Test++/nitf_test_image_blocker.cpp +++ b/Test++/nitf_test_image_blocker.cpp @@ -2,5 +2,12 @@ #include "nitf_Test.h" -#define TEST_CASE(X) TEST(test_image_blocker, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(test_image_blocker) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_image_blocker.cpp" + +}; \ No newline at end of file diff --git a/Test++/nitf_test_image_io.cpp b/Test++/nitf_test_image_io.cpp index 98ccf9c4e..b23256d8f 100644 --- a/Test++/nitf_test_image_io.cpp +++ b/Test++/nitf_test_image_io.cpp @@ -1,10 +1,14 @@ #include "pch.h" -#include -#include -#undef interface - #include "nitf_Test.h" -#define TEST_CASE(X) TEST(test_image_loading__, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(test_image_loading__) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_image_loading++.cpp" + +}; +std::string test_image_loading__::argv0; diff --git a/Test++/nitf_test_image_segment_blank_nm_compression.cpp b/Test++/nitf_test_image_segment_blank_nm_compression.cpp index 13975ff23..47a54fd25 100644 --- a/Test++/nitf_test_image_segment_blank_nm_compression.cpp +++ b/Test++/nitf_test_image_segment_blank_nm_compression.cpp @@ -2,5 +2,12 @@ #include "nitf_Test.h" -#define TEST_CASE(X) TEST(test_image_segment_blank_nm_compression, X) -#include "nitf/unittests/test_image_segment_blank_nm_compression.cpp" \ No newline at end of file +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(test_image_segment_blank_nm_compression) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) +#include "nitf/unittests/test_image_segment_blank_nm_compression.cpp" + +}; \ No newline at end of file diff --git a/Test++/nitf_test_image_segment_computer.cpp b/Test++/nitf_test_image_segment_computer.cpp index 16346f860..3129bc58f 100644 --- a/Test++/nitf_test_image_segment_computer.cpp +++ b/Test++/nitf_test_image_segment_computer.cpp @@ -2,5 +2,12 @@ #include "nitf_Test.h" -#define TEST_CASE(X) TEST(test_image_segment_computer, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(test_image_segment_computer) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_image_segment_computer.cpp" + +}; \ No newline at end of file diff --git a/Test++/nitf_test_j2k_loading++.cpp b/Test++/nitf_test_j2k_loading++.cpp index 278a82ad7..bcd213237 100644 --- a/Test++/nitf_test_j2k_loading++.cpp +++ b/Test++/nitf_test_j2k_loading++.cpp @@ -1,10 +1,13 @@ #include "pch.h" -#include -#include -#undef interface - #include "nitf_Test.h" -#define TEST_CASE(X) TEST(test_j2k_loading__, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(test_j2k_loading__) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_j2k_loading++.cpp" + +}; \ No newline at end of file diff --git a/Test++/nitf_test_j2k_read_tile.cpp b/Test++/nitf_test_j2k_read_tile.cpp index 91275c7ef..c7d2e83d6 100644 --- a/Test++/nitf_test_j2k_read_tile.cpp +++ b/Test++/nitf_test_j2k_read_tile.cpp @@ -1,10 +1,13 @@ #include "pch.h" -#include -#include -#undef interface - #include "nitf_Test.h" -#define TEST_CASE(X) TEST(test_j2k_read_tile, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(test_j2k_read_tile) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_j2k_read_tile.cpp" + +}; \ No newline at end of file diff --git a/Test++/nitf_test_nitf_buffer_list.cpp b/Test++/nitf_test_nitf_buffer_list.cpp index 08f39996a..71f19a07e 100644 --- a/Test++/nitf_test_nitf_buffer_list.cpp +++ b/Test++/nitf_test_nitf_buffer_list.cpp @@ -2,5 +2,12 @@ #include "nitf_Test.h" -#define TEST_CASE(X) TEST(test_nitf_buffer_list, X) +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(test_nitf_buffer_list) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_nitf_buffer_list.cpp" + +}; \ No newline at end of file diff --git a/Test++/nitf_test_tre_create++.cpp b/Test++/nitf_test_tre_create++.cpp index 16121a611..f05067fe6 100644 --- a/Test++/nitf_test_tre_create++.cpp +++ b/Test++/nitf_test_tre_create++.cpp @@ -4,32 +4,19 @@ #include "nitf_Test.h" -struct nitf_test_tre_create__ : public ::testing::Test { +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_tre_create__) { +public: nitf_test_tre_create__() { // initialization code here - //const std::string NITF_PLUGIN_PATH = R"(C:\Users\jdsmith\source\repos\nitro\x64\Debug\share\nitf\plugins)"; sys::OS().setEnv("NITF_PLUGIN_PATH", nitf::Test::buildPluginsDir(), true /*overwrite*/); } - - void SetUp() { - // code here will execute just before the test ensues - } - - void TearDown() { - // code here will be called just after the test completes - // ok to through exceptions from here if need be - } - - ~nitf_test_tre_create__() { - // cleanup any pending stuff, but no exceptions allowed - } - - + ~nitf_test_tre_create__() = default; nitf_test_tre_create__(const nitf_test_tre_create__&) = delete; nitf_test_tre_create__& operator=(const nitf_test_tre_create__&) = delete; - // put in any custom data members that you need -}; - -#define TEST_CASE(X) TEST_F(nitf_test_tre_create__, X) +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_tre_create++.cpp" + +}; \ No newline at end of file diff --git a/Test++/nitf_test_tre_mods.cpp b/Test++/nitf_test_tre_mods.cpp index b8da598b8..5a4962029 100644 --- a/Test++/nitf_test_tre_mods.cpp +++ b/Test++/nitf_test_tre_mods.cpp @@ -1,165 +1,50 @@ #include "pch.h" -#include - -#include -#include +#include #include "nitf_Test.h" -namespace fs = std::filesystem; - -static bool is_x64_Configuration(const fs::path& path) // "Configuration" is typically "Debug" or "Release" -{ - const std::string build_configuration = sys::OS().getSpecialEnv("Configuration"); - const auto Configuration = path.filename(); - const auto path_parent_path = path.parent_path(); - const auto x64 = path_parent_path.filename(); - return (Configuration == build_configuration) && (x64 == "x64"); -} - -static bool is_install_unittests(const fs::path& path) -{ - const auto unittests = path.filename(); - const auto path_parent_path = path.parent_path(); - const auto install = path_parent_path.filename(); - return (unittests == "unittests") && (install == "install"); -} -static bool is_install_tests(const fs::path& path) -{ - const auto tests = path.filename(); - const auto path_parent_path = path.parent_path(); - const auto install = path_parent_path.filename(); - return (tests == "tests") && (install == "install"); -} - -static fs::path buildDir(const fs::path& path) -{ - const auto cwd = fs::current_path(); - - const sys::OS os; - const auto exec = fs::path(os.getCurrentExecutable()); - const auto argv0 = exec.filename(); - if (argv0 == "Test++.exe") - { - // Running GTest unit-tests in Visual Studio on Windows - if (is_x64_Configuration(cwd)) - { - return cwd / path; - } - } - - if (argv0 == "unittests.exe") - { - // stand-alone unittest executable on Windows (ends in .EXE) - const auto parent_path = exec.parent_path(); - if (is_x64_Configuration(parent_path)) - { - const auto parent_path_ = parent_path.parent_path().parent_path(); - return parent_path_ / "dev" / "tests" / "images"; - } - } +using namespace Microsoft::VisualStudio::CppUnitTestFramework; - // stand-alone unit-test on Linux - const auto exec_dir = exec.parent_path(); - if (is_install_unittests(exec_dir)) - { - const auto install = exec_dir.parent_path(); - return install / "unittests" / "data"; - } - if (is_install_tests(exec_dir)) - { - const auto install = exec_dir.parent_path(); - return install / "unittests" / "data"; - } - - if (argv0 == "unittests") - { - // stand-alone unittest executable on Linux - const auto bin = exec.parent_path(); - if (bin.filename() == "bin") - { - const auto unittests = bin.parent_path(); - return unittests / "unittests" / "data"; - } +TEST_CLASS(nitf_test_tre_mods) { +public: + nitf_test_tre_mods() { + // initialization code here + sys::OS().setEnv("NITF_PLUGIN_PATH", nitf::Test::buildPluginsDir(), true /*overwrite*/); } - - //fprintf(stderr, "cwd = %s\n", cwd.c_str()); - //fprintf(stderr, "exec = %s\n", exec.c_str()); - - return cwd; -} - -static fs::path buildPluginsDir() -{ - return buildDir(fs::path("share") / "nitf" / "plugins"); -} - -struct nitf_test_tre_mods : public ::testing::Test { - nitf_test_tre_mods() { - // initialization code here - //const std::string NITF_PLUGIN_PATH = R"(C:\Users\jdsmith\source\repos\nitro\x64\Debug\share\nitf\plugins)"; - const std::string putenv_ = "NITF_PLUGIN_PATH=" + buildPluginsDir().string(); - _putenv(putenv_.c_str()); - } - - void SetUp() { - // code here will execute just before the test ensues - } - - void TearDown() { - // code here will be called just after the test completes - // ok to through exceptions from here if need be - } - - ~nitf_test_tre_mods() { - // cleanup any pending stuff, but no exceptions allowed - } - + ~nitf_test_tre_mods() = default; nitf_test_tre_mods(const nitf_test_tre_mods&) = delete; nitf_test_tre_mods& operator=(const nitf_test_tre_mods&) = delete; - - // put in any custom data members that you need -}; - -#define TEST_CASE(X) TEST_F(nitf_test_tre_mods, X) +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_tre_mods++.cpp" +}; // Be sure this runs AFTER the tre_mods tests ... not really sure why ... #undef TEST_CASE -#define TEST_CASE(X) TEST(test_image_writer, X) +TEST_CLASS(test_image_writer) { +public: + +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_image_writer.cpp" +}; +std::filesystem::path test_image_writer::argv0; +const std::filesystem::path test_image_writer::file = __FILE__; -struct test_load_plugins : public ::testing::Test { +#undef TEST_CASE +TEST_CLASS(test_load_plugins) { +public: test_load_plugins() { // initialization code here - //const std::string NITF_PLUGIN_PATH = R"(C:\Users\jdsmith\source\repos\nitro\x64\Debug\share\nitf\plugins)"; sys::OS().setEnv("NITF_PLUGIN_PATH", nitf::Test::buildPluginsDir(), true /*overwrite*/); } - - void SetUp() { - // code here will execute just before the test ensues - } - - void TearDown() { - // code here will be called just after the test completes - // ok to through exceptions from here if need be - } - - ~test_load_plugins() { - // cleanup any pending stuff, but no exceptions allowed - } - + ~test_load_plugins() = default; test_load_plugins(const test_load_plugins&) = delete; test_load_plugins& operator=(const test_load_plugins&) = delete; +#define TEST_CASE(X) TEST_METHOD(X) +#include "nitf/unittests/test_load_plugins.cpp" - // put in any custom data members that you need }; - -#undef TEST_CASE -#define TEST_CASE(X) TEST_F(test_load_plugins, X) -#include "nitf/unittests/test_load_plugins.cpp" \ No newline at end of file diff --git a/Test++/nitf_test_tre_read.cpp b/Test++/nitf_test_tre_read.cpp index f7ec0cfe5..f02967d46 100644 --- a/Test++/nitf_test_tre_read.cpp +++ b/Test++/nitf_test_tre_read.cpp @@ -4,32 +4,20 @@ #include "nitf_Test.h" -struct test_tre_read : public ::testing::Test { +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(test_tre_read) { +public: test_tre_read() { // initialization code here - //const std::string NITF_PLUGIN_PATH = R"(C:\Users\jdsmith\source\repos\nitro\x64\Debug\share\nitf\plugins)"; sys::OS().setEnv("NITF_PLUGIN_PATH", nitf::Test::buildPluginsDir(), true /*overwrite*/); } - - void SetUp() { - // code here will execute just before the test ensues - } - - void TearDown() { - // code here will be called just after the test completes - // ok to through exceptions from here if need be - } - - ~test_tre_read() { - // cleanup any pending stuff, but no exceptions allowed - } - + ~test_tre_read() = default; test_tre_read(const test_tre_read&) = delete; test_tre_read& operator=(const test_tre_read&) = delete; +#define TEST_CASE(X) TEST_METHOD(X) +#include "nitf/unittests/test_tre_read.cpp" - // put in any custom data members that you need }; - -#define TEST_CASE(X) TEST_F(test_tre_read, X) -#include "nitf/unittests/test_tre_read.cpp" +const char* test_tre_read::argv0 = nullptr; diff --git a/Test++/nitf_test_writer_3++.cpp b/Test++/nitf_test_writer_3++.cpp index ce71bb352..10bfc481e 100644 --- a/Test++/nitf_test_writer_3++.cpp +++ b/Test++/nitf_test_writer_3++.cpp @@ -4,31 +4,20 @@ #include "nitf_Test.h" -struct nitf_test_writer_3__ : public ::testing::Test { +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +TEST_CLASS(nitf_test_writer_3__) { +public: nitf_test_writer_3__() { // initialization code here - //const std::string NITF_PLUGIN_PATH = R"(C:\Users\jdsmith\source\repos\nitro\x64\Debug\share\nitf\plugins)"; sys::OS().setEnv("NITF_PLUGIN_PATH", nitf::Test::buildPluginsDir(), true /*overwrite*/); } - - void SetUp() { - // code here will execute just before the test ensues - } - - void TearDown() { - // code here will be called just after the test completes - // ok to through exceptions from here if need be - } - - ~nitf_test_writer_3__() { - // cleanup any pending stuff, but no exceptions allowed - } - + ~nitf_test_writer_3__() = default; nitf_test_writer_3__(const nitf_test_writer_3__&) = delete; nitf_test_writer_3__& operator=(const nitf_test_writer_3__&) = delete; - // put in any custom data members that you need -}; - -#define TEST_CASE(X) TEST_F(nitf_test_writer_3__, X) +#define TEST_CASE(X) TEST_METHOD(X) #include "nitf/unittests/test_writer_3++.cpp" + +}; +std::string nitf_test_writer_3__::argv0; \ No newline at end of file diff --git a/Test++/nrt_Test.h b/Test++/nrt_Test.h index 576ef9e17..7f0d7a36f 100644 --- a/Test++/nrt_Test.h +++ b/Test++/nrt_Test.h @@ -1,6 +1,6 @@ #pragma once -#if defined(GTEST_API_) +#if defined(MS_CPP_UNITTESTFRAMEWORK) #define __TEST_H__ // #include "../nrt/unittests/Test.h" #endif #include "Test.h" diff --git a/UnitTest++/nrt_test_utils.cpp b/Test++/nrt_test_utils.cpp similarity index 100% rename from UnitTest++/nrt_test_utils.cpp rename to Test++/nrt_test_utils.cpp diff --git a/Test++/packages.config b/Test++/packages.config deleted file mode 100644 index 34505441d..000000000 --- a/Test++/packages.config +++ /dev/null @@ -1,4 +0,0 @@ - - - - \ No newline at end of file diff --git a/Test++/pch.h b/Test++/pch.h index 55be39546..01fd2e7fa 100644 --- a/Test++/pch.h +++ b/Test++/pch.h @@ -1,7 +1,11 @@ -// -// pch.h -// Header for standard system include files. -// +// pch.h: This is a precompiled header file. +// Files listed below are compiled only once, improving build performance for future builds. +// This also affects IntelliSense performance, including code completion and many code browsing features. +// However, files listed here are ALL re-compiled if any one of them is updated between builds. +// Do not add files here that you will be updating frequently as this negates the performance advantage. + +#ifndef PCH_H +#define PCH_H #pragma once #pragma warning(disable: 4820) // '...': '...' bytes padding added after data member '...' @@ -25,6 +29,8 @@ #pragma warning(push) #pragma warning(disable: 4464) // relative include path contains '..' #include +#include +#include #pragma warning(disable: 5031) // #pragma warning(pop): likely mismatch, popping warning state pushed in different file #pragma comment(lib, "io-c++") #pragma comment(lib, "except-c++") @@ -33,20 +39,23 @@ #pragma warning(pop) #pragma warning(push) -#pragma warning(disable: 4388) // '...': signed / unsigned mismatch -#pragma warning(disable: 4389) // '...': signed / unsigned mismatch -#pragma warning(disable: 4800) // Implicit conversion from '...' to bool. Possible information loss -#pragma warning(disable: 4625) // '...': copy constructor was implicitly defined as deleted -#pragma warning(disable: 4626) // '...': assignment operator was implicitly defined as deleted -#pragma warning(disable: 5026) // '...': move constructor was implicitly defined as deleted -#pragma warning(disable: 5027) // '...': move assignment operator was implicitly defined as deleted -#include "gtest/gtest.h" +#include "CppUnitTest.h" #pragma warning(pop) -#include -#include +#include + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include #include "nitf_Test.h" #include "Test.h" - +#endif //PCH_H diff --git a/UnitTest++/Test.h b/UnitTest++/Test.h deleted file mode 100644 index f5b882401..000000000 --- a/UnitTest++/Test.h +++ /dev/null @@ -1,57 +0,0 @@ -#pragma once - -#include -#include - -#include "CppUnitTest.h" - -namespace Microsoft{ namespace VisualStudio {namespace CppUnitTestFramework -{ -template<> -inline std::wstring ToString(const uint16_t& q) -{ - return std::to_wstring(q); -} -}}} - -#define TEST_ASSERT(X) Assert::IsTrue(X) - -template -inline void test_assert_eq_(T&& t, U&& u) -{ - Assert::AreEqual(t, u); - Assert::AreEqual(u, t); -} -#define TEST_ASSERT_EQ(X1, X2) test_assert_eq_(X1, X2); -#define TEST_ASSERT_EQ_INT(X1, X2) TEST_ASSERT_EQ(X2, X1) -#define TEST_ASSERT_EQ_STR(X1, X2) TEST_ASSERT_EQ(std::string(X1), std::string(X2)) -#define TEST_ASSERT_EQ_FLOAT(X1, X2) TEST_ASSERT_EQ(static_cast(X1), static_cast(X2)) - -#define TEST_ASSERT_NULL(X) Assert::IsNull((X)) -#define TEST_ASSERT_NOT_NULL(X) Assert::IsNotNull((X)) -#define TEST_ASSERT_TRUE(X) Assert::IsTrue((X)) -#define TEST_ASSERT_FALSE(X) Assert::IsFalse((X)) - -template -inline void test_assert_not_eq_(T&& t, U&& u) -{ - Assert::AreNotEqual(t, u); - Assert::AreNotEqual(u, t); -} -#define TEST_ASSERT_NOT_EQ(X1, X2) test_assert_not_eq_(X1, X2); -template -inline void test_assert_greater_(T&& t, U&& u) -{ - Assert::IsTrue(t > u); -} -#define TEST_ASSERT_GREATER(X1, X2) test_assert_greater_(X1, X2) - -#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) { Assert:AreEqual(X1, X2, EPS); Assert:AreEqual(X1, X1, EPS); } -#define TEST_ASSERT_ALMOST_EQ(X1, X2) TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, 0.0001) - -#define TEST_ASSERT_EQ_MSG(msg, X1, X2) Logger::WriteMessage(msg.c_str()); TEST_ASSERT_EQ(X1, X2) - -#define TEST_EXCEPTION(X) try { (X); TEST_ASSERT_FALSE(false); } catch (...) { TEST_ASSERT_TRUE(true); } -#define TEST_THROWS(X) TEST_EXCEPTION(X) - -#define TEST_MAIN(X) diff --git a/UnitTest++/TestCase.h b/UnitTest++/TestCase.h deleted file mode 100644 index c9583fa66..000000000 --- a/UnitTest++/TestCase.h +++ /dev/null @@ -1,2 +0,0 @@ -#pragma once -#include "Test.h" diff --git a/UnitTest++/UnitTest++.vcxproj b/UnitTest++/UnitTest++.vcxproj deleted file mode 100644 index dad524a24..000000000 --- a/UnitTest++/UnitTest++.vcxproj +++ /dev/null @@ -1,161 +0,0 @@ - - - - - Debug - x64 - - - Release - x64 - - - - 17.0 - {B19FE958-B3A5-4457-9919-F4F81F28CF95} - Win32Proj - UnitTest - 10.0 - NativeUnitTestProject - - - - DynamicLibrary - true - v143 - Unicode - false - - - DynamicLibrary - false - v143 - true - Unicode - false - - - - - - - - - - - - - - - true - - - false - - - - Use - Level3 - true - $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) - _DEBUG;%(PreprocessorDefinitions) - true - pch.h - - - Windows - $(VCInstallDir)UnitTest\lib;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) - - - - - Use - Level3 - true - true - true - $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) - NDEBUG;%(PreprocessorDefinitions) - true - pch.h - - - Windows - true - true - $(VCInstallDir)UnitTest\lib;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) - - - - - - - - - - - - - - - - - - - Create - Create - - - - - - - - - - - - - {8f357a19-799e-4971-850e-3f28485c130b} - - - {f06550ad-cfc7-40b8-8727-6c82c69a8982} - - - {53f9f908-c678-4dee-9309-e71c1d03a45f} - - - {730b1e6e-2469-4f9e-b093-d0c6262453c9} - - - {51d7b426-899e-428d-9f69-5ddac9e403fb} - - - {12aa0752-4ee3-4e0a-85af-0e5deadbf343} - - - {023de06d-3967-4406-b1b8-032118bb2552} - - - {53f9f908-c678-4dee-9309-e71c1e03a45f} - - - {d749aa73-4c9a-473d-96bb-070a6d9caa54} - - - {d1d7fcd3-6130-4504-9da0-9d80506be55e} - - - {2baaaca9-a5a4-412c-ae52-b16c2d107f55} - - - {cf5b4f02-364d-4117-9fb9-6c9c7938e412} - - - {78849481-d356-4cc7-b182-31c21f857ed1} - - - - - - \ No newline at end of file diff --git a/UnitTest++/nitf_Test.h b/UnitTest++/nitf_Test.h deleted file mode 100644 index 833ebfa7e..000000000 --- a/UnitTest++/nitf_Test.h +++ /dev/null @@ -1,36 +0,0 @@ -#pragma once - -#if defined(MS_CPP_UNITTESTFRAMEWORK) -#define __TEST_H__ // #include "../nitf/unittests/Test.h" -#define __TEST_CASE_H__ // #include "../nitf/unittests/TestCase.h" -#endif -#include "Test.h" - -#include - -#include "import/nitf.h" - -#include - -namespace Microsoft{ namespace VisualStudio {namespace CppUnitTestFramework -{ - -template<> -inline std::wstring ToString(const nitf::PixelValueType& q) -{ - return nitf::to_wstring(q); -} - -template<> -inline std::wstring ToString(const nitf::BlockingMode& q) -{ - return nitf::to_wstring(q); -} - -template<> -inline std::wstring ToString(const nitf::ImageCompression& q) -{ - return nitf::to_wstring(q); -} - -}}} \ No newline at end of file diff --git a/UnitTest++/nitf_test_create_nitf++.cpp b/UnitTest++/nitf_test_create_nitf++.cpp deleted file mode 100644 index e498c6f68..000000000 --- a/UnitTest++/nitf_test_create_nitf++.cpp +++ /dev/null @@ -1,30 +0,0 @@ -#include "pch.h" - -#include - -#include "nitf_Test.h" - -CODA_OSS_disable_warning_push -#if _MSC_VER -#pragma warning(disable: 4464) // relative include path contains '..' -#endif -#include -CODA_OSS_disable_warning_pop - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_create_nitf__) { -public: - nitf_test_create_nitf__() { - // initialization code here - sys::OS().setEnv("NITF_PLUGIN_PATH", nitf::Test::buildPluginsDir(), true /*overwrite*/); - } - - ~nitf_test_create_nitf__() = default; - nitf_test_create_nitf__(const nitf_test_create_nitf__&) = delete; - nitf_test_create_nitf__& operator=(const nitf_test_create_nitf__&) = delete; - - #define TEST_CASE(X) TEST_METHOD(X) - #include "nitf/unittests/test_create_nitf++.cpp" - -}; \ No newline at end of file diff --git a/UnitTest++/nitf_test_field++.cpp b/UnitTest++/nitf_test_field++.cpp deleted file mode 100644 index 416032b1c..000000000 --- a/UnitTest++/nitf_test_field++.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_field__) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_field++.cpp" - -}; \ No newline at end of file diff --git a/UnitTest++/nitf_test_hash_table_1++.cpp b/UnitTest++/nitf_test_hash_table_1++.cpp deleted file mode 100644 index 62fece1c6..000000000 --- a/UnitTest++/nitf_test_hash_table_1++.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_hash_table_1__) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_hash_table_1++.cpp" - -}; \ No newline at end of file diff --git a/UnitTest++/nitf_test_image_blocker.cpp b/UnitTest++/nitf_test_image_blocker.cpp deleted file mode 100644 index be61b895e..000000000 --- a/UnitTest++/nitf_test_image_blocker.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(test_image_blocker) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_image_blocker.cpp" - -}; \ No newline at end of file diff --git a/UnitTest++/nitf_test_image_io.cpp b/UnitTest++/nitf_test_image_io.cpp deleted file mode 100644 index b23256d8f..000000000 --- a/UnitTest++/nitf_test_image_io.cpp +++ /dev/null @@ -1,14 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(test_image_loading__) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_image_loading++.cpp" - -}; -std::string test_image_loading__::argv0; diff --git a/UnitTest++/nitf_test_image_segment_blank_nm_compression.cpp b/UnitTest++/nitf_test_image_segment_blank_nm_compression.cpp deleted file mode 100644 index 47a54fd25..000000000 --- a/UnitTest++/nitf_test_image_segment_blank_nm_compression.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(test_image_segment_blank_nm_compression) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_image_segment_blank_nm_compression.cpp" - -}; \ No newline at end of file diff --git a/UnitTest++/nitf_test_image_segment_computer.cpp b/UnitTest++/nitf_test_image_segment_computer.cpp deleted file mode 100644 index 3129bc58f..000000000 --- a/UnitTest++/nitf_test_image_segment_computer.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(test_image_segment_computer) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_image_segment_computer.cpp" - -}; \ No newline at end of file diff --git a/UnitTest++/nitf_test_j2k_loading++.cpp b/UnitTest++/nitf_test_j2k_loading++.cpp deleted file mode 100644 index bcd213237..000000000 --- a/UnitTest++/nitf_test_j2k_loading++.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(test_j2k_loading__) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_j2k_loading++.cpp" - -}; \ No newline at end of file diff --git a/UnitTest++/nitf_test_j2k_read_tile.cpp b/UnitTest++/nitf_test_j2k_read_tile.cpp deleted file mode 100644 index c7d2e83d6..000000000 --- a/UnitTest++/nitf_test_j2k_read_tile.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(test_j2k_read_tile) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_j2k_read_tile.cpp" - -}; \ No newline at end of file diff --git a/UnitTest++/nitf_test_nitf_buffer_list.cpp b/UnitTest++/nitf_test_nitf_buffer_list.cpp deleted file mode 100644 index 71f19a07e..000000000 --- a/UnitTest++/nitf_test_nitf_buffer_list.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(test_nitf_buffer_list) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_nitf_buffer_list.cpp" - -}; \ No newline at end of file diff --git a/UnitTest++/nitf_test_tre_create++.cpp b/UnitTest++/nitf_test_tre_create++.cpp deleted file mode 100644 index f05067fe6..000000000 --- a/UnitTest++/nitf_test_tre_create++.cpp +++ /dev/null @@ -1,22 +0,0 @@ -#include "pch.h" - -#include - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_tre_create__) { -public: - nitf_test_tre_create__() { - // initialization code here - sys::OS().setEnv("NITF_PLUGIN_PATH", nitf::Test::buildPluginsDir(), true /*overwrite*/); - } - ~nitf_test_tre_create__() = default; - nitf_test_tre_create__(const nitf_test_tre_create__&) = delete; - nitf_test_tre_create__& operator=(const nitf_test_tre_create__&) = delete; - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_tre_create++.cpp" - -}; \ No newline at end of file diff --git a/UnitTest++/nitf_test_tre_mods.cpp b/UnitTest++/nitf_test_tre_mods.cpp deleted file mode 100644 index 5a4962029..000000000 --- a/UnitTest++/nitf_test_tre_mods.cpp +++ /dev/null @@ -1,50 +0,0 @@ -#include "pch.h" - -#include - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_tre_mods) { -public: - nitf_test_tre_mods() { - // initialization code here - sys::OS().setEnv("NITF_PLUGIN_PATH", nitf::Test::buildPluginsDir(), true /*overwrite*/); - } - ~nitf_test_tre_mods() = default; - nitf_test_tre_mods(const nitf_test_tre_mods&) = delete; - nitf_test_tre_mods& operator=(const nitf_test_tre_mods&) = delete; - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_tre_mods++.cpp" - -}; - -// Be sure this runs AFTER the tre_mods tests ... not really sure why ... -#undef TEST_CASE -TEST_CLASS(test_image_writer) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_image_writer.cpp" - -}; -std::filesystem::path test_image_writer::argv0; -const std::filesystem::path test_image_writer::file = __FILE__; - -#undef TEST_CASE -TEST_CLASS(test_load_plugins) { -public: - test_load_plugins() { - // initialization code here - sys::OS().setEnv("NITF_PLUGIN_PATH", nitf::Test::buildPluginsDir(), true /*overwrite*/); - } - ~test_load_plugins() = default; - test_load_plugins(const test_load_plugins&) = delete; - test_load_plugins& operator=(const test_load_plugins&) = delete; - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_load_plugins.cpp" - -}; diff --git a/UnitTest++/nitf_test_tre_read.cpp b/UnitTest++/nitf_test_tre_read.cpp deleted file mode 100644 index f02967d46..000000000 --- a/UnitTest++/nitf_test_tre_read.cpp +++ /dev/null @@ -1,23 +0,0 @@ -#include "pch.h" - -#include - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(test_tre_read) { -public: - test_tre_read() { - // initialization code here - sys::OS().setEnv("NITF_PLUGIN_PATH", nitf::Test::buildPluginsDir(), true /*overwrite*/); - } - ~test_tre_read() = default; - test_tre_read(const test_tre_read&) = delete; - test_tre_read& operator=(const test_tre_read&) = delete; - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_tre_read.cpp" - -}; -const char* test_tre_read::argv0 = nullptr; diff --git a/UnitTest++/nitf_test_writer_3++.cpp b/UnitTest++/nitf_test_writer_3++.cpp deleted file mode 100644 index 10bfc481e..000000000 --- a/UnitTest++/nitf_test_writer_3++.cpp +++ /dev/null @@ -1,23 +0,0 @@ -#include "pch.h" - -#include - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_writer_3__) { -public: - nitf_test_writer_3__() { - // initialization code here - sys::OS().setEnv("NITF_PLUGIN_PATH", nitf::Test::buildPluginsDir(), true /*overwrite*/); - } - ~nitf_test_writer_3__() = default; - nitf_test_writer_3__(const nitf_test_writer_3__&) = delete; - nitf_test_writer_3__& operator=(const nitf_test_writer_3__&) = delete; - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_writer_3++.cpp" - -}; -std::string nitf_test_writer_3__::argv0; \ No newline at end of file diff --git a/UnitTest++/nrt_Test.h b/UnitTest++/nrt_Test.h deleted file mode 100644 index 7f0d7a36f..000000000 --- a/UnitTest++/nrt_Test.h +++ /dev/null @@ -1,6 +0,0 @@ -#pragma once - -#if defined(MS_CPP_UNITTESTFRAMEWORK) -#define __TEST_H__ // #include "../nrt/unittests/Test.h" -#endif -#include "Test.h" diff --git a/UnitTest++/pch.cpp b/UnitTest++/pch.cpp deleted file mode 100644 index 97b544ec1..000000000 --- a/UnitTest++/pch.cpp +++ /dev/null @@ -1,6 +0,0 @@ -// -// pch.cpp -// Include the standard header and generate the precompiled header. -// - -#include "pch.h" diff --git a/UnitTest++/pch.h b/UnitTest++/pch.h deleted file mode 100644 index 01fd2e7fa..000000000 --- a/UnitTest++/pch.h +++ /dev/null @@ -1,61 +0,0 @@ -// pch.h: This is a precompiled header file. -// Files listed below are compiled only once, improving build performance for future builds. -// This also affects IntelliSense performance, including code completion and many code browsing features. -// However, files listed here are ALL re-compiled if any one of them is updated between builds. -// Do not add files here that you will be updating frequently as this negates the performance advantage. - -#ifndef PCH_H -#define PCH_H -#pragma once - -#pragma warning(disable: 4820) // '...': '...' bytes padding added after data member '...' -#pragma warning(disable: 4710) // '...': function not inlined -#pragma warning(disable: 5045) // Compiler will insert Spectre mitigation for memory load if / Qspectre switch specified -#pragma warning(disable: 4668) // '...' is not defined as a preprocessor macro, replacing with '...' for '...' -// TODO: get rid of these someday? -#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to 'extern "C"' function under -EHc. Undefined behavior may occur if this function throws an exception. -#pragma warning(disable: 4514) // '...': unreferenced inline function has been removed - -#pragma warning(push) -#pragma warning(disable: 4464) // relative include path contains '..' -#include "../modules/c++/cpp.h" -#pragma warning(pop) -#pragma comment(lib, "ws2_32") - -// We're building in Visual Studio ... used to control where we get a little bit of config info -#define NITRO_PCH 1 - -#pragma warning(disable: 5032) // detected #pragma warning(push) with no corresponding #pragma warning(pop) -#pragma warning(push) -#pragma warning(disable: 4464) // relative include path contains '..' -#include -#include -#include -#pragma warning(disable: 5031) // #pragma warning(pop): likely mismatch, popping warning state pushed in different file -#pragma comment(lib, "io-c++") -#pragma comment(lib, "except-c++") -#pragma comment(lib, "sys-c++") -#pragma comment(lib, "str-c++") -#pragma warning(pop) - -#pragma warning(push) -#include "CppUnitTest.h" -#pragma warning(pop) - -#include - -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include - -#include "nitf_Test.h" -#include "Test.h" - -#endif //PCH_H diff --git a/nitro.sln b/nitro.sln index e235d6de9..ea6e988e3 100644 --- a/nitro.sln +++ b/nitro.sln @@ -46,8 +46,6 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "Test++", "Test++\Test++.vcx EndProject Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "Test", "Test\Test.vcxproj", "{238C9787-B27D-4107-B8FD-1BDB49EA8023}" EndProject -Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "UnitTest++", "UnitTest++\UnitTest++.vcxproj", "{B19FE958-B3A5-4457-9919-F4F81F28CF95}" -EndProject Global GlobalSection(SolutionConfigurationPlatforms) = preSolution Debug|x64 = Debug|x64 @@ -118,10 +116,6 @@ Global {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Debug|x64.Build.0 = Debug|x64 {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Release|x64.ActiveCfg = Release|x64 {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Release|x64.Build.0 = Release|x64 - {B19FE958-B3A5-4457-9919-F4F81F28CF95}.Debug|x64.ActiveCfg = Debug|x64 - {B19FE958-B3A5-4457-9919-F4F81F28CF95}.Debug|x64.Build.0 = Debug|x64 - {B19FE958-B3A5-4457-9919-F4F81F28CF95}.Release|x64.ActiveCfg = Release|x64 - {B19FE958-B3A5-4457-9919-F4F81F28CF95}.Release|x64.Build.0 = Release|x64 EndGlobalSection GlobalSection(SolutionProperties) = preSolution HideSolutionNode = FALSE From aac24aeea0c9e170a14fba62cc96b640ab753232 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Tue, 15 Mar 2022 15:30:37 -0400 Subject: [PATCH 019/104] update TEST_ macros --- Test++/Test.h | 4 ++-- Test/Test.h | 41 ++++++++++++++++++++++++++++++----------- Test/nitf_Test.h | 8 -------- 3 files changed, 32 insertions(+), 21 deletions(-) diff --git a/Test++/Test.h b/Test++/Test.h index f5b882401..4df348c94 100644 --- a/Test++/Test.h +++ b/Test++/Test.h @@ -25,7 +25,7 @@ inline void test_assert_eq_(T&& t, U&& u) #define TEST_ASSERT_EQ(X1, X2) test_assert_eq_(X1, X2); #define TEST_ASSERT_EQ_INT(X1, X2) TEST_ASSERT_EQ(X2, X1) #define TEST_ASSERT_EQ_STR(X1, X2) TEST_ASSERT_EQ(std::string(X1), std::string(X2)) -#define TEST_ASSERT_EQ_FLOAT(X1, X2) TEST_ASSERT_EQ(static_cast(X1), static_cast(X2)) +#define TEST_ASSERT_EQ_FLOAT(X1, X2) TEST_ASSERT_EQ(X1, X2) #define TEST_ASSERT_NULL(X) Assert::IsNull((X)) #define TEST_ASSERT_NOT_NULL(X) Assert::IsNotNull((X)) @@ -46,7 +46,7 @@ inline void test_assert_greater_(T&& t, U&& u) } #define TEST_ASSERT_GREATER(X1, X2) test_assert_greater_(X1, X2) -#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) { Assert:AreEqual(X1, X2, EPS); Assert:AreEqual(X1, X1, EPS); } +#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) { Assert:AreEqual(X1, X2, EPS); Assert:AreEqual(X2, X1, EPS); } #define TEST_ASSERT_ALMOST_EQ(X1, X2) TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, 0.0001) #define TEST_ASSERT_EQ_MSG(msg, X1, X2) Logger::WriteMessage(msg.c_str()); TEST_ASSERT_EQ(X1, X2) diff --git a/Test/Test.h b/Test/Test.h index 6c0288230..4df348c94 100644 --- a/Test/Test.h +++ b/Test/Test.h @@ -1,38 +1,57 @@ #pragma once +#include +#include + #include "CppUnitTest.h" +namespace Microsoft{ namespace VisualStudio {namespace CppUnitTestFramework +{ +template<> +inline std::wstring ToString(const uint16_t& q) +{ + return std::to_wstring(q); +} +}}} + #define TEST_ASSERT(X) Assert::IsTrue(X) template inline void test_assert_eq_(T&& t, U&& u) { Assert::AreEqual(t, u); + Assert::AreEqual(u, t); } -#define TEST_ASSERT_EQ(X1, X2) { test_assert_eq_(X1, X2); test_assert_eq_(X2, X1); } +#define TEST_ASSERT_EQ(X1, X2) test_assert_eq_(X1, X2); #define TEST_ASSERT_EQ_INT(X1, X2) TEST_ASSERT_EQ(X2, X1) -#define TEST_ASSERT_EQ_STR(X1, X2) TEST_ASSERT_EQ(X1, X2) -#define TEST_ASSERT_EQ_FLOAT(X1, X2) TEST_ASSERT_EQ(static_cast(X1), static_cast(X2)) +#define TEST_ASSERT_EQ_STR(X1, X2) TEST_ASSERT_EQ(std::string(X1), std::string(X2)) +#define TEST_ASSERT_EQ_FLOAT(X1, X2) TEST_ASSERT_EQ(X1, X2) #define TEST_ASSERT_NULL(X) Assert::IsNull((X)) +#define TEST_ASSERT_NOT_NULL(X) Assert::IsNotNull((X)) #define TEST_ASSERT_TRUE(X) Assert::IsTrue((X)) #define TEST_ASSERT_FALSE(X) Assert::IsFalse((X)) template -inline void test_assert_not_eq_(const T& t, const U& u) +inline void test_assert_not_eq_(T&& t, U&& u) { Assert::AreNotEqual(t, u); + Assert::AreNotEqual(u, t); } -#define TEST_ASSERT_NOT_EQ(X1, X2) { test_assert_not_eq_(X1, X2); test_assert_not_eq_(X2, X1);} - -#define TEST_ASSERT_GREATER(X1, X2) EXPECT_GT(X1, X2) +#define TEST_ASSERT_NOT_EQ(X1, X2) test_assert_not_eq_(X1, X2); +template +inline void test_assert_greater_(T&& t, U&& u) +{ + Assert::IsTrue(t > u); +} +#define TEST_ASSERT_GREATER(X1, X2) test_assert_greater_(X1, X2) -#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) Assert:AreEqual(X1, X2, EPS) +#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) { Assert:AreEqual(X1, X2, EPS); Assert:AreEqual(X2, X1, EPS); } #define TEST_ASSERT_ALMOST_EQ(X1, X2) TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, 0.0001) -#define TEST_ASSERT_EQ_MSG(msg, X1, X2) SCOPED_TRACE(msg); TEST_ASSERT_EQ(X1, X2) +#define TEST_ASSERT_EQ_MSG(msg, X1, X2) Logger::WriteMessage(msg.c_str()); TEST_ASSERT_EQ(X1, X2) -#define TEST_EXCEPTION(X) EXPECT_ANY_THROW((X)) -#define TEST_THROWS(X) EXPECT_ANY_THROW((X)) +#define TEST_EXCEPTION(X) try { (X); TEST_ASSERT_FALSE(false); } catch (...) { TEST_ASSERT_TRUE(true); } +#define TEST_THROWS(X) TEST_EXCEPTION(X) #define TEST_MAIN(X) diff --git a/Test/nitf_Test.h b/Test/nitf_Test.h index db18ff558..c307e5643 100644 --- a/Test/nitf_Test.h +++ b/Test/nitf_Test.h @@ -9,11 +9,3 @@ #include #include "import/nitf.h" - -namespace nitf -{ - namespace Test - { - std::string buildPluginsDir(); - } -} \ No newline at end of file From fee835f78437f68dbb338b627b58aed0b1f1457f Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Tue, 15 Mar 2022 15:35:04 -0400 Subject: [PATCH 020/104] use same Test.h for both projects --- Test++/Test.h | 56 +-------------------------------------------------- Test/Test.h | 2 +- 2 files changed, 2 insertions(+), 56 deletions(-) diff --git a/Test++/Test.h b/Test++/Test.h index 4df348c94..71ea5e2d4 100644 --- a/Test++/Test.h +++ b/Test++/Test.h @@ -1,57 +1,3 @@ #pragma once -#include -#include - -#include "CppUnitTest.h" - -namespace Microsoft{ namespace VisualStudio {namespace CppUnitTestFramework -{ -template<> -inline std::wstring ToString(const uint16_t& q) -{ - return std::to_wstring(q); -} -}}} - -#define TEST_ASSERT(X) Assert::IsTrue(X) - -template -inline void test_assert_eq_(T&& t, U&& u) -{ - Assert::AreEqual(t, u); - Assert::AreEqual(u, t); -} -#define TEST_ASSERT_EQ(X1, X2) test_assert_eq_(X1, X2); -#define TEST_ASSERT_EQ_INT(X1, X2) TEST_ASSERT_EQ(X2, X1) -#define TEST_ASSERT_EQ_STR(X1, X2) TEST_ASSERT_EQ(std::string(X1), std::string(X2)) -#define TEST_ASSERT_EQ_FLOAT(X1, X2) TEST_ASSERT_EQ(X1, X2) - -#define TEST_ASSERT_NULL(X) Assert::IsNull((X)) -#define TEST_ASSERT_NOT_NULL(X) Assert::IsNotNull((X)) -#define TEST_ASSERT_TRUE(X) Assert::IsTrue((X)) -#define TEST_ASSERT_FALSE(X) Assert::IsFalse((X)) - -template -inline void test_assert_not_eq_(T&& t, U&& u) -{ - Assert::AreNotEqual(t, u); - Assert::AreNotEqual(u, t); -} -#define TEST_ASSERT_NOT_EQ(X1, X2) test_assert_not_eq_(X1, X2); -template -inline void test_assert_greater_(T&& t, U&& u) -{ - Assert::IsTrue(t > u); -} -#define TEST_ASSERT_GREATER(X1, X2) test_assert_greater_(X1, X2) - -#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) { Assert:AreEqual(X1, X2, EPS); Assert:AreEqual(X2, X1, EPS); } -#define TEST_ASSERT_ALMOST_EQ(X1, X2) TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, 0.0001) - -#define TEST_ASSERT_EQ_MSG(msg, X1, X2) Logger::WriteMessage(msg.c_str()); TEST_ASSERT_EQ(X1, X2) - -#define TEST_EXCEPTION(X) try { (X); TEST_ASSERT_FALSE(false); } catch (...) { TEST_ASSERT_TRUE(true); } -#define TEST_THROWS(X) TEST_EXCEPTION(X) - -#define TEST_MAIN(X) +#include "../Test/Test.h" \ No newline at end of file diff --git a/Test/Test.h b/Test/Test.h index 4df348c94..d0df1ad6c 100644 --- a/Test/Test.h +++ b/Test/Test.h @@ -25,7 +25,7 @@ inline void test_assert_eq_(T&& t, U&& u) #define TEST_ASSERT_EQ(X1, X2) test_assert_eq_(X1, X2); #define TEST_ASSERT_EQ_INT(X1, X2) TEST_ASSERT_EQ(X2, X1) #define TEST_ASSERT_EQ_STR(X1, X2) TEST_ASSERT_EQ(std::string(X1), std::string(X2)) -#define TEST_ASSERT_EQ_FLOAT(X1, X2) TEST_ASSERT_EQ(X1, X2) +#define TEST_ASSERT_EQ_FLOAT(X1, X2) TEST_ASSERT_EQ(static_cast(X1), static_cast(X2)) #define TEST_ASSERT_NULL(X) Assert::IsNull((X)) #define TEST_ASSERT_NOT_NULL(X) Assert::IsNotNull((X)) From a90229c6757568c511e9cd1362b80562cdc82a72 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Tue, 15 Mar 2022 15:53:54 -0400 Subject: [PATCH 021/104] Fix CodeQL diagnostics --- modules/c++/nitf/unittests/test_create_nitf++.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/modules/c++/nitf/unittests/test_create_nitf++.cpp b/modules/c++/nitf/unittests/test_create_nitf++.cpp index 3fb2489c8..ca615a9e0 100644 --- a/modules/c++/nitf/unittests/test_create_nitf++.cpp +++ b/modules/c++/nitf/unittests/test_create_nitf++.cpp @@ -177,7 +177,7 @@ static void test_create_nitf_with_byte_provider__writeNITF(nitf::Record& record, * should work the same */ std::vector > bytesPerBlock(1); - bytesPerBlock[0].push_back(NITRO_IMAGE.width * NITRO_IMAGE.height * NUM_BANDS); + bytesPerBlock[0].push_back(static_cast(NITRO_IMAGE.width) * NITRO_IMAGE.height * NUM_BANDS); nitf::CompressedByteProvider byteProvider(record, bytesPerBlock); nitf::Off fileOffset; @@ -216,7 +216,7 @@ static bool test_create_nitf_with_byte_provider__testRead(const std::string& pat // Read one block. It should match the first blockSize points of the // image. If it does, we got the blocking mode right. auto block = reinterpret_cast(imageReader.readBlock(0, &blockSize)); - const size_t imageLength = NITRO_IMAGE.width * NITRO_IMAGE.height; + const size_t imageLength = static_cast(NITRO_IMAGE.width) * NITRO_IMAGE.height; for (size_t jj = 0; jj < imageLength * NUM_BANDS; ++jj) { @@ -314,7 +314,7 @@ static void test_create_nitf__writeNITF(nitf::Record& record, const std::string& { nitf::BandSource bandSource = nitf::MemorySource( (char*)NITRO_IMAGE.data, - NITRO_IMAGE.width * NITRO_IMAGE.height, + static_cast(NITRO_IMAGE.width) * NITRO_IMAGE.height, ii, 1, 2); imageSource.addBand(bandSource); } @@ -348,7 +348,7 @@ static bool test_create_nitf__testRead(const std::string& pathname, bool isMono // Read one block. It should match the first blockSize points of the // image. If it does, we got the blocking mode right. auto block = reinterpret_cast(imageReader.readBlock(0, &blockSize)); - const size_t imageLength = NITRO_IMAGE.width * NITRO_IMAGE.height; + const auto imageLength = static_cast(NITRO_IMAGE.width) * NITRO_IMAGE.height; // The image data is interleaved by pixel. When feeding it to the // writer, we unpack to interleave by block. Now that we're reading From ec2705b2c1d8980beb16ee28195eea37b627dfbe Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Tue, 15 Mar 2022 16:06:43 -0400 Subject: [PATCH 022/104] use std::span --- modules/c++/nitf/include/nitf/NITFBufferList.hpp | 7 +++++++ .../c++/nitf/unittests/test_create_nitf++.cpp | 16 +++++----------- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/modules/c++/nitf/include/nitf/NITFBufferList.hpp b/modules/c++/nitf/include/nitf/NITFBufferList.hpp index feebf097b..8b4726bf3 100644 --- a/modules/c++/nitf/include/nitf/NITFBufferList.hpp +++ b/modules/c++/nitf/include/nitf/NITFBufferList.hpp @@ -26,6 +26,8 @@ #include #include +#include +#include // std::byte #include "nitf/coda-oss.hpp" #include "nitf/System.hpp" @@ -56,6 +58,11 @@ struct NITRO_NITFCPP_API NITFBuffer const void* mData = nullptr; size_t mNumBytes = 0; + + std::span getBytes() const + { + return std::span(static_cast(mData), mNumBytes); + } }; /*! diff --git a/modules/c++/nitf/unittests/test_create_nitf++.cpp b/modules/c++/nitf/unittests/test_create_nitf++.cpp index ca615a9e0..f09c1e54d 100644 --- a/modules/c++/nitf/unittests/test_create_nitf++.cpp +++ b/modules/c++/nitf/unittests/test_create_nitf++.cpp @@ -176,10 +176,8 @@ static void test_create_nitf_with_byte_provider__writeNITF(nitf::Record& record, * Once you have CompressedByteProvider constructed, everything else * should work the same */ - std::vector > bytesPerBlock(1); - bytesPerBlock[0].push_back(static_cast(NITRO_IMAGE.width) * NITRO_IMAGE.height * NUM_BANDS); - nitf::CompressedByteProvider byteProvider(record, - bytesPerBlock); + const std::vector > bytesPerBlock{ { static_cast(NITRO_IMAGE.width) * NITRO_IMAGE.height * NUM_BANDS } }; + nitf::CompressedByteProvider byteProvider(record, bytesPerBlock); nitf::Off fileOffset; nitf::NITFBufferList buffers; byteProvider.getBytes(NITRO_IMAGE.data, 0, NITRO_IMAGE.height, @@ -187,9 +185,7 @@ static void test_create_nitf_with_byte_provider__writeNITF(nitf::Record& record, io::FileOutputStream outputStream(filename); for (size_t ii = 0; ii < buffers.mBuffers.size(); ++ii) { - outputStream.write( - static_cast(buffers.mBuffers[ii].mData), - buffers.mBuffers[ii].mNumBytes); + outputStream.write(buffers.mBuffers[ii].getBytes()); } } @@ -312,10 +308,8 @@ static void test_create_nitf__writeNITF(nitf::Record& record, const std::string& /* make one bandSource per band */ for (int ii = 0; ii < NUM_BANDS; ++ii) { - nitf::BandSource bandSource = nitf::MemorySource( - (char*)NITRO_IMAGE.data, - static_cast(NITRO_IMAGE.width) * NITRO_IMAGE.height, - ii, 1, 2); + const std::span image(NITRO_IMAGE.data, static_cast(NITRO_IMAGE.width) * NITRO_IMAGE.height); + nitf::BandSource bandSource = nitf::MemorySource(image, ii, 2); imageSource.addBand(bandSource); } From 0d44d85640a538afbfa595da9087cae34730574f Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Tue, 15 Mar 2022 16:22:08 -0400 Subject: [PATCH 023/104] try to fix compile error on Linux --- modules/c++/nitf/unittests/test_create_nitf++.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/c++/nitf/unittests/test_create_nitf++.cpp b/modules/c++/nitf/unittests/test_create_nitf++.cpp index f09c1e54d..317bc7bed 100644 --- a/modules/c++/nitf/unittests/test_create_nitf++.cpp +++ b/modules/c++/nitf/unittests/test_create_nitf++.cpp @@ -185,7 +185,8 @@ static void test_create_nitf_with_byte_provider__writeNITF(nitf::Record& record, io::FileOutputStream outputStream(filename); for (size_t ii = 0; ii < buffers.mBuffers.size(); ++ii) { - outputStream.write(buffers.mBuffers[ii].getBytes()); + const auto bytes = buffers.mBuffers[ii].getBytes(); + outputStream.write(bytes); } } From 8f21ef0d3d9d4a0055babdbabeab49e46e2cdf58 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Tue, 15 Mar 2022 16:24:46 -0400 Subject: [PATCH 024/104] tweak OutputStream::write() overloads --- .../modules/c++/io/include/io/OutputStream.h | 25 ++++++++++--------- .../c++/nitf/unittests/test_create_nitf++.cpp | 3 +-- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/externals/coda-oss/modules/c++/io/include/io/OutputStream.h b/externals/coda-oss/modules/c++/io/include/io/OutputStream.h index 45114d926..6f41aa249 100644 --- a/externals/coda-oss/modules/c++/io/include/io/OutputStream.h +++ b/externals/coda-oss/modules/c++/io/include/io/OutputStream.h @@ -30,6 +30,7 @@ #include "sys/Conf.h" #include "coda_oss/string.h" #include "coda_oss/cstddef.h" +#include "coda_oss/span.h" /*! * \file OutputStream.h @@ -71,23 +72,13 @@ struct OutputStream * Write a string * \param str */ - void write(std::string::const_pointer pStr, size_t length) // i.e., std::string_view - { - const void* const pStr_ = pStr; - write(pStr_, length); - } void write(const std::string& str) { - write(str.c_str(), str.length()); - } - void write(coda_oss::u8string::const_pointer pStr, size_t length) // i.e., std::string_view - { - const void* const pStr_ = pStr; - write(pStr_, length); + write(coda_oss::span(str.data(), str.size())); } void write(const coda_oss::u8string& str) { - write(str.c_str(), str.length()); + write(coda_oss::span(str.data(), str.size())); } /*! @@ -114,6 +105,16 @@ struct OutputStream * \throw IOException */ virtual void write(const void* buffer, size_t len) = 0; + template + void write(coda_oss::span buffer) + { + write(buffer.data(), buffer.size_bytes()); + } + template + void write(coda_oss::span buffer) + { + write(coda_oss::span(buffer.data(), buffer.size())); + } /*! * Flush the stream if needed diff --git a/modules/c++/nitf/unittests/test_create_nitf++.cpp b/modules/c++/nitf/unittests/test_create_nitf++.cpp index 317bc7bed..f09c1e54d 100644 --- a/modules/c++/nitf/unittests/test_create_nitf++.cpp +++ b/modules/c++/nitf/unittests/test_create_nitf++.cpp @@ -185,8 +185,7 @@ static void test_create_nitf_with_byte_provider__writeNITF(nitf::Record& record, io::FileOutputStream outputStream(filename); for (size_t ii = 0; ii < buffers.mBuffers.size(); ++ii) { - const auto bytes = buffers.mBuffers[ii].getBytes(); - outputStream.write(bytes); + outputStream.write(buffers.mBuffers[ii].getBytes()); } } From edefcfaa0557aa0ba97ff83c110e4e2d83e41707 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Wed, 16 Mar 2022 09:16:31 -0400 Subject: [PATCH 025/104] use full name for Assert --- Test/Test.h | 46 ++++++++++++++++++++++++++++------------------ 1 file changed, 28 insertions(+), 18 deletions(-) diff --git a/Test/Test.h b/Test/Test.h index d0df1ad6c..41a197841 100644 --- a/Test/Test.h +++ b/Test/Test.h @@ -5,51 +5,61 @@ #include "CppUnitTest.h" -namespace Microsoft{ namespace VisualStudio {namespace CppUnitTestFramework -{ -template<> -inline std::wstring ToString(const uint16_t& q) -{ - return std::to_wstring(q); +namespace Microsoft { + namespace VisualStudio { + namespace CppUnitTestFramework + { + template<> + inline std::wstring ToString(const uint16_t& q) + { + return std::to_wstring(q); + } + } + } } -}}} #define TEST_ASSERT(X) Assert::IsTrue(X) template inline void test_assert_eq_(T&& t, U&& u) { - Assert::AreEqual(t, u); - Assert::AreEqual(u, t); + Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(t, u); + Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(u, t); } #define TEST_ASSERT_EQ(X1, X2) test_assert_eq_(X1, X2); #define TEST_ASSERT_EQ_INT(X1, X2) TEST_ASSERT_EQ(X2, X1) #define TEST_ASSERT_EQ_STR(X1, X2) TEST_ASSERT_EQ(std::string(X1), std::string(X2)) #define TEST_ASSERT_EQ_FLOAT(X1, X2) TEST_ASSERT_EQ(static_cast(X1), static_cast(X2)) -#define TEST_ASSERT_NULL(X) Assert::IsNull((X)) -#define TEST_ASSERT_NOT_NULL(X) Assert::IsNotNull((X)) -#define TEST_ASSERT_TRUE(X) Assert::IsTrue((X)) -#define TEST_ASSERT_FALSE(X) Assert::IsFalse((X)) +#define TEST_ASSERT_NULL(X) Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNull((X)) +#define TEST_ASSERT_NOT_NULL(X) Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNotNull((X)) +#define TEST_ASSERT_TRUE(X) Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue((X)) +#define TEST_ASSERT_FALSE(X) Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsFalse((X)) template inline void test_assert_not_eq_(T&& t, U&& u) { - Assert::AreNotEqual(t, u); - Assert::AreNotEqual(u, t); + Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreNotEqual(t, u); + Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreNotEqual(u, t); } #define TEST_ASSERT_NOT_EQ(X1, X2) test_assert_not_eq_(X1, X2); template inline void test_assert_greater_(T&& t, U&& u) { - Assert::IsTrue(t > u); + Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(t > u); } #define TEST_ASSERT_GREATER(X1, X2) test_assert_greater_(X1, X2) -#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) { Assert:AreEqual(X1, X2, EPS); Assert:AreEqual(X2, X1, EPS); } +template +inline void test_assert_greater_(T&& t, U&& u, EPS&& eps) +{ + Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(t, u, eps); + Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(u, t, eps); +} +#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) test_assert_greater_(X1, X2, EPS) #define TEST_ASSERT_ALMOST_EQ(X1, X2) TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, 0.0001) -#define TEST_ASSERT_EQ_MSG(msg, X1, X2) Logger::WriteMessage(msg.c_str()); TEST_ASSERT_EQ(X1, X2) +#define TEST_ASSERT_EQ_MSG(msg, X1, X2) Microsoft::VisualStudio::CppUnitTestFramework::Logger::WriteMessage(msg.c_str()); TEST_ASSERT_EQ(X1, X2) #define TEST_EXCEPTION(X) try { (X); TEST_ASSERT_FALSE(false); } catch (...) { TEST_ASSERT_TRUE(true); } #define TEST_THROWS(X) TEST_EXCEPTION(X) From 6fa3b0a0628db2aa51977324d70a0fef752d0f90 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Thu, 23 Jun 2022 12:19:27 -0400 Subject: [PATCH 026/104] Squashed commit of the following: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit commit ac10a6d3c50ab31806563d4043dd86fd2fe0396f Author: J. Daniel Smith Date: Thu Jun 23 12:18:33 2022 -0400 Build with latest VS2022 commit b0743a3cce06c54d41ca7d381365b7e274a6fee8 Author: J. Daniel Smith Date: Fri Jun 10 21:49:01 2022 -0400 add std::nothrow_t overloads commit 19c64270477299f31fab131c9b49e370ed000bbf Author: J. Daniel Smith Date: Fri Jun 10 17:39:54 2022 -0400 overloads for non-throwing index() commit 94572aa9ea01dc205b057b043cbea90a2e071994 Author: J. Daniel Smith Date: Fri Jun 10 17:12:03 2022 -0400 expose routines so that the map doesn't have to be named string_to_enum commit f6237fe795e8731405af010be8d6c844016886f9 Author: J. Daniel Smith Date: Fri Jun 10 15:09:56 2022 -0400 no longer necessary to specialize string_to_enum(); it doesn't work well in other namespaces commit 96e0b97227e7793114a3b6c9b47a75e31075008b Merge: f656114f 3e38c39a Author: J. Daniel Smith Date: Fri Jun 10 14:32:57 2022 -0400 Merge branch 'master' into feature/simplify-cpp-api commit f656114f2b18c14a51be6969c2924464c447ca08 Author: Dan Smith Date: Fri Nov 5 10:38:32 2021 -0400 sys::byte -> nitf::byte commit 8cb2c9890bb7e3c64b845694fe10c67e97ab3eaa Merge: c3a76f4f 888ae929 Author: Dan Smith Date: Fri Nov 5 10:21:25 2021 -0400 Merge branch 'master' into feature/simplify-cpp-api commit c3a76f4f60bb9de9de10225e03dcfc93ec093a06 Merge: fc3573f4 1a19b6b6 Author: Dan Smith Date: Fri Sep 17 09:16:24 2021 -0400 Merge branch 'master' into feature/simplify-cpp-api commit fc3573f42ad9e738fcc079d56f474a43d6cb0f8b Author: Dan Smith Date: Fri Sep 17 09:01:18 2021 -0400 tweak "enum"s; borrowed from SIX commit 92ccc2732878762eece73edfb9bca0ca3bc129f9 Author: Dan Smith Date: Fri Sep 17 08:58:28 2021 -0400 Squashed commit of the following: commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b9cef2cbfe1fd8d1238e644dc4e4ac0b39a65053 Author: Dan Smith Date: Fri Sep 10 10:53:57 2021 -0400 use a normal "enum class" rather than static data members commit 4a6d3dcf76b96a6ef2e88225e15fd234fcd8575a Merge: 9ec9f026 0db498f1 Author: Dan Smith Date: Wed Sep 8 16:15:37 2021 -0400 Merge branch 'master' into feature/simplify-cpp-api commit 9ec9f026133fdb4a6b9192a3f047bfde468d1591 Author: Dan Smith Date: Mon Aug 23 14:26:41 2021 -0400 make a strongly-typed BandInfo::Represenation commit ad54eaa940f6cb1c55c8d7458a855e4a031e8e92 Author: Dan Smith Date: Thu Aug 19 13:42:41 2021 -0400 Revert "infrastructure for getting ntif::Fields with less repetition of the field name" This reverts commit e3ef6531ce3a98bfa7ca02db1a96ebc1376102e0. commit 232f3620a9d518bd3d6f5f5e40f56501be91e79c Author: Dan Smith Date: Thu Aug 19 13:42:35 2021 -0400 Revert "move field-offset code to Object.hpp" This reverts commit fcd8ad368965b741dc3c95a54f54301ff71008ed. commit 5ba52e4da4fb39add720314ae9ede061d0a3f439 Author: Dan Smith Date: Thu Aug 19 13:42:16 2021 -0400 Revert "first pass at trying to do a simple reflection scheme" This reverts commit 295221104c274aefef45cdf4e407315b45b33282. commit 935683eeeb7b5b8c8efecf04116f2774c0577896 Author: Dan Smith Date: Thu Aug 19 13:42:10 2021 -0400 Revert "use __VA_ARGS__" This reverts commit 02d91710962a4caae71516b2bd40b94c8720c379. commit b76f4cbd8db01498dbce1f0bc1ec7c2e5ec33a77 Author: Dan Smith Date: Thu Aug 19 13:42:05 2021 -0400 Revert "try __VA_ARGS__" This reverts commit 345351fdfe86727aca3c30fdcb22ac619a935bc1. commit 345351fdfe86727aca3c30fdcb22ac619a935bc1 Author: Dan Smith Date: Thu Aug 19 12:59:25 2021 -0400 try __VA_ARGS__ commit 02d91710962a4caae71516b2bd40b94c8720c379 Author: Dan Smith Date: Thu Aug 19 12:35:28 2021 -0400 use __VA_ARGS__ commit 295221104c274aefef45cdf4e407315b45b33282 Author: Dan Smith Date: Thu Aug 19 12:08:18 2021 -0400 first pass at trying to do a simple reflection scheme commit fcd8ad368965b741dc3c95a54f54301ff71008ed Author: Dan Smith Date: Wed Aug 18 17:00:29 2021 -0400 move field-offset code to Object.hpp commit e3ef6531ce3a98bfa7ca02db1a96ebc1376102e0 Author: Dan Smith Date: Wed Aug 18 16:36:23 2021 -0400 infrastructure for getting ntif::Fields with less repetition of the field name commit d7b8710887359f09440c146325a5d9199d689931 Author: Dan Smith Date: Wed Aug 18 13:30:06 2021 -0400 Hook up "property" support; not yet used. commit a55c927c9ae904b94c36d0245106417f5087cab6 Author: Dan Smith Date: Wed Aug 18 11:51:43 2021 -0400 simplify creation of nitf::SubWindow commit 07ff1610052f9cf5c2cd5284775df26ab06b7ff6 Author: Dan Smith Date: Wed Aug 18 11:33:57 2021 -0400 create/initialize a SubWindow from an ImageHeader commit 33f199aa0dc212f54c42be1397ecdaf63fb4ca5a Merge: 3a013fdd dc000a51 Author: Dan Smith Date: Wed Aug 18 11:25:11 2021 -0400 Merge branch 'master' into feature/simplify-cpp-api commit 3a013fdd63b52070b6cdd77b93be60e7a2a051a7 Author: Dan Smith Date: Thu May 27 15:32:22 2021 -0400 remove CodeQL diagnostics commit 6ff51c070feb025401fea1a17785c03c35531acd Merge: bde5cad3 75caf49e Author: Dan Smith Date: Thu May 27 14:59:36 2021 -0400 Merge branch 'master' into feature/simplify-cpp-api commit bde5cad35bc151b6207e7d979e8417b101b53ee8 Merge: 653750ae b6014390 Author: Dan Smith Date: Thu May 27 14:02:46 2021 -0400 Merge branch 'feature/remove_compiler_warnings' into feature/simplify-cpp-api commit 653750ae888234915d5194f40d342d0541d5a4d5 Merge: 5b9a50bc f4b80a31 Author: Dan Smith Date: Thu May 27 14:02:38 2021 -0400 Merge branch 'master' into feature/simplify-cpp-api commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5b9a50bc289835959dfc2a7f7d7718a5fdf20009 Merge: f2b11a28 4ddaf23d Author: Dan Smith Date: Mon May 24 15:27:06 2021 -0400 Merge branch 'master' into feature/simplify-cpp-api commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit f2b11a2831aeff4e1fee315932dc44c61860be0e Merge: c8fd70fa d3fab714 Author: Dan Smith Date: Mon May 17 12:02:26 2021 -0400 Merge branch 'master' into feature/simplify-cpp-api commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c8fd70fa5d7aea3ba246e2a14ead5be417bff842 Merge: 74611f09 9aee934e Author: Dan Smith Date: Mon May 17 10:33:28 2021 -0400 Merge branch 'master' into feature/simplify-cpp-api commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 74611f09d251ca4953396d1417aa5bbdfa0978ed Merge: 7c456134 7be6c13b Author: Dan Smith Date: Tue May 11 09:36:39 2021 -0400 Merge branch 'master' into feature/simplify-cpp-api commit 7c456134f6afbf6f520d5572a852b46f15e1d13b Merge: 5f81d561 a58e3b36 Author: Dan Smith Date: Tue May 4 15:03:21 2021 -0400 Merge branch 'feature/shared-library' into feature/simplify-cpp-api commit a58e3b366fa2d21f2bd8f0f6377256405fb51c35 Merge: 8d8d9662 d4f244ee Author: Dan Smith Date: Tue May 4 15:02:56 2021 -0400 Merge branch 'master' into feature/shared-library commit 5f81d561e700589f5620327e186e3d57c66a1a4e Merge: 2f038389 d0117954 Author: Dan Smith Date: Tue May 4 14:45:24 2021 -0400 Merge branch 'master' into feature/simplify-cpp-api commit 8d8d96626f7e26f6d657c7c14724a47bd3f5d632 Merge: 4e806f4e d0117954 Author: Dan Smith Date: Tue May 4 14:45:09 2021 -0400 Merge branch 'master' into feature/shared-library commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 2f038389fe188dd5c94c00e1a61e5d0f67defb02 Merge: 47b8f0d8 4e806f4e Author: Dan Smith Date: Tue May 4 13:45:27 2021 -0400 Merge branch 'feature/shared-library' into feature/simplify-cpp-api commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 47b8f0d8f279e891a788f2b22f58738cec83f9c5 Author: Dan Smith Date: Sat May 1 15:19:43 2021 -0400 fix WAF build commit 942e0363cd293ca96f14e4991d49075437a28a17 Author: Dan Smith Date: Sat May 1 15:11:42 2021 -0400 building mem/tests causes GCC to crash on github commit 4d484bbdcd015abbfc6010f5180909ae55294bc2 Author: Dan Smith Date: Sat May 1 14:46:39 2021 -0400 restore change lost in merge from "master" commit b4db13837ebf98fd720e1ae35c9b076e837e0756 Merge: e55b86ba a16f72b0 Author: Dan Smith Date: Sat May 1 14:45:38 2021 -0400 Merge branch 'master' into feature/simplify-cpp-api commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e55b86ba809b11267c11f4a21fc3ceaf70d25eca Merge: 12500e5e 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:38 2021 -0400 Merge branch 'master' into feature/simplify-cpp-api commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 12500e5e41ac1dccf03b5ff0f6a7aa95ba6b63f2 Merge: 011c2fa6 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:22 2021 -0400 Merge branch 'master' into feature/simplify-cpp-api commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 011c2fa64ff4455456fbe0fe3836bc17e2fdf815 Author: Dan Smith Date: Sat Apr 24 13:01:14 2021 -0400 create test_extract.cpp that is very similar to nitf_extract.py commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss --- Test++/nitf_Test.h | 6 +- .../c++/nitf/include/nitf/ByteProvider.hpp | 14 +-- .../include/nitf/CompressedByteProvider.hpp | 2 +- modules/c++/nitf/include/nitf/Enum.hpp | 91 +++++++++++++------ .../c++/nitf/include/nitf/ImageBlocker.hpp | 8 +- modules/c++/nitf/include/nitf/ImageReader.hpp | 2 +- .../c++/nitf/include/nitf/NITFBufferList.hpp | 2 +- .../c++/nitf/include/nitf/SegmentSource.hpp | 6 +- modules/c++/nitf/source/ByteProvider.cpp | 9 +- .../nitf/source/CompressedByteProvider.cpp | 4 +- modules/c++/nitf/source/NITFBufferList.cpp | 2 +- .../nitf/unittests/test_nitf_buffer_list.cpp | 18 ++-- modules/c/nitf-c.vcxproj | 1 - 13 files changed, 97 insertions(+), 68 deletions(-) diff --git a/Test++/nitf_Test.h b/Test++/nitf_Test.h index 833ebfa7e..107330a62 100644 --- a/Test++/nitf_Test.h +++ b/Test++/nitf_Test.h @@ -18,19 +18,19 @@ namespace Microsoft{ namespace VisualStudio {namespace CppUnitTestFramework template<> inline std::wstring ToString(const nitf::PixelValueType& q) { - return nitf::to_wstring(q); + return str::EncodedStringView(nitf::to_string(q)).wstring(); } template<> inline std::wstring ToString(const nitf::BlockingMode& q) { - return nitf::to_wstring(q); + return str::EncodedStringView(nitf::to_string(q)).wstring(); } template<> inline std::wstring ToString(const nitf::ImageCompression& q) { - return nitf::to_wstring(q); + return str::EncodedStringView(nitf::to_string(q)).wstring(); } }}} \ No newline at end of file diff --git a/modules/c++/nitf/include/nitf/ByteProvider.hpp b/modules/c++/nitf/include/nitf/ByteProvider.hpp index 199b8aecb..f9d6147dc 100644 --- a/modules/c++/nitf/include/nitf/ByteProvider.hpp +++ b/modules/c++/nitf/include/nitf/ByteProvider.hpp @@ -134,7 +134,7 @@ struct NITRO_NITFCPP_API ByteProvider } //! \return The raw file header bytes - const std::vector& getFileHeader() const noexcept + const std::vector& getFileHeader() const noexcept { return mFileHeader; } @@ -144,7 +144,7 @@ struct NITRO_NITFCPP_API ByteProvider * \return The raw bytes for each image subheader. Vector size matches the * number of image segments. */ - const std::vector >& getImageSubheaders() const noexcept + const std::vector >& getImageSubheaders() const noexcept { return mImageSubheaders; } @@ -154,7 +154,7 @@ struct NITRO_NITFCPP_API ByteProvider * \return The raw bytes for each DES (subheader immediately followed by * raw DES data). Vector size matches the number of data extension segments. */ - const std::vector& getDesSubheaderAndData() const noexcept + const std::vector& getDesSubheaderAndData() const noexcept { return mDesSubheaderAndData; } @@ -273,7 +273,7 @@ struct NITRO_NITFCPP_API ByteProvider size_t numRowsPerBlock = 0, size_t numColsPerBlock = 0); static void copyFromStreamAndClear(io::ByteStream& stream, - std::vector& rawBytes); + std::vector& rawBytes); static void copyFromStreamAndClear(io::ByteStream& stream, std::vector& rawBytes); @@ -366,11 +366,11 @@ struct NITRO_NITFCPP_API ByteProvider std::vector mImageSegmentInfo; // Per segment - std::vector mFileHeader; - std::vector > mImageSubheaders; // Per segment + std::vector mFileHeader; + std::vector > mImageSubheaders; // Per segment // All DES subheaders and data together contiguously - std::vector mDesSubheaderAndData; + std::vector mDesSubheaderAndData; std::vector mImageSubheaderFileOffsets; // Per segment nitf::Off mDesSubheaderFileOffset = 0; diff --git a/modules/c++/nitf/include/nitf/CompressedByteProvider.hpp b/modules/c++/nitf/include/nitf/CompressedByteProvider.hpp index 0f3fa117b..7f97b8039 100644 --- a/modules/c++/nitf/include/nitf/CompressedByteProvider.hpp +++ b/modules/c++/nitf/include/nitf/CompressedByteProvider.hpp @@ -179,7 +179,7 @@ struct NITRO_NITFCPP_API CompressedByteProvider : public ByteProvider size_t seg, size_t startRow, size_t numRowsToWrite, - const sys::byte* imageData, + const nitf::byte* imageData, nitf::Off& fileOffset, NITFBufferList& buffers) const; size_t addImageData( diff --git a/modules/c++/nitf/include/nitf/Enum.hpp b/modules/c++/nitf/include/nitf/Enum.hpp index abeda465b..aa6e0c8e3 100644 --- a/modules/c++/nitf/include/nitf/Enum.hpp +++ b/modules/c++/nitf/include/nitf/Enum.hpp @@ -28,6 +28,8 @@ #include #include #include +#include +#include // std::nothrow #include "str/Manip.h" #include "str/EncodedStringView.h" @@ -47,40 +49,39 @@ namespace nitf return retval; } - template - inline TValue index(const std::map& map, const TKey& key, const TException& ex) noexcept(false) + template + inline std::optional index(const std::map& map, const TKey& key) { const auto it = map.find(key); - if (it == map.end()) - { - throw ex; - } - return it->second; + return it == map.end() ? std::optional() : std::optional(it->second); } - template - inline TValue index(const std::map& map, const TKey& key) + + template + inline std::optional to_string(T v, const std::map& enum_to_string) { - return index(map, key, std::invalid_argument("key not found in map.")); + return index(enum_to_string, v); } - // You need to specialize string_to_enum() for each "enum class" - template const std::map& string_to_enum(); template - inline const std::map& enum_to_string() + inline std::optional from_string(std::string v, const std::map& string_to_enum) { - static const auto retval = swap_key_value(string_to_enum()); - return retval; + str::trim(v); + return index(string_to_enum, v); } - template - inline std::string to_string(T v) noexcept(false) + template + inline T value(const std::optional& v, const TException& ex) { - return index(enum_to_string(), v); + if (!v.has_value()) + { + throw ex; + } + return *v; } template - inline T from_string(const std::string& v) noexcept(false) + inline T value(const std::optional& v) { - return index(string_to_enum(), v); + return value(v, std::invalid_argument("key not found in map.")); } } @@ -104,9 +105,8 @@ namespace nitf #define NITF_ENUM_define_string_to_enum_ostream_(name) inline std::ostream& operator<<(std::ostream& os, name e) { os << to_string(e); return os; } #define NITF_ENUM_define_string_to_enum_begin(name) NITF_ENUM_define_string_to_enum_ostream_(name) \ - namespace details { template<> inline const std::map& string_to_enum() { \ - static const std::map retval { -#define NITF_ENUM_define_string_to_end }; return retval; } } + inline const std::map& string_to_enum(name) { static const std::map retval { +#define NITF_ENUM_define_string_to_end }; return retval; } #define NITF_ENUM_define_string_to_enum_(name, ...) NITF_ENUM_define_string_to_enum_begin(name) __VA_ARGS__ \ NITF_ENUM_define_string_to_end @@ -114,20 +114,51 @@ namespace nitf NITF_ENUM_define_string_to_enum_(name, NITF_ENUM_map_entry_##n(name, __VA_ARGS__)) template - inline std::string to_string(T v) noexcept(false) + inline std::optional to_string(T v, const std::map& string_to_enum, std::nothrow_t) { - return details::to_string(v); + static const auto enum_to_string = details::swap_key_value(string_to_enum); + return details::to_string(v, enum_to_string); } template - inline std::wstring to_wstring(T v) noexcept(false) + inline std::string to_string(T v, const std::map& string_to_enum) + { + const auto result = to_string(v, string_to_enum, std::nothrow); + return details::value(result); + } + + template + inline std::optional from_string(const std::string& v, const std::map& string_to_enum, std::nothrow_t) { - return str::EncodedStringView(details::to_string(v)).wstring(); + return details::from_string(v, string_to_enum); } template - inline T from_string(std::string v) noexcept(false) + inline T from_string(const std::string& v, const std::map& string_to_enum) { - str::trim(v); - return details::from_string(v); + const auto result = from_string(v, string_to_enum, std::nothrow); + return details::value(result); } + + template + inline std::optional to_string(T v, std::nothrow_t) + { + return to_string(v, string_to_enum(T()), std::nothrow); + } + template + inline std::string to_string(T v) + { + return to_string(v, string_to_enum(T())); + } + + template + inline std::optional from_string(const std::string& v, std::nothrow_t) + { + return from_string(v, string_to_enum(T()), std::nothrow); + } + template + inline T from_string(const std::string& v) + { + return from_string(v, string_to_enum(T())); + } + } #endif // NITF_Enum_hpp_INCLUDED_ diff --git a/modules/c++/nitf/include/nitf/ImageBlocker.hpp b/modules/c++/nitf/include/nitf/ImageBlocker.hpp index f328226c4..7252e50a1 100644 --- a/modules/c++/nitf/include/nitf/ImageBlocker.hpp +++ b/modules/c++/nitf/include/nitf/ImageBlocker.hpp @@ -279,11 +279,11 @@ struct NITRO_NITFCPP_API ImageBlocker /*final*/ // no "final", SWIG doesn't li size_t& lastBlockWithinLastSeg) const; void blockImpl(size_t seg, - const sys::byte* input, + const nitf::byte* input, size_t numValidRowsInBlock, size_t numValidColsInBlock, size_t numBytesPerPixel, - sys::byte* output) const noexcept + nitf::byte* output) const noexcept { block(input, numBytesPerPixel, mNumCols, mNumRowsPerBlock[seg], mNumColsPerBlock, numValidRowsInBlock, numValidColsInBlock, @@ -336,10 +336,10 @@ struct NITRO_NITFCPP_API ImageBlocker /*final*/ // no "final", SWIG doesn't li input += mNumCols * numBytesPerPixel * (numValidRowsInBlock - 1); } void blockAcrossRow(size_t seg, - const sys::byte*& input, + const nitf::byte*& input, size_t numValidRowsInBlock, size_t numBytesPerPixel, - sys::byte*& output) const noexcept + nitf::byte*& output) const noexcept { blockAcrossRowImpl(seg, input, numValidRowsInBlock, numBytesPerPixel, output); } diff --git a/modules/c++/nitf/include/nitf/ImageReader.hpp b/modules/c++/nitf/include/nitf/ImageReader.hpp index 38ebc139e..efe7057db 100644 --- a/modules/c++/nitf/include/nitf/ImageReader.hpp +++ b/modules/c++/nitf/include/nitf/ImageReader.hpp @@ -129,7 +129,7 @@ DECLARE_CLASS(ImageReader) * \param padded Returns TRUE if pad pixels may have been read */ void read(const nitf::SubWindow & subWindow, uint8_t ** user, int * padded); - void read(const nitf::SubWindow & subWindow, sys::byte** user, int * padded) + void read(const nitf::SubWindow & subWindow, nitf::byte** user, int * padded) { void* user_ = user; read(subWindow, static_cast(user_), padded); diff --git a/modules/c++/nitf/include/nitf/NITFBufferList.hpp b/modules/c++/nitf/include/nitf/NITFBufferList.hpp index 806559dc1..0c1cd0937 100644 --- a/modules/c++/nitf/include/nitf/NITFBufferList.hpp +++ b/modules/c++/nitf/include/nitf/NITFBufferList.hpp @@ -170,7 +170,7 @@ struct NITRO_NITFCPP_API NITFBufferList */ const void* getBlock(size_t blockSize, size_t blockIdx, - std::vector& scratch, + std::vector& scratch, size_t& numBytes) const; const void* getBlock(size_t blockSize, size_t blockIdx, diff --git a/modules/c++/nitf/include/nitf/SegmentSource.hpp b/modules/c++/nitf/include/nitf/SegmentSource.hpp index 4e6357bc8..04ba9646e 100644 --- a/modules/c++/nitf/include/nitf/SegmentSource.hpp +++ b/modules/c++/nitf/include/nitf/SegmentSource.hpp @@ -71,16 +71,16 @@ struct NITRO_NITFCPP_API SegmentMemorySource : public SegmentSource * \param copyData Whether or not to make a copy of the data. If this is * false, the data must outlive the memory source. */ - SegmentMemorySource(const sys::byte* data, nitf::Off size, nitf::Off start, + SegmentMemorySource(const nitf::byte* data, nitf::Off size, nitf::Off start, int byteSkip, bool copyData); SegmentMemorySource(const std::span& data, nitf::Off start, int byteSkip, bool copyData); - SegmentMemorySource(const std::span& data, nitf::Off start, + SegmentMemorySource(const std::span& data, nitf::Off start, int byteSkip, bool copyData); SegmentMemorySource(const std::vector& data, nitf::Off start, int byteSkip, bool copyData); - SegmentMemorySource(const std::vector& data, nitf::Off start, + SegmentMemorySource(const std::vector& data, nitf::Off start, int byteSkip, bool copyData); SegmentMemorySource(const std::string& data, nitf::Off start, int byteSkip, bool copyData); diff --git a/modules/c++/nitf/source/ByteProvider.cpp b/modules/c++/nitf/source/ByteProvider.cpp index 3a134bfd1..55adea06e 100644 --- a/modules/c++/nitf/source/ByteProvider.cpp +++ b/modules/c++/nitf/source/ByteProvider.cpp @@ -78,7 +78,7 @@ static void copyFromStreamAndClear_(io::ByteStream& stream, stream.clear(); } void ByteProvider::copyFromStreamAndClear(io::ByteStream& stream, - std::vector& rawBytes) + std::vector& rawBytes) { copyFromStreamAndClear_(stream, rawBytes); } @@ -393,8 +393,7 @@ mem::auto_ptr ByteProvider::getImageBlocker() const mNumCols, mOverallNumRowsPerBlock, mNumColsPerBlock); - mem::auto_ptr blocker_(blocker.release()); - return blocker_; + return mem::auto_ptr(blocker.release()); } void ByteProvider::checkBlocking(size_t seg, @@ -475,7 +474,7 @@ void ByteProvider::addImageData( const size_t startLocalRowToWrite = startGlobalRowToWrite - startRow + numPadRowsSoFar; const auto imageDataPtr = - static_cast(imageData) + + static_cast(imageData) + startLocalRowToWrite * mNumBytesPerRow; if (buffers.empty()) @@ -632,7 +631,7 @@ void ByteProvider::getBytes(const void* imageData, } } -static std::span make_span(const std::vector& v) noexcept +static std::span make_span(const std::vector& v) noexcept { const void* const pData = v.data(); return std::span(static_cast(pData), v.size()); diff --git a/modules/c++/nitf/source/CompressedByteProvider.cpp b/modules/c++/nitf/source/CompressedByteProvider.cpp index bb15773b0..bd01f13a9 100644 --- a/modules/c++/nitf/source/CompressedByteProvider.cpp +++ b/modules/c++/nitf/source/CompressedByteProvider.cpp @@ -170,7 +170,7 @@ types::Range CompressedByteProvider::findBlocksToWrite( #undef max template static size_t addImageData_(const std::vector > mBytesInEachBlock, - const std::vector >& mImageSubheaders, + const std::vector >& mImageSubheaders, const std::vector& mImageSubheaderFileOffsets, const types::Range& blockRange, size_t seg, @@ -218,7 +218,7 @@ size_t CompressedByteProvider::addImageData( size_t seg, size_t startRow, size_t numRowsToWrite, - const sys::byte* imageData, + const nitf::byte* imageData, nitf::Off& fileOffset, NITFBufferList& buffers) const { diff --git a/modules/c++/nitf/source/NITFBufferList.cpp b/modules/c++/nitf/source/NITFBufferList.cpp index 365157695..49d49a7f0 100644 --- a/modules/c++/nitf/source/NITFBufferList.cpp +++ b/modules/c++/nitf/source/NITFBufferList.cpp @@ -144,7 +144,7 @@ const void* getBlock_(const std::vector& mBuffers, } const void* NITFBufferList::getBlock(size_t blockSize, size_t blockIdx, - std::vector& scratch, + std::vector& scratch, size_t& numBytes) const { numBytes = getNumBytesInBlock(blockSize, blockIdx); diff --git a/modules/c++/nitf/unittests/test_nitf_buffer_list.cpp b/modules/c++/nitf/unittests/test_nitf_buffer_list.cpp index 06a07dfa6..0e136b771 100644 --- a/modules/c++/nitf/unittests/test_nitf_buffer_list.cpp +++ b/modules/c++/nitf/unittests/test_nitf_buffer_list.cpp @@ -45,18 +45,18 @@ TEST_CASE(testGetNumBlocks) TEST_CASE(testGetBlock_sys_byte) { // 100 total bytes - std::vector buffer(100); + std::vector buffer(100); for (size_t ii = 0; ii < buffer.size(); ++ii) { - buffer[ii] = static_cast(rand() % 256); + buffer[ii] = static_cast(rand() % 256); } // Break this into a few pieces - std::vector buffer1(buffer.begin(), buffer.begin() + 10); - std::vector buffer2(buffer.begin() + 10, buffer.begin() + 20); - std::vector buffer3(buffer.begin() + 20, buffer.begin() + 35); - std::vector buffer4(buffer.begin() + 35, buffer.begin() + 57); - std::vector buffer5(buffer.begin() + 57, buffer.end()); + std::vector buffer1(buffer.begin(), buffer.begin() + 10); + std::vector buffer2(buffer.begin() + 10, buffer.begin() + 20); + std::vector buffer3(buffer.begin() + 20, buffer.begin() + 35); + std::vector buffer4(buffer.begin() + 35, buffer.begin() + 57); + std::vector buffer5(buffer.begin() + 57, buffer.end()); // Add them all on nitf::NITFBufferList bufferList; @@ -80,9 +80,9 @@ TEST_CASE(testGetBlock_sys_byte) TEST_ASSERT_EQ(numTotalBytes, buffer.size()); // Extract all the bytes - std::vector extracted(numTotalBytes); + std::vector extracted(numTotalBytes); auto ptr = extracted.data(); - std::vector scratch; + std::vector scratch; size_t numBytesInBlock; for (size_t block = 0; block < numBlocks; ++block) diff --git a/modules/c/nitf-c.vcxproj b/modules/c/nitf-c.vcxproj index 5ee244693..d215863c6 100644 --- a/modules/c/nitf-c.vcxproj +++ b/modules/c/nitf-c.vcxproj @@ -62,7 +62,6 @@ true EnableFastChecks Disabled - true MultiThreadedDebugDLL true From 5d569f213edf99f3339253888a3cf0b888d7c837 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Thu, 23 Jun 2022 12:39:53 -0400 Subject: [PATCH 027/104] Squashed commit of the following: commit e573fc90a0b72b422e8233d45b8bae4b7db38da1 Author: J. Daniel Smith Date: Thu Jun 23 12:39:29 2022 -0400 latest from coda-oss commit 6a64d55a123fb26dba2906dc6b15671b52895b2d Merge: 0add5ad9 3e38c39a Author: J. Daniel Smith Date: Thu Jun 23 12:19:39 2022 -0400 Merge branch 'master' into develop/update-coda-oss commit 0add5ad91c3fa113c4d25c09b3e66486eacecad1 Author: Dan Smith Date: Fri May 13 09:57:07 2022 -0400 latest from coda-oss commit 086e364cb1c8b42b90d0e9b1009f667c94e661fb Author: Dan Smith Date: Thu May 12 13:39:23 2022 -0400 don't need VS UnitTest project commit 48037ff12aca592a79ef3f841b8cc1cae367f8f6 Author: Dan Smith Date: Thu May 12 10:13:19 2022 -0400 fix build errors on Linux commit 85f1cd6274b7a9ace38f404d5de479fc18157e5f Author: Dan Smith Date: Thu May 12 09:50:25 2022 -0400 more updates from coda-oss commit b9b9468d3e78cd2eb1db236012a2ae6358adfb9a Author: Dan Smith Date: Thu May 12 09:49:15 2022 -0400 latest from coda-oss commit 66f9b077ab65e9b4855b51ebdd15f9e8414273de Merge: 0fdf9fbf f27a3894 Author: Dan Smith Date: Thu May 12 09:47:52 2022 -0400 Merge branch 'master' into develop/update-coda-oss commit 0fdf9fbfe31d6b816ea42ebfe14aca1ffd04a6ef Author: Dan Smith Date: Tue May 3 15:42:24 2022 -0400 coda-oss release 2022-05-03 --- .../coda-oss/UnitTest/CppUnitTestAssert.cpp | 43 ++ externals/coda-oss/UnitTest/TestCase.h | 137 ++++++ externals/coda-oss/UnitTest/UnitTest.vcxproj | 361 ++++++++++++++ .../UnitTest/UnitTest.vcxproj.filters | 274 +++++++++++ externals/coda-oss/UnitTest/avx.cpp | 11 + externals/coda-oss/UnitTest/cli.cpp | 10 + externals/coda-oss/UnitTest/io.cpp | 21 + externals/coda-oss/UnitTest/logging.cpp | 15 + externals/coda-oss/UnitTest/math.cpp | 31 ++ externals/coda-oss/UnitTest/math.linear.cpp | 47 ++ externals/coda-oss/UnitTest/math.poly.cpp | 41 ++ externals/coda-oss/UnitTest/mem.cpp | 38 ++ externals/coda-oss/UnitTest/mt.cpp | 27 ++ externals/coda-oss/UnitTest/pch.cpp | 5 + externals/coda-oss/UnitTest/pch.h | 105 ++++ externals/coda-oss/UnitTest/polygon.cpp | 10 + externals/coda-oss/UnitTest/re.cpp | 11 + externals/coda-oss/UnitTest/str.cpp | 18 + externals/coda-oss/UnitTest/sys.cpp | 38 ++ externals/coda-oss/UnitTest/types.cpp | 18 + externals/coda-oss/UnitTest/units.cpp | 12 + externals/coda-oss/coda-oss-lite.sln | 39 ++ .../modules/c++/avx/include/avx/extractf.h | 13 +- .../modules/c++/avx/unittests/test_m256.cpp | 10 +- .../modules/c++/cli/include/cli/Argument.h | 4 +- .../c++/cli/include/cli/ArgumentParser.h | 3 +- .../modules/c++/cli/include/cli/Value.h | 4 +- .../modules/c++/cli/unittests/test_cli.cpp | 6 +- .../modules/c++/coda-oss-lite.vcxproj | 223 +++++---- .../modules/c++/coda-oss-lite.vcxproj.filters | 450 ++++++++++++++---- .../c++/except/include/except/Context.h | 2 +- .../coda-oss/modules/c++/include/TestCase.h | 242 +++------- .../modules/c++/io/include/io/ByteStream.h | 4 +- .../c++/io/include/io/CountingStreams.h | 3 +- .../modules/c++/io/include/io/InputStream.h | 3 +- .../modules/c++/io/include/io/OutputStream.h | 3 +- .../modules/c++/io/include/io/ProxyStreams.h | 7 +- .../io/include/io/RotatingFileOutputStream.h | 3 +- .../modules/c++/io/include/io/Seekable.h | 4 +- .../c++/io/include/io/SeekableStreams.h | 5 +- .../c++/io/include/io/StreamSplitter.h | 8 +- .../modules/c++/io/include/io/TempFile.h | 5 +- .../modules/c++/io/unittests/test_streams.cpp | 20 +- .../c++/io/unittests/test_tempfile.cpp | 10 +- .../c++/logging/include/logging/Filterer.h | 5 +- .../c++/logging/include/logging/Handler.h | 3 +- .../c++/logging/include/logging/Logger.h | 3 +- .../include/logging/RotatingFileHandler.h | 3 +- .../include/logging/StandardFormatter.h | 3 +- .../logging/include/logging/StreamHandler.h | 3 +- .../unittests/test_exception_logger.cpp | 20 +- .../logging/unittests/test_rotating_log.cpp | 5 +- .../c++/math.poly/unittests/test_1d_poly.cpp | 11 +- .../c++/math.poly/unittests/test_2d_poly.cpp | 11 +- .../unittests/test_fixed_1d_poly.cpp | 12 +- .../unittests/test_fixed_2d_poly.cpp | 12 +- .../c++/math.poly/unittests/test_llsq.cpp | 26 +- .../modules/c++/mem/unittests/test_Span.cpp | 4 +- .../modules/c++/mt/include/mt/Algorithm.h | 2 +- .../c++/mt/include/mt/GenerationThreadPool.h | 6 +- .../modules/c++/mt/include/mt/ThreadGroup.h | 5 +- .../modules/c++/mt/include/mt/ThreadPlanner.h | 4 +- .../c++/mt/unittests/Runnable1DTest.cpp | 49 +- .../c++/mt/unittests/ThreadGroupTest.cpp | 35 +- .../c++/mt/unittests/ThreadPlannerTest.cpp | 10 +- .../unittests/balanced_runnable_1d_test.cpp | 9 +- ...work_sharing_balanced_runnable_1d_test.cpp | 12 +- .../c++/polygon/include/polygon/PolygonMask.h | 3 +- .../polygon/unittests/test_polygon_mask.cpp | 25 +- .../modules/c++/re/include/re/Regex.h | 6 +- .../modules/c++/re/unittests/test_regex.cpp | 6 +- .../sio.lite/include/sio/lite/FileReader.h | 129 +---- .../sio.lite/include/sio/lite/FileWriter.h | 174 +------ .../sio.lite/include/sio/lite/SioFileReader.h | 147 ++++++ .../sio.lite/include/sio/lite/SioFileWriter.h | 196 ++++++++ .../{FileReader.cpp => SioFileReader.cpp} | 0 .../{FileWriter.cpp => SioFileWriter.cpp} | 0 .../coda-oss/modules/c++/sio.lite/wscript | 1 - .../modules/c++/str/include/str/Convert.h | 8 +- .../modules/c++/str/include/str/Format.h | 7 +- .../modules/c++/str/source/Convert.cpp | 5 + .../c++/str/unittests/test_base_convert.cpp | 35 +- .../modules/c++/sys/include/sys/AbstractOS.h | 4 +- .../modules/c++/sys/include/sys/Backtrace.h | 6 +- .../sys/include/sys/ConditionVarInterface.h | 5 +- .../c++/sys/include/sys/ConditionVarWin32.h | 6 +- .../modules/c++/sys/include/sys/Conf.h | 2 +- .../modules/c++/sys/include/sys/Dbg.h | 6 +- .../modules/c++/sys/include/sys/Err.h | 4 +- .../c++/sys/include/sys/LocalDateTime.h | 6 +- .../c++/sys/include/sys/MutexInterface.h | 4 +- .../modules/c++/sys/include/sys/MutexWin32.h | 4 +- .../modules/c++/sys/include/sys/OSWin32.h | 2 +- .../modules/c++/sys/include/sys/Path.h | 4 +- .../modules/c++/sys/include/sys/Runnable.h | 3 +- .../c++/sys/include/sys/SemaphoreInterface.h | 3 +- .../c++/sys/include/sys/SemaphoreWin32.h | 4 +- .../c++/sys/include/sys/ThreadInterface.h | 3 +- .../modules/c++/sys/include/sys/ThreadWin32.h | 6 +- .../modules/c++/sys/include/sys/UTCDateTime.h | 10 +- .../c++/sys/include/sys/sys_filesystem.h | 4 +- .../modules/c++/sys/source/LocalDateTime.cpp | 8 +- .../modules/c++/sys/source/UTCDateTime.cpp | 9 +- .../c++/sys/unittests/test_NaN_testing.cpp | 8 +- .../c++/sys/unittests/test_aligned_alloc.cpp | 19 +- .../c++/sys/unittests/test_atomic_counter.cpp | 10 +- .../c++/sys/unittests/test_byte_swap.cpp | 12 +- .../c++/sys/unittests/test_conditionvar.cpp | 12 +- .../c++/sys/unittests/test_datetime.cpp | 12 +- .../modules/c++/sys/unittests/test_os.cpp | 48 +- .../modules/c++/sys/unittests/test_path.cpp | 42 +- .../c++/tiff/include/tiff/FileReader.h | 129 +---- .../c++/tiff/include/tiff/FileWriter.h | 240 +--------- .../c++/tiff/include/tiff/TiffFileReader.h | 148 ++++++ .../c++/tiff/include/tiff/TiffFileWriter.h | 259 ++++++++++ .../{FileReader.cpp => TiffFileReader.cpp} | 2 +- .../{FileWriter.cpp => TiffFileWriter.cpp} | 0 externals/coda-oss/modules/c++/tiff/wscript | 1 - .../modules/c++/types/include/types/Range.h | 4 +- .../c++/types/include/types/RangeList.h | 4 +- .../c++/types/unittests/test_page_row_col.cpp | 9 +- .../c++/types/unittests/test_range.cpp | 9 +- .../c++/types/unittests/test_range_list.cpp | 9 +- .../c++/units/unittests/test_units.cpp | 6 +- .../c++/xml.lite/include/import/xml/lite.h | 47 +- .../sys/source/generated/coda_sys_wrap.cxx | 17 +- 126 files changed, 3025 insertions(+), 1464 deletions(-) create mode 100644 externals/coda-oss/UnitTest/CppUnitTestAssert.cpp create mode 100644 externals/coda-oss/UnitTest/TestCase.h create mode 100644 externals/coda-oss/UnitTest/UnitTest.vcxproj create mode 100644 externals/coda-oss/UnitTest/UnitTest.vcxproj.filters create mode 100644 externals/coda-oss/UnitTest/avx.cpp create mode 100644 externals/coda-oss/UnitTest/cli.cpp create mode 100644 externals/coda-oss/UnitTest/io.cpp create mode 100644 externals/coda-oss/UnitTest/logging.cpp create mode 100644 externals/coda-oss/UnitTest/math.cpp create mode 100644 externals/coda-oss/UnitTest/math.linear.cpp create mode 100644 externals/coda-oss/UnitTest/math.poly.cpp create mode 100644 externals/coda-oss/UnitTest/mem.cpp create mode 100644 externals/coda-oss/UnitTest/mt.cpp create mode 100644 externals/coda-oss/UnitTest/pch.cpp create mode 100644 externals/coda-oss/UnitTest/pch.h create mode 100644 externals/coda-oss/UnitTest/polygon.cpp create mode 100644 externals/coda-oss/UnitTest/re.cpp create mode 100644 externals/coda-oss/UnitTest/str.cpp create mode 100644 externals/coda-oss/UnitTest/sys.cpp create mode 100644 externals/coda-oss/UnitTest/types.cpp create mode 100644 externals/coda-oss/UnitTest/units.cpp create mode 100644 externals/coda-oss/coda-oss-lite.sln create mode 100644 externals/coda-oss/modules/c++/sio.lite/include/sio/lite/SioFileReader.h create mode 100644 externals/coda-oss/modules/c++/sio.lite/include/sio/lite/SioFileWriter.h rename externals/coda-oss/modules/c++/sio.lite/source/{FileReader.cpp => SioFileReader.cpp} (100%) rename externals/coda-oss/modules/c++/sio.lite/source/{FileWriter.cpp => SioFileWriter.cpp} (100%) create mode 100644 externals/coda-oss/modules/c++/tiff/include/tiff/TiffFileReader.h create mode 100644 externals/coda-oss/modules/c++/tiff/include/tiff/TiffFileWriter.h rename externals/coda-oss/modules/c++/tiff/source/{FileReader.cpp => TiffFileReader.cpp} (99%) rename externals/coda-oss/modules/c++/tiff/source/{FileWriter.cpp => TiffFileWriter.cpp} (100%) diff --git a/externals/coda-oss/UnitTest/CppUnitTestAssert.cpp b/externals/coda-oss/UnitTest/CppUnitTestAssert.cpp new file mode 100644 index 000000000..8f86c100f --- /dev/null +++ b/externals/coda-oss/UnitTest/CppUnitTestAssert.cpp @@ -0,0 +1,43 @@ +#include "pch.h" +#include "TestCase.h" + +#include "str/EncodedStringView.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +// EQUALS_MESSAGE() wants ToString() specializations (or overloads) for our types, which is a nusiance. +// This hooks up our existing str::toString() into the VC++ unit-test infrastructure + +// C++ hack to call private methods +// https://stackoverflow.com/questions/6873138/calling-private-method-in-c?msclkid=dd8b1f8bd09711ec8610b4501a04de94 + +using FailOnCondition_t = void(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare method's type +using GetAssertMessage_t = std::wstring(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare method's type +template +struct caller final // helper structure to inject call() code +{ + friend void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) + { + fFailOnCondition(condition, message, pLineInfo); + } + + friend std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message) + { + return fGetAssertMessage(equality, expected, actual, message); + } +}; +template struct caller<&Assert::FailOnCondition, &Assert::GetAssertMessage>; // even instantiation of the helper + +void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare caller +void test::Assert::FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) +{ + ::FailOnCondition(condition, message, pLineInfo); // and call! +} + +std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare caller +std::wstring test::Assert::GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message) +{ + const str::EncodedStringView vExpected(expected); + const str::EncodedStringView vActual(actual); + return ::GetAssertMessage(equality, vExpected.wstring(), vActual.wstring(), message); // and call! +} diff --git a/externals/coda-oss/UnitTest/TestCase.h b/externals/coda-oss/UnitTest/TestCase.h new file mode 100644 index 000000000..32852fa38 --- /dev/null +++ b/externals/coda-oss/UnitTest/TestCase.h @@ -0,0 +1,137 @@ +#pragma once + +#include +#include + +#include "CppUnitTest.h" +#include +#include + +#undef TEST_CHECK +#undef TEST_ASSERT +#undef TEST_ASSERT_NULL +#undef TEST_ASSERT_TRUE +#undef TEST_ASSERT_FALSE +#undef TEST_MAIN +#undef TEST_CASE +#define TEST_CHECK(X) +#define TEST_MAIN(X) +#define TEST_ASSERT_NULL(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNull((X)) +#define TEST_ASSERT_TRUE(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue((X)) +#define TEST_ASSERT_FALSE(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsFalse((X)) +#define TEST_ASSERT(X) TEST_ASSERT_TRUE(X) +#define CODA_OSS_testMethod_(X) testMethod ## _ ## X +#define TEST_CASE(X) TEST_METHOD(X) { CODA_OSS_testMethod_(X)(#X); } void CODA_OSS_testMethod_(X)(std::string testName) + +namespace test +{ + struct Assert final + { + static void FailOnCondition(bool condition, const unsigned short* message, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo); + static std::wstring GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message); + }; +#define CODA_OSS_equals_message_(expected, actual, message) reinterpret_cast(test::Assert::GetAssertMessage(true, str::toString(expected), str::toString(actual), message).c_str()) +#define CODA_OSS_not_equals_message_(notExpected, actual, message) reinterpret_cast(test::Assert::GetAssertMessage(false, str::toString(notExpected), str::toString(actual), message).c_str()) +#define CODA_OSS_message_(message) reinterpret_cast(test::Assert::GetAssertMessage(false, "", "", message).c_str()) + +// see Assert::AreEqual<> +template +inline void diePrintf_eq(const TExpected& expected, const TActual& actual, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(expected == actual, CODA_OSS_equals_message_(expected, actual, message), pLineInfo); +} + +// see Assert::AreNotEqual<> +template +inline void diePrintf_ne(const TExpected& notExpected, const TActual& actual, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(notExpected != actual, CODA_OSS_not_equals_message_(notExpected, actual, message), pLineInfo); +} + +template +inline void diePrintf_ge(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 >= X2, CODA_OSS_message_(message), pLineInfo); +} +template +inline void diePrintf_gt(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 > X2, CODA_OSS_message_(message), pLineInfo); +} +template +inline void diePrintf_le(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 <= X2, CODA_OSS_message_(message), pLineInfo); +} +template +inline void diePrintf_lt(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 < X2, CODA_OSS_message_(message), pLineInfo); +} + +} +#undef CODA_OSS_test_diePrintf_eq_ +#undef CODA_OSS_test_diePrintf_not_eq_ +#define CODA_OSS_test_diePrintf_eq_(X1, X2) testName, test::diePrintf_eq(X1, X2) +#define CODA_OSS_test_diePrintf_not_eq_(X1, X2) testName, test::diePrintf_ne(X1, X2) + +#undef CODA_OSS_test_diePrintf_greater_eq_ +#undef CODA_OSS_test_diePrintf_greater_ +#undef CODA_OSS_test_diePrintf_lesser_eq_ +#undef CODA_OSS_test_diePrintf_lesser_ +#define CODA_OSS_test_diePrintf_greater_eq_(X1, X2) testName, test::diePrintf_ge(X1, X2) +#define CODA_OSS_test_diePrintf_greater_(X1, X2) testName, test::diePrintf_gt(X1, X2) +#define CODA_OSS_test_diePrintf_lesser_eq_(X1, X2) testName, test::diePrintf_le(X1, X2) +#define CODA_OSS_test_diePrintf_lesser_(X1, X2) testName, test::diePrintf_lt(X1, X2) + +template +inline void test_assert_greater_(const TX1& X1, const TX2& X2) +{ + Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(X1 > X2); +} +#undef TEST_ASSERT_GREATER +#define TEST_ASSERT_GREATER(X1, X2) testName, test_assert_greater_(X1, X2) + +#undef TEST_ASSERT_ALMOST_EQ_EPS +#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) { (void)testName; Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(X1, X2, EPS); Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(X2, X1, EPS); } +namespace test +{ +inline void assert_almost_eq(const std::string& testName, float X1, float X2) +{ + constexpr auto EPS = static_cast(0.0001); + TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS); +} +inline void assert_almost_eq(const std::string& testName, double X1, double X2) +{ + constexpr auto EPS = static_cast(0.0001); + TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS); +} +inline void assert_almost_eq(const std::string& testName, long double X1, long double X2) +{ + assert_almost_eq(testName, static_cast(X1), static_cast(X2)); +} +} + +#undef TEST_ASSERT_ALMOST_EQ +#define TEST_ASSERT_ALMOST_EQ(X1, X2) test::assert_almost_eq(testName, X1, X2) + +#undef TEST_ASSERT_EQ_MSG +#define TEST_ASSERT_EQ_MSG(msg, X1, X2) testName, Microsoft::VisualStudio::CppUnitTestFramework::Logger::WriteMessage(msg.c_str()); TEST_ASSERT_EQ(X1, X2) + +#undef TEST_FAIL +#define TEST_FAIL(msg) { (void)testName; const str::EncodedStringView vw(msg); Microsoft::VisualStudio::CppUnitTestFramework::Assert::Fail(vw.wstring().c_str()); } + +#undef TEST_EXCEPTION +#undef TEST_THROWS +#undef TEST_SPECIFIC_EXCEPTION +#define TEST_EXCEPTION(X) (void)testName; try{ (X); TEST_FAIL(#X " should have thrown."); } \ + catch (const except::Throwable&){ TEST_ASSERT_TRUE(true); } catch (const except::Throwable11&){ TEST_ASSERT_TRUE(true); } +#define TEST_THROWS(X) (void)testName; try{ (X); TEST_FAIL(#X " should have thrown."); } catch (...){ TEST_ASSERT_TRUE(true); } +#define TEST_SPECIFIC_EXCEPTION(X, Y) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::ExpectException([&](){(X);}) + diff --git a/externals/coda-oss/UnitTest/UnitTest.vcxproj b/externals/coda-oss/UnitTest/UnitTest.vcxproj new file mode 100644 index 000000000..49c37fc6a --- /dev/null +++ b/externals/coda-oss/UnitTest/UnitTest.vcxproj @@ -0,0 +1,361 @@ + + + + + Debug + x64 + + + Release + x64 + + + + 17.0 + {34A31B3F-47C5-441D-AB22-3C85B3C5314E} + Win32Proj + UnitTest + 10.0 + NativeUnitTestProject + + + + DynamicLibrary + true + v143 + Unicode + false + + + DynamicLibrary + false + v143 + true + Unicode + false + + + + + + + + + + + + + + + true + + + false + + + + Use + Level4 + true + $(VCInstallDir)UnitTest\include;$(ProjectDir);$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\avx\include\;$(SolutionDir)modules\c++\cli\include\;$(SolutionDir)modules\c++\config\include\;$(SolutionDir)modules\c++\coda_oss\include\;$(SolutionDir)modules\c++\gsl\include\;$(SolutionDir)modules\c++\io\include\;$(SolutionDir)modules\c++\std\include\;$(SolutionDir)modules\c++\str\include\;$(SolutionDir)modules\c++\sys\include\;$(SolutionDir)modules\c++\except\include\;$(SolutionDir)modules\c++\logging\include\;$(SolutionDir)modules\c++\math\include\;$(SolutionDir)modules\c++\math.linear\include\;$(SolutionDir)modules\c++\math.poly\include\;$(SolutionDir)modules\c++\mem\include\;$(SolutionDir)modules\c++\mt\include\;$(SolutionDir)modules\c++\polygon\include\;$(SolutionDir)modules\c++\re\include\;$(SolutionDir)modules\c++\types\include\;$(SolutionDir)modules\c++\units\include\;%(AdditionalIncludeDirectories) + _DEBUG;%(PreprocessorDefinitions);MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 + true + pch.h + true + true + Guard + true + true + ProgramDatabase + true + + + Windows + $(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) + + + + + Use + Level3 + true + true + true + $(VCInstallDir)UnitTest\include;$(ProjectDir);$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\avx\include\;$(SolutionDir)modules\c++\cli\include\;$(SolutionDir)modules\c++\config\include\;$(SolutionDir)modules\c++\coda_oss\include\;$(SolutionDir)modules\c++\gsl\include\;$(SolutionDir)modules\c++\io\include\;$(SolutionDir)modules\c++\std\include\;$(SolutionDir)modules\c++\str\include\;$(SolutionDir)modules\c++\sys\include\;$(SolutionDir)modules\c++\except\include\;$(SolutionDir)modules\c++\logging\include\;$(SolutionDir)modules\c++\math\include\;$(SolutionDir)modules\c++\math.linear\include\;$(SolutionDir)modules\c++\math.poly\include\;$(SolutionDir)modules\c++\mem\include\;$(SolutionDir)modules\c++\mt\include\;$(SolutionDir)modules\c++\polygon\include\;$(SolutionDir)modules\c++\re\include\;$(SolutionDir)modules\c++\types\include\;$(SolutionDir)modules\c++\units\include\;%(AdditionalIncludeDirectories) + NDEBUG;%(PreprocessorDefinitions);MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 + true + pch.h + true + Guard + true + + + Windows + true + true + $(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) + + + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + + + + + + + + + + Create + Create + + + + + + + + + + + + + + + + {9997e895-5161-4ddf-8f3f-099894cb2f21} + + + + + + \ No newline at end of file diff --git a/externals/coda-oss/UnitTest/UnitTest.vcxproj.filters b/externals/coda-oss/UnitTest/UnitTest.vcxproj.filters new file mode 100644 index 000000000..c28135611 --- /dev/null +++ b/externals/coda-oss/UnitTest/UnitTest.vcxproj.filters @@ -0,0 +1,274 @@ + + + + + + + mt + + + mt + + + mt + + + mt + + + mt + + + mt + + + sys + + + sys + + + sys + + + sys + + + sys + + + sys + + + sys + + + sys + + + sys + + + cli + + + cli + + + io + + + io + + + io + + + io + + + math + + + math + + + math + + + math + + + math + + + math + + + math + + + math.linear + + + math.poly + + + math.linear + + + math.linear + + + math.linear + + + math.linear + + + math.linear + + + math.linear + + + math.linear + + + math.linear + + + math.linear + + + math.poly + + + math.poly + + + math.poly + + + math.poly + + + math.poly + + + math.poly + + + math.poly + + + mem + + + polygon + + + str + + + types + + + units + + + units + + + types + + + types + + + types + + + str + + + str + + + mem + + + mem + + + mem + + + mem + + + mem + + + mem + + + mem + + + polygon + + + avx + + + avx + + + logging + + + logging + + + logging + + + re + + + re + + + + + + + + + {ea90a933-47d1-448a-8265-3742d1ce18f8} + + + {e3f97021-8c19-46cb-962c-d1cea71da3a2} + + + {4e86a44b-1997-42e6-86bc-f4167698b3a1} + + + {5f9ed5ed-863e-4dd6-a5dd-e22758218112} + + + {d343bd9f-8b19-4740-bdf8-39d687ab56bf} + + + {a4045a72-e6a4-4421-9eab-818136f2d22c} + + + {90e2ffd7-1b9a-4096-b2fa-b41159333682} + + + {cf1423ec-9599-4936-9563-afdcdda85f62} + + + {331ec48a-ac3a-4a63-b410-23701adec599} + + + {87b5dc54-ceaf-4f37-b074-41b295b8a92d} + + + {d444ddb7-6b00-495a-94d6-a2674cbfea83} + + + {7a48027a-9dd9-4700-a6fc-703dc7468721} + + + {0afb2127-0ee7-46d6-963c-132a7830a7d7} + + + {3baea66d-2852-40fe-8482-e3f6ba1a81e0} + + + {d205c017-7e98-456f-923f-2f78870a3d7d} + + + \ No newline at end of file diff --git a/externals/coda-oss/UnitTest/avx.cpp b/externals/coda-oss/UnitTest/avx.cpp new file mode 100644 index 000000000..535dc859f --- /dev/null +++ b/externals/coda-oss/UnitTest/avx.cpp @@ -0,0 +1,11 @@ +#include "pch.h" +#include "CppUnitTest.h" + +namespace avx +{ + +TEST_CLASS(test_m256){ public: +#include "avx/unittests/test_m256.cpp" +}; + +} \ No newline at end of file diff --git a/externals/coda-oss/UnitTest/cli.cpp b/externals/coda-oss/UnitTest/cli.cpp new file mode 100644 index 000000000..0d034e535 --- /dev/null +++ b/externals/coda-oss/UnitTest/cli.cpp @@ -0,0 +1,10 @@ +#include "pch.h" +#include "CppUnitTest.h" + +namespace cli +{ +TEST_CLASS(test_cli){ public: +#include "cli/unittests/test_cli.cpp" +}; + +} \ No newline at end of file diff --git a/externals/coda-oss/UnitTest/io.cpp b/externals/coda-oss/UnitTest/io.cpp new file mode 100644 index 000000000..5a56cce7c --- /dev/null +++ b/externals/coda-oss/UnitTest/io.cpp @@ -0,0 +1,21 @@ +#include "pch.h" +#include "CppUnitTest.h" + +#include +#include + +namespace io +{ +TEST_CLASS(test_stream_splitter){ public: +#include "io/unittests/test_stream_splitter.cpp" +}; + +TEST_CLASS(test_streams){ public: +#include "io/unittests/test_streams.cpp" +}; + +TEST_CLASS(test_tempfile){ public: +#include "io/unittests/test_tempfile.cpp" +}; + +} \ No newline at end of file diff --git a/externals/coda-oss/UnitTest/logging.cpp b/externals/coda-oss/UnitTest/logging.cpp new file mode 100644 index 000000000..5d840e99b --- /dev/null +++ b/externals/coda-oss/UnitTest/logging.cpp @@ -0,0 +1,15 @@ +#include "pch.h" +#include "CppUnitTest.h" + +namespace logging +{ + +TEST_CLASS(test_exception_logger){ public: +#include "logging/unittests/test_exception_logger.cpp" +}; + +TEST_CLASS(test_rotating_log){ public: +#include "logging/unittests/test_rotating_log.cpp" +}; + +} \ No newline at end of file diff --git a/externals/coda-oss/UnitTest/math.cpp b/externals/coda-oss/UnitTest/math.cpp new file mode 100644 index 000000000..7b16b850a --- /dev/null +++ b/externals/coda-oss/UnitTest/math.cpp @@ -0,0 +1,31 @@ +#include "pch.h" +#include "CppUnitTest.h" + +#include + +namespace math +{ +TEST_CLASS(test_bessel_functions){ public: +#include "math/unittests/test_bessel_functions.cpp" +}; + +TEST_CLASS(test_convex_hull){ public: +#include "math/unittests/test_convex_hull.cpp" +}; + +TEST_CLASS(test_is_nan){ public: +#include "math/unittests/test_is_nan.cpp" +}; + +TEST_CLASS(test_n_choose_k){ public: +#include "math/unittests/test_n_choose_k.cpp" +}; + +TEST_CLASS(test_round){ public: +#include "math/unittests/test_round.cpp" +}; + +TEST_CLASS(test_sign){ public: +#include "math/unittests/test_sign.cpp" +}; +} \ No newline at end of file diff --git a/externals/coda-oss/UnitTest/math.linear.cpp b/externals/coda-oss/UnitTest/math.linear.cpp new file mode 100644 index 000000000..d44984fb9 --- /dev/null +++ b/externals/coda-oss/UnitTest/math.linear.cpp @@ -0,0 +1,47 @@ +#include "pch.h" +#include "CppUnitTest.h" + +#include + +namespace math_linear +{ +TEST_CLASS(test_eigenvalue){ public: +#include "math.linear/unittests/test_eigenvalue.cpp" +}; + +TEST_CLASS(test_inf_equality){ public: +#include "math.linear/unittests/test_inf_equality.cpp" +}; + +TEST_CLASS(test_inverse){ public: +#include "math.linear/unittests/test_inverse.cpp" +}; + +TEST_CLASS(test_lin){ public: +#include "math.linear/unittests/test_lin.cpp" +}; + +#ifdef HAVE_BOOST +TEST_CLASS(test_Matrix2D_serialize){ public: +#include "math.linear/unittests/test_Matrix2D_serialize.cpp" +}; +#endif + +TEST_CLASS(test_mx){ public: +#include "math.linear/unittests/test_mx.cpp" +}; + +TEST_CLASS(test_Vector){ public: +#include "math.linear/unittests/test_Vector.cpp" +}; + +#ifdef HAVE_BOOST +TEST_CLASS(test_Vector_serialize){ public: +#include "math.linear/unittests/test_Vector_serialize.cpp" +}; +#endif + +TEST_CLASS(test_VectorN){ public: +#include "math.linear/unittests/test_VectorN.cpp" +}; +} \ No newline at end of file diff --git a/externals/coda-oss/UnitTest/math.poly.cpp b/externals/coda-oss/UnitTest/math.poly.cpp new file mode 100644 index 000000000..84dcaf98a --- /dev/null +++ b/externals/coda-oss/UnitTest/math.poly.cpp @@ -0,0 +1,41 @@ +#include "pch.h" +#include "CppUnitTest.h" + +#include +#include + +namespace math_poly +{ +TEST_CLASS(test_1d_poly){ public: +#include "math.poly/unittests/test_1d_poly.cpp" +}; + +#ifdef HAVE_BOOST +TEST_CLASS(test_1d_poly_serialize){ public: +#include "math.poly/unittests/test_1d_poly_serialize.cpp" +}; +#endif + +TEST_CLASS(test_2d_poly){ public: +#include "math.poly/unittests/test_2d_poly.cpp" +}; + +#ifdef HAVE_BOOST +TEST_CLASS(test_2d_poly_serialize){ public: +#include "math.poly/unittests/test_2d_poly_serialize.cpp" +}; +#endif + +TEST_CLASS(test_fixed_1d_poly){ public: +#include "math.poly/unittests/test_fixed_1d_poly.cpp" +}; + +TEST_CLASS(test_fixed_2d_poly){ public: +#include "math.poly/unittests/test_fixed_2d_poly.cpp" +}; + +TEST_CLASS(test_llsq){ public: +#include "math.poly/unittests/test_llsq.cpp" +}; + +} \ No newline at end of file diff --git a/externals/coda-oss/UnitTest/mem.cpp b/externals/coda-oss/UnitTest/mem.cpp new file mode 100644 index 000000000..5ff41c0a5 --- /dev/null +++ b/externals/coda-oss/UnitTest/mem.cpp @@ -0,0 +1,38 @@ +#include "pch.h" +#include "CppUnitTest.h" + +#include +#include + +namespace mem +{ + +TEST_CLASS(test_scoped_cloneable_ptr){ public: +#include "mem/unittests/test_scoped_cloneable_ptr.cpp" +}; + +TEST_CLASS(test_scoped_copyable_ptr){ public: +#include "mem/unittests/test_scoped_copyable_ptr.cpp" +}; + +TEST_CLASS(test_scratch_memory){ public: +#include "mem/unittests/test_scratch_memory.cpp" +}; + +TEST_CLASS(test_shared_ptr){ public: +#include "mem/unittests/test_shared_ptr.cpp" +}; + +TEST_CLASS(test_Span){ public: +#include "mem/unittests/test_Span.cpp" +}; + +TEST_CLASS(test_unique_ptr){ public: +#include "mem/unittests/test_unique_ptr.cpp" +}; + +TEST_CLASS(test_vector_pointers){ public: +#include "mem/unittests/test_vector_pointers.cpp" +}; + +} \ No newline at end of file diff --git a/externals/coda-oss/UnitTest/mt.cpp b/externals/coda-oss/UnitTest/mt.cpp new file mode 100644 index 000000000..2de6f17fd --- /dev/null +++ b/externals/coda-oss/UnitTest/mt.cpp @@ -0,0 +1,27 @@ +#include "pch.h" +#include "CppUnitTest.h" + +namespace mt +{ + +TEST_CLASS(balanced_runnable_1d_test){ public: +#include "mt/unittests/balanced_runnable_1d_test.cpp" +}; + +TEST_CLASS(Runnable1DTest){ public: +#include "mt/unittests/Runnable1DTest.cpp" +}; + +TEST_CLASS(ThreadGroupTest){ public: +#include "mt/unittests/ThreadGroupTest.cpp" +}; + +TEST_CLASS(ThreadPlannerTest){ public: +#include "mt/unittests/ThreadPlannerTest.cpp" +}; + +TEST_CLASS(work_sharing_balanced_runnable_1d_test){ public: +#include "mt/unittests/work_sharing_balanced_runnable_1d_test.cpp" +}; + +} \ No newline at end of file diff --git a/externals/coda-oss/UnitTest/pch.cpp b/externals/coda-oss/UnitTest/pch.cpp new file mode 100644 index 000000000..64b7eef6d --- /dev/null +++ b/externals/coda-oss/UnitTest/pch.cpp @@ -0,0 +1,5 @@ +// pch.cpp: source file corresponding to the pre-compiled header + +#include "pch.h" + +// When you are using pre-compiled headers, this source file is necessary for compilation to succeed. diff --git a/externals/coda-oss/UnitTest/pch.h b/externals/coda-oss/UnitTest/pch.h new file mode 100644 index 000000000..832b72291 --- /dev/null +++ b/externals/coda-oss/UnitTest/pch.h @@ -0,0 +1,105 @@ +// pch.h: This is a precompiled header file. +// Files listed below are compiled only once, improving build performance for future builds. +// This also affects IntelliSense performance, including code completion and many code browsing features. +// However, files listed here are ALL re-compiled if any one of them is updated between builds. +// Do not add files here that you will be updating frequently as this negates the performance advantage. + +#ifndef PCH_H +#define PCH_H + +// add headers that you want to pre-compile here + +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#include +#include +#undef min +#undef max + +#define _USE_MATH_DEFINES +#include +#include + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include // std::endian +#include +#include // std::accumulate +#include +#include + +#include "CppUnitTest.h" + +#include "gsl/gsl.h" +#include "import/sys.h" +#include "import/math.h" +#include "import/str.h" +#include "str/EncodedStringView.h" +#include "import/except.h" +#include "import/mem.h" +#include +#include "import/cli.h" +#include "polygon/DrawPolygon.h" +#include "polygon/PolygonMask.h" +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include + +#include "TestCase.h" + +#endif //PCH_H diff --git a/externals/coda-oss/UnitTest/polygon.cpp b/externals/coda-oss/UnitTest/polygon.cpp new file mode 100644 index 000000000..32bc9fd0b --- /dev/null +++ b/externals/coda-oss/UnitTest/polygon.cpp @@ -0,0 +1,10 @@ +#include "pch.h" +#include "CppUnitTest.h" + +namespace polygon +{ +TEST_CLASS(test_polygon_mask){ public: +#include "polygon/unittests/test_polygon_mask.cpp" +}; + +} \ No newline at end of file diff --git a/externals/coda-oss/UnitTest/re.cpp b/externals/coda-oss/UnitTest/re.cpp new file mode 100644 index 000000000..28d468241 --- /dev/null +++ b/externals/coda-oss/UnitTest/re.cpp @@ -0,0 +1,11 @@ +#include "pch.h" +#include "CppUnitTest.h" + +namespace re +{ + +TEST_CLASS(test_regex){ public: +#include "re/unittests/test_regex.cpp" +}; + +} \ No newline at end of file diff --git a/externals/coda-oss/UnitTest/str.cpp b/externals/coda-oss/UnitTest/str.cpp new file mode 100644 index 000000000..630428cfa --- /dev/null +++ b/externals/coda-oss/UnitTest/str.cpp @@ -0,0 +1,18 @@ +#include "pch.h" +#include "CppUnitTest.h" + +#include + +#include +#include + +namespace str +{ + TEST_CLASS(test_base_convert){ public: + #include "str/unittests/test_base_convert.cpp" + }; + + TEST_CLASS(test_str){ public: + #include "str/unittests/test_str.cpp" + }; +} diff --git a/externals/coda-oss/UnitTest/sys.cpp b/externals/coda-oss/UnitTest/sys.cpp new file mode 100644 index 000000000..bedfa9818 --- /dev/null +++ b/externals/coda-oss/UnitTest/sys.cpp @@ -0,0 +1,38 @@ +#include "pch.h" +#include "CppUnitTest.h" + +namespace sys +{ +TEST_CLASS(test_aligned_alloc){ public: +#include "sys/unittests/test_aligned_alloc.cpp" +}; + +TEST_CLASS(test_atomic_counter){ public: +#include "sys/unittests/test_atomic_counter.cpp" +}; + +TEST_CLASS(test_byte_swap){ public: +#include "sys/unittests/test_byte_swap.cpp" +}; + +TEST_CLASS(test_conditionvar){ public: +#include "sys/unittests/test_conditionvar.cpp" +}; + +TEST_CLASS(test_datetime){ public: +#include "sys/unittests/test_datetime.cpp" +}; + +TEST_CLASS(test_NaN_testing){ public: +#include "sys/unittests/test_NaN_testing.cpp" +}; + +TEST_CLASS(test_os){ public: +#include "sys/unittests/test_os.cpp" +}; + +TEST_CLASS(test_path){ public: +#include "sys/unittests/test_path.cpp" +}; + +} \ No newline at end of file diff --git a/externals/coda-oss/UnitTest/types.cpp b/externals/coda-oss/UnitTest/types.cpp new file mode 100644 index 000000000..1384c00b7 --- /dev/null +++ b/externals/coda-oss/UnitTest/types.cpp @@ -0,0 +1,18 @@ +#include "pch.h" +#include "CppUnitTest.h" + +namespace types +{ +TEST_CLASS(test_page_row_col){ public: +#include "types/unittests/test_page_row_col.cpp" +}; + +TEST_CLASS(test_range){ public: +#include "types/unittests/test_range.cpp" +}; + +TEST_CLASS(test_range_list){ public: +#include "types/unittests/test_range_list.cpp" +}; + +} \ No newline at end of file diff --git a/externals/coda-oss/UnitTest/units.cpp b/externals/coda-oss/UnitTest/units.cpp new file mode 100644 index 000000000..f0ce0ff73 --- /dev/null +++ b/externals/coda-oss/UnitTest/units.cpp @@ -0,0 +1,12 @@ +#include "pch.h" +#include "CppUnitTest.h" + +#include +#include + +namespace units +{ + TEST_CLASS(test_units){ public: + #include "units/unittests/test_units.cpp" + }; +} diff --git a/externals/coda-oss/coda-oss-lite.sln b/externals/coda-oss/coda-oss-lite.sln new file mode 100644 index 000000000..2681342c5 --- /dev/null +++ b/externals/coda-oss/coda-oss-lite.sln @@ -0,0 +1,39 @@ + +Microsoft Visual Studio Solution File, Format Version 12.00 +# Visual Studio Version 17 +VisualStudioVersion = 17.1.32421.90 +MinimumVisualStudioVersion = 10.0.40219.1 +Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "coda-oss-lite", "modules\c++\coda-oss-lite.vcxproj", "{9997E895-5161-4DDF-8F3F-099894CB2F21}" +EndProject +Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{DEB848DD-4285-4BFA-9B2F-60FA46200205}" + ProjectSection(SolutionItems) = preProject + .gitattributes = .gitattributes + .gitignore = .gitignore + README.md = README.md + ReleaseNotes.md = ReleaseNotes.md + EndProjectSection +EndProject +Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "UnitTest", "UnitTest\UnitTest.vcxproj", "{34A31B3F-47C5-441D-AB22-3C85B3C5314E}" +EndProject +Global + GlobalSection(SolutionConfigurationPlatforms) = preSolution + Debug|x64 = Debug|x64 + Release|x64 = Release|x64 + EndGlobalSection + GlobalSection(ProjectConfigurationPlatforms) = postSolution + {9997E895-5161-4DDF-8F3F-099894CB2F21}.Debug|x64.ActiveCfg = Debug|x64 + {9997E895-5161-4DDF-8F3F-099894CB2F21}.Debug|x64.Build.0 = Debug|x64 + {9997E895-5161-4DDF-8F3F-099894CB2F21}.Release|x64.ActiveCfg = Release|x64 + {9997E895-5161-4DDF-8F3F-099894CB2F21}.Release|x64.Build.0 = Release|x64 + {34A31B3F-47C5-441D-AB22-3C85B3C5314E}.Debug|x64.ActiveCfg = Debug|x64 + {34A31B3F-47C5-441D-AB22-3C85B3C5314E}.Debug|x64.Build.0 = Debug|x64 + {34A31B3F-47C5-441D-AB22-3C85B3C5314E}.Release|x64.ActiveCfg = Release|x64 + {34A31B3F-47C5-441D-AB22-3C85B3C5314E}.Release|x64.Build.0 = Release|x64 + EndGlobalSection + GlobalSection(SolutionProperties) = preSolution + HideSolutionNode = FALSE + EndGlobalSection + GlobalSection(ExtensibilityGlobals) = postSolution + SolutionGuid = {3CAB4AC9-7865-44AD-8623-57905729A559} + EndGlobalSection +EndGlobal diff --git a/externals/coda-oss/modules/c++/avx/include/avx/extractf.h b/externals/coda-oss/modules/c++/avx/include/avx/extractf.h index 5c037fa0f..d6575faf5 100644 --- a/externals/coda-oss/modules/c++/avx/include/avx/extractf.h +++ b/externals/coda-oss/modules/c++/avx/include/avx/extractf.h @@ -24,18 +24,7 @@ #define CODA_OSS_avx_extractf_h_INCLUDED_ #pragma once -#include - -#ifndef _MM256_EXTRACTF - #ifdef HAVE_M256_DIRECT_INDEX - #define _MM256_EXTRACTF(ymm_,i_) ymm_[i_] - #elif defined HAVE_M256_MEMBER_INDEX - #define _MM256_EXTRACTF(ymm_,i_) ymm_.m256_f32[i_] - #else - //This looks awful, but almost all of these intrinsics simply reinterpret bits and generate no actual instructions. - #define _MM256_EXTRACTF(ymm_,i_) _mm256_cvtss_f32(_mm256_castsi256_ps(_mm256_set1_epi32(_mm256_extract_epi32(_mm256_castps_si256(ymm_),i_)))) - #endif -#endif // _MM256_EXTRACTF +#include #ifndef CODA_OSS_mm256_extractf_DEFINED_ #define CODA_OSS_mm256_extractf_DEFINED_ 1 diff --git a/externals/coda-oss/modules/c++/avx/unittests/test_m256.cpp b/externals/coda-oss/modules/c++/avx/unittests/test_m256.cpp index 03587aab5..40e114836 100644 --- a/externals/coda-oss/modules/c++/avx/unittests/test_m256.cpp +++ b/externals/coda-oss/modules/c++/avx/unittests/test_m256.cpp @@ -27,8 +27,6 @@ #include #include -namespace -{ TEST_CASE(extractf) { /* @@ -52,11 +50,7 @@ TEST_CASE(extractf) TEST_ASSERT_TRUE(true); } -} -int main(int /*argc*/, char** /*argv*/) -{ +TEST_MAIN( TEST_CHECK(extractf); - - return 0; -} +) diff --git a/externals/coda-oss/modules/c++/cli/include/cli/Argument.h b/externals/coda-oss/modules/c++/cli/include/cli/Argument.h index 44cab8363..e7a90f83b 100644 --- a/externals/coda-oss/modules/c++/cli/include/cli/Argument.h +++ b/externals/coda-oss/modules/c++/cli/include/cli/Argument.h @@ -24,6 +24,8 @@ #define __CLI_ARGUMENT_H__ #include +#include "config/Exports.h" + #include "cli/Value.h" namespace cli @@ -42,7 +44,7 @@ class ArgumentParser; * * TODO: add support for case insensitive or standardizing choices/parsing */ -class Argument +class CODA_OSS_API Argument { public: diff --git a/externals/coda-oss/modules/c++/cli/include/cli/ArgumentParser.h b/externals/coda-oss/modules/c++/cli/include/cli/ArgumentParser.h index 4c25f930f..cabc41ff7 100644 --- a/externals/coda-oss/modules/c++/cli/include/cli/ArgumentParser.h +++ b/externals/coda-oss/modules/c++/cli/include/cli/ArgumentParser.h @@ -30,6 +30,7 @@ #include #include #include +#include "config/Exports.h" namespace cli { @@ -39,7 +40,7 @@ enum EXIT_USAGE = 1, EXIT_VERSION = 2 }; -class ArgumentParser +class CODA_OSS_API ArgumentParser { public: explicit ArgumentParser(bool ignoreUnknown = false, diff --git a/externals/coda-oss/modules/c++/cli/include/cli/Value.h b/externals/coda-oss/modules/c++/cli/include/cli/Value.h index 82746ec05..f47e8e0a1 100644 --- a/externals/coda-oss/modules/c++/cli/include/cli/Value.h +++ b/externals/coda-oss/modules/c++/cli/include/cli/Value.h @@ -27,6 +27,8 @@ #include #include +#include "config/Exports.h" + namespace cli { @@ -34,7 +36,7 @@ namespace cli * The Value class provides access to one or more actual values. * It provides index-based access to parameters. */ -class Value +class CODA_OSS_API Value { public: Value() diff --git a/externals/coda-oss/modules/c++/cli/unittests/test_cli.cpp b/externals/coda-oss/modules/c++/cli/unittests/test_cli.cpp index 6a0403426..ce0dcfbb0 100644 --- a/externals/coda-oss/modules/c++/cli/unittests/test_cli.cpp +++ b/externals/coda-oss/modules/c++/cli/unittests/test_cli.cpp @@ -247,8 +247,7 @@ TEST_CASE(testUnknownArgumentsOptions) TEST_ASSERT_EQ(results->get("config"), "config.txt"); } -int main(int, char**) -{ +TEST_MAIN( TEST_CHECK( testValue); TEST_CHECK( testChoices); TEST_CHECK( testMultiple); @@ -256,4 +255,5 @@ int main(int, char**) TEST_CHECK( testIterate); TEST_CHECK( testRequired); TEST_CHECK( testUnknownArgumentsOptions); -} +) + diff --git a/externals/coda-oss/modules/c++/coda-oss-lite.vcxproj b/externals/coda-oss/modules/c++/coda-oss-lite.vcxproj index af7e4000c..a77411eb3 100644 --- a/externals/coda-oss/modules/c++/coda-oss-lite.vcxproj +++ b/externals/coda-oss/modules/c++/coda-oss-lite.vcxproj @@ -11,6 +11,7 @@ + @@ -75,6 +76,24 @@ + + + + + + + + + + + + + + + + + + @@ -108,10 +127,52 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -187,6 +248,20 @@ + + + + + + + + + + + + + + @@ -222,100 +297,32 @@ + + + + + + + + + + + + + + - - true - true - - - true - true - - - true - true - - - true - true - - - true - true - - - true - true - - - true - true - - - true - true - - - true - true - - - true - true - - - true - true - - - true - true - - - true - true - - - true - true - - - true - true - - - true - true - - - true - true - - - true - true - - - true - true - - - true - true - - - true - true - - - true - true - + + + + + + @@ -324,7 +331,14 @@ Create Create + + + + + + + @@ -332,14 +346,6 @@ - - true - true - - - true - true - @@ -387,12 +393,19 @@ + + + + + + + + + + + - - true - true - @@ -457,16 +470,17 @@ EnableAllWarnings true - _DEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL + _DEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL;MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 true pch.h - cli\include\;coda_oss\include;config\include\;except\include\;gsl\include\;io\include\;math\include\;math.linear\include\;math.poly\include\;mem\include\;polygon\include\;std\include\;str\include\;sys\include\;types\include\;units\include\ + cli\include\;coda_oss\include;config\include\;except\include\;gsl\include\;io\include\;logging\include\;math\include\;math.linear\include\;math.poly\include\;mem\include\;mt\include\;plugin\include\;polygon\include\;re\include\;sio.lite\include\;std\include\;str\include\;sys\include\;tiff\include;types\include\;units\include\ Use pch.h true Guard true ProgramDatabase + true @@ -480,15 +494,16 @@ true true true - NDEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL + NDEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL;MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 true pch.h - cli\include\;coda_oss\include;config\include\;except\include\;gsl\include\;io\include\;math\include\;math.linear\include\;math.poly\include\;mem\include\;polygon\include\;std\include\;str\include\;sys\include\;types\include\;units\include\ + cli\include\;coda_oss\include;config\include\;except\include\;gsl\include\;io\include\;logging\include\;math\include\;math.linear\include\;math.poly\include\;mem\include\;mt\include\;plugin\include\;polygon\include\;re\include\;sio.lite\include\;std\include\;str\include\;sys\include\;tiff\include;types\include\;units\include\ Use pch.h true Guard true + true diff --git a/externals/coda-oss/modules/c++/coda-oss-lite.vcxproj.filters b/externals/coda-oss/modules/c++/coda-oss-lite.vcxproj.filters index 1125cbccc..1a824ec31 100644 --- a/externals/coda-oss/modules/c++/coda-oss-lite.vcxproj.filters +++ b/externals/coda-oss/modules/c++/coda-oss-lite.vcxproj.filters @@ -540,6 +540,231 @@ io + + mt + + + mt + + + mt + + + mt + + + mt + + + mt + + + mt + + + mt + + + mt + + + mt + + + mt + + + mt + + + mt + + + mt + + + mt + + + mt + + + mt + + + mt + + + mt + + + mt + + + mt + + + mt + + + mt + + + mt + + + mt + + + avx + + + logging + + + logging + + + logging + + + logging + + + logging + + + logging + + + logging + + + logging + + + logging + + + logging + + + logging + + + logging + + + logging + + + logging + + + logging + + + logging + + + logging + + + logging + + + re + + + re + + + re + + + sio.lite + + + sio.lite + + + sio.lite + + + sio.lite + + + sio.lite + + + sio.lite + + + sio.lite + + + sio.lite + + + sio.lite + + + tiff + + + tiff + + + tiff + + + tiff + + + tiff + + + tiff + + + tiff + + + tiff + + + tiff + + + tiff + + + tiff + + + tiff + + + tiff + + + tiff + + + sio.lite + + + sio.lite + + + plugin + + + plugin + + + plugin + @@ -744,81 +969,6 @@ polygon - - math\unittests - - - math\unittests - - - math\unittests - - - math\unittests - - - math\unittests - - - math\unittests - - - math.linear\unittests - - - math.linear\unittests - - - math.linear\unittests - - - math.linear\unittests - - - math.linear\unittests - - - math.linear\unittests - - - math.linear\unittests - - - math.linear\unittests - - - math.linear\unittests - - - str\unittests - - - str\unittests - - - units\unittests - - - mem\unittests - - - mem\unittests - - - mem\unittests - - - mem\unittests - - - mem\unittests - - - mem\unittests - - - mem\unittests - cli @@ -873,6 +1023,120 @@ io + + mt + + + mt + + + mt + + + mt + + + mt + + + mt + + + logging + + + logging + + + logging + + + logging + + + logging + + + logging + + + logging + + + logging + + + logging + + + logging + + + logging + + + logging + + + logging + + + logging + + + re + + + re + + + sio.lite + + + sio.lite + + + sio.lite + + + sio.lite + + + tiff + + + tiff + + + tiff + + + tiff + + + tiff + + + tiff + + + tiff + + + tiff + + + tiff + + + tiff + + + tiff + + + plugin + @@ -917,21 +1181,6 @@ {f2544ccb-0933-44c7-af39-cd986982af3d} - - {82d38fbe-b150-411a-8843-b584142c07ad} - - - {d17adbee-6720-4a93-b45f-2a05eb6a4620} - - - {4cee5537-9ac0-4bb8-9b9f-78aae69d0084} - - - {55522351-e752-4be8-9139-f7ac4b91a66d} - - - {6a70a638-d58c-4e34-87c1-6d1115690de8} - {9050a469-23a5-4da0-92b1-a07a8e52e9fc} @@ -941,6 +1190,27 @@ {cc681a99-da96-483e-a92a-eab0ea3a0ec0} + + {4875d8c0-f285-460a-98a9-38a60f3fcffd} + + + {9720bf2c-6d77-4685-9318-d6e714065c99} + + + {9f9acff4-c149-4908-ae9d-67557974f4ee} + + + {83ae731c-66f7-468c-bc71-7cb57a363b5b} + + + {327a7b72-9a2d-48e4-9c23-2b5b9d2f3519} + + + {d76b6d3f-51f8-4cf8-bc56-35f720080a8b} + + + {387bc6cb-323a-42b3-8502-4fac72586d12} + diff --git a/externals/coda-oss/modules/c++/except/include/except/Context.h b/externals/coda-oss/modules/c++/except/include/except/Context.h index c2e683016..cef7af176 100644 --- a/externals/coda-oss/modules/c++/except/include/except/Context.h +++ b/externals/coda-oss/modules/c++/except/include/except/Context.h @@ -135,7 +135,7 @@ struct CODA_OSS_API Context final int mLine; }; -std::ostream& operator<< (std::ostream& os, const Context& c); +CODA_OSS_API std::ostream& operator<<(std::ostream& os, const Context& c); } #endif // CODA_OSS_except_Context_h_INCLUDED_ diff --git a/externals/coda-oss/modules/c++/include/TestCase.h b/externals/coda-oss/modules/c++/include/TestCase.h index 4d7461e0e..143676e06 100644 --- a/externals/coda-oss/modules/c++/include/TestCase.h +++ b/externals/coda-oss/modules/c++/include/TestCase.h @@ -41,127 +41,61 @@ inline void diePrintf(const char* format, const std::string& testName, const cha { sys::diePrintf(format, testName.c_str(), s); } -template -inline void diePrintf(const char* format, const std::string& testName, const TX& X) -{ - diePrintf(format, testName, str::toString(X).c_str()); -} - inline void diePrintf(const char* format, const std::string& testName, const char* file, const char* func, int line) { sys::diePrintf(format, testName.c_str(), file, func, line); } - -template inline void diePrintf(const char* format, const std::string& testName, const char* file, const char* func, int line, - const TX& X) + const std::string& X) { - sys::diePrintf(format, testName.c_str(), file, func, line, - str::toString(X).c_str()); + sys::diePrintf(format, testName.c_str(), file, func, line, X.c_str()); } -template inline void diePrintf(const char* format, const std::string& testName, const char* file, const char* func, int line, - const TX1& X1, const TX2& X2) + const std::string& X1, const std::string& X2) { - sys::diePrintf(format, testName.c_str(), file, func, line, - str::toString(X1).c_str(), str::toString(X2).c_str()); + sys::diePrintf(format, testName.c_str(), file, func, line, X1.c_str(), X2.c_str()); } - -template -inline void diePrintf_eq(const std::string& testName, const char* file, const char* func, int line, - const TX1& X1, const TX2& X2) +inline void diePrintf(const char* format, const std::string& testName, const char* file, int line, const std::string& msg, + const std::string& X1, const std::string& X2) { - diePrintf("%s (%s,%s,%d): FAILED: Recv'd %s, Expected %s\n", testName, file, func, line, X1, X2); + sys::diePrintf(format, testName.c_str(), file, line, msg.c_str(), X1.c_str(), X2.c_str()); } -#define CODA_OSS_test_diePrintf_eq_(X1, X2) test::diePrintf_eq(testName, __FILE__, SYS_FUNC, __LINE__, X1, X2) -template -inline void diePrintf_eq_msg(const std::string& testName, const TMsg& msg, const char* file, int line, - const TX1& X1, const TX2& X2) +// older C++ compilers don't like __VA_ARGS__ :-( +#define test_diePrintf0(format) test::diePrintf(format, testName, __FILE__, SYS_FUNC, __LINE__) + +template +inline void diePrintf_(const char* format, const std::string& testName, const char* file, const char* func, int line, + const TX& X) { - sys::diePrintf("%s (%s,%d): FAILED (%s): Recv'd %s, Expected %s\n", testName.c_str(), file, line, (msg).c_str(), - str::toString((X1)).c_str(), str::toString((X2)).c_str()); + diePrintf(format, testName, file, func, line, str::toString(X)); } -#define CODA_OSS_test_diePrintf_eq_msg_(msg, X1, X2) test::diePrintf_eq_msg(testName, msg, __FILE__, __LINE__, X1, X2) +#define test_diePrintf1(format, X1) test::diePrintf_(format, testName, __FILE__, SYS_FUNC, __LINE__, (X1)) // might not want str::toString() template -inline void diePrintf_ne(const std::string& testName, const char* file, const char* func, int line, +inline void diePrintf_(const char* format, const std::string& testName, const char* file, const char* func, int line, const TX1& X1, const TX2& X2) { - diePrintf("%s (%s,%s,%d): FAILED: Recv'd %s should not equal %s\n", testName, file, func, line, X1, X2); + diePrintf(format, testName, file, func, line, str::toString(X1), str::toString(X2)); } -#define CODA_OSS_test_diePrintf_not_eq_(X1, X2) test::diePrintf_ne(testName, __FILE__, SYS_FUNC, __LINE__, X1, X2) +#define test_diePrintf2(format, X1, X2) test::diePrintf_(format, testName, __FILE__, SYS_FUNC, __LINE__, (X1), (X2)) // might not want str::toString() -template -inline void diePrintf_ne_msg(const std::string& testName, const TMsg& msg, const char* file, int line, +template +inline void diePrintf_(const char* format, const std::string& testName, const char* file, int line, const std::string& msg, const TX1& X1, const TX2& X2) { - sys::diePrintf("%s (%s,%d): FAILED (%s): Recv'd %s should not equal %s\n", testName.c_str(), file, line, (msg).c_str(), - str::toString((X1)).c_str(), str::toString((X2)).c_str()); -} -#define CODA_OSS_test_diePrintf_not_eq_msg_(msg, X1, X2) test::diePrintf_ne_msg(testName, msg, __FILE__, __LINE__, X1, X2) - -template -inline void check(TFunc f, const std::string& testName) -{ - try - { - f(testName); - std::cerr << testName << ": PASSED" << std::endl; - } - catch (const except::Throwable& ex) - { - diePrintf("%s: FAILED: Exception thrown: %s\n", testName, ex.toString()); - } - catch (const except::Throwable11& ex) - { - diePrintf("%s: FAILED: Exception thrown: %s\n", testName, ex.what()); - } -} - -template -inline void assert_(const TX& X, const std::string& testName, const char* file, const char* func, int line) -{ - if (!X) - { - diePrintf("%s (%s,%s,%d): FAILED: Value should not be NULL\n", testName, file, func, line); - } -} - -template -inline void assert_null(const TX& X, const std::string& testName, const char* file, const char* func, int line) -{ - if ((X != nullptr) || (!(X == nullptr))) - { - diePrintf("%s (%s,%s,%d): FAILED: Value should be NULL\n", testName, file, func, line); - } -} -template -inline void assert_not_null(const TX& X, const std::string& testName, const char* file, const char* func, int line) -{ - if ((X == nullptr) || (!(X != nullptr))) - { - diePrintf("%s (%s,%s,%d): FAILED: Value should *not* be NULL\n", testName, file, func, line); - } + diePrintf(format, testName, file, line, msg, str::toString(X1), str::toString(X2)); } +#define test_diePrintf2_msg(format, msg, X1, X2) test::diePrintf_(format, testName, __FILE__, __LINE__, msg, (X1), (X2)) // might not want str::toString() -template -inline void test_assert_false(const TX& X, const std::string& testName, const char* file, const char* func, int line) -{ - if (X) - { - diePrintf("%s (%s,%s,%d): FAILED: Value should evaluate to false\n", testName, file, func, line); - } -} - -template -inline void test_assert_true(const TX& X, const std::string& testName, const char* file, const char* func, int line) -{ - if (!X) - { - diePrintf("%s (%s,%s,%d): FAILED: Value should evaluate to true\n", testName, file, func, line); - } -} +#define CODA_OSS_test_diePrintf_eq_(X1, X2) test_diePrintf2("%s (%s,%s,%d): FAILED: Recv'd %s, Expected %s\n", (X1), (X2)) +#define CODA_OSS_test_diePrintf_eq_msg_(msg, X1, X2) test_diePrintf2_msg("%s (%s,%d): FAILED (%s): Recv'd %s, Expected %s\n", msg, (X1), (X2)) +#define CODA_OSS_test_diePrintf_not_eq_(X1, X2) test_diePrintf2("%s (%s,%s,%d): FAILED: Recv'd %s should not equal %s\n", X1, X2) +#define CODA_OSS_test_diePrintf_not_eq_msg_(msg, X1, X2) test_diePrintf2_msg("%s (%s,%d): FAILED (%s): Recv'd %s should not equal %s\n", msg, (X1), (X2)) +#define CODA_OSS_test_diePrintf_greater_eq_(X1, X2) test_diePrintf0("%s (%s,%s,%d): FAILED: Value should be greater than or equal\n") +#define CODA_OSS_test_diePrintf_greater_(X1, X2) test_diePrintf0("%s (%s,%s,%d): FAILED: Value should be greater than\n") +#define CODA_OSS_test_diePrintf_lesser_eq_(X1, X2) test_diePrintf0("%s (%s,%s,%d): FAILED: Value should be less than or equal\n") +#define CODA_OSS_test_diePrintf_lesser_(X1, X2) test_diePrintf0("%s (%s,%s,%d): FAILED: Value should be less than\n") // You might be tempted to write something like // template @@ -178,48 +112,9 @@ inline void assert_almost_eq_eps(const TX1& X1, const TX2& X2, const TEPS& EPS, const auto abs_difference = std::abs(X1 - X2); if (abs_difference > EPS || IS_NAN(abs_difference)) { - diePrintf("%s (%s,%s,%d): FAILED: Recv'd %s, Expected %s\n", testName, file, func, line, X1, X2); + diePrintf_("%s (%s,%s,%d): FAILED: Recv'd %s, Expected %s\n", testName, file, func, line, X1, X2); } } -template -inline void assert_almost_eq(const TX1& X1, const TX2& X2, - const std::string& testName, const char* file, const char* func, int line) -{ - const auto eps = std::numeric_limits::epsilon(); - assert_almost_eq_eps(X1, X2, eps, testName, file, func, line); -} - -template -inline void fail(const Tmsg& msg, - const std::string& testName, const char* file, const char* func, int line) -{ - diePrintf("%s (%s,%s,%d): FAILED: %s\n", testName, file, func, line, msg); -} - -template -inline void exception(TFunc f, - const std::string& testName, const char* file, const char* func, int line) -{ - try - { - f(); - diePrintf("%s (%s,%s,%d): FAILED: Should have thrown exception\n", testName, file, func, line); - } - catch (const except::Throwable&) { } - catch (const except::Throwable11&) { } -} - -template -inline void throws(TFunc f, - const std::string& testName, const char* file, const char* func, int line) -{ - try - { - f(); - diePrintf("%s (%s,%s,%d): FAILED: Should have thrown exception\n", testName, file, func, line); - } - catch (...) { } -} template inline void specific_exception(TFunc f, @@ -264,55 +159,52 @@ inline int main(TFunc f) return EXIT_FAILURE; } } -#define TEST_CHECK(X) test::check([&](const std::string& testName) { X(testName); }, #X) -#define TEST_ASSERT(X) test::assert_(X, testName, __FILE__, SYS_FUNC, __LINE__) -#define TEST_ASSERT_NULL(X) test::assert_null(X, testName, __FILE__, SYS_FUNC, __LINE__) -#define TEST_ASSERT_NOT_NULL(X) test::assert_not_null(X, testName, __FILE__, SYS_FUNC, __LINE__) -#define TEST_ASSERT_FALSE(X) test::test_assert_false(X, testName, __FILE__, SYS_FUNC, __LINE__) -#define TEST_ASSERT_TRUE(X) test::test_assert_true(X, testName, __FILE__, SYS_FUNC, __LINE__) + +#define TEST_CHECK(X) try{ X(std::string(#X)); std::cerr << #X << ": PASSED\n"; } \ + catch(const except::Throwable& ex) { test::diePrintf("%s: FAILED: Exception thrown: %s\n", #X, ex.toString().c_str()); } \ + catch(const except::Throwable11& ex) { test::diePrintf("%s: FAILED: Exception thrown: %s\n", #X, ex.what()); } +#define TEST_ASSERT_NULL(X) if ((X) != nullptr) { test_diePrintf0("%s (%s,%s,%d): FAILED: Value should be NULL\n"); } +#define TEST_ASSERT_NOT_NULL(X) if ((X) == nullptr) { test_diePrintf0("%s (%s,%s,%d): FAILED: Value should *not* be NULL\n"); } +#define TEST_ASSERT_FALSE(X) if ((X)) { test_diePrintf0("%s (%s,%s,%d): FAILED: Value should evaluate to false\n"); } +#define TEST_ASSERT_TRUE(X) if (!(X)) { test_diePrintf0("%s (%s,%s,%d): FAILED: Value should evaluate to true\n"); } +#define TEST_ASSERT(X) TEST_ASSERT_TRUE(X) #define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) test::assert_almost_eq_eps(X1, X2, EPS, testName, __FILE__, SYS_FUNC, __LINE__) -#define TEST_ASSERT_ALMOST_EQ(X1, X2) test::assert_almost_eq(X1, X2, testName, __FILE__, SYS_FUNC, __LINE__) -#define TEST_FAIL(msg) test::fail(msg, testName, __FILE__, SYS_FUNC, __LINE__) -#define TEST_EXCEPTION(X) test::exception([&](){(X);}, testName, __FILE__, SYS_FUNC, __LINE__) -#define TEST_THROWS(X) test::throws([&](){(X);}, testName, __FILE__, SYS_FUNC, __LINE__) +#define TEST_ASSERT_ALMOST_EQ(X1, X2) TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, std::numeric_limits::epsilon()) +#define TEST_FAIL(msg) test_diePrintf1("%s (%s,%s,%d): FAILED: %s\n", str::toString(msg).c_str()) +#define TEST_EXCEPTION(X) try{ (X); test_diePrintf0("%s (%s,%s,%d): FAILED: Should have thrown exception\n"); } \ + catch (const except::Throwable&){} catch (const except::Throwable11&){} +#define TEST_THROWS(X) try{ (X); test_diePrintf0("%s (%s,%s,%d): FAILED: Should have thrown exception\n"); } catch (...){} # define TEST_SPECIFIC_EXCEPTION(X, Y) test::specific_exception([&](){(X);}, \ "%s (%s,%s,%d): FAILED: Should have thrown exception: " # Y , testName, __FILE__, SYS_FUNC, __LINE__) # define TEST_CASE(X) void X(std::string testName) #define TEST_MAIN(X) int main() { return test::main([&](){X;}); } #define TEST_MAIN_ARGS(X) int main(int argc, char* argv[]) { return test::main([&](){X;}); } + +#define CODA_OSS_test_eq_(X1, X2) (((X1) == (X2)) && ((X2) == (X1))) // X1 == X2 means X2 == X1 +#define CODA_OSS_test_ne_(X1, X2) (((X1) != (X2)) && ((X2) != (X1))) // X1 != X2 means X2 != X1 +#define CODA_OSS_test_ne(X1, X2) (CODA_OSS_test_ne_(X1, X2) && !CODA_OSS_test_eq_(X1, X2)) +#define CODA_OSS_test_eq(X1, X2) (CODA_OSS_test_eq_(X1, X2) && !CODA_OSS_test_ne_(X1, X2)) +#define TEST_ASSERT_EQ(X1, X2) if (!CODA_OSS_test_eq((X1), (X2))) { CODA_OSS_test_diePrintf_eq_(X1, X2); } +#define TEST_ASSERT_EQ_MSG(msg, X1, X2) if (!CODA_OSS_test_eq((X1), (X2))) { CODA_OSS_test_diePrintf_eq_msg_(msg, X1, X2); } +#define TEST_ASSERT_NOT_EQ(X1, X2) if (!CODA_OSS_test_ne((X1), (X2))) { CODA_OSS_test_diePrintf_not_eq_(X1, X2); } +#define TEST_ASSERT_NOT_EQ_MSG(msg, X1, X2) if (!CODA_OSS_test_ne((X1), (X2))) { CODA_OSS_test_diePrintf_not_eq_msg_(msg, X1, X2); } + +#define CODA_OSS_test_ge_(X1, X2) (((X1) >= (X2)) && ((X2) <= (X1))) // X1 >= X2 means X2 <= X1 +#define CODA_OSS_test_gt_(X1, X2) (((X1) > (X2)) && ((X2) <= (X1))) // X1 > X2 means X2 <= X1 +#define CODA_OSS_test_le_(X1, X2) (((X1) <= (X2)) && ((X2) >= (X1))) // X1 <= X2 means X2 >= X1 +#define CODA_OSS_test_lt_(X1, X2) (((X1) < (X2)) && ((X2) >= (X1))) // X1 < X2 means X2 >= X1 +#define CODA_OSS_test_ge(X1, X2) (CODA_OSS_test_ge_(X1, X2) && !CODA_OSS_test_lt_(X1, X2)) +#define CODA_OSS_test_gt(X1, X2) (CODA_OSS_test_gt_(X1, X2) && !CODA_OSS_test_le_(X1, X2)) +# define TEST_ASSERT_GREATER_EQ(X1, X2) if (!CODA_OSS_test_ge((X1), (X2))) { CODA_OSS_test_diePrintf_greater_eq_(X1, X2); } +# define TEST_ASSERT_GREATER(X1, X2) if (!CODA_OSS_test_gt((X1), (X2))) { CODA_OSS_test_diePrintf_greater_(X1, X2); } +#define CODA_OSS_test_le(X1, X2) (CODA_OSS_test_le_(X1, X2) && !CODA_OSS_test_gt_(X1, X2)) +#define CODA_OSS_test_lt(X1, X2) (CODA_OSS_test_lt_(X1, X2) && !CODA_OSS_test_ge_(X1, X2)) +# define TEST_ASSERT_LESSER_EQ(X1, X2) if (!CODA_OSS_test_le((X1), (X2))) { CODA_OSS_test_diePrintf_lesser_eq_(X1, X2); } +# define TEST_ASSERT_LESSER(X1, X2) if (!CODA_OSS_test_lt((X1), (X2))) { CODA_OSS_test_diePrintf_lesser_(X1, X2); } /* -# define TEST_CHECK(X) try{ X(std::string(#X)); std::cerr << #X << ": PASSED" << std::endl; } \ - catch(const except::Throwable& ex) { die_printf("%s: FAILED: Exception thrown: %s\n", std::string(#X).c_str(), ex.toString().c_str()); } \ - catch(const except::Throwable11& ex) { die_printf("%s: FAILED: Exception thrown: %s\n", std::string(#X).c_str(), ex.what()); } -# define TEST_ASSERT(X) if (!(X)) { die_printf("%s (%s,%s,%d): FAILED: Value should not be NULL\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } -# define TEST_ASSERT_NULL(X) if ((X) != nullptr) { die_printf("%s (%s,%s,%d): FAILED: Value should be NULL\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } -# define TEST_ASSERT_FALSE(X) if ((X)) { die_printf("%s (%s,%s,%d): FAILED: Value should evaluate to false\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } -# define TEST_ASSERT_TRUE(X) if (!(X)) { die_printf("%s (%s,%s,%d): FAILED: Value should evaluate to true\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } -*/ -//#define CODA_OSS_test_eq_(X1, X2) (((X1) == (X2)) && ((X2) == (X1))) // X1 == X2 means X2 == X1 -#define CODA_OSS_test_eq_(X1, X2) ((X1) == (X2)) // above breaks CODA :-( -//#define CODA_OSS_test_ne_(X1, X2) (((X1) != (X2)) && ((X2) != (X1))) // X1 != X2 means X2 != X1 -#define CODA_OSS_test_ne_(X1, X2) ((X1) != (X2)) // above breaks CODA :-( -//#define CODA_OSS_test_ne(X1, X2) (CODA_OSS_test_ne_(X1, X2) && !CODA_OSS_test_eq_(X1, X2)) -#define CODA_OSS_test_ne(X1, X2) CODA_OSS_test_ne_(X1, X2) // above breaks CODA :-( -#define TEST_ASSERT_EQ(X1, X2) if (CODA_OSS_test_ne((X1), (X2))) { CODA_OSS_test_diePrintf_eq_(X1, X2); } -#define TEST_ASSERT_EQ_MSG(msg, X1, X2) if (CODA_OSS_test_ne((X1), (X2))) { CODA_OSS_test_diePrintf_eq_msg_(msg, X1, X2); } -//#define CODA_OSS_test_eq(X1, X2) (CODA_OSS_test_eq_(X1, X2) && !CODA_OSS_test_ne_(X1, X2)) -#define CODA_OSS_test_eq(X1, X2) CODA_OSS_test_eq_(X1, X2) // above breaks CODA :-( -#define TEST_ASSERT_NOT_EQ(X1, X2) if (CODA_OSS_test_eq((X1), (X2))) { CODA_OSS_test_diePrintf_not_eq_(X1, X2); } -#define TEST_ASSERT_NOT_EQ_MSG(msg, X1, X2) if (CODA_OSS_test_eq((X1), (X2))) { CODA_OSS_test_diePrintf_not_eq_msg_(msg, X1, X2); } -# define TEST_ASSERT_GREATER_EQ(X1, X2) if ((X1) < X2) { test::diePrintf("%s (%s,%s,%d): FAILED: Value should be greater than or equal\n", testName, __FILE__, SYS_FUNC, __LINE__); } -# define TEST_ASSERT_GREATER(X1, X2) if ((X1) <= X2) { test::diePrintf("%s (%s,%s,%d): FAILED: Value should be greater than\n", testName, __FILE__, SYS_FUNC, __LINE__); } -# define TEST_ASSERT_LESSER_EQ(X1, X2) if ((X1) > X2) { test::diePrintf("%s (%s,%s,%d): FAILED: Value should be less than or equal\n", testName, __FILE__, SYS_FUNC, __LINE__); } -# define TEST_ASSERT_LESSER(X1, X2) if ((X1) >= X2) { test::diePrintf("%s (%s,%s,%d): FAILED: Value should be less than\n", testName, __FILE__, SYS_FUNC, __LINE__); } -/* -# define TEST_FAIL(msg) die_printf("%s (%s,%s,%d): FAILED: %s\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__, str::toString(msg).c_str()); -# define TEST_EXCEPTION(X) try{ (X); die_printf("%s (%s,%s,%d): FAILED: Should have thrown exception\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } catch (const except::Throwable&){} catch (const except::Throwable11&){} -# define TEST_THROWS(X) try{ (X); die_printf("%s (%s,%s,%d): FAILED: Should have thrown exception\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } catch (...){} # define TEST_SPECIFIC_EXCEPTION(X,Y) try{ (X); die_printf("%s (%s,%s,%d): FAILED: Should have thrown exception: " # Y , testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } catch(const Y&) { } \ catch (const except::Throwable&){ die_printf("%s (%s,%s,%d): FAILED: Should have thrown exception: " # Y , testName.c_str(), __FILE__, SYS_FUNC, __LINE__);} \ catch (const except::Throwable11&){ die_printf("%s (%s,%s,%d): FAILED: Should have thrown exception: " # Y , testName.c_str(), __FILE__, SYS_FUNC, __LINE__);} # define TEST_CASE(X) void X(std::string testName) -# define TEST_CASE(X) void X(std::string testName) #define TEST_MAIN(X) int main(int argc, char** argv) { try { X; return EXIT_SUCCESS; } \ catch (const except::Exception& ex) { std::cerr << ex.toString() << std::endl; } \ catch (const std::exception& e) { std::cerr << e.what() << std::endl; } \ diff --git a/externals/coda-oss/modules/c++/io/include/io/ByteStream.h b/externals/coda-oss/modules/c++/io/include/io/ByteStream.h index 751dc3162..fe2efe184 100644 --- a/externals/coda-oss/modules/c++/io/include/io/ByteStream.h +++ b/externals/coda-oss/modules/c++/io/include/io/ByteStream.h @@ -24,6 +24,8 @@ #define __IO_BYTE_STREAM_H__ #include + +#include "config/Exports.h" #include "sys/Conf.h" #include "except/Error.h" #include "except/Exception.h" @@ -56,7 +58,7 @@ namespace io * 0's can be anywhere (Null-bytes) making it impossible to use * strings as containers. */ -struct ByteStream : public SeekableInputStream, public SeekableOutputStream +struct CODA_OSS_API ByteStream : public SeekableInputStream, public SeekableOutputStream { ByteStream() = default; virtual ~ByteStream() = default; diff --git a/externals/coda-oss/modules/c++/io/include/io/CountingStreams.h b/externals/coda-oss/modules/c++/io/include/io/CountingStreams.h index b9ec0628c..bebca3a5f 100644 --- a/externals/coda-oss/modules/c++/io/include/io/CountingStreams.h +++ b/externals/coda-oss/modules/c++/io/include/io/CountingStreams.h @@ -23,6 +23,7 @@ #ifndef __IO_COUNTING_STREAMS_H__ #define __IO_COUNTING_STREAMS_H__ +#include "config/Exports.h" #include "io/ProxyStreams.h" namespace io @@ -31,7 +32,7 @@ namespace io /** * An OutputStream that keeps track of the number of bytes written to the stream. */ -struct CountingOutputStream: public ProxyOutputStream +struct CODA_OSS_API CountingOutputStream : public ProxyOutputStream { CountingOutputStream(OutputStream *proxy, bool ownPtr = false) : ProxyOutputStream(proxy, ownPtr), mByteCount(0) diff --git a/externals/coda-oss/modules/c++/io/include/io/InputStream.h b/externals/coda-oss/modules/c++/io/include/io/InputStream.h index 07f5d06ef..d520aa7ca 100644 --- a/externals/coda-oss/modules/c++/io/include/io/InputStream.h +++ b/externals/coda-oss/modules/c++/io/include/io/InputStream.h @@ -25,6 +25,7 @@ #include "coda_oss/span.h" +#include "config/Exports.h" #include "sys/Dbg.h" #include "io/OutputStream.h" @@ -53,7 +54,7 @@ namespace io * of large streams of bytes. * */ -struct InputStream +struct CODA_OSS_API InputStream { enum { diff --git a/externals/coda-oss/modules/c++/io/include/io/OutputStream.h b/externals/coda-oss/modules/c++/io/include/io/OutputStream.h index 6f41aa249..0e97518e8 100644 --- a/externals/coda-oss/modules/c++/io/include/io/OutputStream.h +++ b/externals/coda-oss/modules/c++/io/include/io/OutputStream.h @@ -26,6 +26,7 @@ #include +#include "config/Exports.h" #include "sys/Dbg.h" #include "sys/Conf.h" #include "coda_oss/string.h" @@ -50,7 +51,7 @@ namespace io * */ -struct OutputStream +struct CODA_OSS_API OutputStream { OutputStream() = default; virtual ~OutputStream() = default; diff --git a/externals/coda-oss/modules/c++/io/include/io/ProxyStreams.h b/externals/coda-oss/modules/c++/io/include/io/ProxyStreams.h index b9b4d5108..9f578f36f 100644 --- a/externals/coda-oss/modules/c++/io/include/io/ProxyStreams.h +++ b/externals/coda-oss/modules/c++/io/include/io/ProxyStreams.h @@ -23,6 +23,7 @@ #ifndef __IO_PROXY_STREAMS_H__ #define __IO_PROXY_STREAMS_H__ +#include "config/Exports.h" #include "io/InputStream.h" #include "io/OutputStream.h" #include "io/NullStreams.h" @@ -30,7 +31,7 @@ namespace io { -struct ProxyInputStream: public InputStream +struct CODA_OSS_API ProxyInputStream : public InputStream { ProxyInputStream(InputStream *proxy, bool ownPtr = false) : mOwnPtr(ownPtr) @@ -72,7 +73,7 @@ struct ProxyInputStream: public InputStream /** * Proxies to the given OutputStream. */ -struct ProxyOutputStream: public OutputStream +struct CODA_OSS_API ProxyOutputStream : public OutputStream { ProxyOutputStream() = default; ProxyOutputStream(OutputStream *proxy, bool ownPtr = false) : @@ -123,7 +124,7 @@ struct ProxyOutputStream: public OutputStream /** * An output stream that can be enabled/disabled (toggled). */ -struct ToggleOutputStream: public io::ProxyOutputStream +struct CODA_OSS_API ToggleOutputStream : public io::ProxyOutputStream { ToggleOutputStream() = default; ToggleOutputStream(io::OutputStream *output, bool ownPtr = false) : diff --git a/externals/coda-oss/modules/c++/io/include/io/RotatingFileOutputStream.h b/externals/coda-oss/modules/c++/io/include/io/RotatingFileOutputStream.h index 5948123f9..c1c30dcef 100644 --- a/externals/coda-oss/modules/c++/io/include/io/RotatingFileOutputStream.h +++ b/externals/coda-oss/modules/c++/io/include/io/RotatingFileOutputStream.h @@ -23,6 +23,7 @@ #ifndef __IO_ROTATING_FILE_STREAMS_H__ #define __IO_ROTATING_FILE_STREAMS_H__ +#include "config/Exports.h" #include #include "io/CountingStreams.h" @@ -32,7 +33,7 @@ namespace io /** * An OutputStream that keeps track of the number of bytes written to the stream. */ -struct RotatingFileOutputStream: public CountingOutputStream +struct CODA_OSS_API RotatingFileOutputStream : public CountingOutputStream { RotatingFileOutputStream(const std::string& filename, unsigned long maxBytes = 0, diff --git a/externals/coda-oss/modules/c++/io/include/io/Seekable.h b/externals/coda-oss/modules/c++/io/include/io/Seekable.h index e4c368fab..bbcae0374 100644 --- a/externals/coda-oss/modules/c++/io/include/io/Seekable.h +++ b/externals/coda-oss/modules/c++/io/include/io/Seekable.h @@ -24,6 +24,8 @@ #define __IO_SEEKABLE_H__ #pragma once +#include "config/Exports.h" + /*! * Unlike in Java, we have chosen to make our InputStream and OutputStream * classes into interfaces, not abstract classes (in the sense that we @@ -40,7 +42,7 @@ namespace io { -class Seekable +class CODA_OSS_API Seekable { public: Seekable() = default; diff --git a/externals/coda-oss/modules/c++/io/include/io/SeekableStreams.h b/externals/coda-oss/modules/c++/io/include/io/SeekableStreams.h index 792187d26..73d8e79e2 100644 --- a/externals/coda-oss/modules/c++/io/include/io/SeekableStreams.h +++ b/externals/coda-oss/modules/c++/io/include/io/SeekableStreams.h @@ -23,6 +23,7 @@ #ifndef __IO_SEEKABLE_STREAMS_H__ #define __IO_SEEKABLE_STREAMS_H__ +#include "config/Exports.h" #include "io/InputStream.h" #include "io/OutputStream.h" #include "io/BidirectionalStream.h" @@ -41,7 +42,7 @@ namespace io { -struct SeekableInputStream : +struct CODA_OSS_API SeekableInputStream : public InputStream, public Seekable { SeekableInputStream() = default; @@ -49,7 +50,7 @@ struct SeekableInputStream : using InputStream::streamTo; }; -struct SeekableOutputStream : +struct CODA_OSS_API SeekableOutputStream : public OutputStream, public Seekable { SeekableOutputStream() = default; diff --git a/externals/coda-oss/modules/c++/io/include/io/StreamSplitter.h b/externals/coda-oss/modules/c++/io/include/io/StreamSplitter.h index 20a5339b0..d4dff356c 100644 --- a/externals/coda-oss/modules/c++/io/include/io/StreamSplitter.h +++ b/externals/coda-oss/modules/c++/io/include/io/StreamSplitter.h @@ -26,8 +26,9 @@ #include #include -#include -#include +#include "config/Exports.h" +#include "sys/Conf.h" +#include "io/InputStream.h" namespace io { @@ -36,7 +37,8 @@ namespace io * specified delimiter string. It uses buffered stream reads internally for * better efficiency than InputStream::readln for reading large amounts of data. */ -struct StreamSplitter { +struct CODA_OSS_API StreamSplitter +{ /*! * \brief Create a stream splitter. * diff --git a/externals/coda-oss/modules/c++/io/include/io/TempFile.h b/externals/coda-oss/modules/c++/io/include/io/TempFile.h index b08c0a1ac..8e80e054b 100644 --- a/externals/coda-oss/modules/c++/io/include/io/TempFile.h +++ b/externals/coda-oss/modules/c++/io/include/io/TempFile.h @@ -24,7 +24,8 @@ #ifndef __IO_TEMPFILE_H__ #define __IO_TEMPFILE_H__ -#include +#include "config/Exports.h" +#include "sys/OS.h" namespace io { @@ -32,7 +33,7 @@ namespace io * RAII object for a temporary file that gets deleted * upon object destruction */ -struct TempFile +struct CODA_OSS_API TempFile { /*! * Constructor for TempFile object. Provided a directory, diff --git a/externals/coda-oss/modules/c++/io/unittests/test_streams.cpp b/externals/coda-oss/modules/c++/io/unittests/test_streams.cpp index ca652b5d5..e847909e4 100644 --- a/externals/coda-oss/modules/c++/io/unittests/test_streams.cpp +++ b/externals/coda-oss/modules/c++/io/unittests/test_streams.cpp @@ -152,11 +152,13 @@ TEST_CASE(testBufferViewStream) TEST_ASSERT_EQ(stream.available(), 4); std::vector output(3); - TEST_ASSERT_EQ(stream.read(&output[0], 2), 2); + auto result = stream.read(&output[0], 2); + TEST_ASSERT_EQ(result, 2); TEST_ASSERT_EQ(stream.tell(), 2); TEST_ASSERT_EQ(stream.available(), 2); stream.seek(1, io::Seekable::CURRENT); - TEST_ASSERT_EQ(stream.read(&output[2], 1), 1); + result = stream.read(&output[2], 1); + TEST_ASSERT_EQ(result, 1); TEST_ASSERT_EQ(output[0], 2); TEST_ASSERT_EQ(output[1], 4); TEST_ASSERT_EQ(output[2], 9); @@ -189,11 +191,13 @@ TEST_CASE(testBufferViewIntStream) io::BufferViewStream stream(bufferView); std::vector output(3); - TEST_ASSERT_EQ(stream.read(&output[0], 2), 2); + auto result = stream.read(&output[0], 2); + TEST_ASSERT_EQ(result, 2); TEST_ASSERT_EQ(stream.tell(), static_cast(2 * sizeof(int))); TEST_ASSERT_EQ(stream.available(), static_cast(2 * sizeof(int))); stream.seek(1 * sizeof(int), io::Seekable::CURRENT); - TEST_ASSERT_EQ(stream.read(&output[2], 1), 1); + result = stream.read(&output[2], 1); + TEST_ASSERT_EQ(result, 1); TEST_ASSERT_EQ(output[0], 2); TEST_ASSERT_EQ(output[1], 4); TEST_ASSERT_EQ(output[2], 9); @@ -209,7 +213,8 @@ TEST_CASE(testBufferViewIntStream) // Truncate properly if we ask for more elements than there are ::memset(&output[0], 0, output.size() * sizeof(output[0])); stream.seek(3 * sizeof(int), io::Seekable::START); - TEST_ASSERT_EQ(stream.read(&output[0], 2), 1); + result = stream.read(&output[0], 2); + TEST_ASSERT_EQ(result, 1); TEST_ASSERT_EQ(stream.tell(), static_cast(4 * sizeof(int))); TEST_ASSERT_EQ(output[0], 9); TEST_ASSERT_EQ(output[1], 0); @@ -315,8 +320,7 @@ TEST_CASE(testRotateReset) cleanupFiles( outFile); } -int main(int, char**) -{ +TEST_MAIN( TEST_CHECK(testStringStream); TEST_CHECK(testByteStream); TEST_CHECK(testProxyOutputStream); @@ -326,4 +330,4 @@ int main(int, char**) TEST_CHECK(testRotate); TEST_CHECK(testNeverRotate); TEST_CHECK(testRotateReset); -} + ) diff --git a/externals/coda-oss/modules/c++/io/unittests/test_tempfile.cpp b/externals/coda-oss/modules/c++/io/unittests/test_tempfile.cpp index 8f7d1a19f..ae391a26d 100644 --- a/externals/coda-oss/modules/c++/io/unittests/test_tempfile.cpp +++ b/externals/coda-oss/modules/c++/io/unittests/test_tempfile.cpp @@ -26,8 +26,6 @@ #include #include "TestCase.h" -namespace -{ TEST_CASE(testTempFileCreation) { const sys::OS os; @@ -50,13 +48,9 @@ TEST_CASE(testFileDestroyed) TEST_ASSERT(!os.exists(pathname)); } -} - -int main(int, char**) -{ +TEST_MAIN( TEST_CHECK(testTempFileCreation); TEST_CHECK(testFileDestroyed); - return 0; -} + ) diff --git a/externals/coda-oss/modules/c++/logging/include/logging/Filterer.h b/externals/coda-oss/modules/c++/logging/include/logging/Filterer.h index 3a33bb1e5..558844d08 100644 --- a/externals/coda-oss/modules/c++/logging/include/logging/Filterer.h +++ b/externals/coda-oss/modules/c++/logging/include/logging/Filterer.h @@ -30,6 +30,9 @@ #include #include + +#include "config/Exports.h" + #include "logging/Filter.h" #include "logging/LogRecord.h" @@ -42,7 +45,7 @@ namespace logging * A base class for loggers and handlers which allows them to share * common code. */ -struct Filterer +struct CODA_OSS_API Filterer { Filterer() = default; virtual ~Filterer() = default; diff --git a/externals/coda-oss/modules/c++/logging/include/logging/Handler.h b/externals/coda-oss/modules/c++/logging/include/logging/Handler.h index ba9ea2943..9c144f45a 100644 --- a/externals/coda-oss/modules/c++/logging/include/logging/Handler.h +++ b/externals/coda-oss/modules/c++/logging/include/logging/Handler.h @@ -28,6 +28,7 @@ #define CODA_OSS_logging_Handler_h_INCLUDED_ #include +#include "config/Exports.h" #include "logging/LogRecord.h" #include "logging/Formatter.h" #include "logging/StandardFormatter.h" @@ -45,7 +46,7 @@ namespace logging * The Handler class is abstract. Sub-classes handle LogRecord* objects, * emitting the information in a user-defined manner. */ -struct Handler : public Filterer +struct CODA_OSS_API Handler : public Filterer { /*! * Construct a Handler at the specified LogLevel (LogLevel::LOG_NOTSET is default) diff --git a/externals/coda-oss/modules/c++/logging/include/logging/Logger.h b/externals/coda-oss/modules/c++/logging/include/logging/Logger.h index 5ab56a82e..df158fcfc 100644 --- a/externals/coda-oss/modules/c++/logging/include/logging/Logger.h +++ b/externals/coda-oss/modules/c++/logging/include/logging/Logger.h @@ -31,6 +31,7 @@ #include #include +#include "config/Exports.h" #include "logging/Filterer.h" #include "logging/LogRecord.h" #include "logging/Handler.h" @@ -45,7 +46,7 @@ namespace logging * Instances of the Logger class represent a single logging channel. * A Logger instance can log to several Handlers. */ -struct Logger : public Filterer +struct CODA_OSS_API Logger : public Filterer { /*! * Constructs a Logger with an optional name diff --git a/externals/coda-oss/modules/c++/logging/include/logging/RotatingFileHandler.h b/externals/coda-oss/modules/c++/logging/include/logging/RotatingFileHandler.h index 73a3eae07..45fc32943 100644 --- a/externals/coda-oss/modules/c++/logging/include/logging/RotatingFileHandler.h +++ b/externals/coda-oss/modules/c++/logging/include/logging/RotatingFileHandler.h @@ -29,6 +29,7 @@ #include #include +#include "config/Exports.h" #include "logging/LogRecord.h" #include "logging/StreamHandler.h" #include @@ -47,7 +48,7 @@ namespace logging * renamed to 'error.log.1', and all future logs will be logged to error.log. * This is useful if you would like to keep backups of logs. */ -struct RotatingFileHandler : public StreamHandler +struct CODA_OSS_API RotatingFileHandler : public StreamHandler { /*! * \param fname The file to log to diff --git a/externals/coda-oss/modules/c++/logging/include/logging/StandardFormatter.h b/externals/coda-oss/modules/c++/logging/include/logging/StandardFormatter.h index dd44f6f3a..0e11d3d30 100644 --- a/externals/coda-oss/modules/c++/logging/include/logging/StandardFormatter.h +++ b/externals/coda-oss/modules/c++/logging/include/logging/StandardFormatter.h @@ -29,6 +29,7 @@ #include #include +#include "config/Exports.h" #include "logging/Formatter.h" #include "logging/LogRecord.h" @@ -52,7 +53,7 @@ namespace logging * The default format looks like this: * [%c] %p %d ==> %m */ -class StandardFormatter : public Formatter +class CODA_OSS_API StandardFormatter : public Formatter { public: static const char DEFAULT_FORMAT[]; diff --git a/externals/coda-oss/modules/c++/logging/include/logging/StreamHandler.h b/externals/coda-oss/modules/c++/logging/include/logging/StreamHandler.h index 910792b02..d6786d76a 100644 --- a/externals/coda-oss/modules/c++/logging/include/logging/StreamHandler.h +++ b/externals/coda-oss/modules/c++/logging/include/logging/StreamHandler.h @@ -28,6 +28,7 @@ #define __LOGGING_STREAM_HANDLER_H__ #include +#include "config/Exports.h" #include "logging/LogRecord.h" #include "logging/Handler.h" #include @@ -40,7 +41,7 @@ namespace logging * \class StreamHandler * \brief Emits LogRecords to an io::OutputStream */ -struct StreamHandler : public Handler +struct CODA_OSS_API StreamHandler : public Handler { //! Constructs a StreamHandler that uses an io::StandardOutStream StreamHandler(LogLevel level = LogLevel::LOG_NOTSET); diff --git a/externals/coda-oss/modules/c++/logging/unittests/test_exception_logger.cpp b/externals/coda-oss/modules/c++/logging/unittests/test_exception_logger.cpp index a9d9c9709..6efde85a9 100644 --- a/externals/coda-oss/modules/c++/logging/unittests/test_exception_logger.cpp +++ b/externals/coda-oss/modules/c++/logging/unittests/test_exception_logger.cpp @@ -30,13 +30,18 @@ #include #include -class RunNothing : public sys::Runnable +class RunNothing final : public sys::Runnable { -private: size_t& counter; logging::ExceptionLogger* exLog; bool getBacktrace; - static sys::Mutex counterLock; + + static sys::Mutex* counterLock() + { + static sys::Mutex lock; + return &lock; + } + public: RunNothing(size_t& c, logging::ExceptionLogger* el, bool getBacktrace=false) : counter(c), exLog(el), getBacktrace(getBacktrace) {} @@ -46,7 +51,7 @@ class RunNothing : public sys::Runnable return; { - mt::CriticalSection crit(&counterLock); + mt::CriticalSection crit(counterLock()); counter++; } @@ -57,8 +62,6 @@ class RunNothing : public sys::Runnable } }; -sys::Mutex RunNothing::counterLock; - TEST_CASE(testExceptionLogger) { logging::Logger log("test"); @@ -135,8 +138,7 @@ TEST_CASE(testExceptionWithBacktrace) #pragma warning(pop) #endif -int main(int, char**) -{ +TEST_MAIN( TEST_CHECK(testExceptionLogger); TEST_CHECK(testExceptionWithBacktrace); -} +) diff --git a/externals/coda-oss/modules/c++/logging/unittests/test_rotating_log.cpp b/externals/coda-oss/modules/c++/logging/unittests/test_rotating_log.cpp index 222dbfeec..2404c72c2 100644 --- a/externals/coda-oss/modules/c++/logging/unittests/test_rotating_log.cpp +++ b/externals/coda-oss/modules/c++/logging/unittests/test_rotating_log.cpp @@ -111,9 +111,8 @@ TEST_CASE(testRotateReset) cleanupFiles( outFile); } -int main(int, char**) -{ +TEST_MAIN( TEST_CHECK( testNeverRotate); TEST_CHECK( testRotateReset); TEST_CHECK( testRotate); -} + ) diff --git a/externals/coda-oss/modules/c++/math.poly/unittests/test_1d_poly.cpp b/externals/coda-oss/modules/c++/math.poly/unittests/test_1d_poly.cpp index 8ecee86bd..f490b8b81 100644 --- a/externals/coda-oss/modules/c++/math.poly/unittests/test_1d_poly.cpp +++ b/externals/coda-oss/modules/c++/math.poly/unittests/test_1d_poly.cpp @@ -25,10 +25,10 @@ #include #include "TestCase.h" -namespace -{ double getRand() { + static const auto call_srand = [](){ srand(176); return true; }; + static auto srand_called = call_srand(); return (50.0 * rand() / RAND_MAX - 25.0); } @@ -143,13 +143,10 @@ TEST_CASE(testTransformInput) std::abs(.01 * expectedValue)); } } -} -int main(int, char**) -{ - srand(176); +TEST_MAIN( TEST_CHECK(testScaleVariable); TEST_CHECK(testTruncateTo); TEST_CHECK(testTruncateToNonZeros); TEST_CHECK(testTransformInput); -} + ) diff --git a/externals/coda-oss/modules/c++/math.poly/unittests/test_2d_poly.cpp b/externals/coda-oss/modules/c++/math.poly/unittests/test_2d_poly.cpp index edefda2b7..47de5a4d4 100644 --- a/externals/coda-oss/modules/c++/math.poly/unittests/test_2d_poly.cpp +++ b/externals/coda-oss/modules/c++/math.poly/unittests/test_2d_poly.cpp @@ -25,10 +25,10 @@ #include #include "TestCase.h" -namespace -{ double getRand() { + static const auto call_srand = [](){ srand(176); return true; }; + static auto srand_called = call_srand(); return (50.0 * rand() / RAND_MAX - 25.0); } @@ -486,11 +486,8 @@ TEST_CASE(testAtY) TEST_ASSERT_EQ(p4.atY(3)(2), p4(2, 3)); TEST_ASSERT_EQ(p4.flipXY().atY(4)(5), p4(4, 5)); } -} -int main(int, char**) -{ - srand(176); +TEST_MAIN( TEST_CHECK(testScaleVariable); TEST_CHECK(testTruncateTo); TEST_CHECK(testTruncateToNonZeros); @@ -498,5 +495,5 @@ int main(int, char**) TEST_CHECK(testOperators); TEST_CHECK(testIsScalar); TEST_CHECK(testAtY); -} + ) diff --git a/externals/coda-oss/modules/c++/math.poly/unittests/test_fixed_1d_poly.cpp b/externals/coda-oss/modules/c++/math.poly/unittests/test_fixed_1d_poly.cpp index af240eb04..7b588f2f1 100644 --- a/externals/coda-oss/modules/c++/math.poly/unittests/test_fixed_1d_poly.cpp +++ b/externals/coda-oss/modules/c++/math.poly/unittests/test_fixed_1d_poly.cpp @@ -25,13 +25,14 @@ #include #include "TestCase.h" -namespace -{ static const size_t ORDER = 5; typedef math::poly::Fixed1D TestFixed1D; double getRand() { + static const auto call_srand = [](){ srand(176); return true; }; + static auto srand_called = call_srand(); + return (50.0 * rand() / RAND_MAX - 25.0); } @@ -77,10 +78,7 @@ TEST_CASE(testScaleVariable) std::abs(.01 * expectedValue)); } } -} -int main() -{ - srand(176); +TEST_MAIN( TEST_CHECK(testScaleVariable); -} +) diff --git a/externals/coda-oss/modules/c++/math.poly/unittests/test_fixed_2d_poly.cpp b/externals/coda-oss/modules/c++/math.poly/unittests/test_fixed_2d_poly.cpp index e84f17801..05ab29101 100644 --- a/externals/coda-oss/modules/c++/math.poly/unittests/test_fixed_2d_poly.cpp +++ b/externals/coda-oss/modules/c++/math.poly/unittests/test_fixed_2d_poly.cpp @@ -25,14 +25,15 @@ #include #include "TestCase.h" -namespace -{ static const size_t ORDER_X = 4; static const size_t ORDER_Y = 5; typedef math::poly::Fixed2D TestFixed2D; double getRand() { + static const auto call_srand = [](){ srand(176); return true; }; + static auto srand_called = call_srand(); + return (50.0 * rand() / RAND_MAX - 25.0); } @@ -101,10 +102,7 @@ TEST_CASE(testScaleVariable) std::abs(.01 * expectedValue)); } } -} -int main(int, char**) -{ - srand(176); +TEST_MAIN( TEST_CHECK(testScaleVariable); -} +) diff --git a/externals/coda-oss/modules/c++/math.poly/unittests/test_llsq.cpp b/externals/coda-oss/modules/c++/math.poly/unittests/test_llsq.cpp index 44336e0d2..c2968592e 100644 --- a/externals/coda-oss/modules/c++/math.poly/unittests/test_llsq.cpp +++ b/externals/coda-oss/modules/c++/math.poly/unittests/test_llsq.cpp @@ -24,11 +24,7 @@ #include #include "TestCase.h" -using namespace math::linear; -using namespace math::poly; -namespace -{ inline double diffSq(double lhs, double rhs) { @@ -38,6 +34,9 @@ double diffSq(double lhs, double rhs) TEST_CASE(test1DPolyfit) { + using namespace math::linear; + using namespace math::poly; + const double xObs[] = { 1, -1, 2, -2 }; const double yObs[] = { 3, 13, 1, 33 }; const double zPoly[] = { 5, -4, 3, -1 }; @@ -72,6 +71,9 @@ TEST_CASE(test1DPolyfit) TEST_CASE(test1DPolyfitLarge) { + using namespace math::linear; + using namespace math::poly; + // Fit a polynomial static const size_t NUM_OBS = 9; double xObs[] = { 1, -1, 2, -2, 3, 15, 29, -4, -14 }; @@ -129,6 +131,9 @@ TEST_CASE(test1DPolyfitLarge) TEST_CASE(test2DPolyfit) { + using namespace math::linear; + using namespace math::poly; + const double coeffs[] = { -1.02141e-16, 0.15, @@ -162,6 +167,9 @@ TEST_CASE(test2DPolyfit) TEST_CASE(test2DPolyfitLarge) { + using namespace math::linear; + using namespace math::poly; + // Use a defined polynomial to generate mapped values. This ensures // it is possible to fit the points using at least as many coefficients. const double coeffs[] = @@ -233,6 +241,9 @@ TEST_CASE(test2DPolyfitLarge) TEST_CASE(testVectorValuedOrderChange) { + using namespace math::linear; + using namespace math::poly; + // When fitting a vector-valued polynomial, math::poly::fit() // will perform 3 independent fits, and then assemble the coefficients // into vector-valued coefficients for the resulting polynomial. @@ -336,14 +347,11 @@ TEST_CASE(testVectorValuedOrderChange) TEST_ASSERT_ALMOST_EQ(poly[2][2], 0.0); } } -} -int main(int, char**) -{ +TEST_MAIN( TEST_CHECK(test1DPolyfit); TEST_CHECK(test1DPolyfitLarge); TEST_CHECK(test2DPolyfit); TEST_CHECK(test2DPolyfitLarge); TEST_CHECK(testVectorValuedOrderChange); - return 0; -} + ) \ No newline at end of file diff --git a/externals/coda-oss/modules/c++/mem/unittests/test_Span.cpp b/externals/coda-oss/modules/c++/mem/unittests/test_Span.cpp index 119c5a65d..472a87992 100644 --- a/externals/coda-oss/modules/c++/mem/unittests/test_Span.cpp +++ b/externals/coda-oss/modules/c++/mem/unittests/test_Span.cpp @@ -52,7 +52,7 @@ TEST_CASE(testSpanBuffer) { std::vector ints{1, 2, 3, 4, 5}; const coda_oss::span span(ints.data(), ints.size()); - testSpanBuffer_("testSpanBuffer", ints, span); + testSpanBuffer_(testName, ints, span); } } @@ -77,7 +77,7 @@ TEST_CASE(testSpanVector) { std::vector ints{1, 2, 3, 4, 5}; const coda_oss::span span(ints.data(), ints.size()); - testSpanVector_("testSpanVector", ints, span); + testSpanVector_(testName, ints, span); } } diff --git a/externals/coda-oss/modules/c++/mt/include/mt/Algorithm.h b/externals/coda-oss/modules/c++/mt/include/mt/Algorithm.h index e42062ae2..4ef5b5ec9 100644 --- a/externals/coda-oss/modules/c++/mt/include/mt/Algorithm.h +++ b/externals/coda-oss/modules/c++/mt/include/mt/Algorithm.h @@ -46,7 +46,7 @@ namespace details const auto mid1 = first1 + len / 2; const auto d_mid = d_first + len / 2; auto handle = std::async(policy, transform_async, mid1, last1, d_mid, f, cutoff, policy); - transform_async(first1, mid1, d_first, f, cutoff, policy); + details::transform_async(first1, mid1, d_first, f, cutoff, policy); return handle.get(); } } diff --git a/externals/coda-oss/modules/c++/mt/include/mt/GenerationThreadPool.h b/externals/coda-oss/modules/c++/mt/include/mt/GenerationThreadPool.h index c047110aa..f22b6be4b 100644 --- a/externals/coda-oss/modules/c++/mt/include/mt/GenerationThreadPool.h +++ b/externals/coda-oss/modules/c++/mt/include/mt/GenerationThreadPool.h @@ -26,6 +26,8 @@ #include +#include "config/Exports.h" + #if !defined(__APPLE_CC__) #include @@ -37,7 +39,7 @@ namespace mt { - class TiedRequestHandler : public sys::Runnable + class CODA_OSS_API TiedRequestHandler : public sys::Runnable { RunnableRequestQueue* mRequestQueue; sys::Semaphore* mSem = nullptr; @@ -64,7 +66,7 @@ namespace mt virtual void run(); }; - class GenerationThreadPool : public BasicThreadPool + class CODA_OSS_API GenerationThreadPool : public BasicThreadPool { sys::Semaphore mGenerationSync; CPUAffinityInitializer* mAffinityInit = nullptr; diff --git a/externals/coda-oss/modules/c++/mt/include/mt/ThreadGroup.h b/externals/coda-oss/modules/c++/mt/include/mt/ThreadGroup.h index c8d667f6b..745aff022 100644 --- a/externals/coda-oss/modules/c++/mt/include/mt/ThreadGroup.h +++ b/externals/coda-oss/modules/c++/mt/include/mt/ThreadGroup.h @@ -33,8 +33,11 @@ #include #include #include +#include +#if !defined(MT_DEFAULT_PINNING) #include "mt/mt_config.h" +#endif #include #include @@ -50,7 +53,7 @@ namespace mt * sys::Runnable objects and wait for all threads to complete. * */ -struct ThreadGroup +struct CODA_OSS_API ThreadGroup { /*! * Constructor. diff --git a/externals/coda-oss/modules/c++/mt/include/mt/ThreadPlanner.h b/externals/coda-oss/modules/c++/mt/include/mt/ThreadPlanner.h index a6a514730..39cca41b5 100644 --- a/externals/coda-oss/modules/c++/mt/include/mt/ThreadPlanner.h +++ b/externals/coda-oss/modules/c++/mt/include/mt/ThreadPlanner.h @@ -25,13 +25,15 @@ #include +#include + namespace mt { /*! * \class ThreadPlanner * \brief Assists with dividing up work evenly between threads */ -class ThreadPlanner +class CODA_OSS_API ThreadPlanner { public: /*! diff --git a/externals/coda-oss/modules/c++/mt/unittests/Runnable1DTest.cpp b/externals/coda-oss/modules/c++/mt/unittests/Runnable1DTest.cpp index 7f5bf1336..61ad49ae8 100644 --- a/externals/coda-oss/modules/c++/mt/unittests/Runnable1DTest.cpp +++ b/externals/coda-oss/modules/c++/mt/unittests/Runnable1DTest.cpp @@ -26,24 +26,15 @@ #include #include #include +#include #include "import/sys.h" #include "import/mt.h" #include "TestCase.h" -using namespace sys; -using namespace mt; -using namespace std; - -namespace -{ -class AddOp +struct AddOp final { -public: - AddOp() - { - } - + AddOp() = default; void operator()(size_t element) const { std::ostringstream ostr; @@ -55,13 +46,9 @@ class AddOp } }; -class LocalStorage +struct LocalStorage final { -public: - LocalStorage() : mValue(0) - { - } - + LocalStorage() = default; void operator()(size_t element) const { // All we're really showing here is that we never print out the same @@ -73,25 +60,25 @@ class LocalStorage } private: - mutable size_t mValue; + mutable size_t mValue = 0; }; -TEST_CASE(Runnable1DTest) +TEST_CASE(DoRunnable1DTest) { - std::cout << "Running test case" << std::endl; + std::cout << "Running test case\n"; const AddOp op; - std::cout << "Calling run1D" << std::endl; - run1D(10, 16, op); + std::cout << "Calling run1D\n"; + mt::run1D(10, 16, op); } TEST_CASE(Runnable1DWithCopiesTest) { // TODO: Have LocalStorage actually store its values off in a vector, then // show we got all those values. - std::cout << "Running test case" << std::endl; + std::cout << "Running test case\n"; const LocalStorage op; - std::cout << "Calling run1D" << std::endl; - run1DWithCopies(47, 16, op); + std::cout << "Calling run1D\n"; + mt::run1DWithCopies(47, 16, op); } TEST_CASE(transform_async_test) @@ -116,13 +103,9 @@ TEST_CASE(transform_async_test) mt::transform_async(ints.begin(), ints.end(), results.begin(), f, 1000, std::launch::async); TEST_ASSERT_EQ(results.back(), f(ints.back())); } -} -int main(int, char**) -{ - TEST_CHECK(Runnable1DTest); +TEST_MAIN( + TEST_CHECK(DoRunnable1DTest); TEST_CHECK(Runnable1DWithCopiesTest); TEST_CHECK(transform_async_test); - - return 0; -} + ) diff --git a/externals/coda-oss/modules/c++/mt/unittests/ThreadGroupTest.cpp b/externals/coda-oss/modules/c++/mt/unittests/ThreadGroupTest.cpp index 9e8f21bf1..962260056 100644 --- a/externals/coda-oss/modules/c++/mt/unittests/ThreadGroupTest.cpp +++ b/externals/coda-oss/modules/c++/mt/unittests/ThreadGroupTest.cpp @@ -24,13 +24,8 @@ #include "import/mt.h" #include "TestCase.h" -using namespace sys; -using namespace mt; -using namespace std; - -class MyRunTask : public Runnable +struct MyRunTask final : public sys::Runnable { -public: int result; int *state; int *num_deleted; @@ -53,9 +48,9 @@ class MyRunTask : public Runnable } }; -TEST_CASE(ThreadGroupTest) +TEST_CASE(DoThreadGroupTest) { - ThreadGroup *threads = new ThreadGroup(); + auto threads = new mt::ThreadGroup(); int state = 1, numDeleted = 0; MyRunTask *tasks[3]; @@ -89,26 +84,24 @@ TEST_CASE(PinToCPUTest) defaultValue = false; #endif // Check the pinning settings for the default value - TEST_ASSERT_EQ(ThreadGroup::getDefaultPinToCPU(), defaultValue); - ThreadGroup threads1; + TEST_ASSERT_EQ(mt::ThreadGroup::getDefaultPinToCPU(), defaultValue); + mt::ThreadGroup threads1; TEST_ASSERT_EQ(threads1.isPinToCPUEnabled(), defaultValue); // Check the pinning settings when pinning is enabled - ThreadGroup::setDefaultPinToCPU(true); - TEST_ASSERT_EQ(ThreadGroup::getDefaultPinToCPU(), true); - ThreadGroup threads2; + mt::ThreadGroup::setDefaultPinToCPU(true); + TEST_ASSERT_EQ(mt::ThreadGroup::getDefaultPinToCPU(), true); + mt::ThreadGroup threads2; TEST_ASSERT_EQ(threads2.isPinToCPUEnabled(), true); // Check the pinning settings when pinning is disabled - ThreadGroup::setDefaultPinToCPU(false); - TEST_ASSERT_EQ(ThreadGroup::getDefaultPinToCPU(), false); - ThreadGroup threads3; + mt::ThreadGroup::setDefaultPinToCPU(false); + TEST_ASSERT_EQ(mt::ThreadGroup::getDefaultPinToCPU(), false); + mt::ThreadGroup threads3; TEST_ASSERT_EQ(threads3.isPinToCPUEnabled(), false); } -int main(int, char**) -{ - TEST_CHECK(ThreadGroupTest); +TEST_MAIN( + TEST_CHECK(DoThreadGroupTest); TEST_CHECK(PinToCPUTest); - return 0; -} + ) diff --git a/externals/coda-oss/modules/c++/mt/unittests/ThreadPlannerTest.cpp b/externals/coda-oss/modules/c++/mt/unittests/ThreadPlannerTest.cpp index 6fc4b9df4..295719630 100644 --- a/externals/coda-oss/modules/c++/mt/unittests/ThreadPlannerTest.cpp +++ b/externals/coda-oss/modules/c++/mt/unittests/ThreadPlannerTest.cpp @@ -23,8 +23,6 @@ #include #include "TestCase.h" -namespace -{ TEST_CASE(GetThreadInfoTest) { const size_t numThreads(16); @@ -79,12 +77,8 @@ TEST_CASE(GetNumThreadsThatWillBeUsedTest) const mt::ThreadPlanner planner7(NUM_ELEMENTS, 9999); TEST_ASSERT_EQ(planner7.getNumThreadsThatWillBeUsed(), static_cast(100)); } -} -int main(int, char**) -{ +TEST_MAIN( TEST_CHECK(GetThreadInfoTest); TEST_CHECK(GetNumThreadsThatWillBeUsedTest); - - return 0; -} +) diff --git a/externals/coda-oss/modules/c++/mt/unittests/balanced_runnable_1d_test.cpp b/externals/coda-oss/modules/c++/mt/unittests/balanced_runnable_1d_test.cpp index 4a7261703..4ff1d80fa 100644 --- a/externals/coda-oss/modules/c++/mt/unittests/balanced_runnable_1d_test.cpp +++ b/externals/coda-oss/modules/c++/mt/unittests/balanced_runnable_1d_test.cpp @@ -22,8 +22,6 @@ #include #include "TestCase.h" -namespace -{ class IncOp { public: @@ -63,10 +61,7 @@ TEST_CASE(BalancedRunnable1DTestWorkDone) } } } -} -int main(int /*argc*/, char** /*argv*/) -{ +TEST_MAIN( TEST_CHECK(BalancedRunnable1DTestWorkDone); - return 0; -} +) diff --git a/externals/coda-oss/modules/c++/mt/unittests/work_sharing_balanced_runnable_1d_test.cpp b/externals/coda-oss/modules/c++/mt/unittests/work_sharing_balanced_runnable_1d_test.cpp index c45cf306f..c161b31cd 100644 --- a/externals/coda-oss/modules/c++/mt/unittests/work_sharing_balanced_runnable_1d_test.cpp +++ b/externals/coda-oss/modules/c++/mt/unittests/work_sharing_balanced_runnable_1d_test.cpp @@ -22,11 +22,8 @@ #include #include "TestCase.h" -namespace +struct IncOp final { -class IncOp -{ -public: IncOp(std::vector& globalWorkDone) : mGlobalWorkDone(globalWorkDone) { @@ -84,11 +81,8 @@ TEST_CASE(WorkSharingBalancedRunnable1DTestWorkDoneLessWorkThanThreads) } } } -} -int main(int /*argc*/, char** /*argv*/) -{ +TEST_MAIN( TEST_CHECK(WorkSharingBalancedRunnable1DTestWorkDone); TEST_CHECK(WorkSharingBalancedRunnable1DTestWorkDoneLessWorkThanThreads); - return 0; -} +) diff --git a/externals/coda-oss/modules/c++/polygon/include/polygon/PolygonMask.h b/externals/coda-oss/modules/c++/polygon/include/polygon/PolygonMask.h index 40a08feb7..0744e241b 100644 --- a/externals/coda-oss/modules/c++/polygon/include/polygon/PolygonMask.h +++ b/externals/coda-oss/modules/c++/polygon/include/polygon/PolygonMask.h @@ -30,6 +30,7 @@ #include #include #include +#include "config/Exports.h" namespace polygon { @@ -38,7 +39,7 @@ namespace polygon * \brief Acts as a mask for a convex polygon without actually allocating a * bool buffer to draw it. */ -struct PolygonMask final +struct CODA_OSS_API PolygonMask final { enum MarkModesEnum { diff --git a/externals/coda-oss/modules/c++/polygon/unittests/test_polygon_mask.cpp b/externals/coda-oss/modules/c++/polygon/unittests/test_polygon_mask.cpp index 13a4bc53b..01af9905f 100644 --- a/externals/coda-oss/modules/c++/polygon/unittests/test_polygon_mask.cpp +++ b/externals/coda-oss/modules/c++/polygon/unittests/test_polygon_mask.cpp @@ -29,8 +29,6 @@ #include #include -namespace -{ TEST_CASE(testMarkAllTrue) { const polygon::PolygonMask mask(polygon::PolygonMask::MARK_ALL_TRUE, @@ -94,15 +92,9 @@ TEST_CASE(testWithPoints) // Each point should match between the two masks for (size_t row = 0, idx = 0; row < dims.row; ++row) { - std::ostringstream ostr; - ostr << "row = " << row; - for (size_t col = 0; col < dims.col; ++col, ++idx) { - ostr << ", col = " << col; - - TEST_ASSERT_EQ_MSG(ostr.str(), - maskArray[idx], mask.isInPolygon(row, col)); + TEST_ASSERT_EQ(maskArray[idx], mask.isInPolygon(row, col)); } } } @@ -130,15 +122,9 @@ TEST_CASE(testWithMask) // Each point should match between the two masks for (size_t row = 0, idx = 0; row < dims.row; ++row) { - std::ostringstream ostr; - ostr << "row = " << row; - for (size_t col = 0; col < dims.col; ++col, ++idx) { - ostr << ", col = " << col; - - TEST_ASSERT_EQ_MSG(ostr.str(), - maskArray[idx], mask.isInPolygon(row, col)); + TEST_ASSERT_EQ(maskArray[idx], mask.isInPolygon(row, col)); } } } @@ -282,10 +268,8 @@ TEST_CASE(testWithNarrowPassthrough) TEST_ASSERT_TRUE(mask.getRange(4).empty()); TEST_ASSERT_TRUE(mask.getRange(5).empty()); } -} -int main(int /*argc*/, char** /*argv*/) -{ +TEST_MAIN( TEST_CHECK(testMarkAllTrue); TEST_CHECK(testMarkAllFalse); TEST_CHECK(testWithPoints); @@ -295,5 +279,4 @@ int main(int /*argc*/, char** /*argv*/) TEST_CHECK(testWithPartialCutBotomLeft); TEST_CHECK(testWithPartialCutTopRight); TEST_CHECK(testWithNarrowPassthrough); - return 0; -} +) diff --git a/externals/coda-oss/modules/c++/re/include/re/Regex.h b/externals/coda-oss/modules/c++/re/include/re/Regex.h index 72deffae8..5a6234b4d 100644 --- a/externals/coda-oss/modules/c++/re/include/re/Regex.h +++ b/externals/coda-oss/modules/c++/re/include/re/Regex.h @@ -26,7 +26,11 @@ #include #include +#include "config/Exports.h" + +#if !defined(RE_ENABLE_STD_REGEX) #include +#endif #ifdef RE_ENABLE_STD_REGEX #include @@ -54,7 +58,7 @@ typedef std::vector RegexMatch; * documentation regarding the underlying PCRE library, especially for flag * information, see http://www.pcre.org. */ -class Regex +class CODA_OSS_API Regex { public: /*! diff --git a/externals/coda-oss/modules/c++/re/unittests/test_regex.cpp b/externals/coda-oss/modules/c++/re/unittests/test_regex.cpp index 01977988b..5f24d36ce 100644 --- a/externals/coda-oss/modules/c++/re/unittests/test_regex.cpp +++ b/externals/coda-oss/modules/c++/re/unittests/test_regex.cpp @@ -495,8 +495,7 @@ TEST_CASE(testHttpResponse) TEST_ASSERT_EQ(p.getContentLength(), "96"); } -int main(int, char**) -{ +TEST_MAIN( TEST_CHECK(testCompile); TEST_CHECK(testMatches); TEST_CHECK(testMatchOptional); @@ -509,5 +508,4 @@ int main(int, char**) TEST_CHECK(testSub); TEST_CHECK(testSplit); TEST_CHECK(testHttpResponse); - return 0; -} + ) diff --git a/externals/coda-oss/modules/c++/sio.lite/include/sio/lite/FileReader.h b/externals/coda-oss/modules/c++/sio.lite/include/sio/lite/FileReader.h index 8fa513334..b94fbc1ae 100644 --- a/externals/coda-oss/modules/c++/sio.lite/include/sio/lite/FileReader.h +++ b/externals/coda-oss/modules/c++/sio.lite/include/sio/lite/FileReader.h @@ -19,129 +19,10 @@ * see . * */ -#ifndef __SIO_LITE_FILE_READER_H__ -#define __SIO_LITE_FILE_READER_H__ +#ifndef CODA_OSS_sio_lite_FileReader_h_INCLUDED_ +#define CODA_OSS_sio_lite_FileReader_h_INCLUDED_ +#pragma once -#include -#include -#include -#include "sio/lite/InvalidHeaderException.h" -#include "sio/lite/StreamReader.h" - -namespace sio -{ -namespace lite -{ - - -/** - * \class FileReader - * \brief Seekable version of StreamReader - * - * This class takes advantage of our Seekable interface, in addition - * to piggybacking off of the StreamReader. This clears up the situation - * with Seekable vs Non-Seekable SIO streams. If its a pure stream, use - * the StreamReader (e.g., data coming in from a socket). If its really a file - * use the FileReader in conjunction with a FileInputStream. - * - * To make this safer, only supports the FileInputStream and std::string - * args for now: - * - \code - - FileReader reader("/path/to/file.sio"); - - FileHeader* fhdr = reader->getHeader(); - int nl = fhdr->getNumLines(); - int ne = fhdr->getNumElements(); - int es = fhdr->getElementSize(); - int et = fhdr->getElementType(); - - // Read a double element from the user data - std::vector& ud = fhdr->getUserData("userDefinedDouble"); - - // Cast address from sys::byte* -> double*, and deref: - double d = fhdr->isDifferentByteOrdering() ? - sys::byteSwap(*(double*)&ud[0]) : *(double*)&ud[0]; - - // Read in an amplitude single precision float image - // all at once and byte swap - assert( es == sizeof(float) ); - long total( (long)nl * (long)ne ); - std::vector v(total); - - // Slurp file into memory - reader->read((sys::byte*)&v[0], total); - - // Swap data if necessary - if (fhdr->isDifferentByteOrdering()) - sys::byteSwap((sys:byte*)&v[0], sizeof(float), total); - - \endcode - */ - -class FileReader : public StreamReader, public io::Seekable -{ - - -public: - - /** Constructor */ - FileReader() : StreamReader() {} - - /** Destructor */ - ~FileReader() - { - } - - FileReader(const std::string& file) : - StreamReader(new io::FileInputStream(file), true) - { - } - - - /** Construct from stream */ - FileReader(io::FileInputStream* is, bool adopt = false) : - StreamReader(is, adopt) - { - } - - /*! - * Overloaded seek, only works if this is a FileInputStream. - * Reports position relative to file header if Whence == - * io::Seekable::START. Otherwise, works as a normal FileInputStream. - * In a typical - * header with no UD (i.e., headerLength = 20), seek - * with offset 0 to get to the 20th byte: - - \code - - sio.seek(0, io::Seekable::START); - sio.read(buf, n); - assert( sio.tell() == n ); - - \endcode - * - * For simplicity, the final position is reported in the return value relative - * to header start (always). This is done by calling tell(). - */ - sys::Off_T seek( sys::Off_T offset, Whence whence ); - - /*! - * Overloaded method, only works if this is a FileInputStream. - * Reports position relative to file header. In a typical - * header with no UD (i.e., headerLength = 20), this will - * yield 0 as a return value. - * - */ - sys::Off_T tell(); - - - void killStream(); -protected: -}; -} -} - -#endif +#include "sio/lite/SioFileReader.h" +#endif // CODA_OSS_sio_lite_FileReader_h_INCLUDED_ diff --git a/externals/coda-oss/modules/c++/sio.lite/include/sio/lite/FileWriter.h b/externals/coda-oss/modules/c++/sio.lite/include/sio/lite/FileWriter.h index a34c73684..483169ef9 100644 --- a/externals/coda-oss/modules/c++/sio.lite/include/sio/lite/FileWriter.h +++ b/externals/coda-oss/modules/c++/sio.lite/include/sio/lite/FileWriter.h @@ -21,176 +21,8 @@ */ #ifndef CODA_OSS_sio_lite_FileWriter_h_INCLUDED_ #define CODA_OSS_sio_lite_FileWriter_h_INCLUDED_ +#pragma once -#include -#include +#include "sio/lite/SioFileWriter.h" -#include -#include -#include -#include -#include - -#include "sio/lite/InvalidHeaderException.h" -#include "sio/lite/FileHeader.h" - - -namespace sio -{ -namespace lite -{ -/*! - * \class FileWriter - * \brief (Deprecated) class to write an SIO file - * - * This (deprecated) class will help to write out an SIO file. It is almost never necessary - * since the FileHeader.to() method can be used to start a header, and then the OutputStream. - * may be accessed directly. Additionally, the writeSIO() routine provides - * simpler functionality - */ -struct FileWriter -{ - FileWriter(const std::string& outputFile) : mFileName(outputFile), mAdopt(true) - { - mStream.reset(new io::FileOutputStream(mFileName)); - } - - FileWriter(const char* outputFile) : mFileName(outputFile), mAdopt(true) - { - mStream.reset(new io::FileOutputStream(mFileName)); - } - - //! The input stream will get freed by the Writer if adopt is set to true - FileWriter(io::OutputStream* stream, bool adopt = true) : mAdopt(adopt) - { - mStream.reset(stream); - } - - // need copy for Python binding w/SWIG - //FileWriter(const FileWriter&) = default; - //FileWriter& operator=(const FileWriter&) = default; - //FileWriter(FileWriter&&) = default; - //FileWriter& operator=(FileWriter&&) = default; - - virtual ~FileWriter() - { - //if we aren't adopting it, release it - if (!mAdopt) mStream.release(); - } - - /*! - * Writes the SIO given the FileHeader and InputStreams. - */ - void write(FileHeader* header, std::vector bandStreams); - - /*! - * Writes a version 1 SIO given the basic file header contents and a - * vector of InputStreams - */ - void write(int numLines, int numElements, int elementSize, - int elementType, std::vector bandStreams); - - /*! - * Writes the SIO given the FileHeader and a buffer of raw data in - * band-sequential format. - */ - void write(FileHeader* header, const void* data, int numBands = 1); - - /*! - * Writes a version 1 SIO given the basic file header contents and a buffer - * of raw data in band-sequential format. - */ - void write(int numLines, int numElements, int elementSize, - int elementType, const void* data, int numBands = 1); - -protected: - std::string mFileName; - mem::auto_ptr mStream; - bool mAdopt; -}; - -/** Automatic data, this is not explicitly valid, dont use this in an FileHeader */ -enum { AUTO = -1 }; - -/*! - * Utility routine to write an image of type T into an SIO file format. Supported - * types are complex, float, double, byte unsigned and N-byte unsigned. - * - * Sizes are deduced from the template type automatically (complex = 8, - * double = 8, float = 4, and byte = 1, unless the es option is given, which - * should typically only be done for N-byte images (like RGB images). - * - * Types are deduced from the template arguments as well, via the size operator - * (not explicitly). This can be a good thing, but in the case of complex - * vs. double for example, the element type is treated as COMPLEX_FLOAT. This is - * clearly not the intent for a double, so an option element type can be given - * explicitly. - * - * If this function fails to validate the input, it may throw an exception. - * If it does not, the SIO file is presumed to be correct. - * - * \param image Data to write (this really doesnt have to be an image at all) - * \param rows The number of rows in the data (nl in sio-speak) - * \param cols The number of cols in the data (ne in sio-speak) - * \param et The element type, which defaults to AUTO, in which this is guessed - * \param es The element size (in bytes), which defaults to AUTO, in which case - * it is guessed - * - * - */ -template void writeSIO(const T* image, size_t rows, size_t cols, - const std::string& imageFile, - int et = AUTO, int es = AUTO) -{ - - if (es == AUTO) - { - es = sizeof(T); - } - - if (et == -1) - { - switch (es) - { - case 8: - et = FileHeader::COMPLEX_FLOAT; - break; - - case 4: - et = FileHeader::FLOAT; - break; - - case 3: - et = FileHeader::N_BYTE_UNSIGNED; - break; - - case 1: - et = FileHeader::UNSIGNED; - break; - default: - throw except::Exception(Ctxt(FmtX("Unexpected es: %d", es))); - } - } - - io::FileOutputStream imageStream(imageFile); - - FileHeader fhdr(static_cast(rows), static_cast(cols), es, et); - fhdr.to(1, imageStream); - - imageStream.write(reinterpret_cast(image), - rows * cols * es); - - imageStream.close(); -} -template -void writeSIO(const T* image, const types::RowCol& dims, const sys::filesystem::path& imageFile, - int et = AUTO, int es = AUTO) -{ - writeSIO(image, dims.row, dims.col, imageFile.string(), et, es); -} - - -} -} - -#endif // CODA_OSS_sio_lite_FileWriter_h_INCLUDED_ +#endif // CODA_OSS_sio_lite_FileWriter_h_INCLUDED_ diff --git a/externals/coda-oss/modules/c++/sio.lite/include/sio/lite/SioFileReader.h b/externals/coda-oss/modules/c++/sio.lite/include/sio/lite/SioFileReader.h new file mode 100644 index 000000000..8fa513334 --- /dev/null +++ b/externals/coda-oss/modules/c++/sio.lite/include/sio/lite/SioFileReader.h @@ -0,0 +1,147 @@ +/* ========================================================================= + * This file is part of sio.lite-c++ + * ========================================================================= + * + * (C) Copyright 2004 - 2014, MDA Information Systems LLC + * + * sio.lite-c++ is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this program; If not, + * see . + * + */ +#ifndef __SIO_LITE_FILE_READER_H__ +#define __SIO_LITE_FILE_READER_H__ + +#include +#include +#include +#include "sio/lite/InvalidHeaderException.h" +#include "sio/lite/StreamReader.h" + +namespace sio +{ +namespace lite +{ + + +/** + * \class FileReader + * \brief Seekable version of StreamReader + * + * This class takes advantage of our Seekable interface, in addition + * to piggybacking off of the StreamReader. This clears up the situation + * with Seekable vs Non-Seekable SIO streams. If its a pure stream, use + * the StreamReader (e.g., data coming in from a socket). If its really a file + * use the FileReader in conjunction with a FileInputStream. + * + * To make this safer, only supports the FileInputStream and std::string + * args for now: + * + \code + + FileReader reader("/path/to/file.sio"); + + FileHeader* fhdr = reader->getHeader(); + int nl = fhdr->getNumLines(); + int ne = fhdr->getNumElements(); + int es = fhdr->getElementSize(); + int et = fhdr->getElementType(); + + // Read a double element from the user data + std::vector& ud = fhdr->getUserData("userDefinedDouble"); + + // Cast address from sys::byte* -> double*, and deref: + double d = fhdr->isDifferentByteOrdering() ? + sys::byteSwap(*(double*)&ud[0]) : *(double*)&ud[0]; + + // Read in an amplitude single precision float image + // all at once and byte swap + assert( es == sizeof(float) ); + long total( (long)nl * (long)ne ); + std::vector v(total); + + // Slurp file into memory + reader->read((sys::byte*)&v[0], total); + + // Swap data if necessary + if (fhdr->isDifferentByteOrdering()) + sys::byteSwap((sys:byte*)&v[0], sizeof(float), total); + + \endcode + */ + +class FileReader : public StreamReader, public io::Seekable +{ + + +public: + + /** Constructor */ + FileReader() : StreamReader() {} + + /** Destructor */ + ~FileReader() + { + } + + FileReader(const std::string& file) : + StreamReader(new io::FileInputStream(file), true) + { + } + + + /** Construct from stream */ + FileReader(io::FileInputStream* is, bool adopt = false) : + StreamReader(is, adopt) + { + } + + /*! + * Overloaded seek, only works if this is a FileInputStream. + * Reports position relative to file header if Whence == + * io::Seekable::START. Otherwise, works as a normal FileInputStream. + * In a typical + * header with no UD (i.e., headerLength = 20), seek + * with offset 0 to get to the 20th byte: + + \code + + sio.seek(0, io::Seekable::START); + sio.read(buf, n); + assert( sio.tell() == n ); + + \endcode + * + * For simplicity, the final position is reported in the return value relative + * to header start (always). This is done by calling tell(). + */ + sys::Off_T seek( sys::Off_T offset, Whence whence ); + + /*! + * Overloaded method, only works if this is a FileInputStream. + * Reports position relative to file header. In a typical + * header with no UD (i.e., headerLength = 20), this will + * yield 0 as a return value. + * + */ + sys::Off_T tell(); + + + void killStream(); +protected: +}; +} +} + +#endif + diff --git a/externals/coda-oss/modules/c++/sio.lite/include/sio/lite/SioFileWriter.h b/externals/coda-oss/modules/c++/sio.lite/include/sio/lite/SioFileWriter.h new file mode 100644 index 000000000..3b8ec4611 --- /dev/null +++ b/externals/coda-oss/modules/c++/sio.lite/include/sio/lite/SioFileWriter.h @@ -0,0 +1,196 @@ +/* ========================================================================= + * This file is part of sio.lite-c++ + * ========================================================================= + * + * (C) Copyright 2004 - 2014, MDA Information Systems LLC + * + * sio.lite-c++ is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this program; If not, + * see . + * + */ +#ifndef CODA_OSS_sio_lite_SioFileWriter_h_INCLUDED_ +#define CODA_OSS_sio_lite_SioFileWriter_h_INCLUDED_ + +#include +#include + +#include +#include +#include +#include +#include + +#include "sio/lite/InvalidHeaderException.h" +#include "sio/lite/FileHeader.h" + + +namespace sio +{ +namespace lite +{ +/*! + * \class FileWriter + * \brief (Deprecated) class to write an SIO file + * + * This (deprecated) class will help to write out an SIO file. It is almost never necessary + * since the FileHeader.to() method can be used to start a header, and then the OutputStream. + * may be accessed directly. Additionally, the writeSIO() routine provides + * simpler functionality + */ +struct FileWriter +{ + FileWriter(const std::string& outputFile) : mFileName(outputFile), mAdopt(true) + { + mStream.reset(new io::FileOutputStream(mFileName)); + } + + FileWriter(const char* outputFile) : mFileName(outputFile), mAdopt(true) + { + mStream.reset(new io::FileOutputStream(mFileName)); + } + + //! The input stream will get freed by the Writer if adopt is set to true + FileWriter(io::OutputStream* stream, bool adopt = true) : mAdopt(adopt) + { + mStream.reset(stream); + } + + // need copy for Python binding w/SWIG + //FileWriter(const FileWriter&) = default; + //FileWriter& operator=(const FileWriter&) = default; + //FileWriter(FileWriter&&) = default; + //FileWriter& operator=(FileWriter&&) = default; + + virtual ~FileWriter() + { + //if we aren't adopting it, release it + if (!mAdopt) mStream.release(); + } + + /*! + * Writes the SIO given the FileHeader and InputStreams. + */ + void write(FileHeader* header, std::vector bandStreams); + + /*! + * Writes a version 1 SIO given the basic file header contents and a + * vector of InputStreams + */ + void write(int numLines, int numElements, int elementSize, + int elementType, std::vector bandStreams); + + /*! + * Writes the SIO given the FileHeader and a buffer of raw data in + * band-sequential format. + */ + void write(FileHeader* header, const void* data, int numBands = 1); + + /*! + * Writes a version 1 SIO given the basic file header contents and a buffer + * of raw data in band-sequential format. + */ + void write(int numLines, int numElements, int elementSize, + int elementType, const void* data, int numBands = 1); + +protected: + std::string mFileName; + mem::auto_ptr mStream; + bool mAdopt; +}; + +/** Automatic data, this is not explicitly valid, dont use this in an FileHeader */ +enum { AUTO = -1 }; + +/*! + * Utility routine to write an image of type T into an SIO file format. Supported + * types are complex, float, double, byte unsigned and N-byte unsigned. + * + * Sizes are deduced from the template type automatically (complex = 8, + * double = 8, float = 4, and byte = 1, unless the es option is given, which + * should typically only be done for N-byte images (like RGB images). + * + * Types are deduced from the template arguments as well, via the size operator + * (not explicitly). This can be a good thing, but in the case of complex + * vs. double for example, the element type is treated as COMPLEX_FLOAT. This is + * clearly not the intent for a double, so an option element type can be given + * explicitly. + * + * If this function fails to validate the input, it may throw an exception. + * If it does not, the SIO file is presumed to be correct. + * + * \param image Data to write (this really doesnt have to be an image at all) + * \param rows The number of rows in the data (nl in sio-speak) + * \param cols The number of cols in the data (ne in sio-speak) + * \param et The element type, which defaults to AUTO, in which this is guessed + * \param es The element size (in bytes), which defaults to AUTO, in which case + * it is guessed + * + * + */ +template void writeSIO(const T* image, size_t rows, size_t cols, + const std::string& imageFile, + int et = AUTO, int es = AUTO) +{ + + if (es == AUTO) + { + es = sizeof(T); + } + + if (et == -1) + { + switch (es) + { + case 8: + et = FileHeader::COMPLEX_FLOAT; + break; + + case 4: + et = FileHeader::FLOAT; + break; + + case 3: + et = FileHeader::N_BYTE_UNSIGNED; + break; + + case 1: + et = FileHeader::UNSIGNED; + break; + default: + throw except::Exception(Ctxt(FmtX("Unexpected es: %d", es))); + } + } + + io::FileOutputStream imageStream(imageFile); + + FileHeader fhdr(static_cast(rows), static_cast(cols), es, et); + fhdr.to(1, imageStream); + + imageStream.write(reinterpret_cast(image), + rows * cols * es); + + imageStream.close(); +} +template +void writeSIO(const T* image, const types::RowCol& dims, const sys::filesystem::path& imageFile, + int et = AUTO, int es = AUTO) +{ + writeSIO(image, dims.row, dims.col, imageFile.string(), et, es); +} + + +} +} + +#endif // CODA_OSS_sio_lite_SioFileWriter_h_INCLUDED_ diff --git a/externals/coda-oss/modules/c++/sio.lite/source/FileReader.cpp b/externals/coda-oss/modules/c++/sio.lite/source/SioFileReader.cpp similarity index 100% rename from externals/coda-oss/modules/c++/sio.lite/source/FileReader.cpp rename to externals/coda-oss/modules/c++/sio.lite/source/SioFileReader.cpp diff --git a/externals/coda-oss/modules/c++/sio.lite/source/FileWriter.cpp b/externals/coda-oss/modules/c++/sio.lite/source/SioFileWriter.cpp similarity index 100% rename from externals/coda-oss/modules/c++/sio.lite/source/FileWriter.cpp rename to externals/coda-oss/modules/c++/sio.lite/source/SioFileWriter.cpp diff --git a/externals/coda-oss/modules/c++/sio.lite/wscript b/externals/coda-oss/modules/c++/sio.lite/wscript index 22b346518..5a2a1d10d 100644 --- a/externals/coda-oss/modules/c++/sio.lite/wscript +++ b/externals/coda-oss/modules/c++/sio.lite/wscript @@ -1,5 +1,4 @@ NAME = 'sio.lite' -MAINTAINER = 'adam.sylvester@mdaus.com' VERSION = '1.0' MODULE_DEPS = 'io types' diff --git a/externals/coda-oss/modules/c++/str/include/str/Convert.h b/externals/coda-oss/modules/c++/str/include/str/Convert.h index a09bf2aa4..90d0c87d5 100644 --- a/externals/coda-oss/modules/c++/str/include/str/Convert.h +++ b/externals/coda-oss/modules/c++/str/include/str/Convert.h @@ -38,6 +38,7 @@ #include "config/Exports.h" #include "coda_oss/string.h" #include "coda_oss/optional.h" +#include "coda_oss/cstddef.h" #include "import/except.h" namespace str @@ -65,6 +66,9 @@ CODA_OSS_API std::string toString(const uint8_t& value); template <> CODA_OSS_API std::string toString(const int8_t& value); +template <> +CODA_OSS_API std::string toString(const coda_oss::byte& value); + template <> inline std::string toString(const std::nullptr_t&) { @@ -119,9 +123,9 @@ T toType(const std::string& s) } template <> -bool toType(const std::string& s); +CODA_OSS_API bool toType(const std::string& s); template <> -std::string toType(const std::string& s); +CODA_OSS_API std::string toType(const std::string& s); /** * strtoll wrapper for msvc compatibility. diff --git a/externals/coda-oss/modules/c++/str/include/str/Format.h b/externals/coda-oss/modules/c++/str/include/str/Format.h index 7a0a2a78b..b6a6be426 100644 --- a/externals/coda-oss/modules/c++/str/include/str/Format.h +++ b/externals/coda-oss/modules/c++/str/include/str/Format.h @@ -27,6 +27,8 @@ #include #include +#include "config/Exports.h" + namespace str { @@ -34,11 +36,10 @@ namespace str * \param format The format * \param ... Any printf like thing */ -std::string format(const char *format, ...); +CODA_OSS_API std::string format(const char* format, ...); -class Format +struct CODA_OSS_API Format final { -public: Format(const char* format, ...); operator std::string() const diff --git a/externals/coda-oss/modules/c++/str/source/Convert.cpp b/externals/coda-oss/modules/c++/str/source/Convert.cpp index fcf1b8d6a..129b089a2 100644 --- a/externals/coda-oss/modules/c++/str/source/Convert.cpp +++ b/externals/coda-oss/modules/c++/str/source/Convert.cpp @@ -50,6 +50,11 @@ template<> std::string str::toString(const int8_t& value) return str::toString(static_cast(value)); } +template<> std::string str::toString(const coda_oss::byte& value) +{ + return str::toString(static_cast(value)); +} + template<> bool str::toType(const std::string& s) { std::string ss = s; diff --git a/externals/coda-oss/modules/c++/str/unittests/test_base_convert.cpp b/externals/coda-oss/modules/c++/str/unittests/test_base_convert.cpp index 6f528dfe1..c463c4fb2 100644 --- a/externals/coda-oss/modules/c++/str/unittests/test_base_convert.cpp +++ b/externals/coda-oss/modules/c++/str/unittests/test_base_convert.cpp @@ -226,8 +226,6 @@ TEST_CASE(test_string_to_u8string_iso8859_1) template static void test_change_case_(const std::string& testName, const TString& lower, const TString& upper) { - (void)testName; - auto s = upper; str::lower(s); TEST_ASSERT(s == lower); @@ -246,7 +244,7 @@ TEST_CASE(test_change_case) { const std::string ABC = "ABC"; const std::string abc = "abc"; - test_change_case_("test_change_case", abc, ABC); + test_change_case_(testName, abc, ABC); //const std::wstring ABC_w = L"ABC"; //const std::wstring abc_w = L"abc"; @@ -266,16 +264,16 @@ TEST_CASE(test_change_case) // https://en.wikipedia.org/wiki/%C3%89#Character_mappings static const str::EncodedString& classificationText_utf_8() { - static const str::EncodedString retval(str::cast("NON CLASSIFI\xc3\x89 / UNCLASSIFIED")); // UTF-8 "NON CLASSIFIÉ / UNCLASSIFIED" + static const str::EncodedString retval(str::cast("A\xc3\x89IOU")); // UTF-8 "AÉIOU" return retval; } static const str::EncodedString& classificationText_iso8859_1() { - static const str::EncodedString retval(str::cast("NON CLASSIFI\xc9 / UNCLASSIFIED")); // ISO8859-1 "NON CLASSIFIÉ / UNCLASSIFIED" + static const str::EncodedString retval(str::cast("A\xc9IOU")); // ISO8859-1 "AÉIOU" return retval; } // UTF-16 on Windows, UTF-32 on Linux -static const wchar_t* classificationText_wide_() { return L"NON CLASSIFI\xc9 / UNCLASSIFIED"; } // UTF-8 "NON CLASSIFIÉ / UNCLASSIFIED" +static const wchar_t* classificationText_wide_() { return L"A\xc9IOU"; } // UTF-8 "AÉIOU" static str::EncodedString classificationText_wide() { return str::EncodedString(classificationText_wide_()); } static std::string classificationText_platform() { return sys::Platform == sys::PlatformType::Linux ? classificationText_utf_8().native() : classificationText_iso8859_1().native(); } @@ -346,10 +344,17 @@ static void test_EncodedStringView_(const std::string& testName, TEST_ASSERT_EQ(iso8859_1_view, classificationText_utf_8()); TEST_ASSERT(iso8859_1_view.u8string() == utf_8_view.u8string()); - std::string utf8; - TEST_ASSERT_EQ(utf_8_view.toUtf8(utf8), str::EncodedString::details::string(classificationText_utf_8())); - utf8.clear(); - TEST_ASSERT_EQ(iso8859_1_view.toUtf8(utf8), str::EncodedString::details::string(classificationText_utf_8())); + const auto expected = str::EncodedString::details::string(classificationText_utf_8()); + { + std::string buf; + const auto& actual = utf_8_view.toUtf8(buf); + TEST_ASSERT_EQ(actual, expected); + } + { + std::string buf; + const auto& actual = iso8859_1_view.toUtf8(buf); + TEST_ASSERT_EQ(actual, expected); + } } TEST_CASE(test_EncodedStringView) { @@ -360,27 +365,27 @@ TEST_CASE(test_EncodedStringView) { auto utf_8_view(classificationText_utf_8().view()); auto iso8859_1_view(classificationText_iso8859_1().view()); - test_EncodedStringView_("test_EncodedStringView", utf_8_view, iso8859_1_view); + test_EncodedStringView_(testName, utf_8_view, iso8859_1_view); utf_8_view = classificationText_iso8859_1().view(); iso8859_1_view = classificationText_utf_8().view(); - test_EncodedStringView_("test_EncodedStringView", utf_8_view, iso8859_1_view); + test_EncodedStringView_(testName, utf_8_view, iso8859_1_view); } { auto utf_8_view = classificationText_utf_8().view(); auto iso8859_1_view = classificationText_iso8859_1().view(); - test_EncodedStringView_("test_EncodedStringView", utf_8_view, iso8859_1_view); + test_EncodedStringView_(testName, utf_8_view, iso8859_1_view); utf_8_view = classificationText_iso8859_1().view(); iso8859_1_view = classificationText_utf_8().view(); - test_EncodedStringView_("test_EncodedStringView", utf_8_view, iso8859_1_view); + test_EncodedStringView_(testName, utf_8_view, iso8859_1_view); } { str::EncodedStringView utf_8_view; utf_8_view = classificationText_iso8859_1().view(); str::EncodedStringView iso8859_1_view; iso8859_1_view = classificationText_utf_8().view(); - test_EncodedStringView_("test_EncodedStringView", utf_8_view, iso8859_1_view); + test_EncodedStringView_(testName, utf_8_view, iso8859_1_view); } } diff --git a/externals/coda-oss/modules/c++/sys/include/sys/AbstractOS.h b/externals/coda-oss/modules/c++/sys/include/sys/AbstractOS.h index 7a7f465cf..158bce489 100644 --- a/externals/coda-oss/modules/c++/sys/include/sys/AbstractOS.h +++ b/externals/coda-oss/modules/c++/sys/include/sys/AbstractOS.h @@ -27,6 +27,8 @@ #include #include + +#include "config/Exports.h" #include "sys/Conf.h" #include "sys/FileFinder.h" #include "sys/SystemException.h" @@ -51,7 +53,7 @@ namespace sys * The AbstractOS class defines the base for a system * independent layer of function calls. */ -struct AbstractOS +struct CODA_OSS_API AbstractOS { AbstractOS(); diff --git a/externals/coda-oss/modules/c++/sys/include/sys/Backtrace.h b/externals/coda-oss/modules/c++/sys/include/sys/Backtrace.h index 056e740bf..a13b22069 100644 --- a/externals/coda-oss/modules/c++/sys/include/sys/Backtrace.h +++ b/externals/coda-oss/modules/c++/sys/include/sys/Backtrace.h @@ -28,6 +28,8 @@ #include #include +#include "config/Exports.h" + #include "except/Backtrace.h" #define CODA_OSS_sys_Backtrace CODA_OSS_except_Backtrace @@ -46,8 +48,8 @@ namespace sys * return with an error message instead of a backtrace if the current * configuration is unsupported. */ -std::string getBacktrace(bool* pSupported = nullptr); -std::string getBacktrace(bool& supported, std::vector& frames); +CODA_OSS_API std::string getBacktrace(bool* pSupported = nullptr); +CODA_OSS_API std::string getBacktrace(bool& supported, std::vector& frames); } #endif // CODA_OSS_sys_Backtrace_h_INCLUDED_ diff --git a/externals/coda-oss/modules/c++/sys/include/sys/ConditionVarInterface.h b/externals/coda-oss/modules/c++/sys/include/sys/ConditionVarInterface.h index aa89205d8..0c16cc63c 100644 --- a/externals/coda-oss/modules/c++/sys/include/sys/ConditionVarInterface.h +++ b/externals/coda-oss/modules/c++/sys/include/sys/ConditionVarInterface.h @@ -25,6 +25,9 @@ #define __SYS_CONDITION_VAR_INTERFACE_H__ #include + +#include "config/Exports.h" + #include "sys/SystemException.h" #include "sys/Mutex.h" namespace sys @@ -36,7 +39,7 @@ namespace sys * Provide the API for condition variables in this thread wrapper */ -struct ConditionVarInterface +struct CODA_OSS_API ConditionVarInterface { /*! * This constructor means that you are creating the lock diff --git a/externals/coda-oss/modules/c++/sys/include/sys/ConditionVarWin32.h b/externals/coda-oss/modules/c++/sys/include/sys/ConditionVarWin32.h index 1e9b959ef..3847910ed 100644 --- a/externals/coda-oss/modules/c++/sys/include/sys/ConditionVarWin32.h +++ b/externals/coda-oss/modules/c++/sys/include/sys/ConditionVarWin32.h @@ -24,6 +24,8 @@ #ifndef __SYS_WIN32_CONDITION_VARIABLE_H__ #define __SYS_WIN32_CONDITION_VARIABLE_H__ +#include "config/Exports.h" + #if defined(WIN32) || defined(_WIN32) #if !defined(USE_NSPR_THREADS) @@ -37,7 +39,7 @@ namespace sys /// "Strategies for Implementing POSIX Condition Variables on Win32" /// article at www.cse.wustl.edu/~schmidt/win32-cv-1.html. /// This is the ACE framework implementation. -class ConditionVarDataWin32 +class CODA_OSS_API ConditionVarDataWin32 { public: ConditionVarDataWin32(); @@ -74,7 +76,7 @@ class ConditionVarDataWin32 bool mWasBroadcast; }; -struct ConditionVarWin32 final : public ConditionVarInterface +struct CODA_OSS_API ConditionVarWin32 final : public ConditionVarInterface { ConditionVarWin32(); diff --git a/externals/coda-oss/modules/c++/sys/include/sys/Conf.h b/externals/coda-oss/modules/c++/sys/include/sys/Conf.h index b093cdf24..5537b1b32 100644 --- a/externals/coda-oss/modules/c++/sys/include/sys/Conf.h +++ b/externals/coda-oss/modules/c++/sys/include/sys/Conf.h @@ -201,7 +201,7 @@ namespace sys * On Intel systems, we are usually small-endian, and on * RISC architectures we are big-endian. */ - bool isBigEndianSystem(); + bool CODA_OSS_API isBigEndianSystem(); /*! diff --git a/externals/coda-oss/modules/c++/sys/include/sys/Dbg.h b/externals/coda-oss/modules/c++/sys/include/sys/Dbg.h index 127deadee..3a1d1ea77 100644 --- a/externals/coda-oss/modules/c++/sys/include/sys/Dbg.h +++ b/externals/coda-oss/modules/c++/sys/include/sys/Dbg.h @@ -26,6 +26,8 @@ #define CODA_OSS_sys_Dbg_h_INCLUDED_ #pragma once +#include "config/Exports.h" + // A "debug" build has debugging symbols, detailed call stacks, minimal optimization, STL validation, etc. // A "release" build is likely to "run fast" and be "shipped;" it might lack much of what is in a "debug" build. #ifndef CODA_OSS_DEBUG @@ -110,7 +112,7 @@ namespace sys // build-time for Dbg.cpp; may (although shouldn't) be different than above. // C++ says little about debug/release/optimize/etc. (there's NDEBUG inherited from C); // but mixing is likely to cause all kinds of problems. - extern bool debug_build(); + CODA_OSS_API bool debug_build(); inline bool release_build() { return !debug_build(); @@ -186,7 +188,7 @@ namespace sys * \param format * \param ... Put in any format value here */ -void dbgPrintf(const char *format, ...); +CODA_OSS_API void dbgPrintf(const char *format, ...); /*! * Prints to DEBUG_STREAM and kills the program diff --git a/externals/coda-oss/modules/c++/sys/include/sys/Err.h b/externals/coda-oss/modules/c++/sys/include/sys/Err.h index 81dcf649d..161c27618 100644 --- a/externals/coda-oss/modules/c++/sys/include/sys/Err.h +++ b/externals/coda-oss/modules/c++/sys/include/sys/Err.h @@ -38,6 +38,8 @@ #include "sys/Conf.h" #include +#include "config/Exports.h" + namespace sys { //! The default value for the Err object. Maps to errno or GetLastError() @@ -54,7 +56,7 @@ constexpr static int __last_err__ = 0; * */ -struct Err +struct CODA_OSS_API Err { /*! * Copy constructor diff --git a/externals/coda-oss/modules/c++/sys/include/sys/LocalDateTime.h b/externals/coda-oss/modules/c++/sys/include/sys/LocalDateTime.h index 212de18eb..5f36e3c58 100644 --- a/externals/coda-oss/modules/c++/sys/include/sys/LocalDateTime.h +++ b/externals/coda-oss/modules/c++/sys/include/sys/LocalDateTime.h @@ -50,8 +50,6 @@ class CODA_OSS_API LocalDateTime : public DateTime virtual void getTime(time_t numSecondsSinceEpoch, tm& t) const; public: - static const char DEFAULT_DATETIME_FORMAT[]; - /*! * Construct as current date and time (localtime). */ @@ -76,8 +74,8 @@ class CODA_OSS_API LocalDateTime : public DateTime /*! * Construct with string/format. */ - LocalDateTime(const std::string& time, - const std::string& format = DEFAULT_DATETIME_FORMAT); + LocalDateTime(const std::string& time); + LocalDateTime(const std::string& time, const std::string& format); //! Return the Daylight Savings Time flag (true = on, false = off) bool getDST() const { return mDST == 1; } diff --git a/externals/coda-oss/modules/c++/sys/include/sys/MutexInterface.h b/externals/coda-oss/modules/c++/sys/include/sys/MutexInterface.h index 92ec32b4c..490d20e0d 100644 --- a/externals/coda-oss/modules/c++/sys/include/sys/MutexInterface.h +++ b/externals/coda-oss/modules/c++/sys/include/sys/MutexInterface.h @@ -26,6 +26,8 @@ #include + +#include "config/Exports.h" #include "sys/SystemException.h" #include "sys/Dbg.h" @@ -39,7 +41,7 @@ namespace sys * This class defines the interface for any mutex in any package that * is wrapped herein */ -class MutexInterface +class CODA_OSS_API MutexInterface { public: //! Constructor diff --git a/externals/coda-oss/modules/c++/sys/include/sys/MutexWin32.h b/externals/coda-oss/modules/c++/sys/include/sys/MutexWin32.h index 2112236f7..cbea97380 100644 --- a/externals/coda-oss/modules/c++/sys/include/sys/MutexWin32.h +++ b/externals/coda-oss/modules/c++/sys/include/sys/MutexWin32.h @@ -24,6 +24,8 @@ #ifndef __SYS_MUTEX_WIN32_H__ #define __SYS_MUTEX_WIN32_H__ +#include "config/Exports.h" + #if defined(WIN32) || defined(_WIN32) #if !defined(USE_NSPR_THREADS) @@ -31,7 +33,7 @@ namespace sys { -class MutexWin32 : public MutexInterface +class CODA_OSS_API MutexWin32 : public MutexInterface { public: //! \todo Add string name option diff --git a/externals/coda-oss/modules/c++/sys/include/sys/OSWin32.h b/externals/coda-oss/modules/c++/sys/include/sys/OSWin32.h index 5afd2d2dc..3e9c53d91 100644 --- a/externals/coda-oss/modules/c++/sys/include/sys/OSWin32.h +++ b/externals/coda-oss/modules/c++/sys/include/sys/OSWin32.h @@ -46,7 +46,7 @@ namespace sys * This class is the abstraction layer as defined for * the windows operating system. */ -struct OSWin32 final : public AbstractOS +struct CODA_OSS_API OSWin32 final : public AbstractOS { OSWin32() = default; virtual ~OSWin32() = default; diff --git a/externals/coda-oss/modules/c++/sys/include/sys/Path.h b/externals/coda-oss/modules/c++/sys/include/sys/Path.h index e944bacd9..939ad9f6c 100644 --- a/externals/coda-oss/modules/c++/sys/include/sys/Path.h +++ b/externals/coda-oss/modules/c++/sys/include/sys/Path.h @@ -28,6 +28,8 @@ #include #include +#include "config/Exports.h" + #include #include "sys/OS.h" @@ -43,7 +45,7 @@ namespace sys { -class Path +class CODA_OSS_API Path { public: Path(); diff --git a/externals/coda-oss/modules/c++/sys/include/sys/Runnable.h b/externals/coda-oss/modules/c++/sys/include/sys/Runnable.h index 848f5441d..9c76d455a 100644 --- a/externals/coda-oss/modules/c++/sys/include/sys/Runnable.h +++ b/externals/coda-oss/modules/c++/sys/include/sys/Runnable.h @@ -24,6 +24,7 @@ #ifndef __SYS_RUNNABLE_H__ #define __SYS_RUNNABLE_H__ +#include "config/Exports.h" namespace sys { @@ -42,7 +43,7 @@ namespace sys * Design Pattern. * */ -struct Runnable +struct CODA_OSS_API Runnable { Runnable() = default; virtual ~Runnable() = default; diff --git a/externals/coda-oss/modules/c++/sys/include/sys/SemaphoreInterface.h b/externals/coda-oss/modules/c++/sys/include/sys/SemaphoreInterface.h index 41ba5933b..7d0a824e1 100644 --- a/externals/coda-oss/modules/c++/sys/include/sys/SemaphoreInterface.h +++ b/externals/coda-oss/modules/c++/sys/include/sys/SemaphoreInterface.h @@ -26,10 +26,11 @@ #include #include "sys/SystemException.h" +#include "config/Exports.h" namespace sys { -struct SemaphoreInterface +struct CODA_OSS_API SemaphoreInterface { SemaphoreInterface() = default; virtual ~SemaphoreInterface() = default; diff --git a/externals/coda-oss/modules/c++/sys/include/sys/SemaphoreWin32.h b/externals/coda-oss/modules/c++/sys/include/sys/SemaphoreWin32.h index 46cfa51f9..baad6f570 100644 --- a/externals/coda-oss/modules/c++/sys/include/sys/SemaphoreWin32.h +++ b/externals/coda-oss/modules/c++/sys/include/sys/SemaphoreWin32.h @@ -24,6 +24,8 @@ #ifndef __SYS_SEMAPHORE_WIN32_H__ #define __SYS_SEMAPHORE_WIN32_H__ +#include "config/Exports.h" + #if defined(WIN32) || defined(_WIN32) #if !defined(USE_NSPR_THREADS) @@ -34,7 +36,7 @@ namespace sys { -class SemaphoreWin32 : public SemaphoreInterface +class CODA_OSS_API SemaphoreWin32 : public SemaphoreInterface { public: SemaphoreWin32(unsigned int count = 0, size_t maxCount = std::numeric_limits::max()); diff --git a/externals/coda-oss/modules/c++/sys/include/sys/ThreadInterface.h b/externals/coda-oss/modules/c++/sys/include/sys/ThreadInterface.h index 91c02e955..70c8d622f 100644 --- a/externals/coda-oss/modules/c++/sys/include/sys/ThreadInterface.h +++ b/externals/coda-oss/modules/c++/sys/include/sys/ThreadInterface.h @@ -32,6 +32,7 @@ #include #include "sys/SystemException.h" +#include "config/Exports.h" namespace sys { @@ -70,7 +71,7 @@ namespace sys * */ -struct ThreadInterface : public Runnable +struct CODA_OSS_API ThreadInterface : public Runnable { enum { DEFAULT_LEVEL, KERNEL_LEVEL, USER_LEVEL }; enum { MINIMUM_PRIORITY, NORMAL_PRIORITY, MAXIMUM_PRIORITY }; diff --git a/externals/coda-oss/modules/c++/sys/include/sys/ThreadWin32.h b/externals/coda-oss/modules/c++/sys/include/sys/ThreadWin32.h index c4fbc68da..0b6118f32 100644 --- a/externals/coda-oss/modules/c++/sys/include/sys/ThreadWin32.h +++ b/externals/coda-oss/modules/c++/sys/include/sys/ThreadWin32.h @@ -28,6 +28,8 @@ #include +#include "config/Exports.h" + #if defined(WIN32) || defined(_WIN32) #if !defined(USE_NSPR_THREADS) @@ -69,8 +71,8 @@ namespace sys return gsl::narrow(GetCurrentThreadId()); } -struct ThreadWin32 : public ThreadInterface -{ +struct CODA_OSS_API ThreadWin32 : public ThreadInterface + { ThreadWin32(const std::string& name = "") : ThreadInterface(name) {} diff --git a/externals/coda-oss/modules/c++/sys/include/sys/UTCDateTime.h b/externals/coda-oss/modules/c++/sys/include/sys/UTCDateTime.h index e9e9f0ebc..3f58fdaed 100644 --- a/externals/coda-oss/modules/c++/sys/include/sys/UTCDateTime.h +++ b/externals/coda-oss/modules/c++/sys/include/sys/UTCDateTime.h @@ -26,6 +26,8 @@ #include #include +#include "config/Exports.h" + #include namespace sys @@ -33,7 +35,7 @@ namespace sys /*! * Representation of a UTC date/time structure. */ -class UTCDateTime : public DateTime +class CODA_OSS_API UTCDateTime : public DateTime { protected: /** @@ -45,8 +47,6 @@ class UTCDateTime : public DateTime virtual void getTime(time_t numSecondsSinceEpoch, tm& t) const; public: - static const char DEFAULT_DATETIME_FORMAT[]; - /*! * Construct as current date and time (UTC). */ @@ -72,8 +72,8 @@ class UTCDateTime : public DateTime /*! * Construct with string/format. */ - UTCDateTime(const std::string& time, - const std::string& format = DEFAULT_DATETIME_FORMAT); + UTCDateTime(const std::string& time); + UTCDateTime(const std::string& time, const std::string& format); // unhide in the base class format method using DateTime::format; diff --git a/externals/coda-oss/modules/c++/sys/include/sys/sys_filesystem.h b/externals/coda-oss/modules/c++/sys/include/sys/sys_filesystem.h index a878492ec..0cabb1cd3 100644 --- a/externals/coda-oss/modules/c++/sys/include/sys/sys_filesystem.h +++ b/externals/coda-oss/modules/c++/sys/include/sys/sys_filesystem.h @@ -45,8 +45,8 @@ namespace filesystem // not "Filesystem", make it easy to use code in other name struct path; // forward namespace details { - extern bool Equals(const path& lhs, const path& rhs) noexcept; - extern std::ostream& Ostream(std::ostream& os, const path& p); + CODA_OSS_API bool Equals(const path& lhs, const path& rhs) noexcept; + CODA_OSS_API std::ostream& Ostream(std::ostream& os, const path& p); } // https://en.cppreference.com/w/cpp/filesystem/file_type diff --git a/externals/coda-oss/modules/c++/sys/source/LocalDateTime.cpp b/externals/coda-oss/modules/c++/sys/source/LocalDateTime.cpp index 22bde3d57..5f7215480 100644 --- a/externals/coda-oss/modules/c++/sys/source/LocalDateTime.cpp +++ b/externals/coda-oss/modules/c++/sys/source/LocalDateTime.cpp @@ -26,9 +26,10 @@ #include #include +static const char DEFAULT_DATETIME_FORMAT[] = "%Y-%m-%d_%H:%M:%S"; + namespace sys { -const char LocalDateTime::DEFAULT_DATETIME_FORMAT[] = "%Y-%m-%d_%H:%M:%S"; void LocalDateTime::fromMillis(const tm& t) { @@ -116,6 +117,9 @@ LocalDateTime::LocalDateTime(const std::string& time, setTime(time, format); DateTime::fromMillis(); } +LocalDateTime::LocalDateTime(const std::string& time) : LocalDateTime(time, DEFAULT_DATETIME_FORMAT) +{ +} void LocalDateTime::setDST(bool isDST) { @@ -140,7 +144,7 @@ std::istream& operator>>(std::istream& is, LocalDateTime& dateTime) { std::string str; is >> str; - dateTime.setTime(str, LocalDateTime::DEFAULT_DATETIME_FORMAT); + dateTime.setTime(str, DEFAULT_DATETIME_FORMAT); return is; } } diff --git a/externals/coda-oss/modules/c++/sys/source/UTCDateTime.cpp b/externals/coda-oss/modules/c++/sys/source/UTCDateTime.cpp index 0a6e8fd08..36a166ee9 100644 --- a/externals/coda-oss/modules/c++/sys/source/UTCDateTime.cpp +++ b/externals/coda-oss/modules/c++/sys/source/UTCDateTime.cpp @@ -72,10 +72,10 @@ int getNumFullDaysInYearSoFar(int year, int month, int dayOfMonth) } } +static const char DEFAULT_DATETIME_FORMAT[] = "%Y-%m-%dT%H:%M:%SZ"; + namespace sys { -const char UTCDateTime::DEFAULT_DATETIME_FORMAT[] = "%Y-%m-%dT%H:%M:%SZ"; - void UTCDateTime::toMillis() { if (mSecond < 0.0 || mSecond >= 60.0 || @@ -190,6 +190,9 @@ UTCDateTime::UTCDateTime(const std::string& time, const std::string& format) setTime(time, format); fromMillis(); } +UTCDateTime::UTCDateTime(const std::string& time) : UTCDateTime(time, DEFAULT_DATETIME_FORMAT) +{ +} std::string UTCDateTime::format() const { @@ -206,7 +209,7 @@ std::istream& operator>>(std::istream& is, UTCDateTime& dateTime) { std::string str; is >> str; - dateTime.setTime(str, UTCDateTime::DEFAULT_DATETIME_FORMAT); + dateTime.setTime(str, DEFAULT_DATETIME_FORMAT); return is; } } diff --git a/externals/coda-oss/modules/c++/sys/unittests/test_NaN_testing.cpp b/externals/coda-oss/modules/c++/sys/unittests/test_NaN_testing.cpp index 49ae33086..b651af471 100644 --- a/externals/coda-oss/modules/c++/sys/unittests/test_NaN_testing.cpp +++ b/externals/coda-oss/modules/c++/sys/unittests/test_NaN_testing.cpp @@ -23,8 +23,6 @@ #include #include "TestCase.h" -namespace -{ TEST_CASE(testNaNsAreNotEqual) { // This test exists mainly to document behavior @@ -58,12 +56,10 @@ TEST_CASE(testIsNaN) TEST_ASSERT_FALSE(IS_NAN(five)); TEST_ASSERT_FALSE(IS_NAN(std::string("test string"))); } -} -int main(int /*argc*/, char** /*argv*/) -{ +TEST_MAIN( TEST_CHECK(testNaNsAreNotEqual); TEST_CHECK(testNaNIsNotAlmostEqualToNumber); TEST_CHECK(testIsNaN); -} +) diff --git a/externals/coda-oss/modules/c++/sys/unittests/test_aligned_alloc.cpp b/externals/coda-oss/modules/c++/sys/unittests/test_aligned_alloc.cpp index 1d8b02ae1..ca8be2a1d 100644 --- a/externals/coda-oss/modules/c++/sys/unittests/test_aligned_alloc.cpp +++ b/externals/coda-oss/modules/c++/sys/unittests/test_aligned_alloc.cpp @@ -29,11 +29,6 @@ #include "TestCase.h" -namespace -{ - -const size_t numBytes(16384); - bool testAlignedAlloc(const size_t numBytes_, const size_t alignment) { @@ -55,34 +50,34 @@ testAlignedAlloc(const size_t numBytes_, const size_t alignment) TEST_CASE(testAlignedAlloc8) { + constexpr size_t numBytes = 16384; TEST_ASSERT(testAlignedAlloc(numBytes, 8)); } TEST_CASE(testAlignedAlloc16) { + constexpr size_t numBytes = 16384; TEST_ASSERT(testAlignedAlloc(numBytes, 16)); } TEST_CASE(testAlignedAlloc32) { + constexpr size_t numBytes = 16384; TEST_ASSERT(testAlignedAlloc(numBytes, 32)); } TEST_CASE(testAlignedAlloc64) { + constexpr size_t numBytes = 16384; TEST_ASSERT(testAlignedAlloc(numBytes, 64)); } TEST_CASE(testAlignedAlloc128) { + constexpr size_t numBytes = 16384; TEST_ASSERT(testAlignedAlloc(numBytes, 128)); } -} - -int main(int, char**) -{ +TEST_MAIN( TEST_CHECK(testAlignedAlloc8); TEST_CHECK(testAlignedAlloc16); TEST_CHECK(testAlignedAlloc32); TEST_CHECK(testAlignedAlloc64); TEST_CHECK(testAlignedAlloc128); - - return 0; -} +) diff --git a/externals/coda-oss/modules/c++/sys/unittests/test_atomic_counter.cpp b/externals/coda-oss/modules/c++/sys/unittests/test_atomic_counter.cpp index 9b843e366..fa5699599 100644 --- a/externals/coda-oss/modules/c++/sys/unittests/test_atomic_counter.cpp +++ b/externals/coda-oss/modules/c++/sys/unittests/test_atomic_counter.cpp @@ -30,8 +30,6 @@ #include "TestCase.h" -namespace -{ template static void testConstructor_(const std::string& testName) { @@ -286,15 +284,11 @@ TEST_CASE(testThreadedDecrement) testThreadedDecrement_(testName); testThreadedDecrement_(testName); } -} -int main(int, char**) -{ +TEST_MAIN( TEST_CHECK(testConstructor); TEST_CHECK(testIncrement); TEST_CHECK(testDecrement); TEST_CHECK(testThreadedIncrement); TEST_CHECK(testThreadedDecrement); - - return 0; -} + ) diff --git a/externals/coda-oss/modules/c++/sys/unittests/test_byte_swap.cpp b/externals/coda-oss/modules/c++/sys/unittests/test_byte_swap.cpp index 70b70b165..095bc40e3 100644 --- a/externals/coda-oss/modules/c++/sys/unittests/test_byte_swap.cpp +++ b/externals/coda-oss/modules/c++/sys/unittests/test_byte_swap.cpp @@ -29,8 +29,6 @@ #include -namespace -{ TEST_CASE(testEndianness) { /*const*/ auto native = coda_oss::endian::native; // "const" causes "conditional expression is constant." @@ -102,13 +100,9 @@ TEST_CASE(testByteSwap) TEST_ASSERT_EQ(values1[ii], swappedValues2[ii]); } } - -} -int main(int /*argc*/, char** /*argv*/) -{ + +TEST_MAIN( TEST_CHECK(testEndianness); TEST_CHECK(testByteSwap); - - return 0; -} + ) diff --git a/externals/coda-oss/modules/c++/sys/unittests/test_conditionvar.cpp b/externals/coda-oss/modules/c++/sys/unittests/test_conditionvar.cpp index 28369aa8a..75ddcb450 100644 --- a/externals/coda-oss/modules/c++/sys/unittests/test_conditionvar.cpp +++ b/externals/coda-oss/modules/c++/sys/unittests/test_conditionvar.cpp @@ -25,9 +25,6 @@ #include "TestCase.h" -namespace -{ - typedef mt::CriticalSection CriticalSection; TEST_CASE(testDefaultConstructor) @@ -69,14 +66,9 @@ TEST_CASE(testMultipleTimeouts) } } -} - -int main(int, char**) -{ +TEST_MAIN( TEST_CHECK(testDefaultConstructor); TEST_CHECK(testParameterizedConstructor); TEST_CHECK(testMultipleTimeouts); - - return 0; -} + ) diff --git a/externals/coda-oss/modules/c++/sys/unittests/test_datetime.cpp b/externals/coda-oss/modules/c++/sys/unittests/test_datetime.cpp index 6be4ef229..8f386f57b 100644 --- a/externals/coda-oss/modules/c++/sys/unittests/test_datetime.cpp +++ b/externals/coda-oss/modules/c++/sys/unittests/test_datetime.cpp @@ -26,9 +26,6 @@ #include "TestCase.h" -namespace -{ - TEST_CASE(testDefaultConstructor) { sys::OS os; @@ -199,14 +196,9 @@ TEST_CASE(testGetTimeInMillis) TEST_ASSERT_LESSER_EQ(result, far_into_the_future); } -} - -int main(int, char**) -{ +TEST_MAIN( TEST_CHECK(testDefaultConstructor); TEST_CHECK(testParameterizedConstructor); TEST_CHECK(testDateTimeDetails); TEST_CHECK(testGetTimeInMillis); - - return 0; -} +) diff --git a/externals/coda-oss/modules/c++/sys/unittests/test_os.cpp b/externals/coda-oss/modules/c++/sys/unittests/test_os.cpp index 48357ff22..7579d6be7 100644 --- a/externals/coda-oss/modules/c++/sys/unittests/test_os.cpp +++ b/externals/coda-oss/modules/c++/sys/unittests/test_os.cpp @@ -20,13 +20,10 @@ * */ -#include - #include #include #include // std::accumulate #include - #include #include @@ -37,10 +34,6 @@ #include #include "TestCase.h" -namespace fs = std::filesystem; - -namespace -{ void createFile(const std::string& pathname) { std::ofstream oss(pathname.c_str()); @@ -172,7 +165,7 @@ TEST_CASE(testSplitEnv) TEST_ASSERT_GREATER(paths.size(), static_cast(0)); for (const auto& path : paths) { - TEST_ASSERT_TRUE(fs::exists(path)); + TEST_ASSERT_TRUE(std::filesystem::exists(path)); } // create an environemnt variable with a known bogus path @@ -188,11 +181,11 @@ TEST_CASE(testSplitEnv) // PATHs are directories, not files paths.clear(); - result = os.splitEnv(pathEnvVar, paths, fs::file_type::directory); + result = os.splitEnv(pathEnvVar, paths, std::filesystem::file_type::directory); TEST_ASSERT_TRUE(result); TEST_ASSERT_GREATER(paths.size(), static_cast(0)); paths.clear(); - result = os.splitEnv(pathEnvVar, paths, fs::file_type::regular); + result = os.splitEnv(pathEnvVar, paths, std::filesystem::file_type::regular); TEST_ASSERT_FALSE(result); TEST_ASSERT_TRUE(paths.empty()); @@ -244,7 +237,7 @@ static void testFsExtension_(const std::string& testName) } TEST_CASE(testFsExtension) { - testFsExtension_(testName); + testFsExtension_(testName); testFsExtension_(testName); #if CODA_OSS_lib_filesystem testFsExtension_(testName); @@ -266,7 +259,7 @@ static void testFsOutput_(const std::string& testName) } TEST_CASE(testFsOutput) { - testFsOutput_(testName); + testFsOutput_(testName); testFsOutput_(testName); #if CODA_OSS_lib_filesystem testFsOutput_(testName); @@ -309,22 +302,24 @@ TEST_CASE(testBacktrace) #if _WIN32 constexpr auto frames_size_RELEASE = 2; constexpr auto frames_size_RELEASE_other = frames_size_RELEASE; - constexpr auto frames_size_DEBUG = 16; + constexpr auto frames_size_DEBUG = 14; + constexpr auto frames_size_DEBUG_other = frames_size_DEBUG + 1; // 15 #elif defined(__GNUC__) constexpr auto frames_size_RELEASE = 6; constexpr auto frames_size_RELEASE_other = frames_size_RELEASE + 1; // 7 - constexpr auto frames_size_DEBUG = frames_size_RELEASE + 6; // 12 + constexpr auto frames_size_DEBUG = frames_size_RELEASE + 4; // 10 + constexpr auto frames_size_DEBUG_other = frames_size_DEBUG; #else #error "CODA_OSS_sys_Backtrace inconsistency." #endif expected = sys::debug_build() ? frames_size_DEBUG : frames_size_RELEASE; - expected_other = sys::debug_build() ? frames_size_DEBUG : frames_size_RELEASE_other; + expected_other = sys::debug_build() ? frames_size_DEBUG_other : frames_size_RELEASE_other; } else { TEST_ASSERT_FALSE(supported); } - TEST_ASSERT( (frames.size() == expected) || (frames.size() == expected_other) ); + TEST_ASSERT_GREATER_EQ(frames.size(), expected); const auto msg = std::accumulate(frames.begin(), frames.end(), std::string()); if (supported) @@ -345,9 +340,9 @@ TEST_CASE(testSpecialEnvVars) auto result = os.getSpecialEnv("0"); // i.e., ${0) TEST_ASSERT_FALSE(result.empty()); TEST_ASSERT_EQ(result, argv0); - const fs::path fsresult(result); - const fs::path this_file(__FILE__); - TEST_ASSERT_EQ(fsresult.stem(), this_file.stem()); + //const std::filesystem::path fsresult(result); + //const std::filesystem::path this_file(__FILE__); + //TEST_ASSERT_EQ(fsresult.stem(), this_file.stem()); const auto pid = os.getSpecialEnv("PID"); TEST_ASSERT_FALSE(pid.empty()); @@ -393,7 +388,7 @@ TEST_CASE(testFsFileSize) { const sys::OS os; { - const fs::path argv0(os.getSpecialEnv("ARGV0")); + const std::filesystem::path argv0(os.getSpecialEnv("ARGV0")); const auto size = file_size(argv0); TEST_ASSERT_GREATER(size, static_cast(0)); } @@ -405,12 +400,8 @@ TEST_CASE(testFsFileSize) } } -} - -int main(int, char** argv) -{ - sys::AbstractOS::setArgvPathname(argv[0]); - +TEST_MAIN( + //sys::AbstractOS::setArgvPathname(argv[0]); TEST_CHECK(testRecursiveRemove); TEST_CHECK(testForcefulMove); TEST_CHECK(testEnvVariables); @@ -420,7 +411,4 @@ int main(int, char** argv) TEST_CHECK(testBacktrace); TEST_CHECK(testSpecialEnvVars); TEST_CHECK(testFsFileSize); - - return 0; -} - +) diff --git a/externals/coda-oss/modules/c++/sys/unittests/test_path.cpp b/externals/coda-oss/modules/c++/sys/unittests/test_path.cpp index 166cabcb5..42e79af8e 100644 --- a/externals/coda-oss/modules/c++/sys/unittests/test_path.cpp +++ b/externals/coda-oss/modules/c++/sys/unittests/test_path.cpp @@ -21,23 +21,18 @@ * */ -#include - #include #include "TestCase.h" #include -namespace fs = coda_oss::filesystem; -namespace -{ static std::string find_directory(const std::vector& paths) { std::string bad_delim = sys::Path::delimiter(); bad_delim += sys::Path::delimiter(); for (const auto& p : paths) { - if (fs::is_directory(p)) + if (coda_oss::filesystem::is_directory(p)) { // Sometimes the value of PATH has "bad" strings in it ... at least it will // confuse the unit-tests as we don't expect "C:\D1\\D2 @@ -61,7 +56,7 @@ TEST_CASE(testPathMerge) TEST_ASSERT_GREATER(paths.size(), static_cast(0)); auto path = find_directory(paths); - TEST_ASSERT_TRUE(fs::is_directory(path)); + TEST_ASSERT_TRUE(coda_oss::filesystem::is_directory(path)); // add trailing '/' if (!str::endsWith(path, sys::Path::delimiter())) { @@ -73,7 +68,7 @@ TEST_CASE(testPathMerge) TEST_ASSERT_GREATER(components.size(), static_cast(0)); auto result = sys::Path::merge(components, isAbsolute); TEST_ASSERT_EQ(result, path); - TEST_ASSERT_TRUE(fs::is_directory(result)); + TEST_ASSERT_TRUE(coda_oss::filesystem::is_directory(result)); #if _WIN32 path = R"(C:\dir\file.txt)"; @@ -89,12 +84,12 @@ TEST_CASE(testPathMerge) TEST_CASE(testExpandEnvTilde) { auto path = sys::Path::expandEnvironmentVariables("~"); - TEST_ASSERT_TRUE(fs::is_directory(path)); + TEST_ASSERT_TRUE(coda_oss::filesystem::is_directory(path)); - path = sys::Path::expandEnvironmentVariables("~", fs::file_type::directory); - TEST_ASSERT_TRUE(fs::is_directory(path)); + path = sys::Path::expandEnvironmentVariables("~", coda_oss::filesystem::file_type::directory); + TEST_ASSERT_TRUE(coda_oss::filesystem::is_directory(path)); - path = sys::Path::expandEnvironmentVariables("~", fs::file_type::regular); + path = sys::Path::expandEnvironmentVariables("~", coda_oss::filesystem::file_type::regular); TEST_ASSERT_TRUE(path.empty()); } @@ -104,8 +99,8 @@ TEST_CASE(testExpandEnvTildePath) const std::vector exts{"NTUSER.DAT", ".login", ".cshrc", ".bashrc"}; os.prependEnv("exts", exts, true /*overwrite*/); - const auto path = sys::Path::expandEnvironmentVariables("~/$(exts)", fs::file_type::regular); - TEST_ASSERT_TRUE(fs::is_regular_file(path)); + const auto path = sys::Path::expandEnvironmentVariables("~/$(exts)", coda_oss::filesystem::file_type::regular); + TEST_ASSERT_TRUE(coda_oss::filesystem::is_regular_file(path)); } TEST_CASE(testExpandEnv) @@ -193,7 +188,7 @@ TEST_CASE(testExpandEnvPathMultiple) os.prependEnv("paths", paths, true /*overwrite*/); auto expanded_path = sys::Path::expandEnvironmentVariables("$(paths)", false /*checkIfExists*/); std::string home = "home"; - if (fs::is_directory(home) && !str::endsWith(home, sys::Path::delimiter())) + if (coda_oss::filesystem::is_directory(home) && !str::endsWith(home, sys::Path::delimiter())) { home += sys::Path::delimiter(); } @@ -237,11 +232,11 @@ TEST_CASE(testModifyVar) const auto argv0_t = sys::Path::expandEnvironmentVariables("${ARGV0@t}", false /*checkIfExists*/); TEST_ASSERT_FALSE(argv0_t.empty()); - const auto result = os.getSpecialEnv("0"); // i.e., ${0) + const auto result = os.getSpecialEnv("0"); // i.e., ${0} TEST_ASSERT_FALSE(result.empty()); - const fs::path fsresult(result); - const fs::path this_file(__FILE__); - TEST_ASSERT_EQ(fsresult.stem(), this_file.stem()); + const coda_oss::filesystem::path fsresult(result); + //const coda_oss::filesystem::path this_file(__FILE__); + //TEST_ASSERT_EQ(fsresult.stem(), this_file.stem()); TEST_ASSERT_EQ(argv0_t, fsresult.filename()); } @@ -325,10 +320,7 @@ TEST_CASE(testModifyVar2) TEST_ASSERT_EQ(s, "file"); } -} - -int main(int, char**) -{ +TEST_MAIN( TEST_CHECK(testPathMerge); TEST_CHECK(testExpandEnvTilde); TEST_CHECK(testExpandEnv); @@ -337,7 +329,5 @@ int main(int, char**) TEST_CHECK(testExpandEnvPathMultiple); TEST_CHECK(testModifyVar); TEST_CHECK(testModifyVar2); - - return 0; -} + ) diff --git a/externals/coda-oss/modules/c++/tiff/include/tiff/FileReader.h b/externals/coda-oss/modules/c++/tiff/include/tiff/FileReader.h index 47417b0db..88edb7c41 100644 --- a/externals/coda-oss/modules/c++/tiff/include/tiff/FileReader.h +++ b/externals/coda-oss/modules/c++/tiff/include/tiff/FileReader.h @@ -20,129 +20,10 @@ * */ -#ifndef __TIFF_FILE_READER_H__ -#define __TIFF_FILE_READER_H__ +#ifndef CODA_OSS_tiff_FileReader_h_INCLUDED_ +#define CODA_OSS_tiff_FileReader_h_INCLUDED_ +#pragma once -#include -#include -#include +#include "tiff/TiffFileReader.h" -#include "tiff/Header.h" -#include "tiff/ImageReader.h" - -namespace tiff -{ - -/** - ********************************************************************* - * @class FileReader - * @brief Reads a TIFF file. - * - * Reads a TIFF file and all images within that file. Has functions - * to access a specific image within the file, and to read data from - * a specific image in the file. - *********************************************************************/ -struct FileReader -{ - FileReader() = default; - - /** - ***************************************************************** - * Constructor. Opens and parses the specified file as a TIFF - * file. - * - * @param fileName - * the file to open and parse as a TIFF file - * @todo - * ios::nocreate missing in newer G++ - *****************************************************************/ - FileReader(const std::string& fileName) - { - openFile(fileName); - } - - //! Destructor - ~FileReader() - { - close(); - } - - /** - ***************************************************************** - * Processes the TIFF file. Reads the TIFF header, and every - * IFD the file has, creating a new ImageReader for each. - *****************************************************************/ - void openFile(const std::string& fileName); - - //! Closes the TIFF file and clears out member data. - void close(); - - /** - ***************************************************************** - * Retrieves an ImageReader pointer to the specified image. - * - * @param index - * the numeric index of the image to retrieve - * @return - * an ImageReader pointer to the specified image - *****************************************************************/ - tiff::ImageReader *operator[](const sys::Uint32_T index) const; - - /** - ***************************************************************** - * Prints the the file's header, and every image's IFD to the - * specified output stream. - * - * @param output - * the stream to print the file information to - *****************************************************************/ - void print(io::OutputStream &output) const; - - /** - ***************************************************************** - * Gets the specified number of elements from the TIFF image and - * stores them into the specified buffer. The buffer must be - * allocated outside because it is not allocated in this function. - * - * @param buffer - * the buffer to populate with image data - * @param numElementsToRead - * the number of elements (not bytes) to read from the image - * @param subSourceIndex - * the index of the image within the file to read from - *****************************************************************/ - void getData(unsigned char *buffer, const sys::Uint32_T numElementsToRead, - const sys::Uint32_T subSourceIndex = 0); - - /** - ***************************************************************** - * Returns the number of images in the TIFF file. - * - * @return - * the number of images in the TIFF file - *****************************************************************/ - sys::Uint32_T getImageCount() const - { - return static_cast (mImages.size()); - } - - -private: - - //! The input stream to use to read the TIFF file - io::FileInputStream mInput; - - //! The TIFF file header - tiff::Header mHeader; - - //! The images within the TIFF file - std::vector mImages; - - //! Whether to reverse bytes while reading. - bool mReverseBytes = false; - -}; - -} // End namespace. - -#endif // __TIFF_FILE_READER_H__ +#endif // CODA_OSS_tiff_FileReader_h_INCLUDED_ diff --git a/externals/coda-oss/modules/c++/tiff/include/tiff/FileWriter.h b/externals/coda-oss/modules/c++/tiff/include/tiff/FileWriter.h index fb495a676..d77af0d6f 100644 --- a/externals/coda-oss/modules/c++/tiff/include/tiff/FileWriter.h +++ b/externals/coda-oss/modules/c++/tiff/include/tiff/FileWriter.h @@ -20,240 +20,10 @@ * */ -#ifndef __TIFF_FILE_WRITER_H__ -#define __TIFF_FILE_WRITER_H__ +#ifndef CODA_OSS_tiff_FileWriter_h_INCLUDED_ +#define CODA_OSS_tiff_FileWriter_h_INCLUDED_ +#pragma once -#include -#include -#include -#include "tiff/Header.h" -#include "tiff/ImageWriter.h" +#include "tiff/TiffFileWriter.h" -namespace tiff -{ - -/** - ********************************************************************* - * @class FileWriter - * @brief Writes a TIFF file. - * - * Writes a TIFF file to an output stream. Can write multiple images - * to the same file. Contains function for manipulating each - * sub-image and for writing data. - *********************************************************************/ -struct FileWriter -{ - //! Constructor - FileWriter() : - mIFDOffset(0) - { - } - - /** - ***************************************************************** - * Constructor. Opens the specified file name for writing. - * - * @param fileName - * the file to open for writing - *****************************************************************/ - FileWriter(const std::string& fileName) : - mIFDOffset(0) - { - openFile(fileName); - } - - //! Destructor - ~FileWriter(); - - void openFile(const std::string& fileName); - void close(); - - /** - ***************************************************************** - * Retrieves a ImageWriter pointer to the specified image. - * - * @param index - * the numeric index of the image to retrieve - * @return - * a TIFFImageWriter pointer to the specified image - *****************************************************************/ - tiff::ImageWriter *operator[](const sys::Uint32_T index) const; - - /** - ***************************************************************** - * Writes data to the output file stream. The input buffer - * must be in raster format. Converts raster data to either - * tiled or stripped format. - * - * @param buffer - * the buffer to write to the output stream - * @param numElementsToWrite - * the number of elements (not bytes) to write - * @param subImageIndex - * the index to a sub-image to write - *****************************************************************/ - void putData(const unsigned char *buffer, - sys::Uint32_T numElementsToWrite, - sys::Uint32_T subImageIndex = 0); - - /** - ***************************************************************** - * Creates and adds an image to the TIFF file. Sets necessary - * defaults within the image and returns a pointer to that image - * so that the user can manipulate its IFD. - * - * @return - * A pointer to a TIFF image. - *****************************************************************/ - tiff::ImageWriter *addImage(); - - /** - ***************************************************************** - * Writes the TIFF header to the file. There is only one header - * in a TIFF file regardless of how many images are in it. - *****************************************************************/ - void writeHeader(); - - FileWriter(const FileWriter&) = delete; - FileWriter& operator=(const FileWriter&) = delete; - -private: - //! The position to write the offset to the first IFD to - sys::Uint32_T mIFDOffset; - - //! The output stream - io::FileOutputStream mOutput; - - //! The TIFF header - tiff::Header mHeader; - - //! The images to write - std::vector mImages; - -}; - -/** Enumeration for automatic detection of image type */ -enum { AUTO = -1 }; - -/*! - * This function is designed to mimic (roughly) the API for sio::lite::writeSIO(). - * It attempts to automatically guess the correct TIFF type for an input image, - * and write as a TIFF file. - * - * Unlike the writeSIO function, this function does not support complex pixels, - * and will end up writing them as IEEE_FLOAT, which is probably not the desired - * behavior, so care is required. The supported types are double, float, RGB - * 3-byte unsigned, and single unsigned byte (mono). - * - * Most TIFF viewers will not support float files, and therefore, it may be more - * desirable to remap float data to bytes prior to calling this routine. - * - * \param image The data to write to TIFF - * \param rows The number of rows in image - * \param cols The number of cols in image - * \param imageFile The name of the file - * \param et The element type, which can be any tiff::Const::SampleFormatType, or - * defaults to automatically guessing based on the input data size - * \param es The element size, which can be any size, but defaults to automatically - * guessing based on the input data size - * - */ -template void writeTIFF(const T* image, size_t rows, size_t cols, - std::string imageFile, unsigned short et = AUTO, int es = AUTO) -{ - - if (es == AUTO) - es = sizeof(T); - - unsigned int photoInterp(1); - unsigned short numBands(1); - - if (et == static_cast(AUTO)) - { - switch (es) - { - case 8: - et = ::tiff::Const::SampleFormatType::IEEE_FLOAT; - numBands = 2; - break; - - case 4: - et = ::tiff::Const::SampleFormatType::IEEE_FLOAT; - break; - - case 3: - et = ::tiff::Const::SampleFormatType::UNSIGNED_INT; - photoInterp = (unsigned short) ::tiff::Const::PhotoInterpType::RGB; - numBands = 3; - break; - - case 1: - et = ::tiff::Const::SampleFormatType::UNSIGNED_INT; - break; - default: - throw except::Exception(Ctxt(FmtX("Unexpected es: %d", es))); - } - } - unsigned short alpha(0); - if (es == 4 && et == ::tiff::Const::SampleFormatType::UNSIGNED_INT) - { - photoInterp = (unsigned short) ::tiff::Const::PhotoInterpType::RGB; - numBands = 4; - // This is "unassociated alpha value" - alpha = 2; - - } - - - ::tiff::FileWriter fileWriter(imageFile); - - //write the header first - fileWriter.writeHeader(); - - - ::tiff::ImageWriter* imageWriter = fileWriter.addImage(); - ::tiff::IFD* ifd = imageWriter->getIFD(); - - ifd->addEntry(::tiff::KnownTags::IMAGE_WIDTH, cols); - ifd->addEntry(::tiff::KnownTags::IMAGE_LENGTH, rows); - - ifd->addEntry(::tiff::KnownTags::COMPRESSION, - (unsigned short) ::tiff::Const::CompressionType::NO_COMPRESSION); - - - ifd->addEntry(::tiff::KnownTags::PHOTOMETRIC_INTERPRETATION, photoInterp); - // Added this for RGBA, because otherwise the ImageWriter::validate() changes all of - // these fields back assuming 3 bytes per pixel - ifd->addEntry(::tiff::KnownTags::SAMPLES_PER_PIXEL, numBands); - ifd->addEntry(::tiff::KnownTags::BITS_PER_SAMPLE); - ifd->addEntry(::tiff::KnownTags::SAMPLE_FORMAT); - ::tiff::IFDEntry* bps = (*ifd)[::tiff::KnownTags::BITS_PER_SAMPLE]; - ::tiff::IFDEntry* sf = (*ifd)[::tiff::KnownTags::SAMPLE_FORMAT]; - - unsigned short bitsPerBand = (es << 3) / numBands; - - //set some fields that have 'numSamples' values - for (int band = 0; band < numBands; ++band) - { - bps->addValue(::tiff::TypeFactory::create((unsigned char *) &bitsPerBand, - ::tiff::Const::Type::SHORT)); - sf->addValue(::tiff::TypeFactory::create((unsigned char *) &et, - ::tiff::Const::Type::SHORT)); - } - - // If the alpha channel is on (note 0 is a valid value for ExtraSamples, - // but Im using it to be boolean (0 = off) and the unassociated value here - if (alpha) - ifd->addEntry(std::string("ExtraSamples"), alpha); - - imageWriter->putData((unsigned char*) image, rows * cols); - - //write the IFD - imageWriter->writeIFD(); - fileWriter.close(); - -} - -} // End namespace. - -#endif // __TIFF_FILE_WRITER_H__ +#endif // CODA_OSS_tiff_FileWriter_h_INCLUDED_ diff --git a/externals/coda-oss/modules/c++/tiff/include/tiff/TiffFileReader.h b/externals/coda-oss/modules/c++/tiff/include/tiff/TiffFileReader.h new file mode 100644 index 000000000..47417b0db --- /dev/null +++ b/externals/coda-oss/modules/c++/tiff/include/tiff/TiffFileReader.h @@ -0,0 +1,148 @@ +/* ========================================================================= + * This file is part of tiff-c++ + * ========================================================================= + * + * (C) Copyright 2004 - 2014, MDA Information Systems LLC + * + * tiff-c++ is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this program; If not, + * see . + * + */ + +#ifndef __TIFF_FILE_READER_H__ +#define __TIFF_FILE_READER_H__ + +#include +#include +#include + +#include "tiff/Header.h" +#include "tiff/ImageReader.h" + +namespace tiff +{ + +/** + ********************************************************************* + * @class FileReader + * @brief Reads a TIFF file. + * + * Reads a TIFF file and all images within that file. Has functions + * to access a specific image within the file, and to read data from + * a specific image in the file. + *********************************************************************/ +struct FileReader +{ + FileReader() = default; + + /** + ***************************************************************** + * Constructor. Opens and parses the specified file as a TIFF + * file. + * + * @param fileName + * the file to open and parse as a TIFF file + * @todo + * ios::nocreate missing in newer G++ + *****************************************************************/ + FileReader(const std::string& fileName) + { + openFile(fileName); + } + + //! Destructor + ~FileReader() + { + close(); + } + + /** + ***************************************************************** + * Processes the TIFF file. Reads the TIFF header, and every + * IFD the file has, creating a new ImageReader for each. + *****************************************************************/ + void openFile(const std::string& fileName); + + //! Closes the TIFF file and clears out member data. + void close(); + + /** + ***************************************************************** + * Retrieves an ImageReader pointer to the specified image. + * + * @param index + * the numeric index of the image to retrieve + * @return + * an ImageReader pointer to the specified image + *****************************************************************/ + tiff::ImageReader *operator[](const sys::Uint32_T index) const; + + /** + ***************************************************************** + * Prints the the file's header, and every image's IFD to the + * specified output stream. + * + * @param output + * the stream to print the file information to + *****************************************************************/ + void print(io::OutputStream &output) const; + + /** + ***************************************************************** + * Gets the specified number of elements from the TIFF image and + * stores them into the specified buffer. The buffer must be + * allocated outside because it is not allocated in this function. + * + * @param buffer + * the buffer to populate with image data + * @param numElementsToRead + * the number of elements (not bytes) to read from the image + * @param subSourceIndex + * the index of the image within the file to read from + *****************************************************************/ + void getData(unsigned char *buffer, const sys::Uint32_T numElementsToRead, + const sys::Uint32_T subSourceIndex = 0); + + /** + ***************************************************************** + * Returns the number of images in the TIFF file. + * + * @return + * the number of images in the TIFF file + *****************************************************************/ + sys::Uint32_T getImageCount() const + { + return static_cast (mImages.size()); + } + + +private: + + //! The input stream to use to read the TIFF file + io::FileInputStream mInput; + + //! The TIFF file header + tiff::Header mHeader; + + //! The images within the TIFF file + std::vector mImages; + + //! Whether to reverse bytes while reading. + bool mReverseBytes = false; + +}; + +} // End namespace. + +#endif // __TIFF_FILE_READER_H__ diff --git a/externals/coda-oss/modules/c++/tiff/include/tiff/TiffFileWriter.h b/externals/coda-oss/modules/c++/tiff/include/tiff/TiffFileWriter.h new file mode 100644 index 000000000..fb495a676 --- /dev/null +++ b/externals/coda-oss/modules/c++/tiff/include/tiff/TiffFileWriter.h @@ -0,0 +1,259 @@ +/* ========================================================================= + * This file is part of tiff-c++ + * ========================================================================= + * + * (C) Copyright 2004 - 2014, MDA Information Systems LLC + * + * tiff-c++ is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this program; If not, + * see . + * + */ + +#ifndef __TIFF_FILE_WRITER_H__ +#define __TIFF_FILE_WRITER_H__ + +#include +#include +#include +#include "tiff/Header.h" +#include "tiff/ImageWriter.h" + +namespace tiff +{ + +/** + ********************************************************************* + * @class FileWriter + * @brief Writes a TIFF file. + * + * Writes a TIFF file to an output stream. Can write multiple images + * to the same file. Contains function for manipulating each + * sub-image and for writing data. + *********************************************************************/ +struct FileWriter +{ + //! Constructor + FileWriter() : + mIFDOffset(0) + { + } + + /** + ***************************************************************** + * Constructor. Opens the specified file name for writing. + * + * @param fileName + * the file to open for writing + *****************************************************************/ + FileWriter(const std::string& fileName) : + mIFDOffset(0) + { + openFile(fileName); + } + + //! Destructor + ~FileWriter(); + + void openFile(const std::string& fileName); + void close(); + + /** + ***************************************************************** + * Retrieves a ImageWriter pointer to the specified image. + * + * @param index + * the numeric index of the image to retrieve + * @return + * a TIFFImageWriter pointer to the specified image + *****************************************************************/ + tiff::ImageWriter *operator[](const sys::Uint32_T index) const; + + /** + ***************************************************************** + * Writes data to the output file stream. The input buffer + * must be in raster format. Converts raster data to either + * tiled or stripped format. + * + * @param buffer + * the buffer to write to the output stream + * @param numElementsToWrite + * the number of elements (not bytes) to write + * @param subImageIndex + * the index to a sub-image to write + *****************************************************************/ + void putData(const unsigned char *buffer, + sys::Uint32_T numElementsToWrite, + sys::Uint32_T subImageIndex = 0); + + /** + ***************************************************************** + * Creates and adds an image to the TIFF file. Sets necessary + * defaults within the image and returns a pointer to that image + * so that the user can manipulate its IFD. + * + * @return + * A pointer to a TIFF image. + *****************************************************************/ + tiff::ImageWriter *addImage(); + + /** + ***************************************************************** + * Writes the TIFF header to the file. There is only one header + * in a TIFF file regardless of how many images are in it. + *****************************************************************/ + void writeHeader(); + + FileWriter(const FileWriter&) = delete; + FileWriter& operator=(const FileWriter&) = delete; + +private: + //! The position to write the offset to the first IFD to + sys::Uint32_T mIFDOffset; + + //! The output stream + io::FileOutputStream mOutput; + + //! The TIFF header + tiff::Header mHeader; + + //! The images to write + std::vector mImages; + +}; + +/** Enumeration for automatic detection of image type */ +enum { AUTO = -1 }; + +/*! + * This function is designed to mimic (roughly) the API for sio::lite::writeSIO(). + * It attempts to automatically guess the correct TIFF type for an input image, + * and write as a TIFF file. + * + * Unlike the writeSIO function, this function does not support complex pixels, + * and will end up writing them as IEEE_FLOAT, which is probably not the desired + * behavior, so care is required. The supported types are double, float, RGB + * 3-byte unsigned, and single unsigned byte (mono). + * + * Most TIFF viewers will not support float files, and therefore, it may be more + * desirable to remap float data to bytes prior to calling this routine. + * + * \param image The data to write to TIFF + * \param rows The number of rows in image + * \param cols The number of cols in image + * \param imageFile The name of the file + * \param et The element type, which can be any tiff::Const::SampleFormatType, or + * defaults to automatically guessing based on the input data size + * \param es The element size, which can be any size, but defaults to automatically + * guessing based on the input data size + * + */ +template void writeTIFF(const T* image, size_t rows, size_t cols, + std::string imageFile, unsigned short et = AUTO, int es = AUTO) +{ + + if (es == AUTO) + es = sizeof(T); + + unsigned int photoInterp(1); + unsigned short numBands(1); + + if (et == static_cast(AUTO)) + { + switch (es) + { + case 8: + et = ::tiff::Const::SampleFormatType::IEEE_FLOAT; + numBands = 2; + break; + + case 4: + et = ::tiff::Const::SampleFormatType::IEEE_FLOAT; + break; + + case 3: + et = ::tiff::Const::SampleFormatType::UNSIGNED_INT; + photoInterp = (unsigned short) ::tiff::Const::PhotoInterpType::RGB; + numBands = 3; + break; + + case 1: + et = ::tiff::Const::SampleFormatType::UNSIGNED_INT; + break; + default: + throw except::Exception(Ctxt(FmtX("Unexpected es: %d", es))); + } + } + unsigned short alpha(0); + if (es == 4 && et == ::tiff::Const::SampleFormatType::UNSIGNED_INT) + { + photoInterp = (unsigned short) ::tiff::Const::PhotoInterpType::RGB; + numBands = 4; + // This is "unassociated alpha value" + alpha = 2; + + } + + + ::tiff::FileWriter fileWriter(imageFile); + + //write the header first + fileWriter.writeHeader(); + + + ::tiff::ImageWriter* imageWriter = fileWriter.addImage(); + ::tiff::IFD* ifd = imageWriter->getIFD(); + + ifd->addEntry(::tiff::KnownTags::IMAGE_WIDTH, cols); + ifd->addEntry(::tiff::KnownTags::IMAGE_LENGTH, rows); + + ifd->addEntry(::tiff::KnownTags::COMPRESSION, + (unsigned short) ::tiff::Const::CompressionType::NO_COMPRESSION); + + + ifd->addEntry(::tiff::KnownTags::PHOTOMETRIC_INTERPRETATION, photoInterp); + // Added this for RGBA, because otherwise the ImageWriter::validate() changes all of + // these fields back assuming 3 bytes per pixel + ifd->addEntry(::tiff::KnownTags::SAMPLES_PER_PIXEL, numBands); + ifd->addEntry(::tiff::KnownTags::BITS_PER_SAMPLE); + ifd->addEntry(::tiff::KnownTags::SAMPLE_FORMAT); + ::tiff::IFDEntry* bps = (*ifd)[::tiff::KnownTags::BITS_PER_SAMPLE]; + ::tiff::IFDEntry* sf = (*ifd)[::tiff::KnownTags::SAMPLE_FORMAT]; + + unsigned short bitsPerBand = (es << 3) / numBands; + + //set some fields that have 'numSamples' values + for (int band = 0; band < numBands; ++band) + { + bps->addValue(::tiff::TypeFactory::create((unsigned char *) &bitsPerBand, + ::tiff::Const::Type::SHORT)); + sf->addValue(::tiff::TypeFactory::create((unsigned char *) &et, + ::tiff::Const::Type::SHORT)); + } + + // If the alpha channel is on (note 0 is a valid value for ExtraSamples, + // but Im using it to be boolean (0 = off) and the unassociated value here + if (alpha) + ifd->addEntry(std::string("ExtraSamples"), alpha); + + imageWriter->putData((unsigned char*) image, rows * cols); + + //write the IFD + imageWriter->writeIFD(); + fileWriter.close(); + +} + +} // End namespace. + +#endif // __TIFF_FILE_WRITER_H__ diff --git a/externals/coda-oss/modules/c++/tiff/source/FileReader.cpp b/externals/coda-oss/modules/c++/tiff/source/TiffFileReader.cpp similarity index 99% rename from externals/coda-oss/modules/c++/tiff/source/FileReader.cpp rename to externals/coda-oss/modules/c++/tiff/source/TiffFileReader.cpp index bd375b52c..e0d78f841 100644 --- a/externals/coda-oss/modules/c++/tiff/source/FileReader.cpp +++ b/externals/coda-oss/modules/c++/tiff/source/TiffFileReader.cpp @@ -19,7 +19,7 @@ * see . * */ -#include "tiff/FileReader.h" +#include "tiff/TiffFileReader.h" #include #include diff --git a/externals/coda-oss/modules/c++/tiff/source/FileWriter.cpp b/externals/coda-oss/modules/c++/tiff/source/TiffFileWriter.cpp similarity index 100% rename from externals/coda-oss/modules/c++/tiff/source/FileWriter.cpp rename to externals/coda-oss/modules/c++/tiff/source/TiffFileWriter.cpp diff --git a/externals/coda-oss/modules/c++/tiff/wscript b/externals/coda-oss/modules/c++/tiff/wscript index 53913616c..3473aa7e5 100644 --- a/externals/coda-oss/modules/c++/tiff/wscript +++ b/externals/coda-oss/modules/c++/tiff/wscript @@ -1,5 +1,4 @@ NAME = 'tiff' -MAINTAINER = 'jmrandol@users.sourceforge.net' VERSION = '1.0' MODULE_DEPS = 'mt io' diff --git a/externals/coda-oss/modules/c++/types/include/types/Range.h b/externals/coda-oss/modules/c++/types/include/types/Range.h index 922dc8ff1..575cc67bc 100644 --- a/externals/coda-oss/modules/c++/types/include/types/Range.h +++ b/externals/coda-oss/modules/c++/types/include/types/Range.h @@ -25,6 +25,8 @@ #include #include +#include "config/Exports.h" + namespace types { /*! @@ -32,7 +34,7 @@ namespace types * \brief Holds range information i.e a starting element and number of * elements in a range (exclusive) */ -struct Range +struct CODA_OSS_API Range { /*! * Initializes to an empty range diff --git a/externals/coda-oss/modules/c++/types/include/types/RangeList.h b/externals/coda-oss/modules/c++/types/include/types/RangeList.h index 7d3b91388..1622124ae 100644 --- a/externals/coda-oss/modules/c++/types/include/types/RangeList.h +++ b/externals/coda-oss/modules/c++/types/include/types/RangeList.h @@ -27,6 +27,8 @@ #include +#include "config/Exports.h" + namespace types { /*! @@ -50,7 +52,7 @@ namespace types * TODO: Take a look at replacing the internals with some interval list * structure. */ -class RangeList +class CODA_OSS_API RangeList { public: /*! diff --git a/externals/coda-oss/modules/c++/types/unittests/test_page_row_col.cpp b/externals/coda-oss/modules/c++/types/unittests/test_page_row_col.cpp index c508f6344..edf926bab 100644 --- a/externals/coda-oss/modules/c++/types/unittests/test_page_row_col.cpp +++ b/externals/coda-oss/modules/c++/types/unittests/test_page_row_col.cpp @@ -26,8 +26,6 @@ #include #include -namespace -{ TEST_CASE(TestPageRowColSizeT) { // default constructor should initialize all to 0 @@ -115,11 +113,8 @@ TEST_CASE(TestPageRowColDouble) const types::PageRowCol div = pageRowColA / pageRowColB; TEST_ASSERT(div == types::PageRowCol(3.1 / 1.1, 5.2 / 2.2, 11.3 / 3.3)); } -} -int main(int /*argc*/, char** /*argv*/) -{ +TEST_MAIN( TEST_CHECK(TestPageRowColSizeT); TEST_CHECK(TestPageRowColDouble); - return 0; -} + ) diff --git a/externals/coda-oss/modules/c++/types/unittests/test_range.cpp b/externals/coda-oss/modules/c++/types/unittests/test_range.cpp index 1513e4db8..b0564985a 100644 --- a/externals/coda-oss/modules/c++/types/unittests/test_range.cpp +++ b/externals/coda-oss/modules/c++/types/unittests/test_range.cpp @@ -25,8 +25,6 @@ #include -namespace -{ TEST_CASE(TestGetNumSharedElements) { const types::Range range(100, 50); @@ -143,12 +141,9 @@ TEST_CASE(TestSplit) std::numeric_limits::max()); } } -} -int main(int /*argc*/, char** /*argv*/) -{ +TEST_MAIN( TEST_CHECK(TestGetNumSharedElements); TEST_CHECK(TestTouches); TEST_CHECK(TestSplit); - return 0; -} + ) diff --git a/externals/coda-oss/modules/c++/types/unittests/test_range_list.cpp b/externals/coda-oss/modules/c++/types/unittests/test_range_list.cpp index aebe2ae3e..ef1ff5c70 100644 --- a/externals/coda-oss/modules/c++/types/unittests/test_range_list.cpp +++ b/externals/coda-oss/modules/c++/types/unittests/test_range_list.cpp @@ -24,8 +24,6 @@ #include "TestCase.h" #include -namespace -{ TEST_CASE(TestDisjointInsertion) { types::RangeList RL; @@ -205,10 +203,8 @@ TEST_CASE(TestIntersection) TEST_ASSERT_TRUE(types::Range(31,2) == ranges[4]); TEST_ASSERT_TRUE(types::Range(37,1) == ranges[5]); } -} -int main(int /*argc*/, char** /*argv*/) -{ +TEST_MAIN( TEST_CHECK(TestDisjointInsertion); TEST_CHECK(TestMergedInsertion); TEST_CHECK(TestSinglePointTouching); @@ -218,5 +214,4 @@ int main(int /*argc*/, char** /*argv*/) TEST_CHECK(TestRemoveMultiRangeOverlap); TEST_CHECK(TestExpansion); TEST_CHECK(TestIntersection); - return 0; -} +) diff --git a/externals/coda-oss/modules/c++/units/unittests/test_units.cpp b/externals/coda-oss/modules/c++/units/unittests/test_units.cpp index cd8dd3d46..25b514cf5 100644 --- a/externals/coda-oss/modules/c++/units/unittests/test_units.cpp +++ b/externals/coda-oss/modules/c++/units/unittests/test_units.cpp @@ -54,9 +54,9 @@ TEST_CASE(test_degrees) TEST_ASSERT_ALMOST_EQ(0.0, cos(degrees_270)); TEST_ASSERT_ALMOST_EQ(1.0, cos(degrees_360)); - test_degrees_("test_degrees"); - test_degrees_("test_degrees"); - test_degrees_("test_degrees"); + test_degrees_(testName); + test_degrees_(testName); + test_degrees_(testName); } TEST_CASE(test_lengths) diff --git a/externals/coda-oss/modules/c++/xml.lite/include/import/xml/lite.h b/externals/coda-oss/modules/c++/xml.lite/include/import/xml/lite.h index ff258f9f3..477e27c80 100644 --- a/externals/coda-oss/modules/c++/xml.lite/include/import/xml/lite.h +++ b/externals/coda-oss/modules/c++/xml.lite/include/import/xml/lite.h @@ -20,8 +20,39 @@ * */ -#ifndef __IMPORT_XML_LITE_H__ -#define __IMPORT_XML_LITE_H__ +#ifndef CODA_OSS_xml_lite_import_lite_h_INCLUDED_ +#define CODA_OSS_xml_lite_import_lite_h_INCLUDED_ +#pragma once + +#if _MSC_VER +#pragma warning(push) +// these are from Xerces +#pragma warning(disable: 5219) // implicit conversion from '...' to '...', possible loss of data +#pragma warning(disable: 4365) // '...': conversion from '...' to '...', signed / unsigned mismatch +#pragma warning(disable: 26477) // Use 'nullptr' rather than 0 or NULL (es.47). +#pragma warning(disable: 26493) // Don't use C-style casts (type.4). +#pragma warning(disable: 26814) // The const variable '...' can be computed at compile-time. Consider using constexpr (con.5). +#pragma warning(disable: 26496) // The variable '...' does not change after construction, mark it as const (con.4). +#pragma warning(disable: 26497) // The function '...' could be marked constexpr if compile-time evaluation is desired (f.4). +#pragma warning(disable: 26475) // Do not use function style casts (es.49). Prefer '...' over '...'. +#pragma warning(disable: 26495) // Variable '...' is uninitialized. Always initialize a member variable (type.6). +#pragma warning(disable: 26461) // The pointer argument '...' for function '...' can be marked as a pointer to const (con.3). +#pragma warning(disable: 26462) // The value pointed to by '...' is assigned only once, mark it as a pointer to const (con.4). +#pragma warning(disable: 26494) // Variable '...' is uninitialized. Always initialize an object (type.5). +#pragma warning(disable: 26489) // Don't dereference a pointer that may be invalid: '...'. '...' may have been invalidated at line ... (lifetime.1). +#pragma warning(disable: 26488) // Do not dereference a potentially null pointer : ...'. '...' was null at line ... (lifetime.1). +#pragma warning(disable: 26447) // The function is declared '...' but calls function '..' which may throw exceptions (f.6). +#pragma warning(disable: 26485) // Expression '...': No array to pointer decay (bounds.3). +#pragma warning(disable: 26457) // (void) should not be used to ignore return values, use '...' instead (es.48). +#pragma warning(disable: 26487) // Don't return a pointer '...' that may be invalid (lifetime.4). +#pragma warning(disable: 26451) // Arithmetic overflow : Using operator '...' on a 4 byte value and then casting the result to a 8 byte value. Cast the value to the wider type before calling operator '...' to avoid overflow (io.2). +#pragma warning(disable: 26455) // Default constructor may not throw.Declare it 'noexcept' (f.6). +#pragma warning(disable: 26409) // Avoid calling new and delete explicitly, use std::make_unique instead (r.11). +#pragma warning(disable: 26429) // Symbol '...' is never tested for nullness, it can be marked as not_null(f.23). +#pragma warning(disable: 26400) // Do not assign the result of an allocation or a function call with an owner return value to a raw pointer, use owner instead(i.11). +#pragma warning(disable: 26467) // Converting from floating point to unsigned integral types results in non-portable code if the double/float has a negative value. Use gsl::narrow_cast or gsl::narrow instead to guard against undefined behavior and potential data loss (es.46). +#pragma warning(disable: 26823) // Dereferencing a possibly null pointer '...' (lifetime.1). +#endif // _MSC_VER #include "xml/lite/ContentHandler.h" #include "xml/lite/Attributes.h" @@ -36,6 +67,16 @@ #include "xml/lite/Serializable.h" #include "xml/lite/Validator.h" +#if _MSC_VER +#pragma warning(pop) + +#pragma comment(lib, "xml.lite-c++.lib") + +#if defined(USE_XERCES) +#pragma comment(lib, "xerces-c") +#endif +#endif + /*! * \file lite.h * @@ -50,4 +91,4 @@ * */ -#endif +#endif // CODA_OSS_xml_lite_import_lite_h_INCLUDED_ diff --git a/externals/coda-oss/modules/python/sys/source/generated/coda_sys_wrap.cxx b/externals/coda-oss/modules/python/sys/source/generated/coda_sys_wrap.cxx index 936a48dfb..f3a35131f 100644 --- a/externals/coda-oss/modules/python/sys/source/generated/coda_sys_wrap.cxx +++ b/externals/coda-oss/modules/python/sys/source/generated/coda_sys_wrap.cxx @@ -3471,20 +3471,6 @@ SWIGINTERN PyObject *_wrap_alignedFree(PyObject *SWIGUNUSEDPARM(self), PyObject } -SWIGINTERN int Swig_var_UTCDateTime_DEFAULT_DATETIME_FORMAT_set(PyObject *) { - SWIG_Error(SWIG_AttributeError,"Variable UTCDateTime_DEFAULT_DATETIME_FORMAT is read-only."); - return 1; -} - - -SWIGINTERN PyObject *Swig_var_UTCDateTime_DEFAULT_DATETIME_FORMAT_get(void) { - PyObject *pyobj = 0; - - pyobj = SWIG_FromCharPtr(sys::UTCDateTime::DEFAULT_DATETIME_FORMAT); - return pyobj; -} - - SWIGINTERN PyObject *_wrap_new_UTCDateTime__SWIG_0(PyObject *SWIGUNUSEDPARM(self), Py_ssize_t nobjs, PyObject **SWIGUNUSEDPARM(swig_obj)) { PyObject *resultobj = 0; sys::UTCDateTime *result = 0 ; @@ -4025,7 +4011,7 @@ static PyMethodDef SwigMethods[] = { "UTCDateTime(int year, int month, int day)\n" "UTCDateTime(int year, int month, int day, int hour, int minute, double second)\n" "UTCDateTime(double timeInMillis)\n" - "UTCDateTime(std::string const & time, std::string const & format=DEFAULT_DATETIME_FORMAT)\n" + "UTCDateTime(std::string const & time)\n" ""}, { "UTCDateTime_format", _wrap_UTCDateTime_format, METH_VARARGS, "\n" "format()\n" @@ -4881,7 +4867,6 @@ SWIG_init(void) { PyDict_SetItemString(md, "cvar", globals); Py_DECREF(globals); SWIG_addvarlink(globals, "SSE_INSTRUCTION_ALIGNMENT", Swig_var_SSE_INSTRUCTION_ALIGNMENT_get, Swig_var_SSE_INSTRUCTION_ALIGNMENT_set); - SWIG_addvarlink(globals, "UTCDateTime_DEFAULT_DATETIME_FORMAT", Swig_var_UTCDateTime_DEFAULT_DATETIME_FORMAT_get, Swig_var_UTCDateTime_DEFAULT_DATETIME_FORMAT_set); #if PY_VERSION_HEX >= 0x03000000 return m; #else From eeddd4fe8bde27eb5d9f040986ad178b60bc6f13 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Mon, 10 Jul 2023 11:45:25 -0400 Subject: [PATCH 028/104] build with AVX2 --- Test++/Test++.vcxproj | 2 ++ Test/Test.vcxproj | 2 ++ modules/c++/nitf-c++.vcxproj | 2 ++ modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj | 2 ++ modules/c/j2k/J2KCompress.vcxproj | 2 ++ modules/c/j2k/J2KDecompress.vcxproj | 2 ++ modules/c/nitf-c.vcxproj | 2 ++ modules/c/nitf/ACCHZB.vcxproj | 2 ++ modules/c/nitf/ACCPOB.vcxproj | 2 ++ modules/c/nitf/ACFTA.vcxproj | 2 ++ modules/c/nitf/AIMIDB.vcxproj | 2 ++ modules/c/nitf/CSCRNA.vcxproj | 2 ++ modules/c/nitf/CSEXRB.vcxproj | 4 ++-- modules/c/nitf/ENGRDA.vcxproj | 2 ++ modules/c/nitf/HISTOA.vcxproj | 2 ++ modules/c/nitf/JITCID.vcxproj | 2 ++ modules/c/nitf/PTPRAA.vcxproj | 2 ++ modules/c/nitf/RPFHDR.vcxproj | 2 ++ modules/c/nitf/XML_DATA_CONTENT.vcxproj | 2 ++ 19 files changed, 38 insertions(+), 2 deletions(-) diff --git a/Test++/Test++.vcxproj b/Test++/Test++.vcxproj index d1d7e0396..e9fdf492d 100644 --- a/Test++/Test++.vcxproj +++ b/Test++/Test++.vcxproj @@ -68,6 +68,7 @@ true true ProgramDatabase + AdvancedVectorExtensions2 Windows @@ -89,6 +90,7 @@ Guard true true + AdvancedVectorExtensions2 Windows diff --git a/Test/Test.vcxproj b/Test/Test.vcxproj index ff357b9bb..c7d1f0775 100644 --- a/Test/Test.vcxproj +++ b/Test/Test.vcxproj @@ -68,6 +68,7 @@ true true ProgramDatabase + AdvancedVectorExtensions2 Windows @@ -89,6 +90,7 @@ Guard true true + AdvancedVectorExtensions2 Windows diff --git a/modules/c++/nitf-c++.vcxproj b/modules/c++/nitf-c++.vcxproj index 37f4339fb..1271165fe 100644 --- a/modules/c++/nitf-c++.vcxproj +++ b/modules/c++/nitf-c++.vcxproj @@ -233,6 +233,7 @@ true MultiThreadedDebugDLL true + AdvancedVectorExtensions2 @@ -260,6 +261,7 @@ Speed true Level3 + AdvancedVectorExtensions2 diff --git a/modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj b/modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj index 45e85e475..fdcae537f 100644 --- a/modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj +++ b/modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj @@ -64,6 +64,7 @@ true MultiThreadedDebugDLL true + AdvancedVectorExtensions2 Console @@ -87,6 +88,7 @@ Guard true Level3 + AdvancedVectorExtensions2 Console diff --git a/modules/c/j2k/J2KCompress.vcxproj b/modules/c/j2k/J2KCompress.vcxproj index 5acb00e8e..9cb949c31 100644 --- a/modules/c/j2k/J2KCompress.vcxproj +++ b/modules/c/j2k/J2KCompress.vcxproj @@ -75,6 +75,7 @@ MultiThreadedDebugDLL true ProgramDatabase + AdvancedVectorExtensions2 @@ -98,6 +99,7 @@ CompileAsCpp Guard true + AdvancedVectorExtensions2 diff --git a/modules/c/j2k/J2KDecompress.vcxproj b/modules/c/j2k/J2KDecompress.vcxproj index 12c9a8c2b..6006e4eca 100644 --- a/modules/c/j2k/J2KDecompress.vcxproj +++ b/modules/c/j2k/J2KDecompress.vcxproj @@ -75,6 +75,7 @@ MultiThreadedDebugDLL true ProgramDatabase + AdvancedVectorExtensions2 @@ -98,6 +99,7 @@ CompileAsCpp Guard true + AdvancedVectorExtensions2 diff --git a/modules/c/nitf-c.vcxproj b/modules/c/nitf-c.vcxproj index d8961a150..b8acba06b 100644 --- a/modules/c/nitf-c.vcxproj +++ b/modules/c/nitf-c.vcxproj @@ -65,6 +65,7 @@ MultiThreadedDebugDLL true true + AdvancedVectorExtensions2 @@ -88,6 +89,7 @@ Speed true Level3 + AdvancedVectorExtensions2 diff --git a/modules/c/nitf/ACCHZB.vcxproj b/modules/c/nitf/ACCHZB.vcxproj index 00cf593d4..cf18d2390 100644 --- a/modules/c/nitf/ACCHZB.vcxproj +++ b/modules/c/nitf/ACCHZB.vcxproj @@ -75,6 +75,7 @@ MultiThreadedDebugDLL true ProgramDatabase + AdvancedVectorExtensions2 @@ -96,6 +97,7 @@ CompileAsCpp Guard true + AdvancedVectorExtensions2 diff --git a/modules/c/nitf/ACCPOB.vcxproj b/modules/c/nitf/ACCPOB.vcxproj index 5a0dfc6dd..20212f3d2 100644 --- a/modules/c/nitf/ACCPOB.vcxproj +++ b/modules/c/nitf/ACCPOB.vcxproj @@ -75,6 +75,7 @@ MultiThreadedDebugDLL true ProgramDatabase + AdvancedVectorExtensions2 @@ -96,6 +97,7 @@ CompileAsCpp Guard true + AdvancedVectorExtensions2 diff --git a/modules/c/nitf/ACFTA.vcxproj b/modules/c/nitf/ACFTA.vcxproj index 25e8dbf96..05e79a2de 100644 --- a/modules/c/nitf/ACFTA.vcxproj +++ b/modules/c/nitf/ACFTA.vcxproj @@ -75,6 +75,7 @@ MultiThreadedDebugDLL true ProgramDatabase + AdvancedVectorExtensions2 @@ -96,6 +97,7 @@ CompileAsCpp Guard true + AdvancedVectorExtensions2 diff --git a/modules/c/nitf/AIMIDB.vcxproj b/modules/c/nitf/AIMIDB.vcxproj index 1658fcd91..0f70aa7c9 100644 --- a/modules/c/nitf/AIMIDB.vcxproj +++ b/modules/c/nitf/AIMIDB.vcxproj @@ -75,6 +75,7 @@ MultiThreadedDebugDLL true ProgramDatabase + AdvancedVectorExtensions2 @@ -96,6 +97,7 @@ CompileAsCpp Guard true + AdvancedVectorExtensions2 diff --git a/modules/c/nitf/CSCRNA.vcxproj b/modules/c/nitf/CSCRNA.vcxproj index ed2deb6e3..c737b6b4b 100644 --- a/modules/c/nitf/CSCRNA.vcxproj +++ b/modules/c/nitf/CSCRNA.vcxproj @@ -75,6 +75,7 @@ MultiThreadedDebugDLL true ProgramDatabase + AdvancedVectorExtensions2 @@ -96,6 +97,7 @@ CompileAsCpp Guard true + AdvancedVectorExtensions2 diff --git a/modules/c/nitf/CSEXRB.vcxproj b/modules/c/nitf/CSEXRB.vcxproj index f86f3a408..9712bafcd 100644 --- a/modules/c/nitf/CSEXRB.vcxproj +++ b/modules/c/nitf/CSEXRB.vcxproj @@ -75,7 +75,7 @@ MultiThreadedDebugDLL true ProgramDatabase - stdc11 + AdvancedVectorExtensions2 @@ -97,7 +97,7 @@ CompileAsCpp Guard true - stdc11 + AdvancedVectorExtensions2 diff --git a/modules/c/nitf/ENGRDA.vcxproj b/modules/c/nitf/ENGRDA.vcxproj index a44d75b6f..aaa867344 100644 --- a/modules/c/nitf/ENGRDA.vcxproj +++ b/modules/c/nitf/ENGRDA.vcxproj @@ -75,6 +75,7 @@ MultiThreadedDebugDLL true ProgramDatabase + AdvancedVectorExtensions2 @@ -96,6 +97,7 @@ CompileAsCpp Guard true + AdvancedVectorExtensions2 diff --git a/modules/c/nitf/HISTOA.vcxproj b/modules/c/nitf/HISTOA.vcxproj index 25e058963..f186bc6c9 100644 --- a/modules/c/nitf/HISTOA.vcxproj +++ b/modules/c/nitf/HISTOA.vcxproj @@ -75,6 +75,7 @@ MultiThreadedDebugDLL true ProgramDatabase + AdvancedVectorExtensions2 @@ -96,6 +97,7 @@ CompileAsCpp Guard true + AdvancedVectorExtensions2 diff --git a/modules/c/nitf/JITCID.vcxproj b/modules/c/nitf/JITCID.vcxproj index e4982a9d7..37b29b98e 100644 --- a/modules/c/nitf/JITCID.vcxproj +++ b/modules/c/nitf/JITCID.vcxproj @@ -75,6 +75,7 @@ MultiThreadedDebugDLL true ProgramDatabase + AdvancedVectorExtensions2 @@ -96,6 +97,7 @@ CompileAsCpp Guard true + AdvancedVectorExtensions2 diff --git a/modules/c/nitf/PTPRAA.vcxproj b/modules/c/nitf/PTPRAA.vcxproj index 03a08a5a1..d0a975671 100644 --- a/modules/c/nitf/PTPRAA.vcxproj +++ b/modules/c/nitf/PTPRAA.vcxproj @@ -75,6 +75,7 @@ MultiThreadedDebugDLL true ProgramDatabase + AdvancedVectorExtensions2 @@ -96,6 +97,7 @@ CompileAsCpp Guard true + AdvancedVectorExtensions2 diff --git a/modules/c/nitf/RPFHDR.vcxproj b/modules/c/nitf/RPFHDR.vcxproj index c57006a40..a2858247e 100644 --- a/modules/c/nitf/RPFHDR.vcxproj +++ b/modules/c/nitf/RPFHDR.vcxproj @@ -75,6 +75,7 @@ MultiThreadedDebugDLL true ProgramDatabase + AdvancedVectorExtensions2 @@ -96,6 +97,7 @@ CompileAsCpp Guard true + AdvancedVectorExtensions2 diff --git a/modules/c/nitf/XML_DATA_CONTENT.vcxproj b/modules/c/nitf/XML_DATA_CONTENT.vcxproj index af32e16df..a243a545b 100644 --- a/modules/c/nitf/XML_DATA_CONTENT.vcxproj +++ b/modules/c/nitf/XML_DATA_CONTENT.vcxproj @@ -75,6 +75,7 @@ MultiThreadedDebugDLL true ProgramDatabase + AdvancedVectorExtensions2 @@ -96,6 +97,7 @@ CompileAsCpp Guard true + AdvancedVectorExtensions2 From 786e467447eb1984185b76d940415e46d69071eb Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Mon, 10 Jul 2023 11:56:51 -0400 Subject: [PATCH 029/104] build coda-oss project --- externals/coda-oss/modules/c++/coda-oss.vcxproj | 8 ++++---- nitro.sln | 9 +++++++++ 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/externals/coda-oss/modules/c++/coda-oss.vcxproj b/externals/coda-oss/modules/c++/coda-oss.vcxproj index 71ae2208d..cf43fef62 100644 --- a/externals/coda-oss/modules/c++/coda-oss.vcxproj +++ b/externals/coda-oss/modules/c++/coda-oss.vcxproj @@ -574,7 +574,7 @@ true _DEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL;MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 pch.h - cli\include\;coda_oss\include;config\include\;dbi\include\;except\include\;gsl\include\;hdf5.lite\include\;io\include\;logging\include\;math\include\;math.linear\include\;math.poly\include\;mem\include\;mt\include\;net\include\;net.ssl\include\;plugin\include\;polygon\include\;re\include\;sio.lite\include\;std\include\;str\include\;sys\include\;tiff\include;types\include\;unique\include\;units\include\;xml.lite\include\;zip\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ + cli\include\;coda_oss\include;config\include\;dbi\include\;except\include\;gsl\include\;hdf5.lite\include\;io\include\;logging\include\;math\include\;math.linear\include\;math.poly\include\;mem\include\;mt\include\;net\include\;net.ssl\include\;plugin\include\;polygon\include\;re\include\;sio.lite\include\;std\include\;str\include\;sys\include\;tiff\include;types\include\;unique\include\;units\include\;xml.lite\include\;zip\include\;$(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ Use pch.h true @@ -593,7 +593,7 @@ true - $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\ + $(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\ hdf5-c++.lib;z.lib;minizip.lib;xerces-c.lib;rpcrt4.lib;%(AdditionalDependencies) @@ -605,7 +605,7 @@ true NDEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL;MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 pch.h - cli\include\;coda_oss\include;config\include\;dbi\include\;except\include\;gsl\include\;hdf5.lite\include\;io\include\;logging\include\;math\include\;math.linear\include\;math.poly\include\;mem\include\;mt\include\;net\include\;net.ssl\include\;plugin\include\;polygon\include\;re\include\;sio.lite\include\;std\include\;str\include\;sys\include\;tiff\include;types\include\;unique\include\;units\include\;xml.lite\include\;zip\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ + cli\include\;coda_oss\include;config\include\;dbi\include\;except\include\;gsl\include\;hdf5.lite\include\;io\include\;logging\include\;math\include\;math.linear\include\;math.poly\include\;mem\include\;mt\include\;net\include\;net.ssl\include\;plugin\include\;polygon\include\;re\include\;sio.lite\include\;std\include\;str\include\;sys\include\;tiff\include;types\include\;unique\include\;units\include\;xml.lite\include\;zip\include\;$(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ Use pch.h true @@ -623,7 +623,7 @@ true true true - $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\ + $(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\ hdf5-c++.lib;z.lib;minizip.lib;xerces-c.lib;rpcrt4.lib;%(AdditionalDependencies) diff --git a/nitro.sln b/nitro.sln index edc29f5c5..d7e22ef78 100644 --- a/nitro.sln +++ b/nitro.sln @@ -65,6 +65,10 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "workflows", "workflows", "{ EndProject Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "CSEXRB", "modules\c\nitf\CSEXRB.vcxproj", "{0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E}" EndProject +Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "externals", "externals", "{7D26D571-0014-4C50-BF86-612E743E64B6}" +EndProject +Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "coda-oss", "externals\coda-oss\modules\c++\coda-oss.vcxproj", "{9997E895-5161-4DDF-8F3F-099894CB2F21}" +EndProject Global GlobalSection(SolutionConfigurationPlatforms) = preSolution Debug|x64 = Debug|x64 @@ -147,6 +151,10 @@ Global {0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E}.Debug|x64.Build.0 = Debug|x64 {0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E}.Release|x64.ActiveCfg = Release|x64 {0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E}.Release|x64.Build.0 = Release|x64 + {9997E895-5161-4DDF-8F3F-099894CB2F21}.Debug|x64.ActiveCfg = Debug|x64 + {9997E895-5161-4DDF-8F3F-099894CB2F21}.Debug|x64.Build.0 = Debug|x64 + {9997E895-5161-4DDF-8F3F-099894CB2F21}.Release|x64.ActiveCfg = Release|x64 + {9997E895-5161-4DDF-8F3F-099894CB2F21}.Release|x64.Build.0 = Release|x64 EndGlobalSection GlobalSection(SolutionProperties) = preSolution HideSolutionNode = FALSE @@ -168,6 +176,7 @@ Global {A45CB073-25A7-411D-A7E7-589BCC8AF547} = {5C5727E7-0CFF-42B4-8F5A-D31B3BC81F21} {AC22B9D3-0749-486F-A8F2-D6977BF9505D} = {A45CB073-25A7-411D-A7E7-589BCC8AF547} {0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E} = {27A2685A-E869-42A2-956D-92994F60C536} + {9997E895-5161-4DDF-8F3F-099894CB2F21} = {7D26D571-0014-4C50-BF86-612E743E64B6} EndGlobalSection GlobalSection(ExtensibilityGlobals) = postSolution SolutionGuid = {2D7AC542-BBB6-4BAC-8BF1-7E76C714BBA4} From e37e724f379f979b64f6db8e98400436dd34016f Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Mon, 10 Jul 2023 12:00:41 -0400 Subject: [PATCH 030/104] 'build' -> 'out' to match Visual Studio --- .github/workflows/frequent_check.yml | 16 ++++++++-------- .github/workflows/main.yml | 14 +++++++------- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/.github/workflows/frequent_check.yml b/.github/workflows/frequent_check.yml index 28857d3e7..b989da809 100644 --- a/.github/workflows/frequent_check.yml +++ b/.github/workflows/frequent_check.yml @@ -16,17 +16,17 @@ jobs: python-version: '3.7' - name: configure run: | - mkdir build - cd build + mkdir out + cd out cmake -DCMAKE_INSTALL_PREFIX=installWindows-Github -DPYTHON_VERSION="3.7" .. - name: make run: | - cd build + cd out cmake --build . --config Release -j cmake --build . --config Release --target install - name: test run: | - cd build + cd out ctest -C Release --output-on-failure build-linux: @@ -41,16 +41,16 @@ jobs: python-version: '3.7' - name: configure run: | - mkdir build - cd build + mkdir out + cd out cmake -DCMAKE_INSTALL_PREFIX=installLinux-Github -DPYTHON_VERSION=3.7 .. - name: make run: | - cd build + cd out # using the default number of threads (-j) causes G++ to crash cmake --build . -j 6 cmake --build . --target install - name: test run: | - cd build + cd out ctest --output-on-failure diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 8df40ccc1..5c0013b0d 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -20,17 +20,17 @@ jobs: python-version: '3.7' - name: configure run: | - mkdir build - cd build + mkdir out + cd out cmake -DCMAKE_INSTALL_PREFIX=installWindows-Github -DPYTHON_VERSION="3.7" .. - name: make run: | - cd build + cd out cmake --build . --config Release -j cmake --build . --config Release --target install - name: test run: | - cd build + cd out ctest -C Release build-linux: @@ -45,18 +45,18 @@ jobs: python-version: '3.7' - name: configure run: | - mkdir build + mkdir out cd build cmake -DCMAKE_INSTALL_PREFIX=installLinux-Github -DPYTHON_VERSION=3.7 .. - name: make run: | - cd build + cd out # using the default number of threads (-j) causes G++ to crash cmake --build . -j 6 cmake --build . --target install - name: test run: | - cd build + cd out ctest From 75b07f96582efdccbff71370f9bc4fcd5a2a9745 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Mon, 10 Jul 2023 12:03:20 -0400 Subject: [PATCH 031/104] try to build NITRO.SLN --- .github/workflows/frequent_check.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.github/workflows/frequent_check.yml b/.github/workflows/frequent_check.yml index b989da809..1e121fec9 100644 --- a/.github/workflows/frequent_check.yml +++ b/.github/workflows/frequent_check.yml @@ -28,6 +28,17 @@ jobs: run: | cd out ctest -C Release --output-on-failure + - name: Add msbuild to PATH + uses: microsoft/setup-msbuild@v1.1 + with: + msbuild-architecture: x64 + - name: msbuild + run: | + msbuild nitro.sln /p:configuration=Release + #- name: mstest + # run: | + # mstest /testcontainer:${RUNNER_WORKSPACE}\coda-oss\x64\Releast\Test.dll + # mstest /testcontainer:${RUNNER_WORKSPACE}\coda-oss\x64\Releast\Test++.dll build-linux: name: Linux From 804f38e55cbf81f344f16af6693a7914da413218 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Mon, 10 Jul 2023 12:56:27 -0400 Subject: [PATCH 032/104] build coda-oss with "nitro" install --- CMakeLists.txt | 6 ------ externals/coda-oss/modules/c++/coda-oss.vcxproj | 8 ++++---- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index eb788b537..6bd74b735 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -36,12 +36,6 @@ if (${CMAKE_PROJECT_NAME} STREQUAL nitro) coda_initialize_build() else() # build coda-oss ourselves - - # disable some unneeded drivers from coda-oss - set(ENABLE_PCRE OFF CACHE BOOL "enable PCRE library" FORCE) - set(ENABLE_UUID OFF CACHE BOOL "enable uuid library" FORCE) - set(ENABLE_ZIP OFF CACHE BOOL "enable ZIP library" FORCE) - set(CODA_OSS_DIR "coda-oss") list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/externals/${CODA_OSS_DIR}/cmake") diff --git a/externals/coda-oss/modules/c++/coda-oss.vcxproj b/externals/coda-oss/modules/c++/coda-oss.vcxproj index cf43fef62..b0c706116 100644 --- a/externals/coda-oss/modules/c++/coda-oss.vcxproj +++ b/externals/coda-oss/modules/c++/coda-oss.vcxproj @@ -574,7 +574,7 @@ true _DEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL;MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 pch.h - cli\include\;coda_oss\include;config\include\;dbi\include\;except\include\;gsl\include\;hdf5.lite\include\;io\include\;logging\include\;math\include\;math.linear\include\;math.poly\include\;mem\include\;mt\include\;net\include\;net.ssl\include\;plugin\include\;polygon\include\;re\include\;sio.lite\include\;std\include\;str\include\;sys\include\;tiff\include;types\include\;unique\include\;units\include\;xml.lite\include\;zip\include\;$(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ + cli\include\;coda_oss\include;config\include\;dbi\include\;except\include\;gsl\include\;hdf5.lite\include\;io\include\;logging\include\;math\include\;math.linear\include\;math.poly\include\;mem\include\;mt\include\;net\include\;net.ssl\include\;plugin\include\;polygon\include\;re\include\;sio.lite\include\;std\include\;str\include\;sys\include\;tiff\include;types\include\;unique\include\;units\include\;xml.lite\include\;zip\include\;$(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ Use pch.h true @@ -593,7 +593,7 @@ true - $(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\ + $(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\ hdf5-c++.lib;z.lib;minizip.lib;xerces-c.lib;rpcrt4.lib;%(AdditionalDependencies) @@ -605,7 +605,7 @@ true NDEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL;MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 pch.h - cli\include\;coda_oss\include;config\include\;dbi\include\;except\include\;gsl\include\;hdf5.lite\include\;io\include\;logging\include\;math\include\;math.linear\include\;math.poly\include\;mem\include\;mt\include\;net\include\;net.ssl\include\;plugin\include\;polygon\include\;re\include\;sio.lite\include\;std\include\;str\include\;sys\include\;tiff\include;types\include\;unique\include\;units\include\;xml.lite\include\;zip\include\;$(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ + cli\include\;coda_oss\include;config\include\;dbi\include\;except\include\;gsl\include\;hdf5.lite\include\;io\include\;logging\include\;math\include\;math.linear\include\;math.poly\include\;mem\include\;mt\include\;net\include\;net.ssl\include\;plugin\include\;polygon\include\;re\include\;sio.lite\include\;std\include\;str\include\;sys\include\;tiff\include;types\include\;unique\include\;units\include\;xml.lite\include\;zip\include\;$(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ Use pch.h true @@ -623,7 +623,7 @@ true true true - $(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\ + $(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\ hdf5-c++.lib;z.lib;minizip.lib;xerces-c.lib;rpcrt4.lib;%(AdditionalDependencies) From 693e139ce9806075201ad430d49b39c0be2f84a3 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Mon, 10 Jul 2023 13:14:51 -0400 Subject: [PATCH 033/104] more closely match YAML from CODA-OSS --- .github/workflows/frequent_check.yml | 38 ++++++++++++++++------------ 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/.github/workflows/frequent_check.yml b/.github/workflows/frequent_check.yml index 1e121fec9..acfd197e8 100644 --- a/.github/workflows/frequent_check.yml +++ b/.github/workflows/frequent_check.yml @@ -4,9 +4,12 @@ on: [push] jobs: - build-windows: - name: Windows - runs-on: [windows-latest] + build-cmake-windows: + strategy: + matrix: + os: [windows-latest] + name: ${{ matrix.os }}-CMake + runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v2 @@ -16,17 +19,17 @@ jobs: python-version: '3.7' - name: configure run: | - mkdir out - cd out - cmake -DCMAKE_INSTALL_PREFIX=installWindows-Github -DPYTHON_VERSION="3.7" .. + mkdir target-Release + cd target-Release + cmake -DCMAKE_INSTALL_PREFIX=install${{ matrix.os }}CMake-Github -DPYTHON_VERSION="3.7" .. - name: make run: | - cd out + cd target-Release cmake --build . --config Release -j cmake --build . --config Release --target install - name: test run: | - cd out + cd target-Release ctest -C Release --output-on-failure - name: Add msbuild to PATH uses: microsoft/setup-msbuild@v1.1 @@ -40,9 +43,12 @@ jobs: # mstest /testcontainer:${RUNNER_WORKSPACE}\coda-oss\x64\Releast\Test.dll # mstest /testcontainer:${RUNNER_WORKSPACE}\coda-oss\x64\Releast\Test++.dll - build-linux: - name: Linux - runs-on: [ubuntu-latest] + build-linux-cmake: + strategy: + matrix: + os: [ubuntu-latest] + name: ${{ matrix.os }}-CMake + runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v2 @@ -52,16 +58,16 @@ jobs: python-version: '3.7' - name: configure run: | - mkdir out - cd out - cmake -DCMAKE_INSTALL_PREFIX=installLinux-Github -DPYTHON_VERSION=3.7 .. + mkdir target + cd target + cmake -DCMAKE_INSTALL_PREFIX=install${{ matrix.os }}CMake-Github -DPYTHON_VERSION=3.7 .. - name: make run: | - cd out + cd target # using the default number of threads (-j) causes G++ to crash cmake --build . -j 6 cmake --build . --target install - name: test run: | - cd out + cd target ctest --output-on-failure From 13b134b27fdbaa662e67f958371ec676de2e34ef Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Mon, 10 Jul 2023 13:36:23 -0400 Subject: [PATCH 034/104] adjust paths for NITRO install --- Test++/Test++.vcxproj | 8 ++++---- Test/Test.vcxproj | 8 ++++---- modules/c++/nitf-c++.vcxproj | 4 ++-- modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj | 8 ++++---- modules/c/j2k/J2KCompress.vcxproj | 4 ++-- modules/c/j2k/J2KDecompress.vcxproj | 4 ++-- modules/c/nitf-c.vcxproj | 4 ++-- 7 files changed, 20 insertions(+), 20 deletions(-) diff --git a/Test++/Test++.vcxproj b/Test++/Test++.vcxproj index e9fdf492d..19fff43f6 100644 --- a/Test++/Test++.vcxproj +++ b/Test++/Test++.vcxproj @@ -57,7 +57,7 @@ Use EnableAllWarnings true - $(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)modules\c\;$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + $(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)modules\c\;$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories);$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ _DEBUG;%(PreprocessorDefinitions) true pch.h @@ -72,7 +72,7 @@ Windows - $(VCInstallDir)UnitTest\lib;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) + $(VCInstallDir)UnitTest\lib;$(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;%(AdditionalLibraryDirectories) @@ -82,7 +82,7 @@ true true true - $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories);$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ NDEBUG;%(PreprocessorDefinitions) true pch.h @@ -96,7 +96,7 @@ Windows true true - $(VCInstallDir)UnitTest\lib;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) + $(VCInstallDir)UnitTest\lib;$(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;%(AdditionalLibraryDirectories) diff --git a/Test/Test.vcxproj b/Test/Test.vcxproj index c7d1f0775..3f3723594 100644 --- a/Test/Test.vcxproj +++ b/Test/Test.vcxproj @@ -57,7 +57,7 @@ Use EnableAllWarnings true - $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) _DEBUG;%(PreprocessorDefinitions) true pch.h @@ -72,7 +72,7 @@ Windows - $(VCInstallDir)UnitTest\lib;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) + $(VCInstallDir)UnitTest\lib;$(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;%(AdditionalLibraryDirectories) @@ -82,7 +82,7 @@ true true true - $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) NDEBUG;%(PreprocessorDefinitions) true pch.h @@ -96,7 +96,7 @@ Windows true true - $(VCInstallDir)UnitTest\lib;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\;%(AdditionalLibraryDirectories) + $(VCInstallDir)UnitTest\lib;$(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;%(AdditionalLibraryDirectories) diff --git a/modules/c++/nitf-c++.vcxproj b/modules/c++/nitf-c++.vcxproj index 1271165fe..7a9669171 100644 --- a/modules/c++/nitf-c++.vcxproj +++ b/modules/c++/nitf-c++.vcxproj @@ -219,7 +219,7 @@ true _DEBUG;%(PreprocessorDefinitions) true - $(ProjectDir)nitf\include\;$(ProjectDir)..\c\nrt\include\;$(ProjectDir)..\c\nitf\include\;$(ProjectDir)..\c\j2k\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\ + $(ProjectDir)nitf\include\;$(ProjectDir)..\c\nrt\include\;$(ProjectDir)..\c\nitf\include\;$(ProjectDir)..\c\j2k\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ Use pch.h pch.h @@ -252,7 +252,7 @@ true NDEBUG;%(PreprocessorDefinitions) true - $(ProjectDir)nitf\include\;$(ProjectDir)..\c\nrt\include\;$(ProjectDir)..\c\nitf\include\;$(ProjectDir)..\c\j2k\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\ + $(ProjectDir)nitf\include\;$(ProjectDir)..\c\nrt\include\;$(ProjectDir)..\c\nitf\include\;$(ProjectDir)..\c\j2k\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ Use pch.h pch.h diff --git a/modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj b/modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj index fdcae537f..1ab273b98 100644 --- a/modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj +++ b/modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj @@ -51,7 +51,7 @@ true _DEBUG;_CONSOLE;%(PreprocessorDefinitions) true - $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\ + $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ Use pch.h pch.h @@ -69,7 +69,7 @@ Console true - $(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\ + $(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\ @@ -79,7 +79,7 @@ true NDEBUG;_CONSOLE;%(PreprocessorDefinitions) true - $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\ + $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ Use pch.h pch.h @@ -95,7 +95,7 @@ true true true - $(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\ + $(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\ diff --git a/modules/c/j2k/J2KCompress.vcxproj b/modules/c/j2k/J2KCompress.vcxproj index 9cb949c31..80e6ea531 100644 --- a/modules/c/j2k/J2KCompress.vcxproj +++ b/modules/c/j2k/J2KCompress.vcxproj @@ -81,7 +81,7 @@ true - $(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\ + $(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\ openjpeg.lib;%(AdditionalDependencies) @@ -107,7 +107,7 @@ true true true - $(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\ + $(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\ openjpeg.lib;%(AdditionalDependencies) diff --git a/modules/c/j2k/J2KDecompress.vcxproj b/modules/c/j2k/J2KDecompress.vcxproj index 6006e4eca..2010203c4 100644 --- a/modules/c/j2k/J2KDecompress.vcxproj +++ b/modules/c/j2k/J2KDecompress.vcxproj @@ -81,7 +81,7 @@ true - $(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\ + $(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\ openjpeg.lib;%(AdditionalDependencies) @@ -107,7 +107,7 @@ true true true - $(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\lib\ + $(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\ openjpeg.lib;%(AdditionalDependencies) diff --git a/modules/c/nitf-c.vcxproj b/modules/c/nitf-c.vcxproj index b8acba06b..45fa8fa67 100644 --- a/modules/c/nitf-c.vcxproj +++ b/modules/c/nitf-c.vcxproj @@ -52,7 +52,7 @@ true _DEBUG;%(PreprocessorDefinitions);HAVE_OPENJPEG_H true - $(ProjectDir)nrt\include\;$(ProjectDir)nitf\include\;$(ProjectDir)jpeg\include\;$(ProjectDir)j2k\include\;$(ProjectDir)cgm\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;%(AdditionalIncludeDirectories) + $(ProjectDir)nrt\include\;$(ProjectDir)nitf\include\;$(ProjectDir)jpeg\include\;$(ProjectDir)j2k\include\;$(ProjectDir)cgm\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;%(AdditionalIncludeDirectories) Use pch.h pch.h @@ -80,7 +80,7 @@ true NDEBUG;%(PreprocessorDefinitions);HAVE_OPENJPEG_H true - $(ProjectDir)nrt\include\;$(ProjectDir)nitf\include\;$(ProjectDir)jpeg\include\;$(ProjectDir)j2k\include\;$(ProjectDir)cgm\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;%(AdditionalIncludeDirectories) + $(ProjectDir)nrt\include\;$(ProjectDir)nitf\include\;$(ProjectDir)jpeg\include\;$(ProjectDir)j2k\include\;$(ProjectDir)cgm\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;%(AdditionalIncludeDirectories) Use pch.h pch.h From 95a892e41f72d3d1866f88ebec319ef9966e6d1d Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Mon, 10 Jul 2023 13:53:39 -0400 Subject: [PATCH 035/104] restore changes from "main" --- modules/c++/nitf/include/nitf/ByteProvider.hpp | 14 +++++++------- .../include/nitf/CompressedByteProvider.hpp | 2 +- modules/c++/nitf/include/nitf/ImageBlocker.hpp | 8 ++++---- modules/c++/nitf/include/nitf/ImageReader.hpp | 2 +- .../c++/nitf/include/nitf/NITFBufferList.hpp | 2 +- .../c++/nitf/include/nitf/SegmentSource.hpp | 4 ++-- modules/c++/nitf/source/ByteProvider.cpp | 6 +++--- .../c++/nitf/source/CompressedByteProvider.cpp | 4 ++-- modules/c++/nitf/source/NITFBufferList.cpp | 2 +- .../nitf/unittests/test_nitf_buffer_list.cpp | 18 +++++++++--------- 10 files changed, 31 insertions(+), 31 deletions(-) diff --git a/modules/c++/nitf/include/nitf/ByteProvider.hpp b/modules/c++/nitf/include/nitf/ByteProvider.hpp index bd9de9fa7..6cf59f90a 100644 --- a/modules/c++/nitf/include/nitf/ByteProvider.hpp +++ b/modules/c++/nitf/include/nitf/ByteProvider.hpp @@ -134,7 +134,7 @@ struct NITRO_NITFCPP_API ByteProvider } //! \return The raw file header bytes - const std::vector& getFileHeader() const noexcept + const std::vector& getFileHeader() const noexcept { return mFileHeader; } @@ -144,7 +144,7 @@ struct NITRO_NITFCPP_API ByteProvider * \return The raw bytes for each image subheader. Vector size matches the * number of image segments. */ - const std::vector >& getImageSubheaders() const noexcept + const std::vector >& getImageSubheaders() const noexcept { return mImageSubheaders; } @@ -154,7 +154,7 @@ struct NITRO_NITFCPP_API ByteProvider * \return The raw bytes for each DES (subheader immediately followed by * raw DES data). Vector size matches the number of data extension segments. */ - const std::vector& getDesSubheaderAndData() const noexcept + const std::vector& getDesSubheaderAndData() const noexcept { return mDesSubheaderAndData; } @@ -273,7 +273,7 @@ struct NITRO_NITFCPP_API ByteProvider size_t numRowsPerBlock = 0, size_t numColsPerBlock = 0); static void copyFromStreamAndClear(io::ByteStream& stream, - std::vector& rawBytes); + std::vector& rawBytes); static void copyFromStreamAndClear(io::ByteStream& stream, std::vector& rawBytes); @@ -366,11 +366,11 @@ struct NITRO_NITFCPP_API ByteProvider std::vector mImageSegmentInfo; // Per segment - std::vector mFileHeader; - std::vector > mImageSubheaders; // Per segment + std::vector mFileHeader; + std::vector > mImageSubheaders; // Per segment // All DES subheaders and data together contiguously - std::vector mDesSubheaderAndData; + std::vector mDesSubheaderAndData; std::vector mImageSubheaderFileOffsets; // Per segment nitf::Off mDesSubheaderFileOffset = 0; diff --git a/modules/c++/nitf/include/nitf/CompressedByteProvider.hpp b/modules/c++/nitf/include/nitf/CompressedByteProvider.hpp index 7f97b8039..0f3fa117b 100644 --- a/modules/c++/nitf/include/nitf/CompressedByteProvider.hpp +++ b/modules/c++/nitf/include/nitf/CompressedByteProvider.hpp @@ -179,7 +179,7 @@ struct NITRO_NITFCPP_API CompressedByteProvider : public ByteProvider size_t seg, size_t startRow, size_t numRowsToWrite, - const nitf::byte* imageData, + const sys::byte* imageData, nitf::Off& fileOffset, NITFBufferList& buffers) const; size_t addImageData( diff --git a/modules/c++/nitf/include/nitf/ImageBlocker.hpp b/modules/c++/nitf/include/nitf/ImageBlocker.hpp index 7252e50a1..f328226c4 100644 --- a/modules/c++/nitf/include/nitf/ImageBlocker.hpp +++ b/modules/c++/nitf/include/nitf/ImageBlocker.hpp @@ -279,11 +279,11 @@ struct NITRO_NITFCPP_API ImageBlocker /*final*/ // no "final", SWIG doesn't li size_t& lastBlockWithinLastSeg) const; void blockImpl(size_t seg, - const nitf::byte* input, + const sys::byte* input, size_t numValidRowsInBlock, size_t numValidColsInBlock, size_t numBytesPerPixel, - nitf::byte* output) const noexcept + sys::byte* output) const noexcept { block(input, numBytesPerPixel, mNumCols, mNumRowsPerBlock[seg], mNumColsPerBlock, numValidRowsInBlock, numValidColsInBlock, @@ -336,10 +336,10 @@ struct NITRO_NITFCPP_API ImageBlocker /*final*/ // no "final", SWIG doesn't li input += mNumCols * numBytesPerPixel * (numValidRowsInBlock - 1); } void blockAcrossRow(size_t seg, - const nitf::byte*& input, + const sys::byte*& input, size_t numValidRowsInBlock, size_t numBytesPerPixel, - nitf::byte*& output) const noexcept + sys::byte*& output) const noexcept { blockAcrossRowImpl(seg, input, numValidRowsInBlock, numBytesPerPixel, output); } diff --git a/modules/c++/nitf/include/nitf/ImageReader.hpp b/modules/c++/nitf/include/nitf/ImageReader.hpp index efe7057db..38ebc139e 100644 --- a/modules/c++/nitf/include/nitf/ImageReader.hpp +++ b/modules/c++/nitf/include/nitf/ImageReader.hpp @@ -129,7 +129,7 @@ DECLARE_CLASS(ImageReader) * \param padded Returns TRUE if pad pixels may have been read */ void read(const nitf::SubWindow & subWindow, uint8_t ** user, int * padded); - void read(const nitf::SubWindow & subWindow, nitf::byte** user, int * padded) + void read(const nitf::SubWindow & subWindow, sys::byte** user, int * padded) { void* user_ = user; read(subWindow, static_cast(user_), padded); diff --git a/modules/c++/nitf/include/nitf/NITFBufferList.hpp b/modules/c++/nitf/include/nitf/NITFBufferList.hpp index 17251e347..e03c6c707 100644 --- a/modules/c++/nitf/include/nitf/NITFBufferList.hpp +++ b/modules/c++/nitf/include/nitf/NITFBufferList.hpp @@ -170,7 +170,7 @@ struct NITRO_NITFCPP_API NITFBufferList */ const void* getBlock(size_t blockSize, size_t blockIdx, - std::vector& scratch, + std::vector& scratch, size_t& numBytes) const; const void* getBlock(size_t blockSize, size_t blockIdx, diff --git a/modules/c++/nitf/include/nitf/SegmentSource.hpp b/modules/c++/nitf/include/nitf/SegmentSource.hpp index 70c55bb66..3a53c3c25 100644 --- a/modules/c++/nitf/include/nitf/SegmentSource.hpp +++ b/modules/c++/nitf/include/nitf/SegmentSource.hpp @@ -71,7 +71,7 @@ struct NITRO_NITFCPP_API SegmentMemorySource : public SegmentSource * \param copyData Whether or not to make a copy of the data. If this is * false, the data must outlive the memory source. */ - SegmentMemorySource(const nitf::byte* data, nitf::Off size, nitf::Off start, + SegmentMemorySource(const sys::byte* data, nitf::Off size, nitf::Off start, int byteSkip, bool copyData); SegmentMemorySource(std::span data, nitf::Off start, @@ -80,7 +80,7 @@ struct NITRO_NITFCPP_API SegmentMemorySource : public SegmentSource int byteSkip, bool copyData); SegmentMemorySource(const std::vector& data, nitf::Off start, int byteSkip, bool copyData); - SegmentMemorySource(const std::vector& data, nitf::Off start, + SegmentMemorySource(const std::vector& data, nitf::Off start, int byteSkip, bool copyData); SegmentMemorySource(const std::string& data, nitf::Off start, int byteSkip, bool copyData); diff --git a/modules/c++/nitf/source/ByteProvider.cpp b/modules/c++/nitf/source/ByteProvider.cpp index 12535402b..c908b2a8c 100644 --- a/modules/c++/nitf/source/ByteProvider.cpp +++ b/modules/c++/nitf/source/ByteProvider.cpp @@ -78,7 +78,7 @@ static void copyFromStreamAndClear_(io::ByteStream& stream, stream.clear(); } void ByteProvider::copyFromStreamAndClear(io::ByteStream& stream, - std::vector& rawBytes) + std::vector& rawBytes) { copyFromStreamAndClear_(stream, rawBytes); } @@ -474,7 +474,7 @@ void ByteProvider::addImageData( const size_t startLocalRowToWrite = startGlobalRowToWrite - startRow + numPadRowsSoFar; const auto imageDataPtr = - static_cast(imageData) + + static_cast(imageData) + startLocalRowToWrite * mNumBytesPerRow; if (buffers.empty()) @@ -631,7 +631,7 @@ void ByteProvider::getBytes(const void* imageData, } } -static std::span make_span(const std::vector& v) noexcept +static std::span make_span(const std::vector& v) noexcept { const void* const pData = v.data(); return sys::make_span(static_cast(pData), v.size()); diff --git a/modules/c++/nitf/source/CompressedByteProvider.cpp b/modules/c++/nitf/source/CompressedByteProvider.cpp index bd01f13a9..bb15773b0 100644 --- a/modules/c++/nitf/source/CompressedByteProvider.cpp +++ b/modules/c++/nitf/source/CompressedByteProvider.cpp @@ -170,7 +170,7 @@ types::Range CompressedByteProvider::findBlocksToWrite( #undef max template static size_t addImageData_(const std::vector > mBytesInEachBlock, - const std::vector >& mImageSubheaders, + const std::vector >& mImageSubheaders, const std::vector& mImageSubheaderFileOffsets, const types::Range& blockRange, size_t seg, @@ -218,7 +218,7 @@ size_t CompressedByteProvider::addImageData( size_t seg, size_t startRow, size_t numRowsToWrite, - const nitf::byte* imageData, + const sys::byte* imageData, nitf::Off& fileOffset, NITFBufferList& buffers) const { diff --git a/modules/c++/nitf/source/NITFBufferList.cpp b/modules/c++/nitf/source/NITFBufferList.cpp index 49d49a7f0..365157695 100644 --- a/modules/c++/nitf/source/NITFBufferList.cpp +++ b/modules/c++/nitf/source/NITFBufferList.cpp @@ -144,7 +144,7 @@ const void* getBlock_(const std::vector& mBuffers, } const void* NITFBufferList::getBlock(size_t blockSize, size_t blockIdx, - std::vector& scratch, + std::vector& scratch, size_t& numBytes) const { numBytes = getNumBytesInBlock(blockSize, blockIdx); diff --git a/modules/c++/nitf/unittests/test_nitf_buffer_list.cpp b/modules/c++/nitf/unittests/test_nitf_buffer_list.cpp index 0e136b771..06a07dfa6 100644 --- a/modules/c++/nitf/unittests/test_nitf_buffer_list.cpp +++ b/modules/c++/nitf/unittests/test_nitf_buffer_list.cpp @@ -45,18 +45,18 @@ TEST_CASE(testGetNumBlocks) TEST_CASE(testGetBlock_sys_byte) { // 100 total bytes - std::vector buffer(100); + std::vector buffer(100); for (size_t ii = 0; ii < buffer.size(); ++ii) { - buffer[ii] = static_cast(rand() % 256); + buffer[ii] = static_cast(rand() % 256); } // Break this into a few pieces - std::vector buffer1(buffer.begin(), buffer.begin() + 10); - std::vector buffer2(buffer.begin() + 10, buffer.begin() + 20); - std::vector buffer3(buffer.begin() + 20, buffer.begin() + 35); - std::vector buffer4(buffer.begin() + 35, buffer.begin() + 57); - std::vector buffer5(buffer.begin() + 57, buffer.end()); + std::vector buffer1(buffer.begin(), buffer.begin() + 10); + std::vector buffer2(buffer.begin() + 10, buffer.begin() + 20); + std::vector buffer3(buffer.begin() + 20, buffer.begin() + 35); + std::vector buffer4(buffer.begin() + 35, buffer.begin() + 57); + std::vector buffer5(buffer.begin() + 57, buffer.end()); // Add them all on nitf::NITFBufferList bufferList; @@ -80,9 +80,9 @@ TEST_CASE(testGetBlock_sys_byte) TEST_ASSERT_EQ(numTotalBytes, buffer.size()); // Extract all the bytes - std::vector extracted(numTotalBytes); + std::vector extracted(numTotalBytes); auto ptr = extracted.data(); - std::vector scratch; + std::vector scratch; size_t numBytesInBlock; for (size_t block = 0; block < numBlocks; ++block) From af6fd8b8afccd31cb8ffda4605010b463967a72d Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Wed, 12 Jul 2023 14:35:37 -0400 Subject: [PATCH 036/104] Squashed commit of the following: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit commit 44fd92ffaa561fcbe953d36003c913ac40a0c8e9 Author: Dan Smith Date: Wed Jul 12 14:31:03 2023 -0400 simplify #includes/#pragmas commit a9de277a5df88e425304122d0c90707aa74adc93 Author: Dan Smith Date: Wed Jul 12 14:01:53 2023 -0400 remove some `#pragma`s from the PCH as they're no longer needed commit ebf8c5683b7f9aa05ccd72b99df1b1f91569c4fd Author: Dan Smith Date: Wed Jul 12 13:47:03 2023 -0400 compile NITF-C as C++ in Visual Studio for better diagnostics commit 1b3c0caff4397d17488bb611264ea8762bd180dc Merge: 066e3fdc3 b4ae2d429 Author: Dan Smith Date: Wed Jul 12 13:27:44 2023 -0400 Merge branch 'main' into develop/remove-compiler-warnings commit 066e3fdc3f9083180d7bcb4586da2f00b7ae0ce4 Merge: 85842135d 6c06e3711 Author: Dan Smith Date: Wed Jul 5 13:13:59 2023 -0400 Merge branch 'main' into develop/remove-compiler-warnings commit 85842135d12de9883426d9b9f834debba46fa222 Author: Dan Smith Date: Wed Jul 5 12:07:59 2023 -0400 Squashed commit of the following: commit 3218ca3a5ed11cbaf74fc773f2e9da438ad3aae2 Merge: 20ac30dea 6149255f2 Author: Dan Smith Date: Wed Jul 5 12:07:03 2023 -0400 Merge commit '6149255f237e37dae196ede2fba585262c754b60' into develop/sync_externals commit 6149255f237e37dae196ede2fba585262c754b60 Author: Dan Smith Date: Wed Jul 5 12:07:03 2023 -0400 Squashed 'externals/coda-oss/' changes from 54033e70e3..c2fc5fc660 c2fc5fc660 add more projects to coda-oss-lite.vcxproj (#694) ceb86c186e support $(PlatformToolset) as a "special" environment variable (#693) d78a8595a7 OS::getSIMDInstructionSet() utility (#692) 2d2df467da fix `python3 waf dumplib` git-subtree-dir: externals/coda-oss git-subtree-split: c2fc5fc660c2794d77fac2b71cf0dfae76c22c3e commit 20ac30dea2088b1ce7c1dea42d64ff9927860c46 Author: Dan Smith Date: Wed Jul 5 12:06:51 2023 -0400 latest from CODA-OSS commit 6f4212e99a35e81cc3cff59eb8e21227df98c291 Merge: 9a1e6b291 cee9feb42 Author: Dan Smith Date: Wed Jul 5 12:05:41 2023 -0400 Merge branch 'main' into develop/sync_externals commit e13ca8b67ca6f547b5c88649a8d102b32e2cce17 Author: Dan Smith Date: Mon Jun 19 14:00:13 2023 -0400 Squashed 'externals/coda-oss/' changes from 3c63f9f65e..54033e70e3 54033e70e3 Merge branch 'main' into feature/complex_short git-subtree-dir: externals/coda-oss git-subtree-split: 54033e70e353da94340dd7b96d0b1c6652308952 commit 9a1e6b29131df20917a6cb485e2961bfbd43439f Merge: 4896d7f49 e13ca8b67 Author: Dan Smith Date: Mon Jun 19 14:00:13 2023 -0400 Merge commit 'e13ca8b67ca6f547b5c88649a8d102b32e2cce17' into develop/sync_externals commit 4896d7f49bfe6005c2b6fa7d0db4589de7039145 Author: Dan Smith Date: Mon Jun 19 14:00:08 2023 -0400 latest from CODA-OSS commit f6ca547a2cd51a907313efcdd6df461a1878aef0 Author: Dan Smith Date: Mon Jun 19 13:47:55 2023 -0400 Squashed 'externals/coda-oss/' changes from f4d42005fa..3c63f9f65e 3c63f9f65e std::numbers from C++20 (#691) 892dd0e00f ComplexInteger and ComplexReal to better match existing naming conventions (#690) b3872181ec match coda-oss naming conventions (#688) 704d6867f9 beef-up our complex type (#687) 47c1c1cd66 check is_absolute() for URLs (#686) c042373e16 be sure our Path::isAbolute() matches std::filesystem::path::absolute() (#684) ad10286bc0 volatile is about "special" memory, not threading (#685) git-subtree-dir: externals/coda-oss git-subtree-split: 3c63f9f65eaa2f7d8d33797c49525a24c2b82b62 commit 56eda7ac06da791e37e4abf390d96b43e6a929fd Merge: 02988da0c f6ca547a2 Author: Dan Smith Date: Mon Jun 19 13:47:55 2023 -0400 Merge commit 'f6ca547a2cd51a907313efcdd6df461a1878aef0' into develop/sync_externals commit 02988da0c99a32e64617d1dfdcf3531c8bf9f52c Author: Dan Smith Date: Mon Jun 19 13:47:51 2023 -0400 latest from CODA-OSS commit 075c9734ca49dd222203be11dbace5a26291b815 Merge: 48d98e7f2 3f01809fa Author: Dan Smith Date: Mon Jun 19 13:47:14 2023 -0400 Merge branch 'main' into develop/sync_externals commit ae3968aaccdb595304a64eab2f747a24ab0e4f61 Author: Dan Smith Date: Tue Jun 13 17:30:25 2023 -0400 Squashed 'externals/coda-oss/' changes from e87c32b4de..f4d42005fa f4d42005fa fix build error in NITRO ff11a5557e keep using std::complex for now (#682) c88b9c0532 types::complex (#681) d1244a0804 don't need our own make_unique in C++14 (#680) aeec0131c5 assert()s for mem::CopyablePtr (#679) 72b0ebd603 add types::complex_short (#678) 932130a580 patch to build other projects c00c1f203d coda-oss release 2023-06-06 (#677) ef54bbcd53 remove more compiler warnings (#676) dadfc5ce62 distinguish between byte-swapping a buffer and single value (#674) 90187f6cd8 more xml.lite tweaks for SIDD-3.0/ISM (#675) eb99607720 stronger type-checking for byteSwap() (#673) ff4f820ed8 xml.lite tweaks to support SIDD 3.0 ISM (#672) b1de8c0e5e std::byte should be a unique type (#671) c05bf9a028 allow enums to be byte-swapped too 1f9fd88d6d remove spurious 47684c45b8 byteSwap now uses byte buffers (#670) cbc659db27 add swapBytes() utility from SIX (#669) 891481b64f simplify byte-swapping (#668) 540ae763e5 more byteSwap() tweaks 0774c03c46 threaded byteSwap() (#667) d156370d36 swapping a single-byte value makes no sense c120e3255d be sure parameter is used to avoid compiler warning e85ec93317 --output-on-failure for CTest (#666) e80376197b turn off "there is no warning number" warning c5f0a5d154 A C-string may not be NULL-terminated (#665) 0c5eb29ae7 use platform-specific routines for byteSwap() (#664) 0b7d581fa6 remove transform_async() (#663) f6489b6bef Merge branch 'main' into feature/xml.lite_tweaks 836c426a2b use function-pointers so that isConsoleOutput is only checked once 56e3c45b1b move depthPrint() functionality into non-member function in preparation for future changes ddcd26d972 Merge branch 'main' into feature/xml.lite_tweaks 69cc0e5063 use the more rigorous create_and_check_datatype() 9efb875584 Merge branch 'main' into feature/hdf5 4d2f2f4173 more HighFive unittests (#662) 14191a844a HighFive::create_datatype() goes from C++ to HighFive 98583473fb utility routines to read string attributes 1fa75ce81e use the C API to read a string attribute 71e7b69f54 still can't figure out how to read a string attribute :-( e96f37a69b test reading the file attributes a25244519c getAttribute() unittest 8f12a3000b getDataType() unittest 857ff0af32 HighFive utility routines (#661) 1d687db57b writeDataSet() utility overload 106aa68945 sigh ... H5Easy::dump() fill fails on Windows/WAF :-( 2641b60b2b Merge branch 'main' into feature/hdf5 35c19e7e81 change actions to @v3 (#660) 212bbd3a36 works on local machine, but not build server ... ? 7125118b09 dump of 1D vector doesn't work :-( c704db4352 sigh ... WAF build still failing :-( 01aae46163 does dump() of a 1D vector work? 76a53c8134 comment-out H5 writing :-( 0f0e19affe test_highfive_dump() cb8f737957 trying to get highfive_dump() unittest working w/Windows-WAF 6584a264af does test_highfive_create() work? cde6147ced tweak HighFive wrappers (#659) 3165668545 Revert "trying HighFive "write" unittests again" a9ec24ca4d trying HighFive "write" unittests again 585ad49a56 tweak names of utility routines 4c91a4d97a make it easier to read a std::vector and std::vecotr 0217ffa26c readDataSet() now works for 1D data 95e8973f29 trying to get hdf5::lite::load() working 4d294611d4 "const" correctness 5e6305c3f7 fix load_complex() 4a134dc5f1 start work on utility routines to read complex data from HDF5 9d76a7f41e Merge branch 'main' into feature/hdf5 8f9667a240 whitepsace ebd3fc99ea Merge branch 'main' into feature/hdf5 40091b069c comment-out writing tests for now ... need to figure our WAF bulid failure 935aa34592 be sure the dataset has real data 114b9bf33c update release notes bd9c0b26c5 tweak HighFive utility routines acda1ef577 turn off diagnostics around expected failures 22a7488402 readDataSet() utility routine for HighFive bd88a8c256 HighFive writeDataSet() utility to work with our SpanRC 6142f5b339 use HighFive routines to write a HDF5 file 5bbf1abaff Use HiveFive routines to get info about the file 84fbc83789 duplicate unittests with H5Easy f1f054c03a Merge branch 'main' into feature/hdf5 9b63ca470c fix directory names f6f826689a fix directory names 7aeb82c336 Merge branch 'main' into feature/hdf5 d028baaebd hook up HighFive header-only library (#653) 3083b0a313 Revert "HighFive 2.6.2" 246985a7f0 Revert ""build" HighFive HDF5 library" a8b75a5865 Revert "turn off HighFive Boost support" ec68d5f830 Revert "Add HighFive unittests" f1f85b9e7f Revert "get test_high_five_base more-or-less compiling" 5ea634ee15 Revert "more work on getting HighFive unittests to build" ecc45433c7 more work on getting HighFive unittests to build bb194788ab get test_high_five_base more-or-less compiling d42bde0004 Add HighFive unittests ddc86bb328 turn off HighFive Boost support b255122d4f "build" HighFive HDF5 library 396cc3ef2a HighFive 2.6.2 5e5f9d9c0f Merge branch 'main' into feature/hdf5 ee938b4a52 changes from SIX bb764df90b Merge branch 'main' into feature/xml.lite_tweaks de2a243800 make derived classes 'final' if possible 14e19bcd21 Change xml lite function to virtual (#645) 8f42ac8e9e Merge branch 'main' into feature/xml.lite_tweaks 18ad90645f hdf5Write unittest 3462e11792 createFile() and writeFile() overloads ecee81d532 fix typos 197eecfa62 sketch-out hdf5::lite::writeFile() bd2311795e use SpanRC for writeFile(), not yet implemented ea9af75109 simple SpanRC to hold a 2D-size and pointer 027c19ee8a createFile() unittest 1f9d07ecbc hook up createFile() 8c7e4473f0 start hooking up HDF5 writing 146e0bea3b Merge branch 'main' into feature/hdf5 88ca9fcb7f Merge branch 'main' into feature/hdf5 42b604b463 Squashed commit of the following: 10ee602c25 Merge branch 'main' into feature/hdf5 67aa42b69d restore changes from "main" 8bbfcbfbfe unittests can be simplified to match fewer "view" classes 126bb802ea Merge branch 'main' into feature/hdf5 3f8ba7a423 again, don't need a class just to convert from std::vector<> to std::span<> 24c2b489c8 Squashed commit of the following: 2703c119d4 Squashed commit of the following: 9d5228a2be don't need an entire class just to convert a std::vector<> into std::span<> 51bc931dcd Merge branch 'main' into feature/hdf5 a84f258160 Squashed commit of the following: c4d2ed696e add missing #include guards, fix type in existing #include guard d541525a01 use a single ComplexViewConstIterator for all views 86e6a459fe CODA_OSS_disable_warning causes GCC errors :-( 5d4b9c2cb6 only need an custom iterator for ComplexSpansView d9f0fb1286 hook up iterators b9329e4db0 initial pass at a ComplexViewConstIterator 6352388739 remove compiler warning about unused "constexpr" variables b39f6096fb use the casing from H5 to make copy/pasting code slightly easier 0887b13eb4 Merge branch 'main' into feature/hdf5 bd07df1cae Consistent casing for Dataset, Datatype, Dataspace 7acd30ee23 tweak hdf5.lite dependencies 38ab914dfd Jupyter notebook for creating H5 files 95a040e0bf _small.h5 is now (correctly) FLOAT32 107e7c4876 make a simple values() member function to avoid template magic e1feca9194 use TEST_SPECIFIC_EXCEPTION macro instead of try/catch 7383336888 readDatasetT() now throws for the wrong buffer type 6b2cc25294 Merge branch 'feature/hdf5' of github.com:mdaus/coda-oss into feature/hdf5 310f8fd3d5 can't get template magic right for copy_axis() 86b306d596 stepping through copy ctors in the debugger is annoying f243e92d68 trying to make wrong type of buffer fail 2b10d96529 read in new sample file a28e59d8c5 help the compiler with type deduction 49bf5e9bc2 nested_complex_float_data_small.h5 e029325fc0 utility routines to "deconstruct" and array of std::complex dede3bd393 Merge branch 'main' into feature/hdf5 904b1ef5ec tweak class names, make_() and copy() utility routines 8237b9efbf make it harder to pass the wrong types to ComplexViews 4d9aeda2cd ComplexArrayView and ComplexParallelView utility classes f5e367dfa6 test std::span> a4a2844f26 read in the nested "i" and "r" data 1156152650 sample file has subgroups 8e1b7869aa Merge branch 'feature/hdf5' of github.com:mdaus/coda-oss into feature/hdf5 9f4232a1dd update sample H5 file 8c55db73ae walk through HDF5 sub-groups 7775ed9c43 Update 123_barfoo_catdog_cx.h5 677975d7ca Matlab code to create sample H5 file a0e7dfe07b Update test_hdf5info.cpp 0b67e1602f pass __FILE__ and __LINE__ from calling site for a more accurate exception message 86a6773213 skeleton for more sample data 85f79b0999 Merge branch 'main' into feature/hdf5 18088e9421 Merge branch 'main' into feature/hdf5 3a1d17692f Merge branch 'main' into feature/hdf5 1755c69d70 Merge branch 'main' into feature/hdf5 9ad015432d No more "11" suffix on exception names c20d962511 Squashed commit of the following: c88cee999b other values to be filled-in bca4a4ecd8 incorporation NamedObject from HDF5 docs 61fa68f72e groupInfo() 460e7d7665 datasetInfo() 14eb9b764b start filling in DatasetInfo afe5f1c3a0 start to fill in DatasetInfo 77a968c72d start filling in GroupInfo d81bcdfd92 openGroup() to open groups (loc) a0cd294697 comment-out "dataset" unittest for now 86e0060245 begin filling in FileInfo 366dda6ab6 a return_type_of utility is needed to deduce the return type e219282638 explicitly pass return type to template 4937ccd11d template to reduce boilerplate when calling try_catch_H5Exceptions b3b5ebde78 use new exception utility routines ea1c03ef0c put exception handling/conversion in a utility routine 819a99d397 utility routine for exception handling 6f34eea979 put utilities in a separate file for easier reuse fcbde4f241 break utility routines into smaller pieces for easier reuse 52358ea8a9 WIN32 no longer automatically defined? 5a42864722 Revert "build HDF5 with C89" 680e599e9d build HDF5 with C89 a87a071218 Merge branch 'main' into feature/hdf5 8447c1a900 Revert "sym-links instead of copying files" db3b5e12b4 Merge branch 'main' into feature/xml.lite_tweaks fb60b5696f Merge branch 'main' into feature/hdf5 5110a5cc81 Comments about _u and _q 1a937d32cf Merge branch 'main' into feature/xml.lite_tweaks fa06f04d7e get ready for hdf5.lite enhancdements b040c7c437 sym-links instead of copying files aa431bb477 use _u for xml::lite::Uri 3d0c6d58ce fix case-sensitive #include filename 93dcd0e527 operator() for getElementByName() 75a93af859 more operator[] overloads to make attribute management easier 4ab8216f87 user-defined string literals to remove some noise around xml::lite::QName f82f0b0fc6 Merge branch 'main' into feature/xml.lite_tweaks ae30e36443 Merge branch 'feature/xml.lite_tweaks' of github.com:mdaus/coda-oss into feature/xml.lite_tweaks ffdd9beb0b simplify attribute creation 9bf5414f5d simplify attribute creation 82d7a4e959 SWIG gets confused about namespaces 7a61d0741f fix bug on Element ctor uncovered by unittest fdd7e58c1a QName is also in the xerces namespace which confuses SWIG bindings a325b7053b operator+=() overload for addChild daf30e6c0e Merge branch 'feature/xml.lite_tweaks' of github.com:mdaus/coda-oss into feature/xml.lite_tweaks b887d2b476 provide overloads for Element& rather than creating new "reference" types 1fa6bba388 rename test_xmleasy.cpp 7c8c9e0f1c += overload 850da6f63d overload for std::string 4547fc5a75 use UIT-8 strings for characterData 4723462a3b convenient addChild() overloads e48720753a copy over ElementReference from xml.easy a4ca30a0d6 Merge branch 'main' into feature/xml.lite_tweaks 6ae9f0b715 Revert "check-in of new xml.easy (to move code between computers)" f7466a6d75 Revert "simple routines for single element" a5490230d6 Revert "make some operators simplier ways of calling functions" c9a25630a6 Revert "get document creation working" 8af8710b05 Revert "free functions instead of member functions" 16c3847cb2 Revert "ElementReference distinct from Element" 7d68e156ff Revert "ElementMutableReference" 00eb2a2826 Merge branch 'main' into feature/xml.lite_tweaks a42969c1f4 ElementMutableReference a20ae9355e ElementReference distinct from Element 14eeeea0b5 free functions instead of member functions 4aae014b39 get document creation working 8835692699 make some operators simplier ways of calling functions 053bd1212a simple routines for single element 8bf701a2ea check-in of new xml.easy (to move code between computers) 41f959051c unittests for creating XML documents from scratch 9752d50ae2 Merge branch 'main' into feature/xml.lite_tweaks 1531d57095 by default, don't validate strings passed to Uri() 46d13d4bf7 Merge branch 'master' into feature/xml.lite_tweaks 39b547d321 remove more vestiges of Expat and LibXML ec8274d524 remove LibXML and Expat as they're no longer used/supported. 20eeefeef6 Merge branch 'master' into feature/xml.lite_tweaks 95074b9b1a update for newer Intel compiler 7024f71e1b Merge branch 'master' into feature/xml.lite_tweaks 57b1cbc83d Merge branch 'master' into feature/xml.lite_tweaks 4b67561c3d remove validate() overload that nobody is using fa15f1e5dc Squashed commit of the following: 1484a90909 test the new validate() API 470da70fb8 hookup StringStreamT routines 2cddf25047 begin hooking up validate() overloads 1b5d910f38 overload validate() for UTF-8 and Windows-1252 03309b8c9f Squashed commit of the following: b72c6c5bf2 older compiler doesn't like our make_unique af8f00307f validate UTF-8 XML on Linux 211188613e unit-test for LEGACY XML validation 3c1169d2b5 Squashed commit of the following: 3afff19cad std::filesystem::path for FileInputStreamOS 908d452f8f WIP: validate all of our sample XML files 00f9bb16bc validate against a XML schema 243d8c356c Merge branch 'master' into feature/xml.lite_tweaks 2815d707d9 fix to work with SWIG bindings. :-( 4608621326 trying (again) to remove vestiages of old code e3c83a8587 Revert "new code should use UTF-8" 811207c920 new code should use UTF-8 0ffd835f96 Squashed commit of the following: 1e7e03ded0 Merge branch 'master' into feature/xml.lite_tweaks c1d806affa Merge branch 'master' into feature/xml.lite_tweaks 850d3c811d str::strip() that can be easier to use than str::trim() 580ba9c8c3 explicitly =delete move 2b39831a80 Squashed commit of the following: 39eebdc23f Merge branch 'master' into feature/xml.lite_tweaks 9adf86cbaf force calling new UTF-8 write() routines ea61b62045 Merge branch 'master' into feature/xml.lite_tweaks 8a34583fa0 overload to take schemaPaths as filesystem::path 8671b442f7 parse XML embedded in a binary file ec4a902f14 updates from xerces.lite 80dc4d9635 updates from xerces.lite 549766d6c1 Attributes::contains() no longer catches an exception 8a645ceac3 need "sys/" when building in other environments 36af082690 super-simple URI validation 78ef28a3e2 SWIG bindings are a PITA! :-( e9cba8491e SWIG needs help with Uri 8a8d8dc072 another routines used by pre-build SWIG bindings 818e1ec5d3 pre-build SWIG bindings use getElementByTagName() member function 067cac5d85 old compiler gets confused on unadorned QName ba92c0ae7e more use of Uri and QName 446c7d17a7 use QName in new code d6f8b0c836 more direct use of QName 90fff1c737 use xml::lite::QName instead of tuple 646cbb5ed4 more direct use of QName and Uri ba589ea3b3 make QName more robust bab0ee8b5e createElement() -> addNewElement() e3a145747a grab changes from six-library 32285e95c4 Merge branch 'master' into feature/xml.lite_tweaks 9f79f0bf62 Merge branch 'master' into feature/xml.lite_tweaks a12bbc32c6 make it easier to create new Elements with a value fc9967f986 make it easy for callers to addChild() keep a reference to the Element 4627766b7d be sure test_xmlparser works in "externals" of other projects bf22763961 "private" is part of the name-mangling fad92bcc8f making sure copy-ctor is implemented f90fdcead0 consolidate common XML test code 9fc53f2d51 use str:: utility for casting 6da6f794bb still trying to find the right macro for SWIG 0c1b86c566 still trying to fix SWIG fdc6fc9bd6 trying to fix SWIG build error 7835e8c270 SWIG needs copy-ctor 585695942d disable copy/assignment for Element, it's probably almost always wrong 391fed6135 fix double-delete caused by copying 61790fe695 retry parsing XML with Windows-1252 if first parse() fails 63cffac59e change string_encoding to match coda-oss style of PascalCase 010479bbec read an XML file we know is wrongly encoded as Windows-1252 9a05050621 more references instead of pointers 2d44b69519 Reading Windows-1252 w/o "encoding" fails 63dc7b0762 read Windows-1252 too c9434c9cbe test as UIT-8 too f310ccf0cf get reading from UTF-8 XML working on Windows 1fa39c2be0 get testReadUtf8XmlFile working on Linux 1a83cd8157 sys::Path is too much trouble right now ed60aa22c9 unit-test to read XML from a file a9336db7c6 Squashed commit of the following: 0825beb0d3 Merge branch 'master' into feature/xml.lite_tweaks c618489be7 Merge branch 'master' into feature/xml.lite_tweaks e8e4b8fe1d determine string_encoding based on platform 1f43bcfc26 create a new Element by using the platform to determine "characterData" encoding 961bef66b4 Merge branch 'master' into feature/xml.lite_tweaks e9798a5cba fix static_assert() 6f77728748 Merge branch 'master' into feature/xml.lite_tweaks b98d4f5a91 Merge branch 'master' into feature/xml.lite_tweaks 1b5abba2a6 The (old) version of SWIG we're using doesn't like certain C++11 features. 53bdeabaf7 Merge branch 'master' into feature/xml.lite_tweaks 60cf8ae80f "" doesn't work with decltype() in older C++ 97e72477a5 reduce getValue() overloads by making "key" a template argument 5e6373e557 reduce code duplication f9e7cfeee5 provide castValue instead of getValue(T&) cbd0bd8f24 castValue throws instead of returning a bool like getValue(T&) 87c7514fce Merge branch 'master' into feature/xml.lite_tweaks 10cc61223a make getElement*() consistent for zero or >1 results f5b137e3cd Merge branch 'master' into feature/xml.lite_tweaks 1765efc622 allow clients to specify toType() and toString() for getValue() and setValue() df8b746e12 allow clients to specify their own toType/toString routines 66702726ad Merge branch 'master' into feature/xml.lite_tweaks 6956311f14 Merge branch 'master' into feature/xml.lite_tweaks d505f3593a Merge branch 'master' into feature/xml.lite_tweaks fbd106115f catch a BadCastException and return false from getValue() 3a78377b55 use a template to reduce duplicated code 0ad4b86062 Merge branch 'master' into feature/xml.lite_tweaks a848aa3a20 get & set the characer data as a type f3ee1ee12a utility routines to set an attribute value 5952276839 templates to get an attribute value convert to a specific type 06639227b3 miised a change in last commit 1aa458ef8b add getValue() overloads that return true/false rather than throwing faa6d30752 added getElementByTagName() overloads as that's a very common use-case git-subtree-dir: externals/coda-oss git-subtree-split: f4d42005fa477ae59da193422aa2cb14b877cf0c commit 48d98e7f27e987ebfbc7e1b892c18f6377b49fab Merge: 18be3582a ae3968aac Author: Dan Smith Date: Tue Jun 13 17:30:25 2023 -0400 Merge commit 'ae3968aaccdb595304a64eab2f747a24ab0e4f61' into develop/sync_externals commit 18be3582a913519ac9b1e77074beb0c988a618c8 Author: Dan Smith Date: Tue Jun 13 17:30:21 2023 -0400 latest from coda-oss commit 217ecdb18c76f58dba1c853ddf29f48e3b8ca6b0 Author: Dan Smith Date: Wed Jul 5 11:38:30 2023 -0400 use new "PlatformToolset" special environment variable commit 9a3d56f19d7ad4ba2c73ca3782905b0b35aed689 Author: Dan Smith Date: Wed Jul 5 11:27:01 2023 -0400 UNREFERENCED_PARAMETER(envVar); commit 52ad5e164b28099f993501c14470c5eb04b7f749 Author: Dan Smith Date: Wed Jul 5 11:16:14 2023 -0400 latest from CODA-OSS commit 0a21af794392b352a3872527526487e8355006dc Merge: 17b5a679a cee9feb42 Author: Dan Smith Date: Wed Jul 5 11:12:10 2023 -0400 Merge branch 'main' into develop/remove-compiler-warnings commit 17b5a679a7ef676eae6b2c87321eea1229c4e4d0 Author: Dan Smith Date: Tue Jun 13 17:09:10 2023 -0400 Update test_j2k_loading++.cpp commit 66bfc4a74b9f1425240782fd5005011bbc3f8130 Merge: d302617ce b12caf2fc Author: Dan Smith Date: Tue Jun 13 17:07:33 2023 -0400 Merge branch 'main' into develop/remove-compiler-warnings commit d302617ceec61a0cfee9e4881f4daf849d94de2e Author: Dan Smith Date: Thu Mar 9 10:01:47 2023 -0500 remove a few compiler warnings from unittests commit 1371aa9010d52b8911489e3caa02419ec101988f Author: Dan Smith Date: Wed Mar 8 16:58:43 2023 -0500 free allocated objects commit 81db3bfc9e84629f5763a82ea7d238598492c20f Author: Dan Smith Date: Wed Mar 8 16:58:24 2023 -0500 ASAN needs a link option too commit a34ab25a4fc5cf44070901c045cfab542e7d6f47 Merge: dff024f59 7d77233db Author: Dan Smith Date: Wed Mar 8 15:25:06 2023 -0500 Merge branch 'main' into develop/remove-compiler-warnings commit dff024f5998ab81ea8ec752b9a1a14636ff4d6da Author: Dan Smith Date: Thu Feb 9 13:25:30 2023 -0500 add multi-processor compile for MSVC commit 9c7f6761951fda6200465ac014e0a8c8613a236a Merge: 651cc1d88 e2f038e45 Author: Dan Smith Date: Thu Feb 9 13:23:19 2023 -0500 Merge branch 'main' into develop/remove-compiler-warnings commit 651cc1d882cf629aaf16599125ace5cd54afb9b5 Author: Dan Smith Date: Thu Feb 9 12:40:27 2023 -0500 fix the last Windows build error? commit a45614abe16b0d8f453ae716524b966e44df39de Author: Dan Smith Date: Thu Feb 9 12:38:34 2023 -0500 does -j work for Windows builds? commit c02ee149d1484486d1f2fa84f0c1bbafa156553a Author: Dan Smith Date: Thu Feb 9 12:19:05 2023 -0500 fix Windows compile warnings commit e29e2fdb55c8bbf9f2043fc1064cd8e74e4f4706 Author: Dan Smith Date: Thu Feb 9 11:59:21 2023 -0500 latest from coda-oss commit 602606fae5d27b202c49341acbf3f32f89468f52 Author: Dan Smith Date: Thu Feb 9 11:38:05 2023 -0500 latest from coda-oss commit 2550a1a759bad3bc0ebcca774fa53e4a6f2655a5 Author: Dan Smith Date: Thu Feb 9 11:12:08 2023 -0500 /W0 for directories we don't control commit 7009f7bbef13ada6a55e743367308a95d7767207 Author: Dan Smith Date: Thu Feb 9 11:00:33 2023 -0500 set the target language for specific directories commit b59a3358a5631cf564bd106b3f0044d9f30e2ba6 Author: Dan Smith Date: Thu Feb 9 10:58:07 2023 -0500 latest from coda-oss commit 907a87bc71ef25dce66c1e8a46b7e2c65ed95a44 Author: Dan Smith Date: Thu Feb 9 10:49:36 2023 -0500 latest from coda-oss commit 1a10691a8432a82d77968d4da605d87866cdc3cb Author: Dan Smith Date: Thu Feb 9 09:07:28 2023 -0500 turn off 'maybe uninitialized' for our C code commit c966d4d9b88999506cca08a50c31ce5a9f0397ac Author: Dan Smith Date: Thu Feb 9 08:57:05 2023 -0500 build NITRO cleanly (almost) on Windows commit 7baccbc762103cfa080611a0becb57e8fb8e21de Author: Dan Smith Date: Thu Feb 9 08:47:37 2023 -0500 turn off 'misleading indentation' for our C code commit d3fdd159e40e0255ae16b2eb629e01c669e615ab Author: Dan Smith Date: Thu Feb 9 08:42:06 2023 -0500 turn off warnings for code we don't control commit df5acc8b8790be430e0775fab1ba8bc83eff653e Author: Dan Smith Date: Thu Feb 9 08:40:11 2023 -0500 latest from coda-oss commit 0e2d2dde1dad0e69a392b08f39f7c3b776b68462 Author: Dan Smith Date: Wed Feb 8 17:37:22 2023 -0500 latest from coda-oss commit 2f92f4bdb997a3bcbf9ca37f0a3aee4eec67e743 Author: Dan Smith Date: Wed Feb 8 17:28:58 2023 -0500 latest from coda-oss commit 0eea1ad2c3744fa4fc32cc55ca5c02428ab149ac Author: Dan Smith Date: Wed Feb 8 17:18:48 2023 -0500 remove more warnings when building with CMake commit 6614c5a8bc9a5d0f739678c8d38951e4dfcc5af1 Author: Dan Smith Date: Wed Feb 8 17:06:51 2023 -0500 build cleaning in CMake on Windows commit 1f69fc3dec7134457b087d771cc2c867913a08c2 Author: Dan Smith Date: Wed Feb 8 16:31:08 2023 -0500 turn on GCC compiler warnings commit 17e3da4891b6ac7c939747b8fd08b693b6fcf3f5 Author: Dan Smith Date: Wed Feb 8 16:04:53 2023 -0500 reduce compiler warnings commit 82229c17563bcdad0af800af765ea74fbb441ab9 Merge: 0fab73406 b871d2b9c Author: Dan Smith Date: Wed Feb 8 15:46:12 2023 -0500 Merge branch 'main' into develop/remove-compiler-warnings commit 0fab734060da97e0ae063c711183e87497c3b083 Author: Dan Smith Date: Mon Jan 23 11:38:35 2023 -0500 don't need both "override" and "final" commit ba8eebdbf0038231a25eecce835a1546e6bff51d Merge: 2f2a67575 4ccdf5b37 Author: Dan Smith Date: Mon Jan 23 10:56:54 2023 -0500 Merge branch 'main' into develop/remove-compiler-warnings commit 2f2a67575bb08785fa35118fbaaab814cc25c41f Merge: 5883fcd3c 2342edbef Author: Dan Smith Date: Tue Aug 2 10:32:56 2022 -0400 Merge branch 'master' into develop/remove-compiler-warnings commit 5883fcd3c9c415c2afb30db293f9daba4d00e417 Author: Dan Smith Date: Tue Aug 2 10:11:30 2022 -0400 remove merge error commit 204dbc4f47e20498ff57abbccd8cef9bd9813bc5 Author: Dan Smith Date: Tue Aug 2 10:07:45 2022 -0400 Squashed commit of the following: commit 88029713b3d0e61ce4db07a81131c74abebb056f Author: Dan Smith Date: Tue Aug 2 10:02:35 2022 -0400 coda-oss 2022-08-02 commit 41a5580ad83c291cf05e164fed4683b1d6f06e25 Author: Dan Smith Date: Tue Aug 2 09:57:12 2022 -0400 copy export template from coda-oss commit f2e3d705c180d235641a5125cf53099ed9ce2343 Author: Dan Smith Date: Fri Jul 29 11:28:51 2022 -0400 str::strip() is gone, use str::trim() commit 8f98699a1361585be511d4b42dc130874cd7f0c5 Author: Dan Smith Date: Fri Jul 29 11:21:34 2022 -0400 latest from coda-oss commit 6ab60c57d78343cc33f0a055c00c30836da17006 Merge: 24dde2c7d 7e1fe6a68 Author: Dan Smith Date: Fri Jul 29 11:19:57 2022 -0400 Merge branch 'master' into develop/update-coda-oss commit 24dde2c7dd8f1b305ee7cb619978e3762e75269d Author: Dan Smith Date: Wed Jun 29 15:54:25 2022 -0400 coda-oss release 2022-06-29 commit c8afbc06db27593785bb32f32edac1e8718951a3 Merge: 8c0fc52b2 a3bb3a032 Author: Dan Smith Date: Wed Jun 29 15:50:49 2022 -0400 Merge branch 'master' into develop/update-coda-oss commit 8c0fc52b2d171e037785285594de6a4fb7816610 Author: Dan Smith Date: Tue Jun 28 14:55:41 2022 -0400 latest from coda-oss commit 7b35520587684cca305adeba7fd293444483da21 Author: J. Daniel Smith Date: Thu Jun 23 19:06:02 2022 -0400 latest from coda-oss commit 81dd80efc37246b2e96b196bee47394276ab2bb6 Merge: 15429eacf f40179473 Author: J. Daniel Smith Date: Thu Jun 23 19:03:06 2022 -0400 Merge branch 'master' into develop/update-coda-oss commit 15429eacfa662a90948bb9fd44771826313b00e4 Author: J. Daniel Smith Date: Thu Jun 23 13:36:39 2022 -0400 need to use "srand_called" to fix compiler warning commit d7caa35849cf68f8f381041ae0fbc819de64e88e Author: J. Daniel Smith Date: Thu Jun 23 13:13:58 2022 -0400 trying to fix build error commit e573fc90a0b72b422e8233d45b8bae4b7db38da1 Author: J. Daniel Smith Date: Thu Jun 23 12:39:29 2022 -0400 latest from coda-oss commit 6a64d55a123fb26dba2906dc6b15671b52895b2d Merge: 0add5ad91 3e38c39a0 Author: J. Daniel Smith Date: Thu Jun 23 12:19:39 2022 -0400 Merge branch 'master' into develop/update-coda-oss commit 0add5ad91c3fa113c4d25c09b3e66486eacecad1 Author: Dan Smith Date: Fri May 13 09:57:07 2022 -0400 latest from coda-oss commit 086e364cb1c8b42b90d0e9b1009f667c94e661fb Author: Dan Smith Date: Thu May 12 13:39:23 2022 -0400 don't need VS UnitTest project commit 48037ff12aca592a79ef3f841b8cc1cae367f8f6 Author: Dan Smith Date: Thu May 12 10:13:19 2022 -0400 fix build errors on Linux commit 85f1cd6274b7a9ace38f404d5de479fc18157e5f Author: Dan Smith Date: Thu May 12 09:50:25 2022 -0400 more updates from coda-oss commit b9b9468d3e78cd2eb1db236012a2ae6358adfb9a Author: Dan Smith Date: Thu May 12 09:49:15 2022 -0400 latest from coda-oss commit 66f9b077ab65e9b4855b51ebdd15f9e8414273de Merge: 0fdf9fbfe f27a3894e Author: Dan Smith Date: Thu May 12 09:47:52 2022 -0400 Merge branch 'master' into develop/update-coda-oss commit 0fdf9fbfe31d6b816ea42ebfe14aca1ffd04a6ef Author: Dan Smith Date: Tue May 3 15:42:24 2022 -0400 coda-oss release 2022-05-03 commit 8ee9b967c51042758711d734d46cbb0584155595 Author: Dan Smith Date: Fri Jul 29 11:29:18 2022 -0400 Squashed commit of the following: commit f2e3d705c180d235641a5125cf53099ed9ce2343 Author: Dan Smith Date: Fri Jul 29 11:28:51 2022 -0400 str::strip() is gone, use str::trim() commit 8f98699a1361585be511d4b42dc130874cd7f0c5 Author: Dan Smith Date: Fri Jul 29 11:21:34 2022 -0400 latest from coda-oss commit 6ab60c57d78343cc33f0a055c00c30836da17006 Merge: 24dde2c7d 7e1fe6a68 Author: Dan Smith Date: Fri Jul 29 11:19:57 2022 -0400 Merge branch 'master' into develop/update-coda-oss commit 24dde2c7dd8f1b305ee7cb619978e3762e75269d Author: Dan Smith Date: Wed Jun 29 15:54:25 2022 -0400 coda-oss release 2022-06-29 commit c8afbc06db27593785bb32f32edac1e8718951a3 Merge: 8c0fc52b2 a3bb3a032 Author: Dan Smith Date: Wed Jun 29 15:50:49 2022 -0400 Merge branch 'master' into develop/update-coda-oss commit 8c0fc52b2d171e037785285594de6a4fb7816610 Author: Dan Smith Date: Tue Jun 28 14:55:41 2022 -0400 latest from coda-oss commit 7b35520587684cca305adeba7fd293444483da21 Author: J. Daniel Smith Date: Thu Jun 23 19:06:02 2022 -0400 latest from coda-oss commit 81dd80efc37246b2e96b196bee47394276ab2bb6 Merge: 15429eacf f40179473 Author: J. Daniel Smith Date: Thu Jun 23 19:03:06 2022 -0400 Merge branch 'master' into develop/update-coda-oss commit 15429eacfa662a90948bb9fd44771826313b00e4 Author: J. Daniel Smith Date: Thu Jun 23 13:36:39 2022 -0400 need to use "srand_called" to fix compiler warning commit d7caa35849cf68f8f381041ae0fbc819de64e88e Author: J. Daniel Smith Date: Thu Jun 23 13:13:58 2022 -0400 trying to fix build error commit e573fc90a0b72b422e8233d45b8bae4b7db38da1 Author: J. Daniel Smith Date: Thu Jun 23 12:39:29 2022 -0400 latest from coda-oss commit 6a64d55a123fb26dba2906dc6b15671b52895b2d Merge: 0add5ad91 3e38c39a0 Author: J. Daniel Smith Date: Thu Jun 23 12:19:39 2022 -0400 Merge branch 'master' into develop/update-coda-oss commit 0add5ad91c3fa113c4d25c09b3e66486eacecad1 Author: Dan Smith Date: Fri May 13 09:57:07 2022 -0400 latest from coda-oss commit 086e364cb1c8b42b90d0e9b1009f667c94e661fb Author: Dan Smith Date: Thu May 12 13:39:23 2022 -0400 don't need VS UnitTest project commit 48037ff12aca592a79ef3f841b8cc1cae367f8f6 Author: Dan Smith Date: Thu May 12 10:13:19 2022 -0400 fix build errors on Linux commit 85f1cd6274b7a9ace38f404d5de479fc18157e5f Author: Dan Smith Date: Thu May 12 09:50:25 2022 -0400 more updates from coda-oss commit b9b9468d3e78cd2eb1db236012a2ae6358adfb9a Author: Dan Smith Date: Thu May 12 09:49:15 2022 -0400 latest from coda-oss commit 66f9b077ab65e9b4855b51ebdd15f9e8414273de Merge: 0fdf9fbfe f27a3894e Author: Dan Smith Date: Thu May 12 09:47:52 2022 -0400 Merge branch 'master' into develop/update-coda-oss commit 0fdf9fbfe31d6b816ea42ebfe14aca1ffd04a6ef Author: Dan Smith Date: Tue May 3 15:42:24 2022 -0400 coda-oss release 2022-05-03 commit 7d5fd831fdafd4a4b4f0c7368ca4f445071bf264 Author: Dan Smith Date: Wed Jul 20 10:22:10 2022 -0400 turn off "unscoped enum" warning for coda-oss commit 9796edf02f9aeaa34f226dc96b2da624d72baadc Author: Dan Smith Date: Wed Jul 20 09:50:56 2022 -0400 a few casts to "void*" to make the C++ compiler happy when compiling C code commit 985f86beff7660da6357907d01b6257a159abcf9 Merge: 4ef023e04 7e1fe6a68 Author: Dan Smith Date: Wed Jul 20 09:24:56 2022 -0400 Merge branch 'master' into develop/remove-compiler-warnings commit 4ef023e04da0acd198423285395fd7c46502a186 Author: Dan Smith Date: Tue Apr 19 17:13:41 2022 -0400 fix two code-analysis diagnostics commit e8c736e645258a7eb7a650e89f0b5eddb3363735 Author: Dan Smith Date: Tue Apr 19 16:58:50 2022 -0400 Squashed commit of the following: commit c16ea001a2bac255cd841a277c552d2c48487ae3 Author: Dan Smith Date: Tue Apr 19 16:58:15 2022 -0400 EncodedString fixes from coda-oss commit d148a9a4b6ccf48c811ce27b169f688a00fcc24b Author: Dan Smith Date: Mon Apr 18 11:57:13 2022 -0400 latest from coda-oss commit 1115b49682a3280b2eb2dc29b12d7a7a4d74f477 Merge: 24b90913 758ac88e Author: Dan Smith Date: Mon Apr 18 11:55:31 2022 -0400 Merge branch 'master' into develop/update_coda-oss commit 24b909137fab10b61dd566dba690b8e94f5ffc5c Merge: 56756c60 5dbd0d9c Author: Dan Smith Date: Mon Apr 4 17:33:18 2022 -0400 Merge branch 'master' into develop/update_coda-oss commit 56756c60d8f6e96a23ed09bcaac31cc0319ec666 Author: Dan Smith Date: Mon Apr 4 15:10:46 2022 -0400 latest from coda-oss commit 667e11aa448386527be60a10d15d7e6fe83dc845 Author: Dan Smith Date: Mon Apr 4 10:37:43 2022 -0400 updates from "main" commit 395a3b7a168a6ff90ddb1e4eb46dfe97ee35bc12 Merge: fce36bea 3e938797 Author: Dan Smith Date: Mon Apr 4 10:32:27 2022 -0400 Merge branch 'master' into develop/update_coda-oss commit fce36bea264a8a8b704e9f0e7f59873d8acfbd7d Merge: 5bce4a28 dfeb3fe4 Author: J. Daniel Smith Date: Wed Mar 23 09:30:01 2022 -0400 Merge branch 'master' into develop/update_coda-oss commit 5bce4a28d93873c39d7ad565b8dbb16612997988 Author: Dan Smith Date: Wed Mar 16 09:39:03 2022 -0400 tweak cast commit 1fc9ba89120cb4247998f6fb765855c7131b0a56 Merge: 9a63b6e9 5b11fe82 Author: Dan Smith Date: Tue Mar 15 17:56:27 2022 -0400 Merge branch 'master' into develop/update_coda-oss commit 9a63b6e994358b06599677a31d91ae79dd7235b3 Merge: 7ebed839 f02c7064 Author: Dan Smith Date: Tue Mar 15 17:40:37 2022 -0400 Merge branch 'master' into develop/update_coda-oss commit 7ebed83975fd7363057dfdebc2414beda6f2bde9 Author: Dan Smith Date: Tue Mar 15 17:36:34 2022 -0400 coda-oss updates from feature/j2k commit 3464b3d23bbed3c3eaaaf0a8197e065c01ac7587 Merge: 436c98bf 8907b9fc Author: Dan Smith Date: Tue Mar 15 17:35:46 2022 -0400 Merge branch 'master' into develop/update_coda-oss commit 436c98bf917d3428d7b6fad917b807fde7483585 Merge: b0cd9833 1124c00f Author: Dan Smith Date: Tue Mar 15 16:45:15 2022 -0400 Merge branch 'master' into develop/update_coda-oss commit b0cd9833ff1e101623f0bdfed516b1002bfab25d Author: Dan Smith Date: Tue Mar 8 13:15:13 2022 -0500 latest from coda-oss commit 45930df89118c000d81196f263dd5211c5571197 Author: Dan Smith Date: Wed Feb 23 16:28:46 2022 -0500 latest from coda-oss commit b720447a8f7c5d57b33861e2b73b5ca6ef9724ce Author: J. Daniel Smith Date: Thu Feb 17 16:45:39 2022 -0500 latest from coda-oss commit 8fc1eb4f12587d2efcd8573827020e8c6cb0fa0f Merge: 28390d25 3f70bc3c Author: J. Daniel Smith Date: Thu Feb 17 16:43:32 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 28390d254b7037d84de60dfd0b741f7414f7f2ad Author: Dan Smith Date: Wed Feb 9 09:39:34 2022 -0500 more free functions in coda_oss:filesystem commit f2d505d599615c7275dbbce01b1d024d5690a255 Author: Dan Smith Date: Tue Feb 8 17:38:51 2022 -0500 need another fs::path() commit e2fa368d1a7de5a8585aac048098f7ee67361438 Author: Dan Smith Date: Tue Feb 8 17:19:30 2022 -0500 std::filesystem tweaks commit 44bd04c677536583378ee9500a831fe80be20d0d Author: Dan Smith Date: Tue Feb 8 17:06:16 2022 -0500 latest from coda-oss commit c67e70d0feadcf68206601327a4ebf01b1d4d52f Author: Dan Smith Date: Tue Feb 8 16:40:27 2022 -0500 build w/C++20 commit f63d2380fe355895851b5ecd8f7d9dc3b709c8a6 Author: Dan Smith Date: Tue Feb 8 08:50:02 2022 -0500 build with old GCC commit 15ea8e65c6162d2b387b49633552a1e1c16101fd Author: Dan Smith Date: Fri Feb 4 10:12:06 2022 -0500 latest from coda-oss commit 7a363cf23914a739a4f52b31f2abd713d65e0ba9 Author: Dan Smith Date: Fri Feb 4 09:09:20 2022 -0500 latest from coda-oss commit 2e350ba21420d3e571f1929e96ee765e2e814b25 Author: Dan Smith Date: Thu Feb 3 11:21:23 2022 -0500 latest from coda-oss commit fced6290f11ad3a5901c6ff7e8dad0cbde00adf3 Merge: 987a041a 3f70bc3c Author: Dan Smith Date: Wed Feb 2 14:00:24 2022 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 987a041a823b5f1c8bb780db252cdae792319c25 Author: Dan Smith Date: Wed Feb 2 12:42:17 2022 -0500 Update nitro.sln commit a218691b94c1c94accb8b3e8abee108c254a18ff Author: Dan Smith Date: Wed Feb 2 12:39:27 2022 -0500 Update README.md commit 1c43ee11fab3bded80bb2f61129d428ac389175e Author: Dan Smith Date: Wed Feb 2 12:39:22 2022 -0500 Create ReleaseNotes.md commit 3dcb1c944704b12531caed402f714542df1411e5 Author: Dan Smith Date: Wed Feb 2 12:28:38 2022 -0500 Squashed commit of the following: commit d6c2303c4efa301ac3c9d526337e005265f2e8d3 Author: Dan Smith Date: Wed Feb 2 12:27:58 2022 -0500 remove our feature-test macros as they're not used commit f5246c2e847b6738dd104107cd39f8c94da549ae Author: Dan Smith Date: Wed Feb 2 12:10:02 2022 -0500 latest from coda-oss commit 60b8649c29b7f258f1fd73172ee5748169caa611 Author: Dan Smith Date: Wed Jan 26 16:05:44 2022 -0500 coda-oss updates to use "bpstd" commit 0e65cc2efcf37edb62e735a5b2c95b17d9654fd4 Merge: ec0434d7 8a8ea90b Author: Dan Smith Date: Wed Jan 26 14:47:43 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit ec0434d71cad7f8043ec5f8d07682315a96d3058 Merge: ed1b011f 9690f907 Author: Dan Smith Date: Wed Jan 26 11:32:54 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit ed1b011f1e5e04f289f7aa538f9c7153872b7a8d Author: Dan Smith Date: Tue Jan 25 15:21:38 2022 -0500 latest from coda-oss commit acc8b54917ac99c4893e63595d233310dc36828a Author: Dan Smith Date: Thu Jan 20 12:29:15 2022 -0500 latest from coda-oss commit daade6cd654b6ce63117441efc5cd7293ec80f14 Merge: 14802296 1d307d9a Author: Dan Smith Date: Thu Jan 20 12:27:31 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 1480229653ab5cc64eecc757373e56622b4dc4c1 Author: Dan Smith Date: Mon Jan 17 14:04:51 2022 -0500 latest from coda-oss commit b58460656df234ad89e7da7e1b4372a8926f891c Merge: 08b4a933 c71dc6d8 Author: Dan Smith Date: Mon Jan 17 14:03:52 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 08b4a93390ab68ee0059dd1e73832111871fbdcd Author: Dan Smith Date: Mon Jan 17 09:39:55 2022 -0500 require the specified C and C++ versions commit f7669f991be211c6bbe9262753720ec80ff6f878 Author: Dan Smith Date: Mon Jan 17 09:24:45 2022 -0500 latest from coda-oss commit d8efd9f0a8c11314f1ab5d936338f82763f77f22 Author: J. Daniel Smith Date: Fri Jan 14 12:55:25 2022 -0500 be sure variables are referenced to avoid compiler warnings commit 7e343a22c4471680a0a0d7a719846b691e008594 Author: Dan Smith Date: Fri Jan 14 11:06:30 2022 -0500 rename Filesystem commit c5e4489e940af378e6f36ad4d18dede28786c80f Author: Dan Smith Date: Fri Jan 14 11:05:53 2022 -0500 rename Filesystem commit 8c1c253e2349e23c25859b3f30c4dbb2f5e8dfe0 Author: Dan Smith Date: Fri Jan 14 10:57:57 2022 -0500 add missing headers to coda_oss/optional.h commit f6c515959b6e0e6a381508737d974c846ecf03b8 Author: Dan Smith Date: Fri Jan 14 10:36:35 2022 -0500 get rid of compiler warning commit f5436d4b97fdd0a0093023971e6e6dde63d52847 Author: Dan Smith Date: Fri Jan 14 10:27:27 2022 -0500 latest from coda-oss commit 7d476063c8495fd507f99219b15c8750f41f5967 Merge: 3fc510cf db9f1d2a Author: Dan Smith Date: Fri Jan 14 10:10:56 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 3fc510cfc5c97ea243206a802353992515c991a0 Author: Dan Smith Date: Mon Jan 10 13:19:53 2022 -0500 fix TypeTraits.h commit e43ebb21bbf6a49dd37a4d0f4c22c2a6a155457d Author: Dan Smith Date: Mon Jan 10 10:19:01 2022 -0500 latest from coda-oss commit 105dd17f2e177ed8d2f0aa230d1ae3d7239d838a Author: Dan Smith Date: Mon Jan 10 09:59:56 2022 -0500 type_traits from coda-oss commit 1de69902f39eec9cc246e9592b3af825d5815185 Merge: 814dc912 d991a049 Author: Dan Smith Date: Mon Jan 10 09:58:09 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 814dc91268e20bfa12577091a0a7fc7f5801b503 Author: Dan Smith Date: Wed Jan 5 09:32:34 2022 -0500 latest from coda-oss commit fe3db61c0527fa6d0fc36d816b32fce8c5f8fb68 Merge: 6cccaaef fe89ce31 Author: Dan Smith Date: Wed Jan 5 09:31:08 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 6cccaaef59ee883c7483eb9481f483cd976bc31f Author: Dan Smith Date: Mon Jan 3 15:43:56 2022 -0500 str::strip commit 6ca278651bd2ccb5f1987217b99e0a911c125c56 Author: Dan Smith Date: Mon Jan 3 12:10:50 2022 -0500 explicitly =delete moves commit c6f4413b0a05d0cb0ad0178a04e49cc1829f69dd Author: Dan Smith Date: Mon Jan 3 11:44:30 2022 -0500 latest from coda-oss commit 8483731799f17ed2ecd6a4e8717704d9499cbea4 Merge: 063d7fc9 9ea44741 Author: Dan Smith Date: Mon Jan 3 11:42:58 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 063d7fc9c7e6dd5d48f2b9d3703f5e0b042aa79e Merge: 4ae95d0c d4ad4b8a Author: Dan Smith Date: Mon Dec 13 11:13:13 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4ae95d0c4ea5cfa775774809aab87eca651aad0b Author: Dan Smith Date: Mon Dec 13 11:01:01 2021 -0500 coda-oss release 2021-12-13 commit 50a0c4763ca97bdaf4ff8613a36ed7b2b9481276 Author: Dan Smith Date: Mon Dec 13 10:58:10 2021 -0500 Squashed commit of the following: commit c2354a768f0b6f9a5fa9cff064fd182d3438b353 Author: Dan Smith Date: Tue Dec 7 16:44:18 2021 -0500 Update TestCase.h commit 93727a2f06cea62a40dbab073b2d58ae139c022b Merge: 9c7eb207 7c96994a Author: Dan Smith Date: Tue Dec 7 16:41:19 2021 -0500 Merge branch 'master' into develop/jdsmith commit 9c7eb2076903edc507b3426f38086d1ce553e1ae Merge: 6863bdcb 1b22d00a Author: Dan Smith Date: Tue Dec 7 16:14:21 2021 -0500 Merge branch 'master' into develop/jdsmith commit 6863bdcb9d139aa8f98cc8f8b386bbfbbf835f03 Author: Dan Smith Date: Tue Dec 7 15:50:26 2021 -0500 Squashed commit of the following: commit 5e6e22b25c77c6b705aa7dda0258c7805b7a315a Author: Dan Smith Date: Tue Dec 7 15:49:44 2021 -0500 latest from coda-oss commit b91e345a03a6b06678ee4ff7157ef1595ee289e6 Author: Dan Smith Date: Tue Dec 7 10:56:41 2021 -0500 latest from coda-oss commit d2d1d543aa6e97f311d5b5bf52b2b8d7e7f1502b Author: Dan Smith Date: Mon Dec 6 16:39:26 2021 -0500 more "Throwable" updates from coda-oss commit 1d65ff9db316bbd0087ed4a0e15295692b0cca43 Author: Dan Smith Date: Mon Dec 6 16:06:35 2021 -0500 latest "Throwable" changes from coda-oss commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit bc3ebc4f5252721e63fb7b1c888f2d8955878436 Author: Dan Smith Date: Tue Dec 7 11:23:43 2021 -0500 build C unittests commit 81b1d3d55b8c0f5fff01fd23769c90838965eebe Author: Dan Smith Date: Tue Dec 7 11:03:44 2021 -0500 Update TestCase.h commit d39796cffc53db29fddbb4adfcbdade73a1ce4d7 Author: Dan Smith Date: Tue Dec 7 10:57:21 2021 -0500 Squashed commit of the following: commit b91e345a03a6b06678ee4ff7157ef1595ee289e6 Author: Dan Smith Date: Tue Dec 7 10:56:41 2021 -0500 latest from coda-oss commit d2d1d543aa6e97f311d5b5bf52b2b8d7e7f1502b Author: Dan Smith Date: Mon Dec 6 16:39:26 2021 -0500 more "Throwable" updates from coda-oss commit 1d65ff9db316bbd0087ed4a0e15295692b0cca43 Author: Dan Smith Date: Mon Dec 6 16:06:35 2021 -0500 latest "Throwable" changes from coda-oss commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit ebb8e5d0f230d3fda7ac9777bf3d6411ae969e10 Author: Dan Smith Date: Tue Dec 7 10:47:23 2021 -0500 one more Throwable11 commit d8e85171c1244b5a84e0366b0feeb0134de67fe0 Author: Dan Smith Date: Tue Dec 7 10:23:36 2021 -0500 catch Throwable11 too commit e18da07d2c25b5f513167245cd23f62e0be71d10 Author: Dan Smith Date: Mon Dec 6 16:40:47 2021 -0500 Squashed commit of the following: commit d2d1d543aa6e97f311d5b5bf52b2b8d7e7f1502b Author: Dan Smith Date: Mon Dec 6 16:39:26 2021 -0500 more "Throwable" updates from coda-oss commit 1d65ff9db316bbd0087ed4a0e15295692b0cca43 Author: Dan Smith Date: Mon Dec 6 16:06:35 2021 -0500 latest "Throwable" changes from coda-oss commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit 51b6d40df6d6540ef65d5a463db8ffe879f3c47a Author: Dan Smith Date: Mon Dec 6 16:07:10 2021 -0500 Squashed commit of the following: commit 1d65ff9db316bbd0087ed4a0e15295692b0cca43 Author: Dan Smith Date: Mon Dec 6 16:06:35 2021 -0500 latest "Throwable" changes from coda-oss commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit 805f02c5464d0a7c26b7fd4f464abfc88521bf95 Author: Dan Smith Date: Mon Dec 6 15:29:03 2021 -0500 Squashed commit of the following: commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit 048b8f99262375a8739f1ccc610e753270673856 Author: Dan Smith Date: Mon Dec 6 11:21:32 2021 -0500 MemoryDestructor::operator() is "noexcpet(false)" commit b0a0f67be360f05f69a491368851856d86314055 Author: Dan Smith Date: Mon Dec 6 10:42:02 2021 -0500 implicitConstruct() can complain NITF_PLUGIN_PATH, provide a way to turn that off commit 80af6b44d4bf16c281bcfa8f98a3765ab842967a Author: Dan Smith Date: Thu Dec 2 11:59:46 2021 -0500 Squashed commit of the following: commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit f6f01910438a14fdc2f738e055a442fc9faf82b7 Author: Dan Smith Date: Thu Dec 2 11:25:53 2021 -0500 Squashed commit of the following: commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit 2c2275ef6e7c178af890f371e562f93f5819ef40 Author: Dan Smith Date: Wed Dec 1 10:33:18 2021 -0500 Squashed commit of the following: commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit 4fa223eb9eff1171cbdd19edb11656a33bf81ee4 Merge: f6b78b44 2747740a Author: Dan Smith Date: Wed Dec 1 10:28:36 2021 -0500 Merge branch 'develop/jdsmith' of github.com:mdaus/nitro into develop/jdsmith commit 2747740a6f18ac2614a76455b5df5e2d36bff120 Author: Dan Smith Date: Tue Nov 16 17:05:00 2021 -0500 'noexcept' breaks existing code commit f6b78b44be8e7fed442ad514efe3a87b4532bef3 Merge: fc1ea1b5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:01:14 2021 -0500 Merge branch 'master' into develop/jdsmith commit fc1ea1b5f45cedcf06280e421ba017b64f6340c4 Merge: 49f9f76f 9461c626 Author: Dan Smith Date: Tue Nov 16 15:40:24 2021 -0500 Merge branch 'master' into develop/jdsmith commit 49f9f76fe276ccf43109a0c8cfa75544ebc45ec9 Author: Dan Smith Date: Tue Nov 16 10:52:39 2021 -0500 be sure a == b gives the same results as !(a != b) commit 11fb89801be2f3b1f00d2182eeeaf396fc9d3a42 Author: J. Daniel Smith Date: Mon Nov 15 20:22:52 2021 -0500 Squashed commit of the following: commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb9 2e8d7cfae Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa79 64dc4e118 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701d 888ae9293 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c1 28d95160e Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa5114 dfba5e291 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf977 a4a1fc4f8 Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdfa eef3c6ec8 Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f3 f5f1f8ce1 Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b7635 0db498f1e Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba3 9388d5cf2 Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b26 81278527b Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b061 c8186387f Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807a dc000a516 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f200464 7af555d63 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea52593 cb37a8cff Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e596027 1b6cfe099 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe390482 2229fbde0 Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b83 835da56f5 Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c0 7bb82996c Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bfc 98e6bcf5d Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168d ffd5aa858 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857ab 4ddaf23d8 Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d39 2a57741c2 Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4b 8806960a8 Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d39 a16f72b0c Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819dbd 273c39e86 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf579 298536f40 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e57 c1def5d0b Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec21 edb9317db Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b34 edb9317db Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09b 2748224ba Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8c 2748224ba Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b2 a2b3a12d9 Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b38 c68cd17dd Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d46965774 bb0634924 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f69 fa20f42ee Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb2 c80e163ee Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a84 dfad79efc Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f7420 e40a0b3f6 Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15b 7c5dbed7f Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576b 612a55889 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4b c14639765 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4bc 14517c04f Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e0 f62735eb5 Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f916 8705bbb63 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b252 62ec49119 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e1011253 62ec49119 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab20 b7f04aecb Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d28 f810f8f6e Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70f f810f8f6e Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95a f0a45b36d Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f6 1b6ae6adb Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee4 ee89c7d34 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad0136140 1615ce17b Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc4 0fbebcbdc Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b8 91cb40798 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c82540 280141628 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d6 bc379d3f7 Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3a f419dc538 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c7 2d73f0ee1 Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538b 0d6988eb1 Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c0959 0d6988eb1 Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c41 5be4b7e63 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1da 92b19f9c5 Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d9 c1ef1e933 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f16826 aa22bcb57 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f6 8a97faadd Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e4 09c201636 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30f 1f3991624 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c3736061 f17909e9a Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af283859 9a609577c Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f16 c83348fd3 Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a086 a49805f17 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit c7db8465c67aa4db9ae5a2c9367743608f504002 Author: Dan Smith Date: Mon Nov 15 17:50:58 2021 -0500 Squashed commit of the following: commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit c13fc831aee807bfda9bc73f032e2e5f305d8edf Merge: 3ae221bd 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 17:50:46 2021 -0500 Merge branch 'master' into develop/jdsmith commit 3ae221bde34db36ed927a1f5282ab6dc4ec9ca99 Author: Dan Smith Date: Tue Nov 9 17:05:23 2021 -0500 tweaks from "main" commit edb5d2ce24151e63bf477a20a3942d1bceeeb42c Merge: 24201006 e868e374 Author: Dan Smith Date: Tue Nov 9 16:47:21 2021 -0500 Merge branch 'master' into develop/jdsmith commit 24201006a823059f8d15dd17c8406548c3c5bacc Author: Dan Smith Date: Tue Nov 9 15:56:51 2021 -0500 Squashed commit of the following: commit 37cd476058a5368d1ffb77e44b4c12430cb07d60 Author: Dan Smith Date: Tue Nov 9 14:29:37 2021 -0500 fix "noexcept" compiler error commit a77c8bf23f0cdec1b117480ed3e15ee2f97ad7fe Author: Dan Smith Date: Tue Nov 9 14:08:08 2021 -0500 remove (or #pragma-away) more compiler warnings commit 658ea41d14312ea1ae4064e46e3ca13b44c331b8 Author: Dan Smith Date: Tue Nov 9 14:07:16 2021 -0500 Squashed commit of the following: commit b04638d2863fc1c1e5ea321811707d8911071f2c Author: Dan Smith Date: Tue Nov 9 13:23:38 2021 -0500 #pragma away some compiler warnings commit e4679d4d2f7a1df92d0427c7d159e74113fd0720 Merge: 1bda4296 65b4df02 Author: Dan Smith Date: Tue Nov 9 12:55:40 2021 -0500 Merge branch 'master' into develop/jdsmith commit 1bda429694357d27224707d1f84c403d4b23805c Author: Dan Smith Date: Tue Nov 9 12:20:47 2021 -0500 fix errors found with building with C++20 commit 1a3285ab5664989f54fe2de2786b5779263017de Author: Dan Smith Date: Mon Nov 8 15:20:20 2021 -0500 build Test++ w/VS2022 commit 23b0fe1b4b5d5ca1c7b1b32811ea3406dd69bfc7 Author: Dan Smith Date: Mon Nov 8 15:08:50 2021 -0500 build Test project with VS2022 commit 319e7aff066a7aa02a1ed6662a876362b8bc92a8 Author: Dan Smith Date: Mon Nov 8 14:37:24 2021 -0500 VS2022 commit 565f72b69f0036a61e14141a87bcfc434ff2e649 Merge: 59c3e5b3 64dc4e11 Author: Dan Smith Date: Mon Nov 8 11:56:22 2021 -0500 Merge branch 'master' into develop/jdsmith commit 59c3e5b3ddd8cb0422a65684f1aac711ad80ac3d Author: Dan Smith Date: Mon Oct 18 09:26:59 2021 -0400 tweaks from "main" to build with C++17 commit d09f5ed46a12050a5799a2db3a12ff935ec12ef0 Merge: c08dbd52 dfba5e29 Author: Dan Smith Date: Mon Oct 18 09:11:53 2021 -0400 Merge branch 'master' into develop/jdsmith commit c08dbd528725669117ad8c4b30b123ad05e1249b Author: Dan Smith Date: Fri Oct 15 12:02:23 2021 -0400 Squashed commit of the following: commit 0c3a4a65e8db1cd1088de3ede808d0fedfda5ca3 Merge: 2600cedb 3c7653c3 Author: Dan Smith Date: Fri Oct 15 12:01:54 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 2600cedb4c820d8716ce4f87dcdaa15ec5a12295 Author: Dan Smith Date: Fri Oct 15 12:01:35 2021 -0400 braced-initialization causes CodeQL to fail? commit 45eb7bf729eeca30842e05fdf09db1617d0b384d Merge: 29854176 e17d918d Author: Dan Smith Date: Fri Oct 15 11:29:59 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 29854176ab1e941e0ebb588dcc1e8d1f7d916929 Author: Dan Smith Date: Tue Oct 12 15:29:33 2021 -0400 load 8-bit AMP files commit 80e8167fb2df6712620d99e5faba0311c2691cd3 Author: Dan Smith Date: Tue Oct 12 14:53:47 2021 -0400 8-bit AMP/PHS sample files commit d15754270e96e98ec59e58c73ca218d595a03831 Merge: a2ed1398 b7867398 Author: Dan Smith Date: Tue Oct 12 14:48:41 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit a2ed1398e1b4d692696f6bbc69b9bbf58a390ff8 Author: Dan Smith Date: Mon Oct 11 16:11:16 2021 -0400 need operator<< for unit-tests commit 668cd2d52a7bd1a9d3e877e684b2a530d12f90da Author: Dan Smith Date: Mon Oct 11 15:51:24 2021 -0400 more use of enums commit 67e933b5e726ec0898b106bc428511314b02cb31 Author: Dan Smith Date: Mon Oct 11 15:38:10 2021 -0400 use enums in test_image_loading commit 432d2890d7ef6efeb9beeb08332c9e6b4b4e2cd6 Author: Dan Smith Date: Mon Oct 11 11:15:53 2021 -0400 tweaks from SIX commit e7d3e70d643ca1c781ea355b7acd63edf3696eed Author: Dan Smith Date: Mon Oct 11 10:24:13 2021 -0400 make enums more descriptive rather than following cryptic C style commit 0764c55b75236c616e4d56d39f4da3166c444dcf Author: Dan Smith Date: Mon Oct 11 10:23:08 2021 -0400 nitro_image_.c -> nitro_image_.c_ commit 6f88781ea7ea187ee91e0d06c891db4a7ac86479 Author: Dan Smith Date: Thu Oct 7 16:33:48 2021 -0400 Squashed commit of the following: commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 5ee2381e91ef8d8294238199e0c229e946bc809a Merge: 052e5ced 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:17 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 052e5cedd98f59b20ab1b2c8c3b3db177477cfcb Author: Dan Smith Date: Thu Oct 7 15:26:28 2021 -0400 fix broken build with nitro_image.c commit 308be858f0d05e007b419cd048028085ce2ace69 Author: Dan Smith Date: Thu Oct 7 15:03:47 2021 -0400 enums for IREP and BlockingMode commit c880f175fb6da6603751312ab28b42b48d995b95 Author: Dan Smith Date: Thu Oct 7 14:14:47 2021 -0400 add nitf::PixelType to represent #defines in ImageIO.h commit 888c661a5c151a65d4ea18efd2974acefad483a9 Author: Dan Smith Date: Thu Oct 7 13:49:19 2021 -0400 Squashed commit of the following: commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 7d482d2f9c09b46cc5292880c2d44b0dddaf2b65 Merge: 24fa925f 3c7653c3 Author: Dan Smith Date: Fri Oct 15 12:02:14 2021 -0400 Merge branch 'master' into develop/jdsmith commit 24fa925f2468ba6f3015e0818d7c5cbe90ed89e7 Merge: 4a537c0f e17d918d Author: Dan Smith Date: Fri Oct 15 11:29:51 2021 -0400 Merge branch 'master' into develop/jdsmith commit 4a537c0f2da01f1fb7a048ab4e161afb5e1fe4c1 Author: Dan Smith Date: Fri Oct 15 11:25:29 2021 -0400 Build as StaticLibaray commit f686b20b64b5f256939534ecc2ac258fb35d8f38 Author: Dan Smith Date: Fri Oct 15 11:07:38 2021 -0400 need more work to build as DLL commit 970aabefca96d9112cf1d3051f0ec3ff545bd7cf Author: Dan Smith Date: Fri Oct 15 11:07:26 2021 -0400 "noexcept" commit e90546578d9d40e4eb2c0c37c0e02e2282c7cd53 Author: Dan Smith Date: Fri Oct 15 10:34:42 2021 -0400 fix Windows build commit 0364f51a1a38835bb980cc9102ba3c8d31d4d14b Author: Dan Smith Date: Fri Oct 15 10:07:35 2021 -0400 build as a DLL in Visual Studio commit 95ab27ca3676b7749fbe4e726ffbc0c80c39ae67 Author: Dan Smith Date: Fri Oct 15 10:07:20 2021 -0400 unit-tests use ENGRDA TRE commit ec277ffd0749ba2392accbbddabcf1efdcdb358f Author: Dan Smith Date: Fri Oct 15 09:52:57 2021 -0400 =default should be in CPP file because 'Impl" isn't defined in .h commit 833ab37d5997553a5dcb621c6b393e6cfc26c897 Author: Dan Smith Date: Fri Oct 15 08:34:40 2021 -0400 Squashed commit of the following: commit 29854176ab1e941e0ebb588dcc1e8d1f7d916929 Author: Dan Smith Date: Tue Oct 12 15:29:33 2021 -0400 load 8-bit AMP files commit 80e8167fb2df6712620d99e5faba0311c2691cd3 Author: Dan Smith Date: Tue Oct 12 14:53:47 2021 -0400 8-bit AMP/PHS sample files commit d15754270e96e98ec59e58c73ca218d595a03831 Merge: a2ed1398 b7867398 Author: Dan Smith Date: Tue Oct 12 14:48:41 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit a2ed1398e1b4d692696f6bbc69b9bbf58a390ff8 Author: Dan Smith Date: Mon Oct 11 16:11:16 2021 -0400 need operator<< for unit-tests commit 668cd2d52a7bd1a9d3e877e684b2a530d12f90da Author: Dan Smith Date: Mon Oct 11 15:51:24 2021 -0400 more use of enums commit 67e933b5e726ec0898b106bc428511314b02cb31 Author: Dan Smith Date: Mon Oct 11 15:38:10 2021 -0400 use enums in test_image_loading commit 432d2890d7ef6efeb9beeb08332c9e6b4b4e2cd6 Author: Dan Smith Date: Mon Oct 11 11:15:53 2021 -0400 tweaks from SIX commit e7d3e70d643ca1c781ea355b7acd63edf3696eed Author: Dan Smith Date: Mon Oct 11 10:24:13 2021 -0400 make enums more descriptive rather than following cryptic C style commit 0764c55b75236c616e4d56d39f4da3166c444dcf Author: Dan Smith Date: Mon Oct 11 10:23:08 2021 -0400 nitro_image_.c -> nitro_image_.c_ commit 6f88781ea7ea187ee91e0d06c891db4a7ac86479 Author: Dan Smith Date: Thu Oct 7 16:33:48 2021 -0400 Squashed commit of the following: commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 5ee2381e91ef8d8294238199e0c229e946bc809a Merge: 052e5ced 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:17 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 052e5cedd98f59b20ab1b2c8c3b3db177477cfcb Author: Dan Smith Date: Thu Oct 7 15:26:28 2021 -0400 fix broken build with nitro_image.c commit 308be858f0d05e007b419cd048028085ce2ace69 Author: Dan Smith Date: Thu Oct 7 15:03:47 2021 -0400 enums for IREP and BlockingMode commit c880f175fb6da6603751312ab28b42b48d995b95 Author: Dan Smith Date: Thu Oct 7 14:14:47 2021 -0400 add nitf::PixelType to represent #defines in ImageIO.h commit 888c661a5c151a65d4ea18efd2974acefad483a9 Author: Dan Smith Date: Thu Oct 7 13:49:19 2021 -0400 Squashed commit of the following: commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit cea2b5b66c5852b3e5598200e9a70a627b1d1bbf Merge: 9d0aa054 b7867398 Author: Dan Smith Date: Fri Oct 15 08:34:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit 793675d659fa4835b2818fa4191e6b8e8d29fa57 Merge: 210f5fa5 65b4df02 Author: Dan Smith Date: Tue Nov 9 14:06:17 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 210f5fa53a6d246671dd8b890dc429c247c0a238 Author: Dan Smith Date: Wed Aug 25 12:17:26 2021 -0400 remove warning about "unused parameter" commit 8713d386a56db548c4475c9e0050881b3674022f Author: Dan Smith Date: Wed Aug 25 12:09:30 2021 -0400 Squashed commit of the following: commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c414a329aaf6f0247ec481739377a199550908cc Merge: 51b0a83a 81278527 Author: Dan Smith Date: Wed Aug 25 12:09:16 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 51b0a83a29edaf7374aea8263c113edc214ba429 Author: Dan Smith Date: Wed Aug 25 11:08:47 2021 -0400 remove G++ compiler warning commit 9d2c4192777599b449d4fd793fe26f401b61c0dc Merge: ed66875f 3ebffd87 Author: Dan Smith Date: Wed Aug 25 11:02:13 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit ed66875f577253218c3c6eb05ac342e07d6a34d9 Author: Dan Smith Date: Wed Aug 25 10:58:13 2021 -0400 reduce GCC compiler warnings commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit b04638d2863fc1c1e5ea321811707d8911071f2c Author: Dan Smith Date: Tue Nov 9 13:23:38 2021 -0500 #pragma away some compiler warnings commit e4679d4d2f7a1df92d0427c7d159e74113fd0720 Merge: 1bda4296 65b4df02 Author: Dan Smith Date: Tue Nov 9 12:55:40 2021 -0500 Merge branch 'master' into develop/jdsmith commit 1bda429694357d27224707d1f84c403d4b23805c Author: Dan Smith Date: Tue Nov 9 12:20:47 2021 -0500 fix errors found with building with C++20 commit 1a3285ab5664989f54fe2de2786b5779263017de Author: Dan Smith Date: Mon Nov 8 15:20:20 2021 -0500 build Test++ w/VS2022 commit 23b0fe1b4b5d5ca1c7b1b32811ea3406dd69bfc7 Author: Dan Smith Date: Mon Nov 8 15:08:50 2021 -0500 build Test project with VS2022 commit 319e7aff066a7aa02a1ed6662a876362b8bc92a8 Author: Dan Smith Date: Mon Nov 8 14:37:24 2021 -0500 VS2022 commit 565f72b69f0036a61e14141a87bcfc434ff2e649 Merge: 59c3e5b3 64dc4e11 Author: Dan Smith Date: Mon Nov 8 11:56:22 2021 -0500 Merge branch 'master' into develop/jdsmith commit 59c3e5b3ddd8cb0422a65684f1aac711ad80ac3d Author: Dan Smith Date: Mon Oct 18 09:26:59 2021 -0400 tweaks from "main" to build with C++17 commit d09f5ed46a12050a5799a2db3a12ff935ec12ef0 Merge: c08dbd52 dfba5e29 Author: Dan Smith Date: Mon Oct 18 09:11:53 2021 -0400 Merge branch 'master' into develop/jdsmith commit c08dbd528725669117ad8c4b30b123ad05e1249b Author: Dan Smith Date: Fri Oct 15 12:02:23 2021 -0400 Squashed commit of the following: commit 0c3a4a65e8db1cd1088de3ede808d0fedfda5ca3 Merge: 2600cedb 3c7653c3 Author: Dan Smith Date: Fri Oct 15 12:01:54 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 2600cedb4c820d8716ce4f87dcdaa15ec5a12295 Author: Dan Smith Date: Fri Oct 15 12:01:35 2021 -0400 braced-initialization causes CodeQL to fail? commit 45eb7bf729eeca30842e05fdf09db1617d0b384d Merge: 29854176 e17d918d Author: Dan Smith Date: Fri Oct 15 11:29:59 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 29854176ab1e941e0ebb588dcc1e8d1f7d916929 Author: Dan Smith Date: Tue Oct 12 15:29:33 2021 -0400 load 8-bit AMP files commit 80e8167fb2df6712620d99e5faba0311c2691cd3 Author: Dan Smith Date: Tue Oct 12 14:53:47 2021 -0400 8-bit AMP/PHS sample files commit d15754270e96e98ec59e58c73ca218d595a03831 Merge: a2ed1398 b7867398 Author: Dan Smith Date: Tue Oct 12 14:48:41 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit a2ed1398e1b4d692696f6bbc69b9bbf58a390ff8 Author: Dan Smith Date: Mon Oct 11 16:11:16 2021 -0400 need operator<< for unit-tests commit 668cd2d52a7bd1a9d3e877e684b2a530d12f90da Author: Dan Smith Date: Mon Oct 11 15:51:24 2021 -0400 more use of enums commit 67e933b5e726ec0898b106bc428511314b02cb31 Author: Dan Smith Date: Mon Oct 11 15:38:10 2021 -0400 use enums in test_image_loading commit 432d2890d7ef6efeb9beeb08332c9e6b4b4e2cd6 Author: Dan Smith Date: Mon Oct 11 11:15:53 2021 -0400 tweaks from SIX commit e7d3e70d643ca1c781ea355b7acd63edf3696eed Author: Dan Smith Date: Mon Oct 11 10:24:13 2021 -0400 make enums more descriptive rather than following cryptic C style commit 0764c55b75236c616e4d56d39f4da3166c444dcf Author: Dan Smith Date: Mon Oct 11 10:23:08 2021 -0400 nitro_image_.c -> nitro_image_.c_ commit 6f88781ea7ea187ee91e0d06c891db4a7ac86479 Author: Dan Smith Date: Thu Oct 7 16:33:48 2021 -0400 Squashed commit of the following: commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 5ee2381e91ef8d8294238199e0c229e946bc809a Merge: 052e5ced 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:17 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 052e5cedd98f59b20ab1b2c8c3b3db177477cfcb Author: Dan Smith Date: Thu Oct 7 15:26:28 2021 -0400 fix broken build with nitro_image.c commit 308be858f0d05e007b419cd048028085ce2ace69 Author: Dan Smith Date: Thu Oct 7 15:03:47 2021 -0400 enums for IREP and BlockingMode commit c880f175fb6da6603751312ab28b42b48d995b95 Author: Dan Smith Date: Thu Oct 7 14:14:47 2021 -0400 add nitf::PixelType to represent #defines in ImageIO.h commit 888c661a5c151a65d4ea18efd2974acefad483a9 Author: Dan Smith Date: Thu Oct 7 13:49:19 2021 -0400 Squashed commit of the following: commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 7d482d2f9c09b46cc5292880c2d44b0dddaf2b65 Merge: 24fa925f 3c7653c3 Author: Dan Smith Date: Fri Oct 15 12:02:14 2021 -0400 Merge branch 'master' into develop/jdsmith commit 24fa925f2468ba6f3015e0818d7c5cbe90ed89e7 Merge: 4a537c0f e17d918d Author: Dan Smith Date: Fri Oct 15 11:29:51 2021 -0400 Merge branch 'master' into develop/jdsmith commit 4a537c0f2da01f1fb7a048ab4e161afb5e1fe4c1 Author: Dan Smith Date: Fri Oct 15 11:25:29 2021 -0400 Build as StaticLibaray commit f686b20b64b5f256939534ecc2ac258fb35d8f38 Author: Dan Smith Date: Fri Oct 15 11:07:38 2021 -0400 need more work to build as DLL commit 970aabefca96d9112cf1d3051f0ec3ff545bd7cf Author: Dan Smith Date: Fri Oct 15 11:07:26 2021 -0400 "noexcept" commit e90546578d9d40e4eb2c0c37c0e02e2282c7cd53 Author: Dan Smith Date: Fri Oct 15 10:34:42 2021 -0400 fix Windows build commit 0364f51a1a38835bb980cc9102ba3c8d31d4d14b Author: Dan Smith Date: Fri Oct 15 10:07:35 2021 -0400 build as a DLL in Visual Studio commit 95ab27ca3676b7749fbe4e726ffbc0c80c39ae67 Author: Dan Smith Date: Fri Oct 15 10:07:20 2021 -0400 unit-tests use ENGRDA TRE commit ec277ffd0749ba2392accbbddabcf1efdcdb358f Author: Dan Smith Date: Fri Oct 15 09:52:57 2021 -0400 =default should be in CPP file because 'Impl" isn't defined in .h commit 833ab37d5997553a5dcb621c6b393e6cfc26c897 Author: Dan Smith Date: Fri Oct 15 08:34:40 2021 -0400 Squashed commit of the following: commit 29854176ab1e941e0ebb588dcc1e8d1f7d916929 Author: Dan Smith Date: Tue Oct 12 15:29:33 2021 -0400 load 8-bit AMP files commit 80e8167fb2df6712620d99e5faba0311c2691cd3 Author: Dan Smith Date: Tue Oct 12 14:53:47 2021 -0400 8-bit AMP/PHS sample files commit d15754270e96e98ec59e58c73ca218d595a03831 Merge: a2ed1398 b7867398 Author: Dan Smith Date: Tue Oct 12 14:48:41 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit a2ed1398e1b4d692696f6bbc69b9bbf58a390ff8 Author: Dan Smith Date: Mon Oct 11 16:11:16 2021 -0400 need operator<< for unit-tests commit 668cd2d52a7bd1a9d3e877e684b2a530d12f90da Author: Dan Smith Date: Mon Oct 11 15:51:24 2021 -0400 more use of enums commit 67e933b5e726ec0898b106bc428511314b02cb31 Author: Dan Smith Date: Mon Oct 11 15:38:10 2021 -0400 use enums in test_image_loading commit 432d2890d7ef6efeb9beeb08332c9e6b4b4e2cd6 Author: Dan Smith Date: Mon Oct 11 11:15:53 2021 -0400 tweaks from SIX commit e7d3e70d643ca1c781ea355b7acd63edf3696eed Author: Dan Smith Date: Mon Oct 11 10:24:13 2021 -0400 make enums more descriptive rather than following cryptic C style commit 0764c55b75236c616e4d56d39f4da3166c444dcf Author: Dan Smith Date: Mon Oct 11 10:23:08 2021 -0400 nitro_image_.c -> nitro_image_.c_ commit 6f88781ea7ea187ee91e0d06c891db4a7ac86479 Author: Dan Smith Date: Thu Oct 7 16:33:48 2021 -0400 Squashed commit of the following: commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 5ee2381e91ef8d8294238199e0c229e946bc809a Merge: 052e5ced 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:17 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 052e5cedd98f59b20ab1b2c8c3b3db177477cfcb Author: Dan Smith Date: Thu Oct 7 15:26:28 2021 -0400 fix broken build with nitro_image.c commit 308be858f0d05e007b419cd048028085ce2ace69 Author: Dan Smith Date: Thu Oct 7 15:03:47 2021 -0400 enums for IREP and BlockingMode commit c880f175fb6da6603751312ab28b42b48d995b95 Author: Dan Smith Date: Thu Oct 7 14:14:47 2021 -0400 add nitf::PixelType to represent #defines in ImageIO.h commit 888c661a5c151a65d4ea18efd2974acefad483a9 Author: Dan Smith Date: Thu Oct 7 13:49:19 2021 -0400 Squashed commit of the following: commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit cea2b5b66c5852b3e5598200e9a70a627b1d1bbf Merge: 9d0aa054 b7867398 Author: Dan Smith Date: Fri Oct 15 08:34:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit 3f04116aaa473549bddf237ce27252b241612bbe Merge: 5e6e22b2 7c96994a Author: Dan Smith Date: Mon Dec 13 10:57:49 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 5e6e22b25c77c6b705aa7dda0258c7805b7a315a Author: Dan Smith Date: Tue Dec 7 15:49:44 2021 -0500 latest from coda-oss commit b91e345a03a6b06678ee4ff7157ef1595ee289e6 Author: Dan Smith Date: Tue Dec 7 10:56:41 2021 -0500 latest from coda-oss commit d2d1d543aa6e97f311d5b5bf52b2b8d7e7f1502b Author: Dan Smith Date: Mon Dec 6 16:39:26 2021 -0500 more "Throwable" updates from coda-oss commit 1d65ff9db316bbd0087ed4a0e15295692b0cca43 Author: Dan Smith Date: Mon Dec 6 16:06:35 2021 -0500 latest "Throwable" changes from coda-oss commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 01c592eca8607e7908457bfcfc88bd92cb34bcbc Author: Dan Smith Date: Wed Feb 2 12:13:19 2022 -0500 Squashed commit of the following: commit f5246c2e847b6738dd104107cd39f8c94da549ae Author: Dan Smith Date: Wed Feb 2 12:10:02 2022 -0500 latest from coda-oss commit 60b8649c29b7f258f1fd73172ee5748169caa611 Author: Dan Smith Date: Wed Jan 26 16:05:44 2022 -0500 coda-oss updates to use "bpstd" commit 0e65cc2efcf37edb62e735a5b2c95b17d9654fd4 Merge: ec0434d7 8a8ea90b Author: Dan Smith Date: Wed Jan 26 14:47:43 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit ec0434d71cad7f8043ec5f8d07682315a96d3058 Merge: ed1b011f 9690f907 Author: Dan Smith Date: Wed Jan 26 11:32:54 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit ed1b011f1e5e04f289f7aa538f9c7153872b7a8d Author: Dan Smith Date: Tue Jan 25 15:21:38 2022 -0500 latest from coda-oss commit acc8b54917ac99c4893e63595d233310dc36828a Author: Dan Smith Date: Thu Jan 20 12:29:15 2022 -0500 latest from coda-oss commit daade6cd654b6ce63117441efc5cd7293ec80f14 Merge: 14802296 1d307d9a Author: Dan Smith Date: Thu Jan 20 12:27:31 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 1480229653ab5cc64eecc757373e56622b4dc4c1 Author: Dan Smith Date: Mon Jan 17 14:04:51 2022 -0500 latest from coda-oss commit b58460656df234ad89e7da7e1b4372a8926f891c Merge: 08b4a933 c71dc6d8 Author: Dan Smith Date: Mon Jan 17 14:03:52 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 08b4a93390ab68ee0059dd1e73832111871fbdcd Author: Dan Smith Date: Mon Jan 17 09:39:55 2022 -0500 require the specified C and C++ versions commit f7669f991be211c6bbe9262753720ec80ff6f878 Author: Dan Smith Date: Mon Jan 17 09:24:45 2022 -0500 latest from coda-oss commit d8efd9f0a8c11314f1ab5d936338f82763f77f22 Author: J. Daniel Smith Date: Fri Jan 14 12:55:25 2022 -0500 be sure variables are referenced to avoid compiler warnings commit 7e343a22c4471680a0a0d7a719846b691e008594 Author: Dan Smith Date: Fri Jan 14 11:06:30 2022 -0500 rename Filesystem commit c5e4489e940af378e6f36ad4d18dede28786c80f Author: Dan Smith Date: Fri Jan 14 11:05:53 2022 -0500 rename Filesystem commit 8c1c253e2349e23c25859b3f30c4dbb2f5e8dfe0 Author: Dan Smith Date: Fri Jan 14 10:57:57 2022 -0500 add missing headers to coda_oss/optional.h commit f6c515959b6e0e6a381508737d974c846ecf03b8 Author: Dan Smith Date: Fri Jan 14 10:36:35 2022 -0500 get rid of compiler warning commit f5436d4b97fdd0a0093023971e6e6dde63d52847 Author: Dan Smith Date: Fri Jan 14 10:27:27 2022 -0500 latest from coda-oss commit 7d476063c8495fd507f99219b15c8750f41f5967 Merge: 3fc510cf db9f1d2a Author: Dan Smith Date: Fri Jan 14 10:10:56 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 3fc510cfc5c97ea243206a802353992515c991a0 Author: Dan Smith Date: Mon Jan 10 13:19:53 2022 -0500 fix TypeTraits.h commit e43ebb21bbf6a49dd37a4d0f4c22c2a6a155457d Author: Dan Smith Date: Mon Jan 10 10:19:01 2022 -0500 latest from coda-oss commit 105dd17f2e177ed8d2f0aa230d1ae3d7239d838a Author: Dan Smith Date: Mon Jan 10 09:59:56 2022 -0500 type_traits from coda-oss commit 1de69902f39eec9cc246e9592b3af825d5815185 Merge: 814dc912 d991a049 Author: Dan Smith Date: Mon Jan 10 09:58:09 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 814dc91268e20bfa12577091a0a7fc7f5801b503 Author: Dan Smith Date: Wed Jan 5 09:32:34 2022 -0500 latest from coda-oss commit fe3db61c0527fa6d0fc36d816b32fce8c5f8fb68 Merge: 6cccaaef fe89ce31 Author: Dan Smith Date: Wed Jan 5 09:31:08 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 6cccaaef59ee883c7483eb9481f483cd976bc31f Author: Dan Smith Date: Mon Jan 3 15:43:56 2022 -0500 str::strip commit 6ca278651bd2ccb5f1987217b99e0a911c125c56 Author: Dan Smith Date: Mon Jan 3 12:10:50 2022 -0500 explicitly =delete moves commit c6f4413b0a05d0cb0ad0178a04e49cc1829f69dd Author: Dan Smith Date: Mon Jan 3 11:44:30 2022 -0500 latest from coda-oss commit 8483731799f17ed2ecd6a4e8717704d9499cbea4 Merge: 063d7fc9 9ea44741 Author: Dan Smith Date: Mon Jan 3 11:42:58 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 063d7fc9c7e6dd5d48f2b9d3703f5e0b042aa79e Merge: 4ae95d0c d4ad4b8a Author: Dan Smith Date: Mon Dec 13 11:13:13 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4ae95d0c4ea5cfa775774809aab87eca651aad0b Author: Dan Smith Date: Mon Dec 13 11:01:01 2021 -0500 coda-oss release 2021-12-13 commit 50a0c4763ca97bdaf4ff8613a36ed7b2b9481276 Author: Dan Smith Date: Mon Dec 13 10:58:10 2021 -0500 Squashed commit of the following: commit c2354a768f0b6f9a5fa9cff064fd182d3438b353 Author: Dan Smith Date: Tue Dec 7 16:44:18 2021 -0500 Update TestCase.h commit 93727a2f06cea62a40dbab073b2d58ae139c022b Merge: 9c7eb207 7c96994a Author: Dan Smith Date: Tue Dec 7 16:41:19 2021 -0500 Merge branch 'master' into develop/jdsmith commit 9c7eb2076903edc507b3426f38086d1ce553e1ae Merge: 6863bdcb 1b22d00a Author: Dan Smith Date: Tue Dec 7 16:14:21 2021 -0500 Merge branch 'master' into develop/jdsmith commit 6863bdcb9d139aa8f98cc8f8b386bbfbbf835f03 Author: Dan Smith Date: Tue Dec 7 15:50:26 2021 -0500 Squashed commit of the following: commit 5e6e22b25c77c6b705aa7dda0258c7805b7a315a Author: Dan Smith Date: Tue Dec 7 15:49:44 2021 -0500 latest from coda-oss commit b91e345a03a6b06678ee4ff7157ef1595ee289e6 Author: Dan Smith Date: Tue Dec 7 10:56:41 2021 -0500 latest from coda-oss commit d2d1d543aa6e97f311d5b5bf52b2b8d7e7f1502b Author: Dan Smith Date: Mon Dec 6 16:39:26 2021 -0500 more "Throwable" updates from coda-oss commit 1d65ff9db316bbd0087ed4a0e15295692b0cca43 Author: Dan Smith Date: Mon Dec 6 16:06:35 2021 -0500 latest "Throwable" changes from coda-oss commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit bc3ebc4f5252721e63fb7b1c888f2d8955878436 Author: Dan Smith Date: Tue Dec 7 11:23:43 2021 -0500 build C unittests commit 81b1d3d55b8c0f5fff01fd23769c90838965eebe Author: Dan Smith Date: Tue Dec 7 11:03:44 2021 -0500 Update TestCase.h commit d39796cffc53db29fddbb4adfcbdade73a1ce4d7 Author: Dan Smith Date: Tue Dec 7 10:57:21 2021 -0500 Squashed commit of the following: commit b91e345a03a6b06678ee4ff7157ef1595ee289e6 Author: Dan Smith Date: Tue Dec 7 10:56:41 2021 -0500 latest from coda-oss commit d2d1d543aa6e97f311d5b5bf52b2b8d7e7f1502b Author: Dan Smith Date: Mon Dec 6 16:39:26 2021 -0500 more "Throwable" updates from coda-oss commit 1d65ff9db316bbd0087ed4a0e15295692b0cca43 Author: Dan Smith Date: Mon Dec 6 16:06:35 2021 -0500 latest "Throwable" changes from coda-oss commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit ebb8e5d0f230d3fda7ac9777bf3d6411ae969e10 Author: Dan Smith Date: Tue Dec 7 10:47:23 2021 -0500 one more Throwable11 commit d8e85171c1244b5a84e0366b0feeb0134de67fe0 Author: Dan Smith Date: Tue Dec 7 10:23:36 2021 -0500 catch Throwable11 too commit e18da07d2c25b5f513167245cd23f62e0be71d10 Author: Dan Smith Date: Mon Dec 6 16:40:47 2021 -0500 Squashed commit of the following: commit d2d1d543aa6e97f311d5b5bf52b2b8d7e7f1502b Author: Dan Smith Date: Mon Dec 6 16:39:26 2021 -0500 more "Throwable" updates from coda-oss commit 1d65ff9db316bbd0087ed4a0e15295692b0cca43 Author: Dan Smith Date: Mon Dec 6 16:06:35 2021 -0500 latest "Throwable" changes from coda-oss commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit 51b6d40df6d6540ef65d5a463db8ffe879f3c47a Author: Dan Smith Date: Mon Dec 6 16:07:10 2021 -0500 Squashed commit of the following: commit 1d65ff9db316bbd0087ed4a0e15295692b0cca43 Author: Dan Smith Date: Mon Dec 6 16:06:35 2021 -0500 latest "Throwable" changes from coda-oss commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit 805f02c5464d0a7c26b7fd4f464abfc88521bf95 Author: Dan Smith Date: Mon Dec 6 15:29:03 2021 -0500 Squashed commit of the following: commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit 048b8f99262375a8739f1ccc610e753270673856 Author: Dan Smith Date: Mon Dec 6 11:21:32 2021 -0500 MemoryDestructor::operator() is "noexcpet(false)" commit b0a0f67be360f05f69a491368851856d86314055 Author: Dan Smith Date: Mon Dec 6 10:42:02 2021 -0500 implicitConstruct() can complain NITF_PLUGIN_PATH, provide a way to turn that off commit 80af6b44d4bf16c281bcfa8f98a3765ab842967a Author: Dan Smith Date: Thu Dec 2 11:59:46 2021 -0500 Squashed commit of the following: commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit f6f01910438a14fdc2f738e055a442fc9faf82b7 Author: Dan Smith Date: Thu Dec 2 11:25:53 2021 -0500 Squashed commit of the following: commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit 2c2275ef6e7c178af890f371e562f93f5819ef40 Author: Dan Smith Date: Wed Dec 1 10:33:18 2021 -0500 Squashed commit of the following: commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit 4fa223eb9eff1171cbdd19edb11656a33bf81ee4 Merge: f6b78b44 2747740a Author: Dan Smith Date: Wed Dec 1 10:28:36 2021 -0500 Merge branch 'develop/jdsmith' of github.com:mdaus/nitro into develop/jdsmith commit 2747740a6f18ac2614a76455b5df5e2d36bff120 Author: Dan Smith Date: Tue Nov 16 17:05:00 2021 -0500 'noexcept' breaks existing code commit f6b78b44be8e7fed442ad514efe3a87b4532bef3 Merge: fc1ea1b5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:01:14 2021 -0500 Merge branch 'master' into develop/jdsmith commit fc1ea1b5f45cedcf06280e421ba017b64f6340c4 Merge: 49f9f76f 9461c626 Author: Dan Smith Date: Tue Nov 16 15:40:24 2021 -0500 Merge branch 'master' into develop/jdsmith commit 49f9f76fe276ccf43109a0c8cfa75544ebc45ec9 Author: Dan Smith Date: Tue Nov 16 10:52:39 2021 -0500 be sure a == b gives the same results as !(a != b) commit 11fb89801be2f3b1f00d2182eeeaf396fc9d3a42 Author: J. Daniel Smith Date: Mon Nov 15 20:22:52 2021 -0500 Squashed commit of the following: commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb9 2e8d7cfae Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa79 64dc4e118 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701d 888ae9293 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c1 28d95160e Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa5114 dfba5e291 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf977 a4a1fc4f8 Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdfa eef3c6ec8 Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f3 f5f1f8ce1 Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b7635 0db498f1e Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba3 9388d5cf2 Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b26 81278527b Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b061 c8186387f Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807a dc000a516 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f200464 7af555d63 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea52593 cb37a8cff Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e596027 1b6cfe099 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe390482 2229fbde0 Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b83 835da56f5 Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c0 7bb82996c Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bfc 98e6bcf5d Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168d ffd5aa858 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857ab 4ddaf23d8 Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d39 2a57741c2 Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4b 8806960a8 Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d39 a16f72b0c Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819dbd 273c39e86 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf579 298536f40 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e57 c1def5d0b Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec21 edb9317db Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b34 edb9317db Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09b 2748224ba Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8c 2748224ba Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b2 a2b3a12d9 Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b38 c68cd17dd Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d46965774 bb0634924 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f69 fa20f42ee Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb2 c80e163ee Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a84 dfad79efc Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f7420 e40a0b3f6 Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15b 7c5dbed7f Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576b 612a55889 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4b c14639765 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4bc 14517c04f Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e0 f62735eb5 Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f916 8705bbb63 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b252 62ec49119 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e1011253 62ec49119 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab20 b7f04aecb Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d28 f810f8f6e Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70f f810f8f6e Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95a f0a45b36d Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f6 1b6ae6adb Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee4 ee89c7d34 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad0136140 1615ce17b Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc4 0fbebcbdc Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b8 91cb40798 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c82540 280141628 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d6 bc379d3f7 Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3a f419dc538 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c7 2d73f0ee1 Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538b 0d6988eb1 Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c0959 0d6988eb1 Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c41 5be4b7e63 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1da 92b19f9c5 Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d9 c1ef1e933 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f16826 aa22bcb57 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f6 8a97faadd Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e4 09c201636 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30f 1f3991624 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c3736061 f17909e9a Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af283859 9a609577c Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f16 c83348fd3 Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a086 a49805f17 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit c7db8465c67aa4db9ae5a2c9367743608f504002 Author: Dan Smith Date: Mon Nov 15 17:50:58 2021 -0500 Squashed commit of the following: commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit c13fc831aee807bfda9bc73f032e2e5f305d8edf Merge: 3ae221bd 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 17:50:46 2021 -0500 Merge branch 'master' into develop/jdsmith commit 3ae221bde34db36ed927a1f5282ab6dc4ec9ca99 Author: Dan Smith Date: Tue Nov 9 17:05:23 2021 -0500 tweaks from "main" commit edb5d2ce24151e63bf477a20a3942d1bceeeb42c Merge: 24201006 e868e374 Author: Dan Smith Date: Tue Nov 9 16:47:21 2021 -0500 Merge branch 'master' into develop/jdsmith commit 24201006a823059f8d15dd17c8406548c3c5bacc Author: Dan Smith Date: Tue Nov 9 15:56:51 2021 -0500 Squashed commit of the following: commit 37cd476058a5368d1ffb77e44b4c12430cb07d60 Author: Dan Smith Date: Tue Nov 9 14:29:37 2021 -0500 fix "noexcept" compiler error commit a77c8bf23f0cdec1b117480ed3e15ee2f97ad7fe Author: Dan Smith Date: Tue Nov 9 14:08:08 2021 -0500 remove (or #pragma-away) more compiler warnings commit 658ea41d14312ea1ae4064e46e3ca13b44c331b8 Author: Dan Smith Date: Tue Nov 9 14:07:16 2021 -0500 Squashed commit of the following: commit b04638d2863fc1c1e5ea321811707d8911071f2c Author: Dan Smith Date: Tue Nov 9 13:23:38 2021 -0500 #pragma away some compiler warnings commit e4679d4d2f7a1df92d0427c7d159e74113fd0720 Merge: 1bda4296 65b4df02 Author: Dan Smith Date: Tue Nov 9 12:55:40 2021 -0500 Merge branch 'master' into develop/jdsmith commit 1bda429694357d27224707d1f84c403d4b23805c Author: Dan Smith Date: Tue Nov 9 12:20:47 2021 -0500 fix errors found with building with C++20 commit 1a3285ab5664989f54fe2de2786b5779263017de Author: Dan Smith Date: Mon Nov 8 15:20:20 2021 -0500 build Test++ w/VS2022 commit 23b0fe1b4b5d5ca1c7b1b32811ea3406dd69bfc7 Author: Dan Smith Date: Mon Nov 8 15:08:50 2021 -0500 build Test project with VS2022 commit 319e7aff066a7aa02a1ed6662a876362b8bc92a8 Author: Dan Smith Date: Mon Nov 8 14:37:24 2021 -0500 VS2022 commit 565f72b69f0036a61e14141a87bcfc434ff2e649 Merge: 59c3e5b3 64dc4e11 Author: Dan Smith Date: Mon Nov 8 11:56:22 2021 -0500 Merge branch 'master' into develop/jdsmith commit 59c3e5b3ddd8cb0422a65684f1aac711ad80ac3d Author: Dan Smith Date: Mon Oct 18 09:26:59 2021 -0400 tweaks from "main" to build with C++17 commit d09f5ed46a12050a5799a2db3a12ff935ec12ef0 Merge: c08dbd52 dfba5e29 Author: Dan Smith Date: Mon Oct 18 09:11:53 2021 -0400 Merge branch 'master' into develop/jdsmith commit c08dbd528725669117ad8c4b30b123ad05e1249b Author: Dan Smith Date: Fri Oct 15 12:02:23 2021 -0400 Squashed commit of the following: commit 0c3a4a65e8db1cd1088de3ede808d0fedfda5ca3 Merge: 2600cedb 3c7653c3 Author: Dan Smith Date: Fri Oct 15 12:01:54 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 2600cedb4c820d8716ce4f87dcdaa15ec5a12295 Author: Dan Smith Date: Fri Oct 15 12:01:35 2021 -0400 braced-initialization causes CodeQL to fail? commit 45eb7bf729eeca30842e05fdf09db1617d0b384d Merge: 29854176 e17d918d Author: Dan Smith Date: Fri Oct 15 11:29:59 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 29854176ab1e941e0ebb588dcc1e8d1f7d916929 Author: Dan Smith Date: Tue Oct 12 15:29:33 2021 -0400 load 8-bit AMP files commit 80e8167fb2df6712620d99e5faba0311c2691cd3 Author: Dan Smith Date: Tue Oct 12 14:53:47 2021 -0400 8-bit AMP/PHS sample files commit d15754270e96e98ec59e58c73ca218d595a03831 Merge: a2ed1398 b7867398 Author: Dan Smith Date: Tue Oct 12 14:48:41 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit a2ed1398e1b4d692696f6bbc69b9bbf58a390ff8 Author: Dan Smith Date: Mon Oct 11 16:11:16 2021 -0400 need operator<< for unit-tests commit 668cd2d52a7bd1a9d3e877e684b2a530d12f90da Author: Dan Smith Date: Mon Oct 11 15:51:24 2021 -0400 more use of enums commit 67e933b5e726ec0898b106bc428511314b02cb31 Author: Dan Smith Date: Mon Oct 11 15:38:10 2021 -0400 use enums in test_image_loading commit 432d2890d7ef6efeb9beeb08332c9e6b4b4e2cd6 Author: Dan Smith Date: Mon Oct 11 11:15:53 2021 -0400 tweaks from SIX commit e7d3e70d643ca1c781ea355b7acd63edf3696eed Author: Dan Smith Date: Mon Oct 11 10:24:13 2021 -0400 make enums more descriptive rather than following cryptic C style commit 0764c55b75236c616e4d56d39f4da3166c444dcf Author: Dan Smith Date: Mon Oct 11 10:23:08 2021 -0400 nitro_image_.c -> nitro_image_.c_ commit 6f88781ea7ea187ee91e0d06c891db4a7ac86479 Author: Dan Smith Date: Thu Oct 7 16:33:48 2021 -0400 Squashed commit of the following: commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 5ee2381e91ef8d8294238199e0c229e946bc809a Merge: 052e5ced 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:17 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 052e5cedd98f59b20ab1b2c8c3b3db177477cfcb Author: Dan Smith Date: Thu Oct 7 15:26:28 2021 -0400 fix broken build with nitro_image.c commit 308be858f0d05e007b419cd048028085ce2ace69 Author: Dan Smith Date: Thu Oct 7 15:03:47 2021 -0400 enums for IREP and BlockingMode commit c880f175fb6da6603751312ab28b42b48d995b95 Author: Dan Smith Date: Thu Oct 7 14:14:47 2021 -0400 add nitf::PixelType to represent #defines in ImageIO.h commit 888c661a5c151a65d4ea18efd2974acefad483a9 Author: Dan Smith Date: Thu Oct 7 13:49:19 2021 -0400 Squashed commit of the following: commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 7d482d2f9c09b46cc5292880c2d44b0dddaf2b65 Merge: 24fa925f 3c7653c3 Author: Dan Smith Date: Fri Oct 15 12:02:14 2021 -0400 Merge branch 'master' into develop/jdsmith commit 24fa925f2468ba6f3015e0818d7c5cbe90ed89e7 Merge: 4a537c0f e17d918d Author: Dan Smith Date: Fri Oct 15 11:29:51 2021 -0400 Merge branch 'master' into develop/jdsmith commit 4a537c0f2da01f1fb7a048ab4e161afb5e1fe4c1 Author: Dan Smith Date: Fri Oct 15 11:25:29 2021 -0400 Build as StaticLibaray commit f686b20b64b5f256939534ecc2ac258fb35d8f38 Author: Dan Smith Date: Fri Oct 15 11:07:38 2021 -0400 need more work to build as DLL commit 970aabefca96d9112cf1d3051f0ec3ff545bd7cf Author: Dan Smith Date: Fri Oct 15 11:07:26 2021 -0400 "noexcept" commit e90546578d9d40e4eb2c0c37c0e02e2282c7cd53 Author: Dan Smith Date: Fri Oct 15 10:34:42 2021 -0400 fix Windows build commit 0364f51a1a38835bb980cc9102ba3c8d31d4d14b Author: Dan Smith Date: Fri Oct 15 10:07:35 2021 -0400 build as a DLL in Visual Studio commit 95ab27ca3676b7749fbe4e726ffbc0c80c39ae67 Author: Dan Smith Date: Fri Oct 15 10:07:20 2021 -0400 unit-tests use ENGRDA TRE commit ec277ffd0749ba2392accbbddabcf1efdcdb358f Author: Dan Smith Date: Fri Oct 15 09:52:57 2021 -0400 =default should be in CPP file because 'Impl" isn't defined in .h commit 833ab37d5997553a5dcb621c6b393e6cfc26c897 Author: Dan Smith Date: Fri Oct 15 08:34:40 2021 -0400 Squashed commit of the following: commit 29854176ab1e941e0ebb588dcc1e8d1f7d916929 Author: Dan Smith Date: Tue Oct 12 15:29:33 2021 -0400 load 8-bit AMP files commit 80e8167fb2df6712620d99e5faba0311c2691cd3 Author: Dan Smith Date: Tue Oct 12 14:53:47 2021 -0400 8-bit AMP/PHS sample files commit d15754270e96e98ec59e58c73ca218d595a03831 Merge: a2ed1398 b7867398 Author: Dan Smith Date: Tue Oct 12 14:48:41 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit a2ed1398e1b4d692696f6bbc69b9bbf58a390ff8 Author: Dan Smith Date: Mon Oct 11 16:11:16 2021 -0400 need operator<< for unit-tests commit 668cd2d52a7bd1a9d3e877e684b2a530d12f90da Author: Dan Smith Date: Mon Oct 11 15:51:24 2021 -0400 more use of enums commit 67e933b5e726ec0898b106bc428511314b02cb31 Author: Dan Smith Date: Mon Oct 11 15:38:10 2021 -0400 use enums in test_image_loading commit 432d2890d7ef6efeb9beeb08332c9e6b4b4e2cd6 Author: Dan Smith Date: Mon Oct 11 11:15:53 2021 -0400 tweaks from SIX commit e7d3e70d643ca1c781ea355b7acd63edf3696eed Author: Dan Smith Date: Mon Oct 11 10:24:13 2021 -0400 make enums more descriptive rather than following cryptic C style commit 0764c55b75236c616e4d56d39f4da3166c444dcf Author: Dan Smith Date: Mon Oct 11 10:23:08 2021 -0400 nitro_image_.c -> nitro_image_.c_ commit 6f88781ea7ea187ee91e0d06c891db4a7ac86479 Author: Dan Smith Date: Thu Oct 7 16:33:48 2021 -0400 Squashed commit of the following: commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 5ee2381e91ef8d8294238199e0c229e946bc809a Merge: 052e5ced 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:17 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 052e5cedd98f59b20ab1b2c8c3b3db177477cfcb Author: Dan Smith Date: Thu Oct 7 15:26:28 2021 -0400 fix broken build with nitro_image.c commit 308be858f0d05e007b419cd048028085ce2ace69 Author: Dan Smith Date: Thu Oct 7 15:03:47 2021 -0400 enums for IREP and BlockingMode commit c880f175fb6da6603751312ab28b42b48d995b95 Author: Dan Smith Date: Thu Oct 7 14:14:47 2021 -0400 add nitf::PixelType to represent #defines in ImageIO.h commit 888c661a5c151a65d4ea18efd2974acefad483a9 Author: Dan Smith Date: Thu Oct 7 13:49:19 2021 -0400 Squashed commit of the following: commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit cea2b5b66c5852b3e5598200e9a70a627b1d1bbf Merge: 9d0aa054 b7867398 Author: Dan Smith Date: Fri Oct 15 08:34:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit 793675d659fa4835b2818fa4191e6b8e8d29fa57 Merge: 210f5fa5 65b4df02 Author: Dan Smith Date: Tue Nov 9 14:06:17 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 210f5fa53a6d246671dd8b890dc429c247c0a238 Author: Dan Smith Date: Wed Aug 25 12:17:26 2021 -0400 remove warning about "unused parameter" commit 8713d386a56db548c4475c9e0050881b3674022f Author: Dan Smith Date: Wed Aug 25 12:09:30 2021 -0400 Squashed commit of the following: commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c414a329aaf6f0247ec481739377a199550908cc Merge: 51b0a83a 81278527 Author: Dan Smith Date: Wed Aug 25 12:09:16 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 51b0a83a29edaf7374aea8263c113edc214ba429 Author: Dan Smith Date: Wed Aug 25 11:08:47 2021 -0400 remove G++ compiler warning commit 9d2c4192777599b449d4fd793fe26f401b61c0dc Merge: ed66875f 3ebffd87 Author: Dan Smith Date: Wed Aug 25 11:02:13 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit ed66875f577253218c3c6eb05ac342e07d6a34d9 Author: Dan Smith Date: Wed Aug 25 10:58:13 2021 -0400 reduce GCC compiler warnings commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit b04638d2863fc1c1e5ea321811707d8911071f2c Author: Dan Smith Date: Tue Nov 9 13:23:38 2021 -0500 #pragma away some compiler warnings commit e4679d4d2f7a1df92d0427c7d159e74113fd0720 Merge: 1bda4296 65b4df02 Author: Dan Smith Date: Tue Nov 9 12:55:40 2021 -0500 Merge branch 'master' into develop/jdsmith commit 1bda429694357d27224707d1f84c403d4b23805c Author: Dan Smith Date: Tue Nov 9 12:20:47 2021 -0500 fix errors found with building with C++20 commit 1a3285ab5664989f54fe2de2786b5779263017de Author: Dan Smith Date: Mon Nov 8 15:20:20 2021 -0500 build Test++ w/VS2022 commit 23b0fe1b4b5d5ca1c7b1b32811ea3406dd69bfc7 Author: Dan Smith Date: Mon Nov 8 15:08:50 2021 -0500 build Test project with VS2022 commit 319e7aff066a7aa02a1ed6662a876362b8bc92a8 Author: Dan Smith Date: Mon Nov 8 14:37:24 2021 -0500 VS2022 commit 565f72b69f0036a61e14141a87bcfc434ff2e649 Merge: 59c3e5b3 64dc4e11 Author: Dan Smith Date: Mon Nov 8 11:56:22 2021 -0500 Merge branch 'master' into develop/jdsmith commit 59c3e5b3ddd8cb0422a65684f1aac711ad80ac3d Author: Dan Smith Date: Mon Oct 18 09:26:59 2021 -0400 tweaks from "main" to build with C++17 commit d09f5ed46a12050a5799a2db3a12ff935ec12ef0 Merge: c08dbd52 dfba5e29 Author: Dan Smith Date: Mon Oct 18 09:11:53 2021 -0400 Merge branch 'master' into develop/jdsmith commit c08dbd528725669117ad8c4b30b123ad05e1249b Author: Dan Smith Date: Fri Oct 15 12:02:23 2021 -0400 Squashed commit of the following: commit 0c3a4a65e8db1cd1088de3ede808d0fedfda5ca3 Merge: 2600cedb 3c7653c3 Author: Dan Smith Date: Fri Oct 15 12:01:54 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 2600cedb4c820d8716ce4f87dcdaa15ec5a12295 Author: Dan Smith Date: Fri Oct 15 12:01:35 2021 -0400 braced-initialization causes CodeQL to fail? commit 45eb7bf729eeca30842e05fdf09db1617d0b384d Merge: 29854176 e17d918d Author: Dan Smith Date: Fri Oct 15 11:29:59 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 29854176ab1e941e0ebb588dcc1e8d1f7d916929 Author: Dan Smith Date: Tue Oct 12 15:29:33 2021 -0400 load 8-bit AMP files commit 80e8167fb2df6712620d99e5faba0311c2691cd3 Author: Dan Smith Date: Tue Oct 12 14:53:47 2021 -0400 8-bit AMP/PHS sample files commit d15754270e96e98ec59e58c73ca218d595a03831 Merge: a2ed1398 b7867398 Author: Dan Smith Date: Tue Oct 12 14:48:41 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit a2ed1398e1b4d692696f6bbc69b9bbf58a390ff8 Author: Dan Smith Date: Mon Oct 11 16:11:16 2021 -0400 need operator<< for unit-tests commit 668cd2d52a7bd1a9d3e877e684b2a530d12f90da Author: Dan Smith Date: Mon Oct 11 15:51:24 2021 -0400 more use of enums commit 67e933b5e726ec0898b106bc428511314b02cb31 Author: Dan Smith Date: Mon Oct 11 15:38:10 2021 -0400 use enums in test_image_loading commit 432d2890d7ef6efeb9beeb08332c9e6b4b4e2cd6 Author: Dan Smith Date: Mon Oct 11 11:15:53 2021 -0400 tweaks from SIX commit e7d3e70d643ca1c781ea355b7acd63edf3696eed Author: Dan Smith Date: Mon Oct 11 10:24:13 2021 -0400 make enums more descriptive rather than following cryptic C style commit 0764c55b75236c616e4d56d39f4da3166c444dcf Author: Dan Smith Date: Mon Oct 11 10:23:08 2021 -0400 nitro_image_.c -> nitro_image_.c_ commit 6f88781ea7ea187ee91e0d06c891db4a7ac86479 Author: Dan Smith Date: Thu Oct 7 16:33:48 2021 -0400 Squashed commit of the following: commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 5ee2381e91ef8d8294238199e0c229e946bc809a Merge: 052e5ced 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:17 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 052e5cedd98f59b20ab1b2c8c3b3db177477cfcb Author: Dan Smith Date: Thu Oct 7 15:26:28 2021 -0400 fix broken build with nitro_image.c commit 308be858f0d05e007b419cd048028085ce2ace69 Author: Dan Smith Date: Thu Oct 7 15:03:47 2021 -0400 enums for IREP and BlockingMode commit c880f175fb6da6603751312ab28b42b48d995b95 Author: Dan Smith Date: Thu Oct 7 14:14:47 2021 -0400 add nitf::PixelType to represent #defines in ImageIO.h commit 888c661a5c151a65d4ea18efd2974acefad483a9 Author: Dan Smith Date: Thu Oct 7 13:49:19 2021 -0400 Squashed commit of the following: commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 7d482d2f9c09b46cc5292880c2d44b0dddaf2b65 Merge: 24fa925f 3c7653c3 Author: Dan Smith Date: Fri Oct 15 12:02:14 2021 -0400 Merge branch 'master' into develop/jdsmith commit 24fa925f2468ba6f3015e0818d7c5cbe90ed89e7 Merge: 4a537c0f e17d918d Author: Dan Smith Date: Fri Oct 15 11:29:51 2021 -0400 Merge branch 'master' into develop/jdsmith commit 4a537c0f2da01f1fb7a048ab4e161afb5e1fe4c1 Author: Dan Smith Date: Fri Oct 15 11:25:29 2021 -0400 Build as StaticLibaray commit f686b20b64b5f256939534ecc2ac258fb35d8f38 Author: Dan Smith Date: Fri Oct 15 11:07:38 2021 -0400 need more work to build as DLL commit 970aabefca96d9112cf1d3051f0ec3ff545bd7cf Author: Dan Smith Date: Fri Oct 15 11:07:26 2021 -0400 "noexcept" commit e90546578d9d40e4eb2c0c37c0e02e2282c7cd53 Author: Dan Smith Date: Fri Oct 15 10:34:42 2021 -0400 fix Windows build commit 0364f51a1a38835bb980cc9102ba3c8d31d4d14b Author: Dan Smith Date: Fri Oct 15 10:07:35 2021 -0400 build as a DLL in Visual Studio commit 95ab27ca3676b7749fbe4e726ffbc0c80c39ae67 Author: Dan Smith Date: Fri Oct 15 10:07:20 2021 -0400 unit-tests use ENGRDA TRE commit ec277ffd0749ba2392accbbddabcf1efdcdb358f Author: Dan Smith Date: Fri Oct 15 09:52:57 2021 -0400 =default should be in CPP file because 'Impl" isn't defined in .h commit 833ab37d5997553a5dcb621c6b393e6cfc26c897 Author: Dan Smith Date: Fri Oct 15 08:34:40 2021 -0400 Squashed commit of the following: commit 29854176ab1e941e0ebb588dcc1e8d1f7d916929 Author: Dan Smith Date: Tue Oct 12 15:29:33 2021 -0400 load 8-bit AMP files commit 80e8167fb2df6712620d99e5faba0311c2691cd3 Author: Dan Smith Date: Tue Oct 12 14:53:47 2021 -0400 8-bit AMP/PHS sample files commit d15754270e96e98ec59e58c73ca218d595a03831 Merge: a2ed1398 b7867398 Author: Dan Smith Date: Tue Oct 12 14:48:41 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit a2ed1398e1b4d692696f6bbc69b9bbf58a390ff8 Author: Dan Smith Date: Mon Oct 11 16:11:16 2021 -0400 need operator<< for unit-tests commit 668cd2d52a7bd1a9d3e877e684b2a530d12f90da Author: Dan Smith Date: Mon Oct 11 15:51:24 2021 -0400 more use of enums commit 67e933b5e726ec0898b106bc428511314b02cb31 Author: Dan Smith Date: Mon Oct 11 15:38:10 2021 -0400 use enums in test_image_loading commit 432d2890d7ef6efeb9beeb08332c9e6b4b4e2cd6 Author: Dan Smith Date: Mon Oct 11 11:15:53 2021 -0400 tweaks from SIX commit e7d3e70d643ca1c781ea355b7acd63edf3696eed Author: Dan Smith Date: Mon Oct 11 10:24:13 2021 -0400 make enums more descriptive rather than following cryptic C style commit 0764c55b75236c616e4d56d39f4da3166c444dcf Author: Dan Smith Date: Mon Oct 11 10:23:08 2021 -0400 nitro_image_.c -> nitro_image_.c_ commit 6f88781ea7ea187ee91e0d06c891db4a7ac86479 Author: Dan Smith Date: Thu Oct 7 16:33:48 2021 -0400 Squashed commit of the following: commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 5ee2381e91ef8d8294238199e0c229e946bc809a Merge: 052e5ced 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:17 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 052e5cedd98f59b20ab1b2c8c3b3db177477cfcb Author: Dan Smith Date: Thu Oct 7 15:26:28 2021 -0400 fix broken build with nitro_image.c commit 308be858f0d05e007b419cd048028085ce2ace69 Author: Dan Smith Date: Thu Oct 7 15:03:47 2021 -0400 enums for IREP and BlockingMode commit c880f175fb6da6603751312ab28b42b48d995b95 Author: Dan Smith Date: Thu Oct 7 14:14:47 2021 -0400 add nitf::PixelType to represent #defines in ImageIO.h commit 888c661a5c151a65d4ea18efd2974acefad483a9 Author: Dan Smith Date: Thu Oct 7 13:49:19 2021 -0400 Squashed commit of the following: commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit cea2b5b66c5852b3e5598200e9a70a627b1d1bbf Merge: 9d0aa054 b7867398 Author: Dan Smith Date: Fri Oct 15 08:34:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit 3f04116aaa473549bddf237ce27252b241612bbe Merge: 5e6e22b2 7c96994a Author: Dan Smith Date: Mon Dec 13 10:57:49 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 5e6e22b25c77c6b705aa7dda0258c7805b7a315a Author: Dan Smith Date: Tue Dec 7 15:49:44 2021 -0500 latest from coda-oss commit b91e345a03a6b06678ee4ff7157ef1595ee289e6 Author: Dan Smith Date: Tue Dec 7 10:56:41 2021 -0500 latest from coda-oss commit d2d1d543aa6e97f311d5b5bf52b2b8d7e7f1502b Author: Dan Smith Date: Mon Dec 6 16:39:26 2021 -0500 more "Throwable" updates from coda-oss commit 1d65ff9db316bbd0087ed4a0e15295692b0cca43 Author: Dan Smith Date: Mon Dec 6 16:06:35 2021 -0500 latest "Throwable" changes from coda-oss commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cbc886b5ba2651e463f6333c1972b9e5a8ee51d6 Author: Dan Smith Date: Wed Jan 26 16:08:01 2022 -0500 Squashed commit of the following: commit 60b8649c29b7f258f1fd73172ee5748169caa611 Author: Dan Smith Date: Wed Jan 26 16:05:44 2022 -0500 coda-oss updates to use "bpstd" commit 0e65cc2efcf37edb62e735a5b2c95b17d9654fd4 Merge: ec0434d7 8a8ea90b Author: Dan Smith Date: Wed Jan 26 14:47:43 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit ec0434d71cad7f8043ec5f8d07682315a96d3058 Merge: ed1b011f 9690f907 Author: Dan Smith Date: Wed Jan 26 11:32:54 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit ed1b011f1e5e04f289f7aa538f9c7153872b7a8d Author: Dan Smith Date: Tue Jan 25 15:21:38 2022 -0500 latest from coda-oss commit acc8b54917ac99c4893e63595d233310dc36828a Author: Dan Smith Date: Thu Jan 20 12:29:15 2022 -0500 latest from coda-oss commit daade6cd654b6ce63117441efc5cd7293ec80f14 Merge: 14802296 1d307d9a Author: Dan Smith Date: Thu Jan 20 12:27:31 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 1480229653ab5cc64eecc757373e56622b4dc4c1 Author: Dan Smith Date: Mon Jan 17 14:04:51 2022 -0500 latest from coda-oss commit b58460656df234ad89e7da7e1b4372a8926f891c Merge: 08b4a933 c71dc6d8 Author: Dan Smith Date: Mon Jan 17 14:03:52 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 08b4a93390ab68ee0059dd1e73832111871fbdcd Author: Dan Smith Date: Mon Jan 17 09:39:55 2022 -0500 require the specified C and C++ versions commit f7669f991be211c6bbe9262753720ec80ff6f878 Author: Dan Smith Date: Mon Jan 17 09:24:45 2022 -0500 latest from coda-oss commit d8efd9f0a8c11314f1ab5d936338f82763f77f22 Author: J. Daniel Smith Date: Fri Jan 14 12:55:25 2022 -0500 be sure variables are referenced to avoid compiler warnings commit 7e343a22c4471680a0a0d7a719846b691e008594 Author: Dan Smith Date: Fri Jan 14 11:06:30 2022 -0500 rename Filesystem commit c5e4489e940af378e6f36ad4d18dede28786c80f Author: Dan Smith Date: Fri Jan 14 11:05:53 2022 -0500 rename Filesystem commit 8c1c253e2349e23c25859b3f30c4dbb2f5e8dfe0 Author: Dan Smith Date: Fri Jan 14 10:57:57 2022 -0500 add missing headers to coda_oss/optional.h commit f6c515959b6e0e6a381508737d974c846ecf03b8 Author: Dan Smith Date: Fri Jan 14 10:36:35 2022 -0500 get rid of compiler warning commit f5436d4b97fdd0a0093023971e6e6dde63d52847 Author: Dan Smith Date: Fri Jan 14 10:27:27 2022 -0500 latest from coda-oss commit 7d476063c8495fd507f99219b15c8750f41f5967 Merge: 3fc510cf db9f1d2a Author: Dan Smith Date: Fri Jan 14 10:10:56 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 3fc510cfc5c97ea243206a802353992515c991a0 Author: Dan Smith Date: Mon Jan 10 13:19:53 2022 -0500 fix TypeTraits.h commit e43ebb21bbf6a49dd37a4d0f4c22c2a6a155457d Author: Dan Smith Date: Mon Jan 10 10:19:01 2022 -0500 latest from coda-oss commit 105dd17f2e177ed8d2f0aa230d1ae3d7239d838a Author: Dan Smith Date: Mon Jan 10 09:59:56 2022 -0500 type_traits from coda-oss commit 1de69902f39eec9cc246e9592b3af825d5815185 Merge: 814dc912 d991a049 Author: Dan Smith Date: Mon Jan 10 09:58:09 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 814dc91268e20bfa12577091a0a7fc7f5801b503 Author: Dan Smith Date: Wed Jan 5 09:32:34 2022 -0500 latest from coda-oss commit fe3db61c0527fa6d0fc36d816b32fce8c5f8fb68 Merge: 6cccaaef fe89ce31 Author: Dan Smith Date: Wed Jan 5 09:31:08 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 6cccaaef59ee883c7483eb9481f483cd976bc31f Author: Dan Smith Date: Mon Jan 3 15:43:56 2022 -0500 str::strip commit 6ca278651bd2ccb5f1987217b99e0a911c125c56 Author: Dan Smith Date: Mon Jan 3 12:10:50 2022 -0500 explicitly =delete moves commit c6f4413b0a05d0cb0ad0178a04e49cc1829f69dd Author: Dan Smith Date: Mon Jan 3 11:44:30 2022 -0500 latest from coda-oss commit 8483731799f17ed2ecd6a4e8717704d9499cbea4 Merge: 063d7fc9 9ea44741 Author: Dan Smith Date: Mon Jan 3 11:42:58 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 063d7fc9c7e6dd5d48f2b9d3703f5e0b042aa79e Merge: 4ae95d0c d4ad4b8a Author: Dan Smith Date: Mon Dec 13 11:13:13 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4ae95d0c4ea5cfa775774809aab87eca651aad0b Author: Dan Smith Date: Mon Dec 13 11:01:01 2021 -0500 coda-oss release 2021-12-13 commit 50a0c4763ca97bdaf4ff8613a36ed7b2b9481276 Author: Dan Smith Date: Mon Dec 13 10:58:10 2021 -0500 Squashed commit of the following: commit c2354a768f0b6f9a5fa9cff064fd182d3438b353 Author: Dan Smith Date: Tue Dec 7 16:44:18 2021 -0500 Update TestCase.h commit 93727a2f06cea62a40dbab073b2d58ae139c022b Merge: 9c7eb207 7c96994a Author: Dan Smith Date: Tue Dec 7 16:41:19 2021 -0500 Merge branch 'master' into develop/jdsmith commit 9c7eb2076903edc507b3426f38086d1ce553e1ae Merge: 6863bdcb 1b22d00a Author: Dan Smith Date: Tue Dec 7 16:14:21 2021 -0500 Merge branch 'master' into develop/jdsmith commit 6863bdcb9d139aa8f98cc8f8b386bbfbbf835f03 Author: Dan Smith Date: Tue Dec 7 15:50:26 2021 -0500 Squashed commit of the following: commit 5e6e22b25c77c6b705aa7dda0258c7805b7a315a Author: Dan Smith Date: Tue Dec 7 15:49:44 2021 -0500 latest from coda-oss commit b91e345a03a6b06678ee4ff7157ef1595ee289e6 Author: Dan Smith Date: Tue Dec 7 10:56:41 2021 -0500 latest from coda-oss commit d2d1d543aa6e97f311d5b5bf52b2b8d7e7f1502b Author: Dan Smith Date: Mon Dec 6 16:39:26 2021 -0500 more "Throwable" updates from coda-oss commit 1d65ff9db316bbd0087ed4a0e15295692b0cca43 Author: Dan Smith Date: Mon Dec 6 16:06:35 2021 -0500 latest "Throwable" changes from coda-oss commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit bc3ebc4f5252721e63fb7b1c888f2d8955878436 Author: Dan Smith Date: Tue Dec 7 11:23:43 2021 -0500 build C unittests commit 81b1d3d55b8c0f5fff01fd23769c90838965eebe Author: Dan Smith Date: Tue Dec 7 11:03:44 2021 -0500 Update TestCase.h commit d39796cffc53db29fddbb4adfcbdade73a1ce4d7 Author: Dan Smith Date: Tue Dec 7 10:57:21 2021 -0500 Squashed commit of the following: commit b91e345a03a6b06678ee4ff7157ef1595ee289e6 Author: Dan Smith Date: Tue Dec 7 10:56:41 2021 -0500 latest from coda-oss commit d2d1d543aa6e97f311d5b5bf52b2b8d7e7f1502b Author: Dan Smith Date: Mon Dec 6 16:39:26 2021 -0500 more "Throwable" updates from coda-oss commit 1d65ff9db316bbd0087ed4a0e15295692b0cca43 Author: Dan Smith Date: Mon Dec 6 16:06:35 2021 -0500 latest "Throwable" changes from coda-oss commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit ebb8e5d0f230d3fda7ac9777bf3d6411ae969e10 Author: Dan Smith Date: Tue Dec 7 10:47:23 2021 -0500 one more Throwable11 commit d8e85171c1244b5a84e0366b0feeb0134de67fe0 Author: Dan Smith Date: Tue Dec 7 10:23:36 2021 -0500 catch Throwable11 too commit e18da07d2c25b5f513167245cd23f62e0be71d10 Author: Dan Smith Date: Mon Dec 6 16:40:47 2021 -0500 Squashed commit of the following: commit d2d1d543aa6e97f311d5b5bf52b2b8d7e7f1502b Author: Dan Smith Date: Mon Dec 6 16:39:26 2021 -0500 more "Throwable" updates from coda-oss commit 1d65ff9db316bbd0087ed4a0e15295692b0cca43 Author: Dan Smith Date: Mon Dec 6 16:06:35 2021 -0500 latest "Throwable" changes from coda-oss commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit 51b6d40df6d6540ef65d5a463db8ffe879f3c47a Author: Dan Smith Date: Mon Dec 6 16:07:10 2021 -0500 Squashed commit of the following: commit 1d65ff9db316bbd0087ed4a0e15295692b0cca43 Author: Dan Smith Date: Mon Dec 6 16:06:35 2021 -0500 latest "Throwable" changes from coda-oss commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit 805f02c5464d0a7c26b7fd4f464abfc88521bf95 Author: Dan Smith Date: Mon Dec 6 15:29:03 2021 -0500 Squashed commit of the following: commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit 048b8f99262375a8739f1ccc610e753270673856 Author: Dan Smith Date: Mon Dec 6 11:21:32 2021 -0500 MemoryDestructor::operator() is "noexcpet(false)" commit b0a0f67be360f05f69a491368851856d86314055 Author: Dan Smith Date: Mon Dec 6 10:42:02 2021 -0500 implicitConstruct() can complain NITF_PLUGIN_PATH, provide a way to turn that off commit 80af6b44d4bf16c281bcfa8f98a3765ab842967a Author: Dan Smith Date: Thu Dec 2 11:59:46 2021 -0500 Squashed commit of the following: commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit f6f01910438a14fdc2f738e055a442fc9faf82b7 Author: Dan Smith Date: Thu Dec 2 11:25:53 2021 -0500 Squashed commit of the following: commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit 2c2275ef6e7c178af890f371e562f93f5819ef40 Author: Dan Smith Date: Wed Dec 1 10:33:18 2021 -0500 Squashed commit of the following: commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit 4fa223eb9eff1171cbdd19edb11656a33bf81ee4 Merge: f6b78b44 2747740a Author: Dan Smith Date: Wed Dec 1 10:28:36 2021 -0500 Merge branch 'develop/jdsmith' of github.com:mdaus/nitro into develop/jdsmith commit 2747740a6f18ac2614a76455b5df5e2d36bff120 Author: Dan Smith Date: Tue Nov 16 17:05:00 2021 -0500 'noexcept' breaks existing code commit f6b78b44be8e7fed442ad514efe3a87b4532bef3 Merge: fc1ea1b5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:01:14 2021 -0500 Merge branch 'master' into develop/jdsmith commit fc1ea1b5f45cedcf06280e421ba017b64f6340c4 Merge: 49f9f76f 9461c626 Author: Dan Smith Date: Tue Nov 16 15:40:24 2021 -0500 Merge branch 'master' into develop/jdsmith commit 49f9f76fe276ccf43109a0c8cfa75544ebc45ec9 Author: Dan Smith Date: Tue Nov 16 10:52:39 2021 -0500 be sure a == b gives the same results as !(a != b) commit 11fb89801be2f3b1f00d2182eeeaf396fc9d3a42 Author: J. Daniel Smith Date: Mon Nov 15 20:22:52 2021 -0500 Squashed commit of the following: commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb9 2e8d7cfae Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa79 64dc4e118 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701d 888ae9293 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c1 28d95160e Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa5114 dfba5e291 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf977 a4a1fc4f8 Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdfa eef3c6ec8 Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f3 f5f1f8ce1 Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b7635 0db498f1e Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba3 9388d5cf2 Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b26 81278527b Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b061 c8186387f Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807a dc000a516 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f200464 7af555d63 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea52593 cb37a8cff Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e596027 1b6cfe099 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe390482 2229fbde0 Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b83 835da56f5 Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c0 7bb82996c Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bfc 98e6bcf5d Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168d ffd5aa858 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857ab 4ddaf23d8 Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d39 2a57741c2 Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4b 8806960a8 Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d39 a16f72b0c Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819dbd 273c39e86 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf579 298536f40 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e57 c1def5d0b Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec21 edb9317db Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b34 edb9317db Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09b 2748224ba Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8c 2748224ba Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b2 a2b3a12d9 Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b38 c68cd17dd Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d46965774 bb0634924 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f69 fa20f42ee Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb2 c80e163ee Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a84 dfad79efc Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f7420 e40a0b3f6 Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15b 7c5dbed7f Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576b 612a55889 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4b c14639765 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4bc 14517c04f Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e0 f62735eb5 Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f916 8705bbb63 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b252 62ec49119 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e1011253 62ec49119 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab20 b7f04aecb Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d28 f810f8f6e Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70f f810f8f6e Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95a f0a45b36d Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f6 1b6ae6adb Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee4 ee89c7d34 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad0136140 1615ce17b Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc4 0fbebcbdc Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b8 91cb40798 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c82540 280141628 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d6 bc379d3f7 Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3a f419dc538 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c7 2d73f0ee1 Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538b 0d6988eb1 Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c0959 0d6988eb1 Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c41 5be4b7e63 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1da 92b19f9c5 Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d9 c1ef1e933 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f16826 aa22bcb57 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f6 8a97faadd Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e4 09c201636 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30f 1f3991624 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c3736061 f17909e9a Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af283859 9a609577c Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f16 c83348fd3 Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a086 a49805f17 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit c7db8465c67aa4db9ae5a2c9367743608f504002 Author: Dan Smith Date: Mon Nov 15 17:50:58 2021 -0500 Squashed commit of the following: commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit c13fc831aee807bfda9bc73f032e2e5f305d8edf Merge: 3ae221bd 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 17:50:46 2021 -0500 Merge branch 'master' into develop/jdsmith commit 3ae221bde34db36ed927a1f5282ab6dc4ec9ca99 Author: Dan Smith Date: Tue Nov 9 17:05:23 2021 -0500 tweaks from "main" commit edb5d2ce24151e63bf477a20a3942d1bceeeb42c Merge: 24201006 e868e374 Author: Dan Smith Date: Tue Nov 9 16:47:21 2021 -0500 Merge branch 'master' into develop/jdsmith commit 24201006a823059f8d15dd17c8406548c3c5bacc Author: Dan Smith Date: Tue Nov 9 15:56:51 2021 -0500 Squashed commit of the following: commit 37cd476058a5368d1ffb77e44b4c12430cb07d60 Author: Dan Smith Date: Tue Nov 9 14:29:37 2021 -0500 fix "noexcept" compiler error commit a77c8bf23f0cdec1b117480ed3e15ee2f97ad7fe Author: Dan Smith Date: Tue Nov 9 14:08:08 2021 -0500 remove (or #pragma-away) more compiler warnings commit 658ea41d14312ea1ae4064e46e3ca13b44c331b8 Author: Dan Smith Date: Tue Nov 9 14:07:16 2021 -0500 Squashed commit of the following: commit b04638d2863fc1c1e5ea321811707d8911071f2c Author: Dan Smith Date: Tue Nov 9 13:23:38 2021 -0500 #pragma away some compiler warnings commit e4679d4d2f7a1df92d0427c7d159e74113fd0720 Merge: 1bda4296 65b4df02 Author: Dan Smith Date: Tue Nov 9 12:55:40 2021 -0500 Merge branch 'master' into develop/jdsmith commit 1bda429694357d27224707d1f84c403d4b23805c Author: Dan Smith Date: Tue Nov 9 12:20:47 2021 -0500 fix errors found with building with C++20 commit 1a3285ab5664989f54fe2de2786b5779263017de Author: Dan Smith Date: Mon Nov 8 15:20:20 2021 -0500 build Test++ w/VS2022 commit 23b0fe1b4b5d5ca1c7b1b32811ea3406dd69bfc7 Author: Dan Smith Date: Mon Nov 8 15:08:50 2021 -0500 build Test project with VS2022 commit 319e7aff066a7aa02a1ed6662a876362b8bc92a8 Author: Dan Smith Date: Mon Nov 8 14:37:24 2021 -0500 VS2022 commit 565f72b69f0036a61e14141a87bcfc434ff2e649 Merge: 59c3e5b3 64dc4e11 Author: Dan Smith Date: Mon Nov 8 11:56:22 2021 -0500 Merge branch 'master' into develop/jdsmith commit 59c3e5b3ddd8cb0422a65684f1aac711ad80ac3d Author: Dan Smith Date: Mon Oct 18 09:26:59 2021 -0400 tweaks from "main" to build with C++17 commit d09f5ed46a12050a5799a2db3a12ff935ec12ef0 Merge: c08dbd52 dfba5e29 Author: Dan Smith Date: Mon Oct 18 09:11:53 2021 -0400 Merge branch 'master' into develop/jdsmith commit c08dbd528725669117ad8c4b30b123ad05e1249b Author: Dan Smith Date: Fri Oct 15 12:02:23 2021 -0400 Squashed commit of the following: commit 0c3a4a65e8db1cd1088de3ede808d0fedfda5ca3 Merge: 2600cedb 3c7653c3 Author: Dan Smith Date: Fri Oct 15 12:01:54 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 2600cedb4c820d8716ce4f87dcdaa15ec5a12295 Author: Dan Smith Date: Fri Oct 15 12:01:35 2021 -0400 braced-initialization causes CodeQL to fail? commit 45eb7bf729eeca30842e05fdf09db1617d0b384d Merge: 29854176 e17d918d Author: Dan Smith Date: Fri Oct 15 11:29:59 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 29854176ab1e941e0ebb588dcc1e8d1f7d916929 Author: Dan Smith Date: Tue Oct 12 15:29:33 2021 -0400 load 8-bit AMP files commit 80e8167fb2df6712620d99e5faba0311c2691cd3 Author: Dan Smith Date: Tue Oct 12 14:53:47 2021 -0400 8-bit AMP/PHS sample files commit d15754270e96e98ec59e58c73ca218d595a03831 Merge: a2ed1398 b7867398 Author: Dan Smith Date: Tue Oct 12 14:48:41 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit a2ed1398e1b4d692696f6bbc69b9bbf58a390ff8 Author: Dan Smith Date: Mon Oct 11 16:11:16 2021 -0400 need operator<< for unit-tests commit 668cd2d52a7bd1a9d3e877e684b2a530d12f90da Author: Dan Smith Date: Mon Oct 11 15:51:24 2021 -0400 more use of enums commit 67e933b5e726ec0898b106bc428511314b02cb31 Author: Dan Smith Date: Mon Oct 11 15:38:10 2021 -0400 use enums in test_image_loading commit 432d2890d7ef6efeb9beeb08332c9e6b4b4e2cd6 Author: Dan Smith Date: Mon Oct 11 11:15:53 2021 -0400 tweaks from SIX commit e7d3e70d643ca1c781ea355b7acd63edf3696eed Author: Dan Smith Date: Mon Oct 11 10:24:13 2021 -0400 make enums more descriptive rather than following cryptic C style commit 0764c55b75236c616e4d56d39f4da3166c444dcf Author: Dan Smith Date: Mon Oct 11 10:23:08 2021 -0400 nitro_image_.c -> nitro_image_.c_ commit 6f88781ea7ea187ee91e0d06c891db4a7ac86479 Author: Dan Smith Date: Thu Oct 7 16:33:48 2021 -0400 Squashed commit of the following: commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 5ee2381e91ef8d8294238199e0c229e946bc809a Merge: 052e5ced 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:17 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 052e5cedd98f59b20ab1b2c8c3b3db177477cfcb Author: Dan Smith Date: Thu Oct 7 15:26:28 2021 -0400 fix broken build with nitro_image.c commit 308be858f0d05e007b419cd048028085ce2ace69 Author: Dan Smith Date: Thu Oct 7 15:03:47 2021 -0400 enums for IREP and BlockingMode commit c880f175fb6da6603751312ab28b42b48d995b95 Author: Dan Smith Date: Thu Oct 7 14:14:47 2021 -0400 add nitf::PixelType to represent #defines in ImageIO.h commit 888c661a5c151a65d4ea18efd2974acefad483a9 Author: Dan Smith Date: Thu Oct 7 13:49:19 2021 -0400 Squashed commit of the following: commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 7d482d2f9c09b46cc5292880c2d44b0dddaf2b65 Merge: 24fa925f 3c7653c3 Author: Dan Smith Date: Fri Oct 15 12:02:14 2021 -0400 Merge branch 'master' into develop/jdsmith commit 24fa925f2468ba6f3015e0818d7c5cbe90ed89e7 Merge: 4a537c0f e17d918d Author: Dan Smith Date: Fri Oct 15 11:29:51 2021 -0400 Merge branch 'master' into develop/jdsmith commit 4a537c0f2da01f1fb7a048ab4e161afb5e1fe4c1 Author: Dan Smith Date: Fri Oct 15 11:25:29 2021 -0400 Build as StaticLibaray commit f686b20b64b5f256939534ecc2ac258fb35d8f38 Author: Dan Smith Date: Fri Oct 15 11:07:38 2021 -0400 need more work to build as DLL commit 970aabefca96d9112cf1d3051f0ec3ff545bd7cf Author: Dan Smith Date: Fri Oct 15 11:07:26 2021 -0400 "noexcept" commit e90546578d9d40e4eb2c0c37c0e02e2282c7cd53 Author: Dan Smith Date: Fri Oct 15 10:34:42 2021 -0400 fix Windows build commit 0364f51a1a38835bb980cc9102ba3c8d31d4d14b Author: Dan Smith Date: Fri Oct 15 10:07:35 2021 -0400 build as a DLL in Visual Studio commit 95ab27ca3676b7749fbe4e726ffbc0c80c39ae67 Author: Dan Smith Date: Fri Oct 15 10:07:20 2021 -0400 unit-tests use ENGRDA TRE commit ec277ffd0749ba2392accbbddabcf1efdcdb358f Author: Dan Smith Date: Fri Oct 15 09:52:57 2021 -0400 =default should be in CPP file because 'Impl" isn't defined in .h commit 833ab37d5997553a5dcb621c6b393e6cfc26c897 Author: Dan Smith Date: Fri Oct 15 08:34:40 2021 -0400 Squashed commit of the following: commit 29854176ab1e941e0ebb588dcc1e8d1f7d916929 Author: Dan Smith Date: Tue Oct 12 15:29:33 2021 -0400 load 8-bit AMP files commit 80e8167fb2df6712620d99e5faba0311c2691cd3 Author: Dan Smith Date: Tue Oct 12 14:53:47 2021 -0400 8-bit AMP/PHS sample files commit d15754270e96e98ec59e58c73ca218d595a03831 Merge: a2ed1398 b7867398 Author: Dan Smith Date: Tue Oct 12 14:48:41 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit a2ed1398e1b4d692696f6bbc69b9bbf58a390ff8 Author: Dan Smith Date: Mon Oct 11 16:11:16 2021 -0400 need operator<< for unit-tests commit 668cd2d52a7bd1a9d3e877e684b2a530d12f90da Author: Dan Smith Date: Mon Oct 11 15:51:24 2021 -0400 more use of enums commit 67e933b5e726ec0898b106bc428511314b02cb31 Author: Dan Smith Date: Mon Oct 11 15:38:10 2021 -0400 use enums in test_image_loading commit 432d2890d7ef6efeb9beeb08332c9e6b4b4e2cd6 Author: Dan Smith Date: Mon Oct 11 11:15:53 2021 -0400 tweaks from SIX commit e7d3e70d643ca1c781ea355b7acd63edf3696eed Author: Dan Smith Date: Mon Oct 11 10:24:13 2021 -0400 make enums more descriptive rather than following cryptic C style commit 0764c55b75236c616e4d56d39f4da3166c444dcf Author: Dan Smith Date: Mon Oct 11 10:23:08 2021 -0400 nitro_image_.c -> nitro_image_.c_ commit 6f88781ea7ea187ee91e0d06c891db4a7ac86479 Author: Dan Smith Date: Thu Oct 7 16:33:48 2021 -0400 Squashed commit of the following: commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 5ee2381e91ef8d8294238199e0c229e946bc809a Merge: 052e5ced 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:17 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 052e5cedd98f59b20ab1b2c8c3b3db177477cfcb Author: Dan Smith Date: Thu Oct 7 15:26:28 2021 -0400 fix broken build with nitro_image.c commit 308be858f0d05e007b419cd048028085ce2ace69 Author: Dan Smith Date: Thu Oct 7 15:03:47 2021 -0400 enums for IREP and BlockingMode commit c880f175fb6da6603751312ab28b42b48d995b95 Author: Dan Smith Date: Thu Oct 7 14:14:47 2021 -0400 add nitf::PixelType to represent #defines in ImageIO.h commit 888c661a5c151a65d4ea18efd2974acefad483a9 Author: Dan Smith Date: Thu Oct 7 13:49:19 2021 -0400 Squashed commit of the following: commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit cea2b5b66c5852b3e5598200e9a70a627b1d1bbf Merge: 9d0aa054 b7867398 Author: Dan Smith Date: Fri Oct 15 08:34:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit 793675d659fa4835b2818fa4191e6b8e8d29fa57 Merge: 210f5fa5 65b4df02 Author: Dan Smith Date: Tue Nov 9 14:06:17 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 210f5fa53a6d246671dd8b890dc429c247c0a238 Author: Dan Smith Date: Wed Aug 25 12:17:26 2021 -0400 remove warning about "unused parameter" commit 8713d386a56db548c4475c9e0050881b3674022f Author: Dan Smith Date: Wed Aug 25 12:09:30 2021 -0400 Squashed commit of the following: commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c414a329aaf6f0247ec481739377a199550908cc Merge: 51b0a83a 81278527 Author: Dan Smith Date: Wed Aug 25 12:09:16 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 51b0a83a29edaf7374aea8263c113edc214ba429 Author: Dan Smith Date: Wed Aug 25 11:08:47 2021 -0400 remove G++ compiler warning commit 9d2c4192777599b449d4fd793fe26f401b61c0dc Merge: ed66875f 3ebffd87 Author: Dan Smith Date: Wed Aug 25 11:02:13 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit ed66875f577253218c3c6eb05ac342e07d6a34d9 Author: Dan Smith Date: Wed Aug 25 10:58:13 2021 -0400 reduce GCC compiler warnings commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit b04638d2863fc1c1e5ea321811707d8911071f2c Author: Dan Smith Date: Tue Nov 9 13:23:38 2021 -0500 #pragma away some compiler warnings commit e4679d4d2f7a1df92d0427c7d159e74113fd0720 Merge: 1bda4296 65b4df02 Author: Dan Smith Date: Tue Nov 9 12:55:40 2021 -0500 Merge branch 'master' into develop/jdsmith commit 1bda429694357d27224707d1f84c403d4b23805c Author: Dan Smith Date: Tue Nov 9 12:20:47 2021 -0500 fix errors found with building with C++20 commit 1a3285ab5664989f54fe2de2786b5779263017de Author: Dan Smith Date: Mon Nov 8 15:20:20 2021 -0500 build Test++ w/VS2022 commit 23b0fe1b4b5d5ca1c7b1b32811ea3406dd69bfc7 Author: Dan Smith Date: Mon Nov 8 15:08:50 2021 -0500 build Test project with VS2022 commit 319e7aff066a7aa02a1ed6662a876362b8bc92a8 Author: Dan Smith Date: Mon Nov 8 14:37:24 2021 -0500 VS2022 commit 565f72b69f0036a61e14141a87bcfc434ff2e649 Merge: 59c3e5b3 64dc4e11 Author: Dan Smith Date: Mon Nov 8 11:56:22 2021 -0500 Merge branch 'master' into develop/jdsmith commit 59c3e5b3ddd8cb0422a65684f1aac711ad80ac3d Author: Dan Smith Date: Mon Oct 18 09:26:59 2021 -0400 tweaks from "main" to build with C++17 commit d09f5ed46a12050a5799a2db3a12ff935ec12ef0 Merge: c08dbd52 dfba5e29 Author: Dan Smith Date: Mon Oct 18 09:11:53 2021 -0400 Merge branch 'master' into develop/jdsmith commit c08dbd528725669117ad8c4b30b123ad05e1249b Author: Dan Smith Date: Fri Oct 15 12:02:23 2021 -0400 Squashed commit of the following: commit 0c3a4a65e8db1cd1088de3ede808d0fedfda5ca3 Merge: 2600cedb 3c7653c3 Author: Dan Smith Date: Fri Oct 15 12:01:54 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 2600cedb4c820d8716ce4f87dcdaa15ec5a12295 Author: Dan Smith Date: Fri Oct 15 12:01:35 2021 -0400 braced-initialization causes CodeQL to fail? commit 45eb7bf729eeca30842e05fdf09db1617d0b384d Merge: 29854176 e17d918d Author: Dan Smith Date: Fri Oct 15 11:29:59 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 29854176ab1e941e0ebb588dcc1e8d1f7d916929 Author: Dan Smith Date: Tue Oct 12 15:29:33 2021 -0400 load 8-bit AMP files commit 80e8167fb2df6712620d99e5faba0311c2691cd3 Author: Dan Smith Date: Tue Oct 12 14:53:47 2021 -0400 8-bit AMP/PHS sample files commit d15754270e96e98ec59e58c73ca218d595a03831 Merge: a2ed1398 b7867398 Author: Dan Smith Date: Tue Oct 12 14:48:41 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit a2ed1398e1b4d692696f6bbc69b9bbf58a390ff8 Author: Dan Smith Date: Mon Oct 11 16:11:16 2021 -0400 need operator<< for unit-tests commit 668cd2d52a7bd1a9d3e877e684b2a530d12f90da Author: Dan Smith Date: Mon Oct 11 15:51:24 2021 -0400 more use of enums commit 67e933b5e726ec0898b106bc428511314b02cb31 Author: Dan Smith Date: Mon Oct 11 15:38:10 2021 -0400 use enums in test_image_loading commit 432d2890d7ef6efeb9beeb08332c9e6b4b4e2cd6 Author: Dan Smith Date: Mon Oct 11 11:15:53 2021 -0400 tweaks from SIX commit e7d3e70d643ca1c781ea355b7acd63edf3696eed Author: Dan Smith Date: Mon Oct 11 10:24:13 2021 -0400 make enums more descriptive rather than following cryptic C style commit 0764c55b75236c616e4d56d39f4da3166c444dcf Author: Dan Smith Date: Mon Oct 11 10:23:08 2021 -0400 nitro_image_.c -> nitro_image_.c_ commit 6f88781ea7ea187ee91e0d06c891db4a7ac86479 Author: Dan Smith Date: Thu Oct 7 16:33:48 2021 -0400 Squashed commit of the following: commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 5ee2381e91ef8d8294238199e0c229e946bc809a Merge: 052e5ced 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:17 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 052e5cedd98f59b20ab1b2c8c3b3db177477cfcb Author: Dan Smith Date: Thu Oct 7 15:26:28 2021 -0400 fix broken build with nitro_image.c commit 308be858f0d05e007b419cd048028085ce2ace69 Author: Dan Smith Date: Thu Oct 7 15:03:47 2021 -0400 enums for IREP and BlockingMode commit c880f175fb6da6603751312ab28b42b48d995b95 Author: Dan Smith Date: Thu Oct 7 14:14:47 2021 -0400 add nitf::PixelType to represent #defines in ImageIO.h commit 888c661a5c151a65d4ea18efd2974acefad483a9 Author: Dan Smith Date: Thu Oct 7 13:49:19 2021 -0400 Squashed commit of the following: commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 7d482d2f9c09b46cc5292880c2d44b0dddaf2b65 Merge: 24fa925f 3c7653c3 Author: Dan Smith Date: Fri Oct 15 12:02:14 2021 -0400 Merge branch 'master' into develop/jdsmith commit 24fa925f2468ba6f3015e0818d7c5cbe90ed89e7 Merge: 4a537c0f e17d918d Author: Dan Smith Date: Fri Oct 15 11:29:51 2021 -0400 Merge branch 'master' into develop/jdsmith commit 4a537c0f2da01f1fb7a048ab4e161afb5e1fe4c1 Author: Dan Smith Date: Fri Oct 15 11:25:29 2021 -0400 Build as StaticLibaray commit f686b20b64b5f256939534ecc2ac258fb35d8f38 Author: Dan Smith Date: Fri Oct 15 11:07:38 2021 -0400 need more work to build as DLL commit 970aabefca96d9112cf1d3051f0ec3ff545bd7cf Author: Dan Smith Date: Fri Oct 15 11:07:26 2021 -0400 "noexcept" commit e90546578d9d40e4eb2c0c37c0e02e2282c7cd53 Author: Dan Smith Date: Fri Oct 15 10:34:42 2021 -0400 fix Windows build commit 0364f51a1a38835bb980cc9102ba3c8d31d4d14b Author: Dan Smith Date: Fri Oct 15 10:07:35 2021 -0400 build as a DLL in Visual Studio commit 95ab27ca3676b7749fbe4e726ffbc0c80c39ae67 Author: Dan Smith Date: Fri Oct 15 10:07:20 2021 -0400 unit-tests use ENGRDA TRE commit ec277ffd0749ba2392accbbddabcf1efdcdb358f Author: Dan Smith Date: Fri Oct 15 09:52:57 2021 -0400 =default should be in CPP file because 'Impl" isn't defined in .h commit 833ab37d5997553a5dcb621c6b393e6cfc26c897 Author: Dan Smith Date: Fri Oct 15 08:34:40 2021 -0400 Squashed commit of the following: commit 29854176ab1e941e0ebb588dcc1e8d1f7d916929 Author: Dan Smith Date: Tue Oct 12 15:29:33 2021 -0400 load 8-bit AMP files commit 80e8167fb2df6712620d99e5faba0311c2691cd3 Author: Dan Smith Date: Tue Oct 12 14:53:47 2021 -0400 8-bit AMP/PHS sample files commit d15754270e96e98ec59e58c73ca218d595a03831 Merge: a2ed1398 b7867398 Author: Dan Smith Date: Tue Oct 12 14:48:41 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit a2ed1398e1b4d692696f6bbc69b9bbf58a390ff8 Author: Dan Smith Date: Mon Oct 11 16:11:16 2021 -0400 need operator<< for unit-tests commit 668cd2d52a7bd1a9d3e877e684b2a530d12f90da Author: Dan Smith Date: Mon Oct 11 15:51:24 2021 -0400 more use of enums commit 67e933b5e726ec0898b106bc428511314b02cb31 Author: Dan Smith Date: Mon Oct 11 15:38:10 2021 -0400 use enums in test_image_loading commit 432d2890d7ef6efeb9beeb08332c9e6b4b4e2cd6 Author: Dan Smith Date: Mon Oct 11 11:15:53 2021 -0400 tweaks from SIX commit e7d3e70d643ca1c781ea355b7acd63edf3696eed Author: Dan Smith Date: Mon Oct 11 10:24:13 2021 -0400 make enums more descriptive rather than following cryptic C style commit 0764c55b75236c616e4d56d39f4da3166c444dcf Author: Dan Smith Date: Mon Oct 11 10:23:08 2021 -0400 nitro_image_.c -> nitro_image_.c_ commit 6f88781ea7ea187ee91e0d06c891db4a7ac86479 Author: Dan Smith Date: Thu Oct 7 16:33:48 2021 -0400 Squashed commit of the following: commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 5ee2381e91ef8d8294238199e0c229e946bc809a Merge: 052e5ced 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:17 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 052e5cedd98f59b20ab1b2c8c3b3db177477cfcb Author: Dan Smith Date: Thu Oct 7 15:26:28 2021 -0400 fix broken build with nitro_image.c commit 308be858f0d05e007b419cd048028085ce2ace69 Author: Dan Smith Date: Thu Oct 7 15:03:47 2021 -0400 enums for IREP and BlockingMode commit c880f175fb6da6603751312ab28b42b48d995b95 Author: Dan Smith Date: Thu Oct 7 14:14:47 2021 -0400 add nitf::PixelType to represent #defines in ImageIO.h commit 888c661a5c151a65d4ea18efd2974acefad483a9 Author: Dan Smith Date: Thu Oct 7 13:49:19 2021 -0400 Squashed commit of the following: commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit cea2b5b66c5852b3e5598200e9a70a627b1d1bbf Merge: 9d0aa054 b7867398 Author: Dan Smith Date: Fri Oct 15 08:34:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit 3f04116aaa473549bddf237ce27252b241612bbe Merge: 5e6e22b2 7c96994a Author: Dan Smith Date: Mon Dec 13 10:57:49 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 5e6e22b25c77c6b705aa7dda0258c7805b7a315a Author: Dan Smith Date: Tue Dec 7 15:49:44 2021 -0500 latest from coda-oss commit b91e345a03a6b06678ee4ff7157ef1595ee289e6 Author: Dan Smith Date: Tue Dec 7 10:56:41 2021 -0500 latest from coda-oss commit d2d1d543aa6e97f311d5b5bf52b2b8d7e7f1502b Author: Dan Smith Date: Mon Dec 6 16:39:26 2021 -0500 more "Throwable" updates from coda-oss commit 1d65ff9db316bbd0087ed4a0e15295692b0cca43 Author: Dan Smith Date: Mon Dec 6 16:06:35 2021 -0500 latest "Throwable" changes from coda-oss commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 2d8428f90ac4727ff5ed81178bac81ee47fc192f Merge: 37cd4760 8a8ea90b Author: Dan Smith Date: Wed Jan 26 15:08:05 2022 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 37cd476058a5368d1ffb77e44b4c12430cb07d60 Author: Dan Smith Date: Tue Nov 9 14:29:37 2021 -0500 fix "noexcept" compiler error commit a77c8bf23f0cdec1b117480ed3e15ee2f97ad7fe Author: Dan Smith Date: Tue Nov 9 14:08:08 2021 -0500 remove (or #pragma-away) more compiler warnings commit 658ea41d14312ea1ae4064e46e3ca13b44c331b8 Author: Dan Smith Date: Tue Nov 9 14:07:16 2021 -0500 Squashed commit of the following: commit b04638d2863fc1c1e5ea321811707d8911071f2c Author: Dan Smith Date: Tue Nov 9 13:23:38 2021 -0500 #pragma away some compiler warnings commit e4679d4d2f7a1df92d0427c7d159e74113fd0720 Merge: 1bda4296 65b4df02 Author: Dan Smith Date: Tue Nov 9 12:55:40 2021 -0500 Merge branch 'master' into develop/jdsmith commit 1bda429694357d27224707d1f84c403d4b23805c Author: Dan Smith Date: Tue Nov 9 12:20:47 2021 -0500 fix errors found with building with C++20 commit 1a3285ab5664989f54fe2de2786b5779263017de Author: Dan Smith Date: Mon Nov 8 15:20:20 2021 -0500 build Test++ w/VS2022 commit 23b0fe1b4b5d5ca1c7b1b32811ea3406dd69bfc7 Author: Dan Smith Date: Mon Nov 8 15:08:50 2021 -0500 build Test project with VS2022 commit 319e7aff066a7aa02a1ed6662a876362b8bc92a8 Author: Dan Smith Date: Mon Nov 8 14:37:24 2021 -0500 VS2022 commit 565f72b69f0036a61e14141a87bcfc434ff2e649 Merge: 59c3e5b3 64dc4e11 Author: Dan Smith Date: Mon Nov 8 11:56:22 2021 -0500 Merge branch 'master' into develop/jdsmith commit 59c3e5b3ddd8cb0422a65684f1aac711ad80ac3d Author: Dan Smith Date: Mon Oct 18 09:26:59 2021 -0400 tweaks from "main" to build with C++17 commit d09f5ed46a12050a5799a2db3a12ff935ec12ef0 Merge: c08dbd52 dfba5e29 Author: Dan Smith Date: Mon Oct 18 09:11:53 2021 -0400 Merge branch 'master' into develop/jdsmith commit c08dbd528725669117ad8c4b30b123ad05e1249b Author: Dan Smith Date: Fri Oct 15 12:02:23 2021 -0400 Squashed commit of the following: commit 0c3a4a65e8db1cd1088de3ede808d0fedfda5ca3 Merge: 2600cedb 3c7653c3 Author: Dan Smith Date: Fri Oct 15 12:01:54 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 2600cedb4c820d8716ce4f87dcdaa15ec5a12295 Author: Dan Smith Date: Fri Oct 15 12:01:35 2021 -0400 braced-initialization causes CodeQL to fail? commit 45eb7bf729eeca30842e05fdf09db1617d0b384d Merge: 29854176 e17d918d Author: Dan Smith Date: Fri Oct 15 11:29:59 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 29854176ab1e941e0ebb588dcc1e8d1f7d916929 Author: Dan Smith Date: Tue Oct 12 15:29:33 2021 -0400 load 8-bit AMP files commit 80e8167fb2df6712620d99e5faba0311c2691cd3 Author: Dan Smith Date: Tue Oct 12 14:53:47 2021 -0400 8-bit AMP/PHS sample files commit d15754270e96e98ec59e58c73ca218d595a03831 Merge: a2ed1398 b7867398 Author: Dan Smith Date: Tue Oct 12 14:48:41 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit a2ed1398e1b4d692696f6bbc69b9bbf58a390ff8 Author: Dan Smith Date: Mon Oct 11 16:11:16 2021 -0400 need operator<< for unit-tests commit 668cd2d52a7bd1a9d3e877e684b2a530d12f90da Author: Dan Smith Date: Mon Oct 11 15:51:24 2021 -0400 more use of enums commit 67e933b5e726ec0898b106bc428511314b02cb31 Author: Dan Smith Date: Mon Oct 11 15:38:10 2021 -0400 use enums in test_image_loading commit 432d2890d7ef6efeb9beeb08332c9e6b4b4e2cd6 Author: Dan Smith Date: Mon Oct 11 11:15:53 2021 -0400 tweaks from SIX commit e7d3e70d643ca1c781ea355b7acd63edf3696eed Author: Dan Smith Date: Mon Oct 11 10:24:13 2021 -0400 make enums more descriptive rather than following cryptic C style commit 0764c55b75236c616e4d56d39f4da3166c444dcf Author: Dan Smith Date: Mon Oct 11 10:23:08 2021 -0400 nitro_image_.c -> nitro_image_.c_ commit 6f88781ea7ea187ee91e0d06c891db4a7ac86479 Author: Dan Smith Date: Thu Oct 7 16:33:48 2021 -0400 Squashed commit of the following: commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 5ee2381e91ef8d8294238199e0c229e946bc809a Merge: 052e5ced 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:17 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 052e5cedd98f59b20ab1b2c8c3b3db177477cfcb Author: Dan Smith Date: Thu Oct 7 15:26:28 2021 -0400 fix broken build with nitro_image.c commit 308be858f0d05e007b419cd048028085ce2ace69 Author: Dan Smith Date: Thu Oct 7 15:03:47 2021 -0400 enums for IREP and BlockingMode commit c880f175fb6da6603751312ab28b42b48d995b95 Author: Dan Smith Date: Thu Oct 7 14:14:47 2021 -0400 add nitf::PixelType to represent #defines in ImageIO.h commit 888c661a5c151a65d4ea18efd2974acefad483a9 Author: Dan Smith Date: Thu Oct 7 13:49:19 2021 -0400 Squashed commit of the following: commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 7d482d2f9c09b46cc5292880c2d44b0dddaf2b65 Merge: 24fa925f 3c7653c3 Author: Dan Smith Date: Fri Oct 15 12:02:14 2021 -0400 Merge branch 'master' into develop/jdsmith commit 24fa925f2468ba6f3015e0818d7c5cbe90ed89e7 Merge: 4a537c0f e17d918d Author: Dan Smith Date: Fri Oct 15 11:29:51 2021 -0400 Merge branch 'master' into develop/jdsmith commit 4a537c0f2da01f1fb7a048ab4e161afb5e1fe4c1 Author: Dan Smith Date: Fri Oct 15 11:25:29 2021 -0400 Build as StaticLibaray commit f686b20b64b5f256939534ecc2ac258fb35d8f38 Author: Dan Smith Date: Fri Oct 15 11:07:38 2021 -0400 need more work to build as DLL commit 970aabefca96d9112cf1d3051f0ec3ff545bd7cf Author: Dan Smith Date: Fri Oct 15 11:07:26 2021 -0400 "noexcept" commit e90546578d9d40e4eb2c0c37c0e02e2282c7cd53 Author: Dan Smith Date: Fri Oct 15 10:34:42 2021 -0400 fix Windows build commit 0364f51a1a38835bb980cc9102ba3c8d31d4d14b Author: Dan Smith Date: Fri Oct 15 10:07:35 2021 -0400 build as a DLL in Visual Studio commit 95ab27ca3676b7749fbe4e726ffbc0c80c39ae67 Author: Dan Smith Date: Fri Oct 15 10:07:20 2021 -0400 unit-tests use ENGRDA TRE commit ec277ffd0749ba2392accbbddabcf1efdcdb358f Author: Dan Smith Date: Fri Oct 15 09:52:57 2021 -0400 =default should be in CPP file because 'Impl" isn't defined in .h commit 833ab37d5997553a5dcb621c6b393e6cfc26c897 Author: Dan Smith Date: Fri Oct 15 08:34:40 2021 -0400 Squashed commit of the following: commit 29854176ab1e941e0ebb588dcc1e8d1f7d916929 Author: Dan Smith Date: Tue Oct 12 15:29:33 2021 -0400 load 8-bit AMP files commit 80e8167fb2df6712620d99e5faba0311c2691cd3 Author: Dan Smith Date: Tue Oct 12 14:53:47 2021 -0400 8-bit AMP/PHS sample files commit d15754270e96e98ec59e58c73ca218d595a03831 Merge: a2ed1398 b7867398 Author: Dan Smith Date: Tue Oct 12 14:48:41 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit a2ed1398e1b4d692696f6bbc69b9bbf58a390ff8 Author: Dan Smith Date: Mon Oct 11 16:11:16 2021 -0400 need operator<< for unit-tests commit 668cd2d52a7bd1a9d3e877e684b2a530d12f90da Author: Dan Smith Date: Mon Oct 11 15:51:24 2021 -0400 more use of enums commit 67e933b5e726ec0898b106bc428511314b02cb31 Author: Dan Smith Date: Mon Oct 11 15:38:10 2021 -0400 use enums in test_image_loading commit 432d2890d7ef6efeb9beeb08332c9e6b4b4e2cd6 Author: Dan Smith Date: Mon Oct 11 11:15:53 2021 -0400 tweaks from SIX commit e7d3e70d643ca1c781ea355b7acd63edf3696eed Author: Dan Smith Date: Mon Oct 11 10:24:13 2021 -0400 make enums more descriptive rather than following cryptic C style commit 0764c55b75236c616e4d56d39f4da3166c444dcf Author: Dan Smith Date: Mon Oct 11 10:23:08 2021 -0400 nitro_image_.c -> nitro_image_.c_ commit 6f88781ea7ea187ee91e0d06c891db4a7ac86479 Author: Dan Smith Date: Thu Oct 7 16:33:48 2021 -0400 Squashed commit of the following: commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 5ee2381e91ef8d8294238199e0c229e946bc809a Merge: 052e5ced 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:17 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 052e5cedd98f59b20ab1b2c8c3b3db177477cfcb Author: Dan Smith Date: Thu Oct 7 15:26:28 2021 -0400 fix broken build with nitro_image.c commit 308be858f0d05e007b419cd048028085ce2ace69 Author: Dan Smith Date: Thu Oct 7 15:03:47 2021 -0400 enums for IREP and BlockingMode commit c880f175fb6da6603751312ab28b42b48d995b95 Author: Dan Smith Date: Thu Oct 7 14:14:47 2021 -0400 add nitf::PixelType to represent #defines in ImageIO.h commit 888c661a5c151a65d4ea18efd2974acefad483a9 Author: Dan Smith Date: Thu Oct 7 13:49:19 2021 -0400 Squashed commit of the following: commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit cea2b5b66c5852b3e5598200e9a70a627b1d1bbf Merge: 9d0aa054 b7867398 Author: Dan Smith Date: Fri Oct 15 08:34:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit 793675d659fa4835b2818fa4191e6b8e8d29fa57 Merge: 210f5fa5 65b4df02 Author: Dan Smith Date: Tue Nov 9 14:06:17 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 210f5fa53a6d246671dd8b890dc429c247c0a238 Author: Dan Smith Date: Wed Aug 25 12:17:26 2021 -0400 remove warning about "unused parameter" commit 8713d386a56db548c4475c9e0050881b3674022f Author: Dan Smith Date: Wed Aug 25 12:09:30 2021 -0400 Squashed commit of the following: commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c414a329aaf6f0247ec481739377a199550908cc Merge: 51b0a83a 81278527 Author: Dan Smith Date: Wed Aug 25 12:09:16 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 51b0a83a29edaf7374aea8263c113edc214ba429 Author: Dan Smith Date: Wed Aug 25 11:08:47 2021 -0400 remove G++ compiler warning commit 9d2c4192777599b449d4fd793fe26f401b61c0dc Merge: ed66875f 3ebffd87 Author: Dan Smith Date: Wed Aug 25 11:02:13 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit ed66875f577253218c3c6eb05ac342e07d6a34d9 Author: Dan Smith Date: Wed Aug 25 10:58:13 2021 -0400 reduce GCC compiler warnings commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit d6c2303c4efa301ac3c9d526337e005265f2e8d3 Author: Dan Smith Date: Wed Feb 2 12:27:58 2022 -0500 remove our feature-test macros as they're not used commit f5246c2e847b6738dd104107cd39f8c94da549ae Author: Dan Smith Date: Wed Feb 2 12:10:02 2022 -0500 latest from coda-oss commit 60b8649c29b7f258f1fd73172ee5748169caa611 Author: Dan Smith Date: Wed Jan 26 16:05:44 2022 -0500 coda-oss updates to use "bpstd" commit 0e65cc2efcf37edb62e735a5b2c95b17d9654fd4 Merge: ec0434d7 8a8ea90b Author: Dan Smith Date: Wed Jan 26 14:47:43 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit ec0434d71cad7f8043ec5f8d07682315a96d3058 Merge: ed1b011f 9690f907 Author: Dan Smith Date: Wed Jan 26 11:32:54 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit ed1b011f1e5e04f289f7aa538f9c7153872b7a8d Author: Dan Smith Date: Tue Jan 25 15:21:38 2022 -0500 latest from coda-oss commit acc8b54917ac99c4893e63595d233310dc36828a Author: Dan Smith Date: Thu Jan 20 12:29:15 2022 -0500 latest from coda-oss commit daade6cd654b6ce63117441efc5cd7293ec80f14 Merge: 14802296 1d307d9a Author: Dan Smith Date: Thu Jan 20 12:27:31 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 1480229653ab5cc64eecc757373e56622b4dc4c1 Author: Dan Smith Date: Mon Jan 17 14:04:51 2022 -0500 latest from coda-oss commit b58460656df234ad89e7da7e1b4372a8926f891c Merge: 08b4a933 c71dc6d8 Author: Dan Smith Date: Mon Jan 17 14:03:52 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 08b4a93390ab68ee0059dd1e73832111871fbdcd Author: Dan Smith Date: Mon Jan 17 09:39:55 2022 -0500 require the specified C and C++ versions commit f7669f991be211c6bbe9262753720ec80ff6f878 Author: Dan Smith Date: Mon Jan 17 09:24:45 2022 -0500 latest from coda-oss commit d8efd9f0a8c11314f1ab5d936338f82763f77f22 Author: J. Daniel Smith Date: Fri Jan 14 12:55:25 2022 -0500 be sure variables are referenced to avoid compiler warnings commit 7e343a22c4471680a0a0d7a719846b691e008594 Author: Dan Smith Date: Fri Jan 14 11:06:30 2022 -0500 rename Filesystem commit c5e4489e940af378e6f36ad4d18dede28786c80f Author: Dan Smith Date: Fri Jan 14 11:05:53 2022 -0500 rename Filesystem commit 8c1c253e2349e23c25859b3f30c4dbb2f5e8dfe0 Author: Dan Smith Date: Fri Jan 14 10:57:57 2022 -0500 add missing headers to coda_oss/optional.h commit f6c515959b6e0e6a381508737d974c846ecf03b8 Author: Dan Smith Date: Fri Jan 14 10:36:35 2022 -0500 get rid of compiler warning commit f5436d4b97fdd0a0093023971e6e6dde63d52847 Author: Dan Smith Date: Fri Jan 14 10:27:27 2022 -0500 latest from coda-oss commit 7d476063c8495fd507f99219b15c8750f41f5967 Merge: 3fc510cf db9f1d2a Author: Dan Smith Date: Fri Jan 14 10:10:56 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 3fc510cfc5c97ea243206a802353992515c991a0 Author: Dan Smith Date: Mon Jan 10 13:19:53 2022 -0500 fix TypeTraits.h commit e43ebb21bbf6a49dd37a4d0f4c22c2a6a155457d Author: Dan Smith Date: Mon Jan 10 10:19:01 2022 -0500 latest from coda-oss commit 105dd17f2e177ed8d2f0aa230d1ae3d7239d838a Author: Dan Smith Date: Mon Jan 10 09:59:56 2022 -0500 type_traits from coda-oss commit 1de69902f39eec9cc246e9592b3af825d5815185 Merge: 814dc912 d991a049 Author: Dan Smith Date: Mon Jan 10 09:58:09 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 814dc91268e20bfa12577091a0a7fc7f5801b503 Author: Dan Smith Date: Wed Jan 5 09:32:34 2022 -0500 latest from coda-oss commit fe3db61c0527fa6d0fc36d816b32fce8c5f8fb68 Merge: 6cccaaef fe89ce31 Author: Dan Smith Date: Wed Jan 5 09:31:08 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 6cccaaef59ee883c7483eb9481f483cd976bc31f Author: Dan Smith Date: Mon Jan 3 15:43:56 2022 -0500 str::strip commit 6ca278651bd2ccb5f1987217b99e0a911c125c56 Author: Dan Smith Date: Mon Jan 3 12:10:50 2022 -0500 explicitly =delete moves commit c6f4413b0a05d0cb0ad0178a04e49cc1829f69dd Author: Dan Smith Date: Mon Jan 3 11:44:30 2022 -0500 latest from coda-oss commit 8483731799f17ed2ecd6a4e8717704d9499cbea4 Merge: 063d7fc9 9ea44741 Author: Dan Smith Date: Mon Jan 3 11:42:58 2022 -0500 Merge branch 'master' into develop/update_coda-oss commit 063d7fc9c7e6dd5d48f2b9d3703f5e0b042aa79e Merge: 4ae95d0c d4ad4b8a Author: Dan Smith Date: Mon Dec 13 11:13:13 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4ae95d0c4ea5cfa775774809aab87eca651aad0b Author: Dan Smith Date: Mon Dec 13 11:01:01 2021 -0500 coda-oss release 2021-12-13 commit 50a0c4763ca97bdaf4ff8613a36ed7b2b9481276 Author: Dan Smith Date: Mon Dec 13 10:58:10 2021 -0500 Squashed commit of the following: commit c2354a768f0b6f9a5fa9cff064fd182d3438b353 Author: Dan Smith Date: Tue Dec 7 16:44:18 2021 -0500 Update TestCase.h commit 93727a2f06cea62a40dbab073b2d58ae139c022b Merge: 9c7eb207 7c96994a Author: Dan Smith Date: Tue Dec 7 16:41:19 2021 -0500 Merge branch 'master' into develop/jdsmith commit 9c7eb2076903edc507b3426f38086d1ce553e1ae Merge: 6863bdcb 1b22d00a Author: Dan Smith Date: Tue Dec 7 16:14:21 2021 -0500 Merge branch 'master' into develop/jdsmith commit 6863bdcb9d139aa8f98cc8f8b386bbfbbf835f03 Author: Dan Smith Date: Tue Dec 7 15:50:26 2021 -0500 Squashed commit of the following: commit 5e6e22b25c77c6b705aa7dda0258c7805b7a315a Author: Dan Smith Date: Tue Dec 7 15:49:44 2021 -0500 latest from coda-oss commit b91e345a03a6b06678ee4ff7157ef1595ee289e6 Author: Dan Smith Date: Tue Dec 7 10:56:41 2021 -0500 latest from coda-oss commit d2d1d543aa6e97f311d5b5bf52b2b8d7e7f1502b Author: Dan Smith Date: Mon Dec 6 16:39:26 2021 -0500 more "Throwable" updates from coda-oss commit 1d65ff9db316bbd0087ed4a0e15295692b0cca43 Author: Dan Smith Date: Mon Dec 6 16:06:35 2021 -0500 latest "Throwable" changes from coda-oss commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit bc3ebc4f5252721e63fb7b1c888f2d8955878436 Author: Dan Smith Date: Tue Dec 7 11:23:43 2021 -0500 build C unittests commit 81b1d3d55b8c0f5fff01fd23769c90838965eebe Author: Dan Smith Date: Tue Dec 7 11:03:44 2021 -0500 Update TestCase.h commit d39796cffc53db29fddbb4adfcbdade73a1ce4d7 Author: Dan Smith Date: Tue Dec 7 10:57:21 2021 -0500 Squashed commit of the following: commit b91e345a03a6b06678ee4ff7157ef1595ee289e6 Author: Dan Smith Date: Tue Dec 7 10:56:41 2021 -0500 latest from coda-oss commit d2d1d543aa6e97f311d5b5bf52b2b8d7e7f1502b Author: Dan Smith Date: Mon Dec 6 16:39:26 2021 -0500 more "Throwable" updates from coda-oss commit 1d65ff9db316bbd0087ed4a0e15295692b0cca43 Author: Dan Smith Date: Mon Dec 6 16:06:35 2021 -0500 latest "Throwable" changes from coda-oss commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit ebb8e5d0f230d3fda7ac9777bf3d6411ae969e10 Author: Dan Smith Date: Tue Dec 7 10:47:23 2021 -0500 one more Throwable11 commit d8e85171c1244b5a84e0366b0feeb0134de67fe0 Author: Dan Smith Date: Tue Dec 7 10:23:36 2021 -0500 catch Throwable11 too commit e18da07d2c25b5f513167245cd23f62e0be71d10 Author: Dan Smith Date: Mon Dec 6 16:40:47 2021 -0500 Squashed commit of the following: commit d2d1d543aa6e97f311d5b5bf52b2b8d7e7f1502b Author: Dan Smith Date: Mon Dec 6 16:39:26 2021 -0500 more "Throwable" updates from coda-oss commit 1d65ff9db316bbd0087ed4a0e15295692b0cca43 Author: Dan Smith Date: Mon Dec 6 16:06:35 2021 -0500 latest "Throwable" changes from coda-oss commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit 51b6d40df6d6540ef65d5a463db8ffe879f3c47a Author: Dan Smith Date: Mon Dec 6 16:07:10 2021 -0500 Squashed commit of the following: commit 1d65ff9db316bbd0087ed4a0e15295692b0cca43 Author: Dan Smith Date: Mon Dec 6 16:06:35 2021 -0500 latest "Throwable" changes from coda-oss commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit 805f02c5464d0a7c26b7fd4f464abfc88521bf95 Author: Dan Smith Date: Mon Dec 6 15:29:03 2021 -0500 Squashed commit of the following: commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit 048b8f99262375a8739f1ccc610e753270673856 Author: Dan Smith Date: Mon Dec 6 11:21:32 2021 -0500 MemoryDestructor::operator() is "noexcpet(false)" commit b0a0f67be360f05f69a491368851856d86314055 Author: Dan Smith Date: Mon Dec 6 10:42:02 2021 -0500 implicitConstruct() can complain NITF_PLUGIN_PATH, provide a way to turn that off commit 80af6b44d4bf16c281bcfa8f98a3765ab842967a Author: Dan Smith Date: Thu Dec 2 11:59:46 2021 -0500 Squashed commit of the following: commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit f6f01910438a14fdc2f738e055a442fc9faf82b7 Author: Dan Smith Date: Thu Dec 2 11:25:53 2021 -0500 Squashed commit of the following: commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit 2c2275ef6e7c178af890f371e562f93f5819ef40 Author: Dan Smith Date: Wed Dec 1 10:33:18 2021 -0500 Squashed commit of the following: commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit 4fa223eb9eff1171cbdd19edb11656a33bf81ee4 Merge: f6b78b44 2747740a Author: Dan Smith Date: Wed Dec 1 10:28:36 2021 -0500 Merge branch 'develop/jdsmith' of github.com:mdaus/nitro into develop/jdsmith commit 2747740a6f18ac2614a76455b5df5e2d36bff120 Author: Dan Smith Date: Tue Nov 16 17:05:00 2021 -0500 'noexcept' breaks existing code commit f6b78b44be8e7fed442ad514efe3a87b4532bef3 Merge: fc1ea1b5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:01:14 2021 -0500 Merge branch 'master' into develop/jdsmith commit fc1ea1b5f45cedcf06280e421ba017b64f6340c4 Merge: 49f9f76f 9461c626 Author: Dan Smith Date: Tue Nov 16 15:40:24 2021 -0500 Merge branch 'master' into develop/jdsmith commit 49f9f76fe276ccf43109a0c8cfa75544ebc45ec9 Author: Dan Smith Date: Tue Nov 16 10:52:39 2021 -0500 be sure a == b gives the same results as !(a != b) commit 11fb89801be2f3b1f00d2182eeeaf396fc9d3a42 Author: J. Daniel Smith Date: Mon Nov 15 20:22:52 2021 -0500 Squashed commit of the following: commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb9 2e8d7cfae Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa79 64dc4e118 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701d 888ae9293 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c1 28d95160e Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa5114 dfba5e291 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf977 a4a1fc4f8 Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdfa eef3c6ec8 Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f3 f5f1f8ce1 Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b7635 0db498f1e Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba3 9388d5cf2 Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b26 81278527b Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b061 c8186387f Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807a dc000a516 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f200464 7af555d63 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea52593 cb37a8cff Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e596027 1b6cfe099 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe390482 2229fbde0 Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b83 835da56f5 Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c0 7bb82996c Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bfc 98e6bcf5d Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168d ffd5aa858 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857ab 4ddaf23d8 Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d39 2a57741c2 Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4b 8806960a8 Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d39 a16f72b0c Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819dbd 273c39e86 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf579 298536f40 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e57 c1def5d0b Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec21 edb9317db Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b34 edb9317db Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09b 2748224ba Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8c 2748224ba Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b2 a2b3a12d9 Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b38 c68cd17dd Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d46965774 bb0634924 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f69 fa20f42ee Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb2 c80e163ee Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a84 dfad79efc Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f7420 e40a0b3f6 Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15b 7c5dbed7f Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576b 612a55889 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4b c14639765 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4bc 14517c04f Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e0 f62735eb5 Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f916 8705bbb63 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b252 62ec49119 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e1011253 62ec49119 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab20 b7f04aecb Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d28 f810f8f6e Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70f f810f8f6e Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95a f0a45b36d Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f6 1b6ae6adb Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee4 ee89c7d34 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad0136140 1615ce17b Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc4 0fbebcbdc Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b8 91cb40798 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c82540 280141628 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d6 bc379d3f7 Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3a f419dc538 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c7 2d73f0ee1 Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538b 0d6988eb1 Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c0959 0d6988eb1 Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c41 5be4b7e63 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1da 92b19f9c5 Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d9 c1ef1e933 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f16826 aa22bcb57 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f6 8a97faadd Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e4 09c201636 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30f 1f3991624 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c3736061 f17909e9a Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af283859 9a609577c Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f16 c83348fd3 Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a086 a49805f17 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit c7db8465c67aa4db9ae5a2c9367743608f504002 Author: Dan Smith Date: Mon Nov 15 17:50:58 2021 -0500 Squashed commit of the following: commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit c13fc831aee807bfda9bc73f032e2e5f305d8edf Merge: 3ae221bd 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 17:50:46 2021 -0500 Merge branch 'master' into develop/jdsmith commit 3ae221bde34db36ed927a1f5282ab6dc4ec9ca99 Author: Dan Smith Date: Tue Nov 9 17:05:23 2021 -0500 tweaks from "main" commit edb5d2ce24151e63bf477a20a3942d1bceeeb42c Merge: 24201006 e868e374 Author: Dan Smith Date: Tue Nov 9 16:47:21 2021 -0500 Merge branch 'master' into develop/jdsmith commit 24201006a823059f8d15dd17c8406548c3c5bacc Author: Dan Smith Date: Tue Nov 9 15:56:51 2021 -0500 Squashed commit of the following: commit 37cd476058a5368d1ffb77e44b4c12430cb07d60 Author: Dan Smith Date: Tue Nov 9 14:29:37 2021 -0500 fix "noexcept" compiler error commit a77c8bf23f0cdec1b117480ed3e15ee2f97ad7fe Author: Dan Smith Date: Tue Nov 9 14:08:08 2021 -0500 remove (or #pragma-away) more compiler warnings commit 658ea41d14312ea1ae4064e46e3ca13b44c331b8 Author: Dan Smith Date: Tue Nov 9 14:07:16 2021 -0500 Squashed commit of the following: commit b04638d2863fc1c1e5ea321811707d8911071f2c Author: Dan Smith Date: Tue Nov 9 13:23:38 2021 -0500 #pragma away some compiler warnings commit e4679d4d2f7a1df92d0427c7d159e74113fd0720 Merge: 1bda4296 65b4df02 Author: Dan Smith Date: Tue Nov 9 12:55:40 2021 -0500 Merge branch 'master' into develop/jdsmith commit 1bda429694357d27224707d1f84c403d4b23805c Author: Dan Smith Date: Tue Nov 9 12:20:47 2021 -0500 fix errors found with building with C++20 commit 1a3285ab5664989f54fe2de2786b5779263017de Author: Dan Smith Date: Mon Nov 8 15:20:20 2021 -0500 build Test++ w/VS2022 commit 23b0fe1b4b5d5ca1c7b1b32811ea3406dd69bfc7 Author: Dan Smith Date: Mon Nov 8 15:08:50 2021 -0500 build Test project with VS2022 commit 319e7aff066a7aa02a1ed6662a876362b8bc92a8 Author: Dan Smith Date: Mon Nov 8 14:37:24 2021 -0500 VS2022 commit 565f72b69f0036a61e14141a87bcfc434ff2e649 Merge: 59c3e5b3 64dc4e11 Author: Dan Smith Date: Mon Nov 8 11:56:22 2021 -0500 Merge branch 'master' into develop/jdsmith commit 59c3e5b3ddd8cb0422a65684f1aac711ad80ac3d Author: Dan Smith Date: Mon Oct 18 09:26:59 2021 -0400 tweaks from "main" to build with C++17 commit d09f5ed46a12050a5799a2db3a12ff935ec12ef0 Merge: c08dbd52 dfba5e29 Author: Dan Smith Date: Mon Oct 18 09:11:53 2021 -0400 Merge branch 'master' into develop/jdsmith commit c08dbd528725669117ad8c4b30b123ad05e1249b Author: Dan Smith Date: Fri Oct 15 12:02:23 2021 -0400 Squashed commit of the following: commit 0c3a4a65e8db1cd1088de3ede808d0fedfda5ca3 Merge: 2600cedb 3c7653c3 Author: Dan Smith Date: Fri Oct 15 12:01:54 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 2600cedb4c820d8716ce4f87dcdaa15ec5a12295 Author: Dan Smith Date: Fri Oct 15 12:01:35 2021 -0400 braced-initialization causes CodeQL to fail? commit 45eb7bf729eeca30842e05fdf09db1617d0b384d Merge: 29854176 e17d918d Author: Dan Smith Date: Fri Oct 15 11:29:59 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 29854176ab1e941e0ebb588dcc1e8d1f7d916929 Author: Dan Smith Date: Tue Oct 12 15:29:33 2021 -0400 load 8-bit AMP files commit 80e8167fb2df6712620d99e5faba0311c2691cd3 Author: Dan Smith Date: Tue Oct 12 14:53:47 2021 -0400 8-bit AMP/PHS sample files commit d15754270e96e98ec59e58c73ca218d595a03831 Merge: a2ed1398 b7867398 Author: Dan Smith Date: Tue Oct 12 14:48:41 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit a2ed1398e1b4d692696f6bbc69b9bbf58a390ff8 Author: Dan Smith Date: Mon Oct 11 16:11:16 2021 -0400 need operator<< for unit-tests commit 668cd2d52a7bd1a9d3e877e684b2a530d12f90da Author: Dan Smith Date: Mon Oct 11 15:51:24 2021 -0400 more use of enums commit 67e933b5e726ec0898b106bc428511314b02cb31 Author: Dan Smith Date: Mon Oct 11 15:38:10 2021 -0400 use enums in test_image_loading commit 432d2890d7ef6efeb9beeb08332c9e6b4b4e2cd6 Author: Dan Smith Date: Mon Oct 11 11:15:53 2021 -0400 tweaks from SIX commit e7d3e70d643ca1c781ea355b7acd63edf3696eed Author: Dan Smith Date: Mon Oct 11 10:24:13 2021 -0400 make enums more descriptive rather than following cryptic C style commit 0764c55b75236c616e4d56d39f4da3166c444dcf Author: Dan Smith Date: Mon Oct 11 10:23:08 2021 -0400 nitro_image_.c -> nitro_image_.c_ commit 6f88781ea7ea187ee91e0d06c891db4a7ac86479 Author: Dan Smith Date: Thu Oct 7 16:33:48 2021 -0400 Squashed commit of the following: commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 5ee2381e91ef8d8294238199e0c229e946bc809a Merge: 052e5ced 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:17 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 052e5cedd98f59b20ab1b2c8c3b3db177477cfcb Author: Dan Smith Date: Thu Oct 7 15:26:28 2021 -0400 fix broken build with nitro_image.c commit 308be858f0d05e007b419cd048028085ce2ace69 Author: Dan Smith Date: Thu Oct 7 15:03:47 2021 -0400 enums for IREP and BlockingMode commit c880f175fb6da6603751312ab28b42b48d995b95 Author: Dan Smith Date: Thu Oct 7 14:14:47 2021 -0400 add nitf::PixelType to represent #defines in ImageIO.h commit 888c661a5c151a65d4ea18efd2974acefad483a9 Author: Dan Smith Date: Thu Oct 7 13:49:19 2021 -0400 Squashed commit of the following: commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 7d482d2f9c09b46cc5292880c2d44b0dddaf2b65 Merge: 24fa925f 3c7653c3 Author: Dan Smith Date: Fri Oct 15 12:02:14 2021 -0400 Merge branch 'master' into develop/jdsmith commit 24fa925f2468ba6f3015e0818d7c5cbe90ed89e7 Merge: 4a537c0f e17d918d Author: Dan Smith Date: Fri Oct 15 11:29:51 2021 -0400 Merge branch 'master' into develop/jdsmith commit 4a537c0f2da01f1fb7a048ab4e161afb5e1fe4c1 Author: Dan Smith Date: Fri Oct 15 11:25:29 2021 -0400 Build as StaticLibaray commit f686b20b64b5f256939534ecc2ac258fb35d8f38 Author: Dan Smith Date: Fri Oct 15 11:07:38 2021 -0400 need more work to build as DLL commit 970aabefca96d9112cf1d3051f0ec3ff545bd7cf Author: Dan Smith Date: Fri Oct 15 11:07:26 2021 -0400 "noexcept" commit e90546578d9d40e4eb2c0c37c0e02e2282c7cd53 Author: Dan Smith Date: Fri Oct 15 10:34:42 2021 -0400 fix Windows build commit 0364f51a1a38835bb980cc9102ba3c8d31d4d14b Author: Dan Smith Date: Fri Oct 15 10:07:35 2021 -0400 build as a DLL in Visual Studio commit 95ab27ca3676b7749fbe4e726ffbc0c80c39ae67 Author: Dan Smith Date: Fri Oct 15 10:07:20 2021 -0400 unit-tests use ENGRDA TRE commit ec277ffd0749ba2392accbbddabcf1efdcdb358f Author: Dan Smith Date: Fri Oct 15 09:52:57 2021 -0400 =default should be in CPP file because 'Impl" isn't defined in .h commit 833ab37d5997553a5dcb621c6b393e6cfc26c897 Author: Dan Smith Date: Fri Oct 15 08:34:40 2021 -0400 Squashed commit of the following: commit 29854176ab1e941e0ebb588dcc1e8d1f7d916929 Author: Dan Smith Date: Tue Oct 12 15:29:33 2021 -0400 load 8-bit AMP files commit 80e8167fb2df6712620d99e5faba0311c2691cd3 Author: Dan Smith Date: Tue Oct 12 14:53:47 2021 -0400 8-bit AMP/PHS sample files commit d15754270e96e98ec59e58c73ca218d595a03831 Merge: a2ed1398 b7867398 Author: Dan Smith Date: Tue Oct 12 14:48:41 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit a2ed1398e1b4d692696f6bbc69b9bbf58a390ff8 Author: Dan Smith Date: Mon Oct 11 16:11:16 2021 -0400 need operator<< for unit-tests commit 668cd2d52a7bd1a9d3e877e684b2a530d12f90da Author: Dan Smith Date: Mon Oct 11 15:51:24 2021 -0400 more use of enums commit 67e933b5e726ec0898b106bc428511314b02cb31 Author: Dan Smith Date: Mon Oct 11 15:38:10 2021 -0400 use enums in test_image_loading commit 432d2890d7ef6efeb9beeb08332c9e6b4b4e2cd6 Author: Dan Smith Date: Mon Oct 11 11:15:53 2021 -0400 tweaks from SIX commit e7d3e70d643ca1c781ea355b7acd63edf3696eed Author: Dan Smith Date: Mon Oct 11 10:24:13 2021 -0400 make enums more descriptive rather than following cryptic C style commit 0764c55b75236c616e4d56d39f4da3166c444dcf Author: Dan Smith Date: Mon Oct 11 10:23:08 2021 -0400 nitro_image_.c -> nitro_image_.c_ commit 6f88781ea7ea187ee91e0d06c891db4a7ac86479 Author: Dan Smith Date: Thu Oct 7 16:33:48 2021 -0400 Squashed commit of the following: commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 5ee2381e91ef8d8294238199e0c229e946bc809a Merge: 052e5ced 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:17 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 052e5cedd98f59b20ab1b2c8c3b3db177477cfcb Author: Dan Smith Date: Thu Oct 7 15:26:28 2021 -0400 fix broken build with nitro_image.c commit 308be858f0d05e007b419cd048028085ce2ace69 Author: Dan Smith Date: Thu Oct 7 15:03:47 2021 -0400 enums for IREP and BlockingMode commit c880f175fb6da6603751312ab28b42b48d995b95 Author: Dan Smith Date: Thu Oct 7 14:14:47 2021 -0400 add nitf::PixelType to represent #defines in ImageIO.h commit 888c661a5c151a65d4ea18efd2974acefad483a9 Author: Dan Smith Date: Thu Oct 7 13:49:19 2021 -0400 Squashed commit of the following: commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit cea2b5b66c5852b3e5598200e9a70a627b1d1bbf Merge: 9d0aa054 b7867398 Author: Dan Smith Date: Fri Oct 15 08:34:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit 793675d659fa4835b2818fa4191e6b8e8d29fa57 Merge: 210f5fa5 65b4df02 Author: Dan Smith Date: Tue Nov 9 14:06:17 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 210f5fa53a6d246671dd8b890dc429c247c0a238 Author: Dan Smith Date: Wed Aug 25 12:17:26 2021 -0400 remove warning about "unused parameter" commit 8713d386a56db548c4475c9e0050881b3674022f Author: Dan Smith Date: Wed Aug 25 12:09:30 2021 -0400 Squashed commit of the following: commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c414a329aaf6f0247ec481739377a199550908cc Merge: 51b0a83a 81278527 Author: Dan Smith Date: Wed Aug 25 12:09:16 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 51b0a83a29edaf7374aea8263c113edc214ba429 Author: Dan Smith Date: Wed Aug 25 11:08:47 2021 -0400 remove G++ compiler warning commit 9d2c4192777599b449d4fd793fe26f401b61c0dc Merge: ed66875f 3ebffd87 Author: Dan Smith Date: Wed Aug 25 11:02:13 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit ed66875f577253218c3c6eb05ac342e07d6a34d9 Author: Dan Smith Date: Wed Aug 25 10:58:13 2021 -0400 reduce GCC compiler warnings commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit b04638d2863fc1c1e5ea321811707d8911071f2c Author: Dan Smith Date: Tue Nov 9 13:23:38 2021 -0500 #pragma away some compiler warnings commit e4679d4d2f7a1df92d0427c7d159e74113fd0720 Merge: 1bda4296 65b4df02 Author: Dan Smith Date: Tue Nov 9 12:55:40 2021 -0500 Merge branch 'master' into develop/jdsmith commit 1bda429694357d27224707d1f84c403d4b23805c Author: Dan Smith Date: Tue Nov 9 12:20:47 2021 -0500 fix errors found with building with C++20 commit 1a3285ab5664989f54fe2de2786b5779263017de Author: Dan Smith Date: Mon Nov 8 15:20:20 2021 -0500 build Test++ w/VS2022 commit 23b0fe1b4b5d5ca1c7b1b32811ea3406dd69bfc7 Author: Dan Smith Date: Mon Nov 8 15:08:50 2021 -0500 build Test project with VS2022 commit 319e7aff066a7aa02a1ed6662a876362b8bc92a8 Author: Dan Smith Date: Mon Nov 8 14:37:24 2021 -0500 VS2022 commit 565f72b69f0036a61e14141a87bcfc434ff2e649 Merge: 59c3e5b3 64dc4e11 Author: Dan Smith Date: Mon Nov 8 11:56:22 2021 -0500 Merge branch 'master' into develop/jdsmith commit 59c3e5b3ddd8cb0422a65684f1aac711ad80ac3d Author: Dan Smith Date: Mon Oct 18 09:26:59 2021 -0400 tweaks from "main" to build with C++17 commit d09f5ed46a12050a5799a2db3a12ff935ec12ef0 Merge: c08dbd52 dfba5e29 Author: Dan Smith Date: Mon Oct 18 09:11:53 2021 -0400 Merge branch 'master' into develop/jdsmith commit c08dbd528725669117ad8c4b30b123ad05e1249b Author: Dan Smith Date: Fri Oct 15 12:02:23 2021 -0400 Squashed commit of the following: commit 0c3a4a65e8db1cd1088de3ede808d0fedfda5ca3 Merge: 2600cedb 3c7653c3 Author: Dan Smith Date: Fri Oct 15 12:01:54 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 2600cedb4c820d8716ce4f87dcdaa15ec5a12295 Author: Dan Smith Date: Fri Oct 15 12:01:35 2021 -0400 braced-initialization causes CodeQL to fail? commit 45eb7bf729eeca30842e05fdf09db1617d0b384d Merge: 29854176 e17d918d Author: Dan Smith Date: Fri Oct 15 11:29:59 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 29854176ab1e941e0ebb588dcc1e8d1f7d916929 Author: Dan Smith Date: Tue Oct 12 15:29:33 2021 -0400 load 8-bit AMP files commit 80e8167fb2df6712620d99e5faba0311c2691cd3 Author: Dan Smith Date: Tue Oct 12 14:53:47 2021 -0400 8-bit AMP/PHS sample files commit d15754270e96e98ec59e58c73ca218d595a03831 Merge: a2ed1398 b7867398 Author: Dan Smith Date: Tue Oct 12 14:48:41 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit a2ed1398e1b4d692696f6bbc69b9bbf58a390ff8 Author: Dan Smith Date: Mon Oct 11 16:11:16 2021 -0400 need operator<< for unit-tests commit 668cd2d52a7bd1a9d3e877e684b2a530d12f90da Author: Dan Smith Date: Mon Oct 11 15:51:24 2021 -0400 more use of enums commit 67e933b5e726ec0898b106bc428511314b02cb31 Author: Dan Smith Date: Mon Oct 11 15:38:10 2021 -0400 use enums in test_image_loading commit 432d2890d7ef6efeb9beeb08332c9e6b4b4e2cd6 Author: Dan Smith Date: Mon Oct 11 11:15:53 2021 -0400 tweaks from SIX commit e7d3e70d643ca1c781ea355b7acd63edf3696eed Author: Dan Smith Date: Mon Oct 11 10:24:13 2021 -0400 make enums more descriptive rather than following cryptic C style commit 0764c55b75236c616e4d56d39f4da3166c444dcf Author: Dan Smith Date: Mon Oct 11 10:23:08 2021 -0400 nitro_image_.c -> nitro_image_.c_ commit 6f88781ea7ea187ee91e0d06c891db4a7ac86479 Author: Dan Smith Date: Thu Oct 7 16:33:48 2021 -0400 Squashed commit of the following: commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 5ee2381e91ef8d8294238199e0c229e946bc809a Merge: 052e5ced 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:17 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 052e5cedd98f59b20ab1b2c8c3b3db177477cfcb Author: Dan Smith Date: Thu Oct 7 15:26:28 2021 -0400 fix broken build with nitro_image.c commit 308be858f0d05e007b419cd048028085ce2ace69 Author: Dan Smith Date: Thu Oct 7 15:03:47 2021 -0400 enums for IREP and BlockingMode commit c880f175fb6da6603751312ab28b42b48d995b95 Author: Dan Smith Date: Thu Oct 7 14:14:47 2021 -0400 add nitf::PixelType to represent #defines in ImageIO.h commit 888c661a5c151a65d4ea18efd2974acefad483a9 Author: Dan Smith Date: Thu Oct 7 13:49:19 2021 -0400 Squashed commit of the following: commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 7d482d2f9c09b46cc5292880c2d44b0dddaf2b65 Merge: 24fa925f 3c7653c3 Author: Dan Smith Date: Fri Oct 15 12:02:14 2021 -0400 Merge branch 'master' into develop/jdsmith commit 24fa925f2468ba6f3015e0818d7c5cbe90ed89e7 Merge: 4a537c0f e17d918d Author: Dan Smith Date: Fri Oct 15 11:29:51 2021 -0400 Merge branch 'master' into develop/jdsmith commit 4a537c0f2da01f1fb7a048ab4e161afb5e1fe4c1 Author: Dan Smith Date: Fri Oct 15 11:25:29 2021 -0400 Build as StaticLibaray commit f686b20b64b5f256939534ecc2ac258fb35d8f38 Author: Dan Smith Date: Fri Oct 15 11:07:38 2021 -0400 need more work to build as DLL commit 970aabefca96d9112cf1d3051f0ec3ff545bd7cf Author: Dan Smith Date: Fri Oct 15 11:07:26 2021 -0400 "noexcept" commit e90546578d9d40e4eb2c0c37c0e02e2282c7cd53 Author: Dan Smith Date: Fri Oct 15 10:34:42 2021 -0400 fix Windows build commit 0364f51a1a38835bb980cc9102ba3c8d31d4d14b Author: Dan Smith Date: Fri Oct 15 10:07:35 2021 -0400 build as a DLL in Visual Studio commit 95ab27ca3676b7749fbe4e726ffbc0c80c39ae67 Author: Dan Smith Date: Fri Oct 15 10:07:20 2021 -0400 unit-tests use ENGRDA TRE commit ec277ffd0749ba2392accbbddabcf1efdcdb358f Author: Dan Smith Date: Fri Oct 15 09:52:57 2021 -0400 =default should be in CPP file because 'Impl" isn't defined in .h commit 833ab37d5997553a5dcb621c6b393e6cfc26c897 Author: Dan Smith Date: Fri Oct 15 08:34:40 2021 -0400 Squashed commit of the following: commit 29854176ab1e941e0ebb588dcc1e8d1f7d916929 Author: Dan Smith Date: Tue Oct 12 15:29:33 2021 -0400 load 8-bit AMP files commit 80e8167fb2df6712620d99e5faba0311c2691cd3 Author: Dan Smith Date: Tue Oct 12 14:53:47 2021 -0400 8-bit AMP/PHS sample files commit d15754270e96e98ec59e58c73ca218d595a03831 Merge: a2ed1398 b7867398 Author: Dan Smith Date: Tue Oct 12 14:48:41 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit a2ed1398e1b4d692696f6bbc69b9bbf58a390ff8 Author: Dan Smith Date: Mon Oct 11 16:11:16 2021 -0400 need operator<< for unit-tests commit 668cd2d52a7bd1a9d3e877e684b2a530d12f90da Author: Dan Smith Date: Mon Oct 11 15:51:24 2021 -0400 more use of enums commit 67e933b5e726ec0898b106bc428511314b02cb31 Author: Dan Smith Date: Mon Oct 11 15:38:10 2021 -0400 use enums in test_image_loading commit 432d2890d7ef6efeb9beeb08332c9e6b4b4e2cd6 Author: Dan Smith Date: Mon Oct 11 11:15:53 2021 -0400 tweaks from SIX commit e7d3e70d643ca1c781ea355b7acd63edf3696eed Author: Dan Smith Date: Mon Oct 11 10:24:13 2021 -0400 make enums more descriptive rather than following cryptic C style commit 0764c55b75236c616e4d56d39f4da3166c444dcf Author: Dan Smith Date: Mon Oct 11 10:23:08 2021 -0400 nitro_image_.c -> nitro_image_.c_ commit 6f88781ea7ea187ee91e0d06c891db4a7ac86479 Author: Dan Smith Date: Thu Oct 7 16:33:48 2021 -0400 Squashed commit of the following: commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 5ee2381e91ef8d8294238199e0c229e946bc809a Merge: 052e5ced 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:17 2021 -0400 Merge branch 'master' into feature/8AMPI_PHSI commit 052e5cedd98f59b20ab1b2c8c3b3db177477cfcb Author: Dan Smith Date: Thu Oct 7 15:26:28 2021 -0400 fix broken build with nitro_image.c commit 308be858f0d05e007b419cd048028085ce2ace69 Author: Dan Smith Date: Thu Oct 7 15:03:47 2021 -0400 enums for IREP and BlockingMode commit c880f175fb6da6603751312ab28b42b48d995b95 Author: Dan Smith Date: Thu Oct 7 14:14:47 2021 -0400 add nitf::PixelType to represent #defines in ImageIO.h commit 888c661a5c151a65d4ea18efd2974acefad483a9 Author: Dan Smith Date: Thu Oct 7 13:49:19 2021 -0400 Squashed commit of the following: commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit cea2b5b66c5852b3e5598200e9a70a627b1d1bbf Merge: 9d0aa054 b7867398 Author: Dan Smith Date: Fri Oct 15 08:34:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 9d0aa05496d4021445abe248ab9cbe716ce63f6e Merge: 1bb9a059 30fc68fe Author: Dan Smith Date: Thu Oct 7 16:33:25 2021 -0400 Merge branch 'master' into develop/jdsmith commit 1bb9a0596f4c5a1f39c3ef814eae1867aac4f00f Author: Dan Smith Date: Thu Oct 7 13:34:02 2021 -0400 put the big ugly NITRO_IMAGE in a .c file for shared use and to hide it from most people commit aba400576164fff3419e95a6d52df465cc4dd8a4 Author: Dan Smith Date: Thu Oct 7 13:09:26 2021 -0400 Squashed commit of the following: commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit d1c09a533f05aaaba26304751648656c1fd165bc Merge: e4012457 a4a1fc4f Author: Dan Smith Date: Mon Oct 4 15:07:56 2021 -0400 Merge branch 'master' into develop/jdsmith commit e401245736e3170dd83fdf2bbe77836e2100f090 Merge: 378b2e20 eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:27 2021 -0400 Merge branch 'master' into develop/jdsmith commit 378b2e207ed221f6b40fa8df250f0d22cc22c6db Author: Dan Smith Date: Mon Oct 4 13:16:34 2021 -0400 Squashed commit of the following: commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit fe430168ec2e6a8b74c90bd6ad0a70a9b6b5b35f Merge: d6a22d62 f5f1f8ce Author: J. Daniel Smith Date: Tue Sep 28 18:31:35 2021 -0400 Merge branch 'master' into develop/jdsmith commit d6a22d620a517b2371cd30b8b94db237b984a7d2 Author: J. Daniel Smith Date: Tue Sep 28 18:30:58 2021 -0400 slam in master commit 5ba789753e7d8ea7f4ca123d524e5514c7ff629c Author: Dan Smith Date: Mon Jan 4 15:27:25 2021 -0500 Create Gsl_.h. not gsl_.h commit 034e523e0ea069e3b080917fd064e847668e1a6c Author: Dan Smith Date: Mon Jan 4 15:26:53 2021 -0500 Delete gsl_.h, need to re-add as Gsl_.h commit 17ab1522616ed455f4fa4e715c0a8a9ae2ceccb0 Author: Dan Smith Date: Mon Jan 4 15:14:29 2021 -0500 fix #incldues for other GSL files commit 3dcb9a7a94d9a44c361e36ab65152ae4fb0c6f0f Author: Dan Smith Date: Mon Jan 4 15:09:21 2021 -0500 coda-oss now supplies gsl::span commit 0c6769fffab76337f26050bc2000554228220798 Author: Dan Smith Date: Mon Jan 4 15:05:08 2021 -0500 still trying to build w/o changing coda-oss commit 9c402342f4d8c6c0ffc3cd2904335fad342d9c3b Merge: 2f5fd838 f8912752 Author: Dan Smith Date: Mon Jan 4 13:59:55 2021 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2f5fd838a02a760c514fdf0ff8839abae07647d4 Merge: d7975de2 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:59:48 2021 -0500 Merge branch 'main' into develop/jdsmith commit f8912752a67ed7593744272d4a4ea9f91dd9c302 Author: Dan Smith Date: Mon Jan 4 13:59:21 2021 -0500 latest from coda-oss/main commit e45d02d0a739dbd20588f1d7995dc29020c21c69 Merge: 3c5bc891 adc0e73f Author: Dan Smith Date: Mon Jan 4 13:37:14 2021 -0500 Merge branch 'main' into feature/update_coda-oss commit d7975de2683864954e808c066309994b486a18f3 Merge: 80ec6bdd 918ec518 Author: Dan Smith Date: Wed Dec 30 17:42:36 2020 -0500 Merge branch 'main' into develop/jdsmith commit 80ec6bdd8b6acbe2849ce607dda36b91094f3383 Author: Dan Smith Date: Wed Dec 30 17:42:12 2020 -0500 tweak CODA-OSS w/o changing source files commit 85dd51b70fd668c0e027e7f5091ef3bfeefc47e5 Author: Dan Smith Date: Wed Dec 30 16:16:51 2020 -0500 use sys/CStdDef.h directly, get rid of our own commit a7ac877ce262f254e94479f334cd9f5f1bc5ba86 Merge: 29369014 3c5bc891 Author: Dan Smith Date: Wed Dec 30 16:08:49 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 2936901461a8745c37a28269621c0d1ef181bfd4 Merge: 3a5c055f 9946049f Author: Dan Smith Date: Wed Dec 30 16:08:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit 3c5bc891a98bcc331431de1af21dd68162301b99 Author: Dan Smith Date: Wed Dec 30 16:08:08 2020 -0500 latest from coda-oss/main commit 98a9d9976a2c63eead29de70566c8cc052014e91 Merge: fef9b201 9946049f Author: Dan Smith Date: Wed Dec 30 15:53:09 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 3a5c055fa0465a775c7782885816ac605531f199 Author: Dan Smith Date: Wed Dec 30 12:38:52 2020 -0500 throwable needs to derive from std::exception in this repo commit 1a2a6243feeeff4593fe6833a53dda911ef621b3 Author: Dan Smith Date: Wed Dec 30 12:27:21 2020 -0500 add a dependency for gsl so #include files get copied commit eb3683641e6f35ae2034e44e60605359175ccf54 Author: Dan Smith Date: Wed Dec 30 11:40:42 2020 -0500 add dependency on gsl so files get copied for CMAKE commit 809d992179ae6ef429e25002b11dd63273b40e10 Merge: b9eec169 fef9b201 Author: Dan Smith Date: Wed Dec 30 11:28:58 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit fef9b201a08f1eb54b140526d37ceb14e559991d Author: Dan Smith Date: Wed Dec 30 11:28:40 2020 -0500 "nitro" isn't ready for Throwable to be derived from std::exception commit b9eec16905354a3f808c2dc14f1b078361e42b18 Merge: ceb3c22b d84bfd19 Author: Dan Smith Date: Wed Dec 30 11:15:13 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit d84bfd191334f59da68e3c808e092975d23bce6c Author: Dan Smith Date: Wed Dec 30 11:14:50 2020 -0500 latest from coda-oss/main commit 5f35abd6d5271ac19f3965f4288b91530b4ad345 Merge: f4d73770 75ccefa3 Author: Dan Smith Date: Wed Dec 30 11:07:58 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ceb3c22b7c12c7d2e89e860f01e4ea6c02928474 Author: Dan Smith Date: Wed Dec 30 10:49:01 2020 -0500 use GSL from coda-oss commit e7731e34245fd2dec7406d4756334fa93c1b9c2c Merge: d0d75057 75ccefa3 Author: Dan Smith Date: Wed Dec 30 10:45:58 2020 -0500 Merge branch 'main' into develop/jdsmith commit d0d7505761d80195cdfe1d4bf90f603e1a387b38 Merge: 1b5ec835 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:33:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit f4d73770a543fffc2949209f7ce3a151dde63cc4 Merge: 99c135c7 b6f883fc Author: Dan Smith Date: Wed Dec 30 10:20:55 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 99c135c7d85ac7046089656e762a31752fb1f38a Author: Dan Smith Date: Wed Dec 30 10:07:31 2020 -0500 no xml.lite in "nitro" commit 1e36890c62e52cbc7409707fc645b71758718173 Author: Dan Smith Date: Wed Dec 30 10:01:01 2020 -0500 latest from coda-oss/main commit 979130f3782cf6754a92101ae773e1a001a3fbf1 Merge: ce3b9a87 16289ae3 Author: J. Daniel Smith Date: Tue Dec 29 16:36:26 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit ce3b9a87a52e447602620a0d74090f8ecbe03d4c Author: Dan Smith Date: Tue Dec 29 16:24:12 2020 -0500 latest from coda-oss/main commit 433d2ff65b6be2528b07d712274cf7700d146aef Author: Dan Smith Date: Tue Dec 29 08:51:55 2020 -0500 if we're at C++20, there's nothing to augment commit ef9272fea4fec4d0c2c9e3941808e1bbbf9ac975 Author: Dan Smith Date: Tue Dec 29 08:34:17 2020 -0500 fix default for CODA_OSS_AUGMENT_std_namespace commit 656cb48e10aa0cd997c7ac76a9970da4457ab743 Merge: 476a6138 e8c631ec Author: Dan Smith Date: Tue Dec 29 08:10:21 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit e8c631ec990b835ad6d96390528342c4e0f87cd7 Author: Dan Smith Date: Mon Dec 28 17:51:41 2020 -0500 same code builds with both C++11 and C++17 commit 025d082d5f8a64f307c35f79fe1fb13c459755b6 Author: Dan Smith Date: Mon Dec 28 17:33:22 2020 -0500 openjpeg changes from coda-oss commit 3ece09691ab34efebec6b5b14373a20dd15a15c4 Author: Dan Smith Date: Mon Dec 28 17:27:07 2020 -0500 c++ updates from coda-oss commit 6c36adee93dd7bcdf8cbc7f8a97fb21a61c08450 Author: Dan Smith Date: Wed Dec 23 11:48:38 2020 -0500 latest from coda-oss commit abba878694ba21970b911588bbbba4d6e3811a2e Merge: 3ecc0996 bce3916a Author: Dan Smith Date: Wed Dec 23 11:28:00 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 1b5ec8356b93ddc29556b74ed361e66d0e12c826 Merge: 7b5a366c 09eaf726 Author: Dan Smith Date: Sat Dec 19 13:39:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7b5a366cd5a7ed8461c3d472d89f7bc296bb6ad8 Author: Dan Smith Date: Sat Dec 19 13:36:48 2020 -0500 can use std::exception in a few more places now that Throwable derives from it commit 2553a0406dcd2e1d71f539edc14f9ddb1bdaa5dc Merge: 77852e09 3ecc0996 Author: Dan Smith Date: Sat Dec 19 13:00:46 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 3ecc09968f79798db1f0e991ed1ade48ad7efb90 Author: Dan Smith Date: Sat Dec 19 13:00:18 2020 -0500 latest from "coda-oss" commit 69aac0effab2bdf6936b6655108298c24ba32580 Merge: bb641047 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:58:05 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 77852e09b89cd25b6bc09ffc0d271b7008f09307 Author: Dan Smith Date: Sat Dec 19 12:10:21 2020 -0500 should normally "catch" "const" exceptoins commit c7bfc09730dc4e05ece7c9f58257c304c8198c5e Merge: c9392744 2b0e059f Author: Dan Smith Date: Sat Dec 19 12:03:50 2020 -0500 Merge branch 'main' into develop/jdsmith commit c9392744a06be18e805b9a9a6da91920d9af126c Author: Dan Smith Date: Sat Dec 19 12:03:24 2020 -0500 further reduction in use of explicit toString() commit 9f0f85425061aac6c72b97d74424e059a410c473 Author: Dan Smith Date: Sat Dec 19 11:46:34 2020 -0500 restore .toString() changes lost in previous merge commit 07f65a0345ee4b89b472937440876f89c5a70e94 Merge: 292c803e 2bfe14e6 Author: Dan Smith Date: Sat Dec 19 11:31:27 2020 -0500 Merge branch 'feature/use_std_types' into develop/jdsmith commit 2bfe14e6228614598aac012ecc56fb0f8fd5f3ad Author: Dan Smith Date: Sat Dec 19 11:30:57 2020 -0500 use "range for" instead of explicit iterators commit 5ef4556dc7c674b21afa9a0f6b8bcfb213c802f4 Merge: 6a344dd3 8bde6968 Author: Dan Smith Date: Sat Dec 19 11:30:09 2020 -0500 Merge branch 'main' into feature/use_std_types commit 292c803ef1bd0c77ed4095348708872de35df46a Author: Dan Smith Date: Sat Dec 19 11:05:36 2020 -0500 use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() commit 9c85e0a2fd810a2ea4f7e445ab82d8f3b39ad281 Author: Dan Smith Date: Sat Dec 19 10:41:12 2020 -0500 make it easier to get a nitf::Field value as a string commit d8d2a5da65fd156e3f7b7a6ecf8ac04b9b9a86c8 Merge: ced31b3d 8bde6968 Author: Dan Smith Date: Wed Dec 16 11:06:02 2020 -0500 Merge branch 'main' into develop/jdsmith commit ced31b3dba3df88c780b0f65cbe2c52139b0d156 Author: Dan Smith Date: Wed Dec 16 11:05:37 2020 -0500 use range "for" loop commit 5d70d459c19d6bcbc82086bea0fd95adc6ea624f Merge: 0e6ea3d8 b545a610 Author: Dan Smith Date: Wed Dec 16 10:54:28 2020 -0500 Merge branch 'main' into develop/jdsmith commit 0e6ea3d81ef5f743f2bf7dd338d260faa58d5d2c Author: Dan Smith Date: Wed Dec 16 10:21:22 2020 -0500 more use of std::byte instead of uint8_t commit b3e4b8a566bb3f7bb62983df7040c5573cfda2cd Author: Dan Smith Date: Wed Dec 16 09:41:19 2020 -0500 manage the "buffer list" so we can't screw it up commit 1a68c769a0ca0e171b870096dfeb82499a0a6646 Author: Dan Smith Date: Wed Dec 16 09:21:51 2020 -0500 more simplification when using SubWindow commit d4713332910ed797e57346e2137ad2ce2ef6c873 Author: Dan Smith Date: Tue Dec 15 16:57:17 2020 -0500 simplify calling SubWindow::setBandList() commit 9e26dce4f04932647eb01a76171d04f64336d374 Author: Dan Smith Date: Tue Dec 15 16:18:41 2020 -0500 slightly code simplification commit a6a0b721222d1deb167201639b0eaf881f666036 Author: Dan Smith Date: Tue Dec 15 15:57:47 2020 -0500 ignore .out files from unittests commit 9802ba12b3aa0da6c4d10ea9fc012cea2a7c8e96 Author: Dan Smith Date: Tue Dec 15 15:55:18 2020 -0500 test_image_loading++ is now a unittest commit 8297ac630dcf7bfc257018da20ef874e25090fe8 Author: Dan Smith Date: Tue Dec 15 14:06:39 2020 -0500 tweak code organization commit 8f233bb3a3049752db0f423ad9c583ca409751c4 Author: Dan Smith Date: Tue Dec 15 13:56:23 2020 -0500 test_buffered_write is now a unittest commit aa2feb1cd3e551c938a0a09cae26e1ee32ade008 Author: Dan Smith Date: Tue Dec 15 13:17:28 2020 -0500 test_writer_3++ is now a unittest commit c7f1c5409490e8f2205bb35fff552fa755b44c0e Author: Dan Smith Date: Tue Dec 15 13:16:02 2020 -0500 get test_writer_3++ working commit 46f2ed8ed9a2c8f45222aa64f53c3b2f3af70bdc Author: Dan Smith Date: Tue Dec 15 12:54:15 2020 -0500 nitf::PluginRegistry::loadPlugin() needs a full path on Linux commit 44d2c3aea03b94796092a6e44a5fc1bafd33475b Author: Dan Smith Date: Tue Dec 15 12:39:50 2020 -0500 test C++ routines too commit 6a759eabfe53b0ef028a111f7daa73733c008791 Author: Dan Smith Date: Tue Dec 15 12:27:04 2020 -0500 be sure we can load plugins; there was a bug in PTPRAA! commit f8d312c79997b6a57d13208edf882825c64c71c8 Author: Dan Smith Date: Tue Dec 15 11:34:37 2020 -0500 PTPRAA had the wrong id so it wouldn't load commit 0515e0bcfb83a8cc037ef4cc7198a460ddcf7403 Author: Dan Smith Date: Tue Dec 15 11:06:39 2020 -0500 trying to turn test_writer_3++ into a unittest commit 998b7e35c0ccc9a1555a71581da3d4a260a88ae0 Author: Dan Smith Date: Tue Dec 15 09:07:19 2020 -0500 remove more uses of delete[] commit 7101f5d3436dedaba6648839d8974af109772458 Author: Dan Smith Date: Mon Dec 14 18:23:09 2020 -0500 reduce explict use of "delete" commit 0a6771cfb64ff7d9dc05908b178bd53ece7dff8c Author: Dan Smith Date: Mon Dec 14 13:36:18 2020 -0500 make the hashtable test a unittest so it will be ran much more often commit 80ee90384edb1d34a861ccb0bb305fec49cd3279 Author: Dan Smith Date: Mon Dec 14 11:09:23 2020 -0500 reduce use of delete[] commit 84cce3b0addf21d8245f012b92de3d48a239d49f Author: Dan Smith Date: Tue Dec 8 16:57:50 2020 -0500 simplify access to some ImageSubheader values commit 6763c8c530ae2063484ad4652ea071a45171836f Merge: a5d724fb aa13b3a6 Author: Dan Smith Date: Tue Dec 8 11:29:29 2020 -0500 Merge branch 'main' into develop/jdsmith commit a5d724fbfdba66935928fda0c4ef9861f1310245 Merge: d68915c9 bb641047 Author: Dan Smith Date: Tue Dec 8 11:00:15 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit bb6410475ad402c1ad0c1d38286d411aacf39a7d Author: Dan Smith Date: Tue Dec 8 11:00:03 2020 -0500 "filesystem" updates commit d68915c999cdd2d97fc36b917635f72a6b3f51a0 Author: Dan Smith Date: Mon Dec 7 18:23:55 2020 -0500 build with /std:c++17 commit f60c96aca5db00c86e8b3720d17734d5011ceacc Author: Dan Smith Date: Mon Dec 7 18:19:36 2020 -0500 sys::Filesystem -> std::filesystem commit 377bda26155e94b773a55dd11acece6d9ab2ff61 Merge: 7eb69307 9ca83b60 Author: Dan Smith Date: Mon Dec 7 18:04:52 2020 -0500 Merge branch 'feature/update_coda-oss' into develop/jdsmith commit 9ca83b609693367d6f40f96bc7674b927b2d2119 Author: Dan Smith Date: Mon Dec 7 18:04:29 2020 -0500 update coda-oss commit 7a95701a0f1a3fdda166a076fd197e0d0f24254d Merge: 7a43c77f bed0e252 Author: Dan Smith Date: Mon Dec 7 17:41:59 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit 7eb693072e702299b44585180315beb5a1e777a5 Author: Dan Smith Date: Mon Dec 7 13:27:36 2020 -0500 less use of sys:: commit 80daf70783c4941eb7f7e8ead91424f9d8bfccda Author: Dan Smith Date: Mon Dec 7 12:48:15 2020 -0500 sys::Thread -> std::thread commit 35064693727dd4671682075239c26e4960f0ed08 Author: Dan Smith Date: Mon Dec 7 12:36:22 2020 -0500 make test_mt_record a unit-test commit 3fca08e8cbeed38965ffcc116b7429e6384c84dc Author: Dan Smith Date: Mon Dec 7 11:57:42 2020 -0500 use std::this_thread::get_id() instead of sys::getThreadID() commit 6a344dd3f47a2146621d0f49bb9044e18f3b5419 Author: Dan Smith Date: Sat Dec 5 17:46:08 2020 -0500 NULL -> nullptr commit f036d4191642d1faa178add56a6e610917450cf8 Author: Dan Smith Date: Sat Dec 5 17:42:53 2020 -0500 use .data() rather than &d[0] commit 577042838a46f22e96d62bee1cde7c7642e26483 Author: Dan Smith Date: Sat Dec 5 17:37:01 2020 -0500 sys::Off_T -> int64_t commit 64f4048fb4db8c1a655244181d8e43887212d5fb Merge: 918dccf3 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 17:30:56 2020 -0500 Merge branch 'main' into feature/use_std_types commit ae18eb61b1ae4092a16517693c3cdcc6b18ed1b1 Merge: 77543061 07f8d9a6 Author: Dan Smith Date: Sat Dec 5 09:25:40 2020 -0500 Merge branch 'main' into develop/jdsmith commit 77543061ae6186fa1da8ef8aa76d2be95b70877c Author: Dan Smith Date: Wed Dec 2 18:21:27 2020 -0500 remaining "nitro" -> "nitf" commit 2b62b53d5936300a0d4da07754860416c97b209b Author: Dan Smith Date: Wed Dec 2 18:14:45 2020 -0500 more "nitro" -> "nitf" to match Linux commit 82208520acb7374099791d9744345da605ac91e0 Author: Dan Smith Date: Wed Dec 2 18:12:14 2020 -0500 make names match Linux commit e4b1d01ae47dbe88333389324154f686b7161705 Author: Dan Smith Date: Wed Dec 2 18:09:19 2020 -0500 no "auto" return type for GCC commit e7176193b7535b722e10701328f596ca3234cb83 Author: Dan Smith Date: Wed Dec 2 17:49:36 2020 -0500 trying to do our own std::span commit 126e1e9b413dbea15169edacb7f7e4164d9aa325 Author: Dan Smith Date: Wed Dec 2 16:50:10 2020 -0500 use real GSL based on VS version commit 7efb83a26e83470a3d76b22d6dcf6607f79d486d Author: Dan Smith Date: Wed Dec 2 16:34:08 2020 -0500 make project settings more consistent commit 6c2390b15b29bf266a5af952bc86b055ec1d6046 Author: Dan Smith Date: Wed Dec 2 16:11:21 2020 -0500 tweak "externals" configuration commit ed1d071c6c20098dddbb02024fc62a5171caa751 Merge: 685c7722 5d9b377f Author: Dan Smith Date: Wed Dec 2 15:41:01 2020 -0500 Merge branch 'develop/jdsmith' of https://github.com/mdaus/nitro into develop/jdsmith commit 685c7722758e0a492cedca26121f5f2882b95d03 Merge: b35da15f 8a97faad Author: Dan Smith Date: Wed Dec 2 15:39:53 2020 -0500 Merge branch 'main' into develop/jdsmith commit 918dccf32389a0b767f29c6f31df7eb6b2fedc8f Merge: a20dc153 5f1f3477 Author: Dan Smith Date: Wed Dec 2 10:04:54 2020 -0500 Merge branch 'feature/use_std_types' of https://github.com/mdaus/nitro into feature/use_std_types commit a20dc153cfdac17de6f6947603f1a227d82a233d Merge: 559177f7 8a97faad Author: Dan Smith Date: Wed Dec 2 10:04:32 2020 -0500 Merge branch 'main' into feature/use_std_types commit 5f1f3477fe967d755947dbb87f59e06dd4fdce79 Author: Dan Smith Date: Tue Dec 1 18:15:29 2020 -0500 previous commit broke a test-case :-( commit 6e44db36a6df6ed1c387ceb0853e0566cce4ca6e Author: Dan Smith Date: Tue Dec 1 18:01:43 2020 -0500 std::byte* instead of char* commit 104d672b4b066efff895ed7aa705d1681ebb7ca7 Merge: 6546b9a2 f1b67ffa Author: Dan Smith Date: Tue Dec 1 18:01:22 2020 -0500 Merge branch 'main' into feature/use_std_types commit 6546b9a27c76d7615dae9d64a9a662c2595cf970 Author: Dan Smith Date: Tue Dec 1 16:08:12 2020 -0500 use filesystem routines rather than sys:: commit 1aa974c50e41ddc945a81443207351b81a8961d8 Author: Dan Smith Date: Tue Dec 1 15:40:18 2020 -0500 use std::shared_ptr instead of mem::ScopedArray commit 5d9b377fd95660fe808eec9fab3567c61602a1e5 Author: Dan Smith Date: Tue Dec 1 12:52:33 2020 -0500 move real GSL code to a place where it will be copied by existing scripts commit b35da15f2075cfd814ca36651c5930b72a6e344f Author: Dan Smith Date: Tue Nov 24 09:02:59 2020 -0500 make project settings more consistent commit 1bee4992a07e3b3b8d30d8ba9d607bf8cedd41f8 Merge: f6de02f5 57f5aa5c Author: Dan Smith Date: Tue Nov 24 08:50:30 2020 -0500 Merge branch 'main' into develop/jdsmith commit f6de02f5a2d8905e6819f7d5756936d13d5a0da0 Author: Dan Smith Date: Wed Nov 18 16:51:03 2020 -0500 add a project to build show_nitf++ commit a89d4294c0601c03f7f4ec9e87db43f23ca2c91c Author: Dan Smith Date: Wed Nov 18 15:47:49 2020 -0500 use AVX2 commit 7dbe62d46a5c8b865f7efe73a9a05f8ab9ffc79f Merge: 59724977 f07461b6 Author: Dan Smith Date: Wed Nov 18 14:06:38 2020 -0500 Merge branch 'main' into develop/jdsmith commit 5972497729bc049785fbeeb84c30861be7bc63c4 Author: Dan Smith Date: Wed Nov 18 13:59:57 2020 -0500 find path to WAF-build DLLs commit 9085d352f456353b6a19c86069bbf3176493cc48 Author: Dan Smith Date: Wed Nov 18 13:13:22 2020 -0500 use top-level "install" directory so we get DLLs built by WAF commit 0077a0cea31ab60963b253b1cc6189c83d763446 Merge: 106e2f8c 1f399162 Author: Dan Smith Date: Wed Nov 18 12:56:50 2020 -0500 Merge branch 'feature/remove_compiler_warnings' into develop/jdsmith commit 106e2f8c374678bf2f14947c2239a2153c3ef5f6 Merge: 7a7e62a7 00a0a781 Author: Dan Smith Date: Wed Nov 18 12:56:42 2020 -0500 Merge branch 'main' into develop/jdsmith commit 7a7e62a7ee087e4349c321f3f3d360100b5ae26f Author: Dan Smith Date: Mon Nov 16 15:08:45 2020 -0500 move tests\test_geo_utils to unittests so that it is always ran commit 211e2d35d3b2c977376abb468bbfce1ea4569ef5 Author: Dan Smith Date: Mon Nov 16 14:37:42 2020 -0500 remove more "unreerenced parameter" warnings commit 19b9ffc6ea9d75824f8101dd663b39890c092215 Author: Dan Smith Date: Mon Nov 16 14:12:08 2020 -0500 removed a bunch of "unrefered parameter" compiler warnings commit 44ad43d4a344664dddea9a315c405a0120e918f2 Author: Dan Smith Date: Mon Nov 16 11:41:04 2020 -0500 remove compiler warnings from Windows WAF build commit 1d7b5172b773c07aa43ef6c460a0601e0f282d9d Merge: 7ebf1373 487879c1 Author: Dan Smith Date: Mon Nov 16 10:33:12 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 487879c1aa1234d3342a5c39ff3fe6603565c5b1 Merge: 8887532a 3d65ba13 Author: Dan Smith Date: Mon Nov 16 10:32:44 2020 -0500 Merge branch 'main' of github.com:mdaus/nitro into main commit 7ebf1373996cfa334296a3a027ede67efeec2c36 Author: Dan Smith Date: Mon Nov 16 10:19:47 2020 -0500 tweak wrap-around results commit 8887532a102f9cd6f0cdf0700b9fe00e19699f5c Author: Dan Smith Date: Mon Nov 16 09:11:13 2020 -0500 added several more (broken?) unittests commit ca3321606c4d976743003636bec68fc745f83569 Author: Dan Smith Date: Mon Nov 16 09:01:23 2020 -0500 test all 0s for latitude commit e4c6d0852b9c0f178188e75f8f3e3f585f7c6224 Author: Dan Smith Date: Mon Nov 16 08:55:12 2020 -0500 Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. commit d156a5f937dad4d02a57736d79ceb5ed6565ef24 Author: Dan Smith Date: Wed Nov 11 17:27:56 2020 -0500 fix a handful of warnings when bilding on Windows with WAF commit 8da6c33787702f06fe3882d50f2e19758828da28 Merge: 31d07890 c7601b74 Author: Dan Smith Date: Wed Nov 11 17:21:37 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 31d07890fd5d43aa92b4366811698758ca20ce19 Merge: 84aa643b f5c55741 Author: Dan Smith Date: Wed Nov 11 16:39:06 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 84aa643b8878c56bd08006471bdb9a057c05f121 Author: Dan Smith Date: Wed Nov 11 16:27:45 2020 -0500 do a better job wrapping coordinates commit 22c5e479d7cc21a81900909491e5544e775e6add Author: Dan Smith Date: Wed Nov 11 15:01:27 2020 -0500 fix multile broken DMS conversons commit 35a0c1a2a3dde61b25da599cbf3bdd6ac667e64d Author: Dan Smith Date: Wed Nov 11 13:09:33 2020 -0500 once again, preserve existing (incorrect) behavior commit 0cc8998146ade754ae980f815fd15678b71fa7c4 Author: Dan Smith Date: Wed Nov 11 12:45:20 2020 -0500 adjust unit-tests to account for more existing behavior commit 0ef50992adc6e3d1fb3d9e9e0563a0550b7a8999 Author: Dan Smith Date: Wed Nov 11 12:33:13 2020 -0500 unit-test more incorrest results commit 3f59f0698f972ff638070b6e564f78a26a4c62ab Author: Dan Smith Date: Wed Nov 11 12:07:52 2020 -0500 preserve existing (incorrect?) behavior commit 5e44b226ea2bfa23bb8fbb1a40aa9793bd130af0 Author: Dan Smith Date: Wed Nov 11 11:54:32 2020 -0500 test DMS values > 60, 180, 360 ... things are broken commit 8dd4bf3f97e43bd318a892eb3618eb8e2bf77f48 Author: Dan Smith Date: Wed Nov 11 10:40:02 2020 -0500 single utility routine for adjusting dms values commit e8581b76b5c30dc7acd8108d06771b4907f8723c Author: Dan Smith Date: Wed Nov 11 10:29:21 2020 -0500 fix compiler warnings w/o breaking (new :-) ) unittests commit 1b4aff9cd857edd2daafac287ad17535e885d965 Author: Dan Smith Date: Wed Nov 11 09:58:29 2020 -0500 unittest for DMS conversion that is "correct" on main (broken right now) commit 2537347aa35c6197e513a09d9dd05c331f399b61 Author: Dan Smith Date: Tue Nov 10 18:02:01 2020 -0500 don't check-in outputPathname.ntf commit 1e402057a467f544816a9634ad73604ff2f7a02e Author: Dan Smith Date: Tue Nov 10 18:01:27 2020 -0500 fix GCC compiler errors about buffer sizes commit 7a43c77fda1f507e688104fa0f38f08cdf957ba4 Author: Dan Smith Date: Mon Nov 9 12:59:21 2020 -0500 latest coda-oss from "main" commit 476a61380c1287b3d32459545e560083190a04a5 Merge: edccd64f 3ea4b831 Author: Dan Smith Date: Tue Nov 3 16:55:52 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit edccd64f5aebb262fa3236c4cccb47972a2e0b6d Author: Dan Smith Date: Tue Nov 3 16:45:07 2020 -0500 remove coda-oss modules not needed for "nitro" commit ab3900f76f6204f40fc2dd0f6723501c304db291 Merge: b15307f5 dfda756d Author: Dan Smith Date: Tue Nov 3 16:37:19 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit dfda756de7e0077f57cd21e5c26a215321745a56 Merge: 404d14ec a9bf63fb Author: Dan Smith Date: Tue Nov 3 16:14:50 2020 -0500 Merge branch 'main' into feature/update_coda-oss commit b15307f5bf82bf24de82b7114f7b55b6eaec3e98 Merge: e62bf5b1 404d14ec Author: Dan Smith Date: Tue Nov 3 16:06:47 2020 -0500 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 404d14ece170543f54042071fad12bdb18e92996 Author: Dan Smith Date: Tue Nov 3 15:52:21 2020 -0500 latest from coda-oss commit 7b54be6c04a3cfb9d10308c7ba478388084395a1 Author: Dan Smith Date: Wed Oct 28 15:00:41 2020 -0400 update coda-oss commit 6a952494c985423080f1c699ac73ffa2a58c060e Merge: 026198c2 c5f2e5e0 Author: Dan Smith Date: Wed Oct 28 14:46:23 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 026198c24281fbe7a66d7b43cd596c11b526e3d3 Author: Dan Smith Date: Tue Oct 20 11:40:59 2020 -0400 update "coda-oss" with latest from "main" commit 36c2f3d818b0b266c61a2a2c97d4bf915c49e9c8 Merge: 88c1e077 0be5b5cc Author: Dan Smith Date: Tue Oct 20 11:24:38 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 88c1e077d7ae0b06333471dd96f8a6cc49b009a0 Author: Dan Smith Date: Wed Oct 14 16:32:14 2020 -0400 catch unecpted exceptions from unittests commit 8a9cb78b67949cabb19568d2d4cd31a3a75c826e Merge: 357692da 8ffdeaf1 Author: Dan Smith Date: Wed Oct 14 16:15:28 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit e62bf5b16691df1d1a5a2debd7e52c1ecacccdc9 Merge: 47207356 357692da Author: Dan Smith Date: Tue Oct 13 16:16:53 2020 -0400 Merge branch 'feature/update_coda-oss' of github.com:mdaus/nitro into feature/update_coda-oss commit 357692da168772f4b1ab2bf78e0a08da6f61862d Author: Dan Smith Date: Tue Oct 13 15:31:33 2020 -0400 latest from coda-oss to remove code-analysis warnings commit 47207356c39420aa5e4a69a1545b0825d7247503 Author: Dan Smith Date: Mon Oct 5 13:50:57 2020 -0400 update coda-oss (xerces 3.2.3) commit 428b86c4c98725aa6606536c18020dac57d136a5 Merge: 757c17cf d5df4ba2 Author: Dan Smith Date: Mon Oct 5 13:31:47 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 757c17cf61ce390e8f323806f2b322e05d9aade4 Author: Dan Smith Date: Sat Sep 12 10:16:53 2020 -0400 coda-oss doesn-t build "macos" commit 51bc91d95130f33d6b11f769e714d5d47b89bd05 Author: Dan Smith Date: Sat Sep 12 10:09:11 2020 -0400 don't compile @C++17 commit bc5ecde1497a7be5b373945b8547645660e4c0c9 Author: Dan Smith Date: Sat Sep 12 10:06:58 2020 -0400 std::auto_ptr -> std::unique_ptr commit 9f6a632719329bcd107ef37fefb27dff4cbfc04e Author: Dan Smith Date: Sat Sep 12 09:38:41 2020 -0400 build CODA-OSS @C++11 in an attempt fix MacOS failures commit 36ab9da19c5dfe4b278434d3afce55d44d0984dc Author: Dan Smith Date: Sat Sep 12 09:28:43 2020 -0400 turn off Java in an attempt fix MacOS build commit 83a9f85a34a3efea71e182eefbb099b6d1e271a5 Author: Dan Smith Date: Sat Sep 12 09:10:21 2020 -0400 use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments commit 7acc2a13a16a9fcf342d52d39d62ceb89c689f9b Author: Dan Smith Date: Wed Sep 9 17:33:33 2020 -0400 ignore more CMake output commit aa6810a6648ca76ab0ff3464be77973522408a47 Merge: 3b6459d3 033220f9 Author: Dan Smith Date: Wed Sep 9 16:51:44 2020 -0400 Merge branch 'main' into feature/update_coda-oss commit 3b6459d31b2ec85f618ec2ffd4dcd6216cd39ad4 Author: Dan Smith Date: Wed Sep 9 16:30:39 2020 -0400 auto_ptr ->unique_ptr for C++17 commit cfa37ae9cf704bfd9bfdb6975fb5eaddabe992b7 Author: Dan Smith Date: Wed Sep 9 16:14:25 2020 -0400 trying to fix compiler crash after coda-oss update commit 7df9f539da772cf7285db97461938bbd5f35ab0d Author: Dan Smith Date: Wed Sep 9 15:43:11 2020 -0400 trying again with latest from coda-oss/main commit 2a0ac909fb3fa2f1f5e4466c940b153d294898ad Author: Dan Smith Date: Wed Sep 9 14:29:17 2020 -0400 restore coda-oss from "master" (compiler crash on github.com) commit 3749af96ff6b87eff4a4646db35c4242cd94036b Author: J. Daniel Smith Date: Wed Sep 9 14:02:01 2020 -0400 Update master.yml need latest g++ commit 415ea328ecea4483af4a7626b9a3d8e1e4698c71 Author: Dan Smith Date: Wed Sep 9 13:25:21 2020 -0400 trying to get unit-tests building commit 14b5564cf8e6b49b575bd7425f01db685edaf9f6 Author: Dan Smith Date: Wed Sep 9 13:03:54 2020 -0400 trying to fix Linux build failure on github.com commit 3d99131db636a1fa0e69c8334b226f30f01e4076 Author: Dan Smith Date: Wed Sep 9 13:01:31 2020 -0400 ignore more CMake output commit f3b2cb2f57e7027c616cae3d93cd974166b99d4b Author: Dan Smith Date: Wed Sep 9 11:50:41 2020 -0400 update with latest master-C++17 from coda-oss commit 65c13fa63986105a05777aebec665c41fd21ac45 Merge: 7a046e1c 7caacb94 Author: Dan Smith Date: Wed Sep 9 11:40:10 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 7a046e1c378348a594ab14822bc13ae3b276f3b1 Merge: c7c39ea0 0f0d0540 Author: Dan Smith Date: Wed Sep 9 10:17:46 2020 -0400 Merge branch 'master' into feature/update_coda-oss commit 559177f723e0e93b60dbdb0e1ea31f750040bd44 Author: Dan Smith Date: Tue Sep 8 15:09:29 2020 -0400 std::unique_ptr overload for getImageBlocker() commit c7c39ea0b6660c92882c534ec658c401cca233df Author: Dan Smith Date: Tue Sep 8 14:31:23 2020 -0400 latest from coda-oss/develop/master-C++17 commit 38cc9af8385b5bceb7e7801a6bc2ed6841806460 Author: Dan Smith Date: Wed Sep 2 13:40:48 2020 -0400 coda-oss updates to fix compiler warnings commit bea977f89507b6da8273397a18365f7783d7d0ad Author: Dan Smith Date: Wed Sep 2 11:18:11 2020 -0400 coda-oss compiler warning fixes commit baee0823953bc3fc334dbed3829efacaad433328 Author: Dan Smith Date: Tue Sep 1 16:39:35 2020 -0400 use C++11's nullptr instead of NULL commit 3391e564c7f40caf29f538cd925717d325e75849 Author: Dan Smith Date: Tue Sep 1 16:25:51 2020 -0400 update externals/coda-oss commit 2c66f6772ffdc3fdc969dcdec3b8b80427b6e576 Author: Dan Smith Date: Wed Aug 19 17:42:15 2020 -0400 use std::chrono::stead_clock() instead of sys::RealTimeStopWatch commit 854a1a75f08239bf9b60d3a51d18c778ea2b2df7 Author: Dan Smith Date: Wed Aug 19 16:38:50 2020 -0400 change mem::SharedPtr to std::shared_ptr commit 906245593bbb79eb3db62033d170bfa99c13e558 Author: J. Daniel Smith Date: Tue Aug 4 20:46:28 2020 -0400 using instead of makes Handle simpler commit 445979da2dc19a43ec588cfa5b615ca2e93d6e07 Author: Dan Smith Date: Tue Aug 4 11:54:01 2020 -0400 use std::atomic better commit 01e98707fa79b986153a9f3a374734d0281517a3 Author: Dan Smith Date: Tue Aug 4 11:31:25 2020 -0400 Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. commit c9afaa118ae968767544fd57884d4d4ccc75e654 Author: Dan Smith Date: Mon Aug 3 18:16:10 2020 -0400 uset std::mutex instead of sys::Mutex commit e16154f381760a2195edb8e3a36d782216550d3f Author: Dan Smith Date: Mon Aug 3 17:47:16 2020 -0400 use std::atomic instead of std::mutex commit 7a50776e3e5dc89a113f75c0ad74cbfdee4feb3c Author: Dan Smith Date: Mon Aug 3 17:31:44 2020 -0400 prepare for std::mutex commit 82d495fbe81cb1e9512f538aa8829c85dce897be Author: Dan Smith Date: Mon Aug 3 17:31:30 2020 -0400 prepare for std::atomic commit d8f4a35b195af0048e5e645ef8561d8cae8b9a08 Author: Dan Smith Date: Mon Aug 3 17:10:53 2020 -0400 use std::lock_guard rather than lock()/unlock() commit f6f2b08f621e8dc7e6aeddca2ca6764bd55ff383 Author: Dan Smith Date: Mon Aug 3 16:59:40 2020 -0400 prepare for using std::mutex commit cc903b720fa6a84ca30d06eccf3caaf409d4c795 Author: Dan Smith Date: Mon Aug 3 16:33:24 2020 -0400 use std::mutex instead of sys::Mutex commit 88bf4e9066fa355d2f3097ee1c18e727d57e0f61 Author: Dan Smith Date: Mon Aug 3 16:00:57 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit a0f4955a3c419d7d667d9a334503c626329954b6 Author: Dan Smith Date: Mon Aug 3 15:53:26 2020 -0400 don't need since we're now using std::byte instead of sys::byte commit 657a51b788fecb0cef0231265ce2f501089cd9fb Author: Dan Smith Date: Mon Aug 3 15:04:20 2020 -0400 sys::byte -> std::byte commit 3f04116aaa473549bddf237ce27252b241612bbe Merge: 5e6e22b2 7c96994a Author: Dan Smith Date: Mon Dec 13 10:57:49 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 5e6e22b25c77c6b705aa7dda0258c7805b7a315a Author: Dan Smith Date: Tue Dec 7 15:49:44 2021 -0500 latest from coda-oss commit b91e345a03a6b06678ee4ff7157ef1595ee289e6 Author: Dan Smith Date: Tue Dec 7 10:56:41 2021 -0500 latest from coda-oss commit d2d1d543aa6e97f311d5b5bf52b2b8d7e7f1502b Author: Dan Smith Date: Mon Dec 6 16:39:26 2021 -0500 more "Throwable" updates from coda-oss commit 1d65ff9db316bbd0087ed4a0e15295692b0cca43 Author: Dan Smith Date: Mon Dec 6 16:06:35 2021 -0500 latest "Throwable" changes from coda-oss commit 296b2810b0ce31b02c786246354cfd87518d9a8a Author: Dan Smith Date: Mon Dec 6 15:24:15 2021 -0500 latest from coda-oss commit 2bf10dfdc7f8204e2fc7e0edc3fdb754530f629b Author: Dan Smith Date: Thu Dec 2 11:59:25 2021 -0500 forgot to implement Throwable11 commit b1c07ef92bb6bd06da9f7e379e199948e6a71e65 Author: Dan Smith Date: Thu Dec 2 11:23:25 2021 -0500 latest from coda-oss commit f5d1859f88eb12f120d71dd43c26094a16d44e7f Author: Dan Smith Date: Wed Dec 1 10:32:42 2021 -0500 TestCase.h changes break existing code commit 91d5f90b3d905e3e2c902c9416fe09cc44993b69 Merge: 8ebcb7c5 489f10d7 Author: Dan Smith Date: Tue Nov 16 16:00:56 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8ebcb7c56c0516efe35437b83f9177022930ddf3 Merge: e2033540 9461c626 Author: Dan Smith Date: Tue Nov 16 15:56:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit e2033540306d1b9acb41df2f532743c35f770b59 Author: J. Daniel Smith Date: Mon Nov 15 20:05:20 2021 -0500 size_t errors commit 2d1b7789e5ffb1cd234db6ec56905d7329b9010f Author: J. Daniel Smith Date: Mon Nov 15 19:56:53 2021 -0500 size_t errors commit 3af248e47a3d71699629367a576763a04a78ce1f Author: J. Daniel Smith Date: Mon Nov 15 19:47:46 2021 -0500 size_t errors commit 8283713767d45e8cc7bdb96ffb92c704fb5e3bb2 Author: J. Daniel Smith Date: Mon Nov 15 19:41:08 2021 -0500 size_t errors commit ec3847d2bb08c106443b34aa4fea667d29269c8b Author: J. Daniel Smith Date: Mon Nov 15 19:34:53 2021 -0500 size_t errors commit 8bbe62db1fb3ec3dc0d3bc1de96d060d928ae02c Author: J. Daniel Smith Date: Mon Nov 15 19:28:33 2021 -0500 more size_t errors commit d01651f0a60383e3ba0017fd980fa00953a1856d Author: J. Daniel Smith Date: Mon Nov 15 19:17:17 2021 -0500 size_t errors commit be9bb4e05668db96aee69a7360c45c268aa8e0cf Author: J. Daniel Smith Date: Mon Nov 15 19:01:17 2021 -0500 fixing more size_t errors commit 9c36c13d938dcb6830f3791035aae23b5b93ef4c Author: Dan Smith Date: Mon Nov 15 18:06:42 2021 -0500 more size_t errors commit 768cf78bfb9417ee8252538139552afba6e73d3b Author: Dan Smith Date: Mon Nov 15 18:00:11 2021 -0500 more size_t errors commit 074466ca1126fb261823df3bcfdb3277f41fbf47 Author: Dan Smith Date: Mon Nov 15 17:35:10 2021 -0500 more size_t errors commit 6504ec4c97dde992a03a197c9a7c110038dc2041 Author: Dan Smith Date: Mon Nov 15 17:27:47 2021 -0500 more size_t errors commit ddf03b091b79b22445e853cb49b9766834559339 Author: Dan Smith Date: Mon Nov 15 17:22:37 2021 -0500 more size_t errors commit 122e04246e5aca2138074a19396f15a514e39e79 Author: Dan Smith Date: Mon Nov 15 17:15:37 2021 -0500 more size_t errors commit 2c02ceb7279201d5ed7ff0d36986bad918f3b568 Author: Dan Smith Date: Mon Nov 15 17:08:54 2021 -0500 more size_t errors commit 78875f80b376cc57a11d24afd52082caf2f8d987 Author: Dan Smith Date: Mon Nov 15 17:04:09 2021 -0500 more size_t errors commit e5d737819147947c06570cac49a521c851661f46 Author: Dan Smith Date: Mon Nov 15 16:57:58 2021 -0500 more size_t errors commit 3c4d6bd855bdc71fdd78e106e06f42d0a1fbb3ed Author: Dan Smith Date: Mon Nov 15 16:54:54 2021 -0500 more size_t errors commit cf609dff1ad66b963e9c355a2c948ad8ffca006d Author: Dan Smith Date: Mon Nov 15 16:51:33 2021 -0500 more size_t errors commit 546c13035ed1fc0d5b460735875955a757cb29fc Author: Dan Smith Date: Mon Nov 15 16:47:45 2021 -0500 more size_t errors commit ce7355ee1ccc388074bce8fd1e6cef5e83c0cac4 Author: Dan Smith Date: Mon Nov 15 16:41:34 2021 -0500 more size_t errors commit 3d68384755bd2e9ec36cda49edd127e0e2cb50c9 Author: Dan Smith Date: Mon Nov 15 16:37:46 2021 -0500 more size_t errors commit 452764b63ead027ee1f39a3d4a289c9492b47550 Author: Dan Smith Date: Mon Nov 15 16:32:05 2021 -0500 more size_t errors commit 5ea6c0d56412d6a1e2646e7097612947502be85d Author: Dan Smith Date: Mon Nov 15 16:28:04 2021 -0500 more size_t errors commit a6ccf4da555825c9702600fc143af4e85fab2ae2 Author: Dan Smith Date: Mon Nov 15 16:24:53 2021 -0500 more size_t errors commit 0752c9527b7516ba55ed841e556fa162080e6816 Author: Dan Smith Date: Mon Nov 15 16:20:50 2021 -0500 more size_t errors commit b9b7b52441130709d356abdfe7891c62571beca1 Author: Dan Smith Date: Mon Nov 15 16:14:58 2021 -0500 more size_t errors commit d1cb44f8818537429ba8e1ad753ae83dbf4bdb0a Author: Dan Smith Date: Mon Nov 15 15:54:50 2021 -0500 more size_t errors commit c7950561b68281b83e1f53cc73ba6cbd4143f8c9 Author: Dan Smith Date: Mon Nov 15 15:48:23 2021 -0500 missed a static_cast commit e99bb694fc7363cfdcf179fe503ee7366dccb415 Author: Dan Smith Date: Mon Nov 15 15:37:12 2021 -0500 fix more coda-oss build errors commit d9786728b8b11a2e217f0f8880b5c8355de99ba0 Author: Dan Smith Date: Mon Nov 15 15:08:03 2021 -0500 trying to fix coda-oss build error commit eecd4cedb59ac7a906b863f03bb7acf548454418 Author: Dan Smith Date: Mon Nov 15 14:46:00 2021 -0500 fix coda-oss failures commit 7d2b3144b214298df2b84bc1b7d8a5b555481232 Author: Dan Smith Date: Mon Nov 15 12:54:26 2021 -0500 fix coda-oss unit-test error commit 24138ef34d8974af39e6a5f4887a4d19fccb2107 Author: Dan Smith Date: Mon Nov 15 12:29:32 2021 -0500 test (a == b) and (b == a) commit 128f2d9c34cf7813c681c40983b7e80ab03731fc Merge: b0a051eb 2e8d7cfa Author: Dan Smith Date: Mon Nov 15 12:18:46 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit b0a051eb9705be687673badcca42fcee03fd254d Merge: 8bbc7aa7 64dc4e11 Author: Dan Smith Date: Mon Nov 8 10:51:34 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 8bbc7aa7935390267809e0e9e5e1c380e6666a25 Author: J. Daniel Smith Date: Mon Nov 8 10:03:57 2021 -0500 -j 1 to prevent G++ crash commit 0af9025d696a5ce1d2e58d3158f900726f3be51e Author: Dan Smith Date: Mon Nov 8 09:20:59 2021 -0500 try to keep G++ from crashing commit 7c0d47774e13862ea6d09b4777ad90dc2727b8ea Author: Dan Smith Date: Mon Nov 8 09:19:57 2021 -0500 latest from coda-oss commit 89eaaa7a7c8e9e0a6b5ca0a92503e3aaa4e355d2 Author: Dan Smith Date: Mon Nov 8 09:19:26 2021 -0500 modules/python from coda-oss commit 47ee238544ebb8fd8743ce8ade4ba7419ae98081 Author: Dan Smith Date: Mon Nov 8 09:18:31 2021 -0500 drivers from coda-oss commit 009dca4384b17b6106f8eefa4a2c7b6bc75369f5 Author: Dan Smith Date: Mon Nov 8 09:16:52 2021 -0500 ZIP from coda-oss commit f61304a33b73f34981647c2f20029ab24824e715 Author: Dan Smith Date: Mon Nov 8 09:16:12 2021 -0500 xml.lite from coda-oss commit 9c0969b279d37d90d237c6e2b21e6101dfa986eb Author: Dan Smith Date: Mon Nov 8 09:15:04 2021 -0500 UNIQUE from coda-oss commit 3418105c7a25092aaccfb98b5a5adae12b70b151 Author: Dan Smith Date: Mon Nov 8 09:14:43 2021 -0500 sio.lite from coda-oss commit af0081c2dfca8e10e88da0544cf1096aefb44ec7 Author: Dan Smith Date: Mon Nov 8 09:14:15 2021 -0500 serialize from coda-oss commit 0191d56b40f81c2fe44d4be019522df85c0d5652 Author: Dan Smith Date: Mon Nov 8 09:13:12 2021 -0500 RE from coda-oss commit f90b279a3825cecc5966aeeac66a560e68bd79ee Author: Dan Smith Date: Mon Nov 8 09:12:46 2021 -0500 polygon from coda-oss commit 2e0a13317869ca9287b9780950222296d4af605b Author: Dan Smith Date: Mon Nov 8 09:12:23 2021 -0500 NET from coda-oss commit cff1a43ae1a724c73fabfb7ca37c3a902a8c76fc Author: Dan Smith Date: Mon Nov 8 09:11:02 2021 -0500 net.ssl from coda-oss commit a8c02363276a67db4a58cfc4ec9fbc0dea2a1ec5 Author: Dan Smith Date: Mon Nov 8 09:10:37 2021 -0500 mt/tests from coda-oss commit e68512fa4e27cc581a11897aefa357b40466c363 Author: Dan Smith Date: Mon Nov 8 09:10:12 2021 -0500 math.poly from coda-oss commit 3e76c92de216b713815b613b38ac3fb6df55e806 Author: Dan Smith Date: Mon Nov 8 09:09:38 2021 -0500 math.linear from coda-oss commit 7190497dc5d12513d9b324e2a046af3e47f5236f Author: Dan Smith Date: Mon Nov 8 09:08:57 2021 -0500 DBI from coda-oss commit 8ba511affe860c2cb6f7455e1e9c45fb2fc48f81 Author: Dan Smith Date: Mon Nov 8 09:08:23 2021 -0500 AVX from coda-oss commit 992d36b8e410c3de589d7b04a4faad121ede654a Merge: a7baf701 888ae929 Author: Dan Smith Date: Mon Nov 8 09:06:00 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit a7baf701dfe6a598c0d84ae9e4105a6aa39d7b30 Author: Dan Smith Date: Mon Nov 1 15:42:44 2021 -0400 update version numbers before cutting a new release commit cfe5fc57a29e14a1bdaea7e7c744fa4fc895bd61 Merge: b4619c5c 28d95160 Author: Dan Smith Date: Mon Nov 1 15:38:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit b4619c5c14e0b75e46cc94ff8d73a4f8b11e53d3 Author: Dan Smith Date: Mon Nov 1 14:37:38 2021 -0400 latest from coda-oss commit 9ef6117fd940d2fbe3f5a9ead1eee312a199c0b7 Author: Dan Smith Date: Mon Oct 18 11:06:08 2021 -0400 latest from coda-oss commit 9db137b805805af8d389be57c10406679caae3a5 Merge: 816fa511 dfba5e29 Author: Dan Smith Date: Mon Oct 18 10:59:25 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 816fa5114618d9b79a0015b99586f7b19537fbda Author: Dan Smith Date: Thu Oct 7 16:04:16 2021 -0400 build mem/tests commit 8625e9e6d7071e6594194dbc56756aa439a924a5 Author: Dan Smith Date: Thu Oct 7 16:00:58 2021 -0400 auto_ptr changes from coda-oss commit a7c45ae5f1a1b16c414b5937346921e0f40600a5 Merge: 487caf97 a4a1fc4f Author: Dan Smith Date: Thu Oct 7 15:56:47 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487caf9776a4bdfb3ce557575e57021863671f7c Merge: d4297bdf eef3c6ec Author: Dan Smith Date: Mon Oct 4 14:44:19 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d4297bdfafb3dca518368592fbedf2d9c723a428 Author: Dan Smith Date: Mon Oct 4 13:23:01 2021 -0400 Revert "Add NITF_VERSION" This reverts commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06. commit 39a714920aa6d87013f30fa5a234e8faaa5aaf06 Author: Dan Smith Date: Mon Oct 4 13:15:23 2021 -0400 Add NITF_VERSION commit bdd897919b78c0e8ce650bf1af34b46f41a24a10 Author: Dan Smith Date: Mon Oct 4 11:27:59 2021 -0400 build against CMake-derived coda-oss commit 8bcbce295ed3821f77549324ef9416077dc417de Author: Dan Smith Date: Fri Oct 1 12:26:14 2021 -0400 don't build CURL with nitro commit d16024a097542a747088688c2fe54a36f9c44455 Author: Dan Smith Date: Fri Oct 1 11:58:14 2021 -0400 latest from coda-oss commit 03a6f5b20850af5da6dc2eed7b93f98ad5d975f3 Merge: cf5cde0f f5f1f8ce Author: Dan Smith Date: Fri Oct 1 11:51:14 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cf5cde0f334dcfabbf73e367a25973a633250d5b Author: Dan Smith Date: Fri Sep 17 08:57:31 2021 -0400 latest from coda-oss commit b5d29569ea38e8650740fe570b498163c9566c09 Merge: 5b82b763 0db498f1 Author: Dan Smith Date: Fri Sep 17 08:47:38 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5b82b763519fc81d37216a5fa932047fd7c6d384 Author: Dan Smith Date: Wed Aug 25 13:51:55 2021 -0400 latest from coda-oss commit b21c32f7da315d690f8fb009e804a0c5fc2a0b25 Merge: ef447eba 9388d5cf Author: Dan Smith Date: Wed Aug 25 13:47:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ef447eba3cb61d66552e052da4e8cafc41f6a38b Author: Dan Smith Date: Wed Aug 25 11:50:09 2021 -0400 latest from coda-oss commit a4d7c89352101b6609c1da9d897323f9c0f413f1 Merge: efd2e8b2 81278527 Author: Dan Smith Date: Wed Aug 25 11:43:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit efd2e8b26303e4403040172f9a4d705e95834347 Merge: 82871b06 c8186387 Author: Dan Smith Date: Wed Aug 25 10:28:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 82871b061c6933a4adb31db9ac82e059cb421449 Author: Dan Smith Date: Wed Aug 25 09:58:24 2021 -0400 remove unused drivers commit b6bda69baaec7f6df017b7067f26156b6476fb78 Author: Dan Smith Date: Wed Aug 25 09:52:59 2021 -0400 latest from coda-oss commit 70867a6e0c47cbd5bcdf38e36f8bcd86fdff4221 Merge: d0a90807 dc000a51 Author: Dan Smith Date: Wed Aug 25 09:45:51 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d0a90807aa813f87fb9a5f18dbffc5057d063f4d Author: Dan Smith Date: Mon Aug 16 09:00:51 2021 -0400 latest from coda-oss commit fbd8af5f2f8287fc184e8ee84f88ac895acd8b19 Merge: 81f20046 7af555d6 Author: Dan Smith Date: Mon Aug 16 08:50:50 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 81f200464bc5f76aa2a5d3d2fa2ef6bc5976f00b Merge: acea5259 cb37a8cf Author: Dan Smith Date: Wed Aug 11 10:34:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit acea52593e91be6c3eed1d875c89860cd230004a Author: Dan Smith Date: Wed Aug 11 10:30:14 2021 -0400 latest from coda-oss commit 1a4ce530b8452f397bf7877f128ae9154ac0caad Author: Dan Smith Date: Wed Aug 11 10:18:46 2021 -0400 Squashed commit of the following: commit 85ed2efae3ebd6dae28f6ec3c929a62acd1613ce Author: Dan Smith Date: Wed Aug 11 10:04:32 2021 -0400 mem::SharedPtr -> std::shared_ptr commit 21e48011438d0d78eb36ebe58d85798c4ca1b7e3 Merge: a565fa10 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:01:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit a565fa103eb0cbba332c8ef81f7908597af01595 Merge: 39a4a874 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:11 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39a4a874a215df2917d1de6e2ca6ee1f383b19a4 Author: Dan Smith Date: Tue Jun 22 10:27:08 2021 -0400 give up on trying to do a Debug build commit 2447502a3514ab564e95f851419f9f31f83135b9 Author: Dan Smith Date: Tue Jun 22 10:08:27 2021 -0400 no Python for debug builds commit 60bedc0c25275c44085ae4b3a2109fe2f5723e3a Author: Dan Smith Date: Tue Jun 22 09:52:38 2021 -0400 spaces instead of tabs commit 1b4df959dfb99d1cad5a1502a02172e0097b38b9 Author: Dan Smith Date: Tue Jun 22 09:50:37 2021 -0400 do a "Debug" CMAKE build too commit af432c68e526b442ceb8037e4795c60e1445d0a2 Author: Dan Smith Date: Tue Jun 22 09:46:36 2021 -0400 Squashed commit of the following: commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5351b804c0cd99751997b7cab627b81fb8c9f296 Author: Dan Smith Date: Mon Jun 21 10:20:18 2021 -0400 Squashed commit of the following: commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebf45b1b971a2a911984f8d0c4add239fcade245 Author: Dan Smith Date: Thu Jun 17 11:54:46 2021 -0400 nitf::byte commit d785c54ff2c3242d41c24f38b9a599233443083d Author: Dan Smith Date: Thu Jun 17 09:48:49 2021 -0400 getCornersAsLatLons() should be w/o "const" commit 81ad2dc45bf2e16200d8fbbe1589cdbb4b558112 Merge: e6978bf2 7bb82996 Author: Dan Smith Date: Thu Jun 17 09:47:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e6978bf27a161ac278426271f4a8098cdd5686ab Merge: c51be8f8 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:41:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit c51be8f8020977907b9a6061ff7f0a53d92b51a7 Author: Dan Smith Date: Wed Jun 16 17:27:12 2021 -0400 "noexcept(false)" is a breaking change commit c82ba4e0a5cfc3c066aa3e031cb5f703e080b97b Author: Dan Smith Date: Wed Jun 16 17:01:59 2021 -0400 another "noexcept" fix commit 25c5b47d639210ff724daf91694968f3b8ea10ce Author: Dan Smith Date: Wed Jun 16 15:03:20 2021 -0400 "noexcept" can break derived classes commit ec7e9b0c45cd19da5a2d0232649f11deb2b1911b Author: Dan Smith Date: Wed Jun 16 14:23:50 2021 -0400 we're using gsl::span commit c5d4ba86cd999b071681efb3477553bc3979c6f9 Author: Dan Smith Date: Wed Jun 16 14:13:32 2021 -0400 mark throwing constructors with noexcept(false) commit 8cbc74a5fc7f73313b9637b6d051a5181faf67bb Author: Dan Smith Date: Wed Jun 16 13:53:02 2021 -0400 more "noexcept" cleanup commit f2b12f40b1bfbdbc8fe5e2149c4a1fd8946fbec3 Author: Dan Smith Date: Wed Jun 16 13:41:06 2021 -0400 cleanup "noexcept" a little bit commit c8d6126f3af0cf7a412f6a6505ec9625c368854f Author: Dan Smith Date: Wed Jun 16 13:19:08 2021 -0400 remove array -> pointer decay commit 2075e2e412456aaa5f2494474405477a33113b63 Author: Dan Smith Date: Wed Jun 16 12:53:29 2021 -0400 mark functions "noexcept" as indicated by code-analysis commit b4652e9370c34c0841804804e2ed6029858f6949 Author: Dan Smith Date: Wed Jun 16 12:23:37 2021 -0400 Revert "obey the "rule of 5."" This reverts commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa. commit 4f2ef7101b70ece93de0f833fd2b1ae14751dac7 Author: Dan Smith Date: Wed Jun 16 11:56:47 2021 -0400 TRE_setField() now takes "const" NITF_DATA* commit ef0afc27b1efa035f0ca091b7fae5b1f8d4dadfa Author: Dan Smith Date: Wed Jun 16 11:26:06 2021 -0400 obey the "rule of 5." commit d008bf401676f8ca88ad9ce5dbe94e39423b904c Author: Dan Smith Date: Tue Jun 15 08:30:28 2021 -0400 fix new code-analysis diagnostics commit 46ba5d78fe3316d180ec48d9ca5d45e93c18e69a Merge: e2c3a7a3 c3dc8220 Author: Dan Smith Date: Mon Jun 14 09:16:41 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit e2c3a7a3b23273b818431c748932dddd70da231b Merge: b6014390 a6cec9df Author: Dan Smith Date: Thu May 27 14:39:23 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b6014390c83702b4e8e566565d5eb7168c1638b0 Merge: 7e45fb9f 73995168 Author: Dan Smith Date: Thu May 27 13:24:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e45fb9f6f9710c38ddddb8ebe32fd6b8d177437 Merge: 66d7e894 05afcb99 Author: Dan Smith Date: Thu May 27 13:04:45 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 66d7e8942cc01d1b257da72087e6aa5719d3dcf3 Merge: 88e6a046 f4b80a31 Author: Dan Smith Date: Thu May 27 13:04:33 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 88e6a046d10e805ca478878224d0a57084e91941 Author: Dan Smith Date: Wed May 26 10:59:56 2021 -0400 cleanup for VS2019 16.10 commit cc27ac156d7ca3927cd78bd8e3d2498e4dc54c40 Author: Dan Smith Date: Tue May 25 16:46:44 2021 -0400 C++20 doesn't like our use of gsl::make_span commit e7a7ed5f7477677850faa1d8558d1a4b37b9a3ce Merge: dd12167d a2352f25 Author: Dan Smith Date: Mon May 24 16:04:20 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dd12167d29a3f8aae2968c8fb5ebce6d52a83de8 Merge: 994faf7d 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 994faf7dc516700a8213087a9a3696799190ce58 Merge: b8025652 4f1b857a Author: Dan Smith Date: Mon May 24 15:17:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b8025652318622158b0cb70f6080b1e32234cc44 Merge: b110d9b9 2a57741c Author: Dan Smith Date: Mon May 24 15:12:10 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit b110d9b9d7f5d45615ebb5301aa69671a050fe68 Merge: 93160fd8 d99322d3 Author: Dan Smith Date: Mon May 24 14:39:15 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 93160fd8ea26e3b84a7062e1e09c6aed8eddb7e6 Merge: 39e283bc d3fab714 Author: Dan Smith Date: Mon May 24 14:39:07 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 39e283bc26228ce4c6ab42751c9bba6814c9c4a4 Author: Dan Smith Date: Wed May 19 15:28:21 2021 -0400 reduce use of .c_str() commit e0bc08bef56bfea53b93ee665032d85e5e30ab77 Author: Dan Smith Date: Wed May 19 14:52:18 2021 -0400 reduce try/catch code duplication with a few lambdas commit 728eb1e2122f2b2646656e78690b3ebf532ecc55 Author: Dan Smith Date: Wed May 19 14:52:01 2021 -0400 utility routines to initialize nrt_Error from other things commit 13e80d90732eb997d5783967a9bf0fd802db2824 Merge: 3a1c7373 9aee934e Author: Dan Smith Date: Mon May 17 10:33:48 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3a1c7373b1063eefab07ca2b94339971c6f01303 Author: Dan Smith Date: Mon May 17 09:34:50 2021 -0400 changes from six to reduce code-analysis diagnostics commit 1c903c9ea6e4ee722de37ebc75b0d5c92a66be6a Merge: 14be4581 7be6c13b Author: Dan Smith Date: Mon May 17 09:29:58 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 14be458157cb70d3094f5a460835656370236906 Merge: 8e8f5bf9 d0117954 Author: Dan Smith Date: Tue May 4 14:44:56 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 8e8f5bf9c77189eda9de9a5fabe2e8a879e4dda9 Merge: 158ee6ea 4e806f4e Author: Dan Smith Date: Tue May 4 14:17:42 2021 -0400 Merge branch 'feature/shared-library' into feature/remove_compiler_warnings commit 158ee6ea9759a1a1d556b26350d6a88381abdb27 Merge: 758f5977 a16f72b0 Author: Dan Smith Date: Tue May 4 14:14:20 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 4e806f4e55ef61dc5542ed75476705cf10f5ece5 Author: Dan Smith Date: Mon May 3 14:01:10 2021 -0400 export more classes; but sure nitf.hpp gets everything commit 903e1b8b34dcba14e15b87d657838d78f27f1d78 Author: Dan Smith Date: Mon May 3 11:27:44 2021 -0400 #pragma-away 4251) // '...' : class '...' needs to have dll-interface to be used by clients of struct '...' commit 32f5529a8bb0364a0168273709d7fdeef0530991 Merge: 02112ced a16f72b0 Author: Dan Smith Date: Sat May 1 14:44:11 2021 -0400 Merge branch 'master' into feature/shared-library commit 02112ced47b98f8eaa143e0fd6cf4dc167ee8821 Author: Dan Smith Date: Sat May 1 14:06:35 2021 -0400 building mt/tests crashes GCC on github commit 7c8b52df9c06ad03d4a2838b8cd862d4524c5eb6 Author: Dan Smith Date: Sat May 1 13:01:10 2021 -0400 don't need a separate project for the DLL anymore commit 94fc53280464472cd70620b74340e4a598cb2452 Author: Dan Smith Date: Sat May 1 12:55:04 2021 -0400 make it easier for clients to consume nitf-c++ as a DLL commit a1ed1ce954fffd848e0856c2305dbd86cc4c5b44 Author: Dan Smith Date: Wed Apr 28 17:35:44 2021 -0400 wrap nitf_ImageIO_getMaskInfo() for unit-tests commit 2636b229454f5ae0914dd02e9387e7abf07eda0d Author: Dan Smith Date: Wed Apr 28 17:02:50 2021 -0400 test_tre_read needs C, not C++ routines commit f6328bcd61452a3625089220f352e870c075c4f3 Author: Dan Smith Date: Wed Apr 28 16:08:43 2021 -0400 more wrapping of C APIs in C++ for unit-tests commit de329e3065e5f51c4c6eb0420d74067b7fa20d21 Author: Dan Smith Date: Wed Apr 28 15:55:31 2021 -0400 more C APIs exposed through C++ for unit-testing commit f552322088bd2f22e3045a495850bd96c25ccdfb Author: Dan Smith Date: Wed Apr 28 15:31:48 2021 -0400 "Test" project should reference nitf-c, not nitf-c++ commit 66ee139887cb6a7c7764a80097caea46e373f657 Author: Dan Smith Date: Wed Apr 28 15:31:15 2021 -0400 allow unit-tests to use C++ API rather than direct calls to C commit 049b9acd7e677f7f8c42301b0ee84f6185166171 Author: Dan Smith Date: Wed Apr 28 15:10:22 2021 -0400 more tweaks for building as a DLL commit 1dc4103157c9319885ac81c30efe65659e254374 Author: Dan Smith Date: Wed Apr 28 14:04:16 2021 -0400 finish separating unit-tests into C and C++ commit d6541484f500c757ccdcaa9cfd091c1040ec8069 Author: Dan Smith Date: Wed Apr 28 13:45:50 2021 -0400 begin work on separating C and C++ unit-tests commit 1754c79b68730c81c81da84be67c439c6bb062c5 Author: Dan Smith Date: Wed Apr 28 13:05:46 2021 -0400 tweak Field::get() commit c654395457d1557f83f6b1f29e50a77bc8c2d56e Author: Dan Smith Date: Wed Apr 28 12:46:01 2021 -0400 add new files to CMakeLists.txt commit cf1eca1e8cde1af33fe7c7c9438d1a4780ce3947 Author: Dan Smith Date: Wed Apr 28 12:23:36 2021 -0400 need to force-resolve the _destruct() functions commit bb61a5762a38ab4423b2bcb7ec64f013312ed496 Author: Dan Smith Date: Wed Apr 28 10:34:58 2021 -0400 set path to CODA-OSS libraries commit 1232b19a8fe95e5f4a288bf27eab4afe4cd6fe33 Author: Dan Smith Date: Wed Apr 28 10:07:40 2021 -0400 _LIB and _WINDLL are part of Visual Studio, not MSVC commit b05bd737c9a9d5e2522a5ae14917b3b955708d53 Author: Dan Smith Date: Tue Apr 27 18:01:47 2021 -0400 remove reference to nitf-c from "Test" project commit 44a705fe7d30ab551e2bb5ef3ae9cd372874512f Author: Dan Smith Date: Tue Apr 27 17:05:01 2021 -0400 use NITRO_NITFCPP_API to export classes/functions commit 6465b9c5b7dada37e8c48e0f3ab5eedd160a82b0 Author: Dan Smith Date: Tue Apr 27 15:36:19 2021 -0400 Create nitf-c++-dll.vcxproj commit 61bad42f86669c393c318f81a9f0a9db8fa8c59a Author: Dan Smith Date: Tue Apr 27 15:07:05 2021 -0400 infrastructure for exporting symbols from nitf-c++ commit 758f5977222cb1bc833474198eca6e773725dedc Author: Dan Smith Date: Tue Apr 27 11:23:34 2021 -0400 adjust CMakeLists.txt to turn on more compiler warnings commit f5d9c21f568707cd348411bd31bbb405800ca974 Author: Dan Smith Date: Mon Apr 26 14:32:29 2021 -0400 avoid avoid array -> pointer decay in nitf::Error commit b682e55713cfedcaae0cafbb52404c666c989aab Merge: 02f700e4 35c5f4ad Author: Dan Smith Date: Mon Apr 26 14:29:51 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 02f700e46abebd7a4afcea343696efd71cb4b345 Author: Dan Smith Date: Mon Apr 26 11:22:52 2021 -0400 ubuntu-latest commit 3e6fed0eea70245297d2d8511fbfb4ef7c5b5111 Merge: 40af41a9 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:19:40 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 40af41a9444cc1bc066080a4b160a26e18ac6fed Author: Dan Smith Date: Tue Apr 20 10:07:18 2021 -0400 build with fewer compiler warnings/code-analysis diagnostics commit 9d4d36651dc570bc45b747b43087e9de675deb15 Merge: cfe591ab 6e6819db Author: Dan Smith Date: Tue Apr 20 09:57:19 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit cfe591ab71072eb672c575f2d1de176ba06cdff9 Author: Dan Smith Date: Mon Apr 19 11:27:40 2021 -0400 #includes for std::make_unique commit c150cc2867f35ef63913885e8860826c829f0d53 Author: Dan Smith Date: Mon Apr 19 11:12:03 2021 -0400 remove more explicit new and delete commit e3857e573329d9c00889afffc7902d67eaa0f386 Author: Dan Smith Date: Mon Apr 19 10:02:30 2021 -0400 reduce explicit use of new and delete commit 4c56d3aba791491e8fe6d183afc7f7892fb8eb08 Merge: c7b29b1d 7af8169b Author: Dan Smith Date: Sat Apr 17 16:37:07 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c7b29b1d0469c7d63ed78e5c73728d3ee6dda168 Author: Dan Smith Date: Sat Apr 17 16:29:32 2021 -0400 turn on more code-analysis diagnostics commit f8def9cbfdf0d9ada88e91f0271932b3bbc1c4a2 Merge: bcb6bfc4 4b0062b7 Author: Dan Smith Date: Sat Apr 17 15:53:32 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit bcb6bfc49565a6765dc7c9eb5d90df108ea0f411 Merge: 6f4befc1 4aa689b9 Author: Dan Smith Date: Sat Apr 17 15:45:28 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 6f4befc10ffdf12547f5c2eed0819f2a1c9d263e Author: Dan Smith Date: Sat Apr 17 15:44:53 2021 -0400 explicitly =delete copy/assignment commit e381bc348de5c3dfe1a472ad48b61f44cfccf546 Merge: 1a7b623b fdc62abd Author: Dan Smith Date: Sat Apr 17 15:19:56 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 1a7b623b56a7fcd4a29ca14e8547389c56ae843f Merge: 5d07dd64 014917fe Author: Dan Smith Date: Sat Apr 17 15:01:04 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 5d07dd64afc234e8aec83b1086fe8deb51a12084 Merge: 012b9b4f cd50f937 Author: Dan Smith Date: Sat Apr 17 14:47:16 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 012b9b4f3db23a91b4f6d1b467d21fd4f31e1f71 Author: Dan Smith Date: Sat Apr 17 14:47:07 2021 -0400 Update coda-oss.hpp commit 81b99e75295e4beed74729dddd61b78d1d68ec4d Author: Dan Smith Date: Sat Apr 17 14:45:42 2021 -0400 PlatformToolset() is no longer used commit 945e2a284c7a306fb87f8113f18242cc592bbdb8 Merge: b96c0e9c 9532c538 Author: Dan Smith Date: Sat Apr 17 14:19:53 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit b96c0e9cfad6a0e9142240cb0a2807edf6ce0cd1 Author: Dan Smith Date: Sat Apr 17 14:19:22 2021 -0400 more code-analysis cleanup commit f8da5e4924fec7bb25933f0db6b0fc63b06b3694 Author: Dan Smith Date: Sat Apr 17 13:40:36 2021 -0400 no import/logging.h commit fc81a9de7a0c9629f577f6e233e1e1f8ff29cc51 Merge: 7e54d7e9 32609f76 Author: Dan Smith Date: Sat Apr 17 13:07:23 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 7e54d7e9221008d883c2da195cf2d3f321f76442 Author: Dan Smith Date: Mon Apr 12 14:04:01 2021 -0400 wrap nitf_Error to reduce code-analysis diagnostics commit 18c18a206f95fb078f683c06c71504321cc470a4 Author: Dan Smith Date: Mon Apr 12 13:33:50 2021 -0400 adjust the code-analysis diagnostics that are disabled commit e136900ae637eb0a2d9cb282eb03875f32eaad82 Merge: dddbb27b 1ff904eb Author: Dan Smith Date: Mon Apr 12 13:32:48 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit dddbb27b70364ae737bef67f84064ae18409943c Merge: 8b3483cf 20f4e614 Author: Dan Smith Date: Mon Apr 12 12:43:06 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit 8b3483cfe42899487735297a85e83dfa23ea7eff Author: Dan Smith Date: Mon Apr 12 12:39:12 2021 -0400 slam in changes from "master" commit 6ed99321b6e3a3ea70efa9479b6f291c8bb24b1a Merge: 316cf602 298536f4 Author: Dan Smith Date: Mon Apr 12 12:32:05 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 316cf602098d8a486977897a3d032bcd53accf21 Author: Dan Smith Date: Mon Apr 12 12:31:35 2021 -0400 PlatformToolset() isn't used commit 291b497a910922fd084286b042786aa4d339d055 Author: Dan Smith Date: Mon Apr 5 16:09:21 2021 -0400 trying ubuntu-18.04 commit 0669d206c30c7da14f942ae3df25810dfefd300f Author: Dan Smith Date: Mon Apr 5 15:50:26 2021 -0400 try explicitly setting ubuntu versoin commit 0458685824304bd4a6e02758f981556890db9048 Author: Dan Smith Date: Mon Apr 5 14:18:13 2021 -0400 still trying to figure out broken GitHub build commit 024814b37fd3a24597e42c7b18087fcc6efa31e3 Author: Dan Smith Date: Mon Apr 5 13:04:02 2021 -0400 does this build on GitHub ... ? commit 6fbc755ff991e6693c880fe64ddfc1a7ae470044 Author: Dan Smith Date: Mon Apr 5 12:42:59 2021 -0400 trying to figure out what broke GitHub build commit 5ec4a357e2bf260855ed7497fc7b04700b41829e Merge: 24e59602 1b6cfe09 Author: Dan Smith Date: Wed Aug 11 10:18:33 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 24e596027dd7d10acded64ed1f269a29903264d4 Author: Dan Smith Date: Mon Aug 2 11:16:14 2021 -0400 latest from coda-oss commit 6fe93eb028a80a2305ee63a1910edeaf1b29d7d4 Merge: ebe39048 2229fbde Author: Dan Smith Date: Mon Aug 2 11:09:57 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit ebe390482453f0136f8d980016e89046064ff9b4 Author: Dan Smith Date: Thu Jul 29 10:59:50 2021 -0400 latest from coda-oss commit 836ba7dfe5c7237827bcfe8f39dd2d2c6b7c2e54 Merge: c4a794b8 835da56f Author: Dan Smith Date: Thu Jul 29 10:53:34 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c4a794b83dce36c35f526c329c04c98e7edcfbe6 Author: Dan Smith Date: Tue Jun 22 09:46:11 2021 -0400 latest from coda-oss commit dac28609f60952e606a6fad5f5b5888a17b710ee Author: Dan Smith Date: Mon Jun 21 10:19:56 2021 -0400 fix RowCol::cast() again :-( commit b6af85633fd3b16205ae5442ab95cb247e22c25f Author: Dan Smith Date: Mon Jun 21 10:11:07 2021 -0400 "final" breaks SWIG; hide gsl::narrow_cast commit eec5c064243b1e4186d03b8da2318aa5a13f709b Merge: cc85657c 7bb82996 Author: Dan Smith Date: Mon Jun 21 10:05:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit cc85657c0b3c710befaea1064bfaf39595d7a039 Author: Dan Smith Date: Thu Jun 17 08:56:52 2021 -0400 no mt/tests commit 8de6f1a3e3b288dca60a024a539452f03b412014 Author: Dan Smith Date: Thu Jun 17 08:40:26 2021 -0400 latest from coda-oss commit 3a668844f4908838197831958e9eb2374a4664d7 Merge: 639694bf 98e6bcf5 Author: Dan Smith Date: Thu Jun 17 08:36:30 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 639694bfcfd465d658489e277d41ff8a068d5c1f Author: Dan Smith Date: Thu Jun 10 15:47:12 2021 -0400 latest updates from coda-oss commit 95fe355382fb95ec01afac6153283b73c069076a Merge: 73995168 ffd5aa85 Author: Dan Smith Date: Thu Jun 10 15:39:35 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 73995168d5abb6a020ff01425adb8837c24c588b Author: Dan Smith Date: Thu May 27 13:23:48 2021 -0400 Delete Span_.h commit 05afcb9977aa60f57cd94ffd485c20cdc181f173 Author: Dan Smith Date: Thu May 27 13:04:15 2021 -0400 latest from coda-oss commit a2352f253bd5f7e973fb7dc5f11b95a21b7179d7 Merge: 4f1b857a 4ddaf23d Author: Dan Smith Date: Mon May 24 15:26:56 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 4f1b857ab3b391a84532c6e3d139beb64e2e346a Merge: d99322d3 2a57741c Author: Dan Smith Date: Mon May 24 15:16:44 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d99322d3937cef7443e9c91ef84dd52b8eb86102 Author: Dan Smith Date: Mon May 24 14:38:47 2021 -0400 changes from coda-oss to reduce code-analysis diagnostics commit ade02fa44d395889659278da9cb0448d1b7135fe Author: Dan Smith Date: Mon May 17 11:45:28 2021 -0400 don't "compress" build output; everyone should build from source commit 1b4fa40e013b0833838c330698ad6dd89595e415 Author: Dan Smith Date: Mon May 17 11:20:35 2021 -0400 latest from "coda-oss" commit 16633d49e15fc2d5c1394ff399a925d81825adf8 Merge: c5c549f4 8806960a Author: Dan Smith Date: Mon May 17 11:10:59 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit c5c549f4b50adf4caed5c88dbf11005a2f701cc0 Author: Dan Smith Date: Tue May 4 14:09:33 2021 -0400 latest from coda-oss commit 3fd3b4cb04cf54eae01c4e4b5f9555a091cb87a3 Merge: 0902d4d3 a16f72b0 Author: Dan Smith Date: Tue May 4 14:01:12 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 0902d4d39cec7c24f4110be82d1eba2cb95c565d Merge: 6e6819db 273c39e8 Author: Dan Smith Date: Mon Apr 26 11:20:00 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 6e6819dbd32ffb7b860ebf83b99b9b9674d72743 Author: Dan Smith Date: Tue Apr 20 09:57:00 2021 -0400 latest from coda-oss commit 7af8169bc3a9b422c0bf0bf9187e8b6604a462e8 Author: Dan Smith Date: Sat Apr 17 16:36:48 2021 -0400 implement ScopedArray with std::unique_ptr<> commit f5a69e892171f2bad6a1aaa16586517125a46db7 Author: Dan Smith Date: Sat Apr 17 16:32:57 2021 -0400 latest from coda-oss commit 4b0062b73474bff299b45a2419b19625ddc35e56 Author: Dan Smith Date: Sat Apr 17 15:52:21 2021 -0400 pragmas only for MSVC commit 4aa689b93c2f8d654ae783911dbaa241324f034a Author: Dan Smith Date: Sat Apr 17 15:45:13 2021 -0400 latest from coda-oss commit fdc62abd35966d8113b0eef48a2c0b72abb8e58a Author: Dan Smith Date: Sat Apr 17 15:19:40 2021 -0400 more changes for =default from coda-oss commit 014917feef86263980614670a40e77e76963e90a Author: Dan Smith Date: Sat Apr 17 15:00:45 2021 -0400 =default from coda-oss commit cd50f937b347227c1c3f9798a67fb6f8dbe7d611 Author: Dan Smith Date: Sat Apr 17 14:46:07 2021 -0400 more changes from coda-oss commit 9532c53866759861d76b2206cbb330eeed761996 Author: Dan Smith Date: Sat Apr 17 14:19:43 2021 -0400 update coda-oss to get code-analysis changes commit 32609f761a5483f923d205f5e5e586ac8aff825c Author: Dan Smith Date: Sat Apr 17 13:06:48 2021 -0400 update coda-oss to reduce compiler warnings commit 1ff904eb9f0b7c77898a4150d58669c484d45233 Author: Dan Smith Date: Mon Apr 12 13:32:36 2021 -0400 remove more code-analysis diagnostics commit 20f4e6142857ce40985b78e0f1439e62b4fc3357 Author: Dan Smith Date: Mon Apr 12 12:42:51 2021 -0400 update coda-oss to remove compiler warnings commit f491097a4488f5bbe7ff0654453124d4002d3a77 Merge: 84b3bf57 298536f4 Author: Dan Smith Date: Mon Apr 12 12:40:28 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 84b3bf57923367a513f9c55a36253582b8697bee Author: Dan Smith Date: Tue Apr 6 11:22:51 2021 -0400 changes to python wrappers commit 4fc6edb3f9ca67026219161f9749e7984ddde995 Author: Dan Smith Date: Tue Apr 6 10:48:17 2021 -0400 remove unused coda-oss stuff commit 3fb729b5a0b951a701ff62187310cd771238fe89 Author: Dan Smith Date: Mon Apr 5 12:20:21 2021 -0400 Revert "Revert "latest from coda-oss"" This reverts commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d. commit ee91a36f81675ccd8d7b4e46e6204bf8cfc8acb8 Author: Dan Smith Date: Mon Apr 5 11:46:33 2021 -0400 add back -Wall ... ? commit 967ce07bbcbce8ffb6488e807848efcdb2659740 Author: Dan Smith Date: Mon Apr 5 10:36:53 2021 -0400 remove -Wall as that might be causing GitHub build break commit eb9d130ea80ba8d178a03a74e1e7784b6f62720d Merge: 34c947e5 c1def5d0 Author: Dan Smith Date: Mon Apr 5 09:52:12 2021 -0400 Merge branch 'develop/update_coda-oss' into feature/remove_compiler_warnings commit c1def5d0ba9e11a2657134ebd47709b703707a19 Merge: 703f3ec2 edb9317d Author: Dan Smith Date: Mon Apr 5 09:36:10 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 34c947e57db3fe68d0faca505f7bfe37fbb27c62 Merge: 5f4496b3 edb9317d Author: Dan Smith Date: Mon Apr 5 09:35:37 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 703f3ec21bd8605ae4a8985ec095a04cfce12a4d Author: Dan Smith Date: Sat Apr 3 12:21:56 2021 -0400 Revert "latest from coda-oss" This reverts commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14. commit c8f8a8512873adff9786d4f29600fc10fa31d44b Author: Dan Smith Date: Sat Apr 3 12:10:25 2021 -0400 Java and MATLAB bindings are no longer built. commit f7cb3f40d8c97e8086e967d9c09153fc6b988f14 Author: Dan Smith Date: Sat Apr 3 11:10:04 2021 -0400 latest from coda-oss commit 7b7399235f393c6613345856622ede219bcfe260 Merge: daf11b09 2748224b Author: Dan Smith Date: Sat Apr 3 10:33:06 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 5f4496b345aedd3d76b09398ad4fa360ac6f53c3 Merge: 48bd96e8 2748224b Author: Dan Smith Date: Sat Apr 3 10:32:49 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 48bd96e8c0a26dedef478e9f48ed366116550523 Author: Dan Smith Date: Tue Mar 30 13:57:48 2021 -0400 trying to fix remaining formatting diagnostics commit a507d510496731502d1d55439de96c7f38d66a61 Author: Dan Smith Date: Tue Mar 30 13:38:25 2021 -0400 no duplicate "const" commit b92f309f8294dfc6f1e3b94d9053d768dbe23929 Author: Dan Smith Date: Tue Mar 30 13:35:29 2021 -0400 and still more code-analysis diagnostics commit e8540999c3207f5630436c551d3318da2f7b6881 Author: Dan Smith Date: Tue Mar 30 13:18:18 2021 -0400 chain constructors to reduce duplicated code commit d5121db763ec07e6be65967d7010bedf530fe8ed Author: Dan Smith Date: Tue Mar 30 13:02:26 2021 -0400 fix more CodeQL diagnostics commit 85b00538479f8b89991361c290b0879c5a911d5c Author: Dan Smith Date: Tue Mar 30 12:38:22 2021 -0400 fix typo commit 36672a4702a9108323ef4c8e0bcc41526c38ad3e Author: Dan Smith Date: Tue Mar 30 12:26:30 2021 -0400 remove some CodeQL diagnostics commit ad4bf2bd51b7dc46a23f04a96a87e4515dc08330 Merge: 3460f50b a2b3a12d Author: Dan Smith Date: Tue Mar 30 11:26:24 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3460f50b205e668d32c59be613e7806b22e1688d Author: Dan Smith Date: Tue Mar 30 11:05:03 2021 -0400 more code-analysis cleanup commit 759b607064d15ac5b94a7a82bcf0731baf916902 Author: Dan Smith Date: Tue Mar 30 10:48:11 2021 -0400 remove more compiler warnings and code-analysis diagnostics commit 5bc464a7b6f957225da8a24a1b751dac081364db Author: Dan Smith Date: Tue Mar 30 10:03:18 2021 -0400 remove code-analysis diagnostic about NULL pointer commit ab446c910c9c9a4e4e4e64f50e9082bfc2de81cf Author: Dan Smith Date: Tue Mar 30 09:32:56 2021 -0400 removing remaining "Arithmetic overflow" code-analysis diagnostics commit 80c1697e6aa67712a2c8905e15596093b92dddbe Author: Dan Smith Date: Mon Mar 29 13:43:20 2021 -0400 fix more "Arithmetic overflow" code-analysis warnings commit bd8999b433fb7cbe8197e5ca489968acd657ff22 Author: Dan Smith Date: Mon Mar 29 12:53:42 2021 -0400 cleanup more "Arithmetic overflow" code-analysis warnings commit 8245ce2f615d450007acb795c6e0cd4daed4ab8c Author: Dan Smith Date: Mon Mar 29 12:16:37 2021 -0400 stay at /W3 for now commit 3239b715181fb5b892288b6ed4a936b083b01e5e Author: Dan Smith Date: Mon Mar 29 11:54:24 2021 -0400 crank-up compiler warnings commit b0550acd8559b3ae7e0ecbc337cebb5332573fd3 Author: Dan Smith Date: Mon Mar 29 10:21:38 2021 -0400 fix some code-analysis warnings about "arithmetic overflow." commit ff24488cb04ae5971d58393afa6d3b46e99a2a7d Merge: 487e82b3 c68cd17d Author: Dan Smith Date: Mon Mar 29 08:45:50 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit daf11b09b5b0ba7b37ccd421b74cc3fd5881b21d Author: Dan Smith Date: Mon Mar 29 08:19:40 2021 -0400 latest from coda-oss commit b2ee4c0cc432b2232d7f42ea6bad905a3dcfef4c Merge: d4696577 bb063492 Author: Dan Smith Date: Mon Mar 29 08:14:39 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit d46965774fd6eaa310b85174583bd58ff266a35a Author: Dan Smith Date: Sat Mar 27 13:45:49 2021 -0400 latest from coda-oss commit 875900215db824095382fae12c0dca33abb71c28 Merge: eae673f6 fa20f42e Author: Dan Smith Date: Sat Mar 27 13:44:22 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit eae673f69ebd6218cefe827b6604c1685701d309 Author: Dan Smith Date: Wed Mar 24 15:18:27 2021 -0400 tweak std:: handling from coda-oss commit fe3129e92dedaacbe4df07c79f67e001c303590d Author: Dan Smith Date: Wed Mar 24 15:03:22 2021 -0400 std:: changes from coda-oss commit c8b1b7f9bb780660d708ad2767662d58b8606159 Author: Dan Smith Date: Wed Mar 24 12:33:29 2021 -0400 and still more coda-oss updates commit e4b655cea03e4273cefae72d1a1e75649e5374bf Author: Dan Smith Date: Wed Mar 24 11:12:46 2021 -0400 another update from coda-oss commit 32e14a957c70770488a28207862cb4dee74124e6 Author: Dan Smith Date: Wed Mar 24 08:58:28 2021 -0400 latest from coda-oss commit d64174882756c04f7b0e464f5f89005125209f08 Merge: e38e05bb c80e163e Author: Dan Smith Date: Wed Mar 24 08:53:26 2021 -0400 Merge branch 'master' into develop/update_coda-oss commit 487e82b38fe82836e1ee7517265b82dbf2b1f20f Author: Dan Smith Date: Tue Mar 23 12:21:20 2021 -0400 avoid reinterpret_cast commit d65c4ec5bbcc4de4402357a8a46dd3b7adb5c524 Author: Dan Smith Date: Tue Mar 23 12:08:03 2021 -0400 fix some code-analysis diagnostics commit 2f66ba77bbbcf612b3402bcdfcf355e03ba38235 Author: Dan Smith Date: Tue Mar 23 09:49:40 2021 -0400 more NULL checks, especially around strdup() commit 607d4be29d214ed4343d5e6d70afdc914df0917d Author: Dan Smith Date: Mon Mar 22 18:13:14 2021 -0400 nitf_FieldType is no longer a "scoped" enum commit fd708b526f472a5b4003208c111510f7735b2046 Merge: 3680f7a8 dfad79ef Author: Dan Smith Date: Sat Mar 20 10:35:45 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3680f7a84dcf329eca82dc3265ada28f538d5340 Merge: 9fe0f742 e40a0b3f Author: Dan Smith Date: Tue Mar 16 13:53:44 2021 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 9fe0f7420c90bc7acee08d7d287bcd188603895a Author: Dan Smith Date: Wed Mar 10 08:59:26 2021 -0500 trying out -fsanitize=address commit 8481ebc9e1b7893dbc349dcf16416d60bd36a586 Merge: 5f123f15 7c5dbed7 Author: Dan Smith Date: Wed Mar 10 08:17:04 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit e38e05bb29a9065d6faf380ec1b6453ccd7afd92 Merge: 4eb99576 612a5588 Author: Dan Smith Date: Mon Mar 8 10:31:31 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4eb99576b3bd6be185af33d5883439024a5271f3 Author: Dan Smith Date: Mon Mar 8 10:04:58 2021 -0500 missing "build" and "cmake" directories commit f99a8e343c57588404cb0d281f6dd9203bd07bc1 Author: Dan Smith Date: Mon Mar 8 09:49:32 2021 -0500 rename "coda-oss" commit c36f316d06c9d5772ce041843cd5b1f8247df27f Author: Dan Smith Date: Mon Mar 8 09:46:44 2021 -0500 restore coda-oss commit 3a94197a816b7b3f8524699ec5dcf0cdbf04ec70 Author: Dan Smith Date: Mon Mar 8 09:39:32 2021 -0500 do rename (again) commit 2b1c237d26891e6b0b07376f8783421a5765c34a Merge: 03ff84a4 c1463976 Author: Dan Smith Date: Mon Mar 8 09:38:23 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 03ff84a4bbac7eac404204b18e63a1ccff00e204 Author: Dan Smith Date: Mon Mar 8 09:12:19 2021 -0500 missing "build" and "cmake" files commit 25eb45608989519c456312e115d69b02114134b9 Author: Dan Smith Date: Mon Mar 8 08:50:12 2021 -0500 get red of the version number (for now); we've been w/o for a very long time commit 5f123f15be291eab914b754425a6d4734bf6a77f Author: Dan Smith Date: Sat Mar 6 13:58:49 2021 -0500 nitro doesn't need "re"/"pcre" commit 03b67952b0011c83598913ebbe04cc3d7d74e334 Merge: f9a7df4b 14517c04 Author: Dan Smith Date: Sat Mar 6 13:39:55 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d6b87a25205ee7d9987e11c268d7180541a102ed Author: Dan Smith Date: Sat Mar 6 12:57:33 2021 -0500 add back .cmake files commit 0827cf5a5a6f08db46e6c387d639e7db73760c35 Merge: daaf0f7e f62735eb Author: Dan Smith Date: Sat Mar 6 12:46:59 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit f62735eb548ee32f4cd0b1ff45d0227e95bbfe2e Author: Dan Smith Date: Sat Mar 6 12:44:00 2021 -0500 add back build directory commit daaf0f7e00d5167e8d4c767c0f70dc2dae17f6b0 Merge: f26f1f91 8705bbb6 Author: Dan Smith Date: Sat Mar 6 12:31:26 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f26f1f916a3f1374ae03030d033e5672f2fe37ca Author: Dan Smith Date: Sat Mar 6 12:19:09 2021 -0500 externals/coda-oss is now a junction or sym-link commit 4a3200ade5750474039be3d9ca78092af5dab746 Author: Dan Smith Date: Sat Mar 6 12:17:06 2021 -0500 rename "coda-oss" to include version # commit ee54fff151254b7f5a95b7368147598e2099f620 Merge: 4d4c9b25 62ec4911 Author: Dan Smith Date: Sat Mar 6 11:23:57 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f9a7df4bc7d87b5417ae9c91bce2a7d9b7894ebf Author: Dan Smith Date: Sat Mar 6 09:27:58 2021 -0500 arguments to List iterator routines can be "const" commit 6ede78dee70e6bed16c1c77571df50ff65666867 Merge: 2e101125 62ec4911 Author: Dan Smith Date: Sat Mar 6 09:03:27 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit 4d4c9b252bb32ae819cc480eac9869e98fe58558 Author: Dan Smith Date: Tue Mar 2 12:01:27 2021 -0500 latest from coda-oss commit c937262798ee9e8d30fad788f7be25e9e0d413f9 Merge: bebfbab2 b7f04aec Author: Dan Smith Date: Tue Mar 2 11:55:42 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit bebfbab20d733d55b20856f52a13ab45075f266e Merge: d100a7d2 f810f8f6 Author: Dan Smith Date: Tue Mar 2 11:44:32 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 2e1011253135ca947fb2d25b31c7fe6fb2acad1a Author: Dan Smith Date: Tue Mar 2 09:36:03 2021 -0500 run test_tre_read.cpp unittest with CMake commit e8a5986023083c0838069c1f11b596b3645189b8 Author: Dan Smith Date: Tue Mar 2 09:21:09 2021 -0500 added more NULL-checking commit a4cd82a049fc7094172748c4dfcae9d525d75da6 Author: Dan Smith Date: Tue Mar 2 08:46:33 2021 -0500 fewer diffs with code in "master" commit 7916c61335a60f41a72a7b40985db1b500fd242a Author: Dan Smith Date: Mon Mar 1 17:35:53 2021 -0500 create & assign at the same time; ASSERTs commit faec444b427f73c197f3391f315e2199bf20be26 Author: Dan Smith Date: Mon Mar 1 17:30:50 2021 -0500 check for wrap-around and NULL iterator commit ab61b1bed45a0b3347b57ec5d79ec54a0dcce0b2 Author: Dan Smith Date: Mon Mar 1 15:50:20 2021 -0500 inching ever closer to moveTREs() commit 02da8ac4f00481396d365415aee9a8262804c98b Author: Dan Smith Date: Mon Mar 1 15:43:30 2021 -0500 code is even closer to new Record.c commit e775a036f4a3776c092c476d05dc9734385d2349 Author: Dan Smith Date: Mon Mar 1 15:36:40 2021 -0500 code is now closer to moveTRE() changes commit 400285b82827d1b883ea19a3697d9daa89bcd9b4 Author: Dan Smith Date: Mon Mar 1 15:14:36 2021 -0500 prepare for moveTRE() changes commit 1e70efe6a7644d7debef5f2484b0fbce722bbb34 Author: Dan Smith Date: Mon Mar 1 14:18:01 2021 -0500 get rid of intermediate macros/functions commit 935e49e5d6cfbdd126c5d5b78edcdafa92c20471 Author: Dan Smith Date: Mon Mar 1 14:11:49 2021 -0500 make the macro a function commit d0af08870ebe058988ac1374563e44cd030197e4 Author: Dan Smith Date: Mon Mar 1 14:07:31 2021 -0500 pass remaining arguments to macro commit 669d21f4178b09f137f7154f9084587a88008b97 Author: Dan Smith Date: Mon Mar 1 14:02:03 2021 -0500 closer to having UNMERGE_SEGMENT_ be a function commit 296ce4872d31952586fea7b15f04c41ea2e2b942 Author: Dan Smith Date: Mon Mar 1 13:46:01 2021 -0500 begin work on getting rid of the UNMERGE_SEGMENT macro commit ef1b8b79f231c04b330e3c04de8bcbc45d4979d1 Author: Dan Smith Date: Mon Mar 1 13:26:46 2021 -0500 restore changes from release/2.10.1 to fix broken unit-test; WIP commit 91e91942b23b3fe2e3fe18fb29785080090df986 Author: Dan Smith Date: Mon Mar 1 10:21:56 2021 -0500 add missing adapterWriteBlock() implementation commit 45c3e328ed654188f2870fe06c6e6943a6647224 Author: Dan Smith Date: Mon Mar 1 10:05:24 2021 -0500 remove "final" as SWIG doesn't like it commit 21b0f3411b7b36da826521ae93f07339db766cbb Author: Dan Smith Date: Tue Feb 23 15:13:53 2021 -0500 SWIG doesn't like "final" commit f1a981a049a62111452d3dad85cb8abe41b0f741 Merge: 466f7e70 f810f8f6 Author: Dan Smith Date: Tue Feb 23 15:12:32 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit d100a7d2883ba52d9e2adc2a743214eded64216a Author: Dan Smith Date: Mon Feb 15 14:44:30 2021 -0500 latest from coda-oss to build with older compilers commit 82afef8fde9b1e2e5a2bf9d19684a34f2636931a Merge: f1a76a95 f0a45b36 Author: Dan Smith Date: Mon Feb 15 14:42:50 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit f1a76a95a0fdb8bfc96827a5382afed967c882d9 Author: Dan Smith Date: Wed Feb 10 09:45:44 2021 -0500 latest from coda-oss commit a8692278d5b50fd42043cda62a9eec4aa0720041 Merge: dc2bfc2f 1b6ae6ad Author: Dan Smith Date: Wed Feb 10 09:43:01 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 466f7e70f6135670a01d2f515f23c5d48a9ed747 Merge: 61d1b3ee ee89c7d3 Author: Dan Smith Date: Tue Feb 9 17:15:24 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit dc2bfc2f6346fde41d1ea9deb626b97143e5aa44 Merge: ad013614 1615ce17 Author: Dan Smith Date: Tue Feb 9 14:20:39 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit ad01361402f46089b7732003a7abb1c2403c111f Author: Dan Smith Date: Tue Feb 9 13:32:10 2021 -0500 don't need .github in "externals" commit 31e42bbae307f65ea2b2eb76826480bb1e14d7ac Author: Dan Smith Date: Tue Feb 9 13:31:29 2021 -0500 latest from coda-oss commit 1cd6b1e22046bce3ee87804c6af1fc799b29897f Merge: 88cd12dc 0fbebcbd Author: Dan Smith Date: Tue Feb 9 13:23:41 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 88cd12dc4366dd3473fa0b1e16ecef2a449c5af9 Author: Dan Smith Date: Mon Feb 1 13:21:08 2021 -0500 latest from coda-oss commit 6bc7a365c1cfad48d56372701f5ccc15470dc7a8 Merge: 8b51116b 91cb4079 Author: Dan Smith Date: Mon Feb 1 11:50:22 2021 -0500 Merge branch 'develop/update_coda-oss' of github.com:mdaus/nitro into develop/update_coda-oss commit 8b51116b8d4c5cefe20628c454d142ca3d0183f2 Merge: d01c8254 28014162 Author: Dan Smith Date: Mon Feb 1 11:50:16 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 91cb4079882bda87c5d5f1ec3fe1dc5baa7e33a2 Author: Dan Smith Date: Sat Jan 30 16:36:45 2021 -0500 std::filesystem::path doesn't implicitly convert to std::string commit 287ad87bd4c2a1b91c1de1f6a6b9f86554739526 Author: Dan Smith Date: Sat Jan 30 16:21:42 2021 -0500 latest from coda-oss commit 61d1b3ee49f7a28ca2bdda615f2dbea3bab36abe Author: Dan Smith Date: Wed Jan 27 08:26:26 2021 -0500 return an error rather than doing nothing if "infoArray" is NULL commit fcf42b7bc7f5e2282402c8f01bdc1b2776664629 Author: Dan Smith Date: Tue Jan 26 17:55:38 2021 -0500 fix code-analysis warnings commit 350a00b1db964bcf47c36bcc2335eae47653d3cf Author: Dan Smith Date: Tue Jan 26 17:40:46 2021 -0500 prevent uint32_t+1 from overflowing commit c38c7a33ef9aa0e36756854f211bcfadbf36577c Author: Dan Smith Date: Tue Jan 26 17:29:56 2021 -0500 get rid of "goto CATCH_ERROR" use TEST_ASSERTs instead commit 783c30196c818f3798c1e05c51e022ee8d7cc1ad Author: Dan Smith Date: Tue Jan 26 17:18:16 2021 -0500 added extensive commentary about the tests commit d0b683acaf31a73d1cc50b53f23086840917140b Author: Dan Smith Date: Tue Jan 26 17:07:45 2021 -0500 fix crash from NULL buffer in readRESubheader() commit 6b56792a47f4998164a73a334946bd60b266fcc3 Author: Dan Smith Date: Tue Jan 26 17:05:51 2021 -0500 unittest for crash in readRESubheader() commit 37d22c2d222c0f85a61df4b132a94230355c5300 Author: Dan Smith Date: Tue Jan 26 16:48:23 2021 -0500 fix overflow error/crash in readBandInfo() commit 9f02121a723ca88d7936be4be8892d113503d266 Author: Dan Smith Date: Tue Jan 26 16:46:19 2021 -0500 unittest for 32-bit integer overflow commit 0095b760ef05ed7b21c7d60624a654bfe455dffa Author: Dan Smith Date: Tue Jan 26 15:57:32 2021 -0500 fix memory leak in defaultRead() commit c11fc71c950d26ce3c91f938c1cfdfc61ac2b09e Author: Dan Smith Date: Tue Jan 26 15:44:42 2021 -0500 Add missing call to nitf_ListIterator_increment() to prevent nitf_Record_unmergeTREs() from hanging commit f449ba4496e5ea1f1194f3772d9cc6483cbaa01b Author: Dan Smith Date: Tue Jan 26 15:43:32 2021 -0500 add unit-test for test_nitf_Record_unmergeTREs() hanging commit 1e826330c416ce93085009bc470471c544a6d7a1 Author: Dan Smith Date: Tue Jan 26 15:31:21 2021 -0500 fix crash derefering NULL "overflow" in nitf_Record_unmergeTREs() commit 726cd8abbf1bce2f99baf7f49d7891c92c520c76 Author: Dan Smith Date: Tue Jan 26 15:26:28 2021 -0500 test_nitf_Record_unmergeTREs_crash commit 648340246440b55a41b25bbb7b01d88c65b377d9 Author: Dan Smith Date: Tue Jan 26 14:27:18 2021 -0500 starting to set things up to reproduce a few bugs before fixing them commit 65242431c970bd0b3dddb7c7454046fb6591d53d Author: Dan Smith Date: Tue Jan 26 13:17:06 2021 -0500 update from "master" commit a09b82c52d9d8da46a87b1ed4aa6c424f054f2c6 Merge: d60fb61d bc379d3f Author: Dan Smith Date: Tue Jan 26 12:57:39 2021 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit d60fb61d6029de469f1e271ac523c9974db68126 Merge: 04abdaa3 f419dc53 Author: Dan Smith Date: Tue Jan 26 12:50:02 2021 -0500 Merge branch 'master' into feature/remove_compiler_warnings commit bc379d3f73346a332a841d997e2ad04885391b5e Author: Dan Smith Date: Tue Jan 26 08:56:59 2021 -0500 build with C++17 in this branch commit 9bee8c38f8e76b5e44885ee465330a1b6193a8dc Merge: 4a51148c 2d73f0ee Author: Dan Smith Date: Tue Jan 26 08:52:16 2021 -0500 Merge branch 'master' into main commit d01c82540717ed69e840d3f63e9382d0ac58e786 Author: Dan Smith Date: Mon Jan 25 18:19:39 2021 -0500 latest from coda-oss commit 1a3e65cb393e616762e250dae918dbf82440a41f Merge: a7849538 0d6988eb Author: Dan Smith Date: Mon Jan 25 18:18:06 2021 -0500 Merge branch 'master' into develop/update_coda-oss commit 4a51148c71eeec72abad83da9042573918469bf5 Author: Dan Smith Date: Mon Jan 25 17:04:21 2021 -0500 build "main" with C++17 commit 979b11ff307e712ef04aa923ba2b3c62b03b0b36 Merge: 5e60c095 0d6988eb Author: Dan Smith Date: Mon Jan 25 13:25:42 2021 -0500 Merge branch 'master' into main commit a7849538b6d02ccc9a51b5747000b6846f19dd36 Author: Dan Smith Date: Tue Jan 19 16:16:06 2021 -0500 don't need to change coda-oss drop commit 33cf616e4bb22eb92c77460a4263e082636dcb9b Author: Dan Smith Date: Tue Jan 19 16:10:48 2021 -0500 gsl::span -> std::span commit b229bead949e8efe5b78014bc1f3db4d5e42b0d3 Author: Dan Smith Date: Tue Jan 19 16:05:11 2021 -0500 latest from coda-oss:master commit 5e60c0959b3be0dd59a2b7f7cecd413db67250dc Merge: 63ee18c4 5be4b7e6 Author: Dan Smith Date: Sat Jan 16 13:38:22 2021 -0500 Merge branch 'master' into main commit 63ee18c41c44ae6bcd4bbea296345366719d3805 Merge: 657d5a1d 92b19f9c Author: Dan Smith Date: Sat Jan 16 10:46:51 2021 -0500 Merge branch 'master' into main commit 657d5a1daadb6d4d7d5627f38e2e4421c0e8e157 Merge: 9045a98d c1ef1e93 Author: Dan Smith Date: Wed Jan 13 16:10:16 2021 -0500 Merge branch 'master' into main commit 9045a98d9abdc5b083fad91cbec48fe1e2f52e8d Author: Dan Smith Date: Wed Jan 13 16:05:10 2021 -0500 slam in "master" (again) to minimize merge conflicts commit 08dd5441f7b2e05da1f613734e1d61caecbd8849 Author: Dan Smith Date: Wed Jan 13 15:45:16 2021 -0500 restore modules/java and modules/mex and remove archive to minimize changes to "main" and "master" commit 554f1c1b52b10c2b1ff1506f690df5e6b82ed711 Author: Dan Smith Date: Wed Jan 13 15:41:39 2021 -0500 manaully update "main" with changes from "master" to minimize merge conflicts commit cf559b1097c673607f8e25bda4d4cc7f591fab6a Author: J. Daniel Smith Date: Tue Jan 12 17:12:44 2021 -0500 update coda oss (#301) * Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D * java: update to supported version (#241) * Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ * tre: add MATESA support (#244) * Add four TREs defined in MIL-PRF-89034. (#192) * build new TREs w/CMake (#246) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * reduce compiler warnings and the like from C code (#292) * latest from coda-oss:master (#291) * added drivers/gsl from coda-oss:main * Revert "added drivers/gsl from coda-oss:main" This reverts commit 19a9c7445c72518506c5201a2d00227d8241c585. * add GSL from coda-oss:main * latest from coda-oss:main * xml.lit/unittests added in coda-oss * latest from coda-oss:master * restore C++ code from "master"; want *only* java/matlab changes * "Test" directory isn't on "master" (yet) * restore coda-oss changes from "master" * Visual Studio files aren't (yet) on "master" * no scoped enums for C++ on "master" * remove changes that aren't appros to this branch * get unittest changes from main (#294) * start bringing over changes to tests/unittests from "main" * bring over more tests/unittests from "main" * NITF_VER_UNKNOWN -> nitf::Version::NITF_VER_UNKNOWN * get two more unittests from "main" working * get test_writer_3++ working as a unittest * make test_image_loading++ a unittest * fix build error on Linux * don't change derivation of except::Throwable * existing code catches except::Throwable, not std::exception * build with Visual Studio 2019 (#295) * don't include coda-oss stuff we don't need * build with VS2019 * sub-directories must be listed (or not) in CMakeLists.txt * no python wrappers for xml.lite * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * update coda-oss (#297) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * Update .gitignore * std::byte -> nitf::byte until we can use C++17 everywhere (#298) * tweaks so that six builds with nitro updates (#299) * std::byte -> nitf::byte until we can use C++17 everywhere * mem::SharedPtr -> std::shared_ptr is a breaking change * latest from coda-oss/master * latest from coda-oss (#300) * latest from coda-oss * remove extracted openjpeg-2.3.1_mod directory * latest from coda-oss * need CODA-OSS to augment std * Update .gitignore * latest from coda-oss/master * switch to "main" * latest from coda-oss/main (not "master") * slam in "main" * latest from coda-oss/main * except::Throwable needs to inherit from std::exception in this branch * CODA-OSS now does /Zc:__cplusplus for us in a different way * slam in "main" * need to augment std:: in this branch * coda-oss/main Co-authored-by: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Co-authored-by: Zeigler, Bryan D Co-authored-by: Brad Hards Co-authored-by: Andrew Hardin commit 38295eda48fddd0859ed065bd7b85ce35b1845dd Author: J. Daniel Smith Date: Mon Jan 4 15:39:11 2021 -0500 latest from develop/jdsmith (#290) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files * latest from coda-oss/main * still trying to build w/o changing coda-oss * coda-oss now supplies gsl::span * fix #incldues for other GSL files * Delete gsl_.h, need to re-add as Gsl_.h * Create Gsl_.h. not gsl_.h commit adc0e73fe6d5bb02d584772b57a88aa5d30df201 Author: J. Daniel Smith Date: Wed Dec 30 17:57:49 2020 -0500 latest from develop/jdsmith (#289) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo * latest from coda-oss/main * use sys/CStdDef.h directly, get rid of our own * tweak CODA-OSS w/o changing source files commit 918ec51823ee0faf7cf99b115079e9217ef0c651 Author: J. Daniel Smith Date: Wed Dec 30 16:54:08 2020 -0500 update coda-oss (#288) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * latest from coda-oss/main commit 9946049f4eb5b75868439f14c8a8ca0e77a9d56b Author: J. Daniel Smith Date: Wed Dec 30 12:49:47 2020 -0500 use GSL from coda-oss (#287) * latest from coda-oss * Update .gitignore * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" * use GSL from coda-oss * latest from coda-oss/main * "nitro" isn't ready for Throwable to be derived from std::exception * add dependency on gsl so files get copied for CMAKE * add a dependency for gsl so #include files get copied * throwable needs to derive from std::exception in this repo commit 75ccefa3d203a2acee3d6babd8969381b07ca09b Author: J. Daniel Smith Date: Wed Dec 30 10:31:29 2020 -0500 latest from coda-oss (#286) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main * latest from coda-oss/main * no xml.lite in "nitro" commit b6f883fc18dbf85e8fb836c3fce4d7e05ecac730 Author: J. Daniel Smith Date: Tue Dec 29 16:45:44 2020 -0500 latest from coda-oss (#285) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment * latest from coda-oss/main commit 16289ae3bed5a670559fe77899ba65486ef333d9 Author: J. Daniel Smith Date: Tue Dec 29 09:48:03 2020 -0500 update coda-oss (#284) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" * latest from coda-oss * c++ updates from coda-oss * openjpeg changes from coda-oss * same code builds with both C++11 and C++17 * fix default for CODA_OSS_AUGMENT_std_namespace * if we're at C++20, there's nothing to augment commit bce3916acb7e7a9ea77112bf980d394f0334169d Author: J. Daniel Smith Date: Sat Dec 19 13:50:52 2020 -0500 one more change from develop/jdsmith (#283) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" * can use std::exception in a few more places now that Throwable derives from it commit 09eaf7266abfe9b4a75f99e750e30d5a504a1801 Author: J. Daniel Smith Date: Sat Dec 19 13:29:30 2020 -0500 latest from develop/jdsmith (#282) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t * use range "for" loop * make it easier to get a nitf::Field value as a string * use implicit nitf::Field -> std::string conversion to reduce explicit use of toString() * use "range for" instead of explicit iterators * restore .toString() changes lost in previous merge * further reduction in use of explicit toString() * should normally "catch" "const" exceptoins * latest from "coda-oss" commit ff3ca9dcbf5d8dc5bbb9eb4cf60c5e8b24370b06 Author: J. Daniel Smith Date: Sat Dec 19 13:27:54 2020 -0500 update coda-oss (#281) * latest coda-oss from "main" * update coda-oss * "filesystem" updates * latest from "coda-oss" commit 2b0e059f303810bdb513630302cf4688c6518fcc Author: J. Daniel Smith Date: Sat Dec 19 12:02:46 2020 -0500 increase use of range "for" (#280) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr * use "range for" instead of explicit iterators commit 8bde696806acb52ad6ff1ac13a5588bb8fda4c3a Author: J. Daniel Smith Date: Wed Dec 16 11:05:00 2020 -0500 latest updates from develop/jdsmith (#279) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates * simplify access to some ImageSubheader values * reduce use of delete[] * make the hashtable test a unittest so it will be ran much more often * reduce explict use of "delete" * remove more uses of delete[] * trying to turn test_writer_3++ into a unittest * PTPRAA had the wrong id so it wouldn't load * be sure we can load plugins; there was a bug in PTPRAA! * test C++ routines too * nitf::PluginRegistry::loadPlugin() needs a full path on Linux * get test_writer_3++ working * test_writer_3++ is now a unittest * test_buffered_write is now a unittest * tweak code organization * test_image_loading++ is now a unittest * ignore .out files from unittests * slightly code simplification * simplify calling SubWindow::setBandList() * more simplification when using SubWindow * manage the "buffer list" so we can't screw it up * more use of std::byte instead of uint8_t commit b545a6101b7740245596b7323a31a1398951a7a8 Author: J. Daniel Smith Date: Tue Dec 8 11:30:47 2020 -0500 latest from develop/jdsmith (#276) * latest coda-oss from "main" * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" * use std::this_thread::get_id() instead of sys::getThreadID() * make test_mt_record a unit-test * sys::Thread -> std::thread * less use of sys:: * update coda-oss * sys::Filesystem -> std::filesystem * build with /std:c++17 * "filesystem" updates commit aa13b3a620b421bcb3acf45e1885bc5330c41740 Author: J. Daniel Smith Date: Tue Dec 8 11:28:31 2020 -0500 Feature/update coda oss (#277) * latest coda-oss from "main" * update coda-oss * "filesystem" updates commit bed0e25265e7a15e9bc53bc6fae5ae63de6cf2b1 Author: J. Daniel Smith Date: Sat Dec 5 17:56:47 2020 -0500 int64_t instead of sys::Off_T (#275) * sys::byte -> std::byte * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * using instead of makes Handle simpler * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use C++11's nullptr instead of NULL * std::unique_ptr overload for getImageBlocker() * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( * sys::Off_T -> int64_t * use .data() rather than &d[0] * NULL -> nullptr commit 07f8d9a626a58de5589fe0d4131e558e0f1d677a Author: J. Daniel Smith Date: Sat Dec 5 09:21:39 2020 -0500 latest from develop/jdsmith (#274) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent * move real GSL code to a place where it will be copied by existing scripts * tweak "externals" configuration * make project settings more consistent * use real GSL based on VS version * trying to do our own std::span * no "auto" return type for GCC * make names match Linux * more "nitro" -> "nitf" to match Linux * remaining "nitro" -> "nitf" commit 04abdaa3a05142668530b0cd259df3dfeb958ab8 Merge: f44f1682 aa22bcb5 Author: Dan Smith Date: Wed Dec 2 10:02:47 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit f44f168260b4d1b63482108d57a37c78060938a1 Merge: 50c9dc6f 8a97faad Author: Dan Smith Date: Wed Dec 2 10:02:38 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit 8a97faadd85d53141dff991b2d99449281ab4eaa Author: Dan Smith Date: Wed Dec 2 09:37:57 2020 -0500 ... still one more "common" use-case. commit e5b270a9aba6a836e270de8a7b4a8e43d2851932 Author: Dan Smith Date: Wed Dec 2 09:28:45 2020 -0500 ... and one more overload for a common use-case commit 30b249258b6239afd19af88164099f7dc2c49197 Author: Dan Smith Date: Wed Dec 2 09:17:31 2020 -0500 restore SegmentMemorySource() overload to avoid breaking too much existing code commit a7b77e86ae62c06f72e8e9a8115371f322b3e3d4 Author: J. Daniel Smith Date: Tue Dec 1 18:25:24 2020 -0500 more use of std::byte (#273) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: * std::byte* instead of char* * previous commit broke a test-case :-( commit f1b67ffaf1a9d29bcf6ac677cbb00fe200e7fc9e Author: J. Daniel Smith Date: Tue Dec 1 16:20:13 2020 -0500 use std::shared_ptr and filesystem instead of mem:: and sys:: routines (#272) * use std::shared_ptr instead of mem::ScopedArray * use filesystem routines rather than sys:: commit da88a43a63e9874ffde740795d1bffe307ab8ab6 Author: J. Daniel Smith Date: Tue Dec 1 13:00:56 2020 -0500 move real GSL code to a place where it will be copied by existing scripts (#270) commit 19ed66f8611c7a1c53dd21048c52ee70a9c2e843 Author: J. Daniel Smith Date: Tue Dec 1 13:00:33 2020 -0500 Feature/remove compiler warnings (#271) * make test_setReal a unittest * test pointers for possible NULL-ness as indicated by code-analysis commit aa22bcb5751429200900dc97a76b6f97cb193940 Author: Dan Smith Date: Tue Nov 24 15:46:39 2020 -0500 test pointers for possible NULL-ness as indicated by code-analysis commit 6d2c399906232880a5d6ef142305b488d0747e47 Author: Dan Smith Date: Tue Nov 24 14:07:27 2020 -0500 make test_setReal a unittest commit d8f1f8c5c6c6c3526292f9d97a7942ecfeefc4f1 Author: J. Daniel Smith Date: Tue Nov 24 09:31:59 2020 -0500 build show_nitf++ in VS2019 (#269) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs * use AVX2 * add a project to build show_nitf++ * make project settings more consistent commit 57f5aa5c8fc8c156f5a66354490f7db32641ee90 Author: J. Daniel Smith Date: Tue Nov 24 08:46:27 2020 -0500 remove compiler warnings (#268) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch * enlarge the sprintf() buffer to remove compiler warnings commit c6407b8b6ec60681c89891bbca313a242abf4b8f Author: J. Daniel Smith Date: Mon Nov 23 18:01:03 2020 -0500 remove compiler warnings (#267) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * turn on more rules * turn on more CA rules * turn on more rules * turn on STL and arithmetic rules * fix a bunch of CA diagnostics * initialize nitf_Error * remove CA diagnostics about uninitialized member data * removed more CA diagnostics * turn off "noexcept" warning for operator() * add a bunch of "noexcept" per code-analysis diagnostics * noexcept(false) for default-constructors that can throw * need another "noexcept(false)" * get rid of empty destrctor implmeentations, using = default instead * fix GCC compiler error * more "noexcept" in accordance with code-analysis * explicitly delete copy/assignment operators * expliitly =delete move * enable some "raw pointer" rules * use vector::data() rather than &v[0] * turn on remaining code-analysis rules! :-) * use rather than sys::RealTimeStopwatch commit 50c9dc6f6c7955bbdc327688c7f12d9a474724d7 Author: Dan Smith Date: Sat Nov 21 16:36:30 2020 -0500 initialize nitf_Error commit 7dc76b57c313442b583bd7896dc9070e881a2a64 Author: Dan Smith Date: Sat Nov 21 16:18:32 2020 -0500 fix a bunch of CA diagnostics commit 44774c3df11219dd40f5f8ac7ff73b559d35d7ae Author: Dan Smith Date: Sat Nov 21 15:20:20 2020 -0500 turn on STL and arithmetic rules commit 41063c16da2a810eee6daddc17875837b6d6cc65 Author: Dan Smith Date: Sat Nov 21 15:01:05 2020 -0500 turn on more rules commit 3b7e7892e289bb8cdf4a38c0b5bea22ad8fb5561 Author: Dan Smith Date: Sat Nov 21 14:56:58 2020 -0500 turn on more CA rules commit c473b457c8cbfe97f1fd8cc60a5b61fdc5ccc2f8 Merge: a4ccdc8e 09c20163 Author: Dan Smith Date: Sat Nov 21 14:50:02 2020 -0500 Merge branch 'main' into feature/remove_compiler_warnings commit a4ccdc8e4a2679c9f7e7b77e6db8cfde952af0e5 Merge: 9cda4c30 1f399162 Author: Dan Smith Date: Sat Nov 21 14:49:15 2020 -0500 Merge branch 'feature/remove_compiler_warnings' of https://github.com/mdaus/nitro into feature/remove_compiler_warnings commit 9cda4c30f50a465a58cb3e80842ab668513467ab Author: Dan Smith Date: Sat Nov 21 14:45:31 2020 -0500 turn on more rules commit 09c2016361bf4772a4eeeef9c20df2e6503f2d4c Author: Dan Smith Date: Wed Nov 18 15:08:47 2020 -0500 GetEnvironmentVariable() and getenv() aren't quite the same commit be7174a709f2573ad116fd59af4a4dc75c88c6c2 Author: J. Daniel Smith Date: Wed Nov 18 14:20:00 2020 -0500 use top-level WAF install directory rather than externals (#266) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs * use top-level "install" directory so we get DLLs built by WAF * find path to WAF-build DLLs commit f07461b69f00d0f2d7d29f0e9e4b71c65a5c0858 Author: J. Daniel Smith Date: Wed Nov 18 14:04:49 2020 -0500 remove compiler warnings (#265) * still more compiler warnings vanquished * make test_create_nitf_with_byte_provider a unittest so that it is always executed * fix CMake config error * move "test_create_nitf++" into existing unittest * remove newly introduced compiler warnings * remove duplicate code * tryng to build J2K DLLs commit 1f3991624230f24573a1dca1aebaf6f5af5db778 Author: Dan Smith Date: Wed Nov 18 12:49:24 2020 -0500 tryng to build J2K DLLs commit f1e6ff81026730183e23e861eda094509f64173e Author: Dan Smith Date: Wed Nov 18 11:52:16 2020 -0500 remove duplicate code commit 260bf75d9b713f3f68ffd9c49a51f0b5dd6e7459 Author: Dan Smith Date: Wed Nov 18 11:38:21 2020 -0500 remove newly introduced compiler warnings commit 13b22f83a74248eae861a424ba67a77127614b07 Author: Dan Smith Date: Wed Nov 18 11:32:13 2020 -0500 move "test_create_nitf++" into existing unittest commit b37575ba57d594a541dd0894ba3cee4010bb3549 Author: Dan Smith Date: Wed Nov 18 11:03:45 2020 -0500 fix CMake config error commit 6b141ec00116167b6325e71e22bb6c02cce53547 Author: Dan Smith Date: Wed Nov 18 10:46:38 2020 -0500 make test_create_nitf_with_byte_provider a unittest so that it is always executed commit b2398a32f9080778840b65f543f5d7503984af81 Author: Dan Smith Date: Wed Nov 18 10:21:03 2020 -0500 still more compiler warnings vanquished commit 00a0a7819d9129f55c10bf8fe13f339e928a5f21 Author: J. Daniel Smith Date: Tue Nov 17 17:25:30 2020 -0500 remove dozens of compiler warnings (#264) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * Revert "fix wrap-around values (#262)" This reverts commit c7601b742311b4c31db2ac400289e116f6a34f3b. * test all 0s for latitude * added several more (broken?) unittests * tweak wrap-around results * remove compiler warnings from Windows WAF build * removed a bunch of "unrefered parameter" compiler warnings * remove more "unreerenced parameter" warnings * move tests\test_geo_utils to unittests so that it is always ran * fix still more "unreferenced parameter" warnings * wrapper around strlen() to avoid casts * add casts to slience the compiler * use gsl::narrow<> to safely cast integers * get rid of signed/unsigned mismatch warnings * remove more compiler warnings * remove some code-analysis diagnostics * get rid of "expression is always false" warnings * remove compiler warnings about initialization in an "if" * removed "conversion from '...' to '...', signed / unsigned mismatch" warning * #pragma-away warning from GSL * remove more compiler warnings about assignment within conditional * fix broken unittest because of "testName" changes * fix unittest compiler warnings commit 3d65ba13d0941085ff59314f3e5577464b804d35 Author: J. Daniel Smith Date: Mon Nov 16 10:32:11 2020 -0500 tweak wrap-around results (#263) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates * fix a handful of warnings when bilding on Windows with WAF * test all 0s for latitude * tweak wrap-around results commit c7601b742311b4c31db2ac400289e116f6a34f3b Author: J. Daniel Smith Date: Wed Nov 11 17:01:42 2020 -0500 fix wrap-around values (#262) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons * do a better job wrapping coordinates commit f5c5574120390dcf8d2dc7a425651537179ec612 Author: J. Daniel Smith Date: Wed Nov 11 15:18:36 2020 -0500 remove compiler warnings (#261) * fix GCC compiler errors about buffer sizes * don't check-in outputPathname.ntf * unittest for DMS conversion that is "correct" on main (broken right now) * fix compiler warnings w/o breaking (new :-) ) unittests * single utility routine for adjusting dms values * test DMS values > 60, 180, 360 ... things are broken * preserve existing (incorrect?) behavior * unit-test more incorrest results * adjust unit-tests to account for more existing behavior * once again, preserve existing (incorrect) behavior * fix multile broken DMS conversons commit a1022e1c88d066009284422897a371f09eed81b0 Author: J. Daniel Smith Date: Mon Nov 9 13:10:20 2020 -0500 latest coda-oss from "main" (#260) commit 35254eb831cfa1bed38be5c479b33c8f2b58af3f Author: Dan Smith Date: Mon Nov 9 11:14:09 2020 -0500 get unittest working with WAF on Linux commit 7e371459c2dcad17c089eafde12c8571e48fc450 Author: Dan Smith Date: Mon Nov 9 11:00:03 2020 -0500 fix unit-test for WAF on Windows commit 70755443ac4b16fc358614559921f696a49fe898 Author: J. Daniel Smith Date: Wed Nov 4 17:31:09 2020 -0500 latest from coda-oss (#259) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" * use new sys/Filesystem.h instead of * run changeFileHeader() unittest on Linux * better error message if the inputPathname is empty * account for "build" directory when using CMake * still trying to get unittest working in build enviroment * get "root_dir" right commit d141017fb05d1fcbdf71ee9c68548e93081b0080 Author: J. Daniel Smith Date: Tue Nov 3 17:07:02 2020 -0500 remove coda-oss modules not needed by nitro (#258) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss * remove coda-oss modules not needed for "nitro" commit 3ea4b8313d13fa065db26ec7ea418c22c7b83b76 Author: J. Daniel Smith Date: Tue Nov 3 16:29:20 2020 -0500 latest from coda-oss (#257) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss * latest from coda-oss commit a9bf63fb9034f34ac9087d33ee60de3c86715e56 Author: J. Daniel Smith Date: Wed Oct 28 15:13:35 2020 -0400 update coda-oss (#256) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" * update coda-oss commit c5f2e5e0ee2e1d2f5846ffe3c697b7912d948f7b Author: J. Daniel Smith Date: Wed Oct 28 14:37:33 2020 -0400 latest from develop/jdsmith (#254) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" * new unittest to change some metadata * hookup changeFileHeader unittest * utility routine name can't be same as TEST_CASE() * "enable" changeFileHeader unittest on Linux commit e1ff1e8aacd2344ebc40f6ef630f608c768843f6 Author: J. Daniel Smith Date: Wed Oct 28 14:04:03 2020 -0400 move "mex" and "java" to an archive folder (#255) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size * use to remove hard-coded path * LibjpegDecompress builds * move "mex" and "java" to "archive" commit 045718acb87e74cbf69a52334df5e791c20bbfb2 Author: J. Daniel Smith Date: Tue Oct 20 11:53:06 2020 -0400 Feature/update coda oss (#251) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests * update "coda-oss" with latest from "main" commit 0be5b5cc41c1d6936e09b243d7ec44287eeba8fd Author: J. Daniel Smith Date: Wed Oct 14 16:47:51 2020 -0400 update coda oss (#250) * latest from coda-oss to remove code-analysis warnings * catch unecpted exceptions from unittests commit 8ffdeaf110dbb29d7b507ffc46ddd91738bec550 Author: Dan Smith Date: Wed Oct 14 15:39:43 2020 -0400 wlhen building SWIG code, C-style enums are used commit fe4f6c9ef73b20c9ad322728ab731d0e57102feb Author: J. Daniel Smith Date: Wed Oct 14 09:36:21 2020 -0400 need C-style enum with SWIG & build XML_DATA_CONTENT (#249) * need C-style enum with SWIG * build XML_DATA_CONTENT * be sure multi-processor compilation is enabled; optimize for speed over size commit 621bba7dfb284e227ea8fb9e2d14aa71e61d6c66 Author: J. Daniel Smith Date: Tue Oct 13 15:45:59 2020 -0400 latest from coda-oss to remove code-analysis warnings (#248) commit bacedbba30f1591c3035bf7994a9be928d852a07 Author: Dan Smith Date: Tue Oct 13 13:48:42 2020 -0400 fix Field to be compatible with existing code commit 572531c186411221b24610e5542c55e980b44486 Author: J. Daniel Smith Date: Mon Oct 12 09:38:04 2020 -0400 build new TREs w/CMake (#246) commit c126d5d39d3c4f18359ab240db6824fa5a7c88eb Author: Andrew Hardin Date: Mon Oct 12 07:37:29 2020 -0600 Add four TREs defined in MIL-PRF-89034. (#192) commit 839b51f63d289580441bba006c0089c574e26f68 Author: J. Daniel Smith Date: Mon Oct 12 09:26:49 2020 -0400 remove compiler warnings (#245) * latest from coda-oss * Update .gitignore * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * fix warnings about printf() format * fix compiler warnings about using NULL * get rid of more compiler warnings * fix int/int64_t conversion warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * remove several "expression is always true" warnings * fix some code-analysis diagnostics * remove several code-analysis diagnostics * GSL 3.1.0 * removed severl more CA diagnostics * GCC doesn't like * cleanup more CA diagnostics * trying to get home-brew GSL working with GCC * fixed a bunch of "const" code-analysis diagnostics * get rid of CA diagnostics about unscoped enums * be sure NITF_CLEVEL has been #defined * there is a "#define CLEVEL complianceLevel" macro :-( * build unit-tests in Visual Studio * use var-args macro to simply enum * fix #includes for bulding w/o PCH commit 42e35f33e2970074896d9f2ebd41d1ac56a0ff70 Author: Brad Hards Date: Sun Oct 11 09:03:27 2020 +1100 tre: add MATESA support (#244) commit fa37bc21ca10a1023487a03cdb2a31f3022121dc Author: J. Daniel Smith Date: Mon Oct 5 17:23:38 2020 -0400 Create codeql-analysis.yml Enable GitHub code-scanning: https://github.blog/2020-09-30-code-scanning-is-now-available/ commit 505dea66a7121c31d0e25f36f7850a67d37884c4 Author: J. Daniel Smith Date: Mon Oct 5 14:21:51 2020 -0400 update coda-oss (#242) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * update coda-oss (xerces 3.2.3) commit 79bc5e06f05eef04c12219079eef64404bc5b024 Author: Brad Hards Date: Tue Oct 6 04:59:11 2020 +1100 java: update to supported version (#241) commit d5df4ba252e82aa6890660645bd63fa9710ac05c Author: J. Daniel Smith Date: Tue Sep 29 10:01:58 2020 -0400 display TREs from other parts of the file (#239) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * output more TREs as XML * put the --xml argument before the filename * put the TREs in their own elements * tweak XML output so Visual Studio is happy * can\t have NUL characters in XML commit aa8d3aa57f666e90e5e7ce62de854bba604ed288 Author: Bryan Zeigler <30915099+BryanZeigler@users.noreply.github.com> Date: Wed Sep 23 17:43:28 2020 -0400 Fix bug with myResidual calculation (#204) myResidual is unsigned. The original code had a special case for what happened when myResidual was less than 0. However, an unsigned value is always >= 0. Co-authored-by: Zeigler, Bryan D commit 2fb1833dddd1deaef0974cacceab207052154dab Author: J. Daniel Smith Date: Wed Sep 23 17:34:12 2020 -0400 build with Visual Studio 2019 (#237) * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * new System.c file * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * nitf\source\System.c -> nitf\source\NitfSystem.c * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * restore VS2019 files * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * don't need modules\c\packages in this branch * Revert "don't need modules\c\packages in this branch" This reverts commit 1f5f34b7d98f11e2f9c703feb6f636f398e04016. * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment * Revert "Merge branch 'develop/jdsmith' into develop/jdsmith-VS2019" This reverts commit 63401cbbee3573ce8b525e0ee6c54aede40d1f41, reversing changes made to 45ac63208464a8bb61ac4b5ca4a4760fa10a1c2a. * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List * make still more "getters" const * make clone() const * more const-ness * add files for building with VS2019 * provide a level of indirection around the pre-built "*_config.h" files so that Visual Studio builds work * build j2k routines in VS2019 * Visual Studio will restore missing packages Co-authored-by: Dan Smith commit 8251e9a23e0176a5907d396b57b17f159a33bc12 Author: J. Daniel Smith Date: Wed Sep 23 17:22:08 2020 -0400 get some more "const" correctness changes (#238) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const * more const-ness commit 4b3ac6de3865ac4a79ef236c6405de19613ea016 Author: J. Daniel Smith Date: Wed Sep 23 14:59:23 2020 -0400 make many more "getters" const (#235) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List * make still more "getters" const * make clone() const commit f99755a37e549b6c0fe2dd3839397619ebc89ffb Author: J. Daniel Smith Date: Tue Sep 22 13:08:37 2020 -0400 write out the TREs to XML (#234) * separate try/catch from main() * start hooking up some simple XML output * quiet some more non-XML output * dump the file header (TREs) as XML * somebody didn't know about "mutable" * make manyu more "getters" const * all used "getters" are now const * more use of "const" * const-correctness for List commit b8c0cdf7a0309f3ae30c50ff73778506acae17a2 Author: J. Daniel Smith Date: Tue Sep 22 10:32:07 2020 -0400 make a bunch of "getters" const (#233) * somebody didn't know about "mutable" * make manyu more "getters" const * const-correctness for List commit ee745cb88e07cb83c2a16ad957ac7d19438c8a1d Author: Dan Smith Date: Wed Sep 16 14:02:52 2020 -0400 Revert "Merge branch 'master' into main" This reverts commit e4901937806a2c8a092abd8d8c5cae92bab38e40, reversing changes made to 6d77fb41eb3c3654112ff523aa29bded4c746b4d. commit e4901937806a2c8a092abd8d8c5cae92bab38e40 Merge: 6d77fb41 050fcbc9 Author: Dan Smith Date: Wed Sep 16 12:50:14 2020 -0400 Merge branch 'master' into main commit 6d77fb41eb3c3654112ff523aa29bded4c746b4d Author: J. Daniel Smith Date: Wed Sep 16 12:45:53 2020 -0400 Fix assorted compiler warnings (#232) * enable three more C++ unit-tests * do all the test_tre_mods unit-test from a single GTest * get last C++ unit-test working w/GTest * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * remove/suppress remaining compiler warnings * get rid of more compiler warnings * remove duplicate #pragmas * enable all warnings for C++ * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * reduce reliance on coda-oss/str * remove dependency on math-c++ * remove dependency on math-c++ * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * don't need mt-c++ * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * new Test_ project -- trying to get GTest to work w/new VS install * ignore packages/* * add unit-test files * GTest "Test" project now works * fix compiler warning * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * build with C++17 * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * turn off some CA diagnostics * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" * restore changes lost in previous merges * latest from coda_oss "main" * restore more changes lost in previous merges * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests * make develop/master match master * Revert "Merge branch 'develop/master' into develop/jdsmith-VS2019" This reverts commit 1ebecf391d8f84d8cb6d2ca583df010b367ca440, reversing changes made to 3b30a54fb8dd46ad055e3c4a1a9ec3347c63d709. * updates from "main" branch * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defing strncpy for own causes warnings w/GCC * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * remove _CRT_SECURE_NO_WARNINGS from pch.h * use strcpy_s(), etc. from C!! * can't figure out how to use strcpy_s() on all platofrms/environments * build with C99 and C++11 * fix misleading indentation * #pragma-away MSVC compiler warnings :-( * utility to malloc() and strcpy() at once * nrt_strncpy_s() * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * don't need "packages" in this branch ... * remove VS2019 stuff * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines * remove some GCC compiler warnings * update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions * fix more GCC compiler warnings by using formatting macros: PRIu64 instead of "llu" (or "lu") * #include to get PRI macros * fix broken comment Co-authored-by: Dan Smith commit 11704d375d64eb996d18ee5228cca65bc74fc274 Author: J. Daniel Smith Date: Wed Sep 16 09:57:27 2020 -0400 update "documentation" (#231) * copy some documentation from the old website; work-in-progress * add content from nitro-nitf.sourceforge.net wget -w 1 -r -np -nc -k http://nitro-nitf.sourceforge.net/ * removed documentaton for old versions commit ae2c21c9bbf3221d093083124c63b586660cd3d5 Author: J. Daniel Smith Date: Tue Sep 15 14:30:19 2020 -0400 use our own str*_s() routines (#230) * update from develop/jdsmith (#225) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO Co-authored-by: Dan Smith * don't require C++17 * use strcpy_s(), etc. from C!! * we now have our own nrt_strcpy_s() routine * our own nrt_strcpy() routine to prevent compiler warnings * our own strcat_s() routine * starting over ... :-( * our own strcat_s() * our own strncpy_s() * use our own strdup() routine rather tham malloc()+strcpy() * nitf_strdup() to keep malloc()s in-sync * use our own strcpy_s() * use our own strcpy_s() in more places * a few targeted uses of nitf_strdup() * use nrt_strdup() in nrt_DLL_load() routines * Revert "use nrt_strdup() in nrt_DLL_load() routines" This reverts commit 6d72380917ab44c5240d9b8e6ad22dfbf084da0c. * more use of strdup() instead of malloc+strcpy * can call strcpy_s() directly on Windows * use our strcpy_s() in a few more places * more use or nrt_strcpy_s() * more use of our own strcat_s() and strcpy_s() routines Co-authored-by: Dan Smith commit bb814d464abbd7371746e49d276c51e0db2540cc Author: J. Daniel Smith Date: Mon Sep 14 14:31:08 2020 -0400 can't figure out how to use C11 (for strcpy_s()) on all platforms (#226) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch * #defining our own strncpy() causes warnings w/GCC * trying to set GCC/G++ vesion * spaces instead of tabs for YAML ? * GCC 9 is already instaled on 20.04 * our own #define for strcpy() causes GCC warnings * CMakeLists.txt doesn't build ZIP, don't do it for WAF either * C11 for strcpy_s() * don't need ZIP with NITRO * can't figure out how to use strcpy_s() on all platofrms/environments Co-authored-by: Dan Smith commit 1c7aa665343d4560a3a910a2d316f4305816ce57 Merge: 0faaa016 3031b650 Author: Dan Smith Date: Mon Sep 14 12:56:43 2020 -0400 Merge branch 'main' of github.com:mdaus/nitro into main commit 3031b6507fc4d4317316b7c2ab043b25f21815b7 Author: Dan Smith Date: Mon Sep 14 10:53:10 2020 -0400 trying to fix compiler crash commit 9183dcb88dc4530bd11f3e04fea570f350a598df Author: J. Daniel Smith Date: Sat Sep 12 17:16:26 2020 -0400 grab a few tweaks from develop/jdsmith (#223) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * NULL -> nullptr * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * std::unique_ptr overload for getImageBlocker() * std::auto_ptr -> std::unique_ptr * C++17 * remove -Ds suppressing warnings * remove code-analysis warnings about using a NULL pointer * slam "main" onto develop/jdsmith * changes from VS2019 branch Co-authored-by: Dan Smith commit cc9956b2da66470297245d5b51573a391ff57f1e Author: J. Daniel Smith Date: Sat Sep 12 15:41:48 2020 -0400 develop/master -> main (#221) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit 1437badef4e4498a1896ea6e0b6caa5aae130587 Author: J. Daniel Smith Date: Sat Sep 12 15:36:59 2020 -0400 Develop/main (#220) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges * NULL -> nullptr * turn back on building CODA-tests * slam master onto develop/master * Revert "Merge branch 'develop/master' into develop/main" This reverts commit 0d28430ee37ca29c67d65e33c54b09f219997150, reversing changes made to 5988bb5297c53081ca4f91777c4147370f0da8fb. * .github-workflows-macos.yml is now dot-github-... * auto_ptr -> std::unique_ptr * build CODA tests Co-authored-by: Dan Smith commit c13a2e0d2955c1e3dc52d464fda48ada4e16191d Merge: 5988bb52 5579e74e Author: Dan Smith Date: Sat Sep 12 14:44:10 2020 -0400 Merge branch 'master' into main commit 5988bb5297c53081ca4f91777c4147370f0da8fb Merge: 90368641 ed006304 Author: Dan Smith Date: Sat Sep 12 14:14:12 2020 -0400 don't build "macos" commit 903686414c1b9e193a288645c8727b4bbe33ba2f Author: J. Daniel Smith Date: Sat Sep 12 11:55:31 2020 -0400 update "main" with latest "develop" changes (#208) * removed "unused local variable" warnings * VS2019 SLN/VCXPROJ * ignore .vcxproj.user files * move vsxproj into sub-dirs to make /INCLUDE easier * fix some build warnings * added contact details * do VS2019 in a seperate branch for now * Visual Studio creates this ... should it be checked-in? * Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage Quick copy of a few files from http://nitro-nitf.sourceforge.net/wikka.php?wakka=HomePage * WIN32 should be _WIN32 * /WAll warning for doing assignment inside of if() * handle all enum values in case * be sure local variables are initialized for all code paths * fix a bunch of code-analysis warnings about using NULL pointers (mostly benign as pointer won't actually be NULL) * fix a bunch of code-analysis warnings about using NULL pointers (mostly … * Our own version of C's strerror() (to avoid warnings about using strerror()) * Create .gitattributes * CRLF fixes for text files * remove GCC warnings * _1 is used after all * get GCC w fewer warnings * fix GCC warnings * #pragma-away warnings about an "empty translation unit" * fix compiler warnings * Reader.c and Writer.c exist in two different directories; VS doesn't like that * filename changes * .gitattributes causes too many changes on Linux * tweak existing unit-test code to work with GTest * use TEST_MAIN macro for use in VS2019 * use TEST_MAIN macro for compatibility with Visual Studio * update Test.h in "nitif" directory * compile with both C and C++ * give NITF_DEFAULT_PLUGIN_PATH a default value if not #defined * remove no-longer-needed comment * WIN32 isn't always #defined; check for _WIN32 too * remove some more compiler warnings * fix some code-analysis diagnostics * proper initialization to fix compiler error * latest from coda-oss * Update .gitignore * Update .gitignore * min/max get #define'd as macros :-( * move .h files for Linux build * snprintf() is the same on both Windows & Linux * don't need Convert.h and Semaphore.h with PCH * minor cleanup to .h files * use std;;mutex instead of sys::Mutex * use Standard C types "int8_t", etc. instead of our own typedefs * use standard C types uint8_t, etc. instead of nitf_Uint8 * replace nitf::Uint8 etc with int8_t * restore changes lost in merge * use std:: routines instead of str:: * to_string for "const char*" * new cstddef.h for std::byte * use instead of sys::Mutex * sys::ubyte -> std::byte * tweaks to build C++ unittest in VS * TEST_MAIN for C++ unittests * use TEST_MAIN for VS unit-testing * tweaks for unit-tests on VS * Revert "sys::ubyte -> std::byte" This reverts commit 0a38cef03914c34fee9fe744833224a69a5eda8d. * revert use of std;;byte * Revert "use instead of sys::Mutex" This reverts commit e5ae5bc5b1360cd1460a3aba982c34d740a93f44. * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * Feature/remove compiler warnings (#206) * remove a bunch of compiler warnings (copied from develop/jdsmith) * use std::to_string() instead of str::toString() * allow unit-tests to work with Visual Studio/GTest * rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) * WIN32 isn't always defined, _WIN32 is (leading underscore) * min/max should not be #define'd * cleanup compiler warnings * remove several (mostly "unused variable") compiler warnings * remove more compiler warnings * more compiler-warning cleanup * int -> size_t * remove "unused function" compiler warning * get WIN32 right * add back default NITF_DEFAULT_PLUGIN_PATH #define * need to revisit use of str::toString() * sys::byte -> std::byte * fix sys::byte -> std::byte after merge * more cleanup after std::byte merge * don't need since we're now using std::byte instead of sys::byte * don't need since we're now using std::byte instead of sys::byte * use std::mutex instead of sys::Mutex * prepare for using std::mutex * use std::lock_guard rather than lock()/unlock() * prepare for std::atomic * prepare for std::mutex * use std::atomic instead of std::mutex * uset std::mutex instead of sys::Mutex * Revert "use std::atomic instead of std::mutex" This reverts commit e16154f381760a2195edb8e3a36d782216550d3f. * use std::atomic better * simplify #includes slightly * using instead of makes Handle simpler * fix warnings about printf() format * fix compiler warnings about using NULL * prepare for enabling more C++ unit-tests # Conflicts: # Test/Test.h # Test/Test.vcxproj # Test/pch.h # modules/c++/pch.h * remove files brought over w/cherry-pick * get rid of more compiler warnings * get rid of more compiler warnings * fix int/int64_t conversion warnings * no more need for __inline on Windows * restore old typdefs for uint64_t et. al. so that existing code still compiles * _WIN32 is better than WIN32 * C wants f(void) instead of f() # Conflicts: # modules/c++/pch.h # modules/c/pch.h * reduce reliance on coda-oss/str * remove dependency on math-c++ * change mem::SharedPtr to std::shared_ptr * change mem::SharedPtr to std::shared_ptr * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * use std::chrono::stead_clock() instead of sys::RealTimeStopWatch * updates from coda-oss * ignore packages/* * fix compiler warning * update externals/coda-oss * use C++11's nullptr instead of NULL * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * __PluginRegistryInitLock is only used for _WIN32 * oops...put __PluginRegistryInitLock inside the wrong #ifdef * latest from coda-oss/develop/master-C++17 * remove code-analysis warnings about using a NULL pointer * restore changes lost in previous merge * restore changes lost in previous merge * remove compiler warnings w/o updating coda-oss * restore externals/coda-oss to same as "master" * restore changes lost in previous merge * copy some documentation from the old website; work-in-progress * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * restore more changes lost in previous merges * restore changes lost in previous merges * restore changes lost in previous merges Co-authored-by: Dan Smith commit c1ddf4cde8f8c114ffbb21b6072a61e7b26acdc8 Author: J. Daniel Smith Date: Sat Sep 12 11:16:37 2020 -0400 Feature/update coda oss (#217) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit d77737f5da4023b356ec19850b96671e4b5b9a7c Author: J. Daniel Smith Date: Sat Sep 12 10:29:12 2020 -0400 update coda-oss (#216) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 * ignore more CMake output * use Ubuntu 20.04 to get a newer version of gcc https://github.com/actions/virtual-environments * turn off Java in an attempt fix MacOS build * build CODA-OSS @C++11 in an attempt fix MacOS failures * std::auto_ptr -> std::unique_ptr * don't compile @C++17 * coda-oss doesn-t build "macos" commit c5c602dd0c0f89391b3828855ef8006dd5b3bb9e Author: J. Daniel Smith Date: Wed Sep 9 17:06:43 2020 -0400 update coda-oss (#214) * latest from coda-oss * Update .gitignore * update externals/coda-oss * coda-oss compiler warning fixes * coda-oss updates to fix compiler warnings * latest from coda-oss/develop/master-C++17 * update with latest master-C++17 from coda-oss * ignore more CMake output * trying to fix Linux build failure on github.com * trying to get unit-tests building * Update master.yml need latest g++ * restore coda-oss from "master" (compiler crash on github.com) * trying again with latest from coda-oss/main * trying to fix compiler crash after coda-oss update * auto_ptr ->unique_ptr for C++17 commit 10eb2e33aad52e2beb65afe250d7dd2203105ba4 Merge: 4c373606 f17909e9 Author: Dan Smith Date: Wed Sep 9 10:16:45 2020 -0400 Merge branch 'develop/remove_compiler_warnings_wo_coda-oss_update' into feature/remove_compiler_warnings commit 4c3736061ae11e1a8ef643518c680ce3d7171e49 Author: Dan Smith Date: Wed Sep 9 08:55:18 2020 -0400 restore externals/coda-oss to same as "master" commit f17909e9aa88df236514826ce0468955852babfa Author: Dan Smith Date: Tue Sep 8 18:30:08 2020 -0400 remove compiler warnings w/o updating coda-oss commit 328962ccff587f7eb92e1290a7f452c4bbd0dc82 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit f970b8b7e7a6ad9d17a6c9675e069fdfd7f70140 Author: Dan Smith Date: Tue Sep 8 17:08:40 2020 -0400 restore changes lost in previous merge commit 70d815a69218bca4086b3e426498c0c298d39a86 Merge: 3af28385 9a609577 Author: Dan Smith Date: Tue Sep 8 16:57:17 2020 -0400 Merge branch 'master' into feature/remove_compiler_warnings commit 3af283859a2ab8b53a4570da6dba2a7228853963 Author: Dan Smith Date: Tue Sep 8 16:23:59 2020 -0400 remove code-analysis warnings about using a NULL pointer commit 999f3c02f4cb94a5656af34a896c3ec7e68f2925 Author: Dan Smith Date: Wed Sep 2 14:08:33 2020 -0400 oops...put __PluginRegistryInitLock inside the wrong #ifdef commit 6dda633c8e818d0215cdbf3567058cdff8266141 Author: Dan Smith Date: Wed Sep 2 13:47:30 2020 -0400 __PluginRegistryInitLock is only used for _WIN32 commit 21932e18b7a653bdd09f821de545191d73ec8131 Author: Dan Smith Date: Mon Aug 10 18:07:26 2020 -0400 fix int/int64_t conversion warnings commit a09349c45bc3436e919fd96f4f4b2d7b1dfece01 Author: Dan Smith Date: Mon Aug 10 17:45:12 2020 -0400 get rid of more compiler warnings commit 5b3dfdd399c7606676084dbc1b2edf0b246b7a15 Author: Dan Smith Date: Mon Aug 10 14:11:32 2020 -0400 fix compiler warnings about using NULL commit 07fc6adc9294ce0c1a258549a5743f5ce490a40f Author: Dan Smith Date: Wed Aug 5 08:51:02 2020 -0400 fix warnings about printf() format commit 9e403f13172419f86b5cc2dc8bf0cdf0e73bbde1 Author: Dan Smith Date: Mon Aug 3 14:05:47 2020 -0400 add back default NITF_DEFAULT_PLUGIN_PATH #define commit 61c3984500995d132da29bf043131de07ddb312b Author: Dan Smith Date: Mon Aug 3 14:01:30 2020 -0400 get WIN32 right commit 55f08f61593e7c1621b13594419d625dff3f1a5d Author: Dan Smith Date: Mon Aug 3 13:43:32 2020 -0400 remove "unused function" compiler warning commit 07896a4e325b49eef05b79abffae6cce7d831c39 Author: Dan Smith Date: Mon Aug 3 13:30:50 2020 -0400 int -> size_t commit c324b750d570866217c5fa30578958144006f7a5 Author: Dan Smith Date: Mon Aug 3 13:08:30 2020 -0400 more compiler-warning cleanup commit 93f76d72504ef061e5017db964bd339e6cf5232d Author: Dan Smith Date: Mon Aug 3 12:57:44 2020 -0400 remove more compiler warnings commit 2706c9a56d122c347c6cefe0610794aacd554c49 Author: Dan Smith Date: Mon Aug 3 12:38:57 2020 -0400 remove several (mostly "unused variable") compiler warnings commit e00059fa90bdefbda39725413def27990afe02c7 Author: Dan Smith Date: Mon Aug 3 11:47:24 2020 -0400 cleanup compiler warnings commit d30f34a7b1c428e55a39b37ff43ea1e21462dcbe Author: Dan Smith Date: Mon Aug 3 11:41:46 2020 -0400 min/max should not be #define'd commit d6c652a9637bc4fcfd8574f28147f7e0abd7b070 Author: Dan Smith Date: Mon Aug 3 11:35:38 2020 -0400 WIN32 isn't always defined, _WIN32 is (leading underscore) commit 7e41ada5221150fed8d10ecc7aa62a3b76217a33 Author: Dan Smith Date: Mon Aug 3 11:28:28 2020 -0400 rename Reader.c and Writer.c to avoid modules with the same name (and VS warnings) commit 5ed948ba62678f097539f3750f04cdae3ec41bc8 Author: Dan Smith Date: Mon Aug 3 11:22:10 2020 -0400 allow unit-tests to work with Visual Studio/GTest commit 0a84476ea9223b10e12044c35fc76f32e15f4457 Author: Dan Smith Date: Mon Aug 3 11:15:14 2020 -0400 use std::to_string() instead of str::toString() commit e6957fad1d4927dc8bafd85e772a2e89e5da19c5 Author: Dan Smith Date: Mon Aug 3 11:04:19 2020 -0400 remove a bunch of compiler warnings (copied from develop/jdsmith) commit 73fac83ba19cd00e4bb6b3de8fd6e1aa77376046 Merge: 624992f1 c83348fd Author: Dan Smith Date: Mon Aug 3 09:43:19 2020 -0400 Merge branch 'master' into jdsmith/master commit 624992f1609b71ede8f7fffafd6db18746e426d5 Merge: cc264a08 a49805f1 Author: Dan Smith Date: Mon Aug 3 09:39:49 2020 -0400 Merge branch 'feature/use_standard_C_types' into jdsmith/master commit a49805f178aba56a09b338f65a1e3c40127bc95d Author: Dan Smith Date: Sat Aug 1 13:50:57 2020 -0400 replace nitf::Uint8 etc with int8_t commit 7a47bafdc34ee00972cbd05b0389e6330e95227e Author: Dan Smith Date: Sat Aug 1 13:31:20 2020 -0400 use standard C types uint8_t, etc. instead of nitf_Uint8 commit 22a2fe955e798ad5662fbdd4520280bf81dd6ecb Author: Dan Smith Date: Sat Aug 1 13:23:12 2020 -0400 use Standard C types "int8_t", etc. instead of our own typedefs commit cc264a086ddee7c4ac0411a7a69c87fa6a40e379 Author: Dan Smith Date: Wed Jul 29 13:58:27 2020 -0400 Update .gitignore commit 54335a4f26a434a8710d50d6005b2ee17660ffae Author: Dan Smith Date: Wed Jul 29 13:44:17 2020 -0400 latest from coda-oss commit 327aec7e6be3b608af62c6c479080886fc1fd48a Author: Dan Smith Date: Mon Apr 11 17:51:57 2022 -0400 tweak exports.hpp for DLL and LIB commit 3711a6e062b90866b40273258f76da80c2362b07 Merge: e5e704c21 758ac88e1 Author: Dan Smith Date: Mon Apr 11 17:46:39 2022 -0400 Merge branch 'master' into develop/remove-compiler-warnings commit e5e704c218b57ef90db33b82506a6fce63edb232 Author: Dan Smith Date: Mon Apr 11 14:04:40 2022 -0400 tweaks to build NITRO modules as DLLs/share-libraries (not actually enabled) commit 854942d169c91460936a39ce66a1d3015ed4475f Merge: 412b9052a af745281c Author: Dan Smith Date: Mon Apr 11 11:44:16 2022 -0400 Merge branch 'master' into develop/remove-compiler-warnings commit 412b9052abc8d4c57f050e2f9f536eb205df2355 Merge: 39347effd a7da2fc74 Author: Dan Smith Date: Mon Apr 11 10:29:25 2022 -0400 Merge branch 'master' into develop/remove-compiler-warnings commit 39347effdf02855f36c8705005f1ada455b1cb51 Author: Dan Smith Date: Wed Apr 6 12:49:09 2022 -0400 fix some compiler warnings commit 51297f5a43b4c7f92515c181638ffd418a30fd1d Author: Dan Smith Date: Wed Apr 6 12:28:58 2022 -0400 fix a noexcept warning commit ccbd7edcdcb39356db07a0a1ad6a74c672968a35 Author: Dan Smith Date: Tue Apr 5 11:44:59 2022 -0400 compile more C code as C++ for better type-checking commit d2adcfdd22f60876b22f20aa317e10493b5040e4 Author: Dan Smith Date: Tue Apr 5 11:02:19 2022 -0400 fix some errors when compiling C as C++ commit c66a902f0ef98d316d0d6a7479d5ea0de436896d Author: Dan Smith Date: Mon Apr 4 18:16:25 2022 -0400 consistent settings in VS2022 --- Test++/pch.h | 14 +++-- Test/pch.h | 14 +++-- .../coda-oss/modules/c++/coda-oss.vcxproj | 1 + .../modules/c++/coda-oss.vcxproj.filters | 3 + .../modules/c++/mt/include/import/mt.h | 16 ++++- modules/c++/cpp.h | 59 ------------------- modules/c++/nitf-c++.vcxproj | 1 - modules/c++/nitf-c++.vcxproj.filters | 1 - modules/c++/nitf/include/nitf/coda-oss.hpp | 31 ++-------- modules/c++/pch.h | 56 ++++++++++++++---- modules/c/j2k/source/OpenJPEGImpl.c | 6 ++ modules/c/nitf-c.vcxproj | 4 ++ modules/c/pch.h | 36 ++++++----- 13 files changed, 114 insertions(+), 128 deletions(-) delete mode 100644 modules/c++/cpp.h diff --git a/Test++/pch.h b/Test++/pch.h index 050a70e79..da88f1cc9 100644 --- a/Test++/pch.h +++ b/Test++/pch.h @@ -8,6 +8,14 @@ #define PCH_H #pragma once +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define NOMINMAX +#pragma warning(push) +#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to 'extern "C"' function under -EHc. Undefined behavior may occur if this function throws an exception. +#include +#pragma warning(pop) +#pragma comment(lib, "ws2_32") + #pragma warning(disable: 4820) // '...': '...' bytes padding added after data member '...' #pragma warning(disable: 4710) // '...': function not inlined #pragma warning(disable: 5045) // Compiler will insert Spectre mitigation for memory load if / Qspectre switch specified @@ -16,12 +24,6 @@ #pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to 'extern "C"' function under -EHc. Undefined behavior may occur if this function throws an exception. #pragma warning(disable: 4514) // '...': unreferenced inline function has been removed -#pragma warning(push) -#pragma warning(disable: 4464) // relative include path contains '..' -#include "../modules/c++/cpp.h" -#pragma warning(pop) -#pragma comment(lib, "ws2_32") - // We're building in Visual Studio ... used to control where we get a little bit of config info #define NITRO_PCH 1 diff --git a/Test/pch.h b/Test/pch.h index fb05af902..2fa0542e0 100644 --- a/Test/pch.h +++ b/Test/pch.h @@ -8,6 +8,14 @@ #define PCH_H #pragma once +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define NOMINMAX +#pragma warning(push) +#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to 'extern "C"' function under -EHc. Undefined behavior may occur if this function throws an exception. +#include +#pragma warning(pop) +#pragma comment(lib, "ws2_32") + #pragma warning(disable: 4820) // '...': '...' bytes padding added after data member '...' #pragma warning(disable: 4710) // '...': function not inlined #pragma warning(disable: 5045) // Compiler will insert Spectre mitigation for memory load if / Qspectre switch specified @@ -16,12 +24,6 @@ #pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to 'extern "C"' function under -EHc. Undefined behavior may occur if this function throws an exception. #pragma warning(disable: 4514) // '...': unreferenced inline function has been removed -#pragma warning(push) -#pragma warning(disable: 4464) // relative include path contains '..' -#include "../modules/c++/cpp.h" -#pragma warning(pop) -#pragma comment(lib, "ws2_32") - // We're building in Visual Studio ... used to control where we get a little bit of config info #define NITRO_PCH 1 diff --git a/externals/coda-oss/modules/c++/coda-oss.vcxproj b/externals/coda-oss/modules/c++/coda-oss.vcxproj index b0c706116..23e530279 100644 --- a/externals/coda-oss/modules/c++/coda-oss.vcxproj +++ b/externals/coda-oss/modules/c++/coda-oss.vcxproj @@ -146,6 +146,7 @@ + diff --git a/externals/coda-oss/modules/c++/coda-oss.vcxproj.filters b/externals/coda-oss/modules/c++/coda-oss.vcxproj.filters index 2b1f01308..e0bf43bef 100644 --- a/externals/coda-oss/modules/c++/coda-oss.vcxproj.filters +++ b/externals/coda-oss/modules/c++/coda-oss.vcxproj.filters @@ -963,6 +963,9 @@ hdf5.lite + + mt + diff --git a/externals/coda-oss/modules/c++/mt/include/import/mt.h b/externals/coda-oss/modules/c++/mt/include/import/mt.h index 10caa17e6..2a35e189c 100644 --- a/externals/coda-oss/modules/c++/mt/include/import/mt.h +++ b/externals/coda-oss/modules/c++/mt/include/import/mt.h @@ -21,8 +21,14 @@ */ -#ifndef __IMPORT_MT_H__ -#define __IMPORT_MT_H__ +#pragma once +#ifndef CODA_OSS_mt_import_mt_h_h_INCLUDED_ +#define CODA_OSS_mt_import_mt_h_h_INCLUDED_ + +#if _MSC_VER +#pragma warning(push) +#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to 'extern "C"' function under - EHc.Undefined behavior may occur if this function throws an exception. +#endif // _MSC_VER #include "mt/RequestQueue.h" #include "mt/ThreadPoolException.h" @@ -45,4 +51,8 @@ #include "mt/CPUAffinityThreadInitializer.h" #include "mt/Algorithm.h" -#endif +#if _MSC_VER +#pragma warning(pop) +#endif // _MSC_VER + +#endif // CODA_OSS_mt_import_mt_h_h_INCLUDED_ diff --git a/modules/c++/cpp.h b/modules/c++/cpp.h deleted file mode 100644 index 931c7632d..000000000 --- a/modules/c++/cpp.h +++ /dev/null @@ -1,59 +0,0 @@ -#pragma once - -#pragma warning(push) -#pragma warning(disable: 4619) // #pragma warning: there is no warning number '...' - -#pragma warning(disable: 4668) // '...' is not defined as a preprocessor macro, replacing with '...' for '...' -#pragma warning(disable: 4820) // '...': '...' bytes padding added after data member '...' -#pragma warning(disable: 4710) // '...': function not inlined - -#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to 'extern "C"' function under - EHc.Undefined behavior may occur if this function throws an exception. -#pragma warning(disable: 5219) // implicit conversion from '...' to '...', possible loss of data -#pragma warning(disable: 4355) // '...': used in base member initializer list -#pragma warning(disable: 5220) // '...': a non - static data member with a volatile qualified type no longer implies -#pragma warning(disable: 5204) // '...': class has virtual functions, but its trivial destructor is not virtual; instances of objects derived from this class may not be destructed correctly -#pragma warning(disable: 4625) // '...': copy constructor was implicitly defined as deleted -#pragma warning(disable: 4626) // '...': assignment operator was implicitly defined as deleted -#pragma warning(disable: 5026) // '...': move constructor was implicitly defined as deleted -#pragma warning(disable: 5027) // '...': move assignment operator was implicitly defined as deleted -#pragma warning(disable: 5219) // implicit conversion from '...' to '...', possible loss of data -#pragma warning(disable: 6285) // ( || ) is always a non-zero constant. Did you intend to use the bitwise-and operator? -#pragma warning(disable: 5264) // '...': '...' variable is not used - -#define _USE_MATH_DEFINES -#include -#include -#include -#include -#include -#include -#include -#include -#include - -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include - -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers -#include -#undef min -#undef max -#pragma warning(pop) diff --git a/modules/c++/nitf-c++.vcxproj b/modules/c++/nitf-c++.vcxproj index 7a9669171..1f855894c 100644 --- a/modules/c++/nitf-c++.vcxproj +++ b/modules/c++/nitf-c++.vcxproj @@ -86,7 +86,6 @@ - diff --git a/modules/c++/nitf-c++.vcxproj.filters b/modules/c++/nitf-c++.vcxproj.filters index 05d9a5eaa..2ae0875ad 100644 --- a/modules/c++/nitf-c++.vcxproj.filters +++ b/modules/c++/nitf-c++.vcxproj.filters @@ -412,7 +412,6 @@ Header Files - Header Files diff --git a/modules/c++/nitf/include/nitf/coda-oss.hpp b/modules/c++/nitf/include/nitf/coda-oss.hpp index bb4e9720f..5fd053f32 100644 --- a/modules/c++/nitf/include/nitf/coda-oss.hpp +++ b/modules/c++/nitf/include/nitf/coda-oss.hpp @@ -22,19 +22,16 @@ #pragma once -#if _MSC_VER -#pragma warning(disable: 5032) // detected #pragma warning(push) with no corresponding #pragma warning(pop) -#pragma warning(push) -#pragma warning(disable: 26487) // Don't return a pointer '...' that may be invalid (lifetime.4). -#pragma warning(disable: 5031) // #pragma warning(pop): likely mismatch, popping warning state pushed in different file -#endif // _MSC_VER +#include "config/disable_compiler_warnings.h" -#include // std::endian -#include // std::byte +#include "import/std.h" +#include +#include #include #include #include +CODA_OSS_disable_warning_push #if _MSC_VER #pragma warning(disable: 26432) // If you define or delete any default operation in the type '...', define or delete them all(c.21). #pragma warning(disable: 26447) // The function is declared '...' but calls function '..' which may throw exceptions (f.6). @@ -52,29 +49,13 @@ #include #include - #include #include -#if _MSC_VER -#pragma warning(push) -#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to 'extern "C"' function under - EHc.Undefined behavior may occur if this function throws an exception. -#endif // _MSC_VER #include -#if _MSC_VER -#pragma warning(pop) -#endif // _MSC_VER #include - -#include -#include -#include #include -#include #include #include - #include -#if _MSC_VER -#pragma warning(pop) -#endif // _MSC_VER +CODA_OSS_disable_warning_pop diff --git a/modules/c++/pch.h b/modules/c++/pch.h index a969486e3..2d5aa6125 100644 --- a/modules/c++/pch.h +++ b/modules/c++/pch.h @@ -1,5 +1,36 @@ #pragma once +#include "coda_oss/CPlusPlus.h" +#include "config/disable_compiler_warnings.h" + +CODA_OSS_disable_warning_system_header_push + +#define _USE_MATH_DEFINES +#include +#include +#include +#include +#include +#include +#include +#include + +CODA_OSS_disable_warning_pop + +#include "import/std.h" +#include +#include +#include +#include +#include + +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define NOMINMAX +#pragma warning(push) +#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to 'extern "C"' function under -EHc. Undefined behavior may occur if this function throws an exception. +#include +#pragma warning(pop) + #pragma warning(disable: 4619) // #pragma warning: there is no warning number '...' #pragma warning(disable: 4820) // '...': '...' bytes padding added after data member '...' #pragma warning(disable: 4710) // '...': function not inlined @@ -10,27 +41,17 @@ #pragma warning(disable: 4514) // '...': unreferenced inline function has been removed #pragma warning(disable: 26823) // Dereferencing a possibly null pointer '...' (lifetime.1). -#include "cpp.h" -#pragma comment(lib, "ws2_32") - #pragma warning(disable: 26822) // Dereferencing a null pointer '...' (lifetime.1). #pragma warning(disable: 26467) // Converting from floating point to unsigned integral types results in non-portable code if the double/float has a negative value. Use gsl::narrow_cast or gsl::narrow instead to guard against undefined behavior and potential data loss(es.46). // changing this breaks SWIG #pragma warning (disable: 26812) // The enum type '...' is unscoped. Prefer '...' over '...' -#include "nitf/coda-oss.hpp" - -#pragma comment(lib, "io-c++") -#pragma comment(lib, "except-c++") -#pragma comment(lib, "sys-c++") -#pragma comment(lib, "str-c++") -#pragma comment(lib, "mt-c++") -#pragma comment(lib, "math-c++") - // We're building in Visual Studio ... used to control where we get a little bit of config info #define NITRO_PCH 1 +// Yes, these are our files ... but they don't change very often, and if they do +// change we want to rebuild everything anyway. #include "import/nitf.h" #include "nitf/ImageIO.h" #include "nitf/System.h" @@ -49,4 +70,15 @@ #pragma warning(disable: 26486) // Don't pass a pointer that may be invalid to a function. Parameter '...' in call to '...' may be invalid (lifetime.3). #pragma warning(disable: 26487) // Don't return a pointer '...' that may be invalid(lifetime.4). +// Yes, these are our files ... but they don't change very often, and if they do +// change we want to rebuild everything anyway. #include "nitf/Object.hpp" +#include "nitf/Handle.hpp" + +#include "nitf/coda-oss.hpp" +#pragma comment(lib, "io-c++") +#pragma comment(lib, "except-c++") +#pragma comment(lib, "sys-c++") +#pragma comment(lib, "str-c++") +#pragma comment(lib, "mt-c++") +#pragma comment(lib, "math-c++") \ No newline at end of file diff --git a/modules/c/j2k/source/OpenJPEGImpl.c b/modules/c/j2k/source/OpenJPEGImpl.c index 7dd0999b3..11687c50f 100644 --- a/modules/c/j2k/source/OpenJPEGImpl.c +++ b/modules/c/j2k/source/OpenJPEGImpl.c @@ -281,10 +281,16 @@ OpenJPEG_cleanup(opj_stream_t **stream, opj_codec_t **codec, /******************************************************************************/ // these are private to cio.h +#if __cplusplus +extern "C" { +#endif extern OPJ_OFF_T opj_stream_tell(const opj_stream_t*); extern int opj_stream_read_seek(opj_stream_t*, OPJ_OFF_T p_size, void* p_event_mgr); extern OPJ_SIZE_T opj_stream_read_data(opj_stream_t*, OPJ_BYTE* p_buffer, OPJ_SIZE_T p_size, void* p_event_mgr); extern OPJ_OFF_T opj_stream_get_number_byte_left(const opj_stream_t*); +#if __cplusplus +} +#endif // This is our own to distingish an error from an expected failure OPJ_CODEC_FORMAT nitf_OPJ_CODEC_ERROR_ = (OPJ_CODEC_FORMAT)(OPJ_CODEC_UNKNOWN - 1); // i.e., -2 diff --git a/modules/c/nitf-c.vcxproj b/modules/c/nitf-c.vcxproj index 45fa8fa67..3e2559b63 100644 --- a/modules/c/nitf-c.vcxproj +++ b/modules/c/nitf-c.vcxproj @@ -66,6 +66,8 @@ true true AdvancedVectorExtensions2 + CompileAsCpp + false @@ -90,6 +92,8 @@ true Level3 AdvancedVectorExtensions2 + CompileAsCpp + false diff --git a/modules/c/pch.h b/modules/c/pch.h index c022b32c0..c6c7a9bde 100644 --- a/modules/c/pch.h +++ b/modules/c/pch.h @@ -3,24 +3,20 @@ // We're building in Visual Studio ... used to control where we get a little bit of config info #define NITRO_PCH 1 -#pragma warning(disable: 4668) // '...' is not defined as a preprocessor macro, replacing with '...' for '...' -#pragma warning(disable: 4820) // '...': '...' bytes padding added after data member '...' -#pragma warning(disable: 4710) // '...': function not inlined -#pragma warning(disable: 4774) // '...' : format string expected in argument 3 is not a string literal -#pragma warning(disable: 5045) // Compiler will insert Spectre mitigation for memory load if / Qspectre switch specified +#include "config/disable_compiler_warnings.h" // TODO: get rid of these someday? ... from Visual Studio code-analysis #pragma warning(disable: 6385) // Reading invalid data from '...': the readable size is '...' bytes, but '...' bytes may be read. #pragma warning(disable: 6386) // Buffer overrun while writing to '...': the writable size is '...' bytes, but '...' bytes might be written. - -#pragma warning(push) -#pragma warning(disable: 4255) // '...': no function prototype given : converting '...' to '...' -#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to '...' function under -EHc. Undefined behavior may occur if this function throws an exception. -#pragma warning(disable: 5105) // macro expansion producing '...' has undefined behavior - #define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers #include +#if defined(_WIN32) +#undef BIGENDIAN +#include +#else +#include +#endif #include #include @@ -33,11 +29,21 @@ #include #include +#include +#include + #include -#pragma warning(pop) -#pragma warning(disable: 4505) // '...': unreferenced local function has been removed -#pragma warning(disable: 4514) // '...' : unreferenced inline function has been removed -#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to '...' function under -EHc. Undefined behavior may occur if this function throws an exception. +#pragma warning(disable: 4505) // '...': unreferenced function with internal linkage has been removed +#pragma warning(disable: 4774) // '...' : format string expected in argument 3 is not a string literal + +#if __cplusplus +#pragma warning(disable: 4365) // '...': conversion from '...' to '...', signed/unsigned mismatch +#pragma warning(disable: 4800) // Implicit conversion from '...' to bool. Possible information loss +#pragma warning(disable: 4804) // '...: unsafe use of type '...' in operation +#pragma warning(disable: 5219) // implicit conversion from '...' to '...', possible loss of data +#pragma warning(disable: 4191) // '...': unsafe conversion from '...' to '...' +#pragma warning(disable: 4244) // '...': conversion from '...' to '...', possible loss of data +#endif #define OPJ_STATIC From 3ca5b34eeaf80b412b84d145c541ba4bad5475b1 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Wed, 12 Jul 2023 14:38:27 -0400 Subject: [PATCH 037/104] develop/sync_externals --- .../c++/dbi/source/MySQLConnection.cpp | 2 +- .../c++/dbi/source/OracleConnection.cpp | 10 +++---- .../c++/dbi/source/PgSQLConnection.cpp | 2 +- .../c++/except/include/except/Throwable.h | 2 +- .../c++/hdf5.lite/include/hdf5/lite/H5_.h | 2 ++ .../modules/c++/hdf5.lite/source/H5.h | 7 ++--- .../modules/c++/hdf5.lite/source/hdf5.lite.h | 7 ++--- .../c++/hdf5.lite/unittests/test_highfive.cpp | 6 +--- .../c++/math/tests/complexBenchmark.cpp | 4 +-- .../math/tests/complexMultiplyBenchmark.cpp | 4 +-- .../c++/mem/tests/ScratchVisualization.cpp | 2 +- .../c++/mem/unittests/test_scratch_memory.cpp | 2 +- .../c++/mem/unittests/test_shared_ptr.cpp | 12 ++++---- .../c++/net.ssl/source/SSLConnection.cpp | 4 +-- .../c++/net/tests/AckMulticastSender.cpp | 4 +-- .../c++/net/tests/NetConnectionServerTest.cpp | 2 +- .../modules/c++/net/tests/TCPClientTest.cpp | 2 +- .../modules/c++/net/tests/UDPClientTest.cpp | 2 +- .../include/numpyutils/numpyutils.h | 28 ++++++++++++++++++- .../c++/numpyutils/source/numpyutils.cpp | 11 +++----- .../modules/c++/re/include/re/Regex.h | 2 +- .../modules/c++/re/source/RegexPCRE.cpp | 18 ++++++------ .../c++/sys/source/ConditionVarPosix.cpp | 6 ++-- .../modules/c++/sys/source/DLLUnix.cpp | 2 +- .../modules/c++/sys/source/DateTime.cpp | 2 +- .../modules/c++/sys/source/ExecUnix.cpp | 2 +- .../modules/c++/sys/source/MutexPosix.cpp | 2 +- .../modules/c++/sys/source/OSUnix.cpp | 2 +- .../c++/sys/source/ScopedCPUAffinityUnix.cpp | 2 +- .../modules/c++/sys/source/ThreadPosix.cpp | 4 +-- .../modules/c++/sys/tests/DateTimeTest.cpp | 4 +-- .../coda-oss/modules/c++/sys/tests/OSTest.cpp | 4 +-- .../c++/xml.lite/include/xml/lite/xerces_.h | 5 ++++ .../c++/zip/source/ZipOutputStream.cpp | 4 +-- 34 files changed, 99 insertions(+), 75 deletions(-) diff --git a/externals/coda-oss/modules/c++/dbi/source/MySQLConnection.cpp b/externals/coda-oss/modules/c++/dbi/source/MySQLConnection.cpp index 9f0e6aae3..49c01f304 100644 --- a/externals/coda-oss/modules/c++/dbi/source/MySQLConnection.cpp +++ b/externals/coda-oss/modules/c++/dbi/source/MySQLConnection.cpp @@ -38,7 +38,7 @@ bool dbi::MySQLConnection::connect(const std::string& database, if (!mysql_real_connect(&mDBHandle, host.c_str(), user.c_str(), pass.c_str(), database.c_str(), port, - NULL, 0)) + nullptr, 0)) { return false; } diff --git a/externals/coda-oss/modules/c++/dbi/source/OracleConnection.cpp b/externals/coda-oss/modules/c++/dbi/source/OracleConnection.cpp index 66ff79cb5..a03203e4f 100644 --- a/externals/coda-oss/modules/c++/dbi/source/OracleConnection.cpp +++ b/externals/coda-oss/modules/c++/dbi/source/OracleConnection.cpp @@ -80,7 +80,7 @@ const std::string dbi::OracleConnection::getLastErrorMessage() char errbuf[100]; memset(errbuf, 0, 100); int errcode; - OCIErrorGet((dvoid *)mErrorHandle, (ub4) 1, (text *) NULL, &errcode, + OCIErrorGet((dvoid *)mErrorHandle, (ub4) 1, (text *) nullptr, &errcode, (OraText*)errbuf, (ub4) sizeof(errbuf), OCI_HTYPE_ERROR); if (strlen(errbuf) > 0) return std::string(errbuf); @@ -117,7 +117,7 @@ dbi::pResultSet dbi::OracleConnection::query(const std::string& q) OCIStmtPrepare(countHandle, mErrorHandle, (const OraText*)countq.c_str(), (ub4)countq.length(), (ub4) OCI_NTV_SYNTAX, (ub4) OCI_DEFAULT); OCIStmtExecute(mContextHandle, countHandle, mErrorHandle, (ub4)val, (ub4)0, - (CONST OCISnapshot *) NULL, (OCISnapshot *) NULL, OCI_DEFAULT); + (CONST OCISnapshot *) nullptr, (OCISnapshot *) nullptr, OCI_DEFAULT); OCIDefine * defineHandle = nullptr; OCIDefineByPos(countHandle, &defineHandle, mErrorHandle, 1, &rowCount, sizeof(rowCount), SQLT_UIN, 0, 0, 0, OCI_DEFAULT); @@ -126,7 +126,7 @@ dbi::pResultSet dbi::OracleConnection::query(const std::string& q) /* Execute the SQL statment */ OCIStmtExecute(mContextHandle, sqlHandle, mErrorHandle, (ub4) val, (ub4) 0, - (CONST OCISnapshot *) NULL, (OCISnapshot *) NULL, OCI_DEFAULT); + (CONST OCISnapshot *) nullptr, (OCISnapshot *) nullptr, OCI_DEFAULT); return dbi::pResultSet(new dbi::OracleResultSet(sqlHandle, mErrorHandle, rowCount)); } @@ -229,8 +229,8 @@ dbi::Row dbi::OracleResultSet::fetchRow() ub4 bufferSize = 9; OCIDateToText(mErrorHandle, (const OCIDate*)fields[i].value, - NULL, 0, - NULL, 0, &bufferSize, (text*)buffer); + nullptr, 0, + nullptr, 0, &bufferSize, (text*)buffer); memset(fields[i].value, '\0', sizeof(OCIDate)); strncpy(fields[i].value, buffer, bufferSize); } diff --git a/externals/coda-oss/modules/c++/dbi/source/PgSQLConnection.cpp b/externals/coda-oss/modules/c++/dbi/source/PgSQLConnection.cpp index 5e9519dd7..fc5a86a97 100644 --- a/externals/coda-oss/modules/c++/dbi/source/PgSQLConnection.cpp +++ b/externals/coda-oss/modules/c++/dbi/source/PgSQLConnection.cpp @@ -97,7 +97,7 @@ dbi::pResultSet dbi::PgSQLConnection::query(const std::string& q) throw dbi::SQLException(Ctxt(errorMessage)); } - return dbi::pResultSet(new PgSQLResultSet(NULL)); + return dbi::pResultSet(new PgSQLResultSet(nullptr)); } dbi::Row dbi::PgSQLResultSet::fetchRow() diff --git a/externals/coda-oss/modules/c++/except/include/except/Throwable.h b/externals/coda-oss/modules/c++/except/include/except/Throwable.h index 84fe4d038..b71c77250 100644 --- a/externals/coda-oss/modules/c++/except/include/except/Throwable.h +++ b/externals/coda-oss/modules/c++/except/include/except/Throwable.h @@ -265,7 +265,7 @@ class ThrowableEx : public Throwable // "ThrowableEx" = "Throwable exception" ThrowableEx(const Throwable& t, const Context& ctx) : Throwable(t, ctx) {} #if !CODA_OSS_except_Throwable_ISA_std_exception - const char* what() const noexcept final // derived classes override toString() + const char* what() const noexcept override final // derived classes override toString() { const Throwable* pThrowable = this; return pThrowable->what(); diff --git a/externals/coda-oss/modules/c++/hdf5.lite/include/hdf5/lite/H5_.h b/externals/coda-oss/modules/c++/hdf5.lite/include/hdf5/lite/H5_.h index 74ebc436c..a624c2eff 100644 --- a/externals/coda-oss/modules/c++/hdf5.lite/include/hdf5/lite/H5_.h +++ b/externals/coda-oss/modules/c++/hdf5.lite/include/hdf5/lite/H5_.h @@ -56,6 +56,8 @@ CODA_OSS_disable_warning(-Wzero-as-null-pointer-constant) #include #include +#include +#include #include #include #include diff --git a/externals/coda-oss/modules/c++/hdf5.lite/source/H5.h b/externals/coda-oss/modules/c++/hdf5.lite/source/H5.h index 24b0d8cfc..ecfe293d1 100644 --- a/externals/coda-oss/modules/c++/hdf5.lite/source/H5.h +++ b/externals/coda-oss/modules/c++/hdf5.lite/source/H5.h @@ -20,17 +20,16 @@ * */ +#pragma once #ifndef CODA_OSS_hdf5_lite_H5_h_INCLUDED_ #define CODA_OSS_hdf5_lite_H5_h_INCLUDED_ -#pragma once #include -// see https://docs.hdfgroup.org/archive/support/HDF5/doc1.8/cpplus_RM/readdata_8cpp-example.html -#include - #include "types/RowCol.h" +#include "hdf5/lite/H5_.h" + // Utility routines for INTERNAL use! namespace hdf5 diff --git a/externals/coda-oss/modules/c++/hdf5.lite/source/hdf5.lite.h b/externals/coda-oss/modules/c++/hdf5.lite/source/hdf5.lite.h index fce6fb7c0..29617ac23 100644 --- a/externals/coda-oss/modules/c++/hdf5.lite/source/hdf5.lite.h +++ b/externals/coda-oss/modules/c++/hdf5.lite/source/hdf5.lite.h @@ -20,18 +20,17 @@ * */ +#pragma once #ifndef CODA_OSS_hdf5_lite_hdf5_lite_h_INCLUDED_ #define CODA_OSS_hdf5_lite_hdf5_lite_h_INCLUDED_ -#pragma once #include #include #include -// see https://docs.hdfgroup.org/archive/support/HDF5/doc1.8/cpplus_RM/readdata_8cpp-example.html -#include - #include "except/Exception.h" + +#include "hdf5/lite/H5_.h" #include "hdf5/lite/HDF5Exception.h" // Utility routines for INTERNAL use! diff --git a/externals/coda-oss/modules/c++/hdf5.lite/unittests/test_highfive.cpp b/externals/coda-oss/modules/c++/hdf5.lite/unittests/test_highfive.cpp index 14e9f8af2..b506e4948 100644 --- a/externals/coda-oss/modules/c++/hdf5.lite/unittests/test_highfive.cpp +++ b/externals/coda-oss/modules/c++/hdf5.lite/unittests/test_highfive.cpp @@ -29,12 +29,8 @@ #include "types/RowCol.h" #include "mem/ComplexView.h" -#include "highfive/H5Easy.hpp" -#include "highfive/H5DataSet.hpp" -#include "highfive/H5File.hpp" - -#include "hdf5/lite/SpanRC.h" #include "hdf5/lite/highfive.h" +#include "hdf5/lite/SpanRC.h" static std::filesystem::path find_unittest_file(const std::filesystem::path& name) { diff --git a/externals/coda-oss/modules/c++/math/tests/complexBenchmark.cpp b/externals/coda-oss/modules/c++/math/tests/complexBenchmark.cpp index 2de00abbc..9484150c9 100644 --- a/externals/coda-oss/modules/c++/math/tests/complexBenchmark.cpp +++ b/externals/coda-oss/modules/c++/math/tests/complexBenchmark.cpp @@ -217,7 +217,7 @@ void loopingBenchmark(size_t size, std::vector > arr(size); //fill the vector based on a random number - srand(static_cast(time(NULL))); + srand(static_cast(time(nullptr))); auto real = static_cast(rand() % 100 + 1); auto imag = static_cast(rand() % 100 + 1); @@ -321,7 +321,7 @@ void singlePassBenchmark(size_t size, std::vector > arr; arr.reserve(endSize); - srand(static_cast(time(NULL))); + srand(static_cast(time(nullptr))); auto real = static_cast(rand() % 100 + 1); auto imag = static_cast(rand() % 100 + 1); diff --git a/externals/coda-oss/modules/c++/math/tests/complexMultiplyBenchmark.cpp b/externals/coda-oss/modules/c++/math/tests/complexMultiplyBenchmark.cpp index 3f7b19ac9..12ea42619 100644 --- a/externals/coda-oss/modules/c++/math/tests/complexMultiplyBenchmark.cpp +++ b/externals/coda-oss/modules/c++/math/tests/complexMultiplyBenchmark.cpp @@ -199,7 +199,7 @@ void loopingBenchmark(size_t size, std::vector > arr(size); //fill the vector based on a random number - srand(static_cast(time(NULL))); + srand(static_cast(time(nullptr))); auto real = static_cast(rand() % 100 + 1); auto imag = static_cast(rand() % 100 + 1); @@ -297,7 +297,7 @@ void singlePassBenchmark(size_t size, std::vector > arr; arr.reserve(endSize); - srand(static_cast(time(NULL))); + srand(static_cast(time(nullptr))); auto real = static_cast(rand() % 100 + 1); auto imag = static_cast(rand() % 100 + 1); diff --git a/externals/coda-oss/modules/c++/mem/tests/ScratchVisualization.cpp b/externals/coda-oss/modules/c++/mem/tests/ScratchVisualization.cpp index 20974a659..791964c72 100644 --- a/externals/coda-oss/modules/c++/mem/tests/ScratchVisualization.cpp +++ b/externals/coda-oss/modules/c++/mem/tests/ScratchVisualization.cpp @@ -72,7 +72,7 @@ class Visualizer mHTMLFile(htmlFile), mCSSFile(cssFile) { - mStartPtr = NULL; + mStartPtr = nullptr; mColors.push_back("lightgrey"); mColors.push_back("lightblue"); mColors.push_back("lightcyan"); diff --git a/externals/coda-oss/modules/c++/mem/unittests/test_scratch_memory.cpp b/externals/coda-oss/modules/c++/mem/unittests/test_scratch_memory.cpp index 8ef51ee4f..5186e8956 100644 --- a/externals/coda-oss/modules/c++/mem/unittests/test_scratch_memory.cpp +++ b/externals/coda-oss/modules/c++/mem/unittests/test_scratch_memory.cpp @@ -617,7 +617,7 @@ TEST_CASE(testScratchMemory) TEST_EXCEPTION(scratch.setup(smallBuffer)); // calling setup with invalid external buffer should throw - mem::BufferView invalidBuffer(NULL, buffer.size); + mem::BufferView invalidBuffer(nullptr, buffer.size); TEST_EXCEPTION(scratch.setup(invalidBuffer)); } diff --git a/externals/coda-oss/modules/c++/mem/unittests/test_shared_ptr.cpp b/externals/coda-oss/modules/c++/mem/unittests/test_shared_ptr.cpp index 866df1eb7..1441f4723 100644 --- a/externals/coda-oss/modules/c++/mem/unittests/test_shared_ptr.cpp +++ b/externals/coda-oss/modules/c++/mem/unittests/test_shared_ptr.cpp @@ -69,19 +69,19 @@ size_t cpp11Function(std::shared_ptr foo) TEST_CASE(testNullCopying) { mem::SharedPtr ptr1; - TEST_ASSERT_EQ(ptr1.get(), static_cast(NULL)); + TEST_ASSERT_EQ(ptr1.get(), static_cast(nullptr)); // Copy construction const mem::SharedPtr ptr2(ptr1); - TEST_ASSERT_EQ(ptr2.get(), static_cast(NULL)); + TEST_ASSERT_EQ(ptr2.get(), static_cast(nullptr)); // Assignment operator mem::SharedPtr ptr3; ptr3 = ptr1; - TEST_ASSERT_EQ(ptr3.get(), static_cast(NULL)); + TEST_ASSERT_EQ(ptr3.get(), static_cast(nullptr)); ptr1.reset(); - TEST_ASSERT_EQ(ptr1.get(), static_cast(NULL)); + TEST_ASSERT_EQ(ptr1.get(), static_cast(nullptr)); } TEST_CASE(testAutoPtrConstructor) @@ -90,7 +90,7 @@ TEST_CASE(testAutoPtrConstructor) std::unique_ptr autoPtr(rawPtr); const mem::SharedPtr ptr(autoPtr.release()); TEST_ASSERT_EQ(ptr.get(), rawPtr); - TEST_ASSERT_EQ(autoPtr.get(), static_cast(NULL)); + TEST_ASSERT_EQ(autoPtr.get(), static_cast(nullptr)); //TEST_ASSERT_EQ(ptr.getCount(), 1); TEST_ASSERT_EQ(ptr.use_count(), 1); TEST_ASSERT_EQ(getCount(ptr), 1); @@ -287,7 +287,7 @@ TEST_CASE(testCasting) std::unique_ptr autoBar(rawBar); const mem::SharedPtr fooPtr(autoBar.release()); TEST_ASSERT_EQ(fooPtr.get(), rawBar); - TEST_ASSERT_EQ(autoBar.get(), static_cast(NULL)); + TEST_ASSERT_EQ(autoBar.get(), static_cast(nullptr)); //TEST_ASSERT_EQ(fooPtr.getCount(), 1); TEST_ASSERT_EQ(fooPtr.use_count(), 1); TEST_ASSERT_EQ(getCount(fooPtr), 1); diff --git a/externals/coda-oss/modules/c++/net.ssl/source/SSLConnection.cpp b/externals/coda-oss/modules/c++/net.ssl/source/SSLConnection.cpp index 75c7f5e03..903fa077d 100644 --- a/externals/coda-oss/modules/c++/net.ssl/source/SSLConnection.cpp +++ b/externals/coda-oss/modules/c++/net.ssl/source/SSLConnection.cpp @@ -45,11 +45,11 @@ net::ssl::SSLConnection::SSLConnection(std::unique_ptr&& socket, net::ssl::SSLConnection::~SSLConnection() { - if(mSSL != NULL) + if(mSSL != nullptr) { SSL_shutdown(mSSL); } - if(mSSL != NULL) + if(mSSL != nullptr) { SSL_free(mSSL); } diff --git a/externals/coda-oss/modules/c++/net/tests/AckMulticastSender.cpp b/externals/coda-oss/modules/c++/net/tests/AckMulticastSender.cpp index a5c97008a..e02d52752 100644 --- a/externals/coda-oss/modules/c++/net/tests/AckMulticastSender.cpp +++ b/externals/coda-oss/modules/c++/net/tests/AckMulticastSender.cpp @@ -143,8 +143,8 @@ template class AckMulticastSender //FD_SET(mAckChannel->getHandle(), &writers); assert(FD_ISSET(mAckChannel->getHandle(), &readers)); //int rv = 1; - int rv = ::select(mAckChannel->getHandle() + 1, &readers, NULL, - NULL, &tv); + int rv = ::select(mAckChannel->getHandle() + 1, &readers, nullptr, + nullptr, &tv); if (rv < 0) { throw sys::SocketException(Ctxt("Select failed")); diff --git a/externals/coda-oss/modules/c++/net/tests/NetConnectionServerTest.cpp b/externals/coda-oss/modules/c++/net/tests/NetConnectionServerTest.cpp index bcbb46ac1..ed72a907b 100644 --- a/externals/coda-oss/modules/c++/net/tests/NetConnectionServerTest.cpp +++ b/externals/coda-oss/modules/c++/net/tests/NetConnectionServerTest.cpp @@ -76,7 +76,7 @@ int main(int argc, char **argv) if (argc < 2) throw Exception(FmtX("Usage: %s (-mt|-st|-tp)", argv[0])); - net::AllocStrategy* strategy = NULL; + net::AllocStrategy* strategy = nullptr; if (argc == 3) { diff --git a/externals/coda-oss/modules/c++/net/tests/TCPClientTest.cpp b/externals/coda-oss/modules/c++/net/tests/TCPClientTest.cpp index 47a9c10a0..0ca69b276 100644 --- a/externals/coda-oss/modules/c++/net/tests/TCPClientTest.cpp +++ b/externals/coda-oss/modules/c++/net/tests/TCPClientTest.cpp @@ -60,7 +60,7 @@ int main(int argc, char** argv) std::unique_ptr socket = TCPClientSocketFactory().create(sa); my_packet_t packet; packet.packet_no = 1; - packet.time_stamp = time(NULL); + packet.time_stamp = time(nullptr); socket->send(&packet, sizeof(my_packet_t)); int rv; socket->recv(&rv, sizeof(int)); diff --git a/externals/coda-oss/modules/c++/net/tests/UDPClientTest.cpp b/externals/coda-oss/modules/c++/net/tests/UDPClientTest.cpp index 76fed3372..ae2e28ba2 100644 --- a/externals/coda-oss/modules/c++/net/tests/UDPClientTest.cpp +++ b/externals/coda-oss/modules/c++/net/tests/UDPClientTest.cpp @@ -66,7 +66,7 @@ int main(int argc, char** argv) std::unique_ptr socket = UDPClientSocketFactory().create(sa); my_packet_t packet; packet.packet_no = 1; - packet.time_stamp = time(NULL); + packet.time_stamp = time(nullptr); socket->send((const char*)&packet, sizeof(my_packet_t)); int rv; socket->recv((char*)&rv, sizeof(int)); diff --git a/externals/coda-oss/modules/c++/numpyutils/include/numpyutils/numpyutils.h b/externals/coda-oss/modules/c++/numpyutils/include/numpyutils/numpyutils.h index fec9e9e64..4632913dd 100644 --- a/externals/coda-oss/modules/c++/numpyutils/include/numpyutils/numpyutils.h +++ b/externals/coda-oss/modules/c++/numpyutils/include/numpyutils/numpyutils.h @@ -20,14 +20,40 @@ * */ +#pragma once #ifndef __NUMPYUTILS_NUMPYUTILS_H__ #define __NUMPYUTILS_NUMPYUTILS_H__ #define NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION #include -#include CODA_OSS_disable_warning_system_header_push +#if _MSC_VER +#pragma warning(disable: 26493) // Don't use C-style casts (type.4). +#pragma warning(disable: 26494) // Variable '...' is uninitialized. Always initialize an object (type.5). +#pragma warning(disable: 26451) // Arithmetic overflow: Using operator '...' on a 4 byte value and then casting the result to a 8 byte value. Cast the value to the wider type before calling operator '...' to avoid overflow (io.2). +#pragma warning(disable: 26814) // The const variable '...' can be computed at compile-time. Consider using constexpr (con.5). +#pragma warning(disable: 26447) // The function is declared '...' but calls function '...' which may throw exceptions (f.6). +#pragma warning(disable: 26455) // Default constructor should not throw. Declare it '...' (f.6). +#pragma warning(disable: 26440) // Function '...' can be declared '...' (f.6). +#pragma warning(disable: 26496) // The variable '...' does not change after construction, mark it as const (con.4). +#pragma warning(disable: 26462) // The value pointed to by '...' is assigned only once, mark it as a pointer to const (con.4). +#pragma warning(disable: 26435) // Function '...' should specify exactly one of '...', '...', or '...' (c.128). +#pragma warning(disable: 26433) // Function '...' should be marked with '...' (c.128). +#pragma warning(disable: 26497) // You can attempt to make '...' constexpr unless it contains any undefined behavior (f.4). +#pragma warning(disable: 26433) // Function '...' should be marked with '...' (c.128). +#pragma warning(disable: 26456) // Operator '...' hides a non-virtual operator '...' (c.128). +#pragma warning(disable: 26446) // Prefer to use gsl::at() instead of unchecked subscript operator (bounds.4). +#pragma warning(disable: 26477) // Use '...' rather than 0 or NULL(es .47). +#pragma warning(disable: 26457) // (void) should not be used to ignore return values, use '...' instead (es.48). +#pragma warning(disable: 26813) // Use '...' to check if a flag is set. +#else +CODA_OSS_disable_warning(-Wshadow) +CODA_OSS_disable_warning(-Wsuggest-override) +CODA_OSS_disable_warning(-Wzero-as-null-pointer-constant) +#endif + +#include #include CODA_OSS_disable_warning_pop diff --git a/externals/coda-oss/modules/c++/numpyutils/source/numpyutils.cpp b/externals/coda-oss/modules/c++/numpyutils/source/numpyutils.cpp index 53b8b97b1..31a2452c2 100644 --- a/externals/coda-oss/modules/c++/numpyutils/source/numpyutils.cpp +++ b/externals/coda-oss/modules/c++/numpyutils/source/numpyutils.cpp @@ -25,6 +25,9 @@ #ifndef _MSC_VER CODA_OSS_disable_warning(-Wold-style-cast) +CODA_OSS_disable_warning(-Wshadow) +CODA_OSS_disable_warning(-Wsuggest-override) +CODA_OSS_disable_warning(-Wzero-as-null-pointer-constant) #endif #include #include @@ -36,18 +39,12 @@ CODA_OSS_disable_warning(-Wold-style-cast) * https://mail.scipy.org/pipermail/numpy-discussion/2010-December/054350.html * for the source and some discussion */ -#if PY_MAJOR_VERSION >= 3 +static_assert(PY_MAJOR_VERSION >= 3, "Python 3.x required"); void* init_numpy() { import_array(); return nullptr; } -#else -void init_numpy() -{ - import_array(); -} -#endif /* Numpy uses some static variables which are per-compilation * unit and if import_arrays is not called, will segfault on using any of diff --git a/externals/coda-oss/modules/c++/re/include/re/Regex.h b/externals/coda-oss/modules/c++/re/include/re/Regex.h index d7dd55dd2..e4338972a 100644 --- a/externals/coda-oss/modules/c++/re/include/re/Regex.h +++ b/externals/coda-oss/modules/c++/re/include/re/Regex.h @@ -214,7 +214,7 @@ class CODA_OSS_API Regex size_t& end); //! The pcre object - pcre2_code* mPCRE; + pcre2_code* mPCRE = nullptr; #endif }; } diff --git a/externals/coda-oss/modules/c++/re/source/RegexPCRE.cpp b/externals/coda-oss/modules/c++/re/source/RegexPCRE.cpp index 479d1fac7..d70885e3e 100644 --- a/externals/coda-oss/modules/c++/re/source/RegexPCRE.cpp +++ b/externals/coda-oss/modules/c++/re/source/RegexPCRE.cpp @@ -55,9 +55,9 @@ class ScopedMatchData // to do. ScopedMatchData(const pcre2_code* code) : mCode(code), - mMatchData(pcre2_match_data_create_from_pattern(code, NULL)) + mMatchData(pcre2_match_data_create_from_pattern(code, nullptr)) { - if (mMatchData == NULL) + if (mMatchData == nullptr) { throw re::RegexException(Ctxt( "pcre2_match_data_create_from_pattern() failed to " @@ -95,7 +95,7 @@ class ScopedMatchData startOffset, options, mMatchData, - NULL); // Match context + nullptr); // Match context if (returnCode == PCRE2_ERROR_NOMATCH) { @@ -156,7 +156,7 @@ class ScopedMatchData namespace re { Regex::Regex(const std::string& pattern) : - mPattern(pattern), mPCRE(NULL) + mPattern(pattern), mPCRE(nullptr) { if (!mPattern.empty()) { @@ -166,10 +166,10 @@ Regex::Regex(const std::string& pattern) : void Regex::destroy() { - if (mPCRE != NULL) + if (mPCRE != nullptr) { pcre2_code_free(mPCRE); - mPCRE = NULL; + mPCRE = nullptr; } } @@ -179,7 +179,7 @@ Regex::~Regex() } Regex::Regex(const Regex& rhs) : - mPattern(rhs.mPattern), mPCRE(NULL) + mPattern(rhs.mPattern), mPCRE(nullptr) { compile(mPattern); } @@ -218,9 +218,9 @@ Regex& Regex::compile(const std::string& pattern) FLAGS, &errorCode, &errorOffset, - NULL); // Use default compile context + nullptr); // Use default compile context - if (mPCRE == NULL) + if (mPCRE == nullptr) { std::ostringstream ostr; ostr << "PCRE compilation failed at offset " << errorOffset diff --git a/externals/coda-oss/modules/c++/sys/source/ConditionVarPosix.cpp b/externals/coda-oss/modules/c++/sys/source/ConditionVarPosix.cpp index 505a17634..d1e288629 100644 --- a/externals/coda-oss/modules/c++/sys/source/ConditionVarPosix.cpp +++ b/externals/coda-oss/modules/c++/sys/source/ConditionVarPosix.cpp @@ -32,7 +32,7 @@ sys::ConditionVarPosix::ConditionVarPosix() : mMutexOwned(std::make_unique()), mMutex(mMutexOwned.get()) { - if ( ::pthread_cond_init(&mNative, NULL) != 0) + if ( ::pthread_cond_init(&mNative, nullptr) != 0) throw SystemException("ConditionVar initialization failed"); } @@ -41,7 +41,7 @@ sys::ConditionVarPosix::ConditionVarPosix(MutexPosix* theLock, bool isOwner, std if (isOwner) mMutexOwned.reset(theLock); - if (::pthread_cond_init(&mNative, NULL) != 0) + if (::pthread_cond_init(&mNative, nullptr) != 0) throw SystemException("ConditionVar initialization failed"); } sys::ConditionVarPosix::ConditionVarPosix(sys::MutexPosix* theLock, bool isOwner) : ConditionVarPosix(theLock, isOwner, nullptr) @@ -87,7 +87,7 @@ void sys::ConditionVarPosix::wait(double seconds) if ( seconds > 0 ) { timespec tout; - tout.tv_sec = time(NULL) + gsl::narrow_cast(seconds); + tout.tv_sec = time(nullptr) + gsl::narrow_cast(seconds); tout.tv_nsec = gsl::narrow_cast((seconds - gsl::narrow_cast(seconds)) * 1e9); if (::pthread_cond_timedwait(&mNative, &(mMutex->getNative()), diff --git a/externals/coda-oss/modules/c++/sys/source/DLLUnix.cpp b/externals/coda-oss/modules/c++/sys/source/DLLUnix.cpp index f43457e69..6ef817453 100644 --- a/externals/coda-oss/modules/c++/sys/source/DLLUnix.cpp +++ b/externals/coda-oss/modules/c++/sys/source/DLLUnix.cpp @@ -66,7 +66,7 @@ DLL_FUNCTION_PTR sys::DLL::retrieve(const std::string& functionName) { // Check to make sure we have a library - if ( mLib != NULL ) + if ( mLib != nullptr ) { // Now we get a ptr DLL_FUNCTION_PTR ptr = dlsym( mLib , functionName.c_str()); diff --git a/externals/coda-oss/modules/c++/sys/source/DateTime.cpp b/externals/coda-oss/modules/c++/sys/source/DateTime.cpp index e0f411d5b..a79b9bb8c 100644 --- a/externals/coda-oss/modules/c++/sys/source/DateTime.cpp +++ b/externals/coda-oss/modules/c++/sys/source/DateTime.cpp @@ -394,7 +394,7 @@ static double getNowInMillis() return (now.tv_sec + 1.0e-9 * now.tv_nsec) * 1000; #elif CODA_OSS_POSIX_SOURCE struct timeval now; - gettimeofday(&now,NULL); + gettimeofday(&now,nullptr); return (now.tv_sec + 1.0e-6 * now.tv_usec) * 1000; #elif _WIN32 // Getting time twice may be inefficient but is quicker diff --git a/externals/coda-oss/modules/c++/sys/source/ExecUnix.cpp b/externals/coda-oss/modules/c++/sys/source/ExecUnix.cpp index 24ea23103..a31bd6023 100644 --- a/externals/coda-oss/modules/c++/sys/source/ExecUnix.cpp +++ b/externals/coda-oss/modules/c++/sys/source/ExecUnix.cpp @@ -104,7 +104,7 @@ FILE* ExecPipe::openPipe(const std::string& command, // command the user specified execl("/bin/sh", "sh", "-c", command.c_str(), - static_cast(NULL)); + static_cast(nullptr)); //! exit the subprocess once it has completed exit(127); diff --git a/externals/coda-oss/modules/c++/sys/source/MutexPosix.cpp b/externals/coda-oss/modules/c++/sys/source/MutexPosix.cpp index f28ce93be..d28418444 100644 --- a/externals/coda-oss/modules/c++/sys/source/MutexPosix.cpp +++ b/externals/coda-oss/modules/c++/sys/source/MutexPosix.cpp @@ -28,7 +28,7 @@ sys::MutexPosix::MutexPosix() { - if (::pthread_mutex_init(&mNative, NULL) != 0) + if (::pthread_mutex_init(&mNative, nullptr) != 0) throw sys::SystemException("Mutex initialization failed"); } diff --git a/externals/coda-oss/modules/c++/sys/source/OSUnix.cpp b/externals/coda-oss/modules/c++/sys/source/OSUnix.cpp index e2b96cf18..c9241b639 100644 --- a/externals/coda-oss/modules/c++/sys/source/OSUnix.cpp +++ b/externals/coda-oss/modules/c++/sys/source/OSUnix.cpp @@ -308,7 +308,7 @@ std::string sys::OSUnix::getEnv(const std::string& s) const bool sys::OSUnix::isEnvSet(const std::string& s) const { const char* envVal = getenv(s.c_str()); - return (envVal != NULL); + return envVal != nullptr; } void sys::OSUnix::setEnv(const std::string& var, diff --git a/externals/coda-oss/modules/c++/sys/source/ScopedCPUAffinityUnix.cpp b/externals/coda-oss/modules/c++/sys/source/ScopedCPUAffinityUnix.cpp index 2b7fbc844..e409b3b03 100644 --- a/externals/coda-oss/modules/c++/sys/source/ScopedCPUAffinityUnix.cpp +++ b/externals/coda-oss/modules/c++/sys/source/ScopedCPUAffinityUnix.cpp @@ -64,7 +64,7 @@ void ScopedCPUMaskUnix::initialize(int numCPUs) ScopedCPUMaskUnix::~ScopedCPUMaskUnix() { - if (mMask != NULL) + if (mMask != nullptr) { CPU_FREE(mMask); } diff --git a/externals/coda-oss/modules/c++/sys/source/ThreadPosix.cpp b/externals/coda-oss/modules/c++/sys/source/ThreadPosix.cpp index 4ee1f2411..c399b5c83 100644 --- a/externals/coda-oss/modules/c++/sys/source/ThreadPosix.cpp +++ b/externals/coda-oss/modules/c++/sys/source/ThreadPosix.cpp @@ -80,7 +80,7 @@ void *sys::ThreadPosix::__start(void *v) delete runnable; */ - pthread_exit(NULL); + pthread_exit(nullptr); return nullptr; } @@ -94,7 +94,7 @@ void sys::ThreadPosix::kill() } void sys::ThreadPosix::join() { - if (::pthread_join(mNative, NULL) != 0) + if (::pthread_join(mNative, nullptr) != 0) throw sys::SystemException("pthread_join()"); } void sys::ThreadPosix::yield() diff --git a/externals/coda-oss/modules/c++/sys/tests/DateTimeTest.cpp b/externals/coda-oss/modules/c++/sys/tests/DateTimeTest.cpp index f47fc3387..b2c5597f0 100644 --- a/externals/coda-oss/modules/c++/sys/tests/DateTimeTest.cpp +++ b/externals/coda-oss/modules/c++/sys/tests/DateTimeTest.cpp @@ -54,7 +54,7 @@ int main(int, char**) sys::CPUStopWatch csw; //std::cout << "CPS: " << CLOCKS_PER_SEC << std::endl; std::cout << "clock(): " << clock() / CLOCKS_PER_SEC << std::endl; - std::cout << "time(): " << time(NULL) << std::endl; + std::cout << "time(): " << time(nullptr) << std::endl; std::cout << "RTStart: " << sw.start() << std::endl; std::cout << "CStart: " << csw.start() << std::endl; int x = 0; @@ -82,7 +82,7 @@ int main(int, char**) } std::cout << "Finish Loop 3" << std::endl; std::cout << "clock(): " << clock() / CLOCKS_PER_SEC << std::endl; - std::cout << "time(): " << time(NULL) << std::endl; + std::cout << "time(): " << time(nullptr) << std::endl; std::cout << "RTStop: " << std::setprecision(50) << sw.stop() << std::endl; std::cout << "CStop: " << std::setprecision(50) << csw.stop() diff --git a/externals/coda-oss/modules/c++/sys/tests/OSTest.cpp b/externals/coda-oss/modules/c++/sys/tests/OSTest.cpp index f8ee1ea5a..330493eb7 100644 --- a/externals/coda-oss/modules/c++/sys/tests/OSTest.cpp +++ b/externals/coda-oss/modules/c++/sys/tests/OSTest.cpp @@ -110,7 +110,7 @@ int main(int argc, char **argv) } os.remove("TEST_DIRECTORY"); - std::cout << "Time Now: " << time(NULL) << std::endl; + std::cout << "Time Now: " << time(nullptr) << std::endl; sys::RealTimeStopWatch sw; //std::cout << "CPS: " << CLOCKS_PER_SEC << std::endl; // std::cout << "Clock: " << clock() << std::endl; @@ -137,7 +137,7 @@ int main(int argc, char **argv) std::cout << "Finish Loop 3" << std::endl; std::cout << "Stop: " << std::setprecision(50) << sw.stop() << std::endl; - std::cout << "Time Now: " << time(NULL) << std::endl; + std::cout << "Time Now: " << time(nullptr) << std::endl; // std::cout << "Clock: " << clock() << std::endl; } diff --git a/externals/coda-oss/modules/c++/xml.lite/include/xml/lite/xerces_.h b/externals/coda-oss/modules/c++/xml.lite/include/xml/lite/xerces_.h index 51d2ca436..b35fc4714 100644 --- a/externals/coda-oss/modules/c++/xml.lite/include/xml/lite/xerces_.h +++ b/externals/coda-oss/modules/c++/xml.lite/include/xml/lite/xerces_.h @@ -54,6 +54,11 @@ CODA_OSS_disable_warning_system_header_push CODA_OSS_disable_warning(-Wshadow) CODA_OSS_disable_warning(-Wsuggest-override) CODA_OSS_disable_warning(-Wzero-as-null-pointer-constant) +CODA_OSS_disable_warning(-Wmisleading-indentation) +CODA_OSS_disable_warning(-Wsign-compare) +CODA_OSS_disable_warning(-Wformat-overflow=) +CODA_OSS_disable_warning(-Wunused-value) +CODA_OSS_disable_warning(-Walloc-size-larger-than=) #endif #include diff --git a/externals/coda-oss/modules/c++/zip/source/ZipOutputStream.cpp b/externals/coda-oss/modules/c++/zip/source/ZipOutputStream.cpp index f4e09e34c..2b9bd903e 100644 --- a/externals/coda-oss/modules/c++/zip/source/ZipOutputStream.cpp +++ b/externals/coda-oss/modules/c++/zip/source/ZipOutputStream.cpp @@ -48,9 +48,9 @@ void ZipOutputStream::createFileInZip(const std::string& pathname, mZip, pathname.c_str(), &zipFileInfo, - NULL, + nullptr, 0, - NULL, + nullptr, 0, comment.empty() ? nullptr : comment.c_str(), Z_DEFLATED, From 117470ac4bd7d4e5787112251d0c27274e35324b Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Wed, 12 Jul 2023 14:47:44 -0400 Subject: [PATCH 038/104] new UnitTest project --- UnitTest/UnitTest.cpp | 16 +++ UnitTest/UnitTest.vcxproj | 217 ++++++++++++++++++++++++++++++ UnitTest/UnitTest.vcxproj.filters | 30 +++++ UnitTest/pch.cpp | 5 + UnitTest/pch.h | 12 ++ nitro.sln | 92 +++++++++++++ 6 files changed, 372 insertions(+) create mode 100644 UnitTest/UnitTest.cpp create mode 100644 UnitTest/UnitTest.vcxproj create mode 100644 UnitTest/UnitTest.vcxproj.filters create mode 100644 UnitTest/pch.cpp create mode 100644 UnitTest/pch.h diff --git a/UnitTest/UnitTest.cpp b/UnitTest/UnitTest.cpp new file mode 100644 index 000000000..23d61acf7 --- /dev/null +++ b/UnitTest/UnitTest.cpp @@ -0,0 +1,16 @@ +#include "pch.h" +#include "CppUnitTest.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +namespace UnitTest +{ + TEST_CLASS(UnitTest) + { + public: + + TEST_METHOD(TestMethod1) + { + } + }; +} diff --git a/UnitTest/UnitTest.vcxproj b/UnitTest/UnitTest.vcxproj new file mode 100644 index 000000000..294a870d3 --- /dev/null +++ b/UnitTest/UnitTest.vcxproj @@ -0,0 +1,217 @@ + + + + + Debug + Win32 + + + Release + Win32 + + + Debug + x64 + + + Release + x64 + + + + 17.0 + {8ACE478C-8F6F-4D42-9B43-7D75882D4BE1} + Win32Proj + UnitTest + 10.0 + NativeUnitTestProject + + + + DynamicLibrary + true + v143 + Unicode + false + + + DynamicLibrary + false + v143 + true + Unicode + false + + + DynamicLibrary + true + v143 + Unicode + false + + + DynamicLibrary + false + v143 + true + Unicode + false + + + + + + + + + + + + + + + + + + + + + true + + + true + + + false + + + false + + + + Use + Level3 + true + $(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + _DEBUG;%(PreprocessorDefinitions) + true + pch.h + + + Windows + $(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) + + + + + Use + Level3 + true + $(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + WIN32;_DEBUG;%(PreprocessorDefinitions) + true + pch.h + + + Windows + $(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) + + + + + Use + Level3 + true + true + true + $(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + WIN32;NDEBUG;%(PreprocessorDefinitions) + true + pch.h + + + Windows + true + true + $(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) + + + + + Use + Level3 + true + true + true + $(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + NDEBUG;%(PreprocessorDefinitions) + true + pch.h + + + Windows + true + true + $(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) + + + + + Create + Create + Create + Create + + + + + + + + + {8f357a19-799e-4971-850e-3f28485c130b} + + + {f06550ad-cfc7-40b8-8727-6c82c69a8982} + + + {53f9f908-c678-4dee-9309-e71c1d03a45f} + + + {730b1e6e-2469-4f9e-b093-d0c6262453c9} + + + {51d7b426-899e-428d-9f69-5ddac9e403fb} + + + {12aa0752-4ee3-4e0a-85af-0e5deadbf343} + + + {023de06d-3967-4406-b1b8-032118bb2552} + + + {0a9bda26-092f-4a2c-bbef-00c64bf0c65e} + + + {53f9f908-c678-4dee-9309-e71c1e03a45f} + + + {d749aa73-4c9a-473d-96bb-070a6d9caa54} + + + {d1d7fcd3-6130-4504-9da0-9d80506be55e} + + + {2baaaca9-a5a4-412c-ae52-b16c2d107f55} + + + {cf5b4f02-364d-4117-9fb9-6c9c7938e412} + + + {78849481-d356-4cc7-b182-31c21f857ed1} + + + + + + \ No newline at end of file diff --git a/UnitTest/UnitTest.vcxproj.filters b/UnitTest/UnitTest.vcxproj.filters new file mode 100644 index 000000000..470ad0c70 --- /dev/null +++ b/UnitTest/UnitTest.vcxproj.filters @@ -0,0 +1,30 @@ + + + + + {4FC737F1-C7A5-4376-A066-2A32D752A2FF} + cpp;c;cc;cxx;c++;cppm;ixx;def;odl;idl;hpj;bat;asm;asmx + + + {93995380-89BD-4b04-88EB-625FBE52EBFB} + h;hh;hpp;hxx;h++;hm;inl;inc;ipp;xsd + + + {67DA6AB6-F800-4c08-8B7A-83BB121AAD01} + rc;ico;cur;bmp;dlg;rc2;rct;bin;rgs;gif;jpg;jpeg;jpe;resx;tiff;tif;png;wav;mfcribbon-ms + + + + + Source Files + + + Source Files + + + + + Header Files + + + \ No newline at end of file diff --git a/UnitTest/pch.cpp b/UnitTest/pch.cpp new file mode 100644 index 000000000..91c22df2a --- /dev/null +++ b/UnitTest/pch.cpp @@ -0,0 +1,5 @@ +// pch.cpp: source file corresponding to the pre-compiled header + +#include "pch.h" + +// When you are using pre-compiled headers, this source file is necessary for compilation to succeed. diff --git a/UnitTest/pch.h b/UnitTest/pch.h new file mode 100644 index 000000000..a98b1bd98 --- /dev/null +++ b/UnitTest/pch.h @@ -0,0 +1,12 @@ +// pch.h: This is a precompiled header file. +// Files listed below are compiled only once, improving build performance for future builds. +// This also affects IntelliSense performance, including code completion and many code browsing features. +// However, files listed here are ALL re-compiled if any one of them is updated between builds. +// Do not add files here that you will be updating frequently as this negates the performance advantage. + +#ifndef PCH_H +#define PCH_H + +// add headers that you want to pre-compile here + +#endif //PCH_H diff --git a/nitro.sln b/nitro.sln index d7e22ef78..45384a6fa 100644 --- a/nitro.sln +++ b/nitro.sln @@ -69,92 +69,184 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "externals", "externals", "{ EndProject Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "coda-oss", "externals\coda-oss\modules\c++\coda-oss.vcxproj", "{9997E895-5161-4DDF-8F3F-099894CB2F21}" EndProject +Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "UnitTest", "UnitTest\UnitTest.vcxproj", "{8ACE478C-8F6F-4D42-9B43-7D75882D4BE1}" +EndProject Global GlobalSection(SolutionConfigurationPlatforms) = preSolution Debug|x64 = Debug|x64 + Debug|x86 = Debug|x86 Release|x64 = Release|x64 + Release|x86 = Release|x86 EndGlobalSection GlobalSection(ProjectConfigurationPlatforms) = postSolution {F06550AD-CFC7-40B8-8727-6C82C69A8982}.Debug|x64.ActiveCfg = Debug|x64 {F06550AD-CFC7-40B8-8727-6C82C69A8982}.Debug|x64.Build.0 = Debug|x64 + {F06550AD-CFC7-40B8-8727-6C82C69A8982}.Debug|x86.ActiveCfg = Debug|x64 + {F06550AD-CFC7-40B8-8727-6C82C69A8982}.Debug|x86.Build.0 = Debug|x64 {F06550AD-CFC7-40B8-8727-6C82C69A8982}.Release|x64.ActiveCfg = Release|x64 {F06550AD-CFC7-40B8-8727-6C82C69A8982}.Release|x64.Build.0 = Release|x64 + {F06550AD-CFC7-40B8-8727-6C82C69A8982}.Release|x86.ActiveCfg = Release|x64 + {F06550AD-CFC7-40B8-8727-6C82C69A8982}.Release|x86.Build.0 = Release|x64 {8F357A19-799E-4971-850E-3F28485C130B}.Debug|x64.ActiveCfg = Debug|x64 {8F357A19-799E-4971-850E-3F28485C130B}.Debug|x64.Build.0 = Debug|x64 + {8F357A19-799E-4971-850E-3F28485C130B}.Debug|x86.ActiveCfg = Debug|x64 + {8F357A19-799E-4971-850E-3F28485C130B}.Debug|x86.Build.0 = Debug|x64 {8F357A19-799E-4971-850E-3F28485C130B}.Release|x64.ActiveCfg = Release|x64 {8F357A19-799E-4971-850E-3F28485C130B}.Release|x64.Build.0 = Release|x64 + {8F357A19-799E-4971-850E-3F28485C130B}.Release|x86.ActiveCfg = Release|x64 + {8F357A19-799E-4971-850E-3F28485C130B}.Release|x86.Build.0 = Release|x64 {730B1E6E-2469-4F9E-B093-D0C6262453C9}.Debug|x64.ActiveCfg = Debug|x64 {730B1E6E-2469-4F9E-B093-D0C6262453C9}.Debug|x64.Build.0 = Debug|x64 + {730B1E6E-2469-4F9E-B093-D0C6262453C9}.Debug|x86.ActiveCfg = Debug|x64 + {730B1E6E-2469-4F9E-B093-D0C6262453C9}.Debug|x86.Build.0 = Debug|x64 {730B1E6E-2469-4F9E-B093-D0C6262453C9}.Release|x64.ActiveCfg = Release|x64 {730B1E6E-2469-4F9E-B093-D0C6262453C9}.Release|x64.Build.0 = Release|x64 + {730B1E6E-2469-4F9E-B093-D0C6262453C9}.Release|x86.ActiveCfg = Release|x64 + {730B1E6E-2469-4F9E-B093-D0C6262453C9}.Release|x86.Build.0 = Release|x64 {53F9F908-C678-4DEE-9309-E71C1D03A45F}.Debug|x64.ActiveCfg = Debug|x64 {53F9F908-C678-4DEE-9309-E71C1D03A45F}.Debug|x64.Build.0 = Debug|x64 + {53F9F908-C678-4DEE-9309-E71C1D03A45F}.Debug|x86.ActiveCfg = Debug|x64 + {53F9F908-C678-4DEE-9309-E71C1D03A45F}.Debug|x86.Build.0 = Debug|x64 {53F9F908-C678-4DEE-9309-E71C1D03A45F}.Release|x64.ActiveCfg = Release|x64 {53F9F908-C678-4DEE-9309-E71C1D03A45F}.Release|x64.Build.0 = Release|x64 + {53F9F908-C678-4DEE-9309-E71C1D03A45F}.Release|x86.ActiveCfg = Release|x64 + {53F9F908-C678-4DEE-9309-E71C1D03A45F}.Release|x86.Build.0 = Release|x64 {51D7B426-899E-428D-9F69-5DDAC9E403FB}.Debug|x64.ActiveCfg = Debug|x64 {51D7B426-899E-428D-9F69-5DDAC9E403FB}.Debug|x64.Build.0 = Debug|x64 + {51D7B426-899E-428D-9F69-5DDAC9E403FB}.Debug|x86.ActiveCfg = Debug|x64 + {51D7B426-899E-428D-9F69-5DDAC9E403FB}.Debug|x86.Build.0 = Debug|x64 {51D7B426-899E-428D-9F69-5DDAC9E403FB}.Release|x64.ActiveCfg = Release|x64 {51D7B426-899E-428D-9F69-5DDAC9E403FB}.Release|x64.Build.0 = Release|x64 + {51D7B426-899E-428D-9F69-5DDAC9E403FB}.Release|x86.ActiveCfg = Release|x64 + {51D7B426-899E-428D-9F69-5DDAC9E403FB}.Release|x86.Build.0 = Release|x64 {12AA0752-4EE3-4E0A-85AF-0E5DEADBF343}.Debug|x64.ActiveCfg = Debug|x64 {12AA0752-4EE3-4E0A-85AF-0E5DEADBF343}.Debug|x64.Build.0 = Debug|x64 + {12AA0752-4EE3-4E0A-85AF-0E5DEADBF343}.Debug|x86.ActiveCfg = Debug|x64 + {12AA0752-4EE3-4E0A-85AF-0E5DEADBF343}.Debug|x86.Build.0 = Debug|x64 {12AA0752-4EE3-4E0A-85AF-0E5DEADBF343}.Release|x64.ActiveCfg = Release|x64 {12AA0752-4EE3-4E0A-85AF-0E5DEADBF343}.Release|x64.Build.0 = Release|x64 + {12AA0752-4EE3-4E0A-85AF-0E5DEADBF343}.Release|x86.ActiveCfg = Release|x64 + {12AA0752-4EE3-4E0A-85AF-0E5DEADBF343}.Release|x86.Build.0 = Release|x64 {D1D7FCD3-6130-4504-9DA0-9D80506BE55E}.Debug|x64.ActiveCfg = Debug|x64 {D1D7FCD3-6130-4504-9DA0-9D80506BE55E}.Debug|x64.Build.0 = Debug|x64 + {D1D7FCD3-6130-4504-9DA0-9D80506BE55E}.Debug|x86.ActiveCfg = Debug|x64 + {D1D7FCD3-6130-4504-9DA0-9D80506BE55E}.Debug|x86.Build.0 = Debug|x64 {D1D7FCD3-6130-4504-9DA0-9D80506BE55E}.Release|x64.ActiveCfg = Release|x64 {D1D7FCD3-6130-4504-9DA0-9D80506BE55E}.Release|x64.Build.0 = Release|x64 + {D1D7FCD3-6130-4504-9DA0-9D80506BE55E}.Release|x86.ActiveCfg = Release|x64 + {D1D7FCD3-6130-4504-9DA0-9D80506BE55E}.Release|x86.Build.0 = Release|x64 {023DE06D-3967-4406-B1B8-032118BB2552}.Debug|x64.ActiveCfg = Debug|x64 {023DE06D-3967-4406-B1B8-032118BB2552}.Debug|x64.Build.0 = Debug|x64 + {023DE06D-3967-4406-B1B8-032118BB2552}.Debug|x86.ActiveCfg = Debug|x64 + {023DE06D-3967-4406-B1B8-032118BB2552}.Debug|x86.Build.0 = Debug|x64 {023DE06D-3967-4406-B1B8-032118BB2552}.Release|x64.ActiveCfg = Release|x64 {023DE06D-3967-4406-B1B8-032118BB2552}.Release|x64.Build.0 = Release|x64 + {023DE06D-3967-4406-B1B8-032118BB2552}.Release|x86.ActiveCfg = Release|x64 + {023DE06D-3967-4406-B1B8-032118BB2552}.Release|x86.Build.0 = Release|x64 {CF5B4F02-364D-4117-9FB9-6C9C7938E412}.Debug|x64.ActiveCfg = Debug|x64 {CF5B4F02-364D-4117-9FB9-6C9C7938E412}.Debug|x64.Build.0 = Debug|x64 + {CF5B4F02-364D-4117-9FB9-6C9C7938E412}.Debug|x86.ActiveCfg = Debug|x64 + {CF5B4F02-364D-4117-9FB9-6C9C7938E412}.Debug|x86.Build.0 = Debug|x64 {CF5B4F02-364D-4117-9FB9-6C9C7938E412}.Release|x64.ActiveCfg = Release|x64 {CF5B4F02-364D-4117-9FB9-6C9C7938E412}.Release|x64.Build.0 = Release|x64 + {CF5B4F02-364D-4117-9FB9-6C9C7938E412}.Release|x86.ActiveCfg = Release|x64 + {CF5B4F02-364D-4117-9FB9-6C9C7938E412}.Release|x86.Build.0 = Release|x64 {78849481-D356-4CC7-B182-31C21F857ED1}.Debug|x64.ActiveCfg = Debug|x64 {78849481-D356-4CC7-B182-31C21F857ED1}.Debug|x64.Build.0 = Debug|x64 + {78849481-D356-4CC7-B182-31C21F857ED1}.Debug|x86.ActiveCfg = Debug|x64 + {78849481-D356-4CC7-B182-31C21F857ED1}.Debug|x86.Build.0 = Debug|x64 {78849481-D356-4CC7-B182-31C21F857ED1}.Release|x64.ActiveCfg = Release|x64 {78849481-D356-4CC7-B182-31C21F857ED1}.Release|x64.Build.0 = Release|x64 + {78849481-D356-4CC7-B182-31C21F857ED1}.Release|x86.ActiveCfg = Release|x64 + {78849481-D356-4CC7-B182-31C21F857ED1}.Release|x86.Build.0 = Release|x64 {839FF52C-57D1-45B6-81FD-5C7D72523EE5}.Debug|x64.ActiveCfg = Debug|x64 {839FF52C-57D1-45B6-81FD-5C7D72523EE5}.Debug|x64.Build.0 = Debug|x64 + {839FF52C-57D1-45B6-81FD-5C7D72523EE5}.Debug|x86.ActiveCfg = Debug|x64 + {839FF52C-57D1-45B6-81FD-5C7D72523EE5}.Debug|x86.Build.0 = Debug|x64 {839FF52C-57D1-45B6-81FD-5C7D72523EE5}.Release|x64.ActiveCfg = Release|x64 {839FF52C-57D1-45B6-81FD-5C7D72523EE5}.Release|x64.Build.0 = Release|x64 + {839FF52C-57D1-45B6-81FD-5C7D72523EE5}.Release|x86.ActiveCfg = Release|x64 + {839FF52C-57D1-45B6-81FD-5C7D72523EE5}.Release|x86.Build.0 = Release|x64 {2BAAACA9-A5A4-412C-AE52-B16C2D107F55}.Debug|x64.ActiveCfg = Debug|x64 {2BAAACA9-A5A4-412C-AE52-B16C2D107F55}.Debug|x64.Build.0 = Debug|x64 + {2BAAACA9-A5A4-412C-AE52-B16C2D107F55}.Debug|x86.ActiveCfg = Debug|x64 + {2BAAACA9-A5A4-412C-AE52-B16C2D107F55}.Debug|x86.Build.0 = Debug|x64 {2BAAACA9-A5A4-412C-AE52-B16C2D107F55}.Release|x64.ActiveCfg = Release|x64 {2BAAACA9-A5A4-412C-AE52-B16C2D107F55}.Release|x64.Build.0 = Release|x64 + {2BAAACA9-A5A4-412C-AE52-B16C2D107F55}.Release|x86.ActiveCfg = Release|x64 + {2BAAACA9-A5A4-412C-AE52-B16C2D107F55}.Release|x86.Build.0 = Release|x64 {D749AA73-4C9A-473D-96BB-070A6D9CAA54}.Debug|x64.ActiveCfg = Debug|x64 {D749AA73-4C9A-473D-96BB-070A6D9CAA54}.Debug|x64.Build.0 = Debug|x64 + {D749AA73-4C9A-473D-96BB-070A6D9CAA54}.Debug|x86.ActiveCfg = Debug|x64 + {D749AA73-4C9A-473D-96BB-070A6D9CAA54}.Debug|x86.Build.0 = Debug|x64 {D749AA73-4C9A-473D-96BB-070A6D9CAA54}.Release|x64.ActiveCfg = Release|x64 {D749AA73-4C9A-473D-96BB-070A6D9CAA54}.Release|x64.Build.0 = Release|x64 + {D749AA73-4C9A-473D-96BB-070A6D9CAA54}.Release|x86.ActiveCfg = Release|x64 + {D749AA73-4C9A-473D-96BB-070A6D9CAA54}.Release|x86.Build.0 = Release|x64 {53F9F908-C678-4DEE-9309-E71C1E03A45F}.Debug|x64.ActiveCfg = Debug|x64 {53F9F908-C678-4DEE-9309-E71C1E03A45F}.Debug|x64.Build.0 = Debug|x64 + {53F9F908-C678-4DEE-9309-E71C1E03A45F}.Debug|x86.ActiveCfg = Debug|x64 + {53F9F908-C678-4DEE-9309-E71C1E03A45F}.Debug|x86.Build.0 = Debug|x64 {53F9F908-C678-4DEE-9309-E71C1E03A45F}.Release|x64.ActiveCfg = Release|x64 {53F9F908-C678-4DEE-9309-E71C1E03A45F}.Release|x64.Build.0 = Release|x64 + {53F9F908-C678-4DEE-9309-E71C1E03A45F}.Release|x86.ActiveCfg = Release|x64 + {53F9F908-C678-4DEE-9309-E71C1E03A45F}.Release|x86.Build.0 = Release|x64 {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Debug|x64.ActiveCfg = Debug|x64 {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Debug|x64.Build.0 = Debug|x64 + {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Debug|x86.ActiveCfg = Debug|x64 + {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Debug|x86.Build.0 = Debug|x64 {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Release|x64.ActiveCfg = Release|x64 {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Release|x64.Build.0 = Release|x64 + {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Release|x86.ActiveCfg = Release|x64 + {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Release|x86.Build.0 = Release|x64 {E610F11D-1240-4260-87F8-504B49DB6915}.Debug|x64.ActiveCfg = Debug|x64 {E610F11D-1240-4260-87F8-504B49DB6915}.Debug|x64.Build.0 = Debug|x64 + {E610F11D-1240-4260-87F8-504B49DB6915}.Debug|x86.ActiveCfg = Debug|x64 + {E610F11D-1240-4260-87F8-504B49DB6915}.Debug|x86.Build.0 = Debug|x64 {E610F11D-1240-4260-87F8-504B49DB6915}.Release|x64.ActiveCfg = Release|x64 {E610F11D-1240-4260-87F8-504B49DB6915}.Release|x64.Build.0 = Release|x64 + {E610F11D-1240-4260-87F8-504B49DB6915}.Release|x86.ActiveCfg = Release|x64 + {E610F11D-1240-4260-87F8-504B49DB6915}.Release|x86.Build.0 = Release|x64 {A676EDF3-F231-47C8-A6E6-0FE50B50B71B}.Debug|x64.ActiveCfg = Debug|x64 {A676EDF3-F231-47C8-A6E6-0FE50B50B71B}.Debug|x64.Build.0 = Debug|x64 + {A676EDF3-F231-47C8-A6E6-0FE50B50B71B}.Debug|x86.ActiveCfg = Debug|x64 + {A676EDF3-F231-47C8-A6E6-0FE50B50B71B}.Debug|x86.Build.0 = Debug|x64 {A676EDF3-F231-47C8-A6E6-0FE50B50B71B}.Release|x64.ActiveCfg = Release|x64 {A676EDF3-F231-47C8-A6E6-0FE50B50B71B}.Release|x64.Build.0 = Release|x64 + {A676EDF3-F231-47C8-A6E6-0FE50B50B71B}.Release|x86.ActiveCfg = Release|x64 + {A676EDF3-F231-47C8-A6E6-0FE50B50B71B}.Release|x86.Build.0 = Release|x64 {C787537A-0CAC-4D6D-A6D6-A66765A06753}.Debug|x64.ActiveCfg = Debug|x64 {C787537A-0CAC-4D6D-A6D6-A66765A06753}.Debug|x64.Build.0 = Debug|x64 + {C787537A-0CAC-4D6D-A6D6-A66765A06753}.Debug|x86.ActiveCfg = Debug|x64 + {C787537A-0CAC-4D6D-A6D6-A66765A06753}.Debug|x86.Build.0 = Debug|x64 {C787537A-0CAC-4D6D-A6D6-A66765A06753}.Release|x64.ActiveCfg = Release|x64 {C787537A-0CAC-4D6D-A6D6-A66765A06753}.Release|x64.Build.0 = Release|x64 + {C787537A-0CAC-4D6D-A6D6-A66765A06753}.Release|x86.ActiveCfg = Release|x64 + {C787537A-0CAC-4D6D-A6D6-A66765A06753}.Release|x86.Build.0 = Release|x64 {0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E}.Debug|x64.ActiveCfg = Debug|x64 {0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E}.Debug|x64.Build.0 = Debug|x64 + {0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E}.Debug|x86.ActiveCfg = Debug|x64 + {0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E}.Debug|x86.Build.0 = Debug|x64 {0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E}.Release|x64.ActiveCfg = Release|x64 {0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E}.Release|x64.Build.0 = Release|x64 + {0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E}.Release|x86.ActiveCfg = Release|x64 + {0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E}.Release|x86.Build.0 = Release|x64 {9997E895-5161-4DDF-8F3F-099894CB2F21}.Debug|x64.ActiveCfg = Debug|x64 {9997E895-5161-4DDF-8F3F-099894CB2F21}.Debug|x64.Build.0 = Debug|x64 + {9997E895-5161-4DDF-8F3F-099894CB2F21}.Debug|x86.ActiveCfg = Debug|x64 + {9997E895-5161-4DDF-8F3F-099894CB2F21}.Debug|x86.Build.0 = Debug|x64 {9997E895-5161-4DDF-8F3F-099894CB2F21}.Release|x64.ActiveCfg = Release|x64 {9997E895-5161-4DDF-8F3F-099894CB2F21}.Release|x64.Build.0 = Release|x64 + {9997E895-5161-4DDF-8F3F-099894CB2F21}.Release|x86.ActiveCfg = Release|x64 + {9997E895-5161-4DDF-8F3F-099894CB2F21}.Release|x86.Build.0 = Release|x64 + {8ACE478C-8F6F-4D42-9B43-7D75882D4BE1}.Debug|x64.ActiveCfg = Debug|x64 + {8ACE478C-8F6F-4D42-9B43-7D75882D4BE1}.Debug|x64.Build.0 = Debug|x64 + {8ACE478C-8F6F-4D42-9B43-7D75882D4BE1}.Debug|x86.ActiveCfg = Debug|Win32 + {8ACE478C-8F6F-4D42-9B43-7D75882D4BE1}.Debug|x86.Build.0 = Debug|Win32 + {8ACE478C-8F6F-4D42-9B43-7D75882D4BE1}.Release|x64.ActiveCfg = Release|x64 + {8ACE478C-8F6F-4D42-9B43-7D75882D4BE1}.Release|x64.Build.0 = Release|x64 + {8ACE478C-8F6F-4D42-9B43-7D75882D4BE1}.Release|x86.ActiveCfg = Release|Win32 + {8ACE478C-8F6F-4D42-9B43-7D75882D4BE1}.Release|x86.Build.0 = Release|Win32 EndGlobalSection GlobalSection(SolutionProperties) = preSolution HideSolutionNode = FALSE From 7970c5b98038ec327b9a46f9ae8e071fc6a46ff9 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Wed, 12 Jul 2023 15:22:16 -0400 Subject: [PATCH 039/104] hookup "new" Visual Studio unittest --- UnitTest/CppUnitTestAssert.cpp | 43 +++++++++ UnitTest/Test.h | 9 ++ UnitTest/TestCase.h | 138 +++++++++++++++++++++++++++ UnitTest/UnitTest.cpp | 16 ---- UnitTest/UnitTest.vcxproj | 26 ++++- UnitTest/UnitTest.vcxproj.filters | 29 +++--- UnitTest/nrt.cpp | 10 ++ UnitTest/pch.h | 17 ++++ modules/c/nrt/unittests/test_utils.c | 2 - 9 files changed, 249 insertions(+), 41 deletions(-) create mode 100644 UnitTest/CppUnitTestAssert.cpp create mode 100644 UnitTest/Test.h create mode 100644 UnitTest/TestCase.h delete mode 100644 UnitTest/UnitTest.cpp create mode 100644 UnitTest/nrt.cpp diff --git a/UnitTest/CppUnitTestAssert.cpp b/UnitTest/CppUnitTestAssert.cpp new file mode 100644 index 000000000..fdcf5f92b --- /dev/null +++ b/UnitTest/CppUnitTestAssert.cpp @@ -0,0 +1,43 @@ +#include "pch.h" +#include "TestCase.h" + +#include "str/EncodedStringView.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +// EQUALS_MESSAGE() wants ToString() specializations (or overloads) for our types, which is a nusiance. +// This hooks up our existing str::toString() into the VC++ unit-test infrastructure + +// C++ hack to call private methods +// https://stackoverflow.com/a/71578383/8877 + +using FailOnCondition_t = void(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare method's type +using GetAssertMessage_t = std::wstring(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare method's type +template +struct caller final // helper structure to inject call() code +{ + friend void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) + { + fFailOnCondition(condition, message, pLineInfo); + } + + friend std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message) + { + return fGetAssertMessage(equality, expected, actual, message); + } +}; +template struct caller<&Assert::FailOnCondition, &Assert::GetAssertMessage>; // even instantiation of the helper + +void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare caller +void test::Assert::FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) +{ + ::FailOnCondition(condition, message, pLineInfo); // and call! +} + +std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare caller +std::wstring test::Assert::GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message) +{ + const str::EncodedStringView vExpected(expected); + const str::EncodedStringView vActual(actual); + return ::GetAssertMessage(equality, vExpected.wstring(), vActual.wstring(), message); // and call! +} diff --git a/UnitTest/Test.h b/UnitTest/Test.h new file mode 100644 index 000000000..22bbaa00c --- /dev/null +++ b/UnitTest/Test.h @@ -0,0 +1,9 @@ +#pragma once + +#include "nrt/unittests/Test.h" + +#include "TestCase.h" + +#define TEST_ASSERT_EQ_INT(X1, X2) TEST_ASSERT_EQ(X2, X1) +#define TEST_ASSERT_EQ_STR(X1, X2) TEST_ASSERT_EQ(std::string(X1), std::string(X2)) +#define TEST_ASSERT_EQ_FLOAT(X1, X2) TEST_ASSERT_EQ(static_cast(X1), static_cast(X2)) \ No newline at end of file diff --git a/UnitTest/TestCase.h b/UnitTest/TestCase.h new file mode 100644 index 000000000..f4438821f --- /dev/null +++ b/UnitTest/TestCase.h @@ -0,0 +1,138 @@ +#pragma once + +#include +#include + +#include "CppUnitTest.h" +#include +#include + +#undef TEST_CHECK +#undef TEST_ASSERT +#undef TEST_ASSERT_NULL +#undef TEST_ASSERT_NOT_NULL +#undef TEST_ASSERT_TRUE +#undef TEST_ASSERT_FALSE +#undef TEST_MAIN +#undef TEST_CASE +#define TEST_CHECK(X) +#define TEST_MAIN(X) +#define TEST_ASSERT_NULL(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNull(X) +#define TEST_ASSERT_NOT_NULL(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNotNull(X) +#define TEST_ASSERT_TRUE(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(X) +#define TEST_ASSERT_FALSE(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsFalse(X) +#define TEST_ASSERT(X) TEST_ASSERT_TRUE(X) +#define CODA_OSS_testMethod_(X) testMethod ## _ ## X +#define TEST_CASE(X) TEST_METHOD(X) { CODA_OSS_testMethod_(X)(#X); } void CODA_OSS_testMethod_(X)(std::string testName) + +namespace test +{ + struct Assert final + { + static void FailOnCondition(bool condition, const unsigned short* message, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo); + static std::wstring GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message); + }; +#define CODA_OSS_equals_message_(expected, actual, message) reinterpret_cast(test::Assert::GetAssertMessage(true, test::toString(expected), test::toString(actual), message).c_str()) +#define CODA_OSS_not_equals_message_(notExpected, actual, message) reinterpret_cast(test::Assert::GetAssertMessage(false, test::toString(notExpected), test::toString(actual), message).c_str()) +#define CODA_OSS_message_(message) reinterpret_cast(test::Assert::GetAssertMessage(false, "", "", message).c_str()) + +// see Assert::AreEqual<> +template +inline void diePrintf_eq(const TExpected& expected, const TActual& actual, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(expected == actual, CODA_OSS_equals_message_(expected, actual, message), pLineInfo); +} + +// see Assert::AreNotEqual<> +template +inline void diePrintf_ne(const TExpected& notExpected, const TActual& actual, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(notExpected != actual, CODA_OSS_not_equals_message_(notExpected, actual, message), pLineInfo); +} + +template +inline void diePrintf_ge(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 >= X2, CODA_OSS_message_(message), pLineInfo); +} +template +inline void diePrintf_gt(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 > X2, CODA_OSS_message_(message), pLineInfo); +} +template +inline void diePrintf_le(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 <= X2, CODA_OSS_message_(message), pLineInfo); +} +template +inline void diePrintf_lt(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 < X2, CODA_OSS_message_(message), pLineInfo); +} + +} +#undef CODA_OSS_test_diePrintf_eq_ +#undef CODA_OSS_test_diePrintf_not_eq_ +#define CODA_OSS_test_diePrintf_eq_(X1, X2) testName, ::test::diePrintf_eq(X1, X2) +#define CODA_OSS_test_diePrintf_not_eq_(X1, X2) testName, ::test::diePrintf_ne(X1, X2) + +#undef CODA_OSS_test_diePrintf_greater_eq_ +#undef CODA_OSS_test_diePrintf_greater_ +#undef CODA_OSS_test_diePrintf_lesser_eq_ +#undef CODA_OSS_test_diePrintf_lesser_ +#define CODA_OSS_test_diePrintf_greater_eq_(X1, X2) testName, ::test::diePrintf_ge(X1, X2) +#define CODA_OSS_test_diePrintf_greater_(X1, X2) testName, ::test::diePrintf_gt(X1, X2) +#define CODA_OSS_test_diePrintf_lesser_eq_(X1, X2) testName, ::test::diePrintf_le(X1, X2) +#define CODA_OSS_test_diePrintf_lesser_(X1, X2) testName, ::test::diePrintf_lt(X1, X2) + +template +inline void test_assert_greater_(const TX1& X1, const TX2& X2) +{ + Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(X1 > X2); +} +#undef TEST_ASSERT_GREATER +#define TEST_ASSERT_GREATER(X1, X2) testName, test_assert_greater_(X1, X2) + +#undef TEST_ASSERT_ALMOST_EQ_EPS +#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) { (void)testName; Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(X1, X2, EPS); Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(X2, X1, EPS); } +namespace test +{ +inline void assert_almost_eq(const std::string& testName, float X1, float X2) +{ + constexpr auto EPS = static_cast(0.0001); + TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS); +} +inline void assert_almost_eq(const std::string& testName, double X1, double X2) +{ + constexpr auto EPS = static_cast(0.0001); + TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS); +} +inline void assert_almost_eq(const std::string& testName, long double X1, long double X2) +{ + assert_almost_eq(testName, static_cast(X1), static_cast(X2)); +} +} + +#undef TEST_ASSERT_ALMOST_EQ +#define TEST_ASSERT_ALMOST_EQ(X1, X2) test::assert_almost_eq(testName, X1, X2) + +#undef TEST_ASSERT_EQ_MSG +#define TEST_ASSERT_EQ_MSG(msg, X1, X2) testName, Microsoft::VisualStudio::CppUnitTestFramework::Logger::WriteMessage(msg.c_str()); TEST_ASSERT_EQ(X1, X2) + +#undef TEST_FAIL_MSG +#define TEST_FAIL_MSG(msg) { (void)testName; const str::EncodedStringView vw(msg); Microsoft::VisualStudio::CppUnitTestFramework::Assert::Fail(vw.wstring().c_str()); } + +#undef TEST_EXCEPTION +#undef TEST_THROWS +#undef TEST_SPECIFIC_EXCEPTION +#define TEST_EXCEPTION(X) (void)testName; try{ (X); TEST_FAIL(#X " should have thrown."); } CODA_OSS_TEST_EXCEPTION_catch_ +#define TEST_THROWS(X) (void)testName; try{ (X); TEST_FAIL(#X " should have thrown."); } catch (...){ TEST_ASSERT_TRUE(true); } +#define TEST_SPECIFIC_EXCEPTION(X, Y) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::ExpectException([&](){(X);}) + diff --git a/UnitTest/UnitTest.cpp b/UnitTest/UnitTest.cpp deleted file mode 100644 index 23d61acf7..000000000 --- a/UnitTest/UnitTest.cpp +++ /dev/null @@ -1,16 +0,0 @@ -#include "pch.h" -#include "CppUnitTest.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -namespace UnitTest -{ - TEST_CLASS(UnitTest) - { - public: - - TEST_METHOD(TestMethod1) - { - } - }; -} diff --git a/UnitTest/UnitTest.vcxproj b/UnitTest/UnitTest.vcxproj index 294a870d3..69f84e797 100644 --- a/UnitTest/UnitTest.vcxproj +++ b/UnitTest/UnitTest.vcxproj @@ -92,10 +92,11 @@ Use Level3 true - $(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + $(ProjectDir);$(SolutionDir)modules\c\;$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) _DEBUG;%(PreprocessorDefinitions) true pch.h + AdvancedVectorExtensions2 Windows @@ -107,10 +108,11 @@ Use Level3 true - $(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + $(ProjectDir);$(SolutionDir)modules\c\;$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) WIN32;_DEBUG;%(PreprocessorDefinitions) true pch.h + AdvancedVectorExtensions2 Windows @@ -124,10 +126,11 @@ true true true - $(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + $(ProjectDir);$(SolutionDir)modules\c\;$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) WIN32;NDEBUG;%(PreprocessorDefinitions) true pch.h + AdvancedVectorExtensions2 Windows @@ -143,10 +146,11 @@ true true true - $(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + $(ProjectDir);$(SolutionDir)modules\c\;$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) NDEBUG;%(PreprocessorDefinitions) true pch.h + AdvancedVectorExtensions2 Windows @@ -156,18 +160,30 @@ + + true + true + true + true + + + Create Create Create Create - + + + + {9997e895-5161-4ddf-8f3f-099894cb2f21} + {8f357a19-799e-4971-850e-3f28485c130b} diff --git a/UnitTest/UnitTest.vcxproj.filters b/UnitTest/UnitTest.vcxproj.filters index 470ad0c70..7d89690af 100644 --- a/UnitTest/UnitTest.vcxproj.filters +++ b/UnitTest/UnitTest.vcxproj.filters @@ -1,30 +1,23 @@  - - {4FC737F1-C7A5-4376-A066-2A32D752A2FF} - cpp;c;cc;cxx;c++;cppm;ixx;def;odl;idl;hpj;bat;asm;asmx - - - {93995380-89BD-4b04-88EB-625FBE52EBFB} - h;hh;hpp;hxx;h++;hm;inl;inc;ipp;xsd - - - {67DA6AB6-F800-4c08-8B7A-83BB121AAD01} - rc;ico;cur;bmp;dlg;rc2;rct;bin;rgs;gif;jpg;jpeg;jpe;resx;tiff;tif;png;wav;mfcribbon-ms + + {d6b8959a-344d-4af2-b926-05be973609a4} - - Source Files + + nrt - - Source Files + + + nrt + - - Header Files - + + + \ No newline at end of file diff --git a/UnitTest/nrt.cpp b/UnitTest/nrt.cpp new file mode 100644 index 000000000..b9f365590 --- /dev/null +++ b/UnitTest/nrt.cpp @@ -0,0 +1,10 @@ +#include "pch.h" +#include "CppUnitTest.h" + +namespace nrt +{ +TEST_CLASS(test_utils){ public: +#include "nrt/unittests/test_utils.c" +}; + +} \ No newline at end of file diff --git a/UnitTest/pch.h b/UnitTest/pch.h index a98b1bd98..ff2614e19 100644 --- a/UnitTest/pch.h +++ b/UnitTest/pch.h @@ -9,4 +9,21 @@ // add headers that you want to pre-compile here +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define NOMINMAX +#pragma warning(push) +#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to 'extern "C"' function under -EHc. Undefined behavior may occur if this function throws an exception. +#include +#pragma warning(pop) +#pragma comment(lib, "ws2_32") + +// We're building in Visual Studio ... used to control where we get a little bit of config info +#define NITRO_PCH 1 + +#include + +#include + +#include "Test.h" + #endif //PCH_H diff --git a/modules/c/nrt/unittests/test_utils.c b/modules/c/nrt/unittests/test_utils.c index 959cc68ba..e7191e012 100644 --- a/modules/c/nrt/unittests/test_utils.c +++ b/modules/c/nrt/unittests/test_utils.c @@ -473,8 +473,6 @@ TEST_CASE(test_matlab_dms) TEST_MAIN( - (void)argc; - (void)argv; CHECK(testParseZeroDegrees); CHECK(testParseZeroMinutes); CHECK(testParseErrorGeographicString); From abfbf2af46441ea8190868318ca7fffcdd09e0e0 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Wed, 12 Jul 2023 15:32:38 -0400 Subject: [PATCH 040/104] add remaining NRT unittests --- UnitTest/UnitTest.vcxproj | 36 +++++++++++++++++++++++++++++ UnitTest/UnitTest.vcxproj.filters | 18 +++++++++++++++ UnitTest/nrt.cpp | 25 ++++++++++++++++++++ modules/c/nrt/unittests/test_tree.c | 3 ++- 4 files changed, 81 insertions(+), 1 deletion(-) diff --git a/UnitTest/UnitTest.vcxproj b/UnitTest/UnitTest.vcxproj index 69f84e797..f2c3e3b68 100644 --- a/UnitTest/UnitTest.vcxproj +++ b/UnitTest/UnitTest.vcxproj @@ -160,6 +160,42 @@ + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + true true diff --git a/UnitTest/UnitTest.vcxproj.filters b/UnitTest/UnitTest.vcxproj.filters index 7d89690af..0e85b233c 100644 --- a/UnitTest/UnitTest.vcxproj.filters +++ b/UnitTest/UnitTest.vcxproj.filters @@ -14,6 +14,24 @@ nrt + + nrt + + + nrt + + + nrt + + + nrt + + + nrt + + + nrt + diff --git a/UnitTest/nrt.cpp b/UnitTest/nrt.cpp index b9f365590..2963bfab2 100644 --- a/UnitTest/nrt.cpp +++ b/UnitTest/nrt.cpp @@ -3,6 +3,31 @@ namespace nrt { + +TEST_CLASS(test_buffer_adapter){ public: +#include "nrt/unittests/test_buffer_adapter.c" +}; + +TEST_CLASS(test_core_values){ public: +#include "nrt/unittests/test_core_values.c" +}; + +TEST_CLASS(test_list){ public: +#include "nrt/unittests/test_list.c" +}; + +TEST_CLASS(test_nrt_byte_swap){ public: +#include "nrt/unittests/test_nrt_byte_swap.c" +}; + +TEST_CLASS(test_nrt_datetime){ public: +#include "nrt/unittests/test_nrt_datetime.c" +}; + +TEST_CLASS(test_tree){ public: +#include "nrt/unittests/test_tree.c" +}; + TEST_CLASS(test_utils){ public: #include "nrt/unittests/test_utils.c" }; diff --git a/modules/c/nrt/unittests/test_tree.c b/modules/c/nrt/unittests/test_tree.c index 85707b057..e35448d4c 100644 --- a/modules/c/nrt/unittests/test_tree.c +++ b/modules/c/nrt/unittests/test_tree.c @@ -109,7 +109,8 @@ TEST_CASE(testTree) nrt_Tree *tc = NULL; TEST_ASSERT(t != NULL); - makeTree(t, testName); + const char* testName_ = "testTree"; + makeTree(t, testName_); printf("Pre-order traversal:\n"); printf("=======================================================\n"); TEST_ASSERT(nrt_Tree_walk(t, &printElement, NRT_PRE_ORDER, NULL, &e)); From 0f6a3ec40cd9f6dda8869266a8d55e4cbe7fb451 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Wed, 12 Jul 2023 15:55:04 -0400 Subject: [PATCH 041/104] begin adding NITF unittests --- UnitTest/Test.h | 1 + UnitTest/TestCase.h | 8 +++- UnitTest/UnitTest.vcxproj | 57 +++++++++++++++++++++-- UnitTest/UnitTest.vcxproj.filters | 30 ++++++++++++ UnitTest/nitf-c.cpp | 39 ++++++++++++++++ UnitTest/pch.h | 1 + modules/c/nitf/unittests/test_geo_utils.c | 2 - modules/c/nitf/unittests/test_moveTREs.c | 11 ++--- 8 files changed, 135 insertions(+), 14 deletions(-) create mode 100644 UnitTest/nitf-c.cpp diff --git a/UnitTest/Test.h b/UnitTest/Test.h index 22bbaa00c..39ce4f60f 100644 --- a/UnitTest/Test.h +++ b/UnitTest/Test.h @@ -1,6 +1,7 @@ #pragma once #include "nrt/unittests/Test.h" +#include "nitf/unittests/Test.h" #include "TestCase.h" diff --git a/UnitTest/TestCase.h b/UnitTest/TestCase.h index f4438821f..f8c6eef9b 100644 --- a/UnitTest/TestCase.h +++ b/UnitTest/TestCase.h @@ -4,9 +4,15 @@ #include #include "CppUnitTest.h" -#include + #include +#undef TEST_ASSERT_NULL +#undef TEST_ASSERT +#undef TEST_ASSERT_ALMOST_EQ +#undef TEST_ASSERT_EQ +#include + #undef TEST_CHECK #undef TEST_ASSERT #undef TEST_ASSERT_NULL diff --git a/UnitTest/UnitTest.vcxproj b/UnitTest/UnitTest.vcxproj index f2c3e3b68..b0e8c8120 100644 --- a/UnitTest/UnitTest.vcxproj +++ b/UnitTest/UnitTest.vcxproj @@ -92,7 +92,7 @@ Use Level3 true - $(ProjectDir);$(SolutionDir)modules\c\;$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + $(ProjectDir);$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) _DEBUG;%(PreprocessorDefinitions) true pch.h @@ -108,7 +108,7 @@ Use Level3 true - $(ProjectDir);$(SolutionDir)modules\c\;$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + $(ProjectDir);$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) WIN32;_DEBUG;%(PreprocessorDefinitions) true pch.h @@ -126,7 +126,7 @@ true true true - $(ProjectDir);$(SolutionDir)modules\c\;$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + $(ProjectDir);$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) WIN32;NDEBUG;%(PreprocessorDefinitions) true pch.h @@ -146,7 +146,7 @@ true true true - $(ProjectDir);$(SolutionDir)modules\c\;$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + $(ProjectDir);$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) NDEBUG;%(PreprocessorDefinitions) true pch.h @@ -160,6 +160,54 @@ + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + true true @@ -203,6 +251,7 @@ true + Create diff --git a/UnitTest/UnitTest.vcxproj.filters b/UnitTest/UnitTest.vcxproj.filters index 0e85b233c..c2f1c7def 100644 --- a/UnitTest/UnitTest.vcxproj.filters +++ b/UnitTest/UnitTest.vcxproj.filters @@ -4,6 +4,9 @@ {d6b8959a-344d-4af2-b926-05be973609a4} + + {a03980e8-d43d-473b-9f2a-a883ddd94df0} + @@ -32,6 +35,33 @@ nrt + + nitf-c + + + nitf-c + + + nitf-c + + + nitf-c + + + nitf-c + + + nitf-c + + + nitf-c + + + nitf-c + + + nitf-c + diff --git a/UnitTest/nitf-c.cpp b/UnitTest/nitf-c.cpp new file mode 100644 index 000000000..6ee17653d --- /dev/null +++ b/UnitTest/nitf-c.cpp @@ -0,0 +1,39 @@ +#include "pch.h" +#include "CppUnitTest.h" + +namespace nitf_c +{ + +TEST_CLASS(test_create){ public: +#include "nitf/unittests/test_create.c" +}; + +//TEST_CLASS(test_create_nitf){ public: +//#include "nitf/unittests/test_create_nitf.c" +//}; + +TEST_CLASS(test_field){ public: +#include "nitf/unittests/test_field.c" +}; + +TEST_CLASS(test_geo_utils_){ public: // "TEST_CASE(test_geo_utils)" conflicts +#include "nitf/unittests/test_geo_utils.c" +}; + +TEST_CLASS(test_image_io){ public: +#include "nitf/unittests/test_image_io.c" +}; + +TEST_CLASS(test_mem_source){ public: +#include "nitf/unittests/test_mem_source.c" +}; + +TEST_CLASS(test_moveTREs){ public: +#include "nitf/unittests/test_moveTREs.c" +}; + +TEST_CLASS(test_zero_field){ public: +#include "nitf/unittests/test_zero_field.c" +}; + +} \ No newline at end of file diff --git a/UnitTest/pch.h b/UnitTest/pch.h index ff2614e19..b12134cfc 100644 --- a/UnitTest/pch.h +++ b/UnitTest/pch.h @@ -21,6 +21,7 @@ #define NITRO_PCH 1 #include +#include #include diff --git a/modules/c/nitf/unittests/test_geo_utils.c b/modules/c/nitf/unittests/test_geo_utils.c index f166daaa4..62f9fbddb 100644 --- a/modules/c/nitf/unittests/test_geo_utils.c +++ b/modules/c/nitf/unittests/test_geo_utils.c @@ -166,8 +166,6 @@ TEST_CASE(test_decimalToGeographic_normal) } TEST_MAIN( - (void)argc; - (void)argv; CHECK(test_geo_utils); CHECK(test_decimalToGeographic_normal); ) diff --git a/modules/c/nitf/unittests/test_moveTREs.c b/modules/c/nitf/unittests/test_moveTREs.c index b40fa9695..ea02f9b80 100644 --- a/modules/c/nitf/unittests/test_moveTREs.c +++ b/modules/c/nitf/unittests/test_moveTREs.c @@ -30,8 +30,6 @@ #include #include "Test.h" -static const char* const DATE_TIME = "20120126000000"; - static NITF_BOOL insertTRE(nitf_Extensions* ext, nitf_Error* error) { @@ -67,6 +65,8 @@ NITF_BOOL initializeTREs(nitf_FileHeader* header, nitf_Error* error) static NITF_BOOL initializeHeader(nitf_FileHeader* header, nitf_Error* error) { + static const char* const DATE_TIME = "20120126000000"; + return (nitf_Field_setString(header->fileHeader, "NITF", error) && nitf_Field_setString(header->fileVersion, "02.10", error) && nitf_Field_setUint32(header->complianceLevel, 3, error) && @@ -122,9 +122,6 @@ TEST_CASE(testUnmerge) nitf_Record_destruct(&record); } -int main() // int argc, char **argv -{ +TEST_MAIN( CHECK(testUnmerge); - return 0; -} - +) From 7f0c29aa593006e9ec6c05a46cc71ea11002c64e Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Wed, 12 Jul 2023 16:19:18 -0400 Subject: [PATCH 042/104] finish hooking up NITF unittests --- UnitTest/nitf-c.cpp | 6 ++--- .../c++/nitf/unittests/test_create_nitf++.cpp | 14 +++++++++++ modules/c/nitf/unittests/nitro_image_.c_ | 10 +++++--- modules/c/nitf/unittests/test_create_nitf.c | 23 ++++++++++--------- 4 files changed, 36 insertions(+), 17 deletions(-) diff --git a/UnitTest/nitf-c.cpp b/UnitTest/nitf-c.cpp index 6ee17653d..357becae8 100644 --- a/UnitTest/nitf-c.cpp +++ b/UnitTest/nitf-c.cpp @@ -8,9 +8,9 @@ TEST_CLASS(test_create){ public: #include "nitf/unittests/test_create.c" }; -//TEST_CLASS(test_create_nitf){ public: -//#include "nitf/unittests/test_create_nitf.c" -//}; +TEST_CLASS(test_create_nitf){ public: +#include "nitf/unittests/test_create_nitf.c" +}; TEST_CLASS(test_field){ public: #include "nitf/unittests/test_field.c" diff --git a/modules/c++/nitf/unittests/test_create_nitf++.cpp b/modules/c++/nitf/unittests/test_create_nitf++.cpp index 23a02686d..640dc22ae 100644 --- a/modules/c++/nitf/unittests/test_create_nitf++.cpp +++ b/modules/c++/nitf/unittests/test_create_nitf++.cpp @@ -150,6 +150,8 @@ static void test_create_nitf_with_byte_provider__addImageSegment(nitf::Record& r // a file in the j2k plugin. To make this test run, go to the file // and disable the check for blocking mode B. // To the best of my knowledge, nothing bad happens as a result. + const auto pNitroImage = getNitroImage(); + const auto& NITRO_IMAGE = *pNitroImage; header.setBlocking(NITRO_IMAGE.height, /*!< The number of rows */ NITRO_IMAGE.width, /*!< The number of columns */ NITRO_IMAGE.height, /*!< The number of rows/block */ @@ -176,6 +178,8 @@ static void test_create_nitf_with_byte_provider__writeNITF(nitf::Record& record, * Once you have CompressedByteProvider constructed, everything else * should work the same */ + const auto pNitroImage = getNitroImage(); + const auto& NITRO_IMAGE = *pNitroImage; const std::vector > bytesPerBlock{ { static_cast(NITRO_IMAGE.width) * NITRO_IMAGE.height * NUM_BANDS } }; nitf::CompressedByteProvider byteProvider(record, bytesPerBlock); nitf::Off fileOffset; @@ -212,6 +216,8 @@ static bool test_create_nitf_with_byte_provider__testRead(const std::string& pat // Read one block. It should match the first blockSize points of the // image. If it does, we got the blocking mode right. auto block = reinterpret_cast(imageReader.readBlock(0, &blockSize)); + const auto pNitroImage = getNitroImage(); + const auto& NITRO_IMAGE = *pNitroImage; const size_t imageLength = static_cast(NITRO_IMAGE.width) * NITRO_IMAGE.height; for (size_t jj = 0; jj < imageLength * NUM_BANDS; ++jj) @@ -286,6 +292,8 @@ static void test_create_nitf__addImageSegment(nitf::Record& record, bool isMono // a file in the j2k plugin. To make this test run, go to the file // and disable the check for blocking mode B. // To the best of my knowledge, nothing bad happens as a result. + const auto pNitroImage = getNitroImage(); + const auto& NITRO_IMAGE = *pNitroImage; header.setBlocking(NITRO_IMAGE.height, /*!< The number of rows */ NITRO_IMAGE.width, /*!< The number of columns */ NITRO_IMAGE.height, /*!< The number of rows/block */ @@ -305,6 +313,9 @@ static void test_create_nitf__writeNITF(nitf::Record& record, const std::string& nitf::ImageWriter imageWriter = writer.newImageWriter(0); nitf::ImageSource imageSource; + const auto pNitroImage = getNitroImage(); + const auto& NITRO_IMAGE = *pNitroImage; + /* make one bandSource per band */ for (int ii = 0; ii < NUM_BANDS; ++ii) { @@ -339,6 +350,9 @@ static bool test_create_nitf__testRead(const std::string& pathname, bool isMono nitf::Reader reader; nitf::Record record = reader.read(handle); + const auto pNitroImage = getNitroImage(); + const auto& NITRO_IMAGE = *pNitroImage; + for (int ii = 0; ii < static_cast(record.getNumImages()); ++ii) { nitf::ImageReader imageReader = reader.newImageReader(ii); diff --git a/modules/c/nitf/unittests/nitro_image_.c_ b/modules/c/nitf/unittests/nitro_image_.c_ index 611bc89e4..9b871824c 100644 --- a/modules/c/nitf/unittests/nitro_image_.c_ +++ b/modules/c/nitf/unittests/nitro_image_.c_ @@ -28,12 +28,15 @@ #pragma warning(push) #pragma warning(disable: 4125) // decimal digit terminates octal escape sequence #endif -static const struct { +struct NITRO_IMAGE_t { unsigned int width; unsigned int height; unsigned int bytesPerPixel; unsigned char data[188 * 36 * 3 + 1]; -} NITRO_IMAGE = { +}; +inline const NITRO_IMAGE_t* getNitroImage() +{ +static const struct NITRO_IMAGE_t retval = { 188, 36, 3, "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" @@ -971,7 +974,8 @@ static const struct { "\343\343\355\355\355\366\366\366\375\375\375\377\377\377\377\377\377\377" "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" - "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377", + "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377",}; +return &retval; }; #ifdef _MSC_VER #pragma warning(pop) diff --git a/modules/c/nitf/unittests/test_create_nitf.c b/modules/c/nitf/unittests/test_create_nitf.c index 6240db101..7f72f90f4 100644 --- a/modules/c/nitf/unittests/test_create_nitf.c +++ b/modules/c/nitf/unittests/test_create_nitf.c @@ -111,6 +111,7 @@ NITF_BOOL addImageSegment(nitf_Record *record, nitf_Error *error) nitf_ImageSegment *segment = NULL; nitf_ImageSubheader *header = NULL; nitf_BandInfo **bands = NULL; + const NITRO_IMAGE_t* pNITRO_IMAGE = NULL; int i; @@ -179,11 +180,12 @@ NITF_BOOL addImageSegment(nitf_Record *record, nitf_Error *error) goto CATCH_ERROR; /* set the blocking info */ + pNITRO_IMAGE = getNitroImage(); if (!nitf_ImageSubheader_setBlocking(header, - NITRO_IMAGE.height, /*!< The number of rows */ - NITRO_IMAGE.width, /*!< The number of columns */ - NITRO_IMAGE.height, /*!< The number of rows/block */ - NITRO_IMAGE.width, /*!< The number of columns/block */ + pNITRO_IMAGE->height, /*!< The number of rows */ + pNITRO_IMAGE->width, /*!< The number of columns */ + pNITRO_IMAGE->height, /*!< The number of rows/block */ + pNITRO_IMAGE->width, /*!< The number of columns/block */ "P", /*!< Image mode */ error)) goto CATCH_ERROR; @@ -232,8 +234,9 @@ NITF_BOOL writeNITF(nitf_Record *record, const char* filename, nitf_Error *error /* make one bandSource per band */ for (i = 0; i < 3; ++i) { + const NITRO_IMAGE_t* pNITRO_IMAGE = getNitroImage(); nitf_BandSource *bandSource = nitf_MemorySource_construct( - (char*)NITRO_IMAGE.data, NITRO_IMAGE.width * NITRO_IMAGE.height, + (char*)pNITRO_IMAGE->data, pNITRO_IMAGE->width * pNITRO_IMAGE->height, i, 1, 2, error); if (!bandSource) goto CATCH_ERROR; @@ -268,11 +271,11 @@ NITF_BOOL writeNITF(nitf_Record *record, const char* filename, nitf_Error *error } -TEST_CASE_ARGS(testCreate) +TEST_CASE(testCreate) { nitf_Record *record = NULL; nitf_Error error; - const char* outname = argc > 1 ? argv[1] : "test_create.ntf"; + const char* outname = "test_create.ntf"; record = nitf_Record_construct(NITF_VER_21, &error); TEST_ASSERT(record != NULL); @@ -282,13 +285,13 @@ TEST_CASE_ARGS(testCreate) nitf_Record_destruct(&record); } -TEST_CASE_ARGS(testRead) +TEST_CASE(testRead) { nitf_Reader *reader = NULL; nitf_Record *record = NULL; nitf_Error error; nitf_IOHandle io; - const char* outname = argc > 1 ? argv[1] : "test_create.ntf"; + const char* outname = "test_create.ntf"; io = nitf_IOHandle_create(outname, NITF_ACCESS_READONLY, NITF_OPEN_EXISTING, &error); reader = nitf_Reader_construct(&error); @@ -300,8 +303,6 @@ TEST_CASE_ARGS(testRead) } TEST_MAIN( - (void)argc; - (void)argv; CHECK_ARGS(testCreate); CHECK_ARGS(testRead); ) From 34103facf2c5a3738a9a68f2389d09081e78e8f2 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Wed, 12 Jul 2023 16:37:03 -0400 Subject: [PATCH 043/104] fix C compile errors --- modules/c/nitf/unittests/nitro_image_.c_ | 8 ++++---- modules/c/nitf/unittests/test_create_nitf.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/modules/c/nitf/unittests/nitro_image_.c_ b/modules/c/nitf/unittests/nitro_image_.c_ index 9b871824c..7a3fde11e 100644 --- a/modules/c/nitf/unittests/nitro_image_.c_ +++ b/modules/c/nitf/unittests/nitro_image_.c_ @@ -28,15 +28,15 @@ #pragma warning(push) #pragma warning(disable: 4125) // decimal digit terminates octal escape sequence #endif -struct NITRO_IMAGE_t { +typedef struct { unsigned int width; unsigned int height; unsigned int bytesPerPixel; unsigned char data[188 * 36 * 3 + 1]; -}; -inline const NITRO_IMAGE_t* getNitroImage() +} NITRO_IMAGE_t; +static inline const NITRO_IMAGE_t* getNitroImage() { -static const struct NITRO_IMAGE_t retval = { +static const NITRO_IMAGE_t retval = { 188, 36, 3, "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377" diff --git a/modules/c/nitf/unittests/test_create_nitf.c b/modules/c/nitf/unittests/test_create_nitf.c index 7f72f90f4..d092629ac 100644 --- a/modules/c/nitf/unittests/test_create_nitf.c +++ b/modules/c/nitf/unittests/test_create_nitf.c @@ -303,7 +303,7 @@ TEST_CASE(testRead) } TEST_MAIN( - CHECK_ARGS(testCreate); - CHECK_ARGS(testRead); + CHECK(testCreate); + CHECK(testRead); ) From d3d38d42bfc1a4d5b9dcdabc5459d52a7fe18c3d Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Wed, 12 Jul 2023 16:50:06 -0400 Subject: [PATCH 044/104] begin adding NITF-C++ unittests --- UnitTest/UnitTest.vcxproj | 134 +++++++++++++++++++-- UnitTest/UnitTest.vcxproj.filters | 63 ++++++++++ UnitTest/nitf-c++.cpp | 83 +++++++++++++ UnitTest/pch.h | 4 + modules/c++/nitf/include/nitf/coda-oss.hpp | 4 + 5 files changed, 277 insertions(+), 11 deletions(-) create mode 100644 UnitTest/nitf-c++.cpp diff --git a/UnitTest/UnitTest.vcxproj b/UnitTest/UnitTest.vcxproj index b0e8c8120..aa712fb23 100644 --- a/UnitTest/UnitTest.vcxproj +++ b/UnitTest/UnitTest.vcxproj @@ -92,7 +92,7 @@ Use Level3 true - $(ProjectDir);$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + $(ProjectDir);$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) _DEBUG;%(PreprocessorDefinitions) true pch.h @@ -100,7 +100,7 @@ Windows - $(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) + $(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;$(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) @@ -108,7 +108,7 @@ Use Level3 true - $(ProjectDir);$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + $(ProjectDir);$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) WIN32;_DEBUG;%(PreprocessorDefinitions) true pch.h @@ -116,7 +116,7 @@ Windows - $(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) + $(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;$(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) @@ -126,7 +126,7 @@ true true true - $(ProjectDir);$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + $(ProjectDir);$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) WIN32;NDEBUG;%(PreprocessorDefinitions) true pch.h @@ -136,7 +136,7 @@ Windows true true - $(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) + $(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;$(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) @@ -146,7 +146,7 @@ true true true - $(ProjectDir);$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + $(ProjectDir);$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) NDEBUG;%(PreprocessorDefinitions) true pch.h @@ -156,10 +156,124 @@ Windows true true - $(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) + $(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;$(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + + + true + true + true + true + true true @@ -251,6 +365,7 @@ true + @@ -266,9 +381,6 @@ - - {9997e895-5161-4ddf-8f3f-099894cb2f21} - {8f357a19-799e-4971-850e-3f28485c130b} diff --git a/UnitTest/UnitTest.vcxproj.filters b/UnitTest/UnitTest.vcxproj.filters index c2f1c7def..8cada79ca 100644 --- a/UnitTest/UnitTest.vcxproj.filters +++ b/UnitTest/UnitTest.vcxproj.filters @@ -7,6 +7,9 @@ {a03980e8-d43d-473b-9f2a-a883ddd94df0} + + {555282a7-bf5d-4012-842a-435bfb7324ab} + @@ -62,6 +65,66 @@ nitf-c + + nitf-c++ + + + nitf-c++ + + + nitf-c++ + + + nitf-c++ + + + nitf-c++ + + + nitf-c++ + + + nitf-c++ + + + nitf-c++ + + + nitf-c++ + + + nitf-c++ + + + nitf-c++ + + + nitf-c++ + + + nitf-c++ + + + nitf-c++ + + + nitf-c++ + + + nitf-c++ + + + nitf-c++ + + + nitf-c++ + + + nitf-c++ + + + nitf-c++ + diff --git a/UnitTest/nitf-c++.cpp b/UnitTest/nitf-c++.cpp new file mode 100644 index 000000000..0f1cdda6b --- /dev/null +++ b/UnitTest/nitf-c++.cpp @@ -0,0 +1,83 @@ +#include "pch.h" +#include "CppUnitTest.h" + +namespace nitf_cpp +{ + +TEST_CLASS(test_create_nitf__){ public: +#include "nitf/unittests/test_create_nitf++.cpp" +}; + +//TEST_CLASS(test_field__){ public: +//#include "nitf/unittests/test_field++.cpp" +//}; + +TEST_CLASS(test_hash_table_1__){ public: +#include "nitf/unittests/test_hash_table_1++.cpp" +}; + +TEST_CLASS(test_image_blocker){ public: +#include "nitf/unittests/test_image_blocker.cpp" +}; + +TEST_CLASS(test_image_loading__){ public: +#include "nitf/unittests/test_image_loading++.cpp" +}; + +TEST_CLASS(test_image_segment_blank_nm_compression){ public: +#include "nitf/unittests/test_image_segment_blank_nm_compression.cpp" +}; + +TEST_CLASS(test_image_segment_computer){ public: +#include "nitf/unittests/test_image_segment_computer.cpp" +}; + +TEST_CLASS(test_image_writer){ public: +#include "nitf/unittests/test_image_writer.cpp" +}; + +//TEST_CLASS(test_j2k_compress_tile){ public: +//#include "nitf/unittests/test_j2k_compress_tile.cpp" +//}; + +//TEST_CLASS(test_j2k_compressed_byte_provider){ public: +//#include "nitf/unittests/test_j2k_compressed_byte_provider.cpp" +//}; + +//TEST_CLASS(test_j2k_loading__){ public: +//#include "nitf/unittests/test_j2k_loading++.cpp" +//}; + +TEST_CLASS(test_j2k_read_tile){ public: +#include "nitf/unittests/test_j2k_read_tile.cpp" +}; + +//TEST_CLASS(test_load_plugins){ public: +//#include "nitf/unittests/test_load_plugins.cpp" +//}; + +TEST_CLASS(test_nitf_buffer_list){ public: +#include "nitf/unittests/test_nitf_buffer_list.cpp" +}; + +//TEST_CLASS(test_tre_create__){ public: +//#include "nitf/unittests/test_tre_create++.cpp" +//}; +// +//TEST_CLASS(test_tre_mods){ public: +//#include "nitf/unittests/test_tre_mods.cpp" +//}; +// +//TEST_CLASS(test_tre_mods__){ public: +//#include "nitf/unittests/test_tre_mods++.cpp" +//}; + +TEST_CLASS(test_tre_read){ public: +#include "nitf/unittests/test_tre_read.cpp" +}; + +//TEST_CLASS(test_writer_3__){ public: +//#include "nitf/unittests/test_writer_3++.cpp" +//}; + +} \ No newline at end of file diff --git a/UnitTest/pch.h b/UnitTest/pch.h index b12134cfc..366df314e 100644 --- a/UnitTest/pch.h +++ b/UnitTest/pch.h @@ -25,6 +25,10 @@ #include +#include +#include +#include + #include "Test.h" #endif //PCH_H diff --git a/modules/c++/nitf/include/nitf/coda-oss.hpp b/modules/c++/nitf/include/nitf/coda-oss.hpp index 5fd053f32..18467eac9 100644 --- a/modules/c++/nitf/include/nitf/coda-oss.hpp +++ b/modules/c++/nitf/include/nitf/coda-oss.hpp @@ -53,9 +53,13 @@ CODA_OSS_disable_warning_push #include #include #include +#include +#include #include #include +#include #include #include +#include CODA_OSS_disable_warning_pop From 2e3e45568774c3a42e43fe604827b0df8dd3c836 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Wed, 12 Jul 2023 17:18:27 -0400 Subject: [PATCH 045/104] most NITF-C++ unittests building --- UnitTest/nitf-c++.cpp | 6 +++--- UnitTest/pch.h | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/UnitTest/nitf-c++.cpp b/UnitTest/nitf-c++.cpp index 0f1cdda6b..35e3130cd 100644 --- a/UnitTest/nitf-c++.cpp +++ b/UnitTest/nitf-c++.cpp @@ -8,9 +8,9 @@ TEST_CLASS(test_create_nitf__){ public: #include "nitf/unittests/test_create_nitf++.cpp" }; -//TEST_CLASS(test_field__){ public: -//#include "nitf/unittests/test_field++.cpp" -//}; +TEST_CLASS(test_field__){ public: +#include "nitf/unittests/test_field++.cpp" +}; TEST_CLASS(test_hash_table_1__){ public: #include "nitf/unittests/test_hash_table_1++.cpp" diff --git a/UnitTest/pch.h b/UnitTest/pch.h index 366df314e..b6367177c 100644 --- a/UnitTest/pch.h +++ b/UnitTest/pch.h @@ -22,12 +22,14 @@ #include #include +#include #include #include #include #include +#include #include "Test.h" From 664e36cabc8a512880ea664ada4f14ad4249d303 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Wed, 12 Jul 2023 20:56:39 -0400 Subject: [PATCH 046/104] "const" on return value has no effect --- externals/coda-oss/modules/c++/coda-oss.vcxproj | 2 -- modules/c++/nitf/include/nitf/TREField.hpp | 8 ++++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/externals/coda-oss/modules/c++/coda-oss.vcxproj b/externals/coda-oss/modules/c++/coda-oss.vcxproj index 23e530279..9c8a98160 100644 --- a/externals/coda-oss/modules/c++/coda-oss.vcxproj +++ b/externals/coda-oss/modules/c++/coda-oss.vcxproj @@ -581,7 +581,6 @@ true Guard ProgramDatabase - true true true true @@ -611,7 +610,6 @@ pch.h true Guard - true true true true diff --git a/modules/c++/nitf/include/nitf/TREField.hpp b/modules/c++/nitf/include/nitf/TREField.hpp index c6a085715..56b18158f 100644 --- a/modules/c++/nitf/include/nitf/TREField.hpp +++ b/modules/c++/nitf/include/nitf/TREField.hpp @@ -51,7 +51,7 @@ namespace nitf const_field(const_field&&) = default; const_field& operator=(const_field&&) = delete; - const T getFieldValue() const // "const" as a hint to clients that this value is really stored elsewhere + T getFieldValue() const { return tre_.getFieldValue(tag_); } @@ -78,7 +78,7 @@ namespace nitf { tre_.setFieldValue(field_.tag_, v, forceUpdate_); } - const T getFieldValue() const + T getFieldValue() const { return field_.getFieldValue(); } @@ -110,11 +110,11 @@ namespace nitf field_.setFieldValue(v); } - const value_type value() const // "const" as a hint to clients that this value is really stored elsewhere + value_type value() const { return field_.getFieldValue(); } - operator const value_type() const + operator value_type() const { return value(); } From d3d9d4d0fa6367e3c344f8f64b10a1d95ebefbe1 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Wed, 12 Jul 2023 21:29:43 -0400 Subject: [PATCH 047/104] 64-bit only, no Win32/x86 --- UnitTest/UnitTest.vcxproj | 141 -------------------------------------- nitro.sln | 86 ----------------------- 2 files changed, 227 deletions(-) diff --git a/UnitTest/UnitTest.vcxproj b/UnitTest/UnitTest.vcxproj index aa712fb23..d098eef76 100644 --- a/UnitTest/UnitTest.vcxproj +++ b/UnitTest/UnitTest.vcxproj @@ -1,14 +1,6 @@ - - Debug - Win32 - - - Release - Win32 - Debug x64 @@ -27,21 +19,6 @@ NativeUnitTestProject - - DynamicLibrary - true - v143 - Unicode - false - - - DynamicLibrary - false - v143 - true - Unicode - false - DynamicLibrary true @@ -62,12 +39,6 @@ - - - - - - @@ -78,12 +49,6 @@ true - - true - - - false - false @@ -103,42 +68,6 @@ $(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;$(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) - - - Use - Level3 - true - $(ProjectDir);$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) - WIN32;_DEBUG;%(PreprocessorDefinitions) - true - pch.h - AdvancedVectorExtensions2 - - - Windows - $(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;$(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) - - - - - Use - Level3 - true - true - true - $(ProjectDir);$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) - WIN32;NDEBUG;%(PreprocessorDefinitions) - true - pch.h - AdvancedVectorExtensions2 - - - Windows - true - true - $(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;$(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) - - Use @@ -161,206 +90,138 @@ - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true - true - true true true @@ -370,8 +231,6 @@ Create - Create - Create Create diff --git a/nitro.sln b/nitro.sln index 45384a6fa..06c7ef2cc 100644 --- a/nitro.sln +++ b/nitro.sln @@ -74,179 +74,93 @@ EndProject Global GlobalSection(SolutionConfigurationPlatforms) = preSolution Debug|x64 = Debug|x64 - Debug|x86 = Debug|x86 Release|x64 = Release|x64 - Release|x86 = Release|x86 EndGlobalSection GlobalSection(ProjectConfigurationPlatforms) = postSolution {F06550AD-CFC7-40B8-8727-6C82C69A8982}.Debug|x64.ActiveCfg = Debug|x64 {F06550AD-CFC7-40B8-8727-6C82C69A8982}.Debug|x64.Build.0 = Debug|x64 - {F06550AD-CFC7-40B8-8727-6C82C69A8982}.Debug|x86.ActiveCfg = Debug|x64 - {F06550AD-CFC7-40B8-8727-6C82C69A8982}.Debug|x86.Build.0 = Debug|x64 {F06550AD-CFC7-40B8-8727-6C82C69A8982}.Release|x64.ActiveCfg = Release|x64 {F06550AD-CFC7-40B8-8727-6C82C69A8982}.Release|x64.Build.0 = Release|x64 - {F06550AD-CFC7-40B8-8727-6C82C69A8982}.Release|x86.ActiveCfg = Release|x64 - {F06550AD-CFC7-40B8-8727-6C82C69A8982}.Release|x86.Build.0 = Release|x64 {8F357A19-799E-4971-850E-3F28485C130B}.Debug|x64.ActiveCfg = Debug|x64 {8F357A19-799E-4971-850E-3F28485C130B}.Debug|x64.Build.0 = Debug|x64 - {8F357A19-799E-4971-850E-3F28485C130B}.Debug|x86.ActiveCfg = Debug|x64 - {8F357A19-799E-4971-850E-3F28485C130B}.Debug|x86.Build.0 = Debug|x64 {8F357A19-799E-4971-850E-3F28485C130B}.Release|x64.ActiveCfg = Release|x64 {8F357A19-799E-4971-850E-3F28485C130B}.Release|x64.Build.0 = Release|x64 - {8F357A19-799E-4971-850E-3F28485C130B}.Release|x86.ActiveCfg = Release|x64 - {8F357A19-799E-4971-850E-3F28485C130B}.Release|x86.Build.0 = Release|x64 {730B1E6E-2469-4F9E-B093-D0C6262453C9}.Debug|x64.ActiveCfg = Debug|x64 {730B1E6E-2469-4F9E-B093-D0C6262453C9}.Debug|x64.Build.0 = Debug|x64 - {730B1E6E-2469-4F9E-B093-D0C6262453C9}.Debug|x86.ActiveCfg = Debug|x64 - {730B1E6E-2469-4F9E-B093-D0C6262453C9}.Debug|x86.Build.0 = Debug|x64 {730B1E6E-2469-4F9E-B093-D0C6262453C9}.Release|x64.ActiveCfg = Release|x64 {730B1E6E-2469-4F9E-B093-D0C6262453C9}.Release|x64.Build.0 = Release|x64 - {730B1E6E-2469-4F9E-B093-D0C6262453C9}.Release|x86.ActiveCfg = Release|x64 - {730B1E6E-2469-4F9E-B093-D0C6262453C9}.Release|x86.Build.0 = Release|x64 {53F9F908-C678-4DEE-9309-E71C1D03A45F}.Debug|x64.ActiveCfg = Debug|x64 {53F9F908-C678-4DEE-9309-E71C1D03A45F}.Debug|x64.Build.0 = Debug|x64 - {53F9F908-C678-4DEE-9309-E71C1D03A45F}.Debug|x86.ActiveCfg = Debug|x64 - {53F9F908-C678-4DEE-9309-E71C1D03A45F}.Debug|x86.Build.0 = Debug|x64 {53F9F908-C678-4DEE-9309-E71C1D03A45F}.Release|x64.ActiveCfg = Release|x64 {53F9F908-C678-4DEE-9309-E71C1D03A45F}.Release|x64.Build.0 = Release|x64 - {53F9F908-C678-4DEE-9309-E71C1D03A45F}.Release|x86.ActiveCfg = Release|x64 - {53F9F908-C678-4DEE-9309-E71C1D03A45F}.Release|x86.Build.0 = Release|x64 {51D7B426-899E-428D-9F69-5DDAC9E403FB}.Debug|x64.ActiveCfg = Debug|x64 {51D7B426-899E-428D-9F69-5DDAC9E403FB}.Debug|x64.Build.0 = Debug|x64 - {51D7B426-899E-428D-9F69-5DDAC9E403FB}.Debug|x86.ActiveCfg = Debug|x64 - {51D7B426-899E-428D-9F69-5DDAC9E403FB}.Debug|x86.Build.0 = Debug|x64 {51D7B426-899E-428D-9F69-5DDAC9E403FB}.Release|x64.ActiveCfg = Release|x64 {51D7B426-899E-428D-9F69-5DDAC9E403FB}.Release|x64.Build.0 = Release|x64 - {51D7B426-899E-428D-9F69-5DDAC9E403FB}.Release|x86.ActiveCfg = Release|x64 - {51D7B426-899E-428D-9F69-5DDAC9E403FB}.Release|x86.Build.0 = Release|x64 {12AA0752-4EE3-4E0A-85AF-0E5DEADBF343}.Debug|x64.ActiveCfg = Debug|x64 {12AA0752-4EE3-4E0A-85AF-0E5DEADBF343}.Debug|x64.Build.0 = Debug|x64 - {12AA0752-4EE3-4E0A-85AF-0E5DEADBF343}.Debug|x86.ActiveCfg = Debug|x64 - {12AA0752-4EE3-4E0A-85AF-0E5DEADBF343}.Debug|x86.Build.0 = Debug|x64 {12AA0752-4EE3-4E0A-85AF-0E5DEADBF343}.Release|x64.ActiveCfg = Release|x64 {12AA0752-4EE3-4E0A-85AF-0E5DEADBF343}.Release|x64.Build.0 = Release|x64 - {12AA0752-4EE3-4E0A-85AF-0E5DEADBF343}.Release|x86.ActiveCfg = Release|x64 - {12AA0752-4EE3-4E0A-85AF-0E5DEADBF343}.Release|x86.Build.0 = Release|x64 {D1D7FCD3-6130-4504-9DA0-9D80506BE55E}.Debug|x64.ActiveCfg = Debug|x64 {D1D7FCD3-6130-4504-9DA0-9D80506BE55E}.Debug|x64.Build.0 = Debug|x64 - {D1D7FCD3-6130-4504-9DA0-9D80506BE55E}.Debug|x86.ActiveCfg = Debug|x64 - {D1D7FCD3-6130-4504-9DA0-9D80506BE55E}.Debug|x86.Build.0 = Debug|x64 {D1D7FCD3-6130-4504-9DA0-9D80506BE55E}.Release|x64.ActiveCfg = Release|x64 {D1D7FCD3-6130-4504-9DA0-9D80506BE55E}.Release|x64.Build.0 = Release|x64 - {D1D7FCD3-6130-4504-9DA0-9D80506BE55E}.Release|x86.ActiveCfg = Release|x64 - {D1D7FCD3-6130-4504-9DA0-9D80506BE55E}.Release|x86.Build.0 = Release|x64 {023DE06D-3967-4406-B1B8-032118BB2552}.Debug|x64.ActiveCfg = Debug|x64 {023DE06D-3967-4406-B1B8-032118BB2552}.Debug|x64.Build.0 = Debug|x64 - {023DE06D-3967-4406-B1B8-032118BB2552}.Debug|x86.ActiveCfg = Debug|x64 - {023DE06D-3967-4406-B1B8-032118BB2552}.Debug|x86.Build.0 = Debug|x64 {023DE06D-3967-4406-B1B8-032118BB2552}.Release|x64.ActiveCfg = Release|x64 {023DE06D-3967-4406-B1B8-032118BB2552}.Release|x64.Build.0 = Release|x64 - {023DE06D-3967-4406-B1B8-032118BB2552}.Release|x86.ActiveCfg = Release|x64 - {023DE06D-3967-4406-B1B8-032118BB2552}.Release|x86.Build.0 = Release|x64 {CF5B4F02-364D-4117-9FB9-6C9C7938E412}.Debug|x64.ActiveCfg = Debug|x64 {CF5B4F02-364D-4117-9FB9-6C9C7938E412}.Debug|x64.Build.0 = Debug|x64 - {CF5B4F02-364D-4117-9FB9-6C9C7938E412}.Debug|x86.ActiveCfg = Debug|x64 - {CF5B4F02-364D-4117-9FB9-6C9C7938E412}.Debug|x86.Build.0 = Debug|x64 {CF5B4F02-364D-4117-9FB9-6C9C7938E412}.Release|x64.ActiveCfg = Release|x64 {CF5B4F02-364D-4117-9FB9-6C9C7938E412}.Release|x64.Build.0 = Release|x64 - {CF5B4F02-364D-4117-9FB9-6C9C7938E412}.Release|x86.ActiveCfg = Release|x64 - {CF5B4F02-364D-4117-9FB9-6C9C7938E412}.Release|x86.Build.0 = Release|x64 {78849481-D356-4CC7-B182-31C21F857ED1}.Debug|x64.ActiveCfg = Debug|x64 {78849481-D356-4CC7-B182-31C21F857ED1}.Debug|x64.Build.0 = Debug|x64 - {78849481-D356-4CC7-B182-31C21F857ED1}.Debug|x86.ActiveCfg = Debug|x64 - {78849481-D356-4CC7-B182-31C21F857ED1}.Debug|x86.Build.0 = Debug|x64 {78849481-D356-4CC7-B182-31C21F857ED1}.Release|x64.ActiveCfg = Release|x64 {78849481-D356-4CC7-B182-31C21F857ED1}.Release|x64.Build.0 = Release|x64 - {78849481-D356-4CC7-B182-31C21F857ED1}.Release|x86.ActiveCfg = Release|x64 - {78849481-D356-4CC7-B182-31C21F857ED1}.Release|x86.Build.0 = Release|x64 {839FF52C-57D1-45B6-81FD-5C7D72523EE5}.Debug|x64.ActiveCfg = Debug|x64 {839FF52C-57D1-45B6-81FD-5C7D72523EE5}.Debug|x64.Build.0 = Debug|x64 - {839FF52C-57D1-45B6-81FD-5C7D72523EE5}.Debug|x86.ActiveCfg = Debug|x64 - {839FF52C-57D1-45B6-81FD-5C7D72523EE5}.Debug|x86.Build.0 = Debug|x64 {839FF52C-57D1-45B6-81FD-5C7D72523EE5}.Release|x64.ActiveCfg = Release|x64 {839FF52C-57D1-45B6-81FD-5C7D72523EE5}.Release|x64.Build.0 = Release|x64 - {839FF52C-57D1-45B6-81FD-5C7D72523EE5}.Release|x86.ActiveCfg = Release|x64 - {839FF52C-57D1-45B6-81FD-5C7D72523EE5}.Release|x86.Build.0 = Release|x64 {2BAAACA9-A5A4-412C-AE52-B16C2D107F55}.Debug|x64.ActiveCfg = Debug|x64 {2BAAACA9-A5A4-412C-AE52-B16C2D107F55}.Debug|x64.Build.0 = Debug|x64 - {2BAAACA9-A5A4-412C-AE52-B16C2D107F55}.Debug|x86.ActiveCfg = Debug|x64 - {2BAAACA9-A5A4-412C-AE52-B16C2D107F55}.Debug|x86.Build.0 = Debug|x64 {2BAAACA9-A5A4-412C-AE52-B16C2D107F55}.Release|x64.ActiveCfg = Release|x64 {2BAAACA9-A5A4-412C-AE52-B16C2D107F55}.Release|x64.Build.0 = Release|x64 - {2BAAACA9-A5A4-412C-AE52-B16C2D107F55}.Release|x86.ActiveCfg = Release|x64 - {2BAAACA9-A5A4-412C-AE52-B16C2D107F55}.Release|x86.Build.0 = Release|x64 {D749AA73-4C9A-473D-96BB-070A6D9CAA54}.Debug|x64.ActiveCfg = Debug|x64 {D749AA73-4C9A-473D-96BB-070A6D9CAA54}.Debug|x64.Build.0 = Debug|x64 - {D749AA73-4C9A-473D-96BB-070A6D9CAA54}.Debug|x86.ActiveCfg = Debug|x64 - {D749AA73-4C9A-473D-96BB-070A6D9CAA54}.Debug|x86.Build.0 = Debug|x64 {D749AA73-4C9A-473D-96BB-070A6D9CAA54}.Release|x64.ActiveCfg = Release|x64 {D749AA73-4C9A-473D-96BB-070A6D9CAA54}.Release|x64.Build.0 = Release|x64 - {D749AA73-4C9A-473D-96BB-070A6D9CAA54}.Release|x86.ActiveCfg = Release|x64 - {D749AA73-4C9A-473D-96BB-070A6D9CAA54}.Release|x86.Build.0 = Release|x64 {53F9F908-C678-4DEE-9309-E71C1E03A45F}.Debug|x64.ActiveCfg = Debug|x64 {53F9F908-C678-4DEE-9309-E71C1E03A45F}.Debug|x64.Build.0 = Debug|x64 - {53F9F908-C678-4DEE-9309-E71C1E03A45F}.Debug|x86.ActiveCfg = Debug|x64 - {53F9F908-C678-4DEE-9309-E71C1E03A45F}.Debug|x86.Build.0 = Debug|x64 {53F9F908-C678-4DEE-9309-E71C1E03A45F}.Release|x64.ActiveCfg = Release|x64 {53F9F908-C678-4DEE-9309-E71C1E03A45F}.Release|x64.Build.0 = Release|x64 - {53F9F908-C678-4DEE-9309-E71C1E03A45F}.Release|x86.ActiveCfg = Release|x64 - {53F9F908-C678-4DEE-9309-E71C1E03A45F}.Release|x86.Build.0 = Release|x64 {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Debug|x64.ActiveCfg = Debug|x64 {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Debug|x64.Build.0 = Debug|x64 - {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Debug|x86.ActiveCfg = Debug|x64 - {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Debug|x86.Build.0 = Debug|x64 {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Release|x64.ActiveCfg = Release|x64 {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Release|x64.Build.0 = Release|x64 - {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Release|x86.ActiveCfg = Release|x64 - {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Release|x86.Build.0 = Release|x64 {E610F11D-1240-4260-87F8-504B49DB6915}.Debug|x64.ActiveCfg = Debug|x64 {E610F11D-1240-4260-87F8-504B49DB6915}.Debug|x64.Build.0 = Debug|x64 - {E610F11D-1240-4260-87F8-504B49DB6915}.Debug|x86.ActiveCfg = Debug|x64 - {E610F11D-1240-4260-87F8-504B49DB6915}.Debug|x86.Build.0 = Debug|x64 {E610F11D-1240-4260-87F8-504B49DB6915}.Release|x64.ActiveCfg = Release|x64 {E610F11D-1240-4260-87F8-504B49DB6915}.Release|x64.Build.0 = Release|x64 - {E610F11D-1240-4260-87F8-504B49DB6915}.Release|x86.ActiveCfg = Release|x64 - {E610F11D-1240-4260-87F8-504B49DB6915}.Release|x86.Build.0 = Release|x64 {A676EDF3-F231-47C8-A6E6-0FE50B50B71B}.Debug|x64.ActiveCfg = Debug|x64 {A676EDF3-F231-47C8-A6E6-0FE50B50B71B}.Debug|x64.Build.0 = Debug|x64 - {A676EDF3-F231-47C8-A6E6-0FE50B50B71B}.Debug|x86.ActiveCfg = Debug|x64 - {A676EDF3-F231-47C8-A6E6-0FE50B50B71B}.Debug|x86.Build.0 = Debug|x64 {A676EDF3-F231-47C8-A6E6-0FE50B50B71B}.Release|x64.ActiveCfg = Release|x64 {A676EDF3-F231-47C8-A6E6-0FE50B50B71B}.Release|x64.Build.0 = Release|x64 - {A676EDF3-F231-47C8-A6E6-0FE50B50B71B}.Release|x86.ActiveCfg = Release|x64 - {A676EDF3-F231-47C8-A6E6-0FE50B50B71B}.Release|x86.Build.0 = Release|x64 {C787537A-0CAC-4D6D-A6D6-A66765A06753}.Debug|x64.ActiveCfg = Debug|x64 {C787537A-0CAC-4D6D-A6D6-A66765A06753}.Debug|x64.Build.0 = Debug|x64 - {C787537A-0CAC-4D6D-A6D6-A66765A06753}.Debug|x86.ActiveCfg = Debug|x64 - {C787537A-0CAC-4D6D-A6D6-A66765A06753}.Debug|x86.Build.0 = Debug|x64 {C787537A-0CAC-4D6D-A6D6-A66765A06753}.Release|x64.ActiveCfg = Release|x64 {C787537A-0CAC-4D6D-A6D6-A66765A06753}.Release|x64.Build.0 = Release|x64 - {C787537A-0CAC-4D6D-A6D6-A66765A06753}.Release|x86.ActiveCfg = Release|x64 - {C787537A-0CAC-4D6D-A6D6-A66765A06753}.Release|x86.Build.0 = Release|x64 {0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E}.Debug|x64.ActiveCfg = Debug|x64 {0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E}.Debug|x64.Build.0 = Debug|x64 - {0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E}.Debug|x86.ActiveCfg = Debug|x64 - {0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E}.Debug|x86.Build.0 = Debug|x64 {0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E}.Release|x64.ActiveCfg = Release|x64 {0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E}.Release|x64.Build.0 = Release|x64 - {0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E}.Release|x86.ActiveCfg = Release|x64 - {0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E}.Release|x86.Build.0 = Release|x64 {9997E895-5161-4DDF-8F3F-099894CB2F21}.Debug|x64.ActiveCfg = Debug|x64 {9997E895-5161-4DDF-8F3F-099894CB2F21}.Debug|x64.Build.0 = Debug|x64 - {9997E895-5161-4DDF-8F3F-099894CB2F21}.Debug|x86.ActiveCfg = Debug|x64 - {9997E895-5161-4DDF-8F3F-099894CB2F21}.Debug|x86.Build.0 = Debug|x64 {9997E895-5161-4DDF-8F3F-099894CB2F21}.Release|x64.ActiveCfg = Release|x64 {9997E895-5161-4DDF-8F3F-099894CB2F21}.Release|x64.Build.0 = Release|x64 - {9997E895-5161-4DDF-8F3F-099894CB2F21}.Release|x86.ActiveCfg = Release|x64 - {9997E895-5161-4DDF-8F3F-099894CB2F21}.Release|x86.Build.0 = Release|x64 {8ACE478C-8F6F-4D42-9B43-7D75882D4BE1}.Debug|x64.ActiveCfg = Debug|x64 {8ACE478C-8F6F-4D42-9B43-7D75882D4BE1}.Debug|x64.Build.0 = Debug|x64 - {8ACE478C-8F6F-4D42-9B43-7D75882D4BE1}.Debug|x86.ActiveCfg = Debug|Win32 - {8ACE478C-8F6F-4D42-9B43-7D75882D4BE1}.Debug|x86.Build.0 = Debug|Win32 {8ACE478C-8F6F-4D42-9B43-7D75882D4BE1}.Release|x64.ActiveCfg = Release|x64 {8ACE478C-8F6F-4D42-9B43-7D75882D4BE1}.Release|x64.Build.0 = Release|x64 - {8ACE478C-8F6F-4D42-9B43-7D75882D4BE1}.Release|x86.ActiveCfg = Release|Win32 - {8ACE478C-8F6F-4D42-9B43-7D75882D4BE1}.Release|x86.Build.0 = Release|Win32 EndGlobalSection GlobalSection(SolutionProperties) = preSolution HideSolutionNode = FALSE From 9d3d1dbc662ba61c274ef5ebf1f52bf76167a9e8 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Wed, 12 Jul 2023 21:30:03 -0400 Subject: [PATCH 048/104] build CODA-OSS, then MSBUILD --- .github/workflows/frequent_check.yml | 29 ++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/.github/workflows/frequent_check.yml b/.github/workflows/frequent_check.yml index 1a05c1c66..fcfa162ac 100644 --- a/.github/workflows/frequent_check.yml +++ b/.github/workflows/frequent_check.yml @@ -38,6 +38,35 @@ jobs: - name: msbuild run: | msbuild nitro.sln /p:configuration=Release + + build-msbuild-windows: + strategy: + matrix: + os: [windows-latest] + platform: [x64] + configuration: [Release, Debug] + name: ${{ matrix.os }}-msbuild-${{ matrix.platform }} + runs-on: ${{ matrix.os }} + + steps: + - uses: actions/checkout@v2 + - name: configure CODA-OSS + run: | + mkdir externals\coda-oss\out + cd externals\coda-oss\out + cmake -DCMAKE_INSTALL_PREFIX=install\${{ matrix.platform }}-${{ matrix.configuration }} -DENABLE_PYTHON=OFF + - name: make CODA-OSS + run: | + cd externals\coda-oss\out + cmake --build . --config ${{ matrix.configuration }} -j + cmake --build . --config ${{ matrix.configuration }} --target install + - name: Add msbuild to PATH + uses: microsoft/setup-msbuild@v1.1 + with: + msbuild-architecture: x64 + - name: msbuild + run: | + msbuild nitro.sln /p:configuration=${{ matrix.configuration }} #- name: mstest # run: | # mstest /testcontainer:${RUNNER_WORKSPACE}\coda-oss\x64\Releast\Test.dll From 5f440a47e1b5f40f1bf6a1faaca935665bae2589 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Wed, 12 Jul 2023 21:32:06 -0400 Subject: [PATCH 049/104] test_image_loading__ fails on Github? --- UnitTest/nitf-c++.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/UnitTest/nitf-c++.cpp b/UnitTest/nitf-c++.cpp index 35e3130cd..24ec1806b 100644 --- a/UnitTest/nitf-c++.cpp +++ b/UnitTest/nitf-c++.cpp @@ -20,9 +20,9 @@ TEST_CLASS(test_image_blocker){ public: #include "nitf/unittests/test_image_blocker.cpp" }; -TEST_CLASS(test_image_loading__){ public: -#include "nitf/unittests/test_image_loading++.cpp" -}; +//TEST_CLASS(test_image_loading__){ public: +//#include "nitf/unittests/test_image_loading++.cpp" +//}; TEST_CLASS(test_image_segment_blank_nm_compression){ public: #include "nitf/unittests/test_image_segment_blank_nm_compression.cpp" From 9f8b4c245d335caea34b2a1897c81e0d5f95b281 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Wed, 12 Jul 2023 21:33:48 -0400 Subject: [PATCH 050/104] fix cmake typo --- .github/workflows/frequent_check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/frequent_check.yml b/.github/workflows/frequent_check.yml index fcfa162ac..7f8708d88 100644 --- a/.github/workflows/frequent_check.yml +++ b/.github/workflows/frequent_check.yml @@ -54,7 +54,7 @@ jobs: run: | mkdir externals\coda-oss\out cd externals\coda-oss\out - cmake -DCMAKE_INSTALL_PREFIX=install\${{ matrix.platform }}-${{ matrix.configuration }} -DENABLE_PYTHON=OFF + cmake -DCMAKE_INSTALL_PREFIX=install\${{ matrix.platform }}-${{ matrix.configuration }} -DENABLE_PYTHON=OFF .. - name: make CODA-OSS run: | cd externals\coda-oss\out From 2d40aabd14945605f96406dbe88311ffc1efb22e Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Wed, 12 Jul 2023 21:34:41 -0400 Subject: [PATCH 051/104] fix name --- .github/workflows/frequent_check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/frequent_check.yml b/.github/workflows/frequent_check.yml index 7f8708d88..c9319f438 100644 --- a/.github/workflows/frequent_check.yml +++ b/.github/workflows/frequent_check.yml @@ -45,7 +45,7 @@ jobs: os: [windows-latest] platform: [x64] configuration: [Release, Debug] - name: ${{ matrix.os }}-msbuild-${{ matrix.platform }} + name: ${{ matrix.os }}-msbuild-${{ matrix.configuration }} runs-on: ${{ matrix.os }} steps: From f53f64eab22082929bab01393b93bd30a63a2a59 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Wed, 12 Jul 2023 21:51:48 -0400 Subject: [PATCH 052/104] vstest --- .github/workflows/frequent_check.yml | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/workflows/frequent_check.yml b/.github/workflows/frequent_check.yml index c9319f438..353b6a910 100644 --- a/.github/workflows/frequent_check.yml +++ b/.github/workflows/frequent_check.yml @@ -44,7 +44,7 @@ jobs: matrix: os: [windows-latest] platform: [x64] - configuration: [Release, Debug] + configuration: [Release] name: ${{ matrix.os }}-msbuild-${{ matrix.configuration }} runs-on: ${{ matrix.os }} @@ -67,10 +67,12 @@ jobs: - name: msbuild run: | msbuild nitro.sln /p:configuration=${{ matrix.configuration }} - #- name: mstest - # run: | - # mstest /testcontainer:${RUNNER_WORKSPACE}\coda-oss\x64\Releast\Test.dll - # mstest /testcontainer:${RUNNER_WORKSPACE}\coda-oss\x64\Releast\Test++.dll + - name: vstest # https://github.com/marketplace/actions/vstest-action + uses: microsoft-approved-actions/vstest@master + with: + testAssembly: UnitTest.dll + searchFolder: .\${{ matrix.platform }}\${{ matrix.configuration }} + runInParallel: true build-linux-cmake: strategy: From be7a6e428aa23866cceb948d033158d697860c8e Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Wed, 12 Jul 2023 21:52:36 -0400 Subject: [PATCH 053/104] adjust name --- .github/workflows/frequent_check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/frequent_check.yml b/.github/workflows/frequent_check.yml index 353b6a910..2814e9100 100644 --- a/.github/workflows/frequent_check.yml +++ b/.github/workflows/frequent_check.yml @@ -45,7 +45,7 @@ jobs: os: [windows-latest] platform: [x64] configuration: [Release] - name: ${{ matrix.os }}-msbuild-${{ matrix.configuration }} + name: ${{ matrix.os }}-msbuild runs-on: ${{ matrix.os }} steps: From 971efbe76cbb8db864d088596fca63dbf19ef689 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Wed, 12 Jul 2023 21:54:28 -0400 Subject: [PATCH 054/104] find vstest action --- .github/workflows/frequent_check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/frequent_check.yml b/.github/workflows/frequent_check.yml index 2814e9100..9d6fab09d 100644 --- a/.github/workflows/frequent_check.yml +++ b/.github/workflows/frequent_check.yml @@ -68,7 +68,7 @@ jobs: run: | msbuild nitro.sln /p:configuration=${{ matrix.configuration }} - name: vstest # https://github.com/marketplace/actions/vstest-action - uses: microsoft-approved-actions/vstest@master + uses: microsoft/vstest-action@v1.0.0 with: testAssembly: UnitTest.dll searchFolder: .\${{ matrix.platform }}\${{ matrix.configuration }} From dfd1d75efdfaa4811e1e0294f0b376859e2d1bbc Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Thu, 13 Jul 2023 08:15:41 -0400 Subject: [PATCH 055/104] full path to DLL --- .github/workflows/frequent_check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/frequent_check.yml b/.github/workflows/frequent_check.yml index 9d6fab09d..d26f99f89 100644 --- a/.github/workflows/frequent_check.yml +++ b/.github/workflows/frequent_check.yml @@ -71,7 +71,7 @@ jobs: uses: microsoft/vstest-action@v1.0.0 with: testAssembly: UnitTest.dll - searchFolder: .\${{ matrix.platform }}\${{ matrix.configuration }} + searchFolder: ${RUNNER_WORKSPACE}\nitro\${{ matrix.platform }}\${{ matrix.configuration }} runInParallel: true build-linux-cmake: From 36c2e51cb75326d0d8632a2388dc6d4bf5e15433 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Thu, 13 Jul 2023 10:13:47 -0400 Subject: [PATCH 056/104] try w/o ${RUNNER_WORKSPACE} --- .github/workflows/frequent_check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/frequent_check.yml b/.github/workflows/frequent_check.yml index d26f99f89..f55a3c8ed 100644 --- a/.github/workflows/frequent_check.yml +++ b/.github/workflows/frequent_check.yml @@ -71,7 +71,7 @@ jobs: uses: microsoft/vstest-action@v1.0.0 with: testAssembly: UnitTest.dll - searchFolder: ${RUNNER_WORKSPACE}\nitro\${{ matrix.platform }}\${{ matrix.configuration }} + searchFolder: D:\a\nitro\nitro\${{ matrix.platform }}\${{ matrix.configuration }} runInParallel: true build-linux-cmake: From 1319c1759ffb50d705d071855c8ec46b3d6726b1 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Thu, 13 Jul 2023 10:19:22 -0400 Subject: [PATCH 057/104] tweak msbuild action version --- .github/workflows/frequent_check.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/frequent_check.yml b/.github/workflows/frequent_check.yml index f55a3c8ed..04c98df83 100644 --- a/.github/workflows/frequent_check.yml +++ b/.github/workflows/frequent_check.yml @@ -61,14 +61,14 @@ jobs: cmake --build . --config ${{ matrix.configuration }} -j cmake --build . --config ${{ matrix.configuration }} --target install - name: Add msbuild to PATH - uses: microsoft/setup-msbuild@v1.1 + uses: microsoft/setup-msbuild@v1 # https://github.com/marketplace/actions/setup-msbuild with: msbuild-architecture: x64 - name: msbuild run: | msbuild nitro.sln /p:configuration=${{ matrix.configuration }} - - name: vstest # https://github.com/marketplace/actions/vstest-action - uses: microsoft/vstest-action@v1.0.0 + - name: vstest + uses: microsoft/vstest-action@v1.0.0 # https://github.com/marketplace/actions/vstest-action with: testAssembly: UnitTest.dll searchFolder: D:\a\nitro\nitro\${{ matrix.platform }}\${{ matrix.configuration }} From f9e74cdf6da715190dd9691600b617bd95f8b922 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Thu, 13 Jul 2023 10:37:22 -0400 Subject: [PATCH 058/104] comment-out vstest for now --- .github/workflows/frequent_check.yml | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/frequent_check.yml b/.github/workflows/frequent_check.yml index 04c98df83..77285d679 100644 --- a/.github/workflows/frequent_check.yml +++ b/.github/workflows/frequent_check.yml @@ -67,12 +67,13 @@ jobs: - name: msbuild run: | msbuild nitro.sln /p:configuration=${{ matrix.configuration }} - - name: vstest - uses: microsoft/vstest-action@v1.0.0 # https://github.com/marketplace/actions/vstest-action - with: - testAssembly: UnitTest.dll - searchFolder: D:\a\nitro\nitro\${{ matrix.platform }}\${{ matrix.configuration }} - runInParallel: true + # Can't figure out how to make this work :-( + #- name: vstest + # uses: microsoft/vstest-action@v1.0.0 # https://github.com/marketplace/actions/vstest-action + # with: + # testAssembly: UnitTest.dll + # searchFolder: D:\a\nitro\nitro\${{ matrix.platform }}\${{ matrix.configuration }} + # runInParallel: true build-linux-cmake: strategy: From 2b201885bb129e7789e5d830d6199471318f97ca Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Thu, 13 Jul 2023 13:11:00 -0400 Subject: [PATCH 059/104] UnitTest changes from coda-oss --- .../.github/workflows/build_unittest.yml | 41 ++++- .../coda-oss/UnitTest/CppUnitTestAssert.cpp | 42 +---- externals/coda-oss/UnitTest/TestCase.h | 137 +---------------- externals/coda-oss/UnitTest/UnitTest.vcxproj | 10 +- externals/coda-oss/coda-oss.sln | 11 ++ .../coda-oss/modules/c++/coda-oss.vcxproj | 17 ++- .../modules/c++/coda-oss.vcxproj.filters | 6 + .../c++/hdf5.lite/include/hdf5/lite/H5_.h | 1 + .../coda-oss/modules/c++/include/UnitTest.h | 143 ++++++++++++++++++ externals/coda-oss/modules/c++/pch.h | 19 ++- .../coda-oss/modules/c++/sys/include/sys/OS.h | 45 ++++-- .../modules/c++/sys/source/AbstractOS.cpp | 9 +- .../c++/sys/source/CppUnitTestAssert_.cpp_ | 43 ++++++ .../modules/c++/tiff/source/IFDEntry.cpp | 3 +- .../modules/c++/types/include/types/Complex.h | 6 +- .../c++/xml.lite/include/import/xml/lite.h | 42 +---- .../c++/xml.lite/source/Serializable.cpp | 4 +- 17 files changed, 306 insertions(+), 273 deletions(-) create mode 100644 externals/coda-oss/modules/c++/include/UnitTest.h create mode 100644 externals/coda-oss/modules/c++/sys/source/CppUnitTestAssert_.cpp_ diff --git a/externals/coda-oss/.github/workflows/build_unittest.yml b/externals/coda-oss/.github/workflows/build_unittest.yml index 04b2f3fae..c4d7cb0ce 100644 --- a/externals/coda-oss/.github/workflows/build_unittest.yml +++ b/externals/coda-oss/.github/workflows/build_unittest.yml @@ -36,8 +36,7 @@ jobs: cd .. cd target-Debug cmake --build . --config Debug -j - - name: test - # should run w/o install + - name: test # should run w/o install run: | cd target-Release ctest -C Release --output-on-failure @@ -52,17 +51,43 @@ jobs: cd target-Debug cmake --build . --config Debug --target install cd .. + + build-msbuild-windows: + strategy: + matrix: + os: [windows-latest] + platform: [x64] + configuration: [Release] + name: ${{ matrix.os }}-msbuild + runs-on: ${{ matrix.os }} + + steps: + - uses: actions/checkout@v3 + - name: configure + run: | + ls env: + mkdir out + cd out + cmake .. -DCMAKE_INSTALL_PREFIX=install\${{ matrix.platform }}-${{ matrix.configuration }} -DENABLE_PYTHON=OFF + - name: build + run: | + cd out + cmake --build . --config ${{ matrix.configuration }} -j + cmake --build . --config ${{ matrix.configuration }} --target install - name: Add msbuild to PATH - uses: microsoft/setup-msbuild@v1.1 + uses: microsoft/setup-msbuild@v1 # https://github.com/marketplace/actions/setup-msbuild with: msbuild-architecture: x64 - name: msbuild run: | - msbuild coda-oss.sln /p:configuration=Release - msbuild coda-oss.sln /p:configuration=Debug - #- name: mstest - # run: | - # mstest /testcontainer:${RUNNER_WORKSPACE}\coda-oss\x64\Debug\UnitTest.dll + msbuild coda-oss.sln /p:configuration=${{ matrix.configuration }} + # Can't figure out how to make this work :-( + #- name: vstest + # uses: microsoft/vstest-action@v1.0.0 # https://github.com/marketplace/actions/vstest-action + # with: + # testAssembly: UnitTest.dll + # searchFolder: D:\a\nitro\nitro\${{ matrix.platform }}\${{ matrix.configuration }} + # runInParallel: true build-linux-cmake: strategy: diff --git a/externals/coda-oss/UnitTest/CppUnitTestAssert.cpp b/externals/coda-oss/UnitTest/CppUnitTestAssert.cpp index fdcf5f92b..5bea8da59 100644 --- a/externals/coda-oss/UnitTest/CppUnitTestAssert.cpp +++ b/externals/coda-oss/UnitTest/CppUnitTestAssert.cpp @@ -1,43 +1,5 @@ #include "pch.h" #include "TestCase.h" -#include "str/EncodedStringView.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -// EQUALS_MESSAGE() wants ToString() specializations (or overloads) for our types, which is a nusiance. -// This hooks up our existing str::toString() into the VC++ unit-test infrastructure - -// C++ hack to call private methods -// https://stackoverflow.com/a/71578383/8877 - -using FailOnCondition_t = void(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare method's type -using GetAssertMessage_t = std::wstring(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare method's type -template -struct caller final // helper structure to inject call() code -{ - friend void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) - { - fFailOnCondition(condition, message, pLineInfo); - } - - friend std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message) - { - return fGetAssertMessage(equality, expected, actual, message); - } -}; -template struct caller<&Assert::FailOnCondition, &Assert::GetAssertMessage>; // even instantiation of the helper - -void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare caller -void test::Assert::FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) -{ - ::FailOnCondition(condition, message, pLineInfo); // and call! -} - -std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare caller -std::wstring test::Assert::GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message) -{ - const str::EncodedStringView vExpected(expected); - const str::EncodedStringView vActual(actual); - return ::GetAssertMessage(equality, vExpected.wstring(), vActual.wstring(), message); // and call! -} +// Can't get this to build in the **coda-oss** project. +#include "sys/source/CppUnitTestAssert_.cpp_" diff --git a/externals/coda-oss/UnitTest/TestCase.h b/externals/coda-oss/UnitTest/TestCase.h index f4438821f..e769f584f 100644 --- a/externals/coda-oss/UnitTest/TestCase.h +++ b/externals/coda-oss/UnitTest/TestCase.h @@ -1,138 +1,3 @@ #pragma once -#include -#include - -#include "CppUnitTest.h" -#include -#include - -#undef TEST_CHECK -#undef TEST_ASSERT -#undef TEST_ASSERT_NULL -#undef TEST_ASSERT_NOT_NULL -#undef TEST_ASSERT_TRUE -#undef TEST_ASSERT_FALSE -#undef TEST_MAIN -#undef TEST_CASE -#define TEST_CHECK(X) -#define TEST_MAIN(X) -#define TEST_ASSERT_NULL(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNull(X) -#define TEST_ASSERT_NOT_NULL(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNotNull(X) -#define TEST_ASSERT_TRUE(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(X) -#define TEST_ASSERT_FALSE(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsFalse(X) -#define TEST_ASSERT(X) TEST_ASSERT_TRUE(X) -#define CODA_OSS_testMethod_(X) testMethod ## _ ## X -#define TEST_CASE(X) TEST_METHOD(X) { CODA_OSS_testMethod_(X)(#X); } void CODA_OSS_testMethod_(X)(std::string testName) - -namespace test -{ - struct Assert final - { - static void FailOnCondition(bool condition, const unsigned short* message, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo); - static std::wstring GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message); - }; -#define CODA_OSS_equals_message_(expected, actual, message) reinterpret_cast(test::Assert::GetAssertMessage(true, test::toString(expected), test::toString(actual), message).c_str()) -#define CODA_OSS_not_equals_message_(notExpected, actual, message) reinterpret_cast(test::Assert::GetAssertMessage(false, test::toString(notExpected), test::toString(actual), message).c_str()) -#define CODA_OSS_message_(message) reinterpret_cast(test::Assert::GetAssertMessage(false, "", "", message).c_str()) - -// see Assert::AreEqual<> -template -inline void diePrintf_eq(const TExpected& expected, const TActual& actual, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(expected == actual, CODA_OSS_equals_message_(expected, actual, message), pLineInfo); -} - -// see Assert::AreNotEqual<> -template -inline void diePrintf_ne(const TExpected& notExpected, const TActual& actual, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(notExpected != actual, CODA_OSS_not_equals_message_(notExpected, actual, message), pLineInfo); -} - -template -inline void diePrintf_ge(const TX1& X1, const TX2& X2, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(X1 >= X2, CODA_OSS_message_(message), pLineInfo); -} -template -inline void diePrintf_gt(const TX1& X1, const TX2& X2, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(X1 > X2, CODA_OSS_message_(message), pLineInfo); -} -template -inline void diePrintf_le(const TX1& X1, const TX2& X2, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(X1 <= X2, CODA_OSS_message_(message), pLineInfo); -} -template -inline void diePrintf_lt(const TX1& X1, const TX2& X2, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(X1 < X2, CODA_OSS_message_(message), pLineInfo); -} - -} -#undef CODA_OSS_test_diePrintf_eq_ -#undef CODA_OSS_test_diePrintf_not_eq_ -#define CODA_OSS_test_diePrintf_eq_(X1, X2) testName, ::test::diePrintf_eq(X1, X2) -#define CODA_OSS_test_diePrintf_not_eq_(X1, X2) testName, ::test::diePrintf_ne(X1, X2) - -#undef CODA_OSS_test_diePrintf_greater_eq_ -#undef CODA_OSS_test_diePrintf_greater_ -#undef CODA_OSS_test_diePrintf_lesser_eq_ -#undef CODA_OSS_test_diePrintf_lesser_ -#define CODA_OSS_test_diePrintf_greater_eq_(X1, X2) testName, ::test::diePrintf_ge(X1, X2) -#define CODA_OSS_test_diePrintf_greater_(X1, X2) testName, ::test::diePrintf_gt(X1, X2) -#define CODA_OSS_test_diePrintf_lesser_eq_(X1, X2) testName, ::test::diePrintf_le(X1, X2) -#define CODA_OSS_test_diePrintf_lesser_(X1, X2) testName, ::test::diePrintf_lt(X1, X2) - -template -inline void test_assert_greater_(const TX1& X1, const TX2& X2) -{ - Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(X1 > X2); -} -#undef TEST_ASSERT_GREATER -#define TEST_ASSERT_GREATER(X1, X2) testName, test_assert_greater_(X1, X2) - -#undef TEST_ASSERT_ALMOST_EQ_EPS -#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) { (void)testName; Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(X1, X2, EPS); Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(X2, X1, EPS); } -namespace test -{ -inline void assert_almost_eq(const std::string& testName, float X1, float X2) -{ - constexpr auto EPS = static_cast(0.0001); - TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS); -} -inline void assert_almost_eq(const std::string& testName, double X1, double X2) -{ - constexpr auto EPS = static_cast(0.0001); - TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS); -} -inline void assert_almost_eq(const std::string& testName, long double X1, long double X2) -{ - assert_almost_eq(testName, static_cast(X1), static_cast(X2)); -} -} - -#undef TEST_ASSERT_ALMOST_EQ -#define TEST_ASSERT_ALMOST_EQ(X1, X2) test::assert_almost_eq(testName, X1, X2) - -#undef TEST_ASSERT_EQ_MSG -#define TEST_ASSERT_EQ_MSG(msg, X1, X2) testName, Microsoft::VisualStudio::CppUnitTestFramework::Logger::WriteMessage(msg.c_str()); TEST_ASSERT_EQ(X1, X2) - -#undef TEST_FAIL_MSG -#define TEST_FAIL_MSG(msg) { (void)testName; const str::EncodedStringView vw(msg); Microsoft::VisualStudio::CppUnitTestFramework::Assert::Fail(vw.wstring().c_str()); } - -#undef TEST_EXCEPTION -#undef TEST_THROWS -#undef TEST_SPECIFIC_EXCEPTION -#define TEST_EXCEPTION(X) (void)testName; try{ (X); TEST_FAIL(#X " should have thrown."); } CODA_OSS_TEST_EXCEPTION_catch_ -#define TEST_THROWS(X) (void)testName; try{ (X); TEST_FAIL(#X " should have thrown."); } catch (...){ TEST_ASSERT_TRUE(true); } -#define TEST_SPECIFIC_EXCEPTION(X, Y) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::ExpectException([&](){(X);}) - +#include diff --git a/externals/coda-oss/UnitTest/UnitTest.vcxproj b/externals/coda-oss/UnitTest/UnitTest.vcxproj index 65b3ca322..835f574dc 100644 --- a/externals/coda-oss/UnitTest/UnitTest.vcxproj +++ b/externals/coda-oss/UnitTest/UnitTest.vcxproj @@ -57,7 +57,7 @@ Use Level4 true - $(VCInstallDir)UnitTest\include;$(ProjectDir);$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\avx\include\;$(SolutionDir)modules\c++\cli\include\;$(SolutionDir)modules\c++\config\include\;$(SolutionDir)modules\c++\coda_oss\include\;$(SolutionDir)modules\c++\gsl\include\;$(SolutionDir)modules\c++\hdf5.lite\include\;$(SolutionDir)modules\c++\io\include\;$(SolutionDir)modules\c++\std\include\;$(SolutionDir)modules\c++\str\include\;$(SolutionDir)modules\c++\sys\include\;$(SolutionDir)modules\c++\except\include\;$(SolutionDir)modules\c++\logging\include\;$(SolutionDir)modules\c++\math\include\;$(SolutionDir)modules\c++\math.linear\include\;$(SolutionDir)modules\c++\math.poly\include\;$(SolutionDir)modules\c++\mem\include\;$(SolutionDir)modules\c++\mt\include\;$(SolutionDir)modules\c++\polygon\include\;$(SolutionDir)modules\c++\re\include\;$(SolutionDir)modules\c++\types\include\;$(SolutionDir)modules\c++\units\include\;$(SolutionDir)modules\c++\xml.lite\include\;$(SolutionDir)modules\c++\zip\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;%(AdditionalIncludeDirectories) + $(VCInstallDir)UnitTest\include;$(ProjectDir);$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\avx\include;$(SolutionDir)modules\c++\cli\include;$(SolutionDir)modules\c++\config\include;$(SolutionDir)modules\c++\coda_oss\include;$(SolutionDir)modules\c++\gsl\include;$(SolutionDir)modules\c++\hdf5.lite\include;$(SolutionDir)modules\c++\io\include;$(SolutionDir)modules\c++\std\include;$(SolutionDir)modules\c++\str\include;$(SolutionDir)modules\c++\sys\include;$(SolutionDir)modules\c++\except\include;$(SolutionDir)modules\c++\logging\include;$(SolutionDir)modules\c++\math\include;$(SolutionDir)modules\c++\math.linear\include;$(SolutionDir)modules\c++\math.poly\include;$(SolutionDir)modules\c++\mem\include;$(SolutionDir)modules\c++\mt\include;$(SolutionDir)modules\c++\polygon\include;$(SolutionDir)modules\c++\re\include;$(SolutionDir)modules\c++\types\include;$(SolutionDir)modules\c++\units\include;$(SolutionDir)modules\c++\xml.lite\include;$(SolutionDir)modules\c++\zip\include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;%(AdditionalIncludeDirectories) _DEBUG;%(PreprocessorDefinitions);MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 true pch.h @@ -65,7 +65,6 @@ true Guard ProgramDatabase - true true true true @@ -75,7 +74,7 @@ Windows - $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;$(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) + $(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) @@ -85,13 +84,12 @@ true true true - $(VCInstallDir)UnitTest\include;$(ProjectDir);$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\avx\include\;$(SolutionDir)modules\c++\cli\include\;$(SolutionDir)modules\c++\config\include\;$(SolutionDir)modules\c++\coda_oss\include\;$(SolutionDir)modules\c++\gsl\include\;$(SolutionDir)modules\c++\hdf5.lite\include\;$(SolutionDir)modules\c++\io\include\;$(SolutionDir)modules\c++\std\include\;$(SolutionDir)modules\c++\str\include\;$(SolutionDir)modules\c++\sys\include\;$(SolutionDir)modules\c++\except\include\;$(SolutionDir)modules\c++\logging\include\;$(SolutionDir)modules\c++\math\include\;$(SolutionDir)modules\c++\math.linear\include\;$(SolutionDir)modules\c++\math.poly\include\;$(SolutionDir)modules\c++\mem\include\;$(SolutionDir)modules\c++\mt\include\;$(SolutionDir)modules\c++\polygon\include\;$(SolutionDir)modules\c++\re\include\;$(SolutionDir)modules\c++\types\include\;$(SolutionDir)modules\c++\units\include\;$(SolutionDir)modules\c++\xml.lite\include\;$(SolutionDir)modules\c++\zip\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;%(AdditionalIncludeDirectories) + $(VCInstallDir)UnitTest\include;$(ProjectDir);$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\avx\include;$(SolutionDir)modules\c++\cli\include;$(SolutionDir)modules\c++\config\include;$(SolutionDir)modules\c++\coda_oss\include;$(SolutionDir)modules\c++\gsl\include;$(SolutionDir)modules\c++\hdf5.lite\include;$(SolutionDir)modules\c++\io\include;$(SolutionDir)modules\c++\std\include;$(SolutionDir)modules\c++\str\include;$(SolutionDir)modules\c++\sys\include;$(SolutionDir)modules\c++\except\include;$(SolutionDir)modules\c++\logging\include;$(SolutionDir)modules\c++\math\include;$(SolutionDir)modules\c++\math.linear\include;$(SolutionDir)modules\c++\math.poly\include;$(SolutionDir)modules\c++\mem\include;$(SolutionDir)modules\c++\mt\include;$(SolutionDir)modules\c++\polygon\include;$(SolutionDir)modules\c++\re\include;$(SolutionDir)modules\c++\types\include;$(SolutionDir)modules\c++\units\include;$(SolutionDir)modules\c++\xml.lite\include;$(SolutionDir)modules\c++\zip\include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;%(AdditionalIncludeDirectories) NDEBUG;%(PreprocessorDefinitions);MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 true pch.h true Guard - true true true true @@ -103,7 +101,7 @@ Windows true true - $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;$(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) + $(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) diff --git a/externals/coda-oss/coda-oss.sln b/externals/coda-oss/coda-oss.sln index 5583590dd..48465a170 100644 --- a/externals/coda-oss/coda-oss.sln +++ b/externals/coda-oss/coda-oss.sln @@ -15,6 +15,13 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution EndProject Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "UnitTest", "UnitTest\UnitTest.vcxproj", "{34A31B3F-47C5-441D-AB22-3C85B3C5314E}" EndProject +Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".github", ".github", "{E0FA1194-0806-4A6B-A331-33CB43C0C946}" +EndProject +Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "workflows", "workflows", "{4EC1396F-3781-409E-B209-A920C464853C}" + ProjectSection(SolutionItems) = preProject + .github\workflows\build_unittest.yml = .github\workflows\build_unittest.yml + EndProjectSection +EndProject Global GlobalSection(SolutionConfigurationPlatforms) = preSolution Debug|x64 = Debug|x64 @@ -33,6 +40,10 @@ Global GlobalSection(SolutionProperties) = preSolution HideSolutionNode = FALSE EndGlobalSection + GlobalSection(NestedProjects) = preSolution + {E0FA1194-0806-4A6B-A331-33CB43C0C946} = {DEB848DD-4285-4BFA-9B2F-60FA46200205} + {4EC1396F-3781-409E-B209-A920C464853C} = {E0FA1194-0806-4A6B-A331-33CB43C0C946} + EndGlobalSection GlobalSection(ExtensibilityGlobals) = postSolution SolutionGuid = {3CAB4AC9-7865-44AD-8623-57905729A559} EndGlobalSection diff --git a/externals/coda-oss/modules/c++/coda-oss.vcxproj b/externals/coda-oss/modules/c++/coda-oss.vcxproj index 9c8a98160..e2cf91bf5 100644 --- a/externals/coda-oss/modules/c++/coda-oss.vcxproj +++ b/externals/coda-oss/modules/c++/coda-oss.vcxproj @@ -60,6 +60,7 @@ + @@ -527,6 +528,10 @@ + + true + true + 16.0 @@ -575,7 +580,7 @@ true _DEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL;MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 pch.h - cli\include\;coda_oss\include;config\include\;dbi\include\;except\include\;gsl\include\;hdf5.lite\include\;io\include\;logging\include\;math\include\;math.linear\include\;math.poly\include\;mem\include\;mt\include\;net\include\;net.ssl\include\;plugin\include\;polygon\include\;re\include\;sio.lite\include\;std\include\;str\include\;sys\include\;tiff\include;types\include\;unique\include\;units\include\;xml.lite\include\;zip\include\;$(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ + cli\include;coda_oss\include;config\include;dbi\include;except\include;gsl\include;hdf5.lite\include;io\include;logging\include;math\include;math.linear\include;math.poly\include;mem\include;mt\include;net\include;net.ssl\include;plugin\include;polygon\include;re\include;sio.lite\include;std\include;str\include;sys\include;tiff\include;types\include;unique\include;units\include;xml.lite\include;zip\include;$(ProjectDir)include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include Use pch.h true @@ -593,8 +598,8 @@ true - $(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\ - hdf5-c++.lib;z.lib;minizip.lib;xerces-c.lib;rpcrt4.lib;%(AdditionalDependencies) + $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\ + rpcrt4.lib;%(AdditionalDependencies) @@ -605,7 +610,7 @@ true NDEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL;MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 pch.h - cli\include\;coda_oss\include;config\include\;dbi\include\;except\include\;gsl\include\;hdf5.lite\include\;io\include\;logging\include\;math\include\;math.linear\include\;math.poly\include\;mem\include\;mt\include\;net\include\;net.ssl\include\;plugin\include\;polygon\include\;re\include\;sio.lite\include\;std\include\;str\include\;sys\include\;tiff\include;types\include\;unique\include\;units\include\;xml.lite\include\;zip\include\;$(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ + cli\include;coda_oss\include;config\include;dbi\include;except\include;gsl\include;hdf5.lite\include;io\include;logging\include;math\include;math.linear\include;math.poly\include;mem\include;mt\include;net\include;net.ssl\include;plugin\include;polygon\include;re\include;sio.lite\include;std\include;str\include;sys\include;tiff\include;types\include;unique\include;units\include;xml.lite\include;zip\include;$(ProjectDir)include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include Use pch.h true @@ -622,8 +627,8 @@ true true true - $(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\ - hdf5-c++.lib;z.lib;minizip.lib;xerces-c.lib;rpcrt4.lib;%(AdditionalDependencies) + $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\ + rpcrt4.lib;%(AdditionalDependencies) diff --git a/externals/coda-oss/modules/c++/coda-oss.vcxproj.filters b/externals/coda-oss/modules/c++/coda-oss.vcxproj.filters index e0bf43bef..adb5a57f7 100644 --- a/externals/coda-oss/modules/c++/coda-oss.vcxproj.filters +++ b/externals/coda-oss/modules/c++/coda-oss.vcxproj.filters @@ -966,6 +966,9 @@ mt + + include + @@ -1589,5 +1592,8 @@ std + + sys + \ No newline at end of file diff --git a/externals/coda-oss/modules/c++/hdf5.lite/include/hdf5/lite/H5_.h b/externals/coda-oss/modules/c++/hdf5.lite/include/hdf5/lite/H5_.h index a624c2eff..cd470aef2 100644 --- a/externals/coda-oss/modules/c++/hdf5.lite/include/hdf5/lite/H5_.h +++ b/externals/coda-oss/modules/c++/hdf5.lite/include/hdf5/lite/H5_.h @@ -28,6 +28,7 @@ CODA_OSS_disable_warning_system_header_push #if _MSC_VER +#pragma warning(disable: 6313) // Incorrect operator. Use an equality test to check for zero-valued flags. #pragma warning(disable: 26493) // Don't use C-style casts (type.4). #pragma warning(disable: 26494) // Variable '...' is uninitialized. Always initialize an object (type.5). #pragma warning(disable: 26451) // Arithmetic overflow: Using operator '...' on a 4 byte value and then casting the result to a 8 byte value. Cast the value to the wider type before calling operator '...' to avoid overflow (io.2). diff --git a/externals/coda-oss/modules/c++/include/UnitTest.h b/externals/coda-oss/modules/c++/include/UnitTest.h new file mode 100644 index 000000000..51e877609 --- /dev/null +++ b/externals/coda-oss/modules/c++/include/UnitTest.h @@ -0,0 +1,143 @@ +#pragma once + +#include +#include + +#include "TestCase.h" +#include "str/EncodedStringView.h" + +#if !_MSC_VER +#error "This file is for use with a Visual Studio 'UnitTest' project." +#endif + +// Use our various TEST macros with a Visual Studio "UnitTest" project. +#include + +#undef TEST_CHECK +#undef TEST_ASSERT +#undef TEST_ASSERT_NULL +#undef TEST_ASSERT_NOT_NULL +#undef TEST_ASSERT_TRUE +#undef TEST_ASSERT_FALSE +#undef TEST_MAIN +#undef TEST_CASE +#define TEST_CHECK(X) +#define TEST_MAIN(X) +#define TEST_ASSERT_NULL(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNull(X) +#define TEST_ASSERT_NOT_NULL(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNotNull(X) +#define TEST_ASSERT_TRUE(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(X) +#define TEST_ASSERT_FALSE(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsFalse(X) +#define TEST_ASSERT(X) TEST_ASSERT_TRUE(X) +#define CODA_OSS_testMethod_(X) testMethod ## _ ## X +#define TEST_CASE(X) TEST_METHOD(X) { CODA_OSS_testMethod_(X)(#X); } void CODA_OSS_testMethod_(X)(std::string testName) + +namespace test +{ + struct Assert final + { + static void FailOnCondition(bool condition, const unsigned short* message, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo); + static std::wstring GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message); + }; +#define CODA_OSS_equals_message_(expected, actual, message) reinterpret_cast(test::Assert::GetAssertMessage(true, test::toString(expected), test::toString(actual), message).c_str()) +#define CODA_OSS_not_equals_message_(notExpected, actual, message) reinterpret_cast(test::Assert::GetAssertMessage(false, test::toString(notExpected), test::toString(actual), message).c_str()) +#define CODA_OSS_message_(message) reinterpret_cast(test::Assert::GetAssertMessage(false, "", "", message).c_str()) + +// see Assert::AreEqual<> +template +inline void diePrintf_eq(const TExpected& expected, const TActual& actual, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(expected == actual, CODA_OSS_equals_message_(expected, actual, message), pLineInfo); +} + +// see Assert::AreNotEqual<> +template +inline void diePrintf_ne(const TExpected& notExpected, const TActual& actual, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(notExpected != actual, CODA_OSS_not_equals_message_(notExpected, actual, message), pLineInfo); +} + +template +inline void diePrintf_ge(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 >= X2, CODA_OSS_message_(message), pLineInfo); +} +template +inline void diePrintf_gt(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 > X2, CODA_OSS_message_(message), pLineInfo); +} +template +inline void diePrintf_le(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 <= X2, CODA_OSS_message_(message), pLineInfo); +} +template +inline void diePrintf_lt(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 < X2, CODA_OSS_message_(message), pLineInfo); +} + +} +#undef CODA_OSS_test_diePrintf_eq_ +#undef CODA_OSS_test_diePrintf_not_eq_ +#define CODA_OSS_test_diePrintf_eq_(X1, X2) testName, ::test::diePrintf_eq(X1, X2) +#define CODA_OSS_test_diePrintf_not_eq_(X1, X2) testName, ::test::diePrintf_ne(X1, X2) + +#undef CODA_OSS_test_diePrintf_greater_eq_ +#undef CODA_OSS_test_diePrintf_greater_ +#undef CODA_OSS_test_diePrintf_lesser_eq_ +#undef CODA_OSS_test_diePrintf_lesser_ +#define CODA_OSS_test_diePrintf_greater_eq_(X1, X2) testName, ::test::diePrintf_ge(X1, X2) +#define CODA_OSS_test_diePrintf_greater_(X1, X2) testName, ::test::diePrintf_gt(X1, X2) +#define CODA_OSS_test_diePrintf_lesser_eq_(X1, X2) testName, ::test::diePrintf_le(X1, X2) +#define CODA_OSS_test_diePrintf_lesser_(X1, X2) testName, ::test::diePrintf_lt(X1, X2) + +template +inline void test_assert_greater_(const TX1& X1, const TX2& X2) +{ + Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(X1 > X2); +} +#undef TEST_ASSERT_GREATER +#define TEST_ASSERT_GREATER(X1, X2) testName, test_assert_greater_(X1, X2) + +#undef TEST_ASSERT_ALMOST_EQ_EPS +#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) { (void)testName; Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(X1, X2, EPS); Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(X2, X1, EPS); } +namespace test +{ +inline void assert_almost_eq(const std::string& testName, float X1, float X2) +{ + constexpr auto EPS = static_cast(0.0001); + TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS); +} +inline void assert_almost_eq(const std::string& testName, double X1, double X2) +{ + constexpr auto EPS = static_cast(0.0001); + TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS); +} +inline void assert_almost_eq(const std::string& testName, long double X1, long double X2) +{ + assert_almost_eq(testName, static_cast(X1), static_cast(X2)); +} +} + +#undef TEST_ASSERT_ALMOST_EQ +#define TEST_ASSERT_ALMOST_EQ(X1, X2) test::assert_almost_eq(testName, X1, X2) + +#undef TEST_ASSERT_EQ_MSG +#define TEST_ASSERT_EQ_MSG(msg, X1, X2) testName, Microsoft::VisualStudio::CppUnitTestFramework::Logger::WriteMessage(msg.c_str()); TEST_ASSERT_EQ(X1, X2) + +#undef TEST_FAIL_MSG +#define TEST_FAIL_MSG(msg) { (void)testName; const str::EncodedStringView vw(msg); Microsoft::VisualStudio::CppUnitTestFramework::Assert::Fail(vw.wstring().c_str()); } + +#undef TEST_EXCEPTION +#undef TEST_THROWS +#undef TEST_SPECIFIC_EXCEPTION +#define TEST_EXCEPTION(X) (void)testName; try{ (X); TEST_FAIL(#X " should have thrown."); } CODA_OSS_TEST_EXCEPTION_catch_ +#define TEST_THROWS(X) (void)testName; try{ (X); TEST_FAIL(#X " should have thrown."); } catch (...){ TEST_ASSERT_TRUE(true); } +#define TEST_SPECIFIC_EXCEPTION(X, Y) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::ExpectException([&](){(X);}) diff --git a/externals/coda-oss/modules/c++/pch.h b/externals/coda-oss/modules/c++/pch.h index f39484bc2..18067f14d 100644 --- a/externals/coda-oss/modules/c++/pch.h +++ b/externals/coda-oss/modules/c++/pch.h @@ -33,32 +33,29 @@ CODA_OSS_disable_warning_pop #include #include +#pragma comment(lib, "z.lib") +#pragma comment(lib, "minizip.lib") + #include #pragma warning(disable: 4251) // '...': class '...' needs to have dll-interface to be used by clients of class '...' #pragma warning(disable: 4365) // '...': conversion from '...' to '...', signed/unsigned mismatch #pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to '...' function under -EHc. Undefined behavior may occur if this function throws an exception. -#pragma warning(disable: 6326) // Potential comparison of a constant with another constant. #pragma warning(disable: 6054) // String '...' might not be zero-terminated. #pragma warning(disable: 6387) // '...' could be '...'. #pragma warning(disable: 6305) // Potential mismatch between sizeof and countof quantities. Use sizeof() to scale byte sizes. -#pragma warning(disable: 6288) // Incorrect operator. Did you intend to use || instead? -#pragma warning(disable: 6011) // Dereferencing NULL pointer '...'. -#pragma warning(disable: 6313) // Incorrect operator. Use an equality test to check for zero-valued flags. #pragma warning(disable: 6389) // Move '...' to anonymous namespace or put a forward declaration in a common header included in this file. +#pragma warning(disable: 26822) // Dereferencing a null pointer '...' (lifetime.1). #pragma warning(disable: 26432) // If you define or delete any default operation in the type '...', define or delete them all (c.21). #pragma warning(disable: 26429) // Symbol '...' is never tested for nullness, it can be marked as not_null (f.23). #pragma warning(disable: 26455) // Default constructor should not throw. Declare it '...' (f.6). #pragma warning(disable: 26440) // Function '...' can be declared '...' (f.6). #pragma warning(disable: 26447) // The function is declared '...' but calls function '...' which may throw exceptions (f.6). -#pragma warning(disable: 26446) // Prefer to use gsl::at() instead of unchecked subscript operator (bounds.4). -#pragma warning(disable: 26481) // Don't use pointer arithmetic. Use span instead (bounds.1). #pragma warning(disable: 26496) // The variable '...' does not change after construction, mark it as const (con.4). #pragma warning(disable: 26462) // The value pointed to by '...' is assigned only once, mark it as a pointer to const (con.4). #pragma warning(disable: 26409) // Avoid calling new and delete explicitly, use std::make_unique instead (r.11). #pragma warning(disable: 26401) // Do not delete a raw pointer that is not an owner (i.11). -#pragma warning(disable: 26482) // Only index into arrays using constant expressions (bounds.2). #pragma warning(disable: 26472) // Don't use a static_cast for arithmetic conversions. Use brace initialization, gsl::narrow_cast or gsl::narrow (type.1). #pragma warning(disable: 26485) // Expression '...': No array to pointer decay (bounds.3). #pragma warning(disable: 26493) // Don't use C-style casts (type.4). @@ -96,8 +93,10 @@ CODA_OSS_disable_warning_pop #pragma warning(disable: 26823) // Dereferencing a possibly null pointer '...' (lifetime.1). #pragma warning(disable: 26487) // Don't return a pointer '...' that may be invalid (lifetime.4). #pragma warning(disable: 26812) // The enum type '...' is unscoped. Prefer '...' over '...' (Enum.3). -#pragma warning(disable: 26822) // Dereferencing a null pointer '...' (lifetime.1). +#pragma warning(disable: 26446) // Prefer to use gsl::at() instead of unchecked subscript operator (bounds.4). #pragma warning(disable: 26458) // Prefer to use gsl::at() instead of unchecked subscript operator (bounds.4). +#pragma warning(disable: 26482) // Only index into arrays using constant expressions (bounds.2). +#pragma warning(disable: 26481) // Don't use pointer arithmetic. Use span instead (bounds.1). // Yes, these are our files ... but they don't change very often, and if they do // change we want to rebuild everything anyway. @@ -107,7 +106,11 @@ CODA_OSS_disable_warning_pop #include "sys/Conf.h" #include "sys/filesystem.h" #include "mem/SharedPtr.h" + #include "xml/lite/xerces_.h" +#pragma comment(lib, "xerces-c") + #include "hdf5/lite/H5_.h" +#pragma comment(lib, "hdf5-c++.lib") #endif //CODA_OSS_pch_h_INCLUDED_ diff --git a/externals/coda-oss/modules/c++/sys/include/sys/OS.h b/externals/coda-oss/modules/c++/sys/include/sys/OS.h index 6ea40c83f..7a16c53e5 100644 --- a/externals/coda-oss/modules/c++/sys/include/sys/OS.h +++ b/externals/coda-oss/modules/c++/sys/include/sys/OS.h @@ -21,10 +21,12 @@ */ -#ifndef __SYS_OS_H__ -#define __SYS_OS_H__ +#pragma once +#ifndef CODA_OSS_sys_OS_h_INCLUDED_ +#define CODA_OSS_sys_OS_h_INCLUDED_ #include "sys/AbstractOS.h" +#include "sys/Conf.h" #ifdef _WIN32 # include "sys/OSWin32.h" @@ -47,19 +49,34 @@ typedef DirectoryUnix Directory; // and also squelches compiler-warnings about unused local functions. namespace sys { - enum class PlatformType - { - Windows, - Linux, - //MacOS - }; +enum class PlatformType +{ + Windows, + Linux, + // MacOS +}; - #ifdef _WIN32 - constexpr auto Platform = PlatformType::Windows; - #else - constexpr auto Platform = PlatformType::Linux; - #endif +#if defined(_WIN32) +constexpr auto Platform = PlatformType::Windows; +#elif defined(CODA_OSS_POSIX2008_SOURCE) +constexpr auto Platform = PlatformType::Linux; +#else +#error "Unknown platform." +#endif + +template +inline std::string platformName(); +template <> +inline std::string platformName() +{ + return "Windows"; +} +template <> +inline std::string platformName() +{ + return "linux-gnu"; } -#endif +} +#endif // CODA_OSS_sys_OS_h_INCLUDED_ \ No newline at end of file diff --git a/externals/coda-oss/modules/c++/sys/source/AbstractOS.cpp b/externals/coda-oss/modules/c++/sys/source/AbstractOS.cpp index e32b44d87..d1cd33306 100644 --- a/externals/coda-oss/modules/c++/sys/source/AbstractOS.cpp +++ b/externals/coda-oss/modules/c++/sys/source/AbstractOS.cpp @@ -480,14 +480,7 @@ std::string AbstractOS::getSpecialEnv(const std::string& envVar) const if (envVar == "OSTYPE") { - // TODO: Mac - return sys::Platform == sys::PlatformType::Linux ? " linux-gnu" : "Windows"; - } - - if (envVar == "OSTYPE") - { - // TODO: Mac - return sys::Platform == sys::PlatformType::Linux ? " linux-gnu" : "Windows"; + return sys::platformName(); } // should explicitly handle all env. vars in some way diff --git a/externals/coda-oss/modules/c++/sys/source/CppUnitTestAssert_.cpp_ b/externals/coda-oss/modules/c++/sys/source/CppUnitTestAssert_.cpp_ new file mode 100644 index 000000000..fdcf5f92b --- /dev/null +++ b/externals/coda-oss/modules/c++/sys/source/CppUnitTestAssert_.cpp_ @@ -0,0 +1,43 @@ +#include "pch.h" +#include "TestCase.h" + +#include "str/EncodedStringView.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +// EQUALS_MESSAGE() wants ToString() specializations (or overloads) for our types, which is a nusiance. +// This hooks up our existing str::toString() into the VC++ unit-test infrastructure + +// C++ hack to call private methods +// https://stackoverflow.com/a/71578383/8877 + +using FailOnCondition_t = void(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare method's type +using GetAssertMessage_t = std::wstring(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare method's type +template +struct caller final // helper structure to inject call() code +{ + friend void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) + { + fFailOnCondition(condition, message, pLineInfo); + } + + friend std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message) + { + return fGetAssertMessage(equality, expected, actual, message); + } +}; +template struct caller<&Assert::FailOnCondition, &Assert::GetAssertMessage>; // even instantiation of the helper + +void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare caller +void test::Assert::FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) +{ + ::FailOnCondition(condition, message, pLineInfo); // and call! +} + +std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare caller +std::wstring test::Assert::GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message) +{ + const str::EncodedStringView vExpected(expected); + const str::EncodedStringView vActual(actual); + return ::GetAssertMessage(equality, vExpected.wstring(), vActual.wstring(), message); // and call! +} diff --git a/externals/coda-oss/modules/c++/tiff/source/IFDEntry.cpp b/externals/coda-oss/modules/c++/tiff/source/IFDEntry.cpp index 1ac612aea..d9f5447dd 100644 --- a/externals/coda-oss/modules/c++/tiff/source/IFDEntry.cpp +++ b/externals/coda-oss/modules/c++/tiff/source/IFDEntry.cpp @@ -120,8 +120,7 @@ void tiff::IFDEntry::deserialize(io::InputStream& input, const bool reverseBytes { auto elementSize = tiff::Const::sizeOf(mType); sys::Uint32_T numElements = mCount; - if (mType == tiff::Const::Type::RATIONAL && mType - == tiff::Const::Type::SRATIONAL) + if ((mType == tiff::Const::Type::RATIONAL) || (mType == tiff::Const::Type::SRATIONAL)) { elementSize = tiff::Const::sizeOf(mType) / 2; numElements = mCount * 2; diff --git a/externals/coda-oss/modules/c++/types/include/types/Complex.h b/externals/coda-oss/modules/c++/types/include/types/Complex.h index 46daa0f85..8b2218ff4 100644 --- a/externals/coda-oss/modules/c++/types/include/types/Complex.h +++ b/externals/coda-oss/modules/c++/types/include/types/Complex.h @@ -221,9 +221,9 @@ static_assert(sizeof(std::complex) == sizeof(Complex), "sizeof(siz static_assert(std::is_same, ComplexReal>::value, "should be std::complex"); // Convenient aliases -using zfloat = ComplexReal; // std::complex -using zdouble = ComplexReal; // std::complex -//using zlong_double = ComplexReal; // std::complex +using zfloat = ComplexReal; // i.e., std::complex +using zdouble = ComplexReal; // i.e., std::complex +//using zlong_double = ComplexReal; // i.e., std::complex using zint8_t = ComplexInteger; // Complex using zint16_t = ComplexInteger; // Complex using zint32_t = ComplexInteger; // Complex diff --git a/externals/coda-oss/modules/c++/xml.lite/include/import/xml/lite.h b/externals/coda-oss/modules/c++/xml.lite/include/import/xml/lite.h index 477e27c80..b7b66bca8 100644 --- a/externals/coda-oss/modules/c++/xml.lite/include/import/xml/lite.h +++ b/externals/coda-oss/modules/c++/xml.lite/include/import/xml/lite.h @@ -20,39 +20,9 @@ * */ +#pragma once #ifndef CODA_OSS_xml_lite_import_lite_h_INCLUDED_ #define CODA_OSS_xml_lite_import_lite_h_INCLUDED_ -#pragma once - -#if _MSC_VER -#pragma warning(push) -// these are from Xerces -#pragma warning(disable: 5219) // implicit conversion from '...' to '...', possible loss of data -#pragma warning(disable: 4365) // '...': conversion from '...' to '...', signed / unsigned mismatch -#pragma warning(disable: 26477) // Use 'nullptr' rather than 0 or NULL (es.47). -#pragma warning(disable: 26493) // Don't use C-style casts (type.4). -#pragma warning(disable: 26814) // The const variable '...' can be computed at compile-time. Consider using constexpr (con.5). -#pragma warning(disable: 26496) // The variable '...' does not change after construction, mark it as const (con.4). -#pragma warning(disable: 26497) // The function '...' could be marked constexpr if compile-time evaluation is desired (f.4). -#pragma warning(disable: 26475) // Do not use function style casts (es.49). Prefer '...' over '...'. -#pragma warning(disable: 26495) // Variable '...' is uninitialized. Always initialize a member variable (type.6). -#pragma warning(disable: 26461) // The pointer argument '...' for function '...' can be marked as a pointer to const (con.3). -#pragma warning(disable: 26462) // The value pointed to by '...' is assigned only once, mark it as a pointer to const (con.4). -#pragma warning(disable: 26494) // Variable '...' is uninitialized. Always initialize an object (type.5). -#pragma warning(disable: 26489) // Don't dereference a pointer that may be invalid: '...'. '...' may have been invalidated at line ... (lifetime.1). -#pragma warning(disable: 26488) // Do not dereference a potentially null pointer : ...'. '...' was null at line ... (lifetime.1). -#pragma warning(disable: 26447) // The function is declared '...' but calls function '..' which may throw exceptions (f.6). -#pragma warning(disable: 26485) // Expression '...': No array to pointer decay (bounds.3). -#pragma warning(disable: 26457) // (void) should not be used to ignore return values, use '...' instead (es.48). -#pragma warning(disable: 26487) // Don't return a pointer '...' that may be invalid (lifetime.4). -#pragma warning(disable: 26451) // Arithmetic overflow : Using operator '...' on a 4 byte value and then casting the result to a 8 byte value. Cast the value to the wider type before calling operator '...' to avoid overflow (io.2). -#pragma warning(disable: 26455) // Default constructor may not throw.Declare it 'noexcept' (f.6). -#pragma warning(disable: 26409) // Avoid calling new and delete explicitly, use std::make_unique instead (r.11). -#pragma warning(disable: 26429) // Symbol '...' is never tested for nullness, it can be marked as not_null(f.23). -#pragma warning(disable: 26400) // Do not assign the result of an allocation or a function call with an owner return value to a raw pointer, use owner instead(i.11). -#pragma warning(disable: 26467) // Converting from floating point to unsigned integral types results in non-portable code if the double/float has a negative value. Use gsl::narrow_cast or gsl::narrow instead to guard against undefined behavior and potential data loss (es.46). -#pragma warning(disable: 26823) // Dereferencing a possibly null pointer '...' (lifetime.1). -#endif // _MSC_VER #include "xml/lite/ContentHandler.h" #include "xml/lite/Attributes.h" @@ -67,16 +37,6 @@ #include "xml/lite/Serializable.h" #include "xml/lite/Validator.h" -#if _MSC_VER -#pragma warning(pop) - -#pragma comment(lib, "xml.lite-c++.lib") - -#if defined(USE_XERCES) -#pragma comment(lib, "xerces-c") -#endif -#endif - /*! * \file lite.h * diff --git a/externals/coda-oss/modules/c++/xml.lite/source/Serializable.cpp b/externals/coda-oss/modules/c++/xml.lite/source/Serializable.cpp index d5f55479c..27cb7aaf0 100644 --- a/externals/coda-oss/modules/c++/xml.lite/source/Serializable.cpp +++ b/externals/coda-oss/modules/c++/xml.lite/source/Serializable.cpp @@ -26,8 +26,10 @@ void xml::lite::Serializable::serialize(io::OutputStream& os) { xml::lite::Element *root = getDocument()->getRootElement(); if (root != nullptr) + { os.write("\n"); - root->print(os); + root->print(os); + } } void xml::lite::Serializable::deserialize(io::InputStream& is) From 71d8c9d01aeb7fe4cd5c3df5b7abfdfb410a2459 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Thu, 13 Jul 2023 15:34:17 -0400 Subject: [PATCH 060/104] Adjust paths for coda-oss being used in another SLN --- externals/coda-oss/modules/c++/coda-oss.vcxproj | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/externals/coda-oss/modules/c++/coda-oss.vcxproj b/externals/coda-oss/modules/c++/coda-oss.vcxproj index e2cf91bf5..62647fd77 100644 --- a/externals/coda-oss/modules/c++/coda-oss.vcxproj +++ b/externals/coda-oss/modules/c++/coda-oss.vcxproj @@ -580,7 +580,7 @@ true _DEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL;MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 pch.h - cli\include;coda_oss\include;config\include;dbi\include;except\include;gsl\include;hdf5.lite\include;io\include;logging\include;math\include;math.linear\include;math.poly\include;mem\include;mt\include;net\include;net.ssl\include;plugin\include;polygon\include;re\include;sio.lite\include;std\include;str\include;sys\include;tiff\include;types\include;unique\include;units\include;xml.lite\include;zip\include;$(ProjectDir)include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include + cli\include;coda_oss\include;config\include;dbi\include;except\include;gsl\include;hdf5.lite\include;io\include;logging\include;math\include;math.linear\include;math.poly\include;mem\include;mt\include;net\include;net.ssl\include;plugin\include;polygon\include;re\include;sio.lite\include;std\include;str\include;sys\include;tiff\include;types\include;unique\include;units\include;xml.lite\include;zip\include;$(ProjectDir)include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;$(SolutionDir)externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\include Use pch.h true @@ -598,7 +598,7 @@ true - $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\ + $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib;$(SolutionDir)externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\lib rpcrt4.lib;%(AdditionalDependencies) @@ -610,7 +610,7 @@ true NDEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL;MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 pch.h - cli\include;coda_oss\include;config\include;dbi\include;except\include;gsl\include;hdf5.lite\include;io\include;logging\include;math\include;math.linear\include;math.poly\include;mem\include;mt\include;net\include;net.ssl\include;plugin\include;polygon\include;re\include;sio.lite\include;std\include;str\include;sys\include;tiff\include;types\include;unique\include;units\include;xml.lite\include;zip\include;$(ProjectDir)include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include + cli\include;coda_oss\include;config\include;dbi\include;except\include;gsl\include;hdf5.lite\include;io\include;logging\include;math\include;math.linear\include;math.poly\include;mem\include;mt\include;net\include;net.ssl\include;plugin\include;polygon\include;re\include;sio.lite\include;std\include;str\include;sys\include;tiff\include;types\include;unique\include;units\include;xml.lite\include;zip\include;$(ProjectDir)include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;$(SolutionDir)externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\include Use pch.h true @@ -627,7 +627,7 @@ true true true - $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\ + $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib;$(SolutionDir)externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\lib rpcrt4.lib;%(AdditionalDependencies) From e55f757584e9a80a6c91f336a0779d17da5692c5 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Thu, 13 Jul 2023 16:35:08 -0400 Subject: [PATCH 061/104] remove goofy #include path --- UnitTest/UnitTest.vcxproj | 8 ++++---- modules/c++/nitf-c++.vcxproj | 4 ++-- modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj | 8 ++++---- modules/c/nitf-c.vcxproj | 4 ++-- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/UnitTest/UnitTest.vcxproj b/UnitTest/UnitTest.vcxproj index d098eef76..d678b7a87 100644 --- a/UnitTest/UnitTest.vcxproj +++ b/UnitTest/UnitTest.vcxproj @@ -57,7 +57,7 @@ Use Level3 true - $(ProjectDir);$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + $(ProjectDir);$(SolutionDir)modules\c\nrt\include;$(SolutionDir)modules\c\nitf\include;$(SolutionDir)modules\c++\nitf\include;$(SolutionDir)modules\c\j2k\include;$(SolutionDir)modules\c;$(SolutionDir)modules\c++;$(SolutionDir)externals\coda-oss\modules\c++;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) _DEBUG;%(PreprocessorDefinitions) true pch.h @@ -65,7 +65,7 @@ Windows - $(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;$(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) + $(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib;$(SolutionDir)out\install\$(Platform)-$(Configuration)\lib;$(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) @@ -75,7 +75,7 @@ true true true - $(ProjectDir);$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)externals\coda-oss\modules\c++\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) + $(ProjectDir);$(SolutionDir)modules\c\nrt\include;$(SolutionDir)modules\c\nitf\include;$(SolutionDir)modules\c++\nitf\include;$(SolutionDir)modules\c\j2k\include;$(SolutionDir)modules\c;$(SolutionDir)modules\c++;$(SolutionDir)externals\coda-oss\modules\c++;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) NDEBUG;%(PreprocessorDefinitions) true pch.h @@ -85,7 +85,7 @@ Windows true true - $(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;$(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) + $(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib;$(SolutionDir)out\install\$(Platform)-$(Configuration)\lib;$(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) diff --git a/modules/c++/nitf-c++.vcxproj b/modules/c++/nitf-c++.vcxproj index 1f855894c..a68c9f67f 100644 --- a/modules/c++/nitf-c++.vcxproj +++ b/modules/c++/nitf-c++.vcxproj @@ -218,7 +218,7 @@ true _DEBUG;%(PreprocessorDefinitions) true - $(ProjectDir)nitf\include\;$(ProjectDir)..\c\nrt\include\;$(ProjectDir)..\c\nitf\include\;$(ProjectDir)..\c\j2k\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ + $(ProjectDir)nitf\include;$(ProjectDir)..\c\nrt\include;$(ProjectDir)..\c\nitf\include;$(ProjectDir)..\c\j2k\include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include Use pch.h pch.h @@ -251,7 +251,7 @@ true NDEBUG;%(PreprocessorDefinitions) true - $(ProjectDir)nitf\include\;$(ProjectDir)..\c\nrt\include\;$(ProjectDir)..\c\nitf\include\;$(ProjectDir)..\c\j2k\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ + $(ProjectDir)nitf\include;$(ProjectDir)..\c\nrt\include;$(ProjectDir)..\c\nitf\include;$(ProjectDir)..\c\j2k\include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include Use pch.h pch.h diff --git a/modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj b/modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj index 1ab273b98..233b05d16 100644 --- a/modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj +++ b/modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj @@ -51,7 +51,7 @@ true _DEBUG;_CONSOLE;%(PreprocessorDefinitions) true - $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ + $(SolutionDir)modules\c\nrt\include;$(SolutionDir)modules\c\nitf\include;$(SolutionDir)modules\c\jpeg\include;$(SolutionDir)modules\c\j2k\include;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c;$(SolutionDir)modules\c++;$(SolutionDir)modules\c++\nitf\include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include Use pch.h pch.h @@ -69,7 +69,7 @@ Console true - $(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\ + $(SolutionDir)out\install\$(Platform)-$(Configuration)\lib;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib @@ -79,7 +79,7 @@ true NDEBUG;_CONSOLE;%(PreprocessorDefinitions) true - $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ + $(SolutionDir)modules\c\nrt\include;$(SolutionDir)modules\c\nitf\include;$(SolutionDir)modules\c\jpeg\include;$(SolutionDir)modules\c\j2k\include;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c;$(SolutionDir)modules\c++;$(SolutionDir)modules\c++\nitf\include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include Use pch.h pch.h @@ -95,7 +95,7 @@ true true true - $(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\ + $(SolutionDir)out\install\$(Platform)-$(Configuration)\lib;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib diff --git a/modules/c/nitf-c.vcxproj b/modules/c/nitf-c.vcxproj index 3e2559b63..bacf43fcc 100644 --- a/modules/c/nitf-c.vcxproj +++ b/modules/c/nitf-c.vcxproj @@ -52,7 +52,7 @@ true _DEBUG;%(PreprocessorDefinitions);HAVE_OPENJPEG_H true - $(ProjectDir)nrt\include\;$(ProjectDir)nitf\include\;$(ProjectDir)jpeg\include\;$(ProjectDir)j2k\include\;$(ProjectDir)cgm\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;%(AdditionalIncludeDirectories) + $(ProjectDir)nrt\include;$(ProjectDir)nitf\include;$(ProjectDir)jpeg\include;$(ProjectDir)j2k\include;$(ProjectDir)cgm\include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include;%(AdditionalIncludeDirectories) Use pch.h pch.h @@ -82,7 +82,7 @@ true NDEBUG;%(PreprocessorDefinitions);HAVE_OPENJPEG_H true - $(ProjectDir)nrt\include\;$(ProjectDir)nitf\include\;$(ProjectDir)jpeg\include\;$(ProjectDir)j2k\include\;$(ProjectDir)cgm\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;%(AdditionalIncludeDirectories) + $(ProjectDir)nrt\include;$(ProjectDir)nitf\include;$(ProjectDir)jpeg\include;$(ProjectDir)j2k\include;$(ProjectDir)cgm\include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include;%(AdditionalIncludeDirectories) Use pch.h pch.h From 752dd02aa1387a29588b493f301f0f4ec4a5d146 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Thu, 13 Jul 2023 16:52:31 -0400 Subject: [PATCH 062/104] fix compiler warnings from rearranging UnitTest files --- modules/c/nitf/unittests/Test.h | 2 +- modules/c/nrt/unittests/Test.h | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/modules/c/nitf/unittests/Test.h b/modules/c/nitf/unittests/Test.h index db85a2c46..323157889 100644 --- a/modules/c/nitf/unittests/Test.h +++ b/modules/c/nitf/unittests/Test.h @@ -80,7 +80,7 @@ #define TEST_CASE(X) void X(const char* testName) #define TEST_CASE_ARGS(X) void X(const char* testName, int argc, char **argv) -#define TEST_MAIN(X) int main(int argc, char** argv) { X; return 0; } +#define TEST_MAIN(X) int main(int argc, char** argv) { {(void)argc; (void)argv;} X; return 0; } #endif diff --git a/modules/c/nrt/unittests/Test.h b/modules/c/nrt/unittests/Test.h index 71e46bcaf..5b1e503ca 100644 --- a/modules/c/nrt/unittests/Test.h +++ b/modules/c/nrt/unittests/Test.h @@ -79,7 +79,8 @@ #define TEST_CASE(X) void X(const char* testName) #define TEST_CASE_ARGS(X) void X(const char* testName, int argc, char **argv) -#define TEST_MAIN(X) int main(int argc, char** argv) { X; return 0; } +#define TEST_MAIN(X) int main(int argc, char** argv) { {(void)argc; (void)argv;} X; return 0; } + #endif From 77696978ffc14c6bccc3ba36818fd7a8e5b8d94c Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Thu, 13 Jul 2023 16:56:45 -0400 Subject: [PATCH 063/104] do msbuild with DEBUG, not Release --- .github/workflows/frequent_check.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/frequent_check.yml b/.github/workflows/frequent_check.yml index 77285d679..268185a74 100644 --- a/.github/workflows/frequent_check.yml +++ b/.github/workflows/frequent_check.yml @@ -21,7 +21,7 @@ jobs: run: | mkdir target-Release cd target-Release - cmake -DCMAKE_INSTALL_PREFIX=install${{ matrix.os }}CMake-Github -DPYTHON_VERSION="3.7" .. + cmake .. -DCMAKE_INSTALL_PREFIX=install${{ matrix.os }}CMake-Github -DPYTHON_VERSION="3.7" - name: make run: | cd target-Release @@ -44,7 +44,7 @@ jobs: matrix: os: [windows-latest] platform: [x64] - configuration: [Release] + configuration: [Debug] # Debug turns on more compiler warnings name: ${{ matrix.os }}-msbuild runs-on: ${{ matrix.os }} @@ -54,7 +54,7 @@ jobs: run: | mkdir externals\coda-oss\out cd externals\coda-oss\out - cmake -DCMAKE_INSTALL_PREFIX=install\${{ matrix.platform }}-${{ matrix.configuration }} -DENABLE_PYTHON=OFF .. + cmake .. -DCMAKE_INSTALL_PREFIX=install\${{ matrix.platform }}-${{ matrix.configuration }} -DENABLE_PYTHON=OFF - name: make CODA-OSS run: | cd externals\coda-oss\out @@ -92,7 +92,7 @@ jobs: run: | mkdir target-Release cd target-Release - cmake -DCMAKE_INSTALL_PREFIX=install${{ matrix.os }}CMake-Github -DPYTHON_VERSION=3.7 .. + cmake .. -DCMAKE_INSTALL_PREFIX=install${{ matrix.os }}CMake-Github -DPYTHON_VERSION=3.7 - name: make run: | cd target-Release From 35c359a7b856de861d728c5c648bb59963ea8890 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Thu, 13 Jul 2023 17:04:21 -0400 Subject: [PATCH 064/104] Use common UnitTest code from coda-oss --- UnitTest/CppUnitTestAssert.cpp | 42 +--------- UnitTest/Test.h | 2 - UnitTest/TestCase.h | 139 +-------------------------------- UnitTest/nitf-c++.cpp | 6 ++ UnitTest/nitf-c.cpp | 4 + UnitTest/nrt.cpp | 3 + UnitTest/pch.h | 1 - 7 files changed, 16 insertions(+), 181 deletions(-) diff --git a/UnitTest/CppUnitTestAssert.cpp b/UnitTest/CppUnitTestAssert.cpp index fdcf5f92b..5bea8da59 100644 --- a/UnitTest/CppUnitTestAssert.cpp +++ b/UnitTest/CppUnitTestAssert.cpp @@ -1,43 +1,5 @@ #include "pch.h" #include "TestCase.h" -#include "str/EncodedStringView.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -// EQUALS_MESSAGE() wants ToString() specializations (or overloads) for our types, which is a nusiance. -// This hooks up our existing str::toString() into the VC++ unit-test infrastructure - -// C++ hack to call private methods -// https://stackoverflow.com/a/71578383/8877 - -using FailOnCondition_t = void(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare method's type -using GetAssertMessage_t = std::wstring(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare method's type -template -struct caller final // helper structure to inject call() code -{ - friend void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) - { - fFailOnCondition(condition, message, pLineInfo); - } - - friend std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message) - { - return fGetAssertMessage(equality, expected, actual, message); - } -}; -template struct caller<&Assert::FailOnCondition, &Assert::GetAssertMessage>; // even instantiation of the helper - -void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare caller -void test::Assert::FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) -{ - ::FailOnCondition(condition, message, pLineInfo); // and call! -} - -std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare caller -std::wstring test::Assert::GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message) -{ - const str::EncodedStringView vExpected(expected); - const str::EncodedStringView vActual(actual); - return ::GetAssertMessage(equality, vExpected.wstring(), vActual.wstring(), message); // and call! -} +// Can't get this to build in the **coda-oss** project. +#include "sys/source/CppUnitTestAssert_.cpp_" diff --git a/UnitTest/Test.h b/UnitTest/Test.h index 39ce4f60f..a36e09780 100644 --- a/UnitTest/Test.h +++ b/UnitTest/Test.h @@ -1,8 +1,6 @@ #pragma once -#include "nrt/unittests/Test.h" #include "nitf/unittests/Test.h" - #include "TestCase.h" #define TEST_ASSERT_EQ_INT(X1, X2) TEST_ASSERT_EQ(X2, X1) diff --git a/UnitTest/TestCase.h b/UnitTest/TestCase.h index f8c6eef9b..2c8a47050 100644 --- a/UnitTest/TestCase.h +++ b/UnitTest/TestCase.h @@ -1,144 +1,7 @@ #pragma once -#include -#include - -#include "CppUnitTest.h" - -#include - #undef TEST_ASSERT_NULL #undef TEST_ASSERT #undef TEST_ASSERT_ALMOST_EQ #undef TEST_ASSERT_EQ -#include - -#undef TEST_CHECK -#undef TEST_ASSERT -#undef TEST_ASSERT_NULL -#undef TEST_ASSERT_NOT_NULL -#undef TEST_ASSERT_TRUE -#undef TEST_ASSERT_FALSE -#undef TEST_MAIN -#undef TEST_CASE -#define TEST_CHECK(X) -#define TEST_MAIN(X) -#define TEST_ASSERT_NULL(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNull(X) -#define TEST_ASSERT_NOT_NULL(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNotNull(X) -#define TEST_ASSERT_TRUE(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(X) -#define TEST_ASSERT_FALSE(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsFalse(X) -#define TEST_ASSERT(X) TEST_ASSERT_TRUE(X) -#define CODA_OSS_testMethod_(X) testMethod ## _ ## X -#define TEST_CASE(X) TEST_METHOD(X) { CODA_OSS_testMethod_(X)(#X); } void CODA_OSS_testMethod_(X)(std::string testName) - -namespace test -{ - struct Assert final - { - static void FailOnCondition(bool condition, const unsigned short* message, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo); - static std::wstring GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message); - }; -#define CODA_OSS_equals_message_(expected, actual, message) reinterpret_cast(test::Assert::GetAssertMessage(true, test::toString(expected), test::toString(actual), message).c_str()) -#define CODA_OSS_not_equals_message_(notExpected, actual, message) reinterpret_cast(test::Assert::GetAssertMessage(false, test::toString(notExpected), test::toString(actual), message).c_str()) -#define CODA_OSS_message_(message) reinterpret_cast(test::Assert::GetAssertMessage(false, "", "", message).c_str()) - -// see Assert::AreEqual<> -template -inline void diePrintf_eq(const TExpected& expected, const TActual& actual, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(expected == actual, CODA_OSS_equals_message_(expected, actual, message), pLineInfo); -} - -// see Assert::AreNotEqual<> -template -inline void diePrintf_ne(const TExpected& notExpected, const TActual& actual, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(notExpected != actual, CODA_OSS_not_equals_message_(notExpected, actual, message), pLineInfo); -} - -template -inline void diePrintf_ge(const TX1& X1, const TX2& X2, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(X1 >= X2, CODA_OSS_message_(message), pLineInfo); -} -template -inline void diePrintf_gt(const TX1& X1, const TX2& X2, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(X1 > X2, CODA_OSS_message_(message), pLineInfo); -} -template -inline void diePrintf_le(const TX1& X1, const TX2& X2, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(X1 <= X2, CODA_OSS_message_(message), pLineInfo); -} -template -inline void diePrintf_lt(const TX1& X1, const TX2& X2, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(X1 < X2, CODA_OSS_message_(message), pLineInfo); -} - -} -#undef CODA_OSS_test_diePrintf_eq_ -#undef CODA_OSS_test_diePrintf_not_eq_ -#define CODA_OSS_test_diePrintf_eq_(X1, X2) testName, ::test::diePrintf_eq(X1, X2) -#define CODA_OSS_test_diePrintf_not_eq_(X1, X2) testName, ::test::diePrintf_ne(X1, X2) - -#undef CODA_OSS_test_diePrintf_greater_eq_ -#undef CODA_OSS_test_diePrintf_greater_ -#undef CODA_OSS_test_diePrintf_lesser_eq_ -#undef CODA_OSS_test_diePrintf_lesser_ -#define CODA_OSS_test_diePrintf_greater_eq_(X1, X2) testName, ::test::diePrintf_ge(X1, X2) -#define CODA_OSS_test_diePrintf_greater_(X1, X2) testName, ::test::diePrintf_gt(X1, X2) -#define CODA_OSS_test_diePrintf_lesser_eq_(X1, X2) testName, ::test::diePrintf_le(X1, X2) -#define CODA_OSS_test_diePrintf_lesser_(X1, X2) testName, ::test::diePrintf_lt(X1, X2) - -template -inline void test_assert_greater_(const TX1& X1, const TX2& X2) -{ - Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(X1 > X2); -} -#undef TEST_ASSERT_GREATER -#define TEST_ASSERT_GREATER(X1, X2) testName, test_assert_greater_(X1, X2) - -#undef TEST_ASSERT_ALMOST_EQ_EPS -#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) { (void)testName; Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(X1, X2, EPS); Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(X2, X1, EPS); } -namespace test -{ -inline void assert_almost_eq(const std::string& testName, float X1, float X2) -{ - constexpr auto EPS = static_cast(0.0001); - TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS); -} -inline void assert_almost_eq(const std::string& testName, double X1, double X2) -{ - constexpr auto EPS = static_cast(0.0001); - TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS); -} -inline void assert_almost_eq(const std::string& testName, long double X1, long double X2) -{ - assert_almost_eq(testName, static_cast(X1), static_cast(X2)); -} -} - -#undef TEST_ASSERT_ALMOST_EQ -#define TEST_ASSERT_ALMOST_EQ(X1, X2) test::assert_almost_eq(testName, X1, X2) - -#undef TEST_ASSERT_EQ_MSG -#define TEST_ASSERT_EQ_MSG(msg, X1, X2) testName, Microsoft::VisualStudio::CppUnitTestFramework::Logger::WriteMessage(msg.c_str()); TEST_ASSERT_EQ(X1, X2) - -#undef TEST_FAIL_MSG -#define TEST_FAIL_MSG(msg) { (void)testName; const str::EncodedStringView vw(msg); Microsoft::VisualStudio::CppUnitTestFramework::Assert::Fail(vw.wstring().c_str()); } - -#undef TEST_EXCEPTION -#undef TEST_THROWS -#undef TEST_SPECIFIC_EXCEPTION -#define TEST_EXCEPTION(X) (void)testName; try{ (X); TEST_FAIL(#X " should have thrown."); } CODA_OSS_TEST_EXCEPTION_catch_ -#define TEST_THROWS(X) (void)testName; try{ (X); TEST_FAIL(#X " should have thrown."); } catch (...){ TEST_ASSERT_TRUE(true); } -#define TEST_SPECIFIC_EXCEPTION(X, Y) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::ExpectException([&](){(X);}) - +#include diff --git a/UnitTest/nitf-c++.cpp b/UnitTest/nitf-c++.cpp index 24ec1806b..82dd48509 100644 --- a/UnitTest/nitf-c++.cpp +++ b/UnitTest/nitf-c++.cpp @@ -1,6 +1,12 @@ #include "pch.h" #include "CppUnitTest.h" +#include +#include +#include +#include +#include + namespace nitf_cpp { diff --git a/UnitTest/nitf-c.cpp b/UnitTest/nitf-c.cpp index 357becae8..a25999a6e 100644 --- a/UnitTest/nitf-c.cpp +++ b/UnitTest/nitf-c.cpp @@ -1,6 +1,10 @@ #include "pch.h" #include "CppUnitTest.h" +#include +#include +#include + namespace nitf_c { diff --git a/UnitTest/nrt.cpp b/UnitTest/nrt.cpp index 2963bfab2..7fa9c57ea 100644 --- a/UnitTest/nrt.cpp +++ b/UnitTest/nrt.cpp @@ -1,6 +1,9 @@ #include "pch.h" #include "CppUnitTest.h" +#include +#include + namespace nrt { diff --git a/UnitTest/pch.h b/UnitTest/pch.h index b6367177c..04883be8e 100644 --- a/UnitTest/pch.h +++ b/UnitTest/pch.h @@ -25,7 +25,6 @@ #include #include - #include #include #include From 2932a8f1b17b5e832fde3326091cec6454e03b4b Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Thu, 13 Jul 2023 17:33:49 -0400 Subject: [PATCH 065/104] build in "out" directory to match Visual Studio --- .github/workflows/frequent_check.yml | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/.github/workflows/frequent_check.yml b/.github/workflows/frequent_check.yml index 268185a74..66f4df51d 100644 --- a/.github/workflows/frequent_check.yml +++ b/.github/workflows/frequent_check.yml @@ -8,6 +8,8 @@ jobs: strategy: matrix: os: [windows-latest] + platform: [x64] + configuration: [Release] name: ${{ matrix.os }}-CMake runs-on: ${{ matrix.os }} @@ -19,25 +21,24 @@ jobs: python-version: '3.7' - name: configure run: | - mkdir target-Release - cd target-Release - cmake .. -DCMAKE_INSTALL_PREFIX=install${{ matrix.os }}CMake-Github -DPYTHON_VERSION="3.7" + mkdir out + cmake .. -DCMAKE_INSTALL_PREFIX=install\${{ matrix.platform }}-${{ matrix.configuration }} -DPYTHON_VERSION="3.7" - name: make run: | - cd target-Release - cmake --build . --config Release -j - cmake --build . --config Release --target install + cd out + cmake --build . --config ${{ matrix.configuration }} -j + cmake --build . --config ${{ matrix.configuration }} --target install - name: test run: | - cd target-Release - ctest -C Release --output-on-failure + cd out + ctest -C ${{ matrix.configuration }} --output-on-failure - name: Add msbuild to PATH - uses: microsoft/setup-msbuild@v1.1 + uses: microsoft/setup-msbuild@v1 # https://github.com/marketplace/actions/setup-msbuild with: msbuild-architecture: x64 - name: msbuild run: | - msbuild nitro.sln /p:configuration=Release + msbuild nitro.sln /p:configuration=${{ matrix.configuration }} build-msbuild-windows: strategy: From a83f40f81c558f935a9a9ef8612da6a4a62d4e82 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Thu, 13 Jul 2023 17:55:05 -0400 Subject: [PATCH 066/104] forgot to "cd" into new directory --- .github/workflows/frequent_check.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/frequent_check.yml b/.github/workflows/frequent_check.yml index 66f4df51d..af43a7e6a 100644 --- a/.github/workflows/frequent_check.yml +++ b/.github/workflows/frequent_check.yml @@ -22,6 +22,7 @@ jobs: - name: configure run: | mkdir out + cd out cmake .. -DCMAKE_INSTALL_PREFIX=install\${{ matrix.platform }}-${{ matrix.configuration }} -DPYTHON_VERSION="3.7" - name: make run: | From 8afeeb5e08f9ab99cdef9a2fa9d9e17b7b6b7042 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Thu, 13 Jul 2023 21:14:20 -0400 Subject: [PATCH 067/104] use nitf::Test::findInputFile() --- Test++/nitf_test_writer_3++.cpp | 1 - UnitTest/nitf-c++.cpp | 6 +++--- .../modules/c++/sys/source/FileFinder.cpp | 6 +++++- .../c++/nitf/unittests/test_writer_3++.cpp | 20 ++----------------- 4 files changed, 10 insertions(+), 23 deletions(-) diff --git a/Test++/nitf_test_writer_3++.cpp b/Test++/nitf_test_writer_3++.cpp index 820cb4a56..a4a961102 100644 --- a/Test++/nitf_test_writer_3++.cpp +++ b/Test++/nitf_test_writer_3++.cpp @@ -20,4 +20,3 @@ TEST_CLASS(nitf_test_writer_3__) { #include "nitf/unittests/test_writer_3++.cpp" }; -std::string nitf_test_writer_3__::argv0; \ No newline at end of file diff --git a/UnitTest/nitf-c++.cpp b/UnitTest/nitf-c++.cpp index 82dd48509..2c90f3471 100644 --- a/UnitTest/nitf-c++.cpp +++ b/UnitTest/nitf-c++.cpp @@ -82,8 +82,8 @@ TEST_CLASS(test_tre_read){ public: #include "nitf/unittests/test_tre_read.cpp" }; -//TEST_CLASS(test_writer_3__){ public: -//#include "nitf/unittests/test_writer_3++.cpp" -//}; +TEST_CLASS(test_writer_3__){ public: +#include "nitf/unittests/test_writer_3++.cpp" +}; } \ No newline at end of file diff --git a/externals/coda-oss/modules/c++/sys/source/FileFinder.cpp b/externals/coda-oss/modules/c++/sys/source/FileFinder.cpp index 6b47dda79..f9cf747f2 100644 --- a/externals/coda-oss/modules/c++/sys/source/FileFinder.cpp +++ b/externals/coda-oss/modules/c++/sys/source/FileFinder.cpp @@ -297,7 +297,11 @@ fs::path sys::test::findRootDirectory(const fs::path& p, const std::string& root // Once we're at a .git directory, we have to go down, not up ... or fail. if (!is_directory(p / ".git")) { - return findRootDirectory(p.parent_path(), rootName, isRoot); + const auto parent_path = p.parent_path(); + if (p != parent_path) + { + return findRootDirectory(parent_path, rootName, isRoot); + } } // TODO: since we're in the "FileFinder" module, maybe try a bit harder to find "rootName"? diff --git a/modules/c++/nitf/unittests/test_writer_3++.cpp b/modules/c++/nitf/unittests/test_writer_3++.cpp index b7fa3c88f..396cc335b 100644 --- a/modules/c++/nitf/unittests/test_writer_3++.cpp +++ b/modules/c++/nitf/unittests/test_writer_3++.cpp @@ -36,24 +36,10 @@ const std::string output_file = "test_writer_3++.nitf"; using path = std::filesystem::path; -static std::string argv0; static path findInputFile() { - const auto inputFile = path("modules") / "c++" / "nitf" / "unittests" / "sicd_50x50.nitf"; - - path root; - if (argv0.empty()) - { - // running in Visual Studio - root = std::filesystem::current_path().parent_path().parent_path(); - } - else - { - root = absolute(path(argv0)).parent_path().parent_path().parent_path().parent_path(); - root = root.parent_path().parent_path(); - } - - return root / inputFile; + static const auto sicd_50x50(path("modules") / "c++" / "nitf" / "unittests" / "sicd_50x50.nitf"); + return nitf::Test::findInputFile(sicd_50x50); } static std::string makeBandName(const std::string& rootFile, int imageNum, int bandNum) @@ -279,8 +265,6 @@ TEST_CASE(test_buffered_write_) } TEST_MAIN( - (void)argc; - argv0 = argv[0]; TEST_CHECK(test_writer_3_); TEST_CHECK(test_buffered_write_); ) \ No newline at end of file From 8e490ee9cdb3bb73946a5225727e7a287062a227 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Thu, 13 Jul 2023 21:17:10 -0400 Subject: [PATCH 068/104] test_image_loading++ --- UnitTest/nitf-c++.cpp | 6 +++--- modules/c++/nitf/unittests/test_writer_3++.cpp | 5 +++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/UnitTest/nitf-c++.cpp b/UnitTest/nitf-c++.cpp index 2c90f3471..040f6e967 100644 --- a/UnitTest/nitf-c++.cpp +++ b/UnitTest/nitf-c++.cpp @@ -26,9 +26,9 @@ TEST_CLASS(test_image_blocker){ public: #include "nitf/unittests/test_image_blocker.cpp" }; -//TEST_CLASS(test_image_loading__){ public: -//#include "nitf/unittests/test_image_loading++.cpp" -//}; +TEST_CLASS(test_image_loading__){ public: +#include "nitf/unittests/test_image_loading++.cpp" +}; TEST_CLASS(test_image_segment_blank_nm_compression){ public: #include "nitf/unittests/test_image_segment_blank_nm_compression.cpp" diff --git a/modules/c++/nitf/unittests/test_writer_3++.cpp b/modules/c++/nitf/unittests/test_writer_3++.cpp index 396cc335b..a80e33608 100644 --- a/modules/c++/nitf/unittests/test_writer_3++.cpp +++ b/modules/c++/nitf/unittests/test_writer_3++.cpp @@ -38,8 +38,9 @@ using path = std::filesystem::path; static path findInputFile() { - static const auto sicd_50x50(path("modules") / "c++" / "nitf" / "unittests" / "sicd_50x50.nitf"); - return nitf::Test::findInputFile(sicd_50x50); + static const auto unittests = path("modules") / "c++" / "nitf" / "unittests"; + static const auto inputPath = nitf::Test::findInputFile(unittests, "sicd_50x50.nitf"); + return inputPath; } static std::string makeBandName(const std::string& rootFile, int imageNum, int bandNum) From aeb7cfb8ad45241d090ad031d543b18f69ae99f3 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Thu, 13 Jul 2023 21:33:33 -0400 Subject: [PATCH 069/104] TEST_MAIN() already suppresses argc/argv --- modules/c++/nitf/unittests/test_load_plugins.cpp | 2 -- modules/c++/nitf/unittests/test_tre_create++.cpp | 1 - modules/c++/nitf/unittests/test_tre_mods++.cpp | 2 -- modules/c++/nitf/unittests/test_tre_mods.cpp | 3 --- 4 files changed, 8 deletions(-) diff --git a/modules/c++/nitf/unittests/test_load_plugins.cpp b/modules/c++/nitf/unittests/test_load_plugins.cpp index fd6762ca1..960af2378 100644 --- a/modules/c++/nitf/unittests/test_load_plugins.cpp +++ b/modules/c++/nitf/unittests/test_load_plugins.cpp @@ -103,8 +103,6 @@ TEST_CASE(test_load_all_plugins) } TEST_MAIN( - (void)argc; - (void)argv; TEST_CHECK(test_load_PTPRAA); TEST_CHECK(test_load_ENGRDA); TEST_CHECK(test_load_all_plugins_C); diff --git a/modules/c++/nitf/unittests/test_tre_create++.cpp b/modules/c++/nitf/unittests/test_tre_create++.cpp index 9883132a0..9ffe05000 100644 --- a/modules/c++/nitf/unittests/test_tre_create++.cpp +++ b/modules/c++/nitf/unittests/test_tre_create++.cpp @@ -43,7 +43,6 @@ TEST_CASE(test_tre_clone_329) } TEST_MAIN( - (void)argv; (void)argc; TEST_CHECK(test_tre_create_329); TEST_CHECK(test_tre_clone_329); ) diff --git a/modules/c++/nitf/unittests/test_tre_mods++.cpp b/modules/c++/nitf/unittests/test_tre_mods++.cpp index 02e5a2085..8eb85006b 100644 --- a/modules/c++/nitf/unittests/test_tre_mods++.cpp +++ b/modules/c++/nitf/unittests/test_tre_mods++.cpp @@ -418,8 +418,6 @@ TEST_CASE(overflowingNumericFields) } TEST_MAIN( - (void)argv; (void)argc; - TEST_CHECK(setFields); TEST_CHECK(setBinaryFields); TEST_CHECK(cloneTRE); diff --git a/modules/c++/nitf/unittests/test_tre_mods.cpp b/modules/c++/nitf/unittests/test_tre_mods.cpp index 1f0ebff57..be2517963 100644 --- a/modules/c++/nitf/unittests/test_tre_mods.cpp +++ b/modules/c++/nitf/unittests/test_tre_mods.cpp @@ -247,9 +247,6 @@ TEST_CASE(populateWhileIterating) } TEST_MAIN( - (void) argc; - (void) argv; - TEST_CHECK(testClone); TEST_CHECK(testSize); TEST_CHECK(testBasicMod); From 437c12003dde97349225a5a484bf7d958bb6b49b Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Thu, 13 Jul 2023 21:54:49 -0400 Subject: [PATCH 070/104] trying to get VSTest working --- .github/workflows/frequent_check.yml | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/.github/workflows/frequent_check.yml b/.github/workflows/frequent_check.yml index af43a7e6a..a2b8f82f0 100644 --- a/.github/workflows/frequent_check.yml +++ b/.github/workflows/frequent_check.yml @@ -69,13 +69,12 @@ jobs: - name: msbuild run: | msbuild nitro.sln /p:configuration=${{ matrix.configuration }} - # Can't figure out how to make this work :-( - #- name: vstest - # uses: microsoft/vstest-action@v1.0.0 # https://github.com/marketplace/actions/vstest-action - # with: - # testAssembly: UnitTest.dll - # searchFolder: D:\a\nitro\nitro\${{ matrix.platform }}\${{ matrix.configuration }} - # runInParallel: true + - name: vstest + uses: microsoft/vstest-action@v1.0.0 # https://github.com/marketplace/actions/vstest-action + with: + platform: ${{ matrix.platform }} + testAssembly: UnitTest*.dll + searchFolder: D:\a\nitro\nitro\x64\Debug build-linux-cmake: strategy: From 4f426dda549fd697636b76f18e97d8278db3e0b8 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Thu, 13 Jul 2023 22:06:41 -0400 Subject: [PATCH 071/104] no more argc/argv to main() --- modules/c++/nitf/unittests/TestCase.h | 2 +- modules/c++/nitf/unittests/test_create_nitf++.cpp | 2 -- modules/c++/nitf/unittests/test_field++.cpp | 2 -- modules/c++/nitf/unittests/test_image_blocker.cpp | 3 --- .../test_image_segment_blank_nm_compression.cpp | 2 -- .../c++/nitf/unittests/test_image_segment_computer.cpp | 3 --- modules/c++/nitf/unittests/test_image_writer.cpp | 2 -- modules/c++/nitf/unittests/test_j2k_compress_tile.cpp | 2 +- .../nitf/unittests/test_j2k_compressed_byte_provider.cpp | 9 ++++++++- modules/c++/nitf/unittests/test_j2k_read_tile.cpp | 2 -- modules/c++/nitf/unittests/test_nitf_buffer_list.cpp | 2 -- modules/c++/nitf/unittests/test_tre_read.cpp | 2 -- 12 files changed, 10 insertions(+), 23 deletions(-) diff --git a/modules/c++/nitf/unittests/TestCase.h b/modules/c++/nitf/unittests/TestCase.h index cc4ec42a3..0586fd272 100644 --- a/modules/c++/nitf/unittests/TestCase.h +++ b/modules/c++/nitf/unittests/TestCase.h @@ -62,7 +62,7 @@ catch (const std::exception&){ die_printf("%s (%s,%s,%d): FAILED: Should have thrown exception: " # Y , testName.c_str(), __FILE__, SYS_FUNC, __LINE__);} # define TEST_CASE(X) void X(std::string testName) -#define TEST_MAIN(X) int main(int argc, char** argv) { try { X; return EXIT_SUCCESS; } \ +#define TEST_MAIN(X) int main() { try { X; return EXIT_SUCCESS; } \ catch (const except::Exception& ex) { std::cerr << ex.toString() << std::endl; } \ catch (const std::exception& e) { std::cerr << e.what() << std::endl; } \ catch (...) { std::cerr << "Unknown exception\n"; } \ diff --git a/modules/c++/nitf/unittests/test_create_nitf++.cpp b/modules/c++/nitf/unittests/test_create_nitf++.cpp index 640dc22ae..86a7628f0 100644 --- a/modules/c++/nitf/unittests/test_create_nitf++.cpp +++ b/modules/c++/nitf/unittests/test_create_nitf++.cpp @@ -497,8 +497,6 @@ TEST_CASE(test_mt_record) TEST_MAIN( - (void)argc; - (void)argv; TEST_CHECK(test_create_nitf_with_byte_provider_test); TEST_CHECK(test_create_nitf_test); TEST_CHECK(test_mt_record); diff --git a/modules/c++/nitf/unittests/test_field++.cpp b/modules/c++/nitf/unittests/test_field++.cpp index 75b903701..68ea8e8b2 100644 --- a/modules/c++/nitf/unittests/test_field++.cpp +++ b/modules/c++/nitf/unittests/test_field++.cpp @@ -113,8 +113,6 @@ TEST_CASE(testDescriptors) } TEST_MAIN( - (void)argc; - (void)argv; TEST_CHECK(testCastOperator); TEST_CHECK(testDescriptors); ) diff --git a/modules/c++/nitf/unittests/test_image_blocker.cpp b/modules/c++/nitf/unittests/test_image_blocker.cpp index 189e331fa..f08d71198 100644 --- a/modules/c++/nitf/unittests/test_image_blocker.cpp +++ b/modules/c++/nitf/unittests/test_image_blocker.cpp @@ -475,9 +475,6 @@ TEST_CASE(testBlockPartialImage) } TEST_MAIN( - (void)argc; - (void)argv; - TEST_CHECK(testSingleSegmentNoLeftovers); TEST_CHECK(testSingleSegmentPadCols); TEST_CHECK(testSingleSegmentPadRowsAndPadCols); diff --git a/modules/c++/nitf/unittests/test_image_segment_blank_nm_compression.cpp b/modules/c++/nitf/unittests/test_image_segment_blank_nm_compression.cpp index 8cff7624f..9e1e1e612 100644 --- a/modules/c++/nitf/unittests/test_image_segment_blank_nm_compression.cpp +++ b/modules/c++/nitf/unittests/test_image_segment_blank_nm_compression.cpp @@ -279,7 +279,5 @@ TEST_CASE(testBlankSegmentsValid) } TEST_MAIN( - (void)argc; - (void)argv; TEST_CHECK(testBlankSegmentsValid); ) diff --git a/modules/c++/nitf/unittests/test_image_segment_computer.cpp b/modules/c++/nitf/unittests/test_image_segment_computer.cpp index 26c952b9a..3d47d4968 100644 --- a/modules/c++/nitf/unittests/test_image_segment_computer.cpp +++ b/modules/c++/nitf/unittests/test_image_segment_computer.cpp @@ -216,9 +216,6 @@ TEST_CASE(testKnownCase) TEST_MAIN ( - (void)argc; - (void)argv; - TEST_CHECK(testBlockSizedBoundaries); TEST_CHECK(testPerfectSplitting); TEST_CHECK(testOneRowOver); diff --git a/modules/c++/nitf/unittests/test_image_writer.cpp b/modules/c++/nitf/unittests/test_image_writer.cpp index 37645649d..76e315a8e 100644 --- a/modules/c++/nitf/unittests/test_image_writer.cpp +++ b/modules/c++/nitf/unittests/test_image_writer.cpp @@ -107,8 +107,6 @@ TEST_CASE(changeFileHeader) } TEST_MAIN( - (void)argc;(void)argv; - TEST_CHECK(imageWriterThrowsOnFailedConstruction); TEST_CHECK(constructValidImageWriter); TEST_CHECK(changeFileHeader); diff --git a/modules/c++/nitf/unittests/test_j2k_compress_tile.cpp b/modules/c++/nitf/unittests/test_j2k_compress_tile.cpp index fe9736266..dedefd5ce 100644 --- a/modules/c++/nitf/unittests/test_j2k_compress_tile.cpp +++ b/modules/c++/nitf/unittests/test_j2k_compress_tile.cpp @@ -226,7 +226,7 @@ TEST_CASE(j2k_compress_tile) } } -TEST_MAIN((void)argc; (void)argv; +TEST_MAIN( TEST_CHECK(j2k_compress_tile); ) diff --git a/modules/c++/nitf/unittests/test_j2k_compressed_byte_provider.cpp b/modules/c++/nitf/unittests/test_j2k_compressed_byte_provider.cpp index 100cc7382..ed234d855 100644 --- a/modules/c++/nitf/unittests/test_j2k_compressed_byte_provider.cpp +++ b/modules/c++/nitf/unittests/test_j2k_compressed_byte_provider.cpp @@ -631,7 +631,14 @@ TEST_CASE(j2k_compressed_byte_provider) } } -TEST_MAIN((void)argc;(void)argv; +TEST_CASE(j2k_do_nothing) +{ + /* placeholder */ + TEST_ASSERT_TRUE(true); +} + +TEST_MAIN( + TEST_CHECK(j2k_do_nothing); //TEST_CHECK(j2k_compressed_byte_provider_maxRowsPerSegment0); // TODO: get working with CMake //TEST_CHECK(j2k_compressed_byte_provider); // TODO: get working with CMake ) \ No newline at end of file diff --git a/modules/c++/nitf/unittests/test_j2k_read_tile.cpp b/modules/c++/nitf/unittests/test_j2k_read_tile.cpp index f08b268dd..1cf1c1d88 100644 --- a/modules/c++/nitf/unittests/test_j2k_read_tile.cpp +++ b/modules/c++/nitf/unittests/test_j2k_read_tile.cpp @@ -31,8 +31,6 @@ TEST_CASE(j2k_read_tile) } TEST_MAIN( - (void)argc; - (void)argv; TEST_CHECK(j2k_read_tile); ) diff --git a/modules/c++/nitf/unittests/test_nitf_buffer_list.cpp b/modules/c++/nitf/unittests/test_nitf_buffer_list.cpp index 06a07dfa6..889d90446 100644 --- a/modules/c++/nitf/unittests/test_nitf_buffer_list.cpp +++ b/modules/c++/nitf/unittests/test_nitf_buffer_list.cpp @@ -177,8 +177,6 @@ TEST_CASE(testGetBlock_std_byte) } TEST_MAIN( - (void)argc; - (void)argv; TEST_CHECK(testGetNumBlocks); TEST_CHECK(testGetBlock_sys_byte); TEST_CHECK(testGetBlock_std_byte); diff --git a/modules/c++/nitf/unittests/test_tre_read.cpp b/modules/c++/nitf/unittests/test_tre_read.cpp index 183cc048e..e828d88ea 100644 --- a/modules/c++/nitf/unittests/test_tre_read.cpp +++ b/modules/c++/nitf/unittests/test_tre_read.cpp @@ -277,8 +277,6 @@ TEST_CASE(test_nitf_CSEXRB_bugfix) } TEST_MAIN( - (void)argc; (void)argv; - TEST_CHECK(test_nitf_Record_unmergeTREs_crash); // 2 TEST_CHECK(test_defaultRead_crash); // 3 TEST_CHECK(test_readBandInfo_crash); // 4 From 9c48cfe3f48a4b75cd07275de8a9d4de96dfeb00 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Fri, 14 Jul 2023 08:33:13 -0400 Subject: [PATCH 072/104] pass `testName` rather than a `static` variable --- .../test_j2k_compressed_byte_provider.cpp | 2 -- .../c++/nitf/unittests/test_j2k_loading++.cpp | 24 ++++++++++--------- .../c++/nitf/unittests/test_load_plugins.cpp | 2 -- modules/c++/nitf/unittests/test_tre_read.cpp | 1 - .../c++/nitf/unittests/test_writer_3++.cpp | 1 - 5 files changed, 13 insertions(+), 17 deletions(-) diff --git a/modules/c++/nitf/unittests/test_j2k_compressed_byte_provider.cpp b/modules/c++/nitf/unittests/test_j2k_compressed_byte_provider.cpp index ed234d855..efd377469 100644 --- a/modules/c++/nitf/unittests/test_j2k_compressed_byte_provider.cpp +++ b/modules/c++/nitf/unittests/test_j2k_compressed_byte_provider.cpp @@ -54,8 +54,6 @@ #include "TestCase.h" -static std::string testName; - static void setCornersFromDMSBox(nitf::ImageSubheader& header) { /* diff --git a/modules/c++/nitf/unittests/test_j2k_loading++.cpp b/modules/c++/nitf/unittests/test_j2k_loading++.cpp index fec7449b1..22de200df 100644 --- a/modules/c++/nitf/unittests/test_j2k_loading++.cpp +++ b/modules/c++/nitf/unittests/test_j2k_loading++.cpp @@ -59,8 +59,6 @@ #include -static std::string testName; - static auto findInputFile(const std::filesystem::path& fn) { static const auto unittests = std::filesystem::path("modules") / "c++" / "nitf" / "unittests"; @@ -112,7 +110,8 @@ TEST_CASE(test_j2k_loading) TEST_ASSERT_TRUE(true); // be sure hidden "testName" parameter is used } -static void test_j2k_nitf_(const std::string& fname) +static void test_j2k_nitf_(const std::string& testName, + const std::string& fname) { nitf::IOHandle io(fname); nitf::Reader reader; @@ -163,7 +162,7 @@ TEST_CASE(test_j2k_nitf) // This is a JP2 file, not J2K; see OpenJPEG_setup_() const auto input_file = findInputFile("j2k_compressed_file1_jp2.ntf").string(); - test_j2k_nitf_(input_file); + test_j2k_nitf_(testName, input_file); } void writeFile(uint32_t x0, uint32_t y0, @@ -206,7 +205,8 @@ void writeJ2K(uint32_t x0, uint32_t y0, writer.write(outIO); //printf("Wrote file: %s\n", outName.c_str()); } -void test_j2k_nitf_read_region_(const std::filesystem::path& fname) +void test_j2k_nitf_read_region_(const std::string& testName, + const std::filesystem::path& fname) { nitf::IOHandle io(fname.string(), NRT_ACCESS_READONLY, NRT_OPEN_EXISTING); nitf::Reader reader; @@ -281,12 +281,13 @@ TEST_CASE(test_j2k_nitf_read_region) { // This is a JP2 file, not J2K; see OpenJPEG_setup_() const auto input_file = findInputFile("j2k_compressed_file1_jp2.ntf"); - test_j2k_nitf_read_region_(input_file); + test_j2k_nitf_read_region_(testName, input_file); TEST_ASSERT_TRUE(true); // be sure hidden "testName" parameter is used } -static std::vector readImage(nitf::ImageReader& imageReader, const nitf::ImageSubheader& imageSubheader) +static std::vector readImage(const std::string& testName, + nitf::ImageReader& imageReader, const nitf::ImageSubheader& imageSubheader) { const auto numBlocks = imageSubheader.numBlocksPerRow() * imageSubheader.numBlocksPerCol(); TEST_ASSERT_GREATER(static_cast(numBlocks), 0); @@ -308,7 +309,8 @@ static std::vector readImage(nitf::ImageReader& imageReader, const ni } return retval; } -static void test_decompress_nitf_to_sio_(const std::filesystem::path& inputPathname, const std::filesystem::path& outputPathname) +static void test_decompress_nitf_to_sio_(const std::string& testName, + const std::filesystem::path& inputPathname, const std::filesystem::path& outputPathname) { // Take a J2K-compressed NITF, decompress the image and save to an SIO. nitf::Reader reader; @@ -319,7 +321,7 @@ static void test_decompress_nitf_to_sio_(const std::filesystem::path& inputPathn const auto imageSubheader = imageSegment.getSubheader(); auto imageReader = reader.newImageReader(0 /*imageSegmentNumber*/); - const auto imageData = readImage(imageReader, imageSubheader); + const auto imageData = readImage(testName, imageReader, imageSubheader); const sys::filesystem::path outputPathname_ = outputPathname.string(); sio::lite::writeSIO(imageData.data(), imageSubheader.dims(), outputPathname_); @@ -329,7 +331,7 @@ TEST_CASE(test_j2k_decompress_nitf_to_sio) nitf::Test::j2kSetNitfPluginPath(); const auto inputPathname = findInputFile("j2k_compressed_file1_jp2.ntf"); // This is a JP2 file, not J2K; see OpenJPEG_setup_() - test_decompress_nitf_to_sio_(inputPathname, "test_decompress_nitf.sio"); + test_decompress_nitf_to_sio_(testName, inputPathname, "test_decompress_nitf.sio"); TEST_ASSERT_TRUE(true); // be sure hidden "testName" parameter is used } @@ -340,7 +342,7 @@ TEST_CASE(test_j2k_compress_raw_image) const auto inputPathname = findInputFile("j2k_compressed_file1_jp2.ntf"); // This is a JP2 file, not J2K; see OpenJPEG_setup_() const std::filesystem::path outputPathname = "test_j2k_compress_raw_image.sio"; - test_decompress_nitf_to_sio_(inputPathname, outputPathname); + test_decompress_nitf_to_sio_(testName, inputPathname, outputPathname); // --------------------------------------------------------------------------------------- // J2K compresses the raw image data of an SIO file diff --git a/modules/c++/nitf/unittests/test_load_plugins.cpp b/modules/c++/nitf/unittests/test_load_plugins.cpp index 960af2378..e568b838f 100644 --- a/modules/c++/nitf/unittests/test_load_plugins.cpp +++ b/modules/c++/nitf/unittests/test_load_plugins.cpp @@ -29,8 +29,6 @@ #include "TestCase.h" -static std::string testName; - static void load_plugin(const char* tre) { nitf_Error error; diff --git a/modules/c++/nitf/unittests/test_tre_read.cpp b/modules/c++/nitf/unittests/test_tre_read.cpp index e828d88ea..8050f361e 100644 --- a/modules/c++/nitf/unittests/test_tre_read.cpp +++ b/modules/c++/nitf/unittests/test_tre_read.cpp @@ -91,7 +91,6 @@ files, this bug may allow an attacker to cause a denial of service. */ -static std::string testName; const char* output_file = "test_writer_3++.nitf"; static std::filesystem::path findInputFile_(const std::string& name) diff --git a/modules/c++/nitf/unittests/test_writer_3++.cpp b/modules/c++/nitf/unittests/test_writer_3++.cpp index a80e33608..21f6b053e 100644 --- a/modules/c++/nitf/unittests/test_writer_3++.cpp +++ b/modules/c++/nitf/unittests/test_writer_3++.cpp @@ -31,7 +31,6 @@ #include "TestCase.h" -static std::string testName; const std::string output_file = "test_writer_3++.nitf"; using path = std::filesystem::path; From d138c98409395da7a88943456b303b88e90be56a Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Fri, 14 Jul 2023 08:37:33 -0400 Subject: [PATCH 073/104] try calling vstest.console directly --- .github/workflows/frequent_check.yml | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/frequent_check.yml b/.github/workflows/frequent_check.yml index a2b8f82f0..77036d655 100644 --- a/.github/workflows/frequent_check.yml +++ b/.github/workflows/frequent_check.yml @@ -69,12 +69,15 @@ jobs: - name: msbuild run: | msbuild nitro.sln /p:configuration=${{ matrix.configuration }} + #- name: vstest + # uses: microsoft/vstest-action@v1.0.0 # https://github.com/marketplace/actions/vstest-action + # with: + # platform: ${{ matrix.platform }} + # testAssembly: UnitTest.dll + # searchFolder: D:\a\nitro\nitro\x64\Debug - name: vstest - uses: microsoft/vstest-action@v1.0.0 # https://github.com/marketplace/actions/vstest-action - with: - platform: ${{ matrix.platform }} - testAssembly: UnitTest*.dll - searchFolder: D:\a\nitro\nitro\x64\Debug + run: | + vstest.console D:\a\nitro\nitro\x64\Debug\UnitTest.dll build-linux-cmake: strategy: From f32f985a73263cbae71dabfe687b785c83e56168 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Fri, 14 Jul 2023 08:48:12 -0400 Subject: [PATCH 074/104] more `testName` arguments --- ...nitf_test_j2k_compressed_byte_provider.cpp | 1 - UnitTest/nitf-c++.cpp | 6 +++--- .../c++/nitf/unittests/test_writer_3++.cpp | 21 ++++++++++--------- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/Test++/nitf_test_j2k_compressed_byte_provider.cpp b/Test++/nitf_test_j2k_compressed_byte_provider.cpp index 8c102027a..c33c5c877 100644 --- a/Test++/nitf_test_j2k_compressed_byte_provider.cpp +++ b/Test++/nitf_test_j2k_compressed_byte_provider.cpp @@ -12,4 +12,3 @@ TEST_CLASS(test_j2k_compressed_byte_provider) { }; -std::string test_j2k_compressed_byte_provider::testName; diff --git a/UnitTest/nitf-c++.cpp b/UnitTest/nitf-c++.cpp index 040f6e967..6b9bfe56e 100644 --- a/UnitTest/nitf-c++.cpp +++ b/UnitTest/nitf-c++.cpp @@ -82,8 +82,8 @@ TEST_CLASS(test_tre_read){ public: #include "nitf/unittests/test_tre_read.cpp" }; -TEST_CLASS(test_writer_3__){ public: -#include "nitf/unittests/test_writer_3++.cpp" -}; +//TEST_CLASS(test_writer_3__){ public: +//#include "nitf/unittests/test_writer_3++.cpp" +//}; } \ No newline at end of file diff --git a/modules/c++/nitf/unittests/test_writer_3++.cpp b/modules/c++/nitf/unittests/test_writer_3++.cpp index 21f6b053e..d2955dd26 100644 --- a/modules/c++/nitf/unittests/test_writer_3++.cpp +++ b/modules/c++/nitf/unittests/test_writer_3++.cpp @@ -98,10 +98,8 @@ static void doWrite(const nitf::Record& record_, nitf::Reader& reader, const std writer.write(); } -static void manuallyWriteImageBands(nitf::ImageSegment & segment, - const std::string& imageName, - nitf::ImageReader& deserializer, - int imageNumber) +static void manuallyWriteImageBands(const std::string& testName, + nitf::ImageSegment& segment, const std::string& imageName, nitf::ImageReader& deserializer, int imageNumber) { int padded; @@ -174,7 +172,8 @@ static void manuallyWriteImageBands(nitf::ImageSegment & segment, handles[i].close(); } -static nitf::Record doRead(const std::string& inFile, nitf::Reader& reader) +static nitf::Record doRead(const std::string& testName, + const std::string& inFile, nitf::Reader& reader) { // Check that wew have a valid NITF const auto version = nitf::Reader::getNITFVersion(inFile); @@ -193,7 +192,7 @@ static nitf::Record doRead(const std::string& inFile, nitf::Reader& reader) nitf::ImageReader deserializer = reader.newImageReader(count); /* Write the thing out */ - manuallyWriteImageBands(imageSegment, inFile, deserializer, count); + manuallyWriteImageBands(testName, imageSegment, inFile, deserializer, count); } return record; @@ -220,7 +219,7 @@ TEST_CASE(test_writer_3_) const auto input_file = findInputFile().string(); nitf::Reader reader; - nitf::Record record = doRead(input_file, reader); + nitf::Record record = doRead(testName, input_file, reader); test_writer_3__doWrite(record, reader, input_file, output_file); } @@ -235,7 +234,8 @@ TEST_CASE(test_writer_3_) * if the data does not fill the block. * */ -static void test_buffered_write__doWrite(nitf::Record record, nitf::Reader& reader, +static void test_buffered_write__doWrite(const std::string& testName, + nitf::Record record, nitf::Reader& reader, const std::string& inRootFile, const std::string& outFile, size_t bufferSize) @@ -259,8 +259,9 @@ TEST_CASE(test_buffered_write_) size_t blockSize = 8192; nitf::Reader reader; - nitf::Record record = doRead(input_file, reader); - test_buffered_write__doWrite(record, reader, input_file, output_file, blockSize); + nitf::Record record = doRead(testName, input_file, reader); + test_buffered_write__doWrite(testName, + record, reader, input_file, output_file, blockSize); } From 3c37c11c093040f64dddd869b08a1b391464845e Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Fri, 14 Jul 2023 08:53:08 -0400 Subject: [PATCH 075/104] remove Test and Test++, moving to UnitTest anyway --- nitro.sln | 23 ++++------------------- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/nitro.sln b/nitro.sln index 06c7ef2cc..0df4d94e2 100644 --- a/nitro.sln +++ b/nitro.sln @@ -30,7 +30,7 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "AIMIDB", "modules\c\nitf\AI EndProject Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "JITCID", "modules\c\nitf\JITCID.vcxproj", "{D1D7FCD3-6130-4504-9DA0-9D80506BE55E}" EndProject -Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "nitf-plugins", "nitf-plugins", "{27A2685A-E869-42A2-956D-92994F60C536}" +Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "c-nitf-shared", "c-nitf-shared", "{27A2685A-E869-42A2-956D-92994F60C536}" EndProject Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "CSCRNA", "modules\c\nitf\CSCRNA.vcxproj", "{023DE06D-3967-4406-B1B8-032118BB2552}" EndProject @@ -46,21 +46,15 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "HISTOA", "modules\c\nitf\HI EndProject Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "ENGRDA", "modules\c\nitf\ENGRDA.vcxproj", "{53F9F908-C678-4DEE-9309-E71C1E03A45F}" EndProject -Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "Test", "Test\Test.vcxproj", "{238C9787-B27D-4107-B8FD-1BDB49EA8023}" -EndProject -Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "Test++", "Test++\Test++.vcxproj", "{E610F11D-1240-4260-87F8-504B49DB6915}" -EndProject Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "J2KCompress", "modules\c\j2k\J2KCompress.vcxproj", "{A676EDF3-F231-47C8-A6E6-0FE50B50B71B}" EndProject Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "J2KDecompress", "modules\c\j2k\J2KDecompress.vcxproj", "{C787537A-0CAC-4D6D-A6D6-A66765A06753}" EndProject -Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".github", ".github", "{A45CB073-25A7-411D-A7E7-589BCC8AF547}" -EndProject -Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "workflows", "workflows", "{AC22B9D3-0749-486F-A8F2-D6977BF9505D}" +Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".github-workflows", ".github-workflows", "{A45CB073-25A7-411D-A7E7-589BCC8AF547}" ProjectSection(SolutionItems) = preProject - .github\workflows\codeql-analysis.yml = .github\workflows\codeql-analysis.yml + .github\workflows\codeql.yml = .github\workflows\codeql.yml .github\workflows\frequent_check.yml = .github\workflows\frequent_check.yml - .github\workflows\master.yml = .github\workflows\master.yml + .github\workflows\main.yml = .github\workflows\main.yml EndProjectSection EndProject Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "CSEXRB", "modules\c\nitf\CSEXRB.vcxproj", "{0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E}" @@ -133,14 +127,6 @@ Global {53F9F908-C678-4DEE-9309-E71C1E03A45F}.Debug|x64.Build.0 = Debug|x64 {53F9F908-C678-4DEE-9309-E71C1E03A45F}.Release|x64.ActiveCfg = Release|x64 {53F9F908-C678-4DEE-9309-E71C1E03A45F}.Release|x64.Build.0 = Release|x64 - {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Debug|x64.ActiveCfg = Debug|x64 - {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Debug|x64.Build.0 = Debug|x64 - {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Release|x64.ActiveCfg = Release|x64 - {238C9787-B27D-4107-B8FD-1BDB49EA8023}.Release|x64.Build.0 = Release|x64 - {E610F11D-1240-4260-87F8-504B49DB6915}.Debug|x64.ActiveCfg = Debug|x64 - {E610F11D-1240-4260-87F8-504B49DB6915}.Debug|x64.Build.0 = Debug|x64 - {E610F11D-1240-4260-87F8-504B49DB6915}.Release|x64.ActiveCfg = Release|x64 - {E610F11D-1240-4260-87F8-504B49DB6915}.Release|x64.Build.0 = Release|x64 {A676EDF3-F231-47C8-A6E6-0FE50B50B71B}.Debug|x64.ActiveCfg = Debug|x64 {A676EDF3-F231-47C8-A6E6-0FE50B50B71B}.Debug|x64.Build.0 = Debug|x64 {A676EDF3-F231-47C8-A6E6-0FE50B50B71B}.Release|x64.ActiveCfg = Release|x64 @@ -180,7 +166,6 @@ Global {A676EDF3-F231-47C8-A6E6-0FE50B50B71B} = {27A2685A-E869-42A2-956D-92994F60C536} {C787537A-0CAC-4D6D-A6D6-A66765A06753} = {27A2685A-E869-42A2-956D-92994F60C536} {A45CB073-25A7-411D-A7E7-589BCC8AF547} = {5C5727E7-0CFF-42B4-8F5A-D31B3BC81F21} - {AC22B9D3-0749-486F-A8F2-D6977BF9505D} = {A45CB073-25A7-411D-A7E7-589BCC8AF547} {0A9BDA26-092F-4A2C-BBEF-00C64BF0C65E} = {27A2685A-E869-42A2-956D-92994F60C536} {9997E895-5161-4DDF-8F3F-099894CB2F21} = {7D26D571-0014-4C50-BF86-612E743E64B6} EndGlobalSection From 9cf5b973706bc96c460ef7ee61ec773a6bf04fec Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Fri, 14 Jul 2023 09:19:56 -0400 Subject: [PATCH 076/104] vstest.console doesn't work either --- .github/workflows/frequent_check.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/frequent_check.yml b/.github/workflows/frequent_check.yml index 77036d655..aa0c3d30d 100644 --- a/.github/workflows/frequent_check.yml +++ b/.github/workflows/frequent_check.yml @@ -75,9 +75,9 @@ jobs: # platform: ${{ matrix.platform }} # testAssembly: UnitTest.dll # searchFolder: D:\a\nitro\nitro\x64\Debug - - name: vstest - run: | - vstest.console D:\a\nitro\nitro\x64\Debug\UnitTest.dll + #- name: vstest + # run: | + # vstest.console D:\a\nitro\nitro\x64\Debug\UnitTest.dll build-linux-cmake: strategy: From f23998f4989a0e879b3676e2468c167141a17ef1 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Fri, 14 Jul 2023 09:23:33 -0400 Subject: [PATCH 077/104] trying to get unittests building again --- UnitTest/nitf-c++.cpp | 6 +++--- modules/c++/nitf/unittests/test_image_loading++.cpp | 2 -- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/UnitTest/nitf-c++.cpp b/UnitTest/nitf-c++.cpp index 6b9bfe56e..82dd48509 100644 --- a/UnitTest/nitf-c++.cpp +++ b/UnitTest/nitf-c++.cpp @@ -26,9 +26,9 @@ TEST_CLASS(test_image_blocker){ public: #include "nitf/unittests/test_image_blocker.cpp" }; -TEST_CLASS(test_image_loading__){ public: -#include "nitf/unittests/test_image_loading++.cpp" -}; +//TEST_CLASS(test_image_loading__){ public: +//#include "nitf/unittests/test_image_loading++.cpp" +//}; TEST_CLASS(test_image_segment_blank_nm_compression){ public: #include "nitf/unittests/test_image_segment_blank_nm_compression.cpp" diff --git a/modules/c++/nitf/unittests/test_image_loading++.cpp b/modules/c++/nitf/unittests/test_image_loading++.cpp index be3e03569..4850298da 100644 --- a/modules/c++/nitf/unittests/test_image_loading++.cpp +++ b/modules/c++/nitf/unittests/test_image_loading++.cpp @@ -31,8 +31,6 @@ using path = std::filesystem::path; #include "TestCase.h" -static std::string testName; - static path findInputFile() { static const auto unittests = path("modules") / "c++" / "nitf" / "unittests"; From 3fda663da0b5786d0d3d545d92c348c2d3d38330 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Fri, 14 Jul 2023 10:13:19 -0400 Subject: [PATCH 078/104] Squashed commit of the following: commit 4ef66de874b9e7a4f1e5aba85bd54318fea21bc8 Author: J. Daniel Smith Date: Fri Jul 14 10:12:28 2023 -0400 latest from coda-oss commit adee8552dd5a01d670b9766750fe67448b405a13 Merge: 3f942425b 62d502e03 Author: Dan Smith Date: Wed Jul 12 14:37:53 2023 -0400 Merge commit '62d502e036f32f31b869663d630dc5e0c62c54f9' into develop/sync_externals commit 62d502e036f32f31b869663d630dc5e0c62c54f9 Author: Dan Smith Date: Wed Jul 12 14:37:53 2023 -0400 Squashed 'externals/coda-oss/' changes from f70b4202f1..a7f8ef2605 a7f8ef2605 Fix compile warnings from building CODA (#700) git-subtree-dir: externals/coda-oss git-subtree-split: a7f8ef26056a9e840486a0fce58d279915d5c23d commit 3f942425b48e0a3611e2e3a55548d9f6ee226f28 Author: Dan Smith Date: Wed Jul 12 14:37:49 2023 -0400 latest from CODA-OSS commit 131fb0daa0706f30eb907cf80e71df3610a491a5 Merge: c7383461f b4ae2d429 Author: Dan Smith Date: Wed Jul 12 14:37:33 2023 -0400 Merge branch 'main' into develop/sync_externals commit c7383461fe80097a8f33f9ce6049aa5e4c412f2f Author: Dan Smith Date: Mon Jul 10 15:18:35 2023 -0400 match CODA-OSS YAML commit a826a104019fc91669affe064a91f96af04e5f2d Author: Dan Smith Date: Mon Jul 10 14:21:59 2023 -0400 Squashed 'externals/coda-oss/' changes from af3faebfc6..f70b4202f1 f70b4202f1 account for coda-oss.vcxproj being in other SLNs git-subtree-dir: externals/coda-oss git-subtree-split: f70b4202f19f260941a0245e41301ae232348fc7 commit 7448df507bad80cdf5f4d852da4aa6c1e45b4087 Merge: 3cacdcb23 a826a1040 Author: Dan Smith Date: Mon Jul 10 14:21:59 2023 -0400 Merge commit 'a826a104019fc91669affe064a91f96af04e5f2d' into develop/sync_externals commit 3cacdcb23239ed6d8d612bc588b1f38598229771 Merge: 6e64241bd 176bcaf6d Author: Dan Smith Date: Mon Jul 10 14:21:19 2023 -0400 Merge branch 'main' into develop/sync_externals commit 6e64241bd2c09956daa8bf5bfd0f404d03c79bc0 Merge: 457d0f849 85e9043b8 Author: Dan Smith Date: Mon Jul 10 12:58:00 2023 -0400 Merge branch 'main' into develop/sync_externals commit e6f75f4fc04264317fce056dfc5e4d38bf0321d5 Author: Dan Smith Date: Mon Jul 10 10:41:34 2023 -0400 Squashed 'externals/coda-oss/' changes from c2fc5fc660..af3faebfc6 af3faebfc6 Remove more compiler/code-analysis warnings (#699) 82be2a6db2 unittests should work w/o install (#698) dbb90a06d9 add msbuild for coda-oss.sln (#697) 5a417140a6 reduce compiler warnings (#696) 288619dfa3 all modules now part of coda-oss.vcxproj (#695) git-subtree-dir: externals/coda-oss git-subtree-split: af3faebfc6fc7e2fced54e8ea63e17467c8fcac7 commit 457d0f849e25948cc0ce061f5c9eb3fc24ab1b1a Merge: 67c0fdf22 e6f75f4fc Author: Dan Smith Date: Mon Jul 10 10:41:34 2023 -0400 Merge commit 'e6f75f4fc04264317fce056dfc5e4d38bf0321d5' into develop/sync_externals commit 67c0fdf2272019640b8671f4d1a6a02412823b26 Author: Dan Smith Date: Mon Jul 10 10:41:30 2023 -0400 latest from CODA-OSS commit 3278dbbf48dba54b3b57bec0e4ca02c01e1838a8 Merge: 3218ca3a5 49ec50325 Author: Dan Smith Date: Mon Jul 10 10:40:39 2023 -0400 Merge branch 'main' into develop/sync_externals commit 6149255f237e37dae196ede2fba585262c754b60 Author: Dan Smith Date: Wed Jul 5 12:07:03 2023 -0400 Squashed 'externals/coda-oss/' changes from 54033e70e3..c2fc5fc660 c2fc5fc660 add more projects to coda-oss-lite.vcxproj (#694) ceb86c186e support $(PlatformToolset) as a "special" environment variable (#693) d78a8595a7 OS::getSIMDInstructionSet() utility (#692) 2d2df467da fix `python3 waf dumplib` git-subtree-dir: externals/coda-oss git-subtree-split: c2fc5fc660c2794d77fac2b71cf0dfae76c22c3e commit 3218ca3a5ed11cbaf74fc773f2e9da438ad3aae2 Merge: 20ac30dea 6149255f2 Author: Dan Smith Date: Wed Jul 5 12:07:03 2023 -0400 Merge commit '6149255f237e37dae196ede2fba585262c754b60' into develop/sync_externals commit 20ac30dea2088b1ce7c1dea42d64ff9927860c46 Author: Dan Smith Date: Wed Jul 5 12:06:51 2023 -0400 latest from CODA-OSS commit 6f4212e99a35e81cc3cff59eb8e21227df98c291 Merge: 9a1e6b291 cee9feb42 Author: Dan Smith Date: Wed Jul 5 12:05:41 2023 -0400 Merge branch 'main' into develop/sync_externals commit e13ca8b67ca6f547b5c88649a8d102b32e2cce17 Author: Dan Smith Date: Mon Jun 19 14:00:13 2023 -0400 Squashed 'externals/coda-oss/' changes from 3c63f9f65e..54033e70e3 54033e70e3 Merge branch 'main' into feature/complex_short git-subtree-dir: externals/coda-oss git-subtree-split: 54033e70e353da94340dd7b96d0b1c6652308952 commit 9a1e6b29131df20917a6cb485e2961bfbd43439f Merge: 4896d7f49 e13ca8b67 Author: Dan Smith Date: Mon Jun 19 14:00:13 2023 -0400 Merge commit 'e13ca8b67ca6f547b5c88649a8d102b32e2cce17' into develop/sync_externals commit 4896d7f49bfe6005c2b6fa7d0db4589de7039145 Author: Dan Smith Date: Mon Jun 19 14:00:08 2023 -0400 latest from CODA-OSS commit f6ca547a2cd51a907313efcdd6df461a1878aef0 Author: Dan Smith Date: Mon Jun 19 13:47:55 2023 -0400 Squashed 'externals/coda-oss/' changes from f4d42005fa..3c63f9f65e 3c63f9f65e std::numbers from C++20 (#691) 892dd0e00f ComplexInteger and ComplexReal to better match existing naming conventions (#690) b3872181ec match coda-oss naming conventions (#688) 704d6867f9 beef-up our complex type (#687) 47c1c1cd66 check is_absolute() for URLs (#686) c042373e16 be sure our Path::isAbolute() matches std::filesystem::path::absolute() (#684) ad10286bc0 volatile is about "special" memory, not threading (#685) git-subtree-dir: externals/coda-oss git-subtree-split: 3c63f9f65eaa2f7d8d33797c49525a24c2b82b62 commit 56eda7ac06da791e37e4abf390d96b43e6a929fd Merge: 02988da0c f6ca547a2 Author: Dan Smith Date: Mon Jun 19 13:47:55 2023 -0400 Merge commit 'f6ca547a2cd51a907313efcdd6df461a1878aef0' into develop/sync_externals commit 02988da0c99a32e64617d1dfdcf3531c8bf9f52c Author: Dan Smith Date: Mon Jun 19 13:47:51 2023 -0400 latest from CODA-OSS commit 075c9734ca49dd222203be11dbace5a26291b815 Merge: 48d98e7f2 3f01809fa Author: Dan Smith Date: Mon Jun 19 13:47:14 2023 -0400 Merge branch 'main' into develop/sync_externals commit ae3968aaccdb595304a64eab2f747a24ab0e4f61 Author: Dan Smith Date: Tue Jun 13 17:30:25 2023 -0400 Squashed 'externals/coda-oss/' changes from e87c32b4de..f4d42005fa f4d42005fa fix build error in NITRO ff11a5557e keep using std::complex for now (#682) c88b9c0532 types::complex (#681) d1244a0804 don't need our own make_unique in C++14 (#680) aeec0131c5 assert()s for mem::CopyablePtr (#679) 72b0ebd603 add types::complex_short (#678) 932130a580 patch to build other projects c00c1f203d coda-oss release 2023-06-06 (#677) ef54bbcd53 remove more compiler warnings (#676) dadfc5ce62 distinguish between byte-swapping a buffer and single value (#674) 90187f6cd8 more xml.lite tweaks for SIDD-3.0/ISM (#675) eb99607720 stronger type-checking for byteSwap() (#673) ff4f820ed8 xml.lite tweaks to support SIDD 3.0 ISM (#672) b1de8c0e5e std::byte should be a unique type (#671) c05bf9a028 allow enums to be byte-swapped too 1f9fd88d6d remove spurious 47684c45b8 byteSwap now uses byte buffers (#670) cbc659db27 add swapBytes() utility from SIX (#669) 891481b64f simplify byte-swapping (#668) 540ae763e5 more byteSwap() tweaks 0774c03c46 threaded byteSwap() (#667) d156370d36 swapping a single-byte value makes no sense c120e3255d be sure parameter is used to avoid compiler warning e85ec93317 --output-on-failure for CTest (#666) e80376197b turn off "there is no warning number" warning c5f0a5d154 A C-string may not be NULL-terminated (#665) 0c5eb29ae7 use platform-specific routines for byteSwap() (#664) 0b7d581fa6 remove transform_async() (#663) f6489b6bef Merge branch 'main' into feature/xml.lite_tweaks 836c426a2b use function-pointers so that isConsoleOutput is only checked once 56e3c45b1b move depthPrint() functionality into non-member function in preparation for future changes ddcd26d972 Merge branch 'main' into feature/xml.lite_tweaks 69cc0e5063 use the more rigorous create_and_check_datatype() 9efb875584 Merge branch 'main' into feature/hdf5 4d2f2f4173 more HighFive unittests (#662) 14191a844a HighFive::create_datatype() goes from C++ to HighFive 98583473fb utility routines to read string attributes 1fa75ce81e use the C API to read a string attribute 71e7b69f54 still can't figure out how to read a string attribute :-( e96f37a69b test reading the file attributes a25244519c getAttribute() unittest 8f12a3000b getDataType() unittest 857ff0af32 HighFive utility routines (#661) 1d687db57b writeDataSet() utility overload 106aa68945 sigh ... H5Easy::dump() fill fails on Windows/WAF :-( 2641b60b2b Merge branch 'main' into feature/hdf5 35c19e7e81 change actions to @v3 (#660) 212bbd3a36 works on local machine, but not build server ... ? 7125118b09 dump of 1D vector doesn't work :-( c704db4352 sigh ... WAF build still failing :-( 01aae46163 does dump() of a 1D vector work? 76a53c8134 comment-out H5 writing :-( 0f0e19affe test_highfive_dump() cb8f737957 trying to get highfive_dump() unittest working w/Windows-WAF 6584a264af does test_highfive_create() work? cde6147ced tweak HighFive wrappers (#659) 3165668545 Revert "trying HighFive "write" unittests again" a9ec24ca4d trying HighFive "write" unittests again 585ad49a56 tweak names of utility routines 4c91a4d97a make it easier to read a std::vector and std::vecotr 0217ffa26c readDataSet() now works for 1D data 95e8973f29 trying to get hdf5::lite::load() working 4d294611d4 "const" correctness 5e6305c3f7 fix load_complex() 4a134dc5f1 start work on utility routines to read complex data from HDF5 9d76a7f41e Merge branch 'main' into feature/hdf5 8f9667a240 whitepsace ebd3fc99ea Merge branch 'main' into feature/hdf5 40091b069c comment-out writing tests for now ... need to figure our WAF bulid failure 935aa34592 be sure the dataset has real data 114b9bf33c update release notes bd9c0b26c5 tweak HighFive utility routines acda1ef577 turn off diagnostics around expected failures 22a7488402 readDataSet() utility routine for HighFive bd88a8c256 HighFive writeDataSet() utility to work with our SpanRC 6142f5b339 use HighFive routines to write a HDF5 file 5bbf1abaff Use HiveFive routines to get info about the file 84fbc83789 duplicate unittests with H5Easy f1f054c03a Merge branch 'main' into feature/hdf5 9b63ca470c fix directory names f6f826689a fix directory names 7aeb82c336 Merge branch 'main' into feature/hdf5 d028baaebd hook up HighFive header-only library (#653) 3083b0a313 Revert "HighFive 2.6.2" 246985a7f0 Revert ""build" HighFive HDF5 library" a8b75a5865 Revert "turn off HighFive Boost support" ec68d5f830 Revert "Add HighFive unittests" f1f85b9e7f Revert "get test_high_five_base more-or-less compiling" 5ea634ee15 Revert "more work on getting HighFive unittests to build" ecc45433c7 more work on getting HighFive unittests to build bb194788ab get test_high_five_base more-or-less compiling d42bde0004 Add HighFive unittests ddc86bb328 turn off HighFive Boost support b255122d4f "build" HighFive HDF5 library 396cc3ef2a HighFive 2.6.2 5e5f9d9c0f Merge branch 'main' into feature/hdf5 ee938b4a52 changes from SIX bb764df90b Merge branch 'main' into feature/xml.lite_tweaks de2a243800 make derived classes 'final' if possible 14e19bcd21 Change xml lite function to virtual (#645) 8f42ac8e9e Merge branch 'main' into feature/xml.lite_tweaks 18ad90645f hdf5Write unittest 3462e11792 createFile() and writeFile() overloads ecee81d532 fix typos 197eecfa62 sketch-out hdf5::lite::writeFile() bd2311795e use SpanRC for writeFile(), not yet implemented ea9af75109 simple SpanRC to hold a 2D-size and pointer 027c19ee8a createFile() unittest 1f9d07ecbc hook up createFile() 8c7e4473f0 start hooking up HDF5 writing 146e0bea3b Merge branch 'main' into feature/hdf5 88ca9fcb7f Merge branch 'main' into feature/hdf5 42b604b463 Squashed commit of the following: 10ee602c25 Merge branch 'main' into feature/hdf5 67aa42b69d restore changes from "main" 8bbfcbfbfe unittests can be simplified to match fewer "view" classes 126bb802ea Merge branch 'main' into feature/hdf5 3f8ba7a423 again, don't need a class just to convert from std::vector<> to std::span<> 24c2b489c8 Squashed commit of the following: 2703c119d4 Squashed commit of the following: 9d5228a2be don't need an entire class just to convert a std::vector<> into std::span<> 51bc931dcd Merge branch 'main' into feature/hdf5 a84f258160 Squashed commit of the following: c4d2ed696e add missing #include guards, fix type in existing #include guard d541525a01 use a single ComplexViewConstIterator for all views 86e6a459fe CODA_OSS_disable_warning causes GCC errors :-( 5d4b9c2cb6 only need an custom iterator for ComplexSpansView d9f0fb1286 hook up iterators b9329e4db0 initial pass at a ComplexViewConstIterator 6352388739 remove compiler warning about unused "constexpr" variables b39f6096fb use the casing from H5 to make copy/pasting code slightly easier 0887b13eb4 Merge branch 'main' into feature/hdf5 bd07df1cae Consistent casing for Dataset, Datatype, Dataspace 7acd30ee23 tweak hdf5.lite dependencies 38ab914dfd Jupyter notebook for creating H5 files 95a040e0bf _small.h5 is now (correctly) FLOAT32 107e7c4876 make a simple values() member function to avoid template magic e1feca9194 use TEST_SPECIFIC_EXCEPTION macro instead of try/catch 7383336888 readDatasetT() now throws for the wrong buffer type 6b2cc25294 Merge branch 'feature/hdf5' of github.com:mdaus/coda-oss into feature/hdf5 310f8fd3d5 can't get template magic right for copy_axis() 86b306d596 stepping through copy ctors in the debugger is annoying f243e92d68 trying to make wrong type of buffer fail 2b10d96529 read in new sample file a28e59d8c5 help the compiler with type deduction 49bf5e9bc2 nested_complex_float_data_small.h5 e029325fc0 utility routines to "deconstruct" and array of std::complex dede3bd393 Merge branch 'main' into feature/hdf5 904b1ef5ec tweak class names, make_() and copy() utility routines 8237b9efbf make it harder to pass the wrong types to ComplexViews 4d9aeda2cd ComplexArrayView and ComplexParallelView utility classes f5e367dfa6 test std::span> a4a2844f26 read in the nested "i" and "r" data 1156152650 sample file has subgroups 8e1b7869aa Merge branch 'feature/hdf5' of github.com:mdaus/coda-oss into feature/hdf5 9f4232a1dd update sample H5 file 8c55db73ae walk through HDF5 sub-groups 7775ed9c43 Update 123_barfoo_catdog_cx.h5 677975d7ca Matlab code to create sample H5 file a0e7dfe07b Update test_hdf5info.cpp 0b67e1602f pass __FILE__ and __LINE__ from calling site for a more accurate exception message 86a6773213 skeleton for more sample data 85f79b0999 Merge branch 'main' into feature/hdf5 18088e9421 Merge branch 'main' into feature/hdf5 3a1d17692f Merge branch 'main' into feature/hdf5 1755c69d70 Merge branch 'main' into feature/hdf5 9ad015432d No more "11" suffix on exception names c20d962511 Squashed commit of the following: c88cee999b other values to be filled-in bca4a4ecd8 incorporation NamedObject from HDF5 docs 61fa68f72e groupInfo() 460e7d7665 datasetInfo() 14eb9b764b start filling in DatasetInfo afe5f1c3a0 start to fill in DatasetInfo 77a968c72d start filling in GroupInfo d81bcdfd92 openGroup() to open groups (loc) a0cd294697 comment-out "dataset" unittest for now 86e0060245 begin filling in FileInfo 366dda6ab6 a return_type_of utility is needed to deduce the return type e219282638 explicitly pass return type to template 4937ccd11d template to reduce boilerplate when calling try_catch_H5Exceptions b3b5ebde78 use new exception utility routines ea1c03ef0c put exception handling/conversion in a utility routine 819a99d397 utility routine for exception handling 6f34eea979 put utilities in a separate file for easier reuse fcbde4f241 break utility routines into smaller pieces for easier reuse 52358ea8a9 WIN32 no longer automatically defined? 5a42864722 Revert "build HDF5 with C89" 680e599e9d build HDF5 with C89 a87a071218 Merge branch 'main' into feature/hdf5 8447c1a900 Revert "sym-links instead of copying files" db3b5e12b4 Merge branch 'main' into feature/xml.lite_tweaks fb60b5696f Merge branch 'main' into feature/hdf5 5110a5cc81 Comments about _u and _q 1a937d32cf Merge branch 'main' into feature/xml.lite_tweaks fa06f04d7e get ready for hdf5.lite enhancdements b040c7c437 sym-links instead of copying files aa431bb477 use _u for xml::lite::Uri 3d0c6d58ce fix case-sensitive #include filename 93dcd0e527 operator() for getElementByName() 75a93af859 more operator[] overloads to make attribute management easier 4ab8216f87 user-defined string literals to remove some noise around xml::lite::QName f82f0b0fc6 Merge branch 'main' into feature/xml.lite_tweaks ae30e36443 Merge branch 'feature/xml.lite_tweaks' of github.com:mdaus/coda-oss into feature/xml.lite_tweaks ffdd9beb0b simplify attribute creation 9bf5414f5d simplify attribute creation 82d7a4e959 SWIG gets confused about namespaces 7a61d0741f fix bug on Element ctor uncovered by unittest fdd7e58c1a QName is also in the xerces namespace which confuses SWIG bindings a325b7053b operator+=() overload for addChild daf30e6c0e Merge branch 'feature/xml.lite_tweaks' of github.com:mdaus/coda-oss into feature/xml.lite_tweaks b887d2b476 provide overloads for Element& rather than creating new "reference" types 1fa6bba388 rename test_xmleasy.cpp 7c8c9e0f1c += overload 850da6f63d overload for std::string 4547fc5a75 use UIT-8 strings for characterData 4723462a3b convenient addChild() overloads e48720753a copy over ElementReference from xml.easy a4ca30a0d6 Merge branch 'main' into feature/xml.lite_tweaks 6ae9f0b715 Revert "check-in of new xml.easy (to move code between computers)" f7466a6d75 Revert "simple routines for single element" a5490230d6 Revert "make some operators simplier ways of calling functions" c9a25630a6 Revert "get document creation working" 8af8710b05 Revert "free functions instead of member functions" 16c3847cb2 Revert "ElementReference distinct from Element" 7d68e156ff Revert "ElementMutableReference" 00eb2a2826 Merge branch 'main' into feature/xml.lite_tweaks a42969c1f4 ElementMutableReference a20ae9355e ElementReference distinct from Element 14eeeea0b5 free functions instead of member functions 4aae014b39 get document creation working 8835692699 make some operators simplier ways of calling functions 053bd1212a simple routines for single element 8bf701a2ea check-in of new xml.easy (to move code between computers) 41f959051c unittests for creating XML documents from scratch 9752d50ae2 Merge branch 'main' into feature/xml.lite_tweaks 1531d57095 by default, don't validate strings passed to Uri() 46d13d4bf7 Merge branch 'master' into feature/xml.lite_tweaks 39b547d321 remove more vestiges of Expat and LibXML ec8274d524 remove LibXML and Expat as they're no longer used/supported. 20eeefeef6 Merge branch 'master' into feature/xml.lite_tweaks 95074b9b1a update for newer Intel compiler 7024f71e1b Merge branch 'master' into feature/xml.lite_tweaks 57b1cbc83d Merge branch 'master' into feature/xml.lite_tweaks 4b67561c3d remove validate() overload that nobody is using fa15f1e5dc Squashed commit of the following: 1484a90909 test the new validate() API 470da70fb8 hookup StringStreamT routines 2cddf25047 begin hooking up validate() overloads 1b5d910f38 overload validate() for UTF-8 and Windows-1252 03309b8c9f Squashed commit of the following: b72c6c5bf2 older compiler doesn't like our make_unique af8f00307f validate UTF-8 XML on Linux 211188613e unit-test for LEGACY XML validation 3c1169d2b5 Squashed commit of the following: 3afff19cad std::filesystem::path for FileInputStreamOS 908d452f8f WIP: validate all of our sample XML files 00f9bb16bc validate against a XML schema 243d8c356c Merge branch 'master' into feature/xml.lite_tweaks 2815d707d9 fix to work with SWIG bindings. :-( 4608621326 trying (again) to remove vestiages of old code e3c83a8587 Revert "new code should use UTF-8" 811207c920 new code should use UTF-8 0ffd835f96 Squashed commit of the following: 1e7e03ded0 Merge branch 'master' into feature/xml.lite_tweaks c1d806affa Merge branch 'master' into feature/xml.lite_tweaks 850d3c811d str::strip() that can be easier to use than str::trim() 580ba9c8c3 explicitly =delete move 2b39831a80 Squashed commit of the following: 39eebdc23f Merge branch 'master' into feature/xml.lite_tweaks 9adf86cbaf force calling new UTF-8 write() routines ea61b62045 Merge branch 'master' into feature/xml.lite_tweaks 8a34583fa0 overload to take schemaPaths as filesystem::path 8671b442f7 parse XML embedded in a binary file ec4a902f14 updates from xerces.lite 80dc4d9635 updates from xerces.lite 549766d6c1 Attributes::contains() no longer catches an exception 8a645ceac3 need "sys/" when building in other environments 36af082690 super-simple URI validation 78ef28a3e2 SWIG bindings are a PITA! :-( e9cba8491e SWIG needs help with Uri 8a8d8dc072 another routines used by pre-build SWIG bindings 818e1ec5d3 pre-build SWIG bindings use getElementByTagName() member function 067cac5d85 old compiler gets confused on unadorned QName ba92c0ae7e more use of Uri and QName 446c7d17a7 use QName in new code d6f8b0c836 more direct use of QName 90fff1c737 use xml::lite::QName instead of tuple 646cbb5ed4 more direct use of QName and Uri ba589ea3b3 make QName more robust bab0ee8b5e createElement() -> addNewElement() e3a145747a grab changes from six-library 32285e95c4 Merge branch 'master' into feature/xml.lite_tweaks 9f79f0bf62 Merge branch 'master' into feature/xml.lite_tweaks a12bbc32c6 make it easier to create new Elements with a value fc9967f986 make it easy for callers to addChild() keep a reference to the Element 4627766b7d be sure test_xmlparser works in "externals" of other projects bf22763961 "private" is part of the name-mangling fad92bcc8f making sure copy-ctor is implemented f90fdcead0 consolidate common XML test code 9fc53f2d51 use str:: utility for casting 6da6f794bb still trying to find the right macro for SWIG 0c1b86c566 still trying to fix SWIG fdc6fc9bd6 trying to fix SWIG build error 7835e8c270 SWIG needs copy-ctor 585695942d disable copy/assignment for Element, it's probably almost always wrong 391fed6135 fix double-delete caused by copying 61790fe695 retry parsing XML with Windows-1252 if first parse() fails 63cffac59e change string_encoding to match coda-oss style of PascalCase 010479bbec read an XML file we know is wrongly encoded as Windows-1252 9a05050621 more references instead of pointers 2d44b69519 Reading Windows-1252 w/o "encoding" fails 63dc7b0762 read Windows-1252 too c9434c9cbe test as UIT-8 too f310ccf0cf get reading from UTF-8 XML working on Windows 1fa39c2be0 get testReadUtf8XmlFile working on Linux 1a83cd8157 sys::Path is too much trouble right now ed60aa22c9 unit-test to read XML from a file a9336db7c6 Squashed commit of the following: 0825beb0d3 Merge branch 'master' into feature/xml.lite_tweaks c618489be7 Merge branch 'master' into feature/xml.lite_tweaks e8e4b8fe1d determine string_encoding based on platform 1f43bcfc26 create a new Element by using the platform to determine "characterData" encoding 961bef66b4 Merge branch 'master' into feature/xml.lite_tweaks e9798a5cba fix static_assert() 6f77728748 Merge branch 'master' into feature/xml.lite_tweaks b98d4f5a91 Merge branch 'master' into feature/xml.lite_tweaks 1b5abba2a6 The (old) version of SWIG we're using doesn't like certain C++11 features. 53bdeabaf7 Merge branch 'master' into feature/xml.lite_tweaks 60cf8ae80f "" doesn't work with decltype() in older C++ 97e72477a5 reduce getValue() overloads by making "key" a template argument 5e6373e557 reduce code duplication f9e7cfeee5 provide castValue instead of getValue(T&) cbd0bd8f24 castValue throws instead of returning a bool like getValue(T&) 87c7514fce Merge branch 'master' into feature/xml.lite_tweaks 10cc61223a make getElement*() consistent for zero or >1 results f5b137e3cd Merge branch 'master' into feature/xml.lite_tweaks 1765efc622 allow clients to specify toType() and toString() for getValue() and setValue() df8b746e12 allow clients to specify their own toType/toString routines 66702726ad Merge branch 'master' into feature/xml.lite_tweaks 6956311f14 Merge branch 'master' into feature/xml.lite_tweaks d505f3593a Merge branch 'master' into feature/xml.lite_tweaks fbd106115f catch a BadCastException and return false from getValue() 3a78377b55 use a template to reduce duplicated code 0ad4b86062 Merge branch 'master' into feature/xml.lite_tweaks a848aa3a20 get & set the characer data as a type f3ee1ee12a utility routines to set an attribute value 5952276839 templates to get an attribute value convert to a specific type 06639227b3 miised a change in last commit 1aa458ef8b add getValue() overloads that return true/false rather than throwing faa6d30752 added getElementByTagName() overloads as that's a very common use-case git-subtree-dir: externals/coda-oss git-subtree-split: f4d42005fa477ae59da193422aa2cb14b877cf0c commit 48d98e7f27e987ebfbc7e1b892c18f6377b49fab Merge: 18be3582a ae3968aac Author: Dan Smith Date: Tue Jun 13 17:30:25 2023 -0400 Merge commit 'ae3968aaccdb595304a64eab2f747a24ab0e4f61' into develop/sync_externals commit 18be3582a913519ac9b1e77074beb0c988a618c8 Author: Dan Smith Date: Tue Jun 13 17:30:21 2023 -0400 latest from coda-oss --- externals/coda-oss/ReleaseNotes.md | 10 +++--- .../coda-oss/modules/c++/coda-oss.vcxproj | 8 ++--- .../modules/c++/sys/source/FileFinder.cpp | 33 ++++++++++--------- 3 files changed, 27 insertions(+), 24 deletions(-) diff --git a/externals/coda-oss/ReleaseNotes.md b/externals/coda-oss/ReleaseNotes.md index bf8f97f3a..c54bdadcb 100644 --- a/externals/coda-oss/ReleaseNotes.md +++ b/externals/coda-oss/ReleaseNotes.md @@ -18,16 +18,16 @@ * wrap common "file open" routines (e.g., `fopen()`) to support `sys::expandEnvironmentVariables()`. * add header-only [HighFive](https://github.com/BlueBrain/HighFive) HDF5-wrapper library. * Added a handful of [HighFive](https://github.com/BlueBrain/HighFive) utility routines. -* `mt::transform_async()` removed, it doesn't match C++17 techniques.' +* `mt::transform_async()` removed, it doesn't match C++17 techniques. * Revamp `sys::byteSwap()` for improved type-safety and [better performance](https://devblogs.microsoft.com/cppblog/a-tour-of-4-msvc-backend-improvements/). - * Added case-insensitive string comparison utilties: `str::eq()` and `str::ne()`; + * Added case-insensitive string comparison utilities: `str::eq()` and `str::ne()`; `xml::lite::Uri`s compare case-insensitive. ## [Release 2022-12-14](https://github.com/mdaus/coda-oss/releases/tag/2022-12-14) * removed remaining vestiges of `std::auto_ptr`, provide `mem::AutoPtr` for the tiny handful of places (e.g., SWIG bindings) that still need copying. -* `xml::lite::Element` overloads to make creting new XML documents easier; see unittests for examples. +* `xml::lite::Element` overloads to make creating new XML documents easier; see unittests for examples. * try even harder to find unittest files in various scenarios. * build *hdf5.lite* with **waf**. * New `--optz=fastest-possible` (**waf** only) which adds @@ -40,8 +40,8 @@ * The [HDFGroup](https://hdfgroup.org/)s [HDF5 library](https://github.com/HDFGroup/hdf5) is built and installed; a simple (and very incomplete!) wrapper is provided, this is at the "hello world!" stage. * A few **cli** routines have been tweaked to make unit-testing easier. -* Utilitiy routines for finding various files when unit-testing. -* Removed C++14 work-arounds needed in C++11. Legacy C++ exception specificatons removed. +* Utility routines for finding various files when unit-testing. +* Removed C++14 work-arounds needed in C++11. Legacy C++ exception specifications removed. * Rebuild `waf` for FIPS error; added more debug options. ## [Release 2022-08-30](https://github.com/mdaus/coda-oss/releases/tag/2022-08-30) diff --git a/externals/coda-oss/modules/c++/coda-oss.vcxproj b/externals/coda-oss/modules/c++/coda-oss.vcxproj index 62647fd77..e2cf91bf5 100644 --- a/externals/coda-oss/modules/c++/coda-oss.vcxproj +++ b/externals/coda-oss/modules/c++/coda-oss.vcxproj @@ -580,7 +580,7 @@ true _DEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL;MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 pch.h - cli\include;coda_oss\include;config\include;dbi\include;except\include;gsl\include;hdf5.lite\include;io\include;logging\include;math\include;math.linear\include;math.poly\include;mem\include;mt\include;net\include;net.ssl\include;plugin\include;polygon\include;re\include;sio.lite\include;std\include;str\include;sys\include;tiff\include;types\include;unique\include;units\include;xml.lite\include;zip\include;$(ProjectDir)include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;$(SolutionDir)externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\include + cli\include;coda_oss\include;config\include;dbi\include;except\include;gsl\include;hdf5.lite\include;io\include;logging\include;math\include;math.linear\include;math.poly\include;mem\include;mt\include;net\include;net.ssl\include;plugin\include;polygon\include;re\include;sio.lite\include;std\include;str\include;sys\include;tiff\include;types\include;unique\include;units\include;xml.lite\include;zip\include;$(ProjectDir)include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include Use pch.h true @@ -598,7 +598,7 @@ true - $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib;$(SolutionDir)externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\lib + $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\ rpcrt4.lib;%(AdditionalDependencies) @@ -610,7 +610,7 @@ true NDEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL;MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 pch.h - cli\include;coda_oss\include;config\include;dbi\include;except\include;gsl\include;hdf5.lite\include;io\include;logging\include;math\include;math.linear\include;math.poly\include;mem\include;mt\include;net\include;net.ssl\include;plugin\include;polygon\include;re\include;sio.lite\include;std\include;str\include;sys\include;tiff\include;types\include;unique\include;units\include;xml.lite\include;zip\include;$(ProjectDir)include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;$(SolutionDir)externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\include + cli\include;coda_oss\include;config\include;dbi\include;except\include;gsl\include;hdf5.lite\include;io\include;logging\include;math\include;math.linear\include;math.poly\include;mem\include;mt\include;net\include;net.ssl\include;plugin\include;polygon\include;re\include;sio.lite\include;std\include;str\include;sys\include;tiff\include;types\include;unique\include;units\include;xml.lite\include;zip\include;$(ProjectDir)include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include Use pch.h true @@ -627,7 +627,7 @@ true true true - $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib;$(SolutionDir)externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\lib + $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\ rpcrt4.lib;%(AdditionalDependencies) diff --git a/externals/coda-oss/modules/c++/sys/source/FileFinder.cpp b/externals/coda-oss/modules/c++/sys/source/FileFinder.cpp index f9cf747f2..b33cc47c4 100644 --- a/externals/coda-oss/modules/c++/sys/source/FileFinder.cpp +++ b/externals/coda-oss/modules/c++/sys/source/FileFinder.cpp @@ -208,6 +208,17 @@ std::vector sys::FileFinder::search( return files; } +static fs::path parent_path(const fs::path& p) +{ + // If the parent_path() is the same, we've reached to root. + const auto retval = p.parent_path(); + if (retval.empty() || (retval == p)) + { + throw std::runtime_error("At root of filesystem: " + p.string()); + } + return retval; +} + static fs::path findFirst(const sys::FilePredicate& pred, const fs::path& startingDirectory) { auto dir = startingDirectory; @@ -228,7 +239,8 @@ static fs::path findFirst(const sys::FilePredicate& pred, const fs::path& starti { throw std::logic_error("Won't traverse above .git directory at: " + dir.string()); } - dir = dir.parent_path(); + + dir = parent_path(dir); } } fs::path sys::findFirstFile(const fs::path& startingDirectory, const fs::path& filename) @@ -297,11 +309,7 @@ fs::path sys::test::findRootDirectory(const fs::path& p, const std::string& root // Once we're at a .git directory, we have to go down, not up ... or fail. if (!is_directory(p / ".git")) { - const auto parent_path = p.parent_path(); - if (p != parent_path) - { - return findRootDirectory(parent_path, rootName, isRoot); - } + return findRootDirectory(parent_path(p), rootName, isRoot); } // TODO: since we're in the "FileFinder" module, maybe try a bit harder to find "rootName"? @@ -320,7 +328,7 @@ static inline std::string Platform() static fs::path findCMakeRoot(const fs::path& path, const fs::path& dir) { - static const auto platform_and_configuration = ::Platform() + "-" + ::Configuration(); // "x64-Debug" + static const auto platform_and_configuration = ::Platform() + "-" + ::Configuration(); // "x64-Debug" const auto pred = [&](const fs::path& p) { if (p.filename() == platform_and_configuration) @@ -342,7 +350,7 @@ static fs::path findCMakeRoot(const fs::path& path, const fs::path& dir) return false; }; - return sys::test::findRootDirectory(path, "", pred); + return sys::test::findRootDirectory(path, "", pred); } fs::path findCMake_Root(const fs::path& path, @@ -408,13 +416,8 @@ static fs::path find_dotGITDirectory_(const fs::path& p, const fs::path& initial { return p; } - - auto parent = p.parent_path(); - if (parent.empty()) - { - throw std::invalid_argument("Can't find .git/ anywhere in: " + initial.string()); - } - return find_dotGITDirectory_(parent, initial); + + return find_dotGITDirectory_(parent_path(p), initial); } fs::path sys::test::find_dotGITDirectory(const fs::path& p) { From 84746e023aaf25cb954d0f78a2b7b65afa08701d Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Fri, 14 Jul 2023 10:25:04 -0400 Subject: [PATCH 079/104] consistent settings for VCXPROJ files --- UnitTest/UnitTest.vcxproj | 5 +++++ externals/coda-oss/modules/c++/coda-oss.vcxproj | 9 +++++---- modules/c++/nitf-c++.vcxproj | 4 ++-- modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj | 2 +- modules/c/j2k/J2KCompress.vcxproj | 2 +- modules/c/j2k/J2KDecompress.vcxproj | 2 +- modules/c/nitf-c.vcxproj | 4 ++-- modules/c/nitf/ACCHZB.vcxproj | 2 +- modules/c/nitf/ACCPOB.vcxproj | 2 +- modules/c/nitf/ACFTA.vcxproj | 2 +- modules/c/nitf/AIMIDB.vcxproj | 2 +- modules/c/nitf/CSCRNA.vcxproj | 2 +- modules/c/nitf/CSEXRB.vcxproj | 2 +- modules/c/nitf/ENGRDA.vcxproj | 2 +- modules/c/nitf/HISTOA.vcxproj | 2 +- modules/c/nitf/JITCID.vcxproj | 2 +- modules/c/nitf/PTPRAA.vcxproj | 2 +- modules/c/nitf/RPFHDR.vcxproj | 2 +- modules/c/nitf/XML_DATA_CONTENT.vcxproj | 2 +- 19 files changed, 29 insertions(+), 23 deletions(-) diff --git a/UnitTest/UnitTest.vcxproj b/UnitTest/UnitTest.vcxproj index d678b7a87..6d48684c2 100644 --- a/UnitTest/UnitTest.vcxproj +++ b/UnitTest/UnitTest.vcxproj @@ -62,6 +62,9 @@ true pch.h AdvancedVectorExtensions2 + MultiThreadedDebugDLL + true + true Windows @@ -80,6 +83,8 @@ true pch.h AdvancedVectorExtensions2 + Guard + true Windows diff --git a/externals/coda-oss/modules/c++/coda-oss.vcxproj b/externals/coda-oss/modules/c++/coda-oss.vcxproj index e2cf91bf5..cd7468965 100644 --- a/externals/coda-oss/modules/c++/coda-oss.vcxproj +++ b/externals/coda-oss/modules/c++/coda-oss.vcxproj @@ -580,7 +580,7 @@ true _DEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL;MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 pch.h - cli\include;coda_oss\include;config\include;dbi\include;except\include;gsl\include;hdf5.lite\include;io\include;logging\include;math\include;math.linear\include;math.poly\include;mem\include;mt\include;net\include;net.ssl\include;plugin\include;polygon\include;re\include;sio.lite\include;std\include;str\include;sys\include;tiff\include;types\include;unique\include;units\include;xml.lite\include;zip\include;$(ProjectDir)include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include + cli\include;coda_oss\include;config\include;dbi\include;except\include;gsl\include;hdf5.lite\include;io\include;logging\include;math\include;math.linear\include;math.poly\include;mem\include;mt\include;net\include;net.ssl\include;plugin\include;polygon\include;re\include;sio.lite\include;std\include;str\include;sys\include;tiff\include;types\include;unique\include;units\include;xml.lite\include;zip\include;$(ProjectDir)include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;$(SolutionDir)externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\include Use pch.h true @@ -592,13 +592,14 @@ /Zc:__cplusplus %(AdditionalOptions) true AdvancedVectorExtensions2 + MultiThreadedDebugDLL true true - $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\ + $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib;$(SolutionDir)\externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\lib rpcrt4.lib;%(AdditionalDependencies) @@ -610,7 +611,7 @@ true NDEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL;MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 pch.h - cli\include;coda_oss\include;config\include;dbi\include;except\include;gsl\include;hdf5.lite\include;io\include;logging\include;math\include;math.linear\include;math.poly\include;mem\include;mt\include;net\include;net.ssl\include;plugin\include;polygon\include;re\include;sio.lite\include;std\include;str\include;sys\include;tiff\include;types\include;unique\include;units\include;xml.lite\include;zip\include;$(ProjectDir)include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include + cli\include;coda_oss\include;config\include;dbi\include;except\include;gsl\include;hdf5.lite\include;io\include;logging\include;math\include;math.linear\include;math.poly\include;mem\include;mt\include;net\include;net.ssl\include;plugin\include;polygon\include;re\include;sio.lite\include;std\include;str\include;sys\include;tiff\include;types\include;unique\include;units\include;xml.lite\include;zip\include;$(ProjectDir)include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;$(SolutionDir)externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\include Use pch.h true @@ -627,7 +628,7 @@ true true true - $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\ + $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib;$(SolutionDir)\externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\lib rpcrt4.lib;%(AdditionalDependencies) diff --git a/modules/c++/nitf-c++.vcxproj b/modules/c++/nitf-c++.vcxproj index a68c9f67f..f7fecd2d7 100644 --- a/modules/c++/nitf-c++.vcxproj +++ b/modules/c++/nitf-c++.vcxproj @@ -229,10 +229,10 @@ true EnableFastChecks Disabled - true - MultiThreadedDebugDLL true AdvancedVectorExtensions2 + MultiThreadedDebugDLL + true diff --git a/modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj b/modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj index 233b05d16..ccd635b60 100644 --- a/modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj +++ b/modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj @@ -61,10 +61,10 @@ true EnableFastChecks Disabled - true MultiThreadedDebugDLL true AdvancedVectorExtensions2 + true Console diff --git a/modules/c/j2k/J2KCompress.vcxproj b/modules/c/j2k/J2KCompress.vcxproj index 80e6ea531..bb15eb149 100644 --- a/modules/c/j2k/J2KCompress.vcxproj +++ b/modules/c/j2k/J2KCompress.vcxproj @@ -70,12 +70,12 @@ /FS %(AdditionalOptions) true CompileAsCpp - true Guard MultiThreadedDebugDLL true ProgramDatabase AdvancedVectorExtensions2 + true diff --git a/modules/c/j2k/J2KDecompress.vcxproj b/modules/c/j2k/J2KDecompress.vcxproj index 2010203c4..1c1a018e3 100644 --- a/modules/c/j2k/J2KDecompress.vcxproj +++ b/modules/c/j2k/J2KDecompress.vcxproj @@ -70,12 +70,12 @@ /FS %(AdditionalOptions) true CompileAsCpp - true Guard MultiThreadedDebugDLL true ProgramDatabase AdvancedVectorExtensions2 + true diff --git a/modules/c/nitf-c.vcxproj b/modules/c/nitf-c.vcxproj index bacf43fcc..92546ed88 100644 --- a/modules/c/nitf-c.vcxproj +++ b/modules/c/nitf-c.vcxproj @@ -62,12 +62,12 @@ true EnableFastChecks Disabled - MultiThreadedDebugDLL true - true AdvancedVectorExtensions2 CompileAsCpp false + MultiThreadedDebugDLL + true diff --git a/modules/c/nitf/ACCHZB.vcxproj b/modules/c/nitf/ACCHZB.vcxproj index cf18d2390..663aef4ba 100644 --- a/modules/c/nitf/ACCHZB.vcxproj +++ b/modules/c/nitf/ACCHZB.vcxproj @@ -69,13 +69,13 @@ $(ProjectDir)include;$(ProjectDir)..\nrt\include;%(AdditionalIncludeDirectories) /FS %(AdditionalOptions) true - true CompileAsCpp Guard MultiThreadedDebugDLL true ProgramDatabase AdvancedVectorExtensions2 + true diff --git a/modules/c/nitf/ACCPOB.vcxproj b/modules/c/nitf/ACCPOB.vcxproj index 20212f3d2..e8a899d7a 100644 --- a/modules/c/nitf/ACCPOB.vcxproj +++ b/modules/c/nitf/ACCPOB.vcxproj @@ -69,13 +69,13 @@ $(ProjectDir)include;$(ProjectDir)..\nrt\include;%(AdditionalIncludeDirectories) /FS %(AdditionalOptions) true - true CompileAsCpp Guard MultiThreadedDebugDLL true ProgramDatabase AdvancedVectorExtensions2 + true diff --git a/modules/c/nitf/ACFTA.vcxproj b/modules/c/nitf/ACFTA.vcxproj index 05e79a2de..e89489e7f 100644 --- a/modules/c/nitf/ACFTA.vcxproj +++ b/modules/c/nitf/ACFTA.vcxproj @@ -69,13 +69,13 @@ $(ProjectDir)include;$(ProjectDir)..\nrt\include;%(AdditionalIncludeDirectories) /FS %(AdditionalOptions) true - true CompileAsCpp Guard MultiThreadedDebugDLL true ProgramDatabase AdvancedVectorExtensions2 + true diff --git a/modules/c/nitf/AIMIDB.vcxproj b/modules/c/nitf/AIMIDB.vcxproj index 0f70aa7c9..830685508 100644 --- a/modules/c/nitf/AIMIDB.vcxproj +++ b/modules/c/nitf/AIMIDB.vcxproj @@ -69,13 +69,13 @@ $(ProjectDir)include;$(ProjectDir)..\nrt\include;%(AdditionalIncludeDirectories) /FS %(AdditionalOptions) true - true CompileAsCpp Guard MultiThreadedDebugDLL true ProgramDatabase AdvancedVectorExtensions2 + true diff --git a/modules/c/nitf/CSCRNA.vcxproj b/modules/c/nitf/CSCRNA.vcxproj index c737b6b4b..bd97ece2a 100644 --- a/modules/c/nitf/CSCRNA.vcxproj +++ b/modules/c/nitf/CSCRNA.vcxproj @@ -69,13 +69,13 @@ $(ProjectDir)include;$(ProjectDir)..\nrt\include;%(AdditionalIncludeDirectories) /FS %(AdditionalOptions) true - true CompileAsCpp Guard MultiThreadedDebugDLL true ProgramDatabase AdvancedVectorExtensions2 + true diff --git a/modules/c/nitf/CSEXRB.vcxproj b/modules/c/nitf/CSEXRB.vcxproj index 9712bafcd..add865a7c 100644 --- a/modules/c/nitf/CSEXRB.vcxproj +++ b/modules/c/nitf/CSEXRB.vcxproj @@ -69,13 +69,13 @@ $(ProjectDir)include;$(ProjectDir)..\nrt\include;%(AdditionalIncludeDirectories) /FS %(AdditionalOptions) true - true CompileAsCpp Guard MultiThreadedDebugDLL true ProgramDatabase AdvancedVectorExtensions2 + true diff --git a/modules/c/nitf/ENGRDA.vcxproj b/modules/c/nitf/ENGRDA.vcxproj index aaa867344..3e28f89e6 100644 --- a/modules/c/nitf/ENGRDA.vcxproj +++ b/modules/c/nitf/ENGRDA.vcxproj @@ -69,13 +69,13 @@ $(ProjectDir)include;$(ProjectDir)..\nrt\include;%(AdditionalIncludeDirectories) /FS %(AdditionalOptions) true - true CompileAsCpp Guard MultiThreadedDebugDLL true ProgramDatabase AdvancedVectorExtensions2 + true diff --git a/modules/c/nitf/HISTOA.vcxproj b/modules/c/nitf/HISTOA.vcxproj index f186bc6c9..07c71effd 100644 --- a/modules/c/nitf/HISTOA.vcxproj +++ b/modules/c/nitf/HISTOA.vcxproj @@ -69,13 +69,13 @@ $(ProjectDir)include;$(ProjectDir)..\nrt\include;%(AdditionalIncludeDirectories) /FS %(AdditionalOptions) true - true CompileAsCpp Guard MultiThreadedDebugDLL true ProgramDatabase AdvancedVectorExtensions2 + true diff --git a/modules/c/nitf/JITCID.vcxproj b/modules/c/nitf/JITCID.vcxproj index 37b29b98e..9c0d3aedb 100644 --- a/modules/c/nitf/JITCID.vcxproj +++ b/modules/c/nitf/JITCID.vcxproj @@ -69,13 +69,13 @@ $(ProjectDir)include;$(ProjectDir)..\nrt\include;%(AdditionalIncludeDirectories) /FS %(AdditionalOptions) true - true CompileAsCpp Guard MultiThreadedDebugDLL true ProgramDatabase AdvancedVectorExtensions2 + true diff --git a/modules/c/nitf/PTPRAA.vcxproj b/modules/c/nitf/PTPRAA.vcxproj index d0a975671..860ddfeda 100644 --- a/modules/c/nitf/PTPRAA.vcxproj +++ b/modules/c/nitf/PTPRAA.vcxproj @@ -69,13 +69,13 @@ $(ProjectDir)include;$(ProjectDir)..\nrt\include;%(AdditionalIncludeDirectories) /FS %(AdditionalOptions) true - true CompileAsCpp Guard MultiThreadedDebugDLL true ProgramDatabase AdvancedVectorExtensions2 + true diff --git a/modules/c/nitf/RPFHDR.vcxproj b/modules/c/nitf/RPFHDR.vcxproj index a2858247e..2618b6539 100644 --- a/modules/c/nitf/RPFHDR.vcxproj +++ b/modules/c/nitf/RPFHDR.vcxproj @@ -69,13 +69,13 @@ $(ProjectDir)include;$(ProjectDir)..\nrt\include;%(AdditionalIncludeDirectories) /FS %(AdditionalOptions) true - true CompileAsCpp Guard MultiThreadedDebugDLL true ProgramDatabase AdvancedVectorExtensions2 + true diff --git a/modules/c/nitf/XML_DATA_CONTENT.vcxproj b/modules/c/nitf/XML_DATA_CONTENT.vcxproj index a243a545b..5edafec9e 100644 --- a/modules/c/nitf/XML_DATA_CONTENT.vcxproj +++ b/modules/c/nitf/XML_DATA_CONTENT.vcxproj @@ -69,13 +69,13 @@ $(ProjectDir)include;$(ProjectDir)..\nrt\include;%(AdditionalIncludeDirectories) /FS %(AdditionalOptions) true - true CompileAsCpp Guard MultiThreadedDebugDLL true ProgramDatabase AdvancedVectorExtensions2 + true From a39a30edba036a3eb82aba2e13888a737edabb86 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Mon, 17 Jul 2023 10:22:46 -0400 Subject: [PATCH 080/104] consistent project settings --- UnitTest/UnitTest.vcxproj | 6 +++ modules/c++/nitf-c++.vcxproj | 4 +- .../nitf/apps/show_nitf++/show_nitf++.vcxproj | 2 + modules/c/nitf-c.vcxproj | 4 +- modules/c/nitf/XML_DATA_CONTENT.vcxproj | 4 +- modules/c/pch.h | 37 +++++++++++++------ 6 files changed, 43 insertions(+), 14 deletions(-) diff --git a/UnitTest/UnitTest.vcxproj b/UnitTest/UnitTest.vcxproj index 6d48684c2..bef5b5d13 100644 --- a/UnitTest/UnitTest.vcxproj +++ b/UnitTest/UnitTest.vcxproj @@ -65,6 +65,9 @@ MultiThreadedDebugDLL true true + true + true + true Windows @@ -85,6 +88,9 @@ AdvancedVectorExtensions2 Guard true + true + true + true Windows diff --git a/modules/c++/nitf-c++.vcxproj b/modules/c++/nitf-c++.vcxproj index f7fecd2d7..bb2e90828 100644 --- a/modules/c++/nitf-c++.vcxproj +++ b/modules/c++/nitf-c++.vcxproj @@ -231,8 +231,9 @@ Disabled true AdvancedVectorExtensions2 - MultiThreadedDebugDLL true + MultiThreadedDebugDLL + true @@ -261,6 +262,7 @@ true Level3 AdvancedVectorExtensions2 + true diff --git a/modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj b/modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj index ccd635b60..7e93ad84a 100644 --- a/modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj +++ b/modules/c++/nitf/apps/show_nitf++/show_nitf++.vcxproj @@ -65,6 +65,7 @@ true AdvancedVectorExtensions2 true + true Console @@ -89,6 +90,7 @@ true Level3 AdvancedVectorExtensions2 + true Console diff --git a/modules/c/nitf-c.vcxproj b/modules/c/nitf-c.vcxproj index 92546ed88..eb3b5ad7a 100644 --- a/modules/c/nitf-c.vcxproj +++ b/modules/c/nitf-c.vcxproj @@ -66,8 +66,9 @@ AdvancedVectorExtensions2 CompileAsCpp false - MultiThreadedDebugDLL true + MultiThreadedDebugDLL + true @@ -94,6 +95,7 @@ AdvancedVectorExtensions2 CompileAsCpp false + true diff --git a/modules/c/nitf/XML_DATA_CONTENT.vcxproj b/modules/c/nitf/XML_DATA_CONTENT.vcxproj index 5edafec9e..310754ef1 100644 --- a/modules/c/nitf/XML_DATA_CONTENT.vcxproj +++ b/modules/c/nitf/XML_DATA_CONTENT.vcxproj @@ -71,11 +71,12 @@ true CompileAsCpp Guard - MultiThreadedDebugDLL true ProgramDatabase AdvancedVectorExtensions2 true + MultiThreadedDebugDLL + true @@ -98,6 +99,7 @@ Guard true AdvancedVectorExtensions2 + true diff --git a/modules/c/pch.h b/modules/c/pch.h index c6c7a9bde..5928459c7 100644 --- a/modules/c/pch.h +++ b/modules/c/pch.h @@ -3,21 +3,10 @@ // We're building in Visual Studio ... used to control where we get a little bit of config info #define NITRO_PCH 1 -#include "config/disable_compiler_warnings.h" - // TODO: get rid of these someday? ... from Visual Studio code-analysis #pragma warning(disable: 6385) // Reading invalid data from '...': the readable size is '...' bytes, but '...' bytes may be read. #pragma warning(disable: 6386) // Buffer overrun while writing to '...': the writable size is '...' bytes, but '...' bytes might be written. -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers -#include -#if defined(_WIN32) -#undef BIGENDIAN -#include -#else -#include -#endif - #include #include #include @@ -29,13 +18,39 @@ #include #include +#pragma warning(push) +#pragma warning(disable: 4820) // '...': '...' bytes padding added after data member '...' + +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#include +#if defined(_WIN32) +#undef BIGENDIAN +#include +#else +#include +#endif + #include #include +#pragma warning(pop) + + #include #pragma warning(disable: 4505) // '...': unreferenced function with internal linkage has been removed #pragma warning(disable: 4774) // '...' : format string expected in argument 3 is not a string literal +// We don't care about any padding added to structs +#pragma warning(disable: 4820) // '...': '...' bytes padding added after data member '...' + +// Assume any unreferenced functions will be used in other code +#pragma warning(disable: 4514) // '...': unreferenced inline function has been removed + +// ??? +#pragma warning(disable: 4668) // '...' is not defined as a preprocessor macro, replacing with '...' for '...' + +// ??? +#pragma warning(disable: 5045) // Compiler will insert Spectre mitigation for memory load if /Qspectre switch specified #if __cplusplus #pragma warning(disable: 4365) // '...': conversion from '...' to '...', signed/unsigned mismatch From 3a428f1c0b21c600db0bcb200d4d786badc520cf Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Mon, 17 Jul 2023 13:30:21 -0400 Subject: [PATCH 081/104] TEST_ASSERT_EQ_STR() to make it easy to compare `const char*`s --- .../coda-oss/modules/c++/include/TestCase.h | 1 + modules/c++/nitf/unittests/TestCase.h | 117 ------------------ 2 files changed, 1 insertion(+), 117 deletions(-) delete mode 100644 modules/c++/nitf/unittests/TestCase.h diff --git a/externals/coda-oss/modules/c++/include/TestCase.h b/externals/coda-oss/modules/c++/include/TestCase.h index a43314004..5a091dd9b 100644 --- a/externals/coda-oss/modules/c++/include/TestCase.h +++ b/externals/coda-oss/modules/c++/include/TestCase.h @@ -211,6 +211,7 @@ inline int main(TFunc f) #define CODA_OSS_test_eq(X1, X2) (CODA_OSS_test_eq_(X1, X2) && !CODA_OSS_test_ne_(X1, X2)) #define TEST_ASSERT_EQ(X1, X2) if (!CODA_OSS_test_eq((X1), (X2))) { CODA_OSS_test_diePrintf_eq_(X1, X2); } #define TEST_ASSERT_EQ_MSG(msg, X1, X2) if (!CODA_OSS_test_eq((X1), (X2))) { CODA_OSS_test_diePrintf_eq_msg_(msg, X1, X2); } +#define TEST_ASSERT_EQ_STR(X1, X2) TEST_ASSERT_EQ(std::string(X1), std::string(X2)) #define TEST_ASSERT_NOT_EQ(X1, X2) if (!CODA_OSS_test_ne((X1), (X2))) { CODA_OSS_test_diePrintf_not_eq_(X1, X2); } #define TEST_ASSERT_NOT_EQ_MSG(msg, X1, X2) if (!CODA_OSS_test_ne((X1), (X2))) { CODA_OSS_test_diePrintf_not_eq_msg_(msg, X1, X2); } diff --git a/modules/c++/nitf/unittests/TestCase.h b/modules/c++/nitf/unittests/TestCase.h deleted file mode 100644 index 0586fd272..000000000 --- a/modules/c++/nitf/unittests/TestCase.h +++ /dev/null @@ -1,117 +0,0 @@ -/* ========================================================================= - * This file is part of CODA-OSS - * ========================================================================= - * - * (C) Copyright 2004 - 2014, MDA Information Systems LLC - * - * CODA-OSS is free software; you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as published by - * the Free Software Foundation; either version 3 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this program; If not, - * see . - * - */ - -#ifndef __TEST_CASE_H__ -#define __TEST_CASE_H__ -#pragma once - -#ifdef __cplusplus - -# include -# include -# include -# include -# include -# include -# include - -# define IS_NAN(X) X != X -# define TEST_CHECK(X) try{ X(std::string(#X)); std::cerr << #X << ": PASSED" << std::endl; } \ - catch(const except::Throwable& ex) { die_printf("%s: FAILED: Exception thrown: %s\n", std::string(#X).c_str(), ex.what()); } \ - catch(const std::exception& ex) { die_printf("%s: FAILED: Exception thrown: %s\n", std::string(#X).c_str(), ex.what()); } -# define TEST_ASSERT(X) if (!(X)) { die_printf("%s (%s,%s,%d): FAILED: Value should not be NULL\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } -# define TEST_ASSERT_NULL(X) if ((X) != nullptr) { die_printf("%s (%s,%s,%d): FAILED: Value should be NULL\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } -# define TEST_ASSERT_NOT_NULL(X) if ((X) == nullptr) { die_printf("%s (%s,%s,%d): FAILED: Value should not be NULL\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } -# define TEST_ASSERT_FALSE(X) if ((X)) { die_printf("%s (%s,%s,%d): FAILED: Value should evaluate to false\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } -# define TEST_ASSERT_TRUE(X) if (!(X)) { die_printf("%s (%s,%s,%d): FAILED: Value should evaluate to true\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } -# define TEST_ASSERT_EQ(X1, X2) if ((X1) != (X2)) { die_printf("%s (%s,%s,%d): FAILED: Recv'd %s, Expected %s\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__, str::toString(X1).c_str(), str::toString(X2).c_str()); } -# define TEST_ASSERT_EQ_STR(X1, X2) TEST_ASSERT_EQ(std::string(X1), std::string(X2)) -# define TEST_ASSERT_EQ_MSG(msg, X1, X2) if ((X1) != (X2)) die_printf("%s (%s,%d): FAILED (%s): Recv'd %s, Expected %s\n", testName.c_str(), __FILE__, __LINE__, (msg).c_str(), str::toString((X1)).c_str(), str::toString((X2)).c_str()); -# define TEST_ASSERT_NOT_EQ(X1, X2) if ((X1) == (X2)) { die_printf("%s (%s,%s,%d): FAILED: Recv'd %s should not equal %s\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__, str::toString(X1).c_str(), str::toString(X2).c_str()); } -# define TEST_ASSERT_NOT_EQ_MSG(msg, X1, X2) if ((X1) == (X2)) die_printf("%s (%s,%d): FAILED (%s): Recv'd %s should not equal %s\n", testName.c_str(), __FILE__, __LINE__, (msg).c_str(), str::toString((X1)).c_str(), str::toString((X2)).c_str()); -# define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) if (std::abs((X1) - (X2)) > EPS || IS_NAN(std::abs((X1) - (X2)))) die_printf("%s (%s,%d): FAILED: Recv'd %s, Expected %s\n", testName.c_str(), __FILE__, __LINE__, str::toString((X1)).c_str(), str::toString((X2)).c_str()); -# define TEST_ASSERT_ALMOST_EQ(X1, X2) if (std::abs((X1) - (X2)) > std::numeric_limits::epsilon() || IS_NAN(std::abs((X1) - (X2)))) { die_printf("%s (%s,%s,%d): FAILED: Recv'd %s, Expected %s\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__, str::toString(X1).c_str(), str::toString(X2).c_str()); } -# define TEST_ASSERT_GREATER_EQ(X1, X2) if ((X1) < X2) { die_printf("%s (%s,%s,%d): FAILED: Value should be greater than or equal\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } -# define TEST_ASSERT_GREATER(X1, X2) if ((X1) <= X2) { die_printf("%s (%s,%s,%d): FAILED: Value should be greater than\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } -# define TEST_ASSERT_LESSER_EQ(X1, X2) if ((X1) > X2) { die_printf("%s (%s,%s,%d): FAILED: Value should be less than or equal\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } -# define TEST_ASSERT_LESSER(X1, X2) if ((X1) >= X2) { die_printf("%s (%s,%s,%d): FAILED: Value should be less than\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } -# define TEST_FAIL(msg) die_printf("%s (%s,%s,%d): FAILED: %s\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__, str::toString(msg).c_str()); -# define TEST_EXCEPTION(X) try{ (X); die_printf("%s (%s,%s,%d): FAILED: Should have thrown exception\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } catch (const except::Throwable&){ TEST_ASSERT_TRUE(true); } catch (const std::exception&){ TEST_ASSERT_TRUE(true); } -# define TEST_THROWS(X) try{ (X); die_printf("%s (%s,%s,%d): FAILED: Should have thrown exception\n", testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } catch (...){} -# define TEST_SPECIFIC_EXCEPTION(X,Y) try{ (X); die_printf("%s (%s,%s,%d): FAILED: Should have thrown exception: " # Y , testName.c_str(), __FILE__, SYS_FUNC, __LINE__); } catch(const Y&) { } \ - catch (const except::Throwable&){ die_printf("%s (%s,%s,%d): FAILED: Should have thrown exception: " # Y , testName.c_str(), __FILE__, SYS_FUNC, __LINE__);} \ - catch (const std::exception&){ die_printf("%s (%s,%s,%d): FAILED: Should have thrown exception: " # Y , testName.c_str(), __FILE__, SYS_FUNC, __LINE__);} -# define TEST_CASE(X) void X(std::string testName) - -#define TEST_MAIN(X) int main() { try { X; return EXIT_SUCCESS; } \ - catch (const except::Exception& ex) { std::cerr << ex.toString() << std::endl; } \ - catch (const std::exception& e) { std::cerr << e.what() << std::endl; } \ - catch (...) { std::cerr << "Unknown exception\n"; } \ - return EXIT_FAILURE; } - -#else /* C only */ -# include -# include -# include -# include - -/* Copied from sys/Conf.h */ -# define TEST_FILE __FILE__ -# define TEST_LINE __LINE__ -# if defined(__GNUC__) -# define TEST_FUNC __PRETTY_FUNCTION__ -# elif __STDC_VERSION__ < 199901 -# define TEST_FUNC "unknown function" -# else /* Should be c99 */ -# define TEST_FUNC __func__ -# endif - -# define TEST_CHECK(X) X(#X); fprintf(stderr, "%s : PASSED\n", #X); -# define TEST_CHECK_ARGS(X) X(#X,argc,argv); fprintf(stderr, "%s : PASSED\n", #X); -# define TEST_ASSERT(X) if (!(X)) { \ - fprintf(stderr, "%s (%s,%s,%d) : FAILED: Value should not be NULL\n", testName, TEST_FILE, TEST_FUNC, TEST_LINE); \ - exit(EXIT_FAILURE); \ -} -# define TEST_ASSERT_NULL(X) if ((X) != NULL) { \ - fprintf(stderr, "%s (%s,%s,%d) : FAILED: Value should be NULL\n", testName, TEST_FILE, TEST_FUNC, TEST_LINE); \ - exit(EXIT_FAILURE); \ -} -# define TEST_ASSERT_EQ_STR(X1, X2) if (strcmp((X1), (X2)) != 0) { \ - fprintf(stderr, "%s (%s,%s,%d) : FAILED: Recv'd %s, Expected %s\n", testName, TEST_FILE, TEST_FUNC, TEST_LINE, X1, X2); \ - exit(EXIT_FAILURE); \ -} -# define TEST_ASSERT_EQ_INT(X1, X2) if ((X1) != (X2)) { \ - fprintf(stderr, "%s (%s,%s,%d) : FAILED: Recv'd %d, Expected %d\n", testName, TEST_FILE, TEST_FUNC, TEST_LINE, (int)X1, (int)X2); \ - exit(EXIT_FAILURE); \ -} -/* TODO use epsilon for comparing floating points */ -# define TEST_ASSERT_EQ_FLOAT(X1, X2) if (fabs((X1) - (X2)) > .0000001f) { \ - fprintf(stderr, "%s (%s,%s,%d) : FAILED: Recv'd %f, Expected %f\n", testName, TEST_FILE, TEST_FUNC, TEST_LINE, X1, X2); \ - exit(EXIT_FAILURE); \ -} - -# define TEST_CASE(X) void X(const char* testName) -# define TEST_CASE_ARGS(X) void X(const char* testName, int argc, char **argv) - -#endif - -#endif From d5f284d9db58d8afae459fe84a1ee0b8f0135967 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Mon, 17 Jul 2023 13:42:46 -0400 Subject: [PATCH 082/104] test_image_loading++ --- UnitTest/nitf-c++.cpp | 6 ++-- .../nitf/unittests/test_image_loading++.cpp | 31 ++++++++++--------- 2 files changed, 20 insertions(+), 17 deletions(-) diff --git a/UnitTest/nitf-c++.cpp b/UnitTest/nitf-c++.cpp index 82dd48509..6b9bfe56e 100644 --- a/UnitTest/nitf-c++.cpp +++ b/UnitTest/nitf-c++.cpp @@ -26,9 +26,9 @@ TEST_CLASS(test_image_blocker){ public: #include "nitf/unittests/test_image_blocker.cpp" }; -//TEST_CLASS(test_image_loading__){ public: -//#include "nitf/unittests/test_image_loading++.cpp" -//}; +TEST_CLASS(test_image_loading__){ public: +#include "nitf/unittests/test_image_loading++.cpp" +}; TEST_CLASS(test_image_segment_blank_nm_compression){ public: #include "nitf/unittests/test_image_segment_blank_nm_compression.cpp" diff --git a/modules/c++/nitf/unittests/test_image_loading++.cpp b/modules/c++/nitf/unittests/test_image_loading++.cpp index 4850298da..70797983a 100644 --- a/modules/c++/nitf/unittests/test_image_loading++.cpp +++ b/modules/c++/nitf/unittests/test_image_loading++.cpp @@ -67,12 +67,13 @@ struct expected_values final int luts = 0; }; -static void writeImage(nitf::ImageSegment &segment, - nitf::Reader &reader, - const int imageNumber, - const std::string& imageName, - uint32_t rowSkipFactor, - uint32_t columnSkipFactor, bool optz, +static void writeImage(const std::string& testName, + nitf::ImageSegment& segment, + nitf::Reader& reader, + const int imageNumber, + const std::string& imageName, + uint32_t rowSkipFactor, + uint32_t columnSkipFactor, bool optz, const expected_values& expected) { nitf::ImageReader deserializer = reader.newImageReader(imageNumber); @@ -173,7 +174,8 @@ static void writeImage(nitf::ImageSegment &segment, } } -static void test_image_loading_(const std::string& input_file, bool optz, const expected_values& expected) +static void test_image_loading_(const std::string& testName, + const std::string& input_file, bool optz, const expected_values& expected) { /* Skip factors */ uint32_t rowSkipFactor = 1; @@ -198,7 +200,8 @@ static void test_image_loading_(const std::string& input_file, bool optz, const nitf::ImageSegment imageSegment(iter.get()); /* Write the thing out */ - writeImage(imageSegment, reader, count, input_file, + writeImage(testName, + imageSegment, reader, count, input_file, rowSkipFactor, columnSkipFactor, optz, expected); } } @@ -215,8 +218,8 @@ TEST_CASE(test_image_loading) expected.pixelsPerHorizBlock = expected.nCols; expected.pixelsPerVertBlock = expected.nRows; - test_image_loading_(input_file, false /*optz*/, expected); - test_image_loading_(input_file, true /*optz*/, expected); + test_image_loading_(testName, input_file, false /*optz*/, expected); + test_image_loading_(testName, input_file, true /*optz*/, expected); } TEST_CASE(test_8bit_image_loading) @@ -231,12 +234,12 @@ TEST_CASE(test_8bit_image_loading) expected.pixelsPerHorizBlock = expected.nCols; expected.pixelsPerVertBlock = expected.nRows; - test_image_loading_(input_file, false /*optz*/, expected); - test_image_loading_(input_file, true /*optz*/, expected); + test_image_loading_(testName, input_file, false /*optz*/, expected); + test_image_loading_(testName, input_file, true /*optz*/, expected); input_file = findInputFile(false /*withAmpTable*/).string(); - test_image_loading_(input_file, false /*optz*/, expected); - test_image_loading_(input_file, true /*optz*/, expected); + test_image_loading_(testName, input_file, false /*optz*/, expected); + test_image_loading_(testName, input_file, true /*optz*/, expected); } TEST_MAIN( From 6901ffe797a3a5cba05cef9c8efd46688cf4f2a1 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Mon, 17 Jul 2023 13:44:05 -0400 Subject: [PATCH 083/104] test_writer_3++ --- UnitTest/nitf-c++.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/UnitTest/nitf-c++.cpp b/UnitTest/nitf-c++.cpp index 6b9bfe56e..040f6e967 100644 --- a/UnitTest/nitf-c++.cpp +++ b/UnitTest/nitf-c++.cpp @@ -82,8 +82,8 @@ TEST_CLASS(test_tre_read){ public: #include "nitf/unittests/test_tre_read.cpp" }; -//TEST_CLASS(test_writer_3__){ public: -//#include "nitf/unittests/test_writer_3++.cpp" -//}; +TEST_CLASS(test_writer_3__){ public: +#include "nitf/unittests/test_writer_3++.cpp" +}; } \ No newline at end of file From 30af403ce29f6c21c64c3446f5a8beda252edd11 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Mon, 17 Jul 2023 15:35:29 -0400 Subject: [PATCH 084/104] tweak Throwable::toString() --- .../coda-oss/modules/c++/except/include/except/Throwable.h | 4 +++- externals/coda-oss/modules/c++/except/source/Trace.cpp | 7 ++----- externals/coda-oss/modules/c++/include/UnitTest.h | 2 +- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/externals/coda-oss/modules/c++/except/include/except/Throwable.h b/externals/coda-oss/modules/c++/except/include/except/Throwable.h index b71c77250..2a7deecbb 100644 --- a/externals/coda-oss/modules/c++/except/include/except/Throwable.h +++ b/externals/coda-oss/modules/c++/except/include/except/Throwable.h @@ -165,7 +165,9 @@ class CODA_OSS_API Throwable const Trace& t = getTrace(); if (t.getSize() > 0) s << ": " << t; - return s.str(); + + std::string retval(s.str().c_str()); // truncate to first '\0' + return retval; } const std::vector& getBacktrace() const noexcept diff --git a/externals/coda-oss/modules/c++/except/source/Trace.cpp b/externals/coda-oss/modules/c++/except/source/Trace.cpp index 926f321b4..a40645d71 100644 --- a/externals/coda-oss/modules/c++/except/source/Trace.cpp +++ b/externals/coda-oss/modules/c++/except/source/Trace.cpp @@ -26,12 +26,9 @@ namespace except { std::ostream& operator<<(std::ostream& os, const Trace& t) { - const std::list& stack = t.getStack(); - - for (std::list::const_iterator it = stack.begin(); - it != stack.end(); ++it) + for (auto&& trace : t.getStack()) { - os << *it << std::endl; + os << trace << "\n"; } return os; } diff --git a/externals/coda-oss/modules/c++/include/UnitTest.h b/externals/coda-oss/modules/c++/include/UnitTest.h index 51e877609..751843c1f 100644 --- a/externals/coda-oss/modules/c++/include/UnitTest.h +++ b/externals/coda-oss/modules/c++/include/UnitTest.h @@ -133,7 +133,7 @@ inline void assert_almost_eq(const std::string& testName, long double X1, long d #define TEST_ASSERT_EQ_MSG(msg, X1, X2) testName, Microsoft::VisualStudio::CppUnitTestFramework::Logger::WriteMessage(msg.c_str()); TEST_ASSERT_EQ(X1, X2) #undef TEST_FAIL_MSG -#define TEST_FAIL_MSG(msg) { (void)testName; const str::EncodedStringView vw(msg); Microsoft::VisualStudio::CppUnitTestFramework::Assert::Fail(vw.wstring().c_str()); } +#define TEST_FAIL_MSG(msg) { (void)testName; Microsoft::VisualStudio::CppUnitTestFramework::Assert::Fail(str::EncodedStringView(msg).wstring().c_str()); } #undef TEST_EXCEPTION #undef TEST_THROWS From 0880226ed44efadfd9d8686dcd3953f548841b1c Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Mon, 17 Jul 2023 16:15:42 -0400 Subject: [PATCH 085/104] be sure NITF_PLUGIN_PATH is set --- UnitTest/UnitTest.cpp | 11 +++++++ UnitTest/UnitTest.vcxproj | 1 + UnitTest/UnitTest.vcxproj.filters | 1 + UnitTest/nitf-c++.cpp | 6 ++-- UnitTest/pch.h | 1 + .../c++/nitf/unittests/test_create_nitf++.cpp | 11 +++++-- .../c++/nitf/unittests/test_load_plugins.cpp | 33 +++++++++++++++---- 7 files changed, 52 insertions(+), 12 deletions(-) create mode 100644 UnitTest/UnitTest.cpp diff --git a/UnitTest/UnitTest.cpp b/UnitTest/UnitTest.cpp new file mode 100644 index 000000000..aedc2a9f6 --- /dev/null +++ b/UnitTest/UnitTest.cpp @@ -0,0 +1,11 @@ +#include "pch.h" +#include "CppUnitTest.h" + +#include + +// https://learn.microsoft.com/en-us/visualstudio/test/microsoft-visualstudio-testtools-cppunittestframework-api-reference?view=vs-2022 +TEST_MODULE_INITIALIZE(methodName) +{ + // module initialization code + nitf::Test::setNitfPluginPath(); +} \ No newline at end of file diff --git a/UnitTest/UnitTest.vcxproj b/UnitTest/UnitTest.vcxproj index bef5b5d13..d93646725 100644 --- a/UnitTest/UnitTest.vcxproj +++ b/UnitTest/UnitTest.vcxproj @@ -244,6 +244,7 @@ Create Create + diff --git a/UnitTest/UnitTest.vcxproj.filters b/UnitTest/UnitTest.vcxproj.filters index 8cada79ca..7eecfb2b8 100644 --- a/UnitTest/UnitTest.vcxproj.filters +++ b/UnitTest/UnitTest.vcxproj.filters @@ -125,6 +125,7 @@ nitf-c++ + diff --git a/UnitTest/nitf-c++.cpp b/UnitTest/nitf-c++.cpp index 040f6e967..ab4cebd73 100644 --- a/UnitTest/nitf-c++.cpp +++ b/UnitTest/nitf-c++.cpp @@ -58,9 +58,9 @@ TEST_CLASS(test_j2k_read_tile){ public: #include "nitf/unittests/test_j2k_read_tile.cpp" }; -//TEST_CLASS(test_load_plugins){ public: -//#include "nitf/unittests/test_load_plugins.cpp" -//}; +TEST_CLASS(test_load_plugins){ public: +#include "nitf/unittests/test_load_plugins.cpp" +}; TEST_CLASS(test_nitf_buffer_list){ public: #include "nitf/unittests/test_nitf_buffer_list.cpp" diff --git a/UnitTest/pch.h b/UnitTest/pch.h index 04883be8e..dc9bcceff 100644 --- a/UnitTest/pch.h +++ b/UnitTest/pch.h @@ -29,6 +29,7 @@ #include #include #include +#include #include "Test.h" diff --git a/modules/c++/nitf/unittests/test_create_nitf++.cpp b/modules/c++/nitf/unittests/test_create_nitf++.cpp index 86a7628f0..10bf65413 100644 --- a/modules/c++/nitf/unittests/test_create_nitf++.cpp +++ b/modules/c++/nitf/unittests/test_create_nitf++.cpp @@ -41,6 +41,7 @@ #include #include +#include CODA_OSS_disable_warning_push #if _MSC_VER @@ -234,6 +235,8 @@ static bool test_create_nitf_with_byte_provider__testRead(const std::string& pat TEST_CASE(test_create_nitf_with_byte_provider_test) { + nitf::Test::setNitfPluginPath(); + // We can't actually compress. This is just for illustration. const bool shouldCompress = false; const std::string outname("test_create.nitf"); @@ -394,6 +397,8 @@ static bool test_create_nitf__testRead(const std::string& pathname, bool isMono TEST_CASE(test_create_nitf_test) { + nitf::Test::setNitfPluginPath(); + const std::string outname("test_create.nitf"); @@ -428,7 +433,7 @@ TEST_CASE(test_create_nitf_test) } else { - TEST_ASSERT_TRUE(true); + TEST_FAIL_MSG("NITF_PLUGIN_PATH not set"); } } @@ -469,7 +474,9 @@ static void RecordThread_run() TEST_CASE(test_mt_record) { - const int NTHR = 2; + nitf::Test::setNitfPluginPath(); + + constexpr int NTHR = 2; std::array thrs; try diff --git a/modules/c++/nitf/unittests/test_load_plugins.cpp b/modules/c++/nitf/unittests/test_load_plugins.cpp index e568b838f..4aaee43ca 100644 --- a/modules/c++/nitf/unittests/test_load_plugins.cpp +++ b/modules/c++/nitf/unittests/test_load_plugins.cpp @@ -26,10 +26,11 @@ #include #include +#include #include "TestCase.h" -static void load_plugin(const char* tre) +static void load_plugin(const std::string& testName, const char* tre) { nitf_Error error; @@ -73,29 +74,47 @@ static const std::vector& all_plugins() TEST_CASE(test_load_all_plugins_C) { + nitf::Test::setNitfPluginPath(); + for (const auto& tre : all_plugins()) { - load_plugin(tre.c_str()); + load_plugin(testName, tre.c_str()); } } TEST_CASE(test_load_PTPRAA) { - load_plugin("PTPRAA"); + nitf::Test::setNitfPluginPath(); + load_plugin(testName, "PTPRAA"); } TEST_CASE(test_load_ENGRDA) { - load_plugin("ENGRDA"); + nitf::Test::setNitfPluginPath(); + load_plugin(testName, "ENGRDA"); } -TEST_CASE(test_load_all_plugins) +static void loadPlugin(const std::string& testName, const std::string& path) { - for (const auto& tre : all_plugins()) + try { #ifdef _WIN32 // need the full path to load on Linux - nitf::PluginRegistry::loadPlugin(tre); + nitf::PluginRegistry::loadPlugin(path); #endif + TEST_SUCCESS; + } + catch (const nitf::NITFException& ex) + { + TEST_FAIL_MSG(ex.toString()); + } +} +TEST_CASE(test_load_all_plugins) +{ + nitf::Test::setNitfPluginPath(); + + for (const auto& tre : all_plugins()) + { + loadPlugin(testName, tre); TEST_ASSERT(nitf::PluginRegistry::treHandlerExists(tre)); } } From 620f926fade05f8b36c5a12fbbb1e1761fe1edcc Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Mon, 17 Jul 2023 16:21:15 -0400 Subject: [PATCH 086/104] GREATER_EQ for unsigned --- .../nitf/unittests/test_image_segment_blank_nm_compression.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/c++/nitf/unittests/test_image_segment_blank_nm_compression.cpp b/modules/c++/nitf/unittests/test_image_segment_blank_nm_compression.cpp index 9e1e1e612..c8552739f 100644 --- a/modules/c++/nitf/unittests/test_image_segment_blank_nm_compression.cpp +++ b/modules/c++/nitf/unittests/test_image_segment_blank_nm_compression.cpp @@ -255,7 +255,7 @@ TEST_CASE(testBlankSegmentsValid) imageDataOffset, blockRecordLength, padRecordLength, padPixelValueLength, padValue, blockMask, padMask) != 0); - TEST_ASSERT_GREATER(blockRecordLength, 0u); + TEST_ASSERT_GREATER_EQ(blockRecordLength, 1u); const int64_t totalBlocks = blockingInfo.getNumBlocksPerRow()*blockingInfo.getNumBlocksPerCol(); TEST_ASSERT_GREATER(totalBlocks, 0); From 13309880c9f308c19824a67ac758381f25c6d648 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Mon, 17 Jul 2023 16:23:36 -0400 Subject: [PATCH 087/104] TRE unittests --- UnitTest/nitf-c++.cpp | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/UnitTest/nitf-c++.cpp b/UnitTest/nitf-c++.cpp index ab4cebd73..6e4912cc4 100644 --- a/UnitTest/nitf-c++.cpp +++ b/UnitTest/nitf-c++.cpp @@ -45,11 +45,11 @@ TEST_CLASS(test_image_writer){ public: //TEST_CLASS(test_j2k_compress_tile){ public: //#include "nitf/unittests/test_j2k_compress_tile.cpp" //}; - +// //TEST_CLASS(test_j2k_compressed_byte_provider){ public: //#include "nitf/unittests/test_j2k_compressed_byte_provider.cpp" //}; - +// //TEST_CLASS(test_j2k_loading__){ public: //#include "nitf/unittests/test_j2k_loading++.cpp" //}; @@ -66,17 +66,17 @@ TEST_CLASS(test_nitf_buffer_list){ public: #include "nitf/unittests/test_nitf_buffer_list.cpp" }; -//TEST_CLASS(test_tre_create__){ public: -//#include "nitf/unittests/test_tre_create++.cpp" -//}; -// -//TEST_CLASS(test_tre_mods){ public: -//#include "nitf/unittests/test_tre_mods.cpp" -//}; -// -//TEST_CLASS(test_tre_mods__){ public: -//#include "nitf/unittests/test_tre_mods++.cpp" -//}; +TEST_CLASS(test_tre_create__){ public: +#include "nitf/unittests/test_tre_create++.cpp" +}; + +TEST_CLASS(test_tre_mods){ public: +#include "nitf/unittests/test_tre_mods.cpp" +}; + +TEST_CLASS(test_tre_mods__){ public: +#include "nitf/unittests/test_tre_mods++.cpp" +}; TEST_CLASS(test_tre_read){ public: #include "nitf/unittests/test_tre_read.cpp" From 88dd0630c0b68f4983f49a01c832169548f0f8a0 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Mon, 17 Jul 2023 16:30:49 -0400 Subject: [PATCH 088/104] enable remaining unittests --- UnitTest/nitf-c++.cpp | 38 +++++++++++++++++++++++++++----------- UnitTest/pch.h | 9 +++++++++ 2 files changed, 36 insertions(+), 11 deletions(-) diff --git a/UnitTest/nitf-c++.cpp b/UnitTest/nitf-c++.cpp index 6e4912cc4..700258d51 100644 --- a/UnitTest/nitf-c++.cpp +++ b/UnitTest/nitf-c++.cpp @@ -2,10 +2,26 @@ #include "CppUnitTest.h" #include +#include +#include +#include + #include #include #include #include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include namespace nitf_cpp { @@ -42,17 +58,17 @@ TEST_CLASS(test_image_writer){ public: #include "nitf/unittests/test_image_writer.cpp" }; -//TEST_CLASS(test_j2k_compress_tile){ public: -//#include "nitf/unittests/test_j2k_compress_tile.cpp" -//}; -// -//TEST_CLASS(test_j2k_compressed_byte_provider){ public: -//#include "nitf/unittests/test_j2k_compressed_byte_provider.cpp" -//}; -// -//TEST_CLASS(test_j2k_loading__){ public: -//#include "nitf/unittests/test_j2k_loading++.cpp" -//}; +TEST_CLASS(test_j2k_compress_tile){ public: +#include "nitf/unittests/test_j2k_compress_tile.cpp" +}; + +TEST_CLASS(test_j2k_compressed_byte_provider){ public: +#include "nitf/unittests/test_j2k_compressed_byte_provider.cpp" +}; + +TEST_CLASS(test_j2k_loading__){ public: +#include "nitf/unittests/test_j2k_loading++.cpp" +}; TEST_CLASS(test_j2k_read_tile){ public: #include "nitf/unittests/test_j2k_read_tile.cpp" diff --git a/UnitTest/pch.h b/UnitTest/pch.h index dc9bcceff..ab78e8ef4 100644 --- a/UnitTest/pch.h +++ b/UnitTest/pch.h @@ -25,6 +25,15 @@ #include #include +#pragma comment(lib, "io-c++") +#pragma comment(lib, "io-c++") +#pragma comment(lib, "except-c++") +#pragma comment(lib, "sys-c++") +#pragma comment(lib, "str-c++") +#pragma comment(lib, "sio.lite-c++.lib") +#pragma comment(lib, "math-c++") +#pragma comment(lib, "mt-c++") + #include #include #include From cdb661b7ba9b33a9bd453ff2251d1b35485bb49e Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Mon, 17 Jul 2023 16:31:36 -0400 Subject: [PATCH 089/104] All unittests now in single UnitTest project --- Test++/Test++.vcxproj | 177 ------------------ Test++/Test++.vcxproj.filters | 31 --- Test++/Test.h | 6 - Test++/TestCase.h | 2 - Test++/nitf_Test.h | 36 ---- Test++/nitf_test_compress_tile.cpp | 13 -- Test++/nitf_test_create_nitf++.cpp | 30 --- Test++/nitf_test_field++.cpp | 13 -- Test++/nitf_test_hash_table_1++.cpp | 13 -- Test++/nitf_test_image_blocker.cpp | 13 -- Test++/nitf_test_image_io.cpp | 13 -- ...est_image_segment_blank_nm_compression.cpp | 13 -- Test++/nitf_test_image_segment_computer.cpp | 13 -- Test++/nitf_test_j2k_compress_tile.cpp | 13 -- ...nitf_test_j2k_compressed_byte_provider.cpp | 14 -- Test++/nitf_test_j2k_loading++.cpp | 13 -- Test++/nitf_test_j2k_read_tile.cpp | 13 -- Test++/nitf_test_nitf_buffer_list.cpp | 13 -- Test++/nitf_test_tre_create++.cpp | 22 --- Test++/nitf_test_tre_mods++.cpp | 41 ---- Test++/nitf_test_tre_mods.cpp | 123 ------------ Test++/nitf_test_tre_read.cpp | 22 --- Test++/nitf_test_writer_3++.cpp | 22 --- Test++/nrt_Test.h | 6 - Test++/nrt_test_utils.cpp | 13 -- Test++/pch.cpp | 6 - Test++/pch.h | 74 -------- Test/Test.h | 48 ----- Test/Test.vcxproj | 174 ----------------- Test/Test.vcxproj.filters | 28 --- Test/TestCase.h | 2 - Test/j2k_Test.h | 6 - Test/nitf_Test.h | 11 -- Test/nitf_test_create.cpp | 13 -- Test/nitf_test_create_nitf.cpp | 20 -- Test/nitf_test_field.cpp | 13 -- Test/nitf_test_geo_utils.cpp | 13 -- Test/nitf_test_image_io.cpp | 13 -- Test/nitf_test_mem_source.cpp | 13 -- Test/nitf_test_tre_read.cpp | 35 ---- Test/nitf_test_zero_field.cpp | 13 -- Test/nrt_Test.h | 6 - Test/nrt_test_buffer_adapter.cpp | 13 -- Test/nrt_test_core_values.cpp | 13 -- Test/nrt_test_list.cpp | 13 -- Test/nrt_test_nrt_byte_swap.cpp | 13 -- Test/nrt_test_nrt_datetime.cpp | 13 -- Test/nrt_test_tree.cpp | 14 -- Test/nrt_test_utils.cpp | 13 -- Test/pch.cpp | 5 - Test/pch.h | 52 ----- 51 files changed, 1325 deletions(-) delete mode 100644 Test++/Test++.vcxproj delete mode 100644 Test++/Test++.vcxproj.filters delete mode 100644 Test++/Test.h delete mode 100644 Test++/TestCase.h delete mode 100644 Test++/nitf_Test.h delete mode 100644 Test++/nitf_test_compress_tile.cpp delete mode 100644 Test++/nitf_test_create_nitf++.cpp delete mode 100644 Test++/nitf_test_field++.cpp delete mode 100644 Test++/nitf_test_hash_table_1++.cpp delete mode 100644 Test++/nitf_test_image_blocker.cpp delete mode 100644 Test++/nitf_test_image_io.cpp delete mode 100644 Test++/nitf_test_image_segment_blank_nm_compression.cpp delete mode 100644 Test++/nitf_test_image_segment_computer.cpp delete mode 100644 Test++/nitf_test_j2k_compress_tile.cpp delete mode 100644 Test++/nitf_test_j2k_compressed_byte_provider.cpp delete mode 100644 Test++/nitf_test_j2k_loading++.cpp delete mode 100644 Test++/nitf_test_j2k_read_tile.cpp delete mode 100644 Test++/nitf_test_nitf_buffer_list.cpp delete mode 100644 Test++/nitf_test_tre_create++.cpp delete mode 100644 Test++/nitf_test_tre_mods++.cpp delete mode 100644 Test++/nitf_test_tre_mods.cpp delete mode 100644 Test++/nitf_test_tre_read.cpp delete mode 100644 Test++/nitf_test_writer_3++.cpp delete mode 100644 Test++/nrt_Test.h delete mode 100644 Test++/nrt_test_utils.cpp delete mode 100644 Test++/pch.cpp delete mode 100644 Test++/pch.h delete mode 100644 Test/Test.h delete mode 100644 Test/Test.vcxproj delete mode 100644 Test/Test.vcxproj.filters delete mode 100644 Test/TestCase.h delete mode 100644 Test/j2k_Test.h delete mode 100644 Test/nitf_Test.h delete mode 100644 Test/nitf_test_create.cpp delete mode 100644 Test/nitf_test_create_nitf.cpp delete mode 100644 Test/nitf_test_field.cpp delete mode 100644 Test/nitf_test_geo_utils.cpp delete mode 100644 Test/nitf_test_image_io.cpp delete mode 100644 Test/nitf_test_mem_source.cpp delete mode 100644 Test/nitf_test_tre_read.cpp delete mode 100644 Test/nitf_test_zero_field.cpp delete mode 100644 Test/nrt_Test.h delete mode 100644 Test/nrt_test_buffer_adapter.cpp delete mode 100644 Test/nrt_test_core_values.cpp delete mode 100644 Test/nrt_test_list.cpp delete mode 100644 Test/nrt_test_nrt_byte_swap.cpp delete mode 100644 Test/nrt_test_nrt_datetime.cpp delete mode 100644 Test/nrt_test_tree.cpp delete mode 100644 Test/nrt_test_utils.cpp delete mode 100644 Test/pch.cpp delete mode 100644 Test/pch.h diff --git a/Test++/Test++.vcxproj b/Test++/Test++.vcxproj deleted file mode 100644 index 19fff43f6..000000000 --- a/Test++/Test++.vcxproj +++ /dev/null @@ -1,177 +0,0 @@ - - - - - Debug - x64 - - - Release - x64 - - - - 17.0 - {E610F11D-1240-4260-87F8-504B49DB6915} - Win32Proj - UnitTest - 10.0 - NativeUnitTestProject - - - - DynamicLibrary - true - v143 - Unicode - false - - - DynamicLibrary - false - v143 - true - Unicode - false - - - - - - - - - - - - - - - true - - - false - - - - Use - EnableAllWarnings - true - $(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)modules\c\;$(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories);$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ - _DEBUG;%(PreprocessorDefinitions) - true - pch.h - true - true - Guard - MultiThreadedDebugDLL - true - true - ProgramDatabase - AdvancedVectorExtensions2 - - - Windows - $(VCInstallDir)UnitTest\lib;$(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;%(AdditionalLibraryDirectories) - - - - - Use - Level3 - true - true - true - $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)externals\coda-oss\install-$(Configuration)-$(Platform).$(PlatformToolset)\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories);$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ - NDEBUG;%(PreprocessorDefinitions) - true - pch.h - true - Guard - true - true - AdvancedVectorExtensions2 - - - Windows - true - true - $(VCInstallDir)UnitTest\lib;$(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;%(AdditionalLibraryDirectories) - - - - - - - - - - - - - - - - - - - - - - Create - Create - - - - - - - - - - - - - {8f357a19-799e-4971-850e-3f28485c130b} - - - {f06550ad-cfc7-40b8-8727-6c82c69a8982} - - - {53f9f908-c678-4dee-9309-e71c1d03a45f} - - - {730b1e6e-2469-4f9e-b093-d0c6262453c9} - - - {51d7b426-899e-428d-9f69-5ddac9e403fb} - - - {12aa0752-4ee3-4e0a-85af-0e5deadbf343} - - - {023de06d-3967-4406-b1b8-032118bb2552} - - - {53f9f908-c678-4dee-9309-e71c1e03a45f} - - - {d749aa73-4c9a-473d-96bb-070a6d9caa54} - - - {d1d7fcd3-6130-4504-9da0-9d80506be55e} - - - {2baaaca9-a5a4-412c-ae52-b16c2d107f55} - - - {cf5b4f02-364d-4117-9fb9-6c9c7938e412} - - - {78849481-d356-4cc7-b182-31c21f857ed1} - - - - - - \ No newline at end of file diff --git a/Test++/Test++.vcxproj.filters b/Test++/Test++.vcxproj.filters deleted file mode 100644 index cbac6cf64..000000000 --- a/Test++/Test++.vcxproj.filters +++ /dev/null @@ -1,31 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/Test++/Test.h b/Test++/Test.h deleted file mode 100644 index d701a1544..000000000 --- a/Test++/Test.h +++ /dev/null @@ -1,6 +0,0 @@ -#pragma once - -#pragma warning(push) -#pragma warning(disable: 4464) // relative include path contains '..' -#include "../Test/Test.h" -#pragma warning(pop) \ No newline at end of file diff --git a/Test++/TestCase.h b/Test++/TestCase.h deleted file mode 100644 index c9583fa66..000000000 --- a/Test++/TestCase.h +++ /dev/null @@ -1,2 +0,0 @@ -#pragma once -#include "Test.h" diff --git a/Test++/nitf_Test.h b/Test++/nitf_Test.h deleted file mode 100644 index 107330a62..000000000 --- a/Test++/nitf_Test.h +++ /dev/null @@ -1,36 +0,0 @@ -#pragma once - -#if defined(MS_CPP_UNITTESTFRAMEWORK) -#define __TEST_H__ // #include "../nitf/unittests/Test.h" -#define __TEST_CASE_H__ // #include "../nitf/unittests/TestCase.h" -#endif -#include "Test.h" - -#include - -#include "import/nitf.h" - -#include - -namespace Microsoft{ namespace VisualStudio {namespace CppUnitTestFramework -{ - -template<> -inline std::wstring ToString(const nitf::PixelValueType& q) -{ - return str::EncodedStringView(nitf::to_string(q)).wstring(); -} - -template<> -inline std::wstring ToString(const nitf::BlockingMode& q) -{ - return str::EncodedStringView(nitf::to_string(q)).wstring(); -} - -template<> -inline std::wstring ToString(const nitf::ImageCompression& q) -{ - return str::EncodedStringView(nitf::to_string(q)).wstring(); -} - -}}} \ No newline at end of file diff --git a/Test++/nitf_test_compress_tile.cpp b/Test++/nitf_test_compress_tile.cpp deleted file mode 100644 index c4c4d11c2..000000000 --- a/Test++/nitf_test_compress_tile.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(test_j2k_read_tile) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_j2k_compress_tile.cpp" - -}; \ No newline at end of file diff --git a/Test++/nitf_test_create_nitf++.cpp b/Test++/nitf_test_create_nitf++.cpp deleted file mode 100644 index b7a4face1..000000000 --- a/Test++/nitf_test_create_nitf++.cpp +++ /dev/null @@ -1,30 +0,0 @@ -#include "pch.h" - -#include - -#include "nitf_Test.h" - -CODA_OSS_disable_warning_push -#if _MSC_VER -#pragma warning(disable: 4464) // relative include path contains '..' -#endif -#include -CODA_OSS_disable_warning_pop - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_create_nitf__) { -public: - nitf_test_create_nitf__() { - // initialization code here - nitf::Test::setNitfPluginPath(); - } - - ~nitf_test_create_nitf__() = default; - nitf_test_create_nitf__(const nitf_test_create_nitf__&) = delete; - nitf_test_create_nitf__& operator=(const nitf_test_create_nitf__&) = delete; - - #define TEST_CASE(X) TEST_METHOD(X) - #include "nitf/unittests/test_create_nitf++.cpp" - -}; \ No newline at end of file diff --git a/Test++/nitf_test_field++.cpp b/Test++/nitf_test_field++.cpp deleted file mode 100644 index 416032b1c..000000000 --- a/Test++/nitf_test_field++.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_field__) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_field++.cpp" - -}; \ No newline at end of file diff --git a/Test++/nitf_test_hash_table_1++.cpp b/Test++/nitf_test_hash_table_1++.cpp deleted file mode 100644 index 62fece1c6..000000000 --- a/Test++/nitf_test_hash_table_1++.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_hash_table_1__) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_hash_table_1++.cpp" - -}; \ No newline at end of file diff --git a/Test++/nitf_test_image_blocker.cpp b/Test++/nitf_test_image_blocker.cpp deleted file mode 100644 index be61b895e..000000000 --- a/Test++/nitf_test_image_blocker.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(test_image_blocker) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_image_blocker.cpp" - -}; \ No newline at end of file diff --git a/Test++/nitf_test_image_io.cpp b/Test++/nitf_test_image_io.cpp deleted file mode 100644 index 4d9ad9663..000000000 --- a/Test++/nitf_test_image_io.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(test_image_loading__) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_image_loading++.cpp" - -}; diff --git a/Test++/nitf_test_image_segment_blank_nm_compression.cpp b/Test++/nitf_test_image_segment_blank_nm_compression.cpp deleted file mode 100644 index 47a54fd25..000000000 --- a/Test++/nitf_test_image_segment_blank_nm_compression.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(test_image_segment_blank_nm_compression) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_image_segment_blank_nm_compression.cpp" - -}; \ No newline at end of file diff --git a/Test++/nitf_test_image_segment_computer.cpp b/Test++/nitf_test_image_segment_computer.cpp deleted file mode 100644 index 3129bc58f..000000000 --- a/Test++/nitf_test_image_segment_computer.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(test_image_segment_computer) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_image_segment_computer.cpp" - -}; \ No newline at end of file diff --git a/Test++/nitf_test_j2k_compress_tile.cpp b/Test++/nitf_test_j2k_compress_tile.cpp deleted file mode 100644 index 81fc99838..000000000 --- a/Test++/nitf_test_j2k_compress_tile.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(test_j2k_compress_tile) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_j2k_compress_tile.cpp" - -}; \ No newline at end of file diff --git a/Test++/nitf_test_j2k_compressed_byte_provider.cpp b/Test++/nitf_test_j2k_compressed_byte_provider.cpp deleted file mode 100644 index c33c5c877..000000000 --- a/Test++/nitf_test_j2k_compressed_byte_provider.cpp +++ /dev/null @@ -1,14 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(test_j2k_compressed_byte_provider) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_j2k_compressed_byte_provider.cpp" - -}; - diff --git a/Test++/nitf_test_j2k_loading++.cpp b/Test++/nitf_test_j2k_loading++.cpp deleted file mode 100644 index bcd213237..000000000 --- a/Test++/nitf_test_j2k_loading++.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(test_j2k_loading__) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_j2k_loading++.cpp" - -}; \ No newline at end of file diff --git a/Test++/nitf_test_j2k_read_tile.cpp b/Test++/nitf_test_j2k_read_tile.cpp deleted file mode 100644 index c7d2e83d6..000000000 --- a/Test++/nitf_test_j2k_read_tile.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(test_j2k_read_tile) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_j2k_read_tile.cpp" - -}; \ No newline at end of file diff --git a/Test++/nitf_test_nitf_buffer_list.cpp b/Test++/nitf_test_nitf_buffer_list.cpp deleted file mode 100644 index 71f19a07e..000000000 --- a/Test++/nitf_test_nitf_buffer_list.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(test_nitf_buffer_list) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_nitf_buffer_list.cpp" - -}; \ No newline at end of file diff --git a/Test++/nitf_test_tre_create++.cpp b/Test++/nitf_test_tre_create++.cpp deleted file mode 100644 index 2db6022c6..000000000 --- a/Test++/nitf_test_tre_create++.cpp +++ /dev/null @@ -1,22 +0,0 @@ -#include "pch.h" - -#include - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_tre_create__) { -public: - nitf_test_tre_create__() { - // initialization code here - nitf::Test::setNitfPluginPath(); - } - ~nitf_test_tre_create__() = default; - nitf_test_tre_create__(const nitf_test_tre_create__&) = delete; - nitf_test_tre_create__& operator=(const nitf_test_tre_create__&) = delete; - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_tre_create++.cpp" - -}; \ No newline at end of file diff --git a/Test++/nitf_test_tre_mods++.cpp b/Test++/nitf_test_tre_mods++.cpp deleted file mode 100644 index b5ec3ba03..000000000 --- a/Test++/nitf_test_tre_mods++.cpp +++ /dev/null @@ -1,41 +0,0 @@ -#include "pch.h" - -#include - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_tre_mods__) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_tre_mods++.cpp" - -}; - -// Be sure this runs AFTER the tre_mods tests ... not really sure why ... -#undef TEST_CASE -TEST_CLASS(test_image_writer) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_image_writer.cpp" - -}; - -#undef TEST_CASE -TEST_CLASS(test_load_plugins) { -public: - test_load_plugins() { - // initialization code here - nitf::Test::setNitfPluginPath(); - } - ~test_load_plugins() = default; - test_load_plugins(const test_load_plugins&) = delete; - test_load_plugins& operator=(const test_load_plugins&) = delete; - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_load_plugins.cpp" - -}; diff --git a/Test++/nitf_test_tre_mods.cpp b/Test++/nitf_test_tre_mods.cpp deleted file mode 100644 index dac0bec70..000000000 --- a/Test++/nitf_test_tre_mods.cpp +++ /dev/null @@ -1,123 +0,0 @@ -#include "pch.h" - -#include - -#include -#include - -#include "nitf_Test.h" - -namespace fs = std::filesystem; - -static bool is_x64_Configuration(const fs::path& path) // "Configuration" is typically "Debug" or "Release" -{ - const std::string build_configuration = -#if defined(NDEBUG) // i.e., release - "Release"; -#else - "Debug"; -#endif - - const auto Configuration = path.filename(); - const auto path_parent_path = path.parent_path(); - const auto x64 = path_parent_path.filename(); - return (Configuration == build_configuration) && (x64 == "x64"); -} - -static bool is_install_unittests(const fs::path& path) -{ - const auto unittests = path.filename(); - const auto path_parent_path = path.parent_path(); - const auto install = path_parent_path.filename(); - return (unittests == "unittests") && (install == "install"); -} -static bool is_install_tests(const fs::path& path) -{ - const auto tests = path.filename(); - const auto path_parent_path = path.parent_path(); - const auto install = path_parent_path.filename(); - return (tests == "tests") && (install == "install"); -} - -static fs::path buildDir(const fs::path& path) -{ - const auto cwd = fs::current_path(); - - const sys::OS os; - const auto exec = fs::path(os.getCurrentExecutable()); - const auto argv0 = exec.filename(); - if (argv0 == "testhost.exe") - { - // Running Visual Studio unit-tests on Windows - if (is_x64_Configuration(cwd)) - { - return cwd / path; - } - } - - if (argv0 == "unittests.exe") - { - // stand-alone unittest executable on Windows (ends in .EXE) - const auto parent_path = exec.parent_path(); - if (is_x64_Configuration(parent_path)) - { - const auto parent_path_ = parent_path.parent_path().parent_path(); - return parent_path_ / "dev" / "tests" / "images"; - } - } - - // stand-alone unit-test on Linux - const auto exec_dir = exec.parent_path(); - if (is_install_unittests(exec_dir)) - { - const auto install = exec_dir.parent_path(); - return install / "unittests" / "data"; - } - if (is_install_tests(exec_dir)) - { - const auto install = exec_dir.parent_path(); - return install / "unittests" / "data"; - } - - if (argv0 == "unittests") - { - // stand-alone unittest executable on Linux - const auto bin = exec.parent_path(); - if (bin.filename() == "bin") - { - const auto unittests = bin.parent_path(); - return unittests / "unittests" / "data"; - } - } - - //fprintf(stderr, "cwd = %s\n", cwd.c_str()); - //fprintf(stderr, "exec = %s\n", exec.c_str()); - - return cwd; -} - -static fs::path buildPluginsDir() -{ - return buildDir(fs::path("share") / "nitf" / "plugins"); -} - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_tre_mods) { -public: - nitf_test_tre_mods() - { - // initialization code here - //const std::string NITF_PLUGIN_PATH = R"(C:\Users\jdsmith\source\repos\nitro\x64\Debug\share\nitf\plugins)"; - const std::string putenv_ = "NITF_PLUGIN_PATH=" + buildPluginsDir().string(); - _putenv(putenv_.c_str()); - } - - ~nitf_test_tre_mods() = default; - nitf_test_tre_mods(const nitf_test_tre_mods&) = delete; - nitf_test_tre_mods& operator=(const nitf_test_tre_mods&) = delete; - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_tre_mods.cpp" - -}; \ No newline at end of file diff --git a/Test++/nitf_test_tre_read.cpp b/Test++/nitf_test_tre_read.cpp deleted file mode 100644 index f193b32aa..000000000 --- a/Test++/nitf_test_tre_read.cpp +++ /dev/null @@ -1,22 +0,0 @@ -#include "pch.h" - -#include - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(test_tre_read) { -public: - test_tre_read() { - // initialization code here - nitf::Test::setNitfPluginPath(); - } - ~test_tre_read() = default; - test_tre_read(const test_tre_read&) = delete; - test_tre_read& operator=(const test_tre_read&) = delete; - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_tre_read.cpp" - -}; diff --git a/Test++/nitf_test_writer_3++.cpp b/Test++/nitf_test_writer_3++.cpp deleted file mode 100644 index a4a961102..000000000 --- a/Test++/nitf_test_writer_3++.cpp +++ /dev/null @@ -1,22 +0,0 @@ -#include "pch.h" - -#include - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_writer_3__) { -public: - nitf_test_writer_3__() { - // initialization code here - nitf::Test::setNitfPluginPath(); - } - ~nitf_test_writer_3__() = default; - nitf_test_writer_3__(const nitf_test_writer_3__&) = delete; - nitf_test_writer_3__& operator=(const nitf_test_writer_3__&) = delete; - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_writer_3++.cpp" - -}; diff --git a/Test++/nrt_Test.h b/Test++/nrt_Test.h deleted file mode 100644 index 7f0d7a36f..000000000 --- a/Test++/nrt_Test.h +++ /dev/null @@ -1,6 +0,0 @@ -#pragma once - -#if defined(MS_CPP_UNITTESTFRAMEWORK) -#define __TEST_H__ // #include "../nrt/unittests/Test.h" -#endif -#include "Test.h" diff --git a/Test++/nrt_test_utils.cpp b/Test++/nrt_test_utils.cpp deleted file mode 100644 index 4ca3e39fc..000000000 --- a/Test++/nrt_test_utils.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nrt_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nrt_test_utils) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nrt/unittests/test_utils.c" - -}; \ No newline at end of file diff --git a/Test++/pch.cpp b/Test++/pch.cpp deleted file mode 100644 index 97b544ec1..000000000 --- a/Test++/pch.cpp +++ /dev/null @@ -1,6 +0,0 @@ -// -// pch.cpp -// Include the standard header and generate the precompiled header. -// - -#include "pch.h" diff --git a/Test++/pch.h b/Test++/pch.h deleted file mode 100644 index da88f1cc9..000000000 --- a/Test++/pch.h +++ /dev/null @@ -1,74 +0,0 @@ -// pch.h: This is a precompiled header file. -// Files listed below are compiled only once, improving build performance for future builds. -// This also affects IntelliSense performance, including code completion and many code browsing features. -// However, files listed here are ALL re-compiled if any one of them is updated between builds. -// Do not add files here that you will be updating frequently as this negates the performance advantage. - -#ifndef PCH_H -#define PCH_H -#pragma once - -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers -#define NOMINMAX -#pragma warning(push) -#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to 'extern "C"' function under -EHc. Undefined behavior may occur if this function throws an exception. -#include -#pragma warning(pop) -#pragma comment(lib, "ws2_32") - -#pragma warning(disable: 4820) // '...': '...' bytes padding added after data member '...' -#pragma warning(disable: 4710) // '...': function not inlined -#pragma warning(disable: 5045) // Compiler will insert Spectre mitigation for memory load if / Qspectre switch specified -#pragma warning(disable: 4668) // '...' is not defined as a preprocessor macro, replacing with '...' for '...' -// TODO: get rid of these someday? -#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to 'extern "C"' function under -EHc. Undefined behavior may occur if this function throws an exception. -#pragma warning(disable: 4514) // '...': unreferenced inline function has been removed - -// We're building in Visual Studio ... used to control where we get a little bit of config info -#define NITRO_PCH 1 - -#pragma warning(disable: 5032) // detected #pragma warning(push) with no corresponding #pragma warning(pop) -#pragma warning(push) -#pragma warning(disable: 4464) // relative include path contains '..' -#pragma warning(disable: 4625) // '...' : copy constructor was implicitly defined as deleted -#pragma warning(disable: 4626) // '...' : assignment operator was implicitly defined as deleted -#include -#include -#include -#include -#include -#include -#pragma warning(disable: 5031) // #pragma warning(pop): likely mismatch, popping warning state pushed in different file -#pragma comment(lib, "io-c++") -#pragma comment(lib, "except-c++") -#pragma comment(lib, "sys-c++") -#pragma comment(lib, "str-c++") -#pragma comment(lib, "sio.lite-c++.lib") -#pragma comment(lib, "math-c++") -#pragma comment(lib, "mt-c++") -#pragma warning(pop) - -#pragma warning(push) -#include "CppUnitTest.h" -#pragma warning(pop) - -#include - -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include - -#include "nitf_Test.h" -#include "Test.h" - -#endif //PCH_H diff --git a/Test/Test.h b/Test/Test.h deleted file mode 100644 index 8fb840d23..000000000 --- a/Test/Test.h +++ /dev/null @@ -1,48 +0,0 @@ -#pragma once - -#include -#include - -#include "CppUnitTest.h" - -#define TEST_ASSERT(X) Assert::IsTrue(X) - -template -inline void test_assert_eq_(T&& t, U&& u) -{ - Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(t, u); - Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(u, t); -} -#define TEST_ASSERT_EQ(X1, X2) test_assert_eq_(X1, X2); -#define TEST_ASSERT_EQ_INT(X1, X2) TEST_ASSERT_EQ(X2, X1) -#define TEST_ASSERT_EQ_STR(X1, X2) TEST_ASSERT_EQ(std::string(X1), std::string(X2)) -#define TEST_ASSERT_EQ_FLOAT(X1, X2) TEST_ASSERT_EQ(static_cast(X1), static_cast(X2)) - -#define TEST_ASSERT_NULL(X) Assert::IsNull((X)) -#define TEST_ASSERT_NOT_NULL(X) Assert::IsNotNull((X)) -#define TEST_ASSERT_TRUE(X) Assert::IsTrue((X)) -#define TEST_ASSERT_FALSE(X) Assert::IsFalse((X)) - -template -inline void test_assert_not_eq_(T&& t, U&& u) -{ - Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreNotEqual(t, u); - Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreNotEqual(u, t); -} -#define TEST_ASSERT_NOT_EQ(X1, X2) test_assert_not_eq_(X1, X2); -template -inline void test_assert_greater_(T&& t, U&& u) -{ - Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(t > u); -} -#define TEST_ASSERT_GREATER(X1, X2) test_assert_greater_(X1, X2) - -#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) { Assert:AreEqual(X1, X2, EPS); Assert:AreEqual(X2, X1, EPS); } -#define TEST_ASSERT_ALMOST_EQ(X1, X2) TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, 0.0001) - -#define TEST_ASSERT_EQ_MSG(msg, X1, X2) Logger::WriteMessage(msg.c_str()); TEST_ASSERT_EQ(X1, X2) - -#define TEST_EXCEPTION(X) try { (X); TEST_ASSERT_FALSE(false); } catch (...) { TEST_ASSERT_TRUE(true); } -#define TEST_THROWS(X) TEST_EXCEPTION(X) - -#define TEST_MAIN(X) diff --git a/Test/Test.vcxproj b/Test/Test.vcxproj deleted file mode 100644 index 3f3723594..000000000 --- a/Test/Test.vcxproj +++ /dev/null @@ -1,174 +0,0 @@ - - - - - Debug - x64 - - - Release - x64 - - - - 17.0 - {238C9787-B27D-4107-B8FD-1BDB49EA8023} - Win32Proj - UnitTest - 10.0 - NativeUnitTestProject - - - - DynamicLibrary - true - v143 - Unicode - false - - - DynamicLibrary - false - v143 - true - Unicode - false - - - - - - - - - - - - - - - true - - - false - - - - Use - EnableAllWarnings - true - $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) - _DEBUG;%(PreprocessorDefinitions) - true - pch.h - true - true - Guard - MultiThreadedDebugDLL - true - true - ProgramDatabase - AdvancedVectorExtensions2 - - - Windows - $(VCInstallDir)UnitTest\lib;$(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;%(AdditionalLibraryDirectories) - - - - - Use - Level3 - true - true - true - $(SolutionDir)modules\c\nrt\include\;$(SolutionDir)modules\c\nitf\include\;$(SolutionDir)modules\c\jpeg\include\;$(SolutionDir)modules\c\j2k\include\;$(SolutionDir)modules\c\cgm\include;$(SolutionDir)modules\c\;$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\nitf\include\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories) - NDEBUG;%(PreprocessorDefinitions) - true - pch.h - true - Guard - true - true - AdvancedVectorExtensions2 - - - Windows - true - true - $(VCInstallDir)UnitTest\lib;$(SolutionDir)out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)externals\coda-oss\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;%(AdditionalLibraryDirectories) - - - - - - - - - - - - - - - - - - Create - Create - - - - - - - - - - - - - - {8f357a19-799e-4971-850e-3f28485c130b} - - - {f06550ad-cfc7-40b8-8727-6c82c69a8982} - - - {53f9f908-c678-4dee-9309-e71c1d03a45f} - - - {730b1e6e-2469-4f9e-b093-d0c6262453c9} - - - {51d7b426-899e-428d-9f69-5ddac9e403fb} - - - {12aa0752-4ee3-4e0a-85af-0e5deadbf343} - - - {023de06d-3967-4406-b1b8-032118bb2552} - - - {53f9f908-c678-4dee-9309-e71c1e03a45f} - - - {d749aa73-4c9a-473d-96bb-070a6d9caa54} - - - {d1d7fcd3-6130-4504-9da0-9d80506be55e} - - - {2baaaca9-a5a4-412c-ae52-b16c2d107f55} - - - {cf5b4f02-364d-4117-9fb9-6c9c7938e412} - - - {78849481-d356-4cc7-b182-31c21f857ed1} - - - - - - \ No newline at end of file diff --git a/Test/Test.vcxproj.filters b/Test/Test.vcxproj.filters deleted file mode 100644 index 0b5d831d1..000000000 --- a/Test/Test.vcxproj.filters +++ /dev/null @@ -1,28 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/Test/TestCase.h b/Test/TestCase.h deleted file mode 100644 index c9583fa66..000000000 --- a/Test/TestCase.h +++ /dev/null @@ -1,2 +0,0 @@ -#pragma once -#include "Test.h" diff --git a/Test/j2k_Test.h b/Test/j2k_Test.h deleted file mode 100644 index 23af9b6d4..000000000 --- a/Test/j2k_Test.h +++ /dev/null @@ -1,6 +0,0 @@ -#pragma once - -#if defined(GTEST_API_) -#define __TEST_H__ // #include "../j2k/unittests/Test.h" -#endif -#include "Test.h" diff --git a/Test/nitf_Test.h b/Test/nitf_Test.h deleted file mode 100644 index c307e5643..000000000 --- a/Test/nitf_Test.h +++ /dev/null @@ -1,11 +0,0 @@ -#pragma once - -#if defined(MS_CPP_UNITTESTFRAMEWORK) -#define __TEST_H__ // #include "../nitf/unittests/Test.h" -#define __TEST_CASE_H__ // #include "../nitf/unittests/TestCase.h" -#endif -#include "Test.h" - -#include - -#include "import/nitf.h" diff --git a/Test/nitf_test_create.cpp b/Test/nitf_test_create.cpp deleted file mode 100644 index f794fe585..000000000 --- a/Test/nitf_test_create.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_create) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_create.c" - -}; \ No newline at end of file diff --git a/Test/nitf_test_create_nitf.cpp b/Test/nitf_test_create_nitf.cpp deleted file mode 100644 index 8fdf17ce8..000000000 --- a/Test/nitf_test_create_nitf.cpp +++ /dev/null @@ -1,20 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -#define TEST_NAME nitf_test_create_nitf -int argc = 1; -const char* argv[] = { "nitf_test_create_nitf" }; - -#include "nitf/unittests/nitro_image_.c_" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_create_nitf) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#define TEST_CASE_ARGS(X) TEST_METHOD(X) -#include "nitf/unittests/test_create_nitf.c" - -}; \ No newline at end of file diff --git a/Test/nitf_test_field.cpp b/Test/nitf_test_field.cpp deleted file mode 100644 index 70fecd6e6..000000000 --- a/Test/nitf_test_field.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_field) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_field.c" - -}; \ No newline at end of file diff --git a/Test/nitf_test_geo_utils.cpp b/Test/nitf_test_geo_utils.cpp deleted file mode 100644 index e30ba258d..000000000 --- a/Test/nitf_test_geo_utils.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_geo_utils) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_geo_utils.c" - -}; \ No newline at end of file diff --git a/Test/nitf_test_image_io.cpp b/Test/nitf_test_image_io.cpp deleted file mode 100644 index 097defccb..000000000 --- a/Test/nitf_test_image_io.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_image_io) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_image_io.c" - -}; \ No newline at end of file diff --git a/Test/nitf_test_mem_source.cpp b/Test/nitf_test_mem_source.cpp deleted file mode 100644 index 341cccbac..000000000 --- a/Test/nitf_test_mem_source.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_mem_source) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_mem_source.c" - -}; \ No newline at end of file diff --git a/Test/nitf_test_tre_read.cpp b/Test/nitf_test_tre_read.cpp deleted file mode 100644 index aaf2f9886..000000000 --- a/Test/nitf_test_tre_read.cpp +++ /dev/null @@ -1,35 +0,0 @@ -#include "pch.h" - -#include - -#include "nitf_Test.h" - -struct test_tre_read : public ::testing::Test { - test_tre_read() { - // initialization code here - //const std::string NITF_PLUGIN_PATH = R"(C:\Users\jdsmith\source\repos\nitro\x64\Debug\share\nitf\plugins)"; - nitf::Test::setNitfPluginPath(); - } - - void SetUp() { - // code here will execute just before the test ensues - } - - void TearDown() { - // code here will be called just after the test completes - // ok to through exceptions from here if need be - } - - ~test_tre_read() { - // cleanup any pending stuff, but no exceptions allowed - } - - test_tre_read(const test_tre_read&) = delete; - test_tre_read& operator=(const test_tre_read&) = delete; - - - // put in any custom data members that you need -}; - -#define TEST_CASE(X) TEST_F(test_tre_read, X) -#include "nitf/unittests/test_tre_read.cpp" diff --git a/Test/nitf_test_zero_field.cpp b/Test/nitf_test_zero_field.cpp deleted file mode 100644 index adda886ae..000000000 --- a/Test/nitf_test_zero_field.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nitf_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nitf_test_zero_field) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nitf/unittests/test_zero_field.c" - -}; \ No newline at end of file diff --git a/Test/nrt_Test.h b/Test/nrt_Test.h deleted file mode 100644 index 7f0d7a36f..000000000 --- a/Test/nrt_Test.h +++ /dev/null @@ -1,6 +0,0 @@ -#pragma once - -#if defined(MS_CPP_UNITTESTFRAMEWORK) -#define __TEST_H__ // #include "../nrt/unittests/Test.h" -#endif -#include "Test.h" diff --git a/Test/nrt_test_buffer_adapter.cpp b/Test/nrt_test_buffer_adapter.cpp deleted file mode 100644 index 79b5af6f3..000000000 --- a/Test/nrt_test_buffer_adapter.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nrt_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nrt_test_buffer_adapter) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nrt/unittests/test_buffer_adapter.c" - -}; \ No newline at end of file diff --git a/Test/nrt_test_core_values.cpp b/Test/nrt_test_core_values.cpp deleted file mode 100644 index 8e1b96416..000000000 --- a/Test/nrt_test_core_values.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nrt_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nrt_test_core_values) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nrt/unittests/test_core_values.c" - -}; \ No newline at end of file diff --git a/Test/nrt_test_list.cpp b/Test/nrt_test_list.cpp deleted file mode 100644 index 45ddc75ff..000000000 --- a/Test/nrt_test_list.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nrt_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nrt_test_list) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nrt/unittests/test_list.c" - -}; \ No newline at end of file diff --git a/Test/nrt_test_nrt_byte_swap.cpp b/Test/nrt_test_nrt_byte_swap.cpp deleted file mode 100644 index c863cf98f..000000000 --- a/Test/nrt_test_nrt_byte_swap.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nrt_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nrt_test_nrt_byte_swap) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nrt/unittests/test_nrt_byte_swap.c" - -}; diff --git a/Test/nrt_test_nrt_datetime.cpp b/Test/nrt_test_nrt_datetime.cpp deleted file mode 100644 index 59e0f3faa..000000000 --- a/Test/nrt_test_nrt_datetime.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nrt_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nrt_test_nrt_datetime) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nrt/unittests/test_nrt_datetime.c" - -}; diff --git a/Test/nrt_test_tree.cpp b/Test/nrt_test_tree.cpp deleted file mode 100644 index 0d1c83100..000000000 --- a/Test/nrt_test_tree.cpp +++ /dev/null @@ -1,14 +0,0 @@ -#include "pch.h" - -#include "nrt_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -const char* testName = "testTree"; -TEST_CLASS(nrt_test_tree) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nrt/unittests/test_tree.c" - -}; \ No newline at end of file diff --git a/Test/nrt_test_utils.cpp b/Test/nrt_test_utils.cpp deleted file mode 100644 index 4ca3e39fc..000000000 --- a/Test/nrt_test_utils.cpp +++ /dev/null @@ -1,13 +0,0 @@ -#include "pch.h" - -#include "nrt_Test.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -TEST_CLASS(nrt_test_utils) { -public: - -#define TEST_CASE(X) TEST_METHOD(X) -#include "nrt/unittests/test_utils.c" - -}; \ No newline at end of file diff --git a/Test/pch.cpp b/Test/pch.cpp deleted file mode 100644 index 64b7eef6d..000000000 --- a/Test/pch.cpp +++ /dev/null @@ -1,5 +0,0 @@ -// pch.cpp: source file corresponding to the pre-compiled header - -#include "pch.h" - -// When you are using pre-compiled headers, this source file is necessary for compilation to succeed. diff --git a/Test/pch.h b/Test/pch.h deleted file mode 100644 index 2fa0542e0..000000000 --- a/Test/pch.h +++ /dev/null @@ -1,52 +0,0 @@ -// pch.h: This is a precompiled header file. -// Files listed below are compiled only once, improving build performance for future builds. -// This also affects IntelliSense performance, including code completion and many code browsing features. -// However, files listed here are ALL re-compiled if any one of them is updated between builds. -// Do not add files here that you will be updating frequently as this negates the performance advantage. - -#ifndef PCH_H -#define PCH_H -#pragma once - -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers -#define NOMINMAX -#pragma warning(push) -#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to 'extern "C"' function under -EHc. Undefined behavior may occur if this function throws an exception. -#include -#pragma warning(pop) -#pragma comment(lib, "ws2_32") - -#pragma warning(disable: 4820) // '...': '...' bytes padding added after data member '...' -#pragma warning(disable: 4710) // '...': function not inlined -#pragma warning(disable: 5045) // Compiler will insert Spectre mitigation for memory load if / Qspectre switch specified -#pragma warning(disable: 4668) // '...' is not defined as a preprocessor macro, replacing with '...' for '...' -// TODO: get rid of these someday? -#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to 'extern "C"' function under -EHc. Undefined behavior may occur if this function throws an exception. -#pragma warning(disable: 4514) // '...': unreferenced inline function has been removed - -// We're building in Visual Studio ... used to control where we get a little bit of config info -#define NITRO_PCH 1 - -#pragma warning(disable: 5032) // detected #pragma warning(push) with no corresponding #pragma warning(pop) -#pragma warning(push) -#pragma warning(disable: 4464) // relative include path contains '..' -#include -#pragma warning(disable: 5031) // #pragma warning(pop): likely mismatch, popping warning state pushed in different file -#pragma comment(lib, "io-c++") -#pragma comment(lib, "except-c++") -#pragma comment(lib, "sys-c++") -#pragma comment(lib, "str-c++") -#pragma warning(pop) - -#pragma warning(push) -#include "CppUnitTest.h" -#pragma warning(pop) - -#include -#include -#include - -#include "nitf_Test.h" -#include "Test.h" - -#endif //PCH_H From 0abd72fc20f40fee0c46364dd3e2bca7586753c5 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Mon, 17 Jul 2023 17:37:57 -0400 Subject: [PATCH 090/104] latest from coda-oss --- .../c++/str/source/EncodedStringView.cpp | 27 ++++++++++--------- 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/externals/coda-oss/modules/c++/str/source/EncodedStringView.cpp b/externals/coda-oss/modules/c++/str/source/EncodedStringView.cpp index 385293601..6bd00eef4 100644 --- a/externals/coda-oss/modules/c++/str/source/EncodedStringView.cpp +++ b/externals/coda-oss/modules/c++/str/source/EncodedStringView.cpp @@ -85,26 +85,29 @@ static std::string to_native(str::W1252string::const_pointer p, size_t sz) throw std::logic_error("Unknown platform."); } -template -inline coda_oss::span make_span(const CharT* s, size_t c) +template +inline auto make_span(const Char8T* s, size_t c) { - return coda_oss::span(s, c); + static_assert(sizeof(Char8T) == sizeof(char), "sizeof(Char8T) != sizeof(char)"); + return coda_oss::span(s, c); } -template -inline coda_oss::span make_span(const CharT* s) +template +inline auto make_span(const Char8T* s) { - auto s_ = str::cast(s); + auto const s_ = str::cast(s); return make_span(s, strlen(s_)); } -template -inline coda_oss::span make_span(const std::basic_string& s) +template +inline auto make_span(const std::basic_string& s) { - return make_span(s.c_str(), s.size()); + assert(strlen(str::c_str(s)) == s.length()); + return make_span(s.c_str(), s.length()); } -template -inline coda_oss::span make_span(coda_oss::span s) +template +inline auto make_span(coda_oss::span s) { - auto s_ = str::cast(s.data()); + auto const s_ = str::cast(s.data()); + assert(strlen(s_) == s.size()); return coda_oss::span(s_, s.size()); } From ba79b8e9b2e69f3ab0ec6d67ac00e18046cb751c Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Mon, 17 Jul 2023 17:48:57 -0400 Subject: [PATCH 091/104] latest from CODA-OSS --- externals/coda-oss/.github/workflows/build_unittest.yml | 2 +- externals/coda-oss/coda-oss.sln | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/externals/coda-oss/.github/workflows/build_unittest.yml b/externals/coda-oss/.github/workflows/build_unittest.yml index c4d7cb0ce..b96a17a63 100644 --- a/externals/coda-oss/.github/workflows/build_unittest.yml +++ b/externals/coda-oss/.github/workflows/build_unittest.yml @@ -57,7 +57,7 @@ jobs: matrix: os: [windows-latest] platform: [x64] - configuration: [Release] + configuration: [Debug] # Debug turns on more compiler warnings name: ${{ matrix.os }}-msbuild runs-on: ${{ matrix.os }} diff --git a/externals/coda-oss/coda-oss.sln b/externals/coda-oss/coda-oss.sln index 48465a170..cea89c6f0 100644 --- a/externals/coda-oss/coda-oss.sln +++ b/externals/coda-oss/coda-oss.sln @@ -15,9 +15,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution EndProject Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "UnitTest", "UnitTest\UnitTest.vcxproj", "{34A31B3F-47C5-441D-AB22-3C85B3C5314E}" EndProject -Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".github", ".github", "{E0FA1194-0806-4A6B-A331-33CB43C0C946}" -EndProject -Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "workflows", "workflows", "{4EC1396F-3781-409E-B209-A920C464853C}" +Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".github-workflows", ".github-workflows", "{E0FA1194-0806-4A6B-A331-33CB43C0C946}" ProjectSection(SolutionItems) = preProject .github\workflows\build_unittest.yml = .github\workflows\build_unittest.yml EndProjectSection @@ -42,7 +40,6 @@ Global EndGlobalSection GlobalSection(NestedProjects) = preSolution {E0FA1194-0806-4A6B-A331-33CB43C0C946} = {DEB848DD-4285-4BFA-9B2F-60FA46200205} - {4EC1396F-3781-409E-B209-A920C464853C} = {E0FA1194-0806-4A6B-A331-33CB43C0C946} EndGlobalSection GlobalSection(ExtensibilityGlobals) = postSolution SolutionGuid = {3CAB4AC9-7865-44AD-8623-57905729A559} From 5d18020c33ceb7016652a29ac99b548df7e36ce1 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Mon, 17 Jul 2023 17:49:01 -0400 Subject: [PATCH 092/104] Squashed 'externals/coda-oss/' changes from e87c32b4de..e2472acfc1 e2472acfc1 build in NITRO and SIX (#703) 32ccf91052 Use same build paths as Visual Studio (#701) 366ac9f43f Another round of removing compiler warnings (#702) a7f8ef2605 Fix compile warnings from building CODA (#700) f70b4202f1 account for coda-oss.vcxproj being in other SLNs af3faebfc6 Remove more compiler/code-analysis warnings (#699) 82be2a6db2 unittests should work w/o install (#698) dbb90a06d9 add msbuild for coda-oss.sln (#697) 5a417140a6 reduce compiler warnings (#696) 288619dfa3 all modules now part of coda-oss.vcxproj (#695) c2fc5fc660 add more projects to coda-oss-lite.vcxproj (#694) ceb86c186e support $(PlatformToolset) as a "special" environment variable (#693) d78a8595a7 OS::getSIMDInstructionSet() utility (#692) 2d2df467da fix `python3 waf dumplib` 54033e70e3 Merge branch 'main' into feature/complex_short 3c63f9f65e std::numbers from C++20 (#691) 892dd0e00f ComplexInteger and ComplexReal to better match existing naming conventions (#690) b3872181ec match coda-oss naming conventions (#688) 704d6867f9 beef-up our complex type (#687) 47c1c1cd66 check is_absolute() for URLs (#686) c042373e16 be sure our Path::isAbolute() matches std::filesystem::path::absolute() (#684) ad10286bc0 volatile is about "special" memory, not threading (#685) f4d42005fa fix build error in NITRO ff11a5557e keep using std::complex for now (#682) c88b9c0532 types::complex (#681) d1244a0804 don't need our own make_unique in C++14 (#680) aeec0131c5 assert()s for mem::CopyablePtr (#679) 72b0ebd603 add types::complex_short (#678) 932130a580 patch to build other projects c00c1f203d coda-oss release 2023-06-06 (#677) ef54bbcd53 remove more compiler warnings (#676) dadfc5ce62 distinguish between byte-swapping a buffer and single value (#674) 90187f6cd8 more xml.lite tweaks for SIDD-3.0/ISM (#675) eb99607720 stronger type-checking for byteSwap() (#673) ff4f820ed8 xml.lite tweaks to support SIDD 3.0 ISM (#672) b1de8c0e5e std::byte should be a unique type (#671) c05bf9a028 allow enums to be byte-swapped too 1f9fd88d6d remove spurious 47684c45b8 byteSwap now uses byte buffers (#670) cbc659db27 add swapBytes() utility from SIX (#669) 891481b64f simplify byte-swapping (#668) 540ae763e5 more byteSwap() tweaks 0774c03c46 threaded byteSwap() (#667) d156370d36 swapping a single-byte value makes no sense c120e3255d be sure parameter is used to avoid compiler warning e85ec93317 --output-on-failure for CTest (#666) e80376197b turn off "there is no warning number" warning c5f0a5d154 A C-string may not be NULL-terminated (#665) 0c5eb29ae7 use platform-specific routines for byteSwap() (#664) 0b7d581fa6 remove transform_async() (#663) f6489b6bef Merge branch 'main' into feature/xml.lite_tweaks 836c426a2b use function-pointers so that isConsoleOutput is only checked once 56e3c45b1b move depthPrint() functionality into non-member function in preparation for future changes ddcd26d972 Merge branch 'main' into feature/xml.lite_tweaks 69cc0e5063 use the more rigorous create_and_check_datatype() 9efb875584 Merge branch 'main' into feature/hdf5 4d2f2f4173 more HighFive unittests (#662) 14191a844a HighFive::create_datatype() goes from C++ to HighFive 98583473fb utility routines to read string attributes 1fa75ce81e use the C API to read a string attribute 71e7b69f54 still can't figure out how to read a string attribute :-( e96f37a69b test reading the file attributes a25244519c getAttribute() unittest 8f12a3000b getDataType() unittest 857ff0af32 HighFive utility routines (#661) 1d687db57b writeDataSet() utility overload 106aa68945 sigh ... H5Easy::dump() fill fails on Windows/WAF :-( 2641b60b2b Merge branch 'main' into feature/hdf5 35c19e7e81 change actions to @v3 (#660) 212bbd3a36 works on local machine, but not build server ... ? 7125118b09 dump of 1D vector doesn't work :-( c704db4352 sigh ... WAF build still failing :-( 01aae46163 does dump() of a 1D vector work? 76a53c8134 comment-out H5 writing :-( 0f0e19affe test_highfive_dump() cb8f737957 trying to get highfive_dump() unittest working w/Windows-WAF 6584a264af does test_highfive_create() work? cde6147ced tweak HighFive wrappers (#659) 3165668545 Revert "trying HighFive "write" unittests again" a9ec24ca4d trying HighFive "write" unittests again 585ad49a56 tweak names of utility routines 4c91a4d97a make it easier to read a std::vector and std::vecotr 0217ffa26c readDataSet() now works for 1D data 95e8973f29 trying to get hdf5::lite::load() working 4d294611d4 "const" correctness 5e6305c3f7 fix load_complex() 4a134dc5f1 start work on utility routines to read complex data from HDF5 9d76a7f41e Merge branch 'main' into feature/hdf5 8f9667a240 whitepsace ebd3fc99ea Merge branch 'main' into feature/hdf5 40091b069c comment-out writing tests for now ... need to figure our WAF bulid failure 935aa34592 be sure the dataset has real data 114b9bf33c update release notes bd9c0b26c5 tweak HighFive utility routines acda1ef577 turn off diagnostics around expected failures 22a7488402 readDataSet() utility routine for HighFive bd88a8c256 HighFive writeDataSet() utility to work with our SpanRC 6142f5b339 use HighFive routines to write a HDF5 file 5bbf1abaff Use HiveFive routines to get info about the file 84fbc83789 duplicate unittests with H5Easy f1f054c03a Merge branch 'main' into feature/hdf5 9b63ca470c fix directory names f6f826689a fix directory names 7aeb82c336 Merge branch 'main' into feature/hdf5 d028baaebd hook up HighFive header-only library (#653) 3083b0a313 Revert "HighFive 2.6.2" 246985a7f0 Revert ""build" HighFive HDF5 library" a8b75a5865 Revert "turn off HighFive Boost support" ec68d5f830 Revert "Add HighFive unittests" f1f85b9e7f Revert "get test_high_five_base more-or-less compiling" 5ea634ee15 Revert "more work on getting HighFive unittests to build" ecc45433c7 more work on getting HighFive unittests to build bb194788ab get test_high_five_base more-or-less compiling d42bde0004 Add HighFive unittests ddc86bb328 turn off HighFive Boost support b255122d4f "build" HighFive HDF5 library 396cc3ef2a HighFive 2.6.2 5e5f9d9c0f Merge branch 'main' into feature/hdf5 ee938b4a52 changes from SIX bb764df90b Merge branch 'main' into feature/xml.lite_tweaks de2a243800 make derived classes 'final' if possible 14e19bcd21 Change xml lite function to virtual (#645) 8f42ac8e9e Merge branch 'main' into feature/xml.lite_tweaks 18ad90645f hdf5Write unittest 3462e11792 createFile() and writeFile() overloads ecee81d532 fix typos 197eecfa62 sketch-out hdf5::lite::writeFile() bd2311795e use SpanRC for writeFile(), not yet implemented ea9af75109 simple SpanRC to hold a 2D-size and pointer 027c19ee8a createFile() unittest 1f9d07ecbc hook up createFile() 8c7e4473f0 start hooking up HDF5 writing 146e0bea3b Merge branch 'main' into feature/hdf5 88ca9fcb7f Merge branch 'main' into feature/hdf5 42b604b463 Squashed commit of the following: 10ee602c25 Merge branch 'main' into feature/hdf5 67aa42b69d restore changes from "main" 8bbfcbfbfe unittests can be simplified to match fewer "view" classes 126bb802ea Merge branch 'main' into feature/hdf5 3f8ba7a423 again, don't need a class just to convert from std::vector<> to std::span<> 24c2b489c8 Squashed commit of the following: 2703c119d4 Squashed commit of the following: 9d5228a2be don't need an entire class just to convert a std::vector<> into std::span<> 51bc931dcd Merge branch 'main' into feature/hdf5 a84f258160 Squashed commit of the following: c4d2ed696e add missing #include guards, fix type in existing #include guard d541525a01 use a single ComplexViewConstIterator for all views 86e6a459fe CODA_OSS_disable_warning causes GCC errors :-( 5d4b9c2cb6 only need an custom iterator for ComplexSpansView d9f0fb1286 hook up iterators b9329e4db0 initial pass at a ComplexViewConstIterator 6352388739 remove compiler warning about unused "constexpr" variables b39f6096fb use the casing from H5 to make copy/pasting code slightly easier 0887b13eb4 Merge branch 'main' into feature/hdf5 bd07df1cae Consistent casing for Dataset, Datatype, Dataspace 7acd30ee23 tweak hdf5.lite dependencies 38ab914dfd Jupyter notebook for creating H5 files 95a040e0bf _small.h5 is now (correctly) FLOAT32 107e7c4876 make a simple values() member function to avoid template magic e1feca9194 use TEST_SPECIFIC_EXCEPTION macro instead of try/catch 7383336888 readDatasetT() now throws for the wrong buffer type 6b2cc25294 Merge branch 'feature/hdf5' of github.com:mdaus/coda-oss into feature/hdf5 310f8fd3d5 can't get template magic right for copy_axis() 86b306d596 stepping through copy ctors in the debugger is annoying f243e92d68 trying to make wrong type of buffer fail 2b10d96529 read in new sample file a28e59d8c5 help the compiler with type deduction 49bf5e9bc2 nested_complex_float_data_small.h5 e029325fc0 utility routines to "deconstruct" and array of std::complex dede3bd393 Merge branch 'main' into feature/hdf5 904b1ef5ec tweak class names, make_() and copy() utility routines 8237b9efbf make it harder to pass the wrong types to ComplexViews 4d9aeda2cd ComplexArrayView and ComplexParallelView utility classes f5e367dfa6 test std::span> a4a2844f26 read in the nested "i" and "r" data 1156152650 sample file has subgroups 8e1b7869aa Merge branch 'feature/hdf5' of github.com:mdaus/coda-oss into feature/hdf5 9f4232a1dd update sample H5 file 8c55db73ae walk through HDF5 sub-groups 7775ed9c43 Update 123_barfoo_catdog_cx.h5 677975d7ca Matlab code to create sample H5 file a0e7dfe07b Update test_hdf5info.cpp 0b67e1602f pass __FILE__ and __LINE__ from calling site for a more accurate exception message 86a6773213 skeleton for more sample data 85f79b0999 Merge branch 'main' into feature/hdf5 18088e9421 Merge branch 'main' into feature/hdf5 3a1d17692f Merge branch 'main' into feature/hdf5 1755c69d70 Merge branch 'main' into feature/hdf5 9ad015432d No more "11" suffix on exception names c20d962511 Squashed commit of the following: c88cee999b other values to be filled-in bca4a4ecd8 incorporation NamedObject from HDF5 docs 61fa68f72e groupInfo() 460e7d7665 datasetInfo() 14eb9b764b start filling in DatasetInfo afe5f1c3a0 start to fill in DatasetInfo 77a968c72d start filling in GroupInfo d81bcdfd92 openGroup() to open groups (loc) a0cd294697 comment-out "dataset" unittest for now 86e0060245 begin filling in FileInfo 366dda6ab6 a return_type_of utility is needed to deduce the return type e219282638 explicitly pass return type to template 4937ccd11d template to reduce boilerplate when calling try_catch_H5Exceptions b3b5ebde78 use new exception utility routines ea1c03ef0c put exception handling/conversion in a utility routine 819a99d397 utility routine for exception handling 6f34eea979 put utilities in a separate file for easier reuse fcbde4f241 break utility routines into smaller pieces for easier reuse 52358ea8a9 WIN32 no longer automatically defined? 5a42864722 Revert "build HDF5 with C89" 680e599e9d build HDF5 with C89 a87a071218 Merge branch 'main' into feature/hdf5 8447c1a900 Revert "sym-links instead of copying files" db3b5e12b4 Merge branch 'main' into feature/xml.lite_tweaks fb60b5696f Merge branch 'main' into feature/hdf5 5110a5cc81 Comments about _u and _q 1a937d32cf Merge branch 'main' into feature/xml.lite_tweaks fa06f04d7e get ready for hdf5.lite enhancdements b040c7c437 sym-links instead of copying files aa431bb477 use _u for xml::lite::Uri 3d0c6d58ce fix case-sensitive #include filename 93dcd0e527 operator() for getElementByName() 75a93af859 more operator[] overloads to make attribute management easier 4ab8216f87 user-defined string literals to remove some noise around xml::lite::QName f82f0b0fc6 Merge branch 'main' into feature/xml.lite_tweaks ae30e36443 Merge branch 'feature/xml.lite_tweaks' of github.com:mdaus/coda-oss into feature/xml.lite_tweaks ffdd9beb0b simplify attribute creation 9bf5414f5d simplify attribute creation 82d7a4e959 SWIG gets confused about namespaces 7a61d0741f fix bug on Element ctor uncovered by unittest fdd7e58c1a QName is also in the xerces namespace which confuses SWIG bindings a325b7053b operator+=() overload for addChild daf30e6c0e Merge branch 'feature/xml.lite_tweaks' of github.com:mdaus/coda-oss into feature/xml.lite_tweaks b887d2b476 provide overloads for Element& rather than creating new "reference" types 1fa6bba388 rename test_xmleasy.cpp 7c8c9e0f1c += overload 850da6f63d overload for std::string 4547fc5a75 use UIT-8 strings for characterData 4723462a3b convenient addChild() overloads e48720753a copy over ElementReference from xml.easy a4ca30a0d6 Merge branch 'main' into feature/xml.lite_tweaks 6ae9f0b715 Revert "check-in of new xml.easy (to move code between computers)" f7466a6d75 Revert "simple routines for single element" a5490230d6 Revert "make some operators simplier ways of calling functions" c9a25630a6 Revert "get document creation working" 8af8710b05 Revert "free functions instead of member functions" 16c3847cb2 Revert "ElementReference distinct from Element" 7d68e156ff Revert "ElementMutableReference" 00eb2a2826 Merge branch 'main' into feature/xml.lite_tweaks a42969c1f4 ElementMutableReference a20ae9355e ElementReference distinct from Element 14eeeea0b5 free functions instead of member functions 4aae014b39 get document creation working 8835692699 make some operators simplier ways of calling functions 053bd1212a simple routines for single element 8bf701a2ea check-in of new xml.easy (to move code between computers) 41f959051c unittests for creating XML documents from scratch 9752d50ae2 Merge branch 'main' into feature/xml.lite_tweaks 1531d57095 by default, don't validate strings passed to Uri() 46d13d4bf7 Merge branch 'master' into feature/xml.lite_tweaks 39b547d321 remove more vestiges of Expat and LibXML ec8274d524 remove LibXML and Expat as they're no longer used/supported. 20eeefeef6 Merge branch 'master' into feature/xml.lite_tweaks 95074b9b1a update for newer Intel compiler 7024f71e1b Merge branch 'master' into feature/xml.lite_tweaks 57b1cbc83d Merge branch 'master' into feature/xml.lite_tweaks 4b67561c3d remove validate() overload that nobody is using fa15f1e5dc Squashed commit of the following: 1484a90909 test the new validate() API 470da70fb8 hookup StringStreamT routines 2cddf25047 begin hooking up validate() overloads 1b5d910f38 overload validate() for UTF-8 and Windows-1252 03309b8c9f Squashed commit of the following: b72c6c5bf2 older compiler doesn't like our make_unique af8f00307f validate UTF-8 XML on Linux 211188613e unit-test for LEGACY XML validation 3c1169d2b5 Squashed commit of the following: 3afff19cad std::filesystem::path for FileInputStreamOS 908d452f8f WIP: validate all of our sample XML files 00f9bb16bc validate against a XML schema 243d8c356c Merge branch 'master' into feature/xml.lite_tweaks 2815d707d9 fix to work with SWIG bindings. :-( 4608621326 trying (again) to remove vestiages of old code e3c83a8587 Revert "new code should use UTF-8" 811207c920 new code should use UTF-8 0ffd835f96 Squashed commit of the following: 1e7e03ded0 Merge branch 'master' into feature/xml.lite_tweaks c1d806affa Merge branch 'master' into feature/xml.lite_tweaks 850d3c811d str::strip() that can be easier to use than str::trim() 580ba9c8c3 explicitly =delete move 2b39831a80 Squashed commit of the following: 39eebdc23f Merge branch 'master' into feature/xml.lite_tweaks 9adf86cbaf force calling new UTF-8 write() routines ea61b62045 Merge branch 'master' into feature/xml.lite_tweaks 8a34583fa0 overload to take schemaPaths as filesystem::path 8671b442f7 parse XML embedded in a binary file ec4a902f14 updates from xerces.lite 80dc4d9635 updates from xerces.lite 549766d6c1 Attributes::contains() no longer catches an exception 8a645ceac3 need "sys/" when building in other environments 36af082690 super-simple URI validation 78ef28a3e2 SWIG bindings are a PITA! :-( e9cba8491e SWIG needs help with Uri 8a8d8dc072 another routines used by pre-build SWIG bindings 818e1ec5d3 pre-build SWIG bindings use getElementByTagName() member function 067cac5d85 old compiler gets confused on unadorned QName ba92c0ae7e more use of Uri and QName 446c7d17a7 use QName in new code d6f8b0c836 more direct use of QName 90fff1c737 use xml::lite::QName instead of tuple 646cbb5ed4 more direct use of QName and Uri ba589ea3b3 make QName more robust bab0ee8b5e createElement() -> addNewElement() e3a145747a grab changes from six-library 32285e95c4 Merge branch 'master' into feature/xml.lite_tweaks 9f79f0bf62 Merge branch 'master' into feature/xml.lite_tweaks a12bbc32c6 make it easier to create new Elements with a value fc9967f986 make it easy for callers to addChild() keep a reference to the Element 4627766b7d be sure test_xmlparser works in "externals" of other projects bf22763961 "private" is part of the name-mangling fad92bcc8f making sure copy-ctor is implemented f90fdcead0 consolidate common XML test code 9fc53f2d51 use str:: utility for casting 6da6f794bb still trying to find the right macro for SWIG 0c1b86c566 still trying to fix SWIG fdc6fc9bd6 trying to fix SWIG build error 7835e8c270 SWIG needs copy-ctor 585695942d disable copy/assignment for Element, it's probably almost always wrong 391fed6135 fix double-delete caused by copying 61790fe695 retry parsing XML with Windows-1252 if first parse() fails 63cffac59e change string_encoding to match coda-oss style of PascalCase 010479bbec read an XML file we know is wrongly encoded as Windows-1252 9a05050621 more references instead of pointers 2d44b69519 Reading Windows-1252 w/o "encoding" fails 63dc7b0762 read Windows-1252 too c9434c9cbe test as UIT-8 too f310ccf0cf get reading from UTF-8 XML working on Windows 1fa39c2be0 get testReadUtf8XmlFile working on Linux 1a83cd8157 sys::Path is too much trouble right now ed60aa22c9 unit-test to read XML from a file a9336db7c6 Squashed commit of the following: 0825beb0d3 Merge branch 'master' into feature/xml.lite_tweaks c618489be7 Merge branch 'master' into feature/xml.lite_tweaks e8e4b8fe1d determine string_encoding based on platform 1f43bcfc26 create a new Element by using the platform to determine "characterData" encoding 961bef66b4 Merge branch 'master' into feature/xml.lite_tweaks e9798a5cba fix static_assert() 6f77728748 Merge branch 'master' into feature/xml.lite_tweaks b98d4f5a91 Merge branch 'master' into feature/xml.lite_tweaks 1b5abba2a6 The (old) version of SWIG we're using doesn't like certain C++11 features. 53bdeabaf7 Merge branch 'master' into feature/xml.lite_tweaks 60cf8ae80f "" doesn't work with decltype() in older C++ 97e72477a5 reduce getValue() overloads by making "key" a template argument 5e6373e557 reduce code duplication f9e7cfeee5 provide castValue instead of getValue(T&) cbd0bd8f24 castValue throws instead of returning a bool like getValue(T&) 87c7514fce Merge branch 'master' into feature/xml.lite_tweaks 10cc61223a make getElement*() consistent for zero or >1 results f5b137e3cd Merge branch 'master' into feature/xml.lite_tweaks 1765efc622 allow clients to specify toType() and toString() for getValue() and setValue() df8b746e12 allow clients to specify their own toType/toString routines 66702726ad Merge branch 'master' into feature/xml.lite_tweaks 6956311f14 Merge branch 'master' into feature/xml.lite_tweaks d505f3593a Merge branch 'master' into feature/xml.lite_tweaks fbd106115f catch a BadCastException and return false from getValue() 3a78377b55 use a template to reduce duplicated code 0ad4b86062 Merge branch 'master' into feature/xml.lite_tweaks a848aa3a20 get & set the characer data as a type f3ee1ee12a utility routines to set an attribute value 5952276839 templates to get an attribute value convert to a specific type 06639227b3 miised a change in last commit 1aa458ef8b add getValue() overloads that return true/false rather than throwing faa6d30752 added getElementByTagName() overloads as that's a very common use-case git-subtree-dir: externals/coda-oss git-subtree-split: e2472acfc1b31119a1dfbeaced003bfdffe80118 --- .github/workflows/build_unittest.yml | 73 +- .gitignore | 2 +- CMakeLists.txt | 1 + ReleaseNotes.md | 14 +- UnitTest/CppUnitTestAssert.cpp | 42 +- UnitTest/TestCase.h | 137 +--- UnitTest/UnitTest.vcxproj | 59 +- UnitTest/UnitTest.vcxproj.filters | 51 ++ UnitTest/avx.cpp | 2 + UnitTest/hdf5.lite.cpp | 25 + UnitTest/mem.cpp | 3 + UnitTest/mt.cpp | 15 + UnitTest/pch.h | 76 +- UnitTest/polygon.cpp | 3 + UnitTest/str.cpp | 1 + UnitTest/sys.cpp | 21 + UnitTest/types.cpp | 10 + UnitTest/xml.lite.cpp | 33 + UnitTest/zip.cpp | 13 + build/build.py | 12 +- build/dumplibimpl.py | 3 +- cmake/CodaFindSystemDependencies.cmake | 3 - coda-oss-lite.sln => coda-oss.sln | 10 +- modules/CMakeLists.txt | 2 + modules/c++/CMakeLists.txt | 27 +- modules/c++/cli/include/cli/Argument.h | 20 +- modules/c++/cli/source/Argument.cpp | 4 +- modules/c++/cli/source/ArgumentParser.cpp | 14 +- modules/c++/coda-oss.ruleset | 699 ++++++++++++++++++ ...coda-oss-lite.vcxproj => coda-oss.vcxproj} | 156 +++- ...xproj.filters => coda-oss.vcxproj.filters} | 409 +++++++++- .../c++/coda_oss/include/coda_oss/CPlusPlus.h | 3 +- modules/c++/coda_oss/include/coda_oss/bit.h | 62 +- .../c++/coda_oss/include/coda_oss/cstddef.h | 4 + .../c++/coda_oss/include/coda_oss/memory.h | 67 -- .../c++/coda_oss/include/coda_oss/numbers.h | 83 +++ modules/c++/coda_oss/include/coda_oss/span.h | 38 +- modules/c++/config/include/config/Version.h | 8 +- .../c++/dbi/source/DatabaseClientFactory.cpp | 2 +- modules/c++/dbi/source/MySQLConnection.cpp | 2 +- modules/c++/dbi/source/OracleConnection.cpp | 28 +- modules/c++/dbi/source/PgSQLConnection.cpp | 2 +- modules/c++/except/include/except/Throwable.h | 6 +- modules/c++/except/source/Backtrace.cpp | 6 +- modules/c++/except/source/Trace.cpp | 7 +- modules/c++/framework.h | 12 +- modules/c++/gsl/include/gsl/Gsl_.h | 4 +- modules/c++/gsl/include/gsl/gsl.h | 4 +- modules/c++/gsl/include/gsl/use_gsl.h | 8 +- modules/c++/hdf5.lite/include/hdf5/lite/H5_.h | 72 ++ .../include/hdf5/lite/HDF5Exception.h | 2 + .../c++/hdf5.lite/include/hdf5/lite/Info.h | 2 +- .../c++/hdf5.lite/include/hdf5/lite/Read.h | 2 +- .../c++/hdf5.lite/include/hdf5/lite/Write.h | 7 +- .../hdf5.lite/include/hdf5/lite/highfive.h | 83 ++- modules/c++/hdf5.lite/source/H5.h | 7 +- modules/c++/hdf5.lite/source/hdf5.lite.h | 7 +- .../c++/hdf5.lite/unittests/test_highfive.cpp | 255 +++++-- modules/c++/include/TestCase.h | 4 +- modules/c++/include/UnitTest.h | 143 ++++ .../c++/io/include/io/FileOutputStreamOS.h | 5 +- modules/c++/io/include/io/PipeStream.h | 2 +- modules/c++/io/include/io/ReadUtils.h | 9 +- modules/c++/io/include/io/Serializable.h | 2 +- modules/c++/io/source/FileInputStreamOS.cpp | 6 +- modules/c++/io/source/InputStream.cpp | 2 +- modules/c++/io/source/MMapInputStream.cpp | 4 +- modules/c++/io/source/PipeStream.cpp | 2 +- modules/c++/io/source/ReadUtils.cpp | 2 + modules/c++/io/source/StandardStreams.cpp | 4 +- modules/c++/io/source/StreamSplitter.cpp | 2 +- .../unittests/test_exception_logger.cpp | 2 +- .../include/math/linear/MatrixMxN.h | 2 +- modules/c++/math/CMakeLists.txt | 3 +- modules/c++/math/include/math/Constants.h | 16 +- modules/c++/math/include/math/Round.h | 20 +- modules/c++/math/source/Bessel.cpp | 7 +- modules/c++/math/tests/complexBenchmark.cpp | 4 +- .../math/tests/complexMultiplyBenchmark.cpp | 4 +- modules/c++/math/unittests/test_sign.cpp | 11 + modules/c++/math/wscript | 4 +- modules/c++/mem/include/mem/AutoPtr.h | 1 - modules/c++/mem/include/mem/ScopedPtr.h | 20 +- modules/c++/mem/include/mem/ScratchMemory.h | 7 +- modules/c++/mem/include/mem/ScratchMemory.hpp | 2 +- modules/c++/mem/include/mem/SharedPtrCpp11.h | 5 +- modules/c++/mem/source/ScratchMemory.cpp | 25 +- .../c++/mem/tests/ScratchVisualization.cpp | 14 +- modules/c++/mem/unittests/test_Span.cpp | 36 + .../c++/mem/unittests/test_scratch_memory.cpp | 2 +- modules/c++/mem/unittests/test_shared_ptr.cpp | 12 +- modules/c++/mt/include/import/mt.h | 16 +- .../c++/mt/include/mt/AbstractThreadPool.h | 5 + modules/c++/mt/include/mt/Algorithm.h | 39 +- modules/c++/mt/include/mt/RequestQueue.h | 6 +- modules/c++/mt/include/mt/ThreadedByteSwap.h | 90 +++ modules/c++/mt/include/mt/WorkerThread.h | 8 +- .../c++/mt/source/GenerationThreadPool.cpp | 6 +- .../c++/mt/source/GenericRequestHandler.cpp | 2 +- modules/c++/mt/source/ThreadGroup.cpp | 4 +- .../c++/mt/tests/ThreadGroupAffinityTest.cpp | 6 +- modules/c++/mt/unittests/Runnable1DTest.cpp | 24 - .../c++/mt/unittests/test_mt_byte_swap.cpp | 72 ++ modules/c++/net.ssl/source/SSLConnection.cpp | 8 +- .../source/SSLConnectionClientFactory.cpp | 4 +- .../c++/net/include/net/NetConnectionServer.h | 9 +- .../net/PerRequestThreadAllocStrategy.h | 8 +- modules/c++/net/include/net/SocketsWin32.h | 19 +- .../net/include/net/ThreadPoolAllocStrategy.h | 10 + modules/c++/net/source/CurlHandle.cpp | 4 +- .../c++/net/source/NetConnectionServer.cpp | 2 +- modules/c++/net/source/NetUtils.cpp | 2 +- modules/c++/net/source/SocketAddress.cpp | 4 +- modules/c++/net/source/URL.cpp | 6 +- modules/c++/net/tests/AckMulticastSender.cpp | 4 +- .../c++/net/tests/NetConnectionServerTest.cpp | 2 +- modules/c++/net/tests/TCPClientTest.cpp | 2 +- modules/c++/net/tests/UDPClientTest.cpp | 2 +- .../include/numpyutils/numpyutils.h | 28 +- modules/c++/numpyutils/source/numpyutils.cpp | 17 +- modules/c++/pch.h | 112 ++- .../polygon/include/polygon/Intersections.h | 29 +- modules/c++/re/include/re/Regex.h | 6 +- modules/c++/re/source/RegexPCRE.cpp | 23 +- modules/c++/re/source/RegexSTL.cpp | 33 +- modules/c++/sio.lite/CMakeLists.txt | 2 +- .../c++/sio.lite/include/sio/lite/ReadUtils.h | 5 +- .../sio.lite/include/sio/lite/SioFileWriter.h | 5 + modules/c++/sio.lite/source/FileHeader.cpp | 1 + modules/c++/sio.lite/source/StreamReader.cpp | 4 +- modules/c++/sio.lite/wscript | 2 +- modules/c++/std/include/import/cpp14.h | 61 -- modules/c++/std/include/import/cpp17.h | 36 - modules/c++/std/include/import/std.h | 64 +- modules/c++/std/include/std/bit | 20 +- modules/c++/std/include/std/cstddef | 4 + modules/c++/std/include/std/memory | 20 +- modules/c++/std/include/std/numbers | 49 ++ modules/c++/std/include/std/span | 3 + modules/c++/str/CMakeLists.txt | 2 +- modules/c++/str/include/str/Convert.h | 22 +- modules/c++/str/include/str/Format.h | 2 +- modules/c++/str/include/str/Manip.h | 9 +- modules/c++/str/include/str/Tokenizer.h | 2 +- modules/c++/str/source/EncodedStringView.cpp | 32 +- modules/c++/str/source/Encoding.cpp | 94 ++- modules/c++/str/source/Format.cpp | 19 +- modules/c++/str/source/Manip.cpp | 66 +- .../c++/str/unittests/test_base_convert.cpp | 13 +- modules/c++/str/unittests/test_str.cpp | 115 ++- modules/c++/str/wscript | 2 +- modules/c++/sys/include/sys/AbstractOS.h | 35 +- .../c++/sys/include/sys/AtomicCounterCpp11.h | 8 +- modules/c++/sys/include/sys/ByteSwap.h | 298 ++++++++ modules/c++/sys/include/sys/ByteSwapValue.h | 200 +++++ .../sys/include/sys/ConditionVarInterface.h | 4 +- modules/c++/sys/include/sys/Conf.h | 132 +--- modules/c++/sys/include/sys/DateTime.h | 12 +- modules/c++/sys/include/sys/Dbg.h | 34 +- modules/c++/sys/include/sys/Err.h | 8 +- modules/c++/sys/include/sys/FileFinder.h | 6 +- modules/c++/sys/include/sys/LocalDateTime.h | 2 +- modules/c++/sys/include/sys/MutexCpp11.h | 2 +- modules/c++/sys/include/sys/MutexWin32.h | 2 +- modules/c++/sys/include/sys/OS.h | 45 +- modules/c++/sys/include/sys/OSUnix.h | 6 + modules/c++/sys/include/sys/OSWin32.h | 10 +- modules/c++/sys/include/sys/ReadWriteMutex.h | 2 +- modules/c++/sys/include/sys/Span.h | 194 +++++ .../sys/include/sys/{String.h => SysInt.h} | 24 +- modules/c++/sys/include/sys/ThreadInterface.h | 2 +- modules/c++/sys/include/sys/ThreadPosix.h | 2 +- modules/c++/sys/include/sys/TimeStamp.h | 4 +- modules/c++/sys/source/AbstractOS.cpp | 72 +- modules/c++/sys/source/ConditionVarPosix.cpp | 10 +- modules/c++/sys/source/ConditionVarWin32.cpp | 15 +- modules/c++/sys/source/Conf.cpp | 322 +++++++- .../c++/sys/source/CppUnitTestAssert_.cpp_ | 43 ++ modules/c++/sys/source/DLLUnix.cpp | 6 +- modules/c++/sys/source/DLLWin32.cpp | 6 +- modules/c++/sys/source/DateTime.cpp | 18 +- modules/c++/sys/source/Dbg.cpp | 24 +- modules/c++/sys/source/ErrUnix.cpp | 2 +- modules/c++/sys/source/ErrWin32.cpp | 4 +- modules/c++/sys/source/ExecUnix.cpp | 10 +- modules/c++/sys/source/ExecWin32.cpp | 23 +- modules/c++/sys/source/FileFinder.cpp | 35 +- modules/c++/sys/source/FileUnix.cpp | 2 +- modules/c++/sys/source/FileWin32.cpp | 6 +- modules/c++/sys/source/LocalDateTime.cpp | 2 +- modules/c++/sys/source/MutexPosix.cpp | 2 +- modules/c++/sys/source/MutexWin32.cpp | 4 +- modules/c++/sys/source/OSUnix.cpp | 38 +- modules/c++/sys/source/OSWin32.cpp | 50 +- modules/c++/sys/source/Path.cpp | 12 +- modules/c++/sys/source/ResourceCheck.cpp | 3 +- .../c++/sys/source/ScopedCPUAffinityUnix.cpp | 9 +- modules/c++/sys/source/SemaphoreWin32.cpp | 10 +- modules/c++/sys/source/StopWatch.cpp | 6 +- modules/c++/sys/source/ThreadPosix.cpp | 12 +- modules/c++/sys/source/ThreadWin32.cpp | 4 +- modules/c++/sys/source/UTCDateTime.cpp | 2 +- modules/c++/sys/source/sys_Backtrace.cpp | 2 +- modules/c++/sys/tests/DLLTest.cpp | 2 +- modules/c++/sys/tests/DateTimeTest.cpp | 4 +- modules/c++/sys/tests/OSTest.cpp | 4 +- modules/c++/sys/unittests/test_byte_swap.cpp | 236 +++++- modules/c++/sys/unittests/test_os.cpp | 12 + modules/c++/sys/unittests/test_path.cpp | 59 ++ modules/c++/tiff/include/tiff/GenericType.h | 3 +- modules/c++/tiff/source/IFD.cpp | 4 +- modules/c++/tiff/source/IFDEntry.cpp | 9 +- modules/c++/tiff/source/ImageReader.cpp | 2 +- modules/c++/tiff/source/ImageWriter.cpp | 16 +- modules/c++/tiff/source/KnownTags.cpp | 2 +- modules/c++/tiff/source/TypeFactory.cpp | 2 +- modules/c++/tiff/source/Utils.cpp | 10 +- modules/c++/types/CMakeLists.txt | 2 +- modules/c++/types/include/types/Complex.h | 233 ++++++ modules/c++/types/include/types/PageRowCol.h | 44 +- modules/c++/types/include/types/RowCol.h | 3 +- modules/c++/types/unittests/test_complex.cpp | 59 ++ .../c++/types/unittests/test_page_row_col.cpp | 4 +- modules/c++/types/wscript | 2 +- modules/c++/unique/source/UUID.cpp | 2 +- modules/c++/unique/wscript | 1 - .../c++/xml.lite/include/import/xml/lite.h | 42 +- .../xml.lite/include/xml/lite/Attributes.h | 24 +- .../include/xml/lite/ContentHandler.h | 8 +- .../c++/xml.lite/include/xml/lite/Document.h | 9 +- .../c++/xml.lite/include/xml/lite/Element.h | 48 +- .../include/xml/lite/MinidomHandler.h | 10 +- .../xml.lite/include/xml/lite/MinidomParser.h | 5 +- modules/c++/xml.lite/include/xml/lite/QName.h | 17 +- .../xml.lite/include/xml/lite/Serializable.h | 6 +- .../include/xml/lite/UtilitiesXerces.h | 36 +- .../include/xml/lite/ValidatorInterface.h | 13 +- .../include/xml/lite/ValidatorXerces.h | 27 +- .../include/xml/lite/XMLReaderInterface.h | 12 +- .../include/xml/lite/XMLReaderXerces.h | 5 +- .../c++/xml.lite/include/xml/lite/xerces_.h | 102 +++ modules/c++/xml.lite/source/Document.cpp | 8 +- modules/c++/xml.lite/source/Element.cpp | 58 +- .../c++/xml.lite/source/MinidomHandler.cpp | 2 +- .../c++/xml.lite/source/NamespaceStack.cpp | 1 + modules/c++/xml.lite/source/QName.cpp | 2 +- modules/c++/xml.lite/source/Serializable.cpp | 6 +- .../c++/xml.lite/source/ValidatorXerces.cpp | 41 +- .../c++/xml.lite/source/XMLReaderXerces.cpp | 1 + .../xml.lite/unittests/test_soapelements.cpp | 13 +- .../xml.lite/unittests/test_xmlattribute.cpp | 35 +- .../xml.lite/unittests/test_xmlelement.cpp | 32 +- .../c++/xml.lite/unittests/test_xmlparser.cpp | 137 ++-- modules/c++/zip/include/zip/GZipInputStream.h | 12 +- .../c++/zip/include/zip/GZipOutputStream.h | 11 +- modules/c++/zip/source/GZipInputStream.cpp | 4 +- modules/c++/zip/source/GZipOutputStream.cpp | 4 +- modules/c++/zip/source/ZipEntry.cpp | 6 +- modules/c++/zip/source/ZipOutputStream.cpp | 12 +- modules/c++/zip/unittests/unittest_GZip.cpp | 26 +- modules/drivers/j2k/openjpeg/CMakeLists.txt | 6 +- modules/drivers/jpeg/CMakeLists.txt | 12 +- modules/drivers/pcre/CMakeLists.txt | 8 +- modules/drivers/uuid/CMakeLists.txt | 2 +- modules/drivers/xml/xerces/CMakeLists.txt | 54 +- .../sys/source/generated/coda_sys_wrap.cxx | 2 +- 266 files changed, 6031 insertions(+), 1702 deletions(-) create mode 100644 UnitTest/hdf5.lite.cpp create mode 100644 UnitTest/xml.lite.cpp create mode 100644 UnitTest/zip.cpp rename coda-oss-lite.sln => coda-oss.sln (73%) create mode 100644 modules/c++/coda-oss.ruleset rename modules/c++/{coda-oss-lite.vcxproj => coda-oss.vcxproj} (71%) rename modules/c++/{coda-oss-lite.vcxproj.filters => coda-oss.vcxproj.filters} (72%) delete mode 100644 modules/c++/coda_oss/include/coda_oss/memory.h create mode 100644 modules/c++/coda_oss/include/coda_oss/numbers.h create mode 100644 modules/c++/hdf5.lite/include/hdf5/lite/H5_.h create mode 100644 modules/c++/include/UnitTest.h create mode 100644 modules/c++/mt/include/mt/ThreadedByteSwap.h create mode 100644 modules/c++/mt/unittests/test_mt_byte_swap.cpp delete mode 100644 modules/c++/std/include/import/cpp14.h delete mode 100644 modules/c++/std/include/import/cpp17.h create mode 100644 modules/c++/std/include/std/numbers create mode 100644 modules/c++/sys/include/sys/ByteSwap.h create mode 100644 modules/c++/sys/include/sys/ByteSwapValue.h create mode 100644 modules/c++/sys/include/sys/Span.h rename modules/c++/sys/include/sys/{String.h => SysInt.h} (59%) create mode 100644 modules/c++/sys/source/CppUnitTestAssert_.cpp_ create mode 100644 modules/c++/types/include/types/Complex.h create mode 100644 modules/c++/types/unittests/test_complex.cpp create mode 100644 modules/c++/xml.lite/include/xml/lite/xerces_.h diff --git a/.github/workflows/build_unittest.yml b/.github/workflows/build_unittest.yml index 729efd090..b96a17a63 100644 --- a/.github/workflows/build_unittest.yml +++ b/.github/workflows/build_unittest.yml @@ -11,9 +11,9 @@ jobs: name: ${{ matrix.os }}-${{ matrix.python-version }}-CMake runs-on: ${{ matrix.os }} steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Set up Python - uses: actions/setup-python@v2 + uses: actions/setup-python@v3 with: python-version: ${{ matrix.python-version }} - name: Install python dependencies @@ -36,20 +36,58 @@ jobs: cd .. cd target-Debug cmake --build . --config Debug -j - - name: install + - name: test # should run w/o install run: | cd target-Release - cmake --build . --config Release --target install + ctest -C Release --output-on-failure cd .. cd target-Debug - cmake --build . --config Debug --target install - - name: test + ctest -C Debug --output-on-failure + - name: install run: | cd target-Release - ctest -C Release + cmake --build . --config Release --target install cd .. cd target-Debug - ctest -C Debug + cmake --build . --config Debug --target install + cd .. + + build-msbuild-windows: + strategy: + matrix: + os: [windows-latest] + platform: [x64] + configuration: [Debug] # Debug turns on more compiler warnings + name: ${{ matrix.os }}-msbuild + runs-on: ${{ matrix.os }} + + steps: + - uses: actions/checkout@v3 + - name: configure + run: | + ls env: + mkdir out + cd out + cmake .. -DCMAKE_INSTALL_PREFIX=install\${{ matrix.platform }}-${{ matrix.configuration }} -DENABLE_PYTHON=OFF + - name: build + run: | + cd out + cmake --build . --config ${{ matrix.configuration }} -j + cmake --build . --config ${{ matrix.configuration }} --target install + - name: Add msbuild to PATH + uses: microsoft/setup-msbuild@v1 # https://github.com/marketplace/actions/setup-msbuild + with: + msbuild-architecture: x64 + - name: msbuild + run: | + msbuild coda-oss.sln /p:configuration=${{ matrix.configuration }} + # Can't figure out how to make this work :-( + #- name: vstest + # uses: microsoft/vstest-action@v1.0.0 # https://github.com/marketplace/actions/vstest-action + # with: + # testAssembly: UnitTest.dll + # searchFolder: D:\a\nitro\nitro\${{ matrix.platform }}\${{ matrix.configuration }} + # runInParallel: true build-linux-cmake: strategy: @@ -59,9 +97,9 @@ jobs: name: ${{ matrix.os }}-${{ matrix.python-version }}-CMake runs-on: ${{ matrix.os }} steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Set up Python - uses: actions/setup-python@v2 + uses: actions/setup-python@v3 with: python-version: ${{ matrix.python-version }} - name: Install python dependencies @@ -79,14 +117,15 @@ jobs: cd target # "-j" spawns too many processes causing GCC to crash cmake --build . -j 12 - - name: install + - name: test + # should run w/o install run: | cd target - cmake --build . --target install - - name: test + ctest --output-on-failure + - name: install run: | cd target - ctest + cmake --build . --target install build-waf: strategy: @@ -94,12 +133,12 @@ jobs: os: [ubuntu-latest, windows-2019] python-version: ['3.7'] debugging: ['--enable-debugging', ''] - name: ${{ matrix.os }}-${{ matrix.python-version }}-waf + name: ${{ matrix.os }}-${{ matrix.python-version }}-waf${{ matrix.debugging }} runs-on: ${{ matrix.os }} steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Set up Python - uses: actions/setup-python@v2 + uses: actions/setup-python@v3 with: python-version: ${{ matrix.python-version }} - name: configure_with_swig diff --git a/.gitignore b/.gitignore index 7489cb720..8549527fe 100644 --- a/.gitignore +++ b/.gitignore @@ -53,4 +53,4 @@ project.sln *.vcxproj.user # Unit-tests -TEST_*_TMP.* +TEST_*_TMP*.* diff --git a/CMakeLists.txt b/CMakeLists.txt index f1aa8e5ac..4b1bc2c64 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -31,6 +31,7 @@ if (${CMAKE_PROJECT_NAME} STREQUAL coda-oss) endif() elseif (UNIX) add_compile_options(-Werror) # warnings as errors + if (ENABLE_ASAN) # https://gcc.gnu.org/onlinedocs/gcc/Instrumentation-Options.html add_compile_options(-fsanitize=address) diff --git a/ReleaseNotes.md b/ReleaseNotes.md index f473ce016..c54bdadcb 100644 --- a/ReleaseNotes.md +++ b/ReleaseNotes.md @@ -11,17 +11,23 @@ ``` # coda-oss Release Notes -## [Release 2023-??-??](https://github.com/mdaus/coda-oss/releases/tag/2023-??-??) +## [Release 2023-06-05](https://github.com/mdaus/coda-oss/releases/tag/2023-06-05) * *zlib* updated to [1.2.13](https://github.com/madler/zlib/releases/tag/v1.2.13). * new `mem::ComplexView` class to make it easier to process complex data stored in parallel. * adjust compiler flags for clean *CMake* builds. * wrap common "file open" routines (e.g., `fopen()`) to support `sys::expandEnvironmentVariables()`. * add header-only [HighFive](https://github.com/BlueBrain/HighFive) HDF5-wrapper library. +* Added a handful of [HighFive](https://github.com/BlueBrain/HighFive) utility routines. +* `mt::transform_async()` removed, it doesn't match C++17 techniques. +* Revamp `sys::byteSwap()` for improved type-safety and + [better performance](https://devblogs.microsoft.com/cppblog/a-tour-of-4-msvc-backend-improvements/). + * Added case-insensitive string comparison utilities: `str::eq()` and `str::ne()`; + `xml::lite::Uri`s compare case-insensitive. ## [Release 2022-12-14](https://github.com/mdaus/coda-oss/releases/tag/2022-12-14) * removed remaining vestiges of `std::auto_ptr`, provide `mem::AutoPtr` for the tiny handful of places (e.g., SWIG bindings) that still need copying. -* `xml::lite::Element` overloads to make creting new XML documents easier; see unittests for examples. +* `xml::lite::Element` overloads to make creating new XML documents easier; see unittests for examples. * try even harder to find unittest files in various scenarios. * build *hdf5.lite* with **waf**. * New `--optz=fastest-possible` (**waf** only) which adds @@ -34,8 +40,8 @@ * The [HDFGroup](https://hdfgroup.org/)s [HDF5 library](https://github.com/HDFGroup/hdf5) is built and installed; a simple (and very incomplete!) wrapper is provided, this is at the "hello world!" stage. * A few **cli** routines have been tweaked to make unit-testing easier. -* Utilitiy routines for finding various files when unit-testing. -* Removed C++14 work-arounds needed in C++11. Legacy C++ exception specificatons removed. +* Utility routines for finding various files when unit-testing. +* Removed C++14 work-arounds needed in C++11. Legacy C++ exception specifications removed. * Rebuild `waf` for FIPS error; added more debug options. ## [Release 2022-08-30](https://github.com/mdaus/coda-oss/releases/tag/2022-08-30) diff --git a/UnitTest/CppUnitTestAssert.cpp b/UnitTest/CppUnitTestAssert.cpp index fdcf5f92b..5bea8da59 100644 --- a/UnitTest/CppUnitTestAssert.cpp +++ b/UnitTest/CppUnitTestAssert.cpp @@ -1,43 +1,5 @@ #include "pch.h" #include "TestCase.h" -#include "str/EncodedStringView.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -// EQUALS_MESSAGE() wants ToString() specializations (or overloads) for our types, which is a nusiance. -// This hooks up our existing str::toString() into the VC++ unit-test infrastructure - -// C++ hack to call private methods -// https://stackoverflow.com/a/71578383/8877 - -using FailOnCondition_t = void(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare method's type -using GetAssertMessage_t = std::wstring(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare method's type -template -struct caller final // helper structure to inject call() code -{ - friend void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) - { - fFailOnCondition(condition, message, pLineInfo); - } - - friend std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message) - { - return fGetAssertMessage(equality, expected, actual, message); - } -}; -template struct caller<&Assert::FailOnCondition, &Assert::GetAssertMessage>; // even instantiation of the helper - -void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare caller -void test::Assert::FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) -{ - ::FailOnCondition(condition, message, pLineInfo); // and call! -} - -std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare caller -std::wstring test::Assert::GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message) -{ - const str::EncodedStringView vExpected(expected); - const str::EncodedStringView vActual(actual); - return ::GetAssertMessage(equality, vExpected.wstring(), vActual.wstring(), message); // and call! -} +// Can't get this to build in the **coda-oss** project. +#include "sys/source/CppUnitTestAssert_.cpp_" diff --git a/UnitTest/TestCase.h b/UnitTest/TestCase.h index f4438821f..e769f584f 100644 --- a/UnitTest/TestCase.h +++ b/UnitTest/TestCase.h @@ -1,138 +1,3 @@ #pragma once -#include -#include - -#include "CppUnitTest.h" -#include -#include - -#undef TEST_CHECK -#undef TEST_ASSERT -#undef TEST_ASSERT_NULL -#undef TEST_ASSERT_NOT_NULL -#undef TEST_ASSERT_TRUE -#undef TEST_ASSERT_FALSE -#undef TEST_MAIN -#undef TEST_CASE -#define TEST_CHECK(X) -#define TEST_MAIN(X) -#define TEST_ASSERT_NULL(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNull(X) -#define TEST_ASSERT_NOT_NULL(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNotNull(X) -#define TEST_ASSERT_TRUE(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(X) -#define TEST_ASSERT_FALSE(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsFalse(X) -#define TEST_ASSERT(X) TEST_ASSERT_TRUE(X) -#define CODA_OSS_testMethod_(X) testMethod ## _ ## X -#define TEST_CASE(X) TEST_METHOD(X) { CODA_OSS_testMethod_(X)(#X); } void CODA_OSS_testMethod_(X)(std::string testName) - -namespace test -{ - struct Assert final - { - static void FailOnCondition(bool condition, const unsigned short* message, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo); - static std::wstring GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message); - }; -#define CODA_OSS_equals_message_(expected, actual, message) reinterpret_cast(test::Assert::GetAssertMessage(true, test::toString(expected), test::toString(actual), message).c_str()) -#define CODA_OSS_not_equals_message_(notExpected, actual, message) reinterpret_cast(test::Assert::GetAssertMessage(false, test::toString(notExpected), test::toString(actual), message).c_str()) -#define CODA_OSS_message_(message) reinterpret_cast(test::Assert::GetAssertMessage(false, "", "", message).c_str()) - -// see Assert::AreEqual<> -template -inline void diePrintf_eq(const TExpected& expected, const TActual& actual, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(expected == actual, CODA_OSS_equals_message_(expected, actual, message), pLineInfo); -} - -// see Assert::AreNotEqual<> -template -inline void diePrintf_ne(const TExpected& notExpected, const TActual& actual, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(notExpected != actual, CODA_OSS_not_equals_message_(notExpected, actual, message), pLineInfo); -} - -template -inline void diePrintf_ge(const TX1& X1, const TX2& X2, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(X1 >= X2, CODA_OSS_message_(message), pLineInfo); -} -template -inline void diePrintf_gt(const TX1& X1, const TX2& X2, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(X1 > X2, CODA_OSS_message_(message), pLineInfo); -} -template -inline void diePrintf_le(const TX1& X1, const TX2& X2, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(X1 <= X2, CODA_OSS_message_(message), pLineInfo); -} -template -inline void diePrintf_lt(const TX1& X1, const TX2& X2, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(X1 < X2, CODA_OSS_message_(message), pLineInfo); -} - -} -#undef CODA_OSS_test_diePrintf_eq_ -#undef CODA_OSS_test_diePrintf_not_eq_ -#define CODA_OSS_test_diePrintf_eq_(X1, X2) testName, ::test::diePrintf_eq(X1, X2) -#define CODA_OSS_test_diePrintf_not_eq_(X1, X2) testName, ::test::diePrintf_ne(X1, X2) - -#undef CODA_OSS_test_diePrintf_greater_eq_ -#undef CODA_OSS_test_diePrintf_greater_ -#undef CODA_OSS_test_diePrintf_lesser_eq_ -#undef CODA_OSS_test_diePrintf_lesser_ -#define CODA_OSS_test_diePrintf_greater_eq_(X1, X2) testName, ::test::diePrintf_ge(X1, X2) -#define CODA_OSS_test_diePrintf_greater_(X1, X2) testName, ::test::diePrintf_gt(X1, X2) -#define CODA_OSS_test_diePrintf_lesser_eq_(X1, X2) testName, ::test::diePrintf_le(X1, X2) -#define CODA_OSS_test_diePrintf_lesser_(X1, X2) testName, ::test::diePrintf_lt(X1, X2) - -template -inline void test_assert_greater_(const TX1& X1, const TX2& X2) -{ - Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(X1 > X2); -} -#undef TEST_ASSERT_GREATER -#define TEST_ASSERT_GREATER(X1, X2) testName, test_assert_greater_(X1, X2) - -#undef TEST_ASSERT_ALMOST_EQ_EPS -#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) { (void)testName; Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(X1, X2, EPS); Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(X2, X1, EPS); } -namespace test -{ -inline void assert_almost_eq(const std::string& testName, float X1, float X2) -{ - constexpr auto EPS = static_cast(0.0001); - TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS); -} -inline void assert_almost_eq(const std::string& testName, double X1, double X2) -{ - constexpr auto EPS = static_cast(0.0001); - TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS); -} -inline void assert_almost_eq(const std::string& testName, long double X1, long double X2) -{ - assert_almost_eq(testName, static_cast(X1), static_cast(X2)); -} -} - -#undef TEST_ASSERT_ALMOST_EQ -#define TEST_ASSERT_ALMOST_EQ(X1, X2) test::assert_almost_eq(testName, X1, X2) - -#undef TEST_ASSERT_EQ_MSG -#define TEST_ASSERT_EQ_MSG(msg, X1, X2) testName, Microsoft::VisualStudio::CppUnitTestFramework::Logger::WriteMessage(msg.c_str()); TEST_ASSERT_EQ(X1, X2) - -#undef TEST_FAIL_MSG -#define TEST_FAIL_MSG(msg) { (void)testName; const str::EncodedStringView vw(msg); Microsoft::VisualStudio::CppUnitTestFramework::Assert::Fail(vw.wstring().c_str()); } - -#undef TEST_EXCEPTION -#undef TEST_THROWS -#undef TEST_SPECIFIC_EXCEPTION -#define TEST_EXCEPTION(X) (void)testName; try{ (X); TEST_FAIL(#X " should have thrown."); } CODA_OSS_TEST_EXCEPTION_catch_ -#define TEST_THROWS(X) (void)testName; try{ (X); TEST_FAIL(#X " should have thrown."); } catch (...){ TEST_ASSERT_TRUE(true); } -#define TEST_SPECIFIC_EXCEPTION(X, Y) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::ExpectException([&](){(X);}) - +#include diff --git a/UnitTest/UnitTest.vcxproj b/UnitTest/UnitTest.vcxproj index 5f55f6360..835f574dc 100644 --- a/UnitTest/UnitTest.vcxproj +++ b/UnitTest/UnitTest.vcxproj @@ -25,7 +25,6 @@ v143 false Unicode - true DynamicLibrary @@ -34,7 +33,6 @@ true false Unicode - true @@ -59,7 +57,7 @@ Use Level4 true - $(VCInstallDir)UnitTest\include;$(ProjectDir);$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\avx\include\;$(SolutionDir)modules\c++\cli\include\;$(SolutionDir)modules\c++\config\include\;$(SolutionDir)modules\c++\coda_oss\include\;$(SolutionDir)modules\c++\gsl\include\;$(SolutionDir)modules\c++\io\include\;$(SolutionDir)modules\c++\std\include\;$(SolutionDir)modules\c++\str\include\;$(SolutionDir)modules\c++\sys\include\;$(SolutionDir)modules\c++\except\include\;$(SolutionDir)modules\c++\logging\include\;$(SolutionDir)modules\c++\math\include\;$(SolutionDir)modules\c++\math.linear\include\;$(SolutionDir)modules\c++\math.poly\include\;$(SolutionDir)modules\c++\mem\include\;$(SolutionDir)modules\c++\mt\include\;$(SolutionDir)modules\c++\polygon\include\;$(SolutionDir)modules\c++\re\include\;$(SolutionDir)modules\c++\types\include\;$(SolutionDir)modules\c++\units\include\;%(AdditionalIncludeDirectories) + $(VCInstallDir)UnitTest\include;$(ProjectDir);$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\avx\include;$(SolutionDir)modules\c++\cli\include;$(SolutionDir)modules\c++\config\include;$(SolutionDir)modules\c++\coda_oss\include;$(SolutionDir)modules\c++\gsl\include;$(SolutionDir)modules\c++\hdf5.lite\include;$(SolutionDir)modules\c++\io\include;$(SolutionDir)modules\c++\std\include;$(SolutionDir)modules\c++\str\include;$(SolutionDir)modules\c++\sys\include;$(SolutionDir)modules\c++\except\include;$(SolutionDir)modules\c++\logging\include;$(SolutionDir)modules\c++\math\include;$(SolutionDir)modules\c++\math.linear\include;$(SolutionDir)modules\c++\math.poly\include;$(SolutionDir)modules\c++\mem\include;$(SolutionDir)modules\c++\mt\include;$(SolutionDir)modules\c++\polygon\include;$(SolutionDir)modules\c++\re\include;$(SolutionDir)modules\c++\types\include;$(SolutionDir)modules\c++\units\include;$(SolutionDir)modules\c++\xml.lite\include;$(SolutionDir)modules\c++\zip\include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;%(AdditionalIncludeDirectories) _DEBUG;%(PreprocessorDefinitions);MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 true pch.h @@ -67,12 +65,12 @@ true Guard ProgramDatabase - true true true true true /Zc:__cplusplus %(AdditionalOptions) + AdvancedVectorExtensions2 Windows @@ -86,18 +84,18 @@ true true true - $(VCInstallDir)UnitTest\include;$(ProjectDir);$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\avx\include\;$(SolutionDir)modules\c++\cli\include\;$(SolutionDir)modules\c++\config\include\;$(SolutionDir)modules\c++\coda_oss\include\;$(SolutionDir)modules\c++\gsl\include\;$(SolutionDir)modules\c++\io\include\;$(SolutionDir)modules\c++\std\include\;$(SolutionDir)modules\c++\str\include\;$(SolutionDir)modules\c++\sys\include\;$(SolutionDir)modules\c++\except\include\;$(SolutionDir)modules\c++\logging\include\;$(SolutionDir)modules\c++\math\include\;$(SolutionDir)modules\c++\math.linear\include\;$(SolutionDir)modules\c++\math.poly\include\;$(SolutionDir)modules\c++\mem\include\;$(SolutionDir)modules\c++\mt\include\;$(SolutionDir)modules\c++\polygon\include\;$(SolutionDir)modules\c++\re\include\;$(SolutionDir)modules\c++\types\include\;$(SolutionDir)modules\c++\units\include\;%(AdditionalIncludeDirectories) + $(VCInstallDir)UnitTest\include;$(ProjectDir);$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\avx\include;$(SolutionDir)modules\c++\cli\include;$(SolutionDir)modules\c++\config\include;$(SolutionDir)modules\c++\coda_oss\include;$(SolutionDir)modules\c++\gsl\include;$(SolutionDir)modules\c++\hdf5.lite\include;$(SolutionDir)modules\c++\io\include;$(SolutionDir)modules\c++\std\include;$(SolutionDir)modules\c++\str\include;$(SolutionDir)modules\c++\sys\include;$(SolutionDir)modules\c++\except\include;$(SolutionDir)modules\c++\logging\include;$(SolutionDir)modules\c++\math\include;$(SolutionDir)modules\c++\math.linear\include;$(SolutionDir)modules\c++\math.poly\include;$(SolutionDir)modules\c++\mem\include;$(SolutionDir)modules\c++\mt\include;$(SolutionDir)modules\c++\polygon\include;$(SolutionDir)modules\c++\re\include;$(SolutionDir)modules\c++\types\include;$(SolutionDir)modules\c++\units\include;$(SolutionDir)modules\c++\xml.lite\include;$(SolutionDir)modules\c++\zip\include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;%(AdditionalIncludeDirectories) NDEBUG;%(PreprocessorDefinitions);MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 true pch.h true Guard - true true true true true /Zc:__cplusplus %(AdditionalOptions) + AdvancedVectorExtensions2 Windows @@ -115,6 +113,18 @@ true true + + true + true + + + true + true + + + true + true + true true @@ -259,6 +269,10 @@ true true + + true + true + true true @@ -319,6 +333,10 @@ true true + + true + true + true true @@ -335,9 +353,34 @@ true true + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + + true + true + + @@ -355,13 +398,15 @@ + + - + {9997e895-5161-4ddf-8f3f-099894cb2f21} diff --git a/UnitTest/UnitTest.vcxproj.filters b/UnitTest/UnitTest.vcxproj.filters index e85d2fcd0..ab3ead71f 100644 --- a/UnitTest/UnitTest.vcxproj.filters +++ b/UnitTest/UnitTest.vcxproj.filters @@ -219,6 +219,48 @@ re + + mt + + + types + + + hdf5.lite + + + hdf5.lite + + + hdf5.lite + + + hdf5.lite + + + zip + + + zip + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + @@ -270,5 +312,14 @@ {d205c017-7e98-456f-923f-2f78870a3d7d} + + {5997a3de-0dc5-4439-b068-b351c5f395e3} + + + {223c163f-0321-4935-8e20-0e05f048adf0} + + + {f4dfc761-e468-4305-84dc-f3579e46107e} + \ No newline at end of file diff --git a/UnitTest/avx.cpp b/UnitTest/avx.cpp index 535dc859f..907c5ddbc 100644 --- a/UnitTest/avx.cpp +++ b/UnitTest/avx.cpp @@ -1,6 +1,8 @@ #include "pch.h" #include "CppUnitTest.h" +#include + namespace avx { diff --git a/UnitTest/hdf5.lite.cpp b/UnitTest/hdf5.lite.cpp new file mode 100644 index 000000000..6546a2f00 --- /dev/null +++ b/UnitTest/hdf5.lite.cpp @@ -0,0 +1,25 @@ +#include "pch.h" +#include "CppUnitTest.h" + +#include +#include +#include +#include +#include + +namespace hdf5_lite +{ + +TEST_CLASS(test_hdf5info){ public: +#include "hdf5.lite/unittests/test_hdf5info.cpp" +}; + +TEST_CLASS(test_hdf5read){ public: +#include "hdf5.lite/unittests/test_hdf5read.cpp" +}; + +TEST_CLASS(test_hdf5write){ public: +#include "hdf5.lite/unittests/test_hdf5write.cpp" +}; + +} \ No newline at end of file diff --git a/UnitTest/mem.cpp b/UnitTest/mem.cpp index ea35c9405..375bb9384 100644 --- a/UnitTest/mem.cpp +++ b/UnitTest/mem.cpp @@ -3,6 +3,9 @@ #include #include +#include +#include +#include namespace mem { diff --git a/UnitTest/mt.cpp b/UnitTest/mt.cpp index 2de6f17fd..6be7aa933 100644 --- a/UnitTest/mt.cpp +++ b/UnitTest/mt.cpp @@ -1,6 +1,17 @@ #include "pch.h" #include "CppUnitTest.h" +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + namespace mt { @@ -24,4 +35,8 @@ TEST_CLASS(work_sharing_balanced_runnable_1d_test){ public: #include "mt/unittests/work_sharing_balanced_runnable_1d_test.cpp" }; +TEST_CLASS(test_mt_byte_swap){ public: +#include "mt/unittests/test_mt_byte_swap.cpp" +}; + } \ No newline at end of file diff --git a/UnitTest/pch.h b/UnitTest/pch.h index 8229e0b47..8c2ebbb93 100644 --- a/UnitTest/pch.h +++ b/UnitTest/pch.h @@ -24,75 +24,35 @@ #include #include "import/std.h" - -#include -#include -#include -#include #include +#include #include -#include // std::endian +#include +#include +#include +#include +#include #include "CppUnitTest.h" -#include "coda_oss/span.h" -#include "gsl/gsl.h" -#include "import/sys.h" -#include "import/math.h" -#include "import/str.h" -#include "str/EncodedStringView.h" -#include "import/except.h" -#include "import/mem.h" -#include -#include -#include -#include "import/cli.h" -#include "polygon/DrawPolygon.h" -#include "polygon/PolygonMask.h" -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include #include +#include #include #include -#include -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include #include -#include -#include #include #include -#include "io/StringStream.h" +#include +#include +#include + +#include +#include #include "TestCase.h" diff --git a/UnitTest/polygon.cpp b/UnitTest/polygon.cpp index 32bc9fd0b..424f3aa8a 100644 --- a/UnitTest/polygon.cpp +++ b/UnitTest/polygon.cpp @@ -1,6 +1,9 @@ #include "pch.h" #include "CppUnitTest.h" +#include +#include + namespace polygon { TEST_CLASS(test_polygon_mask){ public: diff --git a/UnitTest/str.cpp b/UnitTest/str.cpp index d7fe5b718..a3be22b7c 100644 --- a/UnitTest/str.cpp +++ b/UnitTest/str.cpp @@ -5,6 +5,7 @@ #include #include +#include namespace str { diff --git a/UnitTest/sys.cpp b/UnitTest/sys.cpp index bedfa9818..7ac63c6a1 100644 --- a/UnitTest/sys.cpp +++ b/UnitTest/sys.cpp @@ -1,6 +1,27 @@ #include "pch.h" #include "CppUnitTest.h" +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + namespace sys { TEST_CLASS(test_aligned_alloc){ public: diff --git a/UnitTest/types.cpp b/UnitTest/types.cpp index 1384c00b7..64bb3a272 100644 --- a/UnitTest/types.cpp +++ b/UnitTest/types.cpp @@ -1,6 +1,12 @@ #include "pch.h" #include "CppUnitTest.h" +#include +#include +#include +#include +#include + namespace types { TEST_CLASS(test_page_row_col){ public: @@ -15,4 +21,8 @@ TEST_CLASS(test_range_list){ public: #include "types/unittests/test_range_list.cpp" }; +TEST_CLASS(test_complex){ public: +#include "types/unittests/test_complex.cpp" +}; + } \ No newline at end of file diff --git a/UnitTest/xml.lite.cpp b/UnitTest/xml.lite.cpp new file mode 100644 index 000000000..375a17fe5 --- /dev/null +++ b/UnitTest/xml.lite.cpp @@ -0,0 +1,33 @@ +#include "pch.h" +#include "CppUnitTest.h" + +#include +#include +#include +#include +#include + +namespace xml_lite +{ + +TEST_CLASS(test_soapelements){ public: +#include "xml.lite/unittests/test_soapelements.cpp" +}; + +TEST_CLASS(test_xmlattribute){ public: +#include "xml.lite/unittests/test_xmlattribute.cpp" +}; + +TEST_CLASS(test_xmlcreate){ public: +#include "xml.lite/unittests/test_xmlcreate.cpp" +}; + +TEST_CLASS(test_xmlelement){ public: +#include "xml.lite/unittests/test_xmlelement.cpp" +}; + +TEST_CLASS(test_xmlparser){ public: +#include "xml.lite/unittests/test_xmlparser.cpp" +}; + +} \ No newline at end of file diff --git a/UnitTest/zip.cpp b/UnitTest/zip.cpp new file mode 100644 index 000000000..6dd08743f --- /dev/null +++ b/UnitTest/zip.cpp @@ -0,0 +1,13 @@ +#include "pch.h" +#include "CppUnitTest.h" + +#include +#include + +namespace zip +{ +TEST_CLASS(unittest_GZip){ public: +#include "zip/unittests/unittest_GZip.cpp" +}; + +} \ No newline at end of file diff --git a/build/build.py b/build/build.py index e9fd0ecde..1c9c5eca2 100644 --- a/build/build.py +++ b/build/build.py @@ -852,7 +852,7 @@ def configureCompilerOptions(self): config['cxx']['optz_fast'] = '-O2' config['cxx']['optz_faster'] = '-O3' config['cxx']['optz_fastest'] = config['cxx']['optz_faster'] - config['cxx']['optz_fastest-possible'] = config['cxx']['optz_fastest'] # TODO: -march=native ? + config['cxx']['optz_fastest-possible'] = config['cxx']['optz_fastest'] #self.env.append_value('LINKFLAGS', '-fPIC -dynamiclib'.split()) self.env.append_value('LINKFLAGS', '-fPIC'.split()) @@ -907,10 +907,11 @@ def configureCompilerOptions(self): # https://gcc.gnu.org/onlinedocs/gcc-12.2.0/gcc/x86-Options.html#x86-Options # "Using -march=native enables all instruction subsets supported by the local machine ..." config['cxx']['optz_faster'] = '-O3' # no -march=native - config['cxx']['optz_fastest'] = config['cxx']['optz_faster'] # TODO: add -march=native ? + # Haswell is from 2013 ... 10 years ago: https://en.wikipedia.org/wiki/Haswell_%28microarchitecture%29 + config['cxx']['optz_fastest'] = [ config['cxx']['optz_faster'], '-march=haswell' ] # This "should" be part of fastest, but that could cause unexpected floating point differences. # The "fastest-possible" option is new; see comments above. - config['cxx']['optz_fastest-possible'] = [ config['cxx']['optz_fastest'], '-march=native' ] + config['cxx']['optz_fastest-possible'] = [ config['cxx']['optz_faster'], '-march=native' ] # -march=native instead of haswell self.env.append_value('CXXFLAGS', '-fPIC'.split()) if not Options.options.enablecpp17: @@ -956,10 +957,11 @@ def configureCompilerOptions(self): # https://gcc.gnu.org/onlinedocs/gcc-12.2.0/gcc/x86-Options.html#x86-Options # "Using -march=native enables all instruction subsets supported by the local machine ..." config['cc']['optz_faster'] = '-O3' # no -march=native - config['cc']['optz_fastest'] = config['cc']['optz_faster'] # TODO: add -march=native ? + # Haswell is from 2013 ... 10 years ago: https://en.wikipedia.org/wiki/Haswell_%28microarchitecture%29 + config['cc']['optz_fastest'] = [ config['cc']['optz_faster'], '-march=haswell' ] # This "should" be part of fastest, but that could cause unexpected floating point differences. # The "fastest-possible" option is new; see comments above. - config['cc']['optz_fastest-possible'] = [ config['cc']['optz_fastest'], '-march=native' ] + config['cc']['optz_fastest-possible'] = [ config['cc']['optz_faster'], '-march=native' ] # -march=native instead of haswell self.env.append_value('CFLAGS', '-fPIC'.split()) # "gnu99" enables POSIX and BSD diff --git a/build/dumplibimpl.py b/build/dumplibimpl.py index d88864c87..4ebaff853 100644 --- a/build/dumplibimpl.py +++ b/build/dumplibimpl.py @@ -56,7 +56,8 @@ def dumpLibImpl(context, raw): # We need a source file here so it doesn't think it is headers only topDir = context.top_dir - buildDir = os.path.dirname(os.path.realpath(__file__)) + buildDir = os.path.join(os.path.dirname(os.path.realpath(__file__)), + '__pycache__') modArgs['SOURCE_DIR'] = os.path.relpath(buildDir, topDir) modArgs['SOURCE_EXT'] = 'pyc' context.module(**modArgs) diff --git a/cmake/CodaFindSystemDependencies.cmake b/cmake/CodaFindSystemDependencies.cmake index 5efe5c73b..808361823 100644 --- a/cmake/CodaFindSystemDependencies.cmake +++ b/cmake/CodaFindSystemDependencies.cmake @@ -92,9 +92,6 @@ macro(coda_find_system_dependencies) if (PYTHON_EXTRA_NATIVE) list(APPEND CMAKE_SWIG_FLAGS "-extranative") endif() - if (Python_VERSION_MAJOR GREATER_EQUAL 3) - list(APPEND CMAKE_SWIG_FLAGS "-py3") - endif() endif() else() set(SWIG_FOUND OFF CACHE INTERNAL "") diff --git a/coda-oss-lite.sln b/coda-oss.sln similarity index 73% rename from coda-oss-lite.sln rename to coda-oss.sln index 8310d71fd..cea89c6f0 100644 --- a/coda-oss-lite.sln +++ b/coda-oss.sln @@ -3,7 +3,7 @@ Microsoft Visual Studio Solution File, Format Version 12.00 # Visual Studio Version 17 VisualStudioVersion = 17.1.32421.90 MinimumVisualStudioVersion = 10.0.40219.1 -Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "coda-oss-lite", "modules\c++\coda-oss-lite.vcxproj", "{9997E895-5161-4DDF-8F3F-099894CB2F21}" +Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "coda-oss", "modules\c++\coda-oss.vcxproj", "{9997E895-5161-4DDF-8F3F-099894CB2F21}" EndProject Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{DEB848DD-4285-4BFA-9B2F-60FA46200205}" ProjectSection(SolutionItems) = preProject @@ -15,6 +15,11 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution EndProject Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "UnitTest", "UnitTest\UnitTest.vcxproj", "{34A31B3F-47C5-441D-AB22-3C85B3C5314E}" EndProject +Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".github-workflows", ".github-workflows", "{E0FA1194-0806-4A6B-A331-33CB43C0C946}" + ProjectSection(SolutionItems) = preProject + .github\workflows\build_unittest.yml = .github\workflows\build_unittest.yml + EndProjectSection +EndProject Global GlobalSection(SolutionConfigurationPlatforms) = preSolution Debug|x64 = Debug|x64 @@ -33,6 +38,9 @@ Global GlobalSection(SolutionProperties) = preSolution HideSolutionNode = FALSE EndGlobalSection + GlobalSection(NestedProjects) = preSolution + {E0FA1194-0806-4A6B-A331-33CB43C0C946} = {DEB848DD-4285-4BFA-9B2F-60FA46200205} + EndGlobalSection GlobalSection(ExtensibilityGlobals) = postSolution SolutionGuid = {3CAB4AC9-7865-44AD-8623-57905729A559} EndGlobalSection diff --git a/modules/CMakeLists.txt b/modules/CMakeLists.txt index d21b6d252..d7a4f7d71 100644 --- a/modules/CMakeLists.txt +++ b/modules/CMakeLists.txt @@ -1,5 +1,7 @@ add_subdirectory("drivers") + add_subdirectory("c++") if (BUILD_PYTHON_MODULES) add_subdirectory("python") endif() + diff --git a/modules/c++/CMakeLists.txt b/modules/c++/CMakeLists.txt index 5d6ec9ed8..d24274865 100644 --- a/modules/c++/CMakeLists.txt +++ b/modules/c++/CMakeLists.txt @@ -12,14 +12,27 @@ if (MSVC) elseif (UNIX) add_compile_options(-std=c++14) - add_compile_options(-Wall -pedantic -Wextra) - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wregister") # -Wvolatile - #set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Weffc++") - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wzero-as-null-pointer-constant") - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Woverloaded-virtual") + # https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html + add_compile_options(-Werror) # Make all warnings into errors + add_compile_options(-Wall -Wextra -Wpedantic -pedantic-errors -Wunused) + + add_compile_options(-Wzero-as-null-pointer-constant) + add_compile_options(-Wsuggest-final-types -Wsuggest-final-methods) + add_compile_options(-Wsuggest-override) + add_compile_options(-Woverloaded-virtual) + add_compile_options(-Warray-bounds) + add_compile_options(-Wduplicated-branches -Wduplicated-cond) + add_compile_options(-Wtrampolines) + add_compile_options(-Wshadow) #set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wold-style-cast") - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wsuggest-final-types -Wsuggest-final-methods") - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wsuggest-override") + #add_compile_options(-Wfloat-equal) + #add_compile_options(-Wconversion) + #set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Weffc++") + + add_compile_options(-Wno-double-promotion) # implicit conversion of `float` to `double` is fine + + # Need a newer compiler than GCC 9 + #add_compile_options(-Wnrvo) endif() # add an interface library for unittests diff --git a/modules/c++/cli/include/cli/Argument.h b/modules/c++/cli/include/cli/Argument.h index e7a90f83b..65763cebc 100644 --- a/modules/c++/cli/include/cli/Argument.h +++ b/modules/c++/cli/include/cli/Argument.h @@ -100,20 +100,20 @@ class CODA_OSS_API Argument std::string mName; std::vector mShortFlags; std::vector mLongFlags; - Action mAction; - int mMinArgs; - int mMaxArgs; - Value* mDefaultValue; - bool mOwnDefault; + Action mAction = cli::STORE; + int mMinArgs = 0; + int mMaxArgs = 1; + Value* mDefaultValue = nullptr; + bool mOwnDefault = false; std::vector mChoices; std::string mHelp; std::string mMetavar; std::string mDestination; - Value* mConstValue; - bool mOwnConst; - bool mRequired; - bool mShowsHelp; - ArgumentParser* mParser; + Value* mConstValue = nullptr; + bool mOwnConst = false; + bool mRequired = false; + bool mShowsHelp = true; + ArgumentParser* mParser = nullptr; friend class ArgumentParser; Argument(const std::string& nameOrFlags, ArgumentParser* parser); diff --git a/modules/c++/cli/source/Argument.cpp b/modules/c++/cli/source/Argument.cpp index a925262d1..11c541a2c 100644 --- a/modules/c++/cli/source/Argument.cpp +++ b/modules/c++/cli/source/Argument.cpp @@ -25,9 +25,7 @@ #include cli::Argument::Argument(const std::string& nameOrFlags, cli::ArgumentParser* parser): - mAction(cli::STORE), mMinArgs(0), mMaxArgs(1), mDefaultValue(NULL), - mOwnDefault(false), mConstValue(NULL), mOwnConst(false), - mRequired(false), mShowsHelp(true), mParser(parser) + mParser(parser) { std::vector < std::string > vars = str::split(nameOrFlags, " "); if (vars.size() == 1 && !str::startsWith(vars[0], "-")) diff --git a/modules/c++/cli/source/ArgumentParser.cpp b/modules/c++/cli/source/ArgumentParser.cpp index b2d47fab9..be702484e 100644 --- a/modules/c++/cli/source/ArgumentParser.cpp +++ b/modules/c++/cli/source/ArgumentParser.cpp @@ -294,6 +294,7 @@ std::unique_ptr cli::ArgumentParser::parse(const std::string& prog std::map longOptionsFlags; std::vector positionalArgs; + positionalArgs.reserve(mArgs.size()); for (auto& arg_ : mArgs) { cli::Argument* arg = arg_.get(); @@ -336,6 +337,7 @@ std::unique_ptr cli::ArgumentParser::parse(const std::string& prog } std::vector < std::string > explodedArgs; + explodedArgs.reserve(args.size()); // next, check for combined short options for (size_t i = 0, s = args.size(); i < s; ++i) { @@ -413,12 +415,12 @@ std::unique_ptr cli::ArgumentParser::parse(const std::string& prog } auto results = std::make_unique(); - cli::Results *currentResults = NULL; + cli::Results* currentResults = nullptr; for (size_t i = 0, s = explodedArgs.size(); i < s; ++i) { currentResults = results.get(); // set the pointer std::string argStr = explodedArgs[i]; - cli::Argument *arg = NULL; + cli::Argument* arg = nullptr; std::string optionsStr(""); if (argStr.size() > 2 && argStr[0] == mPrefixChar && argStr[1] == mPrefixChar) @@ -507,7 +509,7 @@ std::unique_ptr cli::ArgumentParser::parse(const std::string& prog } - if (arg != NULL) + if (arg != nullptr) { std::string argVar = arg->getVariable(); switch (arg->getAction()) @@ -564,7 +566,7 @@ std::unique_ptr cli::ArgumentParser::parse(const std::string& prog case cli::STORE_CONST: { const Value* constVal = arg->getConst(); - currentResults->put(argVar, constVal ? constVal->clone() : NULL); + currentResults->put(argVar, constVal ? constVal->clone() : nullptr); break; } case cli::SUB_OPTIONS: @@ -605,7 +607,7 @@ std::unique_ptr cli::ArgumentParser::parse(const std::string& prog else { // it's a positional argument - cli::Value *lastPosVal = NULL; + cli::Value* lastPosVal = nullptr; for (std::vector::iterator it = positionalArgs.begin(); it != positionalArgs.end(); ++it) { @@ -653,7 +655,7 @@ std::unique_ptr cli::ArgumentParser::parse(const std::string& prog if (!results->hasValue(argVar)) { const Value* defaultVal = arg->getDefault(); - if (defaultVal != NULL) + if (defaultVal != nullptr) results->put(argVar, defaultVal->clone()); else if (arg->getAction() == cli::STORE_FALSE) results->put(argVar, new cli::Value(true)); diff --git a/modules/c++/coda-oss.ruleset b/modules/c++/coda-oss.ruleset new file mode 100644 index 000000000..0da8c00a6 --- /dev/null +++ b/modules/c++/coda-oss.ruleset @@ -0,0 +1,699 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/modules/c++/coda-oss-lite.vcxproj b/modules/c++/coda-oss.vcxproj similarity index 71% rename from modules/c++/coda-oss-lite.vcxproj rename to modules/c++/coda-oss.vcxproj index f50ac4a19..cd7468965 100644 --- a/modules/c++/coda-oss-lite.vcxproj +++ b/modules/c++/coda-oss.vcxproj @@ -19,8 +19,8 @@ - + @@ -31,6 +31,12 @@ + + + + + + @@ -43,7 +49,18 @@ + + + + + + + + + + + @@ -130,6 +147,7 @@ + @@ -149,12 +167,44 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -176,8 +226,6 @@ - - @@ -191,6 +239,8 @@ + + @@ -228,8 +278,9 @@ + + - @@ -252,22 +303,58 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -313,6 +400,20 @@ + + + + + + + + + + + + + + @@ -386,8 +487,27 @@ + + + + + + + + + + + + + + + + + + + @@ -402,11 +522,16 @@ + + + true + true + 16.0 @@ -414,21 +539,19 @@ {9997e895-5161-4ddf-8f3f-099894cb2f21} codaoss 10.0 - coda-oss-lite + coda-oss DynamicLibrary true v143 - true DynamicLibrary false v143 true - true @@ -445,10 +568,11 @@ true true - AllRules.ruleset + coda-oss.ruleset false + coda-oss.ruleset @@ -456,24 +580,27 @@ true _DEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL;MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 pch.h - cli\include\;coda_oss\include;config\include\;except\include\;gsl\include\;io\include\;logging\include\;math\include\;math.linear\include\;math.poly\include\;mem\include\;mt\include\;plugin\include\;polygon\include\;re\include\;sio.lite\include\;std\include\;str\include\;sys\include\;tiff\include;types\include\;units\include\ + cli\include;coda_oss\include;config\include;dbi\include;except\include;gsl\include;hdf5.lite\include;io\include;logging\include;math\include;math.linear\include;math.poly\include;mem\include;mt\include;net\include;net.ssl\include;plugin\include;polygon\include;re\include;sio.lite\include;std\include;str\include;sys\include;tiff\include;types\include;unique\include;units\include;xml.lite\include;zip\include;$(ProjectDir)include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;$(SolutionDir)externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\include Use pch.h true Guard ProgramDatabase - true - true true true true /Zc:__cplusplus %(AdditionalOptions) true + AdvancedVectorExtensions2 + MultiThreadedDebugDLL + true true + $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib;$(SolutionDir)\externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\lib + rpcrt4.lib;%(AdditionalDependencies) @@ -484,17 +611,16 @@ true NDEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL;MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 pch.h - cli\include\;coda_oss\include;config\include\;except\include\;gsl\include\;io\include\;logging\include\;math\include\;math.linear\include\;math.poly\include\;mem\include\;mt\include\;plugin\include\;polygon\include\;re\include\;sio.lite\include\;std\include\;str\include\;sys\include\;tiff\include;types\include\;units\include\ + cli\include;coda_oss\include;config\include;dbi\include;except\include;gsl\include;hdf5.lite\include;io\include;logging\include;math\include;math.linear\include;math.poly\include;mem\include;mt\include;net\include;net.ssl\include;plugin\include;polygon\include;re\include;sio.lite\include;std\include;str\include;sys\include;tiff\include;types\include;unique\include;units\include;xml.lite\include;zip\include;$(ProjectDir)include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;$(SolutionDir)externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\include Use pch.h true Guard - true - true true true true /Zc:__cplusplus %(AdditionalOptions) + AdvancedVectorExtensions2 @@ -502,6 +628,8 @@ true true true + $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib;$(SolutionDir)\externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\lib + rpcrt4.lib;%(AdditionalDependencies) diff --git a/modules/c++/coda-oss-lite.vcxproj.filters b/modules/c++/coda-oss.vcxproj.filters similarity index 72% rename from modules/c++/coda-oss-lite.vcxproj.filters rename to modules/c++/coda-oss.vcxproj.filters index 75b551471..adb5a57f7 100644 --- a/modules/c++/coda-oss-lite.vcxproj.filters +++ b/modules/c++/coda-oss.vcxproj.filters @@ -30,9 +30,6 @@ coda_oss - - coda_oss - coda_oss @@ -222,9 +219,6 @@ sys - - sys - sys @@ -723,18 +717,258 @@ mem - - std - - - std - std config + + sys + + + sys + + + mt + + + sys + + + sys + + + types + + + coda_oss + + + hdf5.lite + + + hdf5.lite + + + hdf5.lite + + + hdf5.lite + + + hdf5.lite + + + hdf5.lite + + + hdf5.lite + + + hdf5.lite + + + zip + + + zip + + + zip + + + zip + + + zip + + + zip + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + dbi + + + dbi + + + dbi + + + dbi + + + dbi + + + dbi + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net.ssl + + + net.ssl + + + net.ssl + + + net.ssl + + + unique + + + unique + + + hdf5.lite + + + xml.lite + + + hdf5.lite + + + mt + + + include + @@ -1077,6 +1311,129 @@ sys + + hdf5.lite + + + hdf5.lite + + + hdf5.lite + + + hdf5.lite + + + hdf5.lite + + + zip + + + zip + + + zip + + + zip + + + zip + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + xml.lite + + + dbi + + + dbi + + + dbi + + + dbi + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net + + + net.ssl + + + net.ssl + + + unique + @@ -1151,6 +1508,27 @@ {387bc6cb-323a-42b3-8502-4fac72586d12} + + {e4db8b19-0870-4cb2-af64-14b928c68725} + + + {a2682912-3963-489a-9cf0-c5224b27eb84} + + + {1bb6daf3-40dd-44d8-8680-0e77e2c3bd17} + + + {13c98009-f1f9-4297-a2b3-bde23f3bea55} + + + {6575592b-9b28-49eb-be76-27f40825475e} + + + {21ddb4b6-54a2-4618-81ed-4fbbf37b30de} + + + {79aa73a7-ed0d-4826-b7ed-c8d91d96998a} + @@ -1210,5 +1588,12 @@ sys + + std + + + + sys + \ No newline at end of file diff --git a/modules/c++/coda_oss/include/coda_oss/CPlusPlus.h b/modules/c++/coda_oss/include/coda_oss/CPlusPlus.h index f28d64236..b912e9c3e 100644 --- a/modules/c++/coda_oss/include/coda_oss/CPlusPlus.h +++ b/modules/c++/coda_oss/include/coda_oss/CPlusPlus.h @@ -63,11 +63,12 @@ #endif // CODA_OSS_cplusplus // Define a few macros as that's less verbose than testing against a version number +// https://en.cppreference.com/w/cpp/preprocessor/replace#Predefined_macros #define CODA_OSS_cpp11 (CODA_OSS_cplusplus >= 201103L) #define CODA_OSS_cpp14 (CODA_OSS_cplusplus >= 201402L) #define CODA_OSS_cpp17 (CODA_OSS_cplusplus >= 201703L) #define CODA_OSS_cpp20 (CODA_OSS_cplusplus >= 202002L) -#define CODA_OSS_cpp23 0 +#define CODA_OSS_cpp23 (CODA_OSS_cplusplus >= 202302L) #if !CODA_OSS_cpp14 #error "Must compile with C++14 or greater." diff --git a/modules/c++/coda_oss/include/coda_oss/bit.h b/modules/c++/coda_oss/include/coda_oss/bit.h index 99045bba1..271935ab0 100644 --- a/modules/c++/coda_oss/include/coda_oss/bit.h +++ b/modules/c++/coda_oss/include/coda_oss/bit.h @@ -18,9 +18,17 @@ * License along with this program; If not, http://www.gnu.org/licenses/. * */ +#pragma once #ifndef CODA_OSS_coda_oss_bit_h_INCLUDED_ #define CODA_OSS_coda_oss_bit_h_INCLUDED_ -#pragma once + +#include +#include +#ifdef __GNUC__ +#include // "These functions are GNU extensions." +#endif + +#include #include "coda_oss/namespace_.h" namespace coda_oss @@ -38,6 +46,58 @@ namespace coda_oss native = __BYTE_ORDER__ #endif }; + + // https://en.cppreference.com/w/cpp/numeric/byteswap + namespace details + { + // Overloads for common types + inline constexpr uint8_t byteswap(uint8_t val) noexcept + { + return val; // no-op + } + #if defined(_MSC_VER) + // These routines should generate a single instruction; see + // https://devblogs.microsoft.com/cppblog/a-tour-of-4-msvc-backend-improvements/ + inline uint16_t byteswap(uint16_t val) noexcept + { + return _byteswap_ushort(val); + } + inline uint32_t byteswap(uint32_t val) noexcept + { + return _byteswap_ulong(val); + } + inline uint64_t byteswap(uint64_t val) noexcept + { + return _byteswap_uint64(val); + } + #elif defined(__GNUC__) + inline uint16_t byteswap(uint16_t val) noexcept + { + return bswap_16(val); + } + inline uint32_t byteswap(uint32_t val) noexcept + { + return bswap_32(val); + } + inline uint64_t byteswap(uint64_t val) noexcept + { + return bswap_64(val); + } + #else + #error "No platform-specific byteswap()" // TODO: do something else? + #endif + } + + template + inline T byteswap(T n) noexcept + { + // "std::byteswap participates in overload resolution only if T satisfies integral, i.e., T is an integer type. The program is + // ill-formed if T has padding bits." + static_assert(std::is_integral::value, "T must be integral"); + + using unsigned_t = std::make_unsigned_t; // "Since C++14" https://en.cppreference.com/w/cpp/types/make_unsigned + return details::byteswap(static_cast(n)); + } } #endif // CODA_OSS_coda_oss_bit_h_INCLUDED_ diff --git a/modules/c++/coda_oss/include/coda_oss/cstddef.h b/modules/c++/coda_oss/include/coda_oss/cstddef.h index e6e19a8ad..c8c51ed42 100644 --- a/modules/c++/coda_oss/include/coda_oss/cstddef.h +++ b/modules/c++/coda_oss/include/coda_oss/cstddef.h @@ -22,7 +22,10 @@ #define CODA_OSS_coda_oss_cstddef_h_INCLUDED_ #pragma once +#include + #include +#include // Need a fairly decent C++ compiler to use the real GSL. This brings in more than // we really need for span (e.g., gsl::narrow()), but it keeps things simple. @@ -37,5 +40,6 @@ namespace coda_oss enum class byte : unsigned char {}; #endif // GSL_BYTE_H } +static_assert(!std::is_same::value, "'coda_oss::byte' should be a unique type."); #endif // CODA_OSS_coda_oss_cstddef_h_INCLUDED_ diff --git a/modules/c++/coda_oss/include/coda_oss/memory.h b/modules/c++/coda_oss/include/coda_oss/memory.h deleted file mode 100644 index a546428fb..000000000 --- a/modules/c++/coda_oss/include/coda_oss/memory.h +++ /dev/null @@ -1,67 +0,0 @@ -/* ========================================================================= - * This file is part of coda_oss-c++ - * ========================================================================= - * - * (C) Copyright 2004 - 2018, MDA Information Systems LLC - * (C) Copyright 2022, Maxar Technologies, Inc. - * - * coda_oss-c++ is free software; you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as published by - * the Free Software Foundation; either version 3 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this program; If not, - * see . - * - */ - -#ifndef CODA_OSS_coda_oss_memory_h_INCLUDED_ -#define CODA_OSS_coda_oss_memory_h_INCLUDED_ -#pragma once - -#include -#include -#include - -#include "config/compiler_extensions.h" - -#include "coda_oss/namespace_.h" -namespace coda_oss -{ -// C++11 inadvertently ommitted make_unique; provide it here. (Swiped from .) -template ::value, int>::type = 0> -std::unique_ptr make_unique(TArgs&&... args) -{ - CODA_OSS_disable_warning_push - #if _MSC_VER - #pragma warning(disable: 26409) // Avoid calling new and delete explicitly, use std::make_unique instead (r .11). - #endif - return std::unique_ptr(new T(std::forward(args)...)); - CODA_OSS_disable_warning_pop -} - -template ::value && std::extent::value == 0, int>::type = 0> -std::unique_ptr make_unique(size_t size) -{ - using element_t = typename std::remove_extent::type; - - CODA_OSS_disable_warning_push - #if _MSC_VER - #pragma warning(disable: 26409) // Avoid calling new and delete explicitly, use std::make_unique instead (r .11). - #endif - return std::unique_ptr(new element_t[size]()); - CODA_OSS_disable_warning_pop -} - -template ::value != 0, int>::type = 0> -void make_unique(TArgs&&...) = delete; - -} // namespace coda_oss - -#endif // CODA_OSS_coda_oss_memory_h_INCLUDED_ diff --git a/modules/c++/coda_oss/include/coda_oss/numbers.h b/modules/c++/coda_oss/include/coda_oss/numbers.h new file mode 100644 index 000000000..698bb042d --- /dev/null +++ b/modules/c++/coda_oss/include/coda_oss/numbers.h @@ -0,0 +1,83 @@ +/* ========================================================================= + * This file is part of coda_oss-c++ + * ========================================================================= + * + * (C) Copyright 2020-2022, Maxar Technologies, Inc. + * + * coda_oss-c++ is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this program; If not, http://www.gnu.org/licenses/. + * + */ +#pragma once +#ifndef CODA_OSS_coda_oss_numbers_h_INCLUDED_ +#define CODA_OSS_coda_oss_numbers_h_INCLUDED_ + +#ifndef _USE_MATH_DEFINES +#define _USE_MATH_DEFINES // get M_PI, etc. +#endif +#include +/* +#define M_E 2.71828182845904523536 // e +#define M_LOG2E 1.44269504088896340736 // log2(e) +#define M_LOG10E 0.434294481903251827651 // log10(e) +#define M_LN2 0.693147180559945309417 // ln(2) +#define M_LN10 2.30258509299404568402 // ln(10) +#define M_PI 3.14159265358979323846 // pi +#define M_PI_2 1.57079632679489661923 // pi/2 +#define M_PI_4 0.785398163397448309616 // pi/4 +#define M_1_PI 0.318309886183790671538 // 1/pi +#define M_2_PI 0.636619772367581343076 // 2/pi +#define M_2_SQRTPI 1.12837916709551257390 // 2/sqrt(pi) +#define M_SQRT2 1.41421356237309504880 // sqrt(2) +#define M_SQRT1_2 0.707106781186547524401 // 1/sqrt(2) +*/ + +namespace coda_oss +{ + +namespace numbers +{ +// https://en.cppreference.com/w/cpp/header/numbers + +template constexpr T e_v = static_cast(M_E); +template constexpr T log2e_v = static_cast(M_LOG2E); +template constexpr T log10e_v = static_cast(M_LOG10E); +template constexpr T pi_v = static_cast(M_PI); +template constexpr T inv_pi_v = static_cast(M_1_PI); +//template constexpr T inv_sqrtpi_v = static_cast(); +template constexpr T ln2_v = static_cast(M_LN2); +template constexpr T ln10_v = static_cast(M_LN10); +template constexpr T sqrt2_v = static_cast(M_SQRT2); +//template constexpr T sqrt3_v = static_cast(); +//template constexpr T inv_sqrt3_v = static_cast(); +//template constexpr T egamma_v = static_cast(); +//template constexpr T phi_v = static_cast(); + +constexpr double e = e_v; +constexpr double log2e = log2e_v; +constexpr double log10e = log10e_v; +constexpr double pi = pi_v; +constexpr double inv_pi = inv_pi_v; +//constexpr double inv_sqrtpi = inv_sqrtpi_v; +constexpr double ln2 = ln2_v; +constexpr double ln10 = ln10_v; +constexpr double sqrt2 = sqrt2_v; +//constexpr double sqrt3 = sqrt3_v; +//constexpr double inv_sqrt3 = inv_sqrt3_v; +//constexpr double egamma = egamma_v; +//constexpr double phi = phi_v; +} + +} + +#endif // CODA_OSS_coda_oss_numbers_h_INCLUDED_ diff --git a/modules/c++/coda_oss/include/coda_oss/span.h b/modules/c++/coda_oss/include/coda_oss/span.h index c33375c3e..6aff3b5d5 100644 --- a/modules/c++/coda_oss/include/coda_oss/span.h +++ b/modules/c++/coda_oss/include/coda_oss/span.h @@ -19,12 +19,17 @@ * see . * */ +#pragma once #ifndef CODA_OSS_coda_oss_span_h_INCLUDED_ #define CODA_OSS_coda_oss_span_h_INCLUDED_ -#pragma once + +#include + +#include #include "coda_oss/namespace_.h" #include "coda_oss/span_.h" +#include "coda_oss/cstddef.h" // byte // Need a fairly decent C++ compiler to use the real GSL. This brings in more than // we really need for span (e.g., gsl::narrow()), but it keeps things simple. @@ -37,6 +42,37 @@ namespace coda_oss #else // no gsl::span, use our own using details::span; #endif // GSL_SPAN_H + +// https://en.cppreference.com/w/cpp/container/span/as_bytes +template +inline auto as_bytes(span s) noexcept +{ + // https://en.cppreference.com/w/cpp/types/is_trivially_copyable "... serialized to/from binary files ..." + static_assert(std::is_trivially_copyable::value, "must be 'trivially' copyable."); + + const void* const p_ = s.data(); + auto const p = static_cast(p_); + return span(p, s.size_bytes()); +} +template +inline auto as_bytes(span s) noexcept +{ + const span s_(s.data(), s.size()); + return as_bytes(s_); +} +template +inline span as_writable_bytes(span s) noexcept +{ + // https://en.cppreference.com/w/cpp/types/is_trivially_copyable "... serialized to/from binary files ..." + static_assert(std::is_trivially_copyable::value, "must be 'trivially' copyable."); + + static_assert(!std::is_const::value, "T cannot be 'const'"); + + void* const p_ = s.data(); + auto const p = static_cast(p_); + return span(p, s.size_bytes()); +} + } #endif // CODA_OSS_coda_oss_span_h_INCLUDED_ diff --git a/modules/c++/config/include/config/Version.h b/modules/c++/config/include/config/Version.h index bcb4979bd..69944fc0b 100644 --- a/modules/c++/config/include/config/Version.h +++ b/modules/c++/config/include/config/Version.h @@ -42,12 +42,12 @@ static_assert(CODA_OSS_MAKE_VERSION_MMPB(9999, 9999, 9999, 9999) <= UINT64_MAX, // Do this ala C++ ... we don't currently have major/minor/patch //#define CODA_OSS_VERSION_ 20210910L // c.f. __cplusplus -#define CODA_OSS_VERSION_ 2022 ## 0012 ## 0014 ## 0000 ## L +#define CODA_OSS_VERSION_ 2023 ## 0006 ## 0005 ## 0000 ## L // Use the same macros other projects might want to use; overkill for us. -#define CODA_OSS_VERSION_MAJOR 2022 -#define CODA_OSS_VERSION_MINOR 12 -#define CODA_OSS_VERSION_PATCH 14 +#define CODA_OSS_VERSION_MAJOR 2023 +#define CODA_OSS_VERSION_MINOR 6 +#define CODA_OSS_VERSION_PATCH 5 #define CODA_OSS_VERSION_BUILD 0 #define CODA_OSS_VERSION CODA_OSS_MAKE_VERSION_MMPB(CODA_OSS_VERSION_MAJOR, CODA_OSS_VERSION_MINOR, CODA_OSS_VERSION_PATCH, CODA_OSS_VERSION_BUILD) diff --git a/modules/c++/dbi/source/DatabaseClientFactory.cpp b/modules/c++/dbi/source/DatabaseClientFactory.cpp index 170d40513..cd1b38733 100644 --- a/modules/c++/dbi/source/DatabaseClientFactory.cpp +++ b/modules/c++/dbi/source/DatabaseClientFactory.cpp @@ -47,7 +47,7 @@ dbi::DatabaseConnection * dbi::DatabaseClientFactory::create(const std::string& const std::string& host, unsigned int port) { - dbi::DatabaseConnection * connection = NULL; + dbi::DatabaseConnection * connection = nullptr; # if defined(USE_PGSQL) if (mType == dbi::PGSQL) { diff --git a/modules/c++/dbi/source/MySQLConnection.cpp b/modules/c++/dbi/source/MySQLConnection.cpp index 9f0e6aae3..49c01f304 100644 --- a/modules/c++/dbi/source/MySQLConnection.cpp +++ b/modules/c++/dbi/source/MySQLConnection.cpp @@ -38,7 +38,7 @@ bool dbi::MySQLConnection::connect(const std::string& database, if (!mysql_real_connect(&mDBHandle, host.c_str(), user.c_str(), pass.c_str(), database.c_str(), port, - NULL, 0)) + nullptr, 0)) { return false; } diff --git a/modules/c++/dbi/source/OracleConnection.cpp b/modules/c++/dbi/source/OracleConnection.cpp index 4f09abaa3..a03203e4f 100644 --- a/modules/c++/dbi/source/OracleConnection.cpp +++ b/modules/c++/dbi/source/OracleConnection.cpp @@ -30,8 +30,8 @@ dbi::OracleConnection::OracleConnection() { - mEnvHandle = NULL; - mErrorHandle = NULL; + mEnvHandle = nullptr; + mErrorHandle = nullptr; (void) OCIInitialize((ub4) OCI_DEFAULT, (dvoid *)0, (dvoid * (*)(dvoid *, size_t)) 0, (dvoid * (*)(dvoid *, dvoid *, size_t))0, @@ -80,7 +80,7 @@ const std::string dbi::OracleConnection::getLastErrorMessage() char errbuf[100]; memset(errbuf, 0, 100); int errcode; - OCIErrorGet((dvoid *)mErrorHandle, (ub4) 1, (text *) NULL, &errcode, + OCIErrorGet((dvoid *)mErrorHandle, (ub4) 1, (text *) nullptr, &errcode, (OraText*)errbuf, (ub4) sizeof(errbuf), OCI_HTYPE_ERROR); if (strlen(errbuf) > 0) return std::string(errbuf); @@ -117,8 +117,8 @@ dbi::pResultSet dbi::OracleConnection::query(const std::string& q) OCIStmtPrepare(countHandle, mErrorHandle, (const OraText*)countq.c_str(), (ub4)countq.length(), (ub4) OCI_NTV_SYNTAX, (ub4) OCI_DEFAULT); OCIStmtExecute(mContextHandle, countHandle, mErrorHandle, (ub4)val, (ub4)0, - (CONST OCISnapshot *) NULL, (OCISnapshot *) NULL, OCI_DEFAULT); - OCIDefine * defineHandle = NULL; + (CONST OCISnapshot *) nullptr, (OCISnapshot *) nullptr, OCI_DEFAULT); + OCIDefine * defineHandle = nullptr; OCIDefineByPos(countHandle, &defineHandle, mErrorHandle, 1, &rowCount, sizeof(rowCount), SQLT_UIN, 0, 0, 0, OCI_DEFAULT); OCIStmtFetch(countHandle, mErrorHandle, 1, OCI_FETCH_NEXT, OCI_DEFAULT); @@ -126,7 +126,7 @@ dbi::pResultSet dbi::OracleConnection::query(const std::string& q) /* Execute the SQL statment */ OCIStmtExecute(mContextHandle, sqlHandle, mErrorHandle, (ub4) val, (ub4) 0, - (CONST OCISnapshot *) NULL, (OCISnapshot *) NULL, OCI_DEFAULT); + (CONST OCISnapshot *) nullptr, (OCISnapshot *) nullptr, OCI_DEFAULT); return dbi::pResultSet(new dbi::OracleResultSet(sqlHandle, mErrorHandle, rowCount)); } @@ -150,7 +150,7 @@ dbi::Row dbi::OracleResultSet::fetchRow() dbi::Row row; ub4 count = 0; sword result = OCIAttrGet(mSQLHandle, OCI_HTYPE_STMT, - &count, NULL, OCI_ATTR_PARAM_COUNT, mErrorHandle); + &count, nullptr, OCI_ATTR_PARAM_COUNT, mErrorHandle); Column * fields = new Column[count]; if (result == OCI_SUCCESS) { @@ -160,9 +160,9 @@ dbi::Row dbi::OracleResultSet::fetchRow() fields[i].type = 0; fields[i].extType = SQLT_STR; fields[i].fieldSize = 0; - fields[i].value = NULL; + fields[i].value = nullptr; - OCIParam* param_handle = NULL; + OCIParam* param_handle = nullptr; ub4 name_len = 0; result = OCIParamGet(mSQLHandle, OCI_HTYPE_STMT, @@ -180,14 +180,14 @@ dbi::Row dbi::OracleResultSet::fetchRow() if (result == OCI_SUCCESS) { result = OCIAttrGet(param_handle, OCI_DTYPE_PARAM, - &fields[i].type, NULL, OCI_ATTR_DATA_TYPE, + &fields[i].type, nullptr, OCI_ATTR_DATA_TYPE, mErrorHandle); } if (result == OCI_SUCCESS) { result = OCIAttrGet(param_handle, OCI_DTYPE_PARAM, - &fields[i].fieldSize, NULL, OCI_ATTR_DATA_SIZE, + &fields[i].fieldSize, nullptr, OCI_ATTR_DATA_SIZE, mErrorHandle); } @@ -210,7 +210,7 @@ dbi::Row dbi::OracleResultSet::fetchRow() int indp = -1; // This means that NULL values will not cause an error fields[i].value = new char[fields[i].fieldSize]; memset(fields[i].value, '\0', fields[i].fieldSize); - OCIDefine* defineHandle = NULL; + OCIDefine* defineHandle = nullptr; result = OCIDefineByPos(mSQLHandle, &defineHandle, mErrorHandle, i + 1, fields[i].value, fieldSize, fields[i].extType, &indp, 0, 0, OCI_DEFAULT); @@ -229,8 +229,8 @@ dbi::Row dbi::OracleResultSet::fetchRow() ub4 bufferSize = 9; OCIDateToText(mErrorHandle, (const OCIDate*)fields[i].value, - NULL, 0, - NULL, 0, &bufferSize, (text*)buffer); + nullptr, 0, + nullptr, 0, &bufferSize, (text*)buffer); memset(fields[i].value, '\0', sizeof(OCIDate)); strncpy(fields[i].value, buffer, bufferSize); } diff --git a/modules/c++/dbi/source/PgSQLConnection.cpp b/modules/c++/dbi/source/PgSQLConnection.cpp index 5e9519dd7..fc5a86a97 100644 --- a/modules/c++/dbi/source/PgSQLConnection.cpp +++ b/modules/c++/dbi/source/PgSQLConnection.cpp @@ -97,7 +97,7 @@ dbi::pResultSet dbi::PgSQLConnection::query(const std::string& q) throw dbi::SQLException(Ctxt(errorMessage)); } - return dbi::pResultSet(new PgSQLResultSet(NULL)); + return dbi::pResultSet(new PgSQLResultSet(nullptr)); } dbi::Row dbi::PgSQLResultSet::fetchRow() diff --git a/modules/c++/except/include/except/Throwable.h b/modules/c++/except/include/except/Throwable.h index 84fe4d038..2a7deecbb 100644 --- a/modules/c++/except/include/except/Throwable.h +++ b/modules/c++/except/include/except/Throwable.h @@ -165,7 +165,9 @@ class CODA_OSS_API Throwable const Trace& t = getTrace(); if (t.getSize() > 0) s << ": " << t; - return s.str(); + + std::string retval(s.str().c_str()); // truncate to first '\0' + return retval; } const std::vector& getBacktrace() const noexcept @@ -265,7 +267,7 @@ class ThrowableEx : public Throwable // "ThrowableEx" = "Throwable exception" ThrowableEx(const Throwable& t, const Context& ctx) : Throwable(t, ctx) {} #if !CODA_OSS_except_Throwable_ISA_std_exception - const char* what() const noexcept final // derived classes override toString() + const char* what() const noexcept override final // derived classes override toString() { const Throwable* pThrowable = this; return pThrowable->what(); diff --git a/modules/c++/except/source/Backtrace.cpp b/modules/c++/except/source/Backtrace.cpp index a6a326415..9adb564de 100644 --- a/modules/c++/except/source/Backtrace.cpp +++ b/modules/c++/except/source/Backtrace.cpp @@ -111,7 +111,7 @@ class SymInitialize_RAII final bool result; SymInitialize_RAII(HANDLE process) : process_(process) { - result = SymInitialize(process_, NULL, TRUE) == TRUE ? true : false; // https://docs.microsoft.com/en-us/windows/win32/api/dbghelp/nf-dbghelp-syminitialize + result = SymInitialize(process_, nullptr, TRUE) == TRUE ? true : false; // https://docs.microsoft.com/en-us/windows/win32/api/dbghelp/nf-dbghelp-syminitialize } ~SymInitialize_RAII() @@ -134,7 +134,7 @@ static std::string getBacktrace_(bool& supported, std::vector& symb } PVOID stack[100]; - const auto frames = CaptureStackBackTrace(0, 100, stack, NULL); + const auto frames = CaptureStackBackTrace(0, 100, stack, nullptr); auto symbol = reinterpret_cast(calloc(sizeof(SYMBOL_INFO) + 256 * sizeof(char), 1)); if (symbol == nullptr) { @@ -147,7 +147,7 @@ static std::string getBacktrace_(bool& supported, std::vector& symb for (unsigned int i = 0; i < frames; i++) { const auto address = reinterpret_cast(stack[i]); - const auto result = SymFromAddr(process, address, 0, symbol) == TRUE ? true : false; + const auto result = SymFromAddr(process, address, nullptr, symbol) == TRUE ? true : false; if (!result) { continue; diff --git a/modules/c++/except/source/Trace.cpp b/modules/c++/except/source/Trace.cpp index 926f321b4..a40645d71 100644 --- a/modules/c++/except/source/Trace.cpp +++ b/modules/c++/except/source/Trace.cpp @@ -26,12 +26,9 @@ namespace except { std::ostream& operator<<(std::ostream& os, const Trace& t) { - const std::list& stack = t.getStack(); - - for (std::list::const_iterator it = stack.begin(); - it != stack.end(); ++it) + for (auto&& trace : t.getStack()) { - os << *it << std::endl; + os << trace << "\n"; } return os; } diff --git a/modules/c++/framework.h b/modules/c++/framework.h index ced33cae7..1cab8338a 100644 --- a/modules/c++/framework.h +++ b/modules/c++/framework.h @@ -5,14 +5,18 @@ #pragma warning(disable: 4514) // '...': unreferenced inline function has been removed #pragma warning(disable: 4365) // '...': conversion from '...' to '...', signed/unsigned mismatch #pragma warning(disable: 5204) // '...': class has virtual functions, but its trivial destructor is not virtual; instances of objects derived from this class may not be destructed correctly +#pragma warning(disable: 5105) // macro expansion producing '...' has undefined behavior #define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers #define NOMINMAX // no min()/max() macros -#pragma warning(push) -#pragma warning(disable: 5105) // macro expansion producing '...' has undefined behavior #include + +#define _WINSOCK_DEPRECATED_NO_WARNINGS // '...': Use getaddrinfo() or GetAddrInfoW() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings #include -#include -#pragma warning(pop) +#include #pragma comment(lib, "Ws2_32") + +#include + #pragma warning(pop) + diff --git a/modules/c++/gsl/include/gsl/Gsl_.h b/modules/c++/gsl/include/gsl/Gsl_.h index 46ef55ddf..711458fed 100644 --- a/modules/c++/gsl/include/gsl/Gsl_.h +++ b/modules/c++/gsl/include/gsl/Gsl_.h @@ -29,7 +29,7 @@ #include "gsl/Gsl_narrow.h" #include "gsl/use_gsl.h" // Can't compile all of GSL with older versions of GCC/MSVC -#if !CODA_OSS_gsl_use_real_gsl_ +#if !CODA_OSS_use_real_gsl_ // Add to "gsl" if we're not using the real thing namespace gsl { @@ -45,6 +45,6 @@ namespace gsl return Gsl::narrow(u); } } -#endif // CODA_OSS_gsl_use_real_gsl_ +#endif // CODA_OSS_coda_oss_use_real_gsl_ #endif // CODA_OSS_gsl_Gsl__h_INCLUDED_ diff --git a/modules/c++/gsl/include/gsl/gsl.h b/modules/c++/gsl/include/gsl/gsl.h index 45ed51505..4563274f4 100644 --- a/modules/c++/gsl/include/gsl/gsl.h +++ b/modules/c++/gsl/include/gsl/gsl.h @@ -32,13 +32,15 @@ // always compile Gsl (not "gsl") code--our own simple implementation #include "gsl/Gsl_.h" // our own "fake" GSL -#if CODA_OSS_gsl_use_real_gsl_ +#if CODA_OSS_use_real_gsl_ CODA_OSS_disable_warning_push #if _MSC_VER + #pragma warning(disable: 4619) // #pragma warning : there is no warning number '..' #pragma warning(disable: 4626) // '...' : assignment operator was implicitly defined as deleted #pragma warning(disable: 5027) // '...' : move assignment operator was implicitly defined as deleted #pragma warning(disable: 26487) // Don 't return a pointer '...' that may be invalid (lifetime.4). #pragma warning(disable: 4814) // '...': in C++14 '...' will not imply '...'; consider explicitly specifying '...' + #pragma warning(disable: 26823) // Dereferencing a possibly null pointer '...' (lifetime.1). #endif #include "gsl/gsl" diff --git a/modules/c++/gsl/include/gsl/use_gsl.h b/modules/c++/gsl/include/gsl/use_gsl.h index c19faaae2..8135edf1d 100644 --- a/modules/c++/gsl/include/gsl/use_gsl.h +++ b/modules/c++/gsl/include/gsl/use_gsl.h @@ -24,17 +24,17 @@ #pragma once // Need a fairly decent C++ compiler to use the real GSL -#ifndef CODA_OSS_coda_oss_use_real_gsl_ +#ifndef CODA_OSS_use_real_gsl_ #if defined(_MSC_VER) // need VS2017 or later to compile the real GSL code - #define CODA_OSS_coda_oss_use_real_gsl_ (_MSC_VER >= 1910) // VS2017: https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-160 + #define CODA_OSS_use_real_gsl_ (_MSC_VER >= 1910) // VS2017: https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-160 #elif defined (__GNUC__) // GCC 4.9.1 and 4.9.4 won't compile GSL - #define CODA_OSS_coda_oss_use_real_gsl_ (__GNUC__ >= 5) + #define CODA_OSS_use_real_gsl_ (__GNUC__ >= 5) #else // assume GSL can be compiled with any C++14 compiler #include "coda_oss/CPlusPlus.h" - #define CODA_OSS_coda_oss_use_real_gsl_ CODA_OSS_cpp14 + #define CODA_OSS_use_real_gsl_ CODA_OSS_cpp14 #endif #endif diff --git a/modules/c++/hdf5.lite/include/hdf5/lite/H5_.h b/modules/c++/hdf5.lite/include/hdf5/lite/H5_.h new file mode 100644 index 000000000..cd470aef2 --- /dev/null +++ b/modules/c++/hdf5.lite/include/hdf5/lite/H5_.h @@ -0,0 +1,72 @@ +/* ========================================================================= + * This file is part of hdf5.lite-c++ + * ========================================================================= + * + * (C) Copyright 2022, Maxar Technologies, Inc. + * + * hdf5.lite-c++ is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this program; If not, + * see . + * + */ + +#pragma once +#ifndef CODA_OSS_hdf5_lite_H5__h_INCLUDED_ +#define CODA_OSS_hdf5_lite_H5__h_INCLUDED_ + +#include "config/compiler_extensions.h" + +CODA_OSS_disable_warning_system_header_push +#if _MSC_VER +#pragma warning(disable: 6313) // Incorrect operator. Use an equality test to check for zero-valued flags. +#pragma warning(disable: 26493) // Don't use C-style casts (type.4). +#pragma warning(disable: 26494) // Variable '...' is uninitialized. Always initialize an object (type.5). +#pragma warning(disable: 26451) // Arithmetic overflow: Using operator '...' on a 4 byte value and then casting the result to a 8 byte value. Cast the value to the wider type before calling operator '...' to avoid overflow (io.2). +#pragma warning(disable: 26814) // The const variable '...' can be computed at compile-time. Consider using constexpr (con.5). +#pragma warning(disable: 26447) // The function is declared '...' but calls function '...' which may throw exceptions (f.6). +#pragma warning(disable: 26455) // Default constructor should not throw. Declare it '...' (f.6). +#pragma warning(disable: 26440) // Function '...' can be declared '...' (f.6). +#pragma warning(disable: 26496) // The variable '...' does not change after construction, mark it as const (con.4). +#pragma warning(disable: 26462) // The value pointed to by '...' is assigned only once, mark it as a pointer to const (con.4). +#pragma warning(disable: 26435) // Function '...' should specify exactly one of '...', '...', or '...' (c.128). +#pragma warning(disable: 26433) // Function '...' should be marked with '...' (c.128). +#pragma warning(disable: 26497) // You can attempt to make '...' constexpr unless it contains any undefined behavior (f.4). +#pragma warning(disable: 26433) // Function '...' should be marked with '...' (c.128). +#pragma warning(disable: 26456) // Operator '...' hides a non-virtual operator '...' (c.128). +#pragma warning(disable: 26446) // Prefer to use gsl::at() instead of unchecked subscript operator (bounds.4). +#pragma warning(disable: 26477) // Use '...' rather than 0 or NULL(es .47). +#pragma warning(disable: 26457) // (void) should not be used to ignore return values, use '...' instead (es.48). +#pragma warning(disable: 26813) // Use '...' to check if a flag is set. +#else +CODA_OSS_disable_warning(-Wshadow) +CODA_OSS_disable_warning(-Wsuggest-override) +CODA_OSS_disable_warning(-Wzero-as-null-pointer-constant) +#endif + +// see https://docs.hdfgroup.org/archive/support/HDF5/doc1.8/cpplus_RM/readdata_8cpp-example.html +#include + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +CODA_OSS_disable_warning_pop + +#endif // CODA_OSS_hdf5_lite_H5__h_INCLUDED_ diff --git a/modules/c++/hdf5.lite/include/hdf5/lite/HDF5Exception.h b/modules/c++/hdf5.lite/include/hdf5/lite/HDF5Exception.h index 83fd276bb..463b8bf86 100644 --- a/modules/c++/hdf5.lite/include/hdf5/lite/HDF5Exception.h +++ b/modules/c++/hdf5.lite/include/hdf5/lite/HDF5Exception.h @@ -20,6 +20,7 @@ * */ +#pragma once #ifndef CODA_OSS_hdf5_lite_HDF5Exception_h_INCLUDED_ #define CODA_OSS_hdf5_lite_HDF5Exception_h_INCLUDED_ @@ -52,4 +53,5 @@ CODA_OSS_DECLARE_EXTENDED_EXCEPTION(DataType, hdf5::lite::HDF5Exception); } } + #endif // CODA_OSS_hdf5_lite_HDF5Exception_h_INCLUDED_ diff --git a/modules/c++/hdf5.lite/include/hdf5/lite/Info.h b/modules/c++/hdf5.lite/include/hdf5/lite/Info.h index ee62c137d..145741f86 100644 --- a/modules/c++/hdf5.lite/include/hdf5/lite/Info.h +++ b/modules/c++/hdf5.lite/include/hdf5/lite/Info.h @@ -20,9 +20,9 @@ * */ +#pragma once #ifndef CODA_OSS_hdf5_lite_Info_h_INCLUDED_ #define CODA_OSS_hdf5_lite_Info_h_INCLUDED_ -#pragma once #include #include diff --git a/modules/c++/hdf5.lite/include/hdf5/lite/Read.h b/modules/c++/hdf5.lite/include/hdf5/lite/Read.h index 09a8502ee..72498652f 100644 --- a/modules/c++/hdf5.lite/include/hdf5/lite/Read.h +++ b/modules/c++/hdf5.lite/include/hdf5/lite/Read.h @@ -20,9 +20,9 @@ * */ +#pragma once #ifndef CODA_OSS_hdf5_lite_Read_h_INCLUDED_ #define CODA_OSS_hdf5_lite_Read_h_INCLUDED_ -#pragma once /*! * \file Read.h diff --git a/modules/c++/hdf5.lite/include/hdf5/lite/Write.h b/modules/c++/hdf5.lite/include/hdf5/lite/Write.h index dea204a7f..536d74fa3 100644 --- a/modules/c++/hdf5.lite/include/hdf5/lite/Write.h +++ b/modules/c++/hdf5.lite/include/hdf5/lite/Write.h @@ -20,11 +20,11 @@ * */ +#pragma once #ifndef CODA_OSS_hdf5_lite_Write_h_INCLUDED_ #define CODA_OSS_hdf5_lite_Write_h_INCLUDED_ -#pragma once -/*! + /*! * \file Write.h * \brief HDF File-writing API * @@ -48,6 +48,9 @@ namespace lite { template // currently implemented for float and double CODA_OSS_API void createFile(const coda_oss::filesystem::path&, const std::string& ds, const types::RowCol&); +template<> CODA_OSS_API void createFile(const coda_oss::filesystem::path&, const std::string& ds, const types::RowCol&); +template<> CODA_OSS_API void createFile(const coda_oss::filesystem::path&, const std::string& ds, const types::RowCol&); + CODA_OSS_API void createFile(const coda_oss::filesystem::path&, const std::string& ds, SpanRC); inline void createFile(const coda_oss::filesystem::path& path, const std::string& ds, SpanRC data_) { diff --git a/modules/c++/hdf5.lite/include/hdf5/lite/highfive.h b/modules/c++/hdf5.lite/include/hdf5/lite/highfive.h index 6203344c3..fb276e681 100644 --- a/modules/c++/hdf5.lite/include/hdf5/lite/highfive.h +++ b/modules/c++/hdf5.lite/include/hdf5/lite/highfive.h @@ -20,9 +20,9 @@ * */ +#pragma once #ifndef CODA_OSS_hdf5_lite_highfive_h_INCLUDED_ #define CODA_OSS_hdf5_lite_highfive_h_INCLUDED_ -#pragma once /*! * \file highfive.h @@ -30,18 +30,31 @@ */ #include +#include +#include -#include "highfive/H5Easy.hpp" -#include "highfive/H5DataSet.hpp" - +#include "H5_.h" #include "SpanRC.h" namespace hdf5 { namespace lite { + +// Save the trouble of specifying a return type of std::vector<> +template +inline auto v_load(const H5Easy::File& file, const std::string& dataset_name) +{ + return H5Easy::load>(file, dataset_name); +} template -inline HighFive::DataSet writeDataSet(H5Easy::File& file, SpanRC data, const std::string& dataset_name /*, TODO ...*/) +inline auto vv_load(const H5Easy::File& file, const std::string& dataset_name) +{ + return H5Easy::load>>(file, dataset_name); +} + +template +inline HighFive::DataSet writeDataSet(H5Easy::File& file, const std::string& dataset_name, SpanRC data /*, TODO ...*/) { const std::vector dims{data.dims().row, data.dims().col}; const HighFive::DataSpace dataspace{dims}; @@ -50,11 +63,26 @@ inline HighFive::DataSet writeDataSet(H5Easy::File& file, SpanRC data, const return retval; } +template +inline HighFive::DataSet writeDataSet(const H5Easy::File& file, const std::string& dataset_name, const T& values /*, TODO ...*/) +{ + auto dataset = file.createDataSet(dataset_name, HighFive::DataSpace::From(values)); + dataset.write(values); + return dataset; +} + +// This loads 2D data into one large block of contiguous memory. +// (HighFive::DataSet::read() uses a vector of vectors). template -inline SpanRC readDataSet(HighFive::DataSet& dataSet, std::vector& result /*, TODO ...*/) +inline SpanRC readDataSet(const HighFive::DataSet& dataSet, std::vector& result /*, TODO ...*/) { const auto dimensions = dataSet.getSpace().getDimensions(); - const types::RowCol dims(dimensions[0], dimensions[1]); + if (dimensions.size() > 2) + { + throw std::invalid_argument("'dataSet' has unexpected dimensions."); + } + const auto col = dimensions.size() == 2 ? dimensions[1] : 1; + const types::RowCol dims(dimensions[0], col); result.resize(dims.area()); dataSet.read(result.data()); @@ -63,12 +91,51 @@ inline SpanRC readDataSet(HighFive::DataSet& dataSet, std::vector& result } template -inline SpanRC load(H5Easy::File& file, const std::string& dataset_name, std::vector& result /*, TODO ...*/) +inline SpanRC loadDataSet(const H5Easy::File& file, const std::string& dataset_name, std::vector& result /*, TODO ...*/) { auto dataSet = file.getDataSet(dataset_name); return readDataSet(dataSet, result); } +// Wrapper around HighFive::Attribute::read() to fix problems bug with reading strings +template +inline void read(const HighFive::Attribute& attribute, T& array) +{ + attribute.read(array); +} +template <> +inline void read(const HighFive::Attribute& attribute, std::string& array) +{ + // Attribute::read() doesn't seem to work for fixed length strings + const auto dataType = attribute.getDataType(); + if (!dataType.isFixedLenStr()) + { + return attribute.read(array); // let HighFive deal with it + } + + // https://stackoverflow.com/questions/31344648/c-c-hdf5-read-string-attribute + std::vector buf(attribute.getStorageSize() + 1, '\0'); + const auto err = H5Aread(attribute.getId(), dataType.getId(), buf.data()); + if (err < 0) + { + throw std::runtime_error("H5Aread() failed."); + } + array = buf.data(); +} + +template +inline T read(const HighFive::Attribute& a) +{ + return a.read(); +} +template<> +inline std::string read(const HighFive::Attribute& a) +{ + std::string retval; + read(a, retval); + return retval; +} + } } diff --git a/modules/c++/hdf5.lite/source/H5.h b/modules/c++/hdf5.lite/source/H5.h index 24b0d8cfc..ecfe293d1 100644 --- a/modules/c++/hdf5.lite/source/H5.h +++ b/modules/c++/hdf5.lite/source/H5.h @@ -20,17 +20,16 @@ * */ +#pragma once #ifndef CODA_OSS_hdf5_lite_H5_h_INCLUDED_ #define CODA_OSS_hdf5_lite_H5_h_INCLUDED_ -#pragma once #include -// see https://docs.hdfgroup.org/archive/support/HDF5/doc1.8/cpplus_RM/readdata_8cpp-example.html -#include - #include "types/RowCol.h" +#include "hdf5/lite/H5_.h" + // Utility routines for INTERNAL use! namespace hdf5 diff --git a/modules/c++/hdf5.lite/source/hdf5.lite.h b/modules/c++/hdf5.lite/source/hdf5.lite.h index fce6fb7c0..29617ac23 100644 --- a/modules/c++/hdf5.lite/source/hdf5.lite.h +++ b/modules/c++/hdf5.lite/source/hdf5.lite.h @@ -20,18 +20,17 @@ * */ +#pragma once #ifndef CODA_OSS_hdf5_lite_hdf5_lite_h_INCLUDED_ #define CODA_OSS_hdf5_lite_hdf5_lite_h_INCLUDED_ -#pragma once #include #include #include -// see https://docs.hdfgroup.org/archive/support/HDF5/doc1.8/cpplus_RM/readdata_8cpp-example.html -#include - #include "except/Exception.h" + +#include "hdf5/lite/H5_.h" #include "hdf5/lite/HDF5Exception.h" // Utility routines for INTERNAL use! diff --git a/modules/c++/hdf5.lite/unittests/test_highfive.cpp b/modules/c++/hdf5.lite/unittests/test_highfive.cpp index 1b6ee2862..b506e4948 100644 --- a/modules/c++/hdf5.lite/unittests/test_highfive.cpp +++ b/modules/c++/hdf5.lite/unittests/test_highfive.cpp @@ -27,13 +27,10 @@ #include "sys/FileFinder.h" #include "types/RowCol.h" +#include "mem/ComplexView.h" -#include "highfive/H5Easy.hpp" -#include "highfive/H5DataSet.hpp" -#include "highfive/H5File.hpp" - -#include "hdf5/lite/SpanRC.h" #include "hdf5/lite/highfive.h" +#include "hdf5/lite/SpanRC.h" static std::filesystem::path find_unittest_file(const std::filesystem::path& name) { @@ -46,10 +43,23 @@ TEST_CASE(test_highfive_load) static const auto path = find_unittest_file("example.h5"); const H5Easy::File file(path.string()); - const auto lat = H5Easy::load>(file, "/g4/lat"); - TEST_ASSERT_EQ(lat.size(), 19); - TEST_ASSERT_ALMOST_EQ(lat[0], -90.0); - TEST_ASSERT_ALMOST_EQ(lat[0], -lat[18]); + + { + const auto lat = H5Easy::load>(file, "/g4/lat"); + TEST_ASSERT_EQ(lat.size(), 19); + TEST_ASSERT_ALMOST_EQ(lat[0], -90.0); + TEST_ASSERT_ALMOST_EQ(lat[0], -lat[18]); + } + { + std::vector lat; + const auto rc = hdf5::lite::loadDataSet(file, "/g4/lat", lat); + TEST_ASSERT_EQ(lat.size(), 19); + TEST_ASSERT_EQ(lat.size(), rc.area()); + TEST_ASSERT_EQ(rc.dims().row, 19); + TEST_ASSERT_EQ(rc.dims().col, 1); + TEST_ASSERT_ALMOST_EQ(lat[0], -90.0); + TEST_ASSERT_ALMOST_EQ(lat[0], -lat[18]); + } } TEST_CASE(test_highfive_FileException) @@ -77,11 +87,11 @@ TEST_CASE(test_highfive_nested) static const auto path = find_unittest_file("123_barfoo_catdog_cx.h5"); const H5Easy::File file(path.string()); - const auto i = H5Easy::load>>(file, "/1/bar/cat/i"); + const auto i = hdf5::lite::vv_load(file, "/1/bar/cat/i"); TEST_ASSERT_EQ(i.size(), 1); TEST_ASSERT_EQ(i[0].size(), 10); - const auto r = H5Easy::load>>(file, "/1/bar/dog/r"); + const auto r = hdf5::lite::vv_load(file, "/1/bar/dog/r"); TEST_ASSERT_EQ(r.size(), 1); TEST_ASSERT_EQ(r[0].size(), 10); @@ -89,6 +99,31 @@ TEST_CASE(test_highfive_nested) TEST_ASSERT_EQ(i[0].size(), r[0].size()); } +template +static auto read_complex(const HighFive::DataSet& r, const HighFive::DataSet& i) +{ + std::vector r_result; + hdf5::lite::readDataSet(r, r_result); + std::vector i_result; + hdf5::lite::readDataSet(i, i_result); + return std::make_pair(r, i); +} +template +static auto read_complex(const HighFive::Group& group) +{ + const auto i = group.getDataSet("i"); + const auto r = group.getDataSet("r"); + return read_complex(r, i); +} +template +static auto load_complex(const H5Easy::File& file, + const std::string& r_path, const std::string& i_path) +{ + const auto r = hdf5::lite::v_load(file, r_path); + const auto i = hdf5::lite::v_load(file, i_path); + return std::make_pair(r, i); +} + TEST_CASE(test_highfive_nested_small) { // top group: Data @@ -100,15 +135,22 @@ TEST_CASE(test_highfive_nested_small) static const auto path = find_unittest_file("nested_complex_float32_data_small.h5"); const H5Easy::File file(path.string()); - const auto i = H5Easy::load>(file, "/Data/1/bar/cat/a/i"); + + const auto i = hdf5::lite::v_load(file, "/Data/1/bar/cat/a/i"); TEST_ASSERT_EQ(i.size(), 10); - auto actual = std::accumulate(i.cbegin(), i.cend(), 0.0); - TEST_ASSERT_EQ(actual, 0.0); + auto actual = std::accumulate(i.begin(), i.end(), 0.0f); + TEST_ASSERT_EQ(actual, 0.0f); - const auto r = H5Easy::load>(file, "/Data/5/foo/dog/d/r"); + const auto r = hdf5::lite::v_load(file, "/Data/5/foo/dog/d/r"); TEST_ASSERT_EQ(r.size(), 10); - actual = std::accumulate(r.cbegin(), r.cend(), 0.0); - TEST_ASSERT_EQ(actual, 10.0); + actual = std::accumulate(r.begin(), r.end(), 0.0f); + TEST_ASSERT_EQ(actual, 10.0f); + + const auto a = load_complex(file, "/Data/1/bar/cat/a/r", "/Data/1/bar/cat/a/i"); + const auto cx_view = mem::make_ComplexSpansView(a.first, a.second); + const auto cx_actual = std::accumulate(cx_view.begin(), cx_view.end(), std::complex(0.0)); + TEST_ASSERT_EQ(cx_actual.real(), 10.0f); + TEST_ASSERT_EQ(cx_actual.imag(), 0.0f); } TEST_CASE(test_highfive_nested_small_wrongType) @@ -228,15 +270,18 @@ TEST_CASE(test_highfive_datasetinfo) TEST_ASSERT_EQ(time.listAttributeNames().size(), 2); } -static void read_complex(const std::string& testName, const HighFive::Group& group) -{ - const auto i = group.getDataSet("i"); - TEST_ASSERT(i.getDataType().getClass() == HighFive::DataTypeClass::Float); - TEST_ASSERT_EQ(i.getElementCount(), 10); - - const auto r = group.getDataSet("r"); +static void read_complex(const std::string& testName, const HighFive::DataSet& r, const HighFive::DataSet& i) +{ TEST_ASSERT(r.getDataType().getClass() == HighFive::DataTypeClass::Float); TEST_ASSERT_EQ(r.getElementCount(), 10); + TEST_ASSERT(i.getDataType().getClass() == HighFive::DataTypeClass::Float); + TEST_ASSERT_EQ(i.getElementCount(), 10); + std::ignore = read_complex(r, i); +} +static void read_complex(const std::string& testName, const HighFive::Group& group) +{ + read_complex(testName, group.getDataSet("r"), group.getDataSet("i")); + std::ignore = read_complex(group); } TEST_CASE(test_highfive_info_nested) { @@ -299,26 +344,58 @@ TEST_CASE(test_highfive_info_nested) //******************************************************************************* -TEST_CASE(test_highfive_create) +template +static auto make_data(const types::RowCol& dims) { - static const auto path_ = find_unittest_file("example.h5"); - static const auto path = path_.parent_path() / "TEST_highfive_create_TMP.h5"; - H5Easy::File file(path.string(), H5Easy::File::Overwrite); - - const types::RowCol dims{10, 20}; - std::vector> DS1(dims.row); - float d = 0.0f; - for (auto&& r : DS1) + std::vector> retval(dims.row); + int d = 0; + for (auto&& r : retval) { r.resize(dims.col); - for (size_t c = 0; c < r.size(); c++) + for (auto&& v : r) { - r[c] = d++; + v = static_cast(d++); } } + return retval; +} + +TEST_CASE(test_highfive_dump) +{ + static const std::string dataset_name("/DS1"); + using dataset_t = float; + static const auto path_ = find_unittest_file("example.h5"); + const auto path = path_.parent_path() / "TEST_highfive_create_TMP.h5"; + + { + const std::vector data{1, 2, 3, 4, 5}; + H5Easy::File file(path.string(), H5Easy::File::Overwrite); + //std::ignore = H5Easy::dump(file, dataset_name, data); + TEST_SUCCESS; + } - H5Easy::dump(file, "/DS1", DS1); - TEST_SUCCESS; + const types::RowCol dims{10, 20}; + const auto data = make_data(dims); + { + H5Easy::File file(path.string(), H5Easy::File::Overwrite); + //std::ignore = H5Easy::dump(file, dataset_name, data); + TEST_SUCCESS; + } + + // Be sure we can read the file just written + const H5Easy::File file(path.string(), H5Easy::File::ReadOnly); + //const auto DS1 = hdf5::lite::vv_load(file, dataset_name); + //TEST_ASSERT_EQ(DS1.size(), dims.row); + //TEST_ASSERT_EQ(DS1[0].size(), dims.col); + //for (size_t r = 0; r < DS1.size(); r++) + //{ + // for (size_t c = 0; c < DS1[r].size(); c++) + // { + // const auto expected = data[r][c]; + // const auto actual = DS1[r][c]; + // TEST_ASSERT_EQ(actual, expected); + // } + //} } TEST_CASE(test_highfive_write) @@ -339,7 +416,7 @@ TEST_CASE(test_highfive_write) } { H5Easy::File file(path.string(), H5Easy::File::Overwrite); - const auto ds = hdf5::lite::writeDataSet(file, data, "DS1"); + const auto ds = hdf5::lite::writeDataSet(file, "DS1", data); const auto dimensions = ds.getDimensions(); TEST_ASSERT_EQ(dimensions.size(), 2); TEST_ASSERT_EQ(dims.row, dimensions[0]); @@ -350,7 +427,7 @@ TEST_CASE(test_highfive_write) { const H5Easy::File file(path.string()); - const auto DS1 = H5Easy::load>>(file, "/DS1"); + const auto DS1 = hdf5::lite::vv_load(file, "/DS1"); TEST_ASSERT_EQ(DS1.size(), dims.row); TEST_ASSERT_EQ(DS1[0].size(), dims.col); @@ -368,7 +445,7 @@ TEST_CASE(test_highfive_write) H5Easy::File file(path.string()); std::vector result; - const auto rc = hdf5::lite::load(file, "/DS1", result); + const auto rc = hdf5::lite::loadDataSet(file, "/DS1", result); TEST_ASSERT(rc.dims() == dims); TEST_ASSERT_EQ(dims.area(), result.size()); for (size_t i = 0; i < result.size(); i++) @@ -379,6 +456,97 @@ TEST_CASE(test_highfive_write) } } +TEST_CASE(test_highfive_getDataType) +{ + static const auto path = find_unittest_file("example.h5"); + const H5Easy::File file(path.string(), H5Easy::File::ReadOnly); + + const auto time = file.getDataSet("/g4/time"); + TEST_ASSERT(time.getType() == HighFive::ObjectType::Dataset); + TEST_ASSERT_EQ(time.getElementCount(), 10); + const auto dims = time.getDimensions(); + TEST_ASSERT_EQ(dims.size(), 1); + TEST_ASSERT_EQ(dims[0], 10); + + const auto dataType = time.getDataType(); + TEST_ASSERT(dataType.getClass() == HighFive::DataTypeClass::Float); + TEST_ASSERT_EQ(dataType.string(), "Float64"); + TEST_ASSERT_EQ(dataType.getSize(), sizeof(double)); + const auto doubleDataType = HighFive::create_and_check_datatype(); + TEST_ASSERT(doubleDataType == dataType); + + TEST_ASSERT_FALSE(dataType.isVariableStr()); + TEST_ASSERT_FALSE(dataType.isFixedLenStr()); + TEST_ASSERT_FALSE(dataType.isReference()); +} + +template +static auto getAttribute(const std::string& testName, + const THighFive& obj, const std::string& name, + HighFive::DataTypeClass typeClass, const std::string& typeName) +{ + auto attribute = obj.getAttribute(name); + TEST_ASSERT_EQ(attribute.getName(), name); + TEST_ASSERT(attribute.getType() == HighFive::ObjectType::Attribute); + TEST_ASSERT(attribute.getDataType().getClass() == typeClass); + TEST_ASSERT_EQ(attribute.getDataType().string(), typeName); + return attribute; +} +TEST_CASE(test_highfive_getAttribute) +{ + static const auto path = find_unittest_file("example.h5"); + const H5Easy::File file(path.string(), H5Easy::File::ReadOnly); + + { + const auto attribute = getAttribute(testName, file, "attr1", HighFive::DataTypeClass::Integer, "Integer8"); + const auto memSpace = attribute.getMemSpace(); + const auto elements = memSpace.getElementCount(); + TEST_ASSERT_EQ(elements, 10); + std::vector v; + attribute.read(v); + TEST_ASSERT_EQ(v.size(), elements); + } + { + const auto attribute = getAttribute(testName, file, "attr2", HighFive::DataTypeClass::Integer, "Integer32"); + const auto memSpace = attribute.getMemSpace(); + const auto elements = memSpace.getElementCount(); + TEST_ASSERT_EQ(elements, 4); + std::vector> v; + attribute.read(v); + TEST_ASSERT_EQ(v[0][0], 0); + TEST_ASSERT_EQ(v[0][1], 1); + TEST_ASSERT_EQ(v[1][0], 2); + TEST_ASSERT_EQ(v[1][1], 3); + } + + const auto time = file.getDataSet("/g4/time"); + { + const auto attribute = getAttribute(testName, time, "NAME", HighFive::DataTypeClass::String, "String40"); + // throw DataSetException("Can't output std::string as fixed-length. Use raw arrays or FixedLenStringArray"); + // std::string value; + // attribute.read(value); + // HighFive::FixedLenStringArray<16> arr; + // attribute.read(arr); + const auto value = hdf5::lite::read(attribute); + TEST_ASSERT_EQ(value, "time"); + } + { + const auto attribute = getAttribute(testName, time, "CLASS", HighFive::DataTypeClass::String, "String128"); + // attribute.read(value); + const auto value = hdf5::lite::read(attribute); + TEST_ASSERT_EQ(value, "DIMENSION_SCALE"); + } + + const auto lat = file.getDataSet("/g4/lat"); + { + const auto attribute = getAttribute(testName, lat, "units", HighFive::DataTypeClass::String, "String104"); + //HighFive::FixedLenStringArray<104> value; + //attribute.read(value); + const auto value = hdf5::lite::read(attribute); + TEST_ASSERT_EQ(value, "degrees_north"); + } +} + TEST_MAIN( TEST_CHECK(test_highfive_load); TEST_CHECK(test_highfive_FileException); @@ -391,6 +559,9 @@ TEST_MAIN( TEST_CHECK(test_highfive_datasetinfo); TEST_CHECK(test_highfive_info_nested); - //TEST_CHECK(test_highfive_create); + TEST_CHECK(test_highfive_dump); //TEST_CHECK(test_highfive_write); -) + + TEST_CHECK(test_highfive_getDataType); + TEST_CHECK(test_highfive_getAttribute); + ) diff --git a/modules/c++/include/TestCase.h b/modules/c++/include/TestCase.h index a068260e0..5a091dd9b 100644 --- a/modules/c++/include/TestCase.h +++ b/modules/c++/include/TestCase.h @@ -119,7 +119,8 @@ inline void assert_almost_eq_eps(const TX1& X1, const TX2& X2, const TEPS& EPS, const std::string& testName, const char* file, const char* func, int line) { const auto abs_difference = std::abs(X1 - X2); - if (abs_difference > EPS || IS_NAN(abs_difference)) + using abs_difference_t = decltype(abs_difference); + if (abs_difference > static_cast(EPS) || IS_NAN(abs_difference)) { diePrintf_("%s (%s,%s,%d): FAILED: Recv'd %s, Expected %s\n", testName, file, func, line, X1, X2); } @@ -210,6 +211,7 @@ inline int main(TFunc f) #define CODA_OSS_test_eq(X1, X2) (CODA_OSS_test_eq_(X1, X2) && !CODA_OSS_test_ne_(X1, X2)) #define TEST_ASSERT_EQ(X1, X2) if (!CODA_OSS_test_eq((X1), (X2))) { CODA_OSS_test_diePrintf_eq_(X1, X2); } #define TEST_ASSERT_EQ_MSG(msg, X1, X2) if (!CODA_OSS_test_eq((X1), (X2))) { CODA_OSS_test_diePrintf_eq_msg_(msg, X1, X2); } +#define TEST_ASSERT_EQ_STR(X1, X2) TEST_ASSERT_EQ(std::string(X1), std::string(X2)) #define TEST_ASSERT_NOT_EQ(X1, X2) if (!CODA_OSS_test_ne((X1), (X2))) { CODA_OSS_test_diePrintf_not_eq_(X1, X2); } #define TEST_ASSERT_NOT_EQ_MSG(msg, X1, X2) if (!CODA_OSS_test_ne((X1), (X2))) { CODA_OSS_test_diePrintf_not_eq_msg_(msg, X1, X2); } diff --git a/modules/c++/include/UnitTest.h b/modules/c++/include/UnitTest.h new file mode 100644 index 000000000..751843c1f --- /dev/null +++ b/modules/c++/include/UnitTest.h @@ -0,0 +1,143 @@ +#pragma once + +#include +#include + +#include "TestCase.h" +#include "str/EncodedStringView.h" + +#if !_MSC_VER +#error "This file is for use with a Visual Studio 'UnitTest' project." +#endif + +// Use our various TEST macros with a Visual Studio "UnitTest" project. +#include + +#undef TEST_CHECK +#undef TEST_ASSERT +#undef TEST_ASSERT_NULL +#undef TEST_ASSERT_NOT_NULL +#undef TEST_ASSERT_TRUE +#undef TEST_ASSERT_FALSE +#undef TEST_MAIN +#undef TEST_CASE +#define TEST_CHECK(X) +#define TEST_MAIN(X) +#define TEST_ASSERT_NULL(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNull(X) +#define TEST_ASSERT_NOT_NULL(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNotNull(X) +#define TEST_ASSERT_TRUE(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(X) +#define TEST_ASSERT_FALSE(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsFalse(X) +#define TEST_ASSERT(X) TEST_ASSERT_TRUE(X) +#define CODA_OSS_testMethod_(X) testMethod ## _ ## X +#define TEST_CASE(X) TEST_METHOD(X) { CODA_OSS_testMethod_(X)(#X); } void CODA_OSS_testMethod_(X)(std::string testName) + +namespace test +{ + struct Assert final + { + static void FailOnCondition(bool condition, const unsigned short* message, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo); + static std::wstring GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message); + }; +#define CODA_OSS_equals_message_(expected, actual, message) reinterpret_cast(test::Assert::GetAssertMessage(true, test::toString(expected), test::toString(actual), message).c_str()) +#define CODA_OSS_not_equals_message_(notExpected, actual, message) reinterpret_cast(test::Assert::GetAssertMessage(false, test::toString(notExpected), test::toString(actual), message).c_str()) +#define CODA_OSS_message_(message) reinterpret_cast(test::Assert::GetAssertMessage(false, "", "", message).c_str()) + +// see Assert::AreEqual<> +template +inline void diePrintf_eq(const TExpected& expected, const TActual& actual, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(expected == actual, CODA_OSS_equals_message_(expected, actual, message), pLineInfo); +} + +// see Assert::AreNotEqual<> +template +inline void diePrintf_ne(const TExpected& notExpected, const TActual& actual, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(notExpected != actual, CODA_OSS_not_equals_message_(notExpected, actual, message), pLineInfo); +} + +template +inline void diePrintf_ge(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 >= X2, CODA_OSS_message_(message), pLineInfo); +} +template +inline void diePrintf_gt(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 > X2, CODA_OSS_message_(message), pLineInfo); +} +template +inline void diePrintf_le(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 <= X2, CODA_OSS_message_(message), pLineInfo); +} +template +inline void diePrintf_lt(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 < X2, CODA_OSS_message_(message), pLineInfo); +} + +} +#undef CODA_OSS_test_diePrintf_eq_ +#undef CODA_OSS_test_diePrintf_not_eq_ +#define CODA_OSS_test_diePrintf_eq_(X1, X2) testName, ::test::diePrintf_eq(X1, X2) +#define CODA_OSS_test_diePrintf_not_eq_(X1, X2) testName, ::test::diePrintf_ne(X1, X2) + +#undef CODA_OSS_test_diePrintf_greater_eq_ +#undef CODA_OSS_test_diePrintf_greater_ +#undef CODA_OSS_test_diePrintf_lesser_eq_ +#undef CODA_OSS_test_diePrintf_lesser_ +#define CODA_OSS_test_diePrintf_greater_eq_(X1, X2) testName, ::test::diePrintf_ge(X1, X2) +#define CODA_OSS_test_diePrintf_greater_(X1, X2) testName, ::test::diePrintf_gt(X1, X2) +#define CODA_OSS_test_diePrintf_lesser_eq_(X1, X2) testName, ::test::diePrintf_le(X1, X2) +#define CODA_OSS_test_diePrintf_lesser_(X1, X2) testName, ::test::diePrintf_lt(X1, X2) + +template +inline void test_assert_greater_(const TX1& X1, const TX2& X2) +{ + Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(X1 > X2); +} +#undef TEST_ASSERT_GREATER +#define TEST_ASSERT_GREATER(X1, X2) testName, test_assert_greater_(X1, X2) + +#undef TEST_ASSERT_ALMOST_EQ_EPS +#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) { (void)testName; Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(X1, X2, EPS); Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(X2, X1, EPS); } +namespace test +{ +inline void assert_almost_eq(const std::string& testName, float X1, float X2) +{ + constexpr auto EPS = static_cast(0.0001); + TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS); +} +inline void assert_almost_eq(const std::string& testName, double X1, double X2) +{ + constexpr auto EPS = static_cast(0.0001); + TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS); +} +inline void assert_almost_eq(const std::string& testName, long double X1, long double X2) +{ + assert_almost_eq(testName, static_cast(X1), static_cast(X2)); +} +} + +#undef TEST_ASSERT_ALMOST_EQ +#define TEST_ASSERT_ALMOST_EQ(X1, X2) test::assert_almost_eq(testName, X1, X2) + +#undef TEST_ASSERT_EQ_MSG +#define TEST_ASSERT_EQ_MSG(msg, X1, X2) testName, Microsoft::VisualStudio::CppUnitTestFramework::Logger::WriteMessage(msg.c_str()); TEST_ASSERT_EQ(X1, X2) + +#undef TEST_FAIL_MSG +#define TEST_FAIL_MSG(msg) { (void)testName; Microsoft::VisualStudio::CppUnitTestFramework::Assert::Fail(str::EncodedStringView(msg).wstring().c_str()); } + +#undef TEST_EXCEPTION +#undef TEST_THROWS +#undef TEST_SPECIFIC_EXCEPTION +#define TEST_EXCEPTION(X) (void)testName; try{ (X); TEST_FAIL(#X " should have thrown."); } CODA_OSS_TEST_EXCEPTION_catch_ +#define TEST_THROWS(X) (void)testName; try{ (X); TEST_FAIL(#X " should have thrown."); } catch (...){ TEST_ASSERT_TRUE(true); } +#define TEST_SPECIFIC_EXCEPTION(X, Y) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::ExpectException([&](){(X);}) diff --git a/modules/c++/io/include/io/FileOutputStreamOS.h b/modules/c++/io/include/io/FileOutputStreamOS.h index 5347f4c43..b8e70b893 100644 --- a/modules/c++/io/include/io/FileOutputStreamOS.h +++ b/modules/c++/io/include/io/FileOutputStreamOS.h @@ -26,6 +26,8 @@ #include +#include "config/Exports.h" + #if !defined(USE_IO_STREAMS) #include "io/SeekableStreams.h" @@ -55,8 +57,7 @@ namespace io * This class corresponds closely to its java namesake. * It uses native file handles to make writes. */ -class FileOutputStreamOS : public SeekableOutputStream - +class CODA_OSS_API FileOutputStreamOS : public SeekableOutputStream { protected: sys::File mFile; diff --git a/modules/c++/io/include/io/PipeStream.h b/modules/c++/io/include/io/PipeStream.h index 0a6b91035..33dc70736 100644 --- a/modules/c++/io/include/io/PipeStream.h +++ b/modules/c++/io/include/io/PipeStream.h @@ -23,7 +23,7 @@ #ifndef __IO_PIPE_STREAM_H__ #define __IO_PIPE_STREAM_H__ -#include +#include #include #include diff --git a/modules/c++/io/include/io/ReadUtils.h b/modules/c++/io/include/io/ReadUtils.h index 4d16a06d9..c4862a10d 100644 --- a/modules/c++/io/include/io/ReadUtils.h +++ b/modules/c++/io/include/io/ReadUtils.h @@ -20,12 +20,14 @@ * */ +#pragma once #ifndef CODA_OSS_io_ReadUtils_h_INCLUDED_ #define CODA_OSS_io_ReadUtils_h_INCLUDED_ #include #include +#include #include #include // byte #include @@ -40,9 +42,8 @@ namespace io * \param pathname Pathname of the file to read in * \param buffer Raw bytes of the file */ -void readFileContents(const std::string& pathname, - std::vector& buffer); -void readFileContents(const coda_oss::filesystem::path& pathname, std::vector& buffer); +CODA_OSS_API void readFileContents(const std::string& pathname, std::vector& buffer); +CODA_OSS_API void readFileContents(const coda_oss::filesystem::path& pathname, std::vector& buffer); /*! * Reads the contents of a file into a string. The file is assumed to be a @@ -51,7 +52,7 @@ void readFileContents(const coda_oss::filesystem::path& pathname, std::vector (sys::Size_T)avail) - len = (sys::Size_T)avail; + if (len > static_cast(avail)) + len = static_cast(avail); mFile.readInto(buffer, len); return static_cast(len); diff --git a/modules/c++/io/source/InputStream.cpp b/modules/c++/io/source/InputStream.cpp index 3fd81e2f6..e39ac48a6 100644 --- a/modules/c++/io/source/InputStream.cpp +++ b/modules/c++/io/source/InputStream.cpp @@ -102,6 +102,6 @@ sys::SSize_T InputStream::readln(sys::byte *cStr, const sys::Size_T strLenPlusNu if (*(cStr + i) == '\n') return i + 1; // Otherwise, append c; } - return (sys::SSize_T)i; + return static_cast(i); } } diff --git a/modules/c++/io/source/MMapInputStream.cpp b/modules/c++/io/source/MMapInputStream.cpp index 9818ffb04..d942ac223 100644 --- a/modules/c++/io/source/MMapInputStream.cpp +++ b/modules/c++/io/source/MMapInputStream.cpp @@ -38,7 +38,7 @@ void io::MMapInputStream::close() { _unmap(); fclose(mFile); - mFile = NULL; + mFile = nullptr; } void io::MMapInputStream::_map() @@ -50,7 +50,7 @@ void io::MMapInputStream::_unmap() { // std::cout << "Unmapping file... "; mOs.unmapFile(mData, mLength); - mData = NULL; + mData = nullptr; // std::cout << "done!" << std::endl; } diff --git a/modules/c++/io/source/PipeStream.cpp b/modules/c++/io/source/PipeStream.cpp index d25658380..a807299bd 100644 --- a/modules/c++/io/source/PipeStream.cpp +++ b/modules/c++/io/source/PipeStream.cpp @@ -63,7 +63,7 @@ sys::SSize_T io::PipeStream::readln(sys::byte *cStr, while (!feof(pipe)) { // get the next line or return null - if (fgets(cStr, static_cast(strLenPlusNullByte), pipe) != NULL) + if (fgets(cStr, static_cast(strLenPlusNullByte), pipe) != nullptr) { return gsl::narrow(strlen(cStr)); } diff --git a/modules/c++/io/source/ReadUtils.cpp b/modules/c++/io/source/ReadUtils.cpp index b85fbfdd5..6637122e5 100644 --- a/modules/c++/io/source/ReadUtils.cpp +++ b/modules/c++/io/source/ReadUtils.cpp @@ -20,6 +20,8 @@ * */ +#include + #include #include diff --git a/modules/c++/io/source/StandardStreams.cpp b/modules/c++/io/source/StandardStreams.cpp index 02f6a61de..232361399 100644 --- a/modules/c++/io/source/StandardStreams.cpp +++ b/modules/c++/io/source/StandardStreams.cpp @@ -27,7 +27,7 @@ _STDOUT_DEFINE_MUTEX_SEMICOLON_ void io::StandardOutStream::write(const void* buffer, sys::Size_T len) { _STDSTREAM_BEGIN_CS_SEMICOLON_ - std::cout.write((const char*)buffer, len); + std::cout.write(static_cast(buffer), len); _STDSTREAM_END_CS_SEMICOLON_ //int returnVal = fwrite(b, len, len, stdout); if (!std::cout.good()) @@ -47,7 +47,7 @@ void io::StandardOutStream::flush() void io::StandardErrStream::write(const void* buffer, sys::Size_T len) { _STDSTREAM_BEGIN_CS_SEMICOLON_ - std::cerr.write((const char*)buffer, len); + std::cerr.write(static_cast(buffer), len); //int returnVal = fwrite(b, len, len, stderr); _STDSTREAM_END_CS_SEMICOLON_ if (!std::cerr.good()) diff --git a/modules/c++/io/source/StreamSplitter.cpp b/modules/c++/io/source/StreamSplitter.cpp index b92206383..57d6a2f60 100644 --- a/modules/c++/io/source/StreamSplitter.cpp +++ b/modules/c++/io/source/StreamSplitter.cpp @@ -40,7 +40,7 @@ StreamSplitter::StreamSplitter(io::InputStream& inputStream, mNumDelimitersProcessed(0), mBufferStorage(bufferSize), mBufferCapacity(mBufferStorage.size()), - mBuffer(mBufferStorage.empty() ? NULL : &mBufferStorage[0]), + mBuffer(mBufferStorage.empty() ? nullptr : &mBufferStorage[0]), mInputStream(inputStream), mStreamEmpty(false) { diff --git a/modules/c++/logging/unittests/test_exception_logger.cpp b/modules/c++/logging/unittests/test_exception_logger.cpp index f85d8cc54..57016a0de 100644 --- a/modules/c++/logging/unittests/test_exception_logger.cpp +++ b/modules/c++/logging/unittests/test_exception_logger.cpp @@ -43,7 +43,7 @@ class RunNothing final : public sys::Runnable } public: - RunNothing(size_t& c, logging::ExceptionLogger* el, bool getBacktrace=false) : counter(c), exLog(el), getBacktrace(getBacktrace) {} + RunNothing(size_t& c, logging::ExceptionLogger* el, bool getBacktrace_=false) : counter(c), exLog(el), getBacktrace(getBacktrace_) {} virtual void run() override { diff --git a/modules/c++/math.linear/include/math/linear/MatrixMxN.h b/modules/c++/math.linear/include/math/linear/MatrixMxN.h index 39006e134..ef091020c 100644 --- a/modules/c++/math.linear/include/math/linear/MatrixMxN.h +++ b/modules/c++/math.linear/include/math/linear/MatrixMxN.h @@ -1298,7 +1298,7 @@ template template inline MatrixMxN<_ND, _ND, _T> inverseLU(const MatrixMxN<_ND, _ND, _T>& mx) { - MatrixMxN<_ND, _ND, _T> a((_T)0); + MatrixMxN<_ND, _ND, _T> a(static_cast<_T>(0)); // Identity for (size_t i = 0; i < _ND; i++) diff --git a/modules/c++/math/CMakeLists.txt b/modules/c++/math/CMakeLists.txt index 7af371b07..387b3e955 100644 --- a/modules/c++/math/CMakeLists.txt +++ b/modules/c++/math/CMakeLists.txt @@ -3,7 +3,7 @@ set(MODULE_NAME math) coda_add_module( ${MODULE_NAME} VERSION 0.1 - DEPS except-c++ str-c++ sys-c++ types-c++) + DEPS except-c++ str-c++ sys-c++ types-c++ coda_oss-c++) coda_add_tests( MODULE_NAME ${MODULE_NAME} @@ -11,4 +11,5 @@ coda_add_tests( coda_add_tests( MODULE_NAME ${MODULE_NAME} DIRECTORY "unittests" + DEPS std-c++ UNITTEST) diff --git a/modules/c++/math/include/math/Constants.h b/modules/c++/math/include/math/Constants.h index 59064839f..64803a19e 100644 --- a/modules/c++/math/include/math/Constants.h +++ b/modules/c++/math/include/math/Constants.h @@ -20,24 +20,26 @@ * */ -#ifndef __MATH_CONSTANTS_H__ -#define __MATH_CONSTANTS_H__ +#pragma once +#ifndef CODA_OSS_math_Constants_h_INCLUDED_ +#define CODA_OSS_math_Constants_h_INCLUDED_ + +#include "coda_oss/numbers.h" -#include namespace math { -struct Constants +struct Constants final { static constexpr double FEET_TO_METERS = 0.3048; static constexpr double METERS_TO_FEET = 1.0 / FEET_TO_METERS; - static constexpr double RADIANS_TO_DEGREES = 180.0 / M_PI; + static constexpr double RADIANS_TO_DEGREES = 180.0 / coda_oss::numbers::pi; template static constexpr T radians_to_degrees() noexcept { return static_cast(RADIANS_TO_DEGREES); } - static constexpr double DEGREES_TO_RADIANS = M_PI / 180.0; + static constexpr double DEGREES_TO_RADIANS = coda_oss::numbers::pi / 180.0; template static constexpr T degrees_to_radians() noexcept { @@ -55,4 +57,4 @@ struct Constants SPEED_OF_LIGHT_METERS_PER_SEC * METERS_TO_FEET; }; } -#endif +#endif // CODA_OSS_math_Constants_h_INCLUDED_ diff --git a/modules/c++/math/include/math/Round.h b/modules/c++/math/include/math/Round.h index d14151004..f3df72c1f 100644 --- a/modules/c++/math/include/math/Round.h +++ b/modules/c++/math/include/math/Round.h @@ -36,9 +36,11 @@ namespace math * \param value A number to evaluate * \return The 'fixed' number */ -template inline T fix(T value) +template inline T fix(T value_) { - return (value > 0.0 ? std::floor(value) : std::ceil(value)); + const double value = value_; + const auto result = value > 0.0 ? std::floor(value) : std::ceil(value); + return static_cast(result); } /*! @@ -48,9 +50,11 @@ template inline T fix(T value) * \param value A number to evaluate * \return The rounded number */ -template inline T round(T value) +template inline T round(T value_) { - return static_cast(value > 0.0 ? std::floor(value + 0.5) : std::ceil(value - 0.5)); + const double value = value_; + const auto result = value > 0.0 ? std::floor(value + 0.5) : std::ceil(value - 0.5); + return static_cast(result); } /*! @@ -60,7 +64,7 @@ template inline T round(T value) * \param fractionalDigits Number of fractional digits to round to * \return The rounded number */ -template inline T round(T value, size_t fractionalDigits) +template inline T round(T value_, size_t fractionalDigits) { double power10 = 1.0; for (size_t i = 0; i < fractionalDigits; ++i) @@ -68,8 +72,10 @@ template inline T round(T value, size_t fractionalDigits) power10 *= 10.0; } - return static_cast(value > 0.0 ? std::floor(value * power10 + 0.5) / power10 - : std::ceil(value * power10 - 0.5) / power10); + const double value = value_; + const auto result = value > 0.0 ? std::floor(value * power10 + 0.5) / power10 + : std::ceil(value * power10 - 0.5) / power10; + return static_cast(result); } /*! diff --git a/modules/c++/math/source/Bessel.cpp b/modules/c++/math/source/Bessel.cpp index 5c4911c07..b84f4fb8a 100644 --- a/modules/c++/math/source/Bessel.cpp +++ b/modules/c++/math/source/Bessel.cpp @@ -22,6 +22,7 @@ #include #include +#include #include @@ -147,12 +148,12 @@ double besselIOrderN(size_t order, double x) double bi = 1.0; //Downward recurrence from even n - for (size_t jj = 2 * (order + int(std::sqrt(ACC * order))); jj > 0; jj--) + for (size_t jj = 2 * (order + int(std::sqrt(ACC * static_cast(order)))); jj > 0; jj--) { - double bim = bip + (jj * tox * bi); + double bim = bip + (static_cast(jj) * tox * bi); bip = bi; bi = bim; - std::frexp(bi, &k); + std::ignore = std::frexp(bi, &k); //Renormalize to prevent overflow if (k > IEXP) diff --git a/modules/c++/math/tests/complexBenchmark.cpp b/modules/c++/math/tests/complexBenchmark.cpp index 2de00abbc..9484150c9 100644 --- a/modules/c++/math/tests/complexBenchmark.cpp +++ b/modules/c++/math/tests/complexBenchmark.cpp @@ -217,7 +217,7 @@ void loopingBenchmark(size_t size, std::vector > arr(size); //fill the vector based on a random number - srand(static_cast(time(NULL))); + srand(static_cast(time(nullptr))); auto real = static_cast(rand() % 100 + 1); auto imag = static_cast(rand() % 100 + 1); @@ -321,7 +321,7 @@ void singlePassBenchmark(size_t size, std::vector > arr; arr.reserve(endSize); - srand(static_cast(time(NULL))); + srand(static_cast(time(nullptr))); auto real = static_cast(rand() % 100 + 1); auto imag = static_cast(rand() % 100 + 1); diff --git a/modules/c++/math/tests/complexMultiplyBenchmark.cpp b/modules/c++/math/tests/complexMultiplyBenchmark.cpp index 3f7b19ac9..12ea42619 100644 --- a/modules/c++/math/tests/complexMultiplyBenchmark.cpp +++ b/modules/c++/math/tests/complexMultiplyBenchmark.cpp @@ -199,7 +199,7 @@ void loopingBenchmark(size_t size, std::vector > arr(size); //fill the vector based on a random number - srand(static_cast(time(NULL))); + srand(static_cast(time(nullptr))); auto real = static_cast(rand() % 100 + 1); auto imag = static_cast(rand() % 100 + 1); @@ -297,7 +297,7 @@ void singlePassBenchmark(size_t size, std::vector > arr; arr.reserve(endSize); - srand(static_cast(time(NULL))); + srand(static_cast(time(nullptr))); auto real = static_cast(rand() % 100 + 1); auto imag = static_cast(rand() % 100 + 1); diff --git a/modules/c++/math/unittests/test_sign.cpp b/modules/c++/math/unittests/test_sign.cpp index 51d7f510e..89e1b855e 100644 --- a/modules/c++/math/unittests/test_sign.cpp +++ b/modules/c++/math/unittests/test_sign.cpp @@ -23,6 +23,7 @@ #include #include #include +#include TEST_CASE(testZero) { @@ -43,9 +44,19 @@ TEST_CASE(testNegative) TEST_ASSERT_EQ(math::sign(-0.1), -1); } +TEST_CASE(testConstants) +{ + static auto pi = std::numbers::pi; // "Conditional expression is constant" + TEST_ASSERT_EQ(pi, M_PI); + + static auto e = std::numbers::e; // "Conditional expression is constant" + TEST_ASSERT_EQ(e, M_E); +} + TEST_MAIN( TEST_CHECK(testZero); TEST_CHECK(testPositive); TEST_CHECK(testNegative); + TEST_CHECK(testConstants); ) diff --git a/modules/c++/math/wscript b/modules/c++/math/wscript index 1c048f0c4..c8de78ecc 100644 --- a/modules/c++/math/wscript +++ b/modules/c++/math/wscript @@ -1,9 +1,9 @@ from build import writeConfig NAME = 'math' -MAINTAINER = 'asylvest@users.sourceforge.net' VERSION = '0.1' USELIB = 'MATH' -MODULE_DEPS = 'except str sys types' +MODULE_DEPS = 'except str sys types coda_oss' +TEST_DEPS = 'std' options = distclean = lambda p: None diff --git a/modules/c++/mem/include/mem/AutoPtr.h b/modules/c++/mem/include/mem/AutoPtr.h index 0061b4726..ee3eba601 100644 --- a/modules/c++/mem/include/mem/AutoPtr.h +++ b/modules/c++/mem/include/mem/AutoPtr.h @@ -27,7 +27,6 @@ #include -#include "coda_oss/memory.h" #include "mem/SharedPtr.h" namespace mem diff --git a/modules/c++/mem/include/mem/ScopedPtr.h b/modules/c++/mem/include/mem/ScopedPtr.h index 11a57072b..8b1c1d075 100644 --- a/modules/c++/mem/include/mem/ScopedPtr.h +++ b/modules/c++/mem/include/mem/ScopedPtr.h @@ -21,9 +21,11 @@ * */ +#pragma once #ifndef CODA_OSS_mem_ScopedPtr_h_INCLUDED_ #define CODA_OSS_mem_ScopedPtr_h_INCLUDED_ -#pragma once + +#include #include #include @@ -110,15 +112,13 @@ class ScopedPtr auto rhs_ptr = rhs.get(); if (ptr == nullptr && rhs_ptr == nullptr) { - return true; + return true; // both NULL: equal } - if (ptr == nullptr || rhs_ptr == nullptr) { - return false; + return false; // either NULL, but not both (above): not equal } - - return *ptr == *rhs_ptr; + return *ptr == *rhs_ptr; // compare the (non-NULL) objects } bool operator!=(const ScopedPtr& rhs) const noexcept @@ -138,12 +138,16 @@ class ScopedPtr T& operator*() const { - return *get(); + auto ptr = get(); + assert(ptr != nullptr); + return *ptr; } T* operator->() const noexcept { - return get(); + auto ptr = get(); + assert(ptr != nullptr); + return ptr; } void reset(T* ptr = nullptr) diff --git a/modules/c++/mem/include/mem/ScratchMemory.h b/modules/c++/mem/include/mem/ScratchMemory.h index 1a89da787..57724f0a7 100644 --- a/modules/c++/mem/include/mem/ScratchMemory.h +++ b/modules/c++/mem/include/mem/ScratchMemory.h @@ -50,8 +50,7 @@ namespace mem class CODA_OSS_API ScratchMemory { public: - //! Default constructor - ScratchMemory(); + ScratchMemory() = default; /*! * \brief Reserve a buffer segment within this scratch memory buffer. @@ -183,8 +182,8 @@ class CODA_OSS_API ScratchMemory std::set mConnectedKeys; BufferView mBuffer; - size_t mNumBytesNeeded; - size_t mOffset; + size_t mNumBytesNeeded=0; + size_t mOffset=0; }; } diff --git a/modules/c++/mem/include/mem/ScratchMemory.hpp b/modules/c++/mem/include/mem/ScratchMemory.hpp index 0682c5d83..45c6fcd26 100644 --- a/modules/c++/mem/include/mem/ScratchMemory.hpp +++ b/modules/c++/mem/include/mem/ScratchMemory.hpp @@ -38,7 +38,7 @@ inline void ScratchMemory::put(const std::string& key, size_t alignment) { // invalidate buffer (setup must be called before any subsequent get call) - mBuffer.data = NULL; + mBuffer.data = nullptr; size_t segmentOffset = mOffset; diff --git a/modules/c++/mem/include/mem/SharedPtrCpp11.h b/modules/c++/mem/include/mem/SharedPtrCpp11.h index 867634180..f6832fbce 100644 --- a/modules/c++/mem/include/mem/SharedPtrCpp11.h +++ b/modules/c++/mem/include/mem/SharedPtrCpp11.h @@ -20,16 +20,13 @@ * */ +#pragma once #ifndef CODA_OSS_mem_SharedPtrCpp11_h_INCLUDED_ #define CODA_OSS_mem_SharedPtrCpp11_h_INCLUDED_ -#pragma once #include #include -#include "coda_oss/memory.h" -#include "sys/CPlusPlus.h" - namespace mem { // Pretty much give-up on mem::SharedPtr as it's too hard to get something that will diff --git a/modules/c++/mem/source/ScratchMemory.cpp b/modules/c++/mem/source/ScratchMemory.cpp index bcedacaf0..a3f162daa 100644 --- a/modules/c++/mem/source/ScratchMemory.cpp +++ b/modules/c++/mem/source/ScratchMemory.cpp @@ -25,20 +25,15 @@ namespace mem { -ScratchMemory::ScratchMemory() : - mNumBytesNeeded(0), - mOffset(0) -{ -} -ScratchMemory::Segment::Segment(size_t numBytes, - size_t numBuffers, - size_t alignment, - size_t offset) : - numBytes(numBytes), - numBuffers(numBuffers), - alignment(alignment), - offset(offset) +ScratchMemory::Segment::Segment(size_t numBytes_, + size_t numBuffers_, + size_t alignment_, + size_t offset_) : + numBytes(numBytes_), + numBuffers(numBuffers_), + alignment(alignment_), + offset(offset_) { } @@ -185,7 +180,7 @@ void ScratchMemory::setup(const BufferView& scratchBuffer) throw except::Exception(Ctxt( "Buffer has insufficient space for scratch memory")); } - if (scratchBuffer.data == NULL) + if (scratchBuffer.data == nullptr) { throw except::Exception(Ctxt( "Invalid external buffer was provided")); @@ -214,7 +209,7 @@ const ScratchMemory::Segment& ScratchMemory::lookupSegment( const std::string& key, size_t indexBuffer) const { - if (mBuffer.data == NULL) + if (mBuffer.data == nullptr) { std::ostringstream oss; oss << "Tried to get scratch memory for \"" << key diff --git a/modules/c++/mem/tests/ScratchVisualization.cpp b/modules/c++/mem/tests/ScratchVisualization.cpp index 2585f7473..791964c72 100644 --- a/modules/c++/mem/tests/ScratchVisualization.cpp +++ b/modules/c++/mem/tests/ScratchVisualization.cpp @@ -32,12 +32,12 @@ namespace { struct Operation { - Operation(const std::string& op, - const std::string& name, - const size_t bytes) : - op(op), - name(name), - bytes(bytes) + Operation(const std::string& op_, + const std::string& name_, + const size_t bytes_) : + op(op_), + name(name_), + bytes(bytes_) { } @@ -72,7 +72,7 @@ class Visualizer mHTMLFile(htmlFile), mCSSFile(cssFile) { - mStartPtr = NULL; + mStartPtr = nullptr; mColors.push_back("lightgrey"); mColors.push_back("lightblue"); mColors.push_back("lightcyan"); diff --git a/modules/c++/mem/unittests/test_Span.cpp b/modules/c++/mem/unittests/test_Span.cpp index 472a87992..28a76ad20 100644 --- a/modules/c++/mem/unittests/test_Span.cpp +++ b/modules/c++/mem/unittests/test_Span.cpp @@ -26,6 +26,7 @@ #include #include +#include #include "TestCase.h" @@ -94,8 +95,43 @@ TEST_CASE(testGslNarrow) TEST_THROWS(gsl::narrow(d)); } +TEST_CASE(test_sys_make_span) +{ + int i = 314; + int* const p = &i; + auto s = sys::make_span(p, 1); + TEST_ASSERT(s.data() == p); + TEST_ASSERT_EQ(s[0], i); + s[0] = 123; + TEST_ASSERT_EQ(i, 123); + s[0] = 314; + + const int* const q = &i; + auto cs = sys::make_span(q, 1); + TEST_ASSERT(cs.data() == q); + TEST_ASSERT_EQ(cs[0], i); + //cs[0] = 123; // cs = span + TEST_ASSERT_EQ(i, 314); + + std::vector v{314}; + s = sys::make_span(v); + TEST_ASSERT(s.data() == v.data()); + TEST_ASSERT_EQ(s[0], v[0]); + s[0] = 123; + TEST_ASSERT_EQ(v[0], 123); + s[0] = 314; + + const std::vector& u = v; + cs = sys::make_span(u); + TEST_ASSERT(cs.data() == u.data()); + TEST_ASSERT_EQ(cs[0], u[0]); + // cs[0] = 123; // cs = span + TEST_ASSERT_EQ(u[0], 314); +} + TEST_MAIN( TEST_CHECK(testSpanBuffer); TEST_CHECK(testSpanVector); TEST_CHECK(testGslNarrow); + TEST_CHECK(test_sys_make_span); ) diff --git a/modules/c++/mem/unittests/test_scratch_memory.cpp b/modules/c++/mem/unittests/test_scratch_memory.cpp index 8ef51ee4f..5186e8956 100644 --- a/modules/c++/mem/unittests/test_scratch_memory.cpp +++ b/modules/c++/mem/unittests/test_scratch_memory.cpp @@ -617,7 +617,7 @@ TEST_CASE(testScratchMemory) TEST_EXCEPTION(scratch.setup(smallBuffer)); // calling setup with invalid external buffer should throw - mem::BufferView invalidBuffer(NULL, buffer.size); + mem::BufferView invalidBuffer(nullptr, buffer.size); TEST_EXCEPTION(scratch.setup(invalidBuffer)); } diff --git a/modules/c++/mem/unittests/test_shared_ptr.cpp b/modules/c++/mem/unittests/test_shared_ptr.cpp index 866df1eb7..1441f4723 100644 --- a/modules/c++/mem/unittests/test_shared_ptr.cpp +++ b/modules/c++/mem/unittests/test_shared_ptr.cpp @@ -69,19 +69,19 @@ size_t cpp11Function(std::shared_ptr foo) TEST_CASE(testNullCopying) { mem::SharedPtr ptr1; - TEST_ASSERT_EQ(ptr1.get(), static_cast(NULL)); + TEST_ASSERT_EQ(ptr1.get(), static_cast(nullptr)); // Copy construction const mem::SharedPtr ptr2(ptr1); - TEST_ASSERT_EQ(ptr2.get(), static_cast(NULL)); + TEST_ASSERT_EQ(ptr2.get(), static_cast(nullptr)); // Assignment operator mem::SharedPtr ptr3; ptr3 = ptr1; - TEST_ASSERT_EQ(ptr3.get(), static_cast(NULL)); + TEST_ASSERT_EQ(ptr3.get(), static_cast(nullptr)); ptr1.reset(); - TEST_ASSERT_EQ(ptr1.get(), static_cast(NULL)); + TEST_ASSERT_EQ(ptr1.get(), static_cast(nullptr)); } TEST_CASE(testAutoPtrConstructor) @@ -90,7 +90,7 @@ TEST_CASE(testAutoPtrConstructor) std::unique_ptr autoPtr(rawPtr); const mem::SharedPtr ptr(autoPtr.release()); TEST_ASSERT_EQ(ptr.get(), rawPtr); - TEST_ASSERT_EQ(autoPtr.get(), static_cast(NULL)); + TEST_ASSERT_EQ(autoPtr.get(), static_cast(nullptr)); //TEST_ASSERT_EQ(ptr.getCount(), 1); TEST_ASSERT_EQ(ptr.use_count(), 1); TEST_ASSERT_EQ(getCount(ptr), 1); @@ -287,7 +287,7 @@ TEST_CASE(testCasting) std::unique_ptr autoBar(rawBar); const mem::SharedPtr fooPtr(autoBar.release()); TEST_ASSERT_EQ(fooPtr.get(), rawBar); - TEST_ASSERT_EQ(autoBar.get(), static_cast(NULL)); + TEST_ASSERT_EQ(autoBar.get(), static_cast(nullptr)); //TEST_ASSERT_EQ(fooPtr.getCount(), 1); TEST_ASSERT_EQ(fooPtr.use_count(), 1); TEST_ASSERT_EQ(getCount(fooPtr), 1); diff --git a/modules/c++/mt/include/import/mt.h b/modules/c++/mt/include/import/mt.h index 10caa17e6..2a35e189c 100644 --- a/modules/c++/mt/include/import/mt.h +++ b/modules/c++/mt/include/import/mt.h @@ -21,8 +21,14 @@ */ -#ifndef __IMPORT_MT_H__ -#define __IMPORT_MT_H__ +#pragma once +#ifndef CODA_OSS_mt_import_mt_h_h_INCLUDED_ +#define CODA_OSS_mt_import_mt_h_h_INCLUDED_ + +#if _MSC_VER +#pragma warning(push) +#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to 'extern "C"' function under - EHc.Undefined behavior may occur if this function throws an exception. +#endif // _MSC_VER #include "mt/RequestQueue.h" #include "mt/ThreadPoolException.h" @@ -45,4 +51,8 @@ #include "mt/CPUAffinityThreadInitializer.h" #include "mt/Algorithm.h" -#endif +#if _MSC_VER +#pragma warning(pop) +#endif // _MSC_VER + +#endif // CODA_OSS_mt_import_mt_h_h_INCLUDED_ diff --git a/modules/c++/mt/include/mt/AbstractThreadPool.h b/modules/c++/mt/include/mt/AbstractThreadPool.h index c72e9bd32..92d3de272 100644 --- a/modules/c++/mt/include/mt/AbstractThreadPool.h +++ b/modules/c++/mt/include/mt/AbstractThreadPool.h @@ -66,6 +66,11 @@ template class AbstractThreadPool join();//destroy(); } + AbstractThreadPool(const AbstractThreadPool&) = delete; + AbstractThreadPool& operator=(const AbstractThreadPool&) = delete; + AbstractThreadPool(AbstractThreadPool&&) = delete; + AbstractThreadPool& operator=(AbstractThreadPool&&) = delete; + /*! * Intialize and start each thread running. * Typically the caller will either join at this point diff --git a/modules/c++/mt/include/mt/Algorithm.h b/modules/c++/mt/include/mt/Algorithm.h index 4ef5b5ec9..ba17f39f5 100644 --- a/modules/c++/mt/include/mt/Algorithm.h +++ b/modules/c++/mt/include/mt/Algorithm.h @@ -30,41 +30,12 @@ namespace mt { -namespace details -{ - template - inline OutputIt transform_async(const InputIt first1, const InputIt last1, OutputIt d_first, TFunc f, - typename std::iterator_traits::difference_type cutoff, std::launch policy) - { - // https://en.cppreference.com/w/cpp/thread/async - const auto len = std::distance(first1, last1); - if (len < cutoff) - { - return std::transform(first1, last1, d_first, f); - } - - const auto mid1 = first1 + len / 2; - const auto d_mid = d_first + len / 2; - auto handle = std::async(policy, transform_async, mid1, last1, d_mid, f, cutoff, policy); - details::transform_async(first1, mid1, d_first, f, cutoff, policy); - return handle.get(); - } -} -template -inline OutputIt transform_async(const InputIt first1, const InputIt last1, OutputIt d_first, TFunc f, - typename std::iterator_traits::difference_type cutoff, std::launch policy) -{ - // details::... eliminates the overload - return details::transform_async(first1, last1, d_first, f, cutoff, policy); -} -template -inline OutputIt transform_async(const InputIt first1, const InputIt last1, OutputIt d_first, TFunc f, - typename std::iterator_traits::difference_type cutoff) -{ - const std::launch policy = std::launch::deferred | std::launch::async; - return transform_async(first1, last1, d_first, f, cutoff, policy); +// There was a transform_async() utility here, but I removed it. +// +// First of all, C++11's std::async() is now (in 2023) thought of as maybe a +// bit "half baked," and perhaps shouldn't be emulated. Then, C++17 added +// parallel algorithms which might be a better ... although we're still at C++14. } -} #endif // CODA_OSS_mt_Algorithm_h_INCLUDED_ diff --git a/modules/c++/mt/include/mt/RequestQueue.h b/modules/c++/mt/include/mt/RequestQueue.h index cb0d8201c..ad33a53a1 100644 --- a/modules/c++/mt/include/mt/RequestQueue.h +++ b/modules/c++/mt/include/mt/RequestQueue.h @@ -97,13 +97,13 @@ struct RequestQueue } // Check to see if its empty - inline bool isEmpty() + bool isEmpty() const { - return (mRequestQueue.size() == 0); + return mRequestQueue.empty(); } // Check the length - inline int length() + int length() const { return mRequestQueue.size(); } diff --git a/modules/c++/mt/include/mt/ThreadedByteSwap.h b/modules/c++/mt/include/mt/ThreadedByteSwap.h new file mode 100644 index 000000000..0b97e1171 --- /dev/null +++ b/modules/c++/mt/include/mt/ThreadedByteSwap.h @@ -0,0 +1,90 @@ +#ifndef CODA_OSS_mt_ThreadedByteSwap_h_INCLUDED_ +#define CODA_OSS_mt_ThreadedByteSwap_h_INCLUDED_ +#pragma once + +#include + +#include "sys/ByteSwap.h" + +#include "ThreadPlanner.h" +#include "ThreadGroup.h" + +namespace mt +{ +/* + * Threaded byte-swapping + * + * \param buffer Buffer to swap (contents will be overridden) + * \param elemSize Size of each element in 'buffer' + * \param numElements Number of elements in 'buffer' + * \param numThreads Number of threads to use for byte-swapping + */ +inline void threadedByteSwap(void* buffer, size_t elemSize, size_t numElements, size_t numThreads) +{ + if (numThreads <= 1) + { + sys::byteSwap(buffer, elemSize, numElements); + } + else + { + mt::ThreadGroup threads; + const mt::ThreadPlanner planner(numElements, numThreads); + + size_t threadNum(0); + size_t startElement(0); + size_t numElementsThisThread(0); + while (planner.getThreadInfo(threadNum++, startElement, numElementsThisThread)) + { + auto thread = std::make_unique( + buffer, + elemSize, + startElement, + numElementsThisThread); + + threads.createThread(thread.release()); + } + threads.joinAll(); + } +} + +/* + * Threaded byte-swapping and copy + * + * \param buffer Buffer to swap + * \param elemSize Size of each element in 'buffer' + * \param numElements Number of elements in 'buffer' + * \param numThreads Number of threads to use for byte-swapping + * \param outputBuffer buffer to write into + */ +inline void threadedByteSwap(const void* buffer, size_t elemSize, size_t numElements, size_t numThreads, void* outputBuffer) +{ + if (numThreads <= 1) + { + sys::byteSwap(buffer, elemSize, numElements, outputBuffer); + } + else + { + mt::ThreadGroup threads; + const mt::ThreadPlanner planner(numElements, numThreads); + + size_t threadNum(0); + size_t startElement(0); + size_t numElementsThisThread(0); + while (planner.getThreadInfo(threadNum++, startElement, numElementsThisThread)) + { + auto thread = std::make_unique( + buffer, + elemSize, + startElement, + numElementsThisThread, + outputBuffer); + + threads.createThread(thread.release()); + } + threads.joinAll(); + + } +} +} + +#endif // CODA_OSS_mt_ThreadedByteSwap_h_INCLUDED_ diff --git a/modules/c++/mt/include/mt/WorkerThread.h b/modules/c++/mt/include/mt/WorkerThread.h index 4e865d0ff..2a2e20468 100644 --- a/modules/c++/mt/include/mt/WorkerThread.h +++ b/modules/c++/mt/include/mt/WorkerThread.h @@ -52,8 +52,12 @@ template class WorkerThread : public sys::Thread /*! * Virtual destructor */ - virtual ~WorkerThread() - {} + virtual ~WorkerThread() = default; + + WorkerThread(const WorkerThread&) = delete; + WorkerThread& operator=(const WorkerThread&) = delete; + WorkerThread(WorkerThread&&) = delete; + WorkerThread& operator=(WorkerThread&&) = delete; virtual void initialize() {} diff --git a/modules/c++/mt/source/GenerationThreadPool.cpp b/modules/c++/mt/source/GenerationThreadPool.cpp index a3776c3e8..651756573 100644 --- a/modules/c++/mt/source/GenerationThreadPool.cpp +++ b/modules/c++/mt/source/GenerationThreadPool.cpp @@ -29,7 +29,7 @@ mt::TiedRequestHandler::~TiedRequestHandler() if (mAffinityInit) { delete mAffinityInit; - mAffinityInit = NULL; + mAffinityInit = nullptr; } } @@ -50,7 +50,7 @@ void mt::TiedRequestHandler::run() while (true) { // Pull a runnable off the queue - sys::Runnable *handler = NULL; + sys::Runnable *handler = nullptr; mRequestQueue->dequeue(handler); if (!handler) return; @@ -93,7 +93,7 @@ void mt::GenerationThreadPool::waitGroup() /*void mt::GenerationThreadPool::shutdown() { size_t size = mPool.size(); - static sys::Runnable* shutdown = NULL; + static sys::Runnable* shutdown = nullptr; for(unsigned int i=0; i < size; i++) { addRequest(shutdown); diff --git a/modules/c++/mt/source/GenericRequestHandler.cpp b/modules/c++/mt/source/GenericRequestHandler.cpp index 015a77f91..9fe488668 100644 --- a/modules/c++/mt/source/GenericRequestHandler.cpp +++ b/modules/c++/mt/source/GenericRequestHandler.cpp @@ -29,7 +29,7 @@ void mt::GenericRequestHandler::run() while (true) { // Pull a runnable off the queue - sys::Runnable* handler = NULL; + sys::Runnable* handler = nullptr; mRequest->dequeue(handler); if (!handler) { diff --git a/modules/c++/mt/source/ThreadGroup.cpp b/modules/c++/mt/source/ThreadGroup.cpp index 85bf054c5..0a3616a39 100644 --- a/modules/c++/mt/source/ThreadGroup.cpp +++ b/modules/c++/mt/source/ThreadGroup.cpp @@ -34,7 +34,7 @@ namespace mt ThreadGroup::ThreadGroup(bool pinToCPU) : - mAffinityInit(pinToCPU ? new CPUAffinityInitializer() : NULL), + mAffinityInit(pinToCPU ? new CPUAffinityInitializer() : nullptr), mLastJoined(0) { } @@ -163,7 +163,7 @@ void ThreadGroup::ThreadGroupRunnable::run() bool ThreadGroup::isPinToCPUEnabled() const { - return mAffinityInit.get() != NULL; + return mAffinityInit.get() != nullptr; } bool ThreadGroup::getDefaultPinToCPU() diff --git a/modules/c++/mt/tests/ThreadGroupAffinityTest.cpp b/modules/c++/mt/tests/ThreadGroupAffinityTest.cpp index 32d3c63c0..57f3e3f68 100644 --- a/modules/c++/mt/tests/ThreadGroupAffinityTest.cpp +++ b/modules/c++/mt/tests/ThreadGroupAffinityTest.cpp @@ -20,6 +20,8 @@ * */ +#include + #if !defined(__APPLE_CC__) && (defined(__linux) || defined(__linux__)) #include @@ -64,8 +66,8 @@ class MyRunTask : public Runnable // assigned to for (size_t trials = 0; trials < 10; ++trials) { - volatile size_t count = 10000000000; - volatile size_t sum = 0; + constexpr size_t count = 10000000000; + std::atomic sum{0}; for (size_t ii = 0; ii < count; ++ii) { sum++; diff --git a/modules/c++/mt/unittests/Runnable1DTest.cpp b/modules/c++/mt/unittests/Runnable1DTest.cpp index 14a419d78..7c4c5bb57 100644 --- a/modules/c++/mt/unittests/Runnable1DTest.cpp +++ b/modules/c++/mt/unittests/Runnable1DTest.cpp @@ -83,31 +83,7 @@ TEST_CASE(Runnable1DWithCopiesTest) TEST_ASSERT_TRUE(true); // need to use hidden "testName" parameter } -TEST_CASE(transform_async_test) -{ - const auto f = [&](const int& i) { return i * i; }; - - std::vector ints_(10000); - std::iota(ints_.begin(), ints_.end(), 1); - const auto& ints = ints_; - - std::vector results(ints.size()); - - results.back() = results.front(); - std::transform(ints.begin(), ints.end(), results.begin(), f); - TEST_ASSERT_EQ(results.back(), f(ints.back())); - - results.back() = results.front(); - mt::transform_async(ints.begin(), ints.end(), results.begin(), f, 1000); - TEST_ASSERT_EQ(results.back(), f(ints.back())); - - results.back() = results.front(); - mt::transform_async(ints.begin(), ints.end(), results.begin(), f, 1000, std::launch::async); - TEST_ASSERT_EQ(results.back(), f(ints.back())); -} - TEST_MAIN( TEST_CHECK(DoRunnable1DTest); TEST_CHECK(Runnable1DWithCopiesTest); - TEST_CHECK(transform_async_test); ) diff --git a/modules/c++/mt/unittests/test_mt_byte_swap.cpp b/modules/c++/mt/unittests/test_mt_byte_swap.cpp new file mode 100644 index 000000000..d2099cf83 --- /dev/null +++ b/modules/c++/mt/unittests/test_mt_byte_swap.cpp @@ -0,0 +1,72 @@ +/* ========================================================================= + * This file is part of mt-c++ + * ========================================================================= + * + * (C) Copyright 2004 - 2017, MDA Information Systems LLC + * + * sys-c++ is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this program; If not, + * see . + * + */ + +#include "TestCase.h" + +#include + +#include +#include // std::byte +#include + +#include + +static std::vector make_origValues(size_t NUM_PIXELS) +{ + ::srand(334); + + std::vector retval(NUM_PIXELS); + for (size_t ii = 0; ii < NUM_PIXELS; ++ii) + { + const auto value = static_cast(::rand()) / RAND_MAX * + std::numeric_limits::max(); + retval[ii] = static_cast(value); + } + return retval; +} + +TEST_CASE(testThreadedByteSwap) +{ + constexpr size_t NUM_PIXELS = 10000; + const auto origValues = make_origValues(NUM_PIXELS); + + constexpr size_t numThreads = 4; + + // Byte swap the old-fashioned way + auto values1(origValues); + mt::threadedByteSwap(values1.data(), sizeof(values1[0]), NUM_PIXELS, numThreads); + + // Byte swap into output buffer + std::vector swappedValues2(origValues.size()); + mt::threadedByteSwap(origValues.data(), sizeof(origValues[0]), NUM_PIXELS, numThreads, swappedValues2.data()); + + // Everything should match + for (size_t ii = 0; ii < NUM_PIXELS; ++ii) + { + TEST_ASSERT_EQ(values1[ii], swappedValues2[ii]); + } +} + +TEST_MAIN( + TEST_CHECK(testThreadedByteSwap); + ) + \ No newline at end of file diff --git a/modules/c++/net.ssl/source/SSLConnection.cpp b/modules/c++/net.ssl/source/SSLConnection.cpp index e0f37d1e7..903fa077d 100644 --- a/modules/c++/net.ssl/source/SSLConnection.cpp +++ b/modules/c++/net.ssl/source/SSLConnection.cpp @@ -30,12 +30,12 @@ net::ssl::SSLConnection::SSLConnection(std::unique_ptr&& socket, const std::string& host) : NetConnection(std::move(socket)), mServerAuthentication(serverAuth) { - mSSL = NULL; + mSSL = nullptr; mBioErr = BIO_new_fp(stderr, BIO_NOCLOSE); mSSL = SSL_new(ctx); - if (mSSL == NULL) + if (mSSL == nullptr) { throw net::ssl::SSLException(Ctxt(FmtX("SSL_new failed"))); } @@ -45,11 +45,11 @@ net::ssl::SSLConnection::SSLConnection(std::unique_ptr&& socket, net::ssl::SSLConnection::~SSLConnection() { - if(mSSL != NULL) + if(mSSL != nullptr) { SSL_shutdown(mSSL); } - if(mSSL != NULL) + if(mSSL != nullptr) { SSL_free(mSSL); } diff --git a/modules/c++/net.ssl/source/SSLConnectionClientFactory.cpp b/modules/c++/net.ssl/source/SSLConnectionClientFactory.cpp index c3cefdd41..5a9d44148 100644 --- a/modules/c++/net.ssl/source/SSLConnectionClientFactory.cpp +++ b/modules/c++/net.ssl/source/SSLConnectionClientFactory.cpp @@ -58,12 +58,12 @@ void net::ssl::SSLConnectionClientFactory::initializeContext() const SSL_METHOD *method = SSLv23_client_method(); #endif - if(method == NULL) + if(method == nullptr) { throw net::ssl::SSLException(Ctxt(FmtX("SSLv23_client_method failed"))); } mCtx = SSL_CTX_new(method); - if(mCtx == NULL) + if(mCtx == nullptr) { throw net::ssl::SSLException(Ctxt(FmtX("SSL_CTX_new failed"))); } diff --git a/modules/c++/net/include/net/NetConnectionServer.h b/modules/c++/net/include/net/NetConnectionServer.h index debc58d32..e27a0d543 100644 --- a/modules/c++/net/include/net/NetConnectionServer.h +++ b/modules/c++/net/include/net/NetConnectionServer.h @@ -56,9 +56,12 @@ class NetConnectionServer NetConnectionServer(); //! Destructor. - virtual ~NetConnectionServer() - { - } + virtual ~NetConnectionServer() = default; + + NetConnectionServer(const NetConnectionServer&) = delete; + NetConnectionServer& operator=(const NetConnectionServer&) = delete; + NetConnectionServer(NetConnectionServer&&) = default; + NetConnectionServer& operator=(NetConnectionServer&&) = default; /*! * Create a server on the port, with a backlog queue given in the diff --git a/modules/c++/net/include/net/PerRequestThreadAllocStrategy.h b/modules/c++/net/include/net/PerRequestThreadAllocStrategy.h index c02cb530b..956861047 100644 --- a/modules/c++/net/include/net/PerRequestThreadAllocStrategy.h +++ b/modules/c++/net/include/net/PerRequestThreadAllocStrategy.h @@ -61,8 +61,12 @@ class RequestHandlerThread : public sys::Thread {} //! Destructor - ~RequestHandlerThread() - {} + ~RequestHandlerThread() = default; + + RequestHandlerThread(const RequestHandlerThread&) = delete; + RequestHandlerThread& operator=(const RequestHandlerThread&) = delete; + RequestHandlerThread(RequestHandlerThread&&) = delete; + RequestHandlerThread& operator=(RequestHandlerThread&&) = delete; /*! * Overloaded run method for handling a connection. diff --git a/modules/c++/net/include/net/SocketsWin32.h b/modules/c++/net/include/net/SocketsWin32.h index b0490a7c3..9e363c648 100644 --- a/modules/c++/net/include/net/SocketsWin32.h +++ b/modules/c++/net/include/net/SocketsWin32.h @@ -20,20 +20,28 @@ * */ -#ifndef __NET_SOCKETS_WIN32_H__ -#define __NET_SOCKETS_WIN32_H__ #pragma once +#ifndef CODA_OSS_net_SocketsWin32_h_INCLUDED_ +#define CODA_OSS_net_SocketsWin32_h_INCLUDED_ #include +#include + +#ifndef _WINSOCK2API_ // already #include'd #undef BIGENDIAN // #define'd in +#define _WINSOCK_DEPRECATED_NO_WARNINGS // '...': Use getaddrinfo() or GetAddrInfoW() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings #include #include -#include + +#endif // _WINSOCK2API_ #ifndef BIGENDIAN #error BIGENDIAN should be #defined! #endif +#include + + /*! * \file * \brief Handle winsock-level callss @@ -97,7 +105,7 @@ inline void Win32SocketInit() inited = true; WORD versionRequested = MAKEWORD(1, 1); WSADATA wsaData; - WSAStartup(versionRequested, &wsaData); + std::ignore = WSAStartup(versionRequested, &wsaData); atexit( net::Win32SocketDestroy ); } } @@ -109,5 +117,4 @@ inline void Win32SocketInit() } - -#endif +#endif // CODA_OSS_net_SocketsWin32_h_INCLUDED_ diff --git a/modules/c++/net/include/net/ThreadPoolAllocStrategy.h b/modules/c++/net/include/net/ThreadPoolAllocStrategy.h index 767e02450..2dc4b0509 100644 --- a/modules/c++/net/include/net/ThreadPoolAllocStrategy.h +++ b/modules/c++/net/include/net/ThreadPoolAllocStrategy.h @@ -41,6 +41,11 @@ class ConnectionThread: public mt::WorkerThread delete mHandler; } + ConnectionThread(const ConnectionThread&) = delete; + ConnectionThread& operator=(const ConnectionThread&) = delete; + ConnectionThread(ConnectionThread&&) = delete; + ConnectionThread& operator=(ConnectionThread&&) = delete; + /*! * Do this in a loop forever. */ @@ -78,6 +83,11 @@ class ConnectionThreadPool: public mt::AbstractThreadPool delete mFactory; } + ConnectionThreadPool(const ConnectionThreadPool&) = delete; + ConnectionThreadPool& operator=(const ConnectionThreadPool&) = delete; + ConnectionThreadPool(ConnectionThreadPool&&) = delete; + ConnectionThreadPool& operator=(ConnectionThreadPool&&) = delete; + mt::WorkerThread* newWorker() override { return new ConnectionThread(&mRequestQueue, mFactory->create()); diff --git a/modules/c++/net/source/CurlHandle.cpp b/modules/c++/net/source/CurlHandle.cpp index 4840dc8eb..1b3554ccd 100644 --- a/modules/c++/net/source/CurlHandle.cpp +++ b/modules/c++/net/source/CurlHandle.cpp @@ -31,7 +31,7 @@ namespace net CurlHandle::CurlHandle() : mHandle(curl_easy_init()) { - if (mHandle == NULL) + if (mHandle == nullptr) { throw except::Exception(Ctxt("curl_easy_init() failed")); } @@ -103,7 +103,7 @@ size_t CurlHandle::writeBetterCallback(char* data, size_t nmemb, std::string* writeData) { - if (writeData == NULL) + if (writeData == nullptr) { return 0; } diff --git a/modules/c++/net/source/NetConnectionServer.cpp b/modules/c++/net/source/NetConnectionServer.cpp index e6f4a4c59..0bb479b62 100644 --- a/modules/c++/net/source/NetConnectionServer.cpp +++ b/modules/c++/net/source/NetConnectionServer.cpp @@ -58,7 +58,7 @@ net::NetConnection* net::NetConnectionServer::accept() void net::NetConnectionServer::initialize(net::RequestHandlerFactory* factory, net::AllocStrategy* newStrategy) { - std::unique_ptr tmp ((newStrategy == NULL) ? + std::unique_ptr tmp ((newStrategy == nullptr) ? new DefaultAllocStrategy() : newStrategy); tmp->setRequestHandlerFactory(factory); diff --git a/modules/c++/net/source/NetUtils.cpp b/modules/c++/net/source/NetUtils.cpp index 98c49d9a6..5df324fe7 100644 --- a/modules/c++/net/source/NetUtils.cpp +++ b/modules/c++/net/source/NetUtils.cpp @@ -133,7 +133,7 @@ std::string net::unquote(std::string s) { std::string part = parts[i]; std::string hexStr = "0x" + part.substr(0, 2); - long val = strtol(hexStr.c_str(), NULL, 16); + long val = strtol(hexStr.c_str(), nullptr, 16); unquoted << (char) val; if (part.length() > 2) unquoted << part.substr(2); diff --git a/modules/c++/net/source/SocketAddress.cpp b/modules/c++/net/source/SocketAddress.cpp index e5dcf0494..a6e4e0c9d 100644 --- a/modules/c++/net/source/SocketAddress.cpp +++ b/modules/c++/net/source/SocketAddress.cpp @@ -20,6 +20,8 @@ * */ +#include + #ifdef _WIN32 #define _WINSOCK_DEPRECATED_NO_WARNINGS #endif @@ -69,7 +71,7 @@ void SocketAddress::setHost(const std::string& host) struct sockaddr saddr; int slen = sizeof(saddr); struct sockaddr_in *paddr = (struct sockaddr_in *)&saddr; - (void) WSAStringToAddress((LPSTR)host.c_str(), AF_INET, NULL, &saddr, &slen); + std::ignore = WSAStringToAddress((LPSTR)host.c_str(), AF_INET, nullptr, &saddr, &slen); mAddress.sin_addr = paddr->sin_addr; #else ::inet_pton(AF_INET, host.c_str(), &mAddress.sin_addr); diff --git a/modules/c++/net/source/URL.cpp b/modules/c++/net/source/URL.cpp index 881a4b854..8791e0c6b 100644 --- a/modules/c++/net/source/URL.cpp +++ b/modules/c++/net/source/URL.cpp @@ -161,7 +161,7 @@ bool net::URLParams::contains(std::string key) const net::URLParams::ParamValues& net::URLParams::get(std::string key) { net::URLParams::Params::iterator it = mParams.find(key); - if (it == mParams.end() || it->second.size() == 0) + if (it == mParams.end() || it->second.empty()) throw except::NoSuchKeyException(Ctxt(key)); return it->second; } @@ -169,14 +169,14 @@ net::URLParams::ParamValues& net::URLParams::get(std::string key) const net::URLParams::ParamValues& net::URLParams::get(std::string key) const { net::URLParams::Params::const_iterator it = mParams.find(key); - if (it == mParams.end() || it->second.size() == 0) + if (it == mParams.end() || it->second.empty()) throw except::NoSuchKeyException(Ctxt(key)); return it->second; } std::string net::URLParams::getFirst(std::string key) const { net::URLParams::Params::const_iterator it = mParams.find(key); - if (it == mParams.end() || it->second.size() == 0) + if (it == mParams.end() || it->second.empty()) throw except::NoSuchKeyException(Ctxt(key)); return it->second.front(); } diff --git a/modules/c++/net/tests/AckMulticastSender.cpp b/modules/c++/net/tests/AckMulticastSender.cpp index a5c97008a..e02d52752 100644 --- a/modules/c++/net/tests/AckMulticastSender.cpp +++ b/modules/c++/net/tests/AckMulticastSender.cpp @@ -143,8 +143,8 @@ template class AckMulticastSender //FD_SET(mAckChannel->getHandle(), &writers); assert(FD_ISSET(mAckChannel->getHandle(), &readers)); //int rv = 1; - int rv = ::select(mAckChannel->getHandle() + 1, &readers, NULL, - NULL, &tv); + int rv = ::select(mAckChannel->getHandle() + 1, &readers, nullptr, + nullptr, &tv); if (rv < 0) { throw sys::SocketException(Ctxt("Select failed")); diff --git a/modules/c++/net/tests/NetConnectionServerTest.cpp b/modules/c++/net/tests/NetConnectionServerTest.cpp index bcbb46ac1..ed72a907b 100644 --- a/modules/c++/net/tests/NetConnectionServerTest.cpp +++ b/modules/c++/net/tests/NetConnectionServerTest.cpp @@ -76,7 +76,7 @@ int main(int argc, char **argv) if (argc < 2) throw Exception(FmtX("Usage: %s (-mt|-st|-tp)", argv[0])); - net::AllocStrategy* strategy = NULL; + net::AllocStrategy* strategy = nullptr; if (argc == 3) { diff --git a/modules/c++/net/tests/TCPClientTest.cpp b/modules/c++/net/tests/TCPClientTest.cpp index 47a9c10a0..0ca69b276 100644 --- a/modules/c++/net/tests/TCPClientTest.cpp +++ b/modules/c++/net/tests/TCPClientTest.cpp @@ -60,7 +60,7 @@ int main(int argc, char** argv) std::unique_ptr socket = TCPClientSocketFactory().create(sa); my_packet_t packet; packet.packet_no = 1; - packet.time_stamp = time(NULL); + packet.time_stamp = time(nullptr); socket->send(&packet, sizeof(my_packet_t)); int rv; socket->recv(&rv, sizeof(int)); diff --git a/modules/c++/net/tests/UDPClientTest.cpp b/modules/c++/net/tests/UDPClientTest.cpp index 76fed3372..ae2e28ba2 100644 --- a/modules/c++/net/tests/UDPClientTest.cpp +++ b/modules/c++/net/tests/UDPClientTest.cpp @@ -66,7 +66,7 @@ int main(int argc, char** argv) std::unique_ptr socket = UDPClientSocketFactory().create(sa); my_packet_t packet; packet.packet_no = 1; - packet.time_stamp = time(NULL); + packet.time_stamp = time(nullptr); socket->send((const char*)&packet, sizeof(my_packet_t)); int rv; socket->recv((char*)&rv, sizeof(int)); diff --git a/modules/c++/numpyutils/include/numpyutils/numpyutils.h b/modules/c++/numpyutils/include/numpyutils/numpyutils.h index fec9e9e64..4632913dd 100644 --- a/modules/c++/numpyutils/include/numpyutils/numpyutils.h +++ b/modules/c++/numpyutils/include/numpyutils/numpyutils.h @@ -20,14 +20,40 @@ * */ +#pragma once #ifndef __NUMPYUTILS_NUMPYUTILS_H__ #define __NUMPYUTILS_NUMPYUTILS_H__ #define NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION #include -#include CODA_OSS_disable_warning_system_header_push +#if _MSC_VER +#pragma warning(disable: 26493) // Don't use C-style casts (type.4). +#pragma warning(disable: 26494) // Variable '...' is uninitialized. Always initialize an object (type.5). +#pragma warning(disable: 26451) // Arithmetic overflow: Using operator '...' on a 4 byte value and then casting the result to a 8 byte value. Cast the value to the wider type before calling operator '...' to avoid overflow (io.2). +#pragma warning(disable: 26814) // The const variable '...' can be computed at compile-time. Consider using constexpr (con.5). +#pragma warning(disable: 26447) // The function is declared '...' but calls function '...' which may throw exceptions (f.6). +#pragma warning(disable: 26455) // Default constructor should not throw. Declare it '...' (f.6). +#pragma warning(disable: 26440) // Function '...' can be declared '...' (f.6). +#pragma warning(disable: 26496) // The variable '...' does not change after construction, mark it as const (con.4). +#pragma warning(disable: 26462) // The value pointed to by '...' is assigned only once, mark it as a pointer to const (con.4). +#pragma warning(disable: 26435) // Function '...' should specify exactly one of '...', '...', or '...' (c.128). +#pragma warning(disable: 26433) // Function '...' should be marked with '...' (c.128). +#pragma warning(disable: 26497) // You can attempt to make '...' constexpr unless it contains any undefined behavior (f.4). +#pragma warning(disable: 26433) // Function '...' should be marked with '...' (c.128). +#pragma warning(disable: 26456) // Operator '...' hides a non-virtual operator '...' (c.128). +#pragma warning(disable: 26446) // Prefer to use gsl::at() instead of unchecked subscript operator (bounds.4). +#pragma warning(disable: 26477) // Use '...' rather than 0 or NULL(es .47). +#pragma warning(disable: 26457) // (void) should not be used to ignore return values, use '...' instead (es.48). +#pragma warning(disable: 26813) // Use '...' to check if a flag is set. +#else +CODA_OSS_disable_warning(-Wshadow) +CODA_OSS_disable_warning(-Wsuggest-override) +CODA_OSS_disable_warning(-Wzero-as-null-pointer-constant) +#endif + +#include #include CODA_OSS_disable_warning_pop diff --git a/modules/c++/numpyutils/source/numpyutils.cpp b/modules/c++/numpyutils/source/numpyutils.cpp index 6b8a76a5d..31a2452c2 100644 --- a/modules/c++/numpyutils/source/numpyutils.cpp +++ b/modules/c++/numpyutils/source/numpyutils.cpp @@ -20,6 +20,15 @@ * */ + +#include "config/compiler_extensions.h" + +#ifndef _MSC_VER +CODA_OSS_disable_warning(-Wold-style-cast) +CODA_OSS_disable_warning(-Wshadow) +CODA_OSS_disable_warning(-Wsuggest-override) +CODA_OSS_disable_warning(-Wzero-as-null-pointer-constant) +#endif #include #include #include @@ -30,18 +39,12 @@ * https://mail.scipy.org/pipermail/numpy-discussion/2010-December/054350.html * for the source and some discussion */ -#if PY_MAJOR_VERSION >= 3 +static_assert(PY_MAJOR_VERSION >= 3, "Python 3.x required"); void* init_numpy() { import_array(); return nullptr; } -#else -void init_numpy() -{ - import_array(); -} -#endif /* Numpy uses some static variables which are per-compilation * unit and if import_arrays is not called, will segfault on using any of diff --git a/modules/c++/pch.h b/modules/c++/pch.h index 342ae8526..18067f14d 100644 --- a/modules/c++/pch.h +++ b/modules/c++/pch.h @@ -4,26 +4,14 @@ // However, files listed here are ALL re-compiled if any one of them is updated between builds. // Do not add files here that you will be updating frequently as this negates the performance advantage. +#pragma once #ifndef CODA_OSS_pch_h_INCLUDED_ #define CODA_OSS_pch_h_INCLUDED_ -#pragma warning(disable: 4619) // #pragma warning: there is no warning number '...' +#include "coda_oss/CPlusPlus.h" +#include "config/disable_compiler_warnings.h" -#pragma warning(disable: 4820) // '...': '...' bytes padding added after data member '...' -#pragma warning(disable: 4668) // '...' is not defined as a preprocessor macro, replacing with '...' for '...' -#pragma warning(disable: 5045) // Compiler will insert Spectre mitigation for memory load if / Qspectre switch specified -#pragma warning(disable: 4514) // '...': unreferenced inline function has been removed - -#pragma warning(push) -#pragma warning(disable: 4710) // '...': function not inlined -#pragma warning(disable: 5027) // '...': move assignment operator was implicitly defined as deleted -#pragma warning(disable: 5026) // '...': move constructor was implicitly defined as deleted -#pragma warning(disable: 4626) // '...': assignment operator was implicitly defined as deleted -#pragma warning(disable: 4625) // '...': copy constructor was implicitly defined as deleted -#pragma warning(disable: 4355) // '...': used in base member initializer list -#pragma warning(disable: 5220) // '...': a non-static data member with a volatile qualified type no longer implies that compiler generated copy/move constructors and copy/move assignment operators are not trivial -#pragma warning(disable: 5204) // '...': class has virtual functions, but its trivial destructor is not virtual; instances of objects derived from this class may not be destructed correctly -#pragma warning(disable: 5264) // '...': '...' variable is not used +CODA_OSS_disable_warning_system_header_push // add headers that you want to pre-compile here #include "framework.h" @@ -36,19 +24,93 @@ #include #include #include +#include + +CODA_OSS_disable_warning_pop #include "import/std.h" -#include -#include -#include -#include -#include -#include -#include -#pragma warning(pop) + +#include +#include +#pragma comment(lib, "z.lib") +#pragma comment(lib, "minizip.lib") + +#include #pragma warning(disable: 4251) // '...': class '...' needs to have dll-interface to be used by clients of class '...' -#pragma warning(disable: 5105) // macro expansion producing '...' has undefined behavior +#pragma warning(disable: 4365) // '...': conversion from '...' to '...', signed/unsigned mismatch +#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to '...' function under -EHc. Undefined behavior may occur if this function throws an exception. +#pragma warning(disable: 6054) // String '...' might not be zero-terminated. +#pragma warning(disable: 6387) // '...' could be '...'. +#pragma warning(disable: 6305) // Potential mismatch between sizeof and countof quantities. Use sizeof() to scale byte sizes. +#pragma warning(disable: 6389) // Move '...' to anonymous namespace or put a forward declaration in a common header included in this file. + +#pragma warning(disable: 26822) // Dereferencing a null pointer '...' (lifetime.1). +#pragma warning(disable: 26432) // If you define or delete any default operation in the type '...', define or delete them all (c.21). +#pragma warning(disable: 26429) // Symbol '...' is never tested for nullness, it can be marked as not_null (f.23). +#pragma warning(disable: 26455) // Default constructor should not throw. Declare it '...' (f.6). +#pragma warning(disable: 26440) // Function '...' can be declared '...' (f.6). +#pragma warning(disable: 26447) // The function is declared '...' but calls function '...' which may throw exceptions (f.6). +#pragma warning(disable: 26496) // The variable '...' does not change after construction, mark it as const (con.4). +#pragma warning(disable: 26462) // The value pointed to by '...' is assigned only once, mark it as a pointer to const (con.4). +#pragma warning(disable: 26409) // Avoid calling new and delete explicitly, use std::make_unique instead (r.11). +#pragma warning(disable: 26401) // Do not delete a raw pointer that is not an owner (i.11). +#pragma warning(disable: 26472) // Don't use a static_cast for arithmetic conversions. Use brace initialization, gsl::narrow_cast or gsl::narrow (type.1). +#pragma warning(disable: 26485) // Expression '...': No array to pointer decay (bounds.3). +#pragma warning(disable: 26493) // Don't use C-style casts (type.4). +#pragma warning(disable: 26451) // Arithmetic overflow: Using operator '...' on a 4 byte value and then casting the result to a 8 byte value. Cast the value to the wider type before calling operator '...' to avoid overflow (io.2). +#pragma warning(disable: 26494) // Variable '...' is uninitialized. Always initialize an object (type.5). +#pragma warning(disable: 26814) // The const variable '...' can be computed at compile-time. Consider using constexpr (con.5). +#pragma warning(disable: 26826) // Don't use C-style variable arguments (f.55). +#pragma warning(disable: 26435) // Function '...' should specify exactly one of '...', '...', or '...' (c.128). +#pragma warning(disable: 26434) // Function '...' hides a non-virtual function '...'. +#pragma warning(disable: 26400) // Do not assign the result of an allocation or a function call with an owner return value to a raw pointer, use owner instead (i.11). +#pragma warning(disable: 26433) // Function '...' should be marked with '...' (c.128). +#pragma warning(disable: 26456) // Operator '...' hides a non-virtual operator '...' (c.128). +#pragma warning(disable: 26465) // Don't use const_cast to cast away const or volatile. const_cast is not required; constness or volatility is not being removed by this conversion (type.3). +#pragma warning(disable: 26408) // Avoid malloc() and free(), prefer the nothrow version of new with delete (r.10). +#pragma warning(disable: 26471) // Don't use reinterpret_cast. A cast from void* can use static_cast (type.1). +#pragma warning(disable: 26490) // Don't use reinterpret_cast (type.1). +#pragma warning(disable: 26460) // The reference argument '...' for function '...' can be marked as const (con.3). +#pragma warning(disable: 26495) // Variable '...' is uninitialized. Always initialize a member variable (type.6). +#pragma warning(disable: 26461) // The pointer argument '...' for function '...' can be marked as a pointer to const (con.3). +#pragma warning(disable: 26436) // The type '...' with a virtual function needs either public virtual or protected non-virtual destructor (c.35). +#pragma warning(disable: 26467) // Converting from floating point to unsigned integral types results in non-portable code if the double/float has a negative value. Use gsl::narrow_cast or gsl::narrow instead to guard against undefined behavior and potential data loss (es.46). +#pragma warning(disable: 26135) // Missing annotation _Acquires_lock_(this->mNative) at function '...'. +#pragma warning(disable: 28159) // Consider using '...' instead of '...'. Reason: Deprecated. Use VerifyVersionInfo* or IsWindows* macros from VersionHelpers. +#pragma warning(disable: 26439) // This kind of function should not throw. Declare it '...' (f.6). +#pragma warning(disable: 26454) // Arithmetic overflow: '...' operation produces a negative unsigned result at compile time (io.5). +#pragma warning(disable: 26492) // Don't use const_cast to cast away const or volatile (type.3). +#pragma warning(disable: 26110) // Caller failing to hold lock '...' before calling function '...'. +#pragma warning(disable: 26459) // You called an STL function '...' with a raw pointer parameter at position '...' that may be unsafe - this relies on the caller to check that the passed values are correct. Consider wrapping your range in a gsl::span and pass as a span iterator (stl.1). +#pragma warning(disable: 26473) // Don't cast between pointer types where the source type and the target type are the same (type.1). +#pragma warning(disable: 26491) // Don't use static_cast downcasts (type.2). +#pragma warning(disable: 26405) // Do not assign to an owner which may be in valid state (r.3). +#pragma warning(disable: 26403) // Reset or explicitly delete an owner pointer '...' (r.3). +#pragma warning(disable: 26489) // Don't dereference a pointer that may be invalid: '...'. '...' may have been invalidated at line 132 (lifetime.1). +#pragma warning(disable: 26486) // Don't pass a pointer that may be invalid to a function. Parameter 0 '...' in call to '...' may be invalid (lifetime.3). +#pragma warning(disable: 26823) // Dereferencing a possibly null pointer '...' (lifetime.1). +#pragma warning(disable: 26487) // Don't return a pointer '...' that may be invalid (lifetime.4). +#pragma warning(disable: 26812) // The enum type '...' is unscoped. Prefer '...' over '...' (Enum.3). +#pragma warning(disable: 26446) // Prefer to use gsl::at() instead of unchecked subscript operator (bounds.4). +#pragma warning(disable: 26458) // Prefer to use gsl::at() instead of unchecked subscript operator (bounds.4). +#pragma warning(disable: 26482) // Only index into arrays using constant expressions (bounds.2). +#pragma warning(disable: 26481) // Don't use pointer arithmetic. Use span instead (bounds.1). + +// Yes, these are our files ... but they don't change very often, and if they do +// change we want to rebuild everything anyway. +#include "gsl/gsl.h" +#include "config/Exports.h" +#include "except/Throwable.h" +#include "sys/Conf.h" +#include "sys/filesystem.h" +#include "mem/SharedPtr.h" + +#include "xml/lite/xerces_.h" +#pragma comment(lib, "xerces-c") + +#include "hdf5/lite/H5_.h" +#pragma comment(lib, "hdf5-c++.lib") #endif //CODA_OSS_pch_h_INCLUDED_ diff --git a/modules/c++/polygon/include/polygon/Intersections.h b/modules/c++/polygon/include/polygon/Intersections.h index 7b63b69b8..d73ac1f6d 100644 --- a/modules/c++/polygon/include/polygon/Intersections.h +++ b/modules/c++/polygon/include/polygon/Intersections.h @@ -27,6 +27,7 @@ #include #include +#include namespace polygon { @@ -47,14 +48,13 @@ namespace polygon * square will have 1 pixel of its top edge missing. */ template -class Intersections +struct Intersections final { -public: /*! * \class Intersection * \brief Represents an intersection */ - struct Intersection + struct Intersection final { //! First (inclusive) column size_t first; @@ -63,7 +63,7 @@ class Intersections size_t last; //! \return Number of columns - size_t length() const + size_t length() const noexcept { return last - first + 1; } @@ -172,11 +172,10 @@ class Intersections types::RowCol offset) { std::vector > shiftedPoints(points); - for (size_t ii = 0; ii < shiftedPoints.size(); ++ii) + for (auto&& shiftedPoint : shiftedPoints) { // Get the polygon points with respect to the offset - shiftedPoints[ii].row -= offset.row; - shiftedPoints[ii].col -= offset.col; + shiftedPoint -= offset; // TODO: The original implementation did this (plus subtracted 0.5 // from each row and col which we're not doing here). @@ -184,7 +183,7 @@ class Intersections // right on a row, we skip drawing some rows // (test_draw_polygon will illustrate this). I wonder if we // could tweak the sl0 and sl1 logic to avoid this. - PointT& rowPoint(shiftedPoints[ii].row); + PointT& rowPoint(shiftedPoint.row); if (std::floor(rowPoint) == rowPoint) { // Add small amount to move it off the scan line @@ -195,7 +194,7 @@ class Intersections // We need to get all scanline intersections of polygon edges mIntersections.resize(dims.row); - const sys::SSize_T lastRow = static_cast(dims.row) - 1; + const auto lastRow = gsl::narrow(dims.row) - 1; for (size_t ii = 0; ii < shiftedPoints.size(); ++ii) { @@ -256,9 +255,9 @@ class Intersections // that situation. for (sys::SSize_T row = sl0; row <= sl1; ++row) { - const PointT delt = row - r0; - const PointT sli = c0 + delt * dcdr; - mIntersections[row].push_back(sli); + const auto delt = static_cast(row) - r0; + const auto sli = c0 + delt * dcdr; + mIntersections[gsl::narrow(row)].push_back(sli); } } @@ -273,6 +272,12 @@ class Intersections } } } + + // `const` member data means copy/move must be implemented + Intersections(const Intersections&) = delete; + Intersections& operator=(const Intersections&) = delete; + Intersections(Intersections&&) = delete; + Intersections& operator=(Intersections&&) = delete; private: const types::RowCol mDims; diff --git a/modules/c++/re/include/re/Regex.h b/modules/c++/re/include/re/Regex.h index 5a6234b4d..e4338972a 100644 --- a/modules/c++/re/include/re/Regex.h +++ b/modules/c++/re/include/re/Regex.h @@ -205,10 +205,6 @@ class CODA_OSS_API Regex //! The regex object std::regex mRegex; - static const std::regex badDotRegex; - static const std::regex invalidCaret; - static const std::regex invalidDollar; - #else // Internal function for passing flags to pcre2_match() std::string search(const std::string& matchString, @@ -218,7 +214,7 @@ class CODA_OSS_API Regex size_t& end); //! The pcre object - pcre2_code* mPCRE; + pcre2_code* mPCRE = nullptr; #endif }; } diff --git a/modules/c++/re/source/RegexPCRE.cpp b/modules/c++/re/source/RegexPCRE.cpp index e641e2d57..d70885e3e 100644 --- a/modules/c++/re/source/RegexPCRE.cpp +++ b/modules/c++/re/source/RegexPCRE.cpp @@ -29,6 +29,11 @@ #include +#ifndef _MSC_VER +#include "config/compiler_extensions.h" +CODA_OSS_disable_warning(-Wold-style-cast) +#endif + namespace { std::string getErrorMessage(int errorCode) @@ -50,9 +55,9 @@ class ScopedMatchData // to do. ScopedMatchData(const pcre2_code* code) : mCode(code), - mMatchData(pcre2_match_data_create_from_pattern(code, NULL)) + mMatchData(pcre2_match_data_create_from_pattern(code, nullptr)) { - if (mMatchData == NULL) + if (mMatchData == nullptr) { throw re::RegexException(Ctxt( "pcre2_match_data_create_from_pattern() failed to " @@ -90,7 +95,7 @@ class ScopedMatchData startOffset, options, mMatchData, - NULL); // Match context + nullptr); // Match context if (returnCode == PCRE2_ERROR_NOMATCH) { @@ -151,7 +156,7 @@ class ScopedMatchData namespace re { Regex::Regex(const std::string& pattern) : - mPattern(pattern), mPCRE(NULL) + mPattern(pattern), mPCRE(nullptr) { if (!mPattern.empty()) { @@ -161,10 +166,10 @@ Regex::Regex(const std::string& pattern) : void Regex::destroy() { - if (mPCRE != NULL) + if (mPCRE != nullptr) { pcre2_code_free(mPCRE); - mPCRE = NULL; + mPCRE = nullptr; } } @@ -174,7 +179,7 @@ Regex::~Regex() } Regex::Regex(const Regex& rhs) : - mPattern(rhs.mPattern), mPCRE(NULL) + mPattern(rhs.mPattern), mPCRE(nullptr) { compile(mPattern); } @@ -213,9 +218,9 @@ Regex& Regex::compile(const std::string& pattern) FLAGS, &errorCode, &errorOffset, - NULL); // Use default compile context + nullptr); // Use default compile context - if (mPCRE == NULL) + if (mPCRE == nullptr) { std::ostringstream ostr; ostr << "PCRE compilation failed at offset " << errorOffset diff --git a/modules/c++/re/source/RegexSTL.cpp b/modules/c++/re/source/RegexSTL.cpp index 29aed5dd4..ea0bc2bc9 100644 --- a/modules/c++/re/source/RegexSTL.cpp +++ b/modules/c++/re/source/RegexSTL.cpp @@ -30,15 +30,28 @@ namespace re { -// This is a raw literal, so ignore the R"lit( )lit" -const std::regex Regex::badDotRegex( R"lit(((^|[^\\])(\\\\)*)\.)lit", - std::regex::ECMAScript|std::regex::optimize ); -const std::regex Regex::invalidCaret( R"lit([\s\S]*([^\[\\]|[^\\](\\\\)+)\^)lit", +// These are a raw literals, so ignore the R"lit( )lit" +static const std::regex& badDotRegex() +{ + static const std::regex retval(R"lit(((^|[^\\])(\\\\)*)\.)lit", + std::regex::ECMAScript | std::regex::optimize); + return retval; +} + +static const std::regex& invalidCaret() +{ + static const std::regex retval( R"lit([\s\S]*([^\[\\]|[^\\](\\\\)+)\^)lit", std::regex::ECMAScript|std::regex::optimize ); + return retval; +} -const std::regex Regex::invalidDollar( R"lit(^([\s\S]*[^\\](\\\\)*)?\$[\s\S]+$)lit", - std::regex::ECMAScript|std::regex::optimize ); +static const std::regex& invalidDollar() +{ + static const std::regex retval( R"lit(^([\s\S]*[^\\](\\\\)*)?\$[\s\S]+$)lit", + std::regex::ECMAScript|std::regex::optimize ); + return retval; +} Regex::Regex(const std::string& pattern) : mPattern(pattern) @@ -91,8 +104,7 @@ Regex& Regex::compile(const std::string& pattern) std::smatch tmpmatch; // Look for ^ in the middle, but ignore \^ and [^ - if (std::regex_search(mPattern, tmpmatch, - invalidCaret, + if (std::regex_search(mPattern, tmpmatch, invalidCaret(), std::regex_constants::match_continuous)) { std::string msg( @@ -102,8 +114,7 @@ Regex& Regex::compile(const std::string& pattern) } // Look for $ in the middle, but ignore \$ - if (std::regex_match(mPattern, tmpmatch, - invalidDollar)) + if (std::regex_match(mPattern, tmpmatch, invalidDollar())) { std::string msg( "'$' in mid-string is not handled the same by gcc and VS2015!"); @@ -231,7 +242,7 @@ std::string Regex::replaceDot(const std::string& str) const // This makes sure we're not grabbing "\." // Replace just the "." with "[\s\S]" - std::string newstr = std::regex_replace(str, badDotRegex, "$1[\\s\\S]"); + std::string newstr = std::regex_replace(str, badDotRegex(), "$1[\\s\\S]"); return newstr; } diff --git a/modules/c++/sio.lite/CMakeLists.txt b/modules/c++/sio.lite/CMakeLists.txt index da07b2828..5f2a9e96b 100644 --- a/modules/c++/sio.lite/CMakeLists.txt +++ b/modules/c++/sio.lite/CMakeLists.txt @@ -3,7 +3,7 @@ set(MODULE_NAME sio.lite) coda_add_module( ${MODULE_NAME} VERSION 1.0 - DEPS io-c++ types-c++) + DEPS sys-c++ io-c++ types-c++) coda_add_tests( MODULE_NAME ${MODULE_NAME} diff --git a/modules/c++/sio.lite/include/sio/lite/ReadUtils.h b/modules/c++/sio.lite/include/sio/lite/ReadUtils.h index 358e1ae9e..abdab3a03 100644 --- a/modules/c++/sio.lite/include/sio/lite/ReadUtils.h +++ b/modules/c++/sio.lite/include/sio/lite/ReadUtils.h @@ -36,6 +36,7 @@ #include #include #include +#include namespace sio { @@ -70,7 +71,7 @@ void readSIO(const std::string& pathname, reader.read(image.get(), numPixels * sizeof(InputT), true); } template -void readSIO(const sys::filesystem::path& pathname, +void readSIO(const coda_oss::filesystem::path& pathname, types::RowCol& dims, std::vector& image) { @@ -86,7 +87,7 @@ void readSIO(const sys::filesystem::path& pathname, } image.resize(dims.area()); - reader.read(coda_oss::span(image.data(), image.size()), true /*verifyFullRead*/); + reader.read(sys::make_span(image), true /*verifyFullRead*/); } /* diff --git a/modules/c++/sio.lite/include/sio/lite/SioFileWriter.h b/modules/c++/sio.lite/include/sio/lite/SioFileWriter.h index a674a4f60..8d75266d5 100644 --- a/modules/c++/sio.lite/include/sio/lite/SioFileWriter.h +++ b/modules/c++/sio.lite/include/sio/lite/SioFileWriter.h @@ -78,6 +78,11 @@ struct FileWriter if (!mAdopt) mStream.release(); } + FileWriter(const FileWriter&) = delete; + FileWriter& operator=(const FileWriter&) = delete; + FileWriter(FileWriter&&) = default; + FileWriter& operator=(FileWriter&&) = default; + /*! * Writes the SIO given the FileHeader and InputStreams. */ diff --git a/modules/c++/sio.lite/source/FileHeader.cpp b/modules/c++/sio.lite/source/FileHeader.cpp index f0bf8d77f..8a7c8a40f 100644 --- a/modules/c++/sio.lite/source/FileHeader.cpp +++ b/modules/c++/sio.lite/source/FileHeader.cpp @@ -204,6 +204,7 @@ void sio::lite::FileHeader::addUserData(const std::string& field, void sio::lite::FileHeader::addUserData(const std::string& field, int data) { std::vector vec; + vec.reserve(sizeof(int)); char* cData = (char*)&data; for (int i = 0, size = sizeof(int); i < size; ++i) vec.push_back((sys::byte)cData[i]); diff --git a/modules/c++/sio.lite/source/StreamReader.cpp b/modules/c++/sio.lite/source/StreamReader.cpp index d629f809c..2677d9f9b 100644 --- a/modules/c++/sio.lite/source/StreamReader.cpp +++ b/modules/c++/sio.lite/source/StreamReader.cpp @@ -30,7 +30,7 @@ union _IntBuffer int sio::lite::StreamReader::getNextInteger() { - if (header == NULL) + if (header == nullptr) throw sio::lite::InvalidHeaderException( Ctxt("Header == null") @@ -94,7 +94,7 @@ void sio::lite::StreamReader::killHeader() { if (header) delete header; - header = NULL; + header = nullptr; // Reset length so we always have a correct value headerLength = 0; } diff --git a/modules/c++/sio.lite/wscript b/modules/c++/sio.lite/wscript index 5a2a1d10d..b2814566f 100644 --- a/modules/c++/sio.lite/wscript +++ b/modules/c++/sio.lite/wscript @@ -1,6 +1,6 @@ NAME = 'sio.lite' VERSION = '1.0' -MODULE_DEPS = 'io types' +MODULE_DEPS = 'sys io types' options = configure = distclean = lambda p: None diff --git a/modules/c++/std/include/import/cpp14.h b/modules/c++/std/include/import/cpp14.h deleted file mode 100644 index f91af67f1..000000000 --- a/modules/c++/std/include/import/cpp14.h +++ /dev/null @@ -1,61 +0,0 @@ -/* ========================================================================= - * This file is part of std-c++ - * ========================================================================= - * - * (C) Copyright 2004 - 2014, MDA Information Systems LLC - * (C) Copyright 2023, Maxar Technologies, Inc. - * - * std-c++ is free software; you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as published by - * the Free Software Foundation; either version 3 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this program; If not, - * see . - * - */ - - -#ifndef CODA_OSS_import_cpp14_h_INCLUDED_ -#define CODA_OSS_import_cpp14_h_INCLUDED_ -#pragma once - -// Common C++14 headers -#include -#include -#include - -#include -#include -#include -#include -#include -#include -#include -#include - -#include -#include -#include -#include - -#include -#include -#include -#include -#include - -#include -#include -#include -#include - -#endif // CODA_OSS_import_cpp14_h_INCLUDED_ - - diff --git a/modules/c++/std/include/import/cpp17.h b/modules/c++/std/include/import/cpp17.h deleted file mode 100644 index a03b2c5da..000000000 --- a/modules/c++/std/include/import/cpp17.h +++ /dev/null @@ -1,36 +0,0 @@ -/* ========================================================================= - * This file is part of std-c++ - * ========================================================================= - * - * (C) Copyright 2004 - 2014, MDA Information Systems LLC - * (C) Copyright 2023, Maxar Technologies, Inc. - * - * std-c++ is free software; you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as published by - * the Free Software Foundation; either version 3 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this program; If not, - * see . - * - */ - -#ifndef CODA_OSS_import_cpp17_h_INCLUDED_ -#define CODA_OSS_import_cpp17_h_INCLUDED_ -#pragma once - -#include "cpp14.h" - -// Common C++17 headers -#include -#include - -#endif // CODA_OSS_import_cpp17_h_INCLUDED_ - - diff --git a/modules/c++/std/include/import/std.h b/modules/c++/std/include/import/std.h index 426a80f0c..4dee10481 100644 --- a/modules/c++/std/include/import/std.h +++ b/modules/c++/std/include/import/std.h @@ -29,11 +29,10 @@ #include "coda_oss/CPlusPlus.h" #include "config/disable_compiler_warnings.h" -CODA_OSS_disable_warning_push +CODA_OSS_disable_warning_system_header_push #if _MSC_VER #pragma warning(disable: 4619) // #pragma warning: there is no warning number '...' -#pragma warning(disable: 4710) // '...': function not inlined #pragma warning(disable: 5027) // '...': move assignment operator was implicitly defined as deleted #pragma warning(disable: 5026) // '...': move constructor was implicitly defined as deleted #pragma warning(disable: 4626) // '...': assignment operator was implicitly defined as deleted @@ -44,12 +43,63 @@ CODA_OSS_disable_warning_push #pragma warning(disable: 5264) // '...': '...' variable is not used #endif // _MSC_VER -// Common C++14 headers -#include "cpp14.h" +#include +#include +#include +#include +#include +#include +#include +#include -#if CODA_OSS_cpp17 -#include "cpp17.h" -#endif +#include +#include +#include + +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include + +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include + +//#include +#include +#include +#include +#include +#include +#include +#include CODA_OSS_disable_warning_pop diff --git a/modules/c++/std/include/std/bit b/modules/c++/std/include/std/bit index d564c0020..dbcc0b6c5 100644 --- a/modules/c++/std/include/std/bit +++ b/modules/c++/std/include/std/bit @@ -28,7 +28,7 @@ // Make it (too?) easy for clients to get our various std:: implementations #ifndef CODA_OSS_NO_std_endian #if CODA_OSS_cpp20 - // Some implementations cliam to be C++20 w/o + // Some implementations claim to be C++20 w/o #if __has_include() // __has_include is C++17 #include #define CODA_OSS_NO_std_endian 1 // provided by implementation, probably C++20 @@ -47,4 +47,22 @@ namespace std // This is slightly uncouth: we're not supposed to augment "std". } #endif // CODA_OSS_NO_std_endian +// Make it (too?) easy for clients to get our various std:: implementations +#ifndef CODA_OSS_NO_std_byteswap + #if CODA_OSS_cpp23 + #include + #define CODA_OSS_NO_std_byteswap 1 // provided by implementation, probably C++23 + #endif + #ifndef CODA_OSS_NO_std_byteswap + #define CODA_OSS_NO_std_byteswap 0 // <= C++20, use our own + #endif +#endif + +#if !CODA_OSS_NO_std_byteswap +namespace std // This is slightly uncouth: we're not supposed to augment "std". +{ + using coda_oss::byteswap; +} +#endif // CODA_OSS_NO_std_byteswap + #endif // CODA_OSS_std_bit_INCLUDED_ diff --git a/modules/c++/std/include/std/cstddef b/modules/c++/std/include/std/cstddef index 56700ec71..10ba7deac 100644 --- a/modules/c++/std/include/std/cstddef +++ b/modules/c++/std/include/std/cstddef @@ -22,7 +22,10 @@ #define CODA_OSS_std_cstddef_INCLUDED_ #pragma once +#include + #include +#include #include "coda_oss/cstddef.h" #include "coda_oss/CPlusPlus.h" @@ -41,6 +44,7 @@ namespace std // This is slightly uncouth: we're not supposed to augment "std". { using coda_oss::byte; } +static_assert(!std::is_same::value, "'std::byte' should be a unique type."); #endif // !CODA_OSS_NO_std_byte #endif // CODA_OSS_std_cstddef_INCLUDED_ \ No newline at end of file diff --git a/modules/c++/std/include/std/memory b/modules/c++/std/include/std/memory index 192f67094..4cbd01d7c 100644 --- a/modules/c++/std/include/std/memory +++ b/modules/c++/std/include/std/memory @@ -18,28 +18,10 @@ * License along with this program; If not, http://www.gnu.org/licenses/. * */ +#pragma once #ifndef CODA_OSS_std_memory_INCLUDED_ #define CODA_OSS_std_memory_INCLUDED_ -#pragma once #include -#include "coda_oss/memory.h" -#include "coda_oss/CPlusPlus.h" - -// Make it (too?) easy for clients to get our various std:: implementations -#ifndef CODA_OSS_NO_std_make_unique - #if CODA_OSS_cpp14 - #define CODA_OSS_NO_std_make_unique 1 // part of C++14 - #else - #define CODA_OSS_NO_std_make_unique 0 // use our own - #endif -#endif - -#if !CODA_OSS_NO_std_make_unique -namespace std // This is slightly uncouth: we're not supposed to augment "std". -{ - using coda_oss::make_unique; -} -#endif // !CODA_OSS_NO_std_make_unique #endif // CODA_OSS_std_memory_INCLUDED_ \ No newline at end of file diff --git a/modules/c++/std/include/std/numbers b/modules/c++/std/include/std/numbers new file mode 100644 index 000000000..e089df22b --- /dev/null +++ b/modules/c++/std/include/std/numbers @@ -0,0 +1,49 @@ +/* ========================================================================= + * This file is part of std-c++ + * ========================================================================= + * + * (C) Copyright 2023, Maxar Technologies, Inc. + * + * std-c++ is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this program; If not, http://www.gnu.org/licenses/. + * + */ +#pragma once +#ifndef CODA_OSS_std_numbers_INCLUDED_ +#define CODA_OSS_std_numbers_INCLUDED_ + +#include "coda_oss/numbers.h" +#include "coda_oss/CPlusPlus.h" + + // Make it (too?) easy for clients to get our various std:: implementations +#ifndef CODA_OSS_NO_std_numbers + #if CODA_OSS_cpp20 + #include + #define CODA_OSS_NO_std_numbers 1 // provided by implementation, probably C++20 + #endif + #ifndef CODA_OSS_NO_std_numbers + #define CODA_OSS_NO_std_numbers 0 // <= C++20, use our own + #endif +#endif + +#if !CODA_OSS_NO_std_numbers +namespace std // This is slightly uncouth: we're not supposed to augment "std". +{ +namespace numbers +{ + using namespace coda_oss::numbers; +} +} +#endif // CODA_OSS_NO_std_numbers + +#endif // CODA_OSS_std_numbers_INCLUDED_ diff --git a/modules/c++/std/include/std/span b/modules/c++/std/include/std/span index ffa0d1df9..819befe15 100644 --- a/modules/c++/std/include/std/span +++ b/modules/c++/std/include/std/span @@ -39,6 +39,9 @@ namespace std // This is slightly uncouth: we're not supposed to augment "std". { using coda_oss::span; + + using coda_oss::as_bytes; + using coda_oss::as_writable_bytes; } #endif // CODA_OSS_DEFINE_std_span_ diff --git a/modules/c++/str/CMakeLists.txt b/modules/c++/str/CMakeLists.txt index 0228ccda7..de3d531b7 100644 --- a/modules/c++/str/CMakeLists.txt +++ b/modules/c++/str/CMakeLists.txt @@ -3,7 +3,7 @@ set(MODULE_NAME str) coda_add_module( ${MODULE_NAME} VERSION 1.0 - DEPS except-c++ coda_oss-c++) + DEPS types-c++ except-c++ coda_oss-c++) coda_add_tests( MODULE_NAME ${MODULE_NAME} diff --git a/modules/c++/str/include/str/Convert.h b/modules/c++/str/include/str/Convert.h index dd32bd5ea..0b3698e49 100644 --- a/modules/c++/str/include/str/Convert.h +++ b/modules/c++/str/include/str/Convert.h @@ -20,12 +20,11 @@ * */ +#pragma once #ifndef CODA_OSS_str_Convert_h_INCLUDED_ #define CODA_OSS_str_Convert_h_INCLUDED_ -#pragma once #include -#include #include #include #include @@ -34,20 +33,22 @@ #include #include #include +#include #include "config/Exports.h" #include "coda_oss/string.h" #include "coda_oss/optional.h" #include "coda_oss/cstddef.h" +#include "types/Complex.h" #include "import/except.h" namespace str { -template -int getPrecision(const T& type); - -template -int getPrecision(const std::complex& type); +template int getPrecision(const T& type); +template int getPrecision(const std::complex&); +#if CODA_OSS_types_unique_ComplexInteger +template int getPrecision(const types::ComplexInteger&); +#endif namespace details { @@ -334,6 +335,13 @@ int getPrecision(const std::complex& type) { return getPrecision(type.real()); } +#if CODA_OSS_types_unique_ComplexInteger +template +int getPrecision(const types::ComplexInteger& type) +{ + return getPrecision(type.real()); +} +#endif template <> int getPrecision(const float& type); diff --git a/modules/c++/str/include/str/Format.h b/modules/c++/str/include/str/Format.h index b6a6be426..240943807 100644 --- a/modules/c++/str/include/str/Format.h +++ b/modules/c++/str/include/str/Format.h @@ -47,7 +47,7 @@ struct CODA_OSS_API Format final return mString; } - operator std::string& () + operator std::string& () noexcept { return mString; } diff --git a/modules/c++/str/include/str/Manip.h b/modules/c++/str/include/str/Manip.h index 72f56128a..0b48673a5 100644 --- a/modules/c++/str/include/str/Manip.h +++ b/modules/c++/str/include/str/Manip.h @@ -194,9 +194,9 @@ inline std::string join(const std::vector& toks, const std::string& with) if (toks.empty()) return ""; - const auto len = static_cast(toks.size()); + const auto len = toks.size(); std::ostringstream oss; - int i = 0; + size_t i = 0; for (; i < len - 1; i++) { oss << str::toString(toks[i]) << with; @@ -205,6 +205,11 @@ inline std::string join(const std::vector& toks, const std::string& with) return oss.str(); } +// CASE INSENSTIVE string comparision routines. +// Short names w/o a "case insenstive" indicator would seem OK as +// normal (i.e., case sensitive) comparisons will use `==` and `!=` operators. +CODA_OSS_API bool eq(const std::string& lhs, const std::string& rhs) noexcept; +CODA_OSS_API bool ne(const std::string& lhs, const std::string& rhs) noexcept; } diff --git a/modules/c++/str/include/str/Tokenizer.h b/modules/c++/str/include/str/Tokenizer.h index baa502857..4433b1fdc 100644 --- a/modules/c++/str/include/str/Tokenizer.h +++ b/modules/c++/str/include/str/Tokenizer.h @@ -65,7 +65,7 @@ class Tokenizer * Method to return the resultant vector * \return The vector that was created by the tokenizer */ - operator Tokenizer::Tokens& () + operator Tokenizer::Tokens& () noexcept { return vec; } diff --git a/modules/c++/str/source/EncodedStringView.cpp b/modules/c++/str/source/EncodedStringView.cpp index 90fcf3144..6bd00eef4 100644 --- a/modules/c++/str/source/EncodedStringView.cpp +++ b/modules/c++/str/source/EncodedStringView.cpp @@ -27,7 +27,6 @@ #include #include -#include "coda_oss/memory.h" #include "coda_oss/span.h" #include "str/Convert.h" @@ -66,7 +65,7 @@ static std::string to_native(coda_oss::u8string::const_pointer p, size_t sz) } if (Platform == PlatformType::Linux) { - return str::cast(p); // copy + return std::string(str::cast(p), sz); } throw std::logic_error("Unknown platform."); } @@ -75,7 +74,7 @@ static std::string to_native(str::W1252string::const_pointer p, size_t sz) { if (Platform == PlatformType::Windows) { - return str::cast(p); // copy + return std::string(str::cast(p), sz); } if (Platform == PlatformType::Linux) { @@ -86,26 +85,29 @@ static std::string to_native(str::W1252string::const_pointer p, size_t sz) throw std::logic_error("Unknown platform."); } -template -inline coda_oss::span make_span(const CharT* s, size_t c) +template +inline auto make_span(const Char8T* s, size_t c) { - return coda_oss::span(s, c); + static_assert(sizeof(Char8T) == sizeof(char), "sizeof(Char8T) != sizeof(char)"); + return coda_oss::span(s, c); } -template -inline coda_oss::span make_span(const CharT* s) +template +inline auto make_span(const Char8T* s) { - auto s_ = str::cast(s); + auto const s_ = str::cast(s); return make_span(s, strlen(s_)); } -template -inline coda_oss::span make_span(const std::basic_string& s) +template +inline auto make_span(const std::basic_string& s) { - return make_span(s.c_str(), s.size()); + assert(strlen(str::c_str(s)) == s.length()); + return make_span(s.c_str(), s.length()); } -template -inline coda_oss::span make_span(coda_oss::span s) +template +inline auto make_span(coda_oss::span s) { - auto s_ = str::cast(s.data()); + auto const s_ = str::cast(s.data()); + assert(strlen(s_) == s.size()); return coda_oss::span(s_, s.size()); } diff --git a/modules/c++/str/source/Encoding.cpp b/modules/c++/str/source/Encoding.cpp index 86a879b0c..46ce45b73 100644 --- a/modules/c++/str/source/Encoding.cpp +++ b/modules/c++/str/source/Encoding.cpp @@ -33,56 +33,74 @@ #include #include +#include "gsl/gsl.h" +#include "config/compiler_extensions.h" + #include "str/Encoding.h" #include "str/Manip.h" #include "str/Convert.h" -#include "str/utf8.h" #include "str/EncodedStringView.h" + +CODA_OSS_disable_warning_push +#if _MSC_VER +#pragma warning(disable: 26818) // Switch statement does not cover all cases. Consider adding a '...' label (es.79). +#else +CODA_OSS_disable_warning(-Wshadow) +#endif +#include "str/utf8.h" +CODA_OSS_disable_warning_pop + // Need to look up characters from \x80 (EURO SIGN) to \x9F (LATIN CAPITAL LETTER Y WITH DIAERESIS) // in a map: http://www.unicode.org/Public/MAPPINGS/VENDORS/MICSFT/WINDOWS/CP1252.TXT -inline coda_oss::u8string utf8_(std::u32string::value_type ch) +inline coda_oss::u8string utf8_(uint32_t i) { + const auto ch = gsl::narrow(i); return str::to_u8string(std::u32string{ch}); } -static const std::map Windows1252_x80_x9F_to_u8string{ - {0x80, utf8_(0x20AC) } // EURO SIGN - // , {0x81, replacement_character } // UNDEFINED - , {0x82, utf8_(0x201A) } // SINGLE LOW-9 QUOTATION MARK - , {0x83, utf8_(0x0192) } // LATIN SMALL LETTER F WITH HOOK - , {0x84, utf8_(0x201E) } // DOUBLE LOW-9 QUOTATION MARK - , {0x85, utf8_(0x2026) } // HORIZONTAL ELLIPSIS - , {0x86, utf8_(0x2020) } // DAGGER - , {0x87, utf8_(0x2021) } // DOUBLE DAGGER - , {0x88, utf8_(0x02C6) } // MODIFIER LETTER CIRCUMFLEX ACCENT - , {0x89, utf8_(0x2030) } // PER MILLE SIGN - , {0x8A, utf8_(0x0160) } // LATIN CAPITAL LETTER S WITH CARON - , {0x8B, utf8_(0x2039) } // SINGLE LEFT-POINTING ANGLE QUOTATION MARK - , {0x8C, utf8_(0x0152) } // LATIN CAPITAL LIGATURE OE - //, {0x8D, replacement_character } // UNDEFINED - , {0x8E, utf8_(0x017D) } // LATIN CAPITAL LETTER Z WITH CARON - //, {0x8F, replacement_character } // UNDEFINED - //, {0x90, replacement_character } // UNDEFINED - , {0x91, utf8_(0x2018) } // LEFT SINGLE QUOTATION MARK - , {0x92, utf8_(0x2019) } // RIGHT SINGLE QUOTATION MARK - , {0x93, utf8_(0x201C) } // LEFT DOUBLE QUOTATION MARK - , {0x94, utf8_(0x201D) } // RIGHT DOUBLE QUOTATION MARK - , {0x95, utf8_(0x2022) } // BULLET - , {0x96, utf8_(0x2013) } // EN DASH - , {0x97, utf8_(0x2014) } // EM DASH - , {0x98, utf8_(0x02DC) } // SMALL TILDE - , {0x99, utf8_(0x2122) } // TRADE MARK SIGN - , {0x9A, utf8_(0x0161) } // LATIN SMALL LETTER S WITH CARON - , {0x9B, utf8_(0x203A) } // SINGLE RIGHT-POINTING ANGLE QUOTATION MARK - , {0x9C, utf8_(0x0153) } // LATIN SMALL LIGATURE OE - //, {0x9D, replacement_character } // UNDEFINED - , {0x9E, utf8_(0x017E) } // LATIN SMALL LETTER Z WITH CARON - , {0x9F, utf8_(0x0178) } // LATIN CAPITAL LETTER Y WITH DIAERESIS -}; -static std::map Windows1252_to_u8string() +static const auto& Windows1252_x80_x9F_to_u8string() +{ + static const std::map retval { + {0x80, utf8_(0x20AC) } // EURO SIGN + // , {0x81, replacement_character } // UNDEFINED + , {0x82, utf8_(0x201A) } // SINGLE LOW-9 QUOTATION MARK + , {0x83, utf8_(0x0192) } // LATIN SMALL LETTER F WITH HOOK + , {0x84, utf8_(0x201E) } // DOUBLE LOW-9 QUOTATION MARK + , {0x85, utf8_(0x2026) } // HORIZONTAL ELLIPSIS + , {0x86, utf8_(0x2020) } // DAGGER + , {0x87, utf8_(0x2021) } // DOUBLE DAGGER + , {0x88, utf8_(0x02C6) } // MODIFIER LETTER CIRCUMFLEX ACCENT + , {0x89, utf8_(0x2030) } // PER MILLE SIGN + , {0x8A, utf8_(0x0160) } // LATIN CAPITAL LETTER S WITH CARON + , {0x8B, utf8_(0x2039) } // SINGLE LEFT-POINTING ANGLE QUOTATION MARK + , {0x8C, utf8_(0x0152) } // LATIN CAPITAL LIGATURE OE + //, {0x8D, replacement_character } // UNDEFINED + , {0x8E, utf8_(0x017D) } // LATIN CAPITAL LETTER Z WITH CARON + //, {0x8F, replacement_character } // UNDEFINED + //, {0x90, replacement_character } // UNDEFINED + , {0x91, utf8_(0x2018) } // LEFT SINGLE QUOTATION MARK + , {0x92, utf8_(0x2019) } // RIGHT SINGLE QUOTATION MARK + , {0x93, utf8_(0x201C) } // LEFT DOUBLE QUOTATION MARK + , {0x94, utf8_(0x201D) } // RIGHT DOUBLE QUOTATION MARK + , {0x95, utf8_(0x2022) } // BULLET + , {0x96, utf8_(0x2013) } // EN DASH + , {0x97, utf8_(0x2014) } // EM DASH + , {0x98, utf8_(0x02DC) } // SMALL TILDE + , {0x99, utf8_(0x2122) } // TRADE MARK SIGN + , {0x9A, utf8_(0x0161) } // LATIN SMALL LETTER S WITH CARON + , {0x9B, utf8_(0x203A) } // SINGLE RIGHT-POINTING ANGLE QUOTATION MARK + , {0x9C, utf8_(0x0153) } // LATIN SMALL LIGATURE OE + //, {0x9D, replacement_character } // UNDEFINED + , {0x9E, utf8_(0x017E) } // LATIN SMALL LETTER Z WITH CARON + , {0x9F, utf8_(0x0178) } // LATIN CAPITAL LETTER Y WITH DIAERESIS + }; + return retval; +} + +static auto Windows1252_to_u8string() { - auto retval = Windows1252_x80_x9F_to_u8string; + auto retval = Windows1252_x80_x9F_to_u8string(); // Add the ISO8859-1 values to the map too. 1) We're already looking // in the map anyway for Windows-1252 characters. 2) Need map diff --git a/modules/c++/str/source/Format.cpp b/modules/c++/str/source/Format.cpp index 2d2447088..b89c974e8 100644 --- a/modules/c++/str/source/Format.cpp +++ b/modules/c++/str/source/Format.cpp @@ -22,8 +22,11 @@ #include "str/Format.h" + #include +#include +#include static std::string vformat(const char* format, va_list& args) { @@ -36,12 +39,24 @@ static std::string vformat(const char* format, va_list& args) return std::string(buffer); } +inline void va_end_(va_list& args) +{ + CODA_OSS_disable_warning_push + #if _MSC_VER + #pragma warning(disable : 26477) // Use '...' rather than 0 or NULL(es .47). + #endif + + va_end(args); + + CODA_OSS_disable_warning_pop +} + std::string str::format(const char *format, ...) { va_list args; va_start(args, format); auto retval = vformat(format, args); - va_end(args); + va_end_(args); return retval; } @@ -50,6 +65,6 @@ str::Format::Format(const char* format, ...) va_list args; va_start(args, format); auto result = vformat(format, args); - va_end(args); + va_end_(args); mString = std::move(result); } diff --git a/modules/c++/str/source/Manip.cpp b/modules/c++/str/source/Manip.cpp index 444c89732..f8dbce7db 100644 --- a/modules/c++/str/source/Manip.cpp +++ b/modules/c++/str/source/Manip.cpp @@ -30,6 +30,10 @@ #include #include #include +#include +#include + +#include "gsl/gsl.h" #include "str/Convert.h" #include "str/Encoding.h" @@ -79,7 +83,7 @@ inline void trim_(std::basic_string & s) } s.erase(0, i); - for (i = s.length() - 1; (int) i >= 0; i--) + for (i = s.length() - 1; static_cast(i) >= 0; i--) { if (!iswspace(static_cast(s[i]))) break; @@ -249,10 +253,16 @@ bool containsOnly(const std::string& s, const std::string& validChars) typedef std::string::const_iterator StringIter; std::vector chars(255, false); for (StringIter it = validChars.begin(); it != validChars.end(); ++it) - chars[(unsigned int)*it] = true; + { + const auto i = gsl::narrow(*it); + chars[i] = true; + } for (StringIter it = s.begin(); it != s.end(); ++it) - if (!chars[(unsigned int)*it]) + { + const auto i = gsl::narrow(*it); + if (!chars[i]) return false; + } return true; } @@ -306,4 +316,54 @@ void escapeForXML(std::string& str) replaceAll(str, "\n", " "); replaceAll(str, "\r", " "); } + +// https://en.cppreference.com/w/cpp/string/char_traits +class ci_char_traits final : public std::char_traits +{ + // Use our own routine rather than strcasecmp() so that the same + // toupperCheck() is used as when calling upper(). + static auto to_upper(char ch) noexcept + { + return toupperCheck(ch); + } + + static int compare(const char* s1, const char* s2, std::size_t n) noexcept + { + while (n-- != 0) + { + if (to_upper(*s1) < to_upper(*s2)) + return -1; + if (to_upper(*s1) > to_upper(*s2)) + return 1; + ++s1; + ++s2; + } + return 0; + } + + public: + static int compare(const std::string& s1, const std::string& s2) noexcept + { + if (s1.length() < s2.length()) + { + return -1; + } + if (s1.length() > s2.length()) + { + return 1; + } + assert(s1.length() == s2.length()); + return compare(s1.c_str(), s2.c_str(), s1.length()); + } +}; + +bool eq(const std::string& lhs, const std::string& rhs) noexcept +{ + return ci_char_traits::compare(lhs, rhs) == 0; +} +bool ne(const std::string& lhs, const std::string& rhs) noexcept +{ + return ci_char_traits::compare(lhs, rhs) != 0; +} + } diff --git a/modules/c++/str/unittests/test_base_convert.cpp b/modules/c++/str/unittests/test_base_convert.cpp index 358fa6827..71ee45016 100644 --- a/modules/c++/str/unittests/test_base_convert.cpp +++ b/modules/c++/str/unittests/test_base_convert.cpp @@ -34,6 +34,7 @@ #include #include #include +#include #include "TestCase.h" @@ -44,14 +45,14 @@ inline static void test_assert_eq(const std::string& testName, const std::u8stri TEST_CASE(testConvert) { - TEST_ASSERT_EQ(str::toType("0x3BC7", 16), (long long) 0x3BC7); - TEST_ASSERT_EQ(str::toType("1101", 2), (long long) 13); - TEST_ASSERT_EQ(str::toType("231", 5), (long long) 66); + TEST_ASSERT_EQ(str::toType("0x3BC7", 16), gsl::narrow(0x3BC7)); + TEST_ASSERT_EQ(str::toType("1101", 2), gsl::narrow(13)); + TEST_ASSERT_EQ(str::toType("231", 5), gsl::narrow(66)); TEST_ASSERT_EQ(str::toType("0xFFFFFFFFFFFFFFFF", 16), - (unsigned long long) 0xFFFFFFFFFFFFFFFF); + gsl::narrow(0xFFFFFFFFFFFFFFFF)); TEST_ASSERT_EQ(str::toType("-10", 10), - (unsigned long long) -10); - TEST_ASSERT_EQ(str::toType("13", 4), (short) 7); + gsl::narrow_cast(-10)); + TEST_ASSERT_EQ(str::toType("13", 4), gsl::narrow(7)); } TEST_CASE(testBadConvert) diff --git a/modules/c++/str/unittests/test_str.cpp b/modules/c++/str/unittests/test_str.cpp index d41a64880..a3381632d 100644 --- a/modules/c++/str/unittests/test_str.cpp +++ b/modules/c++/str/unittests/test_str.cpp @@ -22,8 +22,10 @@ #include // std::ignore +#include #include #include + #include "TestCase.h" inline std::string to_string(const std::string& value) @@ -71,6 +73,26 @@ TEST_CASE(testLower) TEST_ASSERT_EQ(s, "test1"); } +TEST_CASE(test_eq_ne) +{ + const auto s1 = "TEST1"; + const auto s2 = "test1"; + const auto s3 = "T2"; + + TEST_ASSERT_TRUE(str::eq(s1, s1)); + TEST_ASSERT_FALSE(str::ne(s1, s1)); + + TEST_ASSERT_TRUE(str::eq(s1, s2)); + TEST_ASSERT_FALSE(str::ne(s1, s2)); + TEST_ASSERT_TRUE(str::eq(s2, s1)); + TEST_ASSERT_FALSE(str::ne(s2, s1)); + + TEST_ASSERT_FALSE(str::eq(s1, s3)); + TEST_ASSERT_TRUE(str::ne(s1, s3)); + TEST_ASSERT_FALSE(str::eq(s3, s1)); + TEST_ASSERT_TRUE(str::ne(s3, s1)); +} + TEST_CASE(testReplace) { std::string s = "helo world"; @@ -177,9 +199,9 @@ TEST_CASE(testRoundDouble) nv *= denom; TEST_ASSERT_ALMOST_EQ_EPS(nv, numerator, eps); std::cout << nv << std::endl; - std::cout << (nv - (int)nv) << std::endl; + std::cout << (nv - static_cast(nv)) << std::endl; std::cout << std::numeric_limits::epsilon() << std::endl; - TEST_ASSERT_EQ((int)std::ceil(nv), (int)numerator); + TEST_ASSERT_EQ(static_cast(std::ceil(nv)), static_cast(numerator)); } TEST_CASE(testEscapeForXMLNoReplace) @@ -205,11 +227,94 @@ TEST_CASE(testEscapeForXMLKitchenSink) TEST_ASSERT_EQ(message, expectedMessage); } +TEST_CASE(test_toStringComplexFloat) +{ + const std::string expected("(1,-2)"); + + const std::complex std_cx_float(1.0f, -2.0f); + auto actual = str::toString(std_cx_float); + TEST_ASSERT_EQ(actual, expected); + + const types::ComplexReal types_cx_float(1.0f, -2.0f); + actual = str::toString(types_cx_float); + TEST_ASSERT_EQ(actual, expected); + + const types::zfloat zfloat(1.0f, -2.0f); + actual = str::toString(zfloat); + TEST_ASSERT_EQ(actual, expected); +} +TEST_CASE(test_toTypeComplexFloat) +{ + const std::string strValue("(1,-2)"); + + auto actual = str::toType>(strValue); + auto strActual = str::toString(actual); + TEST_ASSERT_EQ(strActual, strValue); + + actual = str::toType>(strValue); + strActual = str::toString(actual); + TEST_ASSERT_EQ(strActual, strValue); + + actual = str::toType(strValue); + strActual = str::toString(actual); + TEST_ASSERT_EQ(strActual, strValue); +} + +TEST_CASE(test_toStringComplexShort) +{ + const std::string expected("(1,-2)"); + + CODA_OSS_disable_warning_push + #if _MSC_VER + #pragma warning(disable: 4996) // '...': warning STL4037: The effect of instantiating the template std::complex for any type other than float, double, or long double is unspecified. You can define _SILENCE_NONFLOATING_COMPLEX_DEPRECATION_WARNING to suppress this warning + #endif + const std::complex std_cx_short(1, -2); + CODA_OSS_disable_warning_pop + auto actual = str::toString(std_cx_short); + TEST_ASSERT_EQ(actual, expected); + + const types::ComplexInteger types_cx_short(std_cx_short); // "copy constructor" or overload + actual = str::toString(types_cx_short); + TEST_ASSERT_EQ(actual, expected); + + const types::zint16_t zint16(1, -2); + actual = str::toString(zint16); + TEST_ASSERT_EQ(actual, expected); +} +TEST_CASE(test_toTypeComplexShort) +{ + const std::string strValue("(1,-2)"); + + CODA_OSS_disable_warning_push + #if _MSC_VER + #pragma warning(disable: 4996) // '...': warning STL4037: The effect of instantiating the template std::complex for any type other than float, double, or long double is unspecified. You can define _SILENCE_NONFLOATING_COMPLEX_DEPRECATION_WARNING to suppress this warning + #endif + const auto cx_actual = str::toType>(strValue); + CODA_OSS_disable_warning_pop + auto strActual = str::toString(cx_actual); + TEST_ASSERT_EQ(strActual, strValue); + + CODA_OSS_disable_warning_push + #if _MSC_VER + #pragma warning(disable: 4996) // '...': warning STL4037: The effect of instantiating the template std::complex for any type other than float, double, or long double is unspecified. You can define _SILENCE_NONFLOATING_COMPLEX_DEPRECATION_WARNING to suppress this warning + #endif + auto zactual = str::toType>(strValue); + CODA_OSS_disable_warning_pop + strActual = str::toString(zactual); + TEST_ASSERT_EQ(strActual, strValue); + + zactual = str::toType(strValue); + strActual = str::toString(zactual); + TEST_ASSERT_EQ(strActual, strValue); +} + + TEST_MAIN( TEST_CHECK(testTrim); TEST_CHECK(testData); TEST_CHECK(testUpper); TEST_CHECK(testLower); + TEST_CHECK(test_eq_ne); TEST_CHECK(testReplace); TEST_CHECK(testReplaceAllInfinite); TEST_CHECK(testReplaceAllRecurse); @@ -226,4 +331,8 @@ TEST_MAIN( TEST_CHECK(testRoundDouble); TEST_CHECK(testEscapeForXMLNoReplace); TEST_CHECK(testEscapeForXMLKitchenSink); - ) \ No newline at end of file + TEST_CHECK(test_toStringComplexFloat); + TEST_CHECK(test_toTypeComplexFloat); + TEST_CHECK(test_toStringComplexShort); + TEST_CHECK(test_toTypeComplexShort); + ) diff --git a/modules/c++/str/wscript b/modules/c++/str/wscript index 8cefbb5f7..d50988cfd 100644 --- a/modules/c++/str/wscript +++ b/modules/c++/str/wscript @@ -1,6 +1,6 @@ NAME = 'str' VERSION = '1.0' -MODULE_DEPS = 'except coda_oss' +MODULE_DEPS = 'types except coda_oss' UNITTEST_DEPS = 'sys std' options = configure = distclean = lambda p: None diff --git a/modules/c++/sys/include/sys/AbstractOS.h b/modules/c++/sys/include/sys/AbstractOS.h index 158bce489..1b040790e 100644 --- a/modules/c++/sys/include/sys/AbstractOS.h +++ b/modules/c++/sys/include/sys/AbstractOS.h @@ -46,6 +46,23 @@ */ namespace sys { + +/*! + * \class SIMDInstructionSet + * \brief List of available SIMD instruction sets. + * + * We require at least SSE2 which is from 2000 ... 23 years ago. + * Also see https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html + * "... For the x86-64 compiler, these extensions [ -msse2 ] are enabled by default." +* We're 64-bit only. + */ +enum class SIMDInstructionSet +{ + SSE2, // https://en.wikipedia.org/wiki/SSE2 + AVX2, // https://en.wikipedia.org/wiki/Advanced_Vector_Extensions + AVX512F, // https://en.wikipedia.org/wiki/AVX-512 +}; + /*! * \class AbstractOS * \brief Interface for system independent function calls @@ -99,6 +116,11 @@ struct CODA_OSS_API AbstractOS const std::string& fragment = "", const std::string& extension = "", bool recursive = true) const; + std::vector search( + const std::vector& searchPaths, + const std::string& fragment = "", + const std::string& extension = "", + bool recursive = true) const; /*! * Does this path exist? @@ -278,6 +300,13 @@ struct CODA_OSS_API AbstractOS virtual void getAvailableCPUs(std::vector& physicalCPUs, std::vector& htCPUs) const = 0; + + /*! + * Figure out what SIMD instrunctions are available. Keep in mind these + * are RUN-TIME, not compile-time, checks. + */ + virtual SIMDInstructionSet getSIMDInstructionSet() const = 0; + /*! * Create a symlink, pathnames can be either absolute or relative */ @@ -323,10 +352,8 @@ struct CODA_OSS_API AbstractOS class AbstractDirectory { public: - AbstractDirectory() - { - } - virtual ~AbstractDirectory() + AbstractDirectory() = default; + virtual ~AbstractDirectory() noexcept(false) { } virtual void close() = 0; diff --git a/modules/c++/sys/include/sys/AtomicCounterCpp11.h b/modules/c++/sys/include/sys/AtomicCounterCpp11.h index 79979f283..ce785869f 100644 --- a/modules/c++/sys/include/sys/AtomicCounterCpp11.h +++ b/modules/c++/sys/include/sys/AtomicCounterCpp11.h @@ -39,24 +39,24 @@ struct AtomicCounterImplCpp11 final { using ValueType = size_t ; - explicit AtomicCounterImplCpp11(ValueType initialValue) : + explicit AtomicCounterImplCpp11(ValueType initialValue) noexcept : mValue(initialValue) { } - ValueType getThenIncrement() + ValueType getThenIncrement() noexcept { // https://en.cppreference.com/w/cpp/atomic/atomic/fetch_add return mValue.fetch_add(1); } - ValueType getThenDecrement() + ValueType getThenDecrement() noexcept { // https://en.cppreference.com/w/cpp/atomic/atomic/fetch_sub return mValue.fetch_sub(1); } - ValueType get() const + ValueType get() const noexcept { // https://en.cppreference.com/w/cpp/atomic/atomic/load return mValue.load(); diff --git a/modules/c++/sys/include/sys/ByteSwap.h b/modules/c++/sys/include/sys/ByteSwap.h new file mode 100644 index 000000000..6b135288d --- /dev/null +++ b/modules/c++/sys/include/sys/ByteSwap.h @@ -0,0 +1,298 @@ +/* ========================================================================= + * This file is part of sys-c++ + * ========================================================================= + * + * (C) Copyright 2004 - 2014, MDA Information Systems LLC + * (C) Copyright 2023, Maxar Technologies, Inc. + * + * sys-c++ is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this program; If not, + * see . + * + */ + +#pragma once +#ifndef CODA_OSS_sys_ByteSwap_h_INCLUDED_ +#define CODA_OSS_sys_ByteSwap_h_INCLUDED_ + +#include +#include + +#include +#include +#include +#include +#include + +#include "config/Exports.h" + +#include "ByteSwapValue.h" +#include "Runnable.h" +#include "SysInt.h" + +namespace sys +{ +/*! + * Swap bytes in-place. Note that a complex pixel + * is equivalent to two floats so elemSize and numElems + * must be adjusted accordingly. + * + * \param [inout] buffer to transform + * \param elemSize + * \param numElems + */ +coda_oss::span CODA_OSS_API byteSwap(coda_oss::spanbuffer, size_t elemSize); +void CODA_OSS_API byteSwap(void* buffer, size_t elemSize, size_t numElems); + +// If the caller has given us bytes, assume she knows what she's doing; i.e., don't check sizeof(T) +template +inline void byteSwap_(TByte* buffer, size_t elemSize, size_t numElems) +{ + void* const buffer_ = buffer; + byteSwap(buffer_, elemSize, numElems); +} +inline void byteSwap(coda_oss::byte* buffer, size_t elemSize, size_t numElems) +{ + return byteSwap_(buffer, elemSize, numElems); +} +inline void byteSwap(byte* buffer, size_t elemSize, size_t numElems) +{ + return byteSwap_(buffer, elemSize, numElems); +} +inline void byteSwap(ubyte* buffer, size_t elemSize, size_t numElems) +{ + return byteSwap_(buffer, elemSize, numElems); +} + +namespace details +{ +template +inline void check_elemSize(size_t elemSize) +{ + static_assert(is_byte_swappable(), "T should not be a 'struct'"); + if (sizeof(T) != elemSize) + { + throw std::invalid_argument("'elemSize' != sizeof(T)"); + } +} + +// Repackage into a span; the size is 2* because for byte-swapping +// we want to look at this as an array of `T`, not `std::complex`. +template +inline auto make_span(coda_oss::span> s) +{ + const void* const p_ = s.data(); + auto const p = static_cast(p_); + const auto sz = s.size() * 2; // real and imag + return sys::make_span(p, sz); +} +template +inline auto make_span(coda_oss::span> s) +{ + void* const p_ = s.data(); + auto const p = static_cast(p_); + const auto sz = s.size() * 2; // real and imag + return sys::make_span(p, sz); +} + +} + +// Otherwise, we can sanity-check the `elemSize` parameter +template +inline void byteSwap(T* buffer, size_t elemSize, size_t numElems) +{ + details::check_elemSize(elemSize); + void* const buffer_ = buffer; + byteSwap(buffer_, elemSize, numElems); +} +template +inline void byteSwap(std::complex* buffer, size_t elemSize, size_t numElems) // dont't want `T` as `std::complex<...>` +{ + details::check_elemSize(elemSize); + void* const buffer_ = buffer; + byteSwap(buffer_, elemSize, numElems); +} + +template +inline auto byteSwap(coda_oss::span buffer) +{ + static_assert(!std::is_const::value, "T cannot be 'const'"); + static_assert(details::is_byte_swappable(), "T should not be a 'struct'"); + return byteSwap(as_writable_bytes(buffer), sizeof(T)); +} + +// Take care of treating std::complex as T[] +template +inline auto byteSwap(coda_oss::span> buffer) +{ + return byteSwap(details::make_span(buffer)); +} + +/*! + * Swap bytes into output buffer. Note that a complex pixel + * is equivalent to two floats so elemSize and numElems + * must be adjusted accordingly. + * + * \param buffer to transform + * \param elemSize + * \param numElems + * \param[out] outputBuffer buffer to write swapped elements to + */ +coda_oss::span CODA_OSS_API byteSwap(coda_oss::span buffer, + size_t elemSize, coda_oss::span outputBuffer); +void CODA_OSS_API byteSwap(const void* buffer, size_t elemSize, size_t numElems, void* outputBuffer); + +// If the caller has given us bytes, assume she knows what she's doing; i.e., don't check sizeof(T) +template +inline void byteSwap_(const TByte* buffer, size_t elemSize, size_t numElems, U* outputBuffer) +{ + const void* const buffer_ = buffer; + void* const outputBuffer_ = outputBuffer; + byteSwap(buffer_, elemSize, numElems, outputBuffer_); +} +template +inline void byteSwap(const coda_oss::byte* buffer, size_t elemSize, size_t numElems, U* outputBuffer) +{ + byteSwap_(buffer, elemSize, numElems, outputBuffer); +} +template +inline void byteSwap(const byte* buffer, size_t elemSize, size_t numElems, U* outputBuffer) +{ + byteSwap_(buffer, elemSize, numElems, outputBuffer); +} +template +inline void byteSwap(const ubyte* buffer, size_t elemSize, size_t numElems, U* outputBuffer) +{ + byteSwap_(buffer, elemSize, numElems, outputBuffer); +} + +// Otherwise, we can sanity-check the `elemSize` parameter +template +inline void byteSwap(const T* buffer, size_t elemSize, size_t numElems, U* outputBuffer) +{ + details::check_elemSize(elemSize); + const void* const buffer_ = buffer; + void* const outputBuffer_ = outputBuffer; + byteSwap(buffer_, elemSize, numElems, outputBuffer_); +} +template +inline void byteSwap(const std::complex* buffer, size_t elemSize, size_t numElems, U* outputBuffer) // dont't want `T` as `std::complex<...>` +{ + details::check_elemSize(elemSize); + const void* const buffer_ = buffer; + void* const outputBuffer_ = outputBuffer; + byteSwap(buffer_, elemSize, numElems, outputBuffer_); +} + +template +inline auto byteSwap(coda_oss::span buffer, coda_oss::span outputBuffer) +{ + static_assert(details::is_byte_swappable(), "T should not be a 'struct'"); + return byteSwap(as_bytes(buffer), sizeof(T), outputBuffer); +} +// Take care of treating std::complex as T[] +template +inline auto byteSwap(coda_oss::span> buffer, coda_oss::span outputBuffer) +{ + return byteSwap(details::make_span(buffer), outputBuffer); +} + +template +inline auto byteSwap(coda_oss::span buffer) +{ + std::vector retval(buffer.size_bytes()); + std::ignore = byteSwap(buffer, make_span(retval)); + return retval; +} +// Take care of treating std::complex as T[] +template +inline auto byteSwap(coda_oss::span> buffer) +{ + return byteSwap(details::make_span(buffer)); +} + +// With buffer byte-swap now in place, we can safely byte-swap std::complex. +// This signature is from ByteSwapValue.h +template +inline auto byteSwapValue(std::complex z) +{ + // C++ mandates that `std::complex` be the same as `T cx[2]`; that is + // the structure is contiguous. https://en.cppreference.com/w/cpp/numeric/complex + const auto& z_ = reinterpret_cast(z); + return byteSwap(make_span(z_)); +} +template +inline auto byteSwap(std::complex val) +{ + const auto bytes = byteSwapValue(val); + assert(bytes.size() == sizeof(val)); + + const void* const pBytes = bytes.data(); + auto const pRetVal = static_cast*>(pBytes); + return *pRetVal; +} + +//////////////////////////////////////////////////////////////////////////////////////////////////////////////////////// + +struct ByteSwapRunnable final : public sys::Runnable +{ + ByteSwapRunnable(void* buffer, size_t elemSize, size_t startElement, size_t numElements) noexcept : + mBuffer(static_cast(buffer) + startElement * elemSize), + mElemSize(elemSize), mNumElements(numElements) + { + } + void run() override + { + byteSwap(mBuffer, mElemSize, mNumElements); + } + + virtual ~ByteSwapRunnable() = default; + ByteSwapRunnable(const ByteSwapRunnable&) = delete; + ByteSwapRunnable& operator=(const ByteSwapRunnable&) = delete; + ByteSwapRunnable(ByteSwapRunnable&&) = delete; + ByteSwapRunnable& operator=(ByteSwapRunnable&&) = delete; + +private: + void* const mBuffer; + const size_t mElemSize; + const size_t mNumElements; +}; + +struct ByteSwapCopyRunnable final : public sys::Runnable +{ + ByteSwapCopyRunnable(const void* buffer, size_t elemSize, size_t startElement, size_t numElements, void* outputBuffer) noexcept : + mBuffer(static_cast(buffer) + startElement * elemSize), + mElemSize(elemSize), mNumElements(numElements), + mOutputBuffer(static_cast(outputBuffer) + startElement * elemSize) + { + } + void run() override + { + byteSwap(mBuffer, mElemSize, mNumElements, mOutputBuffer); + } + + virtual ~ByteSwapCopyRunnable() = default; + ByteSwapCopyRunnable(const ByteSwapCopyRunnable&) = delete; + ByteSwapCopyRunnable& operator=(const ByteSwapCopyRunnable&) = delete; + ByteSwapCopyRunnable(ByteSwapCopyRunnable&&) = delete; + ByteSwapCopyRunnable& operator=(ByteSwapCopyRunnable&&) = delete; + +private: + const void* const mBuffer; + const size_t mElemSize; + const size_t mNumElements; + void* const mOutputBuffer; +}; + +} +#endif // CODA_OSS_sys_ByteSwap_h_INCLUDED_ diff --git a/modules/c++/sys/include/sys/ByteSwapValue.h b/modules/c++/sys/include/sys/ByteSwapValue.h new file mode 100644 index 000000000..4bc9132a3 --- /dev/null +++ b/modules/c++/sys/include/sys/ByteSwapValue.h @@ -0,0 +1,200 @@ +/* ========================================================================= + * This file is part of sys-c++ + * ========================================================================= + * + * (C) Copyright 2004 - 2014, MDA Information Systems LLC + * (C) Copyright 2021, Maxar Technologies, Inc. + * + * sys-c++ is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this program; If not, + * see . + * + */ + +#pragma once +#ifndef CODA_OSS_sys_ByteSwapValue_h_INCLUDED_ +#define CODA_OSS_sys_ByteSwapValue_h_INCLUDED_ + +#include +#include +#include + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "config/Exports.h" + +#include "Span.h" + +namespace sys +{ + /*! + * Swap bytes for a single value into output buffer. API is `span` rather than `void*` since + * for a single value we know the size. These "low level" routines may be less efficient than + * the templates since it's not possible to specialize on a specific size. + * + * \param buffer to transform + * \param[out] outputBuffer buffer to write swapped elements to + */ + coda_oss::span CODA_OSS_API byteSwap( + coda_oss::span pIn, coda_oss::span outPtr); + + namespace details + { + // "cast" a single value to bytes + template + inline auto as_bytes(const T& v) noexcept + { + return sys::as_bytes(&v, 1); + } + template + inline auto as_writable_bytes(T& v) noexcept + { + return sys::as_writable_bytes(&v, 1); + } + + template + inline auto swapUIntBytes(coda_oss::span inBytes, coda_oss::span outBytes, + std::nothrow_t) noexcept + { + static_assert(std::is_unsigned::value, "TUInt must be 'unsigned'"); + assert(sizeof(TUInt) == inBytes.size()); + assert(inBytes.size() == outBytes.size()); + + const void* const pIn_ = inBytes.data(); + auto const pIn = static_cast(pIn_); + void* const pOut_ = outBytes.data(); + auto const pOut = static_cast(pOut_); + + *pOut = coda_oss::byteswap(*pIn); // at long last, swap the bytes + + // Give the raw byte-swapped bytes back to the caller for easy serialization + return as_bytes(*pOut); + } + template + inline auto swapUIntBytes(coda_oss::span inBytes, coda_oss::span outBytes) + { + if (sizeof(TUInt) != inBytes.size()) + { + throw std::invalid_argument("'inBytes.size() != sizeof(TUInt)"); + } + if (inBytes.size() != outBytes.size()) + { + throw std::invalid_argument("'inBytes.size() != outBytes.size()"); + } + return swapUIntBytes(inBytes, outBytes, std::nothrow); + } + + // This is a template so that we can have specializations for different sizes. + // By specializing on `size_t`, a `float` can be "cast" to `uint32_t` (via + // `std::byte`) for byte-swapping. + template + inline auto swapBytes(coda_oss::span inBytes, coda_oss::span outBytes) + { + if (elemSize != inBytes.size()) + { + throw std::invalid_argument("'inBytes.size() != elemSize"); + } + return sys::byteSwap(inBytes, outBytes); // size that wasn't specialized + } + + // avoid copy-paste errors + #define CODA_OSS_define_swapBytes_specialization_(T) template <> inline auto swapBytes \ + (coda_oss::span inBytes, coda_oss::span outBytes) { return swapUIntBytes(inBytes, outBytes); } + CODA_OSS_define_swapBytes_specialization_(uint8_t) // no `;`, it's not needed and generates a -Wpedantic warning + CODA_OSS_define_swapBytes_specialization_(uint16_t) + CODA_OSS_define_swapBytes_specialization_(uint32_t) + CODA_OSS_define_swapBytes_specialization_(uint64_t) + #undef CODA_OSS_define_swapBytes_specialization_ + + template + inline constexpr bool is_byte_swappable() noexcept + { + // Trying to byte-swap anything other than integers is likely to cause + // problems (or at least confusion): + // * `struct`s have padding that should be ignored. + // * each individual member of a `struct` should be byte-swaped + // * byte-swaped `float` or `double` bits are nonsense + return (std::is_integral::value || std::is_enum::value) || !std::is_compound::value; + } + } + + /*! + * Function to swap one element irrespective of size. + * Returns the raw byte-swapped bytes for easy serialization. + */ + template + inline auto byteSwapValue(coda_oss::span inBytes, coda_oss::span outBytes) + { + static_assert(details::is_byte_swappable(), "T should not be a 'struct'"); + return details::swapBytes(inBytes, outBytes); + } + template + inline auto byteSwapValue(T in, coda_oss::span outBytes) + { + return byteSwapValue(details::as_bytes(in), outBytes); + } + template + inline auto byteSwapValue(T in) + { + std::vector retval(sizeof(T)); + std::ignore = byteSwapValue(in, make_span(retval)); + return retval; + } + + // Reverse the above: turn `span` back to T after byte-swapping + template + inline auto byteSwapValue(coda_oss::span in) + { + // Don't want to cast the swapped bytes in `in` to T* as they might not be valid; + // e.g., a byte-swapped `float` could be garbage. + T retval; + byteSwapValue(in, details::as_writable_bytes(retval)); + return retval; + } + + /*! + * Function to swap one element irrespective of size. The inplace + * buffer function should be preferred. + * + * To specialize complex float, first include the complex library + * \code + #include + * \endcode + * + * Then put an overload in as specified below: + * \code + template std::complex byteSwap(std::complex val) + { + std::complex out(byteSwap(val.real()), + byteSwap(val.imag())); + return out; + } + * \endcode + * + */ + template inline T byteSwap(T val) + { + T out; + std::ignore = byteSwapValue(val, details::as_writable_bytes(out)); + return out; + } +} +#endif // CODA_OSS_sys_ByteSwapValue_h_INCLUDED_ diff --git a/modules/c++/sys/include/sys/ConditionVarInterface.h b/modules/c++/sys/include/sys/ConditionVarInterface.h index 96172c8bc..8d6f762f5 100644 --- a/modules/c++/sys/include/sys/ConditionVarInterface.h +++ b/modules/c++/sys/include/sys/ConditionVarInterface.h @@ -68,8 +68,8 @@ struct CODA_OSS_API ConditionVarInterface * a lock, but this class will STILL delete it. * */ - explicit ConditionVarInterface(Mutex *, bool = false) {} - explicit ConditionVarInterface(Mutex&) { } + explicit ConditionVarInterface(Mutex *, bool = false) noexcept {} + explicit ConditionVarInterface(Mutex&) noexcept { } virtual ~ConditionVarInterface() = default; diff --git a/modules/c++/sys/include/sys/Conf.h b/modules/c++/sys/include/sys/Conf.h index ad5a1e4c9..45cf7da29 100644 --- a/modules/c++/sys/include/sys/Conf.h +++ b/modules/c++/sys/include/sys/Conf.h @@ -21,9 +21,9 @@ * */ +#pragma once #ifndef CODA_OSS_sys_Conf_h_INCLUDED_ #define CODA_OSS_sys_Conf_h_INCLUDED_ -#pragma once // In case there is still a WIN32 (should be "_WIN32" with a leading '_') someplace. #if defined(_WIN32) && !defined(WIN32) @@ -75,7 +75,8 @@ #include "str/Format.h" #include "sys/TimeStamp.h" - +#include "sys/ByteSwap.h" +#include "sys/SysInt.h" /* Dance around the compiler to figure out */ /* if we have access to function macro... */ @@ -104,22 +105,6 @@ # define NativeLayer_func__ "" #endif - -namespace sys -{ - typedef char byte; - typedef unsigned char ubyte; - typedef uint8_t Uint8_T; - typedef uint16_t Uint16_T; - typedef uint32_t Uint32_T; - typedef uint64_t Uint64_T; - typedef size_t Size_T; - typedef int8_t Int8_T; - typedef int16_t Int16_T; - typedef int32_t Int32_T; - typedef int64_t Int64_T; -} - #ifdef _WIN32 # include # include @@ -197,113 +182,7 @@ namespace sys * RISC architectures we are big-endian. */ bool CODA_OSS_API isBigEndianSystem(); - - - /*! - * Swap bytes in-place. Note that a complex pixel - * is equivalent to two floats so elemSize and numElems - * must be adjusted accordingly. - * - * \param [inout] buffer to transform - * \param elemSize - * \param numElems - */ - inline void byteSwap(void* buffer, - unsigned short elemSize, - size_t numElems) - { - sys::byte* bufferPtr = static_cast(buffer); - if (!bufferPtr || elemSize < 2 || !numElems) - return; - - const auto half = elemSize >> 1; - size_t offset = 0, innerOff = 0, innerSwap = 0; - - for(size_t i = 0; i < numElems; ++i, offset += elemSize) - { - for(unsigned short j = 0; j < half; ++j) - { - innerOff = offset + j; - innerSwap = offset + elemSize - 1 - j; - - std::swap(bufferPtr[innerOff], bufferPtr[innerSwap]); - } - } - } - - /*! - * Swap bytes into output buffer. Note that a complex pixel - * is equivalent to two floats so elemSize and numElems - * must be adjusted accordingly. - * - * \param buffer to transform - * \param elemSize - * \param numElems - * \param[out] outputBuffer buffer to write swapped elements to - */ - inline void byteSwap(const void* buffer, - unsigned short elemSize, - size_t numElems, - void* outputBuffer) - { - const sys::byte* bufferPtr = static_cast(buffer); - sys::byte* outputBufferPtr = static_cast(outputBuffer); - - if (!numElems || !bufferPtr || !outputBufferPtr) - { - return; - } - - const auto half = elemSize >> 1; - size_t offset = 0; - - for (size_t ii = 0; ii < numElems; ++ii, offset += elemSize) - { - for (unsigned short jj = 0; jj < half; ++jj) - { - const size_t innerOff = offset + jj; - const size_t innerSwap = offset + elemSize - 1 - jj; - - outputBufferPtr[innerOff] = bufferPtr[innerSwap]; - outputBufferPtr[innerSwap] = bufferPtr[innerOff]; - } - } - } - - /*! - * Function to swap one element irrespective of size. The inplace - * buffer function should be preferred. - * - * To specialize complex float, first include the complex library - * \code - #include - * \endcode - * - * Then put an overload in as specified below: - * \code - template std::complex byteSwap(std::complex val) - { - std::complex out(byteSwap(val.real()), - byteSwap(val.imag())); - return out; - } - * \endcode - * - */ - template T byteSwap(T val) - { - size_t size = sizeof(T); - T out; - - unsigned char* cOut = reinterpret_cast(&out); - unsigned char* cIn = reinterpret_cast(&val); - for (size_t i = 0, j = size - 1; i < j; ++i, --j) - { - cOut[i] = cIn[j]; - cOut[j] = cIn[i]; - } - return out; - } + bool CODA_OSS_API isLittleEndianSystem(); /*! @@ -352,7 +231,7 @@ namespace sys * * \param p A pointer to the data allocated using alignedAlloc */ - inline void alignedFree(void* p) + inline void alignedFree(void* p) noexcept { #ifdef _WIN32 _aligned_free(p); @@ -361,7 +240,6 @@ namespace sys #endif } - } // https://en.wikipedia.org/wiki/Year_2038_problem diff --git a/modules/c++/sys/include/sys/DateTime.h b/modules/c++/sys/include/sys/DateTime.h index 5ca7db445..d238eda6d 100644 --- a/modules/c++/sys/include/sys/DateTime.h +++ b/modules/c++/sys/include/sys/DateTime.h @@ -155,32 +155,32 @@ class CODA_OSS_API DateTime * @return true if comparison holds, false otherwise. */ //@{ - bool operator<(const DateTime& rhs) const + bool operator<(const DateTime& rhs) const noexcept { return (mTimeInMillis < rhs.mTimeInMillis); } - bool operator<=(const DateTime& rhs) const + bool operator<=(const DateTime& rhs) const noexcept { return (mTimeInMillis <= rhs.mTimeInMillis); } - bool operator>(const DateTime& rhs) const + bool operator>(const DateTime& rhs) const noexcept { return (mTimeInMillis > rhs.mTimeInMillis); } - bool operator>=(const DateTime& rhs) const + bool operator>=(const DateTime& rhs) const noexcept { return (mTimeInMillis >= rhs.mTimeInMillis); } - bool operator==(const DateTime& rhs) const + bool operator==(const DateTime& rhs) const noexcept { return (mTimeInMillis == rhs.mTimeInMillis); } - bool operator!=(const DateTime& rhs) const + bool operator!=(const DateTime& rhs) const noexcept { return !operator==(rhs); } diff --git a/modules/c++/sys/include/sys/Dbg.h b/modules/c++/sys/include/sys/Dbg.h index 96bfb098f..5c896f354 100644 --- a/modules/c++/sys/include/sys/Dbg.h +++ b/modules/c++/sys/include/sys/Dbg.h @@ -21,14 +21,13 @@ * */ - +#pragma once #ifndef CODA_OSS_sys_Dbg_h_INCLUDED_ #define CODA_OSS_sys_Dbg_h_INCLUDED_ -#pragma once - -#include "config/Exports.h" -#include "config/disable_compiler_warnings.h" +// +// The macros below may #define NDEBUG, do them before #including +// // A "debug" build has debugging symbols, detailed call stacks, minimal optimization, STL validation, etc. // A "release" build is likely to "run fast" and be "shipped;" it might lack much of what is in a "debug" build. #ifndef CODA_OSS_DEBUG @@ -44,8 +43,8 @@ #endif #endif // _MSC_VER - // GCC has a "neither" mode with no flags; no -O (optimization) and no -g (debugging); - // that doesn't seem very useful, so try to figure out something that makes sense. + // GCC has a "neither" mode with no flags: no `-O` (optimization) and no `-g` (debugging). + // That doesn't seem very useful, so try to figure out something that makes sense. #if defined(__GNUC__) // https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html#Common-Predefined-Macros // https://gcc.gnu.org/onlinedocs/libstdc++/manual/debug_mode_using.html#debug_mode.using.mode @@ -71,7 +70,7 @@ #ifndef NDEBUG //#error "NDEBUG should be #define'd with __OPTIMIZE__" #endif - #define CODA_OSS_DEBUG 0 + #define CODA_OSS_DEBUG 0 // i.e., release #else #error "Can't #define CODA_OSS_DEBUG for __GNUC__." #endif @@ -92,12 +91,25 @@ #error CODA_OSS_DEBUG is not set. #endif +// #define NDEBUG if not already done +#if CODA_OSS_DEBUG && defined(NDEBUG) + #error "NDEBUG and CODA_OSS_DEBUG=1" +#endif +#if !defined(NDEBUG) && !CODA_OSS_DEBUG + #define NDEBUG +#endif + +#include // *after* NDEBUG, above #include #include -#include + +#include #include #include +#include "config/Exports.h" +#include "config/disable_compiler_warnings.h" + namespace sys { @@ -184,14 +196,14 @@ namespace sys * \param format * \param ... Put in any format value here */ -CODA_OSS_API void dbgPrintf(const char *format, ...); +CODA_OSS_API void dbgPrintf(const char *format, ...) noexcept; /*! * Prints to DEBUG_STREAM and kills the program * \param format * \param ... Put in any format value here */ -void diePrintf(const char *format, ...); +void diePrintf(const char* format, ...) noexcept; } #define dbg_printf sys::dbgPrintf diff --git a/modules/c++/sys/include/sys/Err.h b/modules/c++/sys/include/sys/Err.h index c7163f35b..4c3b37c50 100644 --- a/modules/c++/sys/include/sys/Err.h +++ b/modules/c++/sys/include/sys/Err.h @@ -62,7 +62,7 @@ struct CODA_OSS_API Err * Copy constructor * \param err The err to take */ - Err(const Err& err) + Err(const Err& err) noexcept { mErrId = err.getErrID(); } @@ -82,7 +82,7 @@ struct CODA_OSS_API Err * Assignment operator * \param err The err to take */ - Err& operator=(const Err& err) + Err& operator=(const Err& err) noexcept { if (&err != this) { @@ -115,7 +115,7 @@ struct CODA_OSS_API Err //! Return the last error virtual int getLast() const; - int getErrID() const { return mErrId; } + int getErrID() const noexcept { return mErrId; } protected: @@ -158,7 +158,7 @@ struct SocketErr : public Err * \param err The err to take * */ - SocketErr& operator=(const SocketErr& err) + SocketErr& operator=(const SocketErr& err) noexcept { if (&err != this) { diff --git a/modules/c++/sys/include/sys/FileFinder.h b/modules/c++/sys/include/sys/FileFinder.h index be9ae0bcf..0485de3c8 100644 --- a/modules/c++/sys/include/sys/FileFinder.h +++ b/modules/c++/sys/include/sys/FileFinder.h @@ -28,6 +28,7 @@ #include #include +#include "config/Exports.h" #include "sys/filesystem.h" namespace sys @@ -191,9 +192,10 @@ namespace test // i.e., sys::test // e.g., root / "externals" / [name] / path / file // // Once modulePath is found, the result is cached to avoid searching again. - coda_oss::filesystem::path findModuleFile(const coda_oss::filesystem::path& root, + coda_oss::filesystem::path findModuleFile( + const coda_oss::filesystem::path& root, const std::string& externalsName, const coda_oss::filesystem::path& modulePath, const coda_oss::filesystem::path& moduleFile); - coda_oss::filesystem::path findGITModuleFile( // use current_directory() to find_dotGITDirectory() + CODA_OSS_API coda_oss::filesystem::path findGITModuleFile( // use current_directory() to find_dotGITDirectory() const std::string& externalsName, const coda_oss::filesystem::path& modulePath, const coda_oss::filesystem::path& moduleFile); } } diff --git a/modules/c++/sys/include/sys/LocalDateTime.h b/modules/c++/sys/include/sys/LocalDateTime.h index 5effbcaa6..a264d9273 100644 --- a/modules/c++/sys/include/sys/LocalDateTime.h +++ b/modules/c++/sys/include/sys/LocalDateTime.h @@ -78,7 +78,7 @@ class CODA_OSS_API LocalDateTime : public DateTime LocalDateTime(const std::string& time, const std::string& format); //! Return the Daylight Savings Time flag (true = on, false = off) - bool getDST() const { return mDST == 1; } + bool getDST() const noexcept { return mDST == 1; } //! Set the Daylight Savings Time flag (true = on, false = off) void setDST(bool isDST); diff --git a/modules/c++/sys/include/sys/MutexCpp11.h b/modules/c++/sys/include/sys/MutexCpp11.h index b95738d34..e10ff5420 100644 --- a/modules/c++/sys/include/sys/MutexCpp11.h +++ b/modules/c++/sys/include/sys/MutexCpp11.h @@ -66,7 +66,7 @@ struct MutexCpp11 final : public MutexInterface * Return the type name. This function is essentially free, * because it is static RTTI. */ - const char* getNativeType() const + const char* getNativeType() const noexcept { return typeid(mNative).name(); } diff --git a/modules/c++/sys/include/sys/MutexWin32.h b/modules/c++/sys/include/sys/MutexWin32.h index adc3ac2d3..aa6b4906a 100644 --- a/modules/c++/sys/include/sys/MutexWin32.h +++ b/modules/c++/sys/include/sys/MutexWin32.h @@ -64,7 +64,7 @@ class CODA_OSS_API MutexWin32 : public MutexInterface * Return the type name. This function is essentially free, * because it is static RTTI. */ - const char* getNativeType() const + const char* getNativeType() const noexcept { return typeid(mNative).name(); } diff --git a/modules/c++/sys/include/sys/OS.h b/modules/c++/sys/include/sys/OS.h index 6ea40c83f..7a16c53e5 100644 --- a/modules/c++/sys/include/sys/OS.h +++ b/modules/c++/sys/include/sys/OS.h @@ -21,10 +21,12 @@ */ -#ifndef __SYS_OS_H__ -#define __SYS_OS_H__ +#pragma once +#ifndef CODA_OSS_sys_OS_h_INCLUDED_ +#define CODA_OSS_sys_OS_h_INCLUDED_ #include "sys/AbstractOS.h" +#include "sys/Conf.h" #ifdef _WIN32 # include "sys/OSWin32.h" @@ -47,19 +49,34 @@ typedef DirectoryUnix Directory; // and also squelches compiler-warnings about unused local functions. namespace sys { - enum class PlatformType - { - Windows, - Linux, - //MacOS - }; +enum class PlatformType +{ + Windows, + Linux, + // MacOS +}; - #ifdef _WIN32 - constexpr auto Platform = PlatformType::Windows; - #else - constexpr auto Platform = PlatformType::Linux; - #endif +#if defined(_WIN32) +constexpr auto Platform = PlatformType::Windows; +#elif defined(CODA_OSS_POSIX2008_SOURCE) +constexpr auto Platform = PlatformType::Linux; +#else +#error "Unknown platform." +#endif + +template +inline std::string platformName(); +template <> +inline std::string platformName() +{ + return "Windows"; +} +template <> +inline std::string platformName() +{ + return "linux-gnu"; } -#endif +} +#endif // CODA_OSS_sys_OS_h_INCLUDED_ \ No newline at end of file diff --git a/modules/c++/sys/include/sys/OSUnix.h b/modules/c++/sys/include/sys/OSUnix.h index eb1a52dd3..f92e596ee 100644 --- a/modules/c++/sys/include/sys/OSUnix.h +++ b/modules/c++/sys/include/sys/OSUnix.h @@ -201,6 +201,12 @@ struct OSUnix final : public AbstractOS virtual void getAvailableCPUs(std::vector& physicalCPUs, std::vector& htCPUs) const override; + /*! + * Figure out what SIMD instrunctions are available. Keep in mind these + * are RUN-TIME, not compile-time, checks. + */ + SIMDInstructionSet getSIMDInstructionSet() const override; + /*! * Create a symlink, pathnames can be either absolute or relative */ diff --git a/modules/c++/sys/include/sys/OSWin32.h b/modules/c++/sys/include/sys/OSWin32.h index 3b7dcd3ce..c39d3b846 100644 --- a/modules/c++/sys/include/sys/OSWin32.h +++ b/modules/c++/sys/include/sys/OSWin32.h @@ -59,7 +59,7 @@ struct CODA_OSS_API OSWin32 final : public AbstractOS * For unix it will be one slash / * \return The path delimiter */ - virtual const char* getDelimiter() const + const char* getDelimiter() const noexcept override { return "\\"; } @@ -226,6 +226,12 @@ struct CODA_OSS_API OSWin32 final : public AbstractOS virtual void getAvailableCPUs(std::vector& physicalCPUs, std::vector& htCPUs) const; + /*! + * Figure out what SIMD instrunctions are available. Keep in mind these + * are RUN-TIME, not compile-time, checks. + */ + SIMDInstructionSet getSIMDInstructionSet() const override; + /*! * Create a symlink, pathnames can be either absolute or relative */ @@ -264,7 +270,7 @@ struct CODA_OSS_API OSWin32 final : public AbstractOS struct DirectoryWin32 final : public AbstractDirectory { DirectoryWin32() = default; - virtual ~DirectoryWin32() + virtual ~DirectoryWin32() noexcept(false) { close(); } diff --git a/modules/c++/sys/include/sys/ReadWriteMutex.h b/modules/c++/sys/include/sys/ReadWriteMutex.h index e3141a7dd..1200514cb 100644 --- a/modules/c++/sys/include/sys/ReadWriteMutex.h +++ b/modules/c++/sys/include/sys/ReadWriteMutex.h @@ -51,7 +51,7 @@ struct ReadWriteMutex } //! Destructor - virtual ~ReadWriteMutex() + virtual ~ReadWriteMutex() { dbg_printf("Destroying a read/write mutex\n"); } diff --git a/modules/c++/sys/include/sys/Span.h b/modules/c++/sys/include/sys/Span.h new file mode 100644 index 000000000..bf24e81c7 --- /dev/null +++ b/modules/c++/sys/include/sys/Span.h @@ -0,0 +1,194 @@ +/* ========================================================================= + * This file is part of sys-c++ + * ========================================================================= + * + * (C) Copyright 2004 - 2014, MDA Information Systems LLC + * (C) Copyright 2023, Maxar Technologies, Inc. + * + * sys-c++ is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this program; If not, + * see . + * + */ + +#pragma once +#ifndef CODA_OSS_sys_Span_h_INCLUDED_ +#define CODA_OSS_sys_Span_h_INCLUDED_ + +#include +#include +#include +#include +#include + +namespace sys // not "mem", it depends on sys. +{ + +// Creating a `span` is verbose w/o deduction guidelines in C++17. +// Some overloads to ease the pain. +template +inline coda_oss::span make_span(const T* ptr, size_t sz) noexcept +{ + return coda_oss::span(ptr, sz); +} +template +inline coda_oss::span make_const_span(T* ptr, size_t sz) noexcept +{ + return coda_oss::span(ptr, sz); +} +template +inline coda_oss::span make_writable_span(T* ptr, size_t sz) noexcept // c.f., as_writable_bytes() +{ + return coda_oss::span(ptr, sz); +} +template +inline coda_oss::span make_span(T* ptr, size_t sz) noexcept +{ + return make_writable_span(ptr, sz); +} + +template +inline auto make_span(const void* ptr, size_t sz) noexcept +{ + return make_span(static_cast(ptr), sz); +} +template +inline auto make_const_span(void* ptr, size_t sz) noexcept +{ + return make_const_span(static_cast(ptr), sz); +} +template +inline auto make_span(void* ptr, size_t sz) noexcept +{ + return make_writable_span(static_cast(ptr), sz); +} + +template +inline auto make_const_span(coda_oss::span v) noexcept // turn span into span +{ + return make_const_span(v.data(), v.size()); +} + +template +inline auto make_span(const std::vector& v) noexcept +{ + return make_span(v.data(), v.size()); +} +template +inline auto make_const_span(std::vector& v) noexcept +{ + return make_const_span(v.data(), v.size()); +} +template +inline auto make_span(std::vector& v) noexcept +{ + return make_writable_span(v.data(), v.size()); +} + +template +inline auto make_span(const std::array& v) noexcept +{ + return make_span(v.data(), v.size()); +} +template +inline auto make_const_span(std::array& v) noexcept +{ + return make_const_span(v.data(), v.size()); +} +template +inline auto make_span(std::array& v) noexcept +{ + return make_writable_span(v.data(), v.size()); +} + +template +inline auto make_span(const T (&a)[N]) noexcept +{ + return make_span(a, N); +} +template +inline auto make_const_span(T (&a)[N]) noexcept +{ + return make_const_span(a, N); +} +template +inline auto make_span(T (&a)[N]) noexcept +{ + return make_writable_span(a, N); +} + +// Calling as_bytes() or as_writable_bytes() requires a span, which as +// noted above is a nuisance to create w/o C++17 +template +inline auto as_bytes(coda_oss::span s) noexcept +{ + return coda_oss::as_bytes(s); +} +template +inline auto as_bytes(coda_oss::span s) noexcept +{ + return coda_oss::as_bytes(s); +} +template +inline auto as_writable_bytes(coda_oss::span s) noexcept +{ + return coda_oss::as_writable_bytes(s); +} + +template +inline auto as_bytes(const T* ptr, size_t sz) noexcept +{ + return coda_oss::as_bytes(make_span(ptr, sz)); +} +template +inline auto as_writable_bytes(T* ptr, size_t sz) noexcept +{ + static_assert(!std::is_const::value, "T cannot be 'const'"); + return coda_oss::as_writable_bytes(make_writable_span(ptr, sz)); +} + +template +inline auto as_bytes(const std::vector& v) noexcept +{ + return as_bytes(v.data(), v.size()); +} +template +inline auto as_writable_bytes(std::vector& v) noexcept +{ + return as_writable_bytes(v.data(), v.size()); +} + +template +inline auto as_bytes(const std::array& v) noexcept +{ + return as_bytes(v.data(), v.size()); +} +template +inline auto as_writable_bytes(std::array& v) noexcept +{ + return as_writable_bytes(v.data(), v.size()); +} + +template +inline auto as_bytes(const T (&a)[N]) noexcept +{ + return as_bytes(a, N); +} +template +inline auto as_writable_bytes(T (&a)[N]) noexcept +{ + return as_writable_bytes(a, N); +} + +} +#endif // CODA_OSS_sys_Span_h_INCLUDED_ diff --git a/modules/c++/sys/include/sys/String.h b/modules/c++/sys/include/sys/SysInt.h similarity index 59% rename from modules/c++/sys/include/sys/String.h rename to modules/c++/sys/include/sys/SysInt.h index 5adc016f1..a25f76d1f 100644 --- a/modules/c++/sys/include/sys/String.h +++ b/modules/c++/sys/include/sys/SysInt.h @@ -3,6 +3,7 @@ * ========================================================================= * * (C) Copyright 2004 - 2014, MDA Information Systems LLC + * (C) Copyright 2023, Maxar Technologies, Inc. * * sys-c++ is free software; you can redistribute it and/or modify * it under the terms of the GNU Lesser General Public License as published by @@ -20,10 +21,25 @@ * */ -#ifndef CODA_OSS_sys_String_h_INCLUDED_ -#define CODA_OSS_sys_String_h_INCLUDED_ #pragma once +#ifndef CODA_OSS_sys_SysInt_h_INCLUDED_ +#define CODA_OSS_sys_SysInt_h_INCLUDED_ -#include "str/String_.h" +#include -#endif // CODA_OSS_sys_String_h_INCLUDED_ +namespace sys +{ + typedef char byte; + typedef unsigned char ubyte; + typedef uint8_t Uint8_T; + typedef uint16_t Uint16_T; + typedef uint32_t Uint32_T; + typedef uint64_t Uint64_T; + typedef size_t Size_T; + typedef int8_t Int8_T; + typedef int16_t Int16_T; + typedef int32_t Int32_T; + typedef int64_t Int64_T; +} + +#endif // CODA_OSS_sys_SysInt_h_INCLUDED_ diff --git a/modules/c++/sys/include/sys/ThreadInterface.h b/modules/c++/sys/include/sys/ThreadInterface.h index 576f64347..e536fe48e 100644 --- a/modules/c++/sys/include/sys/ThreadInterface.h +++ b/modules/c++/sys/include/sys/ThreadInterface.h @@ -47,7 +47,7 @@ namespace sys * { * // declare this function. * STANDARD_START_CALL(Win32Thread, v); - * return NULL; + * return nullptr; * } * \endcode */ diff --git a/modules/c++/sys/include/sys/ThreadPosix.h b/modules/c++/sys/include/sys/ThreadPosix.h index 5e5efe8c2..26a17b175 100644 --- a/modules/c++/sys/include/sys/ThreadPosix.h +++ b/modules/c++/sys/include/sys/ThreadPosix.h @@ -49,7 +49,7 @@ namespace sys */ inline long getThreadID() { - return (long)pthread_self(); + return static_cast(pthread_self()); } /*! diff --git a/modules/c++/sys/include/sys/TimeStamp.h b/modules/c++/sys/include/sys/TimeStamp.h index 8d8c72281..a04207938 100644 --- a/modules/c++/sys/include/sys/TimeStamp.h +++ b/modules/c++/sys/include/sys/TimeStamp.h @@ -54,7 +54,7 @@ struct TimeStamp final * \param is24HourTime Optional specifier for military time */ TimeStamp() = default; - TimeStamp(bool is24HourTime) : m24HourTime(is24HourTime) + TimeStamp(bool is24HourTime) noexcept : m24HourTime(is24HourTime) { } ~TimeStamp() = default; @@ -84,7 +84,7 @@ struct TimeStamp final * Sets up string in desired format * \return The string format for printing */ - const char* getFormat() const + const char* getFormat() const noexcept { if (m24HourTime) { diff --git a/modules/c++/sys/source/AbstractOS.cpp b/modules/c++/sys/source/AbstractOS.cpp index 549415680..d1cd33306 100644 --- a/modules/c++/sys/source/AbstractOS.cpp +++ b/modules/c++/sys/source/AbstractOS.cpp @@ -28,7 +28,10 @@ #include #include #include +#include +#include +#include #include #include #include @@ -83,6 +86,31 @@ AbstractOS::search(const std::vector& searchPaths, return elementsFound; } +inline auto convert(const std::vector& paths) +{ + std::vector retval; + std::transform(paths.begin(), paths.end(), std::back_inserter(retval), + [](const fs::path& p) { return p.string(); }); + return retval; +} +inline auto convert(const std::vector& paths) +{ + std::vector retval; + std::transform(paths.begin(), paths.end(), std::back_inserter(retval), + [](const auto& p) { return p; }); + return retval; +} + +std::vector AbstractOS::search( + const std::vector& searchPaths, + const std::string& fragment, + const std::string& extension, + bool recursive) const +{ + const auto results = search(convert(searchPaths), fragment, extension, recursive); + return convert(results); +} + void AbstractOS::remove(const std::string& path) const { if (isDirectory(path)) @@ -333,6 +361,34 @@ static std::string getSpecialEnv_Platform(const AbstractOS&, const std::string& #endif } +// https://stackoverflow.com/questions/13794130/visual-studio-how-to-check-used-c-platform-toolset-programmatically +static std::string getSpecialEnv_PlatformToolset(const AbstractOS&, const std::string& envVar) +{ + assert(envVar == "PlatformToolset"); + #if _MSC_VER + UNREFERENCED_PARAMETER(envVar); + #endif + +#ifdef _WIN32 + // https://docs.microsoft.com/en-us/cpp/build/how-to-modify-the-target-framework-and-platform-toolset?view=msvc-160 + // https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170 + #if _MSC_VER >= 1930 + return "v143"; // Visual Studio 2022 + #elif _MSC_VER >= 1920 + return "v142"; // Visual Studio 2019 + #elif _MSC_VER >= 1910 + return "v141"; // Visual Studio 2017 + #elif _MSC_VER >= 1900 + return "v140"; // Visual Studio 2015 + #else + #error "Don't know $(PlatformToolset) value.'" + #endif +#else + // Linux + return ""; +#endif +} + static std::string getSpecialEnv_SECONDS_() { // https://en.cppreference.com/w/cpp/chrono/c/difftime @@ -350,7 +406,13 @@ static std::string getSpecialEnv_SECONDS(const AbstractOS&, const std::string& e #endif return getSpecialEnv_SECONDS_(); } + +CODA_OSS_disable_warning_push +#if _MSC_VER +#pragma warning(disable: 26426) // Global initializer calls a non-constexpr function '...' (i.22). +#endif static std::string strUnusedSeconds = getSpecialEnv_SECONDS_(); // "start" the "shell" +CODA_OSS_disable_warning_pop // See https://www.gnu.org/software/bash/manual/html_node/Bash-Variables.html // and https://wiki.bash-hackers.org/syntax/shellvars @@ -372,6 +434,7 @@ static const std::map s_get_env{ // c.f., Visual Studio {"Configuration", getSpecialEnv_Configuration}, {"Platform", getSpecialEnv_Platform}, + {"PlatformToolset", getSpecialEnv_PlatformToolset}, }; bool AbstractOS::isSpecialEnv(const std::string& envVar) const { @@ -417,14 +480,7 @@ std::string AbstractOS::getSpecialEnv(const std::string& envVar) const if (envVar == "OSTYPE") { - // TODO: Mac - return sys::Platform == sys::PlatformType::Linux ? " linux-gnu" : "Windows"; - } - - if (envVar == "OSTYPE") - { - // TODO: Mac - return sys::Platform == sys::PlatformType::Linux ? " linux-gnu" : "Windows"; + return sys::platformName(); } // should explicitly handle all env. vars in some way diff --git a/modules/c++/sys/source/ConditionVarPosix.cpp b/modules/c++/sys/source/ConditionVarPosix.cpp index 267a33927..d1e288629 100644 --- a/modules/c++/sys/source/ConditionVarPosix.cpp +++ b/modules/c++/sys/source/ConditionVarPosix.cpp @@ -22,6 +22,8 @@ #include +#include "gsl/gsl.h" + #if CODA_OSS_POSIX_SOURCE #include @@ -30,7 +32,7 @@ sys::ConditionVarPosix::ConditionVarPosix() : mMutexOwned(std::make_unique()), mMutex(mMutexOwned.get()) { - if ( ::pthread_cond_init(&mNative, NULL) != 0) + if ( ::pthread_cond_init(&mNative, nullptr) != 0) throw SystemException("ConditionVar initialization failed"); } @@ -39,7 +41,7 @@ sys::ConditionVarPosix::ConditionVarPosix(MutexPosix* theLock, bool isOwner, std if (isOwner) mMutexOwned.reset(theLock); - if (::pthread_cond_init(&mNative, NULL) != 0) + if (::pthread_cond_init(&mNative, nullptr) != 0) throw SystemException("ConditionVar initialization failed"); } sys::ConditionVarPosix::ConditionVarPosix(sys::MutexPosix* theLock, bool isOwner) : ConditionVarPosix(theLock, isOwner, nullptr) @@ -85,8 +87,8 @@ void sys::ConditionVarPosix::wait(double seconds) if ( seconds > 0 ) { timespec tout; - tout.tv_sec = time(NULL) + (int)seconds; - tout.tv_nsec = (int)((seconds - (int)(seconds)) * 1e9); + tout.tv_sec = time(nullptr) + gsl::narrow_cast(seconds); + tout.tv_nsec = gsl::narrow_cast((seconds - gsl::narrow_cast(seconds)) * 1e9); if (::pthread_cond_timedwait(&mNative, &(mMutex->getNative()), &tout) != 0) diff --git a/modules/c++/sys/source/ConditionVarWin32.cpp b/modules/c++/sys/source/ConditionVarWin32.cpp index 45ffac49a..eb719a428 100644 --- a/modules/c++/sys/source/ConditionVarWin32.cpp +++ b/modules/c++/sys/source/ConditionVarWin32.cpp @@ -41,6 +41,11 @@ namespace LeaveCriticalSection(&mCriticalSection); } + ScopedCriticalSection(const ScopedCriticalSection&) = delete; + ScopedCriticalSection& operator=(const ScopedCriticalSection&) = delete; + ScopedCriticalSection(ScopedCriticalSection&&) = delete; + ScopedCriticalSection& operator=(ScopedCriticalSection&&) = delete; + private: CRITICAL_SECTION& mCriticalSection; }; @@ -48,12 +53,12 @@ namespace sys::ConditionVarDataWin32::ConditionVarDataWin32(): mNumWaiters(0), - mSemaphore(CreateSemaphore(NULL, 0, 0x7FFFFFFF, NULL)), - mWaitersAreDone(CreateEvent(NULL, FALSE, FALSE, NULL)), + mSemaphore(CreateSemaphore(nullptr, 0, 0x7FFFFFFF, nullptr)), + mWaitersAreDone(CreateEvent(nullptr, FALSE, FALSE, nullptr)), mWasBroadcast(false) { InitializeCriticalSection(&mNumWaitersCS); - if (mSemaphore == NULL || mWaitersAreDone == NULL) + if (mSemaphore == nullptr || mWaitersAreDone == nullptr) { throw sys::SystemException( "ConditionVarDataWin32 Initializer failed"); @@ -163,7 +168,7 @@ void sys::ConditionVarDataWin32::signal() // If there are waiters, increment the semaphore by 1 to wake one up if (haveWaiters) { - ReleaseSemaphore(mSemaphore, 1, NULL); + ReleaseSemaphore(mSemaphore, 1, nullptr); } } @@ -179,7 +184,7 @@ void sys::ConditionVarDataWin32::broadcast() { mWasBroadcast = true; haveWaiters = true; - ReleaseSemaphore(mSemaphore, static_cast(mNumWaiters), 0); + ReleaseSemaphore(mSemaphore, static_cast(mNumWaiters), nullptr); } else { diff --git a/modules/c++/sys/source/Conf.cpp b/modules/c++/sys/source/Conf.cpp index c8560c7f3..1358a1e81 100644 --- a/modules/c++/sys/source/Conf.cpp +++ b/modules/c++/sys/source/Conf.cpp @@ -19,48 +19,332 @@ * see . * */ +#include "sys/Conf.h" + +#include #include #include - -#include "sys/Conf.h" +#include +#include #include "coda_oss/bit.h" +#include "coda_oss/cstddef.h" +#include "coda_oss/span.h" -using endian = coda_oss::endian; +#include "sys/Span.h" // https://en.cppreference.com/w/cpp/types/endian -inline bool is_big_endian() +using endian = coda_oss::endian; +template +inline bool is_big_endian_() +{ + throw std::logic_error("Mixed-endian not supported."); +} +template<> +inline constexpr bool is_big_endian_() +{ + return true; +} +template <> +inline constexpr bool is_big_endian_() +{ + return false; +} +constexpr inline bool is_big_endian() +{ + return is_big_endian_(); +} + +// Want to explicitly test against both endian::bit and endian::little; i.e., +// because of "mixed" endianness, little may not the same as !big +template +inline bool is_little_endian_() { - auto endianness = endian::native; // "conditional expression is constant" - if (endianness == endian::big) - { - return true; - } - if (endianness == endian::little) - { - return false; - } throw std::logic_error("Mixed-endian not supported."); } +template <> +inline constexpr bool is_little_endian_() +{ + return false; +} +template <> +inline constexpr bool is_little_endian_() +{ + return true; +} +constexpr inline bool is_little_endian() +{ + return is_little_endian_(); +} + constexpr inline bool is_big_or_little_endian() { - return (endian::native == endian::big) || (endian::native == endian::little) ? true : false; + return is_big_endian() || is_little_endian(); } -inline bool isBigEndianSystem() +inline bool testIsBigEndianSystem() { // This is an endian test - int intVal = 1; - unsigned char* endianTest = (unsigned char*)&intVal; + static const int intVal = 1; + const void* const pIntVal = &intVal; + const auto endianTest = static_cast(pIntVal); return endianTest[0] != 1; } -bool sys::isBigEndianSystem() +inline auto isBigEndianSystem_() { static_assert(is_big_or_little_endian(), "Mixed-endian not supported."); - const auto retval = ::isBigEndianSystem(); + const auto retval = testIsBigEndianSystem(); if (retval != is_big_endian()) { throw std::logic_error("endian values don't agree!"); } return retval; } +inline auto isLittleEndianSystem_() +{ + static_assert(is_big_or_little_endian(), "Mixed-endian not supported."); + const auto retval = !testIsBigEndianSystem(); + if (retval != is_little_endian()) + { + throw std::logic_error("endian values don't agree!"); + } + return retval; +} +bool sys::isBigEndianSystem() +{ + auto const retval = isBigEndianSystem_(); + assert(!retval == isLittleEndianSystem_()); + return retval; +} +bool sys::isLittleEndianSystem() +{ + auto const retval = isLittleEndianSystem_(); + assert(!retval == isBigEndianSystem_()); + return retval; +} + + /*! + * Swap bytes in-place. Note that a complex pixel + * is equivalent to two floats so elemSize and numElems + * must be adjusted accordingly. + * + * \param [inout] buffer to transform + * \param elemSize + * \param numElems + */ +template +inline auto byteSwap(coda_oss::span buffer) +{ + static_assert(std::is_unsigned::value, "TUInt must be 'unsigned'"); + for (auto& v : buffer) + { + v = sys::byteSwap(v); + } + return sys::as_bytes(buffer); +} +template +inline auto byteSwap_n_(coda_oss::span buffer_) +{ + const auto buffer = sys::make_span(buffer_.data(), buffer_.size_bytes() / sizeof(TUInt)); + assert(buffer.size_bytes() == buffer_.size_bytes()); + return byteSwap(buffer); +} +template +inline auto byteSwap_n(coda_oss::span buffer, size_t elemSize) +{ + if (sizeof(TUInt) != elemSize) + { + throw std::invalid_argument("'elemSize' != sizeof(TUInt)"); + } + return byteSwap_n_(buffer); +} +static coda_oss::span byteSwap(coda_oss::span buffer, size_t elemSize, size_t numElems) +{ + switch (elemSize) + { + case sizeof(uint16_t): return byteSwap_n(buffer, elemSize); + case sizeof(uint32_t): return byteSwap_n(buffer, elemSize); + case sizeof(uint64_t): return byteSwap_n(buffer, elemSize); + default: break; + } + + auto const bufferPtr = buffer.data(); + const auto half = elemSize >> 1; + size_t offset = 0, innerOff = 0, innerSwap = 0; + for (size_t i = 0; i < numElems; ++i, offset += elemSize) + { + for (size_t j = 0; j < half; ++j) + { + innerOff = offset + j; + innerSwap = offset + elemSize - 1 - j; + + std::swap(bufferPtr[innerOff], bufferPtr[innerSwap]); + } + } + + return sys::make_const_span(buffer); +} +void sys::byteSwap(void* buffer_, size_t elemSize, size_t numElems) +{ + if ((buffer_ == nullptr) || (elemSize < 2) || (numElems == 0)) + return; + + auto const pBytes = static_cast(buffer_); + const coda_oss::span buffer(pBytes, elemSize * numElems); + std::ignore = ::byteSwap(buffer, elemSize, numElems); +} +coda_oss::span sys::byteSwap(coda_oss::span buffer, size_t elemSize) +{ + if ((buffer.empty()) || (elemSize < 2)) + return sys::make_const_span(buffer); + + size_t const numElems = buffer.size() / elemSize; + if ((numElems * elemSize) != buffer.size()) + { + throw std::invalid_argument("'buffer' is not a multiple of 'elemSize'"); + } + + return ::byteSwap(buffer, elemSize, numElems); +} + + /*! + * Swap bytes into output buffer. Note that a complex pixel + * is equivalent to two floats so elemSize and numElems + * must be adjusted accordingly. + * + * \param buffer to transform + * \param elemSize + * \param numElems + * \param[out] outputBuffer buffer to write swapped elements to + */ +template +inline auto byteSwap_n_(coda_oss::span buffer, coda_oss::span outputBuffer_) +{ + static_assert(std::is_unsigned::value, "TUInt must be 'unsigned'"); + + assert(buffer.size_bytes() == outputBuffer_.size()); + void* pOutputBuffer = outputBuffer_.data(); + const auto outputBuffer = sys::make_span(pOutputBuffer, buffer.size()); + assert(buffer.size_bytes() == outputBuffer.size_bytes()); + + const auto byteSwap = [](const auto& v) { return sys::byteSwap(v); }; + std::transform(buffer.begin(), buffer.end(), outputBuffer.begin(), byteSwap); + + return sys::as_bytes(outputBuffer); +} +template +inline auto byteSwap_n(coda_oss::span buffer_, size_t elemSize, coda_oss::span outputBuffer) +{ + if (sizeof(TUInt) != elemSize) + { + throw std::invalid_argument("'elemSize' != sizeof(TUInt)"); + } + + const auto buffer = sys::make_span(buffer_.data(), buffer_.size_bytes() / sizeof(TUInt)); + assert(buffer.size_bytes() == buffer_.size_bytes()); + return byteSwap_n_(buffer, outputBuffer); +} + +static auto byteSwap(coda_oss::span buffer, + size_t elemSize, size_t numElems, + coda_oss::span outputBuffer) +{ + auto const bufferPtr = buffer.data(); + auto const outputBufferPtr = outputBuffer.data(); + switch (elemSize) + { + case 1: + { + std::ignore = memcpy(outputBufferPtr, bufferPtr, elemSize * numElems); + return sys::make_const_span(outputBuffer); + } + case 2: return byteSwap_n(buffer, elemSize, outputBuffer); + case 4: return byteSwap_n(buffer, elemSize, outputBuffer); + case 8: return byteSwap_n(buffer, elemSize, outputBuffer); + default: break; + } + + const auto half = elemSize >> 1; + size_t offset = 0; + for (size_t ii = 0; ii < numElems; ++ii, offset += elemSize) + { + for (size_t jj = 0; jj < half; ++jj) + { + const size_t innerOff = offset + jj; + const size_t innerSwap = offset + elemSize - 1 - jj; + + outputBufferPtr[innerOff] = bufferPtr[innerSwap]; + outputBufferPtr[innerSwap] = bufferPtr[innerOff]; + } + } + + return sys::make_const_span(outputBuffer); +} + +void sys::byteSwap(const void* buffer_, size_t elemSize, size_t numElems, void* outputBuffer_) +{ + if ((numElems == 0) || (buffer_ == nullptr) || (outputBuffer_ == nullptr)) + { + return; + } + + auto const pBytes = static_cast(buffer_); + const coda_oss::span buffer(pBytes, elemSize * numElems); + + auto const pOutputBytes = static_cast(outputBuffer_); + const coda_oss::span outputBuffer(pOutputBytes, elemSize * numElems); + + std::ignore = ::byteSwap(buffer, elemSize, numElems, outputBuffer); +} +coda_oss::span sys::byteSwap(coda_oss::span buffer, + size_t elemSize, coda_oss::span outputBuffer) +{ + if ((buffer.empty()) || (outputBuffer.empty())) + { + return sys::make_const_span(outputBuffer); + } + + size_t const numElems = buffer.size() / elemSize; + if ((numElems * elemSize) != buffer.size()) + { + throw std::invalid_argument("'buffer' is not a multiple of 'elemSize'"); + } + if (buffer.size() != outputBuffer.size()) + { + const auto s = "'buffer' and 'outputBuffer' are different sizes: " + + std::to_string(buffer.size()) + " != " + std::to_string(outputBuffer.size()); + throw std::invalid_argument(s); + } + + return ::byteSwap(buffer, elemSize, numElems, outputBuffer); + } + +// byte-swap a single value +coda_oss::span sys::byteSwap( + coda_oss::span inPtr, + coda_oss::span outPtr) +{ + if (inPtr.size() != outPtr.size()) + { + throw std::invalid_argument("'size of byte buffers must match"); + } + + const auto elemSize = inPtr.size(); + switch (elemSize) + { + case sizeof(uint8_t): return details::swapUIntBytes(inPtr, outPtr, std::nothrow); + case sizeof(uint16_t): return details::swapUIntBytes(inPtr, outPtr, std::nothrow); + case sizeof(uint32_t): return details::swapUIntBytes(inPtr, outPtr, std::nothrow); + case sizeof(uint64_t): return details::swapUIntBytes(inPtr, outPtr, std::nothrow); + default: break; + } + + for (size_t ii = 0, jj = elemSize - 1; ii < jj; ++ii, --jj) + { + outPtr[ii] = inPtr[jj]; + outPtr[jj] = inPtr[ii]; + } + + // Give the raw byte-swapped bytes back to the caller for easy serialization + return make_const_span(outPtr); +} diff --git a/modules/c++/sys/source/CppUnitTestAssert_.cpp_ b/modules/c++/sys/source/CppUnitTestAssert_.cpp_ new file mode 100644 index 000000000..fdcf5f92b --- /dev/null +++ b/modules/c++/sys/source/CppUnitTestAssert_.cpp_ @@ -0,0 +1,43 @@ +#include "pch.h" +#include "TestCase.h" + +#include "str/EncodedStringView.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +// EQUALS_MESSAGE() wants ToString() specializations (or overloads) for our types, which is a nusiance. +// This hooks up our existing str::toString() into the VC++ unit-test infrastructure + +// C++ hack to call private methods +// https://stackoverflow.com/a/71578383/8877 + +using FailOnCondition_t = void(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare method's type +using GetAssertMessage_t = std::wstring(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare method's type +template +struct caller final // helper structure to inject call() code +{ + friend void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) + { + fFailOnCondition(condition, message, pLineInfo); + } + + friend std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message) + { + return fGetAssertMessage(equality, expected, actual, message); + } +}; +template struct caller<&Assert::FailOnCondition, &Assert::GetAssertMessage>; // even instantiation of the helper + +void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare caller +void test::Assert::FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) +{ + ::FailOnCondition(condition, message, pLineInfo); // and call! +} + +std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare caller +std::wstring test::Assert::GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message) +{ + const str::EncodedStringView vExpected(expected); + const str::EncodedStringView vActual(actual); + return ::GetAssertMessage(equality, vExpected.wstring(), vActual.wstring(), message); // and call! +} diff --git a/modules/c++/sys/source/DLLUnix.cpp b/modules/c++/sys/source/DLLUnix.cpp index a0bb26ecf..6ef817453 100644 --- a/modules/c++/sys/source/DLLUnix.cpp +++ b/modules/c++/sys/source/DLLUnix.cpp @@ -58,7 +58,7 @@ void sys::DLL::unload() throw sys::DLLException("Failed to close library"); // Now we reset member data - mLib = NULL; + mLib = nullptr; mLibName.clear(); } } @@ -66,13 +66,13 @@ DLL_FUNCTION_PTR sys::DLL::retrieve(const std::string& functionName) { // Check to make sure we have a library - if ( mLib != NULL ) + if ( mLib != nullptr ) { // Now we get a ptr DLL_FUNCTION_PTR ptr = dlsym( mLib , functionName.c_str()); // Now we check the ptr value - if (ptr == NULL) + if (ptr == nullptr) throw sys::DLLException("Failed to load function"); return ptr; diff --git a/modules/c++/sys/source/DLLWin32.cpp b/modules/c++/sys/source/DLLWin32.cpp index d3d6ff48b..466f7d295 100644 --- a/modules/c++/sys/source/DLLWin32.cpp +++ b/modules/c++/sys/source/DLLWin32.cpp @@ -58,7 +58,7 @@ void sys::DLL::unload() FreeLibrary( mLib ); // Now we reset member data - mLib = NULL; + mLib = nullptr; mLibName.clear(); } } @@ -67,14 +67,14 @@ DLL_FUNCTION_PTR sys::DLL:: retrieve(const std::string& functionName) { // Check to make sure we have a library - if ( mLib != NULL ) + if ( mLib != nullptr ) { // Now we get a ptr DLL_FUNCTION_PTR ptr = (DLL_FUNCTION_PTR) GetProcAddress(mLib, functionName.c_str()); // Now we check the ptr value - if (ptr == NULL) + if (ptr == nullptr) throw sys::DLLException(FmtX("Failed to load function: %s", functionName.c_str())); return ptr; diff --git a/modules/c++/sys/source/DateTime.cpp b/modules/c++/sys/source/DateTime.cpp index 9aaa96a7b..a79b9bb8c 100644 --- a/modules/c++/sys/source/DateTime.cpp +++ b/modules/c++/sys/source/DateTime.cpp @@ -349,7 +349,7 @@ char* strptime(const char *buf, const char *fmt, struct tm& tm, double& millis) } // LINTED functional specification - return ((char *) bp); + return const_cast(bp); } } @@ -371,14 +371,14 @@ void sys::DateTime::fromMillis(const tm& t) mHour = t.tm_hour; mMinute = t.tm_min; - const size_t timeInSeconds = (size_t)(mTimeInMillis / 1000); - const double timediff = ((double)mTimeInMillis / 1000.0) - timeInSeconds; + const auto timeInSeconds = gsl::narrow_cast(mTimeInMillis / 1000); + const auto timediff = (gsl::narrow_cast(mTimeInMillis) / 1000.0) - gsl::narrow_cast(timeInSeconds); mSecond = t.tm_sec + timediff; } double sys::DateTime::toMillis(tm t) const { - time_t timeInSeconds = mktime(&t); + const auto timeInSeconds = gsl::narrow_cast(mktime(&t)); double timediff = mSecond - t.tm_sec; return (timeInSeconds + timediff) * 1000.0; } @@ -394,7 +394,7 @@ static double getNowInMillis() return (now.tv_sec + 1.0e-9 * now.tv_nsec) * 1000; #elif CODA_OSS_POSIX_SOURCE struct timeval now; - gettimeofday(&now,NULL); + gettimeofday(&now,nullptr); return (now.tv_sec + 1.0e-6 * now.tv_usec) * 1000; #elif _WIN32 // Getting time twice may be inefficient but is quicker @@ -404,9 +404,9 @@ static double getNowInMillis() // does not need millisecond accuracy SYSTEMTIME now; GetLocalTime(&now); - return (double)time(NULL) * 1000 + now.wMilliseconds; + return (double)time(nullptr) * 1000 + now.wMilliseconds; #else - return (double)time(NULL) * 1000; + return (double)time(nullptr) * 1000; #endif } void sys::DateTime::setNow() @@ -634,7 +634,7 @@ void sys::DateTime::localtime(time_t numSecondsSinceEpoch, tm& t) // our fingers and hope the regular function actually is reentrant // (supposedly this is the case on Windows). #if CODA_OSS_POSIX_SOURCE - if (::localtime_r(&numSecondsSinceEpoch, &t) == NULL) + if (::localtime_r(&numSecondsSinceEpoch, &t) == nullptr) { int const errnum = errno; throw except::Exception(Ctxt("localtime_r() failed (" + @@ -664,7 +664,7 @@ void sys::DateTime::gmtime(time_t numSecondsSinceEpoch, tm& t) // our fingers and hope the regular function actually is reentrant // (supposedly this is the case on Windows). #if CODA_OSS_POSIX_SOURCE - if (::gmtime_r(&numSecondsSinceEpoch, &t) == NULL) + if (::gmtime_r(&numSecondsSinceEpoch, &t) == nullptr) { int const errnum = errno; throw except::Exception(Ctxt("gmtime_r() failed (" + diff --git a/modules/c++/sys/source/Dbg.cpp b/modules/c++/sys/source/Dbg.cpp index 804d504ed..3fa6f37a0 100644 --- a/modules/c++/sys/source/Dbg.cpp +++ b/modules/c++/sys/source/Dbg.cpp @@ -24,7 +24,23 @@ #include "sys/Dbg.h" -void sys::dbgPrintf(const char *format, ...) +#include + +#include + +inline void va_end_(va_list& args) noexcept +{ + CODA_OSS_disable_warning_push + #if _MSC_VER + #pragma warning(disable : 26477) // Use '...' rather than 0 or NULL(es .47). + #endif + + va_end(args); + + CODA_OSS_disable_warning_pop +} + +void sys::dbgPrintf(const char *format, ...) noexcept { if (sys::debugging) { @@ -32,16 +48,16 @@ void sys::dbgPrintf(const char *format, ...) va_start(args, format); fprintf(DEBUG_STREAM, " "); vfprintf(DEBUG_STREAM, format, args); - va_end(args); + va_end_(args); } } -void sys::diePrintf(const char *format, ...) +void sys::diePrintf(const char* format, ...) noexcept { va_list args; va_start(args, format); vfprintf(DEBUG_STREAM, format, args); - va_end(args); + va_end_(args); exit(EXIT_FAILURE); } diff --git a/modules/c++/sys/source/ErrUnix.cpp b/modules/c++/sys/source/ErrUnix.cpp index f2db39499..6fcf3699f 100644 --- a/modules/c++/sys/source/ErrUnix.cpp +++ b/modules/c++/sys/source/ErrUnix.cpp @@ -33,7 +33,7 @@ int sys::Err::getLast() const std::string sys::Err::toString() const { char *temp = strerror(mErrId); - if (temp == NULL) + if (temp == nullptr) return std::string(""); std::string stringError = temp; diff --git a/modules/c++/sys/source/ErrWin32.cpp b/modules/c++/sys/source/ErrWin32.cpp index bac96d0af..cb8241687 100644 --- a/modules/c++/sys/source/ErrWin32.cpp +++ b/modules/c++/sys/source/ErrWin32.cpp @@ -35,9 +35,9 @@ std::string sys::Err::toString() const { LPTSTR buffer; if (FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER | - FORMAT_MESSAGE_FROM_SYSTEM, NULL, + FORMAT_MESSAGE_FROM_SYSTEM, nullptr, static_cast(mErrId), 0, - (LPTSTR)&buffer, 0, NULL) == 0) + (LPTSTR)&buffer, 0, nullptr) == 0) { return std::string("Unknown error code"); } diff --git a/modules/c++/sys/source/ExecUnix.cpp b/modules/c++/sys/source/ExecUnix.cpp index 6a5f20912..a31bd6023 100644 --- a/modules/c++/sys/source/ExecUnix.cpp +++ b/modules/c++/sys/source/ExecUnix.cpp @@ -39,13 +39,13 @@ namespace sys FILE* ExecPipe::openPipe(const std::string& command, const std::string& type) { - FILE* ioFile = NULL; + FILE* ioFile = nullptr; int pIO[2]; //! create the IO pipes for stdin/out if (pipe(pIO) < 0) { - return NULL; + return nullptr; } //! fork a subprocess for running our command -- @@ -58,7 +58,7 @@ FILE* ExecPipe::openPipe(const std::string& command, // there was an error while forking close(pIO[READ_PIPE]); close(pIO[WRITE_PIPE]); - return NULL; + return nullptr; case 0: { // we are now in the forked process -- @@ -104,7 +104,7 @@ FILE* ExecPipe::openPipe(const std::string& command, // command the user specified execl("/bin/sh", "sh", "-c", command.c_str(), - static_cast(NULL)); + static_cast(nullptr)); //! exit the subprocess once it has completed exit(127); @@ -144,7 +144,7 @@ int ExecPipe::closePipe() if (mOutStream) { fclose(mOutStream); - mOutStream = NULL; + mOutStream = nullptr; } int exitStatus = 0; diff --git a/modules/c++/sys/source/ExecWin32.cpp b/modules/c++/sys/source/ExecWin32.cpp index 86bfa17cd..f49271d6b 100644 --- a/modules/c++/sys/source/ExecWin32.cpp +++ b/modules/c++/sys/source/ExecWin32.cpp @@ -20,6 +20,7 @@ * */ +#include #ifdef _WIN32 @@ -42,22 +43,22 @@ FILE* ExecPipe::openPipe(const std::string& command, const std::string& type) { FILE* ioFile = nullptr; - HANDLE outIO[2] = {NULL, NULL}; + HANDLE outIO[2] = {nullptr, nullptr}; //! inherit the pipe handles SECURITY_ATTRIBUTES saAttr; saAttr.nLength = sizeof(SECURITY_ATTRIBUTES); saAttr.bInheritHandle = TRUE; - saAttr.lpSecurityDescriptor = NULL; + saAttr.lpSecurityDescriptor = nullptr; if (!CreatePipe(&outIO[READ_PIPE], &outIO[WRITE_PIPE], &saAttr, 0)) { - return NULL; + return nullptr; } // check the pipes themselves are not inherited if (!SetHandleInformation(outIO[READ_PIPE], HANDLE_FLAG_INHERIT, 0)) { - return NULL; + return nullptr; } // the startInfo structure is where the pipes are connected @@ -75,11 +76,11 @@ FILE* ExecPipe::openPipe(const std::string& command, //! create the subprocess -- // this is equivalent to a fork + exec - if (CreateProcess(NULL, const_cast(command.c_str()), - NULL, NULL, TRUE, 0, NULL, NULL, + if (CreateProcess(nullptr, const_cast(command.c_str()), + nullptr, nullptr, TRUE, 0, nullptr, nullptr, &mStartInfo, &mProcessInfo) == 0) { - return NULL; + return nullptr; } // connect the pipes currently connected in the subprocess @@ -92,7 +93,7 @@ FILE* ExecPipe::openPipe(const std::string& command, if ((readDescriptor = _open_osfhandle( (intptr_t)outIO[READ_PIPE], _O_RDONLY)) == -1) { - return NULL; + return nullptr; } ioFile = _fdopen(readDescriptor, type.c_str()); CloseHandle(outIO[WRITE_PIPE]); @@ -121,13 +122,13 @@ int ExecPipe::closePipe() } // in case it fails - mOutStream = NULL; + mOutStream = nullptr; DWORD dwMillisec = INFINITE; - (void) WaitForSingleObject(mProcessInfo.hProcess, dwMillisec); + std::ignore = WaitForSingleObject(mProcessInfo.hProcess, dwMillisec); //! get the exit code - DWORD exitCode = NULL; + DWORD exitCode = 0; GetExitCodeProcess(mProcessInfo.hProcess, &exitCode); const int exitStatus = static_cast(exitCode); if (exitStatus == -1) diff --git a/modules/c++/sys/source/FileFinder.cpp b/modules/c++/sys/source/FileFinder.cpp index b95600aa3..b33cc47c4 100644 --- a/modules/c++/sys/source/FileFinder.cpp +++ b/modules/c++/sys/source/FileFinder.cpp @@ -102,7 +102,7 @@ sys::NotPredicate::~NotPredicate() if (mPredicate.second && mPredicate.first) { FilePredicate* tmp = mPredicate.first; - mPredicate.first = NULL; + mPredicate.first = nullptr; delete tmp; } } @@ -125,7 +125,7 @@ sys::LogicalPredicate::~LogicalPredicate() if (p.first && p.second) { sys::FilePredicate* tmp = p.first; - p.first = NULL; + p.first = nullptr; delete tmp; } } @@ -208,6 +208,17 @@ std::vector sys::FileFinder::search( return files; } +static fs::path parent_path(const fs::path& p) +{ + // If the parent_path() is the same, we've reached to root. + const auto retval = p.parent_path(); + if (retval.empty() || (retval == p)) + { + throw std::runtime_error("At root of filesystem: " + p.string()); + } + return retval; +} + static fs::path findFirst(const sys::FilePredicate& pred, const fs::path& startingDirectory) { auto dir = startingDirectory; @@ -228,7 +239,8 @@ static fs::path findFirst(const sys::FilePredicate& pred, const fs::path& starti { throw std::logic_error("Won't traverse above .git directory at: " + dir.string()); } - dir = dir.parent_path(); + + dir = parent_path(dir); } } fs::path sys::findFirstFile(const fs::path& startingDirectory, const fs::path& filename) @@ -265,7 +277,7 @@ fs::path sys::findFirstDirectory(const fs::path& startingDirectory, const fs::pa fs::path sys::test::findRootDirectory(const fs::path& p, const std::string& rootName, std::function isRoot) { - const auto isRootDirectory = [&](const fs::path& p) { return is_directory(p) && isRoot(p); }; + const auto isRootDirectory = [&](const fs::path& v) { return is_directory(v) && isRoot(v); }; // Does the given path look good? if (isRootDirectory(p)) @@ -297,7 +309,7 @@ fs::path sys::test::findRootDirectory(const fs::path& p, const std::string& root // Once we're at a .git directory, we have to go down, not up ... or fail. if (!is_directory(p / ".git")) { - return findRootDirectory(p.parent_path(), rootName, isRoot); + return findRootDirectory(parent_path(p), rootName, isRoot); } // TODO: since we're in the "FileFinder" module, maybe try a bit harder to find "rootName"? @@ -316,7 +328,7 @@ static inline std::string Platform() static fs::path findCMakeRoot(const fs::path& path, const fs::path& dir) { - static const auto platform_and_configuration = ::Platform() + "-" + ::Configuration(); // "x64-Debug" + static const auto platform_and_configuration = ::Platform() + "-" + ::Configuration(); // "x64-Debug" const auto pred = [&](const fs::path& p) { if (p.filename() == platform_and_configuration) @@ -338,7 +350,7 @@ static fs::path findCMakeRoot(const fs::path& path, const fs::path& dir) return false; }; - return sys::test::findRootDirectory(path, "", pred); + return sys::test::findRootDirectory(path, "", pred); } fs::path findCMake_Root(const fs::path& path, @@ -404,13 +416,8 @@ static fs::path find_dotGITDirectory_(const fs::path& p, const fs::path& initial { return p; } - - auto parent = p.parent_path(); - if (parent.empty()) - { - throw std::invalid_argument("Can't find .git/ anywhere in: " + initial.string()); - } - return find_dotGITDirectory_(parent, initial); + + return find_dotGITDirectory_(parent_path(p), initial); } fs::path sys::test::find_dotGITDirectory(const fs::path& p) { diff --git a/modules/c++/sys/source/FileUnix.cpp b/modules/c++/sys/source/FileUnix.cpp index f046f7db3..e603835a3 100644 --- a/modules/c++/sys/source/FileUnix.cpp +++ b/modules/c++/sys/source/FileUnix.cpp @@ -118,7 +118,7 @@ void sys::File::writeFrom(const void* buffer, size_t size) sys::Off_T sys::File::seekTo(sys::Off_T offset, int whence) { sys::Off_T off = ::lseek(mHandle, offset, whence); - if (off == (sys::Off_T) - 1) + if (off == static_cast(-1)) throw sys::SystemException(Ctxt("Seeking in file")); return off; } diff --git a/modules/c++/sys/source/FileWin32.cpp b/modules/c++/sys/source/FileWin32.cpp index 1b60a0201..5e2f2b23d 100644 --- a/modules/c++/sys/source/FileWin32.cpp +++ b/modules/c++/sys/source/FileWin32.cpp @@ -49,7 +49,7 @@ _SYS_HANDLE_TYPE sys::File::createFile(const coda_oss::filesystem::path& str_, i nullptr /*lpSecurityAttributes*/, dwCreationDisposition, FILE_ATTRIBUTE_NORMAL, - static_cast(0) /*hTemplateFile*/); + static_cast(nullptr) /*hTemplateFile*/); } void sys::File::create(const std::string& str, int accessFlags, @@ -83,7 +83,7 @@ void sys::File::readInto(void* buffer, size_t size) bufferPtr + bytesRead, bytesToRead, &bytesThisRead, - NULL)) + nullptr)) { throw sys::SystemException(Ctxt("Error reading from file")); } @@ -120,7 +120,7 @@ void sys::File::writeFrom(const void* buffer, size_t size) bufferPtr + bytesWritten, bytesToWrite, &bytesThisWrite, - NULL)) + nullptr)) { throw sys::SystemException(Ctxt("Writing from file")); } diff --git a/modules/c++/sys/source/LocalDateTime.cpp b/modules/c++/sys/source/LocalDateTime.cpp index 5f7215480..d0df8a213 100644 --- a/modules/c++/sys/source/LocalDateTime.cpp +++ b/modules/c++/sys/source/LocalDateTime.cpp @@ -47,7 +47,7 @@ void LocalDateTime::toMillis() t.tm_yday = mDayOfYear - 1; t.tm_hour = mHour; t.tm_min = mMinute; - t.tm_sec = (int)mSecond; + t.tm_sec = static_cast(mSecond); t.tm_isdst = mDST; mTimeInMillis = DateTime::toMillis(t); diff --git a/modules/c++/sys/source/MutexPosix.cpp b/modules/c++/sys/source/MutexPosix.cpp index f28ce93be..d28418444 100644 --- a/modules/c++/sys/source/MutexPosix.cpp +++ b/modules/c++/sys/source/MutexPosix.cpp @@ -28,7 +28,7 @@ sys::MutexPosix::MutexPosix() { - if (::pthread_mutex_init(&mNative, NULL) != 0) + if (::pthread_mutex_init(&mNative, nullptr) != 0) throw sys::SystemException("Mutex initialization failed"); } diff --git a/modules/c++/sys/source/MutexWin32.cpp b/modules/c++/sys/source/MutexWin32.cpp index 62786f0ee..d04d74511 100644 --- a/modules/c++/sys/source/MutexWin32.cpp +++ b/modules/c++/sys/source/MutexWin32.cpp @@ -29,8 +29,8 @@ sys::MutexWin32::MutexWin32() { - mNative = CreateMutex(NULL, FALSE, NULL); - if (mNative == NULL) + mNative = CreateMutex(nullptr, FALSE, nullptr); + if (mNative == nullptr) throw sys::SystemException("Mutex initializer failed"); } diff --git a/modules/c++/sys/source/OSUnix.cpp b/modules/c++/sys/source/OSUnix.cpp index e44d9a380..c9241b639 100644 --- a/modules/c++/sys/source/OSUnix.cpp +++ b/modules/c++/sys/source/OSUnix.cpp @@ -29,6 +29,7 @@ #include #include #include +#include #include "sys/Conf.h" @@ -256,7 +257,7 @@ std::string sys::OSUnix::getTempName(const std::string& path, } #else CharWrapper tempname = tempnam(path.c_str(), prefix.c_str()); - if (tempname.get() == NULL) + if (tempname.get() == nullptr) name = ""; else { @@ -298,7 +299,7 @@ std::string sys::OSUnix::operator[](const std::string& s) const std::string sys::OSUnix::getEnv(const std::string& s) const { const char* envVal = getenv(s.c_str()); - if (envVal == NULL) + if (envVal == nullptr) throw sys::SystemException( Ctxt("Unable to get unix environment variable " + s)); return std::string(envVal); @@ -307,7 +308,7 @@ std::string sys::OSUnix::getEnv(const std::string& s) const bool sys::OSUnix::isEnvSet(const std::string& s) const { const char* envVal = getenv(s.c_str()); - return (envVal != NULL); + return envVal != nullptr; } void sys::OSUnix::setEnv(const std::string& var, @@ -323,7 +324,7 @@ void sys::OSUnix::setEnv(const std::string& var, // putenv() will overwrite the value if it already exists, so if we don't // want to overwrite, we do nothing when getenv() indicates the variable's // already set - if (overwrite || getenv(var.c_str()) == NULL) + if (overwrite || getenv(var.c_str()) == nullptr) { // putenv() isn't guaranteed to make a copy of the string, so we need // to allocate it and let it leak. Ugh. @@ -420,6 +421,27 @@ void sys::OSUnix::getAvailableCPUs(std::vector& physicalCPUs, } } +sys::SIMDInstructionSet sys::OSUnix::getSIMDInstructionSet() const +{ + // https://gcc.gnu.org/onlinedocs/gcc-4.8.2/gcc/X86-Built-in-Functions.html + __builtin_cpu_init(); + + if (__builtin_cpu_supports("avx512f")) + { + return SIMDInstructionSet::AVX512F; + } + if (__builtin_cpu_supports("avx2")) + { + return SIMDInstructionSet::AVX2; + } + if (__builtin_cpu_supports("sse2")) + { + return SIMDInstructionSet::SSE2; + } + + throw std::runtime_error("SSE2 support is required."); +} + void sys::OSUnix::createSymlink(const std::string& origPathname, const std::string& symlinkPathname) const { @@ -538,23 +560,23 @@ void sys::DirectoryUnix::close() if (mDir) { closedir( mDir); - mDir = NULL; + mDir = nullptr; } } std::string sys::DirectoryUnix::findFirstFile(const std::string& dir) { // First file is always . on Unix mDir = ::opendir(dir.c_str()); - if (mDir == NULL) + if (mDir == nullptr) return ""; return findNextFile(); } std::string sys::DirectoryUnix::findNextFile() { - struct dirent* entry = NULL; + struct dirent* entry = nullptr; entry = ::readdir(mDir); - if (entry == NULL) + if (entry == nullptr) return ""; return entry->d_name; } diff --git a/modules/c++/sys/source/OSWin32.cpp b/modules/c++/sys/source/OSWin32.cpp index 9fe5e7f15..e381f2f91 100644 --- a/modules/c++/sys/source/OSWin32.cpp +++ b/modules/c++/sys/source/OSWin32.cpp @@ -81,12 +81,12 @@ bool sys::OSWin32::exists(const std::string& path) const const DWORD errCode = GetLastError(); if (errCode != ERROR_FILE_NOT_FOUND && errCode != ERROR_PATH_NOT_FOUND) { - char* err = NULL; + char* err = nullptr; FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM, - NULL, errCode, + nullptr, errCode, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), - (LPTSTR) &err, 0, NULL); + (LPTSTR) &err, 0, nullptr); throw except::Exception(Ctxt( "Problem while testing file existence for " + path + " with Error: " + std::string(err))); @@ -166,7 +166,7 @@ bool sys::OSWin32::isDirectory(const std::string& path) const bool sys::OSWin32::makeDirectory(const std::string& path) const { - return (CreateDirectory(path.c_str(), NULL)) ? (true): (false); + return (CreateDirectory(path.c_str(), nullptr)) ? (true) : (false); } std::string sys::OSWin32::getCurrentWorkingDirectory() const @@ -224,7 +224,7 @@ std::string sys::OSWin32::operator[](const std::string& s) const static std::string getEnv(const std::string& s) { - const DWORD size = GetEnvironmentVariable(s.c_str(), NULL, 0); + const DWORD size = GetEnvironmentVariable(s.c_str(), nullptr, 0); if (size == 0) { throw sys::SystemException(Ctxt( @@ -266,7 +266,7 @@ std::string sys::OSWin32::getEnv(const std::string& s) const bool sys::OSWin32::isEnvSet(const std::string& s) const { - const DWORD size = GetEnvironmentVariable(s.c_str(), NULL, 0); + const DWORD size = GetEnvironmentVariable(s.c_str(), nullptr, 0); if (size != 0) { return true; @@ -283,8 +283,14 @@ static void setEnv(const std::string& var, throw sys::SystemException(Ctxt( "Unable to set windows environment variable " + var)); } + const auto s = var + "=" + val; - _putenv(s.c_str()); + const auto result = _putenv(s.c_str()); + if (result != 0) // "The functions return 0 if successful, or -1 if there's an error." + { + throw sys::SystemException(Ctxt("Unable to set windows environment variable " + var)); + } + } void sys::OSWin32::setEnv(const std::string& var, const std::string& val, @@ -298,13 +304,18 @@ void sys::OSWin32::setEnv(const std::string& var, void sys::OSWin32::unsetEnv(const std::string& var) { - const BOOL ret = SetEnvironmentVariable(var.c_str(), NULL); + const BOOL ret = SetEnvironmentVariable(var.c_str(), nullptr); if (!ret) { throw sys::SystemException(Ctxt("Unable to unset windows environment variable " + var)); } + const auto s = var + "="; - _putenv(s.c_str()); + const auto result = _putenv(s.c_str()); + if (result != 0) // "The functions return 0 if successful, or -1 if there's an error." + { + throw sys::SystemException(Ctxt("Unable to unset windows environment variable " + var)); + } } size_t sys::OSWin32::getNumCPUs() const @@ -342,6 +353,25 @@ void sys::OSWin32::getAvailableCPUs(std::vector& /*physicalCPUs*/, Ctxt("Windows getAvailableCPUs not yet implemented.")); } +sys::SIMDInstructionSet sys::OSWin32::getSIMDInstructionSet() const +{ + // https://learn.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-isprocessorfeaturepresent + if (IsProcessorFeaturePresent(PF_AVX512F_INSTRUCTIONS_AVAILABLE)) + { + return SIMDInstructionSet::AVX512F; + } + if (IsProcessorFeaturePresent(PF_AVX2_INSTRUCTIONS_AVAILABLE)) + { + return SIMDInstructionSet::AVX2; + } + if (IsProcessorFeaturePresent(PF_XMMI64_INSTRUCTIONS_AVAILABLE)) + { + return SIMDInstructionSet::SSE2; + } + + throw std::runtime_error("SSE2 support is required."); +} + void sys::OSWin32::createSymlink(const std::string& origPathname, const std::string& symlinkPathname) const { @@ -414,7 +444,7 @@ std::string sys::OSWin32::getCurrentExecutable( char buffer[MAX_PATH + 2]; memset(buffer, 0, MAX_PATH + 2); - size_t bytesRead = GetModuleFileName(NULL, buffer, MAX_PATH + 1); + size_t bytesRead = GetModuleFileName(nullptr, buffer, MAX_PATH + 1); if (bytesRead == MAX_PATH + 1 || bytesRead == 0) { diff --git a/modules/c++/sys/source/Path.cpp b/modules/c++/sys/source/Path.cpp index c46643854..b775585af 100644 --- a/modules/c++/sys/source/Path.cpp +++ b/modules/c++/sys/source/Path.cpp @@ -178,7 +178,17 @@ std::string Path::absolutePath(const std::string& path) bool Path::isAbsolutePath(const std::string& path) { #ifdef _WIN32 - return !Path::splitDrive(path).first.empty(); + const auto split = Path::splitDrive(path); + const auto drive = split.first; + + // a URL such as "http://example.com" should NOT be an absolute path + // according to std::filesystem::path::is_absolute(). + if (drive.length() > 2) // "C:" + { + return false; // drive letters are single characters, e.g., "C:\Windows" + } + + return !drive.empty(); #else return (!path.empty() && path[0] == Path::delimiter()[0]); #endif diff --git a/modules/c++/sys/source/ResourceCheck.cpp b/modules/c++/sys/source/ResourceCheck.cpp index ab4eacc99..9bfcaea46 100644 --- a/modules/c++/sys/source/ResourceCheck.cpp +++ b/modules/c++/sys/source/ResourceCheck.cpp @@ -22,6 +22,7 @@ #include #include +#include namespace sys { @@ -40,7 +41,7 @@ size_t getAvailableMem(size_t systemMemBytes, size_t reservedBytes, double margin) { - const auto relativeAvailable = static_cast(systemMemBytes * margin); + const auto relativeAvailable = gsl::narrow_cast(gsl::narrow_cast(systemMemBytes) * margin); if (reservedBytes > systemMemBytes) { return 0; diff --git a/modules/c++/sys/source/ScopedCPUAffinityUnix.cpp b/modules/c++/sys/source/ScopedCPUAffinityUnix.cpp index f56e45e77..e409b3b03 100644 --- a/modules/c++/sys/source/ScopedCPUAffinityUnix.cpp +++ b/modules/c++/sys/source/ScopedCPUAffinityUnix.cpp @@ -26,6 +26,7 @@ #include #include +#include #include @@ -51,7 +52,7 @@ void ScopedCPUMaskUnix::initialize(int numCPUs) mSize = CPU_ALLOC_SIZE(numCPUs); mMask = CPU_ALLOC(numCPUs); - if (mMask == NULL) + if (mMask == nullptr) { std::ostringstream msg; msg << "Failed to allocate CPU mask for " << numCPUs << "CPUs"; @@ -63,7 +64,7 @@ void ScopedCPUMaskUnix::initialize(int numCPUs) ScopedCPUMaskUnix::~ScopedCPUMaskUnix() { - if (mMask != NULL) + if (mMask != nullptr) { CPU_FREE(mMask); } @@ -84,12 +85,12 @@ std::string ScopedCPUMaskUnix::toString() const int ScopedCPUMaskUnix::getNumOnlineCPUs() { #ifdef _SC_NPROCESSORS_ONLN - const int numOnlineCPUs = sysconf(_SC_NPROCESSORS_ONLN); + const auto numOnlineCPUs = sysconf(_SC_NPROCESSORS_ONLN); if (numOnlineCPUs == -1) { throw except::Exception(Ctxt("Failed to get online CPU count")); } - return numOnlineCPUs; + return gsl::narrow(numOnlineCPUs); #else throw except::NotImplementedException(Ctxt("Unable to get the number of CPUs")); #endif diff --git a/modules/c++/sys/source/SemaphoreWin32.cpp b/modules/c++/sys/source/SemaphoreWin32.cpp index fcfd8255b..6d136b4b6 100644 --- a/modules/c++/sys/source/SemaphoreWin32.cpp +++ b/modules/c++/sys/source/SemaphoreWin32.cpp @@ -30,11 +30,11 @@ sys::SemaphoreWin32::SemaphoreWin32(unsigned int count, size_t _maxCount) { // Ensure maxCount never becomes negative due to casting between signed/unsigned types - const LONG maxLong = std::numeric_limits::max(); - LONG maxCount = (_maxCount > maxLong) ? maxLong : static_cast(_maxCount); + constexpr auto maxLong = std::numeric_limits::max(); + const auto maxCount = (_maxCount > maxLong) ? maxLong : static_cast(_maxCount); - mNative = CreateSemaphore(NULL, static_cast(count), maxCount, NULL); - if (mNative == NULL) + mNative = CreateSemaphore(nullptr, static_cast(count), maxCount, nullptr); + if (mNative == nullptr) throw sys::SystemException("CreateSemaphore Failed"); } @@ -53,7 +53,7 @@ void sys::SemaphoreWin32::signal() { if (!ReleaseSemaphore(mNative, 1, - NULL) ) + nullptr) ) { throw sys::SystemException("Semaphore signal failed"); } diff --git a/modules/c++/sys/source/StopWatch.cpp b/modules/c++/sys/source/StopWatch.cpp index 81b27ed99..ca3300010 100644 --- a/modules/c++/sys/source/StopWatch.cpp +++ b/modules/c++/sys/source/StopWatch.cpp @@ -114,7 +114,7 @@ double sys::CPUStopWatch::start() else mStartTime = now; - return ((double)now/mClocksPerMillis); + return static_cast(now)/mClocksPerMillis; } double sys::CPUStopWatch::stop() @@ -128,7 +128,7 @@ double sys::CPUStopWatch::stop() } // If start time was never set (or reset) then don't bother calculating elapsed time if(mStartTime != -1) - return ((double)(end - mStartTime - mTimePaused)/mClocksPerMillis); + return static_cast(end - mStartTime - mTimePaused)/mClocksPerMillis; else return 0; } @@ -140,7 +140,7 @@ double sys::CPUStopWatch::pause() mPauseStartTime = clock(); mPaused = true; } - return ((double)mPauseStartTime/mClocksPerMillis); + return static_cast(mPauseStartTime)/mClocksPerMillis; } void sys::CPUStopWatch::clear() diff --git a/modules/c++/sys/source/ThreadPosix.cpp b/modules/c++/sys/source/ThreadPosix.cpp index 4892ab396..c399b5c83 100644 --- a/modules/c++/sys/source/ThreadPosix.cpp +++ b/modules/c++/sys/source/ThreadPosix.cpp @@ -52,7 +52,7 @@ void sys::ThreadPosix::start() if (::pthread_create(&mNative, &attr, - (void *(*)(void *))this->__start, + static_cast(this->__start), this) != 0) throw sys::SystemException("pthread_create()"); pthread_attr_destroy(&attr); @@ -60,8 +60,8 @@ void sys::ThreadPosix::start() else { if (::pthread_create(&mNative, - NULL, - (void *(*)(void *))this->__start, + nullptr, + static_cast(this->__start), this) != 0) throw sys::SystemException("pthread_create()"); } @@ -80,8 +80,8 @@ void *sys::ThreadPosix::__start(void *v) delete runnable; */ - pthread_exit(NULL); - return NULL; + pthread_exit(nullptr); + return nullptr; } void sys::ThreadPosix::kill() @@ -94,7 +94,7 @@ void sys::ThreadPosix::kill() } void sys::ThreadPosix::join() { - if (::pthread_join(mNative, NULL) != 0) + if (::pthread_join(mNative, nullptr) != 0) throw sys::SystemException("pthread_join()"); } void sys::ThreadPosix::yield() diff --git a/modules/c++/sys/source/ThreadWin32.cpp b/modules/c++/sys/source/ThreadWin32.cpp index 43ee313b6..0b0521b00 100644 --- a/modules/c++/sys/source/ThreadWin32.cpp +++ b/modules/c++/sys/source/ThreadWin32.cpp @@ -39,13 +39,13 @@ void sys::ThreadWin32::start() { DWORD threadId; - mNative = __CREATETHREAD(NULL, + mNative = __CREATETHREAD(nullptr, 0, __start, (void*)this, 0, &threadId); - if (mNative == NULL) + if (mNative == nullptr) throw sys::SystemException("Thread creation failed"); diff --git a/modules/c++/sys/source/UTCDateTime.cpp b/modules/c++/sys/source/UTCDateTime.cpp index 36a166ee9..1ed995121 100644 --- a/modules/c++/sys/source/UTCDateTime.cpp +++ b/modules/c++/sys/source/UTCDateTime.cpp @@ -49,7 +49,7 @@ const int DAYS_PER_YEAR[2] = {365, 366}; // Returns the appropriate index into CUMULATIVE_DAYS_PER_MONTH based on // whether 'year' is a leap year or not -int yearIndex(int year) +constexpr int yearIndex(int year) { return (!(year % 4) && ((year % 100) || !(year % 400))); } diff --git a/modules/c++/sys/source/sys_Backtrace.cpp b/modules/c++/sys/source/sys_Backtrace.cpp index 13098be08..ce5bdb03e 100644 --- a/modules/c++/sys/source/sys_Backtrace.cpp +++ b/modules/c++/sys/source/sys_Backtrace.cpp @@ -24,7 +24,7 @@ std::string sys::getBacktrace(bool* pSupported) { - bool supported; + bool supported = false; std::vector frames; bool& supported_ = pSupported != nullptr ? *pSupported : supported; return getBacktrace(supported_, frames); diff --git a/modules/c++/sys/tests/DLLTest.cpp b/modules/c++/sys/tests/DLLTest.cpp index dcaa92a44..1e37e2587 100644 --- a/modules/c++/sys/tests/DLLTest.cpp +++ b/modules/c++/sys/tests/DLLTest.cpp @@ -46,7 +46,7 @@ int main(int argc, char** argv) DLL dso(dsoPath); - HOOK_FN theHook = (HOOK_FN) dso.retrieve(hook); + auto theHook = reinterpret_cast(dso.retrieve(hook)); // Call the hook if (!theHook()) diff --git a/modules/c++/sys/tests/DateTimeTest.cpp b/modules/c++/sys/tests/DateTimeTest.cpp index f47fc3387..b2c5597f0 100644 --- a/modules/c++/sys/tests/DateTimeTest.cpp +++ b/modules/c++/sys/tests/DateTimeTest.cpp @@ -54,7 +54,7 @@ int main(int, char**) sys::CPUStopWatch csw; //std::cout << "CPS: " << CLOCKS_PER_SEC << std::endl; std::cout << "clock(): " << clock() / CLOCKS_PER_SEC << std::endl; - std::cout << "time(): " << time(NULL) << std::endl; + std::cout << "time(): " << time(nullptr) << std::endl; std::cout << "RTStart: " << sw.start() << std::endl; std::cout << "CStart: " << csw.start() << std::endl; int x = 0; @@ -82,7 +82,7 @@ int main(int, char**) } std::cout << "Finish Loop 3" << std::endl; std::cout << "clock(): " << clock() / CLOCKS_PER_SEC << std::endl; - std::cout << "time(): " << time(NULL) << std::endl; + std::cout << "time(): " << time(nullptr) << std::endl; std::cout << "RTStop: " << std::setprecision(50) << sw.stop() << std::endl; std::cout << "CStop: " << std::setprecision(50) << csw.stop() diff --git a/modules/c++/sys/tests/OSTest.cpp b/modules/c++/sys/tests/OSTest.cpp index f8ee1ea5a..330493eb7 100644 --- a/modules/c++/sys/tests/OSTest.cpp +++ b/modules/c++/sys/tests/OSTest.cpp @@ -110,7 +110,7 @@ int main(int argc, char **argv) } os.remove("TEST_DIRECTORY"); - std::cout << "Time Now: " << time(NULL) << std::endl; + std::cout << "Time Now: " << time(nullptr) << std::endl; sys::RealTimeStopWatch sw; //std::cout << "CPS: " << CLOCKS_PER_SEC << std::endl; // std::cout << "Clock: " << clock() << std::endl; @@ -137,7 +137,7 @@ int main(int argc, char **argv) std::cout << "Finish Loop 3" << std::endl; std::cout << "Stop: " << std::setprecision(50) << sw.stop() << std::endl; - std::cout << "Time Now: " << time(NULL) << std::endl; + std::cout << "Time Now: " << time(nullptr) << std::endl; // std::cout << "Clock: " << clock() << std::endl; } diff --git a/modules/c++/sys/unittests/test_byte_swap.cpp b/modules/c++/sys/unittests/test_byte_swap.cpp index 908eae3e3..2d784428b 100644 --- a/modules/c++/sys/unittests/test_byte_swap.cpp +++ b/modules/c++/sys/unittests/test_byte_swap.cpp @@ -23,11 +23,14 @@ #include "TestCase.h" #include - +#include #include // std::endian #include +#include +#include #include +#include TEST_CASE(testEndianness) { @@ -70,39 +73,248 @@ TEST_CASE(testEndianness) } } -TEST_CASE(testByteSwap) +template +static std::vector make_origValues(size_t NUM_PIXELS) { ::srand(334); - static const size_t NUM_PIXELS = 10000; - std::vector origValues(NUM_PIXELS); + std::vector retval(NUM_PIXELS); for (size_t ii = 0; ii < NUM_PIXELS; ++ii) { const auto value = static_cast(::rand()) / RAND_MAX * - std::numeric_limits::max(); - origValues[ii] = static_cast(value); + std::numeric_limits::max(); + retval[ii] = static_cast(value); + } + return retval; +} + +TEST_CASE(testByteSwapV) +{ + constexpr size_t NUM_PIXELS = 10000; + const auto origValues = make_origValues (NUM_PIXELS); + + // Byte swap the old-fashioned way + auto values1(origValues); + sys::byteSwap(values1.data(), sizeof(uint64_t), NUM_PIXELS); + + // Byte swap into output buffer + std::vector swappedValues2(origValues.size()); + sys::byteSwap(origValues.data(), sizeof(uint64_t), NUM_PIXELS, swappedValues2.data()); + + // Everything should match + for (size_t ii = 0; ii < NUM_PIXELS; ++ii) + { + TEST_ASSERT_EQ(values1[ii], swappedValues2[ii]); } +} + +TEST_CASE(testByteSwapCxV) +{ + constexpr size_t NUM_PIXELS = 10000; + using value_type = std::complex; + const auto origValues = make_origValues(NUM_PIXELS); + + constexpr auto elemSize = sizeof(value_type) / 2; + constexpr auto numElems = NUM_PIXELS * 2; // Byte swap the old-fashioned way - std::vector values1(origValues); - sys::byteSwap(&values1[0], sizeof(sys::Uint64_T), NUM_PIXELS); + auto values1(origValues); + sys::byteSwap(values1.data(), elemSize, numElems); + + // Byte swap into output buffer + std::vector swappedValues2(origValues.size()); + sys::byteSwap(origValues.data(), elemSize, numElems, swappedValues2.data()); + + // Everything should match + for (size_t ii = 0; ii < NUM_PIXELS; ++ii) + { + using int_type = uint64_t; + static_assert(sizeof(int_type) == sizeof(value_type), "Unknown sizeof(std::complex)"); + + // If these values are byte-swapped, they could be bogus. + const void* const pValue1_ = &(values1[ii]); + const void* const pSwappedValue2_ = &(swappedValues2[ii]); + + auto const pValue1 = static_cast(pValue1_); + auto const pSwappedValue2 = static_cast(pSwappedValue2_); + + TEST_ASSERT_EQ(*pValue1, *pSwappedValue2); + } +} +template +inline std::span as_span(const std::vector& bytes) +{ + const void* const pBytes_ = bytes.data(); + auto const p = static_cast(pBytes_); + const auto sz = bytes.size() / sizeof(T); + return sys::make_span(p, sz); +} + +TEST_CASE(testByteSwap) +{ + constexpr size_t NUM_PIXELS = 10000; + const auto origValues = make_origValues(NUM_PIXELS); + const auto origValues_ = sys::make_span(origValues); + + auto values1(origValues); + sys::byteSwap(sys::make_span(values1)); // Byte swap into output buffer - const std::vector values2(origValues); - std::vector swappedValues2(values2.size()); - sys::byteSwap(&values2[0], sizeof(sys::Uint64_T), NUM_PIXELS, - &swappedValues2[0]); + std::vector swappedValues2(origValues.size()); + sys::byteSwap(origValues_, sys::as_writable_bytes(swappedValues2)); + + // std::vector returned + const auto swappedValues3_ = sys::byteSwap(origValues_); + const auto swappedValues3 = as_span(swappedValues3_); // Everything should match for (size_t ii = 0; ii < NUM_PIXELS; ++ii) { TEST_ASSERT_EQ(values1[ii], swappedValues2[ii]); + TEST_ASSERT_EQ(values1[ii], swappedValues3[ii]); } } +// 0xnn is an `int` which can't be used to initialize std::byte w/o a cast +#define CODA_OSS_define_byte(v) constexpr static std::byte v = static_cast(0 ## v) +CODA_OSS_define_byte(x00); +CODA_OSS_define_byte(x11); +CODA_OSS_define_byte(x22); +CODA_OSS_define_byte(x33); +CODA_OSS_define_byte(x44); +CODA_OSS_define_byte(x55); +CODA_OSS_define_byte(x66); +CODA_OSS_define_byte(x77); +CODA_OSS_define_byte(x88); +CODA_OSS_define_byte(x99); +CODA_OSS_define_byte(xAA); +CODA_OSS_define_byte(xBB); +CODA_OSS_define_byte(xCC); +CODA_OSS_define_byte(xDD); +CODA_OSS_define_byte(xEE); +CODA_OSS_define_byte(xFF); +#undef CODA_OSS_define_byte + +static constexpr std::byte two_bytes[]{x00, xFF}; +static constexpr std::byte four_bytes[]{x00, x11, xEE, xFF}; +static constexpr std::byte eight_bytes[]{x00, x11, x22, x33, xCC, xDD, xEE, xFF}; +static constexpr std::byte sixteen_bytes[]{x00, x11, x22, x33, x44, x55, x66, x77, x88, x99, xAA, xBB, xCC, xDD, xEE, xFF}; + +template +static void test_assert_eq_swapped(const std::string& testName, size_t sz, + const TByteSpanLike1& pValueBytes, const TByteSpanLike2& pResultBytes) +{ + for (size_t i = 0, j = sz; i < sz && j > 0; i++, j--) + { + TEST_ASSERT(pResultBytes[i] == pValueBytes[j - 1]); + } +} + +template +static void testByteSwapValues_(const std::string& testName, const void* pBytes) +{ + auto pUInt = static_cast(pBytes); + auto swap = sys::byteSwap(*pUInt); + TEST_ASSERT_NOT_EQ(*pUInt, swap); + + const void* pResult_ = &swap; + auto const pResultBytes = static_cast(pResult_); + auto const pValueBytes = static_cast(pBytes); + test_assert_eq_swapped(testName, sizeof(TUInt), pResultBytes, pValueBytes); + + swap = sys::byteSwap(swap); // swap back + TEST_ASSERT_EQ(*pUInt, swap); + + // swap as an "array" of one value + sys::byteSwap(pUInt, sizeof(TUInt), 1, &swap); + TEST_ASSERT_NOT_EQ(*pUInt, swap); + sys::byteSwap(&swap, sizeof(TUInt), 1); // swap back + TEST_ASSERT_EQ(*pUInt, swap); + + const auto resultBytes = sys::byteSwapValue(*pUInt); + TEST_ASSERT_EQ(resultBytes.size(), sizeof(TUInt)); + test_assert_eq_swapped(testName, sizeof(TUInt), resultBytes.data(), pValueBytes); +} +TEST_CASE(testByteSwapValues) +{ + testByteSwapValues_(testName, two_bytes); + testByteSwapValues_(testName, four_bytes); + testByteSwapValues_(testName, eight_bytes); +} + +TEST_CASE(testByteSwapCxValue) +{ + using value_type = std::complex; + const value_type cx{3.14f, -31.4f}; // using raw bytes can lean to `nan`s + auto const pValue = &cx; + + auto swap = sys::byteSwap(*pValue); + TEST_ASSERT_NOT_EQ(*pValue, swap); // technically a bit goofy as the bits may not represent `T`s + + swap = sys::byteSwap(swap); // swap back + TEST_ASSERT_EQ(*pValue, swap); +} + +TEST_CASE(testByteSwap12) +{ + // test a goofy element size + constexpr std::byte twelve_bytes[]{ + x00, x11, x22, x33, x44, x55, + x99, xAA, xBB, xDD, xEE, xFF}; + const auto pValueBytes = sys::as_bytes(twelve_bytes); + constexpr auto extent_twelve_bytes = std::extent::value; + + std::vector swappedValues(extent_twelve_bytes); + auto pResultBytes = sys::make_span(swappedValues); + + auto elemSize = 12; + auto numElements = swappedValues.size() / elemSize; + sys::byteSwap(twelve_bytes, elemSize, numElements, pResultBytes.data()); + test_assert_eq_swapped(testName, elemSize, pResultBytes, pValueBytes); + + // swap as a SINGLE 12-byte value + const auto result = sys::details::swapBytes(pValueBytes, pResultBytes); + test_assert_eq_swapped(testName, elemSize, result, pValueBytes); + + elemSize = 6; // note that an ODD size doesn't work correctly + numElements = swappedValues.size() / elemSize; + sys::byteSwap(twelve_bytes, elemSize, numElements, swappedValues.data()); + test_assert_eq_swapped(testName, elemSize, &(pResultBytes[0]), &(pValueBytes[0])); + test_assert_eq_swapped(testName, elemSize, &(pResultBytes[6]), &(pValueBytes[6])); + + sys::byteSwap(swappedValues.data(), elemSize, numElements); // swap back + for (size_t i = 0; i < swappedValues.size(); i++) + { + TEST_ASSERT(pResultBytes[i] == pValueBytes[i]); + } +} + +template +static inline void six_byteSwap(const void* in, T& out) +{ + auto const inBytes = sys::make_span(in, sizeof(T)); + out = sys::byteSwapValue(inBytes); +} +TEST_CASE(testSixByteSwap) +{ + const int i = 123; + int i_swapped; + six_byteSwap(&i, i_swapped); + TEST_ASSERT_NOT_EQ(i, i_swapped); + + int result; + six_byteSwap(&i_swapped, result); + TEST_ASSERT_EQ(i, result); +} TEST_MAIN( TEST_CHECK(testEndianness); + TEST_CHECK(testByteSwapV); + TEST_CHECK(testByteSwapCxV); TEST_CHECK(testByteSwap); + TEST_CHECK(testByteSwapValues); + TEST_CHECK(testByteSwapCxValue); + TEST_CHECK(testByteSwap12); + TEST_CHECK(testSixByteSwap); ) diff --git a/modules/c++/sys/unittests/test_os.cpp b/modules/c++/sys/unittests/test_os.cpp index af07859a3..2261acd0e 100644 --- a/modules/c++/sys/unittests/test_os.cpp +++ b/modules/c++/sys/unittests/test_os.cpp @@ -511,6 +511,17 @@ TEST_CASE(test_make_ifstream) TEST_ASSERT_TRUE(ifs.is_open()); } +TEST_CASE(test_SIMD_Instructions) +{ + const sys::OS os; + const auto simdInstructionSet = os.getSIMDInstructionSet(); + + const auto isSSE2 = simdInstructionSet == sys::SIMDInstructionSet::SSE2; + const auto isAVX2 = simdInstructionSet == sys::SIMDInstructionSet::AVX2; + const auto isAVX512F = simdInstructionSet == sys::SIMDInstructionSet::AVX512F; + TEST_ASSERT(isSSE2 || isAVX2 || isAVX512F); +} + TEST_MAIN( //sys::AbstractOS::setArgvPathname(argv[0]); TEST_CHECK(testRecursiveRemove); @@ -527,4 +538,5 @@ TEST_MAIN( TEST_CHECK(test_sys_fopen_failure); TEST_CHECK(test_sys_open); TEST_CHECK(test_make_ifstream); + TEST_CHECK(test_SIMD_Instructions); ) diff --git a/modules/c++/sys/unittests/test_path.cpp b/modules/c++/sys/unittests/test_path.cpp index ab838d027..a444b9c65 100644 --- a/modules/c++/sys/unittests/test_path.cpp +++ b/modules/c++/sys/unittests/test_path.cpp @@ -21,6 +21,8 @@ * */ +#include + #include #include "TestCase.h" @@ -81,6 +83,62 @@ TEST_CASE(testPathMerge) TEST_ASSERT_EQ(result, path); } +TEST_CASE(test_std_filesystem_is_absolute) +{ + std::filesystem::path path +#ifdef _WIN32 + (R"(c:\a\b\c)"); +#else + ("/a/b/c"); +#endif + TEST_ASSERT_TRUE(path.is_absolute()); + path = +#ifdef _WIN32 + R"(a\b\c)"; +#else + "a/b/c"; +#endif + TEST_ASSERT_FALSE(path.is_absolute()); + TEST_ASSERT_TRUE(path.is_relative()); + + const std::filesystem::path slash("/"); + // https://en.cppreference.com/w/cpp/filesystem/path/is_absrel + // "The path "/" is absolute on a POSIX OS, but is relative on Windows." +#ifdef _WIN32 + TEST_ASSERT_TRUE(slash.is_relative()); + TEST_ASSERT_FALSE(slash.is_absolute()); +#else + TEST_ASSERT_TRUE(slash.is_absolute()); + TEST_ASSERT_FALSE(slash.is_relative()); +#endif + + std::filesystem::path url("x://example.com"); // 1 letter +#ifdef _WIN32 + TEST_ASSERT_TRUE(url.is_absolute()); // looks like a drive letter on Windows + TEST_ASSERT_FALSE(url.is_relative()); +#else + TEST_ASSERT_FALSE(url.is_absolute()); + TEST_ASSERT_TRUE(url.is_relative()); +#endif + + url = "s3://example.com"; // 2 letters + TEST_ASSERT_FALSE(url.is_absolute()); + TEST_ASSERT_TRUE(url.is_relative()); // Should this be false? + + url = "ftp://example.com"; // 3 letters + TEST_ASSERT_FALSE(url.is_absolute()); + + url = "http://example.com"; // 4 letters + TEST_ASSERT_FALSE(url.is_absolute()); + + url = "https://example.com"; // 5 letters + TEST_ASSERT_FALSE(url.is_absolute()); + + url = "mailto:nobody@example.com"; // 6 letters + TEST_ASSERT_FALSE(url.is_absolute()); + TEST_ASSERT_TRUE(url.is_relative()); // Should this be false? +} + TEST_CASE(testExpandEnvTilde) { auto path = sys::Path::expandEnvironmentVariables("~"); @@ -322,6 +380,7 @@ TEST_CASE(testModifyVar2) TEST_MAIN( TEST_CHECK(testPathMerge); + TEST_CHECK(test_std_filesystem_is_absolute); TEST_CHECK(testExpandEnvTilde); TEST_CHECK(testExpandEnv); TEST_CHECK(testExpandEnvTildePath); diff --git a/modules/c++/tiff/include/tiff/GenericType.h b/modules/c++/tiff/include/tiff/GenericType.h index 9d5a994ea..5e9787f00 100644 --- a/modules/c++/tiff/include/tiff/GenericType.h +++ b/modules/c++/tiff/include/tiff/GenericType.h @@ -112,7 +112,8 @@ template class Gene *****************************************************************/ GenericType(const unsigned char *data) { - mData = *((Data_T *)data); + const void* const pData = data; + mData = *(static_cast(pData)); } //! Deconstructor diff --git a/modules/c++/tiff/source/IFD.cpp b/modules/c++/tiff/source/IFD.cpp index 96de554d5..fb145461d 100644 --- a/modules/c++/tiff/source/IFD.cpp +++ b/modules/c++/tiff/source/IFD.cpp @@ -53,7 +53,7 @@ tiff::IFDEntry *tiff::IFD::operator[](unsigned short tag) // not exist. This is to make sure that the map doesn't get full // of invalid key/value pairs if you're just trying to verify whether // a key already exists of not. - return exists(tag) ? mIFD[tag] : NULL; + return exists(tag) ? mIFD[tag] : nullptr; } const tiff::IFDEntry* tiff::IFD::operator[](unsigned short tag) const { @@ -123,7 +123,7 @@ void tiff::IFD::serialize(io::OutputStream& output) { io::Seekable *seekable = dynamic_cast(&output); - if (seekable == NULL) + if (seekable == nullptr) throw except::Exception(Ctxt("Can only serialize IFD to seekable stream")); // Makes sure all data offsets are defined for each entry. diff --git a/modules/c++/tiff/source/IFDEntry.cpp b/modules/c++/tiff/source/IFDEntry.cpp index 07697da8c..d9f5447dd 100644 --- a/modules/c++/tiff/source/IFDEntry.cpp +++ b/modules/c++/tiff/source/IFDEntry.cpp @@ -38,7 +38,7 @@ void tiff::IFDEntry::serialize(io::OutputStream& output) { io::Seekable *seekable = dynamic_cast(&output); - if (seekable == NULL) + if (seekable == nullptr) throw except::Exception(Ctxt("Can only serialize IFDEntry to seekable stream")); output.write((sys::byte *)&mTag, sizeof(mTag)); @@ -88,7 +88,7 @@ void tiff::IFDEntry::deserialize(io::InputStream& input, const bool reverseBytes { io::Seekable *seekable = dynamic_cast(&input); - if (seekable == NULL) + if (seekable == nullptr) throw except::Exception(Ctxt("Can only deserialize IFDEntry from seekable stream")); input.read((char *)&mTag, sizeof(mTag)); @@ -120,14 +120,13 @@ void tiff::IFDEntry::deserialize(io::InputStream& input, const bool reverseBytes { auto elementSize = tiff::Const::sizeOf(mType); sys::Uint32_T numElements = mCount; - if (mType == tiff::Const::Type::RATIONAL && mType - == tiff::Const::Type::SRATIONAL) + if ((mType == tiff::Const::Type::RATIONAL) || (mType == tiff::Const::Type::SRATIONAL)) { elementSize = tiff::Const::sizeOf(mType) / 2; numElements = mCount * 2; } if (elementSize > 1) - sys::byteSwap(buffer, static_cast(elementSize), numElements); + sys::byteSwap(buffer, elementSize, numElements); } parseValues((const unsigned char *)buffer); diff --git a/modules/c++/tiff/source/ImageReader.cpp b/modules/c++/tiff/source/ImageReader.cpp index 2f7a95ad6..5fd42c6ad 100644 --- a/modules/c++/tiff/source/ImageReader.cpp +++ b/modules/c++/tiff/source/ImageReader.cpp @@ -76,7 +76,7 @@ void tiff::ImageReader::getData(unsigned char *buffer, throw except::Exception(Ctxt("Unsupported TIFF file format")); if (mReverseBytes) - sys::byteSwap((sys::byte*)buffer, mElementSize, numElementsToRead); + sys::byteSwap(buffer, mElementSize, numElementsToRead); } void tiff::ImageReader::getStripData(unsigned char *buffer, diff --git a/modules/c++/tiff/source/ImageWriter.cpp b/modules/c++/tiff/source/ImageWriter.cpp index ed89e6da9..d293fed73 100644 --- a/modules/c++/tiff/source/ImageWriter.cpp +++ b/modules/c++/tiff/source/ImageWriter.cpp @@ -210,7 +210,7 @@ void tiff::ImageWriter::validate() // if (mGeoTIFFReader) // { - // tiff::IFDEntry *entry = NULL; + // tiff::IFDEntry *entry = nullptr; // if ((entry = (*mGeoTIFFReader)["ModelPixelScaleTag"])) // mIFD.addEntry(entry); // if ((entry = (*mGeoTIFFReader)["ModelTiepointTag"])) @@ -230,20 +230,20 @@ void tiff::ImageWriter::validate() void tiff::ImageWriter::initTiles() { - sys::Uint32_T root = (sys::Uint32_T)sqrt((double)mIdealChunkSize + const sys::Uint32_T root = (sys::Uint32_T)sqrt((double)mIdealChunkSize / (double)mIFD.getElementSize()); - sys::Uint32_T ceiling = (sys::Uint32_T)ceil(((double)root) / 16); - sys::Uint32_T tileSize = ceiling * 16; + const sys::Uint32_T ceiling = (sys::Uint32_T)ceil(((double)root) / 16); + const sys::Uint32_T tileSize = ceiling * 16; mIFD.addEntry("TileWidth", (sys::Uint32_T) tileSize); mIFD.addEntry("TileLength", (sys::Uint32_T) tileSize); auto fileOffset = mOutput->tell(); - sys::Uint32_T tilesAcross = (mIFD.getImageWidth() + tileSize - 1) + const sys::Uint32_T tilesAcross = (mIFD.getImageWidth() + tileSize - 1) / tileSize; - sys::Uint32_T tilesDown = (mIFD.getImageLength() + tileSize - 1) / tileSize; + const sys::Uint32_T tilesDown = (mIFD.getImageLength() + tileSize - 1) / tileSize; - unsigned short elementSize = mIFD.getElementSize(); + const unsigned short elementSize = mIFD.getElementSize(); mIFD.addEntry("TileByteCounts"); mIFD.addEntry("TileOffsets"); @@ -251,7 +251,7 @@ void tiff::ImageWriter::initTiles() { for (sys::Uint32_T x = 0; x < tilesAcross; ++x) { - sys::Uint32_T byteCount = tileSize * tileSize * elementSize; + const sys::Uint32_T byteCount = tileSize * tileSize * elementSize; mIFD.addEntryValue("TileOffsets", (sys::Uint32_T) fileOffset); mIFD.addEntryValue("TileByteCounts", (sys::Uint32_T) byteCount); fileOffset += byteCount; diff --git a/modules/c++/tiff/source/KnownTags.cpp b/modules/c++/tiff/source/KnownTags.cpp index 946818b27..60b329079 100644 --- a/modules/c++/tiff/source/KnownTags.cpp +++ b/modules/c++/tiff/source/KnownTags.cpp @@ -161,6 +161,6 @@ tiff::IFDEntry *tiff::KnownTags::operator[] (const unsigned short tagKey) { std::map::iterator pos = mKnownTags.find(tagKey); - return pos != mKnownTags.end() ? pos->second : NULL; + return pos != mKnownTags.end() ? pos->second : nullptr; } diff --git a/modules/c++/tiff/source/TypeFactory.cpp b/modules/c++/tiff/source/TypeFactory.cpp index 5f5715a6c..1e7f52b2a 100644 --- a/modules/c++/tiff/source/TypeFactory.cpp +++ b/modules/c++/tiff/source/TypeFactory.cpp @@ -28,7 +28,7 @@ tiff::TypeInterface *tiff::TypeFactory::create(const unsigned char *data, const unsigned short type) { - tiff::TypeInterface *tiffType = NULL; + tiff::TypeInterface* tiffType = nullptr; switch (type) { case tiff::Const::Type::BYTE: diff --git a/modules/c++/tiff/source/Utils.cpp b/modules/c++/tiff/source/Utils.cpp index 9467a08d4..ff6e60d04 100644 --- a/modules/c++/tiff/source/Utils.cpp +++ b/modules/c++/tiff/source/Utils.cpp @@ -30,7 +30,7 @@ bool tiff::Utils::hasGeoTiffIFD(const tiff::IFD* ifd) tiff::IFD* tiff::Utils::createGeoTiffIFD(tiff::IFD* ifd) { if (!tiff::Utils::hasGeoTiffIFD(ifd)) - return NULL; + return nullptr; std::map keyMap; keyMap[1024] = "GTModelTypeGeoKey"; @@ -83,12 +83,12 @@ tiff::IFD* tiff::Utils::createGeoTiffIFD(tiff::IFD* ifd) tiff::IFD* geoIFD = new tiff::IFD; tiff::IFDEntry *geoDir = (*ifd)["GeoKeyDirectoryTag"]; - tiff::IFDEntry *doubleParams = + tiff::IFDEntry* const doubleParams = ifd->exists("GeoDoubleParamsTag") ? (*ifd)["GeoDoubleParamsTag"] - : NULL; - tiff::IFDEntry *asciiParams = + : nullptr; + tiff::IFDEntry* const asciiParams = ifd->exists("GeoAsciiParamsTag") ? (*ifd)["GeoAsciiParamsTag"] - : NULL; + : nullptr; std::vector geoVals = geoDir->getValues(); size_t idx = 0; diff --git a/modules/c++/types/CMakeLists.txt b/modules/c++/types/CMakeLists.txt index 4663df35e..00881001c 100644 --- a/modules/c++/types/CMakeLists.txt +++ b/modules/c++/types/CMakeLists.txt @@ -2,7 +2,7 @@ set(MODULE_NAME types) coda_add_module(${MODULE_NAME} VERSION 1.0 - DEPS gsl-c++) + DEPS coda_oss-c++ config-c++ gsl-c++) coda_add_tests( MODULE_NAME ${MODULE_NAME} diff --git a/modules/c++/types/include/types/Complex.h b/modules/c++/types/include/types/Complex.h new file mode 100644 index 000000000..8b2218ff4 --- /dev/null +++ b/modules/c++/types/include/types/Complex.h @@ -0,0 +1,233 @@ +/* ========================================================================= + * This file is part of types-c++ + * ========================================================================= + * + * (C) Copyright 2004 - 2014, MDA Information Systems LLC + * (C) Copyright 2023, Maxar Technologies, Inc. + * + * types-c++ is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this program; If not, + * see . + * + */ + +#pragma once +#ifndef CODA_OSS_types_Complex_h_INCLUDED_ +#define CODA_OSS_types_Complex_h_INCLUDED_ + +#include + +#include +#include +#include + +#include "config/disable_compiler_warnings.h" +#include "coda_oss/CPlusPlus.h" + +namespace types +{ +/*! + * \class Complex + * \brief Our own implementation of std::complex for SIX and friends. + * + * `std::complex` is no longer valid C++; provide a (partial) work-around. + * See https://en.cppreference.com/w/cpp/numeric/complex for details. + * + * SIX (and others) mostly use `std::complex` as a convenient + * package for two values; very little "complex math" is done using integers. + */ +template +struct Complex final +{ + using value_type = T; + static_assert(!std::is_floating_point::value, "Use std::complex for floating-point."); + static_assert(std::is_signed::value, "T should be a signed integer."); + + Complex(value_type re = 0, value_type im = 0) : z{re, im} { } + Complex(const Complex&) = default; + Complex& operator=(const Complex&) = default; + Complex(Complex&&) = default; + Complex& operator=(Complex&&) = default; + ~Complex() = default; + + // If someone already has a std::complex, is there any harm in creating ours? + Complex(const std::complex& other) : Complex(other.real(), other.imag()) { } + Complex& operator=(const std::complex& other) + { + real(other.real()); + imag(other.imag()); + return *this; + } + + #if defined(CODA_OSS_types_Complex_implicit_cast) || defined(_SILENCE_NONFLOATING_COMPLEX_DEPRECATION_WARNING) + CODA_OSS_disable_warning_push + #ifdef _MSC_VER + #pragma warning(disable : 4996) // '...': warning STL4037: The effect of instantiating the template std::complex for any type other than float, double, or long double is unspecified. You can define _SILENCE_NONFLOATING_COMPLEX_DEPRECATION_WARNING to suppress this warning. + #endif + // Better interop with existing code? Creates ambiguities? + operator const std::complex&() const + { + const void* const pThis = this; + return *static_cast*>(pThis); + } + operator std::complex&() + { + void* const pThis = this; + return *static_cast*>(pThis); + } + CODA_OSS_disable_warning_pop + #endif // CODA_OSS_types_Complex_implicit_cast || _SILENCE_NONFLOATING_COMPLEX_DEPRECATION_WARNING + + value_type real() const + { + return z[0]; + } + void real(value_type value) + { + z[0] = value; + } + + value_type imag() const + { + return z[1]; + } + void imag(value_type value) + { + z[1] = value; + } + +private: + value_type z[2]{0, 0}; +}; + +namespace details +{ +CODA_OSS_disable_warning_push +#ifdef _MSC_VER +#pragma warning(disable : 4996) // '...': warning STL4037: The effect of instantiating the template std::complex for any type other than float, double, or long double is unspecified. You can define _SILENCE_NONFLOATING_COMPLEX_DEPRECATION_WARNING to suppress this warning. +#endif +// Getting different results with GCC vs MSVC :-( So just use +// std::complex Assume by the time we're actually using C++23 with a +// compiler that enforces this restriction, "something" will be different. +template +inline const std::complex& cast(const Complex& z) +{ + const void* const pZ_ = &z; + return *static_cast*>(pZ_); +} +template +inline std::complex& cast(Complex& z) +{ + void* const pZ_ = &z; + return *static_cast*>(pZ_); +} +CODA_OSS_disable_warning_pop +} + +// https://en.cppreference.com/w/cpp/numeric/complex/operator_ltltgtgt +template +inline auto& operator<<(std::basic_ostream& o, const Complex& z) +{ + return o << details::cast(z); +} +template +inline auto& operator>>(std::basic_istream& o, Complex& z) +{ + return o >> details::cast(z); +} + +// https://en.cppreference.com/w/cpp/numeric/complex/operator_cmp +template +inline bool operator==(const Complex& lhs, const Complex& rhs) +{ + return (lhs.real() == rhs.real()) && (lhs.imag() == rhs.imag()); +} +template +inline bool operator!=(const Complex& lhs, const Complex& rhs) +{ + return !(lhs == rhs); +} + +// Keep functions like abs() to a minimum; complex math probably shouldn't be done with integers. +template +inline auto abs(const Complex& z) // https://en.cppreference.com/w/cpp/numeric/complex/abs +{ + return abs(details::cast(z)); +} + +// Control whether ComplexInteger is std::complex or Complex. +// If it is std::complex, then a types::ComplexInteger overload normally can't be +// used as it will be the same as std::complex +#ifdef CODA_OSS_types_FORCE_unique_ComplexInteger // bypass checks below +#define CODA_OSS_types_unique_ComplexInteger 1 +#endif +#ifdef CODA_OSS_types_NO_unique_ComplexInteger +#ifdef CODA_OSS_types_unique_ComplexInteger +#error "CODA_OSS_types_unique_ComplexInteger already #define'd" +#endif +#define CODA_OSS_types_unique_ComplexInteger 0 +#endif + +#ifndef CODA_OSS_types_unique_ComplexInteger +// If the warning about using std::complex has been turned off, we might +// as well use std:complex. +#ifdef _SILENCE_NONFLOATING_COMPLEX_DEPRECATION_WARNING +#define CODA_OSS_types_unique_ComplexInteger 0 +#endif +#endif + +#ifndef CODA_OSS_types_unique_ComplexInteger +#define CODA_OSS_types_unique_ComplexInteger 1 +#endif + +template +#if CODA_OSS_types_unique_ComplexInteger +using ComplexInteger = Complex; +#else +using ComplexInteger = std::complex; +#endif + +namespace details +{ +// This circumlocution is to prevent clients from doing `ComplexReal`. +// (And also to use the word "circumlocution." :-) ) +template struct ComplexReal +{ + static_assert(std::is_floating_point::value, "T must be floating-point."); + using type = std::complex; +}; +} // namespace details +template +using ComplexReal = typename details::ComplexReal::type; + +// This might be more trouble than it's worth: there really isn't that much code +// that is generic for both integer and real complex types; recall that the primary +// use of `std::complex` is a "convenient package" for two values. +// +//Have the compiler pick between std::complex and Complex +//template +//using complex = std::conditional_t::value, ComplexReal, ComplexInteger>; +static_assert(sizeof(std::complex) == sizeof(Complex), "sizeof(sizeof(std::complex) != sizeof(Complex)"); +static_assert(std::is_same, ComplexReal>::value, "should be std::complex"); + +// Convenient aliases +using zfloat = ComplexReal; // i.e., std::complex +using zdouble = ComplexReal; // i.e., std::complex +//using zlong_double = ComplexReal; // i.e., std::complex +using zint8_t = ComplexInteger; // Complex +using zint16_t = ComplexInteger; // Complex +using zint32_t = ComplexInteger; // Complex +using zint64_t = ComplexInteger; // Complex +} + +#endif // CODA_OSS_types_Complex_h_INCLUDED_ diff --git a/modules/c++/types/include/types/PageRowCol.h b/modules/c++/types/include/types/PageRowCol.h index 1900d23d6..5c4b5ce28 100644 --- a/modules/c++/types/include/types/PageRowCol.h +++ b/modules/c++/types/include/types/PageRowCol.h @@ -52,7 +52,7 @@ struct PageRowCol // especially when doing scalar operations that might otherwise // create ambiguities PageRowCol() : - page((T)0.0), row((T)0.0), col((T)0.0) {} + page(static_cast(0.0)), row(static_cast(0.0)), col(static_cast(0.0)) {} PageRowCol(T p, T r, T c) : @@ -61,17 +61,17 @@ struct PageRowCol template explicit PageRowCol(const PageRowCol& p) { - page = (T)p.page; - row = (T)p.row; - col = (T)p.col; + page = static_cast(p.page); + row = static_cast(p.row); + col = static_cast(p.col); } template PageRowCol(Other_T1 p, const RowCol& rc) { - page = (T)p; - row = (T)rc.row; - col = (T)rc.col; + page = static_cast(p); + row = static_cast(rc.row); + col = static_cast(rc.col); } template @@ -79,9 +79,9 @@ struct PageRowCol { if (this != (PageRowCol*)&p) { - page = (T)p.page; - row = (T)p.row; - col = (T)p.col; + page = static_cast(p.page); + row = static_cast(p.row); + col = static_cast(p.col); } return *this; } @@ -89,9 +89,9 @@ struct PageRowCol template PageRowCol& operator+=(const PageRowCol& p) { - page += (T)p.page; - row += (T)p.row; - col += (T)p.col; + page += static_cast(p.page); + row += static_cast(p.row); + col += static_cast(p.col); return *this; } @@ -105,9 +105,9 @@ struct PageRowCol template PageRowCol& operator*=(const PageRowCol& p) { - page *= (T)p.page; - row *= (T)p.row; - col *= (T)p.col; + page *= static_cast(p.page); + row *= static_cast(p.row); + col *= static_cast(p.col); return *this; } @@ -121,9 +121,9 @@ struct PageRowCol template PageRowCol& operator-=(const PageRowCol& p) { - page -= (T)p.page; - row -= (T)p.row; - col -= (T)p.col; + page -= static_cast(p.page); + row -= static_cast(p.row); + col -= static_cast(p.col); return *this; } @@ -137,9 +137,9 @@ struct PageRowCol template PageRowCol& operator/=(const PageRowCol& p) { - page /= (T)p.page; - row /= (T)p.row; - col /= (T)p.col; + page /= static_cast(p.page); + row /= static_cast(p.row); + col /= static_cast(p.col); return *this; } diff --git a/modules/c++/types/include/types/RowCol.h b/modules/c++/types/include/types/RowCol.h index 1b55265ca..e13f125a2 100644 --- a/modules/c++/types/include/types/RowCol.h +++ b/modules/c++/types/include/types/RowCol.h @@ -50,9 +50,8 @@ namespace types template class RowCol { template - static U cast(const Other_T& t) + static U cast(const Other_T& t) noexcept { - //return static_cast(t); return gsl::narrow_cast(t); } diff --git a/modules/c++/types/unittests/test_complex.cpp b/modules/c++/types/unittests/test_complex.cpp new file mode 100644 index 000000000..01fe012f0 --- /dev/null +++ b/modules/c++/types/unittests/test_complex.cpp @@ -0,0 +1,59 @@ +/* ========================================================================= + * This file is part of types-c++ + * ========================================================================= + * + * (C) Copyright 2004 - 2017, MDA Information Systems LLC + * + * types-c++ is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this program; If not, + * see . + * + */ + +#include "TestCase.h" + +#include + +TEST_CASE(TestCxShort_abs) +{ + constexpr auto real = 123; + constexpr auto imag = -321; + + CODA_OSS_disable_warning_push + #ifdef _MSC_VER + #pragma warning(disable: 4996) // '...': warning STL4037: The effect of instantiating the template std::complex for any type other than float, double, or long double is unspecified. You can define _SILENCE_NONFLOATING_COMPLEX_DEPRECATION_WARNING to suppress this warning. + #endif + const std::complex cx_short(real, imag); + CODA_OSS_disable_warning_pop + const auto expected = abs(cx_short); + + CODA_OSS_disable_warning_push + #ifdef _MSC_VER + #pragma warning(disable: 4996) // '...': warning STL4037: The effect of instantiating the template std::complex for any type other than float, double, or long double is unspecified. You can define _SILENCE_NONFLOATING_COMPLEX_DEPRECATION_WARNING to suppress this warning. + #endif + const types::zint16_t types_zint16(cx_short); + CODA_OSS_disable_warning_pop + auto actual = abs(types_zint16); + TEST_ASSERT_EQ(actual, expected); + + const types::ComplexInteger types_cx_int16(cx_short); + actual = abs(types_cx_int16); + TEST_ASSERT_EQ(actual, expected); + + // This intentionally doesn't compile. + //const auto types::ComplexReal ComplexReal_short; +} + +TEST_MAIN( + TEST_CHECK(TestCxShort_abs); + ) diff --git a/modules/c++/types/unittests/test_page_row_col.cpp b/modules/c++/types/unittests/test_page_row_col.cpp index edf926bab..a2e6702cb 100644 --- a/modules/c++/types/unittests/test_page_row_col.cpp +++ b/modules/c++/types/unittests/test_page_row_col.cpp @@ -97,8 +97,8 @@ TEST_CASE(TestPageRowColDouble) pageRowColAssign.page += std::numeric_limits::epsilon() * 2.0; TEST_ASSERT(pageRowColAssign != pageRowColA); - TEST_ASSERT_EQ(pageRowColA.volume(), 3.1 * 5.2 * 11.3); - TEST_ASSERT_EQ(pageRowColA.normL2(), std::sqrt(3.1 * 3.1 + 5.2 * 5.2 + 11.3 * 11.3)); + TEST_ASSERT_ALMOST_EQ(pageRowColA.volume(), 3.1 * 5.2 * 11.3); + TEST_ASSERT_ALMOST_EQ(pageRowColA.normL2(), std::sqrt(3.1 * 3.1 + 5.2 * 5.2 + 11.3 * 11.3)); // test arithmetic operators const types::PageRowCol sum = pageRowColA + pageRowColB; diff --git a/modules/c++/types/wscript b/modules/c++/types/wscript index c5134be79..eb974e3b8 100644 --- a/modules/c++/types/wscript +++ b/modules/c++/types/wscript @@ -1,6 +1,6 @@ NAME = 'types' VERSION = '1.0' -MODULE_DEPS = 'gsl' +MODULE_DEPS = 'coda_oss config gsl' UNITTEST_DEPS = 'sys' options = configure = distclean = lambda p: None diff --git a/modules/c++/unique/source/UUID.cpp b/modules/c++/unique/source/UUID.cpp index 682dac843..0a79a77d9 100644 --- a/modules/c++/unique/source/UUID.cpp +++ b/modules/c++/unique/source/UUID.cpp @@ -32,7 +32,7 @@ std::string unique::generateUUID() { #ifdef _WIN32 GUID uuid; - unsigned char *cResult = NULL; + unsigned char* cResult = nullptr; if ((UuidCreateSequential (&uuid) != RPC_S_OK) || (UuidToString(&uuid, &cResult) != RPC_S_OK)) diff --git a/modules/c++/unique/wscript b/modules/c++/unique/wscript index ffaf6c723..bd30e6da7 100644 --- a/modules/c++/unique/wscript +++ b/modules/c++/unique/wscript @@ -1,5 +1,4 @@ NAME = 'unique' -MAINTAINER = 'jmrandol@users.sourceforge.net' VERSION = '1.0' MODULE_DEPS = 'except' USELIB = 'RPC' diff --git a/modules/c++/xml.lite/include/import/xml/lite.h b/modules/c++/xml.lite/include/import/xml/lite.h index 477e27c80..b7b66bca8 100644 --- a/modules/c++/xml.lite/include/import/xml/lite.h +++ b/modules/c++/xml.lite/include/import/xml/lite.h @@ -20,39 +20,9 @@ * */ +#pragma once #ifndef CODA_OSS_xml_lite_import_lite_h_INCLUDED_ #define CODA_OSS_xml_lite_import_lite_h_INCLUDED_ -#pragma once - -#if _MSC_VER -#pragma warning(push) -// these are from Xerces -#pragma warning(disable: 5219) // implicit conversion from '...' to '...', possible loss of data -#pragma warning(disable: 4365) // '...': conversion from '...' to '...', signed / unsigned mismatch -#pragma warning(disable: 26477) // Use 'nullptr' rather than 0 or NULL (es.47). -#pragma warning(disable: 26493) // Don't use C-style casts (type.4). -#pragma warning(disable: 26814) // The const variable '...' can be computed at compile-time. Consider using constexpr (con.5). -#pragma warning(disable: 26496) // The variable '...' does not change after construction, mark it as const (con.4). -#pragma warning(disable: 26497) // The function '...' could be marked constexpr if compile-time evaluation is desired (f.4). -#pragma warning(disable: 26475) // Do not use function style casts (es.49). Prefer '...' over '...'. -#pragma warning(disable: 26495) // Variable '...' is uninitialized. Always initialize a member variable (type.6). -#pragma warning(disable: 26461) // The pointer argument '...' for function '...' can be marked as a pointer to const (con.3). -#pragma warning(disable: 26462) // The value pointed to by '...' is assigned only once, mark it as a pointer to const (con.4). -#pragma warning(disable: 26494) // Variable '...' is uninitialized. Always initialize an object (type.5). -#pragma warning(disable: 26489) // Don't dereference a pointer that may be invalid: '...'. '...' may have been invalidated at line ... (lifetime.1). -#pragma warning(disable: 26488) // Do not dereference a potentially null pointer : ...'. '...' was null at line ... (lifetime.1). -#pragma warning(disable: 26447) // The function is declared '...' but calls function '..' which may throw exceptions (f.6). -#pragma warning(disable: 26485) // Expression '...': No array to pointer decay (bounds.3). -#pragma warning(disable: 26457) // (void) should not be used to ignore return values, use '...' instead (es.48). -#pragma warning(disable: 26487) // Don't return a pointer '...' that may be invalid (lifetime.4). -#pragma warning(disable: 26451) // Arithmetic overflow : Using operator '...' on a 4 byte value and then casting the result to a 8 byte value. Cast the value to the wider type before calling operator '...' to avoid overflow (io.2). -#pragma warning(disable: 26455) // Default constructor may not throw.Declare it 'noexcept' (f.6). -#pragma warning(disable: 26409) // Avoid calling new and delete explicitly, use std::make_unique instead (r.11). -#pragma warning(disable: 26429) // Symbol '...' is never tested for nullness, it can be marked as not_null(f.23). -#pragma warning(disable: 26400) // Do not assign the result of an allocation or a function call with an owner return value to a raw pointer, use owner instead(i.11). -#pragma warning(disable: 26467) // Converting from floating point to unsigned integral types results in non-portable code if the double/float has a negative value. Use gsl::narrow_cast or gsl::narrow instead to guard against undefined behavior and potential data loss (es.46). -#pragma warning(disable: 26823) // Dereferencing a possibly null pointer '...' (lifetime.1). -#endif // _MSC_VER #include "xml/lite/ContentHandler.h" #include "xml/lite/Attributes.h" @@ -67,16 +37,6 @@ #include "xml/lite/Serializable.h" #include "xml/lite/Validator.h" -#if _MSC_VER -#pragma warning(pop) - -#pragma comment(lib, "xml.lite-c++.lib") - -#if defined(USE_XERCES) -#pragma comment(lib, "xerces-c") -#endif -#endif - /*! * \file lite.h * diff --git a/modules/c++/xml.lite/include/xml/lite/Attributes.h b/modules/c++/xml.lite/include/xml/lite/Attributes.h index 8b354844b..8dac07f8f 100644 --- a/modules/c++/xml.lite/include/xml/lite/Attributes.h +++ b/modules/c++/xml.lite/include/xml/lite/Attributes.h @@ -20,19 +20,21 @@ * */ +#pragma once #ifndef CODA_OSS_xml_lite_Attributes_h_INCLUDED_ #define CODA_OSS_xml_lite_Attributes_h_INCLUDED_ -#pragma once #include #include +#include + #include "sys/Conf.h" #include "except/Exception.h" -#include "xml/lite/QName.h" #include "str/Convert.h" #include "gsl/gsl.h" +#include "xml/lite/QName.h" /*! * \file Attributes.h * \brief Implementation of SAX 2.0 Attributes @@ -55,7 +57,7 @@ namespace lite * internal organs. We have a URI, a QName, and a local part * as well. We also need a value, of course. */ -struct AttributeNode final +struct CODA_OSS_API AttributeNode final { AttributeNode() = default; @@ -158,7 +160,7 @@ struct AttributeNode final * this data structure everywhere. That also allows us to * simplify future dom classes */ -struct Attributes final +struct CODA_OSS_API Attributes final { typedef std::vector Attributes_T; //! Default constructor @@ -217,6 +219,10 @@ struct Attributes final { return static_cast(size()); } + bool empty() const + { + return mAttributes.empty(); + } /*! * Look up an attribute's local name by index. @@ -396,6 +402,16 @@ struct Attributes final { mAttributes.clear(); } + + auto begin() const + { + return mAttributes.begin(); + } + auto end() const + { + return mAttributes.end(); + } + private: //! Underlying representation Attributes_T mAttributes; diff --git a/modules/c++/xml.lite/include/xml/lite/ContentHandler.h b/modules/c++/xml.lite/include/xml/lite/ContentHandler.h index 9e03adeae..f7e8da6f0 100644 --- a/modules/c++/xml.lite/include/xml/lite/ContentHandler.h +++ b/modules/c++/xml.lite/include/xml/lite/ContentHandler.h @@ -20,9 +20,9 @@ * */ +#pragma once #ifndef CODA_OSS_xml_lite_ContentHandler_h_INCLUDED_ #define CODA_OSS_xml_lite_ContentHandler_h_INCLUDED_ -#pragma once #include #include @@ -30,6 +30,8 @@ #include #include +#include + #include "xml/lite/QName.h" // Uri #include "xml/lite/Attributes.h" @@ -68,12 +70,12 @@ namespace lite * which should increase performance and efficiency. */ -class ContentHandler +class CODA_OSS_API ContentHandler { protected: //! Constructor ContentHandler() = default; - virtual ~ContentHandler() = default; + virtual ~ContentHandler() noexcept(false) {} public: //! Receive notification of the beginning of a document. diff --git a/modules/c++/xml.lite/include/xml/lite/Document.h b/modules/c++/xml.lite/include/xml/lite/Document.h index 1d53fdbab..6d6bdf266 100644 --- a/modules/c++/xml.lite/include/xml/lite/Document.h +++ b/modules/c++/xml.lite/include/xml/lite/Document.h @@ -20,9 +20,9 @@ * */ +#pragma once #ifndef CODA_OSS_xml_lite_Doocument_h_INCLUDED_ #define CODA_OSS_xml_lite_Doocument_h_INCLUDED_ -#pragma once /*! * \file Document.h @@ -39,9 +39,10 @@ #include #include -#include +#include #include "coda_oss/string.h" -#include "coda_oss/memory.h" + +#include #include "xml/lite/Element.h" #include "xml/lite/QName.h" @@ -57,7 +58,7 @@ namespace lite * Use the Document to access the Element nodes contained within. * The DocumentParser will build a tree that you can use. */ -struct Document // SOAPDocument derives :-( +struct CODA_OSS_API Document // SOAPDocument derives :-( { //! Constructor Document(Element* rootNode = nullptr, bool own = true) : diff --git a/modules/c++/xml.lite/include/xml/lite/Element.h b/modules/c++/xml.lite/include/xml/lite/Element.h index 911a50f86..14e23a900 100644 --- a/modules/c++/xml.lite/include/xml/lite/Element.h +++ b/modules/c++/xml.lite/include/xml/lite/Element.h @@ -20,9 +20,9 @@ * */ +#pragma once #ifndef CODA_OSS_xml_lite_Element_h_INCLUDED_ #define CODA_OSS_xml_lite_Element_h_INCLUDED_ -#pragma once #include #include @@ -30,15 +30,17 @@ #include #include +#include #include #include #include #include +#include "sys/Conf.h" +#include "mem/SharedPtr.h" + #include "xml/lite/XMLException.h" #include "xml/lite/Attributes.h" #include "xml/lite/QName.h" -#include "sys/Conf.h" -#include "mem/SharedPtr.h" /*! * \file Element.h @@ -63,7 +65,7 @@ struct AttributeNode; * This class stores all of the element information about an XML * document. */ -struct Element // SOAPElement derives :-( +struct CODA_OSS_API Element // SOAPElement derives :-( { Element() = default; @@ -597,28 +599,28 @@ inline Element* addNewOptionalElement(const xml::lite::QName& name, const coda_o #endif // SWIG -Element& setChild(Element&, std::unique_ptr&&); // destroyChildren() + addChild() +CODA_OSS_API Element& setChild(Element&, std::unique_ptr&&); // destroyChildren() + addChild() -void operator+=(Element&, std::unique_ptr&&); // addChild() +CODA_OSS_API void operator+=(Element&, std::unique_ptr&&); // addChild() -Element& addChild(Element&, const std::string& qname); -void operator+=(Element&, const std::string& qname); // addChild() -Element& addChild(Element&, const xml::lite::QName&); // there is also a QName in the xerces namespace -void operator+=(Element&, const xml::lite::QName&); // addChild() -Element& addChild(Element&, const std::string& qname, const coda_oss::u8string& characterData); +CODA_OSS_API Element& addChild(Element&, const std::string& qname); +CODA_OSS_API void operator+=(Element&, const std::string& qname); // addChild() +CODA_OSS_API Element& addChild(Element&, const xml::lite::QName&); // there is also a QName in the xerces namespace +CODA_OSS_API void operator+=(Element&, const xml::lite::QName&); // addChild() +CODA_OSS_API Element& addChild(Element&, const std::string& qname, const coda_oss::u8string& characterData); Element& addChild(Element&, const std::string&, const std::string&) = delete; // NO, order matters! -Element& addChild(Element&, const xml::lite::QName&, const coda_oss::u8string& characterData); -Element& addChild(Element&, const xml::lite::QName&, const std::string& characterData); -Element& addChild(Element&, const std::string& qname, const xml::lite::Uri&); -Element& addChild(Element&, const std::string& qname, const xml::lite::Uri&, const coda_oss::u8string& characterData); - -coda_oss::u8string getCharacterData(const Element&); - -xml::lite::AttributeNode& addAttribute(Element&, const xml::lite::AttributeNode&); -void operator+=(Element&, const xml::lite::AttributeNode&); // addAttribute() -xml::lite::AttributeNode& addAttribute(Element&, const std::string& qname); -xml::lite::AttributeNode& addAttribute(Element&, const xml::lite::QName&); -xml::lite::AttributeNode& addAttribute(Element&, const xml::lite::QName&, const std::string& value); +CODA_OSS_API Element& addChild(Element&, const xml::lite::QName&, const coda_oss::u8string& characterData); +CODA_OSS_API Element& addChild(Element&, const xml::lite::QName&, const std::string& characterData); +CODA_OSS_API Element& addChild(Element&, const std::string& qname, const xml::lite::Uri&); +CODA_OSS_API Element& addChild(Element&, const std::string& qname, const xml::lite::Uri&, const coda_oss::u8string& characterData); + +CODA_OSS_API coda_oss::u8string getCharacterData(const Element&); + +CODA_OSS_API xml::lite::AttributeNode& addAttribute(Element&, const xml::lite::AttributeNode&); +CODA_OSS_API void operator+=(Element&, const xml::lite::AttributeNode&); // addAttribute() +CODA_OSS_API xml::lite::AttributeNode& addAttribute(Element&, const std::string& qname); +CODA_OSS_API xml::lite::AttributeNode& addAttribute(Element&, const xml::lite::QName&); +CODA_OSS_API xml::lite::AttributeNode& addAttribute(Element&, const xml::lite::QName&, const std::string& value); xml::lite::AttributeNode& addAttribute(Element&, const std::string&, const std::string&) = delete; // NO, order matters! } diff --git a/modules/c++/xml.lite/include/xml/lite/MinidomHandler.h b/modules/c++/xml.lite/include/xml/lite/MinidomHandler.h index 9ff2089bb..ac9590662 100644 --- a/modules/c++/xml.lite/include/xml/lite/MinidomHandler.h +++ b/modules/c++/xml.lite/include/xml/lite/MinidomHandler.h @@ -20,9 +20,9 @@ * */ +#pragma once #ifndef CODA_OSS_xml_lite_MinidomHandler_h_INCLUDED_ #define CODA_OSS_xml_lite_MinidomHandler_h_INCLUDED_ -#pragma once /*! * \file MinidomHandler.h @@ -46,10 +46,10 @@ */ #include -#include +#include #include "coda_oss/string.h" -#include "coda_oss/memory.h" +#include #include "str/EncodedString.h" #include "str/EncodedStringView.h" #include "XMLReader.h" @@ -69,7 +69,7 @@ namespace lite * whether it is allocated externally or not. DONT delete it * explicitly unless you are looking for disaster. */ -struct MinidomHandler final : public ContentHandler +struct CODA_OSS_API MinidomHandler final : public ContentHandler { //! Constructor. Uses default document MinidomHandler() @@ -78,7 +78,7 @@ struct MinidomHandler final : public ContentHandler } //! Destructor - ~ MinidomHandler() + ~MinidomHandler() noexcept(false) { setDocument(nullptr, true); } diff --git a/modules/c++/xml.lite/include/xml/lite/MinidomParser.h b/modules/c++/xml.lite/include/xml/lite/MinidomParser.h index a701e70dd..9fd151ab1 100644 --- a/modules/c++/xml.lite/include/xml/lite/MinidomParser.h +++ b/modules/c++/xml.lite/include/xml/lite/MinidomParser.h @@ -20,12 +20,13 @@ * */ +#pragma once #ifndef CODA_OSS_xml_lite_MinidomParser_h_INCLUDED_ #define CODA_OSS_xml_lite_MinidomParser_h_INCLUDED_ -#pragma once #include +#include #include "xml/lite/XMLReader.h" #include "xml/lite/Document.h" @@ -56,7 +57,7 @@ namespace lite * bloat of the spec. It was inspired by python's xml.dom.minidom * module. */ -struct MinidomParser // SOAPParser inherits :-( +struct CODA_OSS_API MinidomParser // SOAPParser inherits :-( { /*! * Constructor. Set our SAX ContentHandler. diff --git a/modules/c++/xml.lite/include/xml/lite/QName.h b/modules/c++/xml.lite/include/xml/lite/QName.h index d095cdea1..b537b5262 100644 --- a/modules/c++/xml.lite/include/xml/lite/QName.h +++ b/modules/c++/xml.lite/include/xml/lite/QName.h @@ -20,11 +20,11 @@ * */ +#pragma once #ifndef CODA_OSS_xml_lite_QName_h_INCLLUDED_ #define CODA_OSS_xml_lite_QName_h_INCLLUDED_ -#pragma once -/*! + /*! * \file QName.h * \brief A Qualified name (includes the namespace stuff) * @@ -42,7 +42,10 @@ #include #include +#include + #include "sys/OS.h" +#include "str/Manip.h" namespace xml { @@ -65,7 +68,7 @@ namespace lite * to a namespace URI */ -struct Uri final // help prevent mixups with std::string +struct CODA_OSS_API Uri final // help prevent mixups with std::string { Uri(); explicit Uri(const std::string& v); // validate=false @@ -78,11 +81,13 @@ struct Uri final // help prevent mixups with std::string }; inline bool operator==(const Uri& lhs, const Uri& rhs) { - return lhs.value == rhs.value; + // URIs are "supposed to be" case-insenstive + return str::eq(lhs.value, rhs.value); } inline bool operator!=(const Uri& lhs, const Uri& rhs) { - return !(lhs == rhs); + // URIs are "supposed to be" case-insenstive + return str::ne(lhs.value, rhs.value); } inline std::ostream& operator<<(std::ostream& os, const Uri& uri) { @@ -90,7 +95,7 @@ inline std::ostream& operator<<(std::ostream& os, const Uri& uri) return os; } -class QName final +class CODA_OSS_API QName final { //! Prefix (Qualified) std::string mPrefix; diff --git a/modules/c++/xml.lite/include/xml/lite/Serializable.h b/modules/c++/xml.lite/include/xml/lite/Serializable.h index a1e486447..3a6da62e5 100644 --- a/modules/c++/xml.lite/include/xml/lite/Serializable.h +++ b/modules/c++/xml.lite/include/xml/lite/Serializable.h @@ -58,7 +58,7 @@ struct Serializable : public io::Serializable } //! Destructor - virtual ~Serializable() {} + virtual ~Serializable() noexcept(false) {} Serializable(const Serializable&) = delete; Serializable& operator=(const Serializable&) = delete; @@ -94,13 +94,13 @@ struct Serializable : public io::Serializable * Transfer this object into a byte stream * \param os The object to serialize this to */ - virtual void serialize(io::OutputStream& os); + void serialize(io::OutputStream& os) override; /*! * Unpack this input stream to the object * \param is Stream to read object from */ - virtual void deserialize(io::InputStream& is); + void deserialize(io::InputStream& is) override; protected: //! The parser diff --git a/modules/c++/xml.lite/include/xml/lite/UtilitiesXerces.h b/modules/c++/xml.lite/include/xml/lite/UtilitiesXerces.h index ba587a91b..ef2039123 100644 --- a/modules/c++/xml.lite/include/xml/lite/UtilitiesXerces.h +++ b/modules/c++/xml.lite/include/xml/lite/UtilitiesXerces.h @@ -20,6 +20,7 @@ * */ +#pragma once #ifndef CODA_OSS_xml_lite_UtilitiesXerces_h_INCLUDED_ #define CODA_OSS_xml_lite_UtilitiesXerces_h_INCLUDED_ @@ -30,34 +31,7 @@ #include #include "config/compiler_extensions.h" -#include "xml/lite/xml_lite_config.h" - -#if defined(USE_XERCES) - -CODA_OSS_disable_warning_system_header_push -#include -#include -#include -#include -#include -#include - -#include -#include - -#include - -#include -#include -#include -#include -#include -#include - -#include -#include - -CODA_OSS_disable_warning_pop +#include "config/Exports.h" #include #include @@ -66,6 +40,10 @@ CODA_OSS_disable_warning_pop #include #include +#include +#if defined(USE_XERCES) +#include "xerces_.h" + #include "xml/lite/XMLException.h" #include "xml/lite/ContentHandler.h" #include "xml/lite/Attributes.h" @@ -429,7 +407,7 @@ struct XercesErrorHandler final : public XercesErrorHandlerInterface_T * \class XercesContext * \brief This class safely creates and destroys Xerces */ -struct XercesContext final +struct CODA_OSS_API XercesContext final { //! Constructor XercesContext(); diff --git a/modules/c++/xml.lite/include/xml/lite/ValidatorInterface.h b/modules/c++/xml.lite/include/xml/lite/ValidatorInterface.h index c8066b1b1..4e50656ef 100644 --- a/modules/c++/xml.lite/include/xml/lite/ValidatorInterface.h +++ b/modules/c++/xml.lite/include/xml/lite/ValidatorInterface.h @@ -20,9 +20,9 @@ * */ +#pragma once #ifndef CODA_OSS_xml_lite_ValidatorInterface_h_INCLUDED_ #define CODA_OSS_xml_lite_ValidatorInterface_h_INCLUDED_ -#pragma once /*! * \file ValidatorInterface.h @@ -35,14 +35,17 @@ #include #include +#include + +#include #include #include #include #include +#include + #include #include -#include -#include namespace xml { @@ -94,7 +97,7 @@ struct ValidationInfo final * * This class is the interface for schema validators */ -class ValidatorInterface +class CODA_OSS_API ValidatorInterface { public: @@ -184,4 +187,4 @@ inline std::ostream& operator<< (std::ostream& out, } } -#endif // CODA_OSS_xml_lite_ValidatorInterface_h_INCLUDED_ \ No newline at end of file +#endif // CODA_OSS_xml_lite_ValidatorInterface_h_INCLUDED_ diff --git a/modules/c++/xml.lite/include/xml/lite/ValidatorXerces.h b/modules/c++/xml.lite/include/xml/lite/ValidatorXerces.h index 8942aaf57..8d5d79ba0 100644 --- a/modules/c++/xml.lite/include/xml/lite/ValidatorXerces.h +++ b/modules/c++/xml.lite/include/xml/lite/ValidatorXerces.h @@ -20,30 +20,22 @@ * */ +#pragma once #ifndef CODA_OSS_xml_lite_ValidatorXerces_h_INCLUDED_ #define CODA_OSS_xml_lite_ValidatorXerces_h_INCLUDED_ -#include - -#ifdef USE_XERCES - #include #include #include -#include -#include +#include "config/Exports.h" -#include -#include -#include -#include -#include -#include +#include +#ifdef USE_XERCES +#include "xerces_.h" -#include -#include -#include +#include +#include namespace xml { @@ -97,7 +89,7 @@ struct ValidationErrorHandler final : public xercesc::DOMErrorHandler * * This class is the Xercesc schema validator */ -class ValidatorXerces : public ValidatorInterface +class CODA_OSS_API ValidatorXerces : public ValidatorInterface { XercesContext mCtxt; //! this must be the first member listed @@ -137,6 +129,9 @@ class ValidatorXerces : public ValidatorInterface bool validate(const coda_oss::u8string&, const std::string& xmlID, std::vector&) const override; bool validate(const str::W1252string&, const std::string& xmlID, std::vector&) const override; + // Search each directory for XSD files + static std::vector loadSchemas(const std::vector& schemaPaths, bool recursive=true); + private: bool validate_(const coda_oss::u8string& xml, const std::string& xmlID, diff --git a/modules/c++/xml.lite/include/xml/lite/XMLReaderInterface.h b/modules/c++/xml.lite/include/xml/lite/XMLReaderInterface.h index c0540b8cb..f39bb47ea 100644 --- a/modules/c++/xml.lite/include/xml/lite/XMLReaderInterface.h +++ b/modules/c++/xml.lite/include/xml/lite/XMLReaderInterface.h @@ -20,17 +20,21 @@ * */ -#ifndef __XML_LITE_ABSTRACT_XML_READER_H__ -#define __XML_LITE_ABSTRACT_XML_READER_H__ +#pragma once +#ifndef CODA_OSS_xml_lite_XMLReaderInterface_h_INCLUDED_ +#define CODA_OSS_xml_lite_XMLReaderInterface_h_INCLUDED_ #include + +#include + #include "XMLException.h" namespace xml { namespace lite { -class XMLReaderInterface : public io::OutputStream +class CODA_OSS_API XMLReaderInterface : public io::OutputStream { public: @@ -77,4 +81,4 @@ class XMLReaderInterface : public io::OutputStream } } -#endif +#endif // CODA_OSS_xml_lite_XMLReaderInterface_h_INCLUDED_ diff --git a/modules/c++/xml.lite/include/xml/lite/XMLReaderXerces.h b/modules/c++/xml.lite/include/xml/lite/XMLReaderXerces.h index 52b78befb..a808be8d8 100644 --- a/modules/c++/xml.lite/include/xml/lite/XMLReaderXerces.h +++ b/modules/c++/xml.lite/include/xml/lite/XMLReaderXerces.h @@ -20,6 +20,7 @@ * */ +#pragma once #ifndef CODA_OSS_xml_lite_XMLReaderXerces_h_INCLUDED_ #define CODA_OSS_xml_lite_XMLReaderXerces_h_INCLUDED_ @@ -29,6 +30,8 @@ #include +#include + #include #include #include @@ -56,7 +59,7 @@ namespace lite * the Expat C Parser underneath, and wiring it to * generic event calls, via the content handler. */ -class XMLReaderXerces final : public XMLReaderInterface +class CODA_OSS_API XMLReaderXerces final : public XMLReaderInterface { XercesContext mCtxt; //! this must be the first member listed std::unique_ptr mNative; diff --git a/modules/c++/xml.lite/include/xml/lite/xerces_.h b/modules/c++/xml.lite/include/xml/lite/xerces_.h new file mode 100644 index 000000000..b35fc4714 --- /dev/null +++ b/modules/c++/xml.lite/include/xml/lite/xerces_.h @@ -0,0 +1,102 @@ +/* ========================================================================= + * This file is part of xml.lite-c++ + * ========================================================================= + * + * (C) Copyright 2004 - 2014, MDA Information Systems LLC + * + * xml.lite-c++ is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this program; If not, + * see . + * + */ + +#pragma once +#ifndef CODA_OSS_xml_lite_xerces_h_INCLUDED_ +#define CODA_OSS_xml_lite_xerces_h_INCLUDED_ + +#include "config/compiler_extensions.h" +#include + +#if defined(USE_XERCES) + +CODA_OSS_disable_warning_system_header_push +#if _MSC_VER +#pragma warning(disable: 26493) // Don't use C-style casts (type.4). +#pragma warning(disable: 26494) // Variable '...' is uninitialized. Always initialize an object (type.5). +#pragma warning(disable: 26451) // Arithmetic overflow: Using operator '...' on a 4 byte value and then casting the result to a 8 byte value. Cast the value to the wider type before calling operator '...' to avoid overflow (io.2). +#pragma warning(disable: 26814) // The const variable '...' can be computed at compile-time. Consider using constexpr (con.5). +#pragma warning(disable: 26447) // The function is declared '...' but calls function '...' which may throw exceptions (f.6). +#pragma warning(disable: 26455) // Default constructor should not throw. Declare it '...' (f.6). +#pragma warning(disable: 26440) // Function '...' can be declared '...' (f.6). +#pragma warning(disable: 26496) // The variable '...' does not change after construction, mark it as const (con.4). +#pragma warning(disable: 26462) // The value pointed to by '...' is assigned only once, mark it as a pointer to const (con.4). +#pragma warning(disable: 26435) // Function '...' should specify exactly one of '...', '...', or '...' (c.128). +#pragma warning(disable: 26433) // Function '...' should be marked with '...' (c.128). +#pragma warning(disable: 26497) // You can attempt to make '...' constexpr unless it contains any undefined behavior (f.4). +#pragma warning(disable: 26433) // Function '...' should be marked with '...' (c.128). +#pragma warning(disable: 26456) // Operator '...' hides a non-virtual operator '...' (c.128). +#pragma warning(disable: 26446) // Prefer to use gsl::at() instead of unchecked subscript operator (bounds.4). +#pragma warning(disable: 26488) // Do not dereference a potentially null pointer: '...'. '...' was null at line 133 (lifetime.1). +#pragma warning(disable : 26477) // Use '...' rather than 0 or NULL(es .47). +#pragma warning(disable: 26457) // (void) should not be used to ignore return values, use '...' instead (es.48). +#pragma warning(disable: 26475) // Do not use function style casts (es.49). Prefer '...' over '...'.. +#else +CODA_OSS_disable_warning(-Wshadow) +CODA_OSS_disable_warning(-Wsuggest-override) +CODA_OSS_disable_warning(-Wzero-as-null-pointer-constant) +CODA_OSS_disable_warning(-Wmisleading-indentation) +CODA_OSS_disable_warning(-Wsign-compare) +CODA_OSS_disable_warning(-Wformat-overflow=) +CODA_OSS_disable_warning(-Wunused-value) +CODA_OSS_disable_warning(-Walloc-size-larger-than=) +#endif + +#include +#include + +#include +#include +#include + +#include +#include +#include +#include +#include +#include + +#include +#include + +#include +#include + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +CODA_OSS_disable_warning_pop + +#endif + +#endif // CODA_OSS_xml_lite_xerces_h_INCLUDED_ + diff --git a/modules/c++/xml.lite/source/Document.cpp b/modules/c++/xml.lite/source/Document.cpp index 20fec58da..3e61a3af7 100644 --- a/modules/c++/xml.lite/source/Document.cpp +++ b/modules/c++/xml.lite/source/Document.cpp @@ -43,7 +43,7 @@ void xml::lite::Document::remove(Element * toDelete) { if (mRootNode && mOwnRoot) delete mRootNode; - mRootNode = NULL; + mRootNode = nullptr; } else remove(toDelete, mRootNode); @@ -88,14 +88,14 @@ std::unique_ptr xml::lite::Document::createElement(const QNa void xml::lite::Document::insert(xml::lite::Element * element, xml::lite::Element * underThis) { - if (element != NULL && underThis != NULL) + if (element != nullptr && underThis != nullptr) underThis->addChild(element); } void xml::lite::Document::remove(xml::lite::Element * toDelete, xml::lite::Element * fromHere) { - if (fromHere != NULL && toDelete != NULL) + if (fromHere != nullptr && toDelete != nullptr) { for (std::vector::iterator i = fromHere->getChildren().begin(); i @@ -105,7 +105,7 @@ void xml::lite::Document::remove(xml::lite::Element * toDelete, { fromHere->getChildren().erase(i); delete toDelete; - toDelete = NULL; + toDelete = nullptr; return; } else diff --git a/modules/c++/xml.lite/source/Element.cpp b/modules/c++/xml.lite/source/Element.cpp index 143db237b..150588e5e 100644 --- a/modules/c++/xml.lite/source/Element.cpp +++ b/modules/c++/xml.lite/source/Element.cpp @@ -19,6 +19,7 @@ * see . * */ +#include "xml/lite/Element.h" #include @@ -26,7 +27,6 @@ #include #include -#include "xml/lite/Element.h" #include #include #include @@ -69,7 +69,7 @@ void xml::lite::Element::clone(const xml::lite::Element& node) *this = node; clearChildren(); - mParent = NULL; + mParent = nullptr; std::vector::const_iterator iter; iter = node.getChildren().begin(); @@ -111,6 +111,7 @@ void xml::lite::Element::getElementsByTagName(const QName& n, std::vectorgetUri() == uri && mChildren[i]->getLocalName() @@ -163,6 +164,7 @@ void xml::lite::Element::getElementsByTagName(const std::string& localName, std::vector& elements, bool recurse) const { + elements.reserve(mChildren.size()); for (unsigned int i = 0; i < mChildren.size(); i++) { if (mChildren[i]->getLocalName() == localName) @@ -192,6 +194,7 @@ void xml::lite::Element::getElementsByTagNameNS(const std::string& qname, std::vector& elements, bool recurse) const { + elements.reserve(mChildren.size()); for (unsigned int i = 0; i < mChildren.size(); i++) { if (mChildren[i]->mName.toString() == qname) @@ -270,19 +273,18 @@ coda_oss::u8string xml::lite::getCharacterData(const Element& e) return e.getCharacterData(retval); } -static void writeCharacterData(io::OutputStream& stream, const std::u8string& characterData, bool isConsoleOutput) +static void writeCharacterData_utf8(io::OutputStream& stream, const std::u8string& characterData) { - if (!isConsoleOutput) - { - stream.write(characterData); // call UTF-8 overload - } - else - { - stream.write(str::EncodedStringView(characterData).native()); // write to the console using the platform native encoding - } + stream.write(characterData); // call UTF-8 overload +} +static void writeCharacterData_native(io::OutputStream& stream, const std::u8string& characterData) +{ + stream.write(str::EncodedStringView(characterData).native()); } -void xml::lite::Element::depthPrint(io::OutputStream& stream, int depth, const std::string& formatter, bool isConsoleOutput) const +static void depthPrint_(const xml::lite::Element& element, + io::OutputStream& stream, int depth, const std::string& formatter, + void(*writeCharacterData)(io::OutputStream&, const std::u8string&)) { // XML must be stored in UTF-8 (or UTF-16/32), in particular, not Windows-1252. // @@ -297,20 +299,24 @@ void xml::lite::Element::depthPrint(io::OutputStream& stream, int depth, const s // Printing in XML form, recursively std::string lBrack = "<"; - std::string rBrack = ">"; + static const std::string rBrack = ">"; - std::string acc = prefix + lBrack + mName.toString(); + const auto name = element.getQName(); + std::string acc = prefix + lBrack + name; - for (int i = 0; i < mAttributes.getLength(); i++) + auto&& attributes = element.getAttributes(); + for (int i = 0; i < attributes.getLength(); i++) { acc += std::string(" "); - acc += mAttributes.getQName(i); + acc += attributes.getQName(i); acc += std::string("=\""); - acc += mAttributes.getValue(i); + acc += attributes.getValue(i); acc += std::string("\""); } - if (mCharacterData.empty() && mChildren.empty()) + const auto characterData = getCharacterData(element); + auto&& children = element.getChildren(); + if (characterData.empty() && children.empty()) { //simple type - just end it here stream.write(acc + "/" + rBrack); @@ -318,24 +324,30 @@ void xml::lite::Element::depthPrint(io::OutputStream& stream, int depth, const s else { stream.write(acc + rBrack); - writeCharacterData(stream, mCharacterData, isConsoleOutput); + writeCharacterData(stream, characterData); - for (unsigned int i = 0; i < mChildren.size(); i++) + for (auto&& child: children) { if (!formatter.empty()) stream.write("\n"); - mChildren[i]->depthPrint(stream, depth + 1, formatter, isConsoleOutput); + depthPrint_(*child, stream, depth + 1, formatter, writeCharacterData); } - if (!mChildren.empty() && !formatter.empty()) + if (!children.empty() && !formatter.empty()) { stream.write("\n" + prefix); } lBrack += "/"; - stream.write(lBrack + mName.toString() + rBrack); + stream.write(lBrack + name + rBrack); } } +void xml::lite::Element::depthPrint(io::OutputStream& stream, int depth, const std::string& formatter, bool isConsoleOutput) const +{ + const auto f = isConsoleOutput ? writeCharacterData_native // write to the console using the platform native encoding + : writeCharacterData_utf8; + depthPrint_(*this, stream, depth, formatter, f); +} void xml::lite::Element::addChild(xml::lite::Element * node) { diff --git a/modules/c++/xml.lite/source/MinidomHandler.cpp b/modules/c++/xml.lite/source/MinidomHandler.cpp index fe33084b7..3e2e1334c 100644 --- a/modules/c++/xml.lite/source/MinidomHandler.cpp +++ b/modules/c++/xml.lite/source/MinidomHandler.cpp @@ -34,7 +34,7 @@ void xml::lite::MinidomHandler::setDocument(Document *newDocument, bool own) { - if (mDocument != NULL && mOwnDocument) + if (mDocument != nullptr && mOwnDocument) { if (newDocument != mDocument) delete mDocument; diff --git a/modules/c++/xml.lite/source/NamespaceStack.cpp b/modules/c++/xml.lite/source/NamespaceStack.cpp index 4ab047112..998b41ba5 100644 --- a/modules/c++/xml.lite/source/NamespaceStack.cpp +++ b/modules/c++/xml.lite/source/NamespaceStack.cpp @@ -64,6 +64,7 @@ void xml::lite::NamespaceStack::getMapping(const std::string& prefix, Uri& resul void xml::lite::NamespaceStack:: getAllPrefixes(std::vector& allPrefixes) const { + allPrefixes.reserve(mMappingStack.size()); for (unsigned int i = 0; i < mMappingStack.size(); i++) { allPrefixes.push_back(mMappingStack[i].first); diff --git a/modules/c++/xml.lite/source/QName.cpp b/modules/c++/xml.lite/source/QName.cpp index 1893cf4a3..5ce60dfff 100644 --- a/modules/c++/xml.lite/source/QName.cpp +++ b/modules/c++/xml.lite/source/QName.cpp @@ -19,10 +19,10 @@ * see . * */ +#include "xml/lite/QName.h" #include -#include "xml/lite/QName.h" #include "str/Manip.h" std::string xml::lite::QName::getName() const diff --git a/modules/c++/xml.lite/source/Serializable.cpp b/modules/c++/xml.lite/source/Serializable.cpp index c03969ee3..27cb7aaf0 100644 --- a/modules/c++/xml.lite/source/Serializable.cpp +++ b/modules/c++/xml.lite/source/Serializable.cpp @@ -25,9 +25,11 @@ void xml::lite::Serializable::serialize(io::OutputStream& os) { xml::lite::Element *root = getDocument()->getRootElement(); - if (root != NULL) + if (root != nullptr) + { os.write("\n"); - root->print(os); + root->print(os); + } } void xml::lite::Serializable::deserialize(io::InputStream& is) diff --git a/modules/c++/xml.lite/source/ValidatorXerces.cpp b/modules/c++/xml.lite/source/ValidatorXerces.cpp index 7657e7b8a..cc1a1b516 100644 --- a/modules/c++/xml.lite/source/ValidatorXerces.cpp +++ b/modules/c++/xml.lite/source/ValidatorXerces.cpp @@ -26,12 +26,20 @@ #include #include #include +#include // std::ignore + +#include +#include +CODA_OSS_disable_warning_push +#ifndef _MSC_VER +CODA_OSS_disable_warning(-Wshadow) +#endif +#include +CODA_OSS_disable_warning_pop #include #include #include -#include -#include namespace fs = std::filesystem; @@ -89,6 +97,14 @@ inline std::vector convert(const std::vector& schemaPaths [](const fs::path& p) { return p.string(); }); return retval; } +inline auto convert(const std::vector& paths) +{ + std::vector retval; + std::transform(paths.begin(), paths.end(), std::back_inserter(retval), + [](const auto& p) { return p; }); + return retval; +} + ValidatorXerces::ValidatorXerces( const std::vector& schemaPaths, logging::Logger* log, @@ -117,7 +133,7 @@ ValidatorXerces::ValidatorXerces( xercesc::DOMImplementationRegistry:: getDOMImplementation (ls_id)->createLSParser( xercesc::DOMImplementationLS::MODE_SYNCHRONOUS, - 0, + nullptr, xercesc::XMLPlatformUtils::fgMemoryManager, mSchemaPool.get())); @@ -154,19 +170,18 @@ ValidatorXerces::ValidatorXerces( // load our schemas -- // search each directory for schemas - sys::OS os; - std::vector schemas = - os.search(schemaPaths, "", ".xsd", recursive); + const auto schemas = loadSchemas(convert(schemaPaths), recursive); // add the schema to the validator - for (size_t i = 0; i < schemas.size(); ++i) + // add the schema to the validator + for (auto&& schema : schemas) { - if (!mValidator->loadGrammar(schemas[i].c_str(), + if (!mValidator->loadGrammar(schema.c_str(), xercesc::Grammar::SchemaGrammarType, true)) { std::ostringstream oss; - oss << "Error: Failure to load schema " << schemas[i]; + oss << "Error: Failure to load schema " << schema; log->warn(Ctxt(oss.str())); } } @@ -175,6 +190,14 @@ ValidatorXerces::ValidatorXerces( mSchemaPool->lockPool(); } +std::vector ValidatorXerces::loadSchemas(const std::vector& schemaPaths, bool recursive) +{ + // load our schemas -- + // search each directory for schemas + sys::OS os; + return os.search(schemaPaths, "", ".xsd", recursive); +} + // From config.h.in: Define to the 16 bit type used to represent Xerces UTF-16 characters // On Windows, this needs to be wchar_t so that various "wide character" Win32 APIs can be called. static_assert(sizeof(XMLCh) == 2, "XMLCh should be two bytes for UTF-16."); diff --git a/modules/c++/xml.lite/source/XMLReaderXerces.cpp b/modules/c++/xml.lite/source/XMLReaderXerces.cpp index 3ecf8d79f..a776842d9 100644 --- a/modules/c++/xml.lite/source/XMLReaderXerces.cpp +++ b/modules/c++/xml.lite/source/XMLReaderXerces.cpp @@ -19,6 +19,7 @@ * see . * */ +#include "xml/lite/XMLReaderXerces.h" #include diff --git a/modules/c++/xml.lite/unittests/test_soapelements.cpp b/modules/c++/xml.lite/unittests/test_soapelements.cpp index 55de517a9..e1ec61504 100644 --- a/modules/c++/xml.lite/unittests/test_soapelements.cpp +++ b/modules/c++/xml.lite/unittests/test_soapelements.cpp @@ -25,7 +25,12 @@ #include "xml/lite/Document.h" #include "xml/lite/Element.h" #include "xml/lite/QName.h" -static const std::string test_text = "SOAP Test"; + +static const std::string& test_text() +{ + static const std::string retval = "SOAP Test"; + return retval; +} struct SOAPBody final : public xml::lite::Element { @@ -44,7 +49,7 @@ struct SOAP final : public xml::lite::Document const xml::lite::QName asQName(uri, qname); xml::lite::Element* elem = new SOAPBody(asQName); elem->setCharacterData(characterData); // avoid unused parameter warning - elem->setCharacterData(test_text); + elem->setCharacterData(test_text()); return elem; } }; @@ -55,8 +60,8 @@ TEST_CASE(test_overrideCreateElement) std::unique_ptr a(soap_test.createElement("a","b","Not SOAP Test")); auto b = dynamic_cast(a.get()); TEST_ASSERT_NOT_NULL(b); - TEST_ASSERT_EQ(a->getCharacterData(), test_text); - TEST_ASSERT_EQ(b->getCharacterData(), test_text); + TEST_ASSERT_EQ(a->getCharacterData(), test_text()); + TEST_ASSERT_EQ(b->getCharacterData(), test_text()); } TEST_MAIN diff --git a/modules/c++/xml.lite/unittests/test_xmlattribute.cpp b/modules/c++/xml.lite/unittests/test_xmlattribute.cpp index 011bb79d1..8df82c970 100644 --- a/modules/c++/xml.lite/unittests/test_xmlattribute.cpp +++ b/modules/c++/xml.lite/unittests/test_xmlattribute.cpp @@ -28,18 +28,31 @@ #include "xml/lite/MinidomParser.h" #include "xml/lite/QName.h" -static const std::string strUri = "urn:example.com"; -static const xml::lite::Uri uri(strUri); -static const std::string strXml_1_ = R"( +static const std::string& strUri() +{ + static const std::string retval("urn:example.com"); + return retval; +} +static const xml::lite::Uri& uri() +{ + static const xml::lite::Uri retval(strUri()); + return retval; +} + +static const auto& strXml() +{ + static const std::string strXml_1_ = R"( TEXT + static const std::string strXml_2_ = R"(" ns:int="314" /> )"; -static const auto strXml = strXml_1_ + strUri + strXml_2_; + static const auto retval = strXml_1_ + strUri() + strXml_2_; + return retval; +} struct test_MinidomParser final { @@ -47,7 +60,7 @@ struct test_MinidomParser final xml::lite::Element* getRootElement() { io::StringStream ss; - ss.stream() << strXml; + ss.stream() << strXml(); xmlParser.parse(ss); return getDocument(xmlParser).getRootElement(); @@ -88,19 +101,19 @@ TEST_CASE(test_getAttributeByNS) using namespace xml::lite; std::string strValue; - strValue = attributes.getValue(xml::lite::QName(uri, "int")); + strValue = attributes.getValue(xml::lite::QName(uri(), "int")); TEST_ASSERT_EQ("314", strValue); - strValue = getValue(attributes, uri, "int"); + strValue = getValue(attributes, uri(), "int"); TEST_ASSERT_EQ("314", strValue); - const auto key = xml::lite::QName(uri, "int"); + const auto key = xml::lite::QName(uri(), "int"); strValue = getValue(attributes, key); TEST_ASSERT_EQ("314", strValue); int value; - auto result = getValue(attributes, uri, "int", value); + auto result = getValue(attributes, uri(), "int", value); TEST_ASSERT_TRUE(result); TEST_ASSERT_EQ(314, value); - value = getValue(attributes, uri, "int"); + value = getValue(attributes, uri(), "int"); TEST_ASSERT_EQ(314, value); result = getValue(attributes, key, value); diff --git a/modules/c++/xml.lite/unittests/test_xmlelement.cpp b/modules/c++/xml.lite/unittests/test_xmlelement.cpp index a9890ab00..0c252e12a 100644 --- a/modules/c++/xml.lite/unittests/test_xmlelement.cpp +++ b/modules/c++/xml.lite/unittests/test_xmlelement.cpp @@ -37,12 +37,18 @@ #define U8(s) static_cast(static_cast(s)) #endif -static const std::string text = "TEXT"; -static const std::string strXml1_ = R"( +static const std::string& text() +{ + static const std::string retval("TEXT"); + return retval; +} +static const auto& strXml() +{ + static const std::string strXml1_ = R"( )"; -static const std::string strXml2_ = R"( + static const std::string strXml2_ = R"( 314 3.14 @@ -51,7 +57,9 @@ static const std::string strXml2_ = R"( )"; -static const auto strXml = strXml1_ + text + strXml2_; + static const auto retval = strXml1_ + text() + strXml2_; + return retval; +} struct test_MinidomParser final { @@ -59,7 +67,7 @@ struct test_MinidomParser final const xml::lite::Element& getRootElement() const { io::StringStream ss; - ss.stream() << strXml; + ss.stream() << strXml(); xmlParser.parse(ss); return xml::lite::getRootElement(xmlParser.getDocument()); @@ -67,7 +75,7 @@ struct test_MinidomParser final xml::lite::Element& getRootElement() { io::StringStream ss; - ss.stream() << strXml; + ss.stream() << strXml(); xmlParser.parse(ss); return xml::lite::getRootElement(xmlParser.getDocument()); @@ -77,8 +85,8 @@ struct test_MinidomParser final TEST_CASE(test_getRootElement) { io::StringStream ss; - ss.stream() << strXml; - TEST_ASSERT_EQ(ss.stream().str(), strXml); + ss.stream() << strXml(); + TEST_ASSERT_EQ(ss.stream().str(), strXml()); xml::lite::MinidomParser xmlParser; xmlParser.parse(ss); @@ -97,7 +105,7 @@ TEST_CASE(test_getElementsByTagName) const auto& a = *(aElements[0]); const auto characterData = a.getCharacterData(); - TEST_ASSERT_EQ(characterData, text); + TEST_ASSERT_EQ(characterData, text()); } const auto docElements = root.getElementsByTagName("doc"); @@ -109,7 +117,7 @@ TEST_CASE(test_getElementsByTagName) const auto& a = *(aElements[0]); const auto characterData = a.getCharacterData(); - TEST_ASSERT_EQ(characterData, text); + TEST_ASSERT_EQ(characterData, text()); } } @@ -148,14 +156,14 @@ TEST_CASE(test_getElementByTagName) { const auto& a = root.getElementByTagName("a", true /*recurse*/); const auto characterData = a.getCharacterData(); - TEST_ASSERT_EQ(characterData, text); + TEST_ASSERT_EQ(characterData, text()); } const auto& doc = root.getElementByTagName("doc"); { const auto& a = doc.getElementByTagName("a"); const auto characterData = a.getCharacterData(); - TEST_ASSERT_EQ(characterData, text); + TEST_ASSERT_EQ(characterData, text()); } } diff --git a/modules/c++/xml.lite/unittests/test_xmlparser.cpp b/modules/c++/xml.lite/unittests/test_xmlparser.cpp index 6a4ff8bf1..b0e88e33b 100644 --- a/modules/c++/xml.lite/unittests/test_xmlparser.cpp +++ b/modules/c++/xml.lite/unittests/test_xmlparser.cpp @@ -43,22 +43,71 @@ static inline std::u8string fromUtf8(const std::string& utf8) return str::EncodedStringView::fromUtf8(utf8).u8string(); } -static const std::string text("TEXT"); -static const std::string strXml = "" + text + ""; -static const std::u8string text8 = fromUtf8(text); +static const std::string& text() +{ + static const std::string retval("TEXT"); + return retval; +} +static const std::string& strXml() +{ + static const std::string retval = "" + text() + ""; + return retval; +} +static const std::u8string& text8() +{ + static const auto retval = fromUtf8(text()); + return retval; +} + +static const str::EncodedString& iso88591Text() +{ + static const str::EncodedString retval(str::cast("T\xc9XT")); // ISO8859-1, "TÉXT" + return retval; +} +static const auto& iso88591Text1252() +{ + static const auto retval = str::EncodedStringView::details::w1252string(iso88591Text().view()); + return retval; +} +static auto pIso88591Text_() +{ + static const auto retval = str::c_str(iso88591Text1252()); + return retval; +} -static const str::EncodedString iso88591Text(str::cast("T\xc9XT")); // ISO8859-1, "TÉXT" -static const auto iso88591Text1252 = str::EncodedStringView::details::w1252string(iso88591Text.view()); -static const auto pIso88591Text_ = str::c_str(iso88591Text1252); +static const str::EncodedString& utf8Text() +{ + static const str::EncodedString retval(str::cast("T\xc3\x89XT")); // UTF-8, "TÉXT" + return retval; +} -static const str::EncodedString utf8Text(str::cast("T\xc3\x89XT")); // UTF-8, "TÉXT" -static const auto utf8Text8 = utf8Text.u8string(); -static const auto pUtf8Text_ = str::c_str(utf8Text8); +static const auto& utf8Text8() +{ + static const auto retval = utf8Text().u8string(); + return retval; +} +static const auto pUtf8Text_() +{ + static const auto retval = str::c_str(utf8Text8()); + return retval; +} -static const auto strUtf8Xml8 = fromUtf8("") + utf8Text8 + fromUtf8(""); -static const std::string strUtf8Xml = str::c_str(strUtf8Xml8); +static const auto& strUtf8Xml8() +{ + static const auto retval = fromUtf8("") + utf8Text8() + fromUtf8(""); + return retval; +} +static const std::string& strUtf8Xml() +{ + static const std::string retval = str::c_str(strUtf8Xml8()); + return retval; +} -static const std::string platfromText_ = sys::Platform == sys::PlatformType::Windows ? pIso88591Text_ : pUtf8Text_; +static const std::string platfromText_() +{ + static const std::string retval = sys::Platform == sys::PlatformType::Windows ? pIso88591Text_() : pUtf8Text_(); + return retval; +} static std::filesystem::path find_unittest_file(const std::filesystem::path& name) { @@ -73,13 +122,13 @@ static void test_a_element(const std::string& testName, const xml::lite::Element const auto& a = *(aElements[0]); const auto characterData = a.getCharacterData(); - TEST_ASSERT_EQ(characterData, text); + TEST_ASSERT_EQ(characterData, text()); } TEST_CASE(testXmlParseSimple) { io::StringStream ss; - ss.stream() << strXml; - TEST_ASSERT_EQ(ss.stream().str(), strXml); + ss.stream() << strXml(); + TEST_ASSERT_EQ(ss.stream().str(), strXml()); xml::lite::MinidomParser xmlParser; xmlParser.parse(ss); @@ -95,8 +144,8 @@ TEST_CASE(testXmlParseSimple) TEST_CASE(testXmlPreserveCharacterData) { io::StringStream stream; - stream.stream() << strUtf8Xml; - TEST_ASSERT_EQ(stream.stream().str(), strUtf8Xml); + stream.stream() << strUtf8Xml(); + TEST_ASSERT_EQ(stream.stream().str(), strUtf8Xml()); xml::lite::MinidomParser xmlParser; // This is needed in Windows, because the default locale is *.1252 (more-or-less ISO8859-1) @@ -111,7 +160,7 @@ TEST_CASE(testXmlPreserveCharacterData) static xml::lite::Element& testXmlUtf8_(xml::lite::MinidomParser& xmlParser) { io::StringStream stream; - stream.stream() << strUtf8Xml; + stream.stream() << strUtf8Xml(); xmlParser.preserveCharacterData(true); xmlParser.parse(stream); @@ -127,7 +176,7 @@ TEST_CASE(testXmlUtf8_u8string) const auto& a = testXmlUtf8_(xmlParser); const auto actual = getCharacterData(a); - TEST_ASSERT_EQ(actual, utf8Text8); + TEST_ASSERT_EQ(actual, utf8Text8()); } TEST_CASE(testXmlUtf8) @@ -136,7 +185,7 @@ TEST_CASE(testXmlUtf8) const auto& a = testXmlUtf8_(xmlParser); auto actual = a.getCharacterData(); - const auto expected = platfromText_; + const auto expected = platfromText_(); TEST_ASSERT_EQ(actual, expected); } @@ -144,7 +193,7 @@ TEST_CASE(testXml_setCharacterData) { xml::lite::MinidomParser xmlParser; auto& a = testXmlUtf8_(xmlParser); - a.setCharacterData(utf8Text8); + a.setCharacterData(utf8Text8()); TEST_ASSERT_TRUE(true); // need to use hidden "testName" parameter } @@ -163,7 +212,7 @@ static std::string testXmlPrint_(std::string& expected, const std::string& chara TEST_CASE(testXmlPrintSimple) { std::string expected; - const auto actual = testXmlPrint_(expected, text); + const auto actual = testXmlPrint_(expected, text()); TEST_ASSERT_EQ(actual, expected); } @@ -177,12 +226,12 @@ TEST_CASE(testXmlPrintUtf8) { static const xml::lite::QName root(xml::lite::Uri(), "root"); - const auto expected = std::string("") + pUtf8Text_ + ""; + const auto expected = std::string("") + pUtf8Text_() + ""; { xml::lite::MinidomParser xmlParser; auto& document = getDocument(xmlParser); - const auto s8_w1252 = fromWindows1252(pIso88591Text_); + const auto s8_w1252 = fromWindows1252(pIso88591Text_()); const auto pRootElement = document.createElement(root, s8_w1252); io::StringStream output; @@ -194,7 +243,7 @@ TEST_CASE(testXmlPrintUtf8) xml::lite::MinidomParser xmlParser; auto& document = getDocument(xmlParser); - const auto pRootElement = document.createElement(root, utf8Text8); + const auto pRootElement = document.createElement(root, utf8Text8()); io::StringStream output; pRootElement->print(output); @@ -205,7 +254,7 @@ TEST_CASE(testXmlPrintUtf8) xml::lite::MinidomParser xmlParser; auto& document = getDocument(xmlParser); - const auto pRootElement = document.createElement(root, platfromText_); + const auto pRootElement = document.createElement(root, platfromText_()); io::StringStream output; pRootElement->print(output); @@ -218,12 +267,12 @@ TEST_CASE(testXmlConsoleOutput) { static const xml::lite::QName root(xml::lite::Uri(), "root"); - const auto expected = "" + platfromText_ + ""; + const auto expected = "" + platfromText_() + ""; { xml::lite::MinidomParser xmlParser; auto& document = getDocument(xmlParser); - const auto s8_w1252 = fromWindows1252(pIso88591Text_); + const auto s8_w1252 = fromWindows1252(pIso88591Text_()); const auto pRootElement = document.createElement(root, s8_w1252); io::StringStream output; @@ -235,7 +284,7 @@ TEST_CASE(testXmlConsoleOutput) xml::lite::MinidomParser xmlParser; auto& document = getDocument(xmlParser); - const auto pRootElement = document.createElement(root, utf8Text8); + const auto pRootElement = document.createElement(root, utf8Text8()); io::StringStream output; pRootElement->consoleOutput_(output); @@ -246,7 +295,7 @@ TEST_CASE(testXmlConsoleOutput) xml::lite::MinidomParser xmlParser; auto& document = getDocument(xmlParser); - const auto pRootElement = document.createElement(root, platfromText_); + const auto pRootElement = document.createElement(root, platfromText_()); io::StringStream output; pRootElement->consoleOutput_(output); @@ -258,7 +307,7 @@ TEST_CASE(testXmlConsoleOutput) TEST_CASE(testXmlParseAndPrintUtf8) { io::StringStream input; - input.stream() << strUtf8Xml; + input.stream() << strUtf8Xml(); xml::lite::MinidomParser xmlParser; xmlParser.preserveCharacterData(true); @@ -268,7 +317,7 @@ TEST_CASE(testXmlParseAndPrintUtf8) io::StringStream output; pRootElement->print(output); const auto actual = output.stream().str(); - TEST_ASSERT_EQ(actual, strUtf8Xml); + TEST_ASSERT_EQ(actual, strUtf8Xml()); } static void testReadEncodedXmlFile(const std::string& testName, const std::string& xmlFile, bool preserveCharacterData, @@ -308,12 +357,12 @@ static void testReadEncodedXmlFile(const std::string& testName, const std::strin TEST_CASE(testReadEncodedXmlFiles) { // these have "" - testReadEncodedXmlFile(testName, "encoding_utf-8.xml", true /*preserveCharacterData*/, platfromText_ , utf8Text8); - testReadEncodedXmlFile(testName, "encoding_utf-8.xml", false /*preserveCharacterData*/, platfromText_ , utf8Text8); - testReadEncodedXmlFile(testName, "encoding_windows-1252.xml", true /*preserveCharacterData*/, platfromText_ , utf8Text8); - testReadEncodedXmlFile(testName, "encoding_windows-1252.xml", false /*preserveCharacterData*/, platfromText_ , utf8Text8); - testReadEncodedXmlFile(testName, "ascii_encoding_utf-8.xml", true /*preserveCharacterData*/, text , text8); - testReadEncodedXmlFile(testName, "ascii_encoding_utf-8.xml", false /*preserveCharacterData*/, text , text8); + testReadEncodedXmlFile(testName, "encoding_utf-8.xml", true /*preserveCharacterData*/, platfromText_() , utf8Text8()); + testReadEncodedXmlFile(testName, "encoding_utf-8.xml", false /*preserveCharacterData*/, platfromText_(), utf8Text8()); + testReadEncodedXmlFile(testName, "encoding_windows-1252.xml", true /*preserveCharacterData*/, platfromText_(), utf8Text8()); + testReadEncodedXmlFile(testName, "encoding_windows-1252.xml", false /*preserveCharacterData*/, platfromText_(), utf8Text8()); + testReadEncodedXmlFile(testName, "ascii_encoding_utf-8.xml", true /*preserveCharacterData*/, text() , text8()); + testReadEncodedXmlFile(testName, "ascii_encoding_utf-8.xml", false /*preserveCharacterData*/, text(), text8()); } static void testReadXmlFile(const std::string& testName, const std::string& xmlFile, bool preserveCharacterData, @@ -357,12 +406,12 @@ static void testReadXmlFile(const std::string& testName, const std::string& xmlF TEST_CASE(testReadXmlFiles) { // These do NOT have "" - testReadXmlFile(testName, "utf-8.xml", true /*preserveCharacterData*/, platfromText_ , utf8Text8); - testReadXmlFile(testName, "utf-8.xml", false /*preserveCharacterData*/, platfromText_ , utf8Text8); - testReadXmlFile(testName, "windows-1252.xml", true /*preserveCharacterData*/, platfromText_ , utf8Text8); - testReadXmlFile(testName, "windows-1252.xml", false /*preserveCharacterData*/, platfromText_ , utf8Text8); - testReadXmlFile(testName, "ascii.xml", true /*preserveCharacterData*/, text , text8); - testReadXmlFile(testName, "ascii.xml", false /*preserveCharacterData*/, text , text8); + testReadXmlFile(testName, "utf-8.xml", true /*preserveCharacterData*/, platfromText_() , utf8Text8()); + testReadXmlFile(testName, "utf-8.xml", false /*preserveCharacterData*/, platfromText_(), utf8Text8()); + testReadXmlFile(testName, "windows-1252.xml", true /*preserveCharacterData*/, platfromText_(), utf8Text8()); + testReadXmlFile(testName, "windows-1252.xml", false /*preserveCharacterData*/, platfromText_(), utf8Text8()); + testReadXmlFile(testName, "ascii.xml", true /*preserveCharacterData*/, text(), text8()); + testReadXmlFile(testName, "ascii.xml", false /*preserveCharacterData*/, text(), text8()); } static bool find_string(io::FileInputStream& stream, const std::string& s) diff --git a/modules/c++/zip/include/zip/GZipInputStream.h b/modules/c++/zip/include/zip/GZipInputStream.h index 783b6241f..b96f3f32a 100644 --- a/modules/c++/zip/include/zip/GZipInputStream.h +++ b/modules/c++/zip/include/zip/GZipInputStream.h @@ -20,8 +20,11 @@ * */ -#ifndef __ZIP_GZIP_INPUT_STREAM_H__ -#define __ZIP_GZIP_INPUT_STREAM_H__ +#pragma once +#ifndef CODA_OSS_zip_GZipInputStream_h_INCLUDED_ +#define CODA_OSS_zip_GZipInputStream_h_INCLUDED_ + +#include "config/Exports.h" #include "zip/Types.h" @@ -38,7 +41,7 @@ namespace zip * argument is given, and in a loop. On the last run, the buffer * size should will probably smaller than the amount requested. */ -class GZipInputStream: public io::InputStream +class CODA_OSS_API GZipInputStream : public io::InputStream { gzFile mFile; public: @@ -63,5 +66,4 @@ class GZipInputStream: public io::InputStream }; } -#endif - +#endif // CODA_OSS_zip_GZipInputStream_h_INCLUDED_ diff --git a/modules/c++/zip/include/zip/GZipOutputStream.h b/modules/c++/zip/include/zip/GZipOutputStream.h index 7f137d2cf..6c08d8d6e 100644 --- a/modules/c++/zip/include/zip/GZipOutputStream.h +++ b/modules/c++/zip/include/zip/GZipOutputStream.h @@ -20,8 +20,11 @@ * */ -#ifndef __ZIP_GZIP_OUTPUT_STREAM_H__ -#define __ZIP_GZIP_OUTPUT_STREAM_H__ +#pragma once +#ifndef CODA_OSS_zip_GZipOutputStream_h_INCLUDED_ +#define CODA_OSS_zip_GZipOutputStream_h_INCLUDED_ + +#include "config/Exports.h" #include "zip/Types.h" @@ -32,7 +35,7 @@ namespace zip * \brief IO wrapper for zlib API * */ -class GZipOutputStream: public io::OutputStream +class CODA_OSS_API GZipOutputStream : public io::OutputStream { gzFile mFile; public: @@ -56,4 +59,4 @@ class GZipOutputStream: public io::OutputStream }; } -#endif +#endif // CODA_OSS_zip_GZipOutputStream_h_INCLUDED_ \ No newline at end of file diff --git a/modules/c++/zip/source/GZipInputStream.cpp b/modules/c++/zip/source/GZipInputStream.cpp index 2fa47bcda..9a3fd3b39 100644 --- a/modules/c++/zip/source/GZipInputStream.cpp +++ b/modules/c++/zip/source/GZipInputStream.cpp @@ -27,7 +27,7 @@ using namespace zip; GZipInputStream::GZipInputStream(const std::string& file) { mFile = gzopen(file.c_str(), "rb"); - if (mFile == NULL) + if (mFile == nullptr) { throw except::IOException(Ctxt( "Failed to open gzip stream [" + file + "]")); @@ -37,7 +37,7 @@ GZipInputStream::GZipInputStream(const std::string& file) void GZipInputStream::close() { gzclose( mFile); - mFile = NULL; + mFile = nullptr; } sys::SSize_T GZipInputStream::readImpl(void* buffer, size_t len) diff --git a/modules/c++/zip/source/GZipOutputStream.cpp b/modules/c++/zip/source/GZipOutputStream.cpp index b14e540f8..6c83a1fdf 100644 --- a/modules/c++/zip/source/GZipOutputStream.cpp +++ b/modules/c++/zip/source/GZipOutputStream.cpp @@ -27,7 +27,7 @@ using namespace zip; GZipOutputStream::GZipOutputStream(const std::string& file) { mFile = gzopen(file.c_str(), "wb"); - if (mFile == NULL) + if (mFile == nullptr) { throw except::IOException(Ctxt( "Failed to open gzip stream [" + file + "]")); @@ -59,5 +59,5 @@ void GZipOutputStream::write(const void* buffer, size_t len) void GZipOutputStream::close() { gzclose( mFile); - mFile = NULL; + mFile = nullptr; } diff --git a/modules/c++/zip/source/ZipEntry.cpp b/modules/c++/zip/source/ZipEntry.cpp index 9f71cbef3..4c9352672 100644 --- a/modules/c++/zip/source/ZipEntry.cpp +++ b/modules/c++/zip/source/ZipEntry.cpp @@ -29,7 +29,7 @@ const static char* sZipFileMadeByStr[] = { "OpenVMS", "UNIX", "VM/CMS", "Atari ST", "OS/2 H.P.F.S.", "Macintosh", "Z-System", "CP/M", "Windows NTFS", "MVS (OS/390 - Z/OS)", "VSE", "Acorn Risc", "VFAT", "alternative MVS", "BeOS", "Tandem", "OS/400", - "OS/X (Darwin)", NULL }; + "OS/X (Darwin)", nullptr }; namespace zip { @@ -69,7 +69,7 @@ const char* ZipEntry::getVersionMadeByString() const { if (mVersionMadeBy >= 20) - return NULL; + return nullptr; return sZipFileMadeByStr[mVersionMadeBy]; } @@ -97,7 +97,7 @@ std::ostream& operator<<(std::ostream& os, const zip::ZipEntry& ze) { const char* madeBy = ze.getVersionMadeByString(); std::string asStr = "Unknown"; - if (madeBy != NULL) + if (madeBy != nullptr) { asStr = madeBy; } diff --git a/modules/c++/zip/source/ZipOutputStream.cpp b/modules/c++/zip/source/ZipOutputStream.cpp index 3f7302e3d..2b9bd903e 100644 --- a/modules/c++/zip/source/ZipOutputStream.cpp +++ b/modules/c++/zip/source/ZipOutputStream.cpp @@ -29,7 +29,7 @@ namespace zip ZipOutputStream::ZipOutputStream(const std::string& pathname) { mZip = zipOpen64(pathname.c_str(), APPEND_STATUS_CREATE); - if (mZip == NULL) + if (mZip == nullptr) throw except::IOException(Ctxt("Failed to open zip stream " + pathname)); @@ -48,18 +48,18 @@ void ZipOutputStream::createFileInZip(const std::string& pathname, mZip, pathname.c_str(), &zipFileInfo, - NULL, + nullptr, 0, - NULL, + nullptr, 0, - comment.empty() ? NULL : comment.c_str(), + comment.empty() ? nullptr : comment.c_str(), Z_DEFLATED, Z_DEFAULT_COMPRESSION, 0, -MAX_WBITS, DEF_MEM_LEVEL, Z_DEFAULT_STRATEGY, - password.empty() ? NULL : password.c_str(), + password.empty() ? nullptr : password.c_str(), 0, 0); @@ -96,7 +96,7 @@ void ZipOutputStream::write(const void* buffer, size_t len) void ZipOutputStream::close() { - sys::Int32_T results = zipClose(mZip, NULL); + sys::Int32_T results = zipClose(mZip, nullptr); if (results != Z_OK) throw except::IOException(Ctxt("Failed to save zip file.")); } diff --git a/modules/c++/zip/unittests/unittest_GZip.cpp b/modules/c++/zip/unittests/unittest_GZip.cpp index 6439cbfd3..30a72a455 100644 --- a/modules/c++/zip/unittests/unittest_GZip.cpp +++ b/modules/c++/zip/unittests/unittest_GZip.cpp @@ -49,10 +49,14 @@ static std::string gz_to_txt(const std::filesystem::path& gz_path) TEST_CASE(gzip) { - const auto inputPath = find_unittest_file("text.txt"); + static const auto inputPath = find_unittest_file("text.txt"); + + const std::filesystem::path outputName_(txt_to_gz(inputPath)); + const auto outputName = "TEST_" + outputName_.stem().string() + "_TMP" + outputName_.extension().string(); // see .gitignore + const auto outputDir = inputPath.parent_path(); + const auto origOutputPath = outputDir / outputName; + auto outputPath = origOutputPath; - const std::filesystem::path argv0 = sys::OS().getSpecialEnv("0"); - auto outputPath = argv0.parent_path() / txt_to_gz(inputPath); { io::FileInputStream input(inputPath.string()); zip::GZipOutputStream output(outputPath.string()); @@ -67,7 +71,7 @@ TEST_CASE(gzip) TEST_ASSERT_EQ(32, buffer.size()); { zip::GZipInputStream input(outputPath.string()); - outputPath = argv0.parent_path() / gz_to_txt(outputPath); + outputPath = outputDir / gz_to_txt(outputPath); io::FileOutputStream output(outputPath.string()); while (input.streamTo(output, 8192)) ; @@ -77,15 +81,19 @@ TEST_CASE(gzip) const auto str = io::readFileContents(outputPath.string()); TEST_ASSERT_EQ("Hello World!", str); } + + remove(origOutputPath); + remove(outputPath); } TEST_CASE(gunzip) { - const auto inputPath = find_unittest_file("test.gz"); + static const auto inputPath = find_unittest_file("test.gz"); - const std::filesystem::path argv0 = sys::OS().getSpecialEnv("0"); - const auto outputPath = argv0.parent_path() / gz_to_txt(inputPath); - + const std::filesystem::path outputName_(gz_to_txt(inputPath)); + const auto outputName = "TEST_" + outputName_.stem().string() + "_TMP" + outputName_.extension().string(); // see .gitignore + const auto outputPath = inputPath.parent_path() / outputName; + zip::GZipInputStream input(inputPath.string()); io::FileOutputStream output(outputPath.string()); while ( input.streamTo(output, 8192) ); @@ -95,6 +103,8 @@ TEST_CASE(gunzip) const auto str = io::readFileContents(outputPath.string()); TEST_ASSERT_EQ("Hello World!", str); + + remove(outputPath); } TEST_MAIN( diff --git a/modules/drivers/j2k/openjpeg/CMakeLists.txt b/modules/drivers/j2k/openjpeg/CMakeLists.txt index 51338f6c5..ea0096803 100644 --- a/modules/drivers/j2k/openjpeg/CMakeLists.txt +++ b/modules/drivers/j2k/openjpeg/CMakeLists.txt @@ -59,12 +59,12 @@ else() set(SOURCE_DIR "${${CMAKE_PROJECT_NAME}_${TARGET_NAME}_SOURCE_DIR}") - check_include_file("stdint.h" OPJ_HAVE_STDINT_H) + set(OPJ_HAVE_STDINT_H true) set(OPENJPEG_VERSION_MAJOR 2) set(OPENJPEG_VERSION_MINOR 3) set(OPENJPEG_VERSION_BUILD 1) - check_include_file("inttypes.h" OPJ_HAVE_INTTYPES_H) + set(OPJ_HAVE_INTTYPES_H true) set(PACKAGE_VERSION 2.3.1) set(_FILE_OFFSET_BITS 64) set(_LARGEFILE_SOURCE 1) @@ -72,7 +72,7 @@ else() set(CMAKE_REQUIRED_DEFINITIONS -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE) check_symbol_exists("fseeko" "stdio.h" OPJ_HAVE_FSEEKO) unset(CMAKE_REQUIRED_DEFINITIONS) - check_include_file("malloc.h" OPJ_HAVE_MALLOC_H) + set(OPJ_HAVE_MALLOC_H true) check_symbol_exists("aligned_alloc" "malloc.h" OPJ_HAVE_ALIGNED_ALLOC) check_symbol_exists("_aligned_malloc" "malloc.h" OPJ_HAVE__ALIGNED_MALLOC) check_symbol_exists("memalign" "malloc.h" OPJ_HAVE_MEMALIGN) diff --git a/modules/drivers/jpeg/CMakeLists.txt b/modules/drivers/jpeg/CMakeLists.txt index 39b773bd7..dea776709 100644 --- a/modules/drivers/jpeg/CMakeLists.txt +++ b/modules/drivers/jpeg/CMakeLists.txt @@ -53,13 +53,11 @@ else() HASH "SHA256=898C46BFE9152D51220C6679E905DE4DF75D2A67DCF315BF80459673AB1EB797" ) set(HAVE_PROTOTYPES 1) - check_cxx_source_compiles("int main() { unsigned short; return 0; }" - HAVE_UNSIGNED_SHORT) - check_cxx_source_compiles("int main() { unsigned char; return 0; }" - HAVE_UNSIGNED_CHAR) - check_include_file("stddef.h" HAVE_STDDEF_H) - check_include_file("stdlib.h" HAVE_STDLIB_H) - check_include_file("locale.h" HAVE_LOCALE_H) + set(HAVE_UNSIGNED_SHORT true) + set(HAVE_UNSIGNED_CHAR true) + set(HAVE_STDDEF_H true) + set(HAVE_STDLIB_H true) + set(HAVE_STDLIB_H true) set(SOURCE_DIR "${${CMAKE_PROJECT_NAME}_${TARGET_NAME}_SOURCE_DIR}") foreach(src "cdjpeg.c" "jaricom.c" "jcapimin.c" "jcapistd.c" diff --git a/modules/drivers/pcre/CMakeLists.txt b/modules/drivers/pcre/CMakeLists.txt index a1fe67284..ac2c2960a 100644 --- a/modules/drivers/pcre/CMakeLists.txt +++ b/modules/drivers/pcre/CMakeLists.txt @@ -54,10 +54,10 @@ else() ) check_symbol_exists("bcopy" "strings.h" HAVE_BCOPY) - check_include_file("inttypes.h" HAVE_INTTYPES_H) - check_symbol_exists("memmove" "string.h" HAVE_MEMMOVE) - check_include_file("stdint.h" HAVE_STDINT_H) - check_symbol_exists("strerror" "string.h" HAVE_STRERROR) + set(HAVE_INTTYPES_H true) + set(HAVE_MEMMOVE true) + set(HAVE_STDINT_H true) + set(HAVE_STRERROR true) set(SUPPORT_PCRE2_8 1) set(PCRE2_LINK_SIZE 2) set(PCRE2_MATCH_LIMIT 10000000) diff --git a/modules/drivers/uuid/CMakeLists.txt b/modules/drivers/uuid/CMakeLists.txt index 7885376cd..319b35d55 100644 --- a/modules/drivers/uuid/CMakeLists.txt +++ b/modules/drivers/uuid/CMakeLists.txt @@ -47,7 +47,7 @@ else() set(SOURCE_DIR "${${CMAKE_PROJECT_NAME}_${TARGET_NAME}_SOURCE_DIR}") - check_include_file("inttypes.h" HAVE_INTTYPES_H) + set(HAVE_INTTYPES_H true) check_type_size("int" SIZEOF_INT) check_type_size("short" SIZEOF_SHORT) check_type_size("long" SIZEOF_LONG) diff --git a/modules/drivers/xml/xerces/CMakeLists.txt b/modules/drivers/xml/xerces/CMakeLists.txt index c1de78a61..664d68d0d 100644 --- a/modules/drivers/xml/xerces/CMakeLists.txt +++ b/modules/drivers/xml/xerces/CMakeLists.txt @@ -63,48 +63,48 @@ else() HASH "SHA256=61981c7a464e33913a093e0dfe7daf8a45f21e46b1924eb97f92bdbb746e2e6e" ) - check_include_file("inttypes.h" HAVE_INTTYPES_H) + set(HAVE_INTTYPES_H true) check_include_file("netinet/in.h" HAVE_NETINET_IN_H) check_include_file("arpa/inet.h" HAVE_ARPA_INET_H) check_include_file("netdb.h" HAVE_NETDB_H) check_include_file("intrin.h" HAVE_INTRIN_H) - check_include_file("emmintrin.h" HAVE_EMMINTRIN_H) - check_include_file("wchar.h" HAVE_WCHAR_H) - check_include_file("stdint.h" HAVE_STDINT_H) - check_include_file("stdio.h" HAVE_STDIO_H) + set(HAVE_EMMINTRIN_H true) + set(HAVE_WCHAR_H true) + set(HAVE_STDINT_H true) + set(HAVE_STDIO_H true) check_include_file("langinfo.h" HAVE_LANGINFO_H) check_include_file("iconv.h" HAVE_ICONV_H) check_include_file("nl_types.h" HAVE_NL_TYPES_H) - check_include_file("ctype.h" HAVE_CTYPE_H) - check_include_file("wctype.h" HAVE_WCTYPE_H) + set(HAVE_CTYPE_H true) + set(HAVE_WCTYPE_H true) check_include_file("cpuid.h" HAVE_CPUID_H) check_include_file("endian.h" HAVE_ENDIAN_H) check_include_file("machine/endian.h" HAVE_MACHINE_ENDIAN_H) check_include_file("arpa/nameser_compat.h" HAVE_ARPA_NAMESER_COMPAT_H) - check_include_file("errno.h" HAVE_ERRNO_H) - check_include_file("float.h" HAVE_FLOAT_H) - check_include_file("locale.h" HAVE_LOCALE_H) + set(HAVE_ERRNO_H true) + set(HAVE_FLOAT_H true) + set(HAVE_LOCALE_H true) check_include_file("sys/param.h" HAVE_SYS_PARAM_H) check_include_file("sys/socket.h" HAVE_SYS_SOCKET_H) - check_include_file("sys/stat.h" HAVE_SYS_STAT_H) - check_include_file("sys/timeb.h" HAVE_SYS_TIMEB_H) - check_include_file("sys/types.h" HAVE_SYS_TYPES_H) + set(HAVE_SYS_STAT_H true) + set(HAVE_SYS_TIMEB_H true) + set(HAVE_SYS_TYPES_H true) - check_symbol_exists("mblen" "stdlib.h" HAVE_MBLEN) + set(HAVE_MBLEN true) check_symbol_exists("mbrlen" "stdlib.h" HAVE_MBRLEN) check_symbol_exists("mbsrtowcs" "stdlib.h" HAVE_MBSRTOWCS) - check_symbol_exists("mbstowcs" "stdlib.h" HAVE_MBSTOWCS) - check_symbol_exists("wsctombs" "stdlib.h" HAVE_WCSTOMBS) + set(HAVE_MBSTOWCS true) + set(HAVE_WCSTOMBS true) check_symbol_exists("wcsrtombs" "stdlib.h" HAVE_WCSRTOMBS) check_symbol_exists("realpath" "stdlib.h" HAVE_REALPATH) - check_symbol_exists("strchr" "string.h" HAVE_STRCHR) - check_symbol_exists("strdup" "string.h" HAVE_STRDUP) + set(HAVE_STRCHR true) + set(HAVE_STRDUP true) check_symbol_exists("stricmp" "string.h" HAVE_STRICMP) check_symbol_exists("strnicmp" "string.h" HAVE_STRNICMP) check_symbol_exists("strrcmp" "string.h" HAVE_STRRCMP) - check_symbol_exists("strstr" "string.h" HAVE_STRSTR) - check_symbol_exists("strtol" "string.h" HAVE_STRTOL) - check_symbol_exists("strtoul" "string.h" HAVE_STRTOUL) + set(HAVE_STRSTR true) + set(HAVE_STRTOL true) + set(HAVE_STRTOUL true) check_symbol_exists("strcasecmp" "strings.h" HAVE_STRCASECMP) check_symbol_exists("strncasecmp" "strings.h" HAVE_STRNCASECMP) check_symbol_exists("pathconf" "unistd.h" HAVE_PATHCONF) @@ -112,15 +112,15 @@ else() check_symbol_exists("iconv" "iconv.h" HAVE_ICONV) check_symbol_exists("iconv_close" "iconv.h" HAVE_ICONV_CLOSE) check_symbol_exists("iconv_open" "iconv.h" HAVE_ICONV_OPEN) - check_symbol_exists("towupper" "wctype.h" HAVE_TOWUPPER) - check_symbol_exists("towlower" "wctype.h" HAVE_TOWLOWER) + set(HAVE_TOWUPPER true) + set(HAVE_TOWLOWER true) check_symbol_exists("catclose" "nl_types.h" HAVE_CATCLOSE) check_symbol_exists("catgets" "nl_types.h" HAVE_CATGETS) check_symbol_exists("catopen" "nl_types.h" HAVE_CATOPEN) - check_symbol_exists("localeconv" "locale.h" HAVE_LOCALECONV) - check_symbol_exists("setlocale" "locale.h" HAVE_SETLOCALE) + set(HAVE_LOCALECONV true) + set(HAVE_SETLOCALE true) check_symbol_exists("socket" "sys/socket.h" HAVE_SOCKET) - check_symbol_exists("ftime" "sys/timeb.h" HAVE_FTIME) + set(HAVE_FTIME true) check_symbol_exists("getaddrinfo" "netdb.h" HAVE_GETADDRINFO) find_library(NSL_LIB nsl) @@ -130,7 +130,7 @@ else() check_include_file("unistd.h" HAVE_UNISTD_H) check_include_file("sys/time.h" HAVE_SYS_TIME_H) - check_include_file("limits.h" HAVE_LIMITS_H) + set(HAVE_LIMITS_H true) check_include_file("strings.h" HAVE_STRINGS_H) # extra defines for config.h diff --git a/modules/python/sys/source/generated/coda_sys_wrap.cxx b/modules/python/sys/source/generated/coda_sys_wrap.cxx index 0a3ed4820..16000dd61 100644 --- a/modules/python/sys/source/generated/coda_sys_wrap.cxx +++ b/modules/python/sys/source/generated/coda_sys_wrap.cxx @@ -3566,7 +3566,7 @@ SWIGINTERN PyObject *_wrap_byteSwap__SWIG_0(PyObject *SWIGUNUSEDPARM(self), PyOb SWIG_exception_fail(SWIG_ArgError(ecode3), "in method '" "byteSwap" "', argument " "3"" of type '" "size_t""'"); } arg3 = static_cast< size_t >(val3); - sys::byteSwap(arg1,arg2,arg3); + sys::byteSwap(arg1, arg2, arg3); resultobj = SWIG_Py_Void(); return resultobj; fail: From c39449554a1438bf191f036a0904809554d400e0 Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Mon, 17 Jul 2023 21:06:03 -0400 Subject: [PATCH 093/104] Revert "latest from CODA-OSS (known broken build) (#565)" This reverts commit 102a019db7399b4b4330b4eaf4070c310b4cb627. --- .../.github/workflows/build_unittest.yml | 41 +---- externals/coda-oss/ReleaseNotes.md | 10 +- .../coda-oss/UnitTest/CppUnitTestAssert.cpp | 42 ++++- externals/coda-oss/UnitTest/TestCase.h | 137 ++++++++++++++++- externals/coda-oss/UnitTest/UnitTest.vcxproj | 10 +- externals/coda-oss/coda-oss.sln | 8 - .../coda-oss/modules/c++/coda-oss.vcxproj | 21 +-- .../modules/c++/coda-oss.vcxproj.filters | 9 -- .../c++/dbi/source/MySQLConnection.cpp | 2 +- .../c++/dbi/source/OracleConnection.cpp | 10 +- .../c++/dbi/source/PgSQLConnection.cpp | 2 +- .../c++/except/include/except/Throwable.h | 6 +- .../modules/c++/except/source/Trace.cpp | 7 +- .../c++/hdf5.lite/include/hdf5/lite/H5_.h | 3 - .../modules/c++/hdf5.lite/source/H5.h | 7 +- .../modules/c++/hdf5.lite/source/hdf5.lite.h | 7 +- .../c++/hdf5.lite/unittests/test_highfive.cpp | 6 +- .../coda-oss/modules/c++/include/TestCase.h | 1 - .../coda-oss/modules/c++/include/UnitTest.h | 143 ------------------ .../c++/math/tests/complexBenchmark.cpp | 4 +- .../math/tests/complexMultiplyBenchmark.cpp | 4 +- .../c++/mem/tests/ScratchVisualization.cpp | 2 +- .../c++/mem/unittests/test_scratch_memory.cpp | 2 +- .../c++/mem/unittests/test_shared_ptr.cpp | 12 +- .../modules/c++/mt/include/import/mt.h | 16 +- .../c++/net.ssl/source/SSLConnection.cpp | 4 +- .../c++/net/tests/AckMulticastSender.cpp | 4 +- .../c++/net/tests/NetConnectionServerTest.cpp | 2 +- .../modules/c++/net/tests/TCPClientTest.cpp | 2 +- .../modules/c++/net/tests/UDPClientTest.cpp | 2 +- .../include/numpyutils/numpyutils.h | 28 +--- .../c++/numpyutils/source/numpyutils.cpp | 11 +- externals/coda-oss/modules/c++/pch.h | 19 +-- .../modules/c++/re/include/re/Regex.h | 2 +- .../modules/c++/re/source/RegexPCRE.cpp | 18 +-- .../c++/str/source/EncodedStringView.cpp | 27 ++-- .../coda-oss/modules/c++/sys/include/sys/OS.h | 45 ++---- .../modules/c++/sys/source/AbstractOS.cpp | 9 +- .../c++/sys/source/ConditionVarPosix.cpp | 6 +- .../c++/sys/source/CppUnitTestAssert_.cpp_ | 43 ------ .../modules/c++/sys/source/DLLUnix.cpp | 2 +- .../modules/c++/sys/source/DateTime.cpp | 2 +- .../modules/c++/sys/source/ExecUnix.cpp | 2 +- .../modules/c++/sys/source/FileFinder.cpp | 29 ++-- .../modules/c++/sys/source/MutexPosix.cpp | 2 +- .../modules/c++/sys/source/OSUnix.cpp | 2 +- .../c++/sys/source/ScopedCPUAffinityUnix.cpp | 2 +- .../modules/c++/sys/source/ThreadPosix.cpp | 4 +- .../modules/c++/sys/tests/DateTimeTest.cpp | 4 +- .../coda-oss/modules/c++/sys/tests/OSTest.cpp | 4 +- .../modules/c++/tiff/source/IFDEntry.cpp | 3 +- .../modules/c++/types/include/types/Complex.h | 6 +- .../c++/xml.lite/include/import/xml/lite.h | 42 ++++- .../c++/xml.lite/include/xml/lite/xerces_.h | 5 - .../c++/xml.lite/source/Serializable.cpp | 4 +- .../c++/zip/source/ZipOutputStream.cpp | 4 +- 56 files changed, 387 insertions(+), 464 deletions(-) delete mode 100644 externals/coda-oss/modules/c++/include/UnitTest.h delete mode 100644 externals/coda-oss/modules/c++/sys/source/CppUnitTestAssert_.cpp_ diff --git a/externals/coda-oss/.github/workflows/build_unittest.yml b/externals/coda-oss/.github/workflows/build_unittest.yml index b96a17a63..04b2f3fae 100644 --- a/externals/coda-oss/.github/workflows/build_unittest.yml +++ b/externals/coda-oss/.github/workflows/build_unittest.yml @@ -36,7 +36,8 @@ jobs: cd .. cd target-Debug cmake --build . --config Debug -j - - name: test # should run w/o install + - name: test + # should run w/o install run: | cd target-Release ctest -C Release --output-on-failure @@ -51,43 +52,17 @@ jobs: cd target-Debug cmake --build . --config Debug --target install cd .. - - build-msbuild-windows: - strategy: - matrix: - os: [windows-latest] - platform: [x64] - configuration: [Debug] # Debug turns on more compiler warnings - name: ${{ matrix.os }}-msbuild - runs-on: ${{ matrix.os }} - - steps: - - uses: actions/checkout@v3 - - name: configure - run: | - ls env: - mkdir out - cd out - cmake .. -DCMAKE_INSTALL_PREFIX=install\${{ matrix.platform }}-${{ matrix.configuration }} -DENABLE_PYTHON=OFF - - name: build - run: | - cd out - cmake --build . --config ${{ matrix.configuration }} -j - cmake --build . --config ${{ matrix.configuration }} --target install - name: Add msbuild to PATH - uses: microsoft/setup-msbuild@v1 # https://github.com/marketplace/actions/setup-msbuild + uses: microsoft/setup-msbuild@v1.1 with: msbuild-architecture: x64 - name: msbuild run: | - msbuild coda-oss.sln /p:configuration=${{ matrix.configuration }} - # Can't figure out how to make this work :-( - #- name: vstest - # uses: microsoft/vstest-action@v1.0.0 # https://github.com/marketplace/actions/vstest-action - # with: - # testAssembly: UnitTest.dll - # searchFolder: D:\a\nitro\nitro\${{ matrix.platform }}\${{ matrix.configuration }} - # runInParallel: true + msbuild coda-oss.sln /p:configuration=Release + msbuild coda-oss.sln /p:configuration=Debug + #- name: mstest + # run: | + # mstest /testcontainer:${RUNNER_WORKSPACE}\coda-oss\x64\Debug\UnitTest.dll build-linux-cmake: strategy: diff --git a/externals/coda-oss/ReleaseNotes.md b/externals/coda-oss/ReleaseNotes.md index c54bdadcb..bf8f97f3a 100644 --- a/externals/coda-oss/ReleaseNotes.md +++ b/externals/coda-oss/ReleaseNotes.md @@ -18,16 +18,16 @@ * wrap common "file open" routines (e.g., `fopen()`) to support `sys::expandEnvironmentVariables()`. * add header-only [HighFive](https://github.com/BlueBrain/HighFive) HDF5-wrapper library. * Added a handful of [HighFive](https://github.com/BlueBrain/HighFive) utility routines. -* `mt::transform_async()` removed, it doesn't match C++17 techniques. +* `mt::transform_async()` removed, it doesn't match C++17 techniques.' * Revamp `sys::byteSwap()` for improved type-safety and [better performance](https://devblogs.microsoft.com/cppblog/a-tour-of-4-msvc-backend-improvements/). - * Added case-insensitive string comparison utilities: `str::eq()` and `str::ne()`; + * Added case-insensitive string comparison utilties: `str::eq()` and `str::ne()`; `xml::lite::Uri`s compare case-insensitive. ## [Release 2022-12-14](https://github.com/mdaus/coda-oss/releases/tag/2022-12-14) * removed remaining vestiges of `std::auto_ptr`, provide `mem::AutoPtr` for the tiny handful of places (e.g., SWIG bindings) that still need copying. -* `xml::lite::Element` overloads to make creating new XML documents easier; see unittests for examples. +* `xml::lite::Element` overloads to make creting new XML documents easier; see unittests for examples. * try even harder to find unittest files in various scenarios. * build *hdf5.lite* with **waf**. * New `--optz=fastest-possible` (**waf** only) which adds @@ -40,8 +40,8 @@ * The [HDFGroup](https://hdfgroup.org/)s [HDF5 library](https://github.com/HDFGroup/hdf5) is built and installed; a simple (and very incomplete!) wrapper is provided, this is at the "hello world!" stage. * A few **cli** routines have been tweaked to make unit-testing easier. -* Utility routines for finding various files when unit-testing. -* Removed C++14 work-arounds needed in C++11. Legacy C++ exception specifications removed. +* Utilitiy routines for finding various files when unit-testing. +* Removed C++14 work-arounds needed in C++11. Legacy C++ exception specificatons removed. * Rebuild `waf` for FIPS error; added more debug options. ## [Release 2022-08-30](https://github.com/mdaus/coda-oss/releases/tag/2022-08-30) diff --git a/externals/coda-oss/UnitTest/CppUnitTestAssert.cpp b/externals/coda-oss/UnitTest/CppUnitTestAssert.cpp index 5bea8da59..fdcf5f92b 100644 --- a/externals/coda-oss/UnitTest/CppUnitTestAssert.cpp +++ b/externals/coda-oss/UnitTest/CppUnitTestAssert.cpp @@ -1,5 +1,43 @@ #include "pch.h" #include "TestCase.h" -// Can't get this to build in the **coda-oss** project. -#include "sys/source/CppUnitTestAssert_.cpp_" +#include "str/EncodedStringView.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +// EQUALS_MESSAGE() wants ToString() specializations (or overloads) for our types, which is a nusiance. +// This hooks up our existing str::toString() into the VC++ unit-test infrastructure + +// C++ hack to call private methods +// https://stackoverflow.com/a/71578383/8877 + +using FailOnCondition_t = void(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare method's type +using GetAssertMessage_t = std::wstring(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare method's type +template +struct caller final // helper structure to inject call() code +{ + friend void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) + { + fFailOnCondition(condition, message, pLineInfo); + } + + friend std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message) + { + return fGetAssertMessage(equality, expected, actual, message); + } +}; +template struct caller<&Assert::FailOnCondition, &Assert::GetAssertMessage>; // even instantiation of the helper + +void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare caller +void test::Assert::FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) +{ + ::FailOnCondition(condition, message, pLineInfo); // and call! +} + +std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare caller +std::wstring test::Assert::GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message) +{ + const str::EncodedStringView vExpected(expected); + const str::EncodedStringView vActual(actual); + return ::GetAssertMessage(equality, vExpected.wstring(), vActual.wstring(), message); // and call! +} diff --git a/externals/coda-oss/UnitTest/TestCase.h b/externals/coda-oss/UnitTest/TestCase.h index e769f584f..f4438821f 100644 --- a/externals/coda-oss/UnitTest/TestCase.h +++ b/externals/coda-oss/UnitTest/TestCase.h @@ -1,3 +1,138 @@ #pragma once -#include +#include +#include + +#include "CppUnitTest.h" +#include +#include + +#undef TEST_CHECK +#undef TEST_ASSERT +#undef TEST_ASSERT_NULL +#undef TEST_ASSERT_NOT_NULL +#undef TEST_ASSERT_TRUE +#undef TEST_ASSERT_FALSE +#undef TEST_MAIN +#undef TEST_CASE +#define TEST_CHECK(X) +#define TEST_MAIN(X) +#define TEST_ASSERT_NULL(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNull(X) +#define TEST_ASSERT_NOT_NULL(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNotNull(X) +#define TEST_ASSERT_TRUE(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(X) +#define TEST_ASSERT_FALSE(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsFalse(X) +#define TEST_ASSERT(X) TEST_ASSERT_TRUE(X) +#define CODA_OSS_testMethod_(X) testMethod ## _ ## X +#define TEST_CASE(X) TEST_METHOD(X) { CODA_OSS_testMethod_(X)(#X); } void CODA_OSS_testMethod_(X)(std::string testName) + +namespace test +{ + struct Assert final + { + static void FailOnCondition(bool condition, const unsigned short* message, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo); + static std::wstring GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message); + }; +#define CODA_OSS_equals_message_(expected, actual, message) reinterpret_cast(test::Assert::GetAssertMessage(true, test::toString(expected), test::toString(actual), message).c_str()) +#define CODA_OSS_not_equals_message_(notExpected, actual, message) reinterpret_cast(test::Assert::GetAssertMessage(false, test::toString(notExpected), test::toString(actual), message).c_str()) +#define CODA_OSS_message_(message) reinterpret_cast(test::Assert::GetAssertMessage(false, "", "", message).c_str()) + +// see Assert::AreEqual<> +template +inline void diePrintf_eq(const TExpected& expected, const TActual& actual, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(expected == actual, CODA_OSS_equals_message_(expected, actual, message), pLineInfo); +} + +// see Assert::AreNotEqual<> +template +inline void diePrintf_ne(const TExpected& notExpected, const TActual& actual, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(notExpected != actual, CODA_OSS_not_equals_message_(notExpected, actual, message), pLineInfo); +} + +template +inline void diePrintf_ge(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 >= X2, CODA_OSS_message_(message), pLineInfo); +} +template +inline void diePrintf_gt(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 > X2, CODA_OSS_message_(message), pLineInfo); +} +template +inline void diePrintf_le(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 <= X2, CODA_OSS_message_(message), pLineInfo); +} +template +inline void diePrintf_lt(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 < X2, CODA_OSS_message_(message), pLineInfo); +} + +} +#undef CODA_OSS_test_diePrintf_eq_ +#undef CODA_OSS_test_diePrintf_not_eq_ +#define CODA_OSS_test_diePrintf_eq_(X1, X2) testName, ::test::diePrintf_eq(X1, X2) +#define CODA_OSS_test_diePrintf_not_eq_(X1, X2) testName, ::test::diePrintf_ne(X1, X2) + +#undef CODA_OSS_test_diePrintf_greater_eq_ +#undef CODA_OSS_test_diePrintf_greater_ +#undef CODA_OSS_test_diePrintf_lesser_eq_ +#undef CODA_OSS_test_diePrintf_lesser_ +#define CODA_OSS_test_diePrintf_greater_eq_(X1, X2) testName, ::test::diePrintf_ge(X1, X2) +#define CODA_OSS_test_diePrintf_greater_(X1, X2) testName, ::test::diePrintf_gt(X1, X2) +#define CODA_OSS_test_diePrintf_lesser_eq_(X1, X2) testName, ::test::diePrintf_le(X1, X2) +#define CODA_OSS_test_diePrintf_lesser_(X1, X2) testName, ::test::diePrintf_lt(X1, X2) + +template +inline void test_assert_greater_(const TX1& X1, const TX2& X2) +{ + Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(X1 > X2); +} +#undef TEST_ASSERT_GREATER +#define TEST_ASSERT_GREATER(X1, X2) testName, test_assert_greater_(X1, X2) + +#undef TEST_ASSERT_ALMOST_EQ_EPS +#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) { (void)testName; Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(X1, X2, EPS); Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(X2, X1, EPS); } +namespace test +{ +inline void assert_almost_eq(const std::string& testName, float X1, float X2) +{ + constexpr auto EPS = static_cast(0.0001); + TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS); +} +inline void assert_almost_eq(const std::string& testName, double X1, double X2) +{ + constexpr auto EPS = static_cast(0.0001); + TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS); +} +inline void assert_almost_eq(const std::string& testName, long double X1, long double X2) +{ + assert_almost_eq(testName, static_cast(X1), static_cast(X2)); +} +} + +#undef TEST_ASSERT_ALMOST_EQ +#define TEST_ASSERT_ALMOST_EQ(X1, X2) test::assert_almost_eq(testName, X1, X2) + +#undef TEST_ASSERT_EQ_MSG +#define TEST_ASSERT_EQ_MSG(msg, X1, X2) testName, Microsoft::VisualStudio::CppUnitTestFramework::Logger::WriteMessage(msg.c_str()); TEST_ASSERT_EQ(X1, X2) + +#undef TEST_FAIL_MSG +#define TEST_FAIL_MSG(msg) { (void)testName; const str::EncodedStringView vw(msg); Microsoft::VisualStudio::CppUnitTestFramework::Assert::Fail(vw.wstring().c_str()); } + +#undef TEST_EXCEPTION +#undef TEST_THROWS +#undef TEST_SPECIFIC_EXCEPTION +#define TEST_EXCEPTION(X) (void)testName; try{ (X); TEST_FAIL(#X " should have thrown."); } CODA_OSS_TEST_EXCEPTION_catch_ +#define TEST_THROWS(X) (void)testName; try{ (X); TEST_FAIL(#X " should have thrown."); } catch (...){ TEST_ASSERT_TRUE(true); } +#define TEST_SPECIFIC_EXCEPTION(X, Y) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::ExpectException([&](){(X);}) + diff --git a/externals/coda-oss/UnitTest/UnitTest.vcxproj b/externals/coda-oss/UnitTest/UnitTest.vcxproj index 835f574dc..65b3ca322 100644 --- a/externals/coda-oss/UnitTest/UnitTest.vcxproj +++ b/externals/coda-oss/UnitTest/UnitTest.vcxproj @@ -57,7 +57,7 @@ Use Level4 true - $(VCInstallDir)UnitTest\include;$(ProjectDir);$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\avx\include;$(SolutionDir)modules\c++\cli\include;$(SolutionDir)modules\c++\config\include;$(SolutionDir)modules\c++\coda_oss\include;$(SolutionDir)modules\c++\gsl\include;$(SolutionDir)modules\c++\hdf5.lite\include;$(SolutionDir)modules\c++\io\include;$(SolutionDir)modules\c++\std\include;$(SolutionDir)modules\c++\str\include;$(SolutionDir)modules\c++\sys\include;$(SolutionDir)modules\c++\except\include;$(SolutionDir)modules\c++\logging\include;$(SolutionDir)modules\c++\math\include;$(SolutionDir)modules\c++\math.linear\include;$(SolutionDir)modules\c++\math.poly\include;$(SolutionDir)modules\c++\mem\include;$(SolutionDir)modules\c++\mt\include;$(SolutionDir)modules\c++\polygon\include;$(SolutionDir)modules\c++\re\include;$(SolutionDir)modules\c++\types\include;$(SolutionDir)modules\c++\units\include;$(SolutionDir)modules\c++\xml.lite\include;$(SolutionDir)modules\c++\zip\include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;%(AdditionalIncludeDirectories) + $(VCInstallDir)UnitTest\include;$(ProjectDir);$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\avx\include\;$(SolutionDir)modules\c++\cli\include\;$(SolutionDir)modules\c++\config\include\;$(SolutionDir)modules\c++\coda_oss\include\;$(SolutionDir)modules\c++\gsl\include\;$(SolutionDir)modules\c++\hdf5.lite\include\;$(SolutionDir)modules\c++\io\include\;$(SolutionDir)modules\c++\std\include\;$(SolutionDir)modules\c++\str\include\;$(SolutionDir)modules\c++\sys\include\;$(SolutionDir)modules\c++\except\include\;$(SolutionDir)modules\c++\logging\include\;$(SolutionDir)modules\c++\math\include\;$(SolutionDir)modules\c++\math.linear\include\;$(SolutionDir)modules\c++\math.poly\include\;$(SolutionDir)modules\c++\mem\include\;$(SolutionDir)modules\c++\mt\include\;$(SolutionDir)modules\c++\polygon\include\;$(SolutionDir)modules\c++\re\include\;$(SolutionDir)modules\c++\types\include\;$(SolutionDir)modules\c++\units\include\;$(SolutionDir)modules\c++\xml.lite\include\;$(SolutionDir)modules\c++\zip\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;%(AdditionalIncludeDirectories) _DEBUG;%(PreprocessorDefinitions);MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 true pch.h @@ -65,6 +65,7 @@ true Guard ProgramDatabase + true true true true @@ -74,7 +75,7 @@ Windows - $(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) + $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;$(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) @@ -84,12 +85,13 @@ true true true - $(VCInstallDir)UnitTest\include;$(ProjectDir);$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\avx\include;$(SolutionDir)modules\c++\cli\include;$(SolutionDir)modules\c++\config\include;$(SolutionDir)modules\c++\coda_oss\include;$(SolutionDir)modules\c++\gsl\include;$(SolutionDir)modules\c++\hdf5.lite\include;$(SolutionDir)modules\c++\io\include;$(SolutionDir)modules\c++\std\include;$(SolutionDir)modules\c++\str\include;$(SolutionDir)modules\c++\sys\include;$(SolutionDir)modules\c++\except\include;$(SolutionDir)modules\c++\logging\include;$(SolutionDir)modules\c++\math\include;$(SolutionDir)modules\c++\math.linear\include;$(SolutionDir)modules\c++\math.poly\include;$(SolutionDir)modules\c++\mem\include;$(SolutionDir)modules\c++\mt\include;$(SolutionDir)modules\c++\polygon\include;$(SolutionDir)modules\c++\re\include;$(SolutionDir)modules\c++\types\include;$(SolutionDir)modules\c++\units\include;$(SolutionDir)modules\c++\xml.lite\include;$(SolutionDir)modules\c++\zip\include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;%(AdditionalIncludeDirectories) + $(VCInstallDir)UnitTest\include;$(ProjectDir);$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\avx\include\;$(SolutionDir)modules\c++\cli\include\;$(SolutionDir)modules\c++\config\include\;$(SolutionDir)modules\c++\coda_oss\include\;$(SolutionDir)modules\c++\gsl\include\;$(SolutionDir)modules\c++\hdf5.lite\include\;$(SolutionDir)modules\c++\io\include\;$(SolutionDir)modules\c++\std\include\;$(SolutionDir)modules\c++\str\include\;$(SolutionDir)modules\c++\sys\include\;$(SolutionDir)modules\c++\except\include\;$(SolutionDir)modules\c++\logging\include\;$(SolutionDir)modules\c++\math\include\;$(SolutionDir)modules\c++\math.linear\include\;$(SolutionDir)modules\c++\math.poly\include\;$(SolutionDir)modules\c++\mem\include\;$(SolutionDir)modules\c++\mt\include\;$(SolutionDir)modules\c++\polygon\include\;$(SolutionDir)modules\c++\re\include\;$(SolutionDir)modules\c++\types\include\;$(SolutionDir)modules\c++\units\include\;$(SolutionDir)modules\c++\xml.lite\include\;$(SolutionDir)modules\c++\zip\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;%(AdditionalIncludeDirectories) NDEBUG;%(PreprocessorDefinitions);MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 true pch.h true Guard + true true true true @@ -101,7 +103,7 @@ Windows true true - $(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) + $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;$(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) diff --git a/externals/coda-oss/coda-oss.sln b/externals/coda-oss/coda-oss.sln index cea89c6f0..5583590dd 100644 --- a/externals/coda-oss/coda-oss.sln +++ b/externals/coda-oss/coda-oss.sln @@ -15,11 +15,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution EndProject Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "UnitTest", "UnitTest\UnitTest.vcxproj", "{34A31B3F-47C5-441D-AB22-3C85B3C5314E}" EndProject -Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".github-workflows", ".github-workflows", "{E0FA1194-0806-4A6B-A331-33CB43C0C946}" - ProjectSection(SolutionItems) = preProject - .github\workflows\build_unittest.yml = .github\workflows\build_unittest.yml - EndProjectSection -EndProject Global GlobalSection(SolutionConfigurationPlatforms) = preSolution Debug|x64 = Debug|x64 @@ -38,9 +33,6 @@ Global GlobalSection(SolutionProperties) = preSolution HideSolutionNode = FALSE EndGlobalSection - GlobalSection(NestedProjects) = preSolution - {E0FA1194-0806-4A6B-A331-33CB43C0C946} = {DEB848DD-4285-4BFA-9B2F-60FA46200205} - EndGlobalSection GlobalSection(ExtensibilityGlobals) = postSolution SolutionGuid = {3CAB4AC9-7865-44AD-8623-57905729A559} EndGlobalSection diff --git a/externals/coda-oss/modules/c++/coda-oss.vcxproj b/externals/coda-oss/modules/c++/coda-oss.vcxproj index cd7468965..b0c706116 100644 --- a/externals/coda-oss/modules/c++/coda-oss.vcxproj +++ b/externals/coda-oss/modules/c++/coda-oss.vcxproj @@ -60,7 +60,6 @@ - @@ -147,7 +146,6 @@ - @@ -528,10 +526,6 @@ - - true - true - 16.0 @@ -580,27 +574,27 @@ true _DEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL;MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 pch.h - cli\include;coda_oss\include;config\include;dbi\include;except\include;gsl\include;hdf5.lite\include;io\include;logging\include;math\include;math.linear\include;math.poly\include;mem\include;mt\include;net\include;net.ssl\include;plugin\include;polygon\include;re\include;sio.lite\include;std\include;str\include;sys\include;tiff\include;types\include;unique\include;units\include;xml.lite\include;zip\include;$(ProjectDir)include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;$(SolutionDir)externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\include + cli\include\;coda_oss\include;config\include\;dbi\include\;except\include\;gsl\include\;hdf5.lite\include\;io\include\;logging\include\;math\include\;math.linear\include\;math.poly\include\;mem\include\;mt\include\;net\include\;net.ssl\include\;plugin\include\;polygon\include\;re\include\;sio.lite\include\;std\include\;str\include\;sys\include\;tiff\include;types\include\;unique\include\;units\include\;xml.lite\include\;zip\include\;$(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ Use pch.h true Guard ProgramDatabase + true true true true /Zc:__cplusplus %(AdditionalOptions) true AdvancedVectorExtensions2 - MultiThreadedDebugDLL true true - $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib;$(SolutionDir)\externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\lib - rpcrt4.lib;%(AdditionalDependencies) + $(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\ + hdf5-c++.lib;z.lib;minizip.lib;xerces-c.lib;rpcrt4.lib;%(AdditionalDependencies) @@ -611,11 +605,12 @@ true NDEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL;MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 pch.h - cli\include;coda_oss\include;config\include;dbi\include;except\include;gsl\include;hdf5.lite\include;io\include;logging\include;math\include;math.linear\include;math.poly\include;mem\include;mt\include;net\include;net.ssl\include;plugin\include;polygon\include;re\include;sio.lite\include;std\include;str\include;sys\include;tiff\include;types\include;unique\include;units\include;xml.lite\include;zip\include;$(ProjectDir)include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;$(SolutionDir)externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\include + cli\include\;coda_oss\include;config\include\;dbi\include\;except\include\;gsl\include\;hdf5.lite\include\;io\include\;logging\include\;math\include\;math.linear\include\;math.poly\include\;mem\include\;mt\include\;net\include\;net.ssl\include\;plugin\include\;polygon\include\;re\include\;sio.lite\include\;std\include\;str\include\;sys\include\;tiff\include;types\include\;unique\include\;units\include\;xml.lite\include\;zip\include\;$(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ Use pch.h true Guard + true true true true @@ -628,8 +623,8 @@ true true true - $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib;$(SolutionDir)\externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\lib - rpcrt4.lib;%(AdditionalDependencies) + $(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\ + hdf5-c++.lib;z.lib;minizip.lib;xerces-c.lib;rpcrt4.lib;%(AdditionalDependencies) diff --git a/externals/coda-oss/modules/c++/coda-oss.vcxproj.filters b/externals/coda-oss/modules/c++/coda-oss.vcxproj.filters index adb5a57f7..2b1f01308 100644 --- a/externals/coda-oss/modules/c++/coda-oss.vcxproj.filters +++ b/externals/coda-oss/modules/c++/coda-oss.vcxproj.filters @@ -963,12 +963,6 @@ hdf5.lite - - mt - - - include - @@ -1592,8 +1586,5 @@ std - - sys - \ No newline at end of file diff --git a/externals/coda-oss/modules/c++/dbi/source/MySQLConnection.cpp b/externals/coda-oss/modules/c++/dbi/source/MySQLConnection.cpp index 49c01f304..9f0e6aae3 100644 --- a/externals/coda-oss/modules/c++/dbi/source/MySQLConnection.cpp +++ b/externals/coda-oss/modules/c++/dbi/source/MySQLConnection.cpp @@ -38,7 +38,7 @@ bool dbi::MySQLConnection::connect(const std::string& database, if (!mysql_real_connect(&mDBHandle, host.c_str(), user.c_str(), pass.c_str(), database.c_str(), port, - nullptr, 0)) + NULL, 0)) { return false; } diff --git a/externals/coda-oss/modules/c++/dbi/source/OracleConnection.cpp b/externals/coda-oss/modules/c++/dbi/source/OracleConnection.cpp index a03203e4f..66ff79cb5 100644 --- a/externals/coda-oss/modules/c++/dbi/source/OracleConnection.cpp +++ b/externals/coda-oss/modules/c++/dbi/source/OracleConnection.cpp @@ -80,7 +80,7 @@ const std::string dbi::OracleConnection::getLastErrorMessage() char errbuf[100]; memset(errbuf, 0, 100); int errcode; - OCIErrorGet((dvoid *)mErrorHandle, (ub4) 1, (text *) nullptr, &errcode, + OCIErrorGet((dvoid *)mErrorHandle, (ub4) 1, (text *) NULL, &errcode, (OraText*)errbuf, (ub4) sizeof(errbuf), OCI_HTYPE_ERROR); if (strlen(errbuf) > 0) return std::string(errbuf); @@ -117,7 +117,7 @@ dbi::pResultSet dbi::OracleConnection::query(const std::string& q) OCIStmtPrepare(countHandle, mErrorHandle, (const OraText*)countq.c_str(), (ub4)countq.length(), (ub4) OCI_NTV_SYNTAX, (ub4) OCI_DEFAULT); OCIStmtExecute(mContextHandle, countHandle, mErrorHandle, (ub4)val, (ub4)0, - (CONST OCISnapshot *) nullptr, (OCISnapshot *) nullptr, OCI_DEFAULT); + (CONST OCISnapshot *) NULL, (OCISnapshot *) NULL, OCI_DEFAULT); OCIDefine * defineHandle = nullptr; OCIDefineByPos(countHandle, &defineHandle, mErrorHandle, 1, &rowCount, sizeof(rowCount), SQLT_UIN, 0, 0, 0, OCI_DEFAULT); @@ -126,7 +126,7 @@ dbi::pResultSet dbi::OracleConnection::query(const std::string& q) /* Execute the SQL statment */ OCIStmtExecute(mContextHandle, sqlHandle, mErrorHandle, (ub4) val, (ub4) 0, - (CONST OCISnapshot *) nullptr, (OCISnapshot *) nullptr, OCI_DEFAULT); + (CONST OCISnapshot *) NULL, (OCISnapshot *) NULL, OCI_DEFAULT); return dbi::pResultSet(new dbi::OracleResultSet(sqlHandle, mErrorHandle, rowCount)); } @@ -229,8 +229,8 @@ dbi::Row dbi::OracleResultSet::fetchRow() ub4 bufferSize = 9; OCIDateToText(mErrorHandle, (const OCIDate*)fields[i].value, - nullptr, 0, - nullptr, 0, &bufferSize, (text*)buffer); + NULL, 0, + NULL, 0, &bufferSize, (text*)buffer); memset(fields[i].value, '\0', sizeof(OCIDate)); strncpy(fields[i].value, buffer, bufferSize); } diff --git a/externals/coda-oss/modules/c++/dbi/source/PgSQLConnection.cpp b/externals/coda-oss/modules/c++/dbi/source/PgSQLConnection.cpp index fc5a86a97..5e9519dd7 100644 --- a/externals/coda-oss/modules/c++/dbi/source/PgSQLConnection.cpp +++ b/externals/coda-oss/modules/c++/dbi/source/PgSQLConnection.cpp @@ -97,7 +97,7 @@ dbi::pResultSet dbi::PgSQLConnection::query(const std::string& q) throw dbi::SQLException(Ctxt(errorMessage)); } - return dbi::pResultSet(new PgSQLResultSet(nullptr)); + return dbi::pResultSet(new PgSQLResultSet(NULL)); } dbi::Row dbi::PgSQLResultSet::fetchRow() diff --git a/externals/coda-oss/modules/c++/except/include/except/Throwable.h b/externals/coda-oss/modules/c++/except/include/except/Throwable.h index 2a7deecbb..84fe4d038 100644 --- a/externals/coda-oss/modules/c++/except/include/except/Throwable.h +++ b/externals/coda-oss/modules/c++/except/include/except/Throwable.h @@ -165,9 +165,7 @@ class CODA_OSS_API Throwable const Trace& t = getTrace(); if (t.getSize() > 0) s << ": " << t; - - std::string retval(s.str().c_str()); // truncate to first '\0' - return retval; + return s.str(); } const std::vector& getBacktrace() const noexcept @@ -267,7 +265,7 @@ class ThrowableEx : public Throwable // "ThrowableEx" = "Throwable exception" ThrowableEx(const Throwable& t, const Context& ctx) : Throwable(t, ctx) {} #if !CODA_OSS_except_Throwable_ISA_std_exception - const char* what() const noexcept override final // derived classes override toString() + const char* what() const noexcept final // derived classes override toString() { const Throwable* pThrowable = this; return pThrowable->what(); diff --git a/externals/coda-oss/modules/c++/except/source/Trace.cpp b/externals/coda-oss/modules/c++/except/source/Trace.cpp index a40645d71..926f321b4 100644 --- a/externals/coda-oss/modules/c++/except/source/Trace.cpp +++ b/externals/coda-oss/modules/c++/except/source/Trace.cpp @@ -26,9 +26,12 @@ namespace except { std::ostream& operator<<(std::ostream& os, const Trace& t) { - for (auto&& trace : t.getStack()) + const std::list& stack = t.getStack(); + + for (std::list::const_iterator it = stack.begin(); + it != stack.end(); ++it) { - os << trace << "\n"; + os << *it << std::endl; } return os; } diff --git a/externals/coda-oss/modules/c++/hdf5.lite/include/hdf5/lite/H5_.h b/externals/coda-oss/modules/c++/hdf5.lite/include/hdf5/lite/H5_.h index cd470aef2..74ebc436c 100644 --- a/externals/coda-oss/modules/c++/hdf5.lite/include/hdf5/lite/H5_.h +++ b/externals/coda-oss/modules/c++/hdf5.lite/include/hdf5/lite/H5_.h @@ -28,7 +28,6 @@ CODA_OSS_disable_warning_system_header_push #if _MSC_VER -#pragma warning(disable: 6313) // Incorrect operator. Use an equality test to check for zero-valued flags. #pragma warning(disable: 26493) // Don't use C-style casts (type.4). #pragma warning(disable: 26494) // Variable '...' is uninitialized. Always initialize an object (type.5). #pragma warning(disable: 26451) // Arithmetic overflow: Using operator '...' on a 4 byte value and then casting the result to a 8 byte value. Cast the value to the wider type before calling operator '...' to avoid overflow (io.2). @@ -57,8 +56,6 @@ CODA_OSS_disable_warning(-Wzero-as-null-pointer-constant) #include #include -#include -#include #include #include #include diff --git a/externals/coda-oss/modules/c++/hdf5.lite/source/H5.h b/externals/coda-oss/modules/c++/hdf5.lite/source/H5.h index ecfe293d1..24b0d8cfc 100644 --- a/externals/coda-oss/modules/c++/hdf5.lite/source/H5.h +++ b/externals/coda-oss/modules/c++/hdf5.lite/source/H5.h @@ -20,15 +20,16 @@ * */ -#pragma once #ifndef CODA_OSS_hdf5_lite_H5_h_INCLUDED_ #define CODA_OSS_hdf5_lite_H5_h_INCLUDED_ +#pragma once #include -#include "types/RowCol.h" +// see https://docs.hdfgroup.org/archive/support/HDF5/doc1.8/cpplus_RM/readdata_8cpp-example.html +#include -#include "hdf5/lite/H5_.h" +#include "types/RowCol.h" // Utility routines for INTERNAL use! diff --git a/externals/coda-oss/modules/c++/hdf5.lite/source/hdf5.lite.h b/externals/coda-oss/modules/c++/hdf5.lite/source/hdf5.lite.h index 29617ac23..fce6fb7c0 100644 --- a/externals/coda-oss/modules/c++/hdf5.lite/source/hdf5.lite.h +++ b/externals/coda-oss/modules/c++/hdf5.lite/source/hdf5.lite.h @@ -20,17 +20,18 @@ * */ -#pragma once #ifndef CODA_OSS_hdf5_lite_hdf5_lite_h_INCLUDED_ #define CODA_OSS_hdf5_lite_hdf5_lite_h_INCLUDED_ +#pragma once #include #include #include -#include "except/Exception.h" +// see https://docs.hdfgroup.org/archive/support/HDF5/doc1.8/cpplus_RM/readdata_8cpp-example.html +#include -#include "hdf5/lite/H5_.h" +#include "except/Exception.h" #include "hdf5/lite/HDF5Exception.h" // Utility routines for INTERNAL use! diff --git a/externals/coda-oss/modules/c++/hdf5.lite/unittests/test_highfive.cpp b/externals/coda-oss/modules/c++/hdf5.lite/unittests/test_highfive.cpp index b506e4948..14e9f8af2 100644 --- a/externals/coda-oss/modules/c++/hdf5.lite/unittests/test_highfive.cpp +++ b/externals/coda-oss/modules/c++/hdf5.lite/unittests/test_highfive.cpp @@ -29,8 +29,12 @@ #include "types/RowCol.h" #include "mem/ComplexView.h" -#include "hdf5/lite/highfive.h" +#include "highfive/H5Easy.hpp" +#include "highfive/H5DataSet.hpp" +#include "highfive/H5File.hpp" + #include "hdf5/lite/SpanRC.h" +#include "hdf5/lite/highfive.h" static std::filesystem::path find_unittest_file(const std::filesystem::path& name) { diff --git a/externals/coda-oss/modules/c++/include/TestCase.h b/externals/coda-oss/modules/c++/include/TestCase.h index 5a091dd9b..a43314004 100644 --- a/externals/coda-oss/modules/c++/include/TestCase.h +++ b/externals/coda-oss/modules/c++/include/TestCase.h @@ -211,7 +211,6 @@ inline int main(TFunc f) #define CODA_OSS_test_eq(X1, X2) (CODA_OSS_test_eq_(X1, X2) && !CODA_OSS_test_ne_(X1, X2)) #define TEST_ASSERT_EQ(X1, X2) if (!CODA_OSS_test_eq((X1), (X2))) { CODA_OSS_test_diePrintf_eq_(X1, X2); } #define TEST_ASSERT_EQ_MSG(msg, X1, X2) if (!CODA_OSS_test_eq((X1), (X2))) { CODA_OSS_test_diePrintf_eq_msg_(msg, X1, X2); } -#define TEST_ASSERT_EQ_STR(X1, X2) TEST_ASSERT_EQ(std::string(X1), std::string(X2)) #define TEST_ASSERT_NOT_EQ(X1, X2) if (!CODA_OSS_test_ne((X1), (X2))) { CODA_OSS_test_diePrintf_not_eq_(X1, X2); } #define TEST_ASSERT_NOT_EQ_MSG(msg, X1, X2) if (!CODA_OSS_test_ne((X1), (X2))) { CODA_OSS_test_diePrintf_not_eq_msg_(msg, X1, X2); } diff --git a/externals/coda-oss/modules/c++/include/UnitTest.h b/externals/coda-oss/modules/c++/include/UnitTest.h deleted file mode 100644 index 751843c1f..000000000 --- a/externals/coda-oss/modules/c++/include/UnitTest.h +++ /dev/null @@ -1,143 +0,0 @@ -#pragma once - -#include -#include - -#include "TestCase.h" -#include "str/EncodedStringView.h" - -#if !_MSC_VER -#error "This file is for use with a Visual Studio 'UnitTest' project." -#endif - -// Use our various TEST macros with a Visual Studio "UnitTest" project. -#include - -#undef TEST_CHECK -#undef TEST_ASSERT -#undef TEST_ASSERT_NULL -#undef TEST_ASSERT_NOT_NULL -#undef TEST_ASSERT_TRUE -#undef TEST_ASSERT_FALSE -#undef TEST_MAIN -#undef TEST_CASE -#define TEST_CHECK(X) -#define TEST_MAIN(X) -#define TEST_ASSERT_NULL(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNull(X) -#define TEST_ASSERT_NOT_NULL(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNotNull(X) -#define TEST_ASSERT_TRUE(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(X) -#define TEST_ASSERT_FALSE(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsFalse(X) -#define TEST_ASSERT(X) TEST_ASSERT_TRUE(X) -#define CODA_OSS_testMethod_(X) testMethod ## _ ## X -#define TEST_CASE(X) TEST_METHOD(X) { CODA_OSS_testMethod_(X)(#X); } void CODA_OSS_testMethod_(X)(std::string testName) - -namespace test -{ - struct Assert final - { - static void FailOnCondition(bool condition, const unsigned short* message, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo); - static std::wstring GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message); - }; -#define CODA_OSS_equals_message_(expected, actual, message) reinterpret_cast(test::Assert::GetAssertMessage(true, test::toString(expected), test::toString(actual), message).c_str()) -#define CODA_OSS_not_equals_message_(notExpected, actual, message) reinterpret_cast(test::Assert::GetAssertMessage(false, test::toString(notExpected), test::toString(actual), message).c_str()) -#define CODA_OSS_message_(message) reinterpret_cast(test::Assert::GetAssertMessage(false, "", "", message).c_str()) - -// see Assert::AreEqual<> -template -inline void diePrintf_eq(const TExpected& expected, const TActual& actual, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(expected == actual, CODA_OSS_equals_message_(expected, actual, message), pLineInfo); -} - -// see Assert::AreNotEqual<> -template -inline void diePrintf_ne(const TExpected& notExpected, const TActual& actual, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(notExpected != actual, CODA_OSS_not_equals_message_(notExpected, actual, message), pLineInfo); -} - -template -inline void diePrintf_ge(const TX1& X1, const TX2& X2, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(X1 >= X2, CODA_OSS_message_(message), pLineInfo); -} -template -inline void diePrintf_gt(const TX1& X1, const TX2& X2, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(X1 > X2, CODA_OSS_message_(message), pLineInfo); -} -template -inline void diePrintf_le(const TX1& X1, const TX2& X2, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(X1 <= X2, CODA_OSS_message_(message), pLineInfo); -} -template -inline void diePrintf_lt(const TX1& X1, const TX2& X2, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(X1 < X2, CODA_OSS_message_(message), pLineInfo); -} - -} -#undef CODA_OSS_test_diePrintf_eq_ -#undef CODA_OSS_test_diePrintf_not_eq_ -#define CODA_OSS_test_diePrintf_eq_(X1, X2) testName, ::test::diePrintf_eq(X1, X2) -#define CODA_OSS_test_diePrintf_not_eq_(X1, X2) testName, ::test::diePrintf_ne(X1, X2) - -#undef CODA_OSS_test_diePrintf_greater_eq_ -#undef CODA_OSS_test_diePrintf_greater_ -#undef CODA_OSS_test_diePrintf_lesser_eq_ -#undef CODA_OSS_test_diePrintf_lesser_ -#define CODA_OSS_test_diePrintf_greater_eq_(X1, X2) testName, ::test::diePrintf_ge(X1, X2) -#define CODA_OSS_test_diePrintf_greater_(X1, X2) testName, ::test::diePrintf_gt(X1, X2) -#define CODA_OSS_test_diePrintf_lesser_eq_(X1, X2) testName, ::test::diePrintf_le(X1, X2) -#define CODA_OSS_test_diePrintf_lesser_(X1, X2) testName, ::test::diePrintf_lt(X1, X2) - -template -inline void test_assert_greater_(const TX1& X1, const TX2& X2) -{ - Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(X1 > X2); -} -#undef TEST_ASSERT_GREATER -#define TEST_ASSERT_GREATER(X1, X2) testName, test_assert_greater_(X1, X2) - -#undef TEST_ASSERT_ALMOST_EQ_EPS -#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) { (void)testName; Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(X1, X2, EPS); Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(X2, X1, EPS); } -namespace test -{ -inline void assert_almost_eq(const std::string& testName, float X1, float X2) -{ - constexpr auto EPS = static_cast(0.0001); - TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS); -} -inline void assert_almost_eq(const std::string& testName, double X1, double X2) -{ - constexpr auto EPS = static_cast(0.0001); - TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS); -} -inline void assert_almost_eq(const std::string& testName, long double X1, long double X2) -{ - assert_almost_eq(testName, static_cast(X1), static_cast(X2)); -} -} - -#undef TEST_ASSERT_ALMOST_EQ -#define TEST_ASSERT_ALMOST_EQ(X1, X2) test::assert_almost_eq(testName, X1, X2) - -#undef TEST_ASSERT_EQ_MSG -#define TEST_ASSERT_EQ_MSG(msg, X1, X2) testName, Microsoft::VisualStudio::CppUnitTestFramework::Logger::WriteMessage(msg.c_str()); TEST_ASSERT_EQ(X1, X2) - -#undef TEST_FAIL_MSG -#define TEST_FAIL_MSG(msg) { (void)testName; Microsoft::VisualStudio::CppUnitTestFramework::Assert::Fail(str::EncodedStringView(msg).wstring().c_str()); } - -#undef TEST_EXCEPTION -#undef TEST_THROWS -#undef TEST_SPECIFIC_EXCEPTION -#define TEST_EXCEPTION(X) (void)testName; try{ (X); TEST_FAIL(#X " should have thrown."); } CODA_OSS_TEST_EXCEPTION_catch_ -#define TEST_THROWS(X) (void)testName; try{ (X); TEST_FAIL(#X " should have thrown."); } catch (...){ TEST_ASSERT_TRUE(true); } -#define TEST_SPECIFIC_EXCEPTION(X, Y) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::ExpectException([&](){(X);}) diff --git a/externals/coda-oss/modules/c++/math/tests/complexBenchmark.cpp b/externals/coda-oss/modules/c++/math/tests/complexBenchmark.cpp index 9484150c9..2de00abbc 100644 --- a/externals/coda-oss/modules/c++/math/tests/complexBenchmark.cpp +++ b/externals/coda-oss/modules/c++/math/tests/complexBenchmark.cpp @@ -217,7 +217,7 @@ void loopingBenchmark(size_t size, std::vector > arr(size); //fill the vector based on a random number - srand(static_cast(time(nullptr))); + srand(static_cast(time(NULL))); auto real = static_cast(rand() % 100 + 1); auto imag = static_cast(rand() % 100 + 1); @@ -321,7 +321,7 @@ void singlePassBenchmark(size_t size, std::vector > arr; arr.reserve(endSize); - srand(static_cast(time(nullptr))); + srand(static_cast(time(NULL))); auto real = static_cast(rand() % 100 + 1); auto imag = static_cast(rand() % 100 + 1); diff --git a/externals/coda-oss/modules/c++/math/tests/complexMultiplyBenchmark.cpp b/externals/coda-oss/modules/c++/math/tests/complexMultiplyBenchmark.cpp index 12ea42619..3f7b19ac9 100644 --- a/externals/coda-oss/modules/c++/math/tests/complexMultiplyBenchmark.cpp +++ b/externals/coda-oss/modules/c++/math/tests/complexMultiplyBenchmark.cpp @@ -199,7 +199,7 @@ void loopingBenchmark(size_t size, std::vector > arr(size); //fill the vector based on a random number - srand(static_cast(time(nullptr))); + srand(static_cast(time(NULL))); auto real = static_cast(rand() % 100 + 1); auto imag = static_cast(rand() % 100 + 1); @@ -297,7 +297,7 @@ void singlePassBenchmark(size_t size, std::vector > arr; arr.reserve(endSize); - srand(static_cast(time(nullptr))); + srand(static_cast(time(NULL))); auto real = static_cast(rand() % 100 + 1); auto imag = static_cast(rand() % 100 + 1); diff --git a/externals/coda-oss/modules/c++/mem/tests/ScratchVisualization.cpp b/externals/coda-oss/modules/c++/mem/tests/ScratchVisualization.cpp index 791964c72..20974a659 100644 --- a/externals/coda-oss/modules/c++/mem/tests/ScratchVisualization.cpp +++ b/externals/coda-oss/modules/c++/mem/tests/ScratchVisualization.cpp @@ -72,7 +72,7 @@ class Visualizer mHTMLFile(htmlFile), mCSSFile(cssFile) { - mStartPtr = nullptr; + mStartPtr = NULL; mColors.push_back("lightgrey"); mColors.push_back("lightblue"); mColors.push_back("lightcyan"); diff --git a/externals/coda-oss/modules/c++/mem/unittests/test_scratch_memory.cpp b/externals/coda-oss/modules/c++/mem/unittests/test_scratch_memory.cpp index 5186e8956..8ef51ee4f 100644 --- a/externals/coda-oss/modules/c++/mem/unittests/test_scratch_memory.cpp +++ b/externals/coda-oss/modules/c++/mem/unittests/test_scratch_memory.cpp @@ -617,7 +617,7 @@ TEST_CASE(testScratchMemory) TEST_EXCEPTION(scratch.setup(smallBuffer)); // calling setup with invalid external buffer should throw - mem::BufferView invalidBuffer(nullptr, buffer.size); + mem::BufferView invalidBuffer(NULL, buffer.size); TEST_EXCEPTION(scratch.setup(invalidBuffer)); } diff --git a/externals/coda-oss/modules/c++/mem/unittests/test_shared_ptr.cpp b/externals/coda-oss/modules/c++/mem/unittests/test_shared_ptr.cpp index 1441f4723..866df1eb7 100644 --- a/externals/coda-oss/modules/c++/mem/unittests/test_shared_ptr.cpp +++ b/externals/coda-oss/modules/c++/mem/unittests/test_shared_ptr.cpp @@ -69,19 +69,19 @@ size_t cpp11Function(std::shared_ptr foo) TEST_CASE(testNullCopying) { mem::SharedPtr ptr1; - TEST_ASSERT_EQ(ptr1.get(), static_cast(nullptr)); + TEST_ASSERT_EQ(ptr1.get(), static_cast(NULL)); // Copy construction const mem::SharedPtr ptr2(ptr1); - TEST_ASSERT_EQ(ptr2.get(), static_cast(nullptr)); + TEST_ASSERT_EQ(ptr2.get(), static_cast(NULL)); // Assignment operator mem::SharedPtr ptr3; ptr3 = ptr1; - TEST_ASSERT_EQ(ptr3.get(), static_cast(nullptr)); + TEST_ASSERT_EQ(ptr3.get(), static_cast(NULL)); ptr1.reset(); - TEST_ASSERT_EQ(ptr1.get(), static_cast(nullptr)); + TEST_ASSERT_EQ(ptr1.get(), static_cast(NULL)); } TEST_CASE(testAutoPtrConstructor) @@ -90,7 +90,7 @@ TEST_CASE(testAutoPtrConstructor) std::unique_ptr autoPtr(rawPtr); const mem::SharedPtr ptr(autoPtr.release()); TEST_ASSERT_EQ(ptr.get(), rawPtr); - TEST_ASSERT_EQ(autoPtr.get(), static_cast(nullptr)); + TEST_ASSERT_EQ(autoPtr.get(), static_cast(NULL)); //TEST_ASSERT_EQ(ptr.getCount(), 1); TEST_ASSERT_EQ(ptr.use_count(), 1); TEST_ASSERT_EQ(getCount(ptr), 1); @@ -287,7 +287,7 @@ TEST_CASE(testCasting) std::unique_ptr autoBar(rawBar); const mem::SharedPtr fooPtr(autoBar.release()); TEST_ASSERT_EQ(fooPtr.get(), rawBar); - TEST_ASSERT_EQ(autoBar.get(), static_cast(nullptr)); + TEST_ASSERT_EQ(autoBar.get(), static_cast(NULL)); //TEST_ASSERT_EQ(fooPtr.getCount(), 1); TEST_ASSERT_EQ(fooPtr.use_count(), 1); TEST_ASSERT_EQ(getCount(fooPtr), 1); diff --git a/externals/coda-oss/modules/c++/mt/include/import/mt.h b/externals/coda-oss/modules/c++/mt/include/import/mt.h index 2a35e189c..10caa17e6 100644 --- a/externals/coda-oss/modules/c++/mt/include/import/mt.h +++ b/externals/coda-oss/modules/c++/mt/include/import/mt.h @@ -21,14 +21,8 @@ */ -#pragma once -#ifndef CODA_OSS_mt_import_mt_h_h_INCLUDED_ -#define CODA_OSS_mt_import_mt_h_h_INCLUDED_ - -#if _MSC_VER -#pragma warning(push) -#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to 'extern "C"' function under - EHc.Undefined behavior may occur if this function throws an exception. -#endif // _MSC_VER +#ifndef __IMPORT_MT_H__ +#define __IMPORT_MT_H__ #include "mt/RequestQueue.h" #include "mt/ThreadPoolException.h" @@ -51,8 +45,4 @@ #include "mt/CPUAffinityThreadInitializer.h" #include "mt/Algorithm.h" -#if _MSC_VER -#pragma warning(pop) -#endif // _MSC_VER - -#endif // CODA_OSS_mt_import_mt_h_h_INCLUDED_ +#endif diff --git a/externals/coda-oss/modules/c++/net.ssl/source/SSLConnection.cpp b/externals/coda-oss/modules/c++/net.ssl/source/SSLConnection.cpp index 903fa077d..75c7f5e03 100644 --- a/externals/coda-oss/modules/c++/net.ssl/source/SSLConnection.cpp +++ b/externals/coda-oss/modules/c++/net.ssl/source/SSLConnection.cpp @@ -45,11 +45,11 @@ net::ssl::SSLConnection::SSLConnection(std::unique_ptr&& socket, net::ssl::SSLConnection::~SSLConnection() { - if(mSSL != nullptr) + if(mSSL != NULL) { SSL_shutdown(mSSL); } - if(mSSL != nullptr) + if(mSSL != NULL) { SSL_free(mSSL); } diff --git a/externals/coda-oss/modules/c++/net/tests/AckMulticastSender.cpp b/externals/coda-oss/modules/c++/net/tests/AckMulticastSender.cpp index e02d52752..a5c97008a 100644 --- a/externals/coda-oss/modules/c++/net/tests/AckMulticastSender.cpp +++ b/externals/coda-oss/modules/c++/net/tests/AckMulticastSender.cpp @@ -143,8 +143,8 @@ template class AckMulticastSender //FD_SET(mAckChannel->getHandle(), &writers); assert(FD_ISSET(mAckChannel->getHandle(), &readers)); //int rv = 1; - int rv = ::select(mAckChannel->getHandle() + 1, &readers, nullptr, - nullptr, &tv); + int rv = ::select(mAckChannel->getHandle() + 1, &readers, NULL, + NULL, &tv); if (rv < 0) { throw sys::SocketException(Ctxt("Select failed")); diff --git a/externals/coda-oss/modules/c++/net/tests/NetConnectionServerTest.cpp b/externals/coda-oss/modules/c++/net/tests/NetConnectionServerTest.cpp index ed72a907b..bcbb46ac1 100644 --- a/externals/coda-oss/modules/c++/net/tests/NetConnectionServerTest.cpp +++ b/externals/coda-oss/modules/c++/net/tests/NetConnectionServerTest.cpp @@ -76,7 +76,7 @@ int main(int argc, char **argv) if (argc < 2) throw Exception(FmtX("Usage: %s (-mt|-st|-tp)", argv[0])); - net::AllocStrategy* strategy = nullptr; + net::AllocStrategy* strategy = NULL; if (argc == 3) { diff --git a/externals/coda-oss/modules/c++/net/tests/TCPClientTest.cpp b/externals/coda-oss/modules/c++/net/tests/TCPClientTest.cpp index 0ca69b276..47a9c10a0 100644 --- a/externals/coda-oss/modules/c++/net/tests/TCPClientTest.cpp +++ b/externals/coda-oss/modules/c++/net/tests/TCPClientTest.cpp @@ -60,7 +60,7 @@ int main(int argc, char** argv) std::unique_ptr socket = TCPClientSocketFactory().create(sa); my_packet_t packet; packet.packet_no = 1; - packet.time_stamp = time(nullptr); + packet.time_stamp = time(NULL); socket->send(&packet, sizeof(my_packet_t)); int rv; socket->recv(&rv, sizeof(int)); diff --git a/externals/coda-oss/modules/c++/net/tests/UDPClientTest.cpp b/externals/coda-oss/modules/c++/net/tests/UDPClientTest.cpp index ae2e28ba2..76fed3372 100644 --- a/externals/coda-oss/modules/c++/net/tests/UDPClientTest.cpp +++ b/externals/coda-oss/modules/c++/net/tests/UDPClientTest.cpp @@ -66,7 +66,7 @@ int main(int argc, char** argv) std::unique_ptr socket = UDPClientSocketFactory().create(sa); my_packet_t packet; packet.packet_no = 1; - packet.time_stamp = time(nullptr); + packet.time_stamp = time(NULL); socket->send((const char*)&packet, sizeof(my_packet_t)); int rv; socket->recv((char*)&rv, sizeof(int)); diff --git a/externals/coda-oss/modules/c++/numpyutils/include/numpyutils/numpyutils.h b/externals/coda-oss/modules/c++/numpyutils/include/numpyutils/numpyutils.h index 4632913dd..fec9e9e64 100644 --- a/externals/coda-oss/modules/c++/numpyutils/include/numpyutils/numpyutils.h +++ b/externals/coda-oss/modules/c++/numpyutils/include/numpyutils/numpyutils.h @@ -20,40 +20,14 @@ * */ -#pragma once #ifndef __NUMPYUTILS_NUMPYUTILS_H__ #define __NUMPYUTILS_NUMPYUTILS_H__ #define NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION #include -CODA_OSS_disable_warning_system_header_push -#if _MSC_VER -#pragma warning(disable: 26493) // Don't use C-style casts (type.4). -#pragma warning(disable: 26494) // Variable '...' is uninitialized. Always initialize an object (type.5). -#pragma warning(disable: 26451) // Arithmetic overflow: Using operator '...' on a 4 byte value and then casting the result to a 8 byte value. Cast the value to the wider type before calling operator '...' to avoid overflow (io.2). -#pragma warning(disable: 26814) // The const variable '...' can be computed at compile-time. Consider using constexpr (con.5). -#pragma warning(disable: 26447) // The function is declared '...' but calls function '...' which may throw exceptions (f.6). -#pragma warning(disable: 26455) // Default constructor should not throw. Declare it '...' (f.6). -#pragma warning(disable: 26440) // Function '...' can be declared '...' (f.6). -#pragma warning(disable: 26496) // The variable '...' does not change after construction, mark it as const (con.4). -#pragma warning(disable: 26462) // The value pointed to by '...' is assigned only once, mark it as a pointer to const (con.4). -#pragma warning(disable: 26435) // Function '...' should specify exactly one of '...', '...', or '...' (c.128). -#pragma warning(disable: 26433) // Function '...' should be marked with '...' (c.128). -#pragma warning(disable: 26497) // You can attempt to make '...' constexpr unless it contains any undefined behavior (f.4). -#pragma warning(disable: 26433) // Function '...' should be marked with '...' (c.128). -#pragma warning(disable: 26456) // Operator '...' hides a non-virtual operator '...' (c.128). -#pragma warning(disable: 26446) // Prefer to use gsl::at() instead of unchecked subscript operator (bounds.4). -#pragma warning(disable: 26477) // Use '...' rather than 0 or NULL(es .47). -#pragma warning(disable: 26457) // (void) should not be used to ignore return values, use '...' instead (es.48). -#pragma warning(disable: 26813) // Use '...' to check if a flag is set. -#else -CODA_OSS_disable_warning(-Wshadow) -CODA_OSS_disable_warning(-Wsuggest-override) -CODA_OSS_disable_warning(-Wzero-as-null-pointer-constant) -#endif - #include +CODA_OSS_disable_warning_system_header_push #include CODA_OSS_disable_warning_pop diff --git a/externals/coda-oss/modules/c++/numpyutils/source/numpyutils.cpp b/externals/coda-oss/modules/c++/numpyutils/source/numpyutils.cpp index 31a2452c2..53b8b97b1 100644 --- a/externals/coda-oss/modules/c++/numpyutils/source/numpyutils.cpp +++ b/externals/coda-oss/modules/c++/numpyutils/source/numpyutils.cpp @@ -25,9 +25,6 @@ #ifndef _MSC_VER CODA_OSS_disable_warning(-Wold-style-cast) -CODA_OSS_disable_warning(-Wshadow) -CODA_OSS_disable_warning(-Wsuggest-override) -CODA_OSS_disable_warning(-Wzero-as-null-pointer-constant) #endif #include #include @@ -39,12 +36,18 @@ CODA_OSS_disable_warning(-Wzero-as-null-pointer-constant) * https://mail.scipy.org/pipermail/numpy-discussion/2010-December/054350.html * for the source and some discussion */ -static_assert(PY_MAJOR_VERSION >= 3, "Python 3.x required"); +#if PY_MAJOR_VERSION >= 3 void* init_numpy() { import_array(); return nullptr; } +#else +void init_numpy() +{ + import_array(); +} +#endif /* Numpy uses some static variables which are per-compilation * unit and if import_arrays is not called, will segfault on using any of diff --git a/externals/coda-oss/modules/c++/pch.h b/externals/coda-oss/modules/c++/pch.h index 18067f14d..f39484bc2 100644 --- a/externals/coda-oss/modules/c++/pch.h +++ b/externals/coda-oss/modules/c++/pch.h @@ -33,29 +33,32 @@ CODA_OSS_disable_warning_pop #include #include -#pragma comment(lib, "z.lib") -#pragma comment(lib, "minizip.lib") - #include #pragma warning(disable: 4251) // '...': class '...' needs to have dll-interface to be used by clients of class '...' #pragma warning(disable: 4365) // '...': conversion from '...' to '...', signed/unsigned mismatch #pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to '...' function under -EHc. Undefined behavior may occur if this function throws an exception. +#pragma warning(disable: 6326) // Potential comparison of a constant with another constant. #pragma warning(disable: 6054) // String '...' might not be zero-terminated. #pragma warning(disable: 6387) // '...' could be '...'. #pragma warning(disable: 6305) // Potential mismatch between sizeof and countof quantities. Use sizeof() to scale byte sizes. +#pragma warning(disable: 6288) // Incorrect operator. Did you intend to use || instead? +#pragma warning(disable: 6011) // Dereferencing NULL pointer '...'. +#pragma warning(disable: 6313) // Incorrect operator. Use an equality test to check for zero-valued flags. #pragma warning(disable: 6389) // Move '...' to anonymous namespace or put a forward declaration in a common header included in this file. -#pragma warning(disable: 26822) // Dereferencing a null pointer '...' (lifetime.1). #pragma warning(disable: 26432) // If you define or delete any default operation in the type '...', define or delete them all (c.21). #pragma warning(disable: 26429) // Symbol '...' is never tested for nullness, it can be marked as not_null (f.23). #pragma warning(disable: 26455) // Default constructor should not throw. Declare it '...' (f.6). #pragma warning(disable: 26440) // Function '...' can be declared '...' (f.6). #pragma warning(disable: 26447) // The function is declared '...' but calls function '...' which may throw exceptions (f.6). +#pragma warning(disable: 26446) // Prefer to use gsl::at() instead of unchecked subscript operator (bounds.4). +#pragma warning(disable: 26481) // Don't use pointer arithmetic. Use span instead (bounds.1). #pragma warning(disable: 26496) // The variable '...' does not change after construction, mark it as const (con.4). #pragma warning(disable: 26462) // The value pointed to by '...' is assigned only once, mark it as a pointer to const (con.4). #pragma warning(disable: 26409) // Avoid calling new and delete explicitly, use std::make_unique instead (r.11). #pragma warning(disable: 26401) // Do not delete a raw pointer that is not an owner (i.11). +#pragma warning(disable: 26482) // Only index into arrays using constant expressions (bounds.2). #pragma warning(disable: 26472) // Don't use a static_cast for arithmetic conversions. Use brace initialization, gsl::narrow_cast or gsl::narrow (type.1). #pragma warning(disable: 26485) // Expression '...': No array to pointer decay (bounds.3). #pragma warning(disable: 26493) // Don't use C-style casts (type.4). @@ -93,10 +96,8 @@ CODA_OSS_disable_warning_pop #pragma warning(disable: 26823) // Dereferencing a possibly null pointer '...' (lifetime.1). #pragma warning(disable: 26487) // Don't return a pointer '...' that may be invalid (lifetime.4). #pragma warning(disable: 26812) // The enum type '...' is unscoped. Prefer '...' over '...' (Enum.3). -#pragma warning(disable: 26446) // Prefer to use gsl::at() instead of unchecked subscript operator (bounds.4). +#pragma warning(disable: 26822) // Dereferencing a null pointer '...' (lifetime.1). #pragma warning(disable: 26458) // Prefer to use gsl::at() instead of unchecked subscript operator (bounds.4). -#pragma warning(disable: 26482) // Only index into arrays using constant expressions (bounds.2). -#pragma warning(disable: 26481) // Don't use pointer arithmetic. Use span instead (bounds.1). // Yes, these are our files ... but they don't change very often, and if they do // change we want to rebuild everything anyway. @@ -106,11 +107,7 @@ CODA_OSS_disable_warning_pop #include "sys/Conf.h" #include "sys/filesystem.h" #include "mem/SharedPtr.h" - #include "xml/lite/xerces_.h" -#pragma comment(lib, "xerces-c") - #include "hdf5/lite/H5_.h" -#pragma comment(lib, "hdf5-c++.lib") #endif //CODA_OSS_pch_h_INCLUDED_ diff --git a/externals/coda-oss/modules/c++/re/include/re/Regex.h b/externals/coda-oss/modules/c++/re/include/re/Regex.h index e4338972a..d7dd55dd2 100644 --- a/externals/coda-oss/modules/c++/re/include/re/Regex.h +++ b/externals/coda-oss/modules/c++/re/include/re/Regex.h @@ -214,7 +214,7 @@ class CODA_OSS_API Regex size_t& end); //! The pcre object - pcre2_code* mPCRE = nullptr; + pcre2_code* mPCRE; #endif }; } diff --git a/externals/coda-oss/modules/c++/re/source/RegexPCRE.cpp b/externals/coda-oss/modules/c++/re/source/RegexPCRE.cpp index d70885e3e..479d1fac7 100644 --- a/externals/coda-oss/modules/c++/re/source/RegexPCRE.cpp +++ b/externals/coda-oss/modules/c++/re/source/RegexPCRE.cpp @@ -55,9 +55,9 @@ class ScopedMatchData // to do. ScopedMatchData(const pcre2_code* code) : mCode(code), - mMatchData(pcre2_match_data_create_from_pattern(code, nullptr)) + mMatchData(pcre2_match_data_create_from_pattern(code, NULL)) { - if (mMatchData == nullptr) + if (mMatchData == NULL) { throw re::RegexException(Ctxt( "pcre2_match_data_create_from_pattern() failed to " @@ -95,7 +95,7 @@ class ScopedMatchData startOffset, options, mMatchData, - nullptr); // Match context + NULL); // Match context if (returnCode == PCRE2_ERROR_NOMATCH) { @@ -156,7 +156,7 @@ class ScopedMatchData namespace re { Regex::Regex(const std::string& pattern) : - mPattern(pattern), mPCRE(nullptr) + mPattern(pattern), mPCRE(NULL) { if (!mPattern.empty()) { @@ -166,10 +166,10 @@ Regex::Regex(const std::string& pattern) : void Regex::destroy() { - if (mPCRE != nullptr) + if (mPCRE != NULL) { pcre2_code_free(mPCRE); - mPCRE = nullptr; + mPCRE = NULL; } } @@ -179,7 +179,7 @@ Regex::~Regex() } Regex::Regex(const Regex& rhs) : - mPattern(rhs.mPattern), mPCRE(nullptr) + mPattern(rhs.mPattern), mPCRE(NULL) { compile(mPattern); } @@ -218,9 +218,9 @@ Regex& Regex::compile(const std::string& pattern) FLAGS, &errorCode, &errorOffset, - nullptr); // Use default compile context + NULL); // Use default compile context - if (mPCRE == nullptr) + if (mPCRE == NULL) { std::ostringstream ostr; ostr << "PCRE compilation failed at offset " << errorOffset diff --git a/externals/coda-oss/modules/c++/str/source/EncodedStringView.cpp b/externals/coda-oss/modules/c++/str/source/EncodedStringView.cpp index 6bd00eef4..385293601 100644 --- a/externals/coda-oss/modules/c++/str/source/EncodedStringView.cpp +++ b/externals/coda-oss/modules/c++/str/source/EncodedStringView.cpp @@ -85,29 +85,26 @@ static std::string to_native(str::W1252string::const_pointer p, size_t sz) throw std::logic_error("Unknown platform."); } -template -inline auto make_span(const Char8T* s, size_t c) +template +inline coda_oss::span make_span(const CharT* s, size_t c) { - static_assert(sizeof(Char8T) == sizeof(char), "sizeof(Char8T) != sizeof(char)"); - return coda_oss::span(s, c); + return coda_oss::span(s, c); } -template -inline auto make_span(const Char8T* s) +template +inline coda_oss::span make_span(const CharT* s) { - auto const s_ = str::cast(s); + auto s_ = str::cast(s); return make_span(s, strlen(s_)); } -template -inline auto make_span(const std::basic_string& s) +template +inline coda_oss::span make_span(const std::basic_string& s) { - assert(strlen(str::c_str(s)) == s.length()); - return make_span(s.c_str(), s.length()); + return make_span(s.c_str(), s.size()); } -template -inline auto make_span(coda_oss::span s) +template +inline coda_oss::span make_span(coda_oss::span s) { - auto const s_ = str::cast(s.data()); - assert(strlen(s_) == s.size()); + auto s_ = str::cast(s.data()); return coda_oss::span(s_, s.size()); } diff --git a/externals/coda-oss/modules/c++/sys/include/sys/OS.h b/externals/coda-oss/modules/c++/sys/include/sys/OS.h index 7a16c53e5..6ea40c83f 100644 --- a/externals/coda-oss/modules/c++/sys/include/sys/OS.h +++ b/externals/coda-oss/modules/c++/sys/include/sys/OS.h @@ -21,12 +21,10 @@ */ -#pragma once -#ifndef CODA_OSS_sys_OS_h_INCLUDED_ -#define CODA_OSS_sys_OS_h_INCLUDED_ +#ifndef __SYS_OS_H__ +#define __SYS_OS_H__ #include "sys/AbstractOS.h" -#include "sys/Conf.h" #ifdef _WIN32 # include "sys/OSWin32.h" @@ -49,34 +47,19 @@ typedef DirectoryUnix Directory; // and also squelches compiler-warnings about unused local functions. namespace sys { -enum class PlatformType -{ - Windows, - Linux, - // MacOS -}; + enum class PlatformType + { + Windows, + Linux, + //MacOS + }; -#if defined(_WIN32) -constexpr auto Platform = PlatformType::Windows; -#elif defined(CODA_OSS_POSIX2008_SOURCE) -constexpr auto Platform = PlatformType::Linux; -#else -#error "Unknown platform." -#endif - -template -inline std::string platformName(); -template <> -inline std::string platformName() -{ - return "Windows"; -} -template <> -inline std::string platformName() -{ - return "linux-gnu"; + #ifdef _WIN32 + constexpr auto Platform = PlatformType::Windows; + #else + constexpr auto Platform = PlatformType::Linux; + #endif } -} +#endif -#endif // CODA_OSS_sys_OS_h_INCLUDED_ \ No newline at end of file diff --git a/externals/coda-oss/modules/c++/sys/source/AbstractOS.cpp b/externals/coda-oss/modules/c++/sys/source/AbstractOS.cpp index d1cd33306..e32b44d87 100644 --- a/externals/coda-oss/modules/c++/sys/source/AbstractOS.cpp +++ b/externals/coda-oss/modules/c++/sys/source/AbstractOS.cpp @@ -480,7 +480,14 @@ std::string AbstractOS::getSpecialEnv(const std::string& envVar) const if (envVar == "OSTYPE") { - return sys::platformName(); + // TODO: Mac + return sys::Platform == sys::PlatformType::Linux ? " linux-gnu" : "Windows"; + } + + if (envVar == "OSTYPE") + { + // TODO: Mac + return sys::Platform == sys::PlatformType::Linux ? " linux-gnu" : "Windows"; } // should explicitly handle all env. vars in some way diff --git a/externals/coda-oss/modules/c++/sys/source/ConditionVarPosix.cpp b/externals/coda-oss/modules/c++/sys/source/ConditionVarPosix.cpp index d1e288629..505a17634 100644 --- a/externals/coda-oss/modules/c++/sys/source/ConditionVarPosix.cpp +++ b/externals/coda-oss/modules/c++/sys/source/ConditionVarPosix.cpp @@ -32,7 +32,7 @@ sys::ConditionVarPosix::ConditionVarPosix() : mMutexOwned(std::make_unique()), mMutex(mMutexOwned.get()) { - if ( ::pthread_cond_init(&mNative, nullptr) != 0) + if ( ::pthread_cond_init(&mNative, NULL) != 0) throw SystemException("ConditionVar initialization failed"); } @@ -41,7 +41,7 @@ sys::ConditionVarPosix::ConditionVarPosix(MutexPosix* theLock, bool isOwner, std if (isOwner) mMutexOwned.reset(theLock); - if (::pthread_cond_init(&mNative, nullptr) != 0) + if (::pthread_cond_init(&mNative, NULL) != 0) throw SystemException("ConditionVar initialization failed"); } sys::ConditionVarPosix::ConditionVarPosix(sys::MutexPosix* theLock, bool isOwner) : ConditionVarPosix(theLock, isOwner, nullptr) @@ -87,7 +87,7 @@ void sys::ConditionVarPosix::wait(double seconds) if ( seconds > 0 ) { timespec tout; - tout.tv_sec = time(nullptr) + gsl::narrow_cast(seconds); + tout.tv_sec = time(NULL) + gsl::narrow_cast(seconds); tout.tv_nsec = gsl::narrow_cast((seconds - gsl::narrow_cast(seconds)) * 1e9); if (::pthread_cond_timedwait(&mNative, &(mMutex->getNative()), diff --git a/externals/coda-oss/modules/c++/sys/source/CppUnitTestAssert_.cpp_ b/externals/coda-oss/modules/c++/sys/source/CppUnitTestAssert_.cpp_ deleted file mode 100644 index fdcf5f92b..000000000 --- a/externals/coda-oss/modules/c++/sys/source/CppUnitTestAssert_.cpp_ +++ /dev/null @@ -1,43 +0,0 @@ -#include "pch.h" -#include "TestCase.h" - -#include "str/EncodedStringView.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -// EQUALS_MESSAGE() wants ToString() specializations (or overloads) for our types, which is a nusiance. -// This hooks up our existing str::toString() into the VC++ unit-test infrastructure - -// C++ hack to call private methods -// https://stackoverflow.com/a/71578383/8877 - -using FailOnCondition_t = void(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare method's type -using GetAssertMessage_t = std::wstring(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare method's type -template -struct caller final // helper structure to inject call() code -{ - friend void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) - { - fFailOnCondition(condition, message, pLineInfo); - } - - friend std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message) - { - return fGetAssertMessage(equality, expected, actual, message); - } -}; -template struct caller<&Assert::FailOnCondition, &Assert::GetAssertMessage>; // even instantiation of the helper - -void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare caller -void test::Assert::FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) -{ - ::FailOnCondition(condition, message, pLineInfo); // and call! -} - -std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare caller -std::wstring test::Assert::GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message) -{ - const str::EncodedStringView vExpected(expected); - const str::EncodedStringView vActual(actual); - return ::GetAssertMessage(equality, vExpected.wstring(), vActual.wstring(), message); // and call! -} diff --git a/externals/coda-oss/modules/c++/sys/source/DLLUnix.cpp b/externals/coda-oss/modules/c++/sys/source/DLLUnix.cpp index 6ef817453..f43457e69 100644 --- a/externals/coda-oss/modules/c++/sys/source/DLLUnix.cpp +++ b/externals/coda-oss/modules/c++/sys/source/DLLUnix.cpp @@ -66,7 +66,7 @@ DLL_FUNCTION_PTR sys::DLL::retrieve(const std::string& functionName) { // Check to make sure we have a library - if ( mLib != nullptr ) + if ( mLib != NULL ) { // Now we get a ptr DLL_FUNCTION_PTR ptr = dlsym( mLib , functionName.c_str()); diff --git a/externals/coda-oss/modules/c++/sys/source/DateTime.cpp b/externals/coda-oss/modules/c++/sys/source/DateTime.cpp index a79b9bb8c..e0f411d5b 100644 --- a/externals/coda-oss/modules/c++/sys/source/DateTime.cpp +++ b/externals/coda-oss/modules/c++/sys/source/DateTime.cpp @@ -394,7 +394,7 @@ static double getNowInMillis() return (now.tv_sec + 1.0e-9 * now.tv_nsec) * 1000; #elif CODA_OSS_POSIX_SOURCE struct timeval now; - gettimeofday(&now,nullptr); + gettimeofday(&now,NULL); return (now.tv_sec + 1.0e-6 * now.tv_usec) * 1000; #elif _WIN32 // Getting time twice may be inefficient but is quicker diff --git a/externals/coda-oss/modules/c++/sys/source/ExecUnix.cpp b/externals/coda-oss/modules/c++/sys/source/ExecUnix.cpp index a31bd6023..24ea23103 100644 --- a/externals/coda-oss/modules/c++/sys/source/ExecUnix.cpp +++ b/externals/coda-oss/modules/c++/sys/source/ExecUnix.cpp @@ -104,7 +104,7 @@ FILE* ExecPipe::openPipe(const std::string& command, // command the user specified execl("/bin/sh", "sh", "-c", command.c_str(), - static_cast(nullptr)); + static_cast(NULL)); //! exit the subprocess once it has completed exit(127); diff --git a/externals/coda-oss/modules/c++/sys/source/FileFinder.cpp b/externals/coda-oss/modules/c++/sys/source/FileFinder.cpp index b33cc47c4..6b47dda79 100644 --- a/externals/coda-oss/modules/c++/sys/source/FileFinder.cpp +++ b/externals/coda-oss/modules/c++/sys/source/FileFinder.cpp @@ -208,17 +208,6 @@ std::vector sys::FileFinder::search( return files; } -static fs::path parent_path(const fs::path& p) -{ - // If the parent_path() is the same, we've reached to root. - const auto retval = p.parent_path(); - if (retval.empty() || (retval == p)) - { - throw std::runtime_error("At root of filesystem: " + p.string()); - } - return retval; -} - static fs::path findFirst(const sys::FilePredicate& pred, const fs::path& startingDirectory) { auto dir = startingDirectory; @@ -239,8 +228,7 @@ static fs::path findFirst(const sys::FilePredicate& pred, const fs::path& starti { throw std::logic_error("Won't traverse above .git directory at: " + dir.string()); } - - dir = parent_path(dir); + dir = dir.parent_path(); } } fs::path sys::findFirstFile(const fs::path& startingDirectory, const fs::path& filename) @@ -309,7 +297,7 @@ fs::path sys::test::findRootDirectory(const fs::path& p, const std::string& root // Once we're at a .git directory, we have to go down, not up ... or fail. if (!is_directory(p / ".git")) { - return findRootDirectory(parent_path(p), rootName, isRoot); + return findRootDirectory(p.parent_path(), rootName, isRoot); } // TODO: since we're in the "FileFinder" module, maybe try a bit harder to find "rootName"? @@ -328,7 +316,7 @@ static inline std::string Platform() static fs::path findCMakeRoot(const fs::path& path, const fs::path& dir) { - static const auto platform_and_configuration = ::Platform() + "-" + ::Configuration(); // "x64-Debug" + static const auto platform_and_configuration = ::Platform() + "-" + ::Configuration(); // "x64-Debug" const auto pred = [&](const fs::path& p) { if (p.filename() == platform_and_configuration) @@ -350,7 +338,7 @@ static fs::path findCMakeRoot(const fs::path& path, const fs::path& dir) return false; }; - return sys::test::findRootDirectory(path, "", pred); + return sys::test::findRootDirectory(path, "", pred); } fs::path findCMake_Root(const fs::path& path, @@ -416,8 +404,13 @@ static fs::path find_dotGITDirectory_(const fs::path& p, const fs::path& initial { return p; } - - return find_dotGITDirectory_(parent_path(p), initial); + + auto parent = p.parent_path(); + if (parent.empty()) + { + throw std::invalid_argument("Can't find .git/ anywhere in: " + initial.string()); + } + return find_dotGITDirectory_(parent, initial); } fs::path sys::test::find_dotGITDirectory(const fs::path& p) { diff --git a/externals/coda-oss/modules/c++/sys/source/MutexPosix.cpp b/externals/coda-oss/modules/c++/sys/source/MutexPosix.cpp index d28418444..f28ce93be 100644 --- a/externals/coda-oss/modules/c++/sys/source/MutexPosix.cpp +++ b/externals/coda-oss/modules/c++/sys/source/MutexPosix.cpp @@ -28,7 +28,7 @@ sys::MutexPosix::MutexPosix() { - if (::pthread_mutex_init(&mNative, nullptr) != 0) + if (::pthread_mutex_init(&mNative, NULL) != 0) throw sys::SystemException("Mutex initialization failed"); } diff --git a/externals/coda-oss/modules/c++/sys/source/OSUnix.cpp b/externals/coda-oss/modules/c++/sys/source/OSUnix.cpp index c9241b639..e2b96cf18 100644 --- a/externals/coda-oss/modules/c++/sys/source/OSUnix.cpp +++ b/externals/coda-oss/modules/c++/sys/source/OSUnix.cpp @@ -308,7 +308,7 @@ std::string sys::OSUnix::getEnv(const std::string& s) const bool sys::OSUnix::isEnvSet(const std::string& s) const { const char* envVal = getenv(s.c_str()); - return envVal != nullptr; + return (envVal != NULL); } void sys::OSUnix::setEnv(const std::string& var, diff --git a/externals/coda-oss/modules/c++/sys/source/ScopedCPUAffinityUnix.cpp b/externals/coda-oss/modules/c++/sys/source/ScopedCPUAffinityUnix.cpp index e409b3b03..2b7fbc844 100644 --- a/externals/coda-oss/modules/c++/sys/source/ScopedCPUAffinityUnix.cpp +++ b/externals/coda-oss/modules/c++/sys/source/ScopedCPUAffinityUnix.cpp @@ -64,7 +64,7 @@ void ScopedCPUMaskUnix::initialize(int numCPUs) ScopedCPUMaskUnix::~ScopedCPUMaskUnix() { - if (mMask != nullptr) + if (mMask != NULL) { CPU_FREE(mMask); } diff --git a/externals/coda-oss/modules/c++/sys/source/ThreadPosix.cpp b/externals/coda-oss/modules/c++/sys/source/ThreadPosix.cpp index c399b5c83..4ee1f2411 100644 --- a/externals/coda-oss/modules/c++/sys/source/ThreadPosix.cpp +++ b/externals/coda-oss/modules/c++/sys/source/ThreadPosix.cpp @@ -80,7 +80,7 @@ void *sys::ThreadPosix::__start(void *v) delete runnable; */ - pthread_exit(nullptr); + pthread_exit(NULL); return nullptr; } @@ -94,7 +94,7 @@ void sys::ThreadPosix::kill() } void sys::ThreadPosix::join() { - if (::pthread_join(mNative, nullptr) != 0) + if (::pthread_join(mNative, NULL) != 0) throw sys::SystemException("pthread_join()"); } void sys::ThreadPosix::yield() diff --git a/externals/coda-oss/modules/c++/sys/tests/DateTimeTest.cpp b/externals/coda-oss/modules/c++/sys/tests/DateTimeTest.cpp index b2c5597f0..f47fc3387 100644 --- a/externals/coda-oss/modules/c++/sys/tests/DateTimeTest.cpp +++ b/externals/coda-oss/modules/c++/sys/tests/DateTimeTest.cpp @@ -54,7 +54,7 @@ int main(int, char**) sys::CPUStopWatch csw; //std::cout << "CPS: " << CLOCKS_PER_SEC << std::endl; std::cout << "clock(): " << clock() / CLOCKS_PER_SEC << std::endl; - std::cout << "time(): " << time(nullptr) << std::endl; + std::cout << "time(): " << time(NULL) << std::endl; std::cout << "RTStart: " << sw.start() << std::endl; std::cout << "CStart: " << csw.start() << std::endl; int x = 0; @@ -82,7 +82,7 @@ int main(int, char**) } std::cout << "Finish Loop 3" << std::endl; std::cout << "clock(): " << clock() / CLOCKS_PER_SEC << std::endl; - std::cout << "time(): " << time(nullptr) << std::endl; + std::cout << "time(): " << time(NULL) << std::endl; std::cout << "RTStop: " << std::setprecision(50) << sw.stop() << std::endl; std::cout << "CStop: " << std::setprecision(50) << csw.stop() diff --git a/externals/coda-oss/modules/c++/sys/tests/OSTest.cpp b/externals/coda-oss/modules/c++/sys/tests/OSTest.cpp index 330493eb7..f8ee1ea5a 100644 --- a/externals/coda-oss/modules/c++/sys/tests/OSTest.cpp +++ b/externals/coda-oss/modules/c++/sys/tests/OSTest.cpp @@ -110,7 +110,7 @@ int main(int argc, char **argv) } os.remove("TEST_DIRECTORY"); - std::cout << "Time Now: " << time(nullptr) << std::endl; + std::cout << "Time Now: " << time(NULL) << std::endl; sys::RealTimeStopWatch sw; //std::cout << "CPS: " << CLOCKS_PER_SEC << std::endl; // std::cout << "Clock: " << clock() << std::endl; @@ -137,7 +137,7 @@ int main(int argc, char **argv) std::cout << "Finish Loop 3" << std::endl; std::cout << "Stop: " << std::setprecision(50) << sw.stop() << std::endl; - std::cout << "Time Now: " << time(nullptr) << std::endl; + std::cout << "Time Now: " << time(NULL) << std::endl; // std::cout << "Clock: " << clock() << std::endl; } diff --git a/externals/coda-oss/modules/c++/tiff/source/IFDEntry.cpp b/externals/coda-oss/modules/c++/tiff/source/IFDEntry.cpp index d9f5447dd..1ac612aea 100644 --- a/externals/coda-oss/modules/c++/tiff/source/IFDEntry.cpp +++ b/externals/coda-oss/modules/c++/tiff/source/IFDEntry.cpp @@ -120,7 +120,8 @@ void tiff::IFDEntry::deserialize(io::InputStream& input, const bool reverseBytes { auto elementSize = tiff::Const::sizeOf(mType); sys::Uint32_T numElements = mCount; - if ((mType == tiff::Const::Type::RATIONAL) || (mType == tiff::Const::Type::SRATIONAL)) + if (mType == tiff::Const::Type::RATIONAL && mType + == tiff::Const::Type::SRATIONAL) { elementSize = tiff::Const::sizeOf(mType) / 2; numElements = mCount * 2; diff --git a/externals/coda-oss/modules/c++/types/include/types/Complex.h b/externals/coda-oss/modules/c++/types/include/types/Complex.h index 8b2218ff4..46daa0f85 100644 --- a/externals/coda-oss/modules/c++/types/include/types/Complex.h +++ b/externals/coda-oss/modules/c++/types/include/types/Complex.h @@ -221,9 +221,9 @@ static_assert(sizeof(std::complex) == sizeof(Complex), "sizeof(siz static_assert(std::is_same, ComplexReal>::value, "should be std::complex"); // Convenient aliases -using zfloat = ComplexReal; // i.e., std::complex -using zdouble = ComplexReal; // i.e., std::complex -//using zlong_double = ComplexReal; // i.e., std::complex +using zfloat = ComplexReal; // std::complex +using zdouble = ComplexReal; // std::complex +//using zlong_double = ComplexReal; // std::complex using zint8_t = ComplexInteger; // Complex using zint16_t = ComplexInteger; // Complex using zint32_t = ComplexInteger; // Complex diff --git a/externals/coda-oss/modules/c++/xml.lite/include/import/xml/lite.h b/externals/coda-oss/modules/c++/xml.lite/include/import/xml/lite.h index b7b66bca8..477e27c80 100644 --- a/externals/coda-oss/modules/c++/xml.lite/include/import/xml/lite.h +++ b/externals/coda-oss/modules/c++/xml.lite/include/import/xml/lite.h @@ -20,9 +20,39 @@ * */ -#pragma once #ifndef CODA_OSS_xml_lite_import_lite_h_INCLUDED_ #define CODA_OSS_xml_lite_import_lite_h_INCLUDED_ +#pragma once + +#if _MSC_VER +#pragma warning(push) +// these are from Xerces +#pragma warning(disable: 5219) // implicit conversion from '...' to '...', possible loss of data +#pragma warning(disable: 4365) // '...': conversion from '...' to '...', signed / unsigned mismatch +#pragma warning(disable: 26477) // Use 'nullptr' rather than 0 or NULL (es.47). +#pragma warning(disable: 26493) // Don't use C-style casts (type.4). +#pragma warning(disable: 26814) // The const variable '...' can be computed at compile-time. Consider using constexpr (con.5). +#pragma warning(disable: 26496) // The variable '...' does not change after construction, mark it as const (con.4). +#pragma warning(disable: 26497) // The function '...' could be marked constexpr if compile-time evaluation is desired (f.4). +#pragma warning(disable: 26475) // Do not use function style casts (es.49). Prefer '...' over '...'. +#pragma warning(disable: 26495) // Variable '...' is uninitialized. Always initialize a member variable (type.6). +#pragma warning(disable: 26461) // The pointer argument '...' for function '...' can be marked as a pointer to const (con.3). +#pragma warning(disable: 26462) // The value pointed to by '...' is assigned only once, mark it as a pointer to const (con.4). +#pragma warning(disable: 26494) // Variable '...' is uninitialized. Always initialize an object (type.5). +#pragma warning(disable: 26489) // Don't dereference a pointer that may be invalid: '...'. '...' may have been invalidated at line ... (lifetime.1). +#pragma warning(disable: 26488) // Do not dereference a potentially null pointer : ...'. '...' was null at line ... (lifetime.1). +#pragma warning(disable: 26447) // The function is declared '...' but calls function '..' which may throw exceptions (f.6). +#pragma warning(disable: 26485) // Expression '...': No array to pointer decay (bounds.3). +#pragma warning(disable: 26457) // (void) should not be used to ignore return values, use '...' instead (es.48). +#pragma warning(disable: 26487) // Don't return a pointer '...' that may be invalid (lifetime.4). +#pragma warning(disable: 26451) // Arithmetic overflow : Using operator '...' on a 4 byte value and then casting the result to a 8 byte value. Cast the value to the wider type before calling operator '...' to avoid overflow (io.2). +#pragma warning(disable: 26455) // Default constructor may not throw.Declare it 'noexcept' (f.6). +#pragma warning(disable: 26409) // Avoid calling new and delete explicitly, use std::make_unique instead (r.11). +#pragma warning(disable: 26429) // Symbol '...' is never tested for nullness, it can be marked as not_null(f.23). +#pragma warning(disable: 26400) // Do not assign the result of an allocation or a function call with an owner return value to a raw pointer, use owner instead(i.11). +#pragma warning(disable: 26467) // Converting from floating point to unsigned integral types results in non-portable code if the double/float has a negative value. Use gsl::narrow_cast or gsl::narrow instead to guard against undefined behavior and potential data loss (es.46). +#pragma warning(disable: 26823) // Dereferencing a possibly null pointer '...' (lifetime.1). +#endif // _MSC_VER #include "xml/lite/ContentHandler.h" #include "xml/lite/Attributes.h" @@ -37,6 +67,16 @@ #include "xml/lite/Serializable.h" #include "xml/lite/Validator.h" +#if _MSC_VER +#pragma warning(pop) + +#pragma comment(lib, "xml.lite-c++.lib") + +#if defined(USE_XERCES) +#pragma comment(lib, "xerces-c") +#endif +#endif + /*! * \file lite.h * diff --git a/externals/coda-oss/modules/c++/xml.lite/include/xml/lite/xerces_.h b/externals/coda-oss/modules/c++/xml.lite/include/xml/lite/xerces_.h index b35fc4714..51d2ca436 100644 --- a/externals/coda-oss/modules/c++/xml.lite/include/xml/lite/xerces_.h +++ b/externals/coda-oss/modules/c++/xml.lite/include/xml/lite/xerces_.h @@ -54,11 +54,6 @@ CODA_OSS_disable_warning_system_header_push CODA_OSS_disable_warning(-Wshadow) CODA_OSS_disable_warning(-Wsuggest-override) CODA_OSS_disable_warning(-Wzero-as-null-pointer-constant) -CODA_OSS_disable_warning(-Wmisleading-indentation) -CODA_OSS_disable_warning(-Wsign-compare) -CODA_OSS_disable_warning(-Wformat-overflow=) -CODA_OSS_disable_warning(-Wunused-value) -CODA_OSS_disable_warning(-Walloc-size-larger-than=) #endif #include diff --git a/externals/coda-oss/modules/c++/xml.lite/source/Serializable.cpp b/externals/coda-oss/modules/c++/xml.lite/source/Serializable.cpp index 27cb7aaf0..d5f55479c 100644 --- a/externals/coda-oss/modules/c++/xml.lite/source/Serializable.cpp +++ b/externals/coda-oss/modules/c++/xml.lite/source/Serializable.cpp @@ -26,10 +26,8 @@ void xml::lite::Serializable::serialize(io::OutputStream& os) { xml::lite::Element *root = getDocument()->getRootElement(); if (root != nullptr) - { os.write("\n"); - root->print(os); - } + root->print(os); } void xml::lite::Serializable::deserialize(io::InputStream& is) diff --git a/externals/coda-oss/modules/c++/zip/source/ZipOutputStream.cpp b/externals/coda-oss/modules/c++/zip/source/ZipOutputStream.cpp index 2b9bd903e..f4e09e34c 100644 --- a/externals/coda-oss/modules/c++/zip/source/ZipOutputStream.cpp +++ b/externals/coda-oss/modules/c++/zip/source/ZipOutputStream.cpp @@ -48,9 +48,9 @@ void ZipOutputStream::createFileInZip(const std::string& pathname, mZip, pathname.c_str(), &zipFileInfo, - nullptr, + NULL, 0, - nullptr, + NULL, 0, comment.empty() ? nullptr : comment.c_str(), Z_DEFLATED, From 704e17e7b037053b9ff3cb391b92ac8e2b27f6fe Mon Sep 17 00:00:00 2001 From: "J. Daniel Smith" Date: Mon, 17 Jul 2023 22:30:04 -0400 Subject: [PATCH 094/104] slam-in develop/sync_externals --- .../.github/workflows/build_unittest.yml | 41 ++++- externals/coda-oss/ReleaseNotes.md | 10 +- .../coda-oss/UnitTest/CppUnitTestAssert.cpp | 42 +---- externals/coda-oss/UnitTest/TestCase.h | 137 +---------------- externals/coda-oss/UnitTest/UnitTest.vcxproj | 10 +- externals/coda-oss/coda-oss.sln | 8 + .../coda-oss/modules/c++/coda-oss.vcxproj | 21 ++- .../modules/c++/coda-oss.vcxproj.filters | 9 ++ .../c++/dbi/source/MySQLConnection.cpp | 2 +- .../c++/dbi/source/OracleConnection.cpp | 10 +- .../c++/dbi/source/PgSQLConnection.cpp | 2 +- .../c++/except/include/except/Throwable.h | 6 +- .../modules/c++/except/source/Trace.cpp | 7 +- .../c++/hdf5.lite/include/hdf5/lite/H5_.h | 3 + .../modules/c++/hdf5.lite/source/H5.h | 7 +- .../modules/c++/hdf5.lite/source/hdf5.lite.h | 7 +- .../c++/hdf5.lite/unittests/test_highfive.cpp | 6 +- .../coda-oss/modules/c++/include/TestCase.h | 1 + .../coda-oss/modules/c++/include/UnitTest.h | 143 ++++++++++++++++++ .../c++/math/tests/complexBenchmark.cpp | 4 +- .../math/tests/complexMultiplyBenchmark.cpp | 4 +- .../c++/mem/tests/ScratchVisualization.cpp | 2 +- .../c++/mem/unittests/test_scratch_memory.cpp | 2 +- .../c++/mem/unittests/test_shared_ptr.cpp | 12 +- .../modules/c++/mt/include/import/mt.h | 16 +- .../c++/net.ssl/source/SSLConnection.cpp | 4 +- .../c++/net/tests/AckMulticastSender.cpp | 4 +- .../c++/net/tests/NetConnectionServerTest.cpp | 2 +- .../modules/c++/net/tests/TCPClientTest.cpp | 2 +- .../modules/c++/net/tests/UDPClientTest.cpp | 2 +- .../include/numpyutils/numpyutils.h | 28 +++- .../c++/numpyutils/source/numpyutils.cpp | 11 +- externals/coda-oss/modules/c++/pch.h | 19 ++- .../modules/c++/re/include/re/Regex.h | 2 +- .../modules/c++/re/source/RegexPCRE.cpp | 18 +-- .../c++/str/source/EncodedStringView.cpp | 27 ++-- .../coda-oss/modules/c++/sys/include/sys/OS.h | 45 ++++-- .../modules/c++/sys/source/AbstractOS.cpp | 9 +- .../c++/sys/source/ConditionVarPosix.cpp | 6 +- .../c++/sys/source/CppUnitTestAssert_.cpp_ | 43 ++++++ .../modules/c++/sys/source/DLLUnix.cpp | 2 +- .../modules/c++/sys/source/DateTime.cpp | 2 +- .../modules/c++/sys/source/ExecUnix.cpp | 2 +- .../modules/c++/sys/source/FileFinder.cpp | 29 ++-- .../modules/c++/sys/source/MutexPosix.cpp | 2 +- .../modules/c++/sys/source/OSUnix.cpp | 2 +- .../c++/sys/source/ScopedCPUAffinityUnix.cpp | 2 +- .../modules/c++/sys/source/ThreadPosix.cpp | 4 +- .../modules/c++/sys/tests/DateTimeTest.cpp | 4 +- .../coda-oss/modules/c++/sys/tests/OSTest.cpp | 4 +- .../modules/c++/tiff/source/IFDEntry.cpp | 3 +- .../modules/c++/types/include/types/Complex.h | 6 +- .../c++/xml.lite/include/import/xml/lite.h | 42 +---- .../c++/xml.lite/include/xml/lite/xerces_.h | 5 + .../c++/xml.lite/source/Serializable.cpp | 4 +- .../c++/zip/source/ZipOutputStream.cpp | 4 +- 56 files changed, 464 insertions(+), 387 deletions(-) create mode 100644 externals/coda-oss/modules/c++/include/UnitTest.h create mode 100644 externals/coda-oss/modules/c++/sys/source/CppUnitTestAssert_.cpp_ diff --git a/externals/coda-oss/.github/workflows/build_unittest.yml b/externals/coda-oss/.github/workflows/build_unittest.yml index 04b2f3fae..b96a17a63 100644 --- a/externals/coda-oss/.github/workflows/build_unittest.yml +++ b/externals/coda-oss/.github/workflows/build_unittest.yml @@ -36,8 +36,7 @@ jobs: cd .. cd target-Debug cmake --build . --config Debug -j - - name: test - # should run w/o install + - name: test # should run w/o install run: | cd target-Release ctest -C Release --output-on-failure @@ -52,17 +51,43 @@ jobs: cd target-Debug cmake --build . --config Debug --target install cd .. + + build-msbuild-windows: + strategy: + matrix: + os: [windows-latest] + platform: [x64] + configuration: [Debug] # Debug turns on more compiler warnings + name: ${{ matrix.os }}-msbuild + runs-on: ${{ matrix.os }} + + steps: + - uses: actions/checkout@v3 + - name: configure + run: | + ls env: + mkdir out + cd out + cmake .. -DCMAKE_INSTALL_PREFIX=install\${{ matrix.platform }}-${{ matrix.configuration }} -DENABLE_PYTHON=OFF + - name: build + run: | + cd out + cmake --build . --config ${{ matrix.configuration }} -j + cmake --build . --config ${{ matrix.configuration }} --target install - name: Add msbuild to PATH - uses: microsoft/setup-msbuild@v1.1 + uses: microsoft/setup-msbuild@v1 # https://github.com/marketplace/actions/setup-msbuild with: msbuild-architecture: x64 - name: msbuild run: | - msbuild coda-oss.sln /p:configuration=Release - msbuild coda-oss.sln /p:configuration=Debug - #- name: mstest - # run: | - # mstest /testcontainer:${RUNNER_WORKSPACE}\coda-oss\x64\Debug\UnitTest.dll + msbuild coda-oss.sln /p:configuration=${{ matrix.configuration }} + # Can't figure out how to make this work :-( + #- name: vstest + # uses: microsoft/vstest-action@v1.0.0 # https://github.com/marketplace/actions/vstest-action + # with: + # testAssembly: UnitTest.dll + # searchFolder: D:\a\nitro\nitro\${{ matrix.platform }}\${{ matrix.configuration }} + # runInParallel: true build-linux-cmake: strategy: diff --git a/externals/coda-oss/ReleaseNotes.md b/externals/coda-oss/ReleaseNotes.md index bf8f97f3a..c54bdadcb 100644 --- a/externals/coda-oss/ReleaseNotes.md +++ b/externals/coda-oss/ReleaseNotes.md @@ -18,16 +18,16 @@ * wrap common "file open" routines (e.g., `fopen()`) to support `sys::expandEnvironmentVariables()`. * add header-only [HighFive](https://github.com/BlueBrain/HighFive) HDF5-wrapper library. * Added a handful of [HighFive](https://github.com/BlueBrain/HighFive) utility routines. -* `mt::transform_async()` removed, it doesn't match C++17 techniques.' +* `mt::transform_async()` removed, it doesn't match C++17 techniques. * Revamp `sys::byteSwap()` for improved type-safety and [better performance](https://devblogs.microsoft.com/cppblog/a-tour-of-4-msvc-backend-improvements/). - * Added case-insensitive string comparison utilties: `str::eq()` and `str::ne()`; + * Added case-insensitive string comparison utilities: `str::eq()` and `str::ne()`; `xml::lite::Uri`s compare case-insensitive. ## [Release 2022-12-14](https://github.com/mdaus/coda-oss/releases/tag/2022-12-14) * removed remaining vestiges of `std::auto_ptr`, provide `mem::AutoPtr` for the tiny handful of places (e.g., SWIG bindings) that still need copying. -* `xml::lite::Element` overloads to make creting new XML documents easier; see unittests for examples. +* `xml::lite::Element` overloads to make creating new XML documents easier; see unittests for examples. * try even harder to find unittest files in various scenarios. * build *hdf5.lite* with **waf**. * New `--optz=fastest-possible` (**waf** only) which adds @@ -40,8 +40,8 @@ * The [HDFGroup](https://hdfgroup.org/)s [HDF5 library](https://github.com/HDFGroup/hdf5) is built and installed; a simple (and very incomplete!) wrapper is provided, this is at the "hello world!" stage. * A few **cli** routines have been tweaked to make unit-testing easier. -* Utilitiy routines for finding various files when unit-testing. -* Removed C++14 work-arounds needed in C++11. Legacy C++ exception specificatons removed. +* Utility routines for finding various files when unit-testing. +* Removed C++14 work-arounds needed in C++11. Legacy C++ exception specifications removed. * Rebuild `waf` for FIPS error; added more debug options. ## [Release 2022-08-30](https://github.com/mdaus/coda-oss/releases/tag/2022-08-30) diff --git a/externals/coda-oss/UnitTest/CppUnitTestAssert.cpp b/externals/coda-oss/UnitTest/CppUnitTestAssert.cpp index fdcf5f92b..5bea8da59 100644 --- a/externals/coda-oss/UnitTest/CppUnitTestAssert.cpp +++ b/externals/coda-oss/UnitTest/CppUnitTestAssert.cpp @@ -1,43 +1,5 @@ #include "pch.h" #include "TestCase.h" -#include "str/EncodedStringView.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -// EQUALS_MESSAGE() wants ToString() specializations (or overloads) for our types, which is a nusiance. -// This hooks up our existing str::toString() into the VC++ unit-test infrastructure - -// C++ hack to call private methods -// https://stackoverflow.com/a/71578383/8877 - -using FailOnCondition_t = void(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare method's type -using GetAssertMessage_t = std::wstring(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare method's type -template -struct caller final // helper structure to inject call() code -{ - friend void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) - { - fFailOnCondition(condition, message, pLineInfo); - } - - friend std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message) - { - return fGetAssertMessage(equality, expected, actual, message); - } -}; -template struct caller<&Assert::FailOnCondition, &Assert::GetAssertMessage>; // even instantiation of the helper - -void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare caller -void test::Assert::FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) -{ - ::FailOnCondition(condition, message, pLineInfo); // and call! -} - -std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare caller -std::wstring test::Assert::GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message) -{ - const str::EncodedStringView vExpected(expected); - const str::EncodedStringView vActual(actual); - return ::GetAssertMessage(equality, vExpected.wstring(), vActual.wstring(), message); // and call! -} +// Can't get this to build in the **coda-oss** project. +#include "sys/source/CppUnitTestAssert_.cpp_" diff --git a/externals/coda-oss/UnitTest/TestCase.h b/externals/coda-oss/UnitTest/TestCase.h index f4438821f..e769f584f 100644 --- a/externals/coda-oss/UnitTest/TestCase.h +++ b/externals/coda-oss/UnitTest/TestCase.h @@ -1,138 +1,3 @@ #pragma once -#include -#include - -#include "CppUnitTest.h" -#include -#include - -#undef TEST_CHECK -#undef TEST_ASSERT -#undef TEST_ASSERT_NULL -#undef TEST_ASSERT_NOT_NULL -#undef TEST_ASSERT_TRUE -#undef TEST_ASSERT_FALSE -#undef TEST_MAIN -#undef TEST_CASE -#define TEST_CHECK(X) -#define TEST_MAIN(X) -#define TEST_ASSERT_NULL(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNull(X) -#define TEST_ASSERT_NOT_NULL(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNotNull(X) -#define TEST_ASSERT_TRUE(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(X) -#define TEST_ASSERT_FALSE(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsFalse(X) -#define TEST_ASSERT(X) TEST_ASSERT_TRUE(X) -#define CODA_OSS_testMethod_(X) testMethod ## _ ## X -#define TEST_CASE(X) TEST_METHOD(X) { CODA_OSS_testMethod_(X)(#X); } void CODA_OSS_testMethod_(X)(std::string testName) - -namespace test -{ - struct Assert final - { - static void FailOnCondition(bool condition, const unsigned short* message, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo); - static std::wstring GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message); - }; -#define CODA_OSS_equals_message_(expected, actual, message) reinterpret_cast(test::Assert::GetAssertMessage(true, test::toString(expected), test::toString(actual), message).c_str()) -#define CODA_OSS_not_equals_message_(notExpected, actual, message) reinterpret_cast(test::Assert::GetAssertMessage(false, test::toString(notExpected), test::toString(actual), message).c_str()) -#define CODA_OSS_message_(message) reinterpret_cast(test::Assert::GetAssertMessage(false, "", "", message).c_str()) - -// see Assert::AreEqual<> -template -inline void diePrintf_eq(const TExpected& expected, const TActual& actual, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(expected == actual, CODA_OSS_equals_message_(expected, actual, message), pLineInfo); -} - -// see Assert::AreNotEqual<> -template -inline void diePrintf_ne(const TExpected& notExpected, const TActual& actual, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(notExpected != actual, CODA_OSS_not_equals_message_(notExpected, actual, message), pLineInfo); -} - -template -inline void diePrintf_ge(const TX1& X1, const TX2& X2, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(X1 >= X2, CODA_OSS_message_(message), pLineInfo); -} -template -inline void diePrintf_gt(const TX1& X1, const TX2& X2, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(X1 > X2, CODA_OSS_message_(message), pLineInfo); -} -template -inline void diePrintf_le(const TX1& X1, const TX2& X2, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(X1 <= X2, CODA_OSS_message_(message), pLineInfo); -} -template -inline void diePrintf_lt(const TX1& X1, const TX2& X2, - const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) -{ - Assert::FailOnCondition(X1 < X2, CODA_OSS_message_(message), pLineInfo); -} - -} -#undef CODA_OSS_test_diePrintf_eq_ -#undef CODA_OSS_test_diePrintf_not_eq_ -#define CODA_OSS_test_diePrintf_eq_(X1, X2) testName, ::test::diePrintf_eq(X1, X2) -#define CODA_OSS_test_diePrintf_not_eq_(X1, X2) testName, ::test::diePrintf_ne(X1, X2) - -#undef CODA_OSS_test_diePrintf_greater_eq_ -#undef CODA_OSS_test_diePrintf_greater_ -#undef CODA_OSS_test_diePrintf_lesser_eq_ -#undef CODA_OSS_test_diePrintf_lesser_ -#define CODA_OSS_test_diePrintf_greater_eq_(X1, X2) testName, ::test::diePrintf_ge(X1, X2) -#define CODA_OSS_test_diePrintf_greater_(X1, X2) testName, ::test::diePrintf_gt(X1, X2) -#define CODA_OSS_test_diePrintf_lesser_eq_(X1, X2) testName, ::test::diePrintf_le(X1, X2) -#define CODA_OSS_test_diePrintf_lesser_(X1, X2) testName, ::test::diePrintf_lt(X1, X2) - -template -inline void test_assert_greater_(const TX1& X1, const TX2& X2) -{ - Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(X1 > X2); -} -#undef TEST_ASSERT_GREATER -#define TEST_ASSERT_GREATER(X1, X2) testName, test_assert_greater_(X1, X2) - -#undef TEST_ASSERT_ALMOST_EQ_EPS -#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) { (void)testName; Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(X1, X2, EPS); Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(X2, X1, EPS); } -namespace test -{ -inline void assert_almost_eq(const std::string& testName, float X1, float X2) -{ - constexpr auto EPS = static_cast(0.0001); - TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS); -} -inline void assert_almost_eq(const std::string& testName, double X1, double X2) -{ - constexpr auto EPS = static_cast(0.0001); - TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS); -} -inline void assert_almost_eq(const std::string& testName, long double X1, long double X2) -{ - assert_almost_eq(testName, static_cast(X1), static_cast(X2)); -} -} - -#undef TEST_ASSERT_ALMOST_EQ -#define TEST_ASSERT_ALMOST_EQ(X1, X2) test::assert_almost_eq(testName, X1, X2) - -#undef TEST_ASSERT_EQ_MSG -#define TEST_ASSERT_EQ_MSG(msg, X1, X2) testName, Microsoft::VisualStudio::CppUnitTestFramework::Logger::WriteMessage(msg.c_str()); TEST_ASSERT_EQ(X1, X2) - -#undef TEST_FAIL_MSG -#define TEST_FAIL_MSG(msg) { (void)testName; const str::EncodedStringView vw(msg); Microsoft::VisualStudio::CppUnitTestFramework::Assert::Fail(vw.wstring().c_str()); } - -#undef TEST_EXCEPTION -#undef TEST_THROWS -#undef TEST_SPECIFIC_EXCEPTION -#define TEST_EXCEPTION(X) (void)testName; try{ (X); TEST_FAIL(#X " should have thrown."); } CODA_OSS_TEST_EXCEPTION_catch_ -#define TEST_THROWS(X) (void)testName; try{ (X); TEST_FAIL(#X " should have thrown."); } catch (...){ TEST_ASSERT_TRUE(true); } -#define TEST_SPECIFIC_EXCEPTION(X, Y) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::ExpectException([&](){(X);}) - +#include diff --git a/externals/coda-oss/UnitTest/UnitTest.vcxproj b/externals/coda-oss/UnitTest/UnitTest.vcxproj index 65b3ca322..835f574dc 100644 --- a/externals/coda-oss/UnitTest/UnitTest.vcxproj +++ b/externals/coda-oss/UnitTest/UnitTest.vcxproj @@ -57,7 +57,7 @@ Use Level4 true - $(VCInstallDir)UnitTest\include;$(ProjectDir);$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\avx\include\;$(SolutionDir)modules\c++\cli\include\;$(SolutionDir)modules\c++\config\include\;$(SolutionDir)modules\c++\coda_oss\include\;$(SolutionDir)modules\c++\gsl\include\;$(SolutionDir)modules\c++\hdf5.lite\include\;$(SolutionDir)modules\c++\io\include\;$(SolutionDir)modules\c++\std\include\;$(SolutionDir)modules\c++\str\include\;$(SolutionDir)modules\c++\sys\include\;$(SolutionDir)modules\c++\except\include\;$(SolutionDir)modules\c++\logging\include\;$(SolutionDir)modules\c++\math\include\;$(SolutionDir)modules\c++\math.linear\include\;$(SolutionDir)modules\c++\math.poly\include\;$(SolutionDir)modules\c++\mem\include\;$(SolutionDir)modules\c++\mt\include\;$(SolutionDir)modules\c++\polygon\include\;$(SolutionDir)modules\c++\re\include\;$(SolutionDir)modules\c++\types\include\;$(SolutionDir)modules\c++\units\include\;$(SolutionDir)modules\c++\xml.lite\include\;$(SolutionDir)modules\c++\zip\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;%(AdditionalIncludeDirectories) + $(VCInstallDir)UnitTest\include;$(ProjectDir);$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\avx\include;$(SolutionDir)modules\c++\cli\include;$(SolutionDir)modules\c++\config\include;$(SolutionDir)modules\c++\coda_oss\include;$(SolutionDir)modules\c++\gsl\include;$(SolutionDir)modules\c++\hdf5.lite\include;$(SolutionDir)modules\c++\io\include;$(SolutionDir)modules\c++\std\include;$(SolutionDir)modules\c++\str\include;$(SolutionDir)modules\c++\sys\include;$(SolutionDir)modules\c++\except\include;$(SolutionDir)modules\c++\logging\include;$(SolutionDir)modules\c++\math\include;$(SolutionDir)modules\c++\math.linear\include;$(SolutionDir)modules\c++\math.poly\include;$(SolutionDir)modules\c++\mem\include;$(SolutionDir)modules\c++\mt\include;$(SolutionDir)modules\c++\polygon\include;$(SolutionDir)modules\c++\re\include;$(SolutionDir)modules\c++\types\include;$(SolutionDir)modules\c++\units\include;$(SolutionDir)modules\c++\xml.lite\include;$(SolutionDir)modules\c++\zip\include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;%(AdditionalIncludeDirectories) _DEBUG;%(PreprocessorDefinitions);MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 true pch.h @@ -65,7 +65,6 @@ true Guard ProgramDatabase - true true true true @@ -75,7 +74,7 @@ Windows - $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;$(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) + $(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) @@ -85,13 +84,12 @@ true true true - $(VCInstallDir)UnitTest\include;$(ProjectDir);$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\avx\include\;$(SolutionDir)modules\c++\cli\include\;$(SolutionDir)modules\c++\config\include\;$(SolutionDir)modules\c++\coda_oss\include\;$(SolutionDir)modules\c++\gsl\include\;$(SolutionDir)modules\c++\hdf5.lite\include\;$(SolutionDir)modules\c++\io\include\;$(SolutionDir)modules\c++\std\include\;$(SolutionDir)modules\c++\str\include\;$(SolutionDir)modules\c++\sys\include\;$(SolutionDir)modules\c++\except\include\;$(SolutionDir)modules\c++\logging\include\;$(SolutionDir)modules\c++\math\include\;$(SolutionDir)modules\c++\math.linear\include\;$(SolutionDir)modules\c++\math.poly\include\;$(SolutionDir)modules\c++\mem\include\;$(SolutionDir)modules\c++\mt\include\;$(SolutionDir)modules\c++\polygon\include\;$(SolutionDir)modules\c++\re\include\;$(SolutionDir)modules\c++\types\include\;$(SolutionDir)modules\c++\units\include\;$(SolutionDir)modules\c++\xml.lite\include\;$(SolutionDir)modules\c++\zip\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\;%(AdditionalIncludeDirectories) + $(VCInstallDir)UnitTest\include;$(ProjectDir);$(SolutionDir)modules\c++\;$(SolutionDir)modules\c++\avx\include;$(SolutionDir)modules\c++\cli\include;$(SolutionDir)modules\c++\config\include;$(SolutionDir)modules\c++\coda_oss\include;$(SolutionDir)modules\c++\gsl\include;$(SolutionDir)modules\c++\hdf5.lite\include;$(SolutionDir)modules\c++\io\include;$(SolutionDir)modules\c++\std\include;$(SolutionDir)modules\c++\str\include;$(SolutionDir)modules\c++\sys\include;$(SolutionDir)modules\c++\except\include;$(SolutionDir)modules\c++\logging\include;$(SolutionDir)modules\c++\math\include;$(SolutionDir)modules\c++\math.linear\include;$(SolutionDir)modules\c++\math.poly\include;$(SolutionDir)modules\c++\mem\include;$(SolutionDir)modules\c++\mt\include;$(SolutionDir)modules\c++\polygon\include;$(SolutionDir)modules\c++\re\include;$(SolutionDir)modules\c++\types\include;$(SolutionDir)modules\c++\units\include;$(SolutionDir)modules\c++\xml.lite\include;$(SolutionDir)modules\c++\zip\include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;%(AdditionalIncludeDirectories) NDEBUG;%(PreprocessorDefinitions);MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 true pch.h true Guard - true true true true @@ -103,7 +101,7 @@ Windows true true - $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\;$(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) + $(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories) diff --git a/externals/coda-oss/coda-oss.sln b/externals/coda-oss/coda-oss.sln index 5583590dd..cea89c6f0 100644 --- a/externals/coda-oss/coda-oss.sln +++ b/externals/coda-oss/coda-oss.sln @@ -15,6 +15,11 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution EndProject Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "UnitTest", "UnitTest\UnitTest.vcxproj", "{34A31B3F-47C5-441D-AB22-3C85B3C5314E}" EndProject +Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".github-workflows", ".github-workflows", "{E0FA1194-0806-4A6B-A331-33CB43C0C946}" + ProjectSection(SolutionItems) = preProject + .github\workflows\build_unittest.yml = .github\workflows\build_unittest.yml + EndProjectSection +EndProject Global GlobalSection(SolutionConfigurationPlatforms) = preSolution Debug|x64 = Debug|x64 @@ -33,6 +38,9 @@ Global GlobalSection(SolutionProperties) = preSolution HideSolutionNode = FALSE EndGlobalSection + GlobalSection(NestedProjects) = preSolution + {E0FA1194-0806-4A6B-A331-33CB43C0C946} = {DEB848DD-4285-4BFA-9B2F-60FA46200205} + EndGlobalSection GlobalSection(ExtensibilityGlobals) = postSolution SolutionGuid = {3CAB4AC9-7865-44AD-8623-57905729A559} EndGlobalSection diff --git a/externals/coda-oss/modules/c++/coda-oss.vcxproj b/externals/coda-oss/modules/c++/coda-oss.vcxproj index b0c706116..cd7468965 100644 --- a/externals/coda-oss/modules/c++/coda-oss.vcxproj +++ b/externals/coda-oss/modules/c++/coda-oss.vcxproj @@ -60,6 +60,7 @@ + @@ -146,6 +147,7 @@ + @@ -526,6 +528,10 @@ + + true + true + 16.0 @@ -574,27 +580,27 @@ true _DEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL;MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 pch.h - cli\include\;coda_oss\include;config\include\;dbi\include\;except\include\;gsl\include\;hdf5.lite\include\;io\include\;logging\include\;math\include\;math.linear\include\;math.poly\include\;mem\include\;mt\include\;net\include\;net.ssl\include\;plugin\include\;polygon\include\;re\include\;sio.lite\include\;std\include\;str\include\;sys\include\;tiff\include;types\include\;unique\include\;units\include\;xml.lite\include\;zip\include\;$(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ + cli\include;coda_oss\include;config\include;dbi\include;except\include;gsl\include;hdf5.lite\include;io\include;logging\include;math\include;math.linear\include;math.poly\include;mem\include;mt\include;net\include;net.ssl\include;plugin\include;polygon\include;re\include;sio.lite\include;std\include;str\include;sys\include;tiff\include;types\include;unique\include;units\include;xml.lite\include;zip\include;$(ProjectDir)include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;$(SolutionDir)externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\include Use pch.h true Guard ProgramDatabase - true true true true /Zc:__cplusplus %(AdditionalOptions) true AdvancedVectorExtensions2 + MultiThreadedDebugDLL true true - $(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\ - hdf5-c++.lib;z.lib;minizip.lib;xerces-c.lib;rpcrt4.lib;%(AdditionalDependencies) + $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib;$(SolutionDir)\externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\lib + rpcrt4.lib;%(AdditionalDependencies) @@ -605,12 +611,11 @@ true NDEBUG;_LIB;%(PreprocessorDefinitions);CODA_OSS_EXPORTS;CODA_OSS_DLL;MT_DEFAULT_PINNING=0;RE_ENABLE_STD_REGEX=1 pch.h - cli\include\;coda_oss\include;config\include\;dbi\include\;except\include\;gsl\include\;hdf5.lite\include\;io\include\;logging\include\;math\include\;math.linear\include\;math.poly\include\;mem\include\;mt\include\;net\include\;net.ssl\include\;plugin\include\;polygon\include\;re\include\;sio.lite\include\;std\include\;str\include\;sys\include\;tiff\include;types\include\;unique\include\;units\include\;xml.lite\include\;zip\include\;$(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\include\ + cli\include;coda_oss\include;config\include;dbi\include;except\include;gsl\include;hdf5.lite\include;io\include;logging\include;math\include;math.linear\include;math.poly\include;mem\include;mt\include;net\include;net.ssl\include;plugin\include;polygon\include;re\include;sio.lite\include;std\include;str\include;sys\include;tiff\include;types\include;unique\include;units\include;xml.lite\include;zip\include;$(ProjectDir)include;$(SolutionDir)out\install\$(Platform)-$(Configuration)\include;$(SolutionDir)externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\include Use pch.h true Guard - true true true true @@ -623,8 +628,8 @@ true true true - $(ProjectDir)..\..\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib\;$(SolutionDir)\target-$(Configuration)\installwindows-latestCMake-Github\lib\ - hdf5-c++.lib;z.lib;minizip.lib;xerces-c.lib;rpcrt4.lib;%(AdditionalDependencies) + $(SolutionDir)\out\install\$(Platform)-$(Configuration)\lib;$(SolutionDir)\externals\$(ProjectName)\out\install\$(Platform)-$(Configuration)\lib + rpcrt4.lib;%(AdditionalDependencies) diff --git a/externals/coda-oss/modules/c++/coda-oss.vcxproj.filters b/externals/coda-oss/modules/c++/coda-oss.vcxproj.filters index 2b1f01308..adb5a57f7 100644 --- a/externals/coda-oss/modules/c++/coda-oss.vcxproj.filters +++ b/externals/coda-oss/modules/c++/coda-oss.vcxproj.filters @@ -963,6 +963,12 @@ hdf5.lite + + mt + + + include + @@ -1586,5 +1592,8 @@ std + + sys + \ No newline at end of file diff --git a/externals/coda-oss/modules/c++/dbi/source/MySQLConnection.cpp b/externals/coda-oss/modules/c++/dbi/source/MySQLConnection.cpp index 9f0e6aae3..49c01f304 100644 --- a/externals/coda-oss/modules/c++/dbi/source/MySQLConnection.cpp +++ b/externals/coda-oss/modules/c++/dbi/source/MySQLConnection.cpp @@ -38,7 +38,7 @@ bool dbi::MySQLConnection::connect(const std::string& database, if (!mysql_real_connect(&mDBHandle, host.c_str(), user.c_str(), pass.c_str(), database.c_str(), port, - NULL, 0)) + nullptr, 0)) { return false; } diff --git a/externals/coda-oss/modules/c++/dbi/source/OracleConnection.cpp b/externals/coda-oss/modules/c++/dbi/source/OracleConnection.cpp index 66ff79cb5..a03203e4f 100644 --- a/externals/coda-oss/modules/c++/dbi/source/OracleConnection.cpp +++ b/externals/coda-oss/modules/c++/dbi/source/OracleConnection.cpp @@ -80,7 +80,7 @@ const std::string dbi::OracleConnection::getLastErrorMessage() char errbuf[100]; memset(errbuf, 0, 100); int errcode; - OCIErrorGet((dvoid *)mErrorHandle, (ub4) 1, (text *) NULL, &errcode, + OCIErrorGet((dvoid *)mErrorHandle, (ub4) 1, (text *) nullptr, &errcode, (OraText*)errbuf, (ub4) sizeof(errbuf), OCI_HTYPE_ERROR); if (strlen(errbuf) > 0) return std::string(errbuf); @@ -117,7 +117,7 @@ dbi::pResultSet dbi::OracleConnection::query(const std::string& q) OCIStmtPrepare(countHandle, mErrorHandle, (const OraText*)countq.c_str(), (ub4)countq.length(), (ub4) OCI_NTV_SYNTAX, (ub4) OCI_DEFAULT); OCIStmtExecute(mContextHandle, countHandle, mErrorHandle, (ub4)val, (ub4)0, - (CONST OCISnapshot *) NULL, (OCISnapshot *) NULL, OCI_DEFAULT); + (CONST OCISnapshot *) nullptr, (OCISnapshot *) nullptr, OCI_DEFAULT); OCIDefine * defineHandle = nullptr; OCIDefineByPos(countHandle, &defineHandle, mErrorHandle, 1, &rowCount, sizeof(rowCount), SQLT_UIN, 0, 0, 0, OCI_DEFAULT); @@ -126,7 +126,7 @@ dbi::pResultSet dbi::OracleConnection::query(const std::string& q) /* Execute the SQL statment */ OCIStmtExecute(mContextHandle, sqlHandle, mErrorHandle, (ub4) val, (ub4) 0, - (CONST OCISnapshot *) NULL, (OCISnapshot *) NULL, OCI_DEFAULT); + (CONST OCISnapshot *) nullptr, (OCISnapshot *) nullptr, OCI_DEFAULT); return dbi::pResultSet(new dbi::OracleResultSet(sqlHandle, mErrorHandle, rowCount)); } @@ -229,8 +229,8 @@ dbi::Row dbi::OracleResultSet::fetchRow() ub4 bufferSize = 9; OCIDateToText(mErrorHandle, (const OCIDate*)fields[i].value, - NULL, 0, - NULL, 0, &bufferSize, (text*)buffer); + nullptr, 0, + nullptr, 0, &bufferSize, (text*)buffer); memset(fields[i].value, '\0', sizeof(OCIDate)); strncpy(fields[i].value, buffer, bufferSize); } diff --git a/externals/coda-oss/modules/c++/dbi/source/PgSQLConnection.cpp b/externals/coda-oss/modules/c++/dbi/source/PgSQLConnection.cpp index 5e9519dd7..fc5a86a97 100644 --- a/externals/coda-oss/modules/c++/dbi/source/PgSQLConnection.cpp +++ b/externals/coda-oss/modules/c++/dbi/source/PgSQLConnection.cpp @@ -97,7 +97,7 @@ dbi::pResultSet dbi::PgSQLConnection::query(const std::string& q) throw dbi::SQLException(Ctxt(errorMessage)); } - return dbi::pResultSet(new PgSQLResultSet(NULL)); + return dbi::pResultSet(new PgSQLResultSet(nullptr)); } dbi::Row dbi::PgSQLResultSet::fetchRow() diff --git a/externals/coda-oss/modules/c++/except/include/except/Throwable.h b/externals/coda-oss/modules/c++/except/include/except/Throwable.h index 84fe4d038..2a7deecbb 100644 --- a/externals/coda-oss/modules/c++/except/include/except/Throwable.h +++ b/externals/coda-oss/modules/c++/except/include/except/Throwable.h @@ -165,7 +165,9 @@ class CODA_OSS_API Throwable const Trace& t = getTrace(); if (t.getSize() > 0) s << ": " << t; - return s.str(); + + std::string retval(s.str().c_str()); // truncate to first '\0' + return retval; } const std::vector& getBacktrace() const noexcept @@ -265,7 +267,7 @@ class ThrowableEx : public Throwable // "ThrowableEx" = "Throwable exception" ThrowableEx(const Throwable& t, const Context& ctx) : Throwable(t, ctx) {} #if !CODA_OSS_except_Throwable_ISA_std_exception - const char* what() const noexcept final // derived classes override toString() + const char* what() const noexcept override final // derived classes override toString() { const Throwable* pThrowable = this; return pThrowable->what(); diff --git a/externals/coda-oss/modules/c++/except/source/Trace.cpp b/externals/coda-oss/modules/c++/except/source/Trace.cpp index 926f321b4..a40645d71 100644 --- a/externals/coda-oss/modules/c++/except/source/Trace.cpp +++ b/externals/coda-oss/modules/c++/except/source/Trace.cpp @@ -26,12 +26,9 @@ namespace except { std::ostream& operator<<(std::ostream& os, const Trace& t) { - const std::list& stack = t.getStack(); - - for (std::list::const_iterator it = stack.begin(); - it != stack.end(); ++it) + for (auto&& trace : t.getStack()) { - os << *it << std::endl; + os << trace << "\n"; } return os; } diff --git a/externals/coda-oss/modules/c++/hdf5.lite/include/hdf5/lite/H5_.h b/externals/coda-oss/modules/c++/hdf5.lite/include/hdf5/lite/H5_.h index 74ebc436c..cd470aef2 100644 --- a/externals/coda-oss/modules/c++/hdf5.lite/include/hdf5/lite/H5_.h +++ b/externals/coda-oss/modules/c++/hdf5.lite/include/hdf5/lite/H5_.h @@ -28,6 +28,7 @@ CODA_OSS_disable_warning_system_header_push #if _MSC_VER +#pragma warning(disable: 6313) // Incorrect operator. Use an equality test to check for zero-valued flags. #pragma warning(disable: 26493) // Don't use C-style casts (type.4). #pragma warning(disable: 26494) // Variable '...' is uninitialized. Always initialize an object (type.5). #pragma warning(disable: 26451) // Arithmetic overflow: Using operator '...' on a 4 byte value and then casting the result to a 8 byte value. Cast the value to the wider type before calling operator '...' to avoid overflow (io.2). @@ -56,6 +57,8 @@ CODA_OSS_disable_warning(-Wzero-as-null-pointer-constant) #include #include +#include +#include #include #include #include diff --git a/externals/coda-oss/modules/c++/hdf5.lite/source/H5.h b/externals/coda-oss/modules/c++/hdf5.lite/source/H5.h index 24b0d8cfc..ecfe293d1 100644 --- a/externals/coda-oss/modules/c++/hdf5.lite/source/H5.h +++ b/externals/coda-oss/modules/c++/hdf5.lite/source/H5.h @@ -20,17 +20,16 @@ * */ +#pragma once #ifndef CODA_OSS_hdf5_lite_H5_h_INCLUDED_ #define CODA_OSS_hdf5_lite_H5_h_INCLUDED_ -#pragma once #include -// see https://docs.hdfgroup.org/archive/support/HDF5/doc1.8/cpplus_RM/readdata_8cpp-example.html -#include - #include "types/RowCol.h" +#include "hdf5/lite/H5_.h" + // Utility routines for INTERNAL use! namespace hdf5 diff --git a/externals/coda-oss/modules/c++/hdf5.lite/source/hdf5.lite.h b/externals/coda-oss/modules/c++/hdf5.lite/source/hdf5.lite.h index fce6fb7c0..29617ac23 100644 --- a/externals/coda-oss/modules/c++/hdf5.lite/source/hdf5.lite.h +++ b/externals/coda-oss/modules/c++/hdf5.lite/source/hdf5.lite.h @@ -20,18 +20,17 @@ * */ +#pragma once #ifndef CODA_OSS_hdf5_lite_hdf5_lite_h_INCLUDED_ #define CODA_OSS_hdf5_lite_hdf5_lite_h_INCLUDED_ -#pragma once #include #include #include -// see https://docs.hdfgroup.org/archive/support/HDF5/doc1.8/cpplus_RM/readdata_8cpp-example.html -#include - #include "except/Exception.h" + +#include "hdf5/lite/H5_.h" #include "hdf5/lite/HDF5Exception.h" // Utility routines for INTERNAL use! diff --git a/externals/coda-oss/modules/c++/hdf5.lite/unittests/test_highfive.cpp b/externals/coda-oss/modules/c++/hdf5.lite/unittests/test_highfive.cpp index 14e9f8af2..b506e4948 100644 --- a/externals/coda-oss/modules/c++/hdf5.lite/unittests/test_highfive.cpp +++ b/externals/coda-oss/modules/c++/hdf5.lite/unittests/test_highfive.cpp @@ -29,12 +29,8 @@ #include "types/RowCol.h" #include "mem/ComplexView.h" -#include "highfive/H5Easy.hpp" -#include "highfive/H5DataSet.hpp" -#include "highfive/H5File.hpp" - -#include "hdf5/lite/SpanRC.h" #include "hdf5/lite/highfive.h" +#include "hdf5/lite/SpanRC.h" static std::filesystem::path find_unittest_file(const std::filesystem::path& name) { diff --git a/externals/coda-oss/modules/c++/include/TestCase.h b/externals/coda-oss/modules/c++/include/TestCase.h index a43314004..5a091dd9b 100644 --- a/externals/coda-oss/modules/c++/include/TestCase.h +++ b/externals/coda-oss/modules/c++/include/TestCase.h @@ -211,6 +211,7 @@ inline int main(TFunc f) #define CODA_OSS_test_eq(X1, X2) (CODA_OSS_test_eq_(X1, X2) && !CODA_OSS_test_ne_(X1, X2)) #define TEST_ASSERT_EQ(X1, X2) if (!CODA_OSS_test_eq((X1), (X2))) { CODA_OSS_test_diePrintf_eq_(X1, X2); } #define TEST_ASSERT_EQ_MSG(msg, X1, X2) if (!CODA_OSS_test_eq((X1), (X2))) { CODA_OSS_test_diePrintf_eq_msg_(msg, X1, X2); } +#define TEST_ASSERT_EQ_STR(X1, X2) TEST_ASSERT_EQ(std::string(X1), std::string(X2)) #define TEST_ASSERT_NOT_EQ(X1, X2) if (!CODA_OSS_test_ne((X1), (X2))) { CODA_OSS_test_diePrintf_not_eq_(X1, X2); } #define TEST_ASSERT_NOT_EQ_MSG(msg, X1, X2) if (!CODA_OSS_test_ne((X1), (X2))) { CODA_OSS_test_diePrintf_not_eq_msg_(msg, X1, X2); } diff --git a/externals/coda-oss/modules/c++/include/UnitTest.h b/externals/coda-oss/modules/c++/include/UnitTest.h new file mode 100644 index 000000000..751843c1f --- /dev/null +++ b/externals/coda-oss/modules/c++/include/UnitTest.h @@ -0,0 +1,143 @@ +#pragma once + +#include +#include + +#include "TestCase.h" +#include "str/EncodedStringView.h" + +#if !_MSC_VER +#error "This file is for use with a Visual Studio 'UnitTest' project." +#endif + +// Use our various TEST macros with a Visual Studio "UnitTest" project. +#include + +#undef TEST_CHECK +#undef TEST_ASSERT +#undef TEST_ASSERT_NULL +#undef TEST_ASSERT_NOT_NULL +#undef TEST_ASSERT_TRUE +#undef TEST_ASSERT_FALSE +#undef TEST_MAIN +#undef TEST_CASE +#define TEST_CHECK(X) +#define TEST_MAIN(X) +#define TEST_ASSERT_NULL(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNull(X) +#define TEST_ASSERT_NOT_NULL(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsNotNull(X) +#define TEST_ASSERT_TRUE(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(X) +#define TEST_ASSERT_FALSE(X) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsFalse(X) +#define TEST_ASSERT(X) TEST_ASSERT_TRUE(X) +#define CODA_OSS_testMethod_(X) testMethod ## _ ## X +#define TEST_CASE(X) TEST_METHOD(X) { CODA_OSS_testMethod_(X)(#X); } void CODA_OSS_testMethod_(X)(std::string testName) + +namespace test +{ + struct Assert final + { + static void FailOnCondition(bool condition, const unsigned short* message, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo); + static std::wstring GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message); + }; +#define CODA_OSS_equals_message_(expected, actual, message) reinterpret_cast(test::Assert::GetAssertMessage(true, test::toString(expected), test::toString(actual), message).c_str()) +#define CODA_OSS_not_equals_message_(notExpected, actual, message) reinterpret_cast(test::Assert::GetAssertMessage(false, test::toString(notExpected), test::toString(actual), message).c_str()) +#define CODA_OSS_message_(message) reinterpret_cast(test::Assert::GetAssertMessage(false, "", "", message).c_str()) + +// see Assert::AreEqual<> +template +inline void diePrintf_eq(const TExpected& expected, const TActual& actual, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(expected == actual, CODA_OSS_equals_message_(expected, actual, message), pLineInfo); +} + +// see Assert::AreNotEqual<> +template +inline void diePrintf_ne(const TExpected& notExpected, const TActual& actual, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(notExpected != actual, CODA_OSS_not_equals_message_(notExpected, actual, message), pLineInfo); +} + +template +inline void diePrintf_ge(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 >= X2, CODA_OSS_message_(message), pLineInfo); +} +template +inline void diePrintf_gt(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 > X2, CODA_OSS_message_(message), pLineInfo); +} +template +inline void diePrintf_le(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 <= X2, CODA_OSS_message_(message), pLineInfo); +} +template +inline void diePrintf_lt(const TX1& X1, const TX2& X2, + const wchar_t* message = NULL, const Microsoft::VisualStudio::CppUnitTestFramework::__LineInfo* pLineInfo = NULL) +{ + Assert::FailOnCondition(X1 < X2, CODA_OSS_message_(message), pLineInfo); +} + +} +#undef CODA_OSS_test_diePrintf_eq_ +#undef CODA_OSS_test_diePrintf_not_eq_ +#define CODA_OSS_test_diePrintf_eq_(X1, X2) testName, ::test::diePrintf_eq(X1, X2) +#define CODA_OSS_test_diePrintf_not_eq_(X1, X2) testName, ::test::diePrintf_ne(X1, X2) + +#undef CODA_OSS_test_diePrintf_greater_eq_ +#undef CODA_OSS_test_diePrintf_greater_ +#undef CODA_OSS_test_diePrintf_lesser_eq_ +#undef CODA_OSS_test_diePrintf_lesser_ +#define CODA_OSS_test_diePrintf_greater_eq_(X1, X2) testName, ::test::diePrintf_ge(X1, X2) +#define CODA_OSS_test_diePrintf_greater_(X1, X2) testName, ::test::diePrintf_gt(X1, X2) +#define CODA_OSS_test_diePrintf_lesser_eq_(X1, X2) testName, ::test::diePrintf_le(X1, X2) +#define CODA_OSS_test_diePrintf_lesser_(X1, X2) testName, ::test::diePrintf_lt(X1, X2) + +template +inline void test_assert_greater_(const TX1& X1, const TX2& X2) +{ + Microsoft::VisualStudio::CppUnitTestFramework::Assert::IsTrue(X1 > X2); +} +#undef TEST_ASSERT_GREATER +#define TEST_ASSERT_GREATER(X1, X2) testName, test_assert_greater_(X1, X2) + +#undef TEST_ASSERT_ALMOST_EQ_EPS +#define TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS) { (void)testName; Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(X1, X2, EPS); Microsoft::VisualStudio::CppUnitTestFramework::Assert::AreEqual(X2, X1, EPS); } +namespace test +{ +inline void assert_almost_eq(const std::string& testName, float X1, float X2) +{ + constexpr auto EPS = static_cast(0.0001); + TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS); +} +inline void assert_almost_eq(const std::string& testName, double X1, double X2) +{ + constexpr auto EPS = static_cast(0.0001); + TEST_ASSERT_ALMOST_EQ_EPS(X1, X2, EPS); +} +inline void assert_almost_eq(const std::string& testName, long double X1, long double X2) +{ + assert_almost_eq(testName, static_cast(X1), static_cast(X2)); +} +} + +#undef TEST_ASSERT_ALMOST_EQ +#define TEST_ASSERT_ALMOST_EQ(X1, X2) test::assert_almost_eq(testName, X1, X2) + +#undef TEST_ASSERT_EQ_MSG +#define TEST_ASSERT_EQ_MSG(msg, X1, X2) testName, Microsoft::VisualStudio::CppUnitTestFramework::Logger::WriteMessage(msg.c_str()); TEST_ASSERT_EQ(X1, X2) + +#undef TEST_FAIL_MSG +#define TEST_FAIL_MSG(msg) { (void)testName; Microsoft::VisualStudio::CppUnitTestFramework::Assert::Fail(str::EncodedStringView(msg).wstring().c_str()); } + +#undef TEST_EXCEPTION +#undef TEST_THROWS +#undef TEST_SPECIFIC_EXCEPTION +#define TEST_EXCEPTION(X) (void)testName; try{ (X); TEST_FAIL(#X " should have thrown."); } CODA_OSS_TEST_EXCEPTION_catch_ +#define TEST_THROWS(X) (void)testName; try{ (X); TEST_FAIL(#X " should have thrown."); } catch (...){ TEST_ASSERT_TRUE(true); } +#define TEST_SPECIFIC_EXCEPTION(X, Y) testName, Microsoft::VisualStudio::CppUnitTestFramework::Assert::ExpectException([&](){(X);}) diff --git a/externals/coda-oss/modules/c++/math/tests/complexBenchmark.cpp b/externals/coda-oss/modules/c++/math/tests/complexBenchmark.cpp index 2de00abbc..9484150c9 100644 --- a/externals/coda-oss/modules/c++/math/tests/complexBenchmark.cpp +++ b/externals/coda-oss/modules/c++/math/tests/complexBenchmark.cpp @@ -217,7 +217,7 @@ void loopingBenchmark(size_t size, std::vector > arr(size); //fill the vector based on a random number - srand(static_cast(time(NULL))); + srand(static_cast(time(nullptr))); auto real = static_cast(rand() % 100 + 1); auto imag = static_cast(rand() % 100 + 1); @@ -321,7 +321,7 @@ void singlePassBenchmark(size_t size, std::vector > arr; arr.reserve(endSize); - srand(static_cast(time(NULL))); + srand(static_cast(time(nullptr))); auto real = static_cast(rand() % 100 + 1); auto imag = static_cast(rand() % 100 + 1); diff --git a/externals/coda-oss/modules/c++/math/tests/complexMultiplyBenchmark.cpp b/externals/coda-oss/modules/c++/math/tests/complexMultiplyBenchmark.cpp index 3f7b19ac9..12ea42619 100644 --- a/externals/coda-oss/modules/c++/math/tests/complexMultiplyBenchmark.cpp +++ b/externals/coda-oss/modules/c++/math/tests/complexMultiplyBenchmark.cpp @@ -199,7 +199,7 @@ void loopingBenchmark(size_t size, std::vector > arr(size); //fill the vector based on a random number - srand(static_cast(time(NULL))); + srand(static_cast(time(nullptr))); auto real = static_cast(rand() % 100 + 1); auto imag = static_cast(rand() % 100 + 1); @@ -297,7 +297,7 @@ void singlePassBenchmark(size_t size, std::vector > arr; arr.reserve(endSize); - srand(static_cast(time(NULL))); + srand(static_cast(time(nullptr))); auto real = static_cast(rand() % 100 + 1); auto imag = static_cast(rand() % 100 + 1); diff --git a/externals/coda-oss/modules/c++/mem/tests/ScratchVisualization.cpp b/externals/coda-oss/modules/c++/mem/tests/ScratchVisualization.cpp index 20974a659..791964c72 100644 --- a/externals/coda-oss/modules/c++/mem/tests/ScratchVisualization.cpp +++ b/externals/coda-oss/modules/c++/mem/tests/ScratchVisualization.cpp @@ -72,7 +72,7 @@ class Visualizer mHTMLFile(htmlFile), mCSSFile(cssFile) { - mStartPtr = NULL; + mStartPtr = nullptr; mColors.push_back("lightgrey"); mColors.push_back("lightblue"); mColors.push_back("lightcyan"); diff --git a/externals/coda-oss/modules/c++/mem/unittests/test_scratch_memory.cpp b/externals/coda-oss/modules/c++/mem/unittests/test_scratch_memory.cpp index 8ef51ee4f..5186e8956 100644 --- a/externals/coda-oss/modules/c++/mem/unittests/test_scratch_memory.cpp +++ b/externals/coda-oss/modules/c++/mem/unittests/test_scratch_memory.cpp @@ -617,7 +617,7 @@ TEST_CASE(testScratchMemory) TEST_EXCEPTION(scratch.setup(smallBuffer)); // calling setup with invalid external buffer should throw - mem::BufferView invalidBuffer(NULL, buffer.size); + mem::BufferView invalidBuffer(nullptr, buffer.size); TEST_EXCEPTION(scratch.setup(invalidBuffer)); } diff --git a/externals/coda-oss/modules/c++/mem/unittests/test_shared_ptr.cpp b/externals/coda-oss/modules/c++/mem/unittests/test_shared_ptr.cpp index 866df1eb7..1441f4723 100644 --- a/externals/coda-oss/modules/c++/mem/unittests/test_shared_ptr.cpp +++ b/externals/coda-oss/modules/c++/mem/unittests/test_shared_ptr.cpp @@ -69,19 +69,19 @@ size_t cpp11Function(std::shared_ptr foo) TEST_CASE(testNullCopying) { mem::SharedPtr ptr1; - TEST_ASSERT_EQ(ptr1.get(), static_cast(NULL)); + TEST_ASSERT_EQ(ptr1.get(), static_cast(nullptr)); // Copy construction const mem::SharedPtr ptr2(ptr1); - TEST_ASSERT_EQ(ptr2.get(), static_cast(NULL)); + TEST_ASSERT_EQ(ptr2.get(), static_cast(nullptr)); // Assignment operator mem::SharedPtr ptr3; ptr3 = ptr1; - TEST_ASSERT_EQ(ptr3.get(), static_cast(NULL)); + TEST_ASSERT_EQ(ptr3.get(), static_cast(nullptr)); ptr1.reset(); - TEST_ASSERT_EQ(ptr1.get(), static_cast(NULL)); + TEST_ASSERT_EQ(ptr1.get(), static_cast(nullptr)); } TEST_CASE(testAutoPtrConstructor) @@ -90,7 +90,7 @@ TEST_CASE(testAutoPtrConstructor) std::unique_ptr autoPtr(rawPtr); const mem::SharedPtr ptr(autoPtr.release()); TEST_ASSERT_EQ(ptr.get(), rawPtr); - TEST_ASSERT_EQ(autoPtr.get(), static_cast(NULL)); + TEST_ASSERT_EQ(autoPtr.get(), static_cast(nullptr)); //TEST_ASSERT_EQ(ptr.getCount(), 1); TEST_ASSERT_EQ(ptr.use_count(), 1); TEST_ASSERT_EQ(getCount(ptr), 1); @@ -287,7 +287,7 @@ TEST_CASE(testCasting) std::unique_ptr autoBar(rawBar); const mem::SharedPtr fooPtr(autoBar.release()); TEST_ASSERT_EQ(fooPtr.get(), rawBar); - TEST_ASSERT_EQ(autoBar.get(), static_cast(NULL)); + TEST_ASSERT_EQ(autoBar.get(), static_cast(nullptr)); //TEST_ASSERT_EQ(fooPtr.getCount(), 1); TEST_ASSERT_EQ(fooPtr.use_count(), 1); TEST_ASSERT_EQ(getCount(fooPtr), 1); diff --git a/externals/coda-oss/modules/c++/mt/include/import/mt.h b/externals/coda-oss/modules/c++/mt/include/import/mt.h index 10caa17e6..2a35e189c 100644 --- a/externals/coda-oss/modules/c++/mt/include/import/mt.h +++ b/externals/coda-oss/modules/c++/mt/include/import/mt.h @@ -21,8 +21,14 @@ */ -#ifndef __IMPORT_MT_H__ -#define __IMPORT_MT_H__ +#pragma once +#ifndef CODA_OSS_mt_import_mt_h_h_INCLUDED_ +#define CODA_OSS_mt_import_mt_h_h_INCLUDED_ + +#if _MSC_VER +#pragma warning(push) +#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to 'extern "C"' function under - EHc.Undefined behavior may occur if this function throws an exception. +#endif // _MSC_VER #include "mt/RequestQueue.h" #include "mt/ThreadPoolException.h" @@ -45,4 +51,8 @@ #include "mt/CPUAffinityThreadInitializer.h" #include "mt/Algorithm.h" -#endif +#if _MSC_VER +#pragma warning(pop) +#endif // _MSC_VER + +#endif // CODA_OSS_mt_import_mt_h_h_INCLUDED_ diff --git a/externals/coda-oss/modules/c++/net.ssl/source/SSLConnection.cpp b/externals/coda-oss/modules/c++/net.ssl/source/SSLConnection.cpp index 75c7f5e03..903fa077d 100644 --- a/externals/coda-oss/modules/c++/net.ssl/source/SSLConnection.cpp +++ b/externals/coda-oss/modules/c++/net.ssl/source/SSLConnection.cpp @@ -45,11 +45,11 @@ net::ssl::SSLConnection::SSLConnection(std::unique_ptr&& socket, net::ssl::SSLConnection::~SSLConnection() { - if(mSSL != NULL) + if(mSSL != nullptr) { SSL_shutdown(mSSL); } - if(mSSL != NULL) + if(mSSL != nullptr) { SSL_free(mSSL); } diff --git a/externals/coda-oss/modules/c++/net/tests/AckMulticastSender.cpp b/externals/coda-oss/modules/c++/net/tests/AckMulticastSender.cpp index a5c97008a..e02d52752 100644 --- a/externals/coda-oss/modules/c++/net/tests/AckMulticastSender.cpp +++ b/externals/coda-oss/modules/c++/net/tests/AckMulticastSender.cpp @@ -143,8 +143,8 @@ template class AckMulticastSender //FD_SET(mAckChannel->getHandle(), &writers); assert(FD_ISSET(mAckChannel->getHandle(), &readers)); //int rv = 1; - int rv = ::select(mAckChannel->getHandle() + 1, &readers, NULL, - NULL, &tv); + int rv = ::select(mAckChannel->getHandle() + 1, &readers, nullptr, + nullptr, &tv); if (rv < 0) { throw sys::SocketException(Ctxt("Select failed")); diff --git a/externals/coda-oss/modules/c++/net/tests/NetConnectionServerTest.cpp b/externals/coda-oss/modules/c++/net/tests/NetConnectionServerTest.cpp index bcbb46ac1..ed72a907b 100644 --- a/externals/coda-oss/modules/c++/net/tests/NetConnectionServerTest.cpp +++ b/externals/coda-oss/modules/c++/net/tests/NetConnectionServerTest.cpp @@ -76,7 +76,7 @@ int main(int argc, char **argv) if (argc < 2) throw Exception(FmtX("Usage: %s (-mt|-st|-tp)", argv[0])); - net::AllocStrategy* strategy = NULL; + net::AllocStrategy* strategy = nullptr; if (argc == 3) { diff --git a/externals/coda-oss/modules/c++/net/tests/TCPClientTest.cpp b/externals/coda-oss/modules/c++/net/tests/TCPClientTest.cpp index 47a9c10a0..0ca69b276 100644 --- a/externals/coda-oss/modules/c++/net/tests/TCPClientTest.cpp +++ b/externals/coda-oss/modules/c++/net/tests/TCPClientTest.cpp @@ -60,7 +60,7 @@ int main(int argc, char** argv) std::unique_ptr socket = TCPClientSocketFactory().create(sa); my_packet_t packet; packet.packet_no = 1; - packet.time_stamp = time(NULL); + packet.time_stamp = time(nullptr); socket->send(&packet, sizeof(my_packet_t)); int rv; socket->recv(&rv, sizeof(int)); diff --git a/externals/coda-oss/modules/c++/net/tests/UDPClientTest.cpp b/externals/coda-oss/modules/c++/net/tests/UDPClientTest.cpp index 76fed3372..ae2e28ba2 100644 --- a/externals/coda-oss/modules/c++/net/tests/UDPClientTest.cpp +++ b/externals/coda-oss/modules/c++/net/tests/UDPClientTest.cpp @@ -66,7 +66,7 @@ int main(int argc, char** argv) std::unique_ptr socket = UDPClientSocketFactory().create(sa); my_packet_t packet; packet.packet_no = 1; - packet.time_stamp = time(NULL); + packet.time_stamp = time(nullptr); socket->send((const char*)&packet, sizeof(my_packet_t)); int rv; socket->recv((char*)&rv, sizeof(int)); diff --git a/externals/coda-oss/modules/c++/numpyutils/include/numpyutils/numpyutils.h b/externals/coda-oss/modules/c++/numpyutils/include/numpyutils/numpyutils.h index fec9e9e64..4632913dd 100644 --- a/externals/coda-oss/modules/c++/numpyutils/include/numpyutils/numpyutils.h +++ b/externals/coda-oss/modules/c++/numpyutils/include/numpyutils/numpyutils.h @@ -20,14 +20,40 @@ * */ +#pragma once #ifndef __NUMPYUTILS_NUMPYUTILS_H__ #define __NUMPYUTILS_NUMPYUTILS_H__ #define NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION #include -#include CODA_OSS_disable_warning_system_header_push +#if _MSC_VER +#pragma warning(disable: 26493) // Don't use C-style casts (type.4). +#pragma warning(disable: 26494) // Variable '...' is uninitialized. Always initialize an object (type.5). +#pragma warning(disable: 26451) // Arithmetic overflow: Using operator '...' on a 4 byte value and then casting the result to a 8 byte value. Cast the value to the wider type before calling operator '...' to avoid overflow (io.2). +#pragma warning(disable: 26814) // The const variable '...' can be computed at compile-time. Consider using constexpr (con.5). +#pragma warning(disable: 26447) // The function is declared '...' but calls function '...' which may throw exceptions (f.6). +#pragma warning(disable: 26455) // Default constructor should not throw. Declare it '...' (f.6). +#pragma warning(disable: 26440) // Function '...' can be declared '...' (f.6). +#pragma warning(disable: 26496) // The variable '...' does not change after construction, mark it as const (con.4). +#pragma warning(disable: 26462) // The value pointed to by '...' is assigned only once, mark it as a pointer to const (con.4). +#pragma warning(disable: 26435) // Function '...' should specify exactly one of '...', '...', or '...' (c.128). +#pragma warning(disable: 26433) // Function '...' should be marked with '...' (c.128). +#pragma warning(disable: 26497) // You can attempt to make '...' constexpr unless it contains any undefined behavior (f.4). +#pragma warning(disable: 26433) // Function '...' should be marked with '...' (c.128). +#pragma warning(disable: 26456) // Operator '...' hides a non-virtual operator '...' (c.128). +#pragma warning(disable: 26446) // Prefer to use gsl::at() instead of unchecked subscript operator (bounds.4). +#pragma warning(disable: 26477) // Use '...' rather than 0 or NULL(es .47). +#pragma warning(disable: 26457) // (void) should not be used to ignore return values, use '...' instead (es.48). +#pragma warning(disable: 26813) // Use '...' to check if a flag is set. +#else +CODA_OSS_disable_warning(-Wshadow) +CODA_OSS_disable_warning(-Wsuggest-override) +CODA_OSS_disable_warning(-Wzero-as-null-pointer-constant) +#endif + +#include #include CODA_OSS_disable_warning_pop diff --git a/externals/coda-oss/modules/c++/numpyutils/source/numpyutils.cpp b/externals/coda-oss/modules/c++/numpyutils/source/numpyutils.cpp index 53b8b97b1..31a2452c2 100644 --- a/externals/coda-oss/modules/c++/numpyutils/source/numpyutils.cpp +++ b/externals/coda-oss/modules/c++/numpyutils/source/numpyutils.cpp @@ -25,6 +25,9 @@ #ifndef _MSC_VER CODA_OSS_disable_warning(-Wold-style-cast) +CODA_OSS_disable_warning(-Wshadow) +CODA_OSS_disable_warning(-Wsuggest-override) +CODA_OSS_disable_warning(-Wzero-as-null-pointer-constant) #endif #include #include @@ -36,18 +39,12 @@ CODA_OSS_disable_warning(-Wold-style-cast) * https://mail.scipy.org/pipermail/numpy-discussion/2010-December/054350.html * for the source and some discussion */ -#if PY_MAJOR_VERSION >= 3 +static_assert(PY_MAJOR_VERSION >= 3, "Python 3.x required"); void* init_numpy() { import_array(); return nullptr; } -#else -void init_numpy() -{ - import_array(); -} -#endif /* Numpy uses some static variables which are per-compilation * unit and if import_arrays is not called, will segfault on using any of diff --git a/externals/coda-oss/modules/c++/pch.h b/externals/coda-oss/modules/c++/pch.h index f39484bc2..18067f14d 100644 --- a/externals/coda-oss/modules/c++/pch.h +++ b/externals/coda-oss/modules/c++/pch.h @@ -33,32 +33,29 @@ CODA_OSS_disable_warning_pop #include #include +#pragma comment(lib, "z.lib") +#pragma comment(lib, "minizip.lib") + #include #pragma warning(disable: 4251) // '...': class '...' needs to have dll-interface to be used by clients of class '...' #pragma warning(disable: 4365) // '...': conversion from '...' to '...', signed/unsigned mismatch #pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to '...' function under -EHc. Undefined behavior may occur if this function throws an exception. -#pragma warning(disable: 6326) // Potential comparison of a constant with another constant. #pragma warning(disable: 6054) // String '...' might not be zero-terminated. #pragma warning(disable: 6387) // '...' could be '...'. #pragma warning(disable: 6305) // Potential mismatch between sizeof and countof quantities. Use sizeof() to scale byte sizes. -#pragma warning(disable: 6288) // Incorrect operator. Did you intend to use || instead? -#pragma warning(disable: 6011) // Dereferencing NULL pointer '...'. -#pragma warning(disable: 6313) // Incorrect operator. Use an equality test to check for zero-valued flags. #pragma warning(disable: 6389) // Move '...' to anonymous namespace or put a forward declaration in a common header included in this file. +#pragma warning(disable: 26822) // Dereferencing a null pointer '...' (lifetime.1). #pragma warning(disable: 26432) // If you define or delete any default operation in the type '...', define or delete them all (c.21). #pragma warning(disable: 26429) // Symbol '...' is never tested for nullness, it can be marked as not_null (f.23). #pragma warning(disable: 26455) // Default constructor should not throw. Declare it '...' (f.6). #pragma warning(disable: 26440) // Function '...' can be declared '...' (f.6). #pragma warning(disable: 26447) // The function is declared '...' but calls function '...' which may throw exceptions (f.6). -#pragma warning(disable: 26446) // Prefer to use gsl::at() instead of unchecked subscript operator (bounds.4). -#pragma warning(disable: 26481) // Don't use pointer arithmetic. Use span instead (bounds.1). #pragma warning(disable: 26496) // The variable '...' does not change after construction, mark it as const (con.4). #pragma warning(disable: 26462) // The value pointed to by '...' is assigned only once, mark it as a pointer to const (con.4). #pragma warning(disable: 26409) // Avoid calling new and delete explicitly, use std::make_unique instead (r.11). #pragma warning(disable: 26401) // Do not delete a raw pointer that is not an owner (i.11). -#pragma warning(disable: 26482) // Only index into arrays using constant expressions (bounds.2). #pragma warning(disable: 26472) // Don't use a static_cast for arithmetic conversions. Use brace initialization, gsl::narrow_cast or gsl::narrow (type.1). #pragma warning(disable: 26485) // Expression '...': No array to pointer decay (bounds.3). #pragma warning(disable: 26493) // Don't use C-style casts (type.4). @@ -96,8 +93,10 @@ CODA_OSS_disable_warning_pop #pragma warning(disable: 26823) // Dereferencing a possibly null pointer '...' (lifetime.1). #pragma warning(disable: 26487) // Don't return a pointer '...' that may be invalid (lifetime.4). #pragma warning(disable: 26812) // The enum type '...' is unscoped. Prefer '...' over '...' (Enum.3). -#pragma warning(disable: 26822) // Dereferencing a null pointer '...' (lifetime.1). +#pragma warning(disable: 26446) // Prefer to use gsl::at() instead of unchecked subscript operator (bounds.4). #pragma warning(disable: 26458) // Prefer to use gsl::at() instead of unchecked subscript operator (bounds.4). +#pragma warning(disable: 26482) // Only index into arrays using constant expressions (bounds.2). +#pragma warning(disable: 26481) // Don't use pointer arithmetic. Use span instead (bounds.1). // Yes, these are our files ... but they don't change very often, and if they do // change we want to rebuild everything anyway. @@ -107,7 +106,11 @@ CODA_OSS_disable_warning_pop #include "sys/Conf.h" #include "sys/filesystem.h" #include "mem/SharedPtr.h" + #include "xml/lite/xerces_.h" +#pragma comment(lib, "xerces-c") + #include "hdf5/lite/H5_.h" +#pragma comment(lib, "hdf5-c++.lib") #endif //CODA_OSS_pch_h_INCLUDED_ diff --git a/externals/coda-oss/modules/c++/re/include/re/Regex.h b/externals/coda-oss/modules/c++/re/include/re/Regex.h index d7dd55dd2..e4338972a 100644 --- a/externals/coda-oss/modules/c++/re/include/re/Regex.h +++ b/externals/coda-oss/modules/c++/re/include/re/Regex.h @@ -214,7 +214,7 @@ class CODA_OSS_API Regex size_t& end); //! The pcre object - pcre2_code* mPCRE; + pcre2_code* mPCRE = nullptr; #endif }; } diff --git a/externals/coda-oss/modules/c++/re/source/RegexPCRE.cpp b/externals/coda-oss/modules/c++/re/source/RegexPCRE.cpp index 479d1fac7..d70885e3e 100644 --- a/externals/coda-oss/modules/c++/re/source/RegexPCRE.cpp +++ b/externals/coda-oss/modules/c++/re/source/RegexPCRE.cpp @@ -55,9 +55,9 @@ class ScopedMatchData // to do. ScopedMatchData(const pcre2_code* code) : mCode(code), - mMatchData(pcre2_match_data_create_from_pattern(code, NULL)) + mMatchData(pcre2_match_data_create_from_pattern(code, nullptr)) { - if (mMatchData == NULL) + if (mMatchData == nullptr) { throw re::RegexException(Ctxt( "pcre2_match_data_create_from_pattern() failed to " @@ -95,7 +95,7 @@ class ScopedMatchData startOffset, options, mMatchData, - NULL); // Match context + nullptr); // Match context if (returnCode == PCRE2_ERROR_NOMATCH) { @@ -156,7 +156,7 @@ class ScopedMatchData namespace re { Regex::Regex(const std::string& pattern) : - mPattern(pattern), mPCRE(NULL) + mPattern(pattern), mPCRE(nullptr) { if (!mPattern.empty()) { @@ -166,10 +166,10 @@ Regex::Regex(const std::string& pattern) : void Regex::destroy() { - if (mPCRE != NULL) + if (mPCRE != nullptr) { pcre2_code_free(mPCRE); - mPCRE = NULL; + mPCRE = nullptr; } } @@ -179,7 +179,7 @@ Regex::~Regex() } Regex::Regex(const Regex& rhs) : - mPattern(rhs.mPattern), mPCRE(NULL) + mPattern(rhs.mPattern), mPCRE(nullptr) { compile(mPattern); } @@ -218,9 +218,9 @@ Regex& Regex::compile(const std::string& pattern) FLAGS, &errorCode, &errorOffset, - NULL); // Use default compile context + nullptr); // Use default compile context - if (mPCRE == NULL) + if (mPCRE == nullptr) { std::ostringstream ostr; ostr << "PCRE compilation failed at offset " << errorOffset diff --git a/externals/coda-oss/modules/c++/str/source/EncodedStringView.cpp b/externals/coda-oss/modules/c++/str/source/EncodedStringView.cpp index 385293601..6bd00eef4 100644 --- a/externals/coda-oss/modules/c++/str/source/EncodedStringView.cpp +++ b/externals/coda-oss/modules/c++/str/source/EncodedStringView.cpp @@ -85,26 +85,29 @@ static std::string to_native(str::W1252string::const_pointer p, size_t sz) throw std::logic_error("Unknown platform."); } -template -inline coda_oss::span make_span(const CharT* s, size_t c) +template +inline auto make_span(const Char8T* s, size_t c) { - return coda_oss::span(s, c); + static_assert(sizeof(Char8T) == sizeof(char), "sizeof(Char8T) != sizeof(char)"); + return coda_oss::span(s, c); } -template -inline coda_oss::span make_span(const CharT* s) +template +inline auto make_span(const Char8T* s) { - auto s_ = str::cast(s); + auto const s_ = str::cast(s); return make_span(s, strlen(s_)); } -template -inline coda_oss::span make_span(const std::basic_string& s) +template +inline auto make_span(const std::basic_string& s) { - return make_span(s.c_str(), s.size()); + assert(strlen(str::c_str(s)) == s.length()); + return make_span(s.c_str(), s.length()); } -template -inline coda_oss::span make_span(coda_oss::span s) +template +inline auto make_span(coda_oss::span s) { - auto s_ = str::cast(s.data()); + auto const s_ = str::cast(s.data()); + assert(strlen(s_) == s.size()); return coda_oss::span(s_, s.size()); } diff --git a/externals/coda-oss/modules/c++/sys/include/sys/OS.h b/externals/coda-oss/modules/c++/sys/include/sys/OS.h index 6ea40c83f..7a16c53e5 100644 --- a/externals/coda-oss/modules/c++/sys/include/sys/OS.h +++ b/externals/coda-oss/modules/c++/sys/include/sys/OS.h @@ -21,10 +21,12 @@ */ -#ifndef __SYS_OS_H__ -#define __SYS_OS_H__ +#pragma once +#ifndef CODA_OSS_sys_OS_h_INCLUDED_ +#define CODA_OSS_sys_OS_h_INCLUDED_ #include "sys/AbstractOS.h" +#include "sys/Conf.h" #ifdef _WIN32 # include "sys/OSWin32.h" @@ -47,19 +49,34 @@ typedef DirectoryUnix Directory; // and also squelches compiler-warnings about unused local functions. namespace sys { - enum class PlatformType - { - Windows, - Linux, - //MacOS - }; +enum class PlatformType +{ + Windows, + Linux, + // MacOS +}; - #ifdef _WIN32 - constexpr auto Platform = PlatformType::Windows; - #else - constexpr auto Platform = PlatformType::Linux; - #endif +#if defined(_WIN32) +constexpr auto Platform = PlatformType::Windows; +#elif defined(CODA_OSS_POSIX2008_SOURCE) +constexpr auto Platform = PlatformType::Linux; +#else +#error "Unknown platform." +#endif + +template +inline std::string platformName(); +template <> +inline std::string platformName() +{ + return "Windows"; +} +template <> +inline std::string platformName() +{ + return "linux-gnu"; } -#endif +} +#endif // CODA_OSS_sys_OS_h_INCLUDED_ \ No newline at end of file diff --git a/externals/coda-oss/modules/c++/sys/source/AbstractOS.cpp b/externals/coda-oss/modules/c++/sys/source/AbstractOS.cpp index e32b44d87..d1cd33306 100644 --- a/externals/coda-oss/modules/c++/sys/source/AbstractOS.cpp +++ b/externals/coda-oss/modules/c++/sys/source/AbstractOS.cpp @@ -480,14 +480,7 @@ std::string AbstractOS::getSpecialEnv(const std::string& envVar) const if (envVar == "OSTYPE") { - // TODO: Mac - return sys::Platform == sys::PlatformType::Linux ? " linux-gnu" : "Windows"; - } - - if (envVar == "OSTYPE") - { - // TODO: Mac - return sys::Platform == sys::PlatformType::Linux ? " linux-gnu" : "Windows"; + return sys::platformName(); } // should explicitly handle all env. vars in some way diff --git a/externals/coda-oss/modules/c++/sys/source/ConditionVarPosix.cpp b/externals/coda-oss/modules/c++/sys/source/ConditionVarPosix.cpp index 505a17634..d1e288629 100644 --- a/externals/coda-oss/modules/c++/sys/source/ConditionVarPosix.cpp +++ b/externals/coda-oss/modules/c++/sys/source/ConditionVarPosix.cpp @@ -32,7 +32,7 @@ sys::ConditionVarPosix::ConditionVarPosix() : mMutexOwned(std::make_unique()), mMutex(mMutexOwned.get()) { - if ( ::pthread_cond_init(&mNative, NULL) != 0) + if ( ::pthread_cond_init(&mNative, nullptr) != 0) throw SystemException("ConditionVar initialization failed"); } @@ -41,7 +41,7 @@ sys::ConditionVarPosix::ConditionVarPosix(MutexPosix* theLock, bool isOwner, std if (isOwner) mMutexOwned.reset(theLock); - if (::pthread_cond_init(&mNative, NULL) != 0) + if (::pthread_cond_init(&mNative, nullptr) != 0) throw SystemException("ConditionVar initialization failed"); } sys::ConditionVarPosix::ConditionVarPosix(sys::MutexPosix* theLock, bool isOwner) : ConditionVarPosix(theLock, isOwner, nullptr) @@ -87,7 +87,7 @@ void sys::ConditionVarPosix::wait(double seconds) if ( seconds > 0 ) { timespec tout; - tout.tv_sec = time(NULL) + gsl::narrow_cast(seconds); + tout.tv_sec = time(nullptr) + gsl::narrow_cast(seconds); tout.tv_nsec = gsl::narrow_cast((seconds - gsl::narrow_cast(seconds)) * 1e9); if (::pthread_cond_timedwait(&mNative, &(mMutex->getNative()), diff --git a/externals/coda-oss/modules/c++/sys/source/CppUnitTestAssert_.cpp_ b/externals/coda-oss/modules/c++/sys/source/CppUnitTestAssert_.cpp_ new file mode 100644 index 000000000..9b2594ac5 --- /dev/null +++ b/externals/coda-oss/modules/c++/sys/source/CppUnitTestAssert_.cpp_ @@ -0,0 +1,43 @@ +#include "pch.h" +#include "TestCase.h" + +#include "str/EncodedStringView.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +// EQUALS_MESSAGE() wants ToString() specializations (or overloads) for our types, which is a nusiance. +// This hooks up our existing str::toString() into the VC++ unit-test infrastructure + +// C++ hack to call private methods +// https://stackoverflow.com/a/71578383/8877 + +using FailOnCondition_t = void(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare method's type +using GetAssertMessage_t = std::wstring(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare method's type +template +struct caller final // helper structure to inject call() code +{ + friend void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) + { + fFailOnCondition(condition, message, pLineInfo); + } + + friend std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message) + { + return fGetAssertMessage(equality, expected, actual, message); + } +}; +template struct caller<&Assert::FailOnCondition, &Assert::GetAssertMessage>; // even instantiation of the helper + +void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare caller +void test::Assert::FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) +{ + ::FailOnCondition(condition, message, pLineInfo); // and call! +} + +std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare caller +std::wstring test::Assert::GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message) +{ + const str::EncodedStringView vExpected(expected); + const str::EncodedStringView vActual(actual); + return ::GetAssertMessage(equality, vExpected.wstring(), vActual.wstring(), message); // and call! +} diff --git a/externals/coda-oss/modules/c++/sys/source/DLLUnix.cpp b/externals/coda-oss/modules/c++/sys/source/DLLUnix.cpp index f43457e69..6ef817453 100644 --- a/externals/coda-oss/modules/c++/sys/source/DLLUnix.cpp +++ b/externals/coda-oss/modules/c++/sys/source/DLLUnix.cpp @@ -66,7 +66,7 @@ DLL_FUNCTION_PTR sys::DLL::retrieve(const std::string& functionName) { // Check to make sure we have a library - if ( mLib != NULL ) + if ( mLib != nullptr ) { // Now we get a ptr DLL_FUNCTION_PTR ptr = dlsym( mLib , functionName.c_str()); diff --git a/externals/coda-oss/modules/c++/sys/source/DateTime.cpp b/externals/coda-oss/modules/c++/sys/source/DateTime.cpp index e0f411d5b..a79b9bb8c 100644 --- a/externals/coda-oss/modules/c++/sys/source/DateTime.cpp +++ b/externals/coda-oss/modules/c++/sys/source/DateTime.cpp @@ -394,7 +394,7 @@ static double getNowInMillis() return (now.tv_sec + 1.0e-9 * now.tv_nsec) * 1000; #elif CODA_OSS_POSIX_SOURCE struct timeval now; - gettimeofday(&now,NULL); + gettimeofday(&now,nullptr); return (now.tv_sec + 1.0e-6 * now.tv_usec) * 1000; #elif _WIN32 // Getting time twice may be inefficient but is quicker diff --git a/externals/coda-oss/modules/c++/sys/source/ExecUnix.cpp b/externals/coda-oss/modules/c++/sys/source/ExecUnix.cpp index 24ea23103..a31bd6023 100644 --- a/externals/coda-oss/modules/c++/sys/source/ExecUnix.cpp +++ b/externals/coda-oss/modules/c++/sys/source/ExecUnix.cpp @@ -104,7 +104,7 @@ FILE* ExecPipe::openPipe(const std::string& command, // command the user specified execl("/bin/sh", "sh", "-c", command.c_str(), - static_cast(NULL)); + static_cast(nullptr)); //! exit the subprocess once it has completed exit(127); diff --git a/externals/coda-oss/modules/c++/sys/source/FileFinder.cpp b/externals/coda-oss/modules/c++/sys/source/FileFinder.cpp index 6b47dda79..b33cc47c4 100644 --- a/externals/coda-oss/modules/c++/sys/source/FileFinder.cpp +++ b/externals/coda-oss/modules/c++/sys/source/FileFinder.cpp @@ -208,6 +208,17 @@ std::vector sys::FileFinder::search( return files; } +static fs::path parent_path(const fs::path& p) +{ + // If the parent_path() is the same, we've reached to root. + const auto retval = p.parent_path(); + if (retval.empty() || (retval == p)) + { + throw std::runtime_error("At root of filesystem: " + p.string()); + } + return retval; +} + static fs::path findFirst(const sys::FilePredicate& pred, const fs::path& startingDirectory) { auto dir = startingDirectory; @@ -228,7 +239,8 @@ static fs::path findFirst(const sys::FilePredicate& pred, const fs::path& starti { throw std::logic_error("Won't traverse above .git directory at: " + dir.string()); } - dir = dir.parent_path(); + + dir = parent_path(dir); } } fs::path sys::findFirstFile(const fs::path& startingDirectory, const fs::path& filename) @@ -297,7 +309,7 @@ fs::path sys::test::findRootDirectory(const fs::path& p, const std::string& root // Once we're at a .git directory, we have to go down, not up ... or fail. if (!is_directory(p / ".git")) { - return findRootDirectory(p.parent_path(), rootName, isRoot); + return findRootDirectory(parent_path(p), rootName, isRoot); } // TODO: since we're in the "FileFinder" module, maybe try a bit harder to find "rootName"? @@ -316,7 +328,7 @@ static inline std::string Platform() static fs::path findCMakeRoot(const fs::path& path, const fs::path& dir) { - static const auto platform_and_configuration = ::Platform() + "-" + ::Configuration(); // "x64-Debug" + static const auto platform_and_configuration = ::Platform() + "-" + ::Configuration(); // "x64-Debug" const auto pred = [&](const fs::path& p) { if (p.filename() == platform_and_configuration) @@ -338,7 +350,7 @@ static fs::path findCMakeRoot(const fs::path& path, const fs::path& dir) return false; }; - return sys::test::findRootDirectory(path, "", pred); + return sys::test::findRootDirectory(path, "", pred); } fs::path findCMake_Root(const fs::path& path, @@ -404,13 +416,8 @@ static fs::path find_dotGITDirectory_(const fs::path& p, const fs::path& initial { return p; } - - auto parent = p.parent_path(); - if (parent.empty()) - { - throw std::invalid_argument("Can't find .git/ anywhere in: " + initial.string()); - } - return find_dotGITDirectory_(parent, initial); + + return find_dotGITDirectory_(parent_path(p), initial); } fs::path sys::test::find_dotGITDirectory(const fs::path& p) { diff --git a/externals/coda-oss/modules/c++/sys/source/MutexPosix.cpp b/externals/coda-oss/modules/c++/sys/source/MutexPosix.cpp index f28ce93be..d28418444 100644 --- a/externals/coda-oss/modules/c++/sys/source/MutexPosix.cpp +++ b/externals/coda-oss/modules/c++/sys/source/MutexPosix.cpp @@ -28,7 +28,7 @@ sys::MutexPosix::MutexPosix() { - if (::pthread_mutex_init(&mNative, NULL) != 0) + if (::pthread_mutex_init(&mNative, nullptr) != 0) throw sys::SystemException("Mutex initialization failed"); } diff --git a/externals/coda-oss/modules/c++/sys/source/OSUnix.cpp b/externals/coda-oss/modules/c++/sys/source/OSUnix.cpp index e2b96cf18..c9241b639 100644 --- a/externals/coda-oss/modules/c++/sys/source/OSUnix.cpp +++ b/externals/coda-oss/modules/c++/sys/source/OSUnix.cpp @@ -308,7 +308,7 @@ std::string sys::OSUnix::getEnv(const std::string& s) const bool sys::OSUnix::isEnvSet(const std::string& s) const { const char* envVal = getenv(s.c_str()); - return (envVal != NULL); + return envVal != nullptr; } void sys::OSUnix::setEnv(const std::string& var, diff --git a/externals/coda-oss/modules/c++/sys/source/ScopedCPUAffinityUnix.cpp b/externals/coda-oss/modules/c++/sys/source/ScopedCPUAffinityUnix.cpp index 2b7fbc844..e409b3b03 100644 --- a/externals/coda-oss/modules/c++/sys/source/ScopedCPUAffinityUnix.cpp +++ b/externals/coda-oss/modules/c++/sys/source/ScopedCPUAffinityUnix.cpp @@ -64,7 +64,7 @@ void ScopedCPUMaskUnix::initialize(int numCPUs) ScopedCPUMaskUnix::~ScopedCPUMaskUnix() { - if (mMask != NULL) + if (mMask != nullptr) { CPU_FREE(mMask); } diff --git a/externals/coda-oss/modules/c++/sys/source/ThreadPosix.cpp b/externals/coda-oss/modules/c++/sys/source/ThreadPosix.cpp index 4ee1f2411..c399b5c83 100644 --- a/externals/coda-oss/modules/c++/sys/source/ThreadPosix.cpp +++ b/externals/coda-oss/modules/c++/sys/source/ThreadPosix.cpp @@ -80,7 +80,7 @@ void *sys::ThreadPosix::__start(void *v) delete runnable; */ - pthread_exit(NULL); + pthread_exit(nullptr); return nullptr; } @@ -94,7 +94,7 @@ void sys::ThreadPosix::kill() } void sys::ThreadPosix::join() { - if (::pthread_join(mNative, NULL) != 0) + if (::pthread_join(mNative, nullptr) != 0) throw sys::SystemException("pthread_join()"); } void sys::ThreadPosix::yield() diff --git a/externals/coda-oss/modules/c++/sys/tests/DateTimeTest.cpp b/externals/coda-oss/modules/c++/sys/tests/DateTimeTest.cpp index f47fc3387..b2c5597f0 100644 --- a/externals/coda-oss/modules/c++/sys/tests/DateTimeTest.cpp +++ b/externals/coda-oss/modules/c++/sys/tests/DateTimeTest.cpp @@ -54,7 +54,7 @@ int main(int, char**) sys::CPUStopWatch csw; //std::cout << "CPS: " << CLOCKS_PER_SEC << std::endl; std::cout << "clock(): " << clock() / CLOCKS_PER_SEC << std::endl; - std::cout << "time(): " << time(NULL) << std::endl; + std::cout << "time(): " << time(nullptr) << std::endl; std::cout << "RTStart: " << sw.start() << std::endl; std::cout << "CStart: " << csw.start() << std::endl; int x = 0; @@ -82,7 +82,7 @@ int main(int, char**) } std::cout << "Finish Loop 3" << std::endl; std::cout << "clock(): " << clock() / CLOCKS_PER_SEC << std::endl; - std::cout << "time(): " << time(NULL) << std::endl; + std::cout << "time(): " << time(nullptr) << std::endl; std::cout << "RTStop: " << std::setprecision(50) << sw.stop() << std::endl; std::cout << "CStop: " << std::setprecision(50) << csw.stop() diff --git a/externals/coda-oss/modules/c++/sys/tests/OSTest.cpp b/externals/coda-oss/modules/c++/sys/tests/OSTest.cpp index f8ee1ea5a..330493eb7 100644 --- a/externals/coda-oss/modules/c++/sys/tests/OSTest.cpp +++ b/externals/coda-oss/modules/c++/sys/tests/OSTest.cpp @@ -110,7 +110,7 @@ int main(int argc, char **argv) } os.remove("TEST_DIRECTORY"); - std::cout << "Time Now: " << time(NULL) << std::endl; + std::cout << "Time Now: " << time(nullptr) << std::endl; sys::RealTimeStopWatch sw; //std::cout << "CPS: " << CLOCKS_PER_SEC << std::endl; // std::cout << "Clock: " << clock() << std::endl; @@ -137,7 +137,7 @@ int main(int argc, char **argv) std::cout << "Finish Loop 3" << std::endl; std::cout << "Stop: " << std::setprecision(50) << sw.stop() << std::endl; - std::cout << "Time Now: " << time(NULL) << std::endl; + std::cout << "Time Now: " << time(nullptr) << std::endl; // std::cout << "Clock: " << clock() << std::endl; } diff --git a/externals/coda-oss/modules/c++/tiff/source/IFDEntry.cpp b/externals/coda-oss/modules/c++/tiff/source/IFDEntry.cpp index 1ac612aea..d9f5447dd 100644 --- a/externals/coda-oss/modules/c++/tiff/source/IFDEntry.cpp +++ b/externals/coda-oss/modules/c++/tiff/source/IFDEntry.cpp @@ -120,8 +120,7 @@ void tiff::IFDEntry::deserialize(io::InputStream& input, const bool reverseBytes { auto elementSize = tiff::Const::sizeOf(mType); sys::Uint32_T numElements = mCount; - if (mType == tiff::Const::Type::RATIONAL && mType - == tiff::Const::Type::SRATIONAL) + if ((mType == tiff::Const::Type::RATIONAL) || (mType == tiff::Const::Type::SRATIONAL)) { elementSize = tiff::Const::sizeOf(mType) / 2; numElements = mCount * 2; diff --git a/externals/coda-oss/modules/c++/types/include/types/Complex.h b/externals/coda-oss/modules/c++/types/include/types/Complex.h index 46daa0f85..8b2218ff4 100644 --- a/externals/coda-oss/modules/c++/types/include/types/Complex.h +++ b/externals/coda-oss/modules/c++/types/include/types/Complex.h @@ -221,9 +221,9 @@ static_assert(sizeof(std::complex) == sizeof(Complex), "sizeof(siz static_assert(std::is_same, ComplexReal>::value, "should be std::complex"); // Convenient aliases -using zfloat = ComplexReal; // std::complex -using zdouble = ComplexReal; // std::complex -//using zlong_double = ComplexReal; // std::complex +using zfloat = ComplexReal; // i.e., std::complex +using zdouble = ComplexReal; // i.e., std::complex +//using zlong_double = ComplexReal; // i.e., std::complex using zint8_t = ComplexInteger; // Complex using zint16_t = ComplexInteger; // Complex using zint32_t = ComplexInteger; // Complex diff --git a/externals/coda-oss/modules/c++/xml.lite/include/import/xml/lite.h b/externals/coda-oss/modules/c++/xml.lite/include/import/xml/lite.h index 477e27c80..b7b66bca8 100644 --- a/externals/coda-oss/modules/c++/xml.lite/include/import/xml/lite.h +++ b/externals/coda-oss/modules/c++/xml.lite/include/import/xml/lite.h @@ -20,39 +20,9 @@ * */ +#pragma once #ifndef CODA_OSS_xml_lite_import_lite_h_INCLUDED_ #define CODA_OSS_xml_lite_import_lite_h_INCLUDED_ -#pragma once - -#if _MSC_VER -#pragma warning(push) -// these are from Xerces -#pragma warning(disable: 5219) // implicit conversion from '...' to '...', possible loss of data -#pragma warning(disable: 4365) // '...': conversion from '...' to '...', signed / unsigned mismatch -#pragma warning(disable: 26477) // Use 'nullptr' rather than 0 or NULL (es.47). -#pragma warning(disable: 26493) // Don't use C-style casts (type.4). -#pragma warning(disable: 26814) // The const variable '...' can be computed at compile-time. Consider using constexpr (con.5). -#pragma warning(disable: 26496) // The variable '...' does not change after construction, mark it as const (con.4). -#pragma warning(disable: 26497) // The function '...' could be marked constexpr if compile-time evaluation is desired (f.4). -#pragma warning(disable: 26475) // Do not use function style casts (es.49). Prefer '...' over '...'. -#pragma warning(disable: 26495) // Variable '...' is uninitialized. Always initialize a member variable (type.6). -#pragma warning(disable: 26461) // The pointer argument '...' for function '...' can be marked as a pointer to const (con.3). -#pragma warning(disable: 26462) // The value pointed to by '...' is assigned only once, mark it as a pointer to const (con.4). -#pragma warning(disable: 26494) // Variable '...' is uninitialized. Always initialize an object (type.5). -#pragma warning(disable: 26489) // Don't dereference a pointer that may be invalid: '...'. '...' may have been invalidated at line ... (lifetime.1). -#pragma warning(disable: 26488) // Do not dereference a potentially null pointer : ...'. '...' was null at line ... (lifetime.1). -#pragma warning(disable: 26447) // The function is declared '...' but calls function '..' which may throw exceptions (f.6). -#pragma warning(disable: 26485) // Expression '...': No array to pointer decay (bounds.3). -#pragma warning(disable: 26457) // (void) should not be used to ignore return values, use '...' instead (es.48). -#pragma warning(disable: 26487) // Don't return a pointer '...' that may be invalid (lifetime.4). -#pragma warning(disable: 26451) // Arithmetic overflow : Using operator '...' on a 4 byte value and then casting the result to a 8 byte value. Cast the value to the wider type before calling operator '...' to avoid overflow (io.2). -#pragma warning(disable: 26455) // Default constructor may not throw.Declare it 'noexcept' (f.6). -#pragma warning(disable: 26409) // Avoid calling new and delete explicitly, use std::make_unique instead (r.11). -#pragma warning(disable: 26429) // Symbol '...' is never tested for nullness, it can be marked as not_null(f.23). -#pragma warning(disable: 26400) // Do not assign the result of an allocation or a function call with an owner return value to a raw pointer, use owner instead(i.11). -#pragma warning(disable: 26467) // Converting from floating point to unsigned integral types results in non-portable code if the double/float has a negative value. Use gsl::narrow_cast or gsl::narrow instead to guard against undefined behavior and potential data loss (es.46). -#pragma warning(disable: 26823) // Dereferencing a possibly null pointer '...' (lifetime.1). -#endif // _MSC_VER #include "xml/lite/ContentHandler.h" #include "xml/lite/Attributes.h" @@ -67,16 +37,6 @@ #include "xml/lite/Serializable.h" #include "xml/lite/Validator.h" -#if _MSC_VER -#pragma warning(pop) - -#pragma comment(lib, "xml.lite-c++.lib") - -#if defined(USE_XERCES) -#pragma comment(lib, "xerces-c") -#endif -#endif - /*! * \file lite.h * diff --git a/externals/coda-oss/modules/c++/xml.lite/include/xml/lite/xerces_.h b/externals/coda-oss/modules/c++/xml.lite/include/xml/lite/xerces_.h index 51d2ca436..b35fc4714 100644 --- a/externals/coda-oss/modules/c++/xml.lite/include/xml/lite/xerces_.h +++ b/externals/coda-oss/modules/c++/xml.lite/include/xml/lite/xerces_.h @@ -54,6 +54,11 @@ CODA_OSS_disable_warning_system_header_push CODA_OSS_disable_warning(-Wshadow) CODA_OSS_disable_warning(-Wsuggest-override) CODA_OSS_disable_warning(-Wzero-as-null-pointer-constant) +CODA_OSS_disable_warning(-Wmisleading-indentation) +CODA_OSS_disable_warning(-Wsign-compare) +CODA_OSS_disable_warning(-Wformat-overflow=) +CODA_OSS_disable_warning(-Wunused-value) +CODA_OSS_disable_warning(-Walloc-size-larger-than=) #endif #include diff --git a/externals/coda-oss/modules/c++/xml.lite/source/Serializable.cpp b/externals/coda-oss/modules/c++/xml.lite/source/Serializable.cpp index d5f55479c..27cb7aaf0 100644 --- a/externals/coda-oss/modules/c++/xml.lite/source/Serializable.cpp +++ b/externals/coda-oss/modules/c++/xml.lite/source/Serializable.cpp @@ -26,8 +26,10 @@ void xml::lite::Serializable::serialize(io::OutputStream& os) { xml::lite::Element *root = getDocument()->getRootElement(); if (root != nullptr) + { os.write("\n"); - root->print(os); + root->print(os); + } } void xml::lite::Serializable::deserialize(io::InputStream& is) diff --git a/externals/coda-oss/modules/c++/zip/source/ZipOutputStream.cpp b/externals/coda-oss/modules/c++/zip/source/ZipOutputStream.cpp index f4e09e34c..2b9bd903e 100644 --- a/externals/coda-oss/modules/c++/zip/source/ZipOutputStream.cpp +++ b/externals/coda-oss/modules/c++/zip/source/ZipOutputStream.cpp @@ -48,9 +48,9 @@ void ZipOutputStream::createFileInZip(const std::string& pathname, mZip, pathname.c_str(), &zipFileInfo, - NULL, + nullptr, 0, - NULL, + nullptr, 0, comment.empty() ? nullptr : comment.c_str(), Z_DEFLATED, From 60b3c0f0daca81fe13d4c9273da38744c9a3f0f1 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Tue, 18 Jul 2023 09:35:21 -0400 Subject: [PATCH 095/104] Fixed bug in Error::to_string(); using the entire buffer rather than to '\0' --- .../coda-oss/modules/c++/except/include/except/Throwable.h | 4 ++-- modules/c++/nitf/include/nitf/NITFException.hpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/externals/coda-oss/modules/c++/except/include/except/Throwable.h b/externals/coda-oss/modules/c++/except/include/except/Throwable.h index 2a7deecbb..45e990fc8 100644 --- a/externals/coda-oss/modules/c++/except/include/except/Throwable.h +++ b/externals/coda-oss/modules/c++/except/include/except/Throwable.h @@ -166,8 +166,8 @@ class CODA_OSS_API Throwable if (t.getSize() > 0) s << ": " << t; - std::string retval(s.str().c_str()); // truncate to first '\0' - return retval; + return s.str(); + //return s.str().c_str(); // truncate to first '\0' } const std::vector& getBacktrace() const noexcept diff --git a/modules/c++/nitf/include/nitf/NITFException.hpp b/modules/c++/nitf/include/nitf/NITFException.hpp index afdbd8f90..46b9bac5b 100644 --- a/modules/c++/nitf/include/nitf/NITFException.hpp +++ b/modules/c++/nitf/include/nitf/NITFException.hpp @@ -46,7 +46,7 @@ namespace nitf static std::string to_string(const char(&s)[sz]) { // avoid array -> pointer decay; code-analysis diagnostic - return std::string(s, sz); + return std::string(s); } public: Error(const nitf_Error* error) noexcept : pError(error) { assert(pError != nullptr); } From e3c1ad56f888c979e527719ca65f82f8ec350ac9 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Tue, 18 Jul 2023 10:28:52 -0400 Subject: [PATCH 096/104] latest from CODA-OSS --- .../c++/except/include/except/Throwable.h | 1 - .../c++/sys/source/CppUnitTestAssert_.cpp_ | 86 +++++++++---------- 2 files changed, 43 insertions(+), 44 deletions(-) diff --git a/externals/coda-oss/modules/c++/except/include/except/Throwable.h b/externals/coda-oss/modules/c++/except/include/except/Throwable.h index 45e990fc8..5067ab02a 100644 --- a/externals/coda-oss/modules/c++/except/include/except/Throwable.h +++ b/externals/coda-oss/modules/c++/except/include/except/Throwable.h @@ -167,7 +167,6 @@ class CODA_OSS_API Throwable s << ": " << t; return s.str(); - //return s.str().c_str(); // truncate to first '\0' } const std::vector& getBacktrace() const noexcept diff --git a/externals/coda-oss/modules/c++/sys/source/CppUnitTestAssert_.cpp_ b/externals/coda-oss/modules/c++/sys/source/CppUnitTestAssert_.cpp_ index 9b2594ac5..fdcf5f92b 100644 --- a/externals/coda-oss/modules/c++/sys/source/CppUnitTestAssert_.cpp_ +++ b/externals/coda-oss/modules/c++/sys/source/CppUnitTestAssert_.cpp_ @@ -1,43 +1,43 @@ -#include "pch.h" -#include "TestCase.h" - -#include "str/EncodedStringView.h" - -using namespace Microsoft::VisualStudio::CppUnitTestFramework; - -// EQUALS_MESSAGE() wants ToString() specializations (or overloads) for our types, which is a nusiance. -// This hooks up our existing str::toString() into the VC++ unit-test infrastructure - -// C++ hack to call private methods -// https://stackoverflow.com/a/71578383/8877 - -using FailOnCondition_t = void(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare method's type -using GetAssertMessage_t = std::wstring(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare method's type -template -struct caller final // helper structure to inject call() code -{ - friend void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) - { - fFailOnCondition(condition, message, pLineInfo); - } - - friend std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message) - { - return fGetAssertMessage(equality, expected, actual, message); - } -}; -template struct caller<&Assert::FailOnCondition, &Assert::GetAssertMessage>; // even instantiation of the helper - -void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare caller -void test::Assert::FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) -{ - ::FailOnCondition(condition, message, pLineInfo); // and call! -} - -std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare caller -std::wstring test::Assert::GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message) -{ - const str::EncodedStringView vExpected(expected); - const str::EncodedStringView vActual(actual); - return ::GetAssertMessage(equality, vExpected.wstring(), vActual.wstring(), message); // and call! -} +#include "pch.h" +#include "TestCase.h" + +#include "str/EncodedStringView.h" + +using namespace Microsoft::VisualStudio::CppUnitTestFramework; + +// EQUALS_MESSAGE() wants ToString() specializations (or overloads) for our types, which is a nusiance. +// This hooks up our existing str::toString() into the VC++ unit-test infrastructure + +// C++ hack to call private methods +// https://stackoverflow.com/a/71578383/8877 + +using FailOnCondition_t = void(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare method's type +using GetAssertMessage_t = std::wstring(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare method's type +template +struct caller final // helper structure to inject call() code +{ + friend void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) + { + fFailOnCondition(condition, message, pLineInfo); + } + + friend std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message) + { + return fGetAssertMessage(equality, expected, actual, message); + } +}; +template struct caller<&Assert::FailOnCondition, &Assert::GetAssertMessage>; // even instantiation of the helper + +void FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo); // declare caller +void test::Assert::FailOnCondition(bool condition, const unsigned short* message, const __LineInfo* pLineInfo) +{ + ::FailOnCondition(condition, message, pLineInfo); // and call! +} + +std::wstring GetAssertMessage(bool equality, const std::wstring& expected, const std::wstring& actual, const wchar_t *message); // declare caller +std::wstring test::Assert::GetAssertMessage(bool equality, const std::string& expected, const std::string& actual, const wchar_t *message) +{ + const str::EncodedStringView vExpected(expected); + const str::EncodedStringView vActual(actual); + return ::GetAssertMessage(equality, vExpected.wstring(), vActual.wstring(), message); // and call! +} From 9357f7116a6c7be9c39799aa0c235ed1c3261b4c Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Tue, 18 Jul 2023 10:28:56 -0400 Subject: [PATCH 097/104] Squashed 'externals/coda-oss/' changes from e2472acfc1..4092fd8e76 4092fd8e76 remove work-around for NITRO bug (#704) git-subtree-dir: externals/coda-oss git-subtree-split: 4092fd8e76d6c833dfa4c5e1e97396174001dd08 --- modules/c++/except/include/except/Throwable.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/modules/c++/except/include/except/Throwable.h b/modules/c++/except/include/except/Throwable.h index 2a7deecbb..5067ab02a 100644 --- a/modules/c++/except/include/except/Throwable.h +++ b/modules/c++/except/include/except/Throwable.h @@ -166,8 +166,7 @@ class CODA_OSS_API Throwable if (t.getSize() > 0) s << ": " << t; - std::string retval(s.str().c_str()); // truncate to first '\0' - return retval; + return s.str(); } const std::vector& getBacktrace() const noexcept From 7a6d76bed62a27e69b53f47c451879badca59229 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Tue, 18 Jul 2023 16:37:56 -0400 Subject: [PATCH 098/104] fix WAF build errors discovered in CODA --- modules/c++/nitf/unittests/test_hash_table_1++.cpp | 4 +--- modules/c++/nitf/unittests/test_writer_3++.cpp | 3 ++- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/modules/c++/nitf/unittests/test_hash_table_1++.cpp b/modules/c++/nitf/unittests/test_hash_table_1++.cpp index 8f382d942..c13fbd5ae 100644 --- a/modules/c++/nitf/unittests/test_hash_table_1++.cpp +++ b/modules/c++/nitf/unittests/test_hash_table_1++.cpp @@ -151,8 +151,6 @@ TEST_CASE(test_hash_table_iterator) } TEST_MAIN( - (void)argc; - (void)argv; TEST_CHECK(test_hash_table_1); TEST_CHECK(test_hash_table_iterator); -) \ No newline at end of file +) diff --git a/modules/c++/nitf/unittests/test_writer_3++.cpp b/modules/c++/nitf/unittests/test_writer_3++.cpp index d2955dd26..e68dd3d37 100644 --- a/modules/c++/nitf/unittests/test_writer_3++.cpp +++ b/modules/c++/nitf/unittests/test_writer_3++.cpp @@ -28,6 +28,7 @@ #include #include +#include #include "TestCase.h" @@ -268,4 +269,4 @@ TEST_CASE(test_buffered_write_) TEST_MAIN( TEST_CHECK(test_writer_3_); TEST_CHECK(test_buffered_write_); - ) \ No newline at end of file + ) From b3292588d8160b29c2b2b47abe217da82e5eb06f Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Wed, 19 Jul 2023 08:28:00 -0400 Subject: [PATCH 099/104] changes from cpp17 branch --- modules/c++/nitf/apps/show_nitf++/pch.h | 1 + modules/c++/pch.h | 1 + modules/c/j2k/shared/J2KCompress.c | 13 ++-------- modules/c/j2k/shared/J2KDecompress.c | 13 ++-------- modules/c/nitf/include/import/nitf.h | 32 +++++++++++++++++++++++-- modules/c/nitf/shared/ACCHZB.c | 6 ----- modules/c/nitf/shared/JITCID.c | 7 +----- modules/c/pch.h | 1 + 8 files changed, 38 insertions(+), 36 deletions(-) diff --git a/modules/c++/nitf/apps/show_nitf++/pch.h b/modules/c++/nitf/apps/show_nitf++/pch.h index 8177193ae..e9911867d 100644 --- a/modules/c++/nitf/apps/show_nitf++/pch.h +++ b/modules/c++/nitf/apps/show_nitf++/pch.h @@ -41,6 +41,7 @@ #pragma warning(disable: 5204) // '...': class has virtual functions, but its trivial destructor is not virtual; instances of objects derived from this class may not be destructed correctly #pragma warning(disable: 5220) // '...': a non-static data member with a volatile qualified type no longer implies #pragma warning(disable: 4355) // '...': used in base member initializer list +#pragma warning(disable: 5105) // macro expansion producing '...' has undefined behavior #define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers #include diff --git a/modules/c++/pch.h b/modules/c++/pch.h index 2d5aa6125..e2236fd36 100644 --- a/modules/c++/pch.h +++ b/modules/c++/pch.h @@ -28,6 +28,7 @@ CODA_OSS_disable_warning_pop #define NOMINMAX #pragma warning(push) #pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to 'extern "C"' function under -EHc. Undefined behavior may occur if this function throws an exception. +#pragma warning(disable: 5105) // macro expansion producing '...' has undefined behavior #include #pragma warning(pop) diff --git a/modules/c/j2k/shared/J2KCompress.c b/modules/c/j2k/shared/J2KCompress.c index 5eb24805e..9af824236 100644 --- a/modules/c/j2k/shared/J2KCompress.c +++ b/modules/c/j2k/shared/J2KCompress.c @@ -20,23 +20,14 @@ * */ +#include + #ifdef HAVE_J2K_H #if _MSC_VER -#ifndef WIN32_LEAN_AND_MEAN -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers -#endif -#pragma warning(push) -#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to '...' -#include -#pragma warning(pop) -#undef min -#undef max - #pragma warning(disable: 5045) // Compiler will insert Spectre mitigation for memory load if /Qspectre switch specified #endif // _MSC_VER -#include #include NITF_CXX_GUARD diff --git a/modules/c/j2k/shared/J2KDecompress.c b/modules/c/j2k/shared/J2KDecompress.c index 12daa2020..c9b2c0a4a 100644 --- a/modules/c/j2k/shared/J2KDecompress.c +++ b/modules/c/j2k/shared/J2KDecompress.c @@ -20,23 +20,14 @@ * */ +#include + #ifdef HAVE_J2K_H #if _MSC_VER -#ifndef WIN32_LEAN_AND_MEAN -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers -#endif -#pragma warning(push) -#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to '...' -#include -#pragma warning(pop) -#undef min -#undef max - #pragma warning(disable: 5045) // Compiler will insert Spectre mitigation for memory load if /Qspectre switch specified #endif // _MSC_VER -#include #include NITF_CXX_GUARD diff --git a/modules/c/nitf/include/import/nitf.h b/modules/c/nitf/include/import/nitf.h index 14afa57f2..3f03e9bb4 100644 --- a/modules/c/nitf/include/import/nitf.h +++ b/modules/c/nitf/include/import/nitf.h @@ -20,8 +20,32 @@ * */ -#ifndef __IMPORT_NITF_H__ -#define __IMPORT_NITF_H__ +#pragma once +#ifndef NITRO_nitf_import_nitf_h_INCLUDED_ +#define NITRO_nitf_import_nitf_h_INCLUDED_ + +#if _MSC_VER +#pragma warning(push) +#pragma warning(disable: 4820) // '...' : '...' bytes padding added after data member '...' +#pragma warning(disable: 4668) // '...' is not defined as a preprocessor macro, replacing with '...' for '...' +#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to '...' function under -EHc. Undefined behavior may occur if this function throws an exception. +#pragma warning(disable: 5105) // macro expansion producing '...' has undefined behavior +#pragma warning(disable: 5045) // Compiler will insert Spectre mitigation for memory load if /Qspectre switch specified +#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to '...' +#pragma warning(disable: 5105) // macro expansion producing '...' has undefined behavior +#endif + +#if _MSC_VER +#ifndef WIN32_LEAN_AND_MEAN +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#endif +#ifndef NOMINMAX +#define NOMINMAX +#endif +#include +#undef min +#undef max +#endif #include "nitf/BandInfo.h" #include "nitf/BandSource.h" @@ -67,4 +91,8 @@ #include "nitf/DirectBlockSource.h" #include "nitf/WriterOptions.h" +#if _MSC_VER +#pragma warning(pop) #endif + +#endif // NITRO_nitf_import_nitf_h_INCLUDED_ \ No newline at end of file diff --git a/modules/c/nitf/shared/ACCHZB.c b/modules/c/nitf/shared/ACCHZB.c index 108de34b5..2107c87b4 100644 --- a/modules/c/nitf/shared/ACCHZB.c +++ b/modules/c/nitf/shared/ACCHZB.c @@ -20,12 +20,6 @@ * */ -#if _MSC_VER -#pragma warning(disable: 4820) // '...' : '...' bytes padding added after data member '...' -#pragma warning(disable: 4668) // '...' is not defined as a preprocessor macro, replacing with '...' for '...' -#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to '...' function under -EHc. Undefined behavior may occur if this function throws an exception. -#endif - #include NITF_CXX_GUARD diff --git a/modules/c/nitf/shared/JITCID.c b/modules/c/nitf/shared/JITCID.c index 50ee19ed4..73bacd87a 100644 --- a/modules/c/nitf/shared/JITCID.c +++ b/modules/c/nitf/shared/JITCID.c @@ -20,12 +20,7 @@ * */ -#if _MSC_VER -#pragma warning(disable: 4820) // '...' : '...' bytes padding added after data member '...' -#pragma warning(disable: 4668) // '...' is not defined as a preprocessor macro, replacing with '...' for '...' -#pragma warning(disable: 5039) // '...': pointer or reference to potentially throwing function passed to '...' function under -EHc. Undefined behavior may occur if this function throws an exception. -#endif - +#include #include #include diff --git a/modules/c/pch.h b/modules/c/pch.h index 5928459c7..ca4079d2d 100644 --- a/modules/c/pch.h +++ b/modules/c/pch.h @@ -20,6 +20,7 @@ #pragma warning(push) #pragma warning(disable: 4820) // '...': '...' bytes padding added after data member '...' +#pragma warning(disable: 5105) // macro expansion producing '...' has undefined behavior #define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers #include From a01a9f68f2de1068087ac00e7096896a2730e5d2 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Wed, 19 Jul 2023 09:16:29 -0400 Subject: [PATCH 100/104] trying to get test_load_all_plugins() working on Linux --- modules/c++/nitf/unittests/test_load_plugins.cpp | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/modules/c++/nitf/unittests/test_load_plugins.cpp b/modules/c++/nitf/unittests/test_load_plugins.cpp index 4aaee43ca..8be8b31e7 100644 --- a/modules/c++/nitf/unittests/test_load_plugins.cpp +++ b/modules/c++/nitf/unittests/test_load_plugins.cpp @@ -49,13 +49,13 @@ static void load_plugin(const std::string& testName, const char* tre) TEST_ASSERT(test_main_ != nullptr); } -static const std::vector& all_plugins() +static const auto& all_plugins() { - static const std::vector all_plugins_ + static const std::vector retval { #if _MSC_VER && NITRO_PCH // only build a handful in Visual Studio - "ACCHZB", "ACCPOB", "ACFTA", "AIMIDB", "CSCRNA", "ENGRDA", "HISTOA", "JITCID", "PTPRAA", "RPFHDR", + "ACCHZB", "ACCPOB", "ACFTA", "AIMIDB", "CSCRNA", "CSEXRB", "ENGRDA", "HISTOA", "JITCID", "PTPRAA", "RPFHDR", #else "ACCHZB", "BANDSB", "CSDIDA", "GEOLOB", "JITCID", "NBLOCA", "PIAPEB", "REGPTB", "RSMIDA", "STEROB", "ACCPOB", "BCKGDA", "CSEPHA", "GEOPSB", "MAPLOB", "OBJCTA", "PIAPRC", "RPC00B", "RSMPCA", "STREOB", @@ -69,7 +69,7 @@ static const std::vector& all_plugins() "BANDSA", "CSCRNA", "EXPLTB", "J2KLRA", "MTIRPB", "PIAPEA", "PTPRAA", "RSMGIA", "STDIDC", #endif }; - return all_plugins_; + return retval; } TEST_CASE(test_load_all_plugins_C) @@ -97,10 +97,7 @@ static void loadPlugin(const std::string& testName, const std::string& path) { try { -#ifdef _WIN32 - // need the full path to load on Linux nitf::PluginRegistry::loadPlugin(path); -#endif TEST_SUCCESS; } catch (const nitf::NITFException& ex) @@ -121,7 +118,7 @@ TEST_CASE(test_load_all_plugins) TEST_MAIN( TEST_CHECK(test_load_PTPRAA); - TEST_CHECK(test_load_ENGRDA); + TEST_CHECK(test_load_ENGRDA); TEST_CHECK(test_load_all_plugins_C); TEST_CHECK(test_load_all_plugins); ) \ No newline at end of file From 2ea1669e3bf6865be579d263e438fa58d2d18396 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Wed, 19 Jul 2023 09:43:16 -0400 Subject: [PATCH 101/104] fix compile warning --- modules/c/nitf/source/BandInfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/c/nitf/source/BandInfo.c b/modules/c/nitf/source/BandInfo.c index c70ee3f1c..685c5ac33 100644 --- a/modules/c/nitf/source/BandInfo.c +++ b/modules/c/nitf/source/BandInfo.c @@ -80,7 +80,7 @@ NITFAPI(void) nitf_BandInfo_destruct(nitf_BandInfo ** info) _NITF_DESTRUCT_FIELD(&(*info), NITF_NLUTS); _NITF_DESTRUCT_FIELD(&(*info), NITF_NELUT); - if (&(*info)->lut) + if ((*info)->lut) { nitf_LookupTable_destruct(&(*info)->lut); } From bf16edd97ca2fb56eb51848484299df06336cf58 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Wed, 19 Jul 2023 10:53:52 -0400 Subject: [PATCH 102/104] only need to call setNitfPluginPath() once --- .../c++/nitf/unittests/test_load_plugins.cpp | 41 ++++++++----------- 1 file changed, 16 insertions(+), 25 deletions(-) diff --git a/modules/c++/nitf/unittests/test_load_plugins.cpp b/modules/c++/nitf/unittests/test_load_plugins.cpp index 8be8b31e7..32c2f9414 100644 --- a/modules/c++/nitf/unittests/test_load_plugins.cpp +++ b/modules/c++/nitf/unittests/test_load_plugins.cpp @@ -30,7 +30,7 @@ #include "TestCase.h" -static void load_plugin(const std::string& testName, const char* tre) +static void retrieveTREHandler(const std::string& testName, const char* tre) { nitf_Error error; @@ -72,53 +72,44 @@ static const auto& all_plugins() return retval; } -TEST_CASE(test_load_all_plugins_C) +TEST_CASE(test_retrieveTREHandler) { - nitf::Test::setNitfPluginPath(); - for (const auto& tre : all_plugins()) { - load_plugin(testName, tre.c_str()); + retrieveTREHandler(testName, tre.c_str()); } } TEST_CASE(test_load_PTPRAA) { - nitf::Test::setNitfPluginPath(); - load_plugin(testName, "PTPRAA"); + retrieveTREHandler(testName, "PTPRAA"); } TEST_CASE(test_load_ENGRDA) { - nitf::Test::setNitfPluginPath(); - load_plugin(testName, "ENGRDA"); + retrieveTREHandler(testName, "ENGRDA"); } -static void loadPlugin(const std::string& testName, const std::string& path) -{ - try - { - nitf::PluginRegistry::loadPlugin(path); - TEST_SUCCESS; - } - catch (const nitf::NITFException& ex) - { - TEST_FAIL_MSG(ex.toString()); - } -} TEST_CASE(test_load_all_plugins) { - nitf::Test::setNitfPluginPath(); - for (const auto& tre : all_plugins()) { - loadPlugin(testName, tre); + try + { + nitf::PluginRegistry::loadPlugin(tre); + } + catch (const nitf::NITFException& ex) + { + TEST_FAIL_MSG(ex.toString()); + } TEST_ASSERT(nitf::PluginRegistry::treHandlerExists(tre)); } } TEST_MAIN( + nitf::Test::setNitfPluginPath(); + TEST_CHECK(test_load_PTPRAA); TEST_CHECK(test_load_ENGRDA); - TEST_CHECK(test_load_all_plugins_C); + TEST_CHECK(test_retrieveTREHandler); TEST_CHECK(test_load_all_plugins); ) \ No newline at end of file From bfc8903e153825be9b6f295b5ceae9199fa2332e Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Wed, 19 Jul 2023 10:53:52 -0400 Subject: [PATCH 103/104] only need to call setNitfPluginPath() once --- .../c++/nitf/unittests/test_load_plugins.cpp | 51 +++++++------------ 1 file changed, 19 insertions(+), 32 deletions(-) diff --git a/modules/c++/nitf/unittests/test_load_plugins.cpp b/modules/c++/nitf/unittests/test_load_plugins.cpp index 8be8b31e7..9c551728b 100644 --- a/modules/c++/nitf/unittests/test_load_plugins.cpp +++ b/modules/c++/nitf/unittests/test_load_plugins.cpp @@ -30,21 +30,17 @@ #include "TestCase.h" -static void load_plugin(const std::string& testName, const char* tre) +static void retrieveTREHandler(const std::string& testName, const char* tre) { nitf_Error error; - auto reg = nitf::PluginRegistry::getInstance(error); + auto const reg = nitf::PluginRegistry::getInstance(error); TEST_ASSERT(reg != nullptr); - nitf::HashTable::print(*(reg->treHandlers)); + //nitf::HashTable::print(*(reg->treHandlers)); int bad = 0; - auto test_main_ = - nitf::PluginRegistry::retrieveTREHandler(*reg, - tre, - bad, - error); + auto const test_main_ = nitf::PluginRegistry::retrieveTREHandler(*reg, tre, bad, error); TEST_ASSERT_EQ(0, bad); TEST_ASSERT(test_main_ != nullptr); } @@ -72,53 +68,44 @@ static const auto& all_plugins() return retval; } -TEST_CASE(test_load_all_plugins_C) +TEST_CASE(test_retrieveTREHandler) { - nitf::Test::setNitfPluginPath(); - for (const auto& tre : all_plugins()) { - load_plugin(testName, tre.c_str()); + retrieveTREHandler(testName, tre.c_str()); } } TEST_CASE(test_load_PTPRAA) { - nitf::Test::setNitfPluginPath(); - load_plugin(testName, "PTPRAA"); + retrieveTREHandler(testName, "PTPRAA"); } TEST_CASE(test_load_ENGRDA) { - nitf::Test::setNitfPluginPath(); - load_plugin(testName, "ENGRDA"); + retrieveTREHandler(testName, "ENGRDA"); } -static void loadPlugin(const std::string& testName, const std::string& path) -{ - try - { - nitf::PluginRegistry::loadPlugin(path); - TEST_SUCCESS; - } - catch (const nitf::NITFException& ex) - { - TEST_FAIL_MSG(ex.toString()); - } -} TEST_CASE(test_load_all_plugins) { - nitf::Test::setNitfPluginPath(); - for (const auto& tre : all_plugins()) { - loadPlugin(testName, tre); + try + { + nitf::PluginRegistry::loadPlugin(tre); + } + catch (const nitf::NITFException& ex) + { + TEST_FAIL_MSG(ex.toString()); + } TEST_ASSERT(nitf::PluginRegistry::treHandlerExists(tre)); } } TEST_MAIN( + nitf::Test::setNitfPluginPath(); + TEST_CHECK(test_load_PTPRAA); TEST_CHECK(test_load_ENGRDA); - TEST_CHECK(test_load_all_plugins_C); + TEST_CHECK(test_retrieveTREHandler); TEST_CHECK(test_load_all_plugins); ) \ No newline at end of file From 5b88f625b1c18a90fd43f11d64755c85a47311bf Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Wed, 19 Jul 2023 13:19:43 -0400 Subject: [PATCH 104/104] figured out why loadPlugin() failed on Linux --- .../c++/nitf/unittests/test_load_plugins.cpp | 22 ++++++++++++++----- .../c++/nitf/unittests/test_tre_create++.cpp | 6 ++--- .../c++/nitf/unittests/test_tre_mods++.cpp | 22 ++----------------- modules/c++/nitf/unittests/test_tre_mods.cpp | 18 ++------------- 4 files changed, 23 insertions(+), 45 deletions(-) diff --git a/modules/c++/nitf/unittests/test_load_plugins.cpp b/modules/c++/nitf/unittests/test_load_plugins.cpp index 9c551728b..c94707f56 100644 --- a/modules/c++/nitf/unittests/test_load_plugins.cpp +++ b/modules/c++/nitf/unittests/test_load_plugins.cpp @@ -45,7 +45,7 @@ static void retrieveTREHandler(const std::string& testName, const char* tre) TEST_ASSERT(test_main_ != nullptr); } -static const auto& all_plugins() +static const auto& all_TREs() { static const std::vector retval { @@ -70,7 +70,7 @@ static const auto& all_plugins() TEST_CASE(test_retrieveTREHandler) { - for (const auto& tre : all_plugins()) + for (const auto& tre : all_TREs()) { retrieveTREHandler(testName, tre.c_str()); } @@ -85,10 +85,20 @@ TEST_CASE(test_load_ENGRDA) retrieveTREHandler(testName, "ENGRDA"); } -TEST_CASE(test_load_all_plugins) +TEST_CASE(test_load_all_TREs) { - for (const auto& tre : all_plugins()) + const nitf::TRE tre("ACCPOB"); + + for (const auto& tre : all_TREs()) { + // TREs are quite the same thing as an arbitrary "plug in;" the underlying + // infrastructure is all built on shared-libraries/DLLs, but details differ. + // + // As a result, we can't expect loadPlugin() will "just work" on a TRE name. + // Unfortunately, the behavior is different on Windows and Linux. :-( + #if _WIN32 + // Keep this around for now as it works ... but it's not necessarily correct. + // Mostly an excuse to exercise more code. try { nitf::PluginRegistry::loadPlugin(tre); @@ -97,6 +107,8 @@ TEST_CASE(test_load_all_plugins) { TEST_FAIL_MSG(ex.toString()); } + #endif // _WIN32 + TEST_ASSERT(nitf::PluginRegistry::treHandlerExists(tre)); } } @@ -107,5 +119,5 @@ TEST_MAIN( TEST_CHECK(test_load_PTPRAA); TEST_CHECK(test_load_ENGRDA); TEST_CHECK(test_retrieveTREHandler); - TEST_CHECK(test_load_all_plugins); + TEST_CHECK(test_load_all_TREs); ) \ No newline at end of file diff --git a/modules/c++/nitf/unittests/test_tre_create++.cpp b/modules/c++/nitf/unittests/test_tre_create++.cpp index 9ffe05000..bc3f884fc 100644 --- a/modules/c++/nitf/unittests/test_tre_create++.cpp +++ b/modules/c++/nitf/unittests/test_tre_create++.cpp @@ -7,8 +7,6 @@ TEST_CASE(test_tre_create_329) { - nitf::Test::setNitfPluginPath(); - // https://github.com/mdaus/nitro/issues/329 nitf::TRE tre("HISTOA", "HISTOA"); // allocates fields SYSTEM .. NEVENTS @@ -21,8 +19,6 @@ TEST_CASE(test_tre_create_329) TEST_CASE(test_tre_clone_329) { - nitf::Test::setNitfPluginPath(); - // https://github.com/mdaus/nitro/issues/329 const std::string rd = "begin1020030004ABCDEFend"; @@ -43,6 +39,8 @@ TEST_CASE(test_tre_clone_329) } TEST_MAIN( + nitf::Test::setNitfPluginPath(); + TEST_CHECK(test_tre_create_329); TEST_CHECK(test_tre_clone_329); ) diff --git a/modules/c++/nitf/unittests/test_tre_mods++.cpp b/modules/c++/nitf/unittests/test_tre_mods++.cpp index 8eb85006b..1c2b4a870 100644 --- a/modules/c++/nitf/unittests/test_tre_mods++.cpp +++ b/modules/c++/nitf/unittests/test_tre_mods++.cpp @@ -159,8 +159,6 @@ struct /*namespace*/ TREs TEST_CASE(setFields) { - nitf::Test::setNitfPluginPath(); - // create an ACFTA TRE nitf::TRE tre("ACFTA"); @@ -180,8 +178,6 @@ TEST_CASE(setFields) TEST_CASE(setBinaryFields) { - nitf::Test::setNitfPluginPath(); - nitf::TRE tre("RPFHDR"); const int value = 123; tre.setField("LOCSEC", value); @@ -193,8 +189,6 @@ TEST_CASE(setBinaryFields) TEST_CASE(cloneTRE) { - nitf::Test::setNitfPluginPath(); - nitf::TRE tre("JITCID"); tre.setField("FILCMT", "fyi"); @@ -208,8 +202,6 @@ TEST_CASE(cloneTRE) TEST_CASE(basicIteration) { - nitf::Test::setNitfPluginPath(); - nitf::TRE tre("ACCPOB"); // The entire TRE is one loop, and we haven't told it @@ -237,8 +229,6 @@ TEST_CASE(basicIteration) TEST_CASE(use_ENGRDA) { - nitf::Test::setNitfPluginPath(); - nitf::TRE engrda("ENGRDA", "ENGRDA"); engrda.setField("RESRC", "HSS"); @@ -263,8 +253,6 @@ TEST_CASE(use_ENGRDA) TEST_CASE(use_ENGRDA_typed_fields) { - nitf::Test::setNitfPluginPath(); - nitf::TRE engrda("ENGRDA", "ENGRDA"); nitf::TREField_BCS_A<20> RESRC(engrda, "RESRC"); @@ -297,8 +285,6 @@ TEST_CASE(use_ENGRDA_typed_fields) TEST_CASE(use_typed_ENGRDA) { - nitf::Test::setNitfPluginPath(); - TREs::ENGRDA engrda; // nitf::TRE engrda("ENGRDA", "ENGRDA"); engrda.RESRC = "HSS"; // engrda.setField("RESRC", "HSS"); @@ -347,8 +333,6 @@ TEST_CASE(use_typed_ENGRDA) TEST_CASE(use_CSEXRB_typed_fields) { - nitf::Test::setNitfPluginPath(); - nitf::TRE tre("CSEXRB", "CSEXRB"); constexpr auto length = 12; @@ -362,8 +346,6 @@ TEST_CASE(use_CSEXRB_typed_fields) TEST_CASE(populateWhileIterating) { - nitf::Test::setNitfPluginPath(); - nitf::TRE tre("ACCPOB"); size_t numFields = 0; for (auto it = tre.begin(); it != tre.end(); ++it) @@ -388,8 +370,6 @@ TEST_CASE(populateWhileIterating) TEST_CASE(overflowingNumericFields) { - nitf::Test::setNitfPluginPath(); - nitf::TRE tre("CSCRNA"); // This field has a length of 9, so check that it's properly @@ -418,6 +398,8 @@ TEST_CASE(overflowingNumericFields) } TEST_MAIN( + nitf::Test::setNitfPluginPath(); + TEST_CHECK(setFields); TEST_CHECK(setBinaryFields); TEST_CHECK(cloneTRE); diff --git a/modules/c++/nitf/unittests/test_tre_mods.cpp b/modules/c++/nitf/unittests/test_tre_mods.cpp index be2517963..5bee638c7 100644 --- a/modules/c++/nitf/unittests/test_tre_mods.cpp +++ b/modules/c++/nitf/unittests/test_tre_mods.cpp @@ -26,8 +26,6 @@ TEST_CASE(testNestedMod) { - nitf::Test::setNitfPluginPath(); - nitf_Error error; NITF_BOOL exists; nitf_TRE* tre = nitf_TRE_construct("ACCHZB", NULL, &error); @@ -61,8 +59,6 @@ TEST_CASE(testNestedMod) TEST_CASE(testIncompleteCondMod) { - nitf::Test::setNitfPluginPath(); - nitf_Error error; NITF_BOOL exists; nitf_TRE* tre = nitf_TRE_construct("ACCPOB", NULL, &error); @@ -89,8 +85,6 @@ TEST_CASE(testIncompleteCondMod) TEST_CASE(testClone) { - nitf::Test::setNitfPluginPath(); - NITF_BOOL exists; nitf_TRE* dolly; /* used for clone */ nitf_Field* clonedField = NULL; @@ -116,8 +110,6 @@ TEST_CASE(testClone) TEST_CASE(testBasicMod) { - nitf::Test::setNitfPluginPath(); - /* construct a tre */ NITF_BOOL exists; nitf_Error error; @@ -147,8 +139,6 @@ TEST_CASE(testBasicMod) TEST_CASE(testSize) { - nitf::Test::setNitfPluginPath(); - nitf_Error error; int treLength; nitf_TRE* tre = nitf_TRE_construct("AIMIDB", NULL, &error); @@ -163,8 +153,6 @@ TEST_CASE(testSize) TEST_CASE(iterateUnfilled) { - nitf::Test::setNitfPluginPath(); - nitf_Error error; nitf_TRECursor cursor; nitf_TRE* tre = nitf_TRE_construct("ACCPOB", NULL, &error); @@ -186,8 +174,6 @@ TEST_CASE(iterateUnfilled) TEST_CASE(populateThenIterate) { - nitf::Test::setNitfPluginPath(); - nitf_Error error; nitf_TRECursor cursor; nitf_TRE* tre = nitf_TRE_construct("ACCPOB", NULL, &error); @@ -214,8 +200,6 @@ TEST_CASE(populateThenIterate) TEST_CASE(populateWhileIterating) { - nitf::Test::setNitfPluginPath(); - nitf_Error error; nitf_TRECursor cursor; nitf_TRE* tre = nitf_TRE_construct("ACCPOB", NULL, &error); @@ -247,6 +231,8 @@ TEST_CASE(populateWhileIterating) } TEST_MAIN( + nitf::Test::setNitfPluginPath(); + TEST_CHECK(testClone); TEST_CHECK(testSize); TEST_CHECK(testBasicMod);